From a64e37a1d3990b9c2524d166119cb5564dc5d96c Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Tue, 12 Apr 2011 11:43:11 -0700 Subject: [PATCH] configure: Add option --enable-Werror to add -Werror to CFLAGS. -Werror is useful for development, but it screws up configure because it's impossible to guess what new warnings compilers will add in the future. This commit adds a new configure option to add CFLAGS after the configure checks are done. The use of AC_CONFIG_COMMANDS_PRE is based on Eric Blake's suggestion on the autoconf mailing list: "AC_CONFIG_COMMANDS_PRE probably fits the bill as the ideal macro to use for guaranteeing that you inject your shell code at the last possible moment." Requested-by: Andrew Evans --- acinclude.m4 | 11 +++++++++++ configure.ac | 1 + 2 files changed, 12 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4 index fa6f534de..69e61e0e9 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -14,6 +14,17 @@ # See the License for the specific language governing permissions and # limitations under the License. +dnl OVS_ENABLE_WERROR +AC_DEFUN([OVS_ENABLE_WERROR], + [AC_ARG_ENABLE( + [Werror], + [AC_HELP_STRING([--enable-Werror], [Add -Werror to CFLAGS])], + [], [enable_Werror=no]) + AC_CONFIG_COMMANDS_PRE( + [if test "X$enable_Werror" = Xyes; then + CFLAGS="$CFLAGS -Werror" + fi])]) + dnl OVS_CHECK_LINUX26 dnl dnl Configure linux kernel source tree diff --git a/configure.ac b/configure.ac index 5a2b5c0c4..5b5f47ed9 100644 --- a/configure.ac +++ b/configure.ac @@ -84,6 +84,7 @@ OVS_ENABLE_OPTION([-Wmissing-field-initializers]) OVS_ENABLE_OPTION([-Wno-override-init]) OVS_CONDITIONAL_CC_OPTION([-Wno-unused], [HAVE_WNO_UNUSED]) OVS_CONDITIONAL_CC_OPTION([-Wno-unused-parameter], [HAVE_WNO_UNUSED_PARAMETER]) +OVS_ENABLE_WERROR AC_ARG_VAR(KARCH, [Kernel Architecture String]) AC_SUBST(KARCH) -- 2.43.0