From f6af6c0e1cec12863d8fc747317c625ff2eef013 Mon Sep 17 00:00:00 2001 From: Ethan Jackson Date: Fri, 17 Aug 2012 18:47:43 -0700 Subject: [PATCH] bond: Deprecate stable bonds. The stable bond mode is an obsolete attempt to replicate the functionality contained in the bundle action. They are ugly and of questionable usefulness. This patch deprecates them and schedules their removal for February 2013. If there are concerns, please email dev@openvswitch.org. Signed-off-by: Ethan Jackson --- NEWS | 2 ++ lib/bond.c | 6 ++++++ vswitchd/vswitch.xml | 1 + 3 files changed, 9 insertions(+) diff --git a/NEWS b/NEWS index 54a711490..ac12b5df0 100644 --- a/NEWS +++ b/NEWS @@ -18,6 +18,8 @@ post-v1.8.0 are true, but because we do not know of any users for this feature it seems better on balance to remove it. (The ovs-pki-cgi program was not included in distribution packaging.) + - Stable bond mode is deprecated and will be removed no earlier than + February 2013. Please email dev@openvswitch.org with concerns. v1.8.0 - xx xxx xxxx diff --git a/lib/bond.c b/lib/bond.c index 77812edf7..25a0fa1a9 100644 --- a/lib/bond.c +++ b/lib/bond.c @@ -255,6 +255,12 @@ bond_reconfigure(struct bond *bond, const struct bond_settings *s) if (bond->balance != s->balance) { bond->balance = s->balance; revalidate = true; + + if (bond->balance == BM_STABLE) { + VLOG_WARN_ONCE("Stable bond mode is deprecated and may be removed" + " in February 2013. Please email" + " dev@openvswitch.org with concerns."); + } } if (bond->basis != s->basis) { diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index f7b9f0111..b71a30874 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -840,6 +840,7 @@
stable
+

Deprecated and slated for removal in February 2013.

Attempts to always assign a given flow to the same slave consistently. In an effort to maintain stability, no load balancing is done. Uses a similar hashing strategy to -- 2.43.0