From d512449f642dd176ec549731cd17664372894744 Mon Sep 17 00:00:00 2001 From: Thierry Parmentelat Date: Mon, 4 Mar 2013 16:54:32 +0100 Subject: [PATCH] expose javascript data for a plugin only when it has a 'query' field --- engine/plugin.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/engine/plugin.py b/engine/plugin.py index 3ae318eb..58ac4db3 100644 --- a/engine/plugin.py +++ b/engine/plugin.py @@ -112,10 +112,13 @@ class Plugin: env.update(self.__dict__) result = render_to_string ('plugin.html',env) - env ['settings_json' ] = self.settings_json() - # compute plugin-specific initialization - js_init = render_to_string ( 'plugin-setenv.js', env ) - self.add_js_chunks (request, js_init) + # as a first approximation we're only concerned with plugins that are associated with a query + # other simpler plugins that only deal with layout do not need this + if 'query' in self.__dict__: + env ['settings_json' ] = self.settings_json() + # compute plugin-specific initialization + js_init = render_to_string ( 'plugin-setenv.js', env ) + self.add_js_chunks (request, js_init) # interpret the result of requirements () self.handle_requirements (request) -- 2.43.0