1 /* Copyright (c) 2011, 2012, 2013 Nicira, Inc.
3 * Licensed under the Apache License, Version 2.0 (the "License");
4 * you may not use this file except in compliance with the License.
5 * You may obtain a copy of the License at:
7 * http://www.apache.org/licenses/LICENSE-2.0
9 * Unless required by applicable law or agreed to in writing, software
10 * distributed under the License is distributed on an "AS IS" BASIS,
11 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 * See the License for the specific language governing permissions and
13 * limitations under the License.
21 #include "dynamic-string.h"
26 #include "poll-loop.h"
33 VLOG_DEFINE_THIS_MODULE(lacp);
35 /* Masks for lacp_info state member. */
36 #define LACP_STATE_ACT 0x01 /* Activity. Active or passive? */
37 #define LACP_STATE_TIME 0x02 /* Timeout. Short or long timeout? */
38 #define LACP_STATE_AGG 0x04 /* Aggregation. Is the link is bondable? */
39 #define LACP_STATE_SYNC 0x08 /* Synchronization. Is the link in up to date? */
40 #define LACP_STATE_COL 0x10 /* Collecting. Is the link receiving frames? */
41 #define LACP_STATE_DIST 0x20 /* Distributing. Is the link sending frames? */
42 #define LACP_STATE_DEF 0x40 /* Defaulted. Using default partner info? */
43 #define LACP_STATE_EXP 0x80 /* Expired. Using expired partner info? */
45 #define LACP_FAST_TIME_TX 1000 /* Fast transmission rate. */
46 #define LACP_SLOW_TIME_TX 30000 /* Slow transmission rate. */
47 #define LACP_RX_MULTIPLIER 3 /* Multiply by TX rate to get RX rate. */
49 #define LACP_INFO_LEN 15
52 ovs_be16 sys_priority; /* System priority. */
53 uint8_t sys_id[ETH_ADDR_LEN]; /* System ID. */
54 ovs_be16 key; /* Operational key. */
55 ovs_be16 port_priority; /* Port priority. */
56 ovs_be16 port_id; /* Port ID. */
57 uint8_t state; /* State mask. See LACP_STATE macros. */
59 BUILD_ASSERT_DECL(LACP_INFO_LEN == sizeof(struct lacp_info));
61 #define LACP_PDU_LEN 110
64 uint8_t subtype; /* Always 1. */
65 uint8_t version; /* Always 1. */
67 uint8_t actor_type; /* Always 1. */
68 uint8_t actor_len; /* Always 20. */
69 struct lacp_info actor; /* LACP actor information. */
70 uint8_t z1[3]; /* Reserved. Always 0. */
72 uint8_t partner_type; /* Always 2. */
73 uint8_t partner_len; /* Always 20. */
74 struct lacp_info partner; /* LACP partner information. */
75 uint8_t z2[3]; /* Reserved. Always 0. */
77 uint8_t collector_type; /* Always 3. */
78 uint8_t collector_len; /* Always 16. */
79 ovs_be16 collector_delay; /* Maximum collector delay. Set to UINT16_MAX. */
80 uint8_t z3[64]; /* Combination of several fields. Always 0. */
82 BUILD_ASSERT_DECL(LACP_PDU_LEN == sizeof(struct lacp_pdu));
87 LACP_CURRENT, /* Current State. Partner up to date. */
88 LACP_EXPIRED, /* Expired State. Partner out of date. */
89 LACP_DEFAULTED, /* Defaulted State. No partner. */
93 struct list node; /* Node in all_lacps list. */
94 char *name; /* Name of this lacp object. */
95 uint8_t sys_id[ETH_ADDR_LEN]; /* System ID. */
96 uint16_t sys_priority; /* System Priority. */
97 bool active; /* Active or Passive. */
99 struct hmap slaves; /* Slaves this LACP object controls. */
100 struct slave *key_slave; /* Slave whose ID will be the aggregation key. */
102 bool fast; /* True if using fast probe interval. */
103 bool negotiated; /* True if LACP negotiations were successful. */
104 bool update; /* True if lacp_update() needs to be called. */
105 bool fallback_ab; /* True if fallback to active-backup on LACP failure. */
111 void *aux; /* Handle used to identify this slave. */
112 struct hmap_node node; /* Node in master's slaves map. */
114 struct lacp *lacp; /* LACP object containing this slave. */
115 uint16_t port_id; /* Port ID. */
116 uint16_t port_priority; /* Port Priority. */
117 uint16_t key; /* Aggregation Key. 0 if default. */
118 char *name; /* Name of this slave. */
120 enum slave_status status; /* Slave status. */
121 bool attached; /* Attached. Traffic may flow. */
122 struct lacp_info partner; /* Partner information. */
123 struct lacp_info ntt_actor; /* Used to decide if we Need To Transmit. */
124 struct timer tx; /* Next message transmission timer. */
125 struct timer rx; /* Expected message receive timer. */
128 static struct ovs_mutex mutex;
129 static struct list all_lacps__ = LIST_INITIALIZER(&all_lacps__);
130 static struct list *const all_lacps OVS_GUARDED_BY(mutex) = &all_lacps__;
132 static void lacp_update_attached(struct lacp *) OVS_REQUIRES(mutex);
134 static void slave_destroy(struct slave *) OVS_REQUIRES(mutex);
135 static void slave_set_defaulted(struct slave *) OVS_REQUIRES(mutex);
136 static void slave_set_expired(struct slave *) OVS_REQUIRES(mutex);
137 static void slave_get_actor(struct slave *, struct lacp_info *actor)
139 static void slave_get_priority(struct slave *, struct lacp_info *priority)
141 static bool slave_may_tx(const struct slave *)
143 static struct slave *slave_lookup(const struct lacp *, const void *slave)
145 static bool info_tx_equal(struct lacp_info *, struct lacp_info *)
148 static unixctl_cb_func lacp_unixctl_show;
150 /* Populates 'pdu' with a LACP PDU comprised of 'actor' and 'partner'. */
152 compose_lacp_pdu(const struct lacp_info *actor,
153 const struct lacp_info *partner, struct lacp_pdu *pdu)
155 memset(pdu, 0, sizeof *pdu);
164 pdu->partner_type = 2;
165 pdu->partner_len = 20;
166 pdu->partner = *partner;
168 pdu->collector_type = 3;
169 pdu->collector_len = 16;
170 pdu->collector_delay = htons(0);
173 /* Parses 'b' which represents a packet containing a LACP PDU. This function
174 * returns NULL if 'b' is malformed, or does not represent a LACP PDU format
175 * supported by OVS. Otherwise, it returns a pointer to the lacp_pdu contained
177 static const struct lacp_pdu *
178 parse_lacp_packet(const struct ofpbuf *b)
180 const struct lacp_pdu *pdu;
182 pdu = ofpbuf_at(b, (uint8_t *)b->l3 - (uint8_t *)b->data, LACP_PDU_LEN);
184 if (pdu && pdu->subtype == 1
185 && pdu->actor_type == 1 && pdu->actor_len == 20
186 && pdu->partner_type == 2 && pdu->partner_len == 20) {
193 /* LACP Protocol Implementation. */
195 /* Initializes the lacp module. */
199 unixctl_command_register("lacp/show", "[port]", 0, 1,
200 lacp_unixctl_show, NULL);
203 /* Creates a LACP object. */
205 lacp_create(void) OVS_EXCLUDED(mutex)
207 static struct ovsthread_once once = OVSTHREAD_ONCE_INITIALIZER;
210 if (ovsthread_once_start(&once)) {
211 ovs_mutex_init_recursive(&mutex);
212 ovsthread_once_done(&once);
215 lacp = xzalloc(sizeof *lacp);
216 hmap_init(&lacp->slaves);
217 atomic_init(&lacp->ref_cnt, 1);
219 ovs_mutex_lock(&mutex);
220 list_push_back(all_lacps, &lacp->node);
221 ovs_mutex_unlock(&mutex);
226 lacp_ref(const struct lacp *lacp_)
228 struct lacp *lacp = CONST_CAST(struct lacp *, lacp_);
231 atomic_add(&lacp->ref_cnt, 1, &orig);
232 ovs_assert(orig > 0);
237 /* Destroys 'lacp' and its slaves. Does nothing if 'lacp' is NULL. */
239 lacp_unref(struct lacp *lacp) OVS_EXCLUDED(mutex)
247 atomic_sub(&lacp->ref_cnt, 1, &orig);
248 ovs_assert(orig > 0);
250 struct slave *slave, *next;
252 ovs_mutex_lock(&mutex);
253 HMAP_FOR_EACH_SAFE (slave, next, node, &lacp->slaves) {
254 slave_destroy(slave);
257 hmap_destroy(&lacp->slaves);
258 list_remove(&lacp->node);
261 ovs_mutex_unlock(&mutex);
265 /* Configures 'lacp' with settings from 's'. */
267 lacp_configure(struct lacp *lacp, const struct lacp_settings *s)
270 ovs_assert(!eth_addr_is_zero(s->id));
272 ovs_mutex_lock(&mutex);
273 if (!lacp->name || strcmp(s->name, lacp->name)) {
275 lacp->name = xstrdup(s->name);
278 if (!eth_addr_equals(lacp->sys_id, s->id)
279 || lacp->sys_priority != s->priority) {
280 memcpy(lacp->sys_id, s->id, ETH_ADDR_LEN);
281 lacp->sys_priority = s->priority;
285 lacp->active = s->active;
286 lacp->fast = s->fast;
288 if (lacp->fallback_ab != s->fallback_ab_cfg) {
289 lacp->fallback_ab = s->fallback_ab_cfg;
293 ovs_mutex_unlock(&mutex);
296 /* Returns true if 'lacp' is configured in active mode, false if 'lacp' is
297 * configured for passive mode. */
299 lacp_is_active(const struct lacp *lacp) OVS_EXCLUDED(mutex)
302 ovs_mutex_lock(&mutex);
304 ovs_mutex_unlock(&mutex);
308 /* Processes 'packet' which was received on 'slave_'. This function should be
309 * called on all packets received on 'slave_' with Ethernet Type ETH_TYPE_LACP.
312 lacp_process_packet(struct lacp *lacp, const void *slave_,
313 const struct ofpbuf *packet)
316 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
317 const struct lacp_pdu *pdu;
318 long long int tx_rate;
321 ovs_mutex_lock(&mutex);
322 slave = slave_lookup(lacp, slave_);
327 pdu = parse_lacp_packet(packet);
329 VLOG_WARN_RL(&rl, "%s: received an unparsable LACP PDU.", lacp->name);
333 slave->status = LACP_CURRENT;
334 tx_rate = lacp->fast ? LACP_FAST_TIME_TX : LACP_SLOW_TIME_TX;
335 timer_set_duration(&slave->rx, LACP_RX_MULTIPLIER * tx_rate);
337 slave->ntt_actor = pdu->partner;
339 /* Update our information about our partner if it's out of date. This may
340 * cause priorities to change so re-calculate attached status of all
342 if (memcmp(&slave->partner, &pdu->actor, sizeof pdu->actor)) {
344 slave->partner = pdu->actor;
348 ovs_mutex_unlock(&mutex);
351 /* Returns the lacp_status of the given 'lacp' object (which may be NULL). */
353 lacp_status(const struct lacp *lacp) OVS_EXCLUDED(mutex)
355 enum lacp_status ret;
357 ovs_mutex_lock(&mutex);
360 } else if (lacp->negotiated) {
361 ret = LACP_NEGOTIATED;
363 ret = LACP_CONFIGURED;
365 ovs_mutex_unlock(&mutex);
369 /* Registers 'slave_' as subordinate to 'lacp'. This should be called at least
370 * once per slave in a LACP managed bond. Should also be called whenever a
371 * slave's settings change. */
373 lacp_slave_register(struct lacp *lacp, void *slave_,
374 const struct lacp_slave_settings *s)
379 ovs_mutex_lock(&mutex);
380 slave = slave_lookup(lacp, slave_);
382 slave = xzalloc(sizeof *slave);
385 hmap_insert(&lacp->slaves, &slave->node, hash_pointer(slave_, 0));
386 slave_set_defaulted(slave);
388 if (!lacp->key_slave) {
389 lacp->key_slave = slave;
393 if (!slave->name || strcmp(s->name, slave->name)) {
395 slave->name = xstrdup(s->name);
398 if (slave->port_id != s->id
399 || slave->port_priority != s->priority
400 || slave->key != s->key) {
401 slave->port_id = s->id;
402 slave->port_priority = s->priority;
407 if (lacp->active || lacp->negotiated) {
408 slave_set_expired(slave);
411 ovs_mutex_unlock(&mutex);
414 /* Unregisters 'slave_' with 'lacp'. */
416 lacp_slave_unregister(struct lacp *lacp, const void *slave_)
421 ovs_mutex_lock(&mutex);
422 slave = slave_lookup(lacp, slave_);
424 slave_destroy(slave);
427 ovs_mutex_unlock(&mutex);
430 /* This function should be called whenever the carrier status of 'slave_' has
431 * changed. If 'lacp' is null, this function has no effect.*/
433 lacp_slave_carrier_changed(const struct lacp *lacp, const void *slave_)
441 ovs_mutex_lock(&mutex);
442 slave = slave_lookup(lacp, slave_);
447 if (slave->status == LACP_CURRENT || slave->lacp->active) {
448 slave_set_expired(slave);
452 ovs_mutex_unlock(&mutex);
456 slave_may_enable__(struct slave *slave) OVS_REQUIRES(mutex)
458 /* The slave may be enabled if it's attached to an aggregator and its
459 * partner is synchronized.*/
460 return slave->attached && (slave->partner.state & LACP_STATE_SYNC
461 || (slave->lacp && slave->lacp->fallback_ab
462 && slave->status == LACP_DEFAULTED));
465 /* This function should be called before enabling 'slave_' to send or receive
466 * traffic. If it returns false, 'slave_' should not enabled. As a
467 * convenience, returns true if 'lacp' is NULL. */
469 lacp_slave_may_enable(const struct lacp *lacp, const void *slave_)
476 ovs_mutex_lock(&mutex);
477 slave = slave_lookup(lacp, slave_);
478 ret = slave ? slave_may_enable__(slave) : false;
479 ovs_mutex_unlock(&mutex);
486 /* Returns true if partner information on 'slave_' is up to date. 'slave_'
487 * not being current, generally indicates a connectivity problem, or a
488 * misconfigured (or broken) partner. */
490 lacp_slave_is_current(const struct lacp *lacp, const void *slave_)
496 ovs_mutex_lock(&mutex);
497 slave = slave_lookup(lacp, slave_);
498 ret = slave ? slave->status != LACP_DEFAULTED : false;
499 ovs_mutex_unlock(&mutex);
503 /* This function should be called periodically to update 'lacp'. */
505 lacp_run(struct lacp *lacp, lacp_send_pdu *send_pdu) OVS_EXCLUDED(mutex)
509 ovs_mutex_lock(&mutex);
510 HMAP_FOR_EACH (slave, node, &lacp->slaves) {
511 if (timer_expired(&slave->rx)) {
512 if (slave->status == LACP_CURRENT) {
513 slave_set_expired(slave);
514 } else if (slave->status == LACP_EXPIRED) {
515 slave_set_defaulted(slave);
521 lacp_update_attached(lacp);
524 HMAP_FOR_EACH (slave, node, &lacp->slaves) {
525 struct lacp_info actor;
527 if (!slave_may_tx(slave)) {
531 slave_get_actor(slave, &actor);
533 if (timer_expired(&slave->tx)
534 || !info_tx_equal(&actor, &slave->ntt_actor)) {
535 long long int duration;
538 slave->ntt_actor = actor;
539 compose_lacp_pdu(&actor, &slave->partner, &pdu);
540 send_pdu(slave->aux, &pdu, sizeof pdu);
542 duration = (slave->partner.state & LACP_STATE_TIME
544 : LACP_SLOW_TIME_TX);
546 timer_set_duration(&slave->tx, duration);
549 ovs_mutex_unlock(&mutex);
552 /* Causes poll_block() to wake up when lacp_run() needs to be called again. */
554 lacp_wait(struct lacp *lacp) OVS_EXCLUDED(mutex)
558 ovs_mutex_lock(&mutex);
559 HMAP_FOR_EACH (slave, node, &lacp->slaves) {
560 if (slave_may_tx(slave)) {
561 timer_wait(&slave->tx);
564 if (slave->status != LACP_DEFAULTED) {
565 timer_wait(&slave->rx);
568 ovs_mutex_unlock(&mutex);
571 /* Static Helpers. */
573 /* Updates the attached status of all slaves controlled by 'lacp' and sets its
574 * negotiated parameter to true if any slaves are attachable. */
576 lacp_update_attached(struct lacp *lacp) OVS_REQUIRES(mutex)
578 struct slave *lead, *slave;
579 struct lacp_info lead_pri;
580 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 10);
582 lacp->update = false;
585 HMAP_FOR_EACH (slave, node, &lacp->slaves) {
586 struct lacp_info pri;
588 slave->attached = false;
590 /* XXX: In the future allow users to configure the expected system ID.
591 * For now just special case loopback. */
592 if (eth_addr_equals(slave->partner.sys_id, slave->lacp->sys_id)) {
593 VLOG_WARN_RL(&rl, "slave %s: Loopback detected. Slave is "
594 "connected to its own bond", slave->name);
598 if (slave->status == LACP_DEFAULTED) {
599 if (lacp->fallback_ab) {
600 slave->attached = true;
605 slave->attached = true;
606 slave_get_priority(slave, &pri);
608 if (!lead || memcmp(&pri, &lead_pri, sizeof pri) < 0) {
614 lacp->negotiated = lead != NULL;
617 HMAP_FOR_EACH (slave, node, &lacp->slaves) {
618 if ((lacp->fallback_ab && slave->status == LACP_DEFAULTED)
619 || lead->partner.key != slave->partner.key
620 || !eth_addr_equals(lead->partner.sys_id,
621 slave->partner.sys_id)) {
622 slave->attached = false;
629 slave_destroy(struct slave *slave) OVS_REQUIRES(mutex)
632 struct lacp *lacp = slave->lacp;
635 hmap_remove(&lacp->slaves, &slave->node);
637 if (lacp->key_slave == slave) {
638 struct hmap_node *slave_node = hmap_first(&lacp->slaves);
641 lacp->key_slave = CONTAINER_OF(slave_node, struct slave, node);
643 lacp->key_slave = NULL;
653 slave_set_defaulted(struct slave *slave) OVS_REQUIRES(mutex)
655 memset(&slave->partner, 0, sizeof slave->partner);
657 slave->lacp->update = true;
658 slave->status = LACP_DEFAULTED;
662 slave_set_expired(struct slave *slave) OVS_REQUIRES(mutex)
664 slave->status = LACP_EXPIRED;
665 slave->partner.state |= LACP_STATE_TIME;
666 slave->partner.state &= ~LACP_STATE_SYNC;
668 timer_set_duration(&slave->rx, LACP_RX_MULTIPLIER * LACP_FAST_TIME_TX);
672 slave_get_actor(struct slave *slave, struct lacp_info *actor)
675 struct lacp *lacp = slave->lacp;
680 state |= LACP_STATE_ACT;
684 state |= LACP_STATE_TIME;
687 if (slave->attached) {
688 state |= LACP_STATE_SYNC;
691 if (slave->status == LACP_DEFAULTED) {
692 state |= LACP_STATE_DEF;
695 if (slave->status == LACP_EXPIRED) {
696 state |= LACP_STATE_EXP;
699 if (hmap_count(&lacp->slaves) > 1) {
700 state |= LACP_STATE_AGG;
703 if (slave->attached || !lacp->negotiated) {
704 state |= LACP_STATE_COL | LACP_STATE_DIST;
707 key = lacp->key_slave->key;
709 key = lacp->key_slave->port_id;
712 actor->state = state;
713 actor->key = htons(key);
714 actor->port_priority = htons(slave->port_priority);
715 actor->port_id = htons(slave->port_id);
716 actor->sys_priority = htons(lacp->sys_priority);
717 memcpy(&actor->sys_id, lacp->sys_id, ETH_ADDR_LEN);
720 /* Given 'slave', populates 'priority' with data representing its LACP link
721 * priority. If two priority objects populated by this function are compared
722 * using memcmp, the higher priority link will be less than the lower priority
725 slave_get_priority(struct slave *slave, struct lacp_info *priority)
728 uint16_t partner_priority, actor_priority;
730 /* Choose the lacp_info of the higher priority system by comparing their
731 * system priorities and mac addresses. */
732 actor_priority = slave->lacp->sys_priority;
733 partner_priority = ntohs(slave->partner.sys_priority);
734 if (actor_priority < partner_priority) {
735 slave_get_actor(slave, priority);
736 } else if (partner_priority < actor_priority) {
737 *priority = slave->partner;
738 } else if (eth_addr_compare_3way(slave->lacp->sys_id,
739 slave->partner.sys_id) < 0) {
740 slave_get_actor(slave, priority);
742 *priority = slave->partner;
745 /* Key and state are not used in priority comparisons. */
751 slave_may_tx(const struct slave *slave) OVS_REQUIRES(mutex)
753 return slave->lacp->active || slave->status != LACP_DEFAULTED;
756 static struct slave *
757 slave_lookup(const struct lacp *lacp, const void *slave_) OVS_REQUIRES(mutex)
761 HMAP_FOR_EACH_IN_BUCKET (slave, node, hash_pointer(slave_, 0),
763 if (slave->aux == slave_) {
771 /* Two lacp_info structures are tx_equal if and only if they do not differ in
772 * ways which would require a lacp_pdu transmission. */
774 info_tx_equal(struct lacp_info *a, struct lacp_info *b)
777 /* LACP specification dictates that we transmit whenever the actor and
778 * remote_actor differ in the following fields: Port, Port Priority,
779 * System, System Priority, Aggregation Key, Activity State, Timeout State,
780 * Sync State, and Aggregation State. The state flags are most likely to
781 * change so are checked first. */
782 return !((a->state ^ b->state) & (LACP_STATE_ACT
786 && a->port_id == b->port_id
787 && a->port_priority == b->port_priority
789 && a->sys_priority == b->sys_priority
790 && eth_addr_equals(a->sys_id, b->sys_id);
794 lacp_find(const char *name) OVS_REQUIRES(mutex)
798 LIST_FOR_EACH (lacp, node, all_lacps) {
799 if (!strcmp(lacp->name, name)) {
808 ds_put_lacp_state(struct ds *ds, uint8_t state)
810 if (state & LACP_STATE_ACT) {
811 ds_put_cstr(ds, " activity");
814 if (state & LACP_STATE_TIME) {
815 ds_put_cstr(ds, " timeout");
818 if (state & LACP_STATE_AGG) {
819 ds_put_cstr(ds, " aggregation");
822 if (state & LACP_STATE_SYNC) {
823 ds_put_cstr(ds, " synchronized");
826 if (state & LACP_STATE_COL) {
827 ds_put_cstr(ds, " collecting");
830 if (state & LACP_STATE_DIST) {
831 ds_put_cstr(ds, " distributing");
834 if (state & LACP_STATE_DEF) {
835 ds_put_cstr(ds, " defaulted");
838 if (state & LACP_STATE_EXP) {
839 ds_put_cstr(ds, " expired");
844 lacp_print_details(struct ds *ds, struct lacp *lacp) OVS_REQUIRES(mutex)
846 struct shash slave_shash = SHASH_INITIALIZER(&slave_shash);
847 const struct shash_node **sorted_slaves = NULL;
852 ds_put_format(ds, "---- %s ----\n", lacp->name);
853 ds_put_format(ds, "\tstatus: %s", lacp->active ? "active" : "passive");
854 if (lacp->negotiated) {
855 ds_put_cstr(ds, " negotiated");
857 ds_put_cstr(ds, "\n");
859 ds_put_format(ds, "\tsys_id: " ETH_ADDR_FMT "\n", ETH_ADDR_ARGS(lacp->sys_id));
860 ds_put_format(ds, "\tsys_priority: %u\n", lacp->sys_priority);
861 ds_put_cstr(ds, "\taggregation key: ");
862 if (lacp->key_slave) {
863 ds_put_format(ds, "%u", lacp->key_slave->key
864 ? lacp->key_slave->key
865 : lacp->key_slave->port_id);
867 ds_put_cstr(ds, "none");
869 ds_put_cstr(ds, "\n");
871 ds_put_cstr(ds, "\tlacp_time: ");
873 ds_put_cstr(ds, "fast\n");
875 ds_put_cstr(ds, "slow\n");
878 HMAP_FOR_EACH (slave, node, &lacp->slaves) {
879 shash_add(&slave_shash, slave->name, slave);
881 sorted_slaves = shash_sort(&slave_shash);
883 for (i = 0; i < shash_count(&slave_shash); i++) {
885 struct lacp_info actor;
887 slave = sorted_slaves[i]->data;
888 slave_get_actor(slave, &actor);
889 switch (slave->status) {
897 status = "defaulted";
903 ds_put_format(ds, "\nslave: %s: %s %s\n", slave->name, status,
904 slave->attached ? "attached" : "detached");
905 ds_put_format(ds, "\tport_id: %u\n", slave->port_id);
906 ds_put_format(ds, "\tport_priority: %u\n", slave->port_priority);
907 ds_put_format(ds, "\tmay_enable: %s\n", (slave_may_enable__(slave)
908 ? "true" : "false"));
910 ds_put_format(ds, "\n\tactor sys_id: " ETH_ADDR_FMT "\n",
911 ETH_ADDR_ARGS(actor.sys_id));
912 ds_put_format(ds, "\tactor sys_priority: %u\n",
913 ntohs(actor.sys_priority));
914 ds_put_format(ds, "\tactor port_id: %u\n",
915 ntohs(actor.port_id));
916 ds_put_format(ds, "\tactor port_priority: %u\n",
917 ntohs(actor.port_priority));
918 ds_put_format(ds, "\tactor key: %u\n",
920 ds_put_cstr(ds, "\tactor state:");
921 ds_put_lacp_state(ds, actor.state);
922 ds_put_cstr(ds, "\n\n");
924 ds_put_format(ds, "\tpartner sys_id: " ETH_ADDR_FMT "\n",
925 ETH_ADDR_ARGS(slave->partner.sys_id));
926 ds_put_format(ds, "\tpartner sys_priority: %u\n",
927 ntohs(slave->partner.sys_priority));
928 ds_put_format(ds, "\tpartner port_id: %u\n",
929 ntohs(slave->partner.port_id));
930 ds_put_format(ds, "\tpartner port_priority: %u\n",
931 ntohs(slave->partner.port_priority));
932 ds_put_format(ds, "\tpartner key: %u\n",
933 ntohs(slave->partner.key));
934 ds_put_cstr(ds, "\tpartner state:");
935 ds_put_lacp_state(ds, slave->partner.state);
936 ds_put_cstr(ds, "\n");
939 shash_destroy(&slave_shash);
944 lacp_unixctl_show(struct unixctl_conn *conn, int argc, const char *argv[],
945 void *aux OVS_UNUSED) OVS_EXCLUDED(mutex)
947 struct ds ds = DS_EMPTY_INITIALIZER;
950 ovs_mutex_lock(&mutex);
952 lacp = lacp_find(argv[1]);
954 unixctl_command_reply_error(conn, "no such lacp object");
957 lacp_print_details(&ds, lacp);
959 LIST_FOR_EACH (lacp, node, all_lacps) {
960 lacp_print_details(&ds, lacp);
964 unixctl_command_reply(conn, ds_cstr(&ds));
968 ovs_mutex_unlock(&mutex);