1 /* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014 Nicira, Inc.
3 * Licensed under the Apache License, Version 2.0 (the "License");
4 * you may not use this file except in compliance with the License.
5 * You may obtain a copy of the License at:
7 * http://www.apache.org/licenses/LICENSE-2.0
9 * Unless required by applicable law or agreed to in writing, software
10 * distributed under the License is distributed on an "AS IS" BASIS,
11 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 * See the License for the specific language governing permissions and
13 * limitations under the License. */
16 #include "ofproto-dpif-upcall.h"
25 #include "dynamic-string.h"
26 #include "fail-open.h"
27 #include "guarded-list.h"
32 #include "ofproto-dpif-ipfix.h"
33 #include "ofproto-dpif-sflow.h"
34 #include "ofproto-dpif-xlate.h"
36 #include "poll-loop.h"
41 #define MAX_QUEUE_LENGTH 512
42 #define FLOW_MISS_MAX_BATCH 50
43 #define REVALIDATE_MAX_BATCH 50
46 VLOG_DEFINE_THIS_MODULE(ofproto_dpif_upcall);
48 COVERAGE_DEFINE(upcall_queue_overflow);
50 /* A thread that processes each upcall handed to it by the dispatcher thread,
51 * forwards the upcall's packet, and possibly sets up a kernel flow as a
54 struct udpif *udpif; /* Parent udpif. */
55 pthread_t thread; /* Thread ID. */
56 char *name; /* Thread name. */
58 struct ovs_mutex mutex; /* Mutex guarding the following. */
60 /* Atomic queue of unprocessed upcalls. */
61 struct list upcalls OVS_GUARDED;
62 size_t n_upcalls OVS_GUARDED;
64 bool need_signal; /* Only changed by the dispatcher. */
66 pthread_cond_t wake_cond; /* Wakes 'thread' while holding
70 /* A thread that processes each kernel flow handed to it by the flow_dumper
71 * thread, updates OpenFlow statistics, and updates or removes the kernel flow
74 struct udpif *udpif; /* Parent udpif. */
75 char *name; /* Thread name. */
77 pthread_t thread; /* Thread ID. */
78 struct hmap ukeys; /* Datapath flow keys. */
82 struct ovs_mutex mutex; /* Mutex guarding the following. */
83 pthread_cond_t wake_cond;
84 struct list udumps OVS_GUARDED; /* Unprocessed udumps. */
85 size_t n_udumps OVS_GUARDED; /* Number of unprocessed udumps. */
88 /* An upcall handler for ofproto_dpif.
90 * udpif has two logically separate pieces:
92 * - A "dispatcher" thread that reads upcalls from the kernel and dispatches
93 * them to one of several "handler" threads (see struct handler).
95 * - A "flow_dumper" thread that reads the kernel flow table and dispatches
96 * flows to one of several "revalidator" threads (see struct
99 struct list list_node; /* In all_udpifs list. */
101 struct dpif *dpif; /* Datapath handle. */
102 struct dpif_backer *backer; /* Opaque dpif_backer pointer. */
104 uint32_t secret; /* Random seed for upcall hash. */
106 pthread_t dispatcher; /* Dispatcher thread ID. */
107 pthread_t flow_dumper; /* Flow dumper thread ID. */
109 struct handler *handlers; /* Upcall handlers. */
112 struct revalidator *revalidators; /* Flow revalidators. */
113 size_t n_revalidators;
115 uint64_t last_reval_seq; /* 'reval_seq' at last revalidation. */
116 struct seq *reval_seq; /* Incremented to force revalidation. */
118 struct seq *dump_seq; /* Increments each dump iteration. */
120 struct latch exit_latch; /* Tells child threads to exit. */
122 long long int dump_duration; /* Duration of the last flow dump. */
124 /* Datapath flow statistics. */
125 unsigned int max_n_flows;
126 unsigned int avg_n_flows;
128 /* Following fields are accessed and modified by different threads. */
129 atomic_uint flow_limit; /* Datapath flow hard limit. */
131 /* n_flows_mutex prevents multiple threads updating these concurrently. */
132 atomic_uint64_t n_flows; /* Number of flows in the datapath. */
133 atomic_llong n_flows_timestamp; /* Last time n_flows was updated. */
134 struct ovs_mutex n_flows_mutex;
138 BAD_UPCALL, /* Some kind of bug somewhere. */
139 MISS_UPCALL, /* A flow miss. */
140 SFLOW_UPCALL, /* sFlow sample. */
141 FLOW_SAMPLE_UPCALL, /* Per-flow sampling. */
142 IPFIX_UPCALL /* Per-bridge sampling. */
146 struct list list_node; /* For queuing upcalls. */
147 struct flow_miss *flow_miss; /* This upcall's flow_miss. */
149 /* Raw upcall plus data for keeping track of the memory backing it. */
150 struct dpif_upcall dpif_upcall; /* As returned by dpif_recv() */
151 struct ofpbuf upcall_buf; /* Owns some data in 'dpif_upcall'. */
152 uint64_t upcall_stub[512 / 8]; /* Buffer to reduce need for malloc(). */
155 /* 'udpif_key's are responsible for tracking the little bit of state udpif
156 * needs to do flow expiration which can't be pulled directly from the
157 * datapath. They are owned, created by, maintained, and destroyed by a single
158 * revalidator making them easy to efficiently handle with multiple threads. */
160 struct hmap_node hmap_node; /* In parent revalidator 'ukeys' map. */
162 struct nlattr *key; /* Datapath flow key. */
163 size_t key_len; /* Length of 'key'. */
165 struct dpif_flow_stats stats; /* Stats at most recent flow dump. */
166 long long int created; /* Estimation of creation time. */
168 bool mark; /* Used by mark and sweep GC algorithm. */
170 struct odputil_keybuf key_buf; /* Memory for 'key'. */
173 /* 'udpif_flow_dump's hold the state associated with one iteration in a flow
174 * dump operation. This is created by the flow_dumper thread and handed to the
175 * appropriate revalidator thread to be processed. */
176 struct udpif_flow_dump {
177 struct list list_node;
179 struct nlattr *key; /* Datapath flow key. */
180 size_t key_len; /* Length of 'key'. */
181 uint32_t key_hash; /* Hash of 'key'. */
183 struct odputil_keybuf mask_buf;
184 struct nlattr *mask; /* Datapath mask for 'key'. */
185 size_t mask_len; /* Length of 'mask'. */
187 struct dpif_flow_stats stats; /* Stats pulled from the datapath. */
189 bool need_revalidate; /* Key needs revalidation? */
191 struct odputil_keybuf key_buf;
194 /* Flow miss batching.
196 * Some dpifs implement operations faster when you hand them off in a batch.
197 * To allow batching, "struct flow_miss" queues the dpif-related work needed
198 * for a given flow. Each "struct flow_miss" corresponds to sending one or
199 * more packets, plus possibly installing the flow in the dpif. */
201 struct hmap_node hmap_node;
202 struct ofproto_dpif *ofproto;
205 const struct nlattr *key;
207 enum dpif_upcall_type upcall_type;
208 struct dpif_flow_stats stats;
209 odp_port_t odp_in_port;
211 uint64_t slow_path_buf[128 / 8];
212 struct odputil_keybuf mask_buf;
214 struct xlate_out xout;
219 static void upcall_destroy(struct upcall *);
221 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
222 static struct list all_udpifs = LIST_INITIALIZER(&all_udpifs);
224 static void recv_upcalls(struct udpif *);
225 static void handle_upcalls(struct handler *handler, struct list *upcalls);
226 static void *udpif_flow_dumper(void *);
227 static void *udpif_dispatcher(void *);
228 static void *udpif_upcall_handler(void *);
229 static void *udpif_revalidator(void *);
230 static uint64_t udpif_get_n_flows(struct udpif *);
231 static void revalidate_udumps(struct revalidator *, struct list *udumps);
232 static void revalidator_sweep(struct revalidator *);
233 static void revalidator_purge(struct revalidator *);
234 static void upcall_unixctl_show(struct unixctl_conn *conn, int argc,
235 const char *argv[], void *aux);
236 static void upcall_unixctl_disable_megaflows(struct unixctl_conn *, int argc,
237 const char *argv[], void *aux);
238 static void upcall_unixctl_enable_megaflows(struct unixctl_conn *, int argc,
239 const char *argv[], void *aux);
240 static void upcall_unixctl_set_flow_limit(struct unixctl_conn *conn, int argc,
241 const char *argv[], void *aux);
242 static void ukey_delete(struct revalidator *, struct udpif_key *);
244 static atomic_bool enable_megaflows = ATOMIC_VAR_INIT(true);
247 udpif_create(struct dpif_backer *backer, struct dpif *dpif)
249 static struct ovsthread_once once = OVSTHREAD_ONCE_INITIALIZER;
250 struct udpif *udpif = xzalloc(sizeof *udpif);
252 if (ovsthread_once_start(&once)) {
253 unixctl_command_register("upcall/show", "", 0, 0, upcall_unixctl_show,
255 unixctl_command_register("upcall/disable-megaflows", "", 0, 0,
256 upcall_unixctl_disable_megaflows, NULL);
257 unixctl_command_register("upcall/enable-megaflows", "", 0, 0,
258 upcall_unixctl_enable_megaflows, NULL);
259 unixctl_command_register("upcall/set-flow-limit", "", 1, 1,
260 upcall_unixctl_set_flow_limit, NULL);
261 ovsthread_once_done(&once);
265 udpif->backer = backer;
266 atomic_init(&udpif->flow_limit, MIN(ofproto_flow_limit, 10000));
267 udpif->secret = random_uint32();
268 udpif->reval_seq = seq_create();
269 udpif->dump_seq = seq_create();
270 latch_init(&udpif->exit_latch);
271 list_push_back(&all_udpifs, &udpif->list_node);
272 atomic_init(&udpif->n_flows, 0);
273 atomic_init(&udpif->n_flows_timestamp, LLONG_MIN);
274 ovs_mutex_init(&udpif->n_flows_mutex);
280 udpif_destroy(struct udpif *udpif)
282 udpif_set_threads(udpif, 0, 0);
285 list_remove(&udpif->list_node);
286 latch_destroy(&udpif->exit_latch);
287 seq_destroy(udpif->reval_seq);
288 seq_destroy(udpif->dump_seq);
289 atomic_destroy(&udpif->flow_limit);
290 atomic_destroy(&udpif->n_flows);
291 atomic_destroy(&udpif->n_flows_timestamp);
292 ovs_mutex_destroy(&udpif->n_flows_mutex);
296 /* Tells 'udpif' how many threads it should use to handle upcalls. Disables
297 * all threads if 'n_handlers' and 'n_revalidators' is zero. 'udpif''s
298 * datapath handle must have packet reception enabled before starting threads.
301 udpif_set_threads(struct udpif *udpif, size_t n_handlers,
302 size_t n_revalidators)
304 /* Stop the old threads (if any). */
305 if (udpif->handlers &&
306 (udpif->n_handlers != n_handlers
307 || udpif->n_revalidators != n_revalidators)) {
310 latch_set(&udpif->exit_latch);
312 for (i = 0; i < udpif->n_handlers; i++) {
313 struct handler *handler = &udpif->handlers[i];
315 ovs_mutex_lock(&handler->mutex);
316 xpthread_cond_signal(&handler->wake_cond);
317 ovs_mutex_unlock(&handler->mutex);
318 xpthread_join(handler->thread, NULL);
321 for (i = 0; i < udpif->n_revalidators; i++) {
322 struct revalidator *revalidator = &udpif->revalidators[i];
324 ovs_mutex_lock(&revalidator->mutex);
325 xpthread_cond_signal(&revalidator->wake_cond);
326 ovs_mutex_unlock(&revalidator->mutex);
327 xpthread_join(revalidator->thread, NULL);
330 xpthread_join(udpif->flow_dumper, NULL);
331 xpthread_join(udpif->dispatcher, NULL);
333 for (i = 0; i < udpif->n_revalidators; i++) {
334 struct revalidator *revalidator = &udpif->revalidators[i];
335 struct udpif_flow_dump *udump, *next_udump;
337 LIST_FOR_EACH_SAFE (udump, next_udump, list_node,
338 &revalidator->udumps) {
339 list_remove(&udump->list_node);
343 /* Delete ukeys, and delete all flows from the datapath to prevent
344 * double-counting stats. */
345 revalidator_purge(revalidator);
346 hmap_destroy(&revalidator->ukeys);
347 ovs_mutex_destroy(&revalidator->mutex);
349 free(revalidator->name);
352 for (i = 0; i < udpif->n_handlers; i++) {
353 struct handler *handler = &udpif->handlers[i];
354 struct upcall *miss, *next;
356 LIST_FOR_EACH_SAFE (miss, next, list_node, &handler->upcalls) {
357 list_remove(&miss->list_node);
358 upcall_destroy(miss);
360 ovs_mutex_destroy(&handler->mutex);
362 xpthread_cond_destroy(&handler->wake_cond);
365 latch_poll(&udpif->exit_latch);
367 free(udpif->revalidators);
368 udpif->revalidators = NULL;
369 udpif->n_revalidators = 0;
371 free(udpif->handlers);
372 udpif->handlers = NULL;
373 udpif->n_handlers = 0;
376 /* Start new threads (if necessary). */
377 if (!udpif->handlers && n_handlers) {
380 udpif->n_handlers = n_handlers;
381 udpif->n_revalidators = n_revalidators;
383 udpif->handlers = xzalloc(udpif->n_handlers * sizeof *udpif->handlers);
384 for (i = 0; i < udpif->n_handlers; i++) {
385 struct handler *handler = &udpif->handlers[i];
387 handler->udpif = udpif;
388 list_init(&handler->upcalls);
389 handler->need_signal = false;
390 xpthread_cond_init(&handler->wake_cond, NULL);
391 ovs_mutex_init(&handler->mutex);
392 xpthread_create(&handler->thread, NULL, udpif_upcall_handler,
396 udpif->revalidators = xzalloc(udpif->n_revalidators
397 * sizeof *udpif->revalidators);
398 for (i = 0; i < udpif->n_revalidators; i++) {
399 struct revalidator *revalidator = &udpif->revalidators[i];
401 revalidator->udpif = udpif;
402 list_init(&revalidator->udumps);
403 hmap_init(&revalidator->ukeys);
404 ovs_mutex_init(&revalidator->mutex);
405 xpthread_cond_init(&revalidator->wake_cond, NULL);
406 xpthread_create(&revalidator->thread, NULL, udpif_revalidator,
409 xpthread_create(&udpif->dispatcher, NULL, udpif_dispatcher, udpif);
410 xpthread_create(&udpif->flow_dumper, NULL, udpif_flow_dumper, udpif);
414 /* Waits for all ongoing upcall translations to complete. This ensures that
415 * there are no transient references to any removed ofprotos (or other
416 * objects). In particular, this should be called after an ofproto is removed
417 * (e.g. via xlate_remove_ofproto()) but before it is destroyed. */
419 udpif_synchronize(struct udpif *udpif)
421 /* This is stronger than necessary. It would be sufficient to ensure
422 * (somehow) that each handler and revalidator thread had passed through
423 * its main loop once. */
424 size_t n_handlers = udpif->n_handlers;
425 size_t n_revalidators = udpif->n_revalidators;
426 udpif_set_threads(udpif, 0, 0);
427 udpif_set_threads(udpif, n_handlers, n_revalidators);
430 /* Notifies 'udpif' that something changed which may render previous
431 * xlate_actions() results invalid. */
433 udpif_revalidate(struct udpif *udpif)
435 seq_change(udpif->reval_seq);
438 /* Returns a seq which increments every time 'udpif' pulls stats from the
439 * datapath. Callers can use this to get a sense of when might be a good time
440 * to do periodic work which relies on relatively up to date statistics. */
442 udpif_dump_seq(struct udpif *udpif)
444 return udpif->dump_seq;
448 udpif_get_memory_usage(struct udpif *udpif, struct simap *usage)
452 simap_increase(usage, "dispatchers", 1);
453 simap_increase(usage, "flow_dumpers", 1);
455 simap_increase(usage, "handlers", udpif->n_handlers);
456 for (i = 0; i < udpif->n_handlers; i++) {
457 struct handler *handler = &udpif->handlers[i];
458 ovs_mutex_lock(&handler->mutex);
459 simap_increase(usage, "handler upcalls", handler->n_upcalls);
460 ovs_mutex_unlock(&handler->mutex);
463 simap_increase(usage, "revalidators", udpif->n_revalidators);
464 for (i = 0; i < udpif->n_revalidators; i++) {
465 struct revalidator *revalidator = &udpif->revalidators[i];
466 ovs_mutex_lock(&revalidator->mutex);
467 simap_increase(usage, "revalidator dumps", revalidator->n_udumps);
469 /* XXX: This isn't technically thread safe because the revalidator
470 * ukeys maps isn't protected by a mutex since it's per thread. */
471 simap_increase(usage, "revalidator keys",
472 hmap_count(&revalidator->ukeys));
473 ovs_mutex_unlock(&revalidator->mutex);
477 /* Removes all flows from all datapaths. */
483 LIST_FOR_EACH (udpif, list_node, &all_udpifs) {
484 dpif_flow_flush(udpif->dpif);
488 /* Destroys and deallocates 'upcall'. */
490 upcall_destroy(struct upcall *upcall)
493 ofpbuf_uninit(&upcall->dpif_upcall.packet);
494 ofpbuf_uninit(&upcall->upcall_buf);
500 udpif_get_n_flows(struct udpif *udpif)
502 long long int time, now;
506 atomic_read(&udpif->n_flows_timestamp, &time);
507 if (time < now - 100 && !ovs_mutex_trylock(&udpif->n_flows_mutex)) {
508 struct dpif_dp_stats stats;
510 atomic_store(&udpif->n_flows_timestamp, now);
511 dpif_get_dp_stats(udpif->dpif, &stats);
512 flow_count = stats.n_flows;
513 atomic_store(&udpif->n_flows, flow_count);
514 ovs_mutex_unlock(&udpif->n_flows_mutex);
516 atomic_read(&udpif->n_flows, &flow_count);
521 /* The dispatcher thread is responsible for receiving upcalls from the kernel,
522 * assigning them to a upcall_handler thread. */
524 udpif_dispatcher(void *arg)
526 struct udpif *udpif = arg;
528 set_subprogram_name("dispatcher");
529 while (!latch_is_set(&udpif->exit_latch)) {
531 dpif_recv_wait(udpif->dpif);
532 latch_wait(&udpif->exit_latch);
540 udpif_flow_dumper(void *arg)
542 struct udpif *udpif = arg;
544 set_subprogram_name("flow_dumper");
545 while (!latch_is_set(&udpif->exit_latch)) {
546 const struct dpif_flow_stats *stats;
547 long long int start_time, duration;
548 const struct nlattr *key, *mask;
549 struct dpif_flow_dump dump;
550 size_t key_len, mask_len;
551 unsigned int flow_limit;
552 bool need_revalidate;
556 reval_seq = seq_read(udpif->reval_seq);
557 need_revalidate = udpif->last_reval_seq != reval_seq;
558 udpif->last_reval_seq = reval_seq;
560 n_flows = udpif_get_n_flows(udpif);
561 udpif->max_n_flows = MAX(n_flows, udpif->max_n_flows);
562 udpif->avg_n_flows = (udpif->avg_n_flows + n_flows) / 2;
564 start_time = time_msec();
565 dpif_flow_dump_start(&dump, udpif->dpif);
566 while (dpif_flow_dump_next(&dump, &key, &key_len, &mask, &mask_len,
568 && !latch_is_set(&udpif->exit_latch)) {
569 struct udpif_flow_dump *udump = xmalloc(sizeof *udump);
570 struct revalidator *revalidator;
572 udump->key_hash = hash_bytes(key, key_len, udpif->secret);
573 memcpy(&udump->key_buf, key, key_len);
574 udump->key = (struct nlattr *) &udump->key_buf;
575 udump->key_len = key_len;
577 memcpy(&udump->mask_buf, mask, mask_len);
578 udump->mask = (struct nlattr *) &udump->mask_buf;
579 udump->mask_len = mask_len;
581 udump->stats = *stats;
582 udump->need_revalidate = need_revalidate;
584 revalidator = &udpif->revalidators[udump->key_hash
585 % udpif->n_revalidators];
587 ovs_mutex_lock(&revalidator->mutex);
588 while (revalidator->n_udumps >= REVALIDATE_MAX_BATCH * 3
589 && !latch_is_set(&udpif->exit_latch)) {
590 ovs_mutex_cond_wait(&revalidator->wake_cond,
591 &revalidator->mutex);
593 list_push_back(&revalidator->udumps, &udump->list_node);
594 revalidator->n_udumps++;
595 xpthread_cond_signal(&revalidator->wake_cond);
596 ovs_mutex_unlock(&revalidator->mutex);
598 dpif_flow_dump_done(&dump);
600 /* Let all the revalidators finish and garbage collect. */
601 seq_change(udpif->dump_seq);
602 for (i = 0; i < udpif->n_revalidators; i++) {
603 struct revalidator *revalidator = &udpif->revalidators[i];
604 ovs_mutex_lock(&revalidator->mutex);
605 xpthread_cond_signal(&revalidator->wake_cond);
606 ovs_mutex_unlock(&revalidator->mutex);
609 for (i = 0; i < udpif->n_revalidators; i++) {
610 struct revalidator *revalidator = &udpif->revalidators[i];
612 ovs_mutex_lock(&revalidator->mutex);
613 while (revalidator->dump_seq != seq_read(udpif->dump_seq)
614 && !latch_is_set(&udpif->exit_latch)) {
615 ovs_mutex_cond_wait(&revalidator->wake_cond,
616 &revalidator->mutex);
618 ovs_mutex_unlock(&revalidator->mutex);
621 duration = MAX(time_msec() - start_time, 1);
622 udpif->dump_duration = duration;
623 atomic_read(&udpif->flow_limit, &flow_limit);
624 if (duration > 2000) {
625 flow_limit /= duration / 1000;
626 } else if (duration > 1300) {
627 flow_limit = flow_limit * 3 / 4;
628 } else if (duration < 1000 && n_flows > 2000
629 && flow_limit < n_flows * 1000 / duration) {
632 flow_limit = MIN(ofproto_flow_limit, MAX(flow_limit, 1000));
633 atomic_store(&udpif->flow_limit, flow_limit);
635 if (duration > 2000) {
636 VLOG_INFO("Spent an unreasonably long %lldms dumping flows",
640 poll_timer_wait_until(start_time + MIN(MAX_IDLE, 500));
641 seq_wait(udpif->reval_seq, udpif->last_reval_seq);
642 latch_wait(&udpif->exit_latch);
649 /* The miss handler thread is responsible for processing miss upcalls retrieved
650 * by the dispatcher thread. Once finished it passes the processed miss
651 * upcalls to ofproto-dpif where they're installed in the datapath. */
653 udpif_upcall_handler(void *arg)
655 struct handler *handler = arg;
657 handler->name = xasprintf("handler_%u", ovsthread_id_self());
658 set_subprogram_name("%s", handler->name);
660 while (!latch_is_set(&handler->udpif->exit_latch)) {
661 struct list misses = LIST_INITIALIZER(&misses);
664 ovs_mutex_lock(&handler->mutex);
665 if (!handler->n_upcalls) {
666 ovs_mutex_cond_wait(&handler->wake_cond, &handler->mutex);
669 for (i = 0; i < FLOW_MISS_MAX_BATCH; i++) {
670 if (handler->n_upcalls) {
671 handler->n_upcalls--;
672 list_push_back(&misses, list_pop_front(&handler->upcalls));
677 ovs_mutex_unlock(&handler->mutex);
679 handle_upcalls(handler, &misses);
688 udpif_revalidator(void *arg)
690 struct revalidator *revalidator = arg;
692 revalidator->name = xasprintf("revalidator_%u", ovsthread_id_self());
693 set_subprogram_name("%s", revalidator->name);
695 struct list udumps = LIST_INITIALIZER(&udumps);
696 struct udpif *udpif = revalidator->udpif;
699 ovs_mutex_lock(&revalidator->mutex);
700 if (latch_is_set(&udpif->exit_latch)) {
701 ovs_mutex_unlock(&revalidator->mutex);
705 if (!revalidator->n_udumps) {
706 if (revalidator->dump_seq != seq_read(udpif->dump_seq)) {
707 revalidator->dump_seq = seq_read(udpif->dump_seq);
708 revalidator_sweep(revalidator);
710 ovs_mutex_cond_wait(&revalidator->wake_cond,
711 &revalidator->mutex);
715 for (i = 0; i < REVALIDATE_MAX_BATCH && revalidator->n_udumps; i++) {
716 list_push_back(&udumps, list_pop_front(&revalidator->udumps));
717 revalidator->n_udumps--;
720 /* Wake up the flow dumper. */
721 xpthread_cond_signal(&revalidator->wake_cond);
722 ovs_mutex_unlock(&revalidator->mutex);
724 if (!list_is_empty(&udumps)) {
725 revalidate_udumps(revalidator, &udumps);
732 static enum upcall_type
733 classify_upcall(const struct upcall *upcall)
735 const struct dpif_upcall *dpif_upcall = &upcall->dpif_upcall;
736 union user_action_cookie cookie;
739 /* First look at the upcall type. */
740 switch (dpif_upcall->type) {
747 case DPIF_N_UC_TYPES:
749 VLOG_WARN_RL(&rl, "upcall has unexpected type %"PRIu32,
754 /* "action" upcalls need a closer look. */
755 if (!dpif_upcall->userdata) {
756 VLOG_WARN_RL(&rl, "action upcall missing cookie");
759 userdata_len = nl_attr_get_size(dpif_upcall->userdata);
760 if (userdata_len < sizeof cookie.type
761 || userdata_len > sizeof cookie) {
762 VLOG_WARN_RL(&rl, "action upcall cookie has unexpected size %"PRIuSIZE,
766 memset(&cookie, 0, sizeof cookie);
767 memcpy(&cookie, nl_attr_get(dpif_upcall->userdata), userdata_len);
768 if (userdata_len == MAX(8, sizeof cookie.sflow)
769 && cookie.type == USER_ACTION_COOKIE_SFLOW) {
771 } else if (userdata_len == MAX(8, sizeof cookie.slow_path)
772 && cookie.type == USER_ACTION_COOKIE_SLOW_PATH) {
774 } else if (userdata_len == MAX(8, sizeof cookie.flow_sample)
775 && cookie.type == USER_ACTION_COOKIE_FLOW_SAMPLE) {
776 return FLOW_SAMPLE_UPCALL;
777 } else if (userdata_len == MAX(8, sizeof cookie.ipfix)
778 && cookie.type == USER_ACTION_COOKIE_IPFIX) {
781 VLOG_WARN_RL(&rl, "invalid user cookie of type %"PRIu16
782 " and size %"PRIuSIZE, cookie.type, userdata_len);
788 recv_upcalls(struct udpif *udpif)
793 uint32_t hash = udpif->secret;
794 struct handler *handler;
795 struct upcall *upcall;
796 size_t n_bytes, left;
800 upcall = xmalloc(sizeof *upcall);
801 ofpbuf_use_stub(&upcall->upcall_buf, upcall->upcall_stub,
802 sizeof upcall->upcall_stub);
803 error = dpif_recv(udpif->dpif, &upcall->dpif_upcall,
804 &upcall->upcall_buf);
806 /* upcall_destroy() can only be called on successfully received
808 ofpbuf_uninit(&upcall->upcall_buf);
814 NL_ATTR_FOR_EACH (nla, left, upcall->dpif_upcall.key,
815 upcall->dpif_upcall.key_len) {
816 enum ovs_key_attr type = nl_attr_type(nla);
817 if (type == OVS_KEY_ATTR_IN_PORT
818 || type == OVS_KEY_ATTR_TCP
819 || type == OVS_KEY_ATTR_UDP) {
820 if (nl_attr_get_size(nla) == 4) {
821 hash = mhash_add(hash, nl_attr_get_u32(nla));
825 "Netlink attribute with incorrect size.");
829 hash = mhash_finish(hash, n_bytes);
831 handler = &udpif->handlers[hash % udpif->n_handlers];
833 ovs_mutex_lock(&handler->mutex);
834 if (handler->n_upcalls < MAX_QUEUE_LENGTH) {
835 list_push_back(&handler->upcalls, &upcall->list_node);
836 if (handler->n_upcalls == 0) {
837 handler->need_signal = true;
839 handler->n_upcalls++;
840 if (handler->need_signal &&
841 handler->n_upcalls >= FLOW_MISS_MAX_BATCH) {
842 handler->need_signal = false;
843 xpthread_cond_signal(&handler->wake_cond);
845 ovs_mutex_unlock(&handler->mutex);
846 if (!VLOG_DROP_DBG(&rl)) {
847 struct ds ds = DS_EMPTY_INITIALIZER;
849 odp_flow_key_format(upcall->dpif_upcall.key,
850 upcall->dpif_upcall.key_len,
852 VLOG_DBG("dispatcher: enqueue (%s)", ds_cstr(&ds));
856 ovs_mutex_unlock(&handler->mutex);
857 COVERAGE_INC(upcall_queue_overflow);
858 upcall_destroy(upcall);
862 for (n = 0; n < udpif->n_handlers; ++n) {
863 struct handler *handler = &udpif->handlers[n];
865 if (handler->need_signal) {
866 handler->need_signal = false;
867 ovs_mutex_lock(&handler->mutex);
868 xpthread_cond_signal(&handler->wake_cond);
869 ovs_mutex_unlock(&handler->mutex);
874 /* Calculates slow path actions for 'xout'. 'buf' must statically be
875 * initialized with at least 128 bytes of space. */
877 compose_slow_path(struct udpif *udpif, struct xlate_out *xout,
878 odp_port_t odp_in_port, struct ofpbuf *buf)
880 union user_action_cookie cookie;
884 cookie.type = USER_ACTION_COOKIE_SLOW_PATH;
885 cookie.slow_path.unused = 0;
886 cookie.slow_path.reason = xout->slow;
888 port = xout->slow & (SLOW_CFM | SLOW_BFD | SLOW_LACP | SLOW_STP)
891 pid = dpif_port_get_pid(udpif->dpif, port);
892 odp_put_userspace_action(pid, &cookie, sizeof cookie.slow_path, buf);
895 static struct flow_miss *
896 flow_miss_find(struct hmap *todo, const struct ofproto_dpif *ofproto,
897 const struct flow *flow, uint32_t hash)
899 struct flow_miss *miss;
901 HMAP_FOR_EACH_WITH_HASH (miss, hmap_node, hash, todo) {
902 if (miss->ofproto == ofproto && flow_equal(&miss->flow, flow)) {
911 handle_upcalls(struct handler *handler, struct list *upcalls)
913 struct hmap misses = HMAP_INITIALIZER(&misses);
914 struct udpif *udpif = handler->udpif;
916 struct flow_miss miss_buf[FLOW_MISS_MAX_BATCH];
917 struct dpif_op *opsp[FLOW_MISS_MAX_BATCH * 2];
918 struct dpif_op ops[FLOW_MISS_MAX_BATCH * 2];
919 struct flow_miss *miss, *next_miss;
920 struct upcall *upcall, *next;
921 size_t n_misses, n_ops, i;
922 unsigned int flow_limit;
923 bool fail_open, may_put;
924 enum upcall_type type;
926 atomic_read(&udpif->flow_limit, &flow_limit);
927 may_put = udpif_get_n_flows(udpif) < flow_limit;
929 /* Extract the flow from each upcall. Construct in 'misses' a hash table
930 * that maps each unique flow to a 'struct flow_miss'.
932 * Most commonly there is a single packet per flow_miss, but there are
933 * several reasons why there might be more than one, e.g.:
935 * - The dpif packet interface does not support TSO (or UFO, etc.), so a
936 * large packet sent to userspace is split into a sequence of smaller
939 * - A stream of quickly arriving packets in an established "slow-pathed"
942 * - Rarely, a stream of quickly arriving packets in a flow not yet
943 * established. (This is rare because most protocols do not send
944 * multiple back-to-back packets before receiving a reply from the
945 * other end of the connection, which gives OVS a chance to set up a
949 LIST_FOR_EACH_SAFE (upcall, next, list_node, upcalls) {
950 struct dpif_upcall *dupcall = &upcall->dpif_upcall;
951 struct flow_miss *miss = &miss_buf[n_misses];
952 struct ofpbuf *packet = &dupcall->packet;
953 struct flow_miss *existing_miss;
954 struct ofproto_dpif *ofproto;
955 struct dpif_sflow *sflow;
956 struct dpif_ipfix *ipfix;
957 odp_port_t odp_in_port;
961 error = xlate_receive(udpif->backer, packet, dupcall->key,
962 dupcall->key_len, &flow,
963 &ofproto, &ipfix, &sflow, NULL, &odp_in_port);
965 if (error == ENODEV) {
966 /* Received packet on datapath port for which we couldn't
967 * associate an ofproto. This can happen if a port is removed
968 * while traffic is being received. Print a rate-limited
969 * message in case it happens frequently. Install a drop flow
970 * so that future packets of the flow are inexpensively dropped
972 VLOG_INFO_RL(&rl, "received packet on unassociated datapath "
973 "port %"PRIu32, odp_in_port);
974 dpif_flow_put(udpif->dpif, DPIF_FP_CREATE | DPIF_FP_MODIFY,
975 dupcall->key, dupcall->key_len, NULL, 0, NULL, 0,
978 list_remove(&upcall->list_node);
979 upcall_destroy(upcall);
983 type = classify_upcall(upcall);
984 if (type == MISS_UPCALL) {
987 flow_extract(packet, flow.skb_priority, flow.pkt_mark,
988 &flow.tunnel, &flow.in_port, &miss->flow);
990 hash = flow_hash(&miss->flow, 0);
991 existing_miss = flow_miss_find(&misses, ofproto, &miss->flow,
993 if (!existing_miss) {
994 hmap_insert(&misses, &miss->hmap_node, hash);
995 miss->ofproto = ofproto;
996 miss->key = dupcall->key;
997 miss->key_len = dupcall->key_len;
998 miss->upcall_type = dupcall->type;
999 miss->stats.n_packets = 0;
1000 miss->stats.n_bytes = 0;
1001 miss->stats.used = time_msec();
1002 miss->stats.tcp_flags = 0;
1003 miss->odp_in_port = odp_in_port;
1008 miss = existing_miss;
1010 miss->stats.tcp_flags |= packet_get_tcp_flags(packet, &miss->flow);
1011 miss->stats.n_bytes += packet->size;
1012 miss->stats.n_packets++;
1014 upcall->flow_miss = miss;
1021 union user_action_cookie cookie;
1023 memset(&cookie, 0, sizeof cookie);
1024 memcpy(&cookie, nl_attr_get(dupcall->userdata),
1025 sizeof cookie.sflow);
1026 dpif_sflow_received(sflow, packet, &flow, odp_in_port,
1032 dpif_ipfix_bridge_sample(ipfix, packet, &flow);
1035 case FLOW_SAMPLE_UPCALL:
1037 union user_action_cookie cookie;
1039 memset(&cookie, 0, sizeof cookie);
1040 memcpy(&cookie, nl_attr_get(dupcall->userdata),
1041 sizeof cookie.flow_sample);
1043 /* The flow reflects exactly the contents of the packet.
1044 * Sample the packet using it. */
1045 dpif_ipfix_flow_sample(ipfix, packet, &flow,
1046 cookie.flow_sample.collector_set_id,
1047 cookie.flow_sample.probability,
1048 cookie.flow_sample.obs_domain_id,
1049 cookie.flow_sample.obs_point_id);
1058 dpif_ipfix_unref(ipfix);
1059 dpif_sflow_unref(sflow);
1061 list_remove(&upcall->list_node);
1062 upcall_destroy(upcall);
1065 /* Initialize each 'struct flow_miss's ->xout.
1067 * We do this per-flow_miss rather than per-packet because, most commonly,
1068 * all the packets in a flow can use the same translation.
1070 * We can't do this in the previous loop because we need the TCP flags for
1071 * all the packets in each miss. */
1073 HMAP_FOR_EACH (miss, hmap_node, &misses) {
1074 struct xlate_in xin;
1076 xlate_in_init(&xin, miss->ofproto, &miss->flow, NULL,
1077 miss->stats.tcp_flags, NULL);
1078 xin.may_learn = true;
1080 if (miss->upcall_type == DPIF_UC_MISS) {
1081 xin.resubmit_stats = &miss->stats;
1083 /* For non-miss upcalls, there's a flow in the datapath which this
1084 * packet was accounted to. Presumably the revalidators will deal
1085 * with pushing its stats eventually. */
1088 xlate_actions(&xin, &miss->xout);
1089 fail_open = fail_open || miss->xout.fail_open;
1092 /* Now handle the packets individually in order of arrival. In the common
1093 * case each packet of a miss can share the same actions, but slow-pathed
1094 * packets need to be translated individually:
1096 * - For SLOW_CFM, SLOW_LACP, SLOW_STP, and SLOW_BFD, translation is what
1097 * processes received packets for these protocols.
1099 * - For SLOW_CONTROLLER, translation sends the packet to the OpenFlow
1102 * The loop fills 'ops' with an array of operations to execute in the
1105 LIST_FOR_EACH (upcall, list_node, upcalls) {
1106 struct flow_miss *miss = upcall->flow_miss;
1107 struct ofpbuf *packet = &upcall->dpif_upcall.packet;
1109 ovs_be16 flow_vlan_tci;
1111 /* Save a copy of flow.vlan_tci in case it is changed to
1112 * generate proper mega flow masks for VLAN splinter flows. */
1113 flow_vlan_tci = miss->flow.vlan_tci;
1115 if (miss->xout.slow) {
1116 struct xlate_in xin;
1118 xlate_in_init(&xin, miss->ofproto, &miss->flow, NULL, 0, packet);
1119 xlate_actions_for_side_effects(&xin);
1122 if (miss->flow.in_port.ofp_port
1123 != vsp_realdev_to_vlandev(miss->ofproto,
1124 miss->flow.in_port.ofp_port,
1125 miss->flow.vlan_tci)) {
1126 /* This packet was received on a VLAN splinter port. We
1127 * added a VLAN to the packet to make the packet resemble
1128 * the flow, but the actions were composed assuming that
1129 * the packet contained no VLAN. So, we must remove the
1130 * VLAN header from the packet before trying to execute the
1132 if (miss->xout.odp_actions.size) {
1133 eth_pop_vlan(packet);
1136 /* Remove the flow vlan tags inserted by vlan splinter logic
1137 * to ensure megaflow masks generated match the data path flow. */
1138 miss->flow.vlan_tci = 0;
1141 /* Do not install a flow into the datapath if:
1143 * - The datapath already has too many flows.
1145 * - An earlier iteration of this loop already put the same flow.
1147 * - We received this packet via some flow installed in the kernel
1151 && upcall->dpif_upcall.type == DPIF_UC_MISS) {
1157 atomic_read(&enable_megaflows, &megaflow);
1158 ofpbuf_use_stack(&mask, &miss->mask_buf, sizeof miss->mask_buf);
1162 max_mpls = ofproto_dpif_get_max_mpls_depth(miss->ofproto);
1163 odp_flow_key_from_mask(&mask, &miss->xout.wc.masks,
1164 &miss->flow, UINT32_MAX, max_mpls);
1168 op->type = DPIF_OP_FLOW_PUT;
1169 op->u.flow_put.flags = DPIF_FP_CREATE | DPIF_FP_MODIFY;
1170 op->u.flow_put.key = miss->key;
1171 op->u.flow_put.key_len = miss->key_len;
1172 op->u.flow_put.mask = mask.data;
1173 op->u.flow_put.mask_len = mask.size;
1174 op->u.flow_put.stats = NULL;
1176 if (!miss->xout.slow) {
1177 op->u.flow_put.actions = miss->xout.odp_actions.data;
1178 op->u.flow_put.actions_len = miss->xout.odp_actions.size;
1182 ofpbuf_use_stack(&buf, miss->slow_path_buf,
1183 sizeof miss->slow_path_buf);
1184 compose_slow_path(udpif, &miss->xout, miss->odp_in_port, &buf);
1185 op->u.flow_put.actions = buf.data;
1186 op->u.flow_put.actions_len = buf.size;
1191 * The 'miss' may be shared by multiple upcalls. Restore
1192 * the saved flow vlan_tci field before processing the next
1194 miss->flow.vlan_tci = flow_vlan_tci;
1196 if (miss->xout.odp_actions.size) {
1199 op->type = DPIF_OP_EXECUTE;
1200 op->u.execute.packet = packet;
1201 odp_key_to_pkt_metadata(miss->key, miss->key_len,
1203 op->u.execute.actions = miss->xout.odp_actions.data;
1204 op->u.execute.actions_len = miss->xout.odp_actions.size;
1205 op->u.execute.needs_help = (miss->xout.slow & SLOW_ACTION) != 0;
1209 /* Special case for fail-open mode.
1211 * If we are in fail-open mode, but we are connected to a controller too,
1212 * then we should send the packet up to the controller in the hope that it
1213 * will try to set up a flow and thereby allow us to exit fail-open.
1215 * See the top-level comment in fail-open.c for more information.
1217 * Copy packets before they are modified by execution. */
1219 LIST_FOR_EACH (upcall, list_node, upcalls) {
1220 struct flow_miss *miss = upcall->flow_miss;
1221 struct ofpbuf *packet = &upcall->dpif_upcall.packet;
1222 struct ofproto_packet_in *pin;
1224 pin = xmalloc(sizeof *pin);
1225 pin->up.packet = xmemdup(packet->data, packet->size);
1226 pin->up.packet_len = packet->size;
1227 pin->up.reason = OFPR_NO_MATCH;
1228 pin->up.table_id = 0;
1229 pin->up.cookie = OVS_BE64_MAX;
1230 flow_get_metadata(&miss->flow, &pin->up.fmd);
1231 pin->send_len = 0; /* Not used for flow table misses. */
1232 pin->generated_by_table_miss = false;
1233 ofproto_dpif_send_packet_in(miss->ofproto, pin);
1237 /* Execute batch. */
1238 for (i = 0; i < n_ops; i++) {
1241 dpif_operate(udpif->dpif, opsp, n_ops);
1243 HMAP_FOR_EACH_SAFE (miss, next_miss, hmap_node, &misses) {
1244 hmap_remove(&misses, &miss->hmap_node);
1245 xlate_out_uninit(&miss->xout);
1247 hmap_destroy(&misses);
1249 LIST_FOR_EACH_SAFE (upcall, next, list_node, upcalls) {
1250 list_remove(&upcall->list_node);
1251 upcall_destroy(upcall);
1255 static struct udpif_key *
1256 ukey_lookup(struct revalidator *revalidator, struct udpif_flow_dump *udump)
1258 struct udpif_key *ukey;
1260 HMAP_FOR_EACH_WITH_HASH (ukey, hmap_node, udump->key_hash,
1261 &revalidator->ukeys) {
1262 if (ukey->key_len == udump->key_len
1263 && !memcmp(ukey->key, udump->key, udump->key_len)) {
1270 static struct udpif_key *
1271 ukey_create(const struct nlattr *key, size_t key_len, long long int used)
1273 struct udpif_key *ukey = xmalloc(sizeof *ukey);
1275 ukey->key = (struct nlattr *) &ukey->key_buf;
1276 memcpy(&ukey->key_buf, key, key_len);
1277 ukey->key_len = key_len;
1280 ukey->created = used ? used : time_msec();
1281 memset(&ukey->stats, 0, sizeof ukey->stats);
1287 ukey_delete(struct revalidator *revalidator, struct udpif_key *ukey)
1289 hmap_remove(&revalidator->ukeys, &ukey->hmap_node);
1294 revalidate_ukey(struct udpif *udpif, struct udpif_flow_dump *udump,
1295 struct udpif_key *ukey)
1297 struct ofpbuf xout_actions, *actions;
1298 uint64_t slow_path_buf[128 / 8];
1299 struct xlate_out xout, *xoutp;
1300 struct flow flow, udump_mask;
1301 struct ofproto_dpif *ofproto;
1302 struct dpif_flow_stats push;
1303 uint32_t *udump32, *xout32;
1304 odp_port_t odp_in_port;
1305 struct xlate_in xin;
1314 /* If we don't need to revalidate, we can simply push the stats contained
1315 * in the udump, otherwise we'll have to get the actions so we can check
1317 if (udump->need_revalidate) {
1318 if (dpif_flow_get(udpif->dpif, ukey->key, ukey->key_len, &actions,
1324 push.used = udump->stats.used;
1325 push.tcp_flags = udump->stats.tcp_flags;
1326 push.n_packets = udump->stats.n_packets > ukey->stats.n_packets
1327 ? udump->stats.n_packets - ukey->stats.n_packets
1329 push.n_bytes = udump->stats.n_bytes > ukey->stats.n_bytes
1330 ? udump->stats.n_bytes - ukey->stats.n_bytes
1332 ukey->stats = udump->stats;
1334 if (!push.n_packets && !udump->need_revalidate) {
1339 error = xlate_receive(udpif->backer, NULL, ukey->key, ukey->key_len, &flow,
1340 &ofproto, NULL, NULL, NULL, &odp_in_port);
1345 xlate_in_init(&xin, ofproto, &flow, NULL, push.tcp_flags, NULL);
1346 xin.resubmit_stats = push.n_packets ? &push : NULL;
1347 xin.may_learn = push.n_packets > 0;
1348 xin.skip_wildcards = !udump->need_revalidate;
1349 xlate_actions(&xin, &xout);
1352 if (!udump->need_revalidate) {
1358 ofpbuf_use_const(&xout_actions, xout.odp_actions.data,
1359 xout.odp_actions.size);
1361 ofpbuf_use_stack(&xout_actions, slow_path_buf, sizeof slow_path_buf);
1362 compose_slow_path(udpif, &xout, odp_in_port, &xout_actions);
1365 if (!ofpbuf_equal(&xout_actions, actions)) {
1369 if (odp_flow_key_to_mask(udump->mask, udump->mask_len, &udump_mask, &flow)
1374 /* Since the kernel is free to ignore wildcarded bits in the mask, we can't
1375 * directly check that the masks are the same. Instead we check that the
1376 * mask in the kernel is more specific i.e. less wildcarded, than what
1377 * we've calculated here. This guarantees we don't catch any packets we
1378 * shouldn't with the megaflow. */
1379 udump32 = (uint32_t *) &udump_mask;
1380 xout32 = (uint32_t *) &xout.wc.masks;
1381 for (i = 0; i < FLOW_U32S; i++) {
1382 if ((udump32[i] | xout32[i]) != udump32[i]) {
1389 ofpbuf_delete(actions);
1390 xlate_out_uninit(xoutp);
1395 struct udpif_key *ukey;
1396 struct udpif_flow_dump *udump;
1397 struct dpif_flow_stats stats; /* Stats for 'op'. */
1398 struct dpif_op op; /* Flow del operation. */
1402 dump_op_init(struct dump_op *op, const struct nlattr *key, size_t key_len,
1403 struct udpif_key *ukey, struct udpif_flow_dump *udump)
1407 op->op.type = DPIF_OP_FLOW_DEL;
1408 op->op.u.flow_del.key = key;
1409 op->op.u.flow_del.key_len = key_len;
1410 op->op.u.flow_del.stats = &op->stats;
1414 push_dump_ops(struct revalidator *revalidator,
1415 struct dump_op *ops, size_t n_ops)
1417 struct udpif *udpif = revalidator->udpif;
1418 struct dpif_op *opsp[REVALIDATE_MAX_BATCH];
1421 ovs_assert(n_ops <= REVALIDATE_MAX_BATCH);
1422 for (i = 0; i < n_ops; i++) {
1423 opsp[i] = &ops[i].op;
1425 dpif_operate(udpif->dpif, opsp, n_ops);
1427 for (i = 0; i < n_ops; i++) {
1428 struct dump_op *op = &ops[i];
1429 struct dpif_flow_stats *push, *stats, push_buf;
1431 stats = op->op.u.flow_del.stats;
1434 push->used = MAX(stats->used, op->ukey->stats.used);
1435 push->tcp_flags = stats->tcp_flags | op->ukey->stats.tcp_flags;
1436 push->n_packets = stats->n_packets - op->ukey->stats.n_packets;
1437 push->n_bytes = stats->n_bytes - op->ukey->stats.n_bytes;
1442 if (push->n_packets || netflow_exists()) {
1443 struct ofproto_dpif *ofproto;
1444 struct netflow *netflow;
1447 if (!xlate_receive(udpif->backer, NULL, op->op.u.flow_del.key,
1448 op->op.u.flow_del.key_len, &flow, &ofproto,
1449 NULL, NULL, &netflow, NULL)) {
1450 struct xlate_in xin;
1452 xlate_in_init(&xin, ofproto, &flow, NULL, push->tcp_flags,
1454 xin.resubmit_stats = push->n_packets ? push : NULL;
1455 xin.may_learn = push->n_packets > 0;
1456 xin.skip_wildcards = true;
1457 xlate_actions_for_side_effects(&xin);
1460 netflow_expire(netflow, &flow);
1461 netflow_flow_clear(netflow, &flow);
1462 netflow_unref(netflow);
1468 for (i = 0; i < n_ops; i++) {
1469 struct udpif_key *ukey;
1471 /* If there's a udump, this ukey came directly from a datapath flow
1472 * dump. Sometimes a datapath can send duplicates in flow dumps, in
1473 * which case we wouldn't want to double-free a ukey, so avoid that by
1474 * looking up the ukey again.
1476 * If there's no udump then we know what we're doing. */
1477 ukey = (ops[i].udump
1478 ? ukey_lookup(revalidator, ops[i].udump)
1481 ukey_delete(revalidator, ukey);
1487 revalidate_udumps(struct revalidator *revalidator, struct list *udumps)
1489 struct udpif *udpif = revalidator->udpif;
1491 struct dump_op ops[REVALIDATE_MAX_BATCH];
1492 struct udpif_flow_dump *udump, *next_udump;
1493 size_t n_ops, n_flows;
1494 unsigned int flow_limit;
1495 long long int max_idle;
1498 atomic_read(&udpif->flow_limit, &flow_limit);
1500 n_flows = udpif_get_n_flows(udpif);
1503 max_idle = MAX_IDLE;
1504 if (n_flows > flow_limit) {
1505 must_del = n_flows > 2 * flow_limit;
1510 LIST_FOR_EACH_SAFE (udump, next_udump, list_node, udumps) {
1511 long long int used, now;
1512 struct udpif_key *ukey;
1515 ukey = ukey_lookup(revalidator, udump);
1517 used = udump->stats.used;
1518 if (!used && ukey) {
1519 used = ukey->created;
1522 if (must_del || (used && used < now - max_idle)) {
1523 struct dump_op *dop = &ops[n_ops++];
1525 dump_op_init(dop, udump->key, udump->key_len, ukey, udump);
1530 ukey = ukey_create(udump->key, udump->key_len, used);
1531 hmap_insert(&revalidator->ukeys, &ukey->hmap_node,
1536 if (!revalidate_ukey(udpif, udump, ukey)) {
1537 dpif_flow_del(udpif->dpif, udump->key, udump->key_len, NULL);
1538 ukey_delete(revalidator, ukey);
1541 list_remove(&udump->list_node);
1545 push_dump_ops(revalidator, ops, n_ops);
1547 LIST_FOR_EACH_SAFE (udump, next_udump, list_node, udumps) {
1548 list_remove(&udump->list_node);
1554 revalidator_sweep__(struct revalidator *revalidator, bool purge)
1556 struct dump_op ops[REVALIDATE_MAX_BATCH];
1557 struct udpif_key *ukey, *next;
1562 HMAP_FOR_EACH_SAFE (ukey, next, hmap_node, &revalidator->ukeys) {
1563 if (!purge && ukey->mark) {
1566 struct dump_op *op = &ops[n_ops++];
1568 /* If we have previously seen a flow in the datapath, but didn't
1569 * see it during the most recent dump, delete it. This allows us
1570 * to clean up the ukey and keep the statistics consistent. */
1571 dump_op_init(op, ukey->key, ukey->key_len, ukey, NULL);
1572 if (n_ops == REVALIDATE_MAX_BATCH) {
1573 push_dump_ops(revalidator, ops, n_ops);
1580 push_dump_ops(revalidator, ops, n_ops);
1585 revalidator_sweep(struct revalidator *revalidator)
1587 revalidator_sweep__(revalidator, false);
1591 revalidator_purge(struct revalidator *revalidator)
1593 revalidator_sweep__(revalidator, true);
1597 upcall_unixctl_show(struct unixctl_conn *conn, int argc OVS_UNUSED,
1598 const char *argv[] OVS_UNUSED, void *aux OVS_UNUSED)
1600 struct ds ds = DS_EMPTY_INITIALIZER;
1601 struct udpif *udpif;
1603 LIST_FOR_EACH (udpif, list_node, &all_udpifs) {
1604 unsigned int flow_limit;
1607 atomic_read(&udpif->flow_limit, &flow_limit);
1609 ds_put_format(&ds, "%s:\n", dpif_name(udpif->dpif));
1610 ds_put_format(&ds, "\tflows : (current %"PRIu64")"
1611 " (avg %u) (max %u) (limit %u)\n", udpif_get_n_flows(udpif),
1612 udpif->avg_n_flows, udpif->max_n_flows, flow_limit);
1613 ds_put_format(&ds, "\tdump duration : %lldms\n", udpif->dump_duration);
1615 ds_put_char(&ds, '\n');
1616 for (i = 0; i < udpif->n_handlers; i++) {
1617 struct handler *handler = &udpif->handlers[i];
1619 ovs_mutex_lock(&handler->mutex);
1620 ds_put_format(&ds, "\t%s: (upcall queue %"PRIuSIZE")\n",
1621 handler->name, handler->n_upcalls);
1622 ovs_mutex_unlock(&handler->mutex);
1625 ds_put_char(&ds, '\n');
1626 for (i = 0; i < n_revalidators; i++) {
1627 struct revalidator *revalidator = &udpif->revalidators[i];
1629 /* XXX: The result of hmap_count(&revalidator->ukeys) may not be
1630 * accurate because it's not protected by the revalidator mutex. */
1631 ovs_mutex_lock(&revalidator->mutex);
1632 ds_put_format(&ds, "\t%s: (dump queue %"PRIuSIZE") (keys %"PRIuSIZE
1633 ")\n", revalidator->name, revalidator->n_udumps,
1634 hmap_count(&revalidator->ukeys));
1635 ovs_mutex_unlock(&revalidator->mutex);
1639 unixctl_command_reply(conn, ds_cstr(&ds));
1643 /* Disable using the megaflows.
1645 * This command is only needed for advanced debugging, so it's not
1646 * documented in the man page. */
1648 upcall_unixctl_disable_megaflows(struct unixctl_conn *conn,
1649 int argc OVS_UNUSED,
1650 const char *argv[] OVS_UNUSED,
1651 void *aux OVS_UNUSED)
1653 atomic_store(&enable_megaflows, false);
1655 unixctl_command_reply(conn, "megaflows disabled");
1658 /* Re-enable using megaflows.
1660 * This command is only needed for advanced debugging, so it's not
1661 * documented in the man page. */
1663 upcall_unixctl_enable_megaflows(struct unixctl_conn *conn,
1664 int argc OVS_UNUSED,
1665 const char *argv[] OVS_UNUSED,
1666 void *aux OVS_UNUSED)
1668 atomic_store(&enable_megaflows, true);
1670 unixctl_command_reply(conn, "megaflows enabled");
1673 /* Set the flow limit.
1675 * This command is only needed for advanced debugging, so it's not
1676 * documented in the man page. */
1678 upcall_unixctl_set_flow_limit(struct unixctl_conn *conn,
1679 int argc OVS_UNUSED,
1680 const char *argv[] OVS_UNUSED,
1681 void *aux OVS_UNUSED)
1683 struct ds ds = DS_EMPTY_INITIALIZER;
1684 struct udpif *udpif;
1685 unsigned int flow_limit = atoi(argv[1]);
1687 LIST_FOR_EACH (udpif, list_node, &all_udpifs) {
1688 atomic_store(&udpif->flow_limit, flow_limit);
1690 ds_put_format(&ds, "set flow_limit to %u\n", flow_limit);
1691 unixctl_command_reply(conn, ds_cstr(&ds));