2 * Copyright (c) 2009, 2010 Nicira Networks.
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at:
8 * http://www.apache.org/licenses/LICENSE-2.0
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
17 /* "White box" tests for classifier.
19 * With very few exceptions, these tests obtain complete coverage of every
20 * basic block and every branch in the classifier implementation, e.g. a clean
21 * report from "gcov -b". (Covering the exceptions would require finding
22 * collisions in the hash function used for flow data, etc.)
24 * This test should receive a clean report from "valgrind --leak-check=full":
25 * it frees every heap block that it allocates.
29 #include "classifier.h"
32 #include "command-line.h"
35 #include "test-command-line.h"
41 int aux; /* Auxiliary data. */
42 struct cls_rule cls_rule; /* Classifier rule data. */
45 static struct test_rule *
46 test_rule_from_cls_rule(const struct cls_rule *rule)
48 return rule ? CONTAINER_OF(rule, struct test_rule, cls_rule) : NULL;
51 /* Trivial (linear) classifier. */
54 size_t allocated_rules;
55 struct test_rule **rules;
59 tcls_init(struct tcls *tcls)
62 tcls->allocated_rules = 0;
67 tcls_destroy(struct tcls *tcls)
72 for (i = 0; i < tcls->n_rules; i++) {
80 tcls_count_exact(const struct tcls *tcls)
86 for (i = 0; i < tcls->n_rules; i++) {
87 n_exact += tcls->rules[i]->cls_rule.flow.wildcards == 0;
93 tcls_is_empty(const struct tcls *tcls)
95 return tcls->n_rules == 0;
98 static struct test_rule *
99 tcls_insert(struct tcls *tcls, const struct test_rule *rule)
103 assert(rule->cls_rule.flow.wildcards || rule->cls_rule.flow.priority == UINT_MAX);
104 for (i = 0; i < tcls->n_rules; i++) {
105 const struct cls_rule *pos = &tcls->rules[i]->cls_rule;
106 if (pos->flow.priority == rule->cls_rule.flow.priority
107 && pos->flow.wildcards == rule->cls_rule.flow.wildcards
108 && flow_equal(&pos->flow, &rule->cls_rule.flow)) {
110 * XXX flow_equal should ignore wildcarded fields */
111 free(tcls->rules[i]);
112 tcls->rules[i] = xmemdup(rule, sizeof *rule);
113 return tcls->rules[i];
114 } else if (pos->flow.priority < rule->cls_rule.flow.priority) {
119 if (tcls->n_rules >= tcls->allocated_rules) {
120 tcls->rules = x2nrealloc(tcls->rules, &tcls->allocated_rules,
121 sizeof *tcls->rules);
123 if (i != tcls->n_rules) {
124 memmove(&tcls->rules[i + 1], &tcls->rules[i],
125 sizeof *tcls->rules * (tcls->n_rules - i));
127 tcls->rules[i] = xmemdup(rule, sizeof *rule);
129 return tcls->rules[i];
133 tcls_remove(struct tcls *cls, const struct test_rule *rule)
137 for (i = 0; i < cls->n_rules; i++) {
138 struct test_rule *pos = cls->rules[i];
141 memmove(&cls->rules[i], &cls->rules[i + 1],
142 sizeof *cls->rules * (cls->n_rules - i - 1));
151 read_uint32(const void *p)
154 memcpy(&x, p, sizeof x);
159 match(const struct cls_rule *wild, const flow_t *fixed)
163 for (f_idx = 0; f_idx < CLS_N_FIELDS; f_idx++) {
164 const struct cls_field *f = &cls_fields[f_idx];
165 void *wild_field = (char *) &wild->flow + f->ofs;
166 void *fixed_field = (char *) fixed + f->ofs;
168 if ((wild->flow.wildcards & f->wildcards) == f->wildcards ||
169 !memcmp(wild_field, fixed_field, f->len)) {
170 /* Definite match. */
174 if (wild->flow.wildcards & f->wildcards) {
175 uint32_t test = read_uint32(wild_field);
176 uint32_t ip = read_uint32(fixed_field);
177 int shift = (f_idx == CLS_F_IDX_NW_SRC
178 ? OFPFW_NW_SRC_SHIFT : OFPFW_NW_DST_SHIFT);
179 uint32_t mask = flow_nw_bits_to_mask(wild->flow.wildcards, shift);
180 if (!((test ^ ip) & mask)) {
190 static struct cls_rule *
191 tcls_lookup(const struct tcls *cls, const flow_t *flow, int include)
195 for (i = 0; i < cls->n_rules; i++) {
196 struct test_rule *pos = cls->rules[i];
197 uint32_t wildcards = pos->cls_rule.flow.wildcards;
198 if (include & (wildcards ? CLS_INC_WILD : CLS_INC_EXACT)
199 && match(&pos->cls_rule, flow)) {
200 return &pos->cls_rule;
207 tcls_delete_matches(struct tcls *cls,
208 const struct cls_rule *target,
213 for (i = 0; i < cls->n_rules; ) {
214 struct test_rule *pos = cls->rules[i];
215 uint32_t wildcards = pos->cls_rule.flow.wildcards;
216 if (include & (wildcards ? CLS_INC_WILD : CLS_INC_EXACT)
217 && match(target, &pos->cls_rule.flow)) {
218 tcls_remove(cls, pos);
225 #ifdef WORDS_BIGENDIAN
226 #define T_HTONL(VALUE) ((uint32_t) (VALUE))
227 #define T_HTONS(VALUE) ((uint32_t) (VALUE))
229 #define T_HTONL(VALUE) (((((uint32_t) (VALUE)) & 0x000000ff) << 24) | \
230 ((((uint32_t) (VALUE)) & 0x0000ff00) << 8) | \
231 ((((uint32_t) (VALUE)) & 0x00ff0000) >> 8) | \
232 ((((uint32_t) (VALUE)) & 0xff000000) >> 24))
233 #define T_HTONS(VALUE) (((((uint16_t) (VALUE)) & 0xff00) >> 8) | \
234 ((((uint16_t) (VALUE)) & 0x00ff) << 8))
237 static uint32_t nw_src_values[] = { T_HTONL(0xc0a80001),
238 T_HTONL(0xc0a04455) };
239 static uint32_t nw_dst_values[] = { T_HTONL(0xc0a80002),
240 T_HTONL(0xc0a04455) };
241 static uint32_t tun_id_values[] = { 0, 0xffff0000 };
242 static uint16_t in_port_values[] = { T_HTONS(1), T_HTONS(OFPP_LOCAL) };
243 static uint16_t dl_vlan_values[] = { T_HTONS(101), T_HTONS(0) };
244 static uint8_t dl_vlan_pcp_values[] = { 7, 0 };
245 static uint16_t dl_type_values[]
246 = { T_HTONS(ETH_TYPE_IP), T_HTONS(ETH_TYPE_ARP) };
247 static uint16_t tp_src_values[] = { T_HTONS(49362), T_HTONS(80) };
248 static uint16_t tp_dst_values[] = { T_HTONS(6667), T_HTONS(22) };
249 static uint8_t dl_src_values[][6] = { { 0x00, 0x02, 0xe3, 0x0f, 0x80, 0xa4 },
250 { 0x5e, 0x33, 0x7f, 0x5f, 0x1e, 0x99 } };
251 static uint8_t dl_dst_values[][6] = { { 0x4a, 0x27, 0x71, 0xae, 0x64, 0xc1 },
252 { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff } };
253 static uint8_t nw_proto_values[] = { IP_TYPE_TCP, IP_TYPE_ICMP };
254 static uint8_t nw_tos_values[] = { 49, 0 };
256 static void *values[CLS_N_FIELDS][2];
261 values[CLS_F_IDX_TUN_ID][0] = &tun_id_values[0];
262 values[CLS_F_IDX_TUN_ID][1] = &tun_id_values[1];
264 values[CLS_F_IDX_IN_PORT][0] = &in_port_values[0];
265 values[CLS_F_IDX_IN_PORT][1] = &in_port_values[1];
267 values[CLS_F_IDX_DL_VLAN][0] = &dl_vlan_values[0];
268 values[CLS_F_IDX_DL_VLAN][1] = &dl_vlan_values[1];
270 values[CLS_F_IDX_DL_VLAN_PCP][0] = &dl_vlan_pcp_values[0];
271 values[CLS_F_IDX_DL_VLAN_PCP][1] = &dl_vlan_pcp_values[1];
273 values[CLS_F_IDX_DL_SRC][0] = dl_src_values[0];
274 values[CLS_F_IDX_DL_SRC][1] = dl_src_values[1];
276 values[CLS_F_IDX_DL_DST][0] = dl_dst_values[0];
277 values[CLS_F_IDX_DL_DST][1] = dl_dst_values[1];
279 values[CLS_F_IDX_DL_TYPE][0] = &dl_type_values[0];
280 values[CLS_F_IDX_DL_TYPE][1] = &dl_type_values[1];
282 values[CLS_F_IDX_NW_SRC][0] = &nw_src_values[0];
283 values[CLS_F_IDX_NW_SRC][1] = &nw_src_values[1];
285 values[CLS_F_IDX_NW_DST][0] = &nw_dst_values[0];
286 values[CLS_F_IDX_NW_DST][1] = &nw_dst_values[1];
288 values[CLS_F_IDX_NW_PROTO][0] = &nw_proto_values[0];
289 values[CLS_F_IDX_NW_PROTO][1] = &nw_proto_values[1];
291 values[CLS_F_IDX_NW_TOS][0] = &nw_tos_values[0];
292 values[CLS_F_IDX_NW_TOS][1] = &nw_tos_values[1];
294 values[CLS_F_IDX_TP_SRC][0] = &tp_src_values[0];
295 values[CLS_F_IDX_TP_SRC][1] = &tp_src_values[1];
297 values[CLS_F_IDX_TP_DST][0] = &tp_dst_values[0];
298 values[CLS_F_IDX_TP_DST][1] = &tp_dst_values[1];
301 #define N_NW_SRC_VALUES ARRAY_SIZE(nw_src_values)
302 #define N_NW_DST_VALUES ARRAY_SIZE(nw_dst_values)
303 #define N_TUN_ID_VALUES ARRAY_SIZE(tun_id_values)
304 #define N_IN_PORT_VALUES ARRAY_SIZE(in_port_values)
305 #define N_DL_VLAN_VALUES ARRAY_SIZE(dl_vlan_values)
306 #define N_DL_VLAN_PCP_VALUES ARRAY_SIZE(dl_vlan_pcp_values)
307 #define N_DL_TYPE_VALUES ARRAY_SIZE(dl_type_values)
308 #define N_TP_SRC_VALUES ARRAY_SIZE(tp_src_values)
309 #define N_TP_DST_VALUES ARRAY_SIZE(tp_dst_values)
310 #define N_DL_SRC_VALUES ARRAY_SIZE(dl_src_values)
311 #define N_DL_DST_VALUES ARRAY_SIZE(dl_dst_values)
312 #define N_NW_PROTO_VALUES ARRAY_SIZE(nw_proto_values)
313 #define N_NW_TOS_VALUES ARRAY_SIZE(nw_tos_values)
315 #define N_FLOW_VALUES (N_NW_SRC_VALUES * \
320 N_DL_VLAN_PCP_VALUES * \
326 N_NW_PROTO_VALUES * \
330 get_value(unsigned int *x, unsigned n_values)
332 unsigned int rem = *x % n_values;
337 static struct cls_rule *
338 lookup_with_include_bits(const struct classifier *cls,
339 const flow_t *flow, int include)
343 return classifier_lookup_wild(cls, flow);
345 return classifier_lookup_exact(cls, flow);
346 case CLS_INC_WILD | CLS_INC_EXACT:
347 return classifier_lookup(cls, flow);
354 compare_classifiers(struct classifier *cls, struct tcls *tcls)
356 static const int confidence = 500;
359 assert(classifier_count(cls) == tcls->n_rules);
360 assert(classifier_count_exact(cls) == tcls_count_exact(tcls));
361 for (i = 0; i < confidence; i++) {
362 struct cls_rule *cr0, *cr1;
367 x = rand () % N_FLOW_VALUES;
368 flow.nw_src = nw_src_values[get_value(&x, N_NW_SRC_VALUES)];
369 flow.nw_dst = nw_dst_values[get_value(&x, N_NW_DST_VALUES)];
370 flow.tun_id = tun_id_values[get_value(&x, N_TUN_ID_VALUES)];
371 flow.in_port = in_port_values[get_value(&x, N_IN_PORT_VALUES)];
372 flow.dl_vlan = dl_vlan_values[get_value(&x, N_DL_VLAN_VALUES)];
373 flow.dl_vlan_pcp = dl_vlan_pcp_values[get_value(&x,
374 N_DL_VLAN_PCP_VALUES)];
375 flow.dl_type = dl_type_values[get_value(&x, N_DL_TYPE_VALUES)];
376 flow.tp_src = tp_src_values[get_value(&x, N_TP_SRC_VALUES)];
377 flow.tp_dst = tp_dst_values[get_value(&x, N_TP_DST_VALUES)];
378 memcpy(flow.dl_src, dl_src_values[get_value(&x, N_DL_SRC_VALUES)],
380 memcpy(flow.dl_dst, dl_dst_values[get_value(&x, N_DL_DST_VALUES)],
382 flow.nw_proto = nw_proto_values[get_value(&x, N_NW_PROTO_VALUES)];
383 flow.nw_tos = nw_tos_values[get_value(&x, N_NW_TOS_VALUES)];
385 for (include = 1; include <= 3; include++) {
386 cr0 = lookup_with_include_bits(cls, &flow, include);
387 cr1 = tcls_lookup(tcls, &flow, include);
388 assert((cr0 == NULL) == (cr1 == NULL));
390 const struct test_rule *tr0 = test_rule_from_cls_rule(cr0);
391 const struct test_rule *tr1 = test_rule_from_cls_rule(cr1);
393 assert(flow_equal(&cr0->flow, &cr1->flow));
394 assert(cr0->flow.wildcards == cr1->flow.wildcards);
395 assert(cr0->flow.priority == cr1->flow.priority);
396 /* Skip nw_src_mask, nw_dst_mask, and dl_tci_mask, because they
397 * are derived members used only for optimization. */
398 assert(tr0->aux == tr1->aux);
405 free_rule(struct cls_rule *cls_rule, void *cls)
407 classifier_remove(cls, cls_rule);
408 free(test_rule_from_cls_rule(cls_rule));
412 destroy_classifier(struct classifier *cls)
414 classifier_for_each(cls, CLS_INC_ALL, free_rule, cls);
415 classifier_destroy(cls);
419 check_tables(const struct classifier *cls,
420 int n_tables, int n_buckets, int n_rules)
422 int found_tables = 0;
423 int found_buckets = 0;
427 BUILD_ASSERT(CLS_N_FIELDS == ARRAY_SIZE(cls->tables));
428 for (i = 0; i < CLS_N_FIELDS; i++) {
429 const struct cls_bucket *bucket;
430 if (!hmap_is_empty(&cls->tables[i])) {
433 HMAP_FOR_EACH (bucket, struct cls_bucket, hmap_node, &cls->tables[i]) {
435 assert(!list_is_empty(&bucket->rules));
436 found_rules += list_size(&bucket->rules);
440 if (!hmap_is_empty(&cls->exact_table)) {
443 found_rules += hmap_count(&cls->exact_table);
446 assert(n_tables == -1 || found_tables == n_tables);
447 assert(n_rules == -1 || found_rules == n_rules);
448 assert(n_buckets == -1 || found_buckets == n_buckets);
451 static struct test_rule *
452 make_rule(int wc_fields, unsigned int priority, int value_pat)
454 const struct cls_field *f;
455 struct test_rule *rule;
458 memset(&flow, 0, sizeof flow);
459 flow.priority = priority;
460 for (f = &cls_fields[0]; f < &cls_fields[CLS_N_FIELDS]; f++) {
461 int f_idx = f - cls_fields;
462 if (wc_fields & (1u << f_idx)) {
463 flow.wildcards |= f->wildcards;
465 int value_idx = (value_pat & (1u << f_idx)) != 0;
466 memcpy((char *) &flow + f->ofs, values[f_idx][value_idx], f->len);
470 rule = xzalloc(sizeof *rule);
471 cls_rule_from_flow(&flow, &rule->cls_rule);
476 shuffle(unsigned int *p, size_t n)
478 for (; n > 1; n--, p++) {
479 unsigned int *q = &p[rand() % n];
480 unsigned int tmp = *p;
486 /* Tests an empty classifier. */
488 test_empty(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
490 struct classifier cls;
493 classifier_init(&cls);
495 assert(classifier_is_empty(&cls));
496 assert(tcls_is_empty(&tcls));
497 compare_classifiers(&cls, &tcls);
498 classifier_destroy(&cls);
502 /* Destroys a null classifier. */
504 test_destroy_null(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
506 classifier_destroy(NULL);
509 /* Tests classification with one rule at a time. */
511 test_single_rule(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
513 unsigned int wc_fields; /* Hilarious. */
515 for (wc_fields = 0; wc_fields < (1u << CLS_N_FIELDS); wc_fields++) {
516 struct classifier cls;
517 struct test_rule *rule, *tcls_rule;
520 rule = make_rule(wc_fields,
521 hash_bytes(&wc_fields, sizeof wc_fields, 0), 0);
523 classifier_init(&cls);
526 tcls_rule = tcls_insert(&tcls, rule);
528 assert(!classifier_insert(&cls, &rule->cls_rule));
530 classifier_insert_exact(&cls, &rule->cls_rule);
532 check_tables(&cls, 1, 1, 1);
533 compare_classifiers(&cls, &tcls);
535 classifier_remove(&cls, &rule->cls_rule);
536 tcls_remove(&tcls, tcls_rule);
537 assert(classifier_is_empty(&cls));
538 assert(tcls_is_empty(&tcls));
539 compare_classifiers(&cls, &tcls);
542 classifier_destroy(&cls);
547 /* Tests replacing one rule by another. */
549 test_rule_replacement(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
551 unsigned int wc_fields;
553 for (wc_fields = 0; wc_fields < (1u << CLS_N_FIELDS); wc_fields++) {
554 struct classifier cls;
555 struct test_rule *rule1;
556 struct test_rule *rule2;
559 rule1 = make_rule(wc_fields, OFP_DEFAULT_PRIORITY, UINT_MAX);
560 rule2 = make_rule(wc_fields, OFP_DEFAULT_PRIORITY, UINT_MAX);
564 classifier_init(&cls);
566 tcls_insert(&tcls, rule1);
567 assert(!classifier_insert(&cls, &rule1->cls_rule));
568 check_tables(&cls, 1, 1, 1);
569 compare_classifiers(&cls, &tcls);
573 tcls_insert(&tcls, rule2);
574 assert(test_rule_from_cls_rule(
575 classifier_insert(&cls, &rule2->cls_rule)) == rule1);
577 check_tables(&cls, 1, 1, 1);
578 compare_classifiers(&cls, &tcls);
580 destroy_classifier(&cls);
585 table_mask(int table)
587 return ((1u << CLS_N_FIELDS) - 1) & ~((1u << table) - 1);
591 random_wcf_in_table(int table, int seed)
593 int wc_fields = (1u << table) | hash_int(seed, 0);
594 return wc_fields & table_mask(table);
597 /* Tests classification with two rules at a time that fall into the same
600 test_two_rules_in_one_bucket(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
602 int table, rel_pri, wcf_pat, value_pat;
604 for (table = 0; table <= CLS_N_FIELDS; table++) {
605 for (rel_pri = -1; rel_pri <= +1; rel_pri++) {
606 for (wcf_pat = 0; wcf_pat < 4; wcf_pat++) {
607 int n_value_pats = table == CLS_N_FIELDS - 1 ? 1 : 2;
608 for (value_pat = 0; value_pat < n_value_pats; value_pat++) {
609 struct test_rule *rule1, *tcls_rule1;
610 struct test_rule *rule2, *tcls_rule2;
611 struct test_rule *displaced_rule;
612 struct classifier cls;
614 unsigned int pri1, pri2;
617 if (table != CLS_F_IDX_EXACT) {
618 /* We can use identical priorities in this test because
619 * the classifier always chooses the rule added later
620 * for equal-priority rules that fall into the same
622 pri1 = table * 257 + 50;
623 pri2 = pri1 + rel_pri;
626 ? random_wcf_in_table(table, pri1)
629 ? random_wcf_in_table(table, pri2)
632 wcf1 &= ~(1u << (CLS_N_FIELDS - 1));
633 wcf2 &= ~(1u << (CLS_N_FIELDS - 1));
636 /* This classifier always puts exact-match rules at
637 * maximum priority. */
638 pri1 = pri2 = UINT_MAX;
640 /* No wildcard fields. */
644 rule1 = make_rule(wcf1, pri1, 0);
645 rule2 = make_rule(wcf2, pri2,
646 value_pat << (CLS_N_FIELDS - 1));
648 classifier_init(&cls);
651 tcls_rule1 = tcls_insert(&tcls, rule1);
652 tcls_rule2 = tcls_insert(&tcls, rule2);
653 assert(!classifier_insert(&cls, &rule1->cls_rule));
654 displaced_rule = test_rule_from_cls_rule(
655 classifier_insert(&cls, &rule2->cls_rule));
656 if (wcf1 != wcf2 || pri1 != pri2 || value_pat) {
657 assert(!displaced_rule);
659 check_tables(&cls, 1, 1, 2);
660 compare_classifiers(&cls, &tcls);
662 classifier_remove(&cls, &rule1->cls_rule);
663 tcls_remove(&tcls, tcls_rule1);
664 check_tables(&cls, 1, 1, 1);
665 compare_classifiers(&cls, &tcls);
667 assert(displaced_rule == rule1);
668 check_tables(&cls, 1, 1, 1);
669 compare_classifiers(&cls, &tcls);
673 classifier_remove(&cls, &rule2->cls_rule);
674 tcls_remove(&tcls, tcls_rule2);
675 compare_classifiers(&cls, &tcls);
678 destroy_classifier(&cls);
686 /* Tests classification with two rules at a time that fall into the same
687 * table but different buckets. */
689 test_two_rules_in_one_table(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
691 int table, rel_pri, wcf_pat;
693 /* Skip tables 0 and CLS_F_IDX_EXACT because they have one bucket. */
694 for (table = 1; table < CLS_N_FIELDS; table++) {
695 for (rel_pri = -1; rel_pri <= +1; rel_pri++) {
696 for (wcf_pat = 0; wcf_pat < 5; wcf_pat++) {
697 struct test_rule *rule1, *tcls_rule1;
698 struct test_rule *rule2, *tcls_rule2;
699 struct classifier cls;
701 unsigned int pri1, pri2;
703 int value_mask, value_pat1, value_pat2;
706 /* We can use identical priorities in this test because the
707 * classifier always chooses the rule added later for
708 * equal-priority rules that fall into the same table. */
709 pri1 = table * 257 + 50;
710 pri2 = pri1 + rel_pri;
713 wcf1 = wcf2 = random_wcf_in_table(table, pri1);
716 ? random_wcf_in_table(table, pri1)
719 ? random_wcf_in_table(table, pri2)
723 /* Generate value patterns that will put the two rules into
724 * different buckets. */
725 value_mask = ((1u << table) - 1);
726 value_pat1 = hash_int(pri1, 1) & value_mask;
729 value_pat2 = (hash_int(pri2, i++) & value_mask);
730 } while (value_pat1 == value_pat2);
731 rule1 = make_rule(wcf1, pri1, value_pat1);
732 rule2 = make_rule(wcf2, pri2, value_pat2);
734 classifier_init(&cls);
737 tcls_rule1 = tcls_insert(&tcls, rule1);
738 tcls_rule2 = tcls_insert(&tcls, rule2);
739 assert(!classifier_insert(&cls, &rule1->cls_rule));
740 assert(!classifier_insert(&cls, &rule2->cls_rule));
741 check_tables(&cls, 1, 2, 2);
742 compare_classifiers(&cls, &tcls);
744 classifier_remove(&cls, &rule1->cls_rule);
745 tcls_remove(&tcls, tcls_rule1);
746 check_tables(&cls, 1, 1, 1);
747 compare_classifiers(&cls, &tcls);
750 classifier_remove(&cls, &rule2->cls_rule);
751 tcls_remove(&tcls, tcls_rule2);
752 compare_classifiers(&cls, &tcls);
755 classifier_destroy(&cls);
762 /* Tests classification with two rules at a time that fall into different
765 test_two_rules_in_different_tables(int argc OVS_UNUSED,
766 char *argv[] OVS_UNUSED)
768 int table1, table2, rel_pri, wcf_pat;
770 for (table1 = 0; table1 < CLS_N_FIELDS; table1++) {
771 for (table2 = table1 + 1; table2 <= CLS_N_FIELDS; table2++) {
772 for (rel_pri = 0; rel_pri < 2; rel_pri++) {
773 for (wcf_pat = 0; wcf_pat < 4; wcf_pat++) {
774 struct test_rule *rule1, *tcls_rule1;
775 struct test_rule *rule2, *tcls_rule2;
776 struct classifier cls;
778 unsigned int pri1, pri2;
781 /* We must use unique priorities in this test because the
782 * classifier makes the rule choice undefined for rules of
783 * equal priority that fall into different tables. (In
784 * practice, lower-numbered tables win.) */
785 pri1 = table1 * 257 + 50;
786 pri2 = rel_pri ? pri1 - 1 : pri1 + 1;
789 ? random_wcf_in_table(table1, pri1)
792 ? random_wcf_in_table(table2, pri2)
795 if (table2 == CLS_F_IDX_EXACT) {
800 rule1 = make_rule(wcf1, pri1, 0);
801 rule2 = make_rule(wcf2, pri2, 0);
803 classifier_init(&cls);
806 tcls_rule1 = tcls_insert(&tcls, rule1);
807 tcls_rule2 = tcls_insert(&tcls, rule2);
808 assert(!classifier_insert(&cls, &rule1->cls_rule));
809 assert(!classifier_insert(&cls, &rule2->cls_rule));
810 check_tables(&cls, 2, 2, 2);
811 compare_classifiers(&cls, &tcls);
813 classifier_remove(&cls, &rule1->cls_rule);
814 tcls_remove(&tcls, tcls_rule1);
815 check_tables(&cls, 1, 1, 1);
816 compare_classifiers(&cls, &tcls);
819 classifier_remove(&cls, &rule2->cls_rule);
820 tcls_remove(&tcls, tcls_rule2);
821 compare_classifiers(&cls, &tcls);
824 classifier_destroy(&cls);
832 /* Tests classification with many rules at a time that fall into the same
833 * bucket but have unique priorities (and various wildcards). */
835 test_many_rules_in_one_bucket(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
837 enum { MAX_RULES = 50 };
838 int iteration, table;
840 for (iteration = 0; iteration < 3; iteration++) {
841 for (table = 0; table <= CLS_N_FIELDS; table++) {
842 unsigned int priorities[MAX_RULES];
843 struct classifier cls;
847 srand(hash_int(table, iteration));
848 for (i = 0; i < MAX_RULES; i++) {
849 priorities[i] = i * 129;
851 shuffle(priorities, ARRAY_SIZE(priorities));
853 classifier_init(&cls);
856 for (i = 0; i < MAX_RULES; i++) {
857 struct test_rule *rule;
858 unsigned int priority = priorities[i];
861 wcf = random_wcf_in_table(table, priority);
862 rule = make_rule(wcf, priority,
863 table == CLS_F_IDX_EXACT ? i : 1234);
864 tcls_insert(&tcls, rule);
865 assert(!classifier_insert(&cls, &rule->cls_rule));
866 check_tables(&cls, 1, 1, i + 1);
867 compare_classifiers(&cls, &tcls);
870 destroy_classifier(&cls);
876 /* Tests classification with many rules at a time that fall into the same
877 * table but random buckets. */
879 test_many_rules_in_one_table(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
881 enum { MAX_RULES = 50 };
882 int iteration, table;
884 for (iteration = 0; iteration < 3; iteration++) {
885 for (table = 0; table < CLS_N_FIELDS; table++) {
886 unsigned int priorities[MAX_RULES];
887 struct classifier cls;
891 srand(hash_int(table, iteration));
892 for (i = 0; i < MAX_RULES; i++) {
893 priorities[i] = i * 129;
895 shuffle(priorities, ARRAY_SIZE(priorities));
897 classifier_init(&cls);
900 for (i = 0; i < MAX_RULES; i++) {
901 struct test_rule *rule;
902 unsigned int priority = priorities[i];
905 wcf = random_wcf_in_table(table, priority);
906 rule = make_rule(wcf, priority, hash_int(priority, 1));
907 tcls_insert(&tcls, rule);
908 assert(!classifier_insert(&cls, &rule->cls_rule));
909 check_tables(&cls, 1, -1, i + 1);
910 compare_classifiers(&cls, &tcls);
913 destroy_classifier(&cls);
919 /* Tests classification with many rules at a time that fall into random buckets
920 * in random tables. */
922 test_many_rules_in_different_tables(int argc OVS_UNUSED,
923 char *argv[] OVS_UNUSED)
925 enum { MAX_RULES = 50 };
928 for (iteration = 0; iteration < 30; iteration++) {
929 unsigned int priorities[MAX_RULES];
930 struct classifier cls;
935 for (i = 0; i < MAX_RULES; i++) {
936 priorities[i] = i * 129;
938 shuffle(priorities, ARRAY_SIZE(priorities));
940 classifier_init(&cls);
943 for (i = 0; i < MAX_RULES; i++) {
944 struct test_rule *rule;
945 unsigned int priority = priorities[i];
946 int table = rand() % (CLS_N_FIELDS + 1);
947 int wcf = random_wcf_in_table(table, rand());
948 int value_pat = rand() & ((1u << CLS_N_FIELDS) - 1);
949 rule = make_rule(wcf, priority, value_pat);
950 tcls_insert(&tcls, rule);
951 assert(!classifier_insert(&cls, &rule->cls_rule));
952 check_tables(&cls, -1, -1, i + 1);
953 compare_classifiers(&cls, &tcls);
956 while (!classifier_is_empty(&cls)) {
957 struct test_rule *rule = xmemdup(tcls.rules[rand() % tcls.n_rules],
958 sizeof(struct test_rule));
959 int include = rand() % 2 ? CLS_INC_WILD : CLS_INC_EXACT;
960 include |= (rule->cls_rule.flow.wildcards
961 ? CLS_INC_WILD : CLS_INC_EXACT);
962 classifier_for_each_match(&cls, &rule->cls_rule.flow, include,
964 tcls_delete_matches(&tcls, &rule->cls_rule, include);
965 compare_classifiers(&cls, &tcls);
969 destroy_classifier(&cls);
975 main(int argc, char *argv[])
977 static const struct command all_commands[] = {
978 { "empty", 0, 0, test_empty },
979 { "destroy-null", 0, 0, test_destroy_null },
980 { "single-rule", 0, 0, test_single_rule },
981 { "rule-replacement", 0, 0, test_rule_replacement },
982 { "two-rules-in-one-bucket", 0, 0, test_two_rules_in_one_bucket },
983 { "two-rules-in-one-table", 0, 0, test_two_rules_in_one_table },
984 { "two-rules-in-different-tables", 0, 0,
985 test_two_rules_in_different_tables },
986 { "many-rules-in-one-bucket", 0, 0,
987 test_many_rules_in_one_bucket },
988 { "many-rules-in-one-table", 0, 0, test_many_rules_in_one_table },
989 { "many-rules-in-different-tables", 0, 0,
990 test_many_rules_in_different_tables },
991 { NULL, 0, 0, NULL },
994 set_program_name(argv[0]);
996 parse_test_options(argc, argv, all_commands);
997 run_command(argc - 1, argv + 1, all_commands);