2 * Copyright (c) 2009, 2010, 2011, 2012, 2013 Nicira, Inc.
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at:
8 * http://www.apache.org/licenses/LICENSE-2.0
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
30 #include "command-line.h"
33 #include "dynamic-string.h"
36 #include "ovsdb-data.h"
37 #include "ovsdb-idl.h"
38 #include "poll-loop.h"
41 #include "stream-ssl.h"
45 #include "lib/vswitch-idl.h"
52 VLOG_DEFINE_THIS_MODULE(vsctl);
54 /* vsctl_fatal() also logs the error, so it is preferred in this file. */
55 #define ovs_fatal please_use_vsctl_fatal_instead_of_ovs_fatal
59 /* A command supported by ovs-vsctl. */
60 struct vsctl_command_syntax {
61 const char *name; /* e.g. "add-br" */
62 int min_args; /* Min number of arguments following name. */
63 int max_args; /* Max number of arguments following name. */
65 /* If nonnull, calls ovsdb_idl_add_column() or ovsdb_idl_add_table() for
66 * each column or table in ctx->idl that it uses. */
67 void (*prerequisites)(struct vsctl_context *ctx);
69 /* Does the actual work of the command and puts the command's output, if
70 * any, in ctx->output or ctx->table.
72 * Alternatively, if some prerequisite of the command is not met and the
73 * caller should wait for something to change and then retry, it may set
74 * ctx->try_again to true. (Only the "wait-until" command currently does
76 void (*run)(struct vsctl_context *ctx);
78 /* If nonnull, called after the transaction has been successfully
79 * committed. ctx->output is the output from the "run" function, which
80 * this function may modify and otherwise postprocess as needed. (Only the
81 * "create" command currently does any postprocessing.) */
82 void (*postprocess)(struct vsctl_context *ctx);
84 /* A comma-separated list of supported options, e.g. "--a,--b", or the
85 * empty string if the command does not support any options. */
87 enum { RO, RW } mode; /* Does this command modify the database? */
90 struct vsctl_command {
91 /* Data that remains constant after initialization. */
92 const struct vsctl_command_syntax *syntax;
97 /* Data modified by commands. */
102 /* --db: The database server to contact. */
103 static const char *db;
105 /* --oneline: Write each command's output as a single line? */
108 /* --dry-run: Do not commit any changes. */
111 /* --no-wait: Wait for ovs-vswitchd to reload its configuration? */
112 static bool wait_for_reload = true;
114 /* --timeout: Time to wait for a connection to 'db'. */
117 /* --retry: If true, ovs-vsctl will retry connecting to the database forever.
118 * If false and --db says to use an active connection method (e.g. "unix:",
119 * "tcp:", "ssl:"), then ovs-vsctl will try to connect once and exit with an
120 * error if the database server cannot be contacted (e.g. ovsdb-server is not
123 * Regardless of this setting, --timeout always limits how long ovs-vsctl will
127 /* Format for table output. */
128 static struct table_style table_style = TABLE_STYLE_DEFAULT;
130 /* All supported commands. */
131 static const struct vsctl_command_syntax *get_all_commands(void);
133 /* The IDL we're using and the current transaction, if any.
134 * This is for use by vsctl_exit() only, to allow it to clean up.
135 * Other code should use its context arguments. */
136 static struct ovsdb_idl *the_idl;
137 static struct ovsdb_idl_txn *the_idl_txn;
139 static void vsctl_exit(int status) NO_RETURN;
140 static void vsctl_fatal(const char *, ...) PRINTF_FORMAT(1, 2) NO_RETURN;
141 static char *default_db(void);
142 static void usage(void) NO_RETURN;
143 static void parse_options(int argc, char *argv[], struct shash *local_options);
144 static bool might_write_to_db(char **argv);
146 static struct vsctl_command *parse_commands(int argc, char *argv[],
147 struct shash *local_options,
148 size_t *n_commandsp);
149 static void parse_command(int argc, char *argv[], struct shash *local_options,
150 struct vsctl_command *);
151 static const struct vsctl_command_syntax *find_command(const char *name);
152 static void run_prerequisites(struct vsctl_command[], size_t n_commands,
154 static void do_vsctl(const char *args, struct vsctl_command *, size_t n,
157 static const struct vsctl_table_class *get_table(const char *table_name);
158 static void set_column(const struct vsctl_table_class *,
159 const struct ovsdb_idl_row *, const char *arg,
160 struct ovsdb_symbol_table *);
162 static bool is_condition_satisfied(const struct vsctl_table_class *,
163 const struct ovsdb_idl_row *,
165 struct ovsdb_symbol_table *);
168 main(int argc, char *argv[])
170 extern struct vlog_module VLM_reconnect;
171 struct ovsdb_idl *idl;
172 struct vsctl_command *commands;
173 struct shash local_options;
178 set_program_name(argv[0]);
179 signal(SIGPIPE, SIG_IGN);
180 vlog_set_levels(NULL, VLF_CONSOLE, VLL_WARN);
181 vlog_set_levels(&VLM_reconnect, VLF_ANY_FACILITY, VLL_WARN);
184 /* Log our arguments. This is often valuable for debugging systems. */
185 args = process_escape_args(argv);
186 VLOG(might_write_to_db(argv) ? VLL_INFO : VLL_DBG, "Called as %s", args);
188 /* Parse command line. */
189 shash_init(&local_options);
190 parse_options(argc, argv, &local_options);
191 commands = parse_commands(argc - optind, argv + optind, &local_options,
198 /* Initialize IDL. */
199 idl = the_idl = ovsdb_idl_create(db, &ovsrec_idl_class, false, retry);
200 run_prerequisites(commands, n_commands, idl);
202 /* Execute the commands.
204 * 'seqno' is the database sequence number for which we last tried to
205 * execute our transaction. There's no point in trying to commit more than
206 * once for any given sequence number, because if the transaction fails
207 * it's because the database changed and we need to obtain an up-to-date
208 * view of the database before we try the transaction again. */
209 seqno = ovsdb_idl_get_seqno(idl);
212 if (!ovsdb_idl_is_alive(idl)) {
213 int retval = ovsdb_idl_get_last_error(idl);
214 vsctl_fatal("%s: database connection failed (%s)",
215 db, ovs_retval_to_string(retval));
218 if (seqno != ovsdb_idl_get_seqno(idl)) {
219 seqno = ovsdb_idl_get_seqno(idl);
220 do_vsctl(args, commands, n_commands, idl);
223 if (seqno == ovsdb_idl_get_seqno(idl)) {
230 static struct option *
231 find_option(const char *name, struct option *options, size_t n_options)
235 for (i = 0; i < n_options; i++) {
236 if (!strcmp(options[i].name, name)) {
243 static struct option *
244 add_option(struct option **optionsp, size_t *n_optionsp,
245 size_t *allocated_optionsp)
247 if (*n_optionsp >= *allocated_optionsp) {
248 *optionsp = x2nrealloc(*optionsp, allocated_optionsp,
251 return &(*optionsp)[(*n_optionsp)++];
255 parse_options(int argc, char *argv[], struct shash *local_options)
258 OPT_DB = UCHAR_MAX + 1,
269 static const struct option global_long_options[] = {
270 {"db", required_argument, NULL, OPT_DB},
271 {"no-syslog", no_argument, NULL, OPT_NO_SYSLOG},
272 {"no-wait", no_argument, NULL, OPT_NO_WAIT},
273 {"dry-run", no_argument, NULL, OPT_DRY_RUN},
274 {"oneline", no_argument, NULL, OPT_ONELINE},
275 {"timeout", required_argument, NULL, 't'},
276 {"retry", no_argument, NULL, OPT_RETRY},
277 {"help", no_argument, NULL, 'h'},
278 {"version", no_argument, NULL, 'V'},
281 STREAM_SSL_LONG_OPTIONS,
282 {"peer-ca-cert", required_argument, NULL, OPT_PEER_CA_CERT},
285 const int n_global_long_options = ARRAY_SIZE(global_long_options) - 1;
286 char *tmp, *short_options;
288 const struct vsctl_command_syntax *p;
289 struct option *options, *o;
290 size_t allocated_options;
294 tmp = long_options_to_short_options(global_long_options);
295 short_options = xasprintf("+%s", tmp);
298 /* We want to parse both global and command-specific options here, but
299 * getopt_long() isn't too convenient for the job. We copy our global
300 * options into a dynamic array, then append all of the command-specific
302 options = xmemdup(global_long_options, sizeof global_long_options);
303 allocated_options = ARRAY_SIZE(global_long_options);
304 n_options = n_global_long_options;
305 for (p = get_all_commands(); p->name; p++) {
307 char *save_ptr = NULL;
311 s = xstrdup(p->options);
312 for (name = strtok_r(s, ",", &save_ptr); name != NULL;
313 name = strtok_r(NULL, ",", &save_ptr)) {
317 ovs_assert(name[0] == '-' && name[1] == '-' && name[2]);
320 equals = strchr(name, '=');
322 has_arg = required_argument;
325 has_arg = no_argument;
328 o = find_option(name, options, n_options);
330 ovs_assert(o - options >= n_global_long_options);
331 ovs_assert(o->has_arg == has_arg);
333 o = add_option(&options, &n_options, &allocated_options);
334 o->name = xstrdup(name);
335 o->has_arg = has_arg;
344 o = add_option(&options, &n_options, &allocated_options);
345 memset(o, 0, sizeof *o);
347 table_style.format = TF_LIST;
353 c = getopt_long(argc, argv, short_options, options, &idx);
368 vlog_set_levels(&VLM_vsctl, VLF_SYSLOG, VLL_WARN);
372 wait_for_reload = false;
380 if (shash_find(local_options, options[idx].name)) {
381 vsctl_fatal("'%s' option specified multiple times",
384 shash_add_nocopy(local_options,
385 xasprintf("--%s", options[idx].name),
386 optarg ? xstrdup(optarg) : NULL);
393 ovs_print_version(0, 0);
397 timeout = strtoul(optarg, NULL, 10);
399 vsctl_fatal("value %s on -t or --timeout is invalid",
409 TABLE_OPTION_HANDLERS(&table_style)
411 STREAM_SSL_OPTION_HANDLERS
413 case OPT_PEER_CA_CERT:
414 stream_ssl_set_peer_ca_cert_file(optarg);
430 for (i = n_global_long_options; options[i].name; i++) {
431 free(CONST_CAST(char *, options[i].name));
436 static struct vsctl_command *
437 parse_commands(int argc, char *argv[], struct shash *local_options,
440 struct vsctl_command *commands;
441 size_t n_commands, allocated_commands;
445 n_commands = allocated_commands = 0;
447 for (start = i = 0; i <= argc; i++) {
448 if (i == argc || !strcmp(argv[i], "--")) {
450 if (n_commands >= allocated_commands) {
451 struct vsctl_command *c;
453 commands = x2nrealloc(commands, &allocated_commands,
455 for (c = commands; c < &commands[n_commands]; c++) {
456 shash_moved(&c->options);
459 parse_command(i - start, &argv[start], local_options,
460 &commands[n_commands++]);
461 } else if (!shash_is_empty(local_options)) {
462 vsctl_fatal("missing command name (use --help for help)");
468 vsctl_fatal("missing command name (use --help for help)");
470 *n_commandsp = n_commands;
475 parse_command(int argc, char *argv[], struct shash *local_options,
476 struct vsctl_command *command)
478 const struct vsctl_command_syntax *p;
479 struct shash_node *node;
483 shash_init(&command->options);
484 shash_swap(local_options, &command->options);
485 for (i = 0; i < argc; i++) {
486 const char *option = argv[i];
490 if (option[0] != '-') {
494 equals = strchr(option, '=');
496 key = xmemdup0(option, equals - option);
497 value = xstrdup(equals + 1);
499 key = xstrdup(option);
503 if (shash_find(&command->options, key)) {
504 vsctl_fatal("'%s' option specified multiple times", argv[i]);
506 shash_add_nocopy(&command->options, key, value);
509 vsctl_fatal("missing command name (use --help for help)");
512 p = find_command(argv[i]);
514 vsctl_fatal("unknown command '%s'; use --help for help", argv[i]);
517 SHASH_FOR_EACH (node, &command->options) {
518 const char *s = strstr(p->options, node->name);
519 int end = s ? s[strlen(node->name)] : EOF;
521 if (end != '=' && end != ',' && end != ' ' && end != '\0') {
522 vsctl_fatal("'%s' command has no '%s' option",
523 argv[i], node->name);
525 if ((end == '=') != (node->data != NULL)) {
527 vsctl_fatal("missing argument to '%s' option on '%s' "
528 "command", node->name, argv[i]);
530 vsctl_fatal("'%s' option on '%s' does not accept an "
531 "argument", node->name, argv[i]);
536 n_arg = argc - i - 1;
537 if (n_arg < p->min_args) {
538 vsctl_fatal("'%s' command requires at least %d arguments",
539 p->name, p->min_args);
540 } else if (n_arg > p->max_args) {
543 for (j = i + 1; j < argc; j++) {
544 if (argv[j][0] == '-') {
545 vsctl_fatal("'%s' command takes at most %d arguments "
546 "(note that options must precede command "
547 "names and follow a \"--\" argument)",
548 p->name, p->max_args);
552 vsctl_fatal("'%s' command takes at most %d arguments",
553 p->name, p->max_args);
557 command->argc = n_arg + 1;
558 command->argv = &argv[i];
561 /* Returns the "struct vsctl_command_syntax" for a given command 'name', or a
562 * null pointer if there is none. */
563 static const struct vsctl_command_syntax *
564 find_command(const char *name)
566 static struct shash commands = SHASH_INITIALIZER(&commands);
568 if (shash_is_empty(&commands)) {
569 const struct vsctl_command_syntax *p;
571 for (p = get_all_commands(); p->name; p++) {
572 shash_add_assert(&commands, p->name, p);
576 return shash_find_data(&commands, name);
580 vsctl_fatal(const char *format, ...)
585 va_start(args, format);
586 message = xvasprintf(format, args);
589 vlog_set_levels(&VLM_vsctl, VLF_CONSOLE, VLL_OFF);
590 VLOG_ERR("%s", message);
591 ovs_error(0, "%s", message);
592 vsctl_exit(EXIT_FAILURE);
595 /* Frees the current transaction and the underlying IDL and then calls
598 * Freeing the transaction and the IDL is not strictly necessary, but it makes
599 * for a clean memory leak report from valgrind in the normal case. That makes
600 * it easier to notice real memory leaks. */
602 vsctl_exit(int status)
605 ovsdb_idl_txn_abort(the_idl_txn);
606 ovsdb_idl_txn_destroy(the_idl_txn);
608 ovsdb_idl_destroy(the_idl);
616 %s: ovs-vswitchd management utility\n\
617 usage: %s [OPTIONS] COMMAND [ARG...]\n\
619 Open vSwitch commands:\n\
620 init initialize database, if not yet initialized\n\
621 show print overview of database contents\n\
622 emer-reset reset configuration to clean state\n\
625 add-br BRIDGE create a new bridge named BRIDGE\n\
626 add-br BRIDGE PARENT VLAN create new fake BRIDGE in PARENT on VLAN\n\
627 del-br BRIDGE delete BRIDGE and all of its ports\n\
628 list-br print the names of all the bridges\n\
629 br-exists BRIDGE exit 2 if BRIDGE does not exist\n\
630 br-to-vlan BRIDGE print the VLAN which BRIDGE is on\n\
631 br-to-parent BRIDGE print the parent of BRIDGE\n\
632 br-set-external-id BRIDGE KEY VALUE set KEY on BRIDGE to VALUE\n\
633 br-set-external-id BRIDGE KEY unset KEY on BRIDGE\n\
634 br-get-external-id BRIDGE KEY print value of KEY on BRIDGE\n\
635 br-get-external-id BRIDGE list key-value pairs on BRIDGE\n\
637 Port commands (a bond is considered to be a single port):\n\
638 list-ports BRIDGE print the names of all the ports on BRIDGE\n\
639 add-port BRIDGE PORT add network device PORT to BRIDGE\n\
640 add-bond BRIDGE PORT IFACE... add bonded port PORT in BRIDGE from IFACES\n\
641 del-port [BRIDGE] PORT delete PORT (which may be bonded) from BRIDGE\n\
642 port-to-br PORT print name of bridge that contains PORT\n\
644 Interface commands (a bond consists of multiple interfaces):\n\
645 list-ifaces BRIDGE print the names of all interfaces on BRIDGE\n\
646 iface-to-br IFACE print name of bridge that contains IFACE\n\
648 Controller commands:\n\
649 get-controller BRIDGE print the controllers for BRIDGE\n\
650 del-controller BRIDGE delete the controllers for BRIDGE\n\
651 set-controller BRIDGE TARGET... set the controllers for BRIDGE\n\
652 get-fail-mode BRIDGE print the fail-mode for BRIDGE\n\
653 del-fail-mode BRIDGE delete the fail-mode for BRIDGE\n\
654 set-fail-mode BRIDGE MODE set the fail-mode for BRIDGE to MODE\n\
657 get-manager print the managers\n\
658 del-manager delete the managers\n\
659 set-manager TARGET... set the list of managers to TARGET...\n\
662 get-ssl print the SSL configuration\n\
663 del-ssl delete the SSL configuration\n\
664 set-ssl PRIV-KEY CERT CA-CERT set the SSL configuration\n\
667 emer-reset reset switch to known good state\n\
669 Database commands:\n\
670 list TBL [REC] list RECord (or all records) in TBL\n\
671 find TBL CONDITION... list records satisfying CONDITION in TBL\n\
672 get TBL REC COL[:KEY] print values of COLumns in RECord in TBL\n\
673 set TBL REC COL[:KEY]=VALUE set COLumn values in RECord in TBL\n\
674 add TBL REC COL [KEY=]VALUE add (KEY=)VALUE to COLumn in RECord in TBL\n\
675 remove TBL REC COL [KEY=]VALUE remove (KEY=)VALUE from COLumn\n\
676 clear TBL REC COL clear values from COLumn in RECord in TBL\n\
677 create TBL COL[:KEY]=VALUE create and initialize new record\n\
678 destroy TBL REC delete RECord from TBL\n\
679 wait-until TBL REC [COL[:KEY]=VALUE] wait until condition is true\n\
680 Potentially unsafe database commands require --force option.\n\
683 --db=DATABASE connect to DATABASE\n\
685 --no-wait do not wait for ovs-vswitchd to reconfigure\n\
686 --retry keep trying to connect to server forever\n\
687 -t, --timeout=SECS wait at most SECS seconds for ovs-vswitchd\n\
688 --dry-run do not commit changes to database\n\
689 --oneline print exactly one line of output per command\n",
690 program_name, program_name, default_db());
693 --no-syslog equivalent to --verbose=vsctl:syslog:warn\n");
694 stream_usage("database", true, true, false);
697 -h, --help display this help message\n\
698 -V, --version display version information\n");
707 def = xasprintf("unix:%s/db.sock", ovs_rundir());
712 /* Returns true if it looks like this set of arguments might modify the
713 * database, otherwise false. (Not very smart, so it's prone to false
716 might_write_to_db(char **argv)
718 for (; *argv; argv++) {
719 const struct vsctl_command_syntax *p = find_command(*argv);
720 if (p && p->mode == RW) {
727 struct vsctl_context {
731 struct shash options;
733 /* Modifiable state. */
736 struct ovsdb_idl *idl;
737 struct ovsdb_idl_txn *txn;
738 struct ovsdb_symbol_table *symtab;
739 const struct ovsrec_open_vswitch *ovs;
742 /* A cache of the contents of the database.
744 * A command that needs to use any of this information must first call
745 * vsctl_context_populate_cache(). A command that changes anything that
746 * could invalidate the cache must either call
747 * vsctl_context_invalidate_cache() or manually update the cache to
748 * maintain its correctness. */
750 struct shash bridges; /* Maps from bridge name to struct vsctl_bridge. */
751 struct shash ports; /* Maps from port name to struct vsctl_port. */
752 struct shash ifaces; /* Maps from port name to struct vsctl_iface. */
754 /* A command may set this member to true if some prerequisite is not met
755 * and the caller should wait for something to change and then retry. */
759 struct vsctl_bridge {
760 struct ovsrec_bridge *br_cfg;
762 struct list ports; /* Contains "struct vsctl_port"s. */
764 /* VLAN ("fake") bridge support.
766 * Use 'parent != NULL' to detect a fake bridge, because 'vlan' can be 0
768 struct hmap children; /* VLAN bridges indexed by 'vlan'. */
769 struct hmap_node children_node; /* Node in parent's 'children' hmap. */
770 struct vsctl_bridge *parent; /* Real bridge, or NULL. */
771 int vlan; /* VLAN VID (0...4095), or 0. */
775 struct list ports_node; /* In struct vsctl_bridge's 'ports' list. */
776 struct list ifaces; /* Contains "struct vsctl_iface"s. */
777 struct ovsrec_port *port_cfg;
778 struct vsctl_bridge *bridge;
782 struct list ifaces_node; /* In struct vsctl_port's 'ifaces' list. */
783 struct ovsrec_interface *iface_cfg;
784 struct vsctl_port *port;
788 vsctl_context_to_string(const struct vsctl_context *ctx)
790 const struct shash_node *node;
796 SHASH_FOR_EACH (node, &ctx->options) {
797 svec_add(&words, node->name);
799 for (i = 0; i < ctx->argc; i++) {
800 svec_add(&words, ctx->argv[i]);
802 svec_terminate(&words);
804 s = process_escape_args(words.names);
806 svec_destroy(&words);
812 verify_ports(struct vsctl_context *ctx)
814 if (!ctx->verified_ports) {
815 const struct ovsrec_bridge *bridge;
816 const struct ovsrec_port *port;
818 ovsrec_open_vswitch_verify_bridges(ctx->ovs);
819 OVSREC_BRIDGE_FOR_EACH (bridge, ctx->idl) {
820 ovsrec_bridge_verify_ports(bridge);
822 OVSREC_PORT_FOR_EACH (port, ctx->idl) {
823 ovsrec_port_verify_interfaces(port);
826 ctx->verified_ports = true;
830 static struct vsctl_bridge *
831 add_bridge_to_cache(struct vsctl_context *ctx,
832 struct ovsrec_bridge *br_cfg, const char *name,
833 struct vsctl_bridge *parent, int vlan)
835 struct vsctl_bridge *br = xmalloc(sizeof *br);
837 br->name = xstrdup(name);
838 list_init(&br->ports);
841 hmap_init(&br->children);
843 hmap_insert(&parent->children, &br->children_node, hash_int(vlan, 0));
845 shash_add(&ctx->bridges, br->name, br);
850 ovs_delete_bridge(const struct ovsrec_open_vswitch *ovs,
851 struct ovsrec_bridge *bridge)
853 struct ovsrec_bridge **bridges;
856 bridges = xmalloc(sizeof *ovs->bridges * ovs->n_bridges);
857 for (i = n = 0; i < ovs->n_bridges; i++) {
858 if (ovs->bridges[i] != bridge) {
859 bridges[n++] = ovs->bridges[i];
862 ovsrec_open_vswitch_set_bridges(ovs, bridges, n);
867 del_cached_bridge(struct vsctl_context *ctx, struct vsctl_bridge *br)
869 ovs_assert(list_is_empty(&br->ports));
870 ovs_assert(hmap_is_empty(&br->children));
872 hmap_remove(&br->parent->children, &br->children_node);
875 ovsrec_bridge_delete(br->br_cfg);
876 ovs_delete_bridge(ctx->ovs, br->br_cfg);
878 shash_find_and_delete(&ctx->bridges, br->name);
879 hmap_destroy(&br->children);
885 port_is_fake_bridge(const struct ovsrec_port *port_cfg)
887 return (port_cfg->fake_bridge
889 && *port_cfg->tag >= 0 && *port_cfg->tag <= 4095);
892 static struct vsctl_bridge *
893 find_vlan_bridge(struct vsctl_bridge *parent, int vlan)
895 struct vsctl_bridge *child;
897 HMAP_FOR_EACH_IN_BUCKET (child, children_node, hash_int(vlan, 0),
899 if (child->vlan == vlan) {
907 static struct vsctl_port *
908 add_port_to_cache(struct vsctl_context *ctx, struct vsctl_bridge *parent,
909 struct ovsrec_port *port_cfg)
911 struct vsctl_port *port;
914 && *port_cfg->tag >= 0 && *port_cfg->tag <= 4095) {
915 struct vsctl_bridge *vlan_bridge;
917 vlan_bridge = find_vlan_bridge(parent, *port_cfg->tag);
919 parent = vlan_bridge;
923 port = xmalloc(sizeof *port);
924 list_push_back(&parent->ports, &port->ports_node);
925 list_init(&port->ifaces);
926 port->port_cfg = port_cfg;
927 port->bridge = parent;
928 shash_add(&ctx->ports, port_cfg->name, port);
934 del_cached_port(struct vsctl_context *ctx, struct vsctl_port *port)
936 ovs_assert(list_is_empty(&port->ifaces));
937 list_remove(&port->ports_node);
938 shash_find_and_delete(&ctx->ports, port->port_cfg->name);
939 ovsrec_port_delete(port->port_cfg);
943 static struct vsctl_iface *
944 add_iface_to_cache(struct vsctl_context *ctx, struct vsctl_port *parent,
945 struct ovsrec_interface *iface_cfg)
947 struct vsctl_iface *iface;
949 iface = xmalloc(sizeof *iface);
950 list_push_back(&parent->ifaces, &iface->ifaces_node);
951 iface->iface_cfg = iface_cfg;
952 iface->port = parent;
953 shash_add(&ctx->ifaces, iface_cfg->name, iface);
959 del_cached_iface(struct vsctl_context *ctx, struct vsctl_iface *iface)
961 list_remove(&iface->ifaces_node);
962 shash_find_and_delete(&ctx->ifaces, iface->iface_cfg->name);
963 ovsrec_interface_delete(iface->iface_cfg);
968 vsctl_context_invalidate_cache(struct vsctl_context *ctx)
970 struct shash_node *node;
972 if (!ctx->cache_valid) {
975 ctx->cache_valid = false;
977 SHASH_FOR_EACH (node, &ctx->bridges) {
978 struct vsctl_bridge *bridge = node->data;
979 hmap_destroy(&bridge->children);
983 shash_destroy(&ctx->bridges);
985 shash_destroy_free_data(&ctx->ports);
986 shash_destroy_free_data(&ctx->ifaces);
990 pre_get_info(struct vsctl_context *ctx)
992 ovsdb_idl_add_column(ctx->idl, &ovsrec_open_vswitch_col_bridges);
994 ovsdb_idl_add_column(ctx->idl, &ovsrec_bridge_col_name);
995 ovsdb_idl_add_column(ctx->idl, &ovsrec_bridge_col_controller);
996 ovsdb_idl_add_column(ctx->idl, &ovsrec_bridge_col_fail_mode);
997 ovsdb_idl_add_column(ctx->idl, &ovsrec_bridge_col_ports);
999 ovsdb_idl_add_column(ctx->idl, &ovsrec_port_col_name);
1000 ovsdb_idl_add_column(ctx->idl, &ovsrec_port_col_fake_bridge);
1001 ovsdb_idl_add_column(ctx->idl, &ovsrec_port_col_tag);
1002 ovsdb_idl_add_column(ctx->idl, &ovsrec_port_col_interfaces);
1004 ovsdb_idl_add_column(ctx->idl, &ovsrec_interface_col_name);
1008 vsctl_context_populate_cache(struct vsctl_context *ctx)
1010 const struct ovsrec_open_vswitch *ovs = ctx->ovs;
1011 struct sset bridges, ports;
1014 if (ctx->cache_valid) {
1015 /* Cache is already populated. */
1018 ctx->cache_valid = true;
1019 shash_init(&ctx->bridges);
1020 shash_init(&ctx->ports);
1021 shash_init(&ctx->ifaces);
1023 sset_init(&bridges);
1025 for (i = 0; i < ovs->n_bridges; i++) {
1026 struct ovsrec_bridge *br_cfg = ovs->bridges[i];
1027 struct vsctl_bridge *br;
1030 if (!sset_add(&bridges, br_cfg->name)) {
1031 VLOG_WARN("%s: database contains duplicate bridge name",
1035 br = add_bridge_to_cache(ctx, br_cfg, br_cfg->name, NULL, 0);
1040 for (j = 0; j < br_cfg->n_ports; j++) {
1041 struct ovsrec_port *port_cfg = br_cfg->ports[j];
1043 if (!sset_add(&ports, port_cfg->name)) {
1044 /* Duplicate port name. (We will warn about that later.) */
1048 if (port_is_fake_bridge(port_cfg)
1049 && sset_add(&bridges, port_cfg->name)) {
1050 add_bridge_to_cache(ctx, NULL, port_cfg->name, br,
1055 sset_destroy(&bridges);
1056 sset_destroy(&ports);
1058 sset_init(&bridges);
1059 for (i = 0; i < ovs->n_bridges; i++) {
1060 struct ovsrec_bridge *br_cfg = ovs->bridges[i];
1061 struct vsctl_bridge *br;
1064 if (!sset_add(&bridges, br_cfg->name)) {
1067 br = shash_find_data(&ctx->bridges, br_cfg->name);
1068 for (j = 0; j < br_cfg->n_ports; j++) {
1069 struct ovsrec_port *port_cfg = br_cfg->ports[j];
1070 struct vsctl_port *port;
1073 port = shash_find_data(&ctx->ports, port_cfg->name);
1075 if (port_cfg == port->port_cfg) {
1076 VLOG_WARN("%s: port is in multiple bridges (%s and %s)",
1077 port_cfg->name, br->name, port->bridge->name);
1079 /* Log as an error because this violates the database's
1080 * uniqueness constraints, so the database server shouldn't
1081 * have allowed it. */
1082 VLOG_ERR("%s: database contains duplicate port name",
1088 if (port_is_fake_bridge(port_cfg)
1089 && !sset_add(&bridges, port_cfg->name)) {
1093 port = add_port_to_cache(ctx, br, port_cfg);
1094 for (k = 0; k < port_cfg->n_interfaces; k++) {
1095 struct ovsrec_interface *iface_cfg = port_cfg->interfaces[k];
1096 struct vsctl_iface *iface;
1098 iface = shash_find_data(&ctx->ifaces, iface_cfg->name);
1100 if (iface_cfg == iface->iface_cfg) {
1101 VLOG_WARN("%s: interface is in multiple ports "
1104 iface->port->port_cfg->name,
1105 port->port_cfg->name);
1107 /* Log as an error because this violates the database's
1108 * uniqueness constraints, so the database server
1109 * shouldn't have allowed it. */
1110 VLOG_ERR("%s: database contains duplicate interface "
1111 "name", iface_cfg->name);
1116 add_iface_to_cache(ctx, port, iface_cfg);
1120 sset_destroy(&bridges);
1124 check_conflicts(struct vsctl_context *ctx, const char *name,
1127 struct vsctl_iface *iface;
1128 struct vsctl_port *port;
1132 if (shash_find(&ctx->bridges, name)) {
1133 vsctl_fatal("%s because a bridge named %s already exists",
1137 port = shash_find_data(&ctx->ports, name);
1139 vsctl_fatal("%s because a port named %s already exists on "
1140 "bridge %s", msg, name, port->bridge->name);
1143 iface = shash_find_data(&ctx->ifaces, name);
1145 vsctl_fatal("%s because an interface named %s already exists "
1146 "on bridge %s", msg, name, iface->port->bridge->name);
1152 static struct vsctl_bridge *
1153 find_bridge(struct vsctl_context *ctx, const char *name, bool must_exist)
1155 struct vsctl_bridge *br;
1157 ovs_assert(ctx->cache_valid);
1159 br = shash_find_data(&ctx->bridges, name);
1160 if (must_exist && !br) {
1161 vsctl_fatal("no bridge named %s", name);
1163 ovsrec_open_vswitch_verify_bridges(ctx->ovs);
1167 static struct vsctl_bridge *
1168 find_real_bridge(struct vsctl_context *ctx, const char *name, bool must_exist)
1170 struct vsctl_bridge *br = find_bridge(ctx, name, must_exist);
1171 if (br && br->parent) {
1172 vsctl_fatal("%s is a fake bridge", name);
1177 static struct vsctl_port *
1178 find_port(struct vsctl_context *ctx, const char *name, bool must_exist)
1180 struct vsctl_port *port;
1182 ovs_assert(ctx->cache_valid);
1184 port = shash_find_data(&ctx->ports, name);
1185 if (port && !strcmp(name, port->bridge->name)) {
1188 if (must_exist && !port) {
1189 vsctl_fatal("no port named %s", name);
1195 static struct vsctl_iface *
1196 find_iface(struct vsctl_context *ctx, const char *name, bool must_exist)
1198 struct vsctl_iface *iface;
1200 ovs_assert(ctx->cache_valid);
1202 iface = shash_find_data(&ctx->ifaces, name);
1203 if (iface && !strcmp(name, iface->port->bridge->name)) {
1206 if (must_exist && !iface) {
1207 vsctl_fatal("no interface named %s", name);
1214 bridge_insert_port(struct ovsrec_bridge *br, struct ovsrec_port *port)
1216 struct ovsrec_port **ports;
1219 ports = xmalloc(sizeof *br->ports * (br->n_ports + 1));
1220 for (i = 0; i < br->n_ports; i++) {
1221 ports[i] = br->ports[i];
1223 ports[br->n_ports] = port;
1224 ovsrec_bridge_set_ports(br, ports, br->n_ports + 1);
1229 bridge_delete_port(struct ovsrec_bridge *br, struct ovsrec_port *port)
1231 struct ovsrec_port **ports;
1234 ports = xmalloc(sizeof *br->ports * br->n_ports);
1235 for (i = n = 0; i < br->n_ports; i++) {
1236 if (br->ports[i] != port) {
1237 ports[n++] = br->ports[i];
1240 ovsrec_bridge_set_ports(br, ports, n);
1245 ovs_insert_bridge(const struct ovsrec_open_vswitch *ovs,
1246 struct ovsrec_bridge *bridge)
1248 struct ovsrec_bridge **bridges;
1251 bridges = xmalloc(sizeof *ovs->bridges * (ovs->n_bridges + 1));
1252 for (i = 0; i < ovs->n_bridges; i++) {
1253 bridges[i] = ovs->bridges[i];
1255 bridges[ovs->n_bridges] = bridge;
1256 ovsrec_open_vswitch_set_bridges(ovs, bridges, ovs->n_bridges + 1);
1261 cmd_init(struct vsctl_context *ctx OVS_UNUSED)
1265 struct cmd_show_table {
1266 const struct ovsdb_idl_table_class *table;
1267 const struct ovsdb_idl_column *name_column;
1268 const struct ovsdb_idl_column *columns[3];
1272 static struct cmd_show_table cmd_show_tables[] = {
1273 {&ovsrec_table_open_vswitch,
1275 {&ovsrec_open_vswitch_col_manager_options,
1276 &ovsrec_open_vswitch_col_bridges,
1277 &ovsrec_open_vswitch_col_ovs_version},
1280 {&ovsrec_table_bridge,
1281 &ovsrec_bridge_col_name,
1282 {&ovsrec_bridge_col_controller,
1283 &ovsrec_bridge_col_fail_mode,
1284 &ovsrec_bridge_col_ports},
1287 {&ovsrec_table_port,
1288 &ovsrec_port_col_name,
1289 {&ovsrec_port_col_tag,
1290 &ovsrec_port_col_trunks,
1291 &ovsrec_port_col_interfaces},
1294 {&ovsrec_table_interface,
1295 &ovsrec_interface_col_name,
1296 {&ovsrec_interface_col_type,
1297 &ovsrec_interface_col_options,
1301 {&ovsrec_table_controller,
1302 &ovsrec_controller_col_target,
1303 {&ovsrec_controller_col_is_connected,
1308 {&ovsrec_table_manager,
1309 &ovsrec_manager_col_target,
1310 {&ovsrec_manager_col_is_connected,
1317 pre_cmd_show(struct vsctl_context *ctx)
1319 struct cmd_show_table *show;
1321 for (show = cmd_show_tables;
1322 show < &cmd_show_tables[ARRAY_SIZE(cmd_show_tables)];
1326 ovsdb_idl_add_table(ctx->idl, show->table);
1327 if (show->name_column) {
1328 ovsdb_idl_add_column(ctx->idl, show->name_column);
1330 for (i = 0; i < ARRAY_SIZE(show->columns); i++) {
1331 const struct ovsdb_idl_column *column = show->columns[i];
1333 ovsdb_idl_add_column(ctx->idl, column);
1339 static struct cmd_show_table *
1340 cmd_show_find_table_by_row(const struct ovsdb_idl_row *row)
1342 struct cmd_show_table *show;
1344 for (show = cmd_show_tables;
1345 show < &cmd_show_tables[ARRAY_SIZE(cmd_show_tables)];
1347 if (show->table == row->table->class) {
1354 static struct cmd_show_table *
1355 cmd_show_find_table_by_name(const char *name)
1357 struct cmd_show_table *show;
1359 for (show = cmd_show_tables;
1360 show < &cmd_show_tables[ARRAY_SIZE(cmd_show_tables)];
1362 if (!strcmp(show->table->name, name)) {
1370 cmd_show_row(struct vsctl_context *ctx, const struct ovsdb_idl_row *row,
1373 struct cmd_show_table *show = cmd_show_find_table_by_row(row);
1376 ds_put_char_multiple(&ctx->output, ' ', level * 4);
1377 if (show && show->name_column) {
1378 const struct ovsdb_datum *datum;
1380 ds_put_format(&ctx->output, "%s ", show->table->name);
1381 datum = ovsdb_idl_read(row, show->name_column);
1382 ovsdb_datum_to_string(datum, &show->name_column->type, &ctx->output);
1384 ds_put_format(&ctx->output, UUID_FMT, UUID_ARGS(&row->uuid));
1386 ds_put_char(&ctx->output, '\n');
1388 if (!show || show->recurse) {
1392 show->recurse = true;
1393 for (i = 0; i < ARRAY_SIZE(show->columns); i++) {
1394 const struct ovsdb_idl_column *column = show->columns[i];
1395 const struct ovsdb_datum *datum;
1401 datum = ovsdb_idl_read(row, column);
1402 if (column->type.key.type == OVSDB_TYPE_UUID &&
1403 column->type.key.u.uuid.refTableName) {
1404 struct cmd_show_table *ref_show;
1407 ref_show = cmd_show_find_table_by_name(
1408 column->type.key.u.uuid.refTableName);
1410 for (j = 0; j < datum->n; j++) {
1411 const struct ovsdb_idl_row *ref_row;
1413 ref_row = ovsdb_idl_get_row_for_uuid(ctx->idl,
1415 &datum->keys[j].uuid);
1417 cmd_show_row(ctx, ref_row, level + 1);
1424 if (!ovsdb_datum_is_default(datum, &column->type)) {
1425 ds_put_char_multiple(&ctx->output, ' ', (level + 1) * 4);
1426 ds_put_format(&ctx->output, "%s: ", column->name);
1427 ovsdb_datum_to_string(datum, &column->type, &ctx->output);
1428 ds_put_char(&ctx->output, '\n');
1431 show->recurse = false;
1435 cmd_show(struct vsctl_context *ctx)
1437 const struct ovsdb_idl_row *row;
1439 for (row = ovsdb_idl_first_row(ctx->idl, cmd_show_tables[0].table);
1440 row; row = ovsdb_idl_next_row(row)) {
1441 cmd_show_row(ctx, row, 0);
1446 pre_cmd_emer_reset(struct vsctl_context *ctx)
1448 ovsdb_idl_add_column(ctx->idl, &ovsrec_open_vswitch_col_manager_options);
1449 ovsdb_idl_add_column(ctx->idl, &ovsrec_open_vswitch_col_ssl);
1451 ovsdb_idl_add_column(ctx->idl, &ovsrec_bridge_col_controller);
1452 ovsdb_idl_add_column(ctx->idl, &ovsrec_bridge_col_fail_mode);
1453 ovsdb_idl_add_column(ctx->idl, &ovsrec_bridge_col_mirrors);
1454 ovsdb_idl_add_column(ctx->idl, &ovsrec_bridge_col_netflow);
1455 ovsdb_idl_add_column(ctx->idl, &ovsrec_bridge_col_sflow);
1456 ovsdb_idl_add_column(ctx->idl, &ovsrec_bridge_col_ipfix);
1457 ovsdb_idl_add_column(ctx->idl, &ovsrec_bridge_col_flood_vlans);
1458 ovsdb_idl_add_column(ctx->idl, &ovsrec_bridge_col_other_config);
1460 ovsdb_idl_add_column(ctx->idl, &ovsrec_port_col_other_config);
1462 ovsdb_idl_add_column(ctx->idl,
1463 &ovsrec_interface_col_ingress_policing_rate);
1464 ovsdb_idl_add_column(ctx->idl,
1465 &ovsrec_interface_col_ingress_policing_burst);
1469 cmd_emer_reset(struct vsctl_context *ctx)
1471 const struct ovsdb_idl *idl = ctx->idl;
1472 const struct ovsrec_bridge *br;
1473 const struct ovsrec_port *port;
1474 const struct ovsrec_interface *iface;
1475 const struct ovsrec_mirror *mirror, *next_mirror;
1476 const struct ovsrec_controller *ctrl, *next_ctrl;
1477 const struct ovsrec_manager *mgr, *next_mgr;
1478 const struct ovsrec_netflow *nf, *next_nf;
1479 const struct ovsrec_ssl *ssl, *next_ssl;
1480 const struct ovsrec_sflow *sflow, *next_sflow;
1481 const struct ovsrec_ipfix *ipfix, *next_ipfix;
1482 const struct ovsrec_flow_sample_collector_set *fscset, *next_fscset;
1484 /* Reset the Open_vSwitch table. */
1485 ovsrec_open_vswitch_set_manager_options(ctx->ovs, NULL, 0);
1486 ovsrec_open_vswitch_set_ssl(ctx->ovs, NULL);
1488 OVSREC_BRIDGE_FOR_EACH (br, idl) {
1491 ovsrec_bridge_set_controller(br, NULL, 0);
1492 ovsrec_bridge_set_fail_mode(br, NULL);
1493 ovsrec_bridge_set_mirrors(br, NULL, 0);
1494 ovsrec_bridge_set_netflow(br, NULL);
1495 ovsrec_bridge_set_sflow(br, NULL);
1496 ovsrec_bridge_set_ipfix(br, NULL);
1497 ovsrec_bridge_set_flood_vlans(br, NULL, 0);
1499 /* We only want to save the "hwaddr" key from other_config. */
1500 hwaddr = smap_get(&br->other_config, "hwaddr");
1502 struct smap smap = SMAP_INITIALIZER(&smap);
1503 smap_add(&smap, "hwaddr", hwaddr);
1504 ovsrec_bridge_set_other_config(br, &smap);
1505 smap_destroy(&smap);
1507 ovsrec_bridge_set_other_config(br, NULL);
1511 OVSREC_PORT_FOR_EACH (port, idl) {
1512 ovsrec_port_set_other_config(port, NULL);
1515 OVSREC_INTERFACE_FOR_EACH (iface, idl) {
1516 /* xxx What do we do about gre/patch devices created by mgr? */
1518 ovsrec_interface_set_ingress_policing_rate(iface, 0);
1519 ovsrec_interface_set_ingress_policing_burst(iface, 0);
1522 OVSREC_MIRROR_FOR_EACH_SAFE (mirror, next_mirror, idl) {
1523 ovsrec_mirror_delete(mirror);
1526 OVSREC_CONTROLLER_FOR_EACH_SAFE (ctrl, next_ctrl, idl) {
1527 ovsrec_controller_delete(ctrl);
1530 OVSREC_MANAGER_FOR_EACH_SAFE (mgr, next_mgr, idl) {
1531 ovsrec_manager_delete(mgr);
1534 OVSREC_NETFLOW_FOR_EACH_SAFE (nf, next_nf, idl) {
1535 ovsrec_netflow_delete(nf);
1538 OVSREC_SSL_FOR_EACH_SAFE (ssl, next_ssl, idl) {
1539 ovsrec_ssl_delete(ssl);
1542 OVSREC_SFLOW_FOR_EACH_SAFE (sflow, next_sflow, idl) {
1543 ovsrec_sflow_delete(sflow);
1546 OVSREC_IPFIX_FOR_EACH_SAFE (ipfix, next_ipfix, idl) {
1547 ovsrec_ipfix_delete(ipfix);
1550 OVSREC_FLOW_SAMPLE_COLLECTOR_SET_FOR_EACH_SAFE (fscset, next_fscset, idl) {
1551 ovsrec_flow_sample_collector_set_delete(fscset);
1554 vsctl_context_invalidate_cache(ctx);
1558 cmd_add_br(struct vsctl_context *ctx)
1560 bool may_exist = shash_find(&ctx->options, "--may-exist") != NULL;
1561 const char *br_name, *parent_name;
1564 br_name = ctx->argv[1];
1565 if (ctx->argc == 2) {
1568 } else if (ctx->argc == 4) {
1569 parent_name = ctx->argv[2];
1570 vlan = atoi(ctx->argv[3]);
1571 if (vlan < 0 || vlan > 4095) {
1572 vsctl_fatal("%s: vlan must be between 0 and 4095", ctx->argv[0]);
1575 vsctl_fatal("'%s' command takes exactly 1 or 3 arguments",
1579 vsctl_context_populate_cache(ctx);
1581 struct vsctl_bridge *br;
1583 br = find_bridge(ctx, br_name, false);
1587 vsctl_fatal("\"--may-exist add-br %s\" but %s is "
1588 "a VLAN bridge for VLAN %d",
1589 br_name, br_name, br->vlan);
1593 vsctl_fatal("\"--may-exist add-br %s %s %d\" but %s "
1594 "is not a VLAN bridge",
1595 br_name, parent_name, vlan, br_name);
1596 } else if (strcmp(br->parent->name, parent_name)) {
1597 vsctl_fatal("\"--may-exist add-br %s %s %d\" but %s "
1598 "has the wrong parent %s",
1599 br_name, parent_name, vlan,
1600 br_name, br->parent->name);
1601 } else if (br->vlan != vlan) {
1602 vsctl_fatal("\"--may-exist add-br %s %s %d\" but %s "
1603 "is a VLAN bridge for the wrong VLAN %d",
1604 br_name, parent_name, vlan, br_name, br->vlan);
1610 check_conflicts(ctx, br_name,
1611 xasprintf("cannot create a bridge named %s", br_name));
1614 struct ovsrec_port *port;
1615 struct ovsrec_interface *iface;
1616 struct ovsrec_bridge *br;
1618 iface = ovsrec_interface_insert(ctx->txn);
1619 ovsrec_interface_set_name(iface, br_name);
1620 ovsrec_interface_set_type(iface, "internal");
1622 port = ovsrec_port_insert(ctx->txn);
1623 ovsrec_port_set_name(port, br_name);
1624 ovsrec_port_set_interfaces(port, &iface, 1);
1626 br = ovsrec_bridge_insert(ctx->txn);
1627 ovsrec_bridge_set_name(br, br_name);
1628 ovsrec_bridge_set_ports(br, &port, 1);
1630 ovs_insert_bridge(ctx->ovs, br);
1632 struct vsctl_bridge *parent;
1633 struct ovsrec_port *port;
1634 struct ovsrec_interface *iface;
1635 struct ovsrec_bridge *br;
1638 parent = find_bridge(ctx, parent_name, false);
1639 if (parent && parent->parent) {
1640 vsctl_fatal("cannot create bridge with fake bridge as parent");
1643 vsctl_fatal("parent bridge %s does not exist", parent_name);
1645 br = parent->br_cfg;
1647 iface = ovsrec_interface_insert(ctx->txn);
1648 ovsrec_interface_set_name(iface, br_name);
1649 ovsrec_interface_set_type(iface, "internal");
1651 port = ovsrec_port_insert(ctx->txn);
1652 ovsrec_port_set_name(port, br_name);
1653 ovsrec_port_set_interfaces(port, &iface, 1);
1654 ovsrec_port_set_fake_bridge(port, true);
1655 ovsrec_port_set_tag(port, &tag, 1);
1657 bridge_insert_port(br, port);
1660 vsctl_context_invalidate_cache(ctx);
1664 del_port(struct vsctl_context *ctx, struct vsctl_port *port)
1666 struct vsctl_iface *iface, *next_iface;
1668 bridge_delete_port((port->bridge->parent
1669 ? port->bridge->parent->br_cfg
1670 : port->bridge->br_cfg), port->port_cfg);
1672 LIST_FOR_EACH_SAFE (iface, next_iface, ifaces_node, &port->ifaces) {
1673 del_cached_iface(ctx, iface);
1675 del_cached_port(ctx, port);
1679 del_bridge(struct vsctl_context *ctx, struct vsctl_bridge *br)
1681 struct vsctl_bridge *child, *next_child;
1682 struct vsctl_port *port, *next_port;
1683 const struct ovsrec_flow_sample_collector_set *fscset, *next_fscset;
1685 HMAP_FOR_EACH_SAFE (child, next_child, children_node, &br->children) {
1686 del_bridge(ctx, child);
1689 LIST_FOR_EACH_SAFE (port, next_port, ports_node, &br->ports) {
1690 del_port(ctx, port);
1693 OVSREC_FLOW_SAMPLE_COLLECTOR_SET_FOR_EACH_SAFE (fscset, next_fscset,
1695 if (fscset->bridge == br->br_cfg) {
1696 ovsrec_flow_sample_collector_set_delete(fscset);
1700 del_cached_bridge(ctx, br);
1704 cmd_del_br(struct vsctl_context *ctx)
1706 bool must_exist = !shash_find(&ctx->options, "--if-exists");
1707 struct vsctl_bridge *bridge;
1709 vsctl_context_populate_cache(ctx);
1710 bridge = find_bridge(ctx, ctx->argv[1], must_exist);
1712 del_bridge(ctx, bridge);
1717 output_sorted(struct svec *svec, struct ds *output)
1723 SVEC_FOR_EACH (i, name, svec) {
1724 ds_put_format(output, "%s\n", name);
1729 cmd_list_br(struct vsctl_context *ctx)
1731 struct shash_node *node;
1732 struct svec bridges;
1733 bool real = shash_find(&ctx->options, "--real");
1734 bool fake = shash_find(&ctx->options, "--fake");
1736 /* If neither fake nor real were requested, return both. */
1737 if (!real && !fake) {
1741 vsctl_context_populate_cache(ctx);
1743 svec_init(&bridges);
1744 SHASH_FOR_EACH (node, &ctx->bridges) {
1745 struct vsctl_bridge *br = node->data;
1747 if (br->parent ? fake : real) {
1748 svec_add(&bridges, br->name);
1751 output_sorted(&bridges, &ctx->output);
1752 svec_destroy(&bridges);
1756 cmd_br_exists(struct vsctl_context *ctx)
1758 vsctl_context_populate_cache(ctx);
1759 if (!find_bridge(ctx, ctx->argv[1], false)) {
1765 set_external_id(struct smap *old, struct smap *new,
1766 char *key, char *value)
1768 smap_clone(new, old);
1771 smap_replace(new, key, value);
1773 smap_remove(new, key);
1778 pre_cmd_br_set_external_id(struct vsctl_context *ctx)
1781 ovsdb_idl_add_column(ctx->idl, &ovsrec_bridge_col_external_ids);
1782 ovsdb_idl_add_column(ctx->idl, &ovsrec_port_col_external_ids);
1786 cmd_br_set_external_id(struct vsctl_context *ctx)
1788 struct vsctl_bridge *bridge;
1791 vsctl_context_populate_cache(ctx);
1792 bridge = find_bridge(ctx, ctx->argv[1], true);
1793 if (bridge->br_cfg) {
1795 set_external_id(&bridge->br_cfg->external_ids, &new, ctx->argv[2],
1796 ctx->argc >= 4 ? ctx->argv[3] : NULL);
1797 ovsrec_bridge_verify_external_ids(bridge->br_cfg);
1798 ovsrec_bridge_set_external_ids(bridge->br_cfg, &new);
1800 char *key = xasprintf("fake-bridge-%s", ctx->argv[2]);
1801 struct vsctl_port *port = shash_find_data(&ctx->ports, ctx->argv[1]);
1802 set_external_id(&port->port_cfg->external_ids, &new,
1803 key, ctx->argc >= 4 ? ctx->argv[3] : NULL);
1804 ovsrec_port_verify_external_ids(port->port_cfg);
1805 ovsrec_port_set_external_ids(port->port_cfg, &new);
1812 get_external_id(struct smap *smap, const char *prefix, const char *key,
1816 char *prefix_key = xasprintf("%s%s", prefix, key);
1817 const char *value = smap_get(smap, prefix_key);
1820 ds_put_format(output, "%s\n", value);
1824 const struct smap_node **sorted = smap_sort(smap);
1825 size_t prefix_len = strlen(prefix);
1828 for (i = 0; i < smap_count(smap); i++) {
1829 const struct smap_node *node = sorted[i];
1830 if (!strncmp(node->key, prefix, prefix_len)) {
1831 ds_put_format(output, "%s=%s\n", node->key + prefix_len,
1840 pre_cmd_br_get_external_id(struct vsctl_context *ctx)
1842 pre_cmd_br_set_external_id(ctx);
1846 cmd_br_get_external_id(struct vsctl_context *ctx)
1848 struct vsctl_bridge *bridge;
1850 vsctl_context_populate_cache(ctx);
1852 bridge = find_bridge(ctx, ctx->argv[1], true);
1853 if (bridge->br_cfg) {
1854 ovsrec_bridge_verify_external_ids(bridge->br_cfg);
1855 get_external_id(&bridge->br_cfg->external_ids, "",
1856 ctx->argc >= 3 ? ctx->argv[2] : NULL, &ctx->output);
1858 struct vsctl_port *port = shash_find_data(&ctx->ports, ctx->argv[1]);
1859 ovsrec_port_verify_external_ids(port->port_cfg);
1860 get_external_id(&port->port_cfg->external_ids, "fake-bridge-",
1861 ctx->argc >= 3 ? ctx->argv[2] : NULL, &ctx->output);
1866 cmd_list_ports(struct vsctl_context *ctx)
1868 struct vsctl_bridge *br;
1869 struct vsctl_port *port;
1872 vsctl_context_populate_cache(ctx);
1873 br = find_bridge(ctx, ctx->argv[1], true);
1874 ovsrec_bridge_verify_ports(br->br_cfg ? br->br_cfg : br->parent->br_cfg);
1877 LIST_FOR_EACH (port, ports_node, &br->ports) {
1878 if (strcmp(port->port_cfg->name, br->name)) {
1879 svec_add(&ports, port->port_cfg->name);
1882 output_sorted(&ports, &ctx->output);
1883 svec_destroy(&ports);
1887 add_port(struct vsctl_context *ctx,
1888 const char *br_name, const char *port_name,
1889 bool may_exist, bool fake_iface,
1890 char *iface_names[], int n_ifaces,
1891 char *settings[], int n_settings)
1893 struct vsctl_port *vsctl_port;
1894 struct vsctl_bridge *bridge;
1895 struct ovsrec_interface **ifaces;
1896 struct ovsrec_port *port;
1899 vsctl_context_populate_cache(ctx);
1901 struct vsctl_port *vsctl_port;
1903 vsctl_port = find_port(ctx, port_name, false);
1905 struct svec want_names, have_names;
1907 svec_init(&want_names);
1908 for (i = 0; i < n_ifaces; i++) {
1909 svec_add(&want_names, iface_names[i]);
1911 svec_sort(&want_names);
1913 svec_init(&have_names);
1914 for (i = 0; i < vsctl_port->port_cfg->n_interfaces; i++) {
1915 svec_add(&have_names,
1916 vsctl_port->port_cfg->interfaces[i]->name);
1918 svec_sort(&have_names);
1920 if (strcmp(vsctl_port->bridge->name, br_name)) {
1921 char *command = vsctl_context_to_string(ctx);
1922 vsctl_fatal("\"%s\" but %s is actually attached to bridge %s",
1923 command, port_name, vsctl_port->bridge->name);
1926 if (!svec_equal(&want_names, &have_names)) {
1927 char *have_names_string = svec_join(&have_names, ", ", "");
1928 char *command = vsctl_context_to_string(ctx);
1930 vsctl_fatal("\"%s\" but %s actually has interface(s) %s",
1931 command, port_name, have_names_string);
1934 svec_destroy(&want_names);
1935 svec_destroy(&have_names);
1940 check_conflicts(ctx, port_name,
1941 xasprintf("cannot create a port named %s", port_name));
1942 for (i = 0; i < n_ifaces; i++) {
1943 check_conflicts(ctx, iface_names[i],
1944 xasprintf("cannot create an interface named %s",
1947 bridge = find_bridge(ctx, br_name, true);
1949 ifaces = xmalloc(n_ifaces * sizeof *ifaces);
1950 for (i = 0; i < n_ifaces; i++) {
1951 ifaces[i] = ovsrec_interface_insert(ctx->txn);
1952 ovsrec_interface_set_name(ifaces[i], iface_names[i]);
1955 port = ovsrec_port_insert(ctx->txn);
1956 ovsrec_port_set_name(port, port_name);
1957 ovsrec_port_set_interfaces(port, ifaces, n_ifaces);
1958 ovsrec_port_set_bond_fake_iface(port, fake_iface);
1960 if (bridge->parent) {
1961 int64_t tag = bridge->vlan;
1962 ovsrec_port_set_tag(port, &tag, 1);
1965 for (i = 0; i < n_settings; i++) {
1966 set_column(get_table("Port"), &port->header_, settings[i],
1970 bridge_insert_port((bridge->parent ? bridge->parent->br_cfg
1971 : bridge->br_cfg), port);
1973 vsctl_port = add_port_to_cache(ctx, bridge, port);
1974 for (i = 0; i < n_ifaces; i++) {
1975 add_iface_to_cache(ctx, vsctl_port, ifaces[i]);
1981 cmd_add_port(struct vsctl_context *ctx)
1983 bool may_exist = shash_find(&ctx->options, "--may-exist") != NULL;
1985 add_port(ctx, ctx->argv[1], ctx->argv[2], may_exist, false,
1986 &ctx->argv[2], 1, &ctx->argv[3], ctx->argc - 3);
1990 cmd_add_bond(struct vsctl_context *ctx)
1992 bool may_exist = shash_find(&ctx->options, "--may-exist") != NULL;
1993 bool fake_iface = shash_find(&ctx->options, "--fake-iface");
1997 n_ifaces = ctx->argc - 3;
1998 for (i = 3; i < ctx->argc; i++) {
1999 if (strchr(ctx->argv[i], '=')) {
2005 vsctl_fatal("add-bond requires at least 2 interfaces, but only "
2006 "%d were specified", n_ifaces);
2009 add_port(ctx, ctx->argv[1], ctx->argv[2], may_exist, fake_iface,
2010 &ctx->argv[3], n_ifaces,
2011 &ctx->argv[n_ifaces + 3], ctx->argc - 3 - n_ifaces);
2015 cmd_del_port(struct vsctl_context *ctx)
2017 bool must_exist = !shash_find(&ctx->options, "--if-exists");
2018 bool with_iface = shash_find(&ctx->options, "--with-iface") != NULL;
2019 const char *target = ctx->argv[ctx->argc - 1];
2020 struct vsctl_port *port;
2022 vsctl_context_populate_cache(ctx);
2023 if (find_bridge(ctx, target, false)) {
2025 vsctl_fatal("cannot delete port %s because it is the local port "
2026 "for bridge %s (deleting this port requires deleting "
2027 "the entire bridge)", target, target);
2030 } else if (!with_iface) {
2031 port = find_port(ctx, target, must_exist);
2033 struct vsctl_iface *iface;
2035 port = find_port(ctx, target, false);
2037 iface = find_iface(ctx, target, false);
2042 if (must_exist && !port) {
2043 vsctl_fatal("no port or interface named %s", target);
2048 if (ctx->argc == 3) {
2049 struct vsctl_bridge *bridge;
2051 bridge = find_bridge(ctx, ctx->argv[1], true);
2052 if (port->bridge != bridge) {
2053 if (port->bridge->parent == bridge) {
2054 vsctl_fatal("bridge %s does not have a port %s (although "
2055 "its parent bridge %s does)",
2056 ctx->argv[1], ctx->argv[2],
2057 bridge->parent->name);
2059 vsctl_fatal("bridge %s does not have a port %s",
2060 ctx->argv[1], ctx->argv[2]);
2065 del_port(ctx, port);
2070 cmd_port_to_br(struct vsctl_context *ctx)
2072 struct vsctl_port *port;
2074 vsctl_context_populate_cache(ctx);
2076 port = find_port(ctx, ctx->argv[1], true);
2077 ds_put_format(&ctx->output, "%s\n", port->bridge->name);
2081 cmd_br_to_vlan(struct vsctl_context *ctx)
2083 struct vsctl_bridge *bridge;
2085 vsctl_context_populate_cache(ctx);
2087 bridge = find_bridge(ctx, ctx->argv[1], true);
2088 ds_put_format(&ctx->output, "%d\n", bridge->vlan);
2092 cmd_br_to_parent(struct vsctl_context *ctx)
2094 struct vsctl_bridge *bridge;
2096 vsctl_context_populate_cache(ctx);
2098 bridge = find_bridge(ctx, ctx->argv[1], true);
2099 if (bridge->parent) {
2100 bridge = bridge->parent;
2102 ds_put_format(&ctx->output, "%s\n", bridge->name);
2106 cmd_list_ifaces(struct vsctl_context *ctx)
2108 struct vsctl_bridge *br;
2109 struct vsctl_port *port;
2112 vsctl_context_populate_cache(ctx);
2114 br = find_bridge(ctx, ctx->argv[1], true);
2118 LIST_FOR_EACH (port, ports_node, &br->ports) {
2119 struct vsctl_iface *iface;
2121 LIST_FOR_EACH (iface, ifaces_node, &port->ifaces) {
2122 if (strcmp(iface->iface_cfg->name, br->name)) {
2123 svec_add(&ifaces, iface->iface_cfg->name);
2127 output_sorted(&ifaces, &ctx->output);
2128 svec_destroy(&ifaces);
2132 cmd_iface_to_br(struct vsctl_context *ctx)
2134 struct vsctl_iface *iface;
2136 vsctl_context_populate_cache(ctx);
2138 iface = find_iface(ctx, ctx->argv[1], true);
2139 ds_put_format(&ctx->output, "%s\n", iface->port->bridge->name);
2143 verify_controllers(struct ovsrec_bridge *bridge)
2147 ovsrec_bridge_verify_controller(bridge);
2148 for (i = 0; i < bridge->n_controller; i++) {
2149 ovsrec_controller_verify_target(bridge->controller[i]);
2154 pre_controller(struct vsctl_context *ctx)
2158 ovsdb_idl_add_column(ctx->idl, &ovsrec_controller_col_target);
2162 cmd_get_controller(struct vsctl_context *ctx)
2164 struct vsctl_bridge *br;
2165 struct svec targets;
2168 vsctl_context_populate_cache(ctx);
2170 br = find_bridge(ctx, ctx->argv[1], true);
2174 verify_controllers(br->br_cfg);
2176 /* Print the targets in sorted order for reproducibility. */
2177 svec_init(&targets);
2178 for (i = 0; i < br->br_cfg->n_controller; i++) {
2179 svec_add(&targets, br->br_cfg->controller[i]->target);
2182 svec_sort(&targets);
2183 for (i = 0; i < targets.n; i++) {
2184 ds_put_format(&ctx->output, "%s\n", targets.names[i]);
2186 svec_destroy(&targets);
2190 delete_controllers(struct ovsrec_controller **controllers,
2191 size_t n_controllers)
2195 for (i = 0; i < n_controllers; i++) {
2196 ovsrec_controller_delete(controllers[i]);
2201 cmd_del_controller(struct vsctl_context *ctx)
2203 struct ovsrec_bridge *br;
2205 vsctl_context_populate_cache(ctx);
2207 br = find_real_bridge(ctx, ctx->argv[1], true)->br_cfg;
2208 verify_controllers(br);
2210 if (br->controller) {
2211 delete_controllers(br->controller, br->n_controller);
2212 ovsrec_bridge_set_controller(br, NULL, 0);
2216 static struct ovsrec_controller **
2217 insert_controllers(struct ovsdb_idl_txn *txn, char *targets[], size_t n)
2219 struct ovsrec_controller **controllers;
2222 controllers = xmalloc(n * sizeof *controllers);
2223 for (i = 0; i < n; i++) {
2224 if (vconn_verify_name(targets[i]) && pvconn_verify_name(targets[i])) {
2225 VLOG_WARN("target type \"%s\" is possibly erroneous", targets[i]);
2227 controllers[i] = ovsrec_controller_insert(txn);
2228 ovsrec_controller_set_target(controllers[i], targets[i]);
2235 cmd_set_controller(struct vsctl_context *ctx)
2237 struct ovsrec_controller **controllers;
2238 struct ovsrec_bridge *br;
2241 vsctl_context_populate_cache(ctx);
2243 br = find_real_bridge(ctx, ctx->argv[1], true)->br_cfg;
2244 verify_controllers(br);
2246 delete_controllers(br->controller, br->n_controller);
2249 controllers = insert_controllers(ctx->txn, &ctx->argv[2], n);
2250 ovsrec_bridge_set_controller(br, controllers, n);
2255 cmd_get_fail_mode(struct vsctl_context *ctx)
2257 struct vsctl_bridge *br;
2258 const char *fail_mode;
2260 vsctl_context_populate_cache(ctx);
2261 br = find_bridge(ctx, ctx->argv[1], true);
2266 ovsrec_bridge_verify_fail_mode(br->br_cfg);
2268 fail_mode = br->br_cfg->fail_mode;
2269 if (fail_mode && strlen(fail_mode)) {
2270 ds_put_format(&ctx->output, "%s\n", fail_mode);
2275 cmd_del_fail_mode(struct vsctl_context *ctx)
2277 struct vsctl_bridge *br;
2279 vsctl_context_populate_cache(ctx);
2281 br = find_real_bridge(ctx, ctx->argv[1], true);
2283 ovsrec_bridge_set_fail_mode(br->br_cfg, NULL);
2287 cmd_set_fail_mode(struct vsctl_context *ctx)
2289 struct vsctl_bridge *br;
2290 const char *fail_mode = ctx->argv[2];
2292 vsctl_context_populate_cache(ctx);
2294 br = find_real_bridge(ctx, ctx->argv[1], true);
2296 if (strcmp(fail_mode, "standalone") && strcmp(fail_mode, "secure")) {
2297 vsctl_fatal("fail-mode must be \"standalone\" or \"secure\"");
2300 ovsrec_bridge_set_fail_mode(br->br_cfg, fail_mode);
2304 verify_managers(const struct ovsrec_open_vswitch *ovs)
2308 ovsrec_open_vswitch_verify_manager_options(ovs);
2310 for (i = 0; i < ovs->n_manager_options; ++i) {
2311 const struct ovsrec_manager *mgr = ovs->manager_options[i];
2313 ovsrec_manager_verify_target(mgr);
2318 pre_manager(struct vsctl_context *ctx)
2320 ovsdb_idl_add_column(ctx->idl, &ovsrec_open_vswitch_col_manager_options);
2321 ovsdb_idl_add_column(ctx->idl, &ovsrec_manager_col_target);
2325 cmd_get_manager(struct vsctl_context *ctx)
2327 const struct ovsrec_open_vswitch *ovs = ctx->ovs;
2328 struct svec targets;
2331 verify_managers(ovs);
2333 /* Print the targets in sorted order for reproducibility. */
2334 svec_init(&targets);
2336 for (i = 0; i < ovs->n_manager_options; i++) {
2337 svec_add(&targets, ovs->manager_options[i]->target);
2340 svec_sort_unique(&targets);
2341 for (i = 0; i < targets.n; i++) {
2342 ds_put_format(&ctx->output, "%s\n", targets.names[i]);
2344 svec_destroy(&targets);
2348 delete_managers(const struct vsctl_context *ctx)
2350 const struct ovsrec_open_vswitch *ovs = ctx->ovs;
2353 /* Delete Manager rows pointed to by 'manager_options' column. */
2354 for (i = 0; i < ovs->n_manager_options; i++) {
2355 ovsrec_manager_delete(ovs->manager_options[i]);
2358 /* Delete 'Manager' row refs in 'manager_options' column. */
2359 ovsrec_open_vswitch_set_manager_options(ovs, NULL, 0);
2363 cmd_del_manager(struct vsctl_context *ctx)
2365 const struct ovsrec_open_vswitch *ovs = ctx->ovs;
2367 verify_managers(ovs);
2368 delete_managers(ctx);
2372 insert_managers(struct vsctl_context *ctx, char *targets[], size_t n)
2374 struct ovsrec_manager **managers;
2377 /* Insert each manager in a new row in Manager table. */
2378 managers = xmalloc(n * sizeof *managers);
2379 for (i = 0; i < n; i++) {
2380 if (stream_verify_name(targets[i]) && pstream_verify_name(targets[i])) {
2381 VLOG_WARN("target type \"%s\" is possibly erroneous", targets[i]);
2383 managers[i] = ovsrec_manager_insert(ctx->txn);
2384 ovsrec_manager_set_target(managers[i], targets[i]);
2387 /* Store uuids of new Manager rows in 'manager_options' column. */
2388 ovsrec_open_vswitch_set_manager_options(ctx->ovs, managers, n);
2393 cmd_set_manager(struct vsctl_context *ctx)
2395 const size_t n = ctx->argc - 1;
2397 verify_managers(ctx->ovs);
2398 delete_managers(ctx);
2399 insert_managers(ctx, &ctx->argv[1], n);
2403 pre_cmd_get_ssl(struct vsctl_context *ctx)
2405 ovsdb_idl_add_column(ctx->idl, &ovsrec_open_vswitch_col_ssl);
2407 ovsdb_idl_add_column(ctx->idl, &ovsrec_ssl_col_private_key);
2408 ovsdb_idl_add_column(ctx->idl, &ovsrec_ssl_col_certificate);
2409 ovsdb_idl_add_column(ctx->idl, &ovsrec_ssl_col_ca_cert);
2410 ovsdb_idl_add_column(ctx->idl, &ovsrec_ssl_col_bootstrap_ca_cert);
2414 cmd_get_ssl(struct vsctl_context *ctx)
2416 struct ovsrec_ssl *ssl = ctx->ovs->ssl;
2418 ovsrec_open_vswitch_verify_ssl(ctx->ovs);
2420 ovsrec_ssl_verify_private_key(ssl);
2421 ovsrec_ssl_verify_certificate(ssl);
2422 ovsrec_ssl_verify_ca_cert(ssl);
2423 ovsrec_ssl_verify_bootstrap_ca_cert(ssl);
2425 ds_put_format(&ctx->output, "Private key: %s\n", ssl->private_key);
2426 ds_put_format(&ctx->output, "Certificate: %s\n", ssl->certificate);
2427 ds_put_format(&ctx->output, "CA Certificate: %s\n", ssl->ca_cert);
2428 ds_put_format(&ctx->output, "Bootstrap: %s\n",
2429 ssl->bootstrap_ca_cert ? "true" : "false");
2434 pre_cmd_del_ssl(struct vsctl_context *ctx)
2436 ovsdb_idl_add_column(ctx->idl, &ovsrec_open_vswitch_col_ssl);
2440 cmd_del_ssl(struct vsctl_context *ctx)
2442 struct ovsrec_ssl *ssl = ctx->ovs->ssl;
2445 ovsrec_open_vswitch_verify_ssl(ctx->ovs);
2446 ovsrec_ssl_delete(ssl);
2447 ovsrec_open_vswitch_set_ssl(ctx->ovs, NULL);
2452 pre_cmd_set_ssl(struct vsctl_context *ctx)
2454 ovsdb_idl_add_column(ctx->idl, &ovsrec_open_vswitch_col_ssl);
2458 cmd_set_ssl(struct vsctl_context *ctx)
2460 bool bootstrap = shash_find(&ctx->options, "--bootstrap");
2461 struct ovsrec_ssl *ssl = ctx->ovs->ssl;
2463 ovsrec_open_vswitch_verify_ssl(ctx->ovs);
2465 ovsrec_ssl_delete(ssl);
2467 ssl = ovsrec_ssl_insert(ctx->txn);
2469 ovsrec_ssl_set_private_key(ssl, ctx->argv[1]);
2470 ovsrec_ssl_set_certificate(ssl, ctx->argv[2]);
2471 ovsrec_ssl_set_ca_cert(ssl, ctx->argv[3]);
2473 ovsrec_ssl_set_bootstrap_ca_cert(ssl, bootstrap);
2475 ovsrec_open_vswitch_set_ssl(ctx->ovs, ssl);
2478 /* Parameter commands. */
2480 struct vsctl_row_id {
2481 const struct ovsdb_idl_table_class *table;
2482 const struct ovsdb_idl_column *name_column;
2483 const struct ovsdb_idl_column *uuid_column;
2486 struct vsctl_table_class {
2487 struct ovsdb_idl_table_class *class;
2488 struct vsctl_row_id row_ids[2];
2491 static const struct vsctl_table_class tables[] = {
2492 {&ovsrec_table_bridge,
2493 {{&ovsrec_table_bridge, &ovsrec_bridge_col_name, NULL},
2494 {&ovsrec_table_flow_sample_collector_set, NULL,
2495 &ovsrec_flow_sample_collector_set_col_bridge}}},
2497 {&ovsrec_table_controller,
2498 {{&ovsrec_table_bridge,
2499 &ovsrec_bridge_col_name,
2500 &ovsrec_bridge_col_controller}}},
2502 {&ovsrec_table_interface,
2503 {{&ovsrec_table_interface, &ovsrec_interface_col_name, NULL},
2504 {NULL, NULL, NULL}}},
2506 {&ovsrec_table_mirror,
2507 {{&ovsrec_table_mirror, &ovsrec_mirror_col_name, NULL},
2508 {NULL, NULL, NULL}}},
2510 {&ovsrec_table_manager,
2511 {{&ovsrec_table_manager, &ovsrec_manager_col_target, NULL},
2512 {NULL, NULL, NULL}}},
2514 {&ovsrec_table_netflow,
2515 {{&ovsrec_table_bridge,
2516 &ovsrec_bridge_col_name,
2517 &ovsrec_bridge_col_netflow},
2518 {NULL, NULL, NULL}}},
2520 {&ovsrec_table_open_vswitch,
2521 {{&ovsrec_table_open_vswitch, NULL, NULL},
2522 {NULL, NULL, NULL}}},
2524 {&ovsrec_table_port,
2525 {{&ovsrec_table_port, &ovsrec_port_col_name, NULL},
2526 {NULL, NULL, NULL}}},
2529 {{&ovsrec_table_port, &ovsrec_port_col_name, &ovsrec_port_col_qos},
2530 {NULL, NULL, NULL}}},
2532 {&ovsrec_table_queue,
2533 {{NULL, NULL, NULL},
2534 {NULL, NULL, NULL}}},
2537 {{&ovsrec_table_open_vswitch, NULL, &ovsrec_open_vswitch_col_ssl}}},
2539 {&ovsrec_table_sflow,
2540 {{&ovsrec_table_bridge,
2541 &ovsrec_bridge_col_name,
2542 &ovsrec_bridge_col_sflow},
2543 {NULL, NULL, NULL}}},
2545 {&ovsrec_table_flow_table,
2546 {{&ovsrec_table_flow_table, &ovsrec_flow_table_col_name, NULL},
2547 {NULL, NULL, NULL}}},
2549 {&ovsrec_table_ipfix,
2550 {{&ovsrec_table_bridge,
2551 &ovsrec_bridge_col_name,
2552 &ovsrec_bridge_col_ipfix},
2553 {&ovsrec_table_flow_sample_collector_set, NULL,
2554 &ovsrec_flow_sample_collector_set_col_ipfix}}},
2556 {&ovsrec_table_flow_sample_collector_set,
2557 {{NULL, NULL, NULL},
2558 {NULL, NULL, NULL}}},
2560 {NULL, {{NULL, NULL, NULL}, {NULL, NULL, NULL}}}
2564 die_if_error(char *error)
2567 vsctl_fatal("%s", error);
2572 to_lower_and_underscores(unsigned c)
2574 return c == '-' ? '_' : tolower(c);
2578 score_partial_match(const char *name, const char *s)
2582 if (!strcmp(name, s)) {
2585 for (score = 0; ; score++, name++, s++) {
2586 if (to_lower_and_underscores(*name) != to_lower_and_underscores(*s)) {
2588 } else if (*name == '\0') {
2589 return UINT_MAX - 1;
2592 return *s == '\0' ? score : 0;
2595 static const struct vsctl_table_class *
2596 get_table(const char *table_name)
2598 const struct vsctl_table_class *table;
2599 const struct vsctl_table_class *best_match = NULL;
2600 unsigned int best_score = 0;
2602 for (table = tables; table->class; table++) {
2603 unsigned int score = score_partial_match(table->class->name,
2605 if (score > best_score) {
2608 } else if (score == best_score) {
2614 } else if (best_score) {
2615 vsctl_fatal("multiple table names match \"%s\"", table_name);
2617 vsctl_fatal("unknown table \"%s\"", table_name);
2621 static const struct vsctl_table_class *
2622 pre_get_table(struct vsctl_context *ctx, const char *table_name)
2624 const struct vsctl_table_class *table_class;
2627 table_class = get_table(table_name);
2628 ovsdb_idl_add_table(ctx->idl, table_class->class);
2630 for (i = 0; i < ARRAY_SIZE(table_class->row_ids); i++) {
2631 const struct vsctl_row_id *id = &table_class->row_ids[i];
2633 ovsdb_idl_add_table(ctx->idl, id->table);
2635 if (id->name_column) {
2636 ovsdb_idl_add_column(ctx->idl, id->name_column);
2638 if (id->uuid_column) {
2639 ovsdb_idl_add_column(ctx->idl, id->uuid_column);
2646 static const struct ovsdb_idl_row *
2647 get_row_by_id(struct vsctl_context *ctx, const struct vsctl_table_class *table,
2648 const struct vsctl_row_id *id, const char *record_id)
2650 const struct ovsdb_idl_row *referrer, *final;
2656 if (!id->name_column) {
2657 if (strcmp(record_id, ".")) {
2660 referrer = ovsdb_idl_first_row(ctx->idl, id->table);
2661 if (!referrer || ovsdb_idl_next_row(referrer)) {
2665 const struct ovsdb_idl_row *row;
2668 for (row = ovsdb_idl_first_row(ctx->idl, id->table);
2670 row = ovsdb_idl_next_row(row))
2672 const struct ovsdb_datum *name;
2674 name = ovsdb_idl_get(row, id->name_column,
2675 OVSDB_TYPE_STRING, OVSDB_TYPE_VOID);
2676 if (name->n == 1 && !strcmp(name->keys[0].string, record_id)) {
2678 vsctl_fatal("multiple rows in %s match \"%s\"",
2679 table->class->name, record_id);
2690 if (id->uuid_column) {
2691 const struct ovsdb_datum *uuid;
2693 ovsdb_idl_txn_verify(referrer, id->uuid_column);
2694 uuid = ovsdb_idl_get(referrer, id->uuid_column,
2695 OVSDB_TYPE_UUID, OVSDB_TYPE_VOID);
2697 final = ovsdb_idl_get_row_for_uuid(ctx->idl, table->class,
2698 &uuid->keys[0].uuid);
2707 static const struct ovsdb_idl_row *
2708 get_row (struct vsctl_context *ctx,
2709 const struct vsctl_table_class *table, const char *record_id,
2712 const struct ovsdb_idl_row *row;
2715 if (uuid_from_string(&uuid, record_id)) {
2716 row = ovsdb_idl_get_row_for_uuid(ctx->idl, table->class, &uuid);
2720 for (i = 0; i < ARRAY_SIZE(table->row_ids); i++) {
2721 row = get_row_by_id(ctx, table, &table->row_ids[i], record_id);
2727 if (must_exist && !row) {
2728 vsctl_fatal("no row \"%s\" in table %s",
2729 record_id, table->class->name);
2735 get_column(const struct vsctl_table_class *table, const char *column_name,
2736 const struct ovsdb_idl_column **columnp)
2738 const struct ovsdb_idl_column *best_match = NULL;
2739 unsigned int best_score = 0;
2742 for (i = 0; i < table->class->n_columns; i++) {
2743 const struct ovsdb_idl_column *column = &table->class->columns[i];
2744 unsigned int score = score_partial_match(column->name, column_name);
2745 if (score > best_score) {
2746 best_match = column;
2748 } else if (score == best_score) {
2753 *columnp = best_match;
2756 } else if (best_score) {
2757 return xasprintf("%s contains more than one column whose name "
2758 "matches \"%s\"", table->class->name, column_name);
2760 return xasprintf("%s does not contain a column whose name matches "
2761 "\"%s\"", table->class->name, column_name);
2765 static struct ovsdb_symbol *
2766 create_symbol(struct ovsdb_symbol_table *symtab, const char *id, bool *newp)
2768 struct ovsdb_symbol *symbol;
2771 vsctl_fatal("row id \"%s\" does not begin with \"@\"", id);
2775 *newp = ovsdb_symbol_table_get(symtab, id) == NULL;
2778 symbol = ovsdb_symbol_table_insert(symtab, id);
2779 if (symbol->created) {
2780 vsctl_fatal("row id \"%s\" may only be specified on one --id option",
2783 symbol->created = true;
2788 pre_get_column(struct vsctl_context *ctx,
2789 const struct vsctl_table_class *table, const char *column_name,
2790 const struct ovsdb_idl_column **columnp)
2792 die_if_error(get_column(table, column_name, columnp));
2793 ovsdb_idl_add_column(ctx->idl, *columnp);
2797 missing_operator_error(const char *arg, const char **allowed_operators,
2803 ds_put_format(&s, "%s: argument does not end in ", arg);
2804 ds_put_format(&s, "\"%s\"", allowed_operators[0]);
2805 if (n_allowed == 2) {
2806 ds_put_format(&s, " or \"%s\"", allowed_operators[1]);
2807 } else if (n_allowed > 2) {
2810 for (i = 1; i < n_allowed - 1; i++) {
2811 ds_put_format(&s, ", \"%s\"", allowed_operators[i]);
2813 ds_put_format(&s, ", or \"%s\"", allowed_operators[i]);
2815 ds_put_format(&s, " followed by a value.");
2817 return ds_steal_cstr(&s);
2820 /* Breaks 'arg' apart into a number of fields in the following order:
2822 * - The name of a column in 'table', stored into '*columnp'. The column
2823 * name may be abbreviated.
2825 * - Optionally ':' followed by a key string. The key is stored as a
2826 * malloc()'d string into '*keyp', or NULL if no key is present in
2829 * - If 'valuep' is nonnull, an operator followed by a value string. The
2830 * allowed operators are the 'n_allowed' string in 'allowed_operators',
2831 * or just "=" if 'n_allowed' is 0. If 'operatorp' is nonnull, then the
2832 * index of the operator within 'allowed_operators' is stored into
2833 * '*operatorp'. The value is stored as a malloc()'d string into
2834 * '*valuep', or NULL if no value is present in 'arg'.
2836 * On success, returns NULL. On failure, returned a malloc()'d string error
2837 * message and stores NULL into all of the nonnull output arguments. */
2838 static char * WARN_UNUSED_RESULT
2839 parse_column_key_value(const char *arg,
2840 const struct vsctl_table_class *table,
2841 const struct ovsdb_idl_column **columnp, char **keyp,
2843 const char **allowed_operators, size_t n_allowed,
2846 const char *p = arg;
2850 ovs_assert(!(operatorp && !valuep));
2856 /* Parse column name. */
2857 error = ovsdb_token_parse(&p, &column_name);
2861 if (column_name[0] == '\0') {
2863 error = xasprintf("%s: missing column name", arg);
2866 error = get_column(table, column_name, columnp);
2872 /* Parse key string. */
2875 error = ovsdb_token_parse(&p, keyp);
2881 /* Parse value string. */
2887 if (!allowed_operators) {
2888 static const char *equals = "=";
2889 allowed_operators = =
2895 for (i = 0; i < n_allowed; i++) {
2896 const char *op = allowed_operators[i];
2897 size_t op_len = strlen(op);
2899 if (op_len > best_len && !strncmp(op, p, op_len) && p[op_len]) {
2905 error = missing_operator_error(arg, allowed_operators, n_allowed);
2912 *valuep = xstrdup(p + best_len);
2915 error = xasprintf("%s: trailing garbage \"%s\" in argument",
2936 static const struct ovsdb_idl_column *
2937 pre_parse_column_key_value(struct vsctl_context *ctx,
2939 const struct vsctl_table_class *table)
2941 const struct ovsdb_idl_column *column;
2946 die_if_error(ovsdb_token_parse(&p, &column_name));
2947 if (column_name[0] == '\0') {
2948 vsctl_fatal("%s: missing column name", arg);
2951 pre_get_column(ctx, table, column_name, &column);
2958 check_mutable(const struct vsctl_table_class *table,
2959 const struct ovsdb_idl_column *column)
2961 if (!column->mutable) {
2962 vsctl_fatal("cannot modify read-only column %s in table %s",
2963 column->name, table->class->name);
2968 pre_cmd_get(struct vsctl_context *ctx)
2970 const char *id = shash_find_data(&ctx->options, "--id");
2971 const char *table_name = ctx->argv[1];
2972 const struct vsctl_table_class *table;
2975 /* Using "get" without --id or a column name could possibly make sense.
2976 * Maybe, for example, a ovs-vsctl run wants to assert that a row exists.
2977 * But it is unlikely that an interactive user would want to do that, so
2978 * issue a warning if we're running on a terminal. */
2979 if (!id && ctx->argc <= 3 && isatty(STDOUT_FILENO)) {
2980 VLOG_WARN("\"get\" command without row arguments or \"--id\" is "
2981 "possibly erroneous");
2984 table = pre_get_table(ctx, table_name);
2985 for (i = 3; i < ctx->argc; i++) {
2986 if (!strcasecmp(ctx->argv[i], "_uuid")
2987 || !strcasecmp(ctx->argv[i], "-uuid")) {
2991 pre_parse_column_key_value(ctx, ctx->argv[i], table);
2996 cmd_get(struct vsctl_context *ctx)
2998 const char *id = shash_find_data(&ctx->options, "--id");
2999 bool must_exist = !shash_find(&ctx->options, "--if-exists");
3000 const char *table_name = ctx->argv[1];
3001 const char *record_id = ctx->argv[2];
3002 const struct vsctl_table_class *table;
3003 const struct ovsdb_idl_row *row;
3004 struct ds *out = &ctx->output;
3007 if (id && !must_exist) {
3008 vsctl_fatal("--if-exists and --id may not be specified together");
3011 table = get_table(table_name);
3012 row = get_row(ctx, table, record_id, must_exist);
3018 struct ovsdb_symbol *symbol;
3021 symbol = create_symbol(ctx->symtab, id, &new);
3023 vsctl_fatal("row id \"%s\" specified on \"get\" command was used "
3024 "before it was defined", id);
3026 symbol->uuid = row->uuid;
3028 /* This symbol refers to a row that already exists, so disable warnings
3029 * about it being unreferenced. */
3030 symbol->strong_ref = true;
3032 for (i = 3; i < ctx->argc; i++) {
3033 const struct ovsdb_idl_column *column;
3034 const struct ovsdb_datum *datum;
3037 /* Special case for obtaining the UUID of a row. We can't just do this
3038 * through parse_column_key_value() below since it returns a "struct
3039 * ovsdb_idl_column" and the UUID column doesn't have one. */
3040 if (!strcasecmp(ctx->argv[i], "_uuid")
3041 || !strcasecmp(ctx->argv[i], "-uuid")) {
3042 ds_put_format(out, UUID_FMT"\n", UUID_ARGS(&row->uuid));
3046 die_if_error(parse_column_key_value(ctx->argv[i], table,
3047 &column, &key_string,
3048 NULL, NULL, 0, NULL));
3050 ovsdb_idl_txn_verify(row, column);
3051 datum = ovsdb_idl_read(row, column);
3053 union ovsdb_atom key;
3056 if (column->type.value.type == OVSDB_TYPE_VOID) {
3057 vsctl_fatal("cannot specify key to get for non-map column %s",
3061 die_if_error(ovsdb_atom_from_string(&key,
3063 key_string, ctx->symtab));
3065 idx = ovsdb_datum_find_key(datum, &key,
3066 column->type.key.type);
3067 if (idx == UINT_MAX) {
3069 vsctl_fatal("no key \"%s\" in %s record \"%s\" column %s",
3070 key_string, table->class->name, record_id,
3074 ovsdb_atom_to_string(&datum->values[idx],
3075 column->type.value.type, out);
3077 ovsdb_atom_destroy(&key, column->type.key.type);
3079 ovsdb_datum_to_string(datum, &column->type, out);
3081 ds_put_char(out, '\n');
3088 parse_column_names(const char *column_names,
3089 const struct vsctl_table_class *table,
3090 const struct ovsdb_idl_column ***columnsp,
3093 const struct ovsdb_idl_column **columns;
3096 if (!column_names) {
3099 n_columns = table->class->n_columns + 1;
3100 columns = xmalloc(n_columns * sizeof *columns);
3102 for (i = 0; i < table->class->n_columns; i++) {
3103 columns[i + 1] = &table->class->columns[i];
3106 char *s = xstrdup(column_names);
3107 size_t allocated_columns;
3108 char *save_ptr = NULL;
3112 allocated_columns = n_columns = 0;
3113 for (column_name = strtok_r(s, ", ", &save_ptr); column_name;
3114 column_name = strtok_r(NULL, ", ", &save_ptr)) {
3115 const struct ovsdb_idl_column *column;
3117 if (!strcasecmp(column_name, "_uuid")) {
3120 die_if_error(get_column(table, column_name, &column));
3122 if (n_columns >= allocated_columns) {
3123 columns = x2nrealloc(columns, &allocated_columns,
3126 columns[n_columns++] = column;
3131 vsctl_fatal("must specify at least one column name");
3134 *columnsp = columns;
3135 *n_columnsp = n_columns;
3140 pre_list_columns(struct vsctl_context *ctx,
3141 const struct vsctl_table_class *table,
3142 const char *column_names)
3144 const struct ovsdb_idl_column **columns;
3148 parse_column_names(column_names, table, &columns, &n_columns);
3149 for (i = 0; i < n_columns; i++) {
3151 ovsdb_idl_add_column(ctx->idl, columns[i]);
3158 pre_cmd_list(struct vsctl_context *ctx)
3160 const char *column_names = shash_find_data(&ctx->options, "--columns");
3161 const char *table_name = ctx->argv[1];
3162 const struct vsctl_table_class *table;
3164 table = pre_get_table(ctx, table_name);
3165 pre_list_columns(ctx, table, column_names);
3168 static struct table *
3169 list_make_table(const struct ovsdb_idl_column **columns, size_t n_columns)
3174 out = xmalloc(sizeof *out);
3177 for (i = 0; i < n_columns; i++) {
3178 const struct ovsdb_idl_column *column = columns[i];
3179 const char *column_name = column ? column->name : "_uuid";
3181 table_add_column(out, "%s", column_name);
3188 list_record(const struct ovsdb_idl_row *row,
3189 const struct ovsdb_idl_column **columns, size_t n_columns,
3199 for (i = 0; i < n_columns; i++) {
3200 const struct ovsdb_idl_column *column = columns[i];
3201 struct cell *cell = table_add_cell(out);
3204 struct ovsdb_datum datum;
3205 union ovsdb_atom atom;
3207 atom.uuid = row->uuid;
3210 datum.values = NULL;
3213 cell->json = ovsdb_datum_to_json(&datum, &ovsdb_type_uuid);
3214 cell->type = &ovsdb_type_uuid;
3216 const struct ovsdb_datum *datum = ovsdb_idl_read(row, column);
3218 cell->json = ovsdb_datum_to_json(datum, &column->type);
3219 cell->type = &column->type;
3225 cmd_list(struct vsctl_context *ctx)
3227 const char *column_names = shash_find_data(&ctx->options, "--columns");
3228 bool must_exist = !shash_find(&ctx->options, "--if-exists");
3229 const struct ovsdb_idl_column **columns;
3230 const char *table_name = ctx->argv[1];
3231 const struct vsctl_table_class *table;
3236 table = get_table(table_name);
3237 parse_column_names(column_names, table, &columns, &n_columns);
3238 out = ctx->table = list_make_table(columns, n_columns);
3239 if (ctx->argc > 2) {
3240 for (i = 2; i < ctx->argc; i++) {
3241 list_record(get_row(ctx, table, ctx->argv[i], must_exist),
3242 columns, n_columns, out);
3245 const struct ovsdb_idl_row *row;
3247 for (row = ovsdb_idl_first_row(ctx->idl, table->class); row != NULL;
3248 row = ovsdb_idl_next_row(row)) {
3249 list_record(row, columns, n_columns, out);
3256 pre_cmd_find(struct vsctl_context *ctx)
3258 const char *column_names = shash_find_data(&ctx->options, "--columns");
3259 const char *table_name = ctx->argv[1];
3260 const struct vsctl_table_class *table;
3263 table = pre_get_table(ctx, table_name);
3264 pre_list_columns(ctx, table, column_names);
3265 for (i = 2; i < ctx->argc; i++) {
3266 pre_parse_column_key_value(ctx, ctx->argv[i], table);
3271 cmd_find(struct vsctl_context *ctx)
3273 const char *column_names = shash_find_data(&ctx->options, "--columns");
3274 const struct ovsdb_idl_column **columns;
3275 const char *table_name = ctx->argv[1];
3276 const struct vsctl_table_class *table;
3277 const struct ovsdb_idl_row *row;
3281 table = get_table(table_name);
3282 parse_column_names(column_names, table, &columns, &n_columns);
3283 out = ctx->table = list_make_table(columns, n_columns);
3284 for (row = ovsdb_idl_first_row(ctx->idl, table->class); row;
3285 row = ovsdb_idl_next_row(row)) {
3288 for (i = 2; i < ctx->argc; i++) {
3289 if (!is_condition_satisfied(table, row, ctx->argv[i],
3294 list_record(row, columns, n_columns, out);
3302 pre_cmd_set(struct vsctl_context *ctx)
3304 const char *table_name = ctx->argv[1];
3305 const struct vsctl_table_class *table;
3308 table = pre_get_table(ctx, table_name);
3309 for (i = 3; i < ctx->argc; i++) {
3310 const struct ovsdb_idl_column *column;
3312 column = pre_parse_column_key_value(ctx, ctx->argv[i], table);
3313 check_mutable(table, column);
3318 set_column(const struct vsctl_table_class *table,
3319 const struct ovsdb_idl_row *row, const char *arg,
3320 struct ovsdb_symbol_table *symtab)
3322 const struct ovsdb_idl_column *column;
3323 char *key_string, *value_string;
3326 error = parse_column_key_value(arg, table, &column, &key_string,
3327 NULL, NULL, 0, &value_string);
3328 die_if_error(error);
3329 if (!value_string) {
3330 vsctl_fatal("%s: missing value", arg);
3334 union ovsdb_atom key, value;
3335 struct ovsdb_datum datum;
3337 if (column->type.value.type == OVSDB_TYPE_VOID) {
3338 vsctl_fatal("cannot specify key to set for non-map column %s",
3342 die_if_error(ovsdb_atom_from_string(&key, &column->type.key,
3343 key_string, symtab));
3344 die_if_error(ovsdb_atom_from_string(&value, &column->type.value,
3345 value_string, symtab));
3347 ovsdb_datum_init_empty(&datum);
3348 ovsdb_datum_add_unsafe(&datum, &key, &value, &column->type);
3350 ovsdb_atom_destroy(&key, column->type.key.type);
3351 ovsdb_atom_destroy(&value, column->type.value.type);
3353 ovsdb_datum_union(&datum, ovsdb_idl_read(row, column),
3354 &column->type, false);
3355 ovsdb_idl_txn_write(row, column, &datum);
3357 struct ovsdb_datum datum;
3359 die_if_error(ovsdb_datum_from_string(&datum, &column->type,
3360 value_string, symtab));
3361 ovsdb_idl_txn_write(row, column, &datum);
3369 cmd_set(struct vsctl_context *ctx)
3371 bool must_exist = !shash_find(&ctx->options, "--if-exists");
3372 const char *table_name = ctx->argv[1];
3373 const char *record_id = ctx->argv[2];
3374 const struct vsctl_table_class *table;
3375 const struct ovsdb_idl_row *row;
3378 table = get_table(table_name);
3379 row = get_row(ctx, table, record_id, must_exist);
3384 for (i = 3; i < ctx->argc; i++) {
3385 set_column(table, row, ctx->argv[i], ctx->symtab);
3388 vsctl_context_invalidate_cache(ctx);
3392 pre_cmd_add(struct vsctl_context *ctx)
3394 const char *table_name = ctx->argv[1];
3395 const char *column_name = ctx->argv[3];
3396 const struct vsctl_table_class *table;
3397 const struct ovsdb_idl_column *column;
3399 table = pre_get_table(ctx, table_name);
3400 pre_get_column(ctx, table, column_name, &column);
3401 check_mutable(table, column);
3405 cmd_add(struct vsctl_context *ctx)
3407 bool must_exist = !shash_find(&ctx->options, "--if-exists");
3408 const char *table_name = ctx->argv[1];
3409 const char *record_id = ctx->argv[2];
3410 const char *column_name = ctx->argv[3];
3411 const struct vsctl_table_class *table;
3412 const struct ovsdb_idl_column *column;
3413 const struct ovsdb_idl_row *row;
3414 const struct ovsdb_type *type;
3415 struct ovsdb_datum old;
3418 table = get_table(table_name);
3419 die_if_error(get_column(table, column_name, &column));
3420 row = get_row(ctx, table, record_id, must_exist);
3425 type = &column->type;
3426 ovsdb_datum_clone(&old, ovsdb_idl_read(row, column), &column->type);
3427 for (i = 4; i < ctx->argc; i++) {
3428 struct ovsdb_type add_type;
3429 struct ovsdb_datum add;
3433 add_type.n_max = UINT_MAX;
3434 die_if_error(ovsdb_datum_from_string(&add, &add_type, ctx->argv[i],
3436 ovsdb_datum_union(&old, &add, type, false);
3437 ovsdb_datum_destroy(&add, type);
3439 if (old.n > type->n_max) {
3440 vsctl_fatal("\"add\" operation would put %u %s in column %s of "
3441 "table %s but the maximum number is %u",
3443 type->value.type == OVSDB_TYPE_VOID ? "values" : "pairs",
3444 column->name, table->class->name, type->n_max);
3446 ovsdb_idl_txn_verify(row, column);
3447 ovsdb_idl_txn_write(row, column, &old);
3449 vsctl_context_invalidate_cache(ctx);
3453 pre_cmd_remove(struct vsctl_context *ctx)
3455 const char *table_name = ctx->argv[1];
3456 const char *column_name = ctx->argv[3];
3457 const struct vsctl_table_class *table;
3458 const struct ovsdb_idl_column *column;
3460 table = pre_get_table(ctx, table_name);
3461 pre_get_column(ctx, table, column_name, &column);
3462 check_mutable(table, column);
3466 cmd_remove(struct vsctl_context *ctx)
3468 bool must_exist = !shash_find(&ctx->options, "--if-exists");
3469 const char *table_name = ctx->argv[1];
3470 const char *record_id = ctx->argv[2];
3471 const char *column_name = ctx->argv[3];
3472 const struct vsctl_table_class *table;
3473 const struct ovsdb_idl_column *column;
3474 const struct ovsdb_idl_row *row;
3475 const struct ovsdb_type *type;
3476 struct ovsdb_datum old;
3479 table = get_table(table_name);
3480 die_if_error(get_column(table, column_name, &column));
3481 row = get_row(ctx, table, record_id, must_exist);
3486 type = &column->type;
3487 ovsdb_datum_clone(&old, ovsdb_idl_read(row, column), &column->type);
3488 for (i = 4; i < ctx->argc; i++) {
3489 struct ovsdb_type rm_type;
3490 struct ovsdb_datum rm;
3495 rm_type.n_max = UINT_MAX;
3496 error = ovsdb_datum_from_string(&rm, &rm_type,
3497 ctx->argv[i], ctx->symtab);
3498 if (error && ovsdb_type_is_map(&rm_type)) {
3500 rm_type.value.type = OVSDB_TYPE_VOID;
3501 die_if_error(ovsdb_datum_from_string(&rm, &rm_type,
3502 ctx->argv[i], ctx->symtab));
3504 ovsdb_datum_subtract(&old, type, &rm, &rm_type);
3505 ovsdb_datum_destroy(&rm, &rm_type);
3507 if (old.n < type->n_min) {
3508 vsctl_fatal("\"remove\" operation would put %u %s in column %s of "
3509 "table %s but the minimum number is %u",
3511 type->value.type == OVSDB_TYPE_VOID ? "values" : "pairs",
3512 column->name, table->class->name, type->n_min);
3514 ovsdb_idl_txn_verify(row, column);
3515 ovsdb_idl_txn_write(row, column, &old);
3517 vsctl_context_invalidate_cache(ctx);
3521 pre_cmd_clear(struct vsctl_context *ctx)
3523 const char *table_name = ctx->argv[1];
3524 const struct vsctl_table_class *table;
3527 table = pre_get_table(ctx, table_name);
3528 for (i = 3; i < ctx->argc; i++) {
3529 const struct ovsdb_idl_column *column;
3531 pre_get_column(ctx, table, ctx->argv[i], &column);
3532 check_mutable(table, column);
3537 cmd_clear(struct vsctl_context *ctx)
3539 bool must_exist = !shash_find(&ctx->options, "--if-exists");
3540 const char *table_name = ctx->argv[1];
3541 const char *record_id = ctx->argv[2];
3542 const struct vsctl_table_class *table;
3543 const struct ovsdb_idl_row *row;
3546 table = get_table(table_name);
3547 row = get_row(ctx, table, record_id, must_exist);
3552 for (i = 3; i < ctx->argc; i++) {
3553 const struct ovsdb_idl_column *column;
3554 const struct ovsdb_type *type;
3555 struct ovsdb_datum datum;
3557 die_if_error(get_column(table, ctx->argv[i], &column));
3559 type = &column->type;
3560 if (type->n_min > 0) {
3561 vsctl_fatal("\"clear\" operation cannot be applied to column %s "
3562 "of table %s, which is not allowed to be empty",
3563 column->name, table->class->name);
3566 ovsdb_datum_init_empty(&datum);
3567 ovsdb_idl_txn_write(row, column, &datum);
3570 vsctl_context_invalidate_cache(ctx);
3574 pre_create(struct vsctl_context *ctx)
3576 const char *id = shash_find_data(&ctx->options, "--id");
3577 const char *table_name = ctx->argv[1];
3578 const struct vsctl_table_class *table;
3580 table = get_table(table_name);
3581 if (!id && !table->class->is_root) {
3582 VLOG_WARN("applying \"create\" command to table %s without --id "
3583 "option will have no effect", table->class->name);
3588 cmd_create(struct vsctl_context *ctx)
3590 const char *id = shash_find_data(&ctx->options, "--id");
3591 const char *table_name = ctx->argv[1];
3592 const struct vsctl_table_class *table = get_table(table_name);
3593 const struct ovsdb_idl_row *row;
3594 const struct uuid *uuid;
3598 struct ovsdb_symbol *symbol = create_symbol(ctx->symtab, id, NULL);
3599 if (table->class->is_root) {
3600 /* This table is in the root set, meaning that rows created in it
3601 * won't disappear even if they are unreferenced, so disable
3602 * warnings about that by pretending that there is a reference. */
3603 symbol->strong_ref = true;
3605 uuid = &symbol->uuid;
3610 row = ovsdb_idl_txn_insert(ctx->txn, table->class, uuid);
3611 for (i = 2; i < ctx->argc; i++) {
3612 set_column(table, row, ctx->argv[i], ctx->symtab);
3614 ds_put_format(&ctx->output, UUID_FMT, UUID_ARGS(&row->uuid));
3617 /* This function may be used as the 'postprocess' function for commands that
3618 * insert new rows into the database. It expects that the command's 'run'
3619 * function prints the UUID reported by ovsdb_idl_txn_insert() as the command's
3620 * sole output. It replaces that output by the row's permanent UUID assigned
3621 * by the database server and appends a new-line.
3623 * Currently we use this only for "create", because the higher-level commands
3624 * are supposed to be independent of the actual structure of the vswitch
3627 post_create(struct vsctl_context *ctx)
3629 const struct uuid *real;
3632 if (!uuid_from_string(&dummy, ds_cstr(&ctx->output))) {
3635 real = ovsdb_idl_txn_get_insert_uuid(ctx->txn, &dummy);
3637 ds_clear(&ctx->output);
3638 ds_put_format(&ctx->output, UUID_FMT, UUID_ARGS(real));
3640 ds_put_char(&ctx->output, '\n');
3644 pre_cmd_destroy(struct vsctl_context *ctx)
3646 const char *table_name = ctx->argv[1];
3648 pre_get_table(ctx, table_name);
3652 cmd_destroy(struct vsctl_context *ctx)
3654 bool must_exist = !shash_find(&ctx->options, "--if-exists");
3655 bool delete_all = shash_find(&ctx->options, "--all");
3656 const char *table_name = ctx->argv[1];
3657 const struct vsctl_table_class *table;
3660 table = get_table(table_name);
3662 if (delete_all && ctx->argc > 2) {
3663 vsctl_fatal("--all and records argument should not be specified together");
3666 if (delete_all && !must_exist) {
3667 vsctl_fatal("--all and --if-exists should not be specified together");
3671 const struct ovsdb_idl_row *row;
3672 const struct ovsdb_idl_row *next_row;
3674 for (row = ovsdb_idl_first_row(ctx->idl, table->class);
3676 next_row = ovsdb_idl_next_row(row);
3677 ovsdb_idl_txn_delete(row);
3681 for (i = 2; i < ctx->argc; i++) {
3682 const struct ovsdb_idl_row *row;
3684 row = get_row(ctx, table, ctx->argv[i], must_exist);
3686 ovsdb_idl_txn_delete(row);
3690 vsctl_context_invalidate_cache(ctx);
3694 RELOP(RELOP_EQ, "=") \
3695 RELOP(RELOP_NE, "!=") \
3696 RELOP(RELOP_LT, "<") \
3697 RELOP(RELOP_GT, ">") \
3698 RELOP(RELOP_LE, "<=") \
3699 RELOP(RELOP_GE, ">=") \
3700 RELOP(RELOP_SET_EQ, "{=}") \
3701 RELOP(RELOP_SET_NE, "{!=}") \
3702 RELOP(RELOP_SET_LT, "{<}") \
3703 RELOP(RELOP_SET_GT, "{>}") \
3704 RELOP(RELOP_SET_LE, "{<=}") \
3705 RELOP(RELOP_SET_GE, "{>=}")
3708 #define RELOP(ENUM, STRING) ENUM,
3714 is_set_operator(enum relop op)
3716 return (op == RELOP_SET_EQ || op == RELOP_SET_NE ||
3717 op == RELOP_SET_LT || op == RELOP_SET_GT ||
3718 op == RELOP_SET_LE || op == RELOP_SET_GE);
3722 evaluate_relop(const struct ovsdb_datum *a, const struct ovsdb_datum *b,
3723 const struct ovsdb_type *type, enum relop op)
3728 return ovsdb_datum_compare_3way(a, b, type) == 0;
3731 return ovsdb_datum_compare_3way(a, b, type) != 0;
3733 return ovsdb_datum_compare_3way(a, b, type) < 0;
3735 return ovsdb_datum_compare_3way(a, b, type) > 0;
3737 return ovsdb_datum_compare_3way(a, b, type) <= 0;
3739 return ovsdb_datum_compare_3way(a, b, type) >= 0;
3742 return b->n > a->n && ovsdb_datum_includes_all(a, b, type);
3744 return a->n > b->n && ovsdb_datum_includes_all(b, a, type);
3746 return ovsdb_datum_includes_all(a, b, type);
3748 return ovsdb_datum_includes_all(b, a, type);
3756 is_condition_satisfied(const struct vsctl_table_class *table,
3757 const struct ovsdb_idl_row *row, const char *arg,
3758 struct ovsdb_symbol_table *symtab)
3760 static const char *operators[] = {
3761 #define RELOP(ENUM, STRING) STRING,
3766 const struct ovsdb_idl_column *column;
3767 const struct ovsdb_datum *have_datum;
3768 char *key_string, *value_string;
3769 struct ovsdb_type type;
3774 error = parse_column_key_value(arg, table, &column, &key_string,
3775 &operator, operators, ARRAY_SIZE(operators),
3777 die_if_error(error);
3778 if (!value_string) {
3779 vsctl_fatal("%s: missing value", arg);
3782 type = column->type;
3783 type.n_max = UINT_MAX;
3785 have_datum = ovsdb_idl_read(row, column);
3787 union ovsdb_atom want_key;
3788 struct ovsdb_datum b;
3791 if (column->type.value.type == OVSDB_TYPE_VOID) {
3792 vsctl_fatal("cannot specify key to check for non-map column %s",
3796 die_if_error(ovsdb_atom_from_string(&want_key, &column->type.key,
3797 key_string, symtab));
3799 type.key = type.value;
3800 type.value.type = OVSDB_TYPE_VOID;
3801 die_if_error(ovsdb_datum_from_string(&b, &type, value_string, symtab));
3803 idx = ovsdb_datum_find_key(have_datum,
3804 &want_key, column->type.key.type);
3805 if (idx == UINT_MAX && !is_set_operator(operator)) {
3808 struct ovsdb_datum a;
3810 if (idx != UINT_MAX) {
3812 a.keys = &have_datum->values[idx];
3820 retval = evaluate_relop(&a, &b, &type, operator);
3823 ovsdb_atom_destroy(&want_key, column->type.key.type);
3824 ovsdb_datum_destroy(&b, &type);
3826 struct ovsdb_datum want_datum;
3828 die_if_error(ovsdb_datum_from_string(&want_datum, &column->type,
3829 value_string, symtab));
3830 retval = evaluate_relop(have_datum, &want_datum, &type, operator);
3831 ovsdb_datum_destroy(&want_datum, &column->type);
3841 pre_cmd_wait_until(struct vsctl_context *ctx)
3843 const char *table_name = ctx->argv[1];
3844 const struct vsctl_table_class *table;
3847 table = pre_get_table(ctx, table_name);
3849 for (i = 3; i < ctx->argc; i++) {
3850 pre_parse_column_key_value(ctx, ctx->argv[i], table);
3855 cmd_wait_until(struct vsctl_context *ctx)
3857 const char *table_name = ctx->argv[1];
3858 const char *record_id = ctx->argv[2];
3859 const struct vsctl_table_class *table;
3860 const struct ovsdb_idl_row *row;
3863 table = get_table(table_name);
3865 row = get_row(ctx, table, record_id, false);
3867 ctx->try_again = true;
3871 for (i = 3; i < ctx->argc; i++) {
3872 if (!is_condition_satisfied(table, row, ctx->argv[i], ctx->symtab)) {
3873 ctx->try_again = true;
3879 /* Prepares 'ctx', which has already been initialized with
3880 * vsctl_context_init(), for processing 'command'. */
3882 vsctl_context_init_command(struct vsctl_context *ctx,
3883 struct vsctl_command *command)
3885 ctx->argc = command->argc;
3886 ctx->argv = command->argv;
3887 ctx->options = command->options;
3889 ds_swap(&ctx->output, &command->output);
3890 ctx->table = command->table;
3892 ctx->verified_ports = false;
3894 ctx->try_again = false;
3897 /* Prepares 'ctx' for processing commands, initializing its members with the
3898 * values passed in as arguments.
3900 * If 'command' is nonnull, calls vsctl_context_init_command() to prepare for
3901 * that particular command. */
3903 vsctl_context_init(struct vsctl_context *ctx, struct vsctl_command *command,
3904 struct ovsdb_idl *idl, struct ovsdb_idl_txn *txn,
3905 const struct ovsrec_open_vswitch *ovs,
3906 struct ovsdb_symbol_table *symtab)
3909 vsctl_context_init_command(ctx, command);
3914 ctx->symtab = symtab;
3915 ctx->cache_valid = false;
3918 /* Completes processing of 'command' within 'ctx'. */
3920 vsctl_context_done_command(struct vsctl_context *ctx,
3921 struct vsctl_command *command)
3923 ds_swap(&ctx->output, &command->output);
3924 command->table = ctx->table;
3927 /* Finishes up with 'ctx'.
3929 * If command is nonnull, first calls vsctl_context_done_command() to complete
3930 * processing that command within 'ctx'. */
3932 vsctl_context_done(struct vsctl_context *ctx, struct vsctl_command *command)
3935 vsctl_context_done_command(ctx, command);
3937 vsctl_context_invalidate_cache(ctx);
3941 run_prerequisites(struct vsctl_command *commands, size_t n_commands,
3942 struct ovsdb_idl *idl)
3944 struct vsctl_command *c;
3946 ovsdb_idl_add_table(idl, &ovsrec_table_open_vswitch);
3947 if (wait_for_reload) {
3948 ovsdb_idl_add_column(idl, &ovsrec_open_vswitch_col_cur_cfg);
3950 for (c = commands; c < &commands[n_commands]; c++) {
3951 if (c->syntax->prerequisites) {
3952 struct vsctl_context ctx;
3954 ds_init(&c->output);
3957 vsctl_context_init(&ctx, c, idl, NULL, NULL, NULL);
3958 (c->syntax->prerequisites)(&ctx);
3959 vsctl_context_done(&ctx, c);
3961 ovs_assert(!c->output.string);
3962 ovs_assert(!c->table);
3968 do_vsctl(const char *args, struct vsctl_command *commands, size_t n_commands,
3969 struct ovsdb_idl *idl)
3971 struct ovsdb_idl_txn *txn;
3972 const struct ovsrec_open_vswitch *ovs;
3973 enum ovsdb_idl_txn_status status;
3974 struct ovsdb_symbol_table *symtab;
3975 struct vsctl_context ctx;
3976 struct vsctl_command *c;
3977 struct shash_node *node;
3978 int64_t next_cfg = 0;
3981 txn = the_idl_txn = ovsdb_idl_txn_create(idl);
3983 ovsdb_idl_txn_set_dry_run(txn);
3986 ovsdb_idl_txn_add_comment(txn, "ovs-vsctl: %s", args);
3988 ovs = ovsrec_open_vswitch_first(idl);
3990 /* XXX add verification that table is empty */
3991 ovs = ovsrec_open_vswitch_insert(txn);
3994 if (wait_for_reload) {
3995 ovsdb_idl_txn_increment(txn, &ovs->header_,
3996 &ovsrec_open_vswitch_col_next_cfg);
3999 symtab = ovsdb_symbol_table_create();
4000 for (c = commands; c < &commands[n_commands]; c++) {
4001 ds_init(&c->output);
4004 vsctl_context_init(&ctx, NULL, idl, txn, ovs, symtab);
4005 for (c = commands; c < &commands[n_commands]; c++) {
4006 vsctl_context_init_command(&ctx, c);
4007 if (c->syntax->run) {
4008 (c->syntax->run)(&ctx);
4010 vsctl_context_done_command(&ctx, c);
4012 if (ctx.try_again) {
4013 vsctl_context_done(&ctx, NULL);
4017 vsctl_context_done(&ctx, NULL);
4019 SHASH_FOR_EACH (node, &symtab->sh) {
4020 struct ovsdb_symbol *symbol = node->data;
4021 if (!symbol->created) {
4022 vsctl_fatal("row id \"%s\" is referenced but never created (e.g. "
4023 "with \"-- --id=%s create ...\")",
4024 node->name, node->name);
4026 if (!symbol->strong_ref) {
4027 if (!symbol->weak_ref) {
4028 VLOG_WARN("row id \"%s\" was created but no reference to it "
4029 "was inserted, so it will not actually appear in "
4030 "the database", node->name);
4032 VLOG_WARN("row id \"%s\" was created but only a weak "
4033 "reference to it was inserted, so it will not "
4034 "actually appear in the database", node->name);
4039 status = ovsdb_idl_txn_commit_block(txn);
4040 if (wait_for_reload && status == TXN_SUCCESS) {
4041 next_cfg = ovsdb_idl_txn_get_increment_new_value(txn);
4043 if (status == TXN_UNCHANGED || status == TXN_SUCCESS) {
4044 for (c = commands; c < &commands[n_commands]; c++) {
4045 if (c->syntax->postprocess) {
4046 struct vsctl_context ctx;
4048 vsctl_context_init(&ctx, c, idl, txn, ovs, symtab);
4049 (c->syntax->postprocess)(&ctx);
4050 vsctl_context_done(&ctx, c);
4054 error = xstrdup(ovsdb_idl_txn_get_error(txn));
4055 ovsdb_idl_txn_destroy(txn);
4056 txn = the_idl_txn = NULL;
4059 case TXN_UNCOMMITTED:
4060 case TXN_INCOMPLETE:
4064 /* Should not happen--we never call ovsdb_idl_txn_abort(). */
4065 vsctl_fatal("transaction aborted");
4075 vsctl_fatal("transaction error: %s", error);
4077 case TXN_NOT_LOCKED:
4078 /* Should not happen--we never call ovsdb_idl_set_lock(). */
4079 vsctl_fatal("database not locked");
4086 ovsdb_symbol_table_destroy(symtab);
4088 for (c = commands; c < &commands[n_commands]; c++) {
4089 struct ds *ds = &c->output;
4092 table_print(c->table, &table_style);
4093 } else if (oneline) {
4097 for (j = 0; j < ds->length; j++) {
4098 int ch = ds->string[j];
4101 fputs("\\n", stdout);
4105 fputs("\\\\", stdout);
4114 fputs(ds_cstr(ds), stdout);
4116 ds_destroy(&c->output);
4117 table_destroy(c->table);
4120 shash_destroy_free_data(&c->options);
4124 if (wait_for_reload && status != TXN_UNCHANGED) {
4127 OVSREC_OPEN_VSWITCH_FOR_EACH (ovs, idl) {
4128 if (ovs->cur_cfg >= next_cfg) {
4132 ovsdb_idl_wait(idl);
4137 ovsdb_idl_destroy(idl);
4142 /* Our transaction needs to be rerun, or a prerequisite was not met. Free
4143 * resources and return so that the caller can try again. */
4145 ovsdb_idl_txn_abort(txn);
4146 ovsdb_idl_txn_destroy(txn);
4149 ovsdb_symbol_table_destroy(symtab);
4150 for (c = commands; c < &commands[n_commands]; c++) {
4151 ds_destroy(&c->output);
4152 table_destroy(c->table);
4158 static const struct vsctl_command_syntax all_commands[] = {
4159 /* Open vSwitch commands. */
4160 {"init", 0, 0, NULL, cmd_init, NULL, "", RW},
4161 {"show", 0, 0, pre_cmd_show, cmd_show, NULL, "", RO},
4163 /* Bridge commands. */
4164 {"add-br", 1, 3, pre_get_info, cmd_add_br, NULL, "--may-exist", RW},
4165 {"del-br", 1, 1, pre_get_info, cmd_del_br, NULL, "--if-exists", RW},
4166 {"list-br", 0, 0, pre_get_info, cmd_list_br, NULL, "--real,--fake", RO},
4167 {"br-exists", 1, 1, pre_get_info, cmd_br_exists, NULL, "", RO},
4168 {"br-to-vlan", 1, 1, pre_get_info, cmd_br_to_vlan, NULL, "", RO},
4169 {"br-to-parent", 1, 1, pre_get_info, cmd_br_to_parent, NULL, "", RO},
4170 {"br-set-external-id", 2, 3, pre_cmd_br_set_external_id,
4171 cmd_br_set_external_id, NULL, "", RW},
4172 {"br-get-external-id", 1, 2, pre_cmd_br_get_external_id,
4173 cmd_br_get_external_id, NULL, "", RO},
4175 /* Port commands. */
4176 {"list-ports", 1, 1, pre_get_info, cmd_list_ports, NULL, "", RO},
4177 {"add-port", 2, INT_MAX, pre_get_info, cmd_add_port, NULL, "--may-exist",
4179 {"add-bond", 4, INT_MAX, pre_get_info, cmd_add_bond, NULL,
4180 "--may-exist,--fake-iface", RW},
4181 {"del-port", 1, 2, pre_get_info, cmd_del_port, NULL,
4182 "--if-exists,--with-iface", RW},
4183 {"port-to-br", 1, 1, pre_get_info, cmd_port_to_br, NULL, "", RO},
4185 /* Interface commands. */
4186 {"list-ifaces", 1, 1, pre_get_info, cmd_list_ifaces, NULL, "", RO},
4187 {"iface-to-br", 1, 1, pre_get_info, cmd_iface_to_br, NULL, "", RO},
4189 /* Controller commands. */
4190 {"get-controller", 1, 1, pre_controller, cmd_get_controller, NULL, "", RO},
4191 {"del-controller", 1, 1, pre_controller, cmd_del_controller, NULL, "", RW},
4192 {"set-controller", 1, INT_MAX, pre_controller, cmd_set_controller, NULL,
4194 {"get-fail-mode", 1, 1, pre_get_info, cmd_get_fail_mode, NULL, "", RO},
4195 {"del-fail-mode", 1, 1, pre_get_info, cmd_del_fail_mode, NULL, "", RW},
4196 {"set-fail-mode", 2, 2, pre_get_info, cmd_set_fail_mode, NULL, "", RW},
4198 /* Manager commands. */
4199 {"get-manager", 0, 0, pre_manager, cmd_get_manager, NULL, "", RO},
4200 {"del-manager", 0, 0, pre_manager, cmd_del_manager, NULL, "", RW},
4201 {"set-manager", 1, INT_MAX, pre_manager, cmd_set_manager, NULL, "", RW},
4204 {"get-ssl", 0, 0, pre_cmd_get_ssl, cmd_get_ssl, NULL, "", RO},
4205 {"del-ssl", 0, 0, pre_cmd_del_ssl, cmd_del_ssl, NULL, "", RW},
4206 {"set-ssl", 3, 3, pre_cmd_set_ssl, cmd_set_ssl, NULL, "--bootstrap", RW},
4208 /* Switch commands. */
4209 {"emer-reset", 0, 0, pre_cmd_emer_reset, cmd_emer_reset, NULL, "", RW},
4211 /* Database commands. */
4212 {"comment", 0, INT_MAX, NULL, NULL, NULL, "", RO},
4213 {"get", 2, INT_MAX, pre_cmd_get, cmd_get, NULL, "--if-exists,--id=", RO},
4214 {"list", 1, INT_MAX, pre_cmd_list, cmd_list, NULL,
4215 "--if-exists,--columns=", RO},
4216 {"find", 1, INT_MAX, pre_cmd_find, cmd_find, NULL, "--columns=", RO},
4217 {"set", 3, INT_MAX, pre_cmd_set, cmd_set, NULL, "--if-exists", RW},
4218 {"add", 4, INT_MAX, pre_cmd_add, cmd_add, NULL, "--if-exists", RW},
4219 {"remove", 4, INT_MAX, pre_cmd_remove, cmd_remove, NULL, "--if-exists",
4221 {"clear", 3, INT_MAX, pre_cmd_clear, cmd_clear, NULL, "--if-exists", RW},
4222 {"create", 2, INT_MAX, pre_create, cmd_create, post_create, "--id=", RW},
4223 {"destroy", 1, INT_MAX, pre_cmd_destroy, cmd_destroy, NULL,
4224 "--if-exists,--all", RW},
4225 {"wait-until", 2, INT_MAX, pre_cmd_wait_until, cmd_wait_until, NULL, "",
4228 {NULL, 0, 0, NULL, NULL, NULL, NULL, RO},
4231 static const struct vsctl_command_syntax *get_all_commands(void)
4233 return all_commands;