1 /* Copyright (c) 2008, 2009, 2010 Nicira Networks
3 * Licensed under the Apache License, Version 2.0 (the "License");
4 * you may not use this file except in compliance with the License.
5 * You may obtain a copy of the License at:
7 * http://www.apache.org/licenses/LICENSE-2.0
9 * Unless required by applicable law or agreed to in writing, software
10 * distributed under the License is distributed on an "AS IS" BASIS,
11 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 * See the License for the specific language governing permissions and
13 * limitations under the License.
20 #include <arpa/inet.h>
23 #include <sys/socket.h>
25 #include <openflow/openflow.h>
30 #include <sys/socket.h>
31 #include <sys/types.h>
37 #include "dynamic-string.h"
42 #include "mac-learning.h"
45 #include "ofp-print.h"
47 #include "ofproto/netflow.h"
48 #include "ofproto/ofproto.h"
49 #include "ovsdb-data.h"
51 #include "poll-loop.h"
52 #include "port-array.h"
53 #include "proc-net-compat.h"
57 #include "socket-util.h"
58 #include "stream-ssl.h"
64 #include "vswitchd/vswitch-idl.h"
65 #include "xenserver.h"
68 #include "sflow_api.h"
70 VLOG_DEFINE_THIS_MODULE(bridge)
78 /* These members are always valid. */
79 struct port *port; /* Containing port. */
80 size_t port_ifidx; /* Index within containing port. */
81 char *name; /* Host network device name. */
82 tag_type tag; /* Tag associated with this interface. */
83 long long delay_expires; /* Time after which 'enabled' may change. */
85 /* These members are valid only after bridge_reconfigure() causes them to
87 int dp_ifidx; /* Index within kernel datapath. */
88 struct netdev *netdev; /* Network device. */
89 bool enabled; /* May be chosen for flows? */
90 const struct ovsrec_interface *cfg;
93 #define BOND_MASK 0xff
95 int iface_idx; /* Index of assigned iface, or -1 if none. */
96 uint64_t tx_bytes; /* Count of bytes recently transmitted. */
97 tag_type iface_tag; /* Tag associated with iface_idx. */
100 #define MAX_MIRRORS 32
101 typedef uint32_t mirror_mask_t;
102 #define MIRROR_MASK_C(X) UINT32_C(X)
103 BUILD_ASSERT_DECL(sizeof(mirror_mask_t) * CHAR_BIT >= MAX_MIRRORS);
105 struct bridge *bridge;
108 struct uuid uuid; /* UUID of this "mirror" record in database. */
110 /* Selection criteria. */
111 struct shash src_ports; /* Name is port name; data is always NULL. */
112 struct shash dst_ports; /* Name is port name; data is always NULL. */
117 struct port *out_port;
121 #define FLOOD_PORT ((struct port *) 1) /* The 'flood' output port. */
123 struct bridge *bridge;
125 int vlan; /* -1=trunk port, else a 12-bit VLAN ID. */
126 unsigned long *trunks; /* Bitmap of trunked VLANs, if 'vlan' == -1.
127 * NULL if all VLANs are trunked. */
128 const struct ovsrec_port *cfg;
131 /* An ordinary bridge port has 1 interface.
132 * A bridge port for bonding has at least 2 interfaces. */
133 struct iface **ifaces;
134 size_t n_ifaces, allocated_ifaces;
137 struct bond_entry *bond_hash; /* An array of (BOND_MASK + 1) elements. */
138 int active_iface; /* Ifidx on which bcasts accepted, or -1. */
139 tag_type active_iface_tag; /* Tag for bcast flows. */
140 tag_type no_ifaces_tag; /* Tag for flows when all ifaces disabled. */
141 int updelay, downdelay; /* Delay before iface goes up/down, in ms. */
142 bool bond_compat_is_stale; /* Need to call port_update_bond_compat()? */
143 bool bond_fake_iface; /* Fake a bond interface for legacy compat? */
144 long bond_next_fake_iface_update; /* Next update to fake bond stats. */
145 int bond_rebalance_interval; /* Interval between rebalances, in ms. */
146 long long int bond_next_rebalance; /* Next rebalancing time. */
148 /* Port mirroring info. */
149 mirror_mask_t src_mirrors; /* Mirrors triggered when packet received. */
150 mirror_mask_t dst_mirrors; /* Mirrors triggered when packet sent. */
151 bool is_mirror_output_port; /* Does port mirroring send frames here? */
154 #define DP_MAX_PORTS 255
156 struct list node; /* Node in global list of bridges. */
157 char *name; /* User-specified arbitrary name. */
158 struct mac_learning *ml; /* MAC learning table. */
159 uint8_t default_ea[ETH_ADDR_LEN]; /* Default MAC. */
160 const struct ovsrec_bridge *cfg;
162 /* OpenFlow switch processing. */
163 struct ofproto *ofproto; /* OpenFlow switch. */
165 /* Kernel datapath information. */
166 struct dpif *dpif; /* Datapath. */
167 struct port_array ifaces; /* Indexed by kernel datapath port number. */
171 size_t n_ports, allocated_ports;
172 struct shash iface_by_name; /* "struct iface"s indexed by name. */
173 struct shash port_by_name; /* "struct port"s indexed by name. */
176 bool has_bonded_ports;
181 /* Port mirroring. */
182 struct mirror *mirrors[MAX_MIRRORS];
185 /* List of all bridges. */
186 static struct list all_bridges = LIST_INITIALIZER(&all_bridges);
188 /* OVSDB IDL used to obtain configuration. */
189 static struct ovsdb_idl *idl;
191 /* Each time this timer expires, the bridge fetches statistics for every
192 * interface and pushes them into the database. */
193 #define IFACE_STATS_INTERVAL (5 * 1000) /* In milliseconds. */
194 static long long int iface_stats_timer = LLONG_MIN;
196 static struct bridge *bridge_create(const struct ovsrec_bridge *br_cfg);
197 static void bridge_destroy(struct bridge *);
198 static struct bridge *bridge_lookup(const char *name);
199 static unixctl_cb_func bridge_unixctl_dump_flows;
200 static unixctl_cb_func bridge_unixctl_reconnect;
201 static int bridge_run_one(struct bridge *);
202 static size_t bridge_get_controllers(const struct bridge *br,
203 struct ovsrec_controller ***controllersp);
204 static void bridge_reconfigure_one(struct bridge *);
205 static void bridge_reconfigure_remotes(struct bridge *,
206 const struct sockaddr_in *managers,
208 static void bridge_get_all_ifaces(const struct bridge *, struct shash *ifaces);
209 static void bridge_fetch_dp_ifaces(struct bridge *);
210 static void bridge_flush(struct bridge *);
211 static void bridge_pick_local_hw_addr(struct bridge *,
212 uint8_t ea[ETH_ADDR_LEN],
213 struct iface **hw_addr_iface);
214 static uint64_t bridge_pick_datapath_id(struct bridge *,
215 const uint8_t bridge_ea[ETH_ADDR_LEN],
216 struct iface *hw_addr_iface);
217 static struct iface *bridge_get_local_iface(struct bridge *);
218 static uint64_t dpid_from_hash(const void *, size_t nbytes);
220 static unixctl_cb_func bridge_unixctl_fdb_show;
222 static void bond_init(void);
223 static void bond_run(struct bridge *);
224 static void bond_wait(struct bridge *);
225 static void bond_rebalance_port(struct port *);
226 static void bond_send_learning_packets(struct port *);
227 static void bond_enable_slave(struct iface *iface, bool enable);
229 static struct port *port_create(struct bridge *, const char *name);
230 static void port_reconfigure(struct port *, const struct ovsrec_port *);
231 static void port_del_ifaces(struct port *, const struct ovsrec_port *);
232 static void port_destroy(struct port *);
233 static struct port *port_lookup(const struct bridge *, const char *name);
234 static struct iface *port_lookup_iface(const struct port *, const char *name);
235 static struct port *port_from_dp_ifidx(const struct bridge *,
237 static void port_update_bond_compat(struct port *);
238 static void port_update_vlan_compat(struct port *);
239 static void port_update_bonding(struct port *);
241 static void mirror_create(struct bridge *, struct ovsrec_mirror *);
242 static void mirror_destroy(struct mirror *);
243 static void mirror_reconfigure(struct bridge *);
244 static void mirror_reconfigure_one(struct mirror *, struct ovsrec_mirror *);
245 static bool vlan_is_mirrored(const struct mirror *, int vlan);
247 static struct iface *iface_create(struct port *port,
248 const struct ovsrec_interface *if_cfg);
249 static void iface_destroy(struct iface *);
250 static struct iface *iface_lookup(const struct bridge *, const char *name);
251 static struct iface *iface_from_dp_ifidx(const struct bridge *,
253 static bool iface_is_internal(const struct bridge *, const char *name);
254 static void iface_set_mac(struct iface *);
255 static void iface_update_qos(struct iface *, const struct ovsrec_qos *);
257 /* Hooks into ofproto processing. */
258 static struct ofhooks bridge_ofhooks;
260 /* Public functions. */
262 /* Initializes the bridge module, configuring it to obtain its configuration
263 * from an OVSDB server accessed over 'remote', which should be a string in a
264 * form acceptable to ovsdb_idl_create(). */
266 bridge_init(const char *remote)
268 /* Create connection to database. */
269 idl = ovsdb_idl_create(remote, &ovsrec_idl_class);
271 /* Register unixctl commands. */
272 unixctl_command_register("fdb/show", bridge_unixctl_fdb_show, NULL);
273 unixctl_command_register("bridge/dump-flows", bridge_unixctl_dump_flows,
275 unixctl_command_register("bridge/reconnect", bridge_unixctl_reconnect,
280 /* Performs configuration that is only necessary once at ovs-vswitchd startup,
281 * but for which the ovs-vswitchd configuration 'cfg' is required. */
283 bridge_configure_once(const struct ovsrec_open_vswitch *cfg)
285 static bool already_configured_once;
286 struct svec bridge_names;
287 struct svec dpif_names, dpif_types;
290 /* Only do this once per ovs-vswitchd run. */
291 if (already_configured_once) {
294 already_configured_once = true;
296 iface_stats_timer = time_msec() + IFACE_STATS_INTERVAL;
298 /* Get all the configured bridges' names from 'cfg' into 'bridge_names'. */
299 svec_init(&bridge_names);
300 for (i = 0; i < cfg->n_bridges; i++) {
301 svec_add(&bridge_names, cfg->bridges[i]->name);
303 svec_sort(&bridge_names);
305 /* Iterate over all system dpifs and delete any of them that do not appear
307 svec_init(&dpif_names);
308 svec_init(&dpif_types);
309 dp_enumerate_types(&dpif_types);
310 for (i = 0; i < dpif_types.n; i++) {
315 dp_enumerate_names(dpif_types.names[i], &dpif_names);
317 /* For each dpif... */
318 for (j = 0; j < dpif_names.n; j++) {
319 retval = dpif_open(dpif_names.names[j], dpif_types.names[i], &dpif);
321 struct svec all_names;
324 /* ...check whether any of its names is in 'bridge_names'. */
325 svec_init(&all_names);
326 dpif_get_all_names(dpif, &all_names);
327 for (k = 0; k < all_names.n; k++) {
328 if (svec_contains(&bridge_names, all_names.names[k])) {
333 /* No. Delete the dpif. */
337 svec_destroy(&all_names);
342 svec_destroy(&bridge_names);
343 svec_destroy(&dpif_names);
344 svec_destroy(&dpif_types);
347 /* Attempt to create the network device 'iface_name' through the netdev
350 set_up_iface(const struct ovsrec_interface *iface_cfg, struct iface *iface,
353 struct shash options;
357 shash_init(&options);
358 for (i = 0; i < iface_cfg->n_options; i++) {
359 shash_add(&options, iface_cfg->key_options[i],
360 xstrdup(iface_cfg->value_options[i]));
364 struct netdev_options netdev_options;
366 memset(&netdev_options, 0, sizeof netdev_options);
367 netdev_options.name = iface_cfg->name;
368 if (!strcmp(iface_cfg->type, "internal")) {
369 /* An "internal" config type maps to a netdev "system" type. */
370 netdev_options.type = "system";
372 netdev_options.type = iface_cfg->type;
374 netdev_options.args = &options;
375 netdev_options.ethertype = NETDEV_ETH_TYPE_NONE;
377 error = netdev_open(&netdev_options, &iface->netdev);
380 netdev_get_carrier(iface->netdev, &iface->enabled);
382 } else if (iface->netdev) {
383 const char *netdev_type = netdev_get_type(iface->netdev);
384 const char *iface_type = iface_cfg->type && strlen(iface_cfg->type)
385 ? iface_cfg->type : NULL;
387 /* An "internal" config type maps to a netdev "system" type. */
388 if (iface_type && !strcmp(iface_type, "internal")) {
389 iface_type = "system";
392 if (!iface_type || !strcmp(netdev_type, iface_type)) {
393 error = netdev_reconfigure(iface->netdev, &options);
395 VLOG_WARN("%s: attempting change device type from %s to %s",
396 iface_cfg->name, netdev_type, iface_type);
400 shash_destroy_free_data(&options);
406 reconfigure_iface(const struct ovsrec_interface *iface_cfg, struct iface *iface)
408 return set_up_iface(iface_cfg, iface, false);
412 check_iface_netdev(struct bridge *br OVS_UNUSED, struct iface *iface,
413 void *aux OVS_UNUSED)
415 if (!iface->netdev) {
416 int error = set_up_iface(iface->cfg, iface, true);
418 VLOG_WARN("could not open netdev on %s, dropping: %s", iface->name,
428 check_iface_dp_ifidx(struct bridge *br, struct iface *iface,
429 void *aux OVS_UNUSED)
431 if (iface->dp_ifidx >= 0) {
432 VLOG_DBG("%s has interface %s on port %d",
434 iface->name, iface->dp_ifidx);
437 VLOG_ERR("%s interface not in %s, dropping",
438 iface->name, dpif_name(br->dpif));
444 set_iface_properties(struct bridge *br OVS_UNUSED, struct iface *iface,
445 void *aux OVS_UNUSED)
447 /* Set policing attributes. */
448 netdev_set_policing(iface->netdev,
449 iface->cfg->ingress_policing_rate,
450 iface->cfg->ingress_policing_burst);
452 /* Set MAC address of internal interfaces other than the local
454 if (iface->dp_ifidx != ODPP_LOCAL
455 && iface_is_internal(br, iface->name)) {
456 iface_set_mac(iface);
462 /* Calls 'cb' for each interfaces in 'br', passing along the 'aux' argument.
463 * Deletes from 'br' all the interfaces for which 'cb' returns false, and then
464 * deletes from 'br' any ports that no longer have any interfaces. */
466 iterate_and_prune_ifaces(struct bridge *br,
467 bool (*cb)(struct bridge *, struct iface *,
473 for (i = 0; i < br->n_ports; ) {
474 struct port *port = br->ports[i];
475 for (j = 0; j < port->n_ifaces; ) {
476 struct iface *iface = port->ifaces[j];
477 if (cb(br, iface, aux)) {
480 iface_destroy(iface);
484 if (port->n_ifaces) {
487 VLOG_ERR("%s port has no interfaces, dropping", port->name);
493 /* Looks at the list of managers in 'ovs_cfg' and extracts their remote IP
494 * addresses and ports into '*managersp' and '*n_managersp'. The caller is
495 * responsible for freeing '*managersp' (with free()).
497 * You may be asking yourself "why does ovs-vswitchd care?", because
498 * ovsdb-server is responsible for connecting to the managers, and ovs-vswitchd
499 * should not be and in fact is not directly involved in that. But
500 * ovs-vswitchd needs to make sure that ovsdb-server can reach the managers, so
501 * it has to tell in-band control where the managers are to enable that.
504 collect_managers(const struct ovsrec_open_vswitch *ovs_cfg,
505 struct sockaddr_in **managersp, size_t *n_managersp)
507 struct sockaddr_in *managers = NULL;
508 size_t n_managers = 0;
510 if (ovs_cfg->n_managers > 0) {
513 managers = xmalloc(ovs_cfg->n_managers * sizeof *managers);
514 for (i = 0; i < ovs_cfg->n_managers; i++) {
515 const char *name = ovs_cfg->managers[i];
516 struct sockaddr_in *sin = &managers[i];
518 if ((!strncmp(name, "tcp:", 4)
519 && inet_parse_active(name + 4, JSONRPC_TCP_PORT, sin)) ||
520 (!strncmp(name, "ssl:", 4)
521 && inet_parse_active(name + 4, JSONRPC_SSL_PORT, sin))) {
527 *managersp = managers;
528 *n_managersp = n_managers;
532 bridge_reconfigure(const struct ovsrec_open_vswitch *ovs_cfg)
534 struct shash old_br, new_br;
535 struct shash_node *node;
536 struct bridge *br, *next;
537 struct sockaddr_in *managers;
540 int sflow_bridge_number;
542 COVERAGE_INC(bridge_reconfigure);
544 collect_managers(ovs_cfg, &managers, &n_managers);
546 /* Collect old and new bridges. */
549 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
550 shash_add(&old_br, br->name, br);
552 for (i = 0; i < ovs_cfg->n_bridges; i++) {
553 const struct ovsrec_bridge *br_cfg = ovs_cfg->bridges[i];
554 if (!shash_add_once(&new_br, br_cfg->name, br_cfg)) {
555 VLOG_WARN("more than one bridge named %s", br_cfg->name);
559 /* Get rid of deleted bridges and add new bridges. */
560 LIST_FOR_EACH_SAFE (br, next, struct bridge, node, &all_bridges) {
561 struct ovsrec_bridge *br_cfg = shash_find_data(&new_br, br->name);
568 SHASH_FOR_EACH (node, &new_br) {
569 const char *br_name = node->name;
570 const struct ovsrec_bridge *br_cfg = node->data;
571 br = shash_find_data(&old_br, br_name);
573 /* If the bridge datapath type has changed, we need to tear it
574 * down and recreate. */
575 if (strcmp(br->cfg->datapath_type, br_cfg->datapath_type)) {
577 bridge_create(br_cfg);
580 bridge_create(br_cfg);
583 shash_destroy(&old_br);
584 shash_destroy(&new_br);
586 /* Reconfigure all bridges. */
587 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
588 bridge_reconfigure_one(br);
591 /* Add and delete ports on all datapaths.
593 * The kernel will reject any attempt to add a given port to a datapath if
594 * that port already belongs to a different datapath, so we must do all
595 * port deletions before any port additions. */
596 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
597 struct odp_port *dpif_ports;
599 struct shash want_ifaces;
601 dpif_port_list(br->dpif, &dpif_ports, &n_dpif_ports);
602 bridge_get_all_ifaces(br, &want_ifaces);
603 for (i = 0; i < n_dpif_ports; i++) {
604 const struct odp_port *p = &dpif_ports[i];
605 if (!shash_find(&want_ifaces, p->devname)
606 && strcmp(p->devname, br->name)) {
607 int retval = dpif_port_del(br->dpif, p->port);
609 VLOG_ERR("failed to remove %s interface from %s: %s",
610 p->devname, dpif_name(br->dpif),
615 shash_destroy(&want_ifaces);
618 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
619 struct odp_port *dpif_ports;
621 struct shash cur_ifaces, want_ifaces;
622 struct shash_node *node;
624 /* Get the set of interfaces currently in this datapath. */
625 dpif_port_list(br->dpif, &dpif_ports, &n_dpif_ports);
626 shash_init(&cur_ifaces);
627 for (i = 0; i < n_dpif_ports; i++) {
628 const char *name = dpif_ports[i].devname;
629 shash_add_once(&cur_ifaces, name, NULL);
633 /* Get the set of interfaces we want on this datapath. */
634 bridge_get_all_ifaces(br, &want_ifaces);
636 SHASH_FOR_EACH (node, &want_ifaces) {
637 const char *if_name = node->name;
638 struct iface *iface = node->data;
640 if (shash_find(&cur_ifaces, if_name)) {
641 /* Already exists, just reconfigure it. */
643 reconfigure_iface(iface->cfg, iface);
646 /* Need to add to datapath. */
650 /* Add to datapath. */
651 internal = iface_is_internal(br, if_name);
652 error = dpif_port_add(br->dpif, if_name,
653 internal ? ODP_PORT_INTERNAL : 0, NULL);
654 if (error == EFBIG) {
655 VLOG_ERR("ran out of valid port numbers on %s",
656 dpif_name(br->dpif));
659 VLOG_ERR("failed to add %s interface to %s: %s",
660 if_name, dpif_name(br->dpif), strerror(error));
664 shash_destroy(&cur_ifaces);
665 shash_destroy(&want_ifaces);
667 sflow_bridge_number = 0;
668 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
671 struct iface *local_iface;
672 struct iface *hw_addr_iface;
675 bridge_fetch_dp_ifaces(br);
677 iterate_and_prune_ifaces(br, check_iface_netdev, NULL);
678 iterate_and_prune_ifaces(br, check_iface_dp_ifidx, NULL);
680 /* Pick local port hardware address, datapath ID. */
681 bridge_pick_local_hw_addr(br, ea, &hw_addr_iface);
682 local_iface = bridge_get_local_iface(br);
684 int error = netdev_set_etheraddr(local_iface->netdev, ea);
686 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
687 VLOG_ERR_RL(&rl, "bridge %s: failed to set bridge "
688 "Ethernet address: %s",
689 br->name, strerror(error));
693 dpid = bridge_pick_datapath_id(br, ea, hw_addr_iface);
694 ofproto_set_datapath_id(br->ofproto, dpid);
696 dpid_string = xasprintf("%016"PRIx64, dpid);
697 ovsrec_bridge_set_datapath_id(br->cfg, dpid_string);
700 /* Set NetFlow configuration on this bridge. */
701 if (br->cfg->netflow) {
702 struct ovsrec_netflow *nf_cfg = br->cfg->netflow;
703 struct netflow_options opts;
705 memset(&opts, 0, sizeof opts);
707 dpif_get_netflow_ids(br->dpif, &opts.engine_type, &opts.engine_id);
708 if (nf_cfg->engine_type) {
709 opts.engine_type = *nf_cfg->engine_type;
711 if (nf_cfg->engine_id) {
712 opts.engine_id = *nf_cfg->engine_id;
715 opts.active_timeout = nf_cfg->active_timeout;
716 if (!opts.active_timeout) {
717 opts.active_timeout = -1;
718 } else if (opts.active_timeout < 0) {
719 VLOG_WARN("bridge %s: active timeout interval set to negative "
720 "value, using default instead (%d seconds)", br->name,
721 NF_ACTIVE_TIMEOUT_DEFAULT);
722 opts.active_timeout = -1;
725 opts.add_id_to_iface = nf_cfg->add_id_to_interface;
726 if (opts.add_id_to_iface) {
727 if (opts.engine_id > 0x7f) {
728 VLOG_WARN("bridge %s: netflow port mangling may conflict "
729 "with another vswitch, choose an engine id less "
730 "than 128", br->name);
732 if (br->n_ports > 508) {
733 VLOG_WARN("bridge %s: netflow port mangling will conflict "
734 "with another port when more than 508 ports are "
739 opts.collectors.n = nf_cfg->n_targets;
740 opts.collectors.names = nf_cfg->targets;
741 if (ofproto_set_netflow(br->ofproto, &opts)) {
742 VLOG_ERR("bridge %s: problem setting netflow collectors",
746 ofproto_set_netflow(br->ofproto, NULL);
749 /* Set sFlow configuration on this bridge. */
750 if (br->cfg->sflow) {
751 const struct ovsrec_sflow *sflow_cfg = br->cfg->sflow;
752 struct ovsrec_controller **controllers;
753 struct ofproto_sflow_options oso;
754 size_t n_controllers;
757 memset(&oso, 0, sizeof oso);
759 oso.targets.n = sflow_cfg->n_targets;
760 oso.targets.names = sflow_cfg->targets;
762 oso.sampling_rate = SFL_DEFAULT_SAMPLING_RATE;
763 if (sflow_cfg->sampling) {
764 oso.sampling_rate = *sflow_cfg->sampling;
767 oso.polling_interval = SFL_DEFAULT_POLLING_INTERVAL;
768 if (sflow_cfg->polling) {
769 oso.polling_interval = *sflow_cfg->polling;
772 oso.header_len = SFL_DEFAULT_HEADER_SIZE;
773 if (sflow_cfg->header) {
774 oso.header_len = *sflow_cfg->header;
777 oso.sub_id = sflow_bridge_number++;
778 oso.agent_device = sflow_cfg->agent;
780 oso.control_ip = NULL;
781 n_controllers = bridge_get_controllers(br, &controllers);
782 for (i = 0; i < n_controllers; i++) {
783 if (controllers[i]->local_ip) {
784 oso.control_ip = controllers[i]->local_ip;
788 ofproto_set_sflow(br->ofproto, &oso);
790 /* Do not destroy oso.targets because it is owned by sflow_cfg. */
792 ofproto_set_sflow(br->ofproto, NULL);
795 /* Update the controller and related settings. It would be more
796 * straightforward to call this from bridge_reconfigure_one(), but we
797 * can't do it there for two reasons. First, and most importantly, at
798 * that point we don't know the dp_ifidx of any interfaces that have
799 * been added to the bridge (because we haven't actually added them to
800 * the datapath). Second, at that point we haven't set the datapath ID
801 * yet; when a controller is configured, resetting the datapath ID will
802 * immediately disconnect from the controller, so it's better to set
803 * the datapath ID before the controller. */
804 bridge_reconfigure_remotes(br, managers, n_managers);
806 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
807 for (i = 0; i < br->n_ports; i++) {
808 struct port *port = br->ports[i];
811 port_update_vlan_compat(port);
812 port_update_bonding(port);
814 for (j = 0; j < port->n_ifaces; j++) {
815 iface_update_qos(port->ifaces[j], port->cfg->qos);
819 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
820 iterate_and_prune_ifaces(br, set_iface_properties, NULL);
827 get_ovsrec_key_value(const struct ovsdb_idl_row *row,
828 const struct ovsdb_idl_column *column,
831 const struct ovsdb_datum *datum;
832 union ovsdb_atom atom;
835 datum = ovsdb_idl_get(row, column, OVSDB_TYPE_STRING, OVSDB_TYPE_STRING);
836 atom.string = (char *) key;
837 idx = ovsdb_datum_find_key(datum, &atom, OVSDB_TYPE_STRING);
838 return idx == UINT_MAX ? NULL : datum->values[idx].string;
842 bridge_get_other_config(const struct ovsrec_bridge *br_cfg, const char *key)
844 return get_ovsrec_key_value(&br_cfg->header_,
845 &ovsrec_bridge_col_other_config, key);
849 bridge_pick_local_hw_addr(struct bridge *br, uint8_t ea[ETH_ADDR_LEN],
850 struct iface **hw_addr_iface)
856 *hw_addr_iface = NULL;
858 /* Did the user request a particular MAC? */
859 hwaddr = bridge_get_other_config(br->cfg, "hwaddr");
860 if (hwaddr && eth_addr_from_string(hwaddr, ea)) {
861 if (eth_addr_is_multicast(ea)) {
862 VLOG_ERR("bridge %s: cannot set MAC address to multicast "
863 "address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
864 } else if (eth_addr_is_zero(ea)) {
865 VLOG_ERR("bridge %s: cannot set MAC address to zero", br->name);
871 /* Otherwise choose the minimum non-local MAC address among all of the
873 memset(ea, 0xff, sizeof ea);
874 for (i = 0; i < br->n_ports; i++) {
875 struct port *port = br->ports[i];
876 uint8_t iface_ea[ETH_ADDR_LEN];
879 /* Mirror output ports don't participate. */
880 if (port->is_mirror_output_port) {
884 /* Choose the MAC address to represent the port. */
885 if (port->cfg->mac && eth_addr_from_string(port->cfg->mac, iface_ea)) {
886 /* Find the interface with this Ethernet address (if any) so that
887 * we can provide the correct devname to the caller. */
889 for (j = 0; j < port->n_ifaces; j++) {
890 struct iface *candidate = port->ifaces[j];
891 uint8_t candidate_ea[ETH_ADDR_LEN];
892 if (!netdev_get_etheraddr(candidate->netdev, candidate_ea)
893 && eth_addr_equals(iface_ea, candidate_ea)) {
898 /* Choose the interface whose MAC address will represent the port.
899 * The Linux kernel bonding code always chooses the MAC address of
900 * the first slave added to a bond, and the Fedora networking
901 * scripts always add slaves to a bond in alphabetical order, so
902 * for compatibility we choose the interface with the name that is
903 * first in alphabetical order. */
904 iface = port->ifaces[0];
905 for (j = 1; j < port->n_ifaces; j++) {
906 struct iface *candidate = port->ifaces[j];
907 if (strcmp(candidate->name, iface->name) < 0) {
912 /* The local port doesn't count (since we're trying to choose its
913 * MAC address anyway). */
914 if (iface->dp_ifidx == ODPP_LOCAL) {
919 error = netdev_get_etheraddr(iface->netdev, iface_ea);
921 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
922 VLOG_ERR_RL(&rl, "failed to obtain Ethernet address of %s: %s",
923 iface->name, strerror(error));
928 /* Compare against our current choice. */
929 if (!eth_addr_is_multicast(iface_ea) &&
930 !eth_addr_is_local(iface_ea) &&
931 !eth_addr_is_reserved(iface_ea) &&
932 !eth_addr_is_zero(iface_ea) &&
933 memcmp(iface_ea, ea, ETH_ADDR_LEN) < 0)
935 memcpy(ea, iface_ea, ETH_ADDR_LEN);
936 *hw_addr_iface = iface;
939 if (eth_addr_is_multicast(ea)) {
940 memcpy(ea, br->default_ea, ETH_ADDR_LEN);
941 *hw_addr_iface = NULL;
942 VLOG_WARN("bridge %s: using default bridge Ethernet "
943 "address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
945 VLOG_DBG("bridge %s: using bridge Ethernet address "ETH_ADDR_FMT,
946 br->name, ETH_ADDR_ARGS(ea));
950 /* Choose and returns the datapath ID for bridge 'br' given that the bridge
951 * Ethernet address is 'bridge_ea'. If 'bridge_ea' is the Ethernet address of
952 * an interface on 'br', then that interface must be passed in as
953 * 'hw_addr_iface'; if 'bridge_ea' was derived some other way, then
954 * 'hw_addr_iface' must be passed in as a null pointer. */
956 bridge_pick_datapath_id(struct bridge *br,
957 const uint8_t bridge_ea[ETH_ADDR_LEN],
958 struct iface *hw_addr_iface)
961 * The procedure for choosing a bridge MAC address will, in the most
962 * ordinary case, also choose a unique MAC that we can use as a datapath
963 * ID. In some special cases, though, multiple bridges will end up with
964 * the same MAC address. This is OK for the bridges, but it will confuse
965 * the OpenFlow controller, because each datapath needs a unique datapath
968 * Datapath IDs must be unique. It is also very desirable that they be
969 * stable from one run to the next, so that policy set on a datapath
972 const char *datapath_id;
975 datapath_id = bridge_get_other_config(br->cfg, "datapath-id");
976 if (datapath_id && dpid_from_string(datapath_id, &dpid)) {
982 if (!netdev_get_vlan_vid(hw_addr_iface->netdev, &vlan)) {
984 * A bridge whose MAC address is taken from a VLAN network device
985 * (that is, a network device created with vconfig(8) or similar
986 * tool) will have the same MAC address as a bridge on the VLAN
987 * device's physical network device.
989 * Handle this case by hashing the physical network device MAC
990 * along with the VLAN identifier.
992 uint8_t buf[ETH_ADDR_LEN + 2];
993 memcpy(buf, bridge_ea, ETH_ADDR_LEN);
994 buf[ETH_ADDR_LEN] = vlan >> 8;
995 buf[ETH_ADDR_LEN + 1] = vlan;
996 return dpid_from_hash(buf, sizeof buf);
999 * Assume that this bridge's MAC address is unique, since it
1000 * doesn't fit any of the cases we handle specially.
1005 * A purely internal bridge, that is, one that has no non-virtual
1006 * network devices on it at all, is more difficult because it has no
1007 * natural unique identifier at all.
1009 * When the host is a XenServer, we handle this case by hashing the
1010 * host's UUID with the name of the bridge. Names of bridges are
1011 * persistent across XenServer reboots, although they can be reused if
1012 * an internal network is destroyed and then a new one is later
1013 * created, so this is fairly effective.
1015 * When the host is not a XenServer, we punt by using a random MAC
1016 * address on each run.
1018 const char *host_uuid = xenserver_get_host_uuid();
1020 char *combined = xasprintf("%s,%s", host_uuid, br->name);
1021 dpid = dpid_from_hash(combined, strlen(combined));
1027 return eth_addr_to_uint64(bridge_ea);
1031 dpid_from_hash(const void *data, size_t n)
1033 uint8_t hash[SHA1_DIGEST_SIZE];
1035 BUILD_ASSERT_DECL(sizeof hash >= ETH_ADDR_LEN);
1036 sha1_bytes(data, n, hash);
1037 eth_addr_mark_random(hash);
1038 return eth_addr_to_uint64(hash);
1042 iface_refresh_stats(struct iface *iface)
1048 static const struct iface_stat iface_stats[] = {
1049 { "rx_packets", offsetof(struct netdev_stats, rx_packets) },
1050 { "tx_packets", offsetof(struct netdev_stats, tx_packets) },
1051 { "rx_bytes", offsetof(struct netdev_stats, rx_bytes) },
1052 { "tx_bytes", offsetof(struct netdev_stats, tx_bytes) },
1053 { "rx_dropped", offsetof(struct netdev_stats, rx_dropped) },
1054 { "tx_dropped", offsetof(struct netdev_stats, tx_dropped) },
1055 { "rx_errors", offsetof(struct netdev_stats, rx_errors) },
1056 { "tx_errors", offsetof(struct netdev_stats, tx_errors) },
1057 { "rx_frame_err", offsetof(struct netdev_stats, rx_frame_errors) },
1058 { "rx_over_err", offsetof(struct netdev_stats, rx_over_errors) },
1059 { "rx_crc_err", offsetof(struct netdev_stats, rx_crc_errors) },
1060 { "collisions", offsetof(struct netdev_stats, collisions) },
1062 enum { N_STATS = ARRAY_SIZE(iface_stats) };
1063 const struct iface_stat *s;
1065 char *keys[N_STATS];
1066 int64_t values[N_STATS];
1069 struct netdev_stats stats;
1071 /* Intentionally ignore return value, since errors will set 'stats' to
1072 * all-1s, and we will deal with that correctly below. */
1073 netdev_get_stats(iface->netdev, &stats);
1076 for (s = iface_stats; s < &iface_stats[N_STATS]; s++) {
1077 uint64_t value = *(uint64_t *) (((char *) &stats) + s->offset);
1078 if (value != UINT64_MAX) {
1085 ovsrec_interface_set_statistics(iface->cfg, keys, values, n);
1091 const struct ovsrec_open_vswitch *cfg;
1093 bool datapath_destroyed;
1094 bool database_changed;
1097 /* Let each bridge do the work that it needs to do. */
1098 datapath_destroyed = false;
1099 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
1100 int error = bridge_run_one(br);
1102 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
1103 VLOG_ERR_RL(&rl, "bridge %s: datapath was destroyed externally, "
1104 "forcing reconfiguration", br->name);
1105 datapath_destroyed = true;
1109 /* (Re)configure if necessary. */
1110 database_changed = ovsdb_idl_run(idl);
1111 cfg = ovsrec_open_vswitch_first(idl);
1112 if (database_changed || datapath_destroyed) {
1114 struct ovsdb_idl_txn *txn = ovsdb_idl_txn_create(idl);
1116 bridge_configure_once(cfg);
1117 bridge_reconfigure(cfg);
1119 ovsrec_open_vswitch_set_cur_cfg(cfg, cfg->next_cfg);
1120 ovsdb_idl_txn_commit(txn);
1121 ovsdb_idl_txn_destroy(txn); /* XXX */
1123 /* We still need to reconfigure to avoid dangling pointers to
1124 * now-destroyed ovsrec structures inside bridge data. */
1125 static const struct ovsrec_open_vswitch null_cfg;
1127 bridge_reconfigure(&null_cfg);
1132 /* Re-configure SSL. We do this on every trip through the main loop,
1133 * instead of just when the database changes, because the contents of the
1134 * key and certificate files can change without the database changing. */
1135 if (cfg && cfg->ssl) {
1136 const struct ovsrec_ssl *ssl = cfg->ssl;
1138 stream_ssl_set_key_and_cert(ssl->private_key, ssl->certificate);
1139 stream_ssl_set_ca_cert_file(ssl->ca_cert, ssl->bootstrap_ca_cert);
1143 /* Refresh interface stats if necessary. */
1144 if (time_msec() >= iface_stats_timer) {
1145 struct ovsdb_idl_txn *txn;
1147 txn = ovsdb_idl_txn_create(idl);
1148 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
1151 for (i = 0; i < br->n_ports; i++) {
1152 struct port *port = br->ports[i];
1155 for (j = 0; j < port->n_ifaces; j++) {
1156 struct iface *iface = port->ifaces[j];
1157 iface_refresh_stats(iface);
1161 ovsdb_idl_txn_commit(txn);
1162 ovsdb_idl_txn_destroy(txn); /* XXX */
1164 iface_stats_timer = time_msec() + IFACE_STATS_INTERVAL;
1173 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
1174 ofproto_wait(br->ofproto);
1175 if (ofproto_has_controller(br->ofproto)) {
1179 mac_learning_wait(br->ml);
1182 ovsdb_idl_wait(idl);
1183 poll_timer_wait_until(iface_stats_timer);
1186 /* Forces 'br' to revalidate all of its flows. This is appropriate when 'br''s
1187 * configuration changes. */
1189 bridge_flush(struct bridge *br)
1191 COVERAGE_INC(bridge_flush);
1193 mac_learning_flush(br->ml);
1196 /* Returns the 'br' interface for the ODPP_LOCAL port, or null if 'br' has no
1197 * such interface. */
1198 static struct iface *
1199 bridge_get_local_iface(struct bridge *br)
1203 for (i = 0; i < br->n_ports; i++) {
1204 struct port *port = br->ports[i];
1205 for (j = 0; j < port->n_ifaces; j++) {
1206 struct iface *iface = port->ifaces[j];
1207 if (iface->dp_ifidx == ODPP_LOCAL) {
1216 /* Bridge unixctl user interface functions. */
1218 bridge_unixctl_fdb_show(struct unixctl_conn *conn,
1219 const char *args, void *aux OVS_UNUSED)
1221 struct ds ds = DS_EMPTY_INITIALIZER;
1222 const struct bridge *br;
1223 const struct mac_entry *e;
1225 br = bridge_lookup(args);
1227 unixctl_command_reply(conn, 501, "no such bridge");
1231 ds_put_cstr(&ds, " port VLAN MAC Age\n");
1232 LIST_FOR_EACH (e, struct mac_entry, lru_node, &br->ml->lrus) {
1233 if (e->port < 0 || e->port >= br->n_ports) {
1236 ds_put_format(&ds, "%5d %4d "ETH_ADDR_FMT" %3d\n",
1237 br->ports[e->port]->ifaces[0]->dp_ifidx,
1238 e->vlan, ETH_ADDR_ARGS(e->mac), mac_entry_age(e));
1240 unixctl_command_reply(conn, 200, ds_cstr(&ds));
1244 /* Bridge reconfiguration functions. */
1245 static struct bridge *
1246 bridge_create(const struct ovsrec_bridge *br_cfg)
1251 assert(!bridge_lookup(br_cfg->name));
1252 br = xzalloc(sizeof *br);
1254 error = dpif_create_and_open(br_cfg->name, br_cfg->datapath_type,
1260 dpif_flow_flush(br->dpif);
1262 error = ofproto_create(br_cfg->name, br_cfg->datapath_type, &bridge_ofhooks,
1265 VLOG_ERR("failed to create switch %s: %s", br_cfg->name,
1267 dpif_delete(br->dpif);
1268 dpif_close(br->dpif);
1273 br->name = xstrdup(br_cfg->name);
1275 br->ml = mac_learning_create();
1276 eth_addr_nicira_random(br->default_ea);
1278 port_array_init(&br->ifaces);
1280 shash_init(&br->port_by_name);
1281 shash_init(&br->iface_by_name);
1285 list_push_back(&all_bridges, &br->node);
1287 VLOG_INFO("created bridge %s on %s", br->name, dpif_name(br->dpif));
1293 bridge_destroy(struct bridge *br)
1298 while (br->n_ports > 0) {
1299 port_destroy(br->ports[br->n_ports - 1]);
1301 list_remove(&br->node);
1302 error = dpif_delete(br->dpif);
1303 if (error && error != ENOENT) {
1304 VLOG_ERR("failed to delete %s: %s",
1305 dpif_name(br->dpif), strerror(error));
1307 dpif_close(br->dpif);
1308 ofproto_destroy(br->ofproto);
1309 mac_learning_destroy(br->ml);
1310 port_array_destroy(&br->ifaces);
1311 shash_destroy(&br->port_by_name);
1312 shash_destroy(&br->iface_by_name);
1319 static struct bridge *
1320 bridge_lookup(const char *name)
1324 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
1325 if (!strcmp(br->name, name)) {
1332 /* Handle requests for a listing of all flows known by the OpenFlow
1333 * stack, including those normally hidden. */
1335 bridge_unixctl_dump_flows(struct unixctl_conn *conn,
1336 const char *args, void *aux OVS_UNUSED)
1341 br = bridge_lookup(args);
1343 unixctl_command_reply(conn, 501, "Unknown bridge");
1348 ofproto_get_all_flows(br->ofproto, &results);
1350 unixctl_command_reply(conn, 200, ds_cstr(&results));
1351 ds_destroy(&results);
1354 /* "bridge/reconnect [BRIDGE]": makes BRIDGE drop all of its controller
1355 * connections and reconnect. If BRIDGE is not specified, then all bridges
1356 * drop their controller connections and reconnect. */
1358 bridge_unixctl_reconnect(struct unixctl_conn *conn,
1359 const char *args, void *aux OVS_UNUSED)
1362 if (args[0] != '\0') {
1363 br = bridge_lookup(args);
1365 unixctl_command_reply(conn, 501, "Unknown bridge");
1368 ofproto_reconnect_controllers(br->ofproto);
1370 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
1371 ofproto_reconnect_controllers(br->ofproto);
1374 unixctl_command_reply(conn, 200, NULL);
1378 bridge_run_one(struct bridge *br)
1382 error = ofproto_run1(br->ofproto);
1387 mac_learning_run(br->ml, ofproto_get_revalidate_set(br->ofproto));
1390 error = ofproto_run2(br->ofproto, br->flush);
1397 bridge_get_controllers(const struct bridge *br,
1398 struct ovsrec_controller ***controllersp)
1400 struct ovsrec_controller **controllers;
1401 size_t n_controllers;
1403 controllers = br->cfg->controller;
1404 n_controllers = br->cfg->n_controller;
1406 if (n_controllers == 1 && !strcmp(controllers[0]->target, "none")) {
1412 *controllersp = controllers;
1414 return n_controllers;
1418 bridge_reconfigure_one(struct bridge *br)
1420 struct shash old_ports, new_ports;
1421 struct svec listeners, old_listeners;
1422 struct svec snoops, old_snoops;
1423 struct shash_node *node;
1424 enum ofproto_fail_mode fail_mode;
1427 /* Collect old ports. */
1428 shash_init(&old_ports);
1429 for (i = 0; i < br->n_ports; i++) {
1430 shash_add(&old_ports, br->ports[i]->name, br->ports[i]);
1433 /* Collect new ports. */
1434 shash_init(&new_ports);
1435 for (i = 0; i < br->cfg->n_ports; i++) {
1436 const char *name = br->cfg->ports[i]->name;
1437 if (!shash_add_once(&new_ports, name, br->cfg->ports[i])) {
1438 VLOG_WARN("bridge %s: %s specified twice as bridge port",
1443 /* If we have a controller, then we need a local port. Complain if the
1444 * user didn't specify one.
1446 * XXX perhaps we should synthesize a port ourselves in this case. */
1447 if (bridge_get_controllers(br, NULL)) {
1448 char local_name[IF_NAMESIZE];
1451 error = dpif_port_get_name(br->dpif, ODPP_LOCAL,
1452 local_name, sizeof local_name);
1453 if (!error && !shash_find(&new_ports, local_name)) {
1454 VLOG_WARN("bridge %s: controller specified but no local port "
1455 "(port named %s) defined",
1456 br->name, local_name);
1460 /* Get rid of deleted ports.
1461 * Get rid of deleted interfaces on ports that still exist. */
1462 SHASH_FOR_EACH (node, &old_ports) {
1463 struct port *port = node->data;
1464 const struct ovsrec_port *port_cfg;
1466 port_cfg = shash_find_data(&new_ports, node->name);
1470 port_del_ifaces(port, port_cfg);
1474 /* Create new ports.
1475 * Add new interfaces to existing ports.
1476 * Reconfigure existing ports. */
1477 SHASH_FOR_EACH (node, &new_ports) {
1478 struct port *port = shash_find_data(&old_ports, node->name);
1480 port = port_create(br, node->name);
1483 port_reconfigure(port, node->data);
1484 if (!port->n_ifaces) {
1485 VLOG_WARN("bridge %s: port %s has no interfaces, dropping",
1486 br->name, port->name);
1490 shash_destroy(&old_ports);
1491 shash_destroy(&new_ports);
1493 /* Set the fail-mode */
1494 fail_mode = !br->cfg->fail_mode
1495 || !strcmp(br->cfg->fail_mode, "standalone")
1496 ? OFPROTO_FAIL_STANDALONE
1497 : OFPROTO_FAIL_SECURE;
1498 if ((ofproto_get_fail_mode(br->ofproto) != fail_mode)
1499 && !ofproto_has_controller(br->ofproto)) {
1500 ofproto_flush_flows(br->ofproto);
1502 ofproto_set_fail_mode(br->ofproto, fail_mode);
1504 /* Delete all flows if we're switching from connected to standalone or vice
1505 * versa. (XXX Should we delete all flows if we are switching from one
1506 * controller to another?) */
1508 /* Configure OpenFlow management listener. */
1509 svec_init(&listeners);
1510 svec_add_nocopy(&listeners, xasprintf("punix:%s/%s.mgmt",
1511 ovs_rundir, br->name));
1512 svec_init(&old_listeners);
1513 ofproto_get_listeners(br->ofproto, &old_listeners);
1514 if (!svec_equal(&listeners, &old_listeners)) {
1515 ofproto_set_listeners(br->ofproto, &listeners);
1517 svec_destroy(&listeners);
1518 svec_destroy(&old_listeners);
1520 /* Configure OpenFlow controller connection snooping. */
1522 svec_add_nocopy(&snoops, xasprintf("punix:%s/%s.snoop",
1523 ovs_rundir, br->name));
1524 svec_init(&old_snoops);
1525 ofproto_get_snoops(br->ofproto, &old_snoops);
1526 if (!svec_equal(&snoops, &old_snoops)) {
1527 ofproto_set_snoops(br->ofproto, &snoops);
1529 svec_destroy(&snoops);
1530 svec_destroy(&old_snoops);
1532 mirror_reconfigure(br);
1536 bridge_reconfigure_remotes(struct bridge *br,
1537 const struct sockaddr_in *managers,
1540 struct ovsrec_controller **controllers;
1541 size_t n_controllers;
1543 ofproto_set_extra_in_band_remotes(br->ofproto, managers, n_managers);
1545 n_controllers = bridge_get_controllers(br, &controllers);
1546 if (ofproto_has_controller(br->ofproto) != (n_controllers != 0)) {
1547 ofproto_flush_flows(br->ofproto);
1550 if (!n_controllers) {
1551 union ofp_action action;
1554 /* Clear out controllers. */
1555 ofproto_set_controllers(br->ofproto, NULL, 0);
1557 /* If there are no controllers and the bridge is in standalone
1558 * mode, set up a flow that matches every packet and directs
1559 * them to OFPP_NORMAL (which goes to us). Otherwise, the
1560 * switch is in secure mode and we won't pass any traffic until
1561 * a controller has been defined and it tells us to do so. */
1562 if (ofproto_get_fail_mode(br->ofproto) == OFPROTO_FAIL_STANDALONE) {
1563 memset(&action, 0, sizeof action);
1564 action.type = htons(OFPAT_OUTPUT);
1565 action.output.len = htons(sizeof action);
1566 action.output.port = htons(OFPP_NORMAL);
1567 memset(&flow, 0, sizeof flow);
1568 ofproto_add_flow(br->ofproto, &flow, OVSFW_ALL, 0, &action, 1, 0);
1571 struct ofproto_controller *ocs;
1574 ocs = xmalloc(n_controllers * sizeof *ocs);
1575 for (i = 0; i < n_controllers; i++) {
1576 struct ovsrec_controller *c = controllers[i];
1577 struct ofproto_controller *oc = &ocs[i];
1579 if (strcmp(c->target, "discover")) {
1580 struct iface *local_iface;
1583 local_iface = bridge_get_local_iface(br);
1584 if (local_iface && c->local_ip
1585 && inet_aton(c->local_ip, &ip)) {
1586 struct netdev *netdev = local_iface->netdev;
1587 struct in_addr mask, gateway;
1589 if (!c->local_netmask
1590 || !inet_aton(c->local_netmask, &mask)) {
1593 if (!c->local_gateway
1594 || !inet_aton(c->local_gateway, &gateway)) {
1598 netdev_turn_flags_on(netdev, NETDEV_UP, true);
1600 mask.s_addr = guess_netmask(ip.s_addr);
1602 if (!netdev_set_in4(netdev, ip, mask)) {
1603 VLOG_INFO("bridge %s: configured IP address "IP_FMT", "
1605 br->name, IP_ARGS(&ip.s_addr),
1606 IP_ARGS(&mask.s_addr));
1609 if (gateway.s_addr) {
1610 if (!netdev_add_router(netdev, gateway)) {
1611 VLOG_INFO("bridge %s: configured gateway "IP_FMT,
1612 br->name, IP_ARGS(&gateway.s_addr));
1618 oc->target = c->target;
1619 oc->max_backoff = c->max_backoff ? *c->max_backoff / 1000 : 8;
1620 oc->probe_interval = (c->inactivity_probe
1621 ? *c->inactivity_probe / 1000 : 5);
1622 oc->band = (!c->connection_mode
1623 || !strcmp(c->connection_mode, "in-band")
1625 : OFPROTO_OUT_OF_BAND);
1626 oc->accept_re = c->discover_accept_regex;
1627 oc->update_resolv_conf = c->discover_update_resolv_conf;
1628 oc->rate_limit = (c->controller_rate_limit
1629 ? *c->controller_rate_limit : 0);
1630 oc->burst_limit = (c->controller_burst_limit
1631 ? *c->controller_burst_limit : 0);
1633 ofproto_set_controllers(br->ofproto, ocs, n_controllers);
1639 bridge_get_all_ifaces(const struct bridge *br, struct shash *ifaces)
1644 for (i = 0; i < br->n_ports; i++) {
1645 struct port *port = br->ports[i];
1646 for (j = 0; j < port->n_ifaces; j++) {
1647 struct iface *iface = port->ifaces[j];
1648 shash_add_once(ifaces, iface->name, iface);
1650 if (port->n_ifaces > 1 && port->cfg->bond_fake_iface) {
1651 shash_add_once(ifaces, port->name, NULL);
1656 /* For robustness, in case the administrator moves around datapath ports behind
1657 * our back, we re-check all the datapath port numbers here.
1659 * This function will set the 'dp_ifidx' members of interfaces that have
1660 * disappeared to -1, so only call this function from a context where those
1661 * 'struct iface's will be removed from the bridge. Otherwise, the -1
1662 * 'dp_ifidx'es will cause trouble later when we try to send them to the
1663 * datapath, which doesn't support UINT16_MAX+1 ports. */
1665 bridge_fetch_dp_ifaces(struct bridge *br)
1667 struct odp_port *dpif_ports;
1668 size_t n_dpif_ports;
1671 /* Reset all interface numbers. */
1672 for (i = 0; i < br->n_ports; i++) {
1673 struct port *port = br->ports[i];
1674 for (j = 0; j < port->n_ifaces; j++) {
1675 struct iface *iface = port->ifaces[j];
1676 iface->dp_ifidx = -1;
1679 port_array_clear(&br->ifaces);
1681 dpif_port_list(br->dpif, &dpif_ports, &n_dpif_ports);
1682 for (i = 0; i < n_dpif_ports; i++) {
1683 struct odp_port *p = &dpif_ports[i];
1684 struct iface *iface = iface_lookup(br, p->devname);
1686 if (iface->dp_ifidx >= 0) {
1687 VLOG_WARN("%s reported interface %s twice",
1688 dpif_name(br->dpif), p->devname);
1689 } else if (iface_from_dp_ifidx(br, p->port)) {
1690 VLOG_WARN("%s reported interface %"PRIu16" twice",
1691 dpif_name(br->dpif), p->port);
1693 port_array_set(&br->ifaces, p->port, iface);
1694 iface->dp_ifidx = p->port;
1698 int64_t ofport = (iface->dp_ifidx >= 0
1699 ? odp_port_to_ofp_port(iface->dp_ifidx)
1701 ovsrec_interface_set_ofport(iface->cfg, &ofport, 1);
1708 /* Bridge packet processing functions. */
1711 bond_hash(const uint8_t mac[ETH_ADDR_LEN])
1713 return hash_bytes(mac, ETH_ADDR_LEN, 0) & BOND_MASK;
1716 static struct bond_entry *
1717 lookup_bond_entry(const struct port *port, const uint8_t mac[ETH_ADDR_LEN])
1719 return &port->bond_hash[bond_hash(mac)];
1723 bond_choose_iface(const struct port *port)
1725 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);
1726 size_t i, best_down_slave = -1;
1727 long long next_delay_expiration = LLONG_MAX;
1729 for (i = 0; i < port->n_ifaces; i++) {
1730 struct iface *iface = port->ifaces[i];
1732 if (iface->enabled) {
1734 } else if (iface->delay_expires < next_delay_expiration) {
1735 best_down_slave = i;
1736 next_delay_expiration = iface->delay_expires;
1740 if (best_down_slave != -1) {
1741 struct iface *iface = port->ifaces[best_down_slave];
1743 VLOG_INFO_RL(&rl, "interface %s: skipping remaining %lli ms updelay "
1744 "since no other interface is up", iface->name,
1745 iface->delay_expires - time_msec());
1746 bond_enable_slave(iface, true);
1749 return best_down_slave;
1753 choose_output_iface(const struct port *port, const uint8_t *dl_src,
1754 uint16_t *dp_ifidx, tag_type *tags)
1756 struct iface *iface;
1758 assert(port->n_ifaces);
1759 if (port->n_ifaces == 1) {
1760 iface = port->ifaces[0];
1762 struct bond_entry *e = lookup_bond_entry(port, dl_src);
1763 if (e->iface_idx < 0 || e->iface_idx >= port->n_ifaces
1764 || !port->ifaces[e->iface_idx]->enabled) {
1765 /* XXX select interface properly. The current interface selection
1766 * is only good for testing the rebalancing code. */
1767 e->iface_idx = bond_choose_iface(port);
1768 if (e->iface_idx < 0) {
1769 *tags |= port->no_ifaces_tag;
1772 e->iface_tag = tag_create_random();
1773 ((struct port *) port)->bond_compat_is_stale = true;
1775 *tags |= e->iface_tag;
1776 iface = port->ifaces[e->iface_idx];
1778 *dp_ifidx = iface->dp_ifidx;
1779 *tags |= iface->tag; /* Currently only used for bonding. */
1784 bond_link_status_update(struct iface *iface, bool carrier)
1786 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);
1787 struct port *port = iface->port;
1789 if ((carrier == iface->enabled) == (iface->delay_expires == LLONG_MAX)) {
1790 /* Nothing to do. */
1793 VLOG_INFO_RL(&rl, "interface %s: carrier %s",
1794 iface->name, carrier ? "detected" : "dropped");
1795 if (carrier == iface->enabled) {
1796 iface->delay_expires = LLONG_MAX;
1797 VLOG_INFO_RL(&rl, "interface %s: will not be %s",
1798 iface->name, carrier ? "disabled" : "enabled");
1799 } else if (carrier && port->active_iface < 0) {
1800 bond_enable_slave(iface, true);
1801 if (port->updelay) {
1802 VLOG_INFO_RL(&rl, "interface %s: skipping %d ms updelay since no "
1803 "other interface is up", iface->name, port->updelay);
1806 int delay = carrier ? port->updelay : port->downdelay;
1807 iface->delay_expires = time_msec() + delay;
1810 "interface %s: will be %s if it stays %s for %d ms",
1812 carrier ? "enabled" : "disabled",
1813 carrier ? "up" : "down",
1820 bond_choose_active_iface(struct port *port)
1822 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);
1824 port->active_iface = bond_choose_iface(port);
1825 port->active_iface_tag = tag_create_random();
1826 if (port->active_iface >= 0) {
1827 VLOG_INFO_RL(&rl, "port %s: active interface is now %s",
1828 port->name, port->ifaces[port->active_iface]->name);
1830 VLOG_WARN_RL(&rl, "port %s: all ports disabled, no active interface",
1836 bond_enable_slave(struct iface *iface, bool enable)
1838 struct port *port = iface->port;
1839 struct bridge *br = port->bridge;
1841 /* This acts as a recursion check. If the act of disabling a slave
1842 * causes a different slave to be enabled, the flag will allow us to
1843 * skip redundant work when we reenter this function. It must be
1844 * cleared on exit to keep things safe with multiple bonds. */
1845 static bool moving_active_iface = false;
1847 iface->delay_expires = LLONG_MAX;
1848 if (enable == iface->enabled) {
1852 iface->enabled = enable;
1853 if (!iface->enabled) {
1854 VLOG_WARN("interface %s: disabled", iface->name);
1855 ofproto_revalidate(br->ofproto, iface->tag);
1856 if (iface->port_ifidx == port->active_iface) {
1857 ofproto_revalidate(br->ofproto,
1858 port->active_iface_tag);
1860 /* Disabling a slave can lead to another slave being immediately
1861 * enabled if there will be no active slaves but one is waiting
1862 * on an updelay. In this case we do not need to run most of the
1863 * code for the newly enabled slave since there was no period
1864 * without an active slave and it is redundant with the disabling
1866 moving_active_iface = true;
1867 bond_choose_active_iface(port);
1869 bond_send_learning_packets(port);
1871 VLOG_WARN("interface %s: enabled", iface->name);
1872 if (port->active_iface < 0 && !moving_active_iface) {
1873 ofproto_revalidate(br->ofproto, port->no_ifaces_tag);
1874 bond_choose_active_iface(port);
1875 bond_send_learning_packets(port);
1877 iface->tag = tag_create_random();
1880 moving_active_iface = false;
1881 port->bond_compat_is_stale = true;
1884 /* Attempts to make the sum of the bond slaves' statistics appear on the fake
1885 * bond interface. */
1887 bond_update_fake_iface_stats(struct port *port)
1889 struct netdev_stats bond_stats;
1890 struct netdev *bond_dev;
1893 memset(&bond_stats, 0, sizeof bond_stats);
1895 for (i = 0; i < port->n_ifaces; i++) {
1896 struct netdev_stats slave_stats;
1898 if (!netdev_get_stats(port->ifaces[i]->netdev, &slave_stats)) {
1899 /* XXX: We swap the stats here because they are swapped back when
1900 * reported by the internal device. The reason for this is
1901 * internal devices normally represent packets going into the system
1902 * but when used as fake bond device they represent packets leaving
1903 * the system. We really should do this in the internal device
1904 * itself because changing it here reverses the counts from the
1905 * perspective of the switch. However, the internal device doesn't
1906 * know what type of device it represents so we have to do it here
1908 bond_stats.tx_packets += slave_stats.rx_packets;
1909 bond_stats.tx_bytes += slave_stats.rx_bytes;
1910 bond_stats.rx_packets += slave_stats.tx_packets;
1911 bond_stats.rx_bytes += slave_stats.tx_bytes;
1915 if (!netdev_open_default(port->name, &bond_dev)) {
1916 netdev_set_stats(bond_dev, &bond_stats);
1917 netdev_close(bond_dev);
1922 bond_run(struct bridge *br)
1926 for (i = 0; i < br->n_ports; i++) {
1927 struct port *port = br->ports[i];
1929 if (port->n_ifaces >= 2) {
1930 for (j = 0; j < port->n_ifaces; j++) {
1931 struct iface *iface = port->ifaces[j];
1932 if (time_msec() >= iface->delay_expires) {
1933 bond_enable_slave(iface, !iface->enabled);
1937 if (port->bond_fake_iface
1938 && time_msec() >= port->bond_next_fake_iface_update) {
1939 bond_update_fake_iface_stats(port);
1940 port->bond_next_fake_iface_update = time_msec() + 1000;
1944 if (port->bond_compat_is_stale) {
1945 port->bond_compat_is_stale = false;
1946 port_update_bond_compat(port);
1952 bond_wait(struct bridge *br)
1956 for (i = 0; i < br->n_ports; i++) {
1957 struct port *port = br->ports[i];
1958 if (port->n_ifaces < 2) {
1961 for (j = 0; j < port->n_ifaces; j++) {
1962 struct iface *iface = port->ifaces[j];
1963 if (iface->delay_expires != LLONG_MAX) {
1964 poll_timer_wait_until(iface->delay_expires);
1967 if (port->bond_fake_iface) {
1968 poll_timer_wait_until(port->bond_next_fake_iface_update);
1974 set_dst(struct dst *p, const flow_t *flow,
1975 const struct port *in_port, const struct port *out_port,
1978 p->vlan = (out_port->vlan >= 0 ? OFP_VLAN_NONE
1979 : in_port->vlan >= 0 ? in_port->vlan
1980 : ntohs(flow->dl_vlan));
1981 return choose_output_iface(out_port, flow->dl_src, &p->dp_ifidx, tags);
1985 swap_dst(struct dst *p, struct dst *q)
1987 struct dst tmp = *p;
1992 /* Moves all the dsts with vlan == 'vlan' to the front of the 'n_dsts' in
1993 * 'dsts'. (This may help performance by reducing the number of VLAN changes
1994 * that we push to the datapath. We could in fact fully sort the array by
1995 * vlan, but in most cases there are at most two different vlan tags so that's
1996 * possibly overkill.) */
1998 partition_dsts(struct dst *dsts, size_t n_dsts, int vlan)
2000 struct dst *first = dsts;
2001 struct dst *last = dsts + n_dsts;
2003 while (first != last) {
2005 * - All dsts < first have vlan == 'vlan'.
2006 * - All dsts >= last have vlan != 'vlan'.
2007 * - first < last. */
2008 while (first->vlan == vlan) {
2009 if (++first == last) {
2014 /* Same invariants, plus one additional:
2015 * - first->vlan != vlan.
2017 while (last[-1].vlan != vlan) {
2018 if (--last == first) {
2023 /* Same invariants, plus one additional:
2024 * - last[-1].vlan == vlan.*/
2025 swap_dst(first++, --last);
2030 mirror_mask_ffs(mirror_mask_t mask)
2032 BUILD_ASSERT_DECL(sizeof(unsigned int) >= sizeof(mask));
2037 dst_is_duplicate(const struct dst *dsts, size_t n_dsts,
2038 const struct dst *test)
2041 for (i = 0; i < n_dsts; i++) {
2042 if (dsts[i].vlan == test->vlan && dsts[i].dp_ifidx == test->dp_ifidx) {
2050 port_trunks_vlan(const struct port *port, uint16_t vlan)
2052 return (port->vlan < 0
2053 && (!port->trunks || bitmap_is_set(port->trunks, vlan)));
2057 port_includes_vlan(const struct port *port, uint16_t vlan)
2059 return vlan == port->vlan || port_trunks_vlan(port, vlan);
2063 compose_dsts(const struct bridge *br, const flow_t *flow, uint16_t vlan,
2064 const struct port *in_port, const struct port *out_port,
2065 struct dst dsts[], tag_type *tags, uint16_t *nf_output_iface)
2067 mirror_mask_t mirrors = in_port->src_mirrors;
2068 struct dst *dst = dsts;
2071 if (out_port == FLOOD_PORT) {
2072 /* XXX use ODP_FLOOD if no vlans or bonding. */
2073 /* XXX even better, define each VLAN as a datapath port group */
2074 for (i = 0; i < br->n_ports; i++) {
2075 struct port *port = br->ports[i];
2076 if (port != in_port && port_includes_vlan(port, vlan)
2077 && !port->is_mirror_output_port
2078 && set_dst(dst, flow, in_port, port, tags)) {
2079 mirrors |= port->dst_mirrors;
2083 *nf_output_iface = NF_OUT_FLOOD;
2084 } else if (out_port && set_dst(dst, flow, in_port, out_port, tags)) {
2085 *nf_output_iface = dst->dp_ifidx;
2086 mirrors |= out_port->dst_mirrors;
2091 struct mirror *m = br->mirrors[mirror_mask_ffs(mirrors) - 1];
2092 if (!m->n_vlans || vlan_is_mirrored(m, vlan)) {
2094 if (set_dst(dst, flow, in_port, m->out_port, tags)
2095 && !dst_is_duplicate(dsts, dst - dsts, dst)) {
2099 for (i = 0; i < br->n_ports; i++) {
2100 struct port *port = br->ports[i];
2101 if (port_includes_vlan(port, m->out_vlan)
2102 && set_dst(dst, flow, in_port, port, tags))
2106 if (port->vlan < 0) {
2107 dst->vlan = m->out_vlan;
2109 if (dst_is_duplicate(dsts, dst - dsts, dst)) {
2113 /* Use the vlan tag on the original flow instead of
2114 * the one passed in the vlan parameter. This ensures
2115 * that we compare the vlan from before any implicit
2116 * tagging tags place. This is necessary because
2117 * dst->vlan is the final vlan, after removing implicit
2119 flow_vlan = ntohs(flow->dl_vlan);
2120 if (flow_vlan == 0) {
2121 flow_vlan = OFP_VLAN_NONE;
2123 if (port == in_port && dst->vlan == flow_vlan) {
2124 /* Don't send out input port on same VLAN. */
2132 mirrors &= mirrors - 1;
2135 partition_dsts(dsts, dst - dsts, ntohs(flow->dl_vlan));
2139 static void OVS_UNUSED
2140 print_dsts(const struct dst *dsts, size_t n)
2142 for (; n--; dsts++) {
2143 printf(">p%"PRIu16, dsts->dp_ifidx);
2144 if (dsts->vlan != OFP_VLAN_NONE) {
2145 printf("v%"PRIu16, dsts->vlan);
2151 compose_actions(struct bridge *br, const flow_t *flow, uint16_t vlan,
2152 const struct port *in_port, const struct port *out_port,
2153 tag_type *tags, struct odp_actions *actions,
2154 uint16_t *nf_output_iface)
2156 struct dst dsts[DP_MAX_PORTS * (MAX_MIRRORS + 1)];
2158 const struct dst *p;
2161 n_dsts = compose_dsts(br, flow, vlan, in_port, out_port, dsts, tags,
2164 cur_vlan = ntohs(flow->dl_vlan);
2165 for (p = dsts; p < &dsts[n_dsts]; p++) {
2166 union odp_action *a;
2167 if (p->vlan != cur_vlan) {
2168 if (p->vlan == OFP_VLAN_NONE) {
2169 odp_actions_add(actions, ODPAT_STRIP_VLAN);
2171 a = odp_actions_add(actions, ODPAT_SET_VLAN_VID);
2172 a->vlan_vid.vlan_vid = htons(p->vlan);
2176 a = odp_actions_add(actions, ODPAT_OUTPUT);
2177 a->output.port = p->dp_ifidx;
2181 /* Returns the effective vlan of a packet, taking into account both the
2182 * 802.1Q header and implicitly tagged ports. A value of 0 indicates that
2183 * the packet is untagged and -1 indicates it has an invalid header and
2184 * should be dropped. */
2185 static int flow_get_vlan(struct bridge *br, const flow_t *flow,
2186 struct port *in_port, bool have_packet)
2188 /* Note that dl_vlan of 0 and of OFP_VLAN_NONE both mean that the packet
2189 * belongs to VLAN 0, so we should treat both cases identically. (In the
2190 * former case, the packet has an 802.1Q header that specifies VLAN 0,
2191 * presumably to allow a priority to be specified. In the latter case, the
2192 * packet does not have any 802.1Q header.) */
2193 int vlan = ntohs(flow->dl_vlan);
2194 if (vlan == OFP_VLAN_NONE) {
2197 if (in_port->vlan >= 0) {
2199 /* XXX support double tagging? */
2201 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2202 VLOG_WARN_RL(&rl, "bridge %s: dropping VLAN %"PRIu16" tagged "
2203 "packet received on port %s configured with "
2204 "implicit VLAN %"PRIu16,
2205 br->name, ntohs(flow->dl_vlan),
2206 in_port->name, in_port->vlan);
2210 vlan = in_port->vlan;
2212 if (!port_includes_vlan(in_port, vlan)) {
2214 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2215 VLOG_WARN_RL(&rl, "bridge %s: dropping VLAN %d tagged "
2216 "packet received on port %s not configured for "
2218 br->name, vlan, in_port->name, vlan);
2227 /* A VM broadcasts a gratuitous ARP to indicate that it has resumed after
2228 * migration. Older Citrix-patched Linux DomU used gratuitous ARP replies to
2229 * indicate this; newer upstream kernels use gratuitous ARP requests. */
2231 is_gratuitous_arp(const flow_t *flow)
2233 return (flow->dl_type == htons(ETH_TYPE_ARP)
2234 && eth_addr_is_broadcast(flow->dl_dst)
2235 && (flow->nw_proto == ARP_OP_REPLY
2236 || (flow->nw_proto == ARP_OP_REQUEST
2237 && flow->nw_src == flow->nw_dst)));
2241 update_learning_table(struct bridge *br, const flow_t *flow, int vlan,
2242 struct port *in_port)
2244 enum grat_arp_lock_type lock_type;
2247 /* We don't want to learn from gratuitous ARP packets that are reflected
2248 * back over bond slaves so we lock the learning table. */
2249 lock_type = !is_gratuitous_arp(flow) ? GRAT_ARP_LOCK_NONE :
2250 (in_port->n_ifaces == 1) ? GRAT_ARP_LOCK_SET :
2251 GRAT_ARP_LOCK_CHECK;
2253 rev_tag = mac_learning_learn(br->ml, flow->dl_src, vlan, in_port->port_idx,
2256 /* The log messages here could actually be useful in debugging,
2257 * so keep the rate limit relatively high. */
2258 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(30,
2260 VLOG_DBG_RL(&rl, "bridge %s: learned that "ETH_ADDR_FMT" is "
2261 "on port %s in VLAN %d",
2262 br->name, ETH_ADDR_ARGS(flow->dl_src),
2263 in_port->name, vlan);
2264 ofproto_revalidate(br->ofproto, rev_tag);
2268 /* Determines whether packets in 'flow' within 'br' should be forwarded or
2269 * dropped. Returns true if they may be forwarded, false if they should be
2272 * If 'have_packet' is true, it indicates that the caller is processing a
2273 * received packet. If 'have_packet' is false, then the caller is just
2274 * revalidating an existing flow because configuration has changed. Either
2275 * way, 'have_packet' only affects logging (there is no point in logging errors
2276 * during revalidation).
2278 * Sets '*in_portp' to the input port. This will be a null pointer if
2279 * flow->in_port does not designate a known input port (in which case
2280 * is_admissible() returns false).
2282 * When returning true, sets '*vlanp' to the effective VLAN of the input
2283 * packet, as returned by flow_get_vlan().
2285 * May also add tags to '*tags', although the current implementation only does
2286 * so in one special case.
2289 is_admissible(struct bridge *br, const flow_t *flow, bool have_packet,
2290 tag_type *tags, int *vlanp, struct port **in_portp)
2292 struct iface *in_iface;
2293 struct port *in_port;
2296 /* Find the interface and port structure for the received packet. */
2297 in_iface = iface_from_dp_ifidx(br, flow->in_port);
2299 /* No interface? Something fishy... */
2301 /* Odd. A few possible reasons here:
2303 * - We deleted an interface but there are still a few packets
2304 * queued up from it.
2306 * - Someone externally added an interface (e.g. with "ovs-dpctl
2307 * add-if") that we don't know about.
2309 * - Packet arrived on the local port but the local port is not
2310 * one of our bridge ports.
2312 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2314 VLOG_WARN_RL(&rl, "bridge %s: received packet on unknown "
2315 "interface %"PRIu16, br->name, flow->in_port);
2321 *in_portp = in_port = in_iface->port;
2322 *vlanp = vlan = flow_get_vlan(br, flow, in_port, have_packet);
2327 /* Drop frames for reserved multicast addresses. */
2328 if (eth_addr_is_reserved(flow->dl_dst)) {
2332 /* Drop frames on ports reserved for mirroring. */
2333 if (in_port->is_mirror_output_port) {
2335 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2336 VLOG_WARN_RL(&rl, "bridge %s: dropping packet received on port "
2337 "%s, which is reserved exclusively for mirroring",
2338 br->name, in_port->name);
2343 /* Packets received on bonds need special attention to avoid duplicates. */
2344 if (in_port->n_ifaces > 1) {
2346 bool is_grat_arp_locked;
2348 if (eth_addr_is_multicast(flow->dl_dst)) {
2349 *tags |= in_port->active_iface_tag;
2350 if (in_port->active_iface != in_iface->port_ifidx) {
2351 /* Drop all multicast packets on inactive slaves. */
2356 /* Drop all packets for which we have learned a different input
2357 * port, because we probably sent the packet on one slave and got
2358 * it back on the other. Gratuitous ARP packets are an exception
2359 * to this rule: the host has moved to another switch. The exception
2360 * to the exception is if we locked the learning table to avoid
2361 * reflections on bond slaves. If this is the case, just drop the
2363 src_idx = mac_learning_lookup(br->ml, flow->dl_src, vlan,
2364 &is_grat_arp_locked);
2365 if (src_idx != -1 && src_idx != in_port->port_idx &&
2366 (!is_gratuitous_arp(flow) || is_grat_arp_locked)) {
2374 /* If the composed actions may be applied to any packet in the given 'flow',
2375 * returns true. Otherwise, the actions should only be applied to 'packet', or
2376 * not at all, if 'packet' was NULL. */
2378 process_flow(struct bridge *br, const flow_t *flow,
2379 const struct ofpbuf *packet, struct odp_actions *actions,
2380 tag_type *tags, uint16_t *nf_output_iface)
2382 struct port *in_port;
2383 struct port *out_port;
2387 /* Check whether we should drop packets in this flow. */
2388 if (!is_admissible(br, flow, packet != NULL, tags, &vlan, &in_port)) {
2393 /* Learn source MAC (but don't try to learn from revalidation). */
2395 update_learning_table(br, flow, vlan, in_port);
2398 /* Determine output port. */
2399 out_port_idx = mac_learning_lookup_tag(br->ml, flow->dl_dst, vlan, tags,
2401 if (out_port_idx >= 0 && out_port_idx < br->n_ports) {
2402 out_port = br->ports[out_port_idx];
2403 } else if (!packet && !eth_addr_is_multicast(flow->dl_dst)) {
2404 /* If we are revalidating but don't have a learning entry then
2405 * eject the flow. Installing a flow that floods packets opens
2406 * up a window of time where we could learn from a packet reflected
2407 * on a bond and blackhole packets before the learning table is
2408 * updated to reflect the correct port. */
2411 out_port = FLOOD_PORT;
2414 /* Don't send packets out their input ports. */
2415 if (in_port == out_port) {
2421 compose_actions(br, flow, vlan, in_port, out_port, tags, actions,
2428 /* Careful: 'opp' is in host byte order and opp->port_no is an OFP port
2431 bridge_port_changed_ofhook_cb(enum ofp_port_reason reason,
2432 const struct ofp_phy_port *opp,
2435 struct bridge *br = br_;
2436 struct iface *iface;
2439 iface = iface_from_dp_ifidx(br, ofp_port_to_odp_port(opp->port_no));
2445 if (reason == OFPPR_DELETE) {
2446 VLOG_WARN("bridge %s: interface %s deleted unexpectedly",
2447 br->name, iface->name);
2448 iface_destroy(iface);
2449 if (!port->n_ifaces) {
2450 VLOG_WARN("bridge %s: port %s has no interfaces, dropping",
2451 br->name, port->name);
2457 if (port->n_ifaces > 1) {
2458 bool up = !(opp->state & OFPPS_LINK_DOWN);
2459 bond_link_status_update(iface, up);
2460 port_update_bond_compat(port);
2466 bridge_normal_ofhook_cb(const flow_t *flow, const struct ofpbuf *packet,
2467 struct odp_actions *actions, tag_type *tags,
2468 uint16_t *nf_output_iface, void *br_)
2470 struct bridge *br = br_;
2472 COVERAGE_INC(bridge_process_flow);
2473 return process_flow(br, flow, packet, actions, tags, nf_output_iface);
2477 bridge_account_flow_ofhook_cb(const flow_t *flow,
2478 const union odp_action *actions,
2479 size_t n_actions, unsigned long long int n_bytes,
2482 struct bridge *br = br_;
2483 const union odp_action *a;
2484 struct port *in_port;
2488 /* Feed information from the active flows back into the learning table
2489 * to ensure that table is always in sync with what is actually flowing
2490 * through the datapath. */
2491 if (is_admissible(br, flow, false, &tags, &vlan, &in_port)) {
2492 update_learning_table(br, flow, vlan, in_port);
2495 if (!br->has_bonded_ports) {
2499 for (a = actions; a < &actions[n_actions]; a++) {
2500 if (a->type == ODPAT_OUTPUT) {
2501 struct port *out_port = port_from_dp_ifidx(br, a->output.port);
2502 if (out_port && out_port->n_ifaces >= 2) {
2503 struct bond_entry *e = lookup_bond_entry(out_port,
2505 e->tx_bytes += n_bytes;
2512 bridge_account_checkpoint_ofhook_cb(void *br_)
2514 struct bridge *br = br_;
2518 if (!br->has_bonded_ports) {
2523 for (i = 0; i < br->n_ports; i++) {
2524 struct port *port = br->ports[i];
2525 if (port->n_ifaces > 1 && now >= port->bond_next_rebalance) {
2526 port->bond_next_rebalance = now + port->bond_rebalance_interval;
2527 bond_rebalance_port(port);
2532 static struct ofhooks bridge_ofhooks = {
2533 bridge_port_changed_ofhook_cb,
2534 bridge_normal_ofhook_cb,
2535 bridge_account_flow_ofhook_cb,
2536 bridge_account_checkpoint_ofhook_cb,
2539 /* Bonding functions. */
2541 /* Statistics for a single interface on a bonded port, used for load-based
2542 * bond rebalancing. */
2543 struct slave_balance {
2544 struct iface *iface; /* The interface. */
2545 uint64_t tx_bytes; /* Sum of hashes[*]->tx_bytes. */
2547 /* All the "bond_entry"s that are assigned to this interface, in order of
2548 * increasing tx_bytes. */
2549 struct bond_entry **hashes;
2553 /* Sorts pointers to pointers to bond_entries in ascending order by the
2554 * interface to which they are assigned, and within a single interface in
2555 * ascending order of bytes transmitted. */
2557 compare_bond_entries(const void *a_, const void *b_)
2559 const struct bond_entry *const *ap = a_;
2560 const struct bond_entry *const *bp = b_;
2561 const struct bond_entry *a = *ap;
2562 const struct bond_entry *b = *bp;
2563 if (a->iface_idx != b->iface_idx) {
2564 return a->iface_idx > b->iface_idx ? 1 : -1;
2565 } else if (a->tx_bytes != b->tx_bytes) {
2566 return a->tx_bytes > b->tx_bytes ? 1 : -1;
2572 /* Sorts slave_balances so that enabled ports come first, and otherwise in
2573 * *descending* order by number of bytes transmitted. */
2575 compare_slave_balance(const void *a_, const void *b_)
2577 const struct slave_balance *a = a_;
2578 const struct slave_balance *b = b_;
2579 if (a->iface->enabled != b->iface->enabled) {
2580 return a->iface->enabled ? -1 : 1;
2581 } else if (a->tx_bytes != b->tx_bytes) {
2582 return a->tx_bytes > b->tx_bytes ? -1 : 1;
2589 swap_bals(struct slave_balance *a, struct slave_balance *b)
2591 struct slave_balance tmp = *a;
2596 /* Restores the 'n_bals' slave_balance structures in 'bals' to sorted order
2597 * given that 'p' (and only 'p') might be in the wrong location.
2599 * This function invalidates 'p', since it might now be in a different memory
2602 resort_bals(struct slave_balance *p,
2603 struct slave_balance bals[], size_t n_bals)
2606 for (; p > bals && p->tx_bytes > p[-1].tx_bytes; p--) {
2607 swap_bals(p, p - 1);
2609 for (; p < &bals[n_bals - 1] && p->tx_bytes < p[1].tx_bytes; p++) {
2610 swap_bals(p, p + 1);
2616 log_bals(const struct slave_balance *bals, size_t n_bals, struct port *port)
2618 if (VLOG_IS_DBG_ENABLED()) {
2619 struct ds ds = DS_EMPTY_INITIALIZER;
2620 const struct slave_balance *b;
2622 for (b = bals; b < bals + n_bals; b++) {
2626 ds_put_char(&ds, ',');
2628 ds_put_format(&ds, " %s %"PRIu64"kB",
2629 b->iface->name, b->tx_bytes / 1024);
2631 if (!b->iface->enabled) {
2632 ds_put_cstr(&ds, " (disabled)");
2634 if (b->n_hashes > 0) {
2635 ds_put_cstr(&ds, " (");
2636 for (i = 0; i < b->n_hashes; i++) {
2637 const struct bond_entry *e = b->hashes[i];
2639 ds_put_cstr(&ds, " + ");
2641 ds_put_format(&ds, "h%td: %"PRIu64"kB",
2642 e - port->bond_hash, e->tx_bytes / 1024);
2644 ds_put_cstr(&ds, ")");
2647 VLOG_DBG("bond %s:%s", port->name, ds_cstr(&ds));
2652 /* Shifts 'hash' from 'from' to 'to' within 'port'. */
2654 bond_shift_load(struct slave_balance *from, struct slave_balance *to,
2657 struct bond_entry *hash = from->hashes[hash_idx];
2658 struct port *port = from->iface->port;
2659 uint64_t delta = hash->tx_bytes;
2661 VLOG_INFO("bond %s: shift %"PRIu64"kB of load (with hash %td) "
2662 "from %s to %s (now carrying %"PRIu64"kB and "
2663 "%"PRIu64"kB load, respectively)",
2664 port->name, delta / 1024, hash - port->bond_hash,
2665 from->iface->name, to->iface->name,
2666 (from->tx_bytes - delta) / 1024,
2667 (to->tx_bytes + delta) / 1024);
2669 /* Delete element from from->hashes.
2671 * We don't bother to add the element to to->hashes because not only would
2672 * it require more work, the only purpose it would be to allow that hash to
2673 * be migrated to another slave in this rebalancing run, and there is no
2674 * point in doing that. */
2675 if (hash_idx == 0) {
2678 memmove(from->hashes + hash_idx, from->hashes + hash_idx + 1,
2679 (from->n_hashes - (hash_idx + 1)) * sizeof *from->hashes);
2683 /* Shift load away from 'from' to 'to'. */
2684 from->tx_bytes -= delta;
2685 to->tx_bytes += delta;
2687 /* Arrange for flows to be revalidated. */
2688 ofproto_revalidate(port->bridge->ofproto, hash->iface_tag);
2689 hash->iface_idx = to->iface->port_ifidx;
2690 hash->iface_tag = tag_create_random();
2694 bond_rebalance_port(struct port *port)
2696 struct slave_balance bals[DP_MAX_PORTS];
2698 struct bond_entry *hashes[BOND_MASK + 1];
2699 struct slave_balance *b, *from, *to;
2700 struct bond_entry *e;
2703 /* Sets up 'bals' to describe each of the port's interfaces, sorted in
2704 * descending order of tx_bytes, so that bals[0] represents the most
2705 * heavily loaded slave and bals[n_bals - 1] represents the least heavily
2708 * The code is a bit tricky: to avoid dynamically allocating a 'hashes'
2709 * array for each slave_balance structure, we sort our local array of
2710 * hashes in order by slave, so that all of the hashes for a given slave
2711 * become contiguous in memory, and then we point each 'hashes' members of
2712 * a slave_balance structure to the start of a contiguous group. */
2713 n_bals = port->n_ifaces;
2714 for (b = bals; b < &bals[n_bals]; b++) {
2715 b->iface = port->ifaces[b - bals];
2720 for (i = 0; i <= BOND_MASK; i++) {
2721 hashes[i] = &port->bond_hash[i];
2723 qsort(hashes, BOND_MASK + 1, sizeof *hashes, compare_bond_entries);
2724 for (i = 0; i <= BOND_MASK; i++) {
2726 if (e->iface_idx >= 0 && e->iface_idx < port->n_ifaces) {
2727 b = &bals[e->iface_idx];
2728 b->tx_bytes += e->tx_bytes;
2730 b->hashes = &hashes[i];
2735 qsort(bals, n_bals, sizeof *bals, compare_slave_balance);
2736 log_bals(bals, n_bals, port);
2738 /* Discard slaves that aren't enabled (which were sorted to the back of the
2739 * array earlier). */
2740 while (!bals[n_bals - 1].iface->enabled) {
2747 /* Shift load from the most-loaded slaves to the least-loaded slaves. */
2748 to = &bals[n_bals - 1];
2749 for (from = bals; from < to; ) {
2750 uint64_t overload = from->tx_bytes - to->tx_bytes;
2751 if (overload < to->tx_bytes >> 5 || overload < 100000) {
2752 /* The extra load on 'from' (and all less-loaded slaves), compared
2753 * to that of 'to' (the least-loaded slave), is less than ~3%, or
2754 * it is less than ~1Mbps. No point in rebalancing. */
2756 } else if (from->n_hashes == 1) {
2757 /* 'from' only carries a single MAC hash, so we can't shift any
2758 * load away from it, even though we want to. */
2761 /* 'from' is carrying significantly more load than 'to', and that
2762 * load is split across at least two different hashes. Pick a hash
2763 * to migrate to 'to' (the least-loaded slave), given that doing so
2764 * must decrease the ratio of the load on the two slaves by at
2767 * The sort order we use means that we prefer to shift away the
2768 * smallest hashes instead of the biggest ones. There is little
2769 * reason behind this decision; we could use the opposite sort
2770 * order to shift away big hashes ahead of small ones. */
2774 for (i = 0; i < from->n_hashes; i++) {
2775 double old_ratio, new_ratio;
2776 uint64_t delta = from->hashes[i]->tx_bytes;
2778 if (delta == 0 || from->tx_bytes - delta == 0) {
2779 /* Pointless move. */
2783 order_swapped = from->tx_bytes - delta < to->tx_bytes + delta;
2785 if (to->tx_bytes == 0) {
2786 /* Nothing on the new slave, move it. */
2790 old_ratio = (double)from->tx_bytes / to->tx_bytes;
2791 new_ratio = (double)(from->tx_bytes - delta) /
2792 (to->tx_bytes + delta);
2794 if (new_ratio == 0) {
2795 /* Should already be covered but check to prevent division
2800 if (new_ratio < 1) {
2801 new_ratio = 1 / new_ratio;
2804 if (old_ratio - new_ratio > 0.1) {
2805 /* Would decrease the ratio, move it. */
2809 if (i < from->n_hashes) {
2810 bond_shift_load(from, to, i);
2811 port->bond_compat_is_stale = true;
2813 /* If the result of the migration changed the relative order of
2814 * 'from' and 'to' swap them back to maintain invariants. */
2815 if (order_swapped) {
2816 swap_bals(from, to);
2819 /* Re-sort 'bals'. Note that this may make 'from' and 'to'
2820 * point to different slave_balance structures. It is only
2821 * valid to do these two operations in a row at all because we
2822 * know that 'from' will not move past 'to' and vice versa. */
2823 resort_bals(from, bals, n_bals);
2824 resort_bals(to, bals, n_bals);
2831 /* Implement exponentially weighted moving average. A weight of 1/2 causes
2832 * historical data to decay to <1% in 7 rebalancing runs. */
2833 for (e = &port->bond_hash[0]; e <= &port->bond_hash[BOND_MASK]; e++) {
2839 bond_send_learning_packets(struct port *port)
2841 struct bridge *br = port->bridge;
2842 struct mac_entry *e;
2843 struct ofpbuf packet;
2844 int error, n_packets, n_errors;
2846 if (!port->n_ifaces || port->active_iface < 0) {
2850 ofpbuf_init(&packet, 128);
2851 error = n_packets = n_errors = 0;
2852 LIST_FOR_EACH (e, struct mac_entry, lru_node, &br->ml->lrus) {
2853 union ofp_action actions[2], *a;
2859 if (e->port == port->port_idx
2860 || !choose_output_iface(port, e->mac, &dp_ifidx, &tags)) {
2864 /* Compose actions. */
2865 memset(actions, 0, sizeof actions);
2868 a->vlan_vid.type = htons(OFPAT_SET_VLAN_VID);
2869 a->vlan_vid.len = htons(sizeof *a);
2870 a->vlan_vid.vlan_vid = htons(e->vlan);
2873 a->output.type = htons(OFPAT_OUTPUT);
2874 a->output.len = htons(sizeof *a);
2875 a->output.port = htons(odp_port_to_ofp_port(dp_ifidx));
2880 compose_benign_packet(&packet, "Open vSwitch Bond Failover", 0xf177,
2882 flow_extract(&packet, 0, ODPP_NONE, &flow);
2883 retval = ofproto_send_packet(br->ofproto, &flow, actions, a - actions,
2890 ofpbuf_uninit(&packet);
2893 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2894 VLOG_WARN_RL(&rl, "bond %s: %d errors sending %d gratuitous learning "
2895 "packets, last error was: %s",
2896 port->name, n_errors, n_packets, strerror(error));
2898 VLOG_DBG("bond %s: sent %d gratuitous learning packets",
2899 port->name, n_packets);
2903 /* Bonding unixctl user interface functions. */
2906 bond_unixctl_list(struct unixctl_conn *conn,
2907 const char *args OVS_UNUSED, void *aux OVS_UNUSED)
2909 struct ds ds = DS_EMPTY_INITIALIZER;
2910 const struct bridge *br;
2912 ds_put_cstr(&ds, "bridge\tbond\tslaves\n");
2914 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
2917 for (i = 0; i < br->n_ports; i++) {
2918 const struct port *port = br->ports[i];
2919 if (port->n_ifaces > 1) {
2922 ds_put_format(&ds, "%s\t%s\t", br->name, port->name);
2923 for (j = 0; j < port->n_ifaces; j++) {
2924 const struct iface *iface = port->ifaces[j];
2926 ds_put_cstr(&ds, ", ");
2928 ds_put_cstr(&ds, iface->name);
2930 ds_put_char(&ds, '\n');
2934 unixctl_command_reply(conn, 200, ds_cstr(&ds));
2938 static struct port *
2939 bond_find(const char *name)
2941 const struct bridge *br;
2943 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
2946 for (i = 0; i < br->n_ports; i++) {
2947 struct port *port = br->ports[i];
2948 if (!strcmp(port->name, name) && port->n_ifaces > 1) {
2957 bond_unixctl_show(struct unixctl_conn *conn,
2958 const char *args, void *aux OVS_UNUSED)
2960 struct ds ds = DS_EMPTY_INITIALIZER;
2961 const struct port *port;
2964 port = bond_find(args);
2966 unixctl_command_reply(conn, 501, "no such bond");
2970 ds_put_format(&ds, "updelay: %d ms\n", port->updelay);
2971 ds_put_format(&ds, "downdelay: %d ms\n", port->downdelay);
2972 ds_put_format(&ds, "next rebalance: %lld ms\n",
2973 port->bond_next_rebalance - time_msec());
2974 for (j = 0; j < port->n_ifaces; j++) {
2975 const struct iface *iface = port->ifaces[j];
2976 struct bond_entry *be;
2979 ds_put_format(&ds, "slave %s: %s\n",
2980 iface->name, iface->enabled ? "enabled" : "disabled");
2981 if (j == port->active_iface) {
2982 ds_put_cstr(&ds, "\tactive slave\n");
2984 if (iface->delay_expires != LLONG_MAX) {
2985 ds_put_format(&ds, "\t%s expires in %lld ms\n",
2986 iface->enabled ? "downdelay" : "updelay",
2987 iface->delay_expires - time_msec());
2991 for (be = port->bond_hash; be <= &port->bond_hash[BOND_MASK]; be++) {
2992 int hash = be - port->bond_hash;
2993 struct mac_entry *me;
2995 if (be->iface_idx != j) {
2999 ds_put_format(&ds, "\thash %d: %"PRIu64" kB load\n",
3000 hash, be->tx_bytes / 1024);
3003 LIST_FOR_EACH (me, struct mac_entry, lru_node,
3004 &port->bridge->ml->lrus) {
3007 if (bond_hash(me->mac) == hash
3008 && me->port != port->port_idx
3009 && choose_output_iface(port, me->mac, &dp_ifidx, &tags)
3010 && dp_ifidx == iface->dp_ifidx)
3012 ds_put_format(&ds, "\t\t"ETH_ADDR_FMT"\n",
3013 ETH_ADDR_ARGS(me->mac));
3018 unixctl_command_reply(conn, 200, ds_cstr(&ds));
3023 bond_unixctl_migrate(struct unixctl_conn *conn, const char *args_,
3024 void *aux OVS_UNUSED)
3026 char *args = (char *) args_;
3027 char *save_ptr = NULL;
3028 char *bond_s, *hash_s, *slave_s;
3029 uint8_t mac[ETH_ADDR_LEN];
3031 struct iface *iface;
3032 struct bond_entry *entry;
3035 bond_s = strtok_r(args, " ", &save_ptr);
3036 hash_s = strtok_r(NULL, " ", &save_ptr);
3037 slave_s = strtok_r(NULL, " ", &save_ptr);
3039 unixctl_command_reply(conn, 501,
3040 "usage: bond/migrate BOND HASH SLAVE");
3044 port = bond_find(bond_s);
3046 unixctl_command_reply(conn, 501, "no such bond");
3050 if (sscanf(hash_s, ETH_ADDR_SCAN_FMT, ETH_ADDR_SCAN_ARGS(mac))
3051 == ETH_ADDR_SCAN_COUNT) {
3052 hash = bond_hash(mac);
3053 } else if (strspn(hash_s, "0123456789") == strlen(hash_s)) {
3054 hash = atoi(hash_s) & BOND_MASK;
3056 unixctl_command_reply(conn, 501, "bad hash");
3060 iface = port_lookup_iface(port, slave_s);
3062 unixctl_command_reply(conn, 501, "no such slave");
3066 if (!iface->enabled) {
3067 unixctl_command_reply(conn, 501, "cannot migrate to disabled slave");
3071 entry = &port->bond_hash[hash];
3072 ofproto_revalidate(port->bridge->ofproto, entry->iface_tag);
3073 entry->iface_idx = iface->port_ifidx;
3074 entry->iface_tag = tag_create_random();
3075 port->bond_compat_is_stale = true;
3076 unixctl_command_reply(conn, 200, "migrated");
3080 bond_unixctl_set_active_slave(struct unixctl_conn *conn, const char *args_,
3081 void *aux OVS_UNUSED)
3083 char *args = (char *) args_;
3084 char *save_ptr = NULL;
3085 char *bond_s, *slave_s;
3087 struct iface *iface;
3089 bond_s = strtok_r(args, " ", &save_ptr);
3090 slave_s = strtok_r(NULL, " ", &save_ptr);
3092 unixctl_command_reply(conn, 501,
3093 "usage: bond/set-active-slave BOND SLAVE");
3097 port = bond_find(bond_s);
3099 unixctl_command_reply(conn, 501, "no such bond");
3103 iface = port_lookup_iface(port, slave_s);
3105 unixctl_command_reply(conn, 501, "no such slave");
3109 if (!iface->enabled) {
3110 unixctl_command_reply(conn, 501, "cannot make disabled slave active");
3114 if (port->active_iface != iface->port_ifidx) {
3115 ofproto_revalidate(port->bridge->ofproto, port->active_iface_tag);
3116 port->active_iface = iface->port_ifidx;
3117 port->active_iface_tag = tag_create_random();
3118 VLOG_INFO("port %s: active interface is now %s",
3119 port->name, iface->name);
3120 bond_send_learning_packets(port);
3121 unixctl_command_reply(conn, 200, "done");
3123 unixctl_command_reply(conn, 200, "no change");
3128 enable_slave(struct unixctl_conn *conn, const char *args_, bool enable)
3130 char *args = (char *) args_;
3131 char *save_ptr = NULL;
3132 char *bond_s, *slave_s;
3134 struct iface *iface;
3136 bond_s = strtok_r(args, " ", &save_ptr);
3137 slave_s = strtok_r(NULL, " ", &save_ptr);
3139 unixctl_command_reply(conn, 501,
3140 "usage: bond/enable/disable-slave BOND SLAVE");
3144 port = bond_find(bond_s);
3146 unixctl_command_reply(conn, 501, "no such bond");
3150 iface = port_lookup_iface(port, slave_s);
3152 unixctl_command_reply(conn, 501, "no such slave");
3156 bond_enable_slave(iface, enable);
3157 unixctl_command_reply(conn, 501, enable ? "enabled" : "disabled");
3161 bond_unixctl_enable_slave(struct unixctl_conn *conn, const char *args,
3162 void *aux OVS_UNUSED)
3164 enable_slave(conn, args, true);
3168 bond_unixctl_disable_slave(struct unixctl_conn *conn, const char *args,
3169 void *aux OVS_UNUSED)
3171 enable_slave(conn, args, false);
3175 bond_unixctl_hash(struct unixctl_conn *conn, const char *args,
3176 void *aux OVS_UNUSED)
3178 uint8_t mac[ETH_ADDR_LEN];
3182 if (sscanf(args, ETH_ADDR_SCAN_FMT, ETH_ADDR_SCAN_ARGS(mac))
3183 == ETH_ADDR_SCAN_COUNT) {
3184 hash = bond_hash(mac);
3186 hash_cstr = xasprintf("%u", hash);
3187 unixctl_command_reply(conn, 200, hash_cstr);
3190 unixctl_command_reply(conn, 501, "invalid mac");
3197 unixctl_command_register("bond/list", bond_unixctl_list, NULL);
3198 unixctl_command_register("bond/show", bond_unixctl_show, NULL);
3199 unixctl_command_register("bond/migrate", bond_unixctl_migrate, NULL);
3200 unixctl_command_register("bond/set-active-slave",
3201 bond_unixctl_set_active_slave, NULL);
3202 unixctl_command_register("bond/enable-slave", bond_unixctl_enable_slave,
3204 unixctl_command_register("bond/disable-slave", bond_unixctl_disable_slave,
3206 unixctl_command_register("bond/hash", bond_unixctl_hash, NULL);
3209 /* Port functions. */
3211 static struct port *
3212 port_create(struct bridge *br, const char *name)
3216 port = xzalloc(sizeof *port);
3218 port->port_idx = br->n_ports;
3220 port->trunks = NULL;
3221 port->name = xstrdup(name);
3222 port->active_iface = -1;
3224 if (br->n_ports >= br->allocated_ports) {
3225 br->ports = x2nrealloc(br->ports, &br->allocated_ports,
3228 br->ports[br->n_ports++] = port;
3229 shash_add_assert(&br->port_by_name, port->name, port);
3231 VLOG_INFO("created port %s on bridge %s", port->name, br->name);
3238 get_port_other_config(const struct ovsrec_port *port, const char *key,
3239 const char *default_value)
3243 value = get_ovsrec_key_value(&port->header_, &ovsrec_port_col_other_config,
3245 return value ? value : default_value;
3249 port_del_ifaces(struct port *port, const struct ovsrec_port *cfg)
3251 struct shash new_ifaces;
3254 /* Collect list of new interfaces. */
3255 shash_init(&new_ifaces);
3256 for (i = 0; i < cfg->n_interfaces; i++) {
3257 const char *name = cfg->interfaces[i]->name;
3258 shash_add_once(&new_ifaces, name, NULL);
3261 /* Get rid of deleted interfaces. */
3262 for (i = 0; i < port->n_ifaces; ) {
3263 if (!shash_find(&new_ifaces, cfg->interfaces[i]->name)) {
3264 iface_destroy(port->ifaces[i]);
3270 shash_destroy(&new_ifaces);
3274 port_reconfigure(struct port *port, const struct ovsrec_port *cfg)
3276 struct shash new_ifaces;
3277 long long int next_rebalance;
3278 unsigned long *trunks;
3284 /* Update settings. */
3285 port->updelay = cfg->bond_updelay;
3286 if (port->updelay < 0) {
3289 port->updelay = cfg->bond_downdelay;
3290 if (port->downdelay < 0) {
3291 port->downdelay = 0;
3293 port->bond_rebalance_interval = atoi(
3294 get_port_other_config(cfg, "bond-rebalance-interval", "10000"));
3295 if (port->bond_rebalance_interval < 1000) {
3296 port->bond_rebalance_interval = 1000;
3298 next_rebalance = time_msec() + port->bond_rebalance_interval;
3299 if (port->bond_next_rebalance > next_rebalance) {
3300 port->bond_next_rebalance = next_rebalance;
3303 /* Add new interfaces and update 'cfg' member of existing ones. */
3304 shash_init(&new_ifaces);
3305 for (i = 0; i < cfg->n_interfaces; i++) {
3306 const struct ovsrec_interface *if_cfg = cfg->interfaces[i];
3307 struct iface *iface;
3309 if (!shash_add_once(&new_ifaces, if_cfg->name, NULL)) {
3310 VLOG_WARN("port %s: %s specified twice as port interface",
3311 port->name, if_cfg->name);
3315 iface = iface_lookup(port->bridge, if_cfg->name);
3317 if (iface->port != port) {
3318 VLOG_ERR("bridge %s: %s interface is on multiple ports, "
3320 port->bridge->name, if_cfg->name, iface->port->name);
3323 iface->cfg = if_cfg;
3325 iface_create(port, if_cfg);
3328 shash_destroy(&new_ifaces);
3333 if (port->n_ifaces < 2) {
3335 if (vlan >= 0 && vlan <= 4095) {
3336 VLOG_DBG("port %s: assigning VLAN tag %d", port->name, vlan);
3341 /* It's possible that bonded, VLAN-tagged ports make sense. Maybe
3342 * they even work as-is. But they have not been tested. */
3343 VLOG_WARN("port %s: VLAN tags not supported on bonded ports",
3347 if (port->vlan != vlan) {
3349 bridge_flush(port->bridge);
3352 /* Get trunked VLANs. */
3354 if (vlan < 0 && cfg->n_trunks) {
3358 trunks = bitmap_allocate(4096);
3360 for (i = 0; i < cfg->n_trunks; i++) {
3361 int trunk = cfg->trunks[i];
3363 bitmap_set1(trunks, trunk);
3369 VLOG_ERR("port %s: invalid values for %zu trunk VLANs",
3370 port->name, cfg->n_trunks);
3372 if (n_errors == cfg->n_trunks) {
3373 VLOG_ERR("port %s: no valid trunks, trunking all VLANs",
3375 bitmap_free(trunks);
3378 } else if (vlan >= 0 && cfg->n_trunks) {
3379 VLOG_ERR("port %s: ignoring trunks in favor of implicit vlan",
3383 ? port->trunks != NULL
3384 : port->trunks == NULL || !bitmap_equal(trunks, port->trunks, 4096)) {
3385 bridge_flush(port->bridge);
3387 bitmap_free(port->trunks);
3388 port->trunks = trunks;
3392 port_destroy(struct port *port)
3395 struct bridge *br = port->bridge;
3399 proc_net_compat_update_vlan(port->name, NULL, 0);
3400 proc_net_compat_update_bond(port->name, NULL);
3402 for (i = 0; i < MAX_MIRRORS; i++) {
3403 struct mirror *m = br->mirrors[i];
3404 if (m && m->out_port == port) {
3409 while (port->n_ifaces > 0) {
3410 iface_destroy(port->ifaces[port->n_ifaces - 1]);
3413 shash_find_and_delete_assert(&br->port_by_name, port->name);
3415 del = br->ports[port->port_idx] = br->ports[--br->n_ports];
3416 del->port_idx = port->port_idx;
3419 bitmap_free(port->trunks);
3426 static struct port *
3427 port_from_dp_ifidx(const struct bridge *br, uint16_t dp_ifidx)
3429 struct iface *iface = iface_from_dp_ifidx(br, dp_ifidx);
3430 return iface ? iface->port : NULL;
3433 static struct port *
3434 port_lookup(const struct bridge *br, const char *name)
3436 return shash_find_data(&br->port_by_name, name);
3439 static struct iface *
3440 port_lookup_iface(const struct port *port, const char *name)
3442 struct iface *iface = iface_lookup(port->bridge, name);
3443 return iface && iface->port == port ? iface : NULL;
3447 port_update_bonding(struct port *port)
3449 if (port->n_ifaces < 2) {
3450 /* Not a bonded port. */
3451 if (port->bond_hash) {
3452 free(port->bond_hash);
3453 port->bond_hash = NULL;
3454 port->bond_compat_is_stale = true;
3455 port->bond_fake_iface = false;
3458 if (!port->bond_hash) {
3461 port->bond_hash = xcalloc(BOND_MASK + 1, sizeof *port->bond_hash);
3462 for (i = 0; i <= BOND_MASK; i++) {
3463 struct bond_entry *e = &port->bond_hash[i];
3467 port->no_ifaces_tag = tag_create_random();
3468 bond_choose_active_iface(port);
3469 port->bond_next_rebalance
3470 = time_msec() + port->bond_rebalance_interval;
3472 if (port->cfg->bond_fake_iface) {
3473 port->bond_next_fake_iface_update = time_msec();
3476 port->bond_compat_is_stale = true;
3477 port->bond_fake_iface = port->cfg->bond_fake_iface;
3482 port_update_bond_compat(struct port *port)
3484 struct compat_bond_hash compat_hashes[BOND_MASK + 1];
3485 struct compat_bond bond;
3488 if (port->n_ifaces < 2) {
3489 proc_net_compat_update_bond(port->name, NULL);
3494 bond.updelay = port->updelay;
3495 bond.downdelay = port->downdelay;
3498 bond.hashes = compat_hashes;
3499 if (port->bond_hash) {
3500 const struct bond_entry *e;
3501 for (e = port->bond_hash; e <= &port->bond_hash[BOND_MASK]; e++) {
3502 if (e->iface_idx >= 0 && e->iface_idx < port->n_ifaces) {
3503 struct compat_bond_hash *cbh = &bond.hashes[bond.n_hashes++];
3504 cbh->hash = e - port->bond_hash;
3505 cbh->netdev_name = port->ifaces[e->iface_idx]->name;
3510 bond.n_slaves = port->n_ifaces;
3511 bond.slaves = xmalloc(port->n_ifaces * sizeof *bond.slaves);
3512 for (i = 0; i < port->n_ifaces; i++) {
3513 struct iface *iface = port->ifaces[i];
3514 struct compat_bond_slave *slave = &bond.slaves[i];
3515 slave->name = iface->name;
3517 /* We need to make the same determination as the Linux bonding
3518 * code to determine whether a slave should be consider "up".
3519 * The Linux function bond_miimon_inspect() supports four
3520 * BOND_LINK_* states:
3522 * - BOND_LINK_UP: carrier detected, updelay has passed.
3523 * - BOND_LINK_FAIL: carrier lost, downdelay in progress.
3524 * - BOND_LINK_DOWN: carrier lost, downdelay has passed.
3525 * - BOND_LINK_BACK: carrier detected, updelay in progress.
3527 * The function bond_info_show_slave() only considers BOND_LINK_UP
3528 * to be "up" and anything else to be "down".
3530 slave->up = iface->enabled && iface->delay_expires == LLONG_MAX;
3534 netdev_get_etheraddr(iface->netdev, slave->mac);
3537 if (port->bond_fake_iface) {
3538 struct netdev *bond_netdev;
3540 if (!netdev_open_default(port->name, &bond_netdev)) {
3542 netdev_turn_flags_on(bond_netdev, NETDEV_UP, true);
3544 netdev_turn_flags_off(bond_netdev, NETDEV_UP, true);
3546 netdev_close(bond_netdev);
3550 proc_net_compat_update_bond(port->name, &bond);
3555 port_update_vlan_compat(struct port *port)
3557 struct bridge *br = port->bridge;
3558 char *vlandev_name = NULL;
3560 if (port->vlan > 0) {
3561 /* Figure out the name that the VLAN device should actually have, if it
3562 * existed. This takes some work because the VLAN device would not
3563 * have port->name in its name; rather, it would have the trunk port's
3564 * name, and 'port' would be attached to a bridge that also had the
3565 * VLAN device one of its ports. So we need to find a trunk port that
3566 * includes port->vlan.
3568 * There might be more than one candidate. This doesn't happen on
3569 * XenServer, so if it happens we just pick the first choice in
3570 * alphabetical order instead of creating multiple VLAN devices. */
3572 for (i = 0; i < br->n_ports; i++) {
3573 struct port *p = br->ports[i];
3574 if (port_trunks_vlan(p, port->vlan)
3576 && (!vlandev_name || strcmp(p->name, vlandev_name) <= 0))
3578 uint8_t ea[ETH_ADDR_LEN];
3579 netdev_get_etheraddr(p->ifaces[0]->netdev, ea);
3580 if (!eth_addr_is_multicast(ea) &&
3581 !eth_addr_is_reserved(ea) &&
3582 !eth_addr_is_zero(ea)) {
3583 vlandev_name = p->name;
3588 proc_net_compat_update_vlan(port->name, vlandev_name, port->vlan);
3591 /* Interface functions. */
3593 static struct iface *
3594 iface_create(struct port *port, const struct ovsrec_interface *if_cfg)
3596 struct bridge *br = port->bridge;
3597 struct iface *iface;
3598 char *name = if_cfg->name;
3601 iface = xzalloc(sizeof *iface);
3603 iface->port_ifidx = port->n_ifaces;
3604 iface->name = xstrdup(name);
3605 iface->dp_ifidx = -1;
3606 iface->tag = tag_create_random();
3607 iface->delay_expires = LLONG_MAX;
3608 iface->netdev = NULL;
3609 iface->cfg = if_cfg;
3611 shash_add_assert(&br->iface_by_name, iface->name, iface);
3613 /* Attempt to create the network interface in case it doesn't exist yet. */
3614 if (!iface_is_internal(br, iface->name)) {
3615 error = set_up_iface(if_cfg, iface, true);
3617 VLOG_WARN("could not create iface %s: %s", iface->name,
3620 shash_find_and_delete_assert(&br->iface_by_name, iface->name);
3627 if (port->n_ifaces >= port->allocated_ifaces) {
3628 port->ifaces = x2nrealloc(port->ifaces, &port->allocated_ifaces,
3629 sizeof *port->ifaces);
3631 port->ifaces[port->n_ifaces++] = iface;
3632 if (port->n_ifaces > 1) {
3633 br->has_bonded_ports = true;
3636 VLOG_DBG("attached network device %s to port %s", iface->name, port->name);
3644 iface_destroy(struct iface *iface)
3647 struct port *port = iface->port;
3648 struct bridge *br = port->bridge;
3649 bool del_active = port->active_iface == iface->port_ifidx;
3652 shash_find_and_delete_assert(&br->iface_by_name, iface->name);
3654 if (iface->dp_ifidx >= 0) {
3655 port_array_set(&br->ifaces, iface->dp_ifidx, NULL);
3658 del = port->ifaces[iface->port_ifidx] = port->ifaces[--port->n_ifaces];
3659 del->port_ifidx = iface->port_ifidx;
3661 netdev_close(iface->netdev);
3664 ofproto_revalidate(port->bridge->ofproto, port->active_iface_tag);
3665 bond_choose_active_iface(port);
3666 bond_send_learning_packets(port);
3672 bridge_flush(port->bridge);
3676 static struct iface *
3677 iface_lookup(const struct bridge *br, const char *name)
3679 return shash_find_data(&br->iface_by_name, name);
3682 static struct iface *
3683 iface_from_dp_ifidx(const struct bridge *br, uint16_t dp_ifidx)
3685 return port_array_get(&br->ifaces, dp_ifidx);
3688 /* Returns true if 'iface' is the name of an "internal" interface on bridge
3689 * 'br', that is, an interface that is entirely simulated within the datapath.
3690 * The local port (ODPP_LOCAL) is always an internal interface. Other local
3691 * interfaces are created by setting "iface.<iface>.internal = true".
3693 * In addition, we have a kluge-y feature that creates an internal port with
3694 * the name of a bonded port if "bonding.<bondname>.fake-iface = true" is set.
3695 * This feature needs to go away in the long term. Until then, this is one
3696 * reason why this function takes a name instead of a struct iface: the fake
3697 * interfaces created this way do not have a struct iface. */
3699 iface_is_internal(const struct bridge *br, const char *if_name)
3701 struct iface *iface;
3704 if (!strcmp(if_name, br->name)) {
3708 iface = iface_lookup(br, if_name);
3709 if (iface && !strcmp(iface->cfg->type, "internal")) {
3713 port = port_lookup(br, if_name);
3714 if (port && port->n_ifaces > 1 && port->cfg->bond_fake_iface) {
3720 /* Set Ethernet address of 'iface', if one is specified in the configuration
3723 iface_set_mac(struct iface *iface)
3725 uint8_t ea[ETH_ADDR_LEN];
3727 if (iface->cfg->mac && eth_addr_from_string(iface->cfg->mac, ea)) {
3728 if (eth_addr_is_multicast(ea)) {
3729 VLOG_ERR("interface %s: cannot set MAC to multicast address",
3731 } else if (iface->dp_ifidx == ODPP_LOCAL) {
3732 VLOG_ERR("ignoring iface.%s.mac; use bridge.%s.mac instead",
3733 iface->name, iface->name);
3735 int error = netdev_set_etheraddr(iface->netdev, ea);
3737 VLOG_ERR("interface %s: setting MAC failed (%s)",
3738 iface->name, strerror(error));
3745 shash_from_ovs_idl_map(char **keys, char **values, size_t n,
3746 struct shash *shash)
3751 for (i = 0; i < n; i++) {
3752 shash_add(shash, keys[i], values[i]);
3756 struct iface_delete_queues_cbdata {
3757 struct netdev *netdev;
3758 const struct ovsdb_datum *queues;
3762 queue_ids_include(const struct ovsdb_datum *queues, int64_t target)
3764 union ovsdb_atom atom;
3766 atom.integer = target;
3767 return ovsdb_datum_find_key(queues, &atom, OVSDB_TYPE_INTEGER) != UINT_MAX;
3771 iface_delete_queues(unsigned int queue_id,
3772 const struct shash *details OVS_UNUSED, void *cbdata_)
3774 struct iface_delete_queues_cbdata *cbdata = cbdata_;
3776 if (!queue_ids_include(cbdata->queues, queue_id)) {
3777 netdev_delete_queue(cbdata->netdev, queue_id);
3782 iface_update_qos(struct iface *iface, const struct ovsrec_qos *qos)
3784 if (!qos || qos->type[0] == '\0') {
3785 netdev_set_qos(iface->netdev, NULL, NULL);
3787 struct iface_delete_queues_cbdata cbdata;
3788 struct shash details;
3791 /* Configure top-level Qos for 'iface'. */
3792 shash_from_ovs_idl_map(qos->key_other_config, qos->value_other_config,
3793 qos->n_other_config, &details);
3794 netdev_set_qos(iface->netdev, qos->type, &details);
3795 shash_destroy(&details);
3797 /* Deconfigure queues that were deleted. */
3798 cbdata.netdev = iface->netdev;
3799 cbdata.queues = ovsrec_qos_get_queues(qos, OVSDB_TYPE_INTEGER,
3801 netdev_dump_queues(iface->netdev, iface_delete_queues, &cbdata);
3803 /* Configure queues for 'iface'. */
3804 for (i = 0; i < qos->n_queues; i++) {
3805 const struct ovsrec_queue *queue = qos->value_queues[i];
3806 unsigned int queue_id = qos->key_queues[i];
3808 shash_from_ovs_idl_map(queue->key_other_config,
3809 queue->value_other_config,
3810 queue->n_other_config, &details);
3811 netdev_set_queue(iface->netdev, queue_id, &details);
3812 shash_destroy(&details);
3817 /* Port mirroring. */
3819 static struct mirror *
3820 mirror_find_by_uuid(struct bridge *br, const struct uuid *uuid)
3824 for (i = 0; i < MAX_MIRRORS; i++) {
3825 struct mirror *m = br->mirrors[i];
3826 if (m && uuid_equals(uuid, &m->uuid)) {
3834 mirror_reconfigure(struct bridge *br)
3836 unsigned long *rspan_vlans;
3839 /* Get rid of deleted mirrors. */
3840 for (i = 0; i < MAX_MIRRORS; i++) {
3841 struct mirror *m = br->mirrors[i];
3843 const struct ovsdb_datum *mc;
3844 union ovsdb_atom atom;
3846 mc = ovsrec_bridge_get_mirrors(br->cfg, OVSDB_TYPE_UUID);
3847 atom.uuid = br->mirrors[i]->uuid;
3848 if (ovsdb_datum_find_key(mc, &atom, OVSDB_TYPE_UUID) == UINT_MAX) {
3854 /* Add new mirrors and reconfigure existing ones. */
3855 for (i = 0; i < br->cfg->n_mirrors; i++) {
3856 struct ovsrec_mirror *cfg = br->cfg->mirrors[i];
3857 struct mirror *m = mirror_find_by_uuid(br, &cfg->header_.uuid);
3859 mirror_reconfigure_one(m, cfg);
3861 mirror_create(br, cfg);
3865 /* Update port reserved status. */
3866 for (i = 0; i < br->n_ports; i++) {
3867 br->ports[i]->is_mirror_output_port = false;
3869 for (i = 0; i < MAX_MIRRORS; i++) {
3870 struct mirror *m = br->mirrors[i];
3871 if (m && m->out_port) {
3872 m->out_port->is_mirror_output_port = true;
3876 /* Update flooded vlans (for RSPAN). */
3878 if (br->cfg->n_flood_vlans) {
3879 rspan_vlans = bitmap_allocate(4096);
3881 for (i = 0; i < br->cfg->n_flood_vlans; i++) {
3882 int64_t vlan = br->cfg->flood_vlans[i];
3883 if (vlan >= 0 && vlan < 4096) {
3884 bitmap_set1(rspan_vlans, vlan);
3885 VLOG_INFO("bridge %s: disabling learning on vlan %"PRId64,
3888 VLOG_ERR("bridge %s: invalid value %"PRId64 "for flood VLAN",
3893 if (mac_learning_set_flood_vlans(br->ml, rspan_vlans)) {
3899 mirror_create(struct bridge *br, struct ovsrec_mirror *cfg)
3904 for (i = 0; ; i++) {
3905 if (i >= MAX_MIRRORS) {
3906 VLOG_WARN("bridge %s: maximum of %d port mirrors reached, "
3907 "cannot create %s", br->name, MAX_MIRRORS, cfg->name);
3910 if (!br->mirrors[i]) {
3915 VLOG_INFO("created port mirror %s on bridge %s", cfg->name, br->name);
3918 br->mirrors[i] = m = xzalloc(sizeof *m);
3921 m->name = xstrdup(cfg->name);
3922 shash_init(&m->src_ports);
3923 shash_init(&m->dst_ports);
3929 mirror_reconfigure_one(m, cfg);
3933 mirror_destroy(struct mirror *m)
3936 struct bridge *br = m->bridge;
3939 for (i = 0; i < br->n_ports; i++) {
3940 br->ports[i]->src_mirrors &= ~(MIRROR_MASK_C(1) << m->idx);
3941 br->ports[i]->dst_mirrors &= ~(MIRROR_MASK_C(1) << m->idx);
3944 shash_destroy(&m->src_ports);
3945 shash_destroy(&m->dst_ports);
3948 m->bridge->mirrors[m->idx] = NULL;
3957 mirror_collect_ports(struct mirror *m, struct ovsrec_port **ports, int n_ports,
3958 struct shash *names)
3962 for (i = 0; i < n_ports; i++) {
3963 const char *name = ports[i]->name;
3964 if (port_lookup(m->bridge, name)) {
3965 shash_add_once(names, name, NULL);
3967 VLOG_WARN("bridge %s: mirror %s cannot match on nonexistent "
3968 "port %s", m->bridge->name, m->name, name);
3974 mirror_collect_vlans(struct mirror *m, const struct ovsrec_mirror *cfg,
3980 *vlans = xmalloc(sizeof **vlans * cfg->n_select_vlan);
3982 for (i = 0; i < cfg->n_select_vlan; i++) {
3983 int64_t vlan = cfg->select_vlan[i];
3984 if (vlan < 0 || vlan > 4095) {
3985 VLOG_WARN("bridge %s: mirror %s selects invalid VLAN %"PRId64,
3986 m->bridge->name, m->name, vlan);
3988 (*vlans)[n_vlans++] = vlan;
3995 vlan_is_mirrored(const struct mirror *m, int vlan)
3999 for (i = 0; i < m->n_vlans; i++) {
4000 if (m->vlans[i] == vlan) {
4008 port_trunks_any_mirrored_vlan(const struct mirror *m, const struct port *p)
4012 for (i = 0; i < m->n_vlans; i++) {
4013 if (port_trunks_vlan(p, m->vlans[i])) {
4021 mirror_reconfigure_one(struct mirror *m, struct ovsrec_mirror *cfg)
4023 struct shash src_ports, dst_ports;
4024 mirror_mask_t mirror_bit;
4025 struct port *out_port;
4032 if (strcmp(cfg->name, m->name)) {
4034 m->name = xstrdup(cfg->name);
4037 /* Get output port. */
4038 if (cfg->output_port) {
4039 out_port = port_lookup(m->bridge, cfg->output_port->name);
4041 VLOG_ERR("bridge %s: mirror %s outputs to port not on bridge",
4042 m->bridge->name, m->name);
4048 if (cfg->output_vlan) {
4049 VLOG_ERR("bridge %s: mirror %s specifies both output port and "
4050 "output vlan; ignoring output vlan",
4051 m->bridge->name, m->name);
4053 } else if (cfg->output_vlan) {
4055 out_vlan = *cfg->output_vlan;
4057 VLOG_ERR("bridge %s: mirror %s does not specify output; ignoring",
4058 m->bridge->name, m->name);
4063 shash_init(&src_ports);
4064 shash_init(&dst_ports);
4065 if (cfg->select_all) {
4066 for (i = 0; i < m->bridge->n_ports; i++) {
4067 const char *name = m->bridge->ports[i]->name;
4068 shash_add_once(&src_ports, name, NULL);
4069 shash_add_once(&dst_ports, name, NULL);
4074 /* Get ports, and drop duplicates and ports that don't exist. */
4075 mirror_collect_ports(m, cfg->select_src_port, cfg->n_select_src_port,
4077 mirror_collect_ports(m, cfg->select_dst_port, cfg->n_select_dst_port,
4080 /* Get all the vlans, and drop duplicate and invalid vlans. */
4081 n_vlans = mirror_collect_vlans(m, cfg, &vlans);
4084 /* Update mirror data. */
4085 if (!shash_equal_keys(&m->src_ports, &src_ports)
4086 || !shash_equal_keys(&m->dst_ports, &dst_ports)
4087 || m->n_vlans != n_vlans
4088 || memcmp(m->vlans, vlans, sizeof *vlans * n_vlans)
4089 || m->out_port != out_port
4090 || m->out_vlan != out_vlan) {
4091 bridge_flush(m->bridge);
4093 shash_swap(&m->src_ports, &src_ports);
4094 shash_swap(&m->dst_ports, &dst_ports);
4097 m->n_vlans = n_vlans;
4098 m->out_port = out_port;
4099 m->out_vlan = out_vlan;
4102 mirror_bit = MIRROR_MASK_C(1) << m->idx;
4103 for (i = 0; i < m->bridge->n_ports; i++) {
4104 struct port *port = m->bridge->ports[i];
4106 if (shash_find(&m->src_ports, port->name)
4109 ? port_trunks_any_mirrored_vlan(m, port)
4110 : vlan_is_mirrored(m, port->vlan)))) {
4111 port->src_mirrors |= mirror_bit;
4113 port->src_mirrors &= ~mirror_bit;
4116 if (shash_find(&m->dst_ports, port->name)) {
4117 port->dst_mirrors |= mirror_bit;
4119 port->dst_mirrors &= ~mirror_bit;
4124 shash_destroy(&src_ports);
4125 shash_destroy(&dst_ports);