1 /* Copyright (c) 2008, 2009, 2010, 2011 Nicira Networks
3 * Licensed under the Apache License, Version 2.0 (the "License");
4 * you may not use this file except in compliance with the License.
5 * You may obtain a copy of the License at:
7 * http://www.apache.org/licenses/LICENSE-2.0
9 * Unless required by applicable law or agreed to in writing, software
10 * distributed under the License is distributed on an "AS IS" BASIS,
11 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 * See the License for the specific language governing permissions and
13 * limitations under the License.
28 #include "dynamic-string.h"
35 #include "ofp-print.h"
37 #include "ofproto/ofproto.h"
38 #include "poll-loop.h"
41 #include "socket-util.h"
42 #include "stream-ssl.h"
44 #include "system-stats.h"
48 #include "vswitchd/vswitch-idl.h"
49 #include "xenserver.h"
51 #include "sflow_api.h"
52 #include "vlan-bitmap.h"
54 VLOG_DEFINE_THIS_MODULE(bridge);
56 COVERAGE_DEFINE(bridge_reconfigure);
59 /* These members are always valid. */
60 struct list port_elem; /* Element in struct port's "ifaces" list. */
61 struct hmap_node name_node; /* In struct bridge's "iface_by_name" hmap. */
62 struct port *port; /* Containing port. */
63 char *name; /* Host network device name. */
64 tag_type tag; /* Tag associated with this interface. */
66 /* These members are valid only after bridge_reconfigure() causes them to
68 struct hmap_node ofp_port_node; /* In struct bridge's "ifaces" hmap. */
69 int ofp_port; /* OpenFlow port number, -1 if unknown. */
70 struct netdev *netdev; /* Network device. */
71 const char *type; /* Usually same as cfg->type. */
72 const struct ovsrec_interface *cfg;
76 struct uuid uuid; /* UUID of this "mirror" record in database. */
77 struct hmap_node hmap_node; /* In struct bridge's "mirrors" hmap. */
78 struct bridge *bridge;
83 struct bridge *bridge;
84 struct hmap_node hmap_node; /* Element in struct bridge's "ports" hmap. */
87 const struct ovsrec_port *cfg;
89 /* An ordinary bridge port has 1 interface.
90 * A bridge port for bonding has at least 2 interfaces. */
91 struct list ifaces; /* List of "struct iface"s. */
95 struct hmap_node node; /* In 'all_bridges'. */
96 char *name; /* User-specified arbitrary name. */
97 char *type; /* Datapath type. */
98 uint8_t ea[ETH_ADDR_LEN]; /* Bridge Ethernet Address. */
99 uint8_t default_ea[ETH_ADDR_LEN]; /* Default MAC. */
100 const struct ovsrec_bridge *cfg;
102 /* OpenFlow switch processing. */
103 struct ofproto *ofproto; /* OpenFlow switch. */
106 struct hmap ports; /* "struct port"s indexed by name. */
107 struct hmap ifaces; /* "struct iface"s indexed by ofp_port. */
108 struct hmap iface_by_name; /* "struct iface"s indexed by name. */
110 /* Port mirroring. */
111 struct hmap mirrors; /* "struct mirror" indexed by UUID. */
113 /* Synthetic local port if necessary. */
114 struct ovsrec_port synth_local_port;
115 struct ovsrec_interface synth_local_iface;
116 struct ovsrec_interface *synth_local_ifacep;
119 /* All bridges, indexed by name. */
120 static struct hmap all_bridges = HMAP_INITIALIZER(&all_bridges);
122 /* OVSDB IDL used to obtain configuration. */
123 static struct ovsdb_idl *idl;
125 /* Each time this timer expires, the bridge fetches systems and interface
126 * statistics and pushes them into the database. */
127 #define STATS_INTERVAL (5 * 1000) /* In milliseconds. */
128 static long long int stats_timer = LLONG_MIN;
130 /* Stores the time after which rate limited statistics may be written to the
131 * database. Only updated when changes to the database require rate limiting.
133 #define DB_LIMIT_INTERVAL (1 * 1000) /* In milliseconds. */
134 static long long int db_limiter = LLONG_MIN;
136 static void add_del_bridges(const struct ovsrec_open_vswitch *);
137 static void bridge_del_ofprotos(void);
138 static bool bridge_add_ofprotos(struct bridge *);
139 static void bridge_create(const struct ovsrec_bridge *);
140 static void bridge_destroy(struct bridge *);
141 static struct bridge *bridge_lookup(const char *name);
142 static unixctl_cb_func bridge_unixctl_dump_flows;
143 static unixctl_cb_func bridge_unixctl_reconnect;
144 static size_t bridge_get_controllers(const struct bridge *br,
145 struct ovsrec_controller ***controllersp);
146 static void bridge_add_del_ports(struct bridge *);
147 static void bridge_add_ofproto_ports(struct bridge *);
148 static void bridge_del_ofproto_ports(struct bridge *);
149 static void bridge_refresh_ofp_port(struct bridge *);
150 static void bridge_configure_datapath_id(struct bridge *);
151 static void bridge_configure_flow_eviction_threshold(struct bridge *);
152 static void bridge_configure_netflow(struct bridge *);
153 static void bridge_configure_forward_bpdu(struct bridge *);
154 static void bridge_configure_sflow(struct bridge *, int *sflow_bridge_number);
155 static void bridge_configure_stp(struct bridge *);
156 static void bridge_configure_remotes(struct bridge *,
157 const struct sockaddr_in *managers,
159 static void bridge_pick_local_hw_addr(struct bridge *,
160 uint8_t ea[ETH_ADDR_LEN],
161 struct iface **hw_addr_iface);
162 static uint64_t bridge_pick_datapath_id(struct bridge *,
163 const uint8_t bridge_ea[ETH_ADDR_LEN],
164 struct iface *hw_addr_iface);
165 static const char *bridge_get_other_config(const struct ovsrec_bridge *,
167 static const char *get_port_other_config(const struct ovsrec_port *,
169 const char *default_value);
170 static uint64_t dpid_from_hash(const void *, size_t nbytes);
171 static bool bridge_has_bond_fake_iface(const struct bridge *,
173 static bool port_is_bond_fake_iface(const struct port *);
175 static unixctl_cb_func qos_unixctl_show;
177 static struct port *port_create(struct bridge *, const struct ovsrec_port *);
178 static void port_add_ifaces(struct port *);
179 static void port_del_ifaces(struct port *);
180 static void port_destroy(struct port *);
181 static struct port *port_lookup(const struct bridge *, const char *name);
182 static void port_configure(struct port *);
183 static struct lacp_settings *port_configure_lacp(struct port *,
184 struct lacp_settings *);
185 static void port_configure_bond(struct port *, struct bond_settings *,
186 uint32_t *bond_stable_ids);
187 static bool port_is_synthetic(const struct port *);
189 static void bridge_configure_mirrors(struct bridge *);
190 static struct mirror *mirror_create(struct bridge *,
191 const struct ovsrec_mirror *);
192 static void mirror_destroy(struct mirror *);
193 static bool mirror_configure(struct mirror *, const struct ovsrec_mirror *);
195 static void iface_configure_lacp(struct iface *, struct lacp_slave_settings *);
196 static struct iface *iface_create(struct port *port,
197 const struct ovsrec_interface *if_cfg);
198 static void iface_destroy(struct iface *);
199 static struct iface *iface_lookup(const struct bridge *, const char *name);
200 static struct iface *iface_find(const char *name);
201 static struct iface *iface_from_ofp_port(const struct bridge *,
203 static void iface_set_mac(struct iface *);
204 static void iface_set_ofport(const struct ovsrec_interface *, int64_t ofport);
205 static void iface_clear_db_record(const struct ovsrec_interface *if_cfg);
206 static void iface_configure_qos(struct iface *, const struct ovsrec_qos *);
207 static void iface_configure_cfm(struct iface *);
208 static void iface_refresh_cfm_stats(struct iface *);
209 static void iface_refresh_stats(struct iface *);
210 static void iface_refresh_status(struct iface *);
211 static bool iface_is_synthetic(const struct iface *);
213 static void shash_from_ovs_idl_map(char **keys, char **values, size_t n,
215 static void shash_to_ovs_idl_map(struct shash *,
216 char ***keys, char ***values, size_t *n);
218 /* Public functions. */
220 /* Initializes the bridge module, configuring it to obtain its configuration
221 * from an OVSDB server accessed over 'remote', which should be a string in a
222 * form acceptable to ovsdb_idl_create(). */
224 bridge_init(const char *remote)
226 /* Create connection to database. */
227 idl = ovsdb_idl_create(remote, &ovsrec_idl_class, true);
228 ovsdb_idl_set_lock(idl, "ovs_vswitchd");
230 ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_cur_cfg);
231 ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_statistics);
232 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_external_ids);
233 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_ovs_version);
234 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_db_version);
235 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_type);
236 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_version);
238 ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_datapath_id);
239 ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_status);
240 ovsdb_idl_omit(idl, &ovsrec_bridge_col_external_ids);
242 ovsdb_idl_omit_alert(idl, &ovsrec_port_col_status);
243 ovsdb_idl_omit_alert(idl, &ovsrec_port_col_statistics);
244 ovsdb_idl_omit(idl, &ovsrec_port_col_external_ids);
245 ovsdb_idl_omit(idl, &ovsrec_port_col_fake_bridge);
247 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_admin_state);
248 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_duplex);
249 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_speed);
250 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_state);
251 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_resets);
252 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_mtu);
253 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_ofport);
254 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_statistics);
255 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_status);
256 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_fault);
257 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_remote_mpids);
258 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_lacp_current);
259 ovsdb_idl_omit(idl, &ovsrec_interface_col_external_ids);
261 ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_is_connected);
262 ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_role);
263 ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_status);
264 ovsdb_idl_omit(idl, &ovsrec_controller_col_external_ids);
266 ovsdb_idl_omit(idl, &ovsrec_qos_col_external_ids);
268 ovsdb_idl_omit(idl, &ovsrec_queue_col_external_ids);
270 ovsdb_idl_omit(idl, &ovsrec_mirror_col_external_ids);
272 ovsdb_idl_omit(idl, &ovsrec_netflow_col_external_ids);
274 ovsdb_idl_omit(idl, &ovsrec_sflow_col_external_ids);
276 ovsdb_idl_omit(idl, &ovsrec_manager_col_external_ids);
277 ovsdb_idl_omit(idl, &ovsrec_manager_col_inactivity_probe);
278 ovsdb_idl_omit(idl, &ovsrec_manager_col_is_connected);
279 ovsdb_idl_omit(idl, &ovsrec_manager_col_max_backoff);
280 ovsdb_idl_omit(idl, &ovsrec_manager_col_status);
282 ovsdb_idl_omit(idl, &ovsrec_ssl_col_external_ids);
284 /* Register unixctl commands. */
285 unixctl_command_register("qos/show", "interface", qos_unixctl_show, NULL);
286 unixctl_command_register("bridge/dump-flows", "bridge",
287 bridge_unixctl_dump_flows, NULL);
288 unixctl_command_register("bridge/reconnect", "[bridge]",
289 bridge_unixctl_reconnect, NULL);
298 struct bridge *br, *next_br;
300 HMAP_FOR_EACH_SAFE (br, next_br, node, &all_bridges) {
303 ovsdb_idl_destroy(idl);
306 /* Looks at the list of managers in 'ovs_cfg' and extracts their remote IP
307 * addresses and ports into '*managersp' and '*n_managersp'. The caller is
308 * responsible for freeing '*managersp' (with free()).
310 * You may be asking yourself "why does ovs-vswitchd care?", because
311 * ovsdb-server is responsible for connecting to the managers, and ovs-vswitchd
312 * should not be and in fact is not directly involved in that. But
313 * ovs-vswitchd needs to make sure that ovsdb-server can reach the managers, so
314 * it has to tell in-band control where the managers are to enable that.
315 * (Thus, only managers connected in-band are collected.)
318 collect_in_band_managers(const struct ovsrec_open_vswitch *ovs_cfg,
319 struct sockaddr_in **managersp, size_t *n_managersp)
321 struct sockaddr_in *managers = NULL;
322 size_t n_managers = 0;
326 /* Collect all of the potential targets from the "targets" columns of the
327 * rows pointed to by "manager_options", excluding any that are
330 for (i = 0; i < ovs_cfg->n_manager_options; i++) {
331 struct ovsrec_manager *m = ovs_cfg->manager_options[i];
333 if (m->connection_mode && !strcmp(m->connection_mode, "out-of-band")) {
334 sset_find_and_delete(&targets, m->target);
336 sset_add(&targets, m->target);
340 /* Now extract the targets' IP addresses. */
341 if (!sset_is_empty(&targets)) {
344 managers = xmalloc(sset_count(&targets) * sizeof *managers);
345 SSET_FOR_EACH (target, &targets) {
346 struct sockaddr_in *sin = &managers[n_managers];
348 if ((!strncmp(target, "tcp:", 4)
349 && inet_parse_active(target + 4, JSONRPC_TCP_PORT, sin)) ||
350 (!strncmp(target, "ssl:", 4)
351 && inet_parse_active(target + 4, JSONRPC_SSL_PORT, sin))) {
356 sset_destroy(&targets);
358 *managersp = managers;
359 *n_managersp = n_managers;
363 bridge_reconfigure(const struct ovsrec_open_vswitch *ovs_cfg)
365 struct sockaddr_in *managers;
366 struct bridge *br, *next;
367 int sflow_bridge_number;
370 COVERAGE_INC(bridge_reconfigure);
372 /* Create and destroy "struct bridge"s, "struct port"s, and "struct
373 * iface"s according to 'ovs_cfg', with only very minimal configuration
376 * This is purely an update to bridge data structures. Nothing is pushed
377 * down to ofproto or lower layers. */
378 add_del_bridges(ovs_cfg);
379 HMAP_FOR_EACH (br, node, &all_bridges) {
380 bridge_add_del_ports(br);
383 /* Delete all datapaths and datapath ports that are no longer configured.
385 * The kernel will reject any attempt to add a given port to a datapath if
386 * that port already belongs to a different datapath, so we must do all
387 * port deletions before any port additions. A datapath always has a
388 * "local port" so we must delete not-configured datapaths too. */
389 bridge_del_ofprotos();
390 HMAP_FOR_EACH (br, node, &all_bridges) {
392 bridge_del_ofproto_ports(br);
396 /* Create datapaths and datapath ports that are missing.
398 * After this is done, we have our final set of bridges, ports, and
399 * interfaces. Every "struct bridge" has an ofproto, every "struct port"
400 * has at least one iface, every "struct iface" has a valid ofp_port and
402 HMAP_FOR_EACH_SAFE (br, next, node, &all_bridges) {
403 if (!br->ofproto && !bridge_add_ofprotos(br)) {
407 HMAP_FOR_EACH (br, node, &all_bridges) {
408 bridge_refresh_ofp_port(br);
409 bridge_add_ofproto_ports(br);
412 /* Complete the configuration. */
413 sflow_bridge_number = 0;
414 collect_in_band_managers(ovs_cfg, &managers, &n_managers);
415 HMAP_FOR_EACH (br, node, &all_bridges) {
418 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
421 port_configure(port);
423 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
424 iface_configure_cfm(iface);
425 iface_configure_qos(iface, port->cfg->qos);
426 iface_set_mac(iface);
429 bridge_configure_mirrors(br);
430 bridge_configure_datapath_id(br);
431 bridge_configure_flow_eviction_threshold(br);
432 bridge_configure_forward_bpdu(br);
433 bridge_configure_remotes(br, managers, n_managers);
434 bridge_configure_netflow(br);
435 bridge_configure_sflow(br, &sflow_bridge_number);
436 bridge_configure_stp(br);
440 /* ovs-vswitchd has completed initialization, so allow the process that
441 * forked us to exit successfully. */
442 daemonize_complete();
445 /* Iterate over all ofprotos and delete any of them that do not have a
446 * configured bridge or that are the wrong type. */
448 bridge_del_ofprotos(void)
456 ofproto_enumerate_types(&types);
457 SSET_FOR_EACH (type, &types) {
460 ofproto_enumerate_names(type, &names);
461 SSET_FOR_EACH (name, &names) {
462 struct bridge *br = bridge_lookup(name);
463 if (!br || strcmp(type, br->type)) {
464 ofproto_delete(name, type);
468 sset_destroy(&names);
469 sset_destroy(&types);
473 bridge_add_ofprotos(struct bridge *br)
475 int error = ofproto_create(br->name, br->type, &br->ofproto);
477 VLOG_ERR("failed to create bridge %s: %s", br->name, strerror(error));
484 port_configure(struct port *port)
486 const struct ovsrec_port *cfg = port->cfg;
487 struct bond_settings bond_settings;
488 struct lacp_settings lacp_settings;
489 struct ofproto_bundle_settings s;
497 s.slaves = xmalloc(list_size(&port->ifaces) * sizeof *s.slaves);
498 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
499 s.slaves[s.n_slaves++] = iface->ofp_port;
505 if (list_is_short(&port->ifaces)) {
506 if (*cfg->tag >= 0 && *cfg->tag <= 4095) {
510 /* It's possible that bonded, VLAN-tagged ports make sense. Maybe
511 * they even work as-is. But they have not been tested. */
512 VLOG_WARN("port %s: VLAN tags not supported on bonded ports",
517 /* Get VLAN trunks. */
520 s.trunks = vlan_bitmap_from_array(cfg->trunks, cfg->n_trunks);
524 if (cfg->vlan_mode) {
525 if (!strcmp(cfg->vlan_mode, "access")) {
526 s.vlan_mode = PORT_VLAN_ACCESS;
527 } else if (!strcmp(cfg->vlan_mode, "trunk")) {
528 s.vlan_mode = PORT_VLAN_TRUNK;
529 } else if (!strcmp(cfg->vlan_mode, "native-tagged")) {
530 s.vlan_mode = PORT_VLAN_NATIVE_TAGGED;
531 } else if (!strcmp(cfg->vlan_mode, "native-untagged")) {
532 s.vlan_mode = PORT_VLAN_NATIVE_UNTAGGED;
534 /* This "can't happen" because ovsdb-server should prevent it. */
535 VLOG_ERR("unknown VLAN mode %s", cfg->vlan_mode);
536 s.vlan_mode = PORT_VLAN_TRUNK;
540 s.vlan_mode = PORT_VLAN_ACCESS;
542 VLOG_ERR("port %s: ignoring trunks in favor of implicit vlan",
546 s.vlan_mode = PORT_VLAN_TRUNK;
550 /* Get LACP settings. */
551 s.lacp = port_configure_lacp(port, &lacp_settings);
555 s.lacp_slaves = xmalloc(s.n_slaves * sizeof *s.lacp_slaves);
556 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
557 iface_configure_lacp(iface, &s.lacp_slaves[i++]);
560 s.lacp_slaves = NULL;
563 /* Get bond settings. */
564 if (s.n_slaves > 1) {
565 s.bond = &bond_settings;
566 s.bond_stable_ids = xmalloc(s.n_slaves * sizeof *s.bond_stable_ids);
567 port_configure_bond(port, &bond_settings, s.bond_stable_ids);
570 s.bond_stable_ids = NULL;
572 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
573 netdev_set_miimon_interval(iface->netdev, 0);
578 ofproto_bundle_register(port->bridge->ofproto, port, &s);
584 free(s.bond_stable_ids);
587 /* Pick local port hardware address and datapath ID for 'br'. */
589 bridge_configure_datapath_id(struct bridge *br)
591 uint8_t ea[ETH_ADDR_LEN];
593 struct iface *local_iface;
594 struct iface *hw_addr_iface;
597 bridge_pick_local_hw_addr(br, ea, &hw_addr_iface);
598 local_iface = iface_from_ofp_port(br, OFPP_LOCAL);
600 int error = netdev_set_etheraddr(local_iface->netdev, ea);
602 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
603 VLOG_ERR_RL(&rl, "bridge %s: failed to set bridge "
604 "Ethernet address: %s",
605 br->name, strerror(error));
608 memcpy(br->ea, ea, ETH_ADDR_LEN);
610 dpid = bridge_pick_datapath_id(br, ea, hw_addr_iface);
611 ofproto_set_datapath_id(br->ofproto, dpid);
613 dpid_string = xasprintf("%016"PRIx64, dpid);
614 ovsrec_bridge_set_datapath_id(br->cfg, dpid_string);
618 /* Set NetFlow configuration on 'br'. */
620 bridge_configure_netflow(struct bridge *br)
622 struct ovsrec_netflow *cfg = br->cfg->netflow;
623 struct netflow_options opts;
626 ofproto_set_netflow(br->ofproto, NULL);
630 memset(&opts, 0, sizeof opts);
632 /* Get default NetFlow configuration from datapath.
633 * Apply overrides from 'cfg'. */
634 ofproto_get_netflow_ids(br->ofproto, &opts.engine_type, &opts.engine_id);
635 if (cfg->engine_type) {
636 opts.engine_type = *cfg->engine_type;
638 if (cfg->engine_id) {
639 opts.engine_id = *cfg->engine_id;
642 /* Configure active timeout interval. */
643 opts.active_timeout = cfg->active_timeout;
644 if (!opts.active_timeout) {
645 opts.active_timeout = -1;
646 } else if (opts.active_timeout < 0) {
647 VLOG_WARN("bridge %s: active timeout interval set to negative "
648 "value, using default instead (%d seconds)", br->name,
649 NF_ACTIVE_TIMEOUT_DEFAULT);
650 opts.active_timeout = -1;
653 /* Add engine ID to interface number to disambiguate bridgs? */
654 opts.add_id_to_iface = cfg->add_id_to_interface;
655 if (opts.add_id_to_iface) {
656 if (opts.engine_id > 0x7f) {
657 VLOG_WARN("bridge %s: NetFlow port mangling may conflict with "
658 "another vswitch, choose an engine id less than 128",
661 if (hmap_count(&br->ports) > 508) {
662 VLOG_WARN("bridge %s: NetFlow port mangling will conflict with "
663 "another port when more than 508 ports are used",
669 sset_init(&opts.collectors);
670 sset_add_array(&opts.collectors, cfg->targets, cfg->n_targets);
673 if (ofproto_set_netflow(br->ofproto, &opts)) {
674 VLOG_ERR("bridge %s: problem setting netflow collectors", br->name);
676 sset_destroy(&opts.collectors);
679 /* Set sFlow configuration on 'br'. */
681 bridge_configure_sflow(struct bridge *br, int *sflow_bridge_number)
683 const struct ovsrec_sflow *cfg = br->cfg->sflow;
684 struct ovsrec_controller **controllers;
685 struct ofproto_sflow_options oso;
686 size_t n_controllers;
690 ofproto_set_sflow(br->ofproto, NULL);
694 memset(&oso, 0, sizeof oso);
696 sset_init(&oso.targets);
697 sset_add_array(&oso.targets, cfg->targets, cfg->n_targets);
699 oso.sampling_rate = SFL_DEFAULT_SAMPLING_RATE;
701 oso.sampling_rate = *cfg->sampling;
704 oso.polling_interval = SFL_DEFAULT_POLLING_INTERVAL;
706 oso.polling_interval = *cfg->polling;
709 oso.header_len = SFL_DEFAULT_HEADER_SIZE;
711 oso.header_len = *cfg->header;
714 oso.sub_id = (*sflow_bridge_number)++;
715 oso.agent_device = cfg->agent;
717 oso.control_ip = NULL;
718 n_controllers = bridge_get_controllers(br, &controllers);
719 for (i = 0; i < n_controllers; i++) {
720 if (controllers[i]->local_ip) {
721 oso.control_ip = controllers[i]->local_ip;
725 ofproto_set_sflow(br->ofproto, &oso);
727 sset_destroy(&oso.targets);
731 port_configure_stp(const struct ofproto *ofproto, struct port *port,
732 struct ofproto_port_stp_settings *port_s,
733 int *port_num_counter, unsigned long *port_num_bitmap)
735 const char *config_str;
738 config_str = get_port_other_config(port->cfg, "stp-enable", NULL);
739 if (config_str && !strcmp(config_str, "false")) {
740 port_s->enable = false;
743 port_s->enable = true;
746 /* STP over bonds is not supported. */
747 if (!list_is_singleton(&port->ifaces)) {
748 VLOG_ERR("port %s: cannot enable STP on bonds, disabling",
750 port_s->enable = false;
754 iface = CONTAINER_OF(list_front(&port->ifaces), struct iface, port_elem);
756 /* Internal ports shouldn't participate in spanning tree, so
758 if (!strcmp(iface->type, "internal")) {
759 VLOG_DBG("port %s: disable STP on internal ports", port->name);
760 port_s->enable = false;
764 /* STP on mirror output ports is not supported. */
765 if (ofproto_is_mirror_output_bundle(ofproto, port)) {
766 VLOG_DBG("port %s: disable STP on mirror ports", port->name);
767 port_s->enable = false;
771 config_str = get_port_other_config(port->cfg, "stp-port-num", NULL);
773 unsigned long int port_num = strtoul(config_str, NULL, 0);
774 int port_idx = port_num - 1;
776 if (port_num < 1 || port_num > STP_MAX_PORTS) {
777 VLOG_ERR("port %s: invalid stp-port-num", port->name);
778 port_s->enable = false;
782 if (bitmap_is_set(port_num_bitmap, port_idx)) {
783 VLOG_ERR("port %s: duplicate stp-port-num %lu, disabling",
784 port->name, port_num);
785 port_s->enable = false;
788 bitmap_set1(port_num_bitmap, port_idx);
789 port_s->port_num = port_idx;
791 if (*port_num_counter > STP_MAX_PORTS) {
792 VLOG_ERR("port %s: too many STP ports, disabling", port->name);
793 port_s->enable = false;
797 port_s->port_num = (*port_num_counter)++;
800 config_str = get_port_other_config(port->cfg, "stp-path-cost", NULL);
802 port_s->path_cost = strtoul(config_str, NULL, 10);
806 if (netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL)) {
807 /* Couldn't get speed, so assume 100Mb/s. */
808 port_s->path_cost = 19;
812 mbps = netdev_features_to_bps(current) / 1000000;
813 port_s->path_cost = stp_convert_speed_to_cost(mbps);
817 config_str = get_port_other_config(port->cfg, "stp-port-priority", NULL);
819 port_s->priority = strtoul(config_str, NULL, 0);
821 port_s->priority = STP_DEFAULT_PORT_PRIORITY;
825 /* Set spanning tree configuration on 'br'. */
827 bridge_configure_stp(struct bridge *br)
829 if (!br->cfg->stp_enable) {
830 ofproto_set_stp(br->ofproto, NULL);
832 struct ofproto_stp_settings br_s;
833 const char *config_str;
835 int port_num_counter;
836 unsigned long *port_num_bitmap;
838 config_str = bridge_get_other_config(br->cfg, "stp-system-id");
840 uint8_t ea[ETH_ADDR_LEN];
842 if (eth_addr_from_string(config_str, ea)) {
843 br_s.system_id = eth_addr_to_uint64(ea);
845 br_s.system_id = eth_addr_to_uint64(br->ea);
846 VLOG_ERR("bridge %s: invalid stp-system-id, defaulting "
847 "to "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(br->ea));
850 br_s.system_id = eth_addr_to_uint64(br->ea);
853 config_str = bridge_get_other_config(br->cfg, "stp-priority");
855 br_s.priority = strtoul(config_str, NULL, 0);
857 br_s.priority = STP_DEFAULT_BRIDGE_PRIORITY;
860 config_str = bridge_get_other_config(br->cfg, "stp-hello-time");
862 br_s.hello_time = strtoul(config_str, NULL, 10) * 1000;
864 br_s.hello_time = STP_DEFAULT_HELLO_TIME;
867 config_str = bridge_get_other_config(br->cfg, "stp-max-age");
869 br_s.max_age = strtoul(config_str, NULL, 10) * 1000;
871 br_s.max_age = STP_DEFAULT_MAX_AGE;
874 config_str = bridge_get_other_config(br->cfg, "stp-forward-delay");
876 br_s.fwd_delay = strtoul(config_str, NULL, 10) * 1000;
878 br_s.fwd_delay = STP_DEFAULT_FWD_DELAY;
881 /* Configure STP on the bridge. */
882 if (ofproto_set_stp(br->ofproto, &br_s)) {
883 VLOG_ERR("bridge %s: could not enable STP", br->name);
887 /* Users must either set the port number with the "stp-port-num"
888 * configuration on all ports or none. If manual configuration
889 * is not done, then we allocate them sequentially. */
890 port_num_counter = 0;
891 port_num_bitmap = bitmap_allocate(STP_MAX_PORTS);
892 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
893 struct ofproto_port_stp_settings port_s;
896 port_configure_stp(br->ofproto, port, &port_s,
897 &port_num_counter, port_num_bitmap);
899 /* As bonds are not supported, just apply configuration to
901 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
902 if (ofproto_port_set_stp(br->ofproto, iface->ofp_port,
904 VLOG_ERR("port %s: could not enable STP", port->name);
910 if (bitmap_scan(port_num_bitmap, 0, STP_MAX_PORTS) != STP_MAX_PORTS
911 && port_num_counter) {
912 VLOG_ERR("bridge %s: must manually configure all STP port "
913 "IDs or none, disabling", br->name);
914 ofproto_set_stp(br->ofproto, NULL);
916 bitmap_free(port_num_bitmap);
921 bridge_has_bond_fake_iface(const struct bridge *br, const char *name)
923 const struct port *port = port_lookup(br, name);
924 return port && port_is_bond_fake_iface(port);
928 port_is_bond_fake_iface(const struct port *port)
930 return port->cfg->bond_fake_iface && !list_is_short(&port->ifaces);
934 add_del_bridges(const struct ovsrec_open_vswitch *cfg)
936 struct bridge *br, *next;
940 /* Collect new bridges' names and types. */
942 for (i = 0; i < cfg->n_bridges; i++) {
943 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
944 const struct ovsrec_bridge *br_cfg = cfg->bridges[i];
946 if (strchr(br_cfg->name, '/')) {
947 /* Prevent remote ovsdb-server users from accessing arbitrary
948 * directories, e.g. consider a bridge named "../../../etc/". */
949 VLOG_WARN_RL(&rl, "ignoring bridge with invalid name \"%s\"",
951 } else if (!shash_add_once(&new_br, br_cfg->name, br_cfg)) {
952 VLOG_WARN_RL(&rl, "bridge %s specified twice", br_cfg->name);
956 /* Get rid of deleted bridges or those whose types have changed.
957 * Update 'cfg' of bridges that still exist. */
958 HMAP_FOR_EACH_SAFE (br, next, node, &all_bridges) {
959 br->cfg = shash_find_data(&new_br, br->name);
960 if (!br->cfg || strcmp(br->type, ofproto_normalize_type(
961 br->cfg->datapath_type))) {
966 /* Add new bridges. */
967 for (i = 0; i < cfg->n_bridges; i++) {
968 const struct ovsrec_bridge *br_cfg = cfg->bridges[i];
969 struct bridge *br = bridge_lookup(br_cfg->name);
971 bridge_create(br_cfg);
975 shash_destroy(&new_br);
978 /* Delete each ofproto port on 'br' that doesn't have a corresponding "struct
981 * The kernel will reject any attempt to add a given port to a datapath if that
982 * port already belongs to a different datapath, so we must do all port
983 * deletions before any port additions. */
985 bridge_del_ofproto_ports(struct bridge *br)
987 struct ofproto_port_dump dump;
988 struct ofproto_port ofproto_port;
990 OFPROTO_PORT_FOR_EACH (&ofproto_port, &dump, br->ofproto) {
991 const char *name = ofproto_port.name;
996 /* Ignore the local port. We can't change it anyhow. */
997 if (!strcmp(name, br->name)) {
1001 /* Get the type that 'ofproto_port' should have (ordinarily the
1002 * type of its corresponding iface) or NULL if it should be
1004 iface = iface_lookup(br, name);
1005 type = (iface ? iface->type
1006 : bridge_has_bond_fake_iface(br, name) ? "internal"
1009 /* If it's the wrong type then delete the ofproto port. */
1011 && !strcmp(ofproto_port.type, type)
1012 && (!iface || !iface->netdev
1013 || !strcmp(netdev_get_type(iface->netdev), type))) {
1016 error = ofproto_port_del(br->ofproto, ofproto_port.ofp_port);
1018 VLOG_WARN("bridge %s: failed to remove %s interface (%s)",
1019 br->name, name, strerror(error));
1022 netdev_close(iface->netdev);
1023 iface->netdev = NULL;
1029 iface_set_ofp_port(struct iface *iface, int ofp_port)
1031 struct bridge *br = iface->port->bridge;
1033 assert(iface->ofp_port < 0 && ofp_port >= 0);
1034 iface->ofp_port = ofp_port;
1035 hmap_insert(&br->ifaces, &iface->ofp_port_node, hash_int(ofp_port, 0));
1036 iface_set_ofport(iface->cfg, ofp_port);
1040 bridge_refresh_ofp_port(struct bridge *br)
1042 struct ofproto_port_dump dump;
1043 struct ofproto_port ofproto_port;
1046 /* Clear all the "ofp_port"es. */
1047 hmap_clear(&br->ifaces);
1048 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
1049 struct iface *iface;
1051 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
1052 iface->ofp_port = -1;
1056 /* Obtain the correct "ofp_port"s from ofproto. */
1057 OFPROTO_PORT_FOR_EACH (&ofproto_port, &dump, br->ofproto) {
1058 struct iface *iface = iface_lookup(br, ofproto_port.name);
1060 if (iface->ofp_port >= 0) {
1061 VLOG_WARN("bridge %s: interface %s reported twice",
1062 br->name, ofproto_port.name);
1063 } else if (iface_from_ofp_port(br, ofproto_port.ofp_port)) {
1064 VLOG_WARN("bridge %s: interface %"PRIu16" reported twice",
1065 br->name, ofproto_port.ofp_port);
1067 iface_set_ofp_port(iface, ofproto_port.ofp_port);
1073 /* Add an ofproto port for any "struct iface" that doesn't have one.
1074 * Delete any "struct iface" for which this fails.
1075 * Delete any "struct port" that thereby ends up with no ifaces. */
1077 bridge_add_ofproto_ports(struct bridge *br)
1079 struct port *port, *next_port;
1081 HMAP_FOR_EACH_SAFE (port, next_port, hmap_node, &br->ports) {
1082 struct iface *iface, *next_iface;
1083 struct ofproto_port ofproto_port;
1085 LIST_FOR_EACH_SAFE (iface, next_iface, port_elem, &port->ifaces) {
1088 /* Open the netdev. */
1089 if (!iface->netdev) {
1090 error = netdev_open(iface->name, iface->type, &iface->netdev);
1092 VLOG_WARN("could not open network device %s (%s)",
1093 iface->name, strerror(error));
1099 /* Configure the netdev. */
1100 if (iface->netdev) {
1104 shash_from_ovs_idl_map(iface->cfg->key_options,
1105 iface->cfg->value_options,
1106 iface->cfg->n_options, &args);
1107 error = netdev_set_config(iface->netdev, &args);
1108 shash_destroy(&args);
1111 VLOG_WARN("could not configure network device %s (%s)",
1112 iface->name, strerror(error));
1113 netdev_close(iface->netdev);
1114 iface->netdev = NULL;
1118 /* Add the port, if necessary. */
1119 if (iface->netdev && iface->ofp_port < 0) {
1123 error = ofproto_port_add(br->ofproto, iface->netdev,
1126 iface_set_ofp_port(iface, ofp_port);
1128 netdev_close(iface->netdev);
1129 iface->netdev = NULL;
1133 /* Populate stats columns in new Interface rows. */
1134 if (iface->netdev && !iface->cfg->mtu) {
1135 iface_refresh_stats(iface);
1136 iface_refresh_status(iface);
1139 /* Delete the iface if we failed. */
1140 if (iface->netdev && iface->ofp_port >= 0) {
1141 VLOG_DBG("bridge %s: interface %s is on port %d",
1142 br->name, iface->name, iface->ofp_port);
1144 if (iface->netdev) {
1145 VLOG_ERR("bridge %s: missing %s interface, dropping",
1146 br->name, iface->name);
1148 /* We already reported a related error, don't bother
1149 * duplicating it. */
1151 iface_clear_db_record(iface->cfg);
1152 iface_destroy(iface);
1155 if (list_is_empty(&port->ifaces)) {
1156 VLOG_WARN("%s port has no interfaces, dropping", port->name);
1161 /* Add bond fake iface if necessary. */
1162 if (port_is_bond_fake_iface(port)) {
1163 if (ofproto_port_query_by_name(br->ofproto, port->name,
1165 struct netdev *netdev;
1168 error = netdev_open(port->name, "internal", &netdev);
1170 ofproto_port_add(br->ofproto, netdev, NULL);
1171 netdev_close(netdev);
1173 VLOG_WARN("could not open network device %s (%s)",
1174 port->name, strerror(error));
1177 /* Already exists, nothing to do. */
1178 ofproto_port_destroy(&ofproto_port);
1185 get_ovsrec_key_value(const struct ovsdb_idl_row *row,
1186 const struct ovsdb_idl_column *column,
1189 const struct ovsdb_datum *datum;
1190 union ovsdb_atom atom;
1193 datum = ovsdb_idl_get(row, column, OVSDB_TYPE_STRING, OVSDB_TYPE_STRING);
1194 atom.string = (char *) key;
1195 idx = ovsdb_datum_find_key(datum, &atom, OVSDB_TYPE_STRING);
1196 return idx == UINT_MAX ? NULL : datum->values[idx].string;
1200 bridge_get_other_config(const struct ovsrec_bridge *br_cfg, const char *key)
1202 return get_ovsrec_key_value(&br_cfg->header_,
1203 &ovsrec_bridge_col_other_config, key);
1206 /* Set Flow eviction threshold */
1208 bridge_configure_flow_eviction_threshold(struct bridge *br)
1210 const char *threshold_str;
1213 threshold_str = bridge_get_other_config(br->cfg, "flow-eviction-threshold");
1214 if (threshold_str) {
1215 threshold = strtoul(threshold_str, NULL, 10);
1217 threshold = OFPROTO_FLOW_EVICTON_THRESHOLD_DEFAULT;
1219 ofproto_set_flow_eviction_threshold(br->ofproto, threshold);
1222 /* Set forward BPDU option. */
1224 bridge_configure_forward_bpdu(struct bridge *br)
1226 const char *forward_bpdu_str;
1227 bool forward_bpdu = false;
1229 forward_bpdu_str = bridge_get_other_config(br->cfg, "forward-bpdu");
1230 if (forward_bpdu_str && !strcmp(forward_bpdu_str, "true")) {
1231 forward_bpdu = true;
1233 ofproto_set_forward_bpdu(br->ofproto, forward_bpdu);
1237 bridge_pick_local_hw_addr(struct bridge *br, uint8_t ea[ETH_ADDR_LEN],
1238 struct iface **hw_addr_iface)
1242 bool found_addr = false;
1245 *hw_addr_iface = NULL;
1247 /* Did the user request a particular MAC? */
1248 hwaddr = bridge_get_other_config(br->cfg, "hwaddr");
1249 if (hwaddr && eth_addr_from_string(hwaddr, ea)) {
1250 if (eth_addr_is_multicast(ea)) {
1251 VLOG_ERR("bridge %s: cannot set MAC address to multicast "
1252 "address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
1253 } else if (eth_addr_is_zero(ea)) {
1254 VLOG_ERR("bridge %s: cannot set MAC address to zero", br->name);
1260 /* Otherwise choose the minimum non-local MAC address among all of the
1262 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
1263 uint8_t iface_ea[ETH_ADDR_LEN];
1264 struct iface *candidate;
1265 struct iface *iface;
1267 /* Mirror output ports don't participate. */
1268 if (ofproto_is_mirror_output_bundle(br->ofproto, port)) {
1272 /* Choose the MAC address to represent the port. */
1274 if (port->cfg->mac && eth_addr_from_string(port->cfg->mac, iface_ea)) {
1275 /* Find the interface with this Ethernet address (if any) so that
1276 * we can provide the correct devname to the caller. */
1277 LIST_FOR_EACH (candidate, port_elem, &port->ifaces) {
1278 uint8_t candidate_ea[ETH_ADDR_LEN];
1279 if (!netdev_get_etheraddr(candidate->netdev, candidate_ea)
1280 && eth_addr_equals(iface_ea, candidate_ea)) {
1285 /* Choose the interface whose MAC address will represent the port.
1286 * The Linux kernel bonding code always chooses the MAC address of
1287 * the first slave added to a bond, and the Fedora networking
1288 * scripts always add slaves to a bond in alphabetical order, so
1289 * for compatibility we choose the interface with the name that is
1290 * first in alphabetical order. */
1291 LIST_FOR_EACH (candidate, port_elem, &port->ifaces) {
1292 if (!iface || strcmp(candidate->name, iface->name) < 0) {
1297 /* The local port doesn't count (since we're trying to choose its
1298 * MAC address anyway). */
1299 if (iface->ofp_port == OFPP_LOCAL) {
1304 error = netdev_get_etheraddr(iface->netdev, iface_ea);
1310 /* Compare against our current choice. */
1311 if (!eth_addr_is_multicast(iface_ea) &&
1312 !eth_addr_is_local(iface_ea) &&
1313 !eth_addr_is_reserved(iface_ea) &&
1314 !eth_addr_is_zero(iface_ea) &&
1315 (!found_addr || eth_addr_compare_3way(iface_ea, ea) < 0))
1317 memcpy(ea, iface_ea, ETH_ADDR_LEN);
1318 *hw_addr_iface = iface;
1323 VLOG_DBG("bridge %s: using bridge Ethernet address "ETH_ADDR_FMT,
1324 br->name, ETH_ADDR_ARGS(ea));
1326 memcpy(ea, br->default_ea, ETH_ADDR_LEN);
1327 *hw_addr_iface = NULL;
1328 VLOG_WARN("bridge %s: using default bridge Ethernet "
1329 "address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
1333 /* Choose and returns the datapath ID for bridge 'br' given that the bridge
1334 * Ethernet address is 'bridge_ea'. If 'bridge_ea' is the Ethernet address of
1335 * an interface on 'br', then that interface must be passed in as
1336 * 'hw_addr_iface'; if 'bridge_ea' was derived some other way, then
1337 * 'hw_addr_iface' must be passed in as a null pointer. */
1339 bridge_pick_datapath_id(struct bridge *br,
1340 const uint8_t bridge_ea[ETH_ADDR_LEN],
1341 struct iface *hw_addr_iface)
1344 * The procedure for choosing a bridge MAC address will, in the most
1345 * ordinary case, also choose a unique MAC that we can use as a datapath
1346 * ID. In some special cases, though, multiple bridges will end up with
1347 * the same MAC address. This is OK for the bridges, but it will confuse
1348 * the OpenFlow controller, because each datapath needs a unique datapath
1351 * Datapath IDs must be unique. It is also very desirable that they be
1352 * stable from one run to the next, so that policy set on a datapath
1355 const char *datapath_id;
1358 datapath_id = bridge_get_other_config(br->cfg, "datapath-id");
1359 if (datapath_id && dpid_from_string(datapath_id, &dpid)) {
1363 if (hw_addr_iface) {
1365 if (!netdev_get_vlan_vid(hw_addr_iface->netdev, &vlan)) {
1367 * A bridge whose MAC address is taken from a VLAN network device
1368 * (that is, a network device created with vconfig(8) or similar
1369 * tool) will have the same MAC address as a bridge on the VLAN
1370 * device's physical network device.
1372 * Handle this case by hashing the physical network device MAC
1373 * along with the VLAN identifier.
1375 uint8_t buf[ETH_ADDR_LEN + 2];
1376 memcpy(buf, bridge_ea, ETH_ADDR_LEN);
1377 buf[ETH_ADDR_LEN] = vlan >> 8;
1378 buf[ETH_ADDR_LEN + 1] = vlan;
1379 return dpid_from_hash(buf, sizeof buf);
1382 * Assume that this bridge's MAC address is unique, since it
1383 * doesn't fit any of the cases we handle specially.
1388 * A purely internal bridge, that is, one that has no non-virtual
1389 * network devices on it at all, is more difficult because it has no
1390 * natural unique identifier at all.
1392 * When the host is a XenServer, we handle this case by hashing the
1393 * host's UUID with the name of the bridge. Names of bridges are
1394 * persistent across XenServer reboots, although they can be reused if
1395 * an internal network is destroyed and then a new one is later
1396 * created, so this is fairly effective.
1398 * When the host is not a XenServer, we punt by using a random MAC
1399 * address on each run.
1401 const char *host_uuid = xenserver_get_host_uuid();
1403 char *combined = xasprintf("%s,%s", host_uuid, br->name);
1404 dpid = dpid_from_hash(combined, strlen(combined));
1410 return eth_addr_to_uint64(bridge_ea);
1414 dpid_from_hash(const void *data, size_t n)
1416 uint8_t hash[SHA1_DIGEST_SIZE];
1418 BUILD_ASSERT_DECL(sizeof hash >= ETH_ADDR_LEN);
1419 sha1_bytes(data, n, hash);
1420 eth_addr_mark_random(hash);
1421 return eth_addr_to_uint64(hash);
1425 iface_refresh_status(struct iface *iface)
1429 enum netdev_flags flags;
1436 if (iface_is_synthetic(iface)) {
1442 if (!netdev_get_status(iface->netdev, &sh)) {
1444 char **keys, **values;
1446 shash_to_ovs_idl_map(&sh, &keys, &values, &n);
1447 ovsrec_interface_set_status(iface->cfg, keys, values, n);
1452 ovsrec_interface_set_status(iface->cfg, NULL, NULL, 0);
1455 shash_destroy_free_data(&sh);
1457 error = netdev_get_flags(iface->netdev, &flags);
1459 ovsrec_interface_set_admin_state(iface->cfg, flags & NETDEV_UP ? "up" : "down");
1462 ovsrec_interface_set_admin_state(iface->cfg, NULL);
1465 error = netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL);
1467 ovsrec_interface_set_duplex(iface->cfg,
1468 netdev_features_is_full_duplex(current)
1470 /* warning: uint64_t -> int64_t conversion */
1471 bps = netdev_features_to_bps(current);
1472 ovsrec_interface_set_link_speed(iface->cfg, &bps, 1);
1475 ovsrec_interface_set_duplex(iface->cfg, NULL);
1476 ovsrec_interface_set_link_speed(iface->cfg, NULL, 0);
1479 error = netdev_get_mtu(iface->netdev, &mtu);
1482 ovsrec_interface_set_mtu(iface->cfg, &mtu_64, 1);
1485 ovsrec_interface_set_mtu(iface->cfg, NULL, 0);
1489 /* Writes 'iface''s CFM statistics to the database. */
1491 iface_refresh_cfm_stats(struct iface *iface)
1493 const struct ovsrec_interface *cfg = iface->cfg;
1495 const uint64_t *rmps;
1498 if (iface_is_synthetic(iface)) {
1502 fault = ofproto_port_get_cfm_fault(iface->port->bridge->ofproto,
1505 bool fault_bool = fault;
1506 ovsrec_interface_set_cfm_fault(cfg, &fault_bool, 1);
1508 ovsrec_interface_set_cfm_fault(cfg, NULL, 0);
1511 error = ofproto_port_get_cfm_remote_mpids(iface->port->bridge->ofproto,
1512 iface->ofp_port, &rmps, &n_rmps);
1514 ovsrec_interface_set_cfm_remote_mpids(cfg, (const int64_t *)rmps,
1517 ovsrec_interface_set_cfm_remote_mpids(cfg, NULL, 0);
1522 iface_refresh_stats(struct iface *iface)
1524 #define IFACE_STATS \
1525 IFACE_STAT(rx_packets, "rx_packets") \
1526 IFACE_STAT(tx_packets, "tx_packets") \
1527 IFACE_STAT(rx_bytes, "rx_bytes") \
1528 IFACE_STAT(tx_bytes, "tx_bytes") \
1529 IFACE_STAT(rx_dropped, "rx_dropped") \
1530 IFACE_STAT(tx_dropped, "tx_dropped") \
1531 IFACE_STAT(rx_errors, "rx_errors") \
1532 IFACE_STAT(tx_errors, "tx_errors") \
1533 IFACE_STAT(rx_frame_errors, "rx_frame_err") \
1534 IFACE_STAT(rx_over_errors, "rx_over_err") \
1535 IFACE_STAT(rx_crc_errors, "rx_crc_err") \
1536 IFACE_STAT(collisions, "collisions")
1538 #define IFACE_STAT(MEMBER, NAME) NAME,
1539 static char *keys[] = { IFACE_STATS };
1541 int64_t values[ARRAY_SIZE(keys)];
1544 struct netdev_stats stats;
1546 if (iface_is_synthetic(iface)) {
1550 /* Intentionally ignore return value, since errors will set 'stats' to
1551 * all-1s, and we will deal with that correctly below. */
1552 netdev_get_stats(iface->netdev, &stats);
1554 /* Copy statistics into values[] array. */
1556 #define IFACE_STAT(MEMBER, NAME) values[i++] = stats.MEMBER;
1559 assert(i == ARRAY_SIZE(keys));
1561 ovsrec_interface_set_statistics(iface->cfg, keys, values, ARRAY_SIZE(keys));
1566 br_refresh_stp_status(struct bridge *br)
1568 struct ofproto *ofproto = br->ofproto;
1569 struct ofproto_stp_status status;
1570 char *keys[3], *values[3];
1573 if (ofproto_get_stp_status(ofproto, &status)) {
1577 if (!status.enabled) {
1578 ovsrec_bridge_set_status(br->cfg, NULL, NULL, 0);
1582 keys[0] = "stp_bridge_id",
1583 values[0] = xasprintf(STP_ID_FMT, STP_ID_ARGS(status.bridge_id));
1584 keys[1] = "stp_designated_root",
1585 values[1] = xasprintf(STP_ID_FMT, STP_ID_ARGS(status.designated_root));
1586 keys[2] = "stp_root_path_cost",
1587 values[2] = xasprintf("%d", status.root_path_cost);
1589 ovsrec_bridge_set_status(br->cfg, keys, values, ARRAY_SIZE(values));
1591 for (i = 0; i < ARRAY_SIZE(values); i++) {
1597 port_refresh_stp_status(struct port *port)
1599 struct ofproto *ofproto = port->bridge->ofproto;
1600 struct iface *iface;
1601 struct ofproto_port_stp_status status;
1603 char *str_values[4];
1604 int64_t int_values[3];
1607 if (port_is_synthetic(port)) {
1611 /* STP doesn't currently support bonds. */
1612 if (!list_is_singleton(&port->ifaces)) {
1613 ovsrec_port_set_status(port->cfg, NULL, NULL, 0);
1617 iface = CONTAINER_OF(list_front(&port->ifaces), struct iface, port_elem);
1619 if (ofproto_port_get_stp_status(ofproto, iface->ofp_port, &status)) {
1623 if (!status.enabled) {
1624 ovsrec_port_set_status(port->cfg, NULL, NULL, 0);
1625 ovsrec_port_set_statistics(port->cfg, NULL, NULL, 0);
1629 /* Set Status column. */
1630 keys[0] = "stp_port_id";
1631 str_values[0] = xasprintf(STP_PORT_ID_FMT, status.port_id);
1632 keys[1] = "stp_state";
1633 str_values[1] = xstrdup(stp_state_name(status.state));
1634 keys[2] = "stp_sec_in_state";
1635 str_values[2] = xasprintf("%u", status.sec_in_state);
1636 keys[3] = "stp_role";
1637 str_values[3] = xstrdup(stp_role_name(status.role));
1639 ovsrec_port_set_status(port->cfg, keys, str_values,
1640 ARRAY_SIZE(str_values));
1642 for (i = 0; i < ARRAY_SIZE(str_values); i++) {
1643 free(str_values[i]);
1646 /* Set Statistics column. */
1647 keys[0] = "stp_tx_count";
1648 int_values[0] = status.tx_count;
1649 keys[1] = "stp_rx_count";
1650 int_values[1] = status.rx_count;
1651 keys[2] = "stp_error_count";
1652 int_values[2] = status.error_count;
1654 ovsrec_port_set_statistics(port->cfg, keys, int_values,
1655 ARRAY_SIZE(int_values));
1659 enable_system_stats(const struct ovsrec_open_vswitch *cfg)
1663 /* Use other-config:enable-system-stats by preference. */
1664 enable = get_ovsrec_key_value(&cfg->header_,
1665 &ovsrec_open_vswitch_col_other_config,
1666 "enable-statistics");
1668 return !strcmp(enable, "true");
1671 /* Disable by default. */
1676 refresh_system_stats(const struct ovsrec_open_vswitch *cfg)
1678 struct ovsdb_datum datum;
1682 if (enable_system_stats(cfg)) {
1683 get_system_stats(&stats);
1686 ovsdb_datum_from_shash(&datum, &stats);
1687 ovsdb_idl_txn_write(&cfg->header_, &ovsrec_open_vswitch_col_statistics,
1691 static inline const char *
1692 nx_role_to_str(enum nx_role role)
1697 case NX_ROLE_MASTER:
1702 return "*** INVALID ROLE ***";
1707 refresh_controller_status(void)
1711 const struct ovsrec_controller *cfg;
1715 /* Accumulate status for controllers on all bridges. */
1716 HMAP_FOR_EACH (br, node, &all_bridges) {
1717 ofproto_get_ofproto_controller_info(br->ofproto, &info);
1720 /* Update each controller in the database with current status. */
1721 OVSREC_CONTROLLER_FOR_EACH(cfg, idl) {
1722 struct ofproto_controller_info *cinfo =
1723 shash_find_data(&info, cfg->target);
1726 ovsrec_controller_set_is_connected(cfg, cinfo->is_connected);
1727 ovsrec_controller_set_role(cfg, nx_role_to_str(cinfo->role));
1728 ovsrec_controller_set_status(cfg, (char **) cinfo->pairs.keys,
1729 (char **) cinfo->pairs.values,
1732 ovsrec_controller_set_is_connected(cfg, false);
1733 ovsrec_controller_set_role(cfg, NULL);
1734 ovsrec_controller_set_status(cfg, NULL, NULL, 0);
1738 ofproto_free_ofproto_controller_info(&info);
1742 refresh_cfm_stats(void)
1744 static struct ovsdb_idl_txn *txn = NULL;
1749 txn = ovsdb_idl_txn_create(idl);
1751 HMAP_FOR_EACH (br, node, &all_bridges) {
1752 struct iface *iface;
1754 HMAP_FOR_EACH (iface, name_node, &br->iface_by_name) {
1755 iface_refresh_cfm_stats(iface);
1760 if (ovsdb_idl_txn_commit(txn) != TXN_INCOMPLETE) {
1761 ovsdb_idl_txn_destroy(txn);
1769 const struct ovsrec_open_vswitch *cfg;
1771 bool datapath_destroyed;
1772 bool database_changed;
1775 /* (Re)configure if necessary. */
1776 database_changed = ovsdb_idl_run(idl);
1777 if (ovsdb_idl_is_lock_contended(idl)) {
1778 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
1779 struct bridge *br, *next_br;
1781 VLOG_ERR_RL(&rl, "another ovs-vswitchd process is running, "
1782 "disabling this process until it goes away");
1784 HMAP_FOR_EACH_SAFE (br, next_br, node, &all_bridges) {
1788 } else if (!ovsdb_idl_has_lock(idl)) {
1791 cfg = ovsrec_open_vswitch_first(idl);
1793 /* Let each bridge do the work that it needs to do. */
1794 datapath_destroyed = false;
1795 HMAP_FOR_EACH (br, node, &all_bridges) {
1796 int error = ofproto_run(br->ofproto);
1798 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
1799 VLOG_ERR_RL(&rl, "bridge %s: datapath was destroyed externally, "
1800 "forcing reconfiguration", br->name);
1801 datapath_destroyed = true;
1805 /* Re-configure SSL. We do this on every trip through the main loop,
1806 * instead of just when the database changes, because the contents of the
1807 * key and certificate files can change without the database changing.
1809 * We do this before bridge_reconfigure() because that function might
1810 * initiate SSL connections and thus requires SSL to be configured. */
1811 if (cfg && cfg->ssl) {
1812 const struct ovsrec_ssl *ssl = cfg->ssl;
1814 stream_ssl_set_key_and_cert(ssl->private_key, ssl->certificate);
1815 stream_ssl_set_ca_cert_file(ssl->ca_cert, ssl->bootstrap_ca_cert);
1818 if (database_changed || datapath_destroyed) {
1820 struct ovsdb_idl_txn *txn = ovsdb_idl_txn_create(idl);
1822 bridge_reconfigure(cfg);
1824 ovsrec_open_vswitch_set_cur_cfg(cfg, cfg->next_cfg);
1825 ovsdb_idl_txn_commit(txn);
1826 ovsdb_idl_txn_destroy(txn); /* XXX */
1828 /* We still need to reconfigure to avoid dangling pointers to
1829 * now-destroyed ovsrec structures inside bridge data. */
1830 static const struct ovsrec_open_vswitch null_cfg;
1832 bridge_reconfigure(&null_cfg);
1836 /* Refresh system and interface stats if necessary. */
1837 if (time_msec() >= stats_timer) {
1839 struct ovsdb_idl_txn *txn;
1841 txn = ovsdb_idl_txn_create(idl);
1842 HMAP_FOR_EACH (br, node, &all_bridges) {
1845 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
1846 struct iface *iface;
1848 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
1849 iface_refresh_stats(iface);
1850 iface_refresh_status(iface);
1854 refresh_system_stats(cfg);
1855 refresh_controller_status();
1856 ovsdb_idl_txn_commit(txn);
1857 ovsdb_idl_txn_destroy(txn); /* XXX */
1860 stats_timer = time_msec() + STATS_INTERVAL;
1863 if (time_msec() >= db_limiter) {
1864 struct ovsdb_idl_txn *txn;
1866 txn = ovsdb_idl_txn_create(idl);
1867 HMAP_FOR_EACH (br, node, &all_bridges) {
1868 struct iface *iface;
1871 br_refresh_stp_status(br);
1873 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
1874 port_refresh_stp_status(port);
1877 HMAP_FOR_EACH (iface, name_node, &br->iface_by_name) {
1878 const char *link_state;
1879 int64_t link_resets;
1882 if (iface_is_synthetic(iface)) {
1886 current = ofproto_port_is_lacp_current(br->ofproto,
1890 ovsrec_interface_set_lacp_current(iface->cfg, &bl, 1);
1892 ovsrec_interface_set_lacp_current(iface->cfg, NULL, 0);
1895 link_state = netdev_get_carrier(iface->netdev) ? "up" : "down";
1896 ovsrec_interface_set_link_state(iface->cfg, link_state);
1898 link_resets = netdev_get_carrier_resets(iface->netdev);
1899 ovsrec_interface_set_link_resets(iface->cfg, &link_resets, 1);
1903 if (ovsdb_idl_txn_commit(txn) != TXN_UNCHANGED) {
1904 db_limiter = time_msec() + DB_LIMIT_INTERVAL;
1906 ovsdb_idl_txn_destroy(txn);
1909 refresh_cfm_stats();
1915 ovsdb_idl_wait(idl);
1916 if (!hmap_is_empty(&all_bridges)) {
1919 HMAP_FOR_EACH (br, node, &all_bridges) {
1920 ofproto_wait(br->ofproto);
1922 poll_timer_wait_until(stats_timer);
1924 if (db_limiter > time_msec()) {
1925 poll_timer_wait_until(db_limiter);
1930 /* QoS unixctl user interface functions. */
1932 struct qos_unixctl_show_cbdata {
1934 struct iface *iface;
1938 qos_unixctl_show_cb(unsigned int queue_id,
1939 const struct shash *details,
1942 struct qos_unixctl_show_cbdata *data = aux;
1943 struct ds *ds = data->ds;
1944 struct iface *iface = data->iface;
1945 struct netdev_queue_stats stats;
1946 struct shash_node *node;
1949 ds_put_cstr(ds, "\n");
1951 ds_put_format(ds, "Queue %u:\n", queue_id);
1953 ds_put_cstr(ds, "Default:\n");
1956 SHASH_FOR_EACH (node, details) {
1957 ds_put_format(ds, "\t%s: %s\n", node->name, (char *)node->data);
1960 error = netdev_get_queue_stats(iface->netdev, queue_id, &stats);
1962 if (stats.tx_packets != UINT64_MAX) {
1963 ds_put_format(ds, "\ttx_packets: %"PRIu64"\n", stats.tx_packets);
1966 if (stats.tx_bytes != UINT64_MAX) {
1967 ds_put_format(ds, "\ttx_bytes: %"PRIu64"\n", stats.tx_bytes);
1970 if (stats.tx_errors != UINT64_MAX) {
1971 ds_put_format(ds, "\ttx_errors: %"PRIu64"\n", stats.tx_errors);
1974 ds_put_format(ds, "\tFailed to get statistics for queue %u: %s",
1975 queue_id, strerror(error));
1980 qos_unixctl_show(struct unixctl_conn *conn,
1981 const char *args, void *aux OVS_UNUSED)
1983 struct ds ds = DS_EMPTY_INITIALIZER;
1984 struct shash sh = SHASH_INITIALIZER(&sh);
1985 struct iface *iface;
1987 struct shash_node *node;
1988 struct qos_unixctl_show_cbdata data;
1991 iface = iface_find(args);
1993 unixctl_command_reply(conn, 501, "no such interface");
1997 netdev_get_qos(iface->netdev, &type, &sh);
1999 if (*type != '\0') {
2000 ds_put_format(&ds, "QoS: %s %s\n", iface->name, type);
2002 SHASH_FOR_EACH (node, &sh) {
2003 ds_put_format(&ds, "%s: %s\n", node->name, (char *)node->data);
2008 error = netdev_dump_queues(iface->netdev, qos_unixctl_show_cb, &data);
2011 ds_put_format(&ds, "failed to dump queues: %s", strerror(error));
2013 unixctl_command_reply(conn, 200, ds_cstr(&ds));
2015 ds_put_format(&ds, "QoS not configured on %s\n", iface->name);
2016 unixctl_command_reply(conn, 501, ds_cstr(&ds));
2019 shash_destroy_free_data(&sh);
2023 /* Bridge reconfiguration functions. */
2025 bridge_create(const struct ovsrec_bridge *br_cfg)
2029 assert(!bridge_lookup(br_cfg->name));
2030 br = xzalloc(sizeof *br);
2032 br->name = xstrdup(br_cfg->name);
2033 br->type = xstrdup(ofproto_normalize_type(br_cfg->datapath_type));
2036 /* Derive the default Ethernet address from the bridge's UUID. This should
2037 * be unique and it will be stable between ovs-vswitchd runs. */
2038 memcpy(br->default_ea, &br_cfg->header_.uuid, ETH_ADDR_LEN);
2039 eth_addr_mark_random(br->default_ea);
2041 hmap_init(&br->ports);
2042 hmap_init(&br->ifaces);
2043 hmap_init(&br->iface_by_name);
2044 hmap_init(&br->mirrors);
2046 hmap_insert(&all_bridges, &br->node, hash_string(br->name, 0));
2050 bridge_destroy(struct bridge *br)
2053 struct mirror *mirror, *next_mirror;
2054 struct port *port, *next_port;
2056 HMAP_FOR_EACH_SAFE (port, next_port, hmap_node, &br->ports) {
2059 HMAP_FOR_EACH_SAFE (mirror, next_mirror, hmap_node, &br->mirrors) {
2060 mirror_destroy(mirror);
2062 hmap_remove(&all_bridges, &br->node);
2063 ofproto_destroy(br->ofproto);
2064 hmap_destroy(&br->ifaces);
2065 hmap_destroy(&br->ports);
2066 hmap_destroy(&br->iface_by_name);
2067 hmap_destroy(&br->mirrors);
2074 static struct bridge *
2075 bridge_lookup(const char *name)
2079 HMAP_FOR_EACH_WITH_HASH (br, node, hash_string(name, 0), &all_bridges) {
2080 if (!strcmp(br->name, name)) {
2087 /* Handle requests for a listing of all flows known by the OpenFlow
2088 * stack, including those normally hidden. */
2090 bridge_unixctl_dump_flows(struct unixctl_conn *conn,
2091 const char *args, void *aux OVS_UNUSED)
2096 br = bridge_lookup(args);
2098 unixctl_command_reply(conn, 501, "Unknown bridge");
2103 ofproto_get_all_flows(br->ofproto, &results);
2105 unixctl_command_reply(conn, 200, ds_cstr(&results));
2106 ds_destroy(&results);
2109 /* "bridge/reconnect [BRIDGE]": makes BRIDGE drop all of its controller
2110 * connections and reconnect. If BRIDGE is not specified, then all bridges
2111 * drop their controller connections and reconnect. */
2113 bridge_unixctl_reconnect(struct unixctl_conn *conn,
2114 const char *args, void *aux OVS_UNUSED)
2117 if (args[0] != '\0') {
2118 br = bridge_lookup(args);
2120 unixctl_command_reply(conn, 501, "Unknown bridge");
2123 ofproto_reconnect_controllers(br->ofproto);
2125 HMAP_FOR_EACH (br, node, &all_bridges) {
2126 ofproto_reconnect_controllers(br->ofproto);
2129 unixctl_command_reply(conn, 200, NULL);
2133 bridge_get_controllers(const struct bridge *br,
2134 struct ovsrec_controller ***controllersp)
2136 struct ovsrec_controller **controllers;
2137 size_t n_controllers;
2139 controllers = br->cfg->controller;
2140 n_controllers = br->cfg->n_controller;
2142 if (n_controllers == 1 && !strcmp(controllers[0]->target, "none")) {
2148 *controllersp = controllers;
2150 return n_controllers;
2153 /* Adds and deletes "struct port"s and "struct iface"s under 'br' to match
2154 * those configured in 'br->cfg'. */
2156 bridge_add_del_ports(struct bridge *br)
2158 struct port *port, *next;
2159 struct shash_node *node;
2160 struct shash new_ports;
2163 /* Collect new ports. */
2164 shash_init(&new_ports);
2165 for (i = 0; i < br->cfg->n_ports; i++) {
2166 const char *name = br->cfg->ports[i]->name;
2167 if (!shash_add_once(&new_ports, name, br->cfg->ports[i])) {
2168 VLOG_WARN("bridge %s: %s specified twice as bridge port",
2172 if (bridge_get_controllers(br, NULL)
2173 && !shash_find(&new_ports, br->name)) {
2174 VLOG_WARN("bridge %s: no port named %s, synthesizing one",
2175 br->name, br->name);
2177 br->synth_local_port.interfaces = &br->synth_local_ifacep;
2178 br->synth_local_port.n_interfaces = 1;
2179 br->synth_local_port.name = br->name;
2181 br->synth_local_iface.name = br->name;
2182 br->synth_local_iface.type = "internal";
2184 br->synth_local_ifacep = &br->synth_local_iface;
2186 shash_add(&new_ports, br->name, &br->synth_local_port);
2189 /* Get rid of deleted ports.
2190 * Get rid of deleted interfaces on ports that still exist.
2191 * Update 'cfg' of ports that still exist. */
2192 HMAP_FOR_EACH_SAFE (port, next, hmap_node, &br->ports) {
2193 port->cfg = shash_find_data(&new_ports, port->name);
2197 port_del_ifaces(port);
2201 /* Create new ports.
2202 * Add new interfaces to existing ports. */
2203 SHASH_FOR_EACH (node, &new_ports) {
2204 struct port *port = port_lookup(br, node->name);
2206 struct ovsrec_port *cfg = node->data;
2207 port = port_create(br, cfg);
2209 port_add_ifaces(port);
2210 if (list_is_empty(&port->ifaces)) {
2211 VLOG_WARN("bridge %s: port %s has no interfaces, dropping",
2212 br->name, port->name);
2216 shash_destroy(&new_ports);
2219 /* Initializes 'oc' appropriately as a management service controller for
2222 * The caller must free oc->target when it is no longer needed. */
2224 bridge_ofproto_controller_for_mgmt(const struct bridge *br,
2225 struct ofproto_controller *oc)
2227 oc->target = xasprintf("punix:%s/%s.mgmt", ovs_rundir(), br->name);
2228 oc->max_backoff = 0;
2229 oc->probe_interval = 60;
2230 oc->band = OFPROTO_OUT_OF_BAND;
2232 oc->burst_limit = 0;
2235 /* Converts ovsrec_controller 'c' into an ofproto_controller in 'oc'. */
2237 bridge_ofproto_controller_from_ovsrec(const struct ovsrec_controller *c,
2238 struct ofproto_controller *oc)
2240 oc->target = c->target;
2241 oc->max_backoff = c->max_backoff ? *c->max_backoff / 1000 : 8;
2242 oc->probe_interval = c->inactivity_probe ? *c->inactivity_probe / 1000 : 5;
2243 oc->band = (!c->connection_mode || !strcmp(c->connection_mode, "in-band")
2244 ? OFPROTO_IN_BAND : OFPROTO_OUT_OF_BAND);
2245 oc->rate_limit = c->controller_rate_limit ? *c->controller_rate_limit : 0;
2246 oc->burst_limit = (c->controller_burst_limit
2247 ? *c->controller_burst_limit : 0);
2250 /* Configures the IP stack for 'br''s local interface properly according to the
2251 * configuration in 'c'. */
2253 bridge_configure_local_iface_netdev(struct bridge *br,
2254 struct ovsrec_controller *c)
2256 struct netdev *netdev;
2257 struct in_addr mask, gateway;
2259 struct iface *local_iface;
2262 /* If there's no local interface or no IP address, give up. */
2263 local_iface = iface_from_ofp_port(br, OFPP_LOCAL);
2264 if (!local_iface || !c->local_ip || !inet_aton(c->local_ip, &ip)) {
2268 /* Bring up the local interface. */
2269 netdev = local_iface->netdev;
2270 netdev_turn_flags_on(netdev, NETDEV_UP, true);
2272 /* Configure the IP address and netmask. */
2273 if (!c->local_netmask
2274 || !inet_aton(c->local_netmask, &mask)
2276 mask.s_addr = guess_netmask(ip.s_addr);
2278 if (!netdev_set_in4(netdev, ip, mask)) {
2279 VLOG_INFO("bridge %s: configured IP address "IP_FMT", netmask "IP_FMT,
2280 br->name, IP_ARGS(&ip.s_addr), IP_ARGS(&mask.s_addr));
2283 /* Configure the default gateway. */
2284 if (c->local_gateway
2285 && inet_aton(c->local_gateway, &gateway)
2286 && gateway.s_addr) {
2287 if (!netdev_add_router(netdev, gateway)) {
2288 VLOG_INFO("bridge %s: configured gateway "IP_FMT,
2289 br->name, IP_ARGS(&gateway.s_addr));
2294 /* Returns true if 'a' and 'b' are the same except that any number of slashes
2295 * in either string are treated as equal to any number of slashes in the other,
2296 * e.g. "x///y" is equal to "x/y". */
2298 equal_pathnames(const char *a, const char *b)
2302 a += strspn(a, "/");
2303 b += strspn(b, "/");
2304 } else if (*a == '\0') {
2315 bridge_configure_remotes(struct bridge *br,
2316 const struct sockaddr_in *managers, size_t n_managers)
2318 const char *disable_ib_str, *queue_id_str;
2319 bool disable_in_band = false;
2322 struct ovsrec_controller **controllers;
2323 size_t n_controllers;
2325 enum ofproto_fail_mode fail_mode;
2327 struct ofproto_controller *ocs;
2331 /* Check if we should disable in-band control on this bridge. */
2332 disable_ib_str = bridge_get_other_config(br->cfg, "disable-in-band");
2333 if (disable_ib_str && !strcmp(disable_ib_str, "true")) {
2334 disable_in_band = true;
2337 /* Set OpenFlow queue ID for in-band control. */
2338 queue_id_str = bridge_get_other_config(br->cfg, "in-band-queue");
2339 queue_id = queue_id_str ? strtol(queue_id_str, NULL, 10) : -1;
2340 ofproto_set_in_band_queue(br->ofproto, queue_id);
2342 if (disable_in_band) {
2343 ofproto_set_extra_in_band_remotes(br->ofproto, NULL, 0);
2345 ofproto_set_extra_in_band_remotes(br->ofproto, managers, n_managers);
2348 n_controllers = bridge_get_controllers(br, &controllers);
2350 ocs = xmalloc((n_controllers + 1) * sizeof *ocs);
2353 bridge_ofproto_controller_for_mgmt(br, &ocs[n_ocs++]);
2354 for (i = 0; i < n_controllers; i++) {
2355 struct ovsrec_controller *c = controllers[i];
2357 if (!strncmp(c->target, "punix:", 6)
2358 || !strncmp(c->target, "unix:", 5)) {
2359 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2362 whitelist = xasprintf("unix:%s/%s.controller",
2363 ovs_rundir(), br->name);
2364 if (!equal_pathnames(c->target, whitelist)) {
2365 /* Prevent remote ovsdb-server users from accessing arbitrary
2366 * Unix domain sockets and overwriting arbitrary local
2368 VLOG_ERR_RL(&rl, "bridge %s: Not adding Unix domain socket "
2369 "controller \"%s\" due to possibility for remote "
2370 "exploit. Instead, specify whitelisted \"%s\" or "
2371 "connect to \"unix:%s/%s.mgmt\" (which is always "
2372 "available without special configuration).",
2373 br->name, c->target, whitelist,
2374 ovs_rundir(), br->name);
2382 bridge_configure_local_iface_netdev(br, c);
2383 bridge_ofproto_controller_from_ovsrec(c, &ocs[n_ocs]);
2384 if (disable_in_band) {
2385 ocs[n_ocs].band = OFPROTO_OUT_OF_BAND;
2390 ofproto_set_controllers(br->ofproto, ocs, n_ocs);
2391 free(ocs[0].target); /* From bridge_ofproto_controller_for_mgmt(). */
2394 /* Set the fail-mode. */
2395 fail_mode = !br->cfg->fail_mode
2396 || !strcmp(br->cfg->fail_mode, "standalone")
2397 ? OFPROTO_FAIL_STANDALONE
2398 : OFPROTO_FAIL_SECURE;
2399 ofproto_set_fail_mode(br->ofproto, fail_mode);
2401 /* Configure OpenFlow controller connection snooping. */
2402 if (!ofproto_has_snoops(br->ofproto)) {
2406 sset_add_and_free(&snoops, xasprintf("punix:%s/%s.snoop",
2407 ovs_rundir(), br->name));
2408 ofproto_set_snoops(br->ofproto, &snoops);
2409 sset_destroy(&snoops);
2413 /* Port functions. */
2415 static struct port *
2416 port_create(struct bridge *br, const struct ovsrec_port *cfg)
2420 port = xzalloc(sizeof *port);
2422 port->name = xstrdup(cfg->name);
2424 list_init(&port->ifaces);
2426 hmap_insert(&br->ports, &port->hmap_node, hash_string(port->name, 0));
2428 VLOG_INFO("created port %s on bridge %s", port->name, br->name);
2434 get_port_other_config(const struct ovsrec_port *port, const char *key,
2435 const char *default_value)
2439 value = get_ovsrec_key_value(&port->header_, &ovsrec_port_col_other_config,
2441 return value ? value : default_value;
2445 get_interface_other_config(const struct ovsrec_interface *iface,
2446 const char *key, const char *default_value)
2450 value = get_ovsrec_key_value(&iface->header_,
2451 &ovsrec_interface_col_other_config, key);
2452 return value ? value : default_value;
2455 /* Deletes interfaces from 'port' that are no longer configured for it. */
2457 port_del_ifaces(struct port *port)
2459 struct iface *iface, *next;
2460 struct sset new_ifaces;
2463 /* Collect list of new interfaces. */
2464 sset_init(&new_ifaces);
2465 for (i = 0; i < port->cfg->n_interfaces; i++) {
2466 const char *name = port->cfg->interfaces[i]->name;
2467 const char *type = port->cfg->interfaces[i]->name;
2468 if (strcmp(type, "null")) {
2469 sset_add(&new_ifaces, name);
2473 /* Get rid of deleted interfaces. */
2474 LIST_FOR_EACH_SAFE (iface, next, port_elem, &port->ifaces) {
2475 if (!sset_contains(&new_ifaces, iface->name)) {
2476 iface_destroy(iface);
2480 sset_destroy(&new_ifaces);
2483 /* Adds new interfaces to 'port' and updates 'type' and 'cfg' members of
2486 port_add_ifaces(struct port *port)
2488 struct shash new_ifaces;
2489 struct shash_node *node;
2492 /* Collect new ifaces. */
2493 shash_init(&new_ifaces);
2494 for (i = 0; i < port->cfg->n_interfaces; i++) {
2495 const struct ovsrec_interface *cfg = port->cfg->interfaces[i];
2496 if (strcmp(cfg->type, "null")
2497 && !shash_add_once(&new_ifaces, cfg->name, cfg)) {
2498 VLOG_WARN("port %s: %s specified twice as port interface",
2499 port->name, cfg->name);
2500 iface_clear_db_record(cfg);
2504 /* Create new interfaces.
2505 * Update interface types and 'cfg' members. */
2506 SHASH_FOR_EACH (node, &new_ifaces) {
2507 const struct ovsrec_interface *cfg = node->data;
2508 const char *iface_name = node->name;
2509 struct iface *iface;
2511 iface = iface_lookup(port->bridge, iface_name);
2513 iface = iface_create(port, cfg);
2518 /* Determine interface type. The local port always has type
2519 * "internal". Other ports take their type from the database and
2520 * default to "system" if none is specified. */
2521 iface->type = (!strcmp(iface_name, port->bridge->name) ? "internal"
2522 : cfg->type[0] ? cfg->type
2525 shash_destroy(&new_ifaces);
2529 port_destroy(struct port *port)
2532 struct bridge *br = port->bridge;
2533 struct iface *iface, *next;
2536 ofproto_bundle_unregister(br->ofproto, port);
2539 LIST_FOR_EACH_SAFE (iface, next, port_elem, &port->ifaces) {
2540 iface_destroy(iface);
2543 hmap_remove(&br->ports, &port->hmap_node);
2545 VLOG_INFO("destroyed port %s on bridge %s", port->name, br->name);
2552 static struct port *
2553 port_lookup(const struct bridge *br, const char *name)
2557 HMAP_FOR_EACH_WITH_HASH (port, hmap_node, hash_string(name, 0),
2559 if (!strcmp(port->name, name)) {
2567 enable_lacp(struct port *port, bool *activep)
2569 if (!port->cfg->lacp) {
2570 /* XXX when LACP implementation has been sufficiently tested, enable by
2571 * default and make active on bonded ports. */
2573 } else if (!strcmp(port->cfg->lacp, "off")) {
2575 } else if (!strcmp(port->cfg->lacp, "active")) {
2578 } else if (!strcmp(port->cfg->lacp, "passive")) {
2582 VLOG_WARN("port %s: unknown LACP mode %s",
2583 port->name, port->cfg->lacp);
2588 static struct lacp_settings *
2589 port_configure_lacp(struct port *port, struct lacp_settings *s)
2591 const char *lacp_time;
2592 long long int custom_time;
2595 if (!enable_lacp(port, &s->active)) {
2599 s->name = port->name;
2600 memcpy(s->id, port->bridge->ea, ETH_ADDR_LEN);
2602 /* Prefer bondable links if unspecified. */
2603 priority = atoi(get_port_other_config(port->cfg, "lacp-system-priority",
2605 s->priority = (priority > 0 && priority <= UINT16_MAX
2607 : UINT16_MAX - !list_is_short(&port->ifaces));
2609 s->heartbeat = !strcmp(get_port_other_config(port->cfg,
2614 lacp_time = get_port_other_config(port->cfg, "lacp-time", "slow");
2615 custom_time = atoi(lacp_time);
2616 if (!strcmp(lacp_time, "fast")) {
2617 s->lacp_time = LACP_TIME_FAST;
2618 } else if (!strcmp(lacp_time, "slow")) {
2619 s->lacp_time = LACP_TIME_SLOW;
2620 } else if (custom_time > 0) {
2621 s->lacp_time = LACP_TIME_CUSTOM;
2622 s->custom_time = custom_time;
2624 s->lacp_time = LACP_TIME_SLOW;
2631 iface_configure_lacp(struct iface *iface, struct lacp_slave_settings *s)
2633 int priority, portid, key;
2635 portid = atoi(get_interface_other_config(iface->cfg, "lacp-port-id", "0"));
2636 priority = atoi(get_interface_other_config(iface->cfg,
2637 "lacp-port-priority", "0"));
2638 key = atoi(get_interface_other_config(iface->cfg, "lacp-aggregation-key",
2641 if (portid <= 0 || portid > UINT16_MAX) {
2642 portid = iface->ofp_port;
2645 if (priority <= 0 || priority > UINT16_MAX) {
2646 priority = UINT16_MAX;
2649 if (key < 0 || key > UINT16_MAX) {
2653 s->name = iface->name;
2655 s->priority = priority;
2660 port_configure_bond(struct port *port, struct bond_settings *s,
2661 uint32_t *bond_stable_ids)
2663 const char *detect_s;
2664 struct iface *iface;
2665 int miimon_interval;
2668 s->name = port->name;
2669 s->balance = BM_SLB;
2670 if (port->cfg->bond_mode
2671 && !bond_mode_from_string(&s->balance, port->cfg->bond_mode)) {
2672 VLOG_WARN("port %s: unknown bond_mode %s, defaulting to %s",
2673 port->name, port->cfg->bond_mode,
2674 bond_mode_to_string(s->balance));
2676 if (s->balance == BM_SLB && port->bridge->cfg->n_flood_vlans) {
2677 VLOG_WARN("port %s: SLB bonds are incompatible with flood_vlans, "
2678 "please use another bond type or disable flood_vlans",
2682 miimon_interval = atoi(get_port_other_config(port->cfg,
2683 "bond-miimon-interval", "0"));
2684 if (miimon_interval <= 0) {
2685 miimon_interval = 200;
2688 detect_s = get_port_other_config(port->cfg, "bond-detect-mode", "carrier");
2689 if (!strcmp(detect_s, "carrier")) {
2690 miimon_interval = 0;
2691 } else if (strcmp(detect_s, "miimon")) {
2692 VLOG_WARN("port %s: unsupported bond-detect-mode %s, "
2693 "defaulting to carrier", port->name, detect_s);
2694 miimon_interval = 0;
2697 s->up_delay = MAX(0, port->cfg->bond_updelay);
2698 s->down_delay = MAX(0, port->cfg->bond_downdelay);
2699 s->basis = atoi(get_port_other_config(port->cfg, "bond-hash-basis", "0"));
2700 s->rebalance_interval = atoi(
2701 get_port_other_config(port->cfg, "bond-rebalance-interval", "10000"));
2702 if (s->rebalance_interval < 1000) {
2703 s->rebalance_interval = 1000;
2706 s->fake_iface = port->cfg->bond_fake_iface;
2709 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
2710 long long stable_id;
2712 stable_id = atoll(get_interface_other_config(iface->cfg,
2713 "bond-stable-id", "0"));
2714 if (stable_id <= 0 || stable_id >= UINT32_MAX) {
2715 stable_id = iface->ofp_port;
2717 bond_stable_ids[i++] = stable_id;
2719 netdev_set_miimon_interval(iface->netdev, miimon_interval);
2723 /* Returns true if 'port' is synthetic, that is, if we constructed it locally
2724 * instead of obtaining it from the database. */
2726 port_is_synthetic(const struct port *port)
2728 return ovsdb_idl_row_is_synthetic(&port->cfg->header_);
2731 /* Interface functions. */
2733 static struct iface *
2734 iface_create(struct port *port, const struct ovsrec_interface *if_cfg)
2736 struct bridge *br = port->bridge;
2737 struct iface *iface;
2738 char *name = if_cfg->name;
2740 iface = xzalloc(sizeof *iface);
2742 iface->name = xstrdup(name);
2743 iface->ofp_port = -1;
2744 iface->tag = tag_create_random();
2745 iface->netdev = NULL;
2746 iface->cfg = if_cfg;
2748 hmap_insert(&br->iface_by_name, &iface->name_node, hash_string(name, 0));
2750 list_push_back(&port->ifaces, &iface->port_elem);
2752 VLOG_DBG("attached network device %s to port %s", iface->name, port->name);
2758 iface_destroy(struct iface *iface)
2761 struct port *port = iface->port;
2762 struct bridge *br = port->bridge;
2764 if (br->ofproto && iface->ofp_port >= 0) {
2765 ofproto_port_unregister(br->ofproto, iface->ofp_port);
2768 if (iface->ofp_port >= 0) {
2769 hmap_remove(&br->ifaces, &iface->ofp_port_node);
2772 list_remove(&iface->port_elem);
2773 hmap_remove(&br->iface_by_name, &iface->name_node);
2775 netdev_close(iface->netdev);
2782 static struct iface *
2783 iface_lookup(const struct bridge *br, const char *name)
2785 struct iface *iface;
2787 HMAP_FOR_EACH_WITH_HASH (iface, name_node, hash_string(name, 0),
2788 &br->iface_by_name) {
2789 if (!strcmp(iface->name, name)) {
2797 static struct iface *
2798 iface_find(const char *name)
2800 const struct bridge *br;
2802 HMAP_FOR_EACH (br, node, &all_bridges) {
2803 struct iface *iface = iface_lookup(br, name);
2812 static struct iface *
2813 iface_from_ofp_port(const struct bridge *br, uint16_t ofp_port)
2815 struct iface *iface;
2817 HMAP_FOR_EACH_IN_BUCKET (iface, ofp_port_node,
2818 hash_int(ofp_port, 0), &br->ifaces) {
2819 if (iface->ofp_port == ofp_port) {
2826 /* Set Ethernet address of 'iface', if one is specified in the configuration
2829 iface_set_mac(struct iface *iface)
2831 uint8_t ea[ETH_ADDR_LEN];
2833 if (!strcmp(iface->type, "internal")
2834 && iface->cfg->mac && eth_addr_from_string(iface->cfg->mac, ea)) {
2835 if (iface->ofp_port == OFPP_LOCAL) {
2836 VLOG_ERR("interface %s: ignoring mac in Interface record "
2837 "(use Bridge record to set local port's mac)",
2839 } else if (eth_addr_is_multicast(ea)) {
2840 VLOG_ERR("interface %s: cannot set MAC to multicast address",
2843 int error = netdev_set_etheraddr(iface->netdev, ea);
2845 VLOG_ERR("interface %s: setting MAC failed (%s)",
2846 iface->name, strerror(error));
2852 /* Sets the ofport column of 'if_cfg' to 'ofport'. */
2854 iface_set_ofport(const struct ovsrec_interface *if_cfg, int64_t ofport)
2856 if (if_cfg && !ovsdb_idl_row_is_synthetic(&if_cfg->header_)) {
2857 ovsrec_interface_set_ofport(if_cfg, &ofport, 1);
2861 /* Clears all of the fields in 'if_cfg' that indicate interface status, and
2862 * sets the "ofport" field to -1.
2864 * This is appropriate when 'if_cfg''s interface cannot be created or is
2865 * otherwise invalid. */
2867 iface_clear_db_record(const struct ovsrec_interface *if_cfg)
2869 if (!ovsdb_idl_row_is_synthetic(&if_cfg->header_)) {
2870 iface_set_ofport(if_cfg, -1);
2871 ovsrec_interface_set_status(if_cfg, NULL, NULL, 0);
2872 ovsrec_interface_set_admin_state(if_cfg, NULL);
2873 ovsrec_interface_set_duplex(if_cfg, NULL);
2874 ovsrec_interface_set_link_speed(if_cfg, NULL, 0);
2875 ovsrec_interface_set_link_state(if_cfg, NULL);
2876 ovsrec_interface_set_mtu(if_cfg, NULL, 0);
2877 ovsrec_interface_set_cfm_fault(if_cfg, NULL, 0);
2878 ovsrec_interface_set_cfm_remote_mpids(if_cfg, NULL, 0);
2879 ovsrec_interface_set_lacp_current(if_cfg, NULL, 0);
2880 ovsrec_interface_set_statistics(if_cfg, NULL, NULL, 0);
2884 /* Adds the 'n' key-value pairs in 'keys' in 'values' to 'shash'.
2886 * The value strings in '*shash' are taken directly from values[], not copied,
2887 * so the caller should not modify or free them. */
2889 shash_from_ovs_idl_map(char **keys, char **values, size_t n,
2890 struct shash *shash)
2895 for (i = 0; i < n; i++) {
2896 shash_add(shash, keys[i], values[i]);
2900 /* Creates 'keys' and 'values' arrays from 'shash'.
2902 * Sets 'keys' and 'values' to heap allocated arrays representing the key-value
2903 * pairs in 'shash'. The caller takes ownership of 'keys' and 'values'. They
2904 * are populated with with strings taken directly from 'shash' and thus have
2905 * the same ownership of the key-value pairs in shash.
2908 shash_to_ovs_idl_map(struct shash *shash,
2909 char ***keys, char ***values, size_t *n)
2913 struct shash_node *sn;
2915 count = shash_count(shash);
2917 k = xmalloc(count * sizeof *k);
2918 v = xmalloc(count * sizeof *v);
2921 SHASH_FOR_EACH(sn, shash) {
2932 struct iface_delete_queues_cbdata {
2933 struct netdev *netdev;
2934 const struct ovsdb_datum *queues;
2938 queue_ids_include(const struct ovsdb_datum *queues, int64_t target)
2940 union ovsdb_atom atom;
2942 atom.integer = target;
2943 return ovsdb_datum_find_key(queues, &atom, OVSDB_TYPE_INTEGER) != UINT_MAX;
2947 iface_delete_queues(unsigned int queue_id,
2948 const struct shash *details OVS_UNUSED, void *cbdata_)
2950 struct iface_delete_queues_cbdata *cbdata = cbdata_;
2952 if (!queue_ids_include(cbdata->queues, queue_id)) {
2953 netdev_delete_queue(cbdata->netdev, queue_id);
2958 iface_configure_qos(struct iface *iface, const struct ovsrec_qos *qos)
2960 if (!qos || qos->type[0] == '\0' || qos->n_queues < 1) {
2961 netdev_set_qos(iface->netdev, NULL, NULL);
2963 struct iface_delete_queues_cbdata cbdata;
2964 struct shash details;
2968 /* Configure top-level Qos for 'iface'. */
2969 shash_from_ovs_idl_map(qos->key_other_config, qos->value_other_config,
2970 qos->n_other_config, &details);
2971 netdev_set_qos(iface->netdev, qos->type, &details);
2972 shash_destroy(&details);
2974 /* Deconfigure queues that were deleted. */
2975 cbdata.netdev = iface->netdev;
2976 cbdata.queues = ovsrec_qos_get_queues(qos, OVSDB_TYPE_INTEGER,
2978 netdev_dump_queues(iface->netdev, iface_delete_queues, &cbdata);
2980 /* Configure queues for 'iface'. */
2982 for (i = 0; i < qos->n_queues; i++) {
2983 const struct ovsrec_queue *queue = qos->value_queues[i];
2984 unsigned int queue_id = qos->key_queues[i];
2986 if (queue_id == 0) {
2990 shash_from_ovs_idl_map(queue->key_other_config,
2991 queue->value_other_config,
2992 queue->n_other_config, &details);
2993 netdev_set_queue(iface->netdev, queue_id, &details);
2994 shash_destroy(&details);
2997 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
2998 VLOG_WARN_RL(&rl, "interface %s: QoS configured without a default "
2999 "queue (queue 0). Packets not directed to a "
3000 "correctly configured queue may be dropped.",
3005 netdev_set_policing(iface->netdev,
3006 iface->cfg->ingress_policing_rate,
3007 iface->cfg->ingress_policing_burst);
3011 iface_configure_cfm(struct iface *iface)
3013 const struct ovsrec_interface *cfg = iface->cfg;
3014 const char *extended_str, *opstate_str;
3015 struct cfm_settings s;
3017 if (!cfg->n_cfm_mpid) {
3018 ofproto_port_clear_cfm(iface->port->bridge->ofproto, iface->ofp_port);
3022 s.mpid = *cfg->cfm_mpid;
3023 s.interval = atoi(get_interface_other_config(iface->cfg, "cfm_interval",
3025 if (s.interval <= 0) {
3029 extended_str = get_interface_other_config(iface->cfg, "cfm_extended",
3031 s.extended = !strcasecmp("true", extended_str);
3033 opstate_str = get_interface_other_config(iface->cfg, "cfm_opstate", "up");
3034 s.opup = !strcasecmp("up", opstate_str);
3036 ofproto_port_set_cfm(iface->port->bridge->ofproto, iface->ofp_port, &s);
3039 /* Returns true if 'iface' is synthetic, that is, if we constructed it locally
3040 * instead of obtaining it from the database. */
3042 iface_is_synthetic(const struct iface *iface)
3044 return ovsdb_idl_row_is_synthetic(&iface->cfg->header_);
3047 /* Port mirroring. */
3049 static struct mirror *
3050 mirror_find_by_uuid(struct bridge *br, const struct uuid *uuid)
3054 HMAP_FOR_EACH_IN_BUCKET (m, hmap_node, uuid_hash(uuid), &br->mirrors) {
3055 if (uuid_equals(uuid, &m->uuid)) {
3063 bridge_configure_mirrors(struct bridge *br)
3065 const struct ovsdb_datum *mc;
3066 unsigned long *flood_vlans;
3067 struct mirror *m, *next;
3070 /* Get rid of deleted mirrors. */
3071 mc = ovsrec_bridge_get_mirrors(br->cfg, OVSDB_TYPE_UUID);
3072 HMAP_FOR_EACH_SAFE (m, next, hmap_node, &br->mirrors) {
3073 union ovsdb_atom atom;
3075 atom.uuid = m->uuid;
3076 if (ovsdb_datum_find_key(mc, &atom, OVSDB_TYPE_UUID) == UINT_MAX) {
3081 /* Add new mirrors and reconfigure existing ones. */
3082 for (i = 0; i < br->cfg->n_mirrors; i++) {
3083 const struct ovsrec_mirror *cfg = br->cfg->mirrors[i];
3084 struct mirror *m = mirror_find_by_uuid(br, &cfg->header_.uuid);
3086 m = mirror_create(br, cfg);
3088 if (!mirror_configure(m, cfg)) {
3093 /* Update flooded vlans (for RSPAN). */
3094 flood_vlans = vlan_bitmap_from_array(br->cfg->flood_vlans,
3095 br->cfg->n_flood_vlans);
3096 ofproto_set_flood_vlans(br->ofproto, flood_vlans);
3097 bitmap_free(flood_vlans);
3100 static struct mirror *
3101 mirror_create(struct bridge *br, const struct ovsrec_mirror *cfg)
3105 m = xzalloc(sizeof *m);
3106 m->uuid = cfg->header_.uuid;
3107 hmap_insert(&br->mirrors, &m->hmap_node, uuid_hash(&m->uuid));
3109 m->name = xstrdup(cfg->name);
3115 mirror_destroy(struct mirror *m)
3118 struct bridge *br = m->bridge;
3121 ofproto_mirror_unregister(br->ofproto, m);
3124 hmap_remove(&br->mirrors, &m->hmap_node);
3131 mirror_collect_ports(struct mirror *m,
3132 struct ovsrec_port **in_ports, int n_in_ports,
3133 void ***out_portsp, size_t *n_out_portsp)
3135 void **out_ports = xmalloc(n_in_ports * sizeof *out_ports);
3136 size_t n_out_ports = 0;
3139 for (i = 0; i < n_in_ports; i++) {
3140 const char *name = in_ports[i]->name;
3141 struct port *port = port_lookup(m->bridge, name);
3143 out_ports[n_out_ports++] = port;
3145 VLOG_WARN("bridge %s: mirror %s cannot match on nonexistent "
3146 "port %s", m->bridge->name, m->name, name);
3149 *out_portsp = out_ports;
3150 *n_out_portsp = n_out_ports;
3154 mirror_configure(struct mirror *m, const struct ovsrec_mirror *cfg)
3156 struct ofproto_mirror_settings s;
3159 if (strcmp(cfg->name, m->name)) {
3161 m->name = xstrdup(cfg->name);
3165 /* Get output port or VLAN. */
3166 if (cfg->output_port) {
3167 s.out_bundle = port_lookup(m->bridge, cfg->output_port->name);
3168 if (!s.out_bundle) {
3169 VLOG_ERR("bridge %s: mirror %s outputs to port not on bridge",
3170 m->bridge->name, m->name);
3173 s.out_vlan = UINT16_MAX;
3175 if (cfg->output_vlan) {
3176 VLOG_ERR("bridge %s: mirror %s specifies both output port and "
3177 "output vlan; ignoring output vlan",
3178 m->bridge->name, m->name);
3180 } else if (cfg->output_vlan) {
3181 /* The database should prevent invalid VLAN values. */
3182 s.out_bundle = NULL;
3183 s.out_vlan = *cfg->output_vlan;
3185 VLOG_ERR("bridge %s: mirror %s does not specify output; ignoring",
3186 m->bridge->name, m->name);
3190 /* Get port selection. */
3191 if (cfg->select_all) {
3192 size_t n_ports = hmap_count(&m->bridge->ports);
3193 void **ports = xmalloc(n_ports * sizeof *ports);
3198 HMAP_FOR_EACH (port, hmap_node, &m->bridge->ports) {
3208 /* Get ports, dropping ports that don't exist.
3209 * The IDL ensures that there are no duplicates. */
3210 mirror_collect_ports(m, cfg->select_src_port, cfg->n_select_src_port,
3211 &s.srcs, &s.n_srcs);
3212 mirror_collect_ports(m, cfg->select_dst_port, cfg->n_select_dst_port,
3213 &s.dsts, &s.n_dsts);
3216 /* Get VLAN selection. */
3217 s.src_vlans = vlan_bitmap_from_array(cfg->select_vlan, cfg->n_select_vlan);
3220 ofproto_mirror_register(m->bridge->ofproto, m, &s);
3223 if (s.srcs != s.dsts) {