git://git.onelab.eu
/
plcapi.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
revised type-checking on taggable classes - previous code would reject any tag
[plcapi.git]
/
PLC
/
Methods
/
AddSlice.py
diff --git
a/PLC/Methods/AddSlice.py
b/PLC/Methods/AddSlice.py
index
3e2a89c
..
a29b41f
100644
(file)
--- a/
PLC/Methods/AddSlice.py
+++ b/
PLC/Methods/AddSlice.py
@@
-35,7
+35,8
@@
class AddSlice(Method):
roles = ['admin', 'pi']
roles = ['admin', 'pi']
- accepted_fields = Row.accepted_fields(can_update, [Slice.fields,Slice.tags])
+ accepted_fields = Row.accepted_fields(can_update, Slice.fields)
+ accepted_fields.update(Slice.tags)
accepts = [
Auth(),
accepts = [
Auth(),
@@
-46,10
+47,10
@@
class AddSlice(Method):
def call(self, auth, slice_fields):
def call(self, auth, slice_fields):
- slice_fields = Row.check_fields (slice_fields, self.accepted_fields)
-
[native,tags,rejected]=Row.split_fields(slice_fields,[Slice.fields,Slice.tags])
[native,tags,rejected]=Row.split_fields(slice_fields,[Slice.fields,Slice.tags])
+ # type checking
+ native = Row.check_fields (native, self.accepted_fields)
if rejected:
raise PLCInvalidArgument, "Cannot add Slice with column(s) %r"%rejected
if rejected:
raise PLCInvalidArgument, "Cannot add Slice with column(s) %r"%rejected