git://git.onelab.eu
/
sliver-openvswitch.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Add reminder comment to lib/learning-switch.c.
[sliver-openvswitch.git]
/
lib
/
learning-switch.c
diff --git
a/lib/learning-switch.c
b/lib/learning-switch.c
index
44d655d
..
76636a7
100644
(file)
--- a/
lib/learning-switch.c
+++ b/
lib/learning-switch.c
@@
-457,11
+457,14
@@
process_packet_in(struct lswitch *sw, struct rconn *rconn, void *opi_)
return;
drop_it:
return;
drop_it:
- /* Set up a flow to drop packets, or just drop the packet if we don't set
- * up flows at all. */
if (sw->max_idle >= 0) {
if (sw->max_idle >= 0) {
+ /* Set up a flow to drop packets. */
queue_tx(sw, rconn, make_add_flow(&flow, ntohl(opi->buffer_id),
sw->max_idle, 0));
queue_tx(sw, rconn, make_add_flow(&flow, ntohl(opi->buffer_id),
sw->max_idle, 0));
+ } else {
+ /* Just drop the packet, since we don't set up flows at all.
+ * XXX we should send a packet_out with no actions if buffer_id !=
+ * UINT32_MAX, to avoid clogging the kernel buffers. */
}
return;
}
}
return;
}