now parses correctly some args (empty array and empty string)

[plcapi.git] / PLC / Addresses.py

diff --git a/PLC/Addresses.py b/PLC/Addresses.py
index aca5178..6d6acee 100644 (file)
--- a/PLC/Addresses.py
+++ b/PLC/Addresses.py
@@ -1,6 +1,7 @@
 from PLC.Faults import *
 from PLC.Parameter import Parameter
 from PLC.Table import Row, Table
+from PLC.Filter import Filter
 from PLC.AddressTypes import AddressType, AddressTypes
 
 class Address(Row):
@@ -11,24 +12,20 @@ class Address(Row):
 
     table_name = 'addresses'
     primary_key = 'address_id'
+    join_tables = ['address_address_type', 'site_address']
     fields = {
         'address_id': Parameter(int, "Address identifier"),
-        'line1': Parameter(str, "Address line 1", max = 254, optional = False),
-        'line2': Parameter(str, "Address line 2", max = 254),
-        'line3': Parameter(str, "Address line 3", max = 254),
-        'city': Parameter(str, "City", max = 254, optional = False),
-        'state': Parameter(str, "State or province", max = 254, optional = False),
-        'postalcode': Parameter(str, "Postal code", max = 64, optional = False),
-        'country': Parameter(str, "Country", max = 128, optional = False),
-        'site_id': Parameter(str, "Site identifier"),
-        'address_type_ids': Parameter([int], "Address type identifiers", ro = True),
-        'address_types': Parameter([str], "Address types", ro = True),
+        'line1': Parameter(str, "Address line 1", max = 254),
+        'line2': Parameter(str, "Address line 2", max = 254, nullok = True),
+        'line3': Parameter(str, "Address line 3", max = 254, nullok = True),
+        'city': Parameter(str, "City", max = 254),
+        'state': Parameter(str, "State or province", max = 254),
+        'postalcode': Parameter(str, "Postal code", max = 64),
+        'country': Parameter(str, "Country", max = 128),
+        'address_type_ids': Parameter([int], "Address type identifiers"),
+        'address_types': Parameter([str], "Address types"),
         }
 
-    def __init__(self, api, fields = {}):
-        Row.__init__(self, fields)
-        self.api = api
-
     def add_address_type(self, address_type, commit = True):
         """
         Add address type to existing address.
@@ -80,47 +77,23 @@ class Address(Row):
             self['address_type_ids'].remove(address_type_id)
             self['address_types'].remove(address_type['name'])
 
-    def delete(self, commit = True):
-        """
-        Delete existing address from the database.
-        """
-
-        assert 'address_id' in self
-
-        # Clean up miscellaneous join tables
-        for table in ['address_address_type', 'addresses']:
-            self.api.db.do("DELETE FROM %s" \
-                           " WHERE address_id = %d" % \
-                           (table, self['address_id']), self)
-
-        if commit:
-            self.api.db.commit()
-
 class Addresses(Table):
     """
     Representation of row(s) from the addresses table in the
     database.
     """
 
-    def __init__(self, api, address_id_list = None):
-       self.api = api
-
-        sql = "SELECT %s FROM view_addresses" % \
-              ", ".join(Address.fields)
+    def __init__(self, api, address_filter = None, columns = None):
+        Table.__init__(self, api, Address, columns)
 
-        if address_id_list:
-            sql += " WHERE address_id IN (%s)" % ", ".join(map(str, address_id_list))
+        sql = "SELECT %s FROM view_addresses WHERE True" % \
+              ", ".join(self.columns)
 
-        rows = self.api.db.selectall(sql)
+        if address_filter is not None:
+            if isinstance(address_filter, (list, tuple, set, int, long)):
+                address_filter = Filter(Address.fields, {'address_id': address_filter})
+            elif isinstance(address_filter, dict):
+                address_filter = Filter(Address.fields, address_filter)
+            sql += " AND (%s) %s" % address_filter.sql(api)
 
-        for row in rows:
-            self[row['address_id']] = address = Address(api, row)
-            for aggregate in 'address_type_ids', 'address_types':
-                if not address.has_key(aggregate) or address[aggregate] is None:
-                    address[aggregate] = []
-                else:
-                    elements = address[aggregate].split(',')
-                    try:
-                        address[aggregate] = map(int, elements)
-                    except ValueError:
-                        address[aggregate] = elements
+        self.selectall(sql)