from PLC.Parameter import Parameter, Mixed
from PLC.Nodes import Node, Nodes
from PLC.NodeNetworks import NodeNetwork, NodeNetworks
-from PLC.Auth import PasswordAuth
+from PLC.Auth import Auth
+
+can_update = lambda (field, value): field not in ['nodenetwork_id', 'node_id']
class AddNodeNetwork(Method):
"""
+
Adds a new network for a node. Any values specified in
- optional_vals are used, otherwise defaults are used. Acceptable
- values for method are dhcp, static, proxy, tap, and
- ipmi. Acceptable value for type is ipv4. If type is static, ip,
- gateway, network, broadcast, netmask, and dns1 must all be
- specified in optional_vals. If type is dhcp, these parameters,
- even if specified, are ignored.
-
- PIs and techs may only add networks to their own nodes. ins may
+ nodenetwork_fields are used, otherwise defaults are
+ used. Acceptable values for method may be retrieved via
+ GetNetworkMethods. Acceptable values for type may be retrieved via
+ GetNetworkTypes.
+
+ If type is static, ip, gateway, network, broadcast, netmask, and
+ dns1 must all be specified in nodenetwork_fields. If type is dhcp,
+ these parameters, even if specified, are ignored.
+
+ PIs and techs may only add networks to their own nodes. Admins may
add networks to any node.
Returns the new nodenetwork_id (> 0) if successful, faults otherwise.
roles = ['admin', 'pi', 'tech']
- can_update = lambda (field, value): field in \
- ['ip', 'mac', 'gateway', 'network', 'broadcast', 'netmask',
- 'dns1', 'dns2', 'hostname', 'bwlimit', 'is_primary']
- update_fields = dict(filter(can_update, NodeNetwork.fields.items()))
+ nodenetwork_fields = dict(filter(can_update, NodeNetwork.fields.items()))
accepts = [
- PasswordAuth(),
- Node.fields['node_id'],
- NodeNetwork.fields['method'],
- NodeNetwork.fields['type'],
- update_fields
+ Auth(),
+ Mixed(Node.fields['node_id'],
+ Node.fields['hostname']),
+ nodenetwork_fields
]
returns = Parameter(int, 'New nodenetwork_id (> 0) if successful')
- def call(self, auth, node_id, method, type, optional_vals = {}):
- if filter(lambda field: field not in self.update_fields, optional_vals):
- raise PLCInvalidArgument, "Invalid fields specified"
+
+ def call(self, auth, node_id_or_hostname, nodenetwork_fields):
+ nodenetwork_fields = dict(filter(can_update, nodenetwork_fields.items()))
# Check if node exists
- nodes = Nodes(self.api, [node_id]).values()
+ nodes = Nodes(self.api, [node_id_or_hostname])
if not nodes:
raise PLCInvalidArgument, "No such node"
node = nodes[0]
raise PLCPermissionDenied, "Not allowed to add node network for specified node"
# Add node network
- nodenetwork = NodeNetwork(self.api, optional_vals)
- nodenetwork['node_id'] = node_id
- nodenetwork['method'] = method
- nodenetwork['type'] = type
+ nodenetwork = NodeNetwork(self.api, nodenetwork_fields)
+ nodenetwork['node_id'] = node['node_id']
+ # if this is the first node network, make it primary
+ if not node['nodenetwork_ids']:
+ nodenetwork['is_primary'] = True
nodenetwork.sync()
+
+ # Logging variables
+ self.object_ids = [node['node_id'], nodenetwork['nodenetwork_id']]
+ self.messgage = "Node network %d added" % nodenetwork['nodenetwork_id']
return nodenetwork['nodenetwork_id']