iteration 4 & last:

[plcapi.git] / PLC / Methods / AddSliceToNodes.py

diff --git a/PLC/Methods/AddSliceToNodes.py b/PLC/Methods/AddSliceToNodes.py
index 8cc9ad7..1b2942c 100644 (file)
--- a/PLC/Methods/AddSliceToNodes.py
+++ b/PLC/Methods/AddSliceToNodes.py
@@ -7,7 +7,10 @@ from PLC.Auth import Auth
 
 class AddSliceToNodes(Method):
     """
-    Adds the specified slice to the specified nodes. If the slice is
+    Adds the specified slice to the specified nodes.
+    Nodes can be either local or foreign nodes, as returned by GetNodes
+
+    If the slice is
     already associated with a node, no errors are returned. 
 
     Returns 1 if successful, faults otherwise.
@@ -27,7 +30,6 @@ class AddSliceToNodes(Method):
 
     event_type = 'AddTo'
     object_type = 'Node'
-    object_ids = []
 
     def call(self, auth, slice_id_or_name, node_id_or_hostname_list):
         # Get slice information
@@ -35,24 +37,27 @@ class AddSliceToNodes(Method):
         if not slices:
             raise PLCInvalidArgument, "No such slice"
 
-        slice = slices.values()[0]
-
-        # Get specified nodes
-        nodes = Nodes(self.api, node_id_or_hostname_list).values()
+        slice = slices[0]
 
         if 'admin' not in self.caller['roles']:
             if self.caller['person_id'] in slice['person_ids']:
                 pass
+            # Thierry : I cannot figure out how this works
+            # how is having pi role related to being in a slice ?
             elif 'pi' not in self.caller['roles']:
                 raise PLCPermissionDenied, "Not a member of the specified slice"
             elif slice['site_id'] not in self.caller['site_ids']:
                 raise PLCPermissionDenied, "Specified slice not associated with any of your sites"
        
-       # Add slice to all nodes found
+        # Get specified nodes, add them to the slice
+         
+        nodes = Nodes(self.api, node_id_or_hostname_list)
        for node in nodes:
             if slice['slice_id'] not in node['slice_ids']:
-                slice.add_node(node)
-                
+                slice.add_node(node, commit = False)
+
+        slice.sync()
+
        self.object_ids = [node['node_id'] for node in nodes]
 
         return 1