-# $Id: DeleteSiteTag.py 14587 2009-07-19 13:18:50Z thierry $
-# $URL: http://svn.planet-lab.org/svn/PLCAPI/tags/PLCAPI-4.3-27/PLC/Methods/DeleteSiteTag.py $
#
# Thierry Parmentelat - INRIA
#
-# $Revision: 14587 $
-#
-
from PLC.Faults import *
from PLC.Method import Method
from PLC.Parameter import Parameter, Mixed
from PLC.Auth import Auth
-from PLC.SiteTags import SiteTag, SiteTags
from PLC.Sites import Site, Sites
+from PLC.TagTypes import TagType, TagTypes
+from PLC.SiteTags import SiteTag, SiteTags
-from PLC.Nodes import Node, Nodes
-from PLC.Sites import Site, Sites
+# need to import so the core classes get decorated with caller_may_write_tag
+from PLC.AuthorizeHelpers import AuthorizeHelpers
class DeleteSiteTag(Method):
"""
Deletes the specified site setting
- Attributes may require the caller to have a particular role in order
- to be deleted, depending on the related tag type.
- Admins may delete attributes of any slice or sliver.
+ Admins have full access. Non-admins need to
+ (1) have at least one of the roles attached to the tagtype,
+ and (2) belong in the same site as the tagged subject.
Returns 1 if successful, faults otherwise.
"""
returns = Parameter(int, '1 if successful')
- object_type = 'Site'
-
-
def call(self, auth, site_tag_id):
site_tags = SiteTags(self.api, [site_tag_id])
if not site_tags:
raise PLCInvalidArgument, "No such site tag %r"%site_tag_id
site_tag = site_tags[0]
- ### reproducing a check from UpdateSliceTag, looks dumb though
- sites = Sites(self.api, [site_tag['site_id']])
- if not sites:
- raise PLCInvalidArgument, "No such site %r"%site_tag['site_id']
- site = sites[0]
-
- assert site_tag['site_tag_id'] in site['site_tag_ids']
+ tag_type_id = site_tag['tag_type_id']
+ tag_type = TagTypes (self.api,[tag_type_id])[0]
- # check permission : it not admin, is the user affiliated with the right site
- if 'admin' not in self.caller['roles']:
- # check caller is affiliated with this site
- if self.caller['person_id'] not in site['person_ids']:
- raise PLCPermissionDenied, "Not a member of the hosting site %s"%site['abbreviated_site']
-
- required_min_role = tag_type ['min_role_id']
- if required_min_role is not None and \
- min(self.caller['role_ids']) > required_min_role:
- raise PLCPermissionDenied, "Not allowed to modify the specified site setting, requires role %d",required_min_role
+ sites = Sites (self.api, site_tag['site_id'])
+ if not sites:
+ raise PLCInvalidArgument, "No such site %d"%site_tag['site_id']
+ site=sites[0]
+
+ # check authorizations
+ site.caller_may_write_tag(self.api,self.caller,tag_type)
site_tag.delete()
self.object_ids = [site_tag['site_tag_id']]