Fix typo

[plcapi.git] / PLC / Methods / UpdatePersonTag.py

diff --git a/PLC/Methods/UpdatePersonTag.py b/PLC/Methods/UpdatePersonTag.py
index 928b54f..804d17d 100644 (file)
--- a/PLC/Methods/UpdatePersonTag.py
+++ b/PLC/Methods/UpdatePersonTag.py
@@ -50,19 +50,19 @@ class UpdatePersonTag(Method):
 
         assert person_tag['person_tag_id'] in person['person_tag_ids']
 
-       # check permission : it not admin, is the user affiliated with the right person
-       if 'admin' not in self.caller['roles']:
-           # check caller is affiliated with this person's person
-           if len(set(person['person_ids']) & set(self.caller['person_ids'])) == 0:
-               raise PLCPermissionDenied, "Not a member of the person's persons: %s"%person['person_ids']
-           
-           required_min_role = tag_type ['min_role_id']
-           if required_min_role is not None and \
-                   min(self.caller['role_ids']) > required_min_role:
-               raise PLCPermissionDenied, "Not allowed to modify the specified person setting, requires role %d",required_min_role
+        # check permission : it not admin, is the user affiliated with the right person
+        if 'admin' not in self.caller['roles']:
+            # check caller is affiliated with this person's person
+            if not self.caller.can_update(person):
+                raise PLCPermissionDenied, "Not a member of the person's persons: %s"%person['person_ids']
+
+            required_min_role = person_tag['min_role_id']
+            if required_min_role is not None and \
+                    min(self.caller['role_ids']) > required_min_role:
+                raise PLCPermissionDenied, "Not allowed to modify the specified person setting, requires role %d",required_min_role
 
         person_tag['value'] = value
         person_tag.sync()
 
-       self.object_ids = [person_tag['person_tag_id']]
+        self.object_ids = [person_tag['person_tag_id']]
         return 1