This commit was manufactured by cvs2svn to create tag
[linux-2.6.git] / arch / i386 / kernel / apic.c
index de08552..61db30b 100644 (file)
@@ -47,24 +47,6 @@ int apic_verbosity;
 
 static void apic_pm_activate(void);
 
-/*
- * 'what should we do if we get a hw irq event on an illegal vector'.
- * each architecture has to answer this themselves.
- */
-void ack_bad_irq(unsigned int irq)
-{
-       printk("unexpected IRQ trap at vector %02x\n", irq);
-       /*
-        * Currently unexpected vectors happen only on SMP and APIC.
-        * We _must_ ack these because every local APIC has only N
-        * irq slots per priority level, and a 'hanging, unacked' IRQ
-        * holds up an irq slot - in excessive cases (when multiple
-        * unexpected vectors occur) that might lock up the APIC
-        * completely.
-        */
-       ack_APIC_irq();
-}
-
 void __init apic_intr_init(void)
 {
 #ifdef CONFIG_SMP
@@ -330,10 +312,6 @@ int __init verify_local_APIC(void)
 
 void __init sync_Arb_IDs(void)
 {
-       /* Unsupported on P4 - see Intel Dev. Manual Vol. 3, Ch. 8.6.1 */
-       unsigned int ver = GET_APIC_VERSION(apic_read(APIC_LVR));
-       if (ver >= 0x14)        /* P4 or higher */
-               return;
        /*
         * Wait for idle.
         */
@@ -543,25 +521,12 @@ void __init setup_local_APIC (void)
        apic_pm_activate();
 }
 
-/*
- * If Linux enabled the LAPIC against the BIOS default
- * disable it down before re-entering the BIOS on shutdown.
- * Otherwise the BIOS may get confused and not power-off.
- */
-void
-lapic_shutdown(void)
-{
-       if (!cpu_has_apic || !enabled_via_apicbase)
-               return;
-
-       local_irq_disable();
-       disable_local_APIC();
-       local_irq_enable();
-}
-
 #ifdef CONFIG_PM
 
 static struct {
+       /* 'active' is true if the local APIC was enabled by us and
+          not the BIOS; this signifies that we are also responsible
+          for disabling it before entering apm/acpi suspend */
        int active;
        /* r/w apic fields */
        unsigned int apic_id;
@@ -649,10 +614,6 @@ static int lapic_resume(struct sys_device *dev)
        return 0;
 }
 
-/*
- * This device has no shutdown method - fully functioning local APICs
- * are needed on every CPU up until machine_halt/restart/poweroff.
- */
 
 static struct sysdev_class lapic_sysclass = {
        set_kset_name("lapic"),
@@ -736,7 +697,7 @@ static int __init detect_init_APIC (void)
        u32 h, l, features;
        extern void get_cpu_vendor(struct cpuinfo_x86*);
 
-       /* Disabled by kernel option? */
+       /* Disabled by DMI scan or kernel option? */
        if (enable_local_apic < 0)
                return -1;
 
@@ -750,7 +711,8 @@ static int __init detect_init_APIC (void)
                        break;
                goto no_apic;
        case X86_VENDOR_INTEL:
-               if (boot_cpu_data.x86 == 6 || boot_cpu_data.x86 == 15 ||
+               if (boot_cpu_data.x86 == 6 ||
+                   (boot_cpu_data.x86 == 15 && (cpu_has_apic || enable_local_apic > 0)) ||
                    (boot_cpu_data.x86 == 5 && cpu_has_apic))
                        break;
                goto no_apic;
@@ -760,23 +722,20 @@ static int __init detect_init_APIC (void)
 
        if (!cpu_has_apic) {
                /*
-                * Over-ride BIOS and try to enable the local
-                * APIC only if "lapic" specified.
+                * Over-ride BIOS and try to enable LAPIC
+                * only if "lapic" specified
                 */
-               if (enable_local_apic <= 0) {
-                       printk("Local APIC disabled by BIOS -- "
-                              "you can enable it with \"lapic\"\n");
-                       return -1;
-               }
+               if (enable_local_apic != 1)
+                       goto no_apic;
                /*
                 * Some BIOSes disable the local APIC in the
                 * APIC_BASE MSR. This can only be done in
-                * software for Intel P6 or later and AMD K7
-                * (Model > 1) or later.
+                * software for Intel P6 and AMD K7 (Model > 1).
                 */
                rdmsr(MSR_IA32_APICBASE, l, h);
                if (!(l & MSR_IA32_APICBASE_ENABLE)) {
-                       printk("Local APIC disabled by BIOS -- reenabling.\n");
+                       apic_printk(APIC_VERBOSE, "Local APIC disabled "
+                                       "by BIOS -- reenabling.\n");
                        l &= ~MSR_IA32_APICBASE_BASE;
                        l |= MSR_IA32_APICBASE_ENABLE | APIC_DEFAULT_PHYS_BASE;
                        wrmsr(MSR_IA32_APICBASE, l, h);
@@ -803,7 +762,7 @@ static int __init detect_init_APIC (void)
        if (nmi_watchdog != NMI_NONE)
                nmi_watchdog = NMI_LOCAL_APIC;
 
-       printk("Found and enabled local APIC!\n");
+       apic_printk(APIC_VERBOSE, "Found and enabled local APIC!\n");
 
        apic_pm_activate();
 
@@ -830,8 +789,8 @@ void __init init_apic_mappings(void)
                apic_phys = mp_lapic_addr;
 
        set_fixmap_nocache(FIX_APIC_BASE, apic_phys);
-       printk(KERN_DEBUG "mapped APIC to %08lx (%08lx)\n", APIC_BASE,
-              apic_phys);
+       apic_printk(APIC_DEBUG, "mapped APIC to %08lx (%08lx)\n", APIC_BASE,
+                       apic_phys);
 
        /*
         * Fetch the APIC ID of the BSP in case we have a
@@ -849,23 +808,21 @@ void __init init_apic_mappings(void)
                        if (smp_found_config) {
                                ioapic_phys = mp_ioapics[i].mpc_apicaddr;
                                if (!ioapic_phys) {
-                                       printk(KERN_ERR
-                                              "WARNING: bogus zero IO-APIC "
-                                              "address found in MPTABLE, "
-                                              "disabling IO/APIC support!\n");
+                                       printk(KERN_ERR "WARNING: bogus zero IO-APIC address found in MPTABLE, disabling IO/APIC support!\n");
+
                                        smp_found_config = 0;
                                        skip_ioapic_setup = 1;
                                        goto fake_ioapic_page;
                                }
                        } else {
 fake_ioapic_page:
-                               ioapic_phys = (unsigned long)
-                                             alloc_bootmem_pages(PAGE_SIZE);
+                               ioapic_phys = (unsigned long) alloc_bootmem_pages(PAGE_SIZE);
                                ioapic_phys = __pa(ioapic_phys);
                        }
                        set_fixmap_nocache(idx, ioapic_phys);
-                       printk(KERN_DEBUG "mapped IOAPIC to %08lx (%08lx)\n",
-                              __fix_to_virt(idx), ioapic_phys);
+                       apic_printk(APIC_DEBUG, "mapped IOAPIC to "
+                                       "%08lx (%08lx)\n",
+                                       __fix_to_virt(idx), ioapic_phys);
                        idx++;
                }
        }
@@ -1196,7 +1153,7 @@ inline void smp_local_timer_interrupt(struct pt_regs * regs)
  *   interrupt as well. Thus we cannot inline the local irq ... ]
  */
 
-fastcall void smp_apic_timer_interrupt(struct pt_regs *regs)
+void smp_apic_timer_interrupt(struct pt_regs regs)
 {
        int cpu = smp_processor_id();
 
@@ -1216,14 +1173,14 @@ fastcall void smp_apic_timer_interrupt(struct pt_regs *regs)
         * interrupt lock, which is the WrongThing (tm) to do.
         */
        irq_enter();
-       smp_local_timer_interrupt(regs);
+       smp_local_timer_interrupt(&regs);
        irq_exit();
 }
 
 /*
  * This interrupt should _never_ happen with our APIC/SMP architecture
  */
-fastcall void smp_spurious_interrupt(struct pt_regs *regs)
+asmlinkage void smp_spurious_interrupt(void)
 {
        unsigned long v;
 
@@ -1247,7 +1204,7 @@ fastcall void smp_spurious_interrupt(struct pt_regs *regs)
  * This interrupt should never happen with our APIC/SMP architecture
  */
 
-fastcall void smp_error_interrupt(struct pt_regs *regs)
+asmlinkage void smp_error_interrupt(void)
 {
        unsigned long v, v1;