datapath: Drop padding from struct odp_flow_key.
[sliver-openvswitch.git] / datapath / datapath.c
index e468198..46497c6 100644 (file)
@@ -8,6 +8,8 @@
 
 /* Functions for managing the dp interface/device. */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/fs.h>
@@ -27,7 +29,6 @@
 #include <linux/udp.h>
 #include <linux/version.h>
 #include <linux/ethtool.h>
-#include <linux/random.h>
 #include <linux/wait.h>
 #include <asm/system.h>
 #include <asm/div64.h>
@@ -38,7 +39,6 @@
 #include <linux/inetdevice.h>
 #include <linux/list.h>
 #include <linux/rculist.h>
-#include <linux/workqueue.h>
 #include <linux/dmi.h>
 #include <net/inet_ecn.h>
 #include <linux/compat.h>
@@ -325,8 +325,6 @@ static void do_destroy_dp(struct datapath *dp)
 
        for (i = 0; i < DP_N_QUEUES; i++)
                skb_queue_purge(&dp->queues[i]);
-       for (i = 0; i < DP_MAX_GROUPS; i++)
-               kfree(dp->groups[i]);
        free_percpu(dp->stats_percpu);
        kobject_put(&dp->ifobj);
        module_put(THIS_MODULE);
@@ -531,8 +529,8 @@ out:
 static void suppress_loop(struct datapath *dp, struct sw_flow_actions *actions)
 {
        if (net_ratelimit())
-               printk(KERN_WARNING "%s: flow looped %d times, dropping\n",
-                      dp_name(dp), DP_MAX_LOOPS);
+               pr_warn("%s: flow looped %d times, dropping\n",
+                       dp_name(dp), DP_MAX_LOOPS);
        actions->n_actions = 0;
 }
 
@@ -542,35 +540,45 @@ void dp_process_received_packet(struct dp_port *p, struct sk_buff *skb)
        struct datapath *dp = p->dp;
        struct dp_stats_percpu *stats;
        int stats_counter_off;
-       struct odp_flow_key key;
-       struct tbl_node *flow_node;
-       struct sw_flow *flow;
        struct sw_flow_actions *acts;
        struct loop_counter *loop;
+       int error;
 
        OVS_CB(skb)->dp_port = p;
 
-       /* Extract flow from 'skb' into 'key'. */
-       if (flow_extract(skb, p ? p->port_no : ODPP_NONE, &key)) {
-               if (dp->drop_frags) {
+       if (!OVS_CB(skb)->flow) {
+               struct odp_flow_key key;
+               struct tbl_node *flow_node;
+               bool is_frag;
+
+               /* Extract flow from 'skb' into 'key'. */
+               error = flow_extract(skb, p ? p->port_no : ODPP_NONE, &key, &is_frag);
+               if (unlikely(error)) {
+                       kfree_skb(skb);
+                       return;
+               }
+
+               if (is_frag && dp->drop_frags) {
                        kfree_skb(skb);
                        stats_counter_off = offsetof(struct dp_stats_percpu, n_frags);
                        goto out;
                }
-       }
 
-       /* Look up flow. */
-       flow_node = tbl_lookup(rcu_dereference(dp->table), &key, flow_hash(&key), flow_cmp);
-       if (unlikely(!flow_node)) {
-               dp_output_control(dp, skb, _ODPL_MISS_NR, OVS_CB(skb)->tun_id);
-               stats_counter_off = offsetof(struct dp_stats_percpu, n_missed);
-               goto out;
+               /* Look up flow. */
+               flow_node = tbl_lookup(rcu_dereference(dp->table), &key,
+                                       flow_hash(&key), flow_cmp);
+               if (unlikely(!flow_node)) {
+                       dp_output_control(dp, skb, _ODPL_MISS_NR, OVS_CB(skb)->tun_id);
+                       stats_counter_off = offsetof(struct dp_stats_percpu, n_missed);
+                       goto out;
+               }
+
+               OVS_CB(skb)->flow = flow_cast(flow_node);
        }
 
-       flow = flow_cast(flow_node);
-       flow_used(flow, skb);
+       flow_used(OVS_CB(skb)->flow, skb);
 
-       acts = rcu_dereference(flow->sf_acts);
+       acts = rcu_dereference(OVS_CB(skb)->flow->sf_acts);
 
        /* Check whether we've looped too much. */
        loop = &get_cpu_var(dp_loop_counters).counters[!!in_interrupt()];
@@ -582,7 +590,8 @@ void dp_process_received_packet(struct dp_port *p, struct sk_buff *skb)
        }
 
        /* Execute actions. */
-       execute_actions(dp, skb, &key, acts->actions, acts->n_actions, GFP_ATOMIC);
+       execute_actions(dp, skb, &OVS_CB(skb)->flow->key, acts->actions,
+                       acts->n_actions, GFP_ATOMIC);
        stats_counter_off = offsetof(struct dp_stats_percpu, n_hit);
 
        /* Check whether sub-actions looped too much. */
@@ -599,7 +608,11 @@ out:
        /* Update datapath statistics. */
        local_bh_disable();
        stats = per_cpu_ptr(dp->stats_percpu, smp_processor_id());
+
+       write_seqcount_begin(&stats->seqlock);
        (*(u64 *)((u8 *)stats + stats_counter_off))++;
+       write_seqcount_end(&stats->seqlock);
+
        local_bh_enable();
 }
 
@@ -636,9 +649,9 @@ int vswitch_skb_checksum_setup(struct sk_buff *skb)
                break;
        default:
                if (net_ratelimit())
-                       printk(KERN_ERR "Attempting to checksum a non-"
-                              "TCP/UDP packet, dropping a protocol"
-                              " %d packet", iph->protocol);
+                       pr_err("Attempting to checksum a non-TCP/UDP packet, "
+                              "dropping a protocol %d packet",
+                              iph->protocol);
                goto out;
        }
 
@@ -741,11 +754,10 @@ void compute_ip_summed(struct sk_buff *skb, bool xmit)
                break;
 #endif
        default:
-               printk(KERN_ERR "openvswitch: unknown checksum type %d\n",
-                      skb->ip_summed);
+               pr_err("unknown checksum type %d\n", skb->ip_summed);
                /* None seems the safest... */
                OVS_CB(skb)->ip_summed = OVS_CSUM_NONE;
-       }       
+       }
 
 #if defined(CONFIG_XEN) && defined(HAVE_PROTO_DATA_VALID)
        /* Xen has a special way of representing CHECKSUM_PARTIAL on older
@@ -860,7 +872,11 @@ err_kfree_skb:
 err:
        local_bh_disable();
        stats = per_cpu_ptr(dp->stats_percpu, smp_processor_id());
+
+       write_seqcount_begin(&stats->seqlock);
        stats->n_lost++;
+       write_seqcount_end(&stats->seqlock);
+
        local_bh_enable();
 
        return err;
@@ -888,25 +904,36 @@ static int validate_actions(const struct sw_flow_actions *actions)
 
        for (i = 0; i < actions->n_actions; i++) {
                const union odp_action *a = &actions->actions[i];
+               __be16 mask;
+
                switch (a->type) {
-               case ODPAT_OUTPUT:
-                       if (a->output.port >= DP_MAX_PORTS)
-                               return -EINVAL;
+               case ODPAT_CONTROLLER:
+               case ODPAT_STRIP_VLAN:
+               case ODPAT_SET_DL_SRC:
+               case ODPAT_SET_DL_DST:
+               case ODPAT_SET_NW_SRC:
+               case ODPAT_SET_NW_DST:
+               case ODPAT_SET_TP_SRC:
+               case ODPAT_SET_TP_DST:
+               case ODPAT_SET_TUNNEL:
+               case ODPAT_SET_PRIORITY:
+               case ODPAT_POP_PRIORITY:
+               case ODPAT_DROP_SPOOFED_ARP:
+                       /* No validation needed. */
                        break;
 
-               case ODPAT_OUTPUT_GROUP:
-                       if (a->output_group.group >= DP_MAX_GROUPS)
+               case ODPAT_OUTPUT:
+                       if (a->output.port >= DP_MAX_PORTS)
                                return -EINVAL;
                        break;
 
-               case ODPAT_SET_VLAN_VID:
-                       if (a->vlan_vid.vlan_vid & htons(~VLAN_VID_MASK))
+               case ODPAT_SET_DL_TCI:
+                       mask = a->dl_tci.mask;
+                       if (mask != htons(VLAN_VID_MASK) &&
+                           mask != htons(VLAN_PCP_MASK) &&
+                           mask != htons(VLAN_VID_MASK | VLAN_PCP_MASK))
                                return -EINVAL;
-                       break;
-
-               case ODPAT_SET_VLAN_PCP:
-                       if (a->vlan_pcp.vlan_pcp
-                           & ~(VLAN_PCP_MASK >> VLAN_PCP_SHIFT))
+                       if (a->dl_tci.tci & ~mask)
                                return -EINVAL;
                        break;
 
@@ -916,9 +943,7 @@ static int validate_actions(const struct sw_flow_actions *actions)
                        break;
 
                default:
-                       if (a->type >= ODPAT_N_ACTIONS)
-                               return -EOPNOTSUPP;
-                       break;
+                       return -EOPNOTSUPP;
                }
        }
 
@@ -1015,8 +1040,6 @@ static int do_put_flow(struct datapath *dp, struct odp_flow_put *uf,
        struct tbl *table;
        int error;
 
-       memset(uf->flow.key.reserved, 0, sizeof uf->flow.key.reserved);
-
        table = rcu_dereference(dp->table);
        flow_node = tbl_lookup(table, &uf->flow.key, flow_hash(&uf->flow.key), flow_cmp);
        if (!flow_node) {
@@ -1036,12 +1059,12 @@ static int do_put_flow(struct datapath *dp, struct odp_flow_put *uf,
                }
 
                /* Allocate flow. */
-               error = -ENOMEM;
-               flow = kmem_cache_alloc(flow_cache, GFP_KERNEL);
-               if (flow == NULL)
+               flow = flow_alloc();
+               if (IS_ERR(flow)) {
+                       error = PTR_ERR(flow);
                        goto error;
+               }
                flow->key = uf->flow.key;
-               spin_lock_init(&flow->lock);
                clear_stats(flow);
 
                /* Obtain actions. */
@@ -1096,7 +1119,8 @@ static int do_put_flow(struct datapath *dp, struct odp_flow_put *uf,
 error_free_flow_acts:
        kfree(flow->sf_acts);
 error_free_flow:
-       kmem_cache_free(flow_cache, flow);
+       flow->sf_acts = NULL;
+       flow_put(flow);
 error:
        return error;
 }
@@ -1174,7 +1198,6 @@ static struct sw_flow *do_del_flow(struct datapath *dp, struct odp_flow_key *key
        struct tbl_node *flow_node;
        int error;
 
-       memset(key->reserved, 0, sizeof key->reserved);
        flow_node = tbl_lookup(table, key, flow_hash(key), flow_cmp);
        if (!flow_node)
                return ERR_PTR(-ENOENT);
@@ -1224,7 +1247,6 @@ static int do_query_flows(struct datapath *dp, const struct odp_flowvec *flowvec
 
                if (copy_from_user(&uf, ufp, sizeof uf))
                        return -EFAULT;
-               memset(uf.key.reserved, 0, sizeof uf.key.reserved);
 
                flow_node = tbl_lookup(table, &uf.key, flow_hash(&uf.key), flow_cmp);
                if (!flow_node)
@@ -1306,16 +1328,18 @@ static int do_execute(struct datapath *dp, const struct odp_execute *execute)
        struct sk_buff *skb;
        struct sw_flow_actions *actions;
        struct ethhdr *eth;
+       bool is_frag;
        int err;
 
        err = -EINVAL;
        if (execute->length < ETH_HLEN || execute->length > 65535)
                goto error;
 
-       err = -ENOMEM;
        actions = flow_actions_alloc(execute->n_actions);
-       if (!actions)
+       if (IS_ERR(actions)) {
+               err = PTR_ERR(actions);
                goto error;
+       }
 
        err = -EFAULT;
        if (copy_from_user(actions->actions, execute->actions,
@@ -1331,11 +1355,6 @@ static int do_execute(struct datapath *dp, const struct odp_execute *execute)
        if (!skb)
                goto error_free_actions;
 
-       if (execute->in_port < DP_MAX_PORTS)
-               OVS_CB(skb)->dp_port = dp->ports[execute->in_port];
-       else
-               OVS_CB(skb)->dp_port = NULL;
-
        err = -EFAULT;
        if (copy_from_user(skb_put(skb, execute->length), execute->data,
                           execute->length))
@@ -1352,7 +1371,9 @@ static int do_execute(struct datapath *dp, const struct odp_execute *execute)
        else
                skb->protocol = htons(ETH_P_802_2);
 
-       flow_extract(skb, execute->in_port, &key);
+       err = flow_extract(skb, -1, &key, &is_frag);
+       if (err)
+               goto error_free_skb;
 
        rcu_read_lock();
        err = execute_actions(dp, skb, &key, actions->actions,
@@ -1391,15 +1412,23 @@ static int get_dp_stats(struct datapath *dp, struct odp_stats __user *statsp)
        stats.max_capacity = TBL_MAX_BUCKETS;
        stats.n_ports = dp->n_ports;
        stats.max_ports = DP_MAX_PORTS;
-       stats.max_groups = DP_MAX_GROUPS;
        stats.n_frags = stats.n_hit = stats.n_missed = stats.n_lost = 0;
        for_each_possible_cpu(i) {
-               const struct dp_stats_percpu *s;
-               s = per_cpu_ptr(dp->stats_percpu, i);
-               stats.n_frags += s->n_frags;
-               stats.n_hit += s->n_hit;
-               stats.n_missed += s->n_missed;
-               stats.n_lost += s->n_lost;
+               const struct dp_stats_percpu *percpu_stats;
+               struct dp_stats_percpu local_stats;
+               unsigned seqcount;
+
+               percpu_stats = per_cpu_ptr(dp->stats_percpu, i);
+
+               do {
+                       seqcount = read_seqcount_begin(&percpu_stats->seqlock);
+                       local_stats = *percpu_stats;
+               } while (read_seqcount_retry(&percpu_stats->seqlock, seqcount));
+
+               stats.n_frags += local_stats.n_frags;
+               stats.n_hit += local_stats.n_hit;
+               stats.n_missed += local_stats.n_missed;
+               stats.n_lost += local_stats.n_lost;
        }
        stats.max_miss_queue = DP_MAX_QUEUE_LEN;
        stats.max_action_queue = DP_MAX_QUEUE_LEN;
@@ -1542,87 +1571,6 @@ static int list_ports(struct datapath *dp, struct odp_portvec __user *upv)
        return put_user(retval, &upv->n_ports);
 }
 
-/* RCU callback for freeing a dp_port_group */
-static void free_port_group(struct rcu_head *rcu)
-{
-       struct dp_port_group *g = container_of(rcu, struct dp_port_group, rcu);
-       kfree(g);
-}
-
-static int do_set_port_group(struct datapath *dp, u16 __user *ports,
-                            int n_ports, int group)
-{
-       struct dp_port_group *new_group, *old_group;
-       int error;
-
-       error = -EINVAL;
-       if (n_ports > DP_MAX_PORTS || group >= DP_MAX_GROUPS)
-               goto error;
-
-       error = -ENOMEM;
-       new_group = kmalloc(sizeof *new_group + sizeof(u16) * n_ports, GFP_KERNEL);
-       if (!new_group)
-               goto error;
-
-       new_group->n_ports = n_ports;
-       error = -EFAULT;
-       if (copy_from_user(new_group->ports, ports, sizeof(u16) * n_ports))
-               goto error_free;
-
-       old_group = rcu_dereference(dp->groups[group]);
-       rcu_assign_pointer(dp->groups[group], new_group);
-       if (old_group)
-               call_rcu(&old_group->rcu, free_port_group);
-       return 0;
-
-error_free:
-       kfree(new_group);
-error:
-       return error;
-}
-
-static int set_port_group(struct datapath *dp,
-                         const struct odp_port_group __user *upg)
-{
-       struct odp_port_group pg;
-
-       if (copy_from_user(&pg, upg, sizeof pg))
-               return -EFAULT;
-
-       return do_set_port_group(dp, pg.ports, pg.n_ports, pg.group);
-}
-
-static int do_get_port_group(struct datapath *dp,
-                            u16 __user *ports, int n_ports, int group,
-                            u16 __user *n_portsp)
-{
-       struct dp_port_group *g;
-       u16 n_copy;
-
-       if (group >= DP_MAX_GROUPS)
-               return -EINVAL;
-
-       g = dp->groups[group];
-       n_copy = g ? min_t(int, g->n_ports, n_ports) : 0;
-       if (n_copy && copy_to_user(ports, g->ports, n_copy * sizeof(u16)))
-               return -EFAULT;
-
-       if (put_user(g ? g->n_ports : 0, n_portsp))
-               return -EFAULT;
-
-       return 0;
-}
-
-static int get_port_group(struct datapath *dp, struct odp_port_group __user *upg)
-{
-       struct odp_port_group pg;
-
-       if (copy_from_user(&pg, upg, sizeof pg))
-               return -EFAULT;
-
-       return do_get_port_group(dp, pg.ports, pg.n_ports, pg.group, &upg->n_ports);
-}
-
 static int get_listen_mask(const struct file *f)
 {
        return (long)f->private_data;
@@ -1757,14 +1705,6 @@ static long openvswitch_ioctl(struct file *f, unsigned int cmd,
                err = list_ports(dp, (struct odp_portvec __user *)argp);
                break;
 
-       case ODP_PORT_GROUP_SET:
-               err = set_port_group(dp, (struct odp_port_group __user *)argp);
-               break;
-
-       case ODP_PORT_GROUP_GET:
-               err = get_port_group(dp, (struct odp_port_group __user *)argp);
-               break;
-
        case ODP_FLOW_FLUSH:
                err = flush_flows(dp);
                break;
@@ -1824,27 +1764,6 @@ static int compat_list_ports(struct datapath *dp, struct compat_odp_portvec __us
        return put_user(retval, &upv->n_ports);
 }
 
-static int compat_set_port_group(struct datapath *dp, const struct compat_odp_port_group __user *upg)
-{
-       struct compat_odp_port_group pg;
-
-       if (copy_from_user(&pg, upg, sizeof pg))
-               return -EFAULT;
-
-       return do_set_port_group(dp, compat_ptr(pg.ports), pg.n_ports, pg.group);
-}
-
-static int compat_get_port_group(struct datapath *dp, struct compat_odp_port_group __user *upg)
-{
-       struct compat_odp_port_group pg;
-
-       if (copy_from_user(&pg, upg, sizeof pg))
-               return -EFAULT;
-
-       return do_get_port_group(dp, compat_ptr(pg.ports), pg.n_ports,
-                                pg.group, &upg->n_ports);
-}
-
 static int compat_get_flow(struct odp_flow *flow, const struct compat_odp_flow __user *compat)
 {
        compat_uptr_t actions;
@@ -2020,7 +1939,6 @@ static int compat_execute(struct datapath *dp, const struct compat_odp_execute _
        compat_uptr_t data;
 
        if (!access_ok(VERIFY_READ, uexecute, sizeof(struct compat_odp_execute)) ||
-           __get_user(execute.in_port, &uexecute->in_port) ||
            __get_user(actions, &uexecute->actions) ||
            __get_user(execute.n_actions, &uexecute->n_actions) ||
            __get_user(data, &uexecute->data) ||
@@ -2083,14 +2001,6 @@ static long openvswitch_compat_ioctl(struct file *f, unsigned int cmd, unsigned
                err = compat_list_ports(dp, compat_ptr(argp));
                break;
 
-       case ODP_PORT_GROUP_SET32:
-               err = compat_set_port_group(dp, compat_ptr(argp));
-               break;
-
-       case ODP_PORT_GROUP_GET32:
-               err = compat_get_port_group(dp, compat_ptr(argp));
-               break;
-
        case ODP_FLOW_PUT32:
                err = compat_put_flow(dp, compat_ptr(argp));
                break;
@@ -2259,7 +2169,7 @@ ssize_t openvswitch_read(struct file *f, char __user *buf, size_t nbytes,
        }
 success:
        copy_bytes = tot_copy_bytes = min_t(size_t, skb->len, nbytes);
-       
+
        retval = 0;
        if (skb->ip_summed == CHECKSUM_PARTIAL) {
                if (copy_bytes == skb->len) {