static void discard_skb(uint32_t id);
/* 'skb' was received on 'in_port', a physical switch port between 0 and
- * OFPP_MAX. Process it according to 'chain'. */
-void fwd_port_input(struct sw_chain *chain, struct sk_buff *skb, int in_port)
+ * OFPP_MAX. Process it according to 'chain'. Returns 0 if successful, in
+ * which case 'skb' is destroyed, or -ESRCH if there is no matching flow, in
+ * which case 'skb' still belongs to the caller. */
+int run_flow_through_tables(struct sw_chain *chain, struct sk_buff *skb,
+ int in_port)
{
struct sw_flow_key key;
struct sw_flow *flow;
- flow_extract(skb, in_port, &key);
+ if (flow_extract(skb, in_port, &key)
+ && (chain->dp->flags & OFPC_FRAG_MASK) == OFPC_FRAG_DROP) {
+ /* Drop fragment. */
+ kfree_skb(skb);
+ return 0;
+ }
+
flow = chain_lookup(chain, &key);
if (likely(flow != NULL)) {
flow_used(flow, skb);
execute_actions(chain->dp, skb, &key,
flow->actions, flow->n_actions);
+ return 0;
} else {
+ return -ESRCH;
+ }
+}
+
+/* 'skb' was received on 'in_port', a physical switch port between 0 and
+ * OFPP_MAX. Process it according to 'chain', sending it up to the controller
+ * if no flow matches. Takes ownership of 'skb'. */
+void fwd_port_input(struct sw_chain *chain, struct sk_buff *skb, int in_port)
+{
+ if (run_flow_through_tables(chain, skb, in_port))
dp_output_control(chain->dp, skb, fwd_save_skb(skb),
chain->dp->miss_send_len,
OFPR_NO_MATCH);
- }
}
static int do_output(struct datapath *dp, struct sk_buff *skb, size_t max_len,
max_len = ntohs(a->arg.output.max_len);
} else {
if (!make_writable(&skb)) {
- printk("make_writable failed\n");
+ if (net_ratelimit())
+ printk("make_writable failed\n");
break;
}
skb = execute_setter(skb, eth_proto, key, a);
+ if (!skb) {
+ if (net_ratelimit())
+ printk("execute_setter lost skb\n");
+ return;
+ }
}
}
if (prev_port != -1)
static struct sk_buff *modify_vlan(struct sk_buff *skb,
const struct sw_flow_key *key, const struct ofp_action *a)
{
- uint16_t new_id = a->arg.vlan_id;
+ uint16_t new_id = ntohs(a->arg.vlan_id);
if (new_id != OFP_VLAN_NONE) {
if (key->dl_vlan != htons(OFP_VLAN_NONE)) {
/* Modify vlan id, but maintain other TCI values */
struct vlan_ethhdr *vh = vlan_eth_hdr(skb);
vh->h_vlan_TCI = (vh->h_vlan_TCI
- & ~(htons(VLAN_VID_MASK))) | htons(new_id);
+ & ~(htons(VLAN_VID_MASK))) | a->arg.vlan_id;
} else {
/* Add vlan header */
- skb = vlan_put_tag(skb, new_id);
+
+ /* xxx The vlan_put_tag function, doesn't seem to work
+ * xxx reliably when it attempts to use the hardware-accelerated
+ * xxx version. We'll directly use the software version
+ * xxx until the problem can be diagnosed.
+ */
+ skb = __vlan_put_tag(skb, new_id);
}
} else {
/* Remove an existing vlan header if it exists */
return 0;
}
+static int
+recv_echo_request(struct sw_chain *chain, const struct sender *sender,
+ const void *msg)
+{
+ return dp_send_echo_reply(chain->dp, sender, msg);
+}
+
+static int
+recv_echo_reply(struct sw_chain *chain, const struct sender *sender,
+ const void *msg)
+{
+ return 0;
+}
+
static int
add_flow(struct sw_chain *chain, const struct ofp_flow_mod *ofm)
{
const struct ofp_action *a = &ofm->actions[i];
if (a->type == htons(OFPAT_OUTPUT)
- && a->arg.output.port == htons(OFPP_TABLE)) {
+ && (a->arg.output.port == htons(OFPP_TABLE)
+ || a->arg.output.port == htons(OFPP_NONE))) {
/* xxx Send fancy new error message? */
goto error;
}
flow->init_time = jiffies;
flow->byte_count = 0;
flow->packet_count = 0;
- atomic_set(&flow->deleted, 0);
spin_lock_init(&flow->lock);
memcpy(flow->actions, ofm->actions, n_acts * sizeof *flow->actions);
sizeof (struct ofp_port_mod),
recv_port_mod,
},
+ [OFPT_ECHO_REQUEST] = {
+ sizeof (struct ofp_header),
+ recv_echo_request,
+ },
+ [OFPT_ECHO_REPLY] = {
+ sizeof (struct ofp_header),
+ recv_echo_reply,
+ },
};
const struct openflow_packet *pkt;
return skb;
}
+void fwd_discard_all(void)
+{
+ unsigned long int flags;
+ int i;
+
+ spin_lock_irqsave(&buffer_lock, flags);
+ for (i = 0; i < N_PKT_BUFFERS; i++) {
+ kfree_skb(buffers[i].skb);
+ buffers[i].skb = NULL;
+ }
+ spin_unlock_irqrestore(&buffer_lock, flags);
+}
+
static void discard_skb(uint32_t id)
{
unsigned long int flags;
void fwd_exit(void)
{
- int i;
-
- for (i = 0; i < N_PKT_BUFFERS; i++)
- kfree_skb(buffers[i].skb);
+ fwd_discard_all();
}
/* Utility functions. */
if (skb_shared(*pskb) || skb_cloned(*pskb))
goto copy_skb;
- return pskb_may_pull(*pskb, 64); /* FIXME? */
+ return pskb_may_pull(*pskb, 40); /* FIXME? */
copy_skb:
nskb = skb_copy(*pskb, GFP_ATOMIC);
git://git.onelab.eu / sliver-openvswitch.git / blobdiff