fedora core 6 1.2949 + vserver 2.2.0
[linux-2.6.git] / drivers / base / class.c
index 70be974..8bf2ca2 100644 (file)
  *
  */
 
-#include <linux/config.h>
 #include <linux/device.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/string.h>
+#include <linux/kdev_t.h>
+#include <linux/err.h>
+#include <linux/slab.h>
 #include "base.h"
 
+extern struct subsystem devices_subsys;
+
 #define to_class_attr(_attr) container_of(_attr, struct class_attribute, attr)
 #define to_class(obj) container_of(obj, struct class, subsys.kset.kobj)
 
@@ -25,7 +29,7 @@ class_attr_show(struct kobject * kobj, struct attribute * attr, char * buf)
 {
        struct class_attribute * class_attr = to_class_attr(attr);
        struct class * dc = to_class(kobj);
-       ssize_t ret = 0;
+       ssize_t ret = -EIO;
 
        if (class_attr->show)
                ret = class_attr->show(dc, buf);
@@ -38,7 +42,7 @@ class_attr_store(struct kobject * kobj, struct attribute * attr,
 {
        struct class_attribute * class_attr = to_class_attr(attr);
        struct class * dc = to_class(kobj);
-       ssize_t ret = 0;
+       ssize_t ret = -EIO;
 
        if (class_attr->store)
                ret = class_attr->store(dc, buf, count);
@@ -88,16 +92,17 @@ void class_remove_file(struct class * cls, const struct class_attribute * attr)
                sysfs_remove_file(&cls->subsys.kset.kobj, &attr->attr);
 }
 
-struct class * class_get(struct class * cls)
+static struct class *class_get(struct class *cls)
 {
        if (cls)
                return container_of(subsys_get(&cls->subsys), struct class, subsys);
        return NULL;
 }
 
-void class_put(struct class * cls)
+static void class_put(struct class * cls)
 {
-       subsys_put(&cls->subsys);
+       if (cls)
+               subsys_put(&cls->subsys);
 }
 
 
@@ -138,8 +143,10 @@ int class_register(struct class * cls)
        pr_debug("device class '%s': registering\n", cls->name);
 
        INIT_LIST_HEAD(&cls->children);
+       INIT_LIST_HEAD(&cls->devices);
        INIT_LIST_HEAD(&cls->interfaces);
-       error = kobject_set_name(&cls->subsys.kset.kobj, cls->name);
+       init_MUTEX(&cls->sem);
+       error = kobject_set_name(&cls->subsys.kset.kobj, "%s", cls->name);
        if (error)
                return error;
 
@@ -156,10 +163,85 @@ int class_register(struct class * cls)
 void class_unregister(struct class * cls)
 {
        pr_debug("device class '%s': unregistering\n", cls->name);
+       if (cls->virtual_dir)
+               kobject_unregister(cls->virtual_dir);
        remove_class_attrs(cls);
        subsystem_unregister(&cls->subsys);
 }
 
+static void class_create_release(struct class *cls)
+{
+       pr_debug("%s called for %s\n", __FUNCTION__, cls->name);
+       kfree(cls);
+}
+
+static void class_device_create_release(struct class_device *class_dev)
+{
+       pr_debug("%s called for %s\n", __FUNCTION__, class_dev->class_id);
+       kfree(class_dev);
+}
+
+/* needed to allow these devices to have parent class devices */
+static int class_device_create_uevent(struct class_device *class_dev,
+                                      char **envp, int num_envp,
+                                      char *buffer, int buffer_size)
+{
+       pr_debug("%s called for %s\n", __FUNCTION__, class_dev->class_id);
+       return 0;
+}
+
+/**
+ * class_create - create a struct class structure
+ * @owner: pointer to the module that is to "own" this struct class
+ * @name: pointer to a string for the name of this class.
+ *
+ * This is used to create a struct class pointer that can then be used
+ * in calls to class_device_create().
+ *
+ * Note, the pointer created here is to be destroyed when finished by
+ * making a call to class_destroy().
+ */
+struct class *class_create(struct module *owner, const char *name)
+{
+       struct class *cls;
+       int retval;
+
+       cls = kzalloc(sizeof(*cls), GFP_KERNEL);
+       if (!cls) {
+               retval = -ENOMEM;
+               goto error;
+       }
+
+       cls->name = name;
+       cls->owner = owner;
+       cls->class_release = class_create_release;
+       cls->release = class_device_create_release;
+
+       retval = class_register(cls);
+       if (retval)
+               goto error;
+
+       return cls;
+
+error:
+       kfree(cls);
+       return ERR_PTR(retval);
+}
+
+/**
+ * class_destroy - destroys a struct class structure
+ * @cls: pointer to the struct class that is to be destroyed
+ *
+ * Note, the pointer to be destroyed must have been created with a call
+ * to class_create().
+ */
+void class_destroy(struct class *cls)
+{
+       if ((cls == NULL) || (IS_ERR(cls)))
+               return;
+
+       class_unregister(cls);
+}
 
 /* Class Device Stuff */
 
@@ -179,33 +261,22 @@ void class_device_remove_file(struct class_device * class_dev,
                sysfs_remove_file(&class_dev->kobj, &attr->attr);
 }
 
-static int class_device_dev_link(struct class_device * class_dev)
-{
-       if (class_dev->dev)
-               return sysfs_create_link(&class_dev->kobj,
-                                        &class_dev->dev->kobj, "device");
-       return 0;
-}
-
-static void class_device_dev_unlink(struct class_device * class_dev)
-{
-       sysfs_remove_link(&class_dev->kobj, "device");
-}
-
-static int class_device_driver_link(struct class_device * class_dev)
+int class_device_create_bin_file(struct class_device *class_dev,
+                                struct bin_attribute *attr)
 {
-       if ((class_dev->dev) && (class_dev->dev->driver))
-               return sysfs_create_link(&class_dev->kobj,
-                                        &class_dev->dev->driver->kobj, "driver");
-       return 0;
+       int error = -EINVAL;
+       if (class_dev)
+               error = sysfs_create_bin_file(&class_dev->kobj, attr);
+       return error;
 }
 
-static void class_device_driver_unlink(struct class_device * class_dev)
+void class_device_remove_bin_file(struct class_device *class_dev,
+                                 struct bin_attribute *attr)
 {
-       sysfs_remove_link(&class_dev->kobj, "driver");
+       if (class_dev)
+               sysfs_remove_bin_file(&class_dev->kobj, attr);
 }
 
-
 static ssize_t
 class_device_attr_show(struct kobject * kobj, struct attribute * attr,
                       char * buf)
@@ -244,10 +315,15 @@ static void class_dev_release(struct kobject * kobj)
 
        pr_debug("device class '%s': release.\n", cd->class_id);
 
-       if (cls->release)
+       kfree(cd->devt_attr);
+       cd->devt_attr = NULL;
+
+       if (cd->release)
+               cd->release(cd);
+       else if (cls->release)
                cls->release(cd);
        else {
-               printk(KERN_ERR "Device class '%s' does not have a release() function, "
+               printk(KERN_ERR "Class Device '%s' does not have a release() function, "
                        "it is broken and must be fixed.\n",
                        cd->class_id);
                WARN_ON(1);
@@ -259,7 +335,7 @@ static struct kobj_type ktype_class_device = {
        .release        = class_dev_release,
 };
 
-static int class_hotplug_filter(struct kset *kset, struct kobject *kobj)
+static int class_uevent_filter(struct kset *kset, struct kobject *kobj)
 {
        struct kobj_type *ktype = get_ktype(kobj);
 
@@ -271,40 +347,153 @@ static int class_hotplug_filter(struct kset *kset, struct kobject *kobj)
        return 0;
 }
 
-static char *class_hotplug_name(struct kset *kset, struct kobject *kobj)
+static const char *class_uevent_name(struct kset *kset, struct kobject *kobj)
 {
        struct class_device *class_dev = to_class_dev(kobj);
 
        return class_dev->class->name;
 }
 
-static int class_hotplug(struct kset *kset, struct kobject *kobj, char **envp,
+#ifdef CONFIG_SYSFS_DEPRECATED
+char *make_class_name(const char *name, struct kobject *kobj)
+{
+       char *class_name;
+       int size;
+
+       size = strlen(name) + strlen(kobject_name(kobj)) + 2;
+
+       class_name = kmalloc(size, GFP_KERNEL);
+       if (!class_name)
+               return ERR_PTR(-ENOMEM);
+
+       strcpy(class_name, name);
+       strcat(class_name, ":");
+       strcat(class_name, kobject_name(kobj));
+       return class_name;
+}
+
+static int deprecated_class_uevent(char **envp, int num_envp, int *cur_index,
+                                  char *buffer, int buffer_size,
+                                  int *cur_len,
+                                  struct class_device *class_dev)
+{
+       struct device *dev = class_dev->dev;
+       char *path;
+
+       if (!dev)
+               return 0;
+
+       /* add device, backing this class device (deprecated) */
+       path = kobject_get_path(&dev->kobj, GFP_KERNEL);
+
+       add_uevent_var(envp, num_envp, cur_index, buffer, buffer_size,
+                      cur_len, "PHYSDEVPATH=%s", path);
+       kfree(path);
+
+       if (dev->bus)
+               add_uevent_var(envp, num_envp, cur_index,
+                              buffer, buffer_size, cur_len,
+                              "PHYSDEVBUS=%s", dev->bus->name);
+
+       if (dev->driver)
+               add_uevent_var(envp, num_envp, cur_index,
+                              buffer, buffer_size, cur_len,
+                              "PHYSDEVDRIVER=%s", dev->driver->name);
+       return 0;
+}
+
+static int make_deprecated_class_device_links(struct class_device *class_dev)
+{
+       char *class_name;
+       int error;
+
+       if (!class_dev->dev)
+               return 0;
+
+       class_name = make_class_name(class_dev->class->name, &class_dev->kobj);
+       error = sysfs_create_link(&class_dev->dev->kobj, &class_dev->kobj,
+                                 class_name);
+       kfree(class_name);
+       return error;
+}
+
+static void remove_deprecated_class_device_links(struct class_device *class_dev)
+{
+       char *class_name;
+
+       if (!class_dev->dev)
+               return;
+
+       class_name = make_class_name(class_dev->class->name, &class_dev->kobj);
+       sysfs_remove_link(&class_dev->dev->kobj, class_name);
+       kfree(class_name);
+}
+#else
+static inline int deprecated_class_uevent(char **envp, int num_envp,
+                                         int *cur_index, char *buffer,
+                                         int buffer_size, int *cur_len,
+                                         struct class_device *class_dev)
+{ return 0; }
+static inline int make_deprecated_class_device_links(struct class_device *cd)
+{ return 0; }
+static void remove_deprecated_class_device_links(struct class_device *cd)
+{ }
+#endif
+
+static int class_uevent(struct kset *kset, struct kobject *kobj, char **envp,
                         int num_envp, char *buffer, int buffer_size)
 {
        struct class_device *class_dev = to_class_dev(kobj);
+       int i = 0;
+       int length = 0;
        int retval = 0;
 
        pr_debug("%s - name = %s\n", __FUNCTION__, class_dev->class_id);
-       if (class_dev->class->hotplug) {
-               /* have the bus specific function add its stuff */
-               retval = class_dev->class->hotplug (class_dev, envp, num_envp,
-                                                   buffer, buffer_size);
-                       if (retval) {
-                       pr_debug ("%s - hotplug() returned %d\n",
-                                 __FUNCTION__, retval);
-               }
+
+       deprecated_class_uevent(envp, num_envp, &i, buffer, buffer_size,
+                               &length, class_dev);
+
+       if (MAJOR(class_dev->devt)) {
+               add_uevent_var(envp, num_envp, &i,
+                              buffer, buffer_size, &length,
+                              "MAJOR=%u", MAJOR(class_dev->devt));
+
+               add_uevent_var(envp, num_envp, &i,
+                              buffer, buffer_size, &length,
+                              "MINOR=%u", MINOR(class_dev->devt));
+       }
+
+       /* terminate, set to next free slot, shrink available space */
+       envp[i] = NULL;
+       envp = &envp[i];
+       num_envp -= i;
+       buffer = &buffer[length];
+       buffer_size -= length;
+
+       if (class_dev->uevent) {
+               /* have the class device specific function add its stuff */
+               retval = class_dev->uevent(class_dev, envp, num_envp,
+                                           buffer, buffer_size);
+               if (retval)
+                       pr_debug("class_dev->uevent() returned %d\n", retval);
+       } else if (class_dev->class->uevent) {
+               /* have the class specific function add its stuff */
+               retval = class_dev->class->uevent(class_dev, envp, num_envp,
+                                                  buffer, buffer_size);
+               if (retval)
+                       pr_debug("class->uevent() returned %d\n", retval);
        }
 
        return retval;
 }
 
-static struct kset_hotplug_ops class_hotplug_ops = {
-       .filter =       class_hotplug_filter,
-       .name =         class_hotplug_name,
-       .hotplug =      class_hotplug,
+static struct kset_uevent_ops class_uevent_ops = {
+       .filter =       class_uevent_filter,
+       .name =         class_uevent_name,
+       .uevent =       class_uevent,
 };
 
-static decl_subsys(class_obj, &ktype_class_device, &class_hotplug_ops);
+static decl_subsys(class_obj, &ktype_class_device, &class_uevent_ops);
 
 
 static int class_device_add_attrs(struct class_device * cd)
@@ -340,6 +529,47 @@ static void class_device_remove_attrs(struct class_device * cd)
        }
 }
 
+static int class_device_add_groups(struct class_device * cd)
+{
+       int i;
+       int error = 0;
+
+       if (cd->groups) {
+               for (i = 0; cd->groups[i]; i++) {
+                       error = sysfs_create_group(&cd->kobj, cd->groups[i]);
+                       if (error) {
+                               while (--i >= 0)
+                                       sysfs_remove_group(&cd->kobj, cd->groups[i]);
+                               goto out;
+                       }
+               }
+       }
+out:
+       return error;
+}
+
+static void class_device_remove_groups(struct class_device * cd)
+{
+       int i;
+       if (cd->groups) {
+               for (i = 0; cd->groups[i]; i++) {
+                       sysfs_remove_group(&cd->kobj, cd->groups[i]);
+               }
+       }
+}
+
+static ssize_t show_dev(struct class_device *class_dev, char *buf)
+{
+       return print_dev_t(buf, class_dev->devt);
+}
+
+static ssize_t store_uevent(struct class_device *class_dev,
+                           const char *buf, size_t count)
+{
+       kobject_uevent(&class_dev->kobj, KOBJ_ADD);
+       return count;
+}
+
 void class_device_initialize(struct class_device *class_dev)
 {
        kobj_set_kset_s(class_dev, class_obj_subsys);
@@ -349,48 +579,125 @@ void class_device_initialize(struct class_device *class_dev)
 
 int class_device_add(struct class_device *class_dev)
 {
-       struct class * parent = NULL;
-       struct class_interface * class_intf;
-       int error;
+       struct class *parent_class = NULL;
+       struct class_device *parent_class_dev = NULL;
+       struct class_interface *class_intf;
+       int error = -EINVAL;
 
        class_dev = class_device_get(class_dev);
        if (!class_dev)
                return -EINVAL;
 
-       if (!strlen(class_dev->class_id)) {
-               error = -EINVAL;
-               goto register_done;
-       }
+       if (!strlen(class_dev->class_id))
+               goto out1;
+
+       parent_class = class_get(class_dev->class);
+       if (!parent_class)
+               goto out1;
 
-       parent = class_get(class_dev->class);
+       parent_class_dev = class_device_get(class_dev->parent);
 
        pr_debug("CLASS: registering class device: ID = '%s'\n",
                 class_dev->class_id);
 
        /* first, register with generic layer. */
-       kobject_set_name(&class_dev->kobj, class_dev->class_id);
-       if (parent)
-               class_dev->kobj.parent = &parent->subsys.kset.kobj;
-
-       if ((error = kobject_add(&class_dev->kobj)))
-               goto register_done;
-
-       /* now take care of our own registration */
-       if (parent) {
-               down_write(&parent->subsys.rwsem);
-               list_add_tail(&class_dev->node, &parent->children);
-               list_for_each_entry(class_intf, &parent->interfaces, node)
-                       if (class_intf->add)
-                               class_intf->add(class_dev);
-               up_write(&parent->subsys.rwsem);
+       error = kobject_set_name(&class_dev->kobj, "%s", class_dev->class_id);
+       if (error)
+               goto out2;
+
+       if (parent_class_dev)
+               class_dev->kobj.parent = &parent_class_dev->kobj;
+       else
+               class_dev->kobj.parent = &parent_class->subsys.kset.kobj;
+
+       error = kobject_add(&class_dev->kobj);
+       if (error)
+               goto out2;
+
+       /* add the needed attributes to this device */
+       error = sysfs_create_link(&class_dev->kobj,
+                                 &parent_class->subsys.kset.kobj, "subsystem");
+       if (error)
+               goto out3;
+       class_dev->uevent_attr.attr.name = "uevent";
+       class_dev->uevent_attr.attr.mode = S_IWUSR;
+       class_dev->uevent_attr.attr.owner = parent_class->owner;
+       class_dev->uevent_attr.store = store_uevent;
+       error = class_device_create_file(class_dev, &class_dev->uevent_attr);
+       if (error)
+               goto out3;
+
+       if (MAJOR(class_dev->devt)) {
+               struct class_device_attribute *attr;
+               attr = kzalloc(sizeof(*attr), GFP_KERNEL);
+               if (!attr) {
+                       error = -ENOMEM;
+                       goto out4;
+               }
+               attr->attr.name = "dev";
+               attr->attr.mode = S_IRUGO;
+               attr->attr.owner = parent_class->owner;
+               attr->show = show_dev;
+               error = class_device_create_file(class_dev, attr);
+               if (error) {
+                       kfree(attr);
+                       goto out4;
+               }
+
+               class_dev->devt_attr = attr;
+       }
+
+       error = class_device_add_attrs(class_dev);
+       if (error)
+               goto out5;
+
+       if (class_dev->dev) {
+               error = sysfs_create_link(&class_dev->kobj,
+                                         &class_dev->dev->kobj, "device");
+               if (error)
+                       goto out6;
        }
-       class_device_add_attrs(class_dev);
-       class_device_dev_link(class_dev);
-       class_device_driver_link(class_dev);
 
- register_done:
-       if (error && parent)
-               class_put(parent);
+       error = class_device_add_groups(class_dev);
+       if (error)
+               goto out7;
+
+       error = make_deprecated_class_device_links(class_dev);
+       if (error)
+               goto out8;
+
+       kobject_uevent(&class_dev->kobj, KOBJ_ADD);
+
+       /* notify any interfaces this device is now here */
+       down(&parent_class->sem);
+       list_add_tail(&class_dev->node, &parent_class->children);
+       list_for_each_entry(class_intf, &parent_class->interfaces, node) {
+               if (class_intf->add)
+                       class_intf->add(class_dev, class_intf);
+       }
+       up(&parent_class->sem);
+
+       goto out1;
+
+ out8:
+       class_device_remove_groups(class_dev);
+ out7:
+       if (class_dev->dev)
+               sysfs_remove_link(&class_dev->kobj, "device");
+ out6:
+       class_device_remove_attrs(class_dev);
+ out5:
+       if (class_dev->devt_attr)
+               class_device_remove_file(class_dev, class_dev->devt_attr);
+ out4:
+       class_device_remove_file(class_dev, &class_dev->uevent_attr);
+ out3:
+       kobject_del(&class_dev->kobj);
+ out2:
+       if(parent_class_dev)
+               class_device_put(parent_class_dev);
+       class_put(parent_class);
+ out1:
        class_device_put(class_dev);
        return error;
 }
@@ -401,28 +708,99 @@ int class_device_register(struct class_device *class_dev)
        return class_device_add(class_dev);
 }
 
+/**
+ * class_device_create - creates a class device and registers it with sysfs
+ * @cls: pointer to the struct class that this device should be registered to.
+ * @parent: pointer to the parent struct class_device of this new device, if any.
+ * @devt: the dev_t for the char device to be added.
+ * @device: a pointer to a struct device that is assiociated with this class device.
+ * @fmt: string for the class device's name
+ *
+ * This function can be used by char device classes.  A struct
+ * class_device will be created in sysfs, registered to the specified
+ * class.
+ * A "dev" file will be created, showing the dev_t for the device, if
+ * the dev_t is not 0,0.
+ * If a pointer to a parent struct class_device is passed in, the newly
+ * created struct class_device will be a child of that device in sysfs.
+ * The pointer to the struct class_device will be returned from the
+ * call.  Any further sysfs files that might be required can be created
+ * using this pointer.
+ *
+ * Note: the struct class passed to this function must have previously
+ * been created with a call to class_create().
+ */
+struct class_device *class_device_create(struct class *cls,
+                                        struct class_device *parent,
+                                        dev_t devt,
+                                        struct device *device,
+                                        const char *fmt, ...)
+{
+       va_list args;
+       struct class_device *class_dev = NULL;
+       int retval = -ENODEV;
+
+       if (cls == NULL || IS_ERR(cls))
+               goto error;
+
+       class_dev = kzalloc(sizeof(*class_dev), GFP_KERNEL);
+       if (!class_dev) {
+               retval = -ENOMEM;
+               goto error;
+       }
+
+       class_dev->devt = devt;
+       class_dev->dev = device;
+       class_dev->class = cls;
+       class_dev->parent = parent;
+       class_dev->release = class_device_create_release;
+       class_dev->uevent = class_device_create_uevent;
+
+       va_start(args, fmt);
+       vsnprintf(class_dev->class_id, BUS_ID_SIZE, fmt, args);
+       va_end(args);
+       retval = class_device_register(class_dev);
+       if (retval)
+               goto error;
+
+       return class_dev;
+
+error:
+       kfree(class_dev);
+       return ERR_PTR(retval);
+}
+
 void class_device_del(struct class_device *class_dev)
 {
-       struct class * parent = class_dev->class;
-       struct class_interface * class_intf;
+       struct class *parent_class = class_dev->class;
+       struct class_device *parent_device = class_dev->parent;
+       struct class_interface *class_intf;
 
-       if (parent) {
-               down_write(&parent->subsys.rwsem);
+       if (parent_class) {
+               down(&parent_class->sem);
                list_del_init(&class_dev->node);
-               list_for_each_entry(class_intf, &parent->interfaces, node)
+               list_for_each_entry(class_intf, &parent_class->interfaces, node)
                        if (class_intf->remove)
-                               class_intf->remove(class_dev);
-               up_write(&parent->subsys.rwsem);
+                               class_intf->remove(class_dev, class_intf);
+               up(&parent_class->sem);
        }
 
-       class_device_dev_unlink(class_dev);
-       class_device_driver_unlink(class_dev);
+       if (class_dev->dev) {
+               remove_deprecated_class_device_links(class_dev);
+               sysfs_remove_link(&class_dev->kobj, "device");
+       }
+       sysfs_remove_link(&class_dev->kobj, "subsystem");
+       class_device_remove_file(class_dev, &class_dev->uevent_attr);
+       if (class_dev->devt_attr)
+               class_device_remove_file(class_dev, class_dev->devt_attr);
        class_device_remove_attrs(class_dev);
+       class_device_remove_groups(class_dev);
 
+       kobject_uevent(&class_dev->kobj, KOBJ_REMOVE);
        kobject_del(&class_dev->kobj);
 
-       if (parent)
-               class_put(parent);
+       class_device_put(parent_device);
+       class_put(parent_class);
 }
 
 void class_device_unregister(struct class_device *class_dev)
@@ -433,9 +811,36 @@ void class_device_unregister(struct class_device *class_dev)
        class_device_put(class_dev);
 }
 
+/**
+ * class_device_destroy - removes a class device that was created with class_device_create()
+ * @cls: the pointer to the struct class that this device was registered * with.
+ * @devt: the dev_t of the device that was previously registered.
+ *
+ * This call unregisters and cleans up a class device that was created with a
+ * call to class_device_create()
+ */
+void class_device_destroy(struct class *cls, dev_t devt)
+{
+       struct class_device *class_dev = NULL;
+       struct class_device *class_dev_tmp;
+
+       down(&cls->sem);
+       list_for_each_entry(class_dev_tmp, &cls->children, node) {
+               if (class_dev_tmp->devt == devt) {
+                       class_dev = class_dev_tmp;
+                       break;
+               }
+       }
+       up(&cls->sem);
+
+       if (class_dev)
+               class_device_unregister(class_dev);
+}
+
 int class_device_rename(struct class_device *class_dev, char *new_name)
 {
        int error = 0;
+       char *old_class_name = NULL, *new_class_name = NULL;
 
        class_dev = class_device_get(class_dev);
        if (!class_dev)
@@ -444,12 +849,30 @@ int class_device_rename(struct class_device *class_dev, char *new_name)
        pr_debug("CLASS: renaming '%s' to '%s'\n", class_dev->class_id,
                 new_name);
 
+#ifdef CONFIG_SYSFS_DEPRECATED
+       if (class_dev->dev)
+               old_class_name = make_class_name(class_dev->class->name,
+                                                &class_dev->kobj);
+#endif
+
        strlcpy(class_dev->class_id, new_name, KOBJ_NAME_LEN);
 
        error = kobject_rename(&class_dev->kobj, new_name);
 
+#ifdef CONFIG_SYSFS_DEPRECATED
+       if (class_dev->dev) {
+               new_class_name = make_class_name(class_dev->class->name,
+                                                &class_dev->kobj);
+               sysfs_create_link(&class_dev->dev->kobj, &class_dev->kobj,
+                                 new_class_name);
+               sysfs_remove_link(&class_dev->dev->kobj, old_class_name);
+       }
+#endif
        class_device_put(class_dev);
 
+       kfree(old_class_name);
+       kfree(new_class_name);
+
        return error;
 }
 
@@ -462,14 +885,16 @@ struct class_device * class_device_get(struct class_device *class_dev)
 
 void class_device_put(struct class_device *class_dev)
 {
-       kobject_put(&class_dev->kobj);
+       if (class_dev)
+               kobject_put(&class_dev->kobj);
 }
 
 
 int class_interface_register(struct class_interface *class_intf)
 {
-       struct class * parent;
-       struct class_device * class_dev;
+       struct class *parent;
+       struct class_device *class_dev;
+       struct device *dev;
 
        if (!class_intf || !class_intf->class)
                return -ENODEV;
@@ -478,14 +903,17 @@ int class_interface_register(struct class_interface *class_intf)
        if (!parent)
                return -EINVAL;
 
-       down_write(&parent->subsys.rwsem);
+       down(&parent->sem);
        list_add_tail(&class_intf->node, &parent->interfaces);
-
        if (class_intf->add) {
                list_for_each_entry(class_dev, &parent->children, node)
-                       class_intf->add(class_dev);
+                       class_intf->add(class_dev, class_intf);
        }
-       up_write(&parent->subsys.rwsem);
+       if (class_intf->add_dev) {
+               list_for_each_entry(dev, &parent->devices, node)
+                       class_intf->add_dev(dev, class_intf);
+       }
+       up(&parent->sem);
 
        return 0;
 }
@@ -494,24 +922,26 @@ void class_interface_unregister(struct class_interface *class_intf)
 {
        struct class * parent = class_intf->class;
        struct class_device *class_dev;
+       struct device *dev;
 
        if (!parent)
                return;
 
-       down_write(&parent->subsys.rwsem);
+       down(&parent->sem);
        list_del_init(&class_intf->node);
-
        if (class_intf->remove) {
                list_for_each_entry(class_dev, &parent->children, node)
-                       class_intf->remove(class_dev);
+                       class_intf->remove(class_dev, class_intf);
+       }
+       if (class_intf->remove_dev) {
+               list_for_each_entry(dev, &parent->devices, node)
+                       class_intf->remove_dev(dev, class_intf);
        }
-       up_write(&parent->subsys.rwsem);
+       up(&parent->sem);
 
        class_put(parent);
 }
 
-
-
 int __init classes_init(void)
 {
        int retval;
@@ -528,22 +958,26 @@ int __init classes_init(void)
        return 0;
 }
 
-EXPORT_SYMBOL(class_create_file);
-EXPORT_SYMBOL(class_remove_file);
-EXPORT_SYMBOL(class_register);
-EXPORT_SYMBOL(class_unregister);
-EXPORT_SYMBOL(class_get);
-EXPORT_SYMBOL(class_put);
-
-EXPORT_SYMBOL(class_device_register);
-EXPORT_SYMBOL(class_device_unregister);
-EXPORT_SYMBOL(class_device_initialize);
-EXPORT_SYMBOL(class_device_add);
-EXPORT_SYMBOL(class_device_del);
-EXPORT_SYMBOL(class_device_get);
-EXPORT_SYMBOL(class_device_put);
-EXPORT_SYMBOL(class_device_create_file);
-EXPORT_SYMBOL(class_device_remove_file);
-
-EXPORT_SYMBOL(class_interface_register);
-EXPORT_SYMBOL(class_interface_unregister);
+EXPORT_SYMBOL_GPL(class_create_file);
+EXPORT_SYMBOL_GPL(class_remove_file);
+EXPORT_SYMBOL_GPL(class_register);
+EXPORT_SYMBOL_GPL(class_unregister);
+EXPORT_SYMBOL_GPL(class_create);
+EXPORT_SYMBOL_GPL(class_destroy);
+
+EXPORT_SYMBOL_GPL(class_device_register);
+EXPORT_SYMBOL_GPL(class_device_unregister);
+EXPORT_SYMBOL_GPL(class_device_initialize);
+EXPORT_SYMBOL_GPL(class_device_add);
+EXPORT_SYMBOL_GPL(class_device_del);
+EXPORT_SYMBOL_GPL(class_device_get);
+EXPORT_SYMBOL_GPL(class_device_put);
+EXPORT_SYMBOL_GPL(class_device_create);
+EXPORT_SYMBOL_GPL(class_device_destroy);
+EXPORT_SYMBOL_GPL(class_device_create_file);
+EXPORT_SYMBOL_GPL(class_device_remove_file);
+EXPORT_SYMBOL_GPL(class_device_create_bin_file);
+EXPORT_SYMBOL_GPL(class_device_remove_bin_file);
+
+EXPORT_SYMBOL_GPL(class_interface_register);
+EXPORT_SYMBOL_GPL(class_interface_unregister);