linux 2.6.16.38 w/ vs2.0.3-rc1
[linux-2.6.git] / drivers / char / ipmi / ipmi_si_intf.c
index 8a1fd40..fd63716 100644 (file)
@@ -51,7 +51,9 @@
 #include <linux/list.h>
 #include <linux/pci.h>
 #include <linux/ioport.h>
-#include <linux/irq.h>
+#include <linux/notifier.h>
+#include <linux/kthread.h>
+#include <asm/irq.h>
 #ifdef CONFIG_HIGH_RES_TIMERS
 #include <linux/hrtime.h>
 # if defined(schedule_next_int)
 # endif
 static inline void add_usec_to_timer(struct timer_list *t, long v)
 {
-       t->sub_expires += nsec_to_arch_cycle(v * 1000);
-       while (t->sub_expires >= arch_cycles_per_jiffy)
+       t->arch_cycle_expires += nsec_to_arch_cycle(v * 1000);
+       while (t->arch_cycle_expires >= arch_cycles_per_jiffy)
        {
                t->expires++;
-               t->sub_expires -= arch_cycles_per_jiffy;
+               t->arch_cycle_expires -= arch_cycles_per_jiffy;
        }
 }
 #endif
@@ -75,8 +77,7 @@ static inline void add_usec_to_timer(struct timer_list *t, long v)
 #include <asm/io.h>
 #include "ipmi_si_sm.h"
 #include <linux/init.h>
-
-#define IPMI_SI_VERSION "v31"
+#include <linux/dmi.h>
 
 /* Measure times between events in the driver. */
 #undef DEBUG_TIMING
@@ -100,12 +101,33 @@ enum si_intf_state {
        /* FIXME - add watchdog stuff. */
 };
 
+/* Some BT-specific defines we need here. */
+#define IPMI_BT_INTMASK_REG            2
+#define IPMI_BT_INTMASK_CLEAR_IRQ_BIT  2
+#define IPMI_BT_INTMASK_ENABLE_IRQ_BIT 1
+
 enum si_type {
     SI_KCS, SI_SMIC, SI_BT
 };
 
+struct ipmi_device_id {
+       unsigned char device_id;
+       unsigned char device_revision;
+       unsigned char firmware_revision_1;
+       unsigned char firmware_revision_2;
+       unsigned char ipmi_version;
+       unsigned char additional_device_support;
+       unsigned char manufacturer_id[3];
+       unsigned char product_id[2];
+       unsigned char aux_firmware_revision[4];
+} __attribute__((packed));
+
+#define ipmi_version_major(v) ((v)->ipmi_version & 0xf)
+#define ipmi_version_minor(v) ((v)->ipmi_version >> 4)
+
 struct smi_info
 {
+       int                    intf_num;
        ipmi_smi_t             intf;
        struct si_sm_data      *si_sm;
        struct si_sm_handlers  *handlers;
@@ -126,12 +148,24 @@ struct smi_info
        void (*irq_cleanup)(struct smi_info *info);
        unsigned int io_size;
 
+       /* Per-OEM handler, called from handle_flags().
+          Returns 1 when handle_flags() needs to be re-run
+          or 0 indicating it set si_state itself.
+       */
+       int (*oem_data_avail_handler)(struct smi_info *smi_info);
+
        /* Flags from the last GET_MSG_FLAGS command, used when an ATTN
           is set to hold the flags until we are done handling everything
           from the flags. */
 #define RECEIVE_MSG_AVAIL      0x01
 #define EVENT_MSG_BUFFER_FULL  0x02
 #define WDT_PRE_TIMEOUT_INT    0x08
+#define OEM0_DATA_AVAIL     0x20
+#define OEM1_DATA_AVAIL     0x40
+#define OEM2_DATA_AVAIL     0x80
+#define OEM_DATA_AVAIL      (OEM0_DATA_AVAIL | \
+                             OEM1_DATA_AVAIL | \
+                             OEM2_DATA_AVAIL)
        unsigned char       msg_flags;
 
        /* If set to true, this will request events the next time the
@@ -146,6 +180,11 @@ struct smi_info
        /* The I/O port of an SI interface. */
        int                 port;
 
+       /* The space between start addresses of the two ports.  For
+          instance, if the first port is 0xca2 and the spacing is 4, then
+          the second port is 0xca6. */
+       unsigned int        spacing;
+
        /* zero if no irq; */
        int                 irq;
 
@@ -156,8 +195,7 @@ struct smi_info
        unsigned long       last_timeout_jiffies;
 
        /* Used to gracefully stop the timer without race conditions. */
-       volatile int        stop_operation;
-       volatile int        timer_stopped;
+       atomic_t            stop_operation;
 
        /* The driver will disable interrupts when it gets into a
           situation where it cannot handle messages due to lack of
@@ -165,11 +203,10 @@ struct smi_info
           interrupts. */
        int interrupt_disabled;
 
-       unsigned char ipmi_si_dev_rev;
-       unsigned char ipmi_si_fw_rev_major;
-       unsigned char ipmi_si_fw_rev_minor;
-       unsigned char ipmi_version_major;
-       unsigned char ipmi_version_minor;
+       struct ipmi_device_id device_id;
+
+       /* Slave address, could be reported from DMI. */
+       unsigned char slave_addr;
 
        /* Counters and things for the proc filesystem. */
        spinlock_t count_lock;
@@ -185,8 +222,16 @@ struct smi_info
        unsigned long events;
        unsigned long watchdog_pretimeouts;
        unsigned long incoming_messages;
+
+        struct task_struct *thread;
 };
 
+static struct notifier_block *xaction_notifier_list;
+static int register_xaction_notifier(struct notifier_block * nb)
+{
+       return notifier_chain_register(&xaction_notifier_list, nb);
+}
+
 static void si_restart_short_timer(struct smi_info *smi_info);
 
 static void deliver_recv_msg(struct smi_info *smi_info,
@@ -232,7 +277,7 @@ static enum si_sm_result start_next_msg(struct smi_info *smi_info)
                entry = smi_info->xmit_msgs.next;
        }
 
-       if (!entry) {
+       if (! entry) {
                smi_info->curr_msg = NULL;
                rv = SI_SM_IDLE;
        } else {
@@ -246,6 +291,11 @@ static enum si_sm_result start_next_msg(struct smi_info *smi_info)
                do_gettimeofday(&t);
                printk("**Start2: %d.%9.9d\n", t.tv_sec, t.tv_usec);
 #endif
+               err = notifier_call_chain(&xaction_notifier_list, 0, smi_info);
+               if (err & NOTIFY_STOP_MASK) {
+                       rv = SI_SM_CALL_WITHOUT_DELAY;
+                       goto out;
+               }
                err = smi_info->handlers->start_transaction(
                        smi_info->si_sm,
                        smi_info->curr_msg->data,
@@ -256,6 +306,7 @@ static enum si_sm_result start_next_msg(struct smi_info *smi_info)
 
                rv = SI_SM_CALL_WITHOUT_DELAY;
        }
+       out:
        spin_unlock(&(smi_info->msg_lock));
 
        return rv;
@@ -293,7 +344,7 @@ static void start_clear_flags(struct smi_info *smi_info)
    memory, we will re-enable the interrupt. */
 static inline void disable_si_irq(struct smi_info *smi_info)
 {
-       if ((smi_info->irq) && (!smi_info->interrupt_disabled)) {
+       if ((smi_info->irq) && (! smi_info->interrupt_disabled)) {
                disable_irq_nosync(smi_info->irq);
                smi_info->interrupt_disabled = 1;
        }
@@ -309,6 +360,7 @@ static inline void enable_si_irq(struct smi_info *smi_info)
 
 static void handle_flags(struct smi_info *smi_info)
 {
+ retry:
        if (smi_info->msg_flags & WDT_PRE_TIMEOUT_INT) {
                /* Watchdog pre-timeout */
                spin_lock(&smi_info->count_lock);
@@ -323,7 +375,7 @@ static void handle_flags(struct smi_info *smi_info)
        } else if (smi_info->msg_flags & RECEIVE_MSG_AVAIL) {
                /* Messages available. */
                smi_info->curr_msg = ipmi_alloc_smi_msg();
-               if (!smi_info->curr_msg) {
+               if (! smi_info->curr_msg) {
                        disable_si_irq(smi_info);
                        smi_info->si_state = SI_NORMAL;
                        return;
@@ -342,7 +394,7 @@ static void handle_flags(struct smi_info *smi_info)
        } else if (smi_info->msg_flags & EVENT_MSG_BUFFER_FULL) {
                /* Events available. */
                smi_info->curr_msg = ipmi_alloc_smi_msg();
-               if (!smi_info->curr_msg) {
+               if (! smi_info->curr_msg) {
                        disable_si_irq(smi_info);
                        smi_info->si_state = SI_NORMAL;
                        return;
@@ -358,6 +410,10 @@ static void handle_flags(struct smi_info *smi_info)
                        smi_info->curr_msg->data,
                        smi_info->curr_msg->data_size);
                smi_info->si_state = SI_GETTING_EVENTS;
+       } else if (smi_info->msg_flags & OEM_DATA_AVAIL) {
+               if (smi_info->oem_data_avail_handler)
+                       if (smi_info->oem_data_avail_handler(smi_info))
+                               goto retry;
        } else {
                smi_info->si_state = SI_NORMAL;
        }
@@ -374,7 +430,7 @@ static void handle_transaction_done(struct smi_info *smi_info)
 #endif
        switch (smi_info->si_state) {
        case SI_NORMAL:
-               if (!smi_info->curr_msg)
+               if (! smi_info->curr_msg)
                        break;
 
                smi_info->curr_msg->rsp_size
@@ -402,7 +458,7 @@ static void handle_transaction_done(struct smi_info *smi_info)
                        /* Error fetching flags, just give up for
                           now. */
                        smi_info->si_state = SI_NORMAL;
-               } else if (len < 3) {
+               } else if (len < 4) {
                        /* Hmm, no flags.  That's technically illegal, but
                           don't use uninitialized data. */
                        smi_info->si_state = SI_NORMAL;
@@ -452,14 +508,20 @@ static void handle_transaction_done(struct smi_info *smi_info)
 
                        /* Take off the event flag. */
                        smi_info->msg_flags &= ~EVENT_MSG_BUFFER_FULL;
+                       handle_flags(smi_info);
                } else {
                        spin_lock(&smi_info->count_lock);
                        smi_info->events++;
                        spin_unlock(&smi_info->count_lock);
 
+                       /* Do this before we deliver the message
+                          because delivering the message releases the
+                          lock and something else can mess with the
+                          state. */
+                       handle_flags(smi_info);
+
                        deliver_recv_msg(smi_info, msg);
                }
-               handle_flags(smi_info);
                break;
        }
 
@@ -482,14 +544,20 @@ static void handle_transaction_done(struct smi_info *smi_info)
 
                        /* Take off the msg flag. */
                        smi_info->msg_flags &= ~RECEIVE_MSG_AVAIL;
+                       handle_flags(smi_info);
                } else {
                        spin_lock(&smi_info->count_lock);
                        smi_info->incoming_messages++;
                        spin_unlock(&smi_info->count_lock);
 
+                       /* Do this before we deliver the message
+                          because delivering the message releases the
+                          lock and something else can mess with the
+                          state. */
+                       handle_flags(smi_info);
+
                        deliver_recv_msg(smi_info, msg);
                }
-               handle_flags(smi_info);
                break;
        }
 
@@ -568,6 +636,9 @@ static enum si_sm_result smi_event_handler(struct smi_info *smi_info,
                smi_info->hosed_count++;
                spin_unlock(&smi_info->count_lock);
 
+               /* Do the before return_hosed_msg, because that
+                  releases the lock. */
+               smi_info->si_state = SI_NORMAL;
                if (smi_info->curr_msg != NULL) {
                        /* If we were handling a user message, format
                            a response to send to the upper layer to
@@ -575,7 +646,6 @@ static enum si_sm_result smi_event_handler(struct smi_info *smi_info,
                        return_hosed_msg(smi_info);
                }
                si_sm_result = smi_info->handlers->event(smi_info->si_sm, 0);
-               smi_info->si_state = SI_NORMAL;
        }
 
        /* We prefer handling attn over new messages. */
@@ -712,6 +782,36 @@ static void set_run_to_completion(void *send_info, int i_run_to_completion)
        spin_unlock_irqrestore(&(smi_info->si_lock), flags);
 }
 
+static int ipmi_thread(void *data)
+{
+       struct smi_info *smi_info = data;
+       unsigned long flags;
+       enum si_sm_result smi_result;
+
+       set_user_nice(current, 19);
+       while (!kthread_should_stop()) {
+               spin_lock_irqsave(&(smi_info->si_lock), flags);
+               smi_result=smi_event_handler(smi_info, 0);
+               spin_unlock_irqrestore(&(smi_info->si_lock), flags);
+               if (smi_result == SI_SM_CALL_WITHOUT_DELAY) {
+                       /* do nothing */
+               }
+               else if (smi_result == SI_SM_CALL_WITH_DELAY)
+                       udelay(1);
+               else
+                       schedule_timeout_interruptible(1);
+       }
+       return 0;
+}
+
+
+static void poll(void *send_info)
+{
+       struct smi_info *smi_info = send_info;
+
+       smi_event_handler(smi_info, 0);
+}
+
 static void request_events(void *send_info)
 {
        struct smi_info *smi_info = send_info;
@@ -727,18 +827,20 @@ static void si_restart_short_timer(struct smi_info *smi_info)
 #if defined(CONFIG_HIGH_RES_TIMERS)
        unsigned long flags;
        unsigned long jiffies_now;
+       unsigned long seq;
 
        if (del_timer(&(smi_info->si_timer))) {
                /* If we don't delete the timer, then it will go off
                   immediately, anyway.  So we only process if we
                   actually delete the timer. */
 
-               /* We already have irqsave on, so no need for it
-                   here. */
-               read_lock(&xtime_lock);
-               jiffies_now = jiffies;
-               smi_info->si_timer.expires = jiffies_now;
-               smi_info->si_timer.sub_expires = get_arch_cycles(jiffies_now);
+               do {
+                       seq = read_seqbegin_irqsave(&xtime_lock, flags);
+                       jiffies_now = jiffies;
+                       smi_info->si_timer.expires = jiffies_now;
+                       smi_info->si_timer.arch_cycle_expires
+                               = get_arch_cycles(jiffies_now);
+               } while (read_seqretry_irqrestore(&xtime_lock, seq, flags));
 
                add_usec_to_timer(&smi_info->si_timer, SI_SHORT_TIMEOUT_USEC);
 
@@ -756,15 +858,13 @@ static void smi_timeout(unsigned long data)
        enum si_sm_result smi_result;
        unsigned long     flags;
        unsigned long     jiffies_now;
-       unsigned long     time_diff;
+       long              time_diff;
 #ifdef DEBUG_TIMING
        struct timeval    t;
 #endif
 
-       if (smi_info->stop_operation) {
-               smi_info->timer_stopped = 1;
+       if (atomic_read(&smi_info->stop_operation))
                return;
-       }
 
        spin_lock_irqsave(&(smi_info->si_lock), flags);
 #ifdef DEBUG_TIMING
@@ -772,7 +872,7 @@ static void smi_timeout(unsigned long data)
        printk("**Timer: %d.%9.9d\n", t.tv_sec, t.tv_usec);
 #endif
        jiffies_now = jiffies;
-       time_diff = ((jiffies_now - smi_info->last_timeout_jiffies)
+       time_diff = (((long)jiffies_now - (long)smi_info->last_timeout_jiffies)
                     * SI_USEC_PER_JIFFY);
        smi_result = smi_event_handler(smi_info, time_diff);
 
@@ -792,15 +892,19 @@ static void smi_timeout(unsigned long data)
        /* If the state machine asks for a short delay, then shorten
            the timer timeout. */
        if (smi_result == SI_SM_CALL_WITH_DELAY) {
+#if defined(CONFIG_HIGH_RES_TIMERS)
+               unsigned long seq;
+#endif
                spin_lock_irqsave(&smi_info->count_lock, flags);
                smi_info->short_timeouts++;
                spin_unlock_irqrestore(&smi_info->count_lock, flags);
 #if defined(CONFIG_HIGH_RES_TIMERS)
-               read_lock(&xtime_lock);
-                smi_info->si_timer.expires = jiffies;
-                smi_info->si_timer.sub_expires
-                        = get_arch_cycles(smi_info->si_timer.expires);
-                read_unlock(&xtime_lock);
+               do {
+                       seq = read_seqbegin_irqsave(&xtime_lock, flags);
+                       smi_info->si_timer.expires = jiffies;
+                       smi_info->si_timer.arch_cycle_expires
+                               = get_arch_cycles(smi_info->si_timer.expires);
+               } while (read_seqretry_irqrestore(&xtime_lock, seq, flags));
                add_usec_to_timer(&smi_info->si_timer, SI_SHORT_TIMEOUT_USEC);
 #else
                smi_info->si_timer.expires = jiffies + 1;
@@ -811,7 +915,7 @@ static void smi_timeout(unsigned long data)
                spin_unlock_irqrestore(&smi_info->count_lock, flags);
                smi_info->si_timer.expires = jiffies + SI_TIMEOUT_JIFFIES;
 #if defined(CONFIG_HIGH_RES_TIMERS)
-               smi_info->si_timer.sub_expires = 0;
+               smi_info->si_timer.arch_cycle_expires = 0;
 #endif
        }
 
@@ -833,7 +937,7 @@ static irqreturn_t si_irq_handler(int irq, void *data, struct pt_regs *regs)
        smi_info->interrupts++;
        spin_unlock(&smi_info->count_lock);
 
-       if (smi_info->stop_operation)
+       if (atomic_read(&smi_info->stop_operation))
                goto out;
 
 #ifdef DEBUG_TIMING
@@ -846,12 +950,24 @@ static irqreturn_t si_irq_handler(int irq, void *data, struct pt_regs *regs)
        return IRQ_HANDLED;
 }
 
+static irqreturn_t si_bt_irq_handler(int irq, void *data, struct pt_regs *regs)
+{
+       struct smi_info *smi_info = data;
+       /* We need to clear the IRQ flag for the BT interface. */
+       smi_info->io.outputb(&smi_info->io, IPMI_BT_INTMASK_REG,
+                            IPMI_BT_INTMASK_CLEAR_IRQ_BIT
+                            | IPMI_BT_INTMASK_ENABLE_IRQ_BIT);
+       return si_irq_handler(irq, data, regs);
+}
+
+
 static struct ipmi_smi_handlers handlers =
 {
        .owner                  = THIS_MODULE,
        .sender                 = sender,
        .request_events         = request_events,
-       .set_run_to_completion  = set_run_to_completion
+       .set_run_to_completion  = set_run_to_completion,
+       .poll                   = poll,
 };
 
 /* There can be 4 IO ports passed in (with or without IRQs), 4 addresses,
@@ -864,20 +980,29 @@ static struct smi_info *smi_infos[SI_MAX_DRIVERS] =
 
 #define DEVICE_NAME "ipmi_si"
 
-#define DEFAULT_KCS_IO_PORT 0xca2
-#define DEFAULT_SMIC_IO_PORT 0xca9
-#define DEFAULT_BT_IO_PORT   0xe4
+#define DEFAULT_KCS_IO_PORT    0xca2
+#define DEFAULT_SMIC_IO_PORT   0xca9
+#define DEFAULT_BT_IO_PORT     0xe4
+#define DEFAULT_REGSPACING     1
 
 static int           si_trydefaults = 1;
-static char          *si_type[SI_MAX_PARMS] = { NULL, NULL, NULL, NULL };
+static char          *si_type[SI_MAX_PARMS];
 #define MAX_SI_TYPE_STR 30
 static char          si_type_str[MAX_SI_TYPE_STR];
-static unsigned long addrs[SI_MAX_PARMS] = { 0, 0, 0, 0 };
-static int num_addrs = 0;
-static unsigned int  ports[SI_MAX_PARMS] = { 0, 0, 0, 0 };
-static int num_ports = 0;
-static int           irqs[SI_MAX_PARMS] = { 0, 0, 0, 0 };
-static int num_irqs = 0;
+static unsigned long addrs[SI_MAX_PARMS];
+static int num_addrs;
+static unsigned int  ports[SI_MAX_PARMS];
+static int num_ports;
+static int           irqs[SI_MAX_PARMS];
+static int num_irqs;
+static int           regspacings[SI_MAX_PARMS];
+static int num_regspacings = 0;
+static int           regsizes[SI_MAX_PARMS];
+static int num_regsizes = 0;
+static int           regshifts[SI_MAX_PARMS];
+static int num_regshifts = 0;
+static int slave_addrs[SI_MAX_PARMS];
+static int num_slave_addrs = 0;
 
 
 module_param_named(trydefaults, si_trydefaults, bool, 0);
@@ -889,26 +1014,49 @@ MODULE_PARM_DESC(type, "Defines the type of each interface, each"
                 " interface separated by commas.  The types are 'kcs',"
                 " 'smic', and 'bt'.  For example si_type=kcs,bt will set"
                 " the first interface to kcs and the second to bt");
-module_param_array(addrs, long, num_addrs, 0);
+module_param_array(addrs, long, &num_addrs, 0);
 MODULE_PARM_DESC(addrs, "Sets the memory address of each interface, the"
                 " addresses separated by commas.  Only use if an interface"
                 " is in memory.  Otherwise, set it to zero or leave"
                 " it blank.");
-module_param_array(ports, int, num_ports, 0);
+module_param_array(ports, int, &num_ports, 0);
 MODULE_PARM_DESC(ports, "Sets the port address of each interface, the"
                 " addresses separated by commas.  Only use if an interface"
                 " is a port.  Otherwise, set it to zero or leave"
                 " it blank.");
-module_param_array(irqs, int, num_irqs, 0);
+module_param_array(irqs, int, &num_irqs, 0);
 MODULE_PARM_DESC(irqs, "Sets the interrupt of each interface, the"
                 " addresses separated by commas.  Only use if an interface"
                 " has an interrupt.  Otherwise, set it to zero or leave"
                 " it blank.");
+module_param_array(regspacings, int, &num_regspacings, 0);
+MODULE_PARM_DESC(regspacings, "The number of bytes between the start address"
+                " and each successive register used by the interface.  For"
+                " instance, if the start address is 0xca2 and the spacing"
+                " is 2, then the second address is at 0xca4.  Defaults"
+                " to 1.");
+module_param_array(regsizes, int, &num_regsizes, 0);
+MODULE_PARM_DESC(regsizes, "The size of the specific IPMI register in bytes."
+                " This should generally be 1, 2, 4, or 8 for an 8-bit,"
+                " 16-bit, 32-bit, or 64-bit register.  Use this if you"
+                " the 8-bit IPMI register has to be read from a larger"
+                " register.");
+module_param_array(regshifts, int, &num_regshifts, 0);
+MODULE_PARM_DESC(regshifts, "The amount to shift the data read from the."
+                " IPMI register, in bits.  For instance, if the data"
+                " is read from a 32-bit word and the IPMI data is in"
+                " bit 8-15, then the shift would be 8");
+module_param_array(slave_addrs, int, &num_slave_addrs, 0);
+MODULE_PARM_DESC(slave_addrs, "Set the default IPMB slave address for"
+                " the controller.  Normally this is 0x20, but can be"
+                " overridden by this parm.  This is an array indexed"
+                " by interface number.");
+
 
 #define IPMI_MEM_ADDR_SPACE 1
 #define IPMI_IO_ADDR_SPACE  2
 
-#if defined(CONFIG_ACPI_INTERPETER) || defined(CONFIG_X86) || defined(CONFIG_PCI)
+#if defined(CONFIG_ACPI) || defined(CONFIG_DMI) || defined(CONFIG_PCI)
 static int is_new_interface(int intf, u8 addr_space, unsigned long base_addr)
 {
        int i;
@@ -936,14 +1084,25 @@ static int std_irq_setup(struct smi_info *info)
 {
        int rv;
 
-       if (!info->irq)
+       if (! info->irq)
                return 0;
 
-       rv = request_irq(info->irq,
-                        si_irq_handler,
-                        SA_INTERRUPT,
-                        DEVICE_NAME,
-                        info);
+       if (info->si_type == SI_BT) {
+               rv = request_irq(info->irq,
+                                si_bt_irq_handler,
+                                SA_INTERRUPT,
+                                DEVICE_NAME,
+                                info);
+               if (! rv)
+                       /* Enable the interrupt in the BT interface. */
+                       info->io.outputb(&info->io, IPMI_BT_INTMASK_REG,
+                                        IPMI_BT_INTMASK_ENABLE_IRQ_BIT);
+       } else
+               rv = request_irq(info->irq,
+                                si_irq_handler,
+                                SA_INTERRUPT,
+                                DEVICE_NAME,
+                                info);
        if (rv) {
                printk(KERN_WARNING
                       "ipmi_si: %s unable to claim interrupt %d,"
@@ -959,9 +1118,12 @@ static int std_irq_setup(struct smi_info *info)
 
 static void std_irq_cleanup(struct smi_info *info)
 {
-       if (!info->irq)
+       if (! info->irq)
                return;
 
+       if (info->si_type == SI_BT)
+               /* Disable the interrupt in the BT interface. */
+               info->io.outputb(&info->io, IPMI_BT_INTMASK_REG, 0);
        free_irq(info->irq, info);
 }
 
@@ -969,7 +1131,7 @@ static unsigned char port_inb(struct si_sm_io *io, unsigned int offset)
 {
        unsigned int *addr = io->info;
 
-       return inb((*addr)+offset);
+       return inb((*addr)+(offset*io->regspacing));
 }
 
 static void port_outb(struct si_sm_io *io, unsigned int offset,
@@ -977,54 +1139,125 @@ static void port_outb(struct si_sm_io *io, unsigned int offset,
 {
        unsigned int *addr = io->info;
 
-       outb(b, (*addr)+offset);
+       outb(b, (*addr)+(offset * io->regspacing));
 }
 
-static int port_setup(struct smi_info *info)
+static unsigned char port_inw(struct si_sm_io *io, unsigned int offset)
 {
-       unsigned int *addr = info->io.info;
+       unsigned int *addr = io->info;
 
-       if (!addr || (!*addr))
-               return -ENODEV;
+       return (inw((*addr)+(offset * io->regspacing)) >> io->regshift) & 0xff;
+}
 
-       if (request_region(*addr, info->io_size, DEVICE_NAME) == NULL)
-               return -EIO;
-       return 0;
+static void port_outw(struct si_sm_io *io, unsigned int offset,
+                     unsigned char b)
+{
+       unsigned int *addr = io->info;
+
+       outw(b << io->regshift, (*addr)+(offset * io->regspacing));
+}
+
+static unsigned char port_inl(struct si_sm_io *io, unsigned int offset)
+{
+       unsigned int *addr = io->info;
+
+       return (inl((*addr)+(offset * io->regspacing)) >> io->regshift) & 0xff;
+}
+
+static void port_outl(struct si_sm_io *io, unsigned int offset,
+                     unsigned char b)
+{
+       unsigned int *addr = io->info;
+
+       outl(b << io->regshift, (*addr)+(offset * io->regspacing));
 }
 
 static void port_cleanup(struct smi_info *info)
 {
        unsigned int *addr = info->io.info;
+       int           mapsize;
+
+       if (addr && (*addr)) {
+               mapsize = ((info->io_size * info->io.regspacing)
+                          - (info->io.regspacing - info->io.regsize));
 
-       if (addr && (*addr))
-               release_region (*addr, info->io_size);
+               release_region (*addr, mapsize);
+       }
        kfree(info);
 }
 
+static int port_setup(struct smi_info *info)
+{
+       unsigned int *addr = info->io.info;
+       int           mapsize;
+
+       if (! addr || (! *addr))
+               return -ENODEV;
+
+       info->io_cleanup = port_cleanup;
+
+       /* Figure out the actual inb/inw/inl/etc routine to use based
+          upon the register size. */
+       switch (info->io.regsize) {
+       case 1:
+               info->io.inputb = port_inb;
+               info->io.outputb = port_outb;
+               break;
+       case 2:
+               info->io.inputb = port_inw;
+               info->io.outputb = port_outw;
+               break;
+       case 4:
+               info->io.inputb = port_inl;
+               info->io.outputb = port_outl;
+               break;
+       default:
+               printk("ipmi_si: Invalid register size: %d\n",
+                      info->io.regsize);
+               return -EINVAL;
+       }
+
+       /* Calculate the total amount of memory to claim.  This is an
+        * unusual looking calculation, but it avoids claiming any
+        * more memory than it has to.  It will claim everything
+        * between the first address to the end of the last full
+        * register. */
+       mapsize = ((info->io_size * info->io.regspacing)
+                  - (info->io.regspacing - info->io.regsize));
+
+       if (request_region(*addr, mapsize, DEVICE_NAME) == NULL)
+               return -EIO;
+       return 0;
+}
+
 static int try_init_port(int intf_num, struct smi_info **new_info)
 {
        struct smi_info *info;
 
-       if (!ports[intf_num])
+       if (! ports[intf_num])
                return -ENODEV;
 
-       if (!is_new_interface(intf_num, IPMI_IO_ADDR_SPACE,
+       if (! is_new_interface(intf_num, IPMI_IO_ADDR_SPACE,
                              ports[intf_num]))
                return -ENODEV;
 
        info = kmalloc(sizeof(*info), GFP_KERNEL);
-       if (!info) {
+       if (! info) {
                printk(KERN_ERR "ipmi_si: Could not allocate SI data (1)\n");
                return -ENOMEM;
        }
        memset(info, 0, sizeof(*info));
 
        info->io_setup = port_setup;
-       info->io_cleanup = port_cleanup;
-       info->io.inputb = port_inb;
-       info->io.outputb = port_outb;
        info->io.info = &(ports[intf_num]);
        info->io.addr = NULL;
+       info->io.regspacing = regspacings[intf_num];
+       if (! info->io.regspacing)
+               info->io.regspacing = DEFAULT_REGSPACING;
+       info->io.regsize = regsizes[intf_num];
+       if (! info->io.regsize)
+               info->io.regsize = DEFAULT_REGSPACING;
+       info->io.regshift = regshifts[intf_num];
        info->irq = 0;
        info->irq_setup = NULL;
        *new_info = info;
@@ -1037,70 +1270,155 @@ static int try_init_port(int intf_num, struct smi_info **new_info)
        return 0;
 }
 
-static unsigned char mem_inb(struct si_sm_io *io, unsigned int offset)
+static unsigned char intf_mem_inb(struct si_sm_io *io, unsigned int offset)
 {
-       return readb((io->addr)+offset);
+       return readb((io->addr)+(offset * io->regspacing));
 }
 
-static void mem_outb(struct si_sm_io *io, unsigned int offset,
+static void intf_mem_outb(struct si_sm_io *io, unsigned int offset,
                     unsigned char b)
 {
-       writeb(b, (io->addr)+offset);
+       writeb(b, (io->addr)+(offset * io->regspacing));
 }
 
-static int mem_setup(struct smi_info *info)
+static unsigned char intf_mem_inw(struct si_sm_io *io, unsigned int offset)
 {
-       unsigned long *addr = info->io.info;
+       return (readw((io->addr)+(offset * io->regspacing)) >> io->regshift)
+               & 0xff;
+}
 
-       if (!addr || (!*addr))
-               return -ENODEV;
+static void intf_mem_outw(struct si_sm_io *io, unsigned int offset,
+                    unsigned char b)
+{
+       writeb(b << io->regshift, (io->addr)+(offset * io->regspacing));
+}
 
-       if (request_mem_region(*addr, info->io_size, DEVICE_NAME) == NULL)
-               return -EIO;
+static unsigned char intf_mem_inl(struct si_sm_io *io, unsigned int offset)
+{
+       return (readl((io->addr)+(offset * io->regspacing)) >> io->regshift)
+               & 0xff;
+}
 
-       info->io.addr = ioremap(*addr, info->io_size);
-       if (info->io.addr == NULL) {
-               release_mem_region(*addr, info->io_size);
-               return -EIO;
-       }
-       return 0;
+static void intf_mem_outl(struct si_sm_io *io, unsigned int offset,
+                    unsigned char b)
+{
+       writel(b << io->regshift, (io->addr)+(offset * io->regspacing));
+}
+
+#ifdef readq
+static unsigned char mem_inq(struct si_sm_io *io, unsigned int offset)
+{
+       return (readq((io->addr)+(offset * io->regspacing)) >> io->regshift)
+               & 0xff;
 }
 
+static void mem_outq(struct si_sm_io *io, unsigned int offset,
+                    unsigned char b)
+{
+       writeq(b << io->regshift, (io->addr)+(offset * io->regspacing));
+}
+#endif
+
 static void mem_cleanup(struct smi_info *info)
 {
        unsigned long *addr = info->io.info;
+       int           mapsize;
 
        if (info->io.addr) {
                iounmap(info->io.addr);
-               release_mem_region(*addr, info->io_size);
+
+               mapsize = ((info->io_size * info->io.regspacing)
+                          - (info->io.regspacing - info->io.regsize));
+
+               release_mem_region(*addr, mapsize);
        }
        kfree(info);
 }
 
+static int mem_setup(struct smi_info *info)
+{
+       unsigned long *addr = info->io.info;
+       int           mapsize;
+
+       if (! addr || (! *addr))
+               return -ENODEV;
+
+       info->io_cleanup = mem_cleanup;
+
+       /* Figure out the actual readb/readw/readl/etc routine to use based
+          upon the register size. */
+       switch (info->io.regsize) {
+       case 1:
+               info->io.inputb = intf_mem_inb;
+               info->io.outputb = intf_mem_outb;
+               break;
+       case 2:
+               info->io.inputb = intf_mem_inw;
+               info->io.outputb = intf_mem_outw;
+               break;
+       case 4:
+               info->io.inputb = intf_mem_inl;
+               info->io.outputb = intf_mem_outl;
+               break;
+#ifdef readq
+       case 8:
+               info->io.inputb = mem_inq;
+               info->io.outputb = mem_outq;
+               break;
+#endif
+       default:
+               printk("ipmi_si: Invalid register size: %d\n",
+                      info->io.regsize);
+               return -EINVAL;
+       }
+
+       /* Calculate the total amount of memory to claim.  This is an
+        * unusual looking calculation, but it avoids claiming any
+        * more memory than it has to.  It will claim everything
+        * between the first address to the end of the last full
+        * register. */
+       mapsize = ((info->io_size * info->io.regspacing)
+                  - (info->io.regspacing - info->io.regsize));
+
+       if (request_mem_region(*addr, mapsize, DEVICE_NAME) == NULL)
+               return -EIO;
+
+       info->io.addr = ioremap(*addr, mapsize);
+       if (info->io.addr == NULL) {
+               release_mem_region(*addr, mapsize);
+               return -EIO;
+       }
+       return 0;
+}
+
 static int try_init_mem(int intf_num, struct smi_info **new_info)
 {
        struct smi_info *info;
 
-       if (!addrs[intf_num])
+       if (! addrs[intf_num])
                return -ENODEV;
 
-       if (!is_new_interface(intf_num, IPMI_MEM_ADDR_SPACE,
+       if (! is_new_interface(intf_num, IPMI_MEM_ADDR_SPACE,
                              addrs[intf_num]))
                return -ENODEV;
 
        info = kmalloc(sizeof(*info), GFP_KERNEL);
-       if (!info) {
+       if (! info) {
                printk(KERN_ERR "ipmi_si: Could not allocate SI data (2)\n");
                return -ENOMEM;
        }
        memset(info, 0, sizeof(*info));
 
        info->io_setup = mem_setup;
-       info->io_cleanup = mem_cleanup;
-       info->io.inputb = mem_inb;
-       info->io.outputb = mem_outb;
-       info->io.info = (void *) addrs[intf_num];
+       info->io.info = &addrs[intf_num];
        info->io.addr = NULL;
+       info->io.regspacing = regspacings[intf_num];
+       if (! info->io.regspacing)
+               info->io.regspacing = DEFAULT_REGSPACING;
+       info->io.regsize = regsizes[intf_num];
+       if (! info->io.regsize)
+               info->io.regsize = DEFAULT_REGSPACING;
+       info->io.regshift = regshifts[intf_num];
        info->irq = 0;
        info->irq_setup = NULL;
        *new_info = info;
@@ -1114,7 +1432,7 @@ static int try_init_mem(int intf_num, struct smi_info **new_info)
 }
 
 
-#ifdef CONFIG_ACPI_INTERPRETER
+#ifdef CONFIG_ACPI
 
 #include <linux/acpi.h>
 
@@ -1124,7 +1442,7 @@ static int try_init_mem(int intf_num, struct smi_info **new_info)
 static int acpi_failure = 0;
 
 /* For GPE-type interrupts. */
-void ipmi_acpi_gpe(void *context)
+static u32 ipmi_acpi_gpe(void *context)
 {
        struct smi_info *smi_info = context;
        unsigned long   flags;
@@ -1138,7 +1456,7 @@ void ipmi_acpi_gpe(void *context)
        smi_info->interrupts++;
        spin_unlock(&smi_info->count_lock);
 
-       if (smi_info->stop_operation)
+       if (atomic_read(&smi_info->stop_operation))
                goto out;
 
 #ifdef DEBUG_TIMING
@@ -1148,20 +1466,22 @@ void ipmi_acpi_gpe(void *context)
        smi_event_handler(smi_info, 0);
  out:
        spin_unlock_irqrestore(&(smi_info->si_lock), flags);
+
+       return ACPI_INTERRUPT_HANDLED;
 }
 
 static int acpi_gpe_irq_setup(struct smi_info *info)
 {
        acpi_status status;
 
-       if (!info->irq)
+       if (! info->irq)
                return 0;
 
        /* FIXME - is level triggered right? */
        status = acpi_install_gpe_handler(NULL,
                                          info->irq,
                                          ACPI_GPE_LEVEL_TRIGGERED,
-                                         ipmi_acpi_gpe,
+                                         &ipmi_acpi_gpe,
                                          info);
        if (status != AE_OK) {
                printk(KERN_WARNING
@@ -1174,15 +1494,14 @@ static int acpi_gpe_irq_setup(struct smi_info *info)
                printk("  Using ACPI GPE %d\n", info->irq);
                return 0;
        }
-
 }
 
 static void acpi_gpe_irq_cleanup(struct smi_info *info)
 {
-       if (!info->irq)
+       if (! info->irq)
                return;
 
-       acpi_remove_gpe_handler(NULL, info->irq, ipmi_acpi_gpe);
+       acpi_remove_gpe_handler(NULL, info->irq, &ipmi_acpi_gpe);
 }
 
 /*
@@ -1235,6 +1554,9 @@ static int try_init_acpi(int intf_num, struct smi_info **new_info)
        char             *io_type;
        u8               addr_space;
 
+       if (acpi_disabled)
+               return -ENODEV;
+
        if (acpi_failure)
                return -ENODEV;
 
@@ -1255,7 +1577,7 @@ static int try_init_acpi(int intf_num, struct smi_info **new_info)
                addr_space = IPMI_MEM_ADDR_SPACE;
        else
                addr_space = IPMI_IO_ADDR_SPACE;
-       if (!is_new_interface(-1, addr_space, spmi->addr.address))
+       if (! is_new_interface(-1, addr_space, spmi->addr.address))
                return -ENODEV;
 
        /* Figure out the interface type. */
@@ -1280,7 +1602,7 @@ static int try_init_acpi(int intf_num, struct smi_info **new_info)
        }
 
        info = kmalloc(sizeof(*info), GFP_KERNEL);
-       if (!info) {
+       if (! info) {
                printk(KERN_ERR "ipmi_si: Could not allocate SI data (3)\n");
                return -ENOMEM;
        }
@@ -1302,21 +1624,28 @@ static int try_init_acpi(int intf_num, struct smi_info **new_info)
                info->irq_setup = NULL;
        }
 
+       if (spmi->addr.register_bit_width) {
+               /* A (hopefully) properly formed register bit width. */
+               regspacings[intf_num] = spmi->addr.register_bit_width / 8;
+               info->io.regspacing = spmi->addr.register_bit_width / 8;
+       } else {
+               regspacings[intf_num] = DEFAULT_REGSPACING;
+               info->io.regspacing = DEFAULT_REGSPACING;
+       }
+       regsizes[intf_num] = regspacings[intf_num];
+       info->io.regsize = regsizes[intf_num];
+       regshifts[intf_num] = spmi->addr.register_bit_offset;
+       info->io.regshift = regshifts[intf_num];
+
        if (spmi->addr.address_space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY) {
                io_type = "memory";
                info->io_setup = mem_setup;
-               info->io_cleanup = mem_cleanup;
                addrs[intf_num] = spmi->addr.address;
-               info->io.inputb = mem_inb;
-               info->io.outputb = mem_outb;
                info->io.info = &(addrs[intf_num]);
        } else if (spmi->addr.address_space_id == ACPI_ADR_SPACE_SYSTEM_IO) {
                io_type = "I/O";
                info->io_setup = port_setup;
-               info->io_cleanup = port_cleanup;
                ports[intf_num] = spmi->addr.address;
-               info->io.inputb = port_inb;
-               info->io.outputb = port_outb;
                info->io.info = &(ports[intf_num]);
        } else {
                kfree(info);
@@ -1332,142 +1661,111 @@ static int try_init_acpi(int intf_num, struct smi_info **new_info)
 }
 #endif
 
-#ifdef CONFIG_X86
-
+#ifdef CONFIG_DMI
 typedef struct dmi_ipmi_data
 {
        u8              type;
        u8              addr_space;
        unsigned long   base_addr;
        u8              irq;
-}dmi_ipmi_data_t;
+       u8              offset;
+       u8              slave_addr;
+} dmi_ipmi_data_t;
 
-typedef struct dmi_header
-{
-       u8      type;
-       u8      length;
-       u16     handle;
-}dmi_header_t;
+static dmi_ipmi_data_t dmi_data[SI_MAX_DRIVERS];
+static int dmi_data_entries;
 
-static int decode_dmi(dmi_header_t *dm, dmi_ipmi_data_t *ipmi_data)
+static int __init decode_dmi(struct dmi_header *dm, int intf_num)
 {
-       u8              *data = (u8 *)dm;
+       u8              *data = (u8 *)dm;
        unsigned long   base_addr;
-
-       ipmi_data->type = data[0x04];
-
-       memcpy(&base_addr,&data[0x08],sizeof(unsigned long));
-       if (base_addr & 1) {
-               /* I/O */
-               base_addr &= 0xFFFE;
+       u8              reg_spacing;
+       u8              len = dm->length;
+       dmi_ipmi_data_t *ipmi_data = dmi_data+intf_num;
+
+       ipmi_data->type = data[4];
+
+       memcpy(&base_addr, data+8, sizeof(unsigned long));
+       if (len >= 0x11) {
+               if (base_addr & 1) {
+                       /* I/O */
+                       base_addr &= 0xFFFE;
+                       ipmi_data->addr_space = IPMI_IO_ADDR_SPACE;
+               }
+               else {
+                       /* Memory */
+                       ipmi_data->addr_space = IPMI_MEM_ADDR_SPACE;
+               }
+               /* If bit 4 of byte 0x10 is set, then the lsb for the address
+                  is odd. */
+               ipmi_data->base_addr = base_addr | ((data[0x10] & 0x10) >> 4);
+
+               ipmi_data->irq = data[0x11];
+
+               /* The top two bits of byte 0x10 hold the register spacing. */
+               reg_spacing = (data[0x10] & 0xC0) >> 6;
+               switch(reg_spacing){
+               case 0x00: /* Byte boundaries */
+                   ipmi_data->offset = 1;
+                   break;
+               case 0x01: /* 32-bit boundaries */
+                   ipmi_data->offset = 4;
+                   break;
+               case 0x02: /* 16-byte boundaries */
+                   ipmi_data->offset = 16;
+                   break;
+               default:
+                   /* Some other interface, just ignore it. */
+                   return -EIO;
+               }
+       } else {
+               /* Old DMI spec. */
+               /* Note that technically, the lower bit of the base
+                * address should be 1 if the address is I/O and 0 if
+                * the address is in memory.  So many systems get that
+                * wrong (and all that I have seen are I/O) so we just
+                * ignore that bit and assume I/O.  Systems that use
+                * memory should use the newer spec, anyway. */
+               ipmi_data->base_addr = base_addr & 0xfffe;
                ipmi_data->addr_space = IPMI_IO_ADDR_SPACE;
+               ipmi_data->offset = 1;
        }
-       else {
-               /* Memory */
-               ipmi_data->addr_space = IPMI_MEM_ADDR_SPACE;
-       }
-
-       ipmi_data->base_addr = base_addr;
-       ipmi_data->irq = data[0x11];
-
-       if (is_new_interface(-1, ipmi_data->addr_space,ipmi_data->base_addr))
-           return 0;
-
-       memset(ipmi_data,0,sizeof(dmi_ipmi_data_t));
-
-       return -1;
-}
-
-static int dmi_table(u32 base, int len, int num,
-       dmi_ipmi_data_t *ipmi_data)
-{
-       u8                *buf;
-       struct dmi_header *dm;
-       u8                *data;
-       int               i=1;
-       int               status=-1;
-
-       buf = ioremap(base, len);
-       if(buf==NULL)
-               return -1;
-
-       data = buf;
-
-       while(i<num && (data - buf) < len)
-       {
-               dm=(dmi_header_t *)data;
-
-               if((data-buf+dm->length) >= len)
-                       break;
 
-               if (dm->type == 38) {
-                       if (decode_dmi(dm, ipmi_data) == 0) {
-                               status = 0;
-                               break;
-                       }
-               }
+       ipmi_data->slave_addr = data[6];
 
-               data+=dm->length;
-               while((data-buf) < len && (*data || data[1]))
-                       data++;
-               data+=2;
-               i++;
+       if (is_new_interface(-1, ipmi_data->addr_space,ipmi_data->base_addr)) {
+               dmi_data_entries++;
+               return 0;
        }
-       iounmap(buf);
 
-       return status;
-}
+       memset(ipmi_data, 0, sizeof(dmi_ipmi_data_t));
 
-inline static int dmi_checksum(u8 *buf)
-{
-       u8   sum=0;
-       int  a;
-
-       for(a=0; a<15; a++)
-               sum+=buf[a];
-       return (sum==0);
+       return -1;
 }
 
-static int dmi_iterator(dmi_ipmi_data_t *ipmi_data)
+static void __init dmi_find_bmc(void)
 {
-       u8   buf[15];
-       u32  fp=0xF0000;
+       struct dmi_device *dev = NULL;
+       int               intf_num = 0;
 
-#ifdef CONFIG_SIMNOW
-       return -1;
-#endif
-
-       while(fp < 0xFFFFF)
-       {
-               isa_memcpy_fromio(buf, fp, 15);
-               if(memcmp(buf, "_DMI_", 5)==0 && dmi_checksum(buf))
-               {
-                       u16 num=buf[13]<<8|buf[12];
-                       u16 len=buf[7]<<8|buf[6];
-                       u32 base=buf[11]<<24|buf[10]<<16|buf[9]<<8|buf[8];
+       while ((dev = dmi_find_device(DMI_DEV_TYPE_IPMI, NULL, dev))) {
+               if (intf_num >= SI_MAX_DRIVERS)
+                       break;
 
-                       if(dmi_table(base, len, num, ipmi_data) == 0)
-                               return 0;
-               }
-               fp+=16;
+               decode_dmi((struct dmi_header *) dev->device_data, intf_num++);
        }
-
-       return -1;
 }
 
 static int try_init_smbios(int intf_num, struct smi_info **new_info)
 {
-       struct smi_info   *info;
-       dmi_ipmi_data_t   ipmi_data;
-       char              *io_type;
-       int               status;
-
-       status = dmi_iterator(&ipmi_data);
+       struct smi_info *info;
+       dmi_ipmi_data_t *ipmi_data = dmi_data+intf_num;
+       char            *io_type;
 
-       if (status < 0)
+       if (intf_num >= dmi_data_entries)
                return -ENODEV;
 
-       switch(ipmi_data.type) {
+       switch (ipmi_data->type) {
                case 0x01: /* KCS */
                        si_type[intf_num] = "kcs";
                        break;
@@ -1478,32 +1776,25 @@ static int try_init_smbios(int intf_num, struct smi_info **new_info)
                        si_type[intf_num] = "bt";
                        break;
                default:
-                       printk("ipmi_si: Unknown SMBIOS SI type.\n");
                        return -EIO;
        }
 
        info = kmalloc(sizeof(*info), GFP_KERNEL);
-       if (!info) {
+       if (! info) {
                printk(KERN_ERR "ipmi_si: Could not allocate SI data (4)\n");
                return -ENOMEM;
        }
        memset(info, 0, sizeof(*info));
 
-       if (ipmi_data.addr_space == 1) {
+       if (ipmi_data->addr_space == 1) {
                io_type = "memory";
                info->io_setup = mem_setup;
-               info->io_cleanup = mem_cleanup;
-               addrs[intf_num] = ipmi_data.base_addr;
-               info->io.inputb = mem_inb;
-               info->io.outputb = mem_outb;
+               addrs[intf_num] = ipmi_data->base_addr;
                info->io.info = &(addrs[intf_num]);
-       } else if (ipmi_data.addr_space == 2) {
+       } else if (ipmi_data->addr_space == 2) {
                io_type = "I/O";
                info->io_setup = port_setup;
-               info->io_cleanup = port_cleanup;
-               ports[intf_num] = ipmi_data.base_addr;
-               info->io.inputb = port_inb;
-               info->io.outputb = port_outb;
+               ports[intf_num] = ipmi_data->base_addr;
                info->io.info = &(ports[intf_num]);
        } else {
                kfree(info);
@@ -1511,16 +1802,26 @@ static int try_init_smbios(int intf_num, struct smi_info **new_info)
                return -EIO;
        }
 
-       irqs[intf_num] = ipmi_data.irq;
+       regspacings[intf_num] = ipmi_data->offset;
+       info->io.regspacing = regspacings[intf_num];
+       if (! info->io.regspacing)
+               info->io.regspacing = DEFAULT_REGSPACING;
+       info->io.regsize = DEFAULT_REGSPACING;
+       info->io.regshift = regshifts[intf_num];
+
+       info->slave_addr = ipmi_data->slave_addr;
+
+       irqs[intf_num] = ipmi_data->irq;
 
        *new_info = info;
 
        printk("ipmi_si: Found SMBIOS-specified state machine at %s"
-              " address 0x%lx\n",
-              io_type, (unsigned long)ipmi_data.base_addr);
+              " address 0x%lx, slave address 0x%x\n",
+              io_type, (unsigned long)ipmi_data->base_addr,
+              ipmi_data->slave_addr);
        return 0;
 }
-#endif /* CONFIG_X86 */
+#endif /* CONFIG_DMI */
 
 #ifdef CONFIG_PCI
 
@@ -1545,18 +1846,19 @@ static int find_pci_smic(int intf_num, struct smi_info **new_info)
 
        pci_smic_checked = 1;
 
-       if ((pci_dev = pci_find_device(PCI_HP_VENDOR_ID, PCI_MMC_DEVICE_ID,
-                                      NULL)))
-               ;
-       else if ((pci_dev = pci_find_class(PCI_ERMC_CLASSCODE, NULL)) &&
-                pci_dev->subsystem_vendor == PCI_HP_VENDOR_ID)
-               fe_rmc = 1;
-       else
-               return -ENODEV;
+       pci_dev = pci_get_device(PCI_HP_VENDOR_ID, PCI_MMC_DEVICE_ID, NULL);
+       if (! pci_dev) {
+               pci_dev = pci_get_class(PCI_ERMC_CLASSCODE, NULL);
+               if (pci_dev && (pci_dev->subsystem_vendor == PCI_HP_VENDOR_ID))
+                       fe_rmc = 1;
+               else
+                       return -ENODEV;
+       }
 
        error = pci_read_config_word(pci_dev, PCI_MMC_ADDR_CW, &base_addr);
        if (error)
        {
+               pci_dev_put(pci_dev);
                printk(KERN_ERR
                       "ipmi_si: pci_read_config_word() failed (%d).\n",
                       error);
@@ -1564,8 +1866,9 @@ static int find_pci_smic(int intf_num, struct smi_info **new_info)
        }
 
        /* Bit 0: 1 specifies programmed I/O, 0 specifies memory mapped I/O */
-       if (!(base_addr & 0x0001))
+       if (! (base_addr & 0x0001))
        {
+               pci_dev_put(pci_dev);
                printk(KERN_ERR
                       "ipmi_si: memory mapped I/O not supported for PCI"
                       " smic.\n");
@@ -1573,26 +1876,31 @@ static int find_pci_smic(int intf_num, struct smi_info **new_info)
        }
 
        base_addr &= 0xFFFE;
-       if (!fe_rmc)
+       if (! fe_rmc)
                /* Data register starts at base address + 1 in eRMC */
                ++base_addr;
 
-       if (!is_new_interface(-1, IPMI_IO_ADDR_SPACE, base_addr))
-           return -ENODEV;
+       if (! is_new_interface(-1, IPMI_IO_ADDR_SPACE, base_addr)) {
+               pci_dev_put(pci_dev);
+               return -ENODEV;
+       }
 
        info = kmalloc(sizeof(*info), GFP_KERNEL);
-       if (!info) {
+       if (! info) {
+               pci_dev_put(pci_dev);
                printk(KERN_ERR "ipmi_si: Could not allocate SI data (5)\n");
                return -ENOMEM;
        }
        memset(info, 0, sizeof(*info));
 
        info->io_setup = port_setup;
-       info->io_cleanup = port_cleanup;
        ports[intf_num] = base_addr;
-       info->io.inputb = port_inb;
-       info->io.outputb = port_outb;
        info->io.info = &(ports[intf_num]);
+       info->io.regspacing = regspacings[intf_num];
+       if (! info->io.regspacing)
+               info->io.regspacing = DEFAULT_REGSPACING;
+       info->io.regsize = DEFAULT_REGSPACING;
+       info->io.regshift = regshifts[intf_num];
 
        *new_info = info;
 
@@ -1602,6 +1910,7 @@ static int find_pci_smic(int intf_num, struct smi_info **new_info)
        printk("ipmi_si: Found PCI SMIC at I/O address 0x%lx\n",
                (long unsigned int) base_addr);
 
+       pci_dev_put(pci_dev);
        return 0;
 }
 #endif /* CONFIG_PCI */
@@ -1609,7 +1918,7 @@ static int find_pci_smic(int intf_num, struct smi_info **new_info)
 static int try_init_plug_and_play(int intf_num, struct smi_info **new_info)
 {
 #ifdef CONFIG_PCI
-       if (find_pci_smic(intf_num, new_info)==0)
+       if (find_pci_smic(intf_num, new_info) == 0)
                return 0;
 #endif
        /* Include other methods here. */
@@ -1627,7 +1936,7 @@ static int try_get_dev_id(struct smi_info *smi_info)
        int               rv = 0;
 
        resp = kmalloc(IPMI_MAX_MSG_LENGTH, GFP_KERNEL);
-       if (!resp)
+       if (! resp)
                return -ENOMEM;
 
        /* Do a Get Device ID command, since it comes back with some
@@ -1639,9 +1948,9 @@ static int try_get_dev_id(struct smi_info *smi_info)
        smi_result = smi_info->handlers->event(smi_info->si_sm, 0);
        for (;;)
        {
-               if (smi_result == SI_SM_CALL_WITH_DELAY) {
-                       set_current_state(TASK_UNINTERRUPTIBLE);
-                       schedule_timeout(1);
+               if (smi_result == SI_SM_CALL_WITH_DELAY ||
+                   smi_result == SI_SM_CALL_WITH_TICK_DELAY) {
+                       schedule_timeout_uninterruptible(1);
                        smi_result = smi_info->handlers->event(
                                smi_info->si_sm, 100);
                }
@@ -1676,11 +1985,8 @@ static int try_get_dev_id(struct smi_info *smi_info)
        }
 
        /* Record info from the get device id, in case we need it. */
-       smi_info->ipmi_si_dev_rev = resp[4] & 0xf;
-       smi_info->ipmi_si_fw_rev_major = resp[5] & 0x7f;
-       smi_info->ipmi_si_fw_rev_minor = resp[6];
-       smi_info->ipmi_version_major = resp[7] & 0xf;
-       smi_info->ipmi_version_minor = resp[7] >> 4;
+       memcpy(&smi_info->device_id, &resp[3],
+              min_t(unsigned long, resp_len-3, sizeof(smi_info->device_id)));
 
  out:
        kfree(resp);
@@ -1712,7 +2018,7 @@ static int stat_file_read_proc(char *page, char **start, off_t off,
        struct smi_info *smi = data;
 
        out += sprintf(out, "interrupts_enabled:    %d\n",
-                      smi->irq && !smi->interrupt_disabled);
+                      smi->irq && ! smi->interrupt_disabled);
        out += sprintf(out, "short_timeouts:        %ld\n",
                       smi->short_timeouts);
        out += sprintf(out, "long_timeouts:         %ld\n",
@@ -1741,6 +2047,159 @@ static int stat_file_read_proc(char *page, char **start, off_t off,
        return (out - ((char *) page));
 }
 
+/*
+ * oem_data_avail_to_receive_msg_avail
+ * @info - smi_info structure with msg_flags set
+ *
+ * Converts flags from OEM_DATA_AVAIL to RECEIVE_MSG_AVAIL
+ * Returns 1 indicating need to re-run handle_flags().
+ */
+static int oem_data_avail_to_receive_msg_avail(struct smi_info *smi_info)
+{
+       smi_info->msg_flags = ((smi_info->msg_flags & ~OEM_DATA_AVAIL) |
+                               RECEIVE_MSG_AVAIL);
+       return 1;
+}
+
+/*
+ * setup_dell_poweredge_oem_data_handler
+ * @info - smi_info.device_id must be populated
+ *
+ * Systems that match, but have firmware version < 1.40 may assert
+ * OEM0_DATA_AVAIL on their own, without being told via Set Flags that
+ * it's safe to do so.  Such systems will de-assert OEM1_DATA_AVAIL
+ * upon receipt of IPMI_GET_MSG_CMD, so we should treat these flags
+ * as RECEIVE_MSG_AVAIL instead.
+ *
+ * As Dell has no plans to release IPMI 1.5 firmware that *ever*
+ * assert the OEM[012] bits, and if it did, the driver would have to
+ * change to handle that properly, we don't actually check for the
+ * firmware version.
+ * Device ID = 0x20                BMC on PowerEdge 8G servers
+ * Device Revision = 0x80
+ * Firmware Revision1 = 0x01       BMC version 1.40
+ * Firmware Revision2 = 0x40       BCD encoded
+ * IPMI Version = 0x51             IPMI 1.5
+ * Manufacturer ID = A2 02 00      Dell IANA
+ *
+ * Additionally, PowerEdge systems with IPMI < 1.5 may also assert
+ * OEM0_DATA_AVAIL and needs to be treated as RECEIVE_MSG_AVAIL.
+ *
+ */
+#define DELL_POWEREDGE_8G_BMC_DEVICE_ID  0x20
+#define DELL_POWEREDGE_8G_BMC_DEVICE_REV 0x80
+#define DELL_POWEREDGE_8G_BMC_IPMI_VERSION 0x51
+#define DELL_IANA_MFR_ID {0xA2, 0x02, 0x00}
+static void setup_dell_poweredge_oem_data_handler(struct smi_info *smi_info)
+{
+       struct ipmi_device_id *id = &smi_info->device_id;
+       const char mfr[3]=DELL_IANA_MFR_ID;
+       if (! memcmp(mfr, id->manufacturer_id, sizeof(mfr))) {
+               if (id->device_id       == DELL_POWEREDGE_8G_BMC_DEVICE_ID  &&
+                   id->device_revision == DELL_POWEREDGE_8G_BMC_DEVICE_REV &&
+                   id->ipmi_version    == DELL_POWEREDGE_8G_BMC_IPMI_VERSION) {
+                       smi_info->oem_data_avail_handler =
+                               oem_data_avail_to_receive_msg_avail;
+               }
+               else if (ipmi_version_major(id) < 1 ||
+                        (ipmi_version_major(id) == 1 &&
+                         ipmi_version_minor(id) < 5)) {
+                       smi_info->oem_data_avail_handler =
+                               oem_data_avail_to_receive_msg_avail;
+               }
+       }
+}
+
+#define CANNOT_RETURN_REQUESTED_LENGTH 0xCA
+static void return_hosed_msg_badsize(struct smi_info *smi_info)
+{
+       struct ipmi_smi_msg *msg = smi_info->curr_msg;
+
+       /* Make it a reponse */
+       msg->rsp[0] = msg->data[0] | 4;
+       msg->rsp[1] = msg->data[1];
+       msg->rsp[2] = CANNOT_RETURN_REQUESTED_LENGTH;
+       msg->rsp_size = 3;
+       smi_info->curr_msg = NULL;
+       deliver_recv_msg(smi_info, msg);
+}
+
+/*
+ * dell_poweredge_bt_xaction_handler
+ * @info - smi_info.device_id must be populated
+ *
+ * Dell PowerEdge servers with the BT interface (x6xx and 1750) will
+ * not respond to a Get SDR command if the length of the data
+ * requested is exactly 0x3A, which leads to command timeouts and no
+ * data returned.  This intercepts such commands, and causes userspace
+ * callers to try again with a different-sized buffer, which succeeds.
+ */
+
+#define STORAGE_NETFN 0x0A
+#define STORAGE_CMD_GET_SDR 0x23
+static int dell_poweredge_bt_xaction_handler(struct notifier_block *self,
+                                            unsigned long unused,
+                                            void *in)
+{
+       struct smi_info *smi_info = in;
+       unsigned char *data = smi_info->curr_msg->data;
+       unsigned int size   = smi_info->curr_msg->data_size;
+       if (size >= 8 &&
+           (data[0]>>2) == STORAGE_NETFN &&
+           data[1] == STORAGE_CMD_GET_SDR &&
+           data[7] == 0x3A) {
+               return_hosed_msg_badsize(smi_info);
+               return NOTIFY_STOP;
+       }
+       return NOTIFY_DONE;
+}
+
+static struct notifier_block dell_poweredge_bt_xaction_notifier = {
+       .notifier_call  = dell_poweredge_bt_xaction_handler,
+};
+
+/*
+ * setup_dell_poweredge_bt_xaction_handler
+ * @info - smi_info.device_id must be filled in already
+ *
+ * Fills in smi_info.device_id.start_transaction_pre_hook
+ * when we know what function to use there.
+ */
+static void
+setup_dell_poweredge_bt_xaction_handler(struct smi_info *smi_info)
+{
+       struct ipmi_device_id *id = &smi_info->device_id;
+       const char mfr[3]=DELL_IANA_MFR_ID;
+       if (! memcmp(mfr, id->manufacturer_id, sizeof(mfr)) &&
+           smi_info->si_type == SI_BT)
+               register_xaction_notifier(&dell_poweredge_bt_xaction_notifier);
+}
+
+/*
+ * setup_oem_data_handler
+ * @info - smi_info.device_id must be filled in already
+ *
+ * Fills in smi_info.device_id.oem_data_available_handler
+ * when we know what function to use there.
+ */
+
+static void setup_oem_data_handler(struct smi_info *smi_info)
+{
+       setup_dell_poweredge_oem_data_handler(smi_info);
+}
+
+static void setup_xaction_handlers(struct smi_info *smi_info)
+{
+       setup_dell_poweredge_bt_xaction_handler(smi_info);
+}
+
+static inline void wait_for_timer_and_thread(struct smi_info *smi_info)
+{
+       if (smi_info->thread != NULL && smi_info->thread != ERR_PTR(-ENOMEM))
+               kthread_stop(smi_info->thread);
+       del_timer_sync(&smi_info->si_timer);
+}
+
 /* Returns 0 if initialized, or negative on an error. */
 static int init_one_smi(int intf_num, struct smi_info **smi)
 {
@@ -1751,20 +2210,16 @@ static int init_one_smi(int intf_num, struct smi_info **smi)
        rv = try_init_mem(intf_num, &new_smi);
        if (rv)
                rv = try_init_port(intf_num, &new_smi);
-#ifdef CONFIG_ACPI_INTERPRETER
-       if ((rv) && (si_trydefaults)) {
+#ifdef CONFIG_ACPI
+       if (rv && si_trydefaults)
                rv = try_init_acpi(intf_num, &new_smi);
-       }
 #endif
-#ifdef CONFIG_X86
-       if ((rv) && (si_trydefaults)) {
+#ifdef CONFIG_DMI
+       if (rv && si_trydefaults)
                rv = try_init_smbios(intf_num, &new_smi);
-        }
 #endif
-       if ((rv) && (si_trydefaults)) {
+       if (rv && si_trydefaults)
                rv = try_init_plug_and_play(intf_num, &new_smi);
-       }
-
 
        if (rv)
                return rv;
@@ -1772,9 +2227,9 @@ static int init_one_smi(int intf_num, struct smi_info **smi)
        /* So we know not to free it unless we have allocated one. */
        new_smi->intf = NULL;
        new_smi->si_sm = NULL;
-       new_smi->handlers = 0;
+       new_smi->handlers = NULL;
 
-       if (!new_smi->irq_setup) {
+       if (! new_smi->irq_setup) {
                new_smi->irq = irqs[intf_num];
                new_smi->irq_setup = std_irq_setup;
                new_smi->irq_cleanup = std_irq_cleanup;
@@ -1808,7 +2263,7 @@ static int init_one_smi(int intf_num, struct smi_info **smi)
 
        /* Allocate the state machine's data and initialize it. */
        new_smi->si_sm = kmalloc(new_smi->handlers->size(), GFP_KERNEL);
-       if (!new_smi->si_sm) {
+       if (! new_smi->si_sm) {
                printk(" Could not allocate state machine memory\n");
                rv = -ENOMEM;
                goto out_err;
@@ -1839,6 +2294,9 @@ static int init_one_smi(int intf_num, struct smi_info **smi)
        if (rv)
                goto out_err;
 
+       setup_oem_data_handler(new_smi);
+       setup_xaction_handlers(new_smi);
+
        /* Try to claim any interrupts. */
        new_smi->irq_setup(new_smi);
 
@@ -1848,16 +2306,43 @@ static int init_one_smi(int intf_num, struct smi_info **smi)
        atomic_set(&new_smi->req_events, 0);
        new_smi->run_to_completion = 0;
 
+       new_smi->interrupt_disabled = 0;
+       atomic_set(&new_smi->stop_operation, 0);
+       new_smi->intf_num = intf_num;
+
+       /* Start clearing the flags before we enable interrupts or the
+          timer to avoid racing with the timer. */
+       start_clear_flags(new_smi);
+       /* IRQ is defined to be set when non-zero. */
+       if (new_smi->irq)
+               new_smi->si_state = SI_CLEARING_FLAGS_THEN_SET_IRQ;
+
+       /* The ipmi_register_smi() code does some operations to
+          determine the channel information, so we must be ready to
+          handle operations before it is called.  This means we have
+          to stop the timer if we get an error after this point. */
+       init_timer(&(new_smi->si_timer));
+       new_smi->si_timer.data = (long) new_smi;
+       new_smi->si_timer.function = smi_timeout;
+       new_smi->last_timeout_jiffies = jiffies;
+       new_smi->si_timer.expires = jiffies + SI_TIMEOUT_JIFFIES;
+
+       add_timer(&(new_smi->si_timer));
+       if (new_smi->si_type != SI_BT)
+               new_smi->thread = kthread_run(ipmi_thread, new_smi,
+                                             "kipmi%d", new_smi->intf_num);
+
        rv = ipmi_register_smi(&handlers,
                               new_smi,
-                              new_smi->ipmi_version_major,
-                              new_smi->ipmi_version_minor,
+                              ipmi_version_major(&new_smi->device_id),
+                              ipmi_version_minor(&new_smi->device_id),
+                              new_smi->slave_addr,
                               &(new_smi->intf));
        if (rv) {
                printk(KERN_ERR
                       "ipmi_si: Unable to register device: error %d\n",
                       rv);
-               goto out_err;
+               goto out_err_stop_timer;
        }
 
        rv = ipmi_smi_add_proc_entry(new_smi->intf, "type",
@@ -1867,7 +2352,7 @@ static int init_one_smi(int intf_num, struct smi_info **smi)
                printk(KERN_ERR
                       "ipmi_si: Unable to create proc entry: %d\n",
                       rv);
-               goto out_err;
+               goto out_err_stop_timer;
        }
 
        rv = ipmi_smi_add_proc_entry(new_smi->intf, "si_stats",
@@ -1877,43 +2362,38 @@ static int init_one_smi(int intf_num, struct smi_info **smi)
                printk(KERN_ERR
                       "ipmi_si: Unable to create proc entry: %d\n",
                       rv);
-               goto out_err;
+               goto out_err_stop_timer;
        }
 
-       start_clear_flags(new_smi);
-
-       /* IRQ is defined to be set when non-zero. */
-       if (new_smi->irq)
-               new_smi->si_state = SI_CLEARING_FLAGS_THEN_SET_IRQ;
-
-       new_smi->interrupt_disabled = 0;
-       new_smi->timer_stopped = 0;
-       new_smi->stop_operation = 0;
-
-       init_timer(&(new_smi->si_timer));
-       new_smi->si_timer.data = (long) new_smi;
-       new_smi->si_timer.function = smi_timeout;
-       new_smi->last_timeout_jiffies = jiffies;
-       new_smi->si_timer.expires = jiffies + SI_TIMEOUT_JIFFIES;
-       add_timer(&(new_smi->si_timer));
-
        *smi = new_smi;
 
        printk(" IPMI %s interface initialized\n", si_type[intf_num]);
 
        return 0;
 
+ out_err_stop_timer:
+       atomic_inc(&new_smi->stop_operation);
+       wait_for_timer_and_thread(new_smi);
+
  out_err:
        if (new_smi->intf)
                ipmi_unregister_smi(new_smi->intf);
 
        new_smi->irq_cleanup(new_smi);
+
+       /* Wait until we know that we are out of any interrupt
+          handlers might have been running before we freed the
+          interrupt. */
+       synchronize_sched();
+
        if (new_smi->si_sm) {
                if (new_smi->handlers)
                        new_smi->handlers->cleanup(new_smi->si_sm);
                kfree(new_smi->si_sm);
        }
-       new_smi->io_cleanup(new_smi);
+       if (new_smi->io_cleanup)
+               new_smi->io_cleanup(new_smi);
+
        return rv;
 }
 
@@ -1931,7 +2411,7 @@ static __init int init_ipmi_si(void)
        /* Parse out the si_type string into its components. */
        str = si_type_str;
        if (*str != '\0') {
-               for (i=0; (i<SI_MAX_PARMS) && (*str != '\0'); i++) {
+               for (i = 0; (i < SI_MAX_PARMS) && (*str != '\0'); i++) {
                        si_type[i] = str;
                        str = strchr(str, ',');
                        if (str) {
@@ -1943,18 +2423,14 @@ static __init int init_ipmi_si(void)
                }
        }
 
-       printk(KERN_INFO "IPMI System Interface driver version "
-              IPMI_SI_VERSION);
-       if (kcs_smi_handlers.version)
-               printk(", KCS version %s", kcs_smi_handlers.version);
-       if (smic_smi_handlers.version)
-               printk(", SMIC version %s", smic_smi_handlers.version);
-       if (bt_smi_handlers.version)
-               printk(", BT version %s", bt_smi_handlers.version);
-       printk("\n");
+       printk(KERN_INFO "IPMI System Interface driver.\n");
+
+#ifdef CONFIG_DMI
+       dmi_find_bmc();
+#endif
 
        rv = init_one_smi(0, &(smi_infos[pos]));
-       if (rv && !ports[0] && si_trydefaults) {
+       if (rv && ! ports[0] && si_trydefaults) {
                /* If we are trying defaults and the initial port is
                    not set, then set it. */
                si_type[0] = "kcs";
@@ -1976,7 +2452,7 @@ static __init int init_ipmi_si(void)
        if (rv == 0)
                pos++;
 
-       for (i=1; i < SI_MAX_PARMS; i++) {
+       for (i = 1; i < SI_MAX_PARMS; i++) {
                rv = init_one_smi(i, &(smi_infos[pos]));
                if (rv == 0)
                        pos++;
@@ -1991,7 +2467,7 @@ static __init int init_ipmi_si(void)
 }
 module_init(init_ipmi_si);
 
-void __exit cleanup_one_si(struct smi_info *to_clean)
+static void __exit cleanup_one_si(struct smi_info *to_clean)
 {
        int           rv;
        unsigned long flags;
@@ -2004,8 +2480,7 @@ void __exit cleanup_one_si(struct smi_info *to_clean)
        spin_lock_irqsave(&(to_clean->si_lock), flags);
        spin_lock(&(to_clean->msg_lock));
 
-       to_clean->stop_operation = 1;
-
+       atomic_inc(&to_clean->stop_operation);
        to_clean->irq_cleanup(to_clean);
 
        spin_unlock(&(to_clean->msg_lock));
@@ -2014,13 +2489,15 @@ void __exit cleanup_one_si(struct smi_info *to_clean)
        /* Wait until we know that we are out of any interrupt
           handlers might have been running before we freed the
           interrupt. */
-       synchronize_kernel();
+       synchronize_sched();
+
+       wait_for_timer_and_thread(to_clean);
 
-       /* Wait for the timer to stop.  This avoids problems with race
-          conditions removing the timer here. */
-       while (!to_clean->timer_stopped) {
-               set_current_state(TASK_UNINTERRUPTIBLE);
-               schedule_timeout(1);
+       /* Interrupts and timeouts are stopped, now make sure the
+          interface is in a clean state. */
+       while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
+               poll(to_clean);
+               schedule_timeout_uninterruptible(1);
        }
 
        rv = ipmi_unregister_smi(to_clean->intf);
@@ -2034,20 +2511,23 @@ void __exit cleanup_one_si(struct smi_info *to_clean)
 
        kfree(to_clean->si_sm);
 
-       to_clean->io_cleanup(to_clean);
+       if (to_clean->io_cleanup)
+               to_clean->io_cleanup(to_clean);
 }
 
 static __exit void cleanup_ipmi_si(void)
 {
        int i;
 
-       if (!initialized)
+       if (! initialized)
                return;
 
-       for (i=0; i<SI_MAX_DRIVERS; i++) {
+       for (i = 0; i < SI_MAX_DRIVERS; i++) {
                cleanup_one_si(smi_infos[i]);
        }
 }
 module_exit(cleanup_ipmi_si);
 
 MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Corey Minyard <minyard@mvista.com>");
+MODULE_DESCRIPTION("Interface to the IPMI driver for the KCS, SMIC, and BT system interfaces.");