fedora core 6 1.2949 + vserver 2.2.0
[linux-2.6.git] / drivers / ide / ide-disk.c
index 020bb4c..0a05a37 100644 (file)
@@ -37,7 +37,7 @@
  * Version 1.15                convert all calls to ide_raw_taskfile
  *                             since args will return register content.
  * Version 1.16                added suspend-resume-checkpower
- * Version 1.17                do flush on standy, do flush on ATA < ATA6
+ * Version 1.17                do flush on standby, do flush on ATA < ATA6
  *                     fix wcache setup.
  */
 
@@ -47,7 +47,6 @@
 
 //#define DEBUG
 
-#include <linux/config.h>
 #include <linux/module.h>
 #include <linux/types.h>
 #include <linux/string.h>
@@ -60,6 +59,8 @@
 #include <linux/genhd.h>
 #include <linux/slab.h>
 #include <linux/delay.h>
+#include <linux/mutex.h>
+#include <linux/leds.h>
 
 #define _IDE_DISK
 
 #include <asm/io.h>
 #include <asm/div64.h>
 
-/* FIXME: some day we shouldn't need to look in here! */
+struct ide_disk_obj {
+       ide_drive_t     *drive;
+       ide_driver_t    *driver;
+       struct gendisk  *disk;
+       struct kref     kref;
+};
+
+static DEFINE_MUTEX(idedisk_ref_mutex);
+
+#define to_ide_disk(obj) container_of(obj, struct ide_disk_obj, kref)
 
-#include "legacy/pdc4030.h"
+#define ide_disk_g(disk) \
+       container_of((disk)->private_data, struct ide_disk_obj, driver)
+
+static struct ide_disk_obj *ide_disk_get(struct gendisk *disk)
+{
+       struct ide_disk_obj *idkp = NULL;
+
+       mutex_lock(&idedisk_ref_mutex);
+       idkp = ide_disk_g(disk);
+       if (idkp)
+               kref_get(&idkp->kref);
+       mutex_unlock(&idedisk_ref_mutex);
+       return idkp;
+}
+
+static void ide_disk_release(struct kref *);
+
+static void ide_disk_put(struct ide_disk_obj *idkp)
+{
+       mutex_lock(&idedisk_ref_mutex);
+       kref_put(&idkp->kref, ide_disk_release);
+       mutex_unlock(&idedisk_ref_mutex);
+}
 
 /*
  * lba_capacity_is_ok() performs a sanity check on the claimed "lba_capacity"
@@ -88,6 +120,10 @@ static int lba_capacity_is_ok (struct hd_driveid *id)
 {
        unsigned long lba_sects, chs_sects, head, tail;
 
+       /* No non-LBA info .. so valid! */
+       if (id->cyls == 0)
+               return 1;
+
        /*
         * The ATA spec tells large drives to return
         * C/H/S = 16383/16/63 independent of their size.
@@ -120,224 +156,11 @@ static int lba_capacity_is_ok (struct hd_driveid *id)
        return 0;       /* lba_capacity value may be bad */
 }
 
-#ifndef CONFIG_IDE_TASKFILE_IO
-
-/*
- * read_intr() is the handler for disk read/multread interrupts
- */
-static ide_startstop_t read_intr (ide_drive_t *drive)
-{
-       ide_hwif_t *hwif        = HWIF(drive);
-       u32 i = 0, nsect        = 0, msect = drive->mult_count;
-       struct request *rq;
-       unsigned long flags;
-       u8 stat;
-       char *to;
-
-       /* new way for dealing with premature shared PCI interrupts */
-       if (!OK_STAT(stat=hwif->INB(IDE_STATUS_REG),DATA_READY,BAD_R_STAT)) {
-               if (stat & (ERR_STAT|DRQ_STAT)) {
-                       return DRIVER(drive)->error(drive, "read_intr", stat);
-               }
-               /* no data yet, so wait for another interrupt */
-               ide_set_handler(drive, &read_intr, WAIT_CMD, NULL);
-               return ide_started;
-       }
-       
-read_next:
-       rq = HWGROUP(drive)->rq;
-       if (msect) {
-               if ((nsect = rq->current_nr_sectors) > msect)
-                       nsect = msect;
-               msect -= nsect;
-       } else
-               nsect = 1;
-       to = ide_map_buffer(rq, &flags);
-       taskfile_input_data(drive, to, nsect * SECTOR_WORDS);
-#ifdef DEBUG
-       printk("%s:  read: sectors(%ld-%ld), buffer=0x%08lx, remaining=%ld\n",
-               drive->name, rq->sector, rq->sector+nsect-1,
-               (unsigned long) rq->buffer+(nsect<<9), rq->nr_sectors-nsect);
-#endif
-       ide_unmap_buffer(rq, to, &flags);
-       rq->sector += nsect;
-       rq->errors = 0;
-       i = (rq->nr_sectors -= nsect);
-       if (((long)(rq->current_nr_sectors -= nsect)) <= 0)
-               ide_end_request(drive, 1, rq->hard_cur_sectors);
-       /*
-        * Another BH Page walker and DATA INTEGRITY Questioned on ERROR.
-        * If passed back up on multimode read, BAD DATA could be ACKED
-        * to FILE SYSTEMS above ...
-        */
-       if (i > 0) {
-               if (msect)
-                       goto read_next;
-               ide_set_handler(drive, &read_intr, WAIT_CMD, NULL);
-                return ide_started;
-       }
-        return ide_stopped;
-}
-
-/*
- * write_intr() is the handler for disk write interrupts
- */
-static ide_startstop_t write_intr (ide_drive_t *drive)
-{
-       ide_hwgroup_t *hwgroup  = HWGROUP(drive);
-       ide_hwif_t *hwif        = HWIF(drive);
-       struct request *rq      = hwgroup->rq;
-       u32 i = 0;
-       u8 stat;
-
-       if (!OK_STAT(stat = hwif->INB(IDE_STATUS_REG),
-                       DRIVE_READY, drive->bad_wstat)) {
-               printk("%s: write_intr error1: nr_sectors=%ld, stat=0x%02x\n",
-                       drive->name, rq->nr_sectors, stat);
-        } else {
-#ifdef DEBUG
-               printk("%s: write: sector %ld, buffer=0x%08lx, remaining=%ld\n",
-                       drive->name, rq->sector, (unsigned long) rq->buffer,
-                       rq->nr_sectors-1);
-#endif
-               if ((rq->nr_sectors == 1) ^ ((stat & DRQ_STAT) != 0)) {
-                       rq->sector++;
-                       rq->errors = 0;
-                       i = --rq->nr_sectors;
-                       --rq->current_nr_sectors;
-                       if (((long)rq->current_nr_sectors) <= 0)
-                               ide_end_request(drive, 1, rq->hard_cur_sectors);
-                       if (i > 0) {
-                               unsigned long flags;
-                               char *to = ide_map_buffer(rq, &flags);
-                               taskfile_output_data(drive, to, SECTOR_WORDS);
-                               ide_unmap_buffer(rq, to, &flags);
-                               ide_set_handler(drive, &write_intr, WAIT_CMD, NULL);
-                                return ide_started;
-                       }
-                        return ide_stopped;
-               }
-               /* the original code did this here (?) */
-               return ide_stopped;
-       }
-       return DRIVER(drive)->error(drive, "write_intr", stat);
-}
-
-/*
- * ide_multwrite() transfers a block of up to mcount sectors of data
- * to a drive as part of a disk multiple-sector write operation.
- *
- * Note that we may be called from two contexts - __ide_do_rw_disk() context
- * and IRQ context. The IRQ can happen any time after we've output the
- * full "mcount" number of sectors, so we must make sure we update the
- * state _before_ we output the final part of the data!
- *
- * The update and return to BH is a BLOCK Layer Fakey to get more data
- * to satisfy the hardware atomic segment.  If the hardware atomic segment
- * is shorter or smaller than the BH segment then we should be OKAY.
- * This is only valid if we can rewind the rq->current_nr_sectors counter.
- */
-static void ide_multwrite(ide_drive_t *drive, unsigned int mcount)
-{
-       ide_hwgroup_t *hwgroup  = HWGROUP(drive);
-       struct request *rq      = &hwgroup->wrq;
-       do {
-               char *buffer;
-               int nsect = rq->current_nr_sectors;
-               unsigned long flags;
-               if (nsect > mcount)
-                       nsect = mcount;
-               mcount -= nsect;
-               buffer = ide_map_buffer(rq, &flags);
-
-               rq->sector += nsect;
-               rq->nr_sectors -= nsect;
-               rq->current_nr_sectors -= nsect;
-
-               /* Do we move to the next bh after this? */
-               if (!rq->current_nr_sectors) {
-                       struct bio *bio = rq->bio;
-
-                       /*
-                        * only move to next bio, when we have processed
-                        * all bvecs in this one.
-                        */
-                       if (++bio->bi_idx >= bio->bi_vcnt) {
-                               bio->bi_idx = bio->bi_vcnt - rq->nr_cbio_segments;
-                               bio = bio->bi_next;
-                       }
-
-                       /* end early early we ran out of requests */
-                       if (!bio) {
-                               mcount = 0;
-                       } else {
-                               rq->bio = bio;
-                               rq->nr_cbio_segments = bio_segments(bio);
-                               rq->current_nr_sectors = bio_cur_sectors(bio);
-                               rq->hard_cur_sectors = rq->current_nr_sectors;
-                       }
-               }
-
-               /*
-                * Ok, we're all setup for the interrupt
-                * re-entering us on the last transfer.
-                */
-               taskfile_output_data(drive, buffer, nsect<<7);
-               ide_unmap_buffer(rq, buffer, &flags);
-       } while (mcount);
-}
-
-/*
- * multwrite_intr() is the handler for disk multwrite interrupts
- */
-static ide_startstop_t multwrite_intr (ide_drive_t *drive)
-{
-       ide_hwgroup_t *hwgroup  = HWGROUP(drive);
-       ide_hwif_t *hwif        = HWIF(drive);
-       struct request *rq      = &hwgroup->wrq;
-       struct bio *bio         = rq->bio;
-       u8 stat;
-
-       stat = hwif->INB(IDE_STATUS_REG);
-       if (OK_STAT(stat, DRIVE_READY, drive->bad_wstat)) {
-               if (stat & DRQ_STAT) {
-                       /*
-                        *      The drive wants data. Remember rq is the copy
-                        *      of the request
-                        */
-                       if (rq->nr_sectors) {
-                               ide_multwrite(drive, drive->mult_count);
-                               ide_set_handler(drive, &multwrite_intr, WAIT_CMD, NULL);
-                               return ide_started;
-                       }
-               } else {
-                       /*
-                        *      If the copy has all the blocks completed then
-                        *      we can end the original request.
-                        */
-                       if (!rq->nr_sectors) {  /* all done? */
-                               bio->bi_idx = bio->bi_vcnt - rq->nr_cbio_segments;
-                               rq = hwgroup->rq;
-                               ide_end_request(drive, 1, rq->nr_sectors);
-                               return ide_stopped;
-                       }
-               }
-               bio->bi_idx = bio->bi_vcnt - rq->nr_cbio_segments;
-               /* the original code did this here (?) */
-               return ide_stopped;
-       }
-       bio->bi_idx = bio->bi_vcnt - rq->nr_cbio_segments;
-       return DRIVER(drive)->error(drive, "multwrite_intr", stat);
-}
-
 /*
  * __ide_do_rw_disk() issues READ and WRITE commands to a disk,
  * using LBA if supported, or CHS otherwise, to address sectors.
- * It also takes care of issuing special DRIVE_CMDs.
  */
-ide_startstop_t __ide_do_rw_disk (ide_drive_t *drive, struct request *rq, sector_t block)
+static ide_startstop_t __ide_do_rw_disk(ide_drive_t *drive, struct request *rq, sector_t block)
 {
        ide_hwif_t *hwif        = HWIF(drive);
        unsigned int dma        = drive->using_dma;
@@ -348,18 +171,28 @@ ide_startstop_t __ide_do_rw_disk (ide_drive_t *drive, struct request *rq, sector
        nsectors.all            = (u16) rq->nr_sectors;
 
        if (hwif->no_lba48_dma && lba48 && dma) {
-               if (rq->sector + rq->nr_sectors > 1ULL << 28)
+               if (block + rq->nr_sectors > 1ULL << 28)
                        dma = 0;
+               else
+                       lba48 = 0;
+       }
+
+       if (!dma) {
+               ide_init_sg_cmd(drive, rq);
+               ide_map_sg(drive, rq);
        }
 
        if (IDE_CONTROL_REG)
                hwif->OUTB(drive->ctl, IDE_CONTROL_REG);
 
+       /* FIXME: SELECT_MASK(drive, 0) ? */
+
        if (drive->select.b.lba) {
-               if (drive->addressing == 1) {
+               if (lba48) {
                        task_ioreg_t tasklets[10];
 
-                       pr_debug("%s: LBA=0x%012llx\n", drive->name, block);
+                       pr_debug("%s: LBA=0x%012llx\n", drive->name,
+                                       (unsigned long long)block);
 
                        tasklets[0] = 0;
                        tasklets[1] = 0;
@@ -419,171 +252,51 @@ ide_startstop_t __ide_do_rw_disk (ide_drive_t *drive, struct request *rq, sector
                hwif->OUTB(head|drive->select.all,IDE_SELECT_REG);
        }
 
-       if (rq_data_dir(rq) == READ) {
-               if (dma && !hwif->ide_dma_read(drive))
-                       return ide_started;
-
-               command = ((drive->mult_count) ?
-                          ((lba48) ? WIN_MULTREAD_EXT : WIN_MULTREAD) :
-                          ((lba48) ? WIN_READ_EXT : WIN_READ));
-               ide_execute_command(drive, command, &read_intr, WAIT_CMD, NULL);
-               return ide_started;
-       } else {
-               ide_startstop_t startstop;
-
-               if (dma && !hwif->ide_dma_write(drive))
+       if (dma) {
+               if (!hwif->dma_setup(drive)) {
+                       if (rq_data_dir(rq)) {
+                               command = lba48 ? WIN_WRITEDMA_EXT : WIN_WRITEDMA;
+                               if (drive->vdma)
+                                       command = lba48 ? WIN_WRITE_EXT: WIN_WRITE;
+                       } else {
+                               command = lba48 ? WIN_READDMA_EXT : WIN_READDMA;
+                               if (drive->vdma)
+                                       command = lba48 ? WIN_READ_EXT: WIN_READ;
+                       }
+                       hwif->dma_exec_cmd(drive, command);
+                       hwif->dma_start(drive);
                        return ide_started;
-
-               command = ((drive->mult_count) ?
-                          ((lba48) ? WIN_MULTWRITE_EXT : WIN_MULTWRITE) :
-                          ((lba48) ? WIN_WRITE_EXT : WIN_WRITE));
-               hwif->OUTB(command, IDE_COMMAND_REG);
-
-               if (ide_wait_stat(&startstop, drive, DATA_READY,
-                               drive->bad_wstat, WAIT_DRQ)) {
-                       printk(KERN_ERR "%s: no DRQ after issuing %s\n",
-                               drive->name,
-                               drive->mult_count ? "MULTWRITE" : "WRITE");
-                       return startstop;
                }
-               if (!drive->unmask)
-                       local_irq_disable();
-               if (drive->mult_count) {
-                       ide_hwgroup_t *hwgroup = HWGROUP(drive);
-
-                       hwgroup->wrq = *rq; /* scratchpad */
-                       ide_set_handler(drive, &multwrite_intr, WAIT_CMD, NULL);
-                       ide_multwrite(drive, drive->mult_count);
-               } else {
-                       unsigned long flags;
-                       char *to = ide_map_buffer(rq, &flags);
-                       ide_set_handler(drive, &write_intr, WAIT_CMD, NULL);
-                       taskfile_output_data(drive, to, SECTOR_WORDS);
-                       ide_unmap_buffer(rq, to, &flags);
-               }
-               return ide_started;
-       }
-}
-EXPORT_SYMBOL_GPL(__ide_do_rw_disk);
-
-#else /* CONFIG_IDE_TASKFILE_IO */
-
-static ide_startstop_t chs_rw_disk(ide_drive_t *, struct request *, unsigned long);
-static ide_startstop_t lba_28_rw_disk(ide_drive_t *, struct request *, unsigned long);
-static ide_startstop_t lba_48_rw_disk(ide_drive_t *, struct request *, unsigned long long);
-
-/*
- * __ide_do_rw_disk() issues READ and WRITE commands to a disk,
- * using LBA if supported, or CHS otherwise, to address sectors.
- * It also takes care of issuing special DRIVE_CMDs.
- */
-ide_startstop_t __ide_do_rw_disk (ide_drive_t *drive, struct request *rq, sector_t block)
-{
-       /*
-        * 268435455  == 137439 MB or 28bit limit
-        *
-        * need to add split taskfile operations based on 28bit threshold.
-        */
-       if (drive->addressing == 1)             /* 48-bit LBA */
-               return lba_48_rw_disk(drive, rq, (unsigned long long) block);
-       if (drive->select.b.lba)                /* 28-bit LBA */
-               return lba_28_rw_disk(drive, rq, (unsigned long) block);
-
-       /* 28-bit CHS : DIE DIE DIE piece of legacy crap!!! */
-       return chs_rw_disk(drive, rq, (unsigned long) block);
-}
-EXPORT_SYMBOL_GPL(__ide_do_rw_disk);
-
-static u8 get_command(ide_drive_t *drive, struct request *rq, ide_task_t *task)
-{
-       unsigned int lba48 = (drive->addressing == 1) ? 1 : 0;
-       unsigned int dma = drive->using_dma;
-
-       if (drive->hwif->no_lba48_dma && lba48 && dma) {
-               if (rq->sector + rq->nr_sectors > 1ULL << 28)
-                       dma = 0;
+               /* fallback to PIO */
+               ide_init_sg_cmd(drive, rq);
        }
 
        if (rq_data_dir(rq) == READ) {
-               task->command_type = IDE_DRIVE_TASK_IN;
-               if (dma)
-                       return lba48 ? WIN_READDMA_EXT : WIN_READDMA;
-               task->handler = &task_in_intr;
+
                if (drive->mult_count) {
-                       task->data_phase = TASKFILE_MULTI_IN;
-                       return lba48 ? WIN_MULTREAD_EXT : WIN_MULTREAD;
+                       hwif->data_phase = TASKFILE_MULTI_IN;
+                       command = lba48 ? WIN_MULTREAD_EXT : WIN_MULTREAD;
+               } else {
+                       hwif->data_phase = TASKFILE_IN;
+                       command = lba48 ? WIN_READ_EXT : WIN_READ;
                }
-               task->data_phase = TASKFILE_IN;
-               return lba48 ? WIN_READ_EXT : WIN_READ;
+
+               ide_execute_command(drive, command, &task_in_intr, WAIT_CMD, NULL);
+               return ide_started;
        } else {
-               task->command_type = IDE_DRIVE_TASK_RAW_WRITE;
-               if (dma)
-                       return lba48 ? WIN_WRITEDMA_EXT : WIN_WRITEDMA;
-               task->prehandler = &pre_task_out_intr;
-               task->handler = &task_out_intr;
                if (drive->mult_count) {
-                       task->data_phase = TASKFILE_MULTI_OUT;
-                       return lba48 ? WIN_MULTWRITE_EXT : WIN_MULTWRITE;
+                       hwif->data_phase = TASKFILE_MULTI_OUT;
+                       command = lba48 ? WIN_MULTWRITE_EXT : WIN_MULTWRITE;
+               } else {
+                       hwif->data_phase = TASKFILE_OUT;
+                       command = lba48 ? WIN_WRITE_EXT : WIN_WRITE;
                }
-               task->data_phase = TASKFILE_OUT;
-               return lba48 ? WIN_WRITE_EXT : WIN_WRITE;
-       }
-}
-
-static ide_startstop_t chs_rw_disk (ide_drive_t *drive, struct request *rq, unsigned long block)
-{
-       ide_task_t              args;
-       int                     sectors;
-       ata_nsector_t           nsectors;
-       unsigned int track      = (block / drive->sect);
-       unsigned int sect       = (block % drive->sect) + 1;
-       unsigned int head       = (track % drive->head);
-       unsigned int cyl        = (track / drive->head);
 
-       nsectors.all = (u16) rq->nr_sectors;
-
-       pr_debug("%s: CHS=%u/%u/%u\n", drive->name, cyl, head, sect);
-
-       memset(&args, 0, sizeof(ide_task_t));
-
-       sectors = (rq->nr_sectors == 256) ? 0x00 : rq->nr_sectors;
-
-       args.tfRegister[IDE_NSECTOR_OFFSET]     = sectors;
-       args.tfRegister[IDE_SECTOR_OFFSET]      = sect;
-       args.tfRegister[IDE_LCYL_OFFSET]        = cyl;
-       args.tfRegister[IDE_HCYL_OFFSET]        = (cyl>>8);
-       args.tfRegister[IDE_SELECT_OFFSET]      = head;
-       args.tfRegister[IDE_SELECT_OFFSET]      |= drive->select.all;
-       args.tfRegister[IDE_COMMAND_OFFSET]     = get_command(drive, rq, &args);
-       args.rq                                 = (struct request *) rq;
-       rq->special                             = (ide_task_t *)&args;
-       drive->hwif->data_phase = args.data_phase;
-       return do_rw_taskfile(drive, &args);
-}
-
-static ide_startstop_t lba_28_rw_disk (ide_drive_t *drive, struct request *rq, unsigned long block)
-{
-       ide_task_t              args;
-       int                     sectors;
-       ata_nsector_t           nsectors;
-
-       nsectors.all = (u16) rq->nr_sectors;
-
-       memset(&args, 0, sizeof(ide_task_t));
+               /* FIXME: ->OUTBSYNC ? */
+               hwif->OUTB(command, IDE_COMMAND_REG);
 
-       sectors = (rq->nr_sectors == 256) ? 0x00 : rq->nr_sectors;
-
-       args.tfRegister[IDE_NSECTOR_OFFSET]     = sectors;
-       args.tfRegister[IDE_SECTOR_OFFSET]      = block;
-       args.tfRegister[IDE_LCYL_OFFSET]        = (block>>=8);
-       args.tfRegister[IDE_HCYL_OFFSET]        = (block>>=8);
-       args.tfRegister[IDE_SELECT_OFFSET]      = ((block>>8)&0x0f);
-       args.tfRegister[IDE_SELECT_OFFSET]      |= drive->select.all;
-       args.tfRegister[IDE_COMMAND_OFFSET]     = get_command(drive, rq, &args);
-       args.rq                                 = (struct request *) rq;
-       rq->special                             = (ide_task_t *)&args;
-       drive->hwif->data_phase = args.data_phase;
-       return do_rw_taskfile(drive, &args);
+               return pre_task_out_intr(drive, rq);
+       }
 }
 
 /*
@@ -592,38 +305,6 @@ static ide_startstop_t lba_28_rw_disk (ide_drive_t *drive, struct request *rq, u
  * 1073741822 == 549756 MB or 48bit addressing fake drive
  */
 
-static ide_startstop_t lba_48_rw_disk (ide_drive_t *drive, struct request *rq, unsigned long long block)
-{
-       ide_task_t              args;
-       int                     sectors;
-       ata_nsector_t           nsectors;
-
-       nsectors.all = (u16) rq->nr_sectors;
-
-       memset(&args, 0, sizeof(ide_task_t));
-
-       sectors = (rq->nr_sectors == 65536) ? 0 : rq->nr_sectors;
-
-       args.tfRegister[IDE_NSECTOR_OFFSET]     = sectors;
-       args.hobRegister[IDE_NSECTOR_OFFSET]    = sectors >> 8;
-       args.tfRegister[IDE_SECTOR_OFFSET]      = block;        /* low lba */
-       args.tfRegister[IDE_LCYL_OFFSET]        = (block>>=8);  /* mid lba */
-       args.tfRegister[IDE_HCYL_OFFSET]        = (block>>=8);  /* hi  lba */
-       args.tfRegister[IDE_SELECT_OFFSET]      = drive->select.all;
-       args.tfRegister[IDE_COMMAND_OFFSET]     = get_command(drive, rq, &args);
-       args.hobRegister[IDE_SECTOR_OFFSET]     = (block>>=8);  /* low lba */
-       args.hobRegister[IDE_LCYL_OFFSET]       = (block>>=8);  /* mid lba */
-       args.hobRegister[IDE_HCYL_OFFSET]       = (block>>=8);  /* hi  lba */
-       args.hobRegister[IDE_SELECT_OFFSET]     = drive->select.all;
-       args.hobRegister[IDE_CONTROL_OFFSET_HOB]= (drive->ctl|0x80);
-       args.rq                                 = (struct request *) rq;
-       rq->special                             = (ide_task_t *)&args;
-       drive->hwif->data_phase = args.data_phase;
-       return do_rw_taskfile(drive, &args);
-}
-
-#endif /* CONFIG_IDE_TASKFILE_IO */
-
 static ide_startstop_t ide_do_rw_disk (ide_drive_t *drive, struct request *rq, sector_t block)
 {
        ide_hwif_t *hwif = HWIF(drive);
@@ -636,201 +317,17 @@ static ide_startstop_t ide_do_rw_disk (ide_drive_t *drive, struct request *rq, s
                return ide_stopped;
        }
 
+       ledtrig_ide_activity();
+
        pr_debug("%s: %sing: block=%llu, sectors=%lu, buffer=0x%08lx\n",
                 drive->name, rq_data_dir(rq) == READ ? "read" : "writ",
-                block, rq->nr_sectors, (unsigned long)rq->buffer);
+                (unsigned long long)block, rq->nr_sectors,
+                (unsigned long)rq->buffer);
 
        if (hwif->rw_disk)
-               return hwif->rw_disk(drive, rq, block);
-       else
-               return __ide_do_rw_disk(drive, rq, block);
-}
+               hwif->rw_disk(drive, rq);
 
-static u8 idedisk_dump_status (ide_drive_t *drive, const char *msg, u8 stat)
-{
-       ide_hwif_t *hwif = HWIF(drive);
-       unsigned long flags;
-       u8 err = 0;
-
-       local_irq_set(flags);
-       printk("%s: %s: status=0x%02x", drive->name, msg, stat);
-       printk(" { ");
-       if (stat & BUSY_STAT)
-               printk("Busy ");
-       else {
-               if (stat & READY_STAT)  printk("DriveReady ");
-               if (stat & WRERR_STAT)  printk("DeviceFault ");
-               if (stat & SEEK_STAT)   printk("SeekComplete ");
-               if (stat & DRQ_STAT)    printk("DataRequest ");
-               if (stat & ECC_STAT)    printk("CorrectedError ");
-               if (stat & INDEX_STAT)  printk("Index ");
-               if (stat & ERR_STAT)    printk("Error ");
-       }
-       printk("}");
-       printk("\n");
-       if ((stat & (BUSY_STAT|ERR_STAT)) == ERR_STAT) {
-               err = hwif->INB(IDE_ERROR_REG);
-               printk("%s: %s: error=0x%02x", drive->name, msg, err);
-               printk(" { ");
-               if (err & ABRT_ERR)     printk("DriveStatusError ");
-               if (err & ICRC_ERR)
-                       printk("Bad%s ", (err & ABRT_ERR) ? "CRC" : "Sector");
-               if (err & ECC_ERR)      printk("UncorrectableError ");
-               if (err & ID_ERR)       printk("SectorIdNotFound ");
-               if (err & TRK0_ERR)     printk("TrackZeroNotFound ");
-               if (err & MARK_ERR)     printk("AddrMarkNotFound ");
-               printk("}");
-               if ((err & (BBD_ERR | ABRT_ERR)) == BBD_ERR ||
-                   (err & (ECC_ERR|ID_ERR|MARK_ERR))) {
-                       if (drive->addressing == 1) {
-                               __u64 sectors = 0;
-                               u32 low = 0, high = 0;
-                               low = ide_read_24(drive);
-                               hwif->OUTB(drive->ctl|0x80, IDE_CONTROL_REG);
-                               high = ide_read_24(drive);
-                               sectors = ((__u64)high << 24) | low;
-                               printk(", LBAsect=%llu, high=%d, low=%d",
-                                      (unsigned long long) sectors,
-                                      high, low);
-                       } else {
-                               u8 cur = hwif->INB(IDE_SELECT_REG);
-                               if (cur & 0x40) {       /* using LBA? */
-                                       printk(", LBAsect=%ld", (unsigned long)
-                                        ((cur&0xf)<<24)
-                                        |(hwif->INB(IDE_HCYL_REG)<<16)
-                                        |(hwif->INB(IDE_LCYL_REG)<<8)
-                                        | hwif->INB(IDE_SECTOR_REG));
-                               } else {
-                                       printk(", CHS=%d/%d/%d",
-                                        (hwif->INB(IDE_HCYL_REG)<<8) +
-                                         hwif->INB(IDE_LCYL_REG),
-                                         cur & 0xf,
-                                         hwif->INB(IDE_SECTOR_REG));
-                               }
-                       }
-                       if (HWGROUP(drive) && HWGROUP(drive)->rq)
-                               printk(", sector=%llu",
-                                       (unsigned long long)HWGROUP(drive)->rq->sector);
-               }
-       }
-       printk("\n");
-       {
-               struct request *rq;
-               unsigned char opcode = 0;
-               int found = 0;
-
-               spin_lock(&ide_lock);
-               rq = HWGROUP(drive)->rq;
-               spin_unlock(&ide_lock);
-               if (!rq)
-                       goto out;
-               if (rq->flags & (REQ_DRIVE_CMD | REQ_DRIVE_TASK)) {
-                       char *args = rq->buffer;
-                       if (args) {
-                               opcode = args[0];
-                               found = 1;
-                       }
-               } else if (rq->flags & REQ_DRIVE_TASKFILE) {
-                       ide_task_t *args = rq->special;
-                       if (args) {
-                               task_struct_t *tf = (task_struct_t *) args->tfRegister;
-                               opcode = tf->command;
-                               found = 1;
-                       }
-               }
-               printk("ide: failed opcode was: ");
-               if (!found)
-                       printk("unknown\n");
-               else
-                       printk("0x%02x\n", opcode);
-       }
-out:
-       local_irq_restore(flags);
-       return err;
-}
-
-ide_startstop_t idedisk_error (ide_drive_t *drive, const char *msg, u8 stat)
-{
-       ide_hwif_t *hwif;
-       struct request *rq;
-       u8 err;
-
-       err = idedisk_dump_status(drive, msg, stat);
-
-       if (drive == NULL || (rq = HWGROUP(drive)->rq) == NULL)
-               return ide_stopped;
-
-       hwif = HWIF(drive);
-       /* retry only "normal" I/O: */
-       if (rq->flags & (REQ_DRIVE_CMD | REQ_DRIVE_TASK | REQ_DRIVE_TASKFILE)) {
-               rq->errors = 1;
-               ide_end_drive_cmd(drive, stat, err);
-               return ide_stopped;
-       }
-#ifdef CONFIG_IDE_TASKFILE_IO
-       /* make rq completion pointers new submission pointers */
-       blk_rq_prep_restart(rq);
-#endif
-
-       if (stat & BUSY_STAT || ((stat & WRERR_STAT) && !drive->nowerr)) {
-               /* other bits are useless when BUSY */
-               rq->errors |= ERROR_RESET;
-       } else if (stat & ERR_STAT) {
-               /* err has different meaning on cdrom and tape */
-               if (err == ABRT_ERR) {
-                       if (drive->select.b.lba &&
-                           /* some newer drives don't support WIN_SPECIFY */
-                           hwif->INB(IDE_COMMAND_REG) == WIN_SPECIFY)
-                               return ide_stopped;
-               } else if ((err & BAD_CRC) == BAD_CRC) {
-                       /* UDMA crc error, just retry the operation */
-                       drive->crc_count++;
-               } else if (err & (BBD_ERR | ECC_ERR)) {
-                       /* retries won't help these */
-                       rq->errors = ERROR_MAX;
-               } else if (err & TRK0_ERR) {
-                       /* help it find track zero */
-                       rq->errors |= ERROR_RECAL;
-               }
-       }
-       if ((stat & DRQ_STAT) && rq_data_dir(rq) == READ)
-               try_to_flush_leftover_data(drive);
-       if (hwif->INB(IDE_STATUS_REG) & (BUSY_STAT|DRQ_STAT)) {
-               /* force an abort */
-               hwif->OUTB(WIN_IDLEIMMEDIATE,IDE_COMMAND_REG);
-       }
-       if (rq->errors >= ERROR_MAX || blk_noretry_request(rq))
-               DRIVER(drive)->end_request(drive, 0, 0);
-       else {
-               if ((rq->errors & ERROR_RESET) == ERROR_RESET) {
-                       ++rq->errors;
-                       return ide_do_reset(drive);
-               }
-               if ((rq->errors & ERROR_RECAL) == ERROR_RECAL)
-                       drive->special.b.recalibrate = 1;
-               ++rq->errors;
-       }
-       return ide_stopped;
-}
-
-ide_startstop_t idedisk_abort(ide_drive_t *drive, const char *msg)
-{
-       ide_hwif_t *hwif;
-       struct request *rq;
-
-       if (drive == NULL || (rq = HWGROUP(drive)->rq) == NULL)
-               return ide_stopped;
-
-       hwif = HWIF(drive);
-
-       if (rq->flags & (REQ_DRIVE_CMD | REQ_DRIVE_TASK | REQ_DRIVE_TASKFILE)) {
-               rq->errors = 1;
-               ide_end_drive_cmd(drive, BUSY_STAT, 0);
-               return ide_stopped;
-       }
-
-       DRIVER(drive)->end_request(drive, 0, 0);
-       return ide_stopped;
+       return __ide_do_rw_disk(drive, rq, block);
 }
 
 /*
@@ -985,7 +482,7 @@ static inline int idedisk_supports_lba48(const struct hd_driveid *id)
               && id->lba_capacity_2;
 }
 
-static inline void idedisk_check_hpa(ide_drive_t *drive)
+static void idedisk_check_hpa(ide_drive_t *drive)
 {
        unsigned long long capacity, set_max;
        int lba48 = idedisk_supports_lba48(drive->id);
@@ -1006,9 +503,6 @@ static inline void idedisk_check_hpa(ide_drive_t *drive)
                         capacity, sectors_to_MB(capacity),
                         set_max, sectors_to_MB(set_max));
 
-       if (!drive->stroke)
-               return;
-
        if (lba48)
                set_max = idedisk_set_max_address_ext(drive, set_max);
        else
@@ -1066,73 +560,6 @@ static sector_t idedisk_capacity (ide_drive_t *drive)
        return drive->capacity64 - drive->sect0;
 }
 
-static ide_startstop_t idedisk_special (ide_drive_t *drive)
-{
-       special_t *s = &drive->special;
-
-       if (s->b.set_geometry) {
-               s->b.set_geometry       = 0;
-               if (!IS_PDC4030_DRIVE) {
-                       ide_task_t args;
-                       memset(&args, 0, sizeof(ide_task_t));
-                       args.tfRegister[IDE_NSECTOR_OFFSET] = drive->sect;
-                       args.tfRegister[IDE_SECTOR_OFFSET]  = drive->sect;
-                       args.tfRegister[IDE_LCYL_OFFSET]    = drive->cyl;
-                       args.tfRegister[IDE_HCYL_OFFSET]    = drive->cyl>>8;
-                       args.tfRegister[IDE_SELECT_OFFSET]  = ((drive->head-1)|drive->select.all)&0xBF;
-                       args.tfRegister[IDE_COMMAND_OFFSET] = WIN_SPECIFY;
-                       args.command_type = IDE_DRIVE_TASK_NO_DATA;
-                       args.handler      = &set_geometry_intr;
-                       do_rw_taskfile(drive, &args);
-               }
-       } else if (s->b.recalibrate) {
-               s->b.recalibrate = 0;
-               if (!IS_PDC4030_DRIVE) {
-                       ide_task_t args;
-                       memset(&args, 0, sizeof(ide_task_t));
-                       args.tfRegister[IDE_NSECTOR_OFFSET] = drive->sect;
-                       args.tfRegister[IDE_COMMAND_OFFSET] = WIN_RESTORE;
-                       args.command_type = IDE_DRIVE_TASK_NO_DATA;
-                       args.handler      = &recal_intr;
-                       do_rw_taskfile(drive, &args);
-               }
-       } else if (s->b.set_multmode) {
-               s->b.set_multmode = 0;
-               if (drive->mult_req > drive->id->max_multsect)
-                       drive->mult_req = drive->id->max_multsect;
-               if (!IS_PDC4030_DRIVE) {
-                       ide_task_t args;
-                       memset(&args, 0, sizeof(ide_task_t));
-                       args.tfRegister[IDE_NSECTOR_OFFSET] = drive->mult_req;
-                       args.tfRegister[IDE_COMMAND_OFFSET] = WIN_SETMULT;
-                       args.command_type = IDE_DRIVE_TASK_NO_DATA;
-                       args.handler      = &set_multmode_intr;
-                       do_rw_taskfile(drive, &args);
-               }
-       } else if (s->all) {
-               int special = s->all;
-               s->all = 0;
-               printk(KERN_ERR "%s: bad special flag: 0x%02x\n", drive->name, special);
-               return ide_stopped;
-       }
-       return IS_PDC4030_DRIVE ? ide_stopped : ide_started;
-}
-
-static void idedisk_pre_reset (ide_drive_t *drive)
-{
-       int legacy = (drive->id->cfs_enable_2 & 0x0400) ? 0 : 1;
-
-       drive->special.all = 0;
-       drive->special.b.set_geometry = legacy;
-       drive->special.b.recalibrate  = legacy;
-       if (OK_TO_RESET_CONTROLLER)
-               drive->mult_count = 0;
-       if (!drive->keep_settings && !drive->using_dma)
-               drive->mult_req = 0;
-       if (drive->mult_req != drive->mult_count)
-               drive->special.b.set_multmode = 1;
-}
-
 #ifdef CONFIG_PROC_FS
 
 static int smart_enable(ide_drive_t *drive)
@@ -1176,6 +603,7 @@ static int get_smart_thresholds(ide_drive_t *drive, u8 *buf)
        args.tfRegister[IDE_HCYL_OFFSET]        = SMART_HCYL_PASS;
        args.tfRegister[IDE_COMMAND_OFFSET]     = WIN_SMART;
        args.command_type                       = IDE_DRIVE_TASK_IN;
+       args.data_phase                         = TASKFILE_IN;
        args.handler                            = &task_in_intr;
        (void) smart_enable(drive);
        return ide_raw_taskfile(drive, &args, buf);
@@ -1195,6 +623,16 @@ static int proc_idedisk_read_cache
        PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
 }
 
+static int proc_idedisk_read_capacity
+       (char *page, char **start, off_t off, int count, int *eof, void *data)
+{
+       ide_drive_t*drive = (ide_drive_t *)data;
+       int len;
+
+       len = sprintf(page,"%llu\n", (long long)idedisk_capacity(drive));
+       PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
+}
+
 static int proc_idedisk_read_smart_thresholds
        (char *page, char **start, off_t off, int count, int *eof, void *data)
 {
@@ -1235,6 +673,7 @@ static int proc_idedisk_read_smart_values
 
 static ide_proc_entry_t idedisk_proc[] = {
        { "cache",              S_IFREG|S_IRUGO,        proc_idedisk_read_cache,                NULL },
+       { "capacity",           S_IFREG|S_IRUGO,        proc_idedisk_read_capacity,             NULL },
        { "geometry",           S_IFREG|S_IRUGO,        proc_ide_read_geometry,                 NULL },
        { "smart_values",       S_IFREG|S_IRUSR,        proc_idedisk_read_smart_values,         NULL },
        { "smart_thresholds",   S_IFREG|S_IRUSR,        proc_idedisk_read_smart_thresholds,     NULL },
@@ -1247,17 +686,9 @@ static ide_proc_entry_t idedisk_proc[] = {
 
 #endif /* CONFIG_PROC_FS */
 
-static int idedisk_issue_flush(request_queue_t *q, struct gendisk *disk,
-                              sector_t *error_sector)
+static void idedisk_prepare_flush(request_queue_t *q, struct request *rq)
 {
        ide_drive_t *drive = q->queuedata;
-       struct request *rq;
-       int ret;
-
-       if (!drive->wcache)
-               return 0;
-
-       rq = blk_get_request(q, WRITE, __GFP_WAIT);
 
        memset(rq->cmd, 0, sizeof(rq->cmd));
 
@@ -1268,10 +699,26 @@ static int idedisk_issue_flush(request_queue_t *q, struct gendisk *disk,
                rq->cmd[0] = WIN_FLUSH_CACHE;
 
 
-       rq->flags |= REQ_DRIVE_TASK | REQ_SOFTBARRIER;
+       rq->cmd_type = REQ_TYPE_ATA_TASK;
+       rq->cmd_flags |= REQ_SOFTBARRIER;
        rq->buffer = rq->cmd;
+}
+
+static int idedisk_issue_flush(request_queue_t *q, struct gendisk *disk,
+                              sector_t *error_sector)
+{
+       ide_drive_t *drive = q->queuedata;
+       struct request *rq;
+       int ret;
 
-       ret = blk_execute_rq(q, disk, rq);
+       if (!drive->wcache)
+               return 0;
+
+       rq = blk_get_request(q, WRITE, __GFP_WAIT);
+
+       idedisk_prepare_flush(q, rq);
+
+       ret = blk_execute_rq(q, disk, rq, 0);
 
        /*
         * if we failed and caller wants error offset, get it
@@ -1294,7 +741,7 @@ static int set_multcount(ide_drive_t *drive, int arg)
        if (drive->special.b.set_multmode)
                return -EBUSY;
        ide_init_drive_cmd (&rq);
-       rq.flags = REQ_DRIVE_CMD;
+       rq.cmd_type = REQ_TYPE_ATA_CMD;
        drive->mult_req = arg;
        drive->special.b.set_multmode = 1;
        (void) ide_do_drive_cmd (drive, &rq, ide_wait);
@@ -1311,27 +758,64 @@ static int set_nowerr(ide_drive_t *drive, int arg)
        return 0;
 }
 
+static void update_ordered(ide_drive_t *drive)
+{
+       struct hd_driveid *id = drive->id;
+       unsigned ordered = QUEUE_ORDERED_NONE;
+       prepare_flush_fn *prep_fn = NULL;
+       issue_flush_fn *issue_fn = NULL;
+
+       if (drive->wcache) {
+               unsigned long long capacity;
+               int barrier;
+               /*
+                * We must avoid issuing commands a drive does not
+                * understand or we may crash it. We check flush cache
+                * is supported. We also check we have the LBA48 flush
+                * cache if the drive capacity is too large. By this
+                * time we have trimmed the drive capacity if LBA48 is
+                * not available so we don't need to recheck that.
+                */
+               capacity = idedisk_capacity(drive);
+               barrier = ide_id_has_flush_cache(id) && !drive->noflush &&
+                       (drive->addressing == 0 || capacity <= (1ULL << 28) ||
+                        ide_id_has_flush_cache_ext(id));
+
+               printk(KERN_INFO "%s: cache flushes %ssupported\n",
+                      drive->name, barrier ? "" : "not ");
+
+               if (barrier) {
+                       ordered = QUEUE_ORDERED_DRAIN_FLUSH;
+                       prep_fn = idedisk_prepare_flush;
+                       issue_fn = idedisk_issue_flush;
+               }
+       } else
+               ordered = QUEUE_ORDERED_DRAIN;
+
+       blk_queue_ordered(drive->queue, ordered, prep_fn);
+       blk_queue_issue_flush_fn(drive->queue, issue_fn);
+}
+
 static int write_cache(ide_drive_t *drive, int arg)
 {
        ide_task_t args;
-       int err;
-
-       if (!ide_id_has_flush_cache(drive->id))
-               return 1;
+       int err = 1;
 
-       memset(&args, 0, sizeof(ide_task_t));
-       args.tfRegister[IDE_FEATURE_OFFSET]     = (arg) ?
+       if (ide_id_has_flush_cache(drive->id)) {
+               memset(&args, 0, sizeof(ide_task_t));
+               args.tfRegister[IDE_FEATURE_OFFSET]     = (arg) ?
                        SETFEATURES_EN_WCACHE : SETFEATURES_DIS_WCACHE;
-       args.tfRegister[IDE_COMMAND_OFFSET]     = WIN_SETFEATURES;
-       args.command_type                       = IDE_DRIVE_TASK_NO_DATA;
-       args.handler                            = &task_no_data_intr;
+               args.tfRegister[IDE_COMMAND_OFFSET]     = WIN_SETFEATURES;
+               args.command_type               = IDE_DRIVE_TASK_NO_DATA;
+               args.handler                    = &task_no_data_intr;
+               err = ide_raw_taskfile(drive, &args, NULL);
+               if (err == 0)
+                       drive->wcache = arg;
+       }
 
-       err = ide_raw_taskfile(drive, &args, NULL);
-       if (err)
-               return err;
+       update_ordered(drive);
 
-       drive->wcache = arg;
-       return 0;
+       return err;
 }
 
 static int do_idedisk_flushcache (ide_drive_t *drive)
@@ -1401,106 +885,17 @@ static void idedisk_add_settings(ide_drive_t *drive)
        ide_add_setting(drive,  "max_failures",         SETTING_RW,                                     -1,                     -1,                     TYPE_INT,       0,      65535,                          1,      1,      &drive->max_failures,           NULL);
 }
 
-/*
- * Power Management state machine. This one is rather trivial for now,
- * we should probably add more, like switching back to PIO on suspend
- * to help some BIOSes, re-do the door locking on resume, etc...
- */
-
-enum {
-       idedisk_pm_flush_cache  = ide_pm_state_start_suspend,
-       idedisk_pm_standby,
-
-       idedisk_pm_idle         = ide_pm_state_start_resume,
-       idedisk_pm_restore_dma,
-};
-
-static void idedisk_complete_power_step (ide_drive_t *drive, struct request *rq, u8 stat, u8 error)
-{
-       switch (rq->pm->pm_step) {
-       case idedisk_pm_flush_cache:    /* Suspend step 1 (flush cache) complete */
-               if (rq->pm->pm_state == 4)
-                       rq->pm->pm_step = ide_pm_state_completed;
-               else
-                       rq->pm->pm_step = idedisk_pm_standby;
-               break;
-       case idedisk_pm_standby:        /* Suspend step 2 (standby) complete */
-               rq->pm->pm_step = ide_pm_state_completed;
-               break;
-       case idedisk_pm_idle:           /* Resume step 1 (idle) complete */
-               rq->pm->pm_step = idedisk_pm_restore_dma;
-               break;
-       }
-}
-
-static ide_startstop_t idedisk_start_power_step (ide_drive_t *drive, struct request *rq)
-{
-       ide_task_t *args = rq->special;
-
-       memset(args, 0, sizeof(*args));
-
-       switch (rq->pm->pm_step) {
-       case idedisk_pm_flush_cache:    /* Suspend step 1 (flush cache) */
-               /* Not supported? Switch to next step now. */
-               if (!drive->wcache || !ide_id_has_flush_cache(drive->id)) {
-                       idedisk_complete_power_step(drive, rq, 0, 0);
-                       return ide_stopped;
-               }
-               if (ide_id_has_flush_cache_ext(drive->id))
-                       args->tfRegister[IDE_COMMAND_OFFSET] = WIN_FLUSH_CACHE_EXT;
-               else
-                       args->tfRegister[IDE_COMMAND_OFFSET] = WIN_FLUSH_CACHE;
-               args->command_type = IDE_DRIVE_TASK_NO_DATA;
-               args->handler      = &task_no_data_intr;
-               return do_rw_taskfile(drive, args);
-
-       case idedisk_pm_standby:        /* Suspend step 2 (standby) */
-               args->tfRegister[IDE_COMMAND_OFFSET] = WIN_STANDBYNOW1;
-               args->command_type = IDE_DRIVE_TASK_NO_DATA;
-               args->handler      = &task_no_data_intr;
-               return do_rw_taskfile(drive, args);
-
-       case idedisk_pm_idle:           /* Resume step 1 (idle) */
-               args->tfRegister[IDE_COMMAND_OFFSET] = WIN_IDLEIMMEDIATE;
-               args->command_type = IDE_DRIVE_TASK_NO_DATA;
-               args->handler = task_no_data_intr;
-               return do_rw_taskfile(drive, args);
-
-       case idedisk_pm_restore_dma:    /* Resume step 2 (restore DMA) */
-               /*
-                * Right now, all we do is call hwif->ide_dma_check(drive),
-                * we could be smarter and check for current xfer_speed
-                * in struct drive etc...
-                * Also, this step could be implemented as a generic helper
-                * as most subdrivers will use it
-                */
-               if ((drive->id->capability & 1) == 0)
-                       break;
-               if (HWIF(drive)->ide_dma_check == NULL)
-                       break;
-               HWIF(drive)->ide_dma_check(drive);
-               break;
-       }
-       rq->pm->pm_step = ide_pm_state_completed;
-       return ide_stopped;
-}
-
 static void idedisk_setup (ide_drive_t *drive)
 {
        struct hd_driveid *id = drive->id;
        unsigned long long capacity;
-       int barrier;
 
        idedisk_add_settings(drive);
 
        if (drive->id_read == 0)
                return;
 
-       /*
-        * CompactFlash cards and their brethern look just like hard drives
-        * to us, but they are removable and don't have a doorlock mechanism.
-        */
-       if (drive->removable && !(drive->is_flash)) {
+       if (drive->removable) {
                /*
                 * Removable disks (eg. SYQUEST); ignore 'WD' drives 
                 */
@@ -1523,28 +918,6 @@ static void idedisk_setup (ide_drive_t *drive)
 
        printk(KERN_INFO "%s: max request size: %dKiB\n", drive->name, drive->queue->max_sectors / 2);
 
-       /* Extract geometry if we did not already have one for the drive */
-       if (!drive->cyl || !drive->head || !drive->sect) {
-               drive->cyl     = drive->bios_cyl  = id->cyls;
-               drive->head    = drive->bios_head = id->heads;
-               drive->sect    = drive->bios_sect = id->sectors;
-       }
-
-       /* Handle logical geometry translation by the drive */
-       if ((id->field_valid & 1) && id->cur_cyls &&
-           id->cur_heads && (id->cur_heads <= 16) && id->cur_sectors) {
-               drive->cyl  = id->cur_cyls;
-               drive->head = id->cur_heads;
-               drive->sect = id->cur_sectors;
-       }
-
-       /* Use physical geometry if what we have still makes no sense */
-       if (drive->head > 16 && id->heads && id->heads <= 16) {
-               drive->cyl  = id->cyls;
-               drive->head = id->heads;
-               drive->sect = id->sectors;
-       }
-
        /* calculate drive capacity, and select LBA if possible */
        init_idedisk_capacity (drive);
 
@@ -1605,54 +978,14 @@ static void idedisk_setup (ide_drive_t *drive)
        printk(", CHS=%d/%d/%d", 
               drive->bios_cyl, drive->bios_head, drive->bios_sect);
        if (drive->using_dma)
-               (void) HWIF(drive)->ide_dma_verbose(drive);
+               ide_dma_verbose(drive);
        printk("\n");
 
-       drive->mult_count = 0;
-       if (id->max_multsect) {
-#ifdef CONFIG_IDEDISK_MULTI_MODE
-               id->multsect = ((id->max_multsect/2) > 1) ? id->max_multsect : 0;
-               id->multsect_valid = id->multsect ? 1 : 0;
-               drive->mult_req = id->multsect_valid ? id->max_multsect : INITIAL_MULT_COUNT;
-               drive->special.b.set_multmode = drive->mult_req ? 1 : 0;
-#else  /* original, pre IDE-NFG, per request of AC */
-               drive->mult_req = INITIAL_MULT_COUNT;
-               if (drive->mult_req > id->max_multsect)
-                       drive->mult_req = id->max_multsect;
-               if (drive->mult_req || ((id->multsect_valid & 1) && id->multsect))
-                       drive->special.b.set_multmode = 1;
-#endif /* CONFIG_IDEDISK_MULTI_MODE */
-       }
-       drive->no_io_32bit = id->dword_io ? 1 : 0;
-
        /* write cache enabled? */
        if ((id->csfo & 1) || (id->cfs_enable_1 & (1 << 5)))
                drive->wcache = 1;
 
        write_cache(drive, 1);
-
-       /*
-        * We must avoid issuing commands a drive does not understand
-        * or we may crash it. We check flush cache is supported. We also
-        * check we have the LBA48 flush cache if the drive capacity is
-        * too large. By this time we have trimmed the drive capacity if
-        * LBA48 is not available so we don't need to recheck that.
-        */
-       barrier = 0;
-       if (ide_id_has_flush_cache(id))
-               barrier = 1;
-       if (drive->addressing == 1) {
-               /* Can't issue the correct flush ? */
-               if (capacity > (1ULL << 28) && !ide_id_has_flush_cache_ext(id))
-                       barrier = 0;
-       }
-
-       printk(KERN_DEBUG "%s: cache flushes %ssupported\n",
-               drive->name, barrier ? "" : "not ");
-       if (barrier) {
-               blk_queue_ordered(drive->queue, 1);
-               blk_queue_issue_flush_fn(drive->queue, idedisk_issue_flush);
-       }
 }
 
 static void ide_cacheflush_p(ide_drive_t *drive)
@@ -1664,24 +997,36 @@ static void ide_cacheflush_p(ide_drive_t *drive)
                printk(KERN_INFO "%s: wcache flush failed!\n", drive->name);
 }
 
-static int idedisk_cleanup (ide_drive_t *drive)
+static void ide_disk_remove(ide_drive_t *drive)
 {
-       struct gendisk *g = drive->disk;
-       ide_cacheflush_p(drive);
-       if (ide_unregister_subdriver(drive))
-               return 1;
+       struct ide_disk_obj *idkp = drive->driver_data;
+       struct gendisk *g = idkp->disk;
+
+       ide_unregister_subdriver(drive, idkp->driver);
+
        del_gendisk(g);
-       drive->devfs_name[0] = '\0';
-       g->fops = ide_fops;
-       return 0;
-}
 
-static int idedisk_attach(ide_drive_t *drive);
+       ide_cacheflush_p(drive);
+
+       ide_disk_put(idkp);
+}
 
-static void ide_device_shutdown(struct device *dev)
+static void ide_disk_release(struct kref *kref)
 {
-       ide_drive_t *drive = container_of(dev, ide_drive_t, gendev);
+       struct ide_disk_obj *idkp = to_ide_disk(kref);
+       ide_drive_t *drive = idkp->drive;
+       struct gendisk *g = idkp->disk;
+
+       drive->driver_data = NULL;
+       g->private_data = NULL;
+       put_disk(g);
+       kfree(idkp);
+}
+
+static int ide_disk_probe(ide_drive_t *drive);
 
+static void ide_device_shutdown(ide_drive_t *drive)
+{
 #ifdef CONFIG_ALPHA
        /* On Alpha, halt(8) doesn't actually turn the machine off,
           it puts you into the sort of firmware monitor. Typically,
@@ -1703,40 +1048,39 @@ static void ide_device_shutdown(struct device *dev)
        }
 
        printk("Shutdown: %s\n", drive->name);
-       dev->bus->suspend(dev, PM_SUSPEND_STANDBY);
+       drive->gendev.bus->suspend(&drive->gendev, PMSG_SUSPEND);
 }
 
-/*
- *      IDE subdriver functions, registered with ide.c
- */
 static ide_driver_t idedisk_driver = {
-       .owner                  = THIS_MODULE,
        .gen_driver = {
-               .shutdown       = ide_device_shutdown,
+               .owner          = THIS_MODULE,
+               .name           = "ide-disk",
+               .bus            = &ide_bus_type,
        },
-       .name                   = "ide-disk",
+       .probe                  = ide_disk_probe,
+       .remove                 = ide_disk_remove,
+       .shutdown               = ide_device_shutdown,
        .version                = IDEDISK_VERSION,
        .media                  = ide_disk,
-       .busy                   = 0,
        .supports_dsc_overlap   = 0,
-       .cleanup                = idedisk_cleanup,
        .do_request             = ide_do_rw_disk,
-       .sense                  = idedisk_dump_status,
-       .error                  = idedisk_error,
-       .abort                  = idedisk_abort,
-       .pre_reset              = idedisk_pre_reset,
-       .capacity               = idedisk_capacity,
-       .special                = idedisk_special,
+       .end_request            = ide_end_request,
+       .error                  = __ide_error,
+       .abort                  = __ide_abort,
        .proc                   = idedisk_proc,
-       .attach                 = idedisk_attach,
-       .drives                 = LIST_HEAD_INIT(idedisk_driver.drives),
-       .start_power_step       = idedisk_start_power_step,
-       .complete_power_step    = idedisk_complete_power_step,
 };
 
 static int idedisk_open(struct inode *inode, struct file *filp)
 {
-       ide_drive_t *drive = inode->i_bdev->bd_disk->private_data;
+       struct gendisk *disk = inode->i_bdev->bd_disk;
+       struct ide_disk_obj *idkp;
+       ide_drive_t *drive;
+
+       if (!(idkp = ide_disk_get(disk)))
+               return -ENXIO;
+
+       drive = idkp->drive;
+
        drive->usage++;
        if (drive->removable && drive->usage == 1) {
                ide_task_t args;
@@ -1758,7 +1102,10 @@ static int idedisk_open(struct inode *inode, struct file *filp)
 
 static int idedisk_release(struct inode *inode, struct file *filp)
 {
-       ide_drive_t *drive = inode->i_bdev->bd_disk->private_data;
+       struct gendisk *disk = inode->i_bdev->bd_disk;
+       struct ide_disk_obj *idkp = ide_disk_g(disk);
+       ide_drive_t *drive = idkp->drive;
+
        if (drive->usage == 1)
                ide_cacheflush_p(drive);
        if (drive->removable && drive->usage == 1) {
@@ -1771,6 +1118,20 @@ static int idedisk_release(struct inode *inode, struct file *filp)
                        drive->doorlocking = 0;
        }
        drive->usage--;
+
+       ide_disk_put(idkp);
+
+       return 0;
+}
+
+static int idedisk_getgeo(struct block_device *bdev, struct hd_geometry *geo)
+{
+       struct ide_disk_obj *idkp = ide_disk_g(bdev->bd_disk);
+       ide_drive_t *drive = idkp->drive;
+
+       geo->heads = drive->bios_head;
+       geo->sectors = drive->bios_sect;
+       geo->cylinders = (u16)drive->bios_cyl; /* truncate */
        return 0;
 }
 
@@ -1778,12 +1139,14 @@ static int idedisk_ioctl(struct inode *inode, struct file *file,
                        unsigned int cmd, unsigned long arg)
 {
        struct block_device *bdev = inode->i_bdev;
-       return generic_ide_ioctl(file, bdev, cmd, arg);
+       struct ide_disk_obj *idkp = ide_disk_g(bdev->bd_disk);
+       return generic_ide_ioctl(idkp->drive, file, bdev, cmd, arg);
 }
 
 static int idedisk_media_changed(struct gendisk *disk)
 {
-       ide_drive_t *drive = disk->private_data;
+       struct ide_disk_obj *idkp = ide_disk_g(disk);
+       ide_drive_t *drive = idkp->drive;
 
        /* do not scan partitions twice if this is a removable device */
        if (drive->attach) {
@@ -1796,8 +1159,8 @@ static int idedisk_media_changed(struct gendisk *disk)
 
 static int idedisk_revalidate_disk(struct gendisk *disk)
 {
-       ide_drive_t *drive = disk->private_data;
-       set_capacity(disk, current_capacity(drive));
+       struct ide_disk_obj *idkp = ide_disk_g(disk);
+       set_capacity(disk, idedisk_capacity(idkp->drive));
        return 0;
 }
 
@@ -1806,15 +1169,17 @@ static struct block_device_operations idedisk_ops = {
        .open           = idedisk_open,
        .release        = idedisk_release,
        .ioctl          = idedisk_ioctl,
+       .getgeo         = idedisk_getgeo,
        .media_changed  = idedisk_media_changed,
        .revalidate_disk= idedisk_revalidate_disk
 };
 
 MODULE_DESCRIPTION("ATA DISK Driver");
 
-static int idedisk_attach(ide_drive_t *drive)
+static int ide_disk_probe(ide_drive_t *drive)
 {
-       struct gendisk *g = drive->disk;
+       struct ide_disk_obj *idkp;
+       struct gendisk *g;
 
        /* strstr("foo", "") is non-NULL */
        if (!strstr("ide-disk", drive->driver_req))
@@ -1824,11 +1189,29 @@ static int idedisk_attach(ide_drive_t *drive)
        if (drive->media != ide_disk)
                goto failed;
 
-       if (ide_register_subdriver(drive, &idedisk_driver)) {
-               printk (KERN_ERR "ide-disk: %s: Failed to register the driver with ide.c\n", drive->name);
+       idkp = kzalloc(sizeof(*idkp), GFP_KERNEL);
+       if (!idkp)
                goto failed;
-       }
-       DRIVER(drive)->busy++;
+
+       g = alloc_disk_node(1 << PARTN_BITS,
+                       hwif_to_node(drive->hwif));
+       if (!g)
+               goto out_free_idkp;
+
+       ide_init_disk(g, drive);
+
+       ide_register_subdriver(drive, &idedisk_driver);
+
+       kref_init(&idkp->kref);
+
+       idkp->drive = drive;
+       idkp->driver = &idedisk_driver;
+       idkp->disk = g;
+
+       g->private_data = &idkp->driver;
+
+       drive->driver_data = idkp;
+
        idedisk_setup(drive);
        if ((!drive->head || drive->head > 16) && !drive->select.b.lba) {
                printk(KERN_ERR "%s: INVALID GEOMETRY: %d PHYSICAL HEADS?\n",
@@ -1836,29 +1219,32 @@ static int idedisk_attach(ide_drive_t *drive)
                drive->attach = 0;
        } else
                drive->attach = 1;
-       DRIVER(drive)->busy--;
+
        g->minors = 1 << PARTN_BITS;
-       strcpy(g->devfs_name, drive->devfs_name);
        g->driverfs_dev = &drive->gendev;
        g->flags = drive->removable ? GENHD_FL_REMOVABLE : 0;
-       set_capacity(g, current_capacity(drive));
+       set_capacity(g, idedisk_capacity(drive));
        g->fops = &idedisk_ops;
        add_disk(g);
        return 0;
+
+out_free_idkp:
+       kfree(idkp);
 failed:
-       return 1;
+       return -ENODEV;
 }
 
 static void __exit idedisk_exit (void)
 {
-       ide_unregister_driver(&idedisk_driver);
+       driver_unregister(&idedisk_driver.gen_driver);
 }
 
-static int idedisk_init (void)
+static int __init idedisk_init(void)
 {
-       return ide_register_driver(&idedisk_driver);
+       return driver_register(&idedisk_driver.gen_driver);
 }
 
+MODULE_ALIAS("ide:*m-disk*");
 module_init(idedisk_init);
 module_exit(idedisk_exit);
 MODULE_LICENSE("GPL");