vserver 1.9.5.x5
[linux-2.6.git] / drivers / ide / ide-disk.c
index ac94367..db55f24 100644 (file)
@@ -45,6 +45,8 @@
 
 #undef REALLY_SLOW_IO          /* most systems can safely undef this */
 
+//#define DEBUG
+
 #include <linux/config.h>
 #include <linux/module.h>
 #include <linux/types.h>
 #include <asm/io.h>
 #include <asm/div64.h>
 
-/* FIXME: some day we shouldn't need to look in here! */
-
-#include "legacy/pdc4030.h"
-
 /*
  * lba_capacity_is_ok() performs a sanity check on the claimed "lba_capacity"
  * value for this drive (from its reported identification information).
@@ -118,272 +116,45 @@ static int lba_capacity_is_ok (struct hd_driveid *id)
        return 0;       /* lba_capacity value may be bad */
 }
 
-static int idedisk_start_tag(ide_drive_t *drive, struct request *rq)
-{
-       unsigned long flags;
-       int ret = 1;
-
-       spin_lock_irqsave(&ide_lock, flags);
-
-       if (ata_pending_commands(drive) < drive->queue_depth)
-               ret = blk_queue_start_tag(drive->queue, rq);
-
-       spin_unlock_irqrestore(&ide_lock, flags);
-       return ret;
-}
-
-#ifndef CONFIG_IDE_TASKFILE_IO
-
-/*
- * read_intr() is the handler for disk read/multread interrupts
- */
-static ide_startstop_t read_intr (ide_drive_t *drive)
-{
-       ide_hwif_t *hwif        = HWIF(drive);
-       u32 i = 0, nsect        = 0, msect = drive->mult_count;
-       struct request *rq;
-       unsigned long flags;
-       u8 stat;
-       char *to;
-
-       /* new way for dealing with premature shared PCI interrupts */
-       if (!OK_STAT(stat=hwif->INB(IDE_STATUS_REG),DATA_READY,BAD_R_STAT)) {
-               if (stat & (ERR_STAT|DRQ_STAT)) {
-                       return DRIVER(drive)->error(drive, "read_intr", stat);
-               }
-               /* no data yet, so wait for another interrupt */
-               ide_set_handler(drive, &read_intr, WAIT_CMD, NULL);
-               return ide_started;
-       }
-       
-read_next:
-       rq = HWGROUP(drive)->rq;
-       if (msect) {
-               if ((nsect = rq->current_nr_sectors) > msect)
-                       nsect = msect;
-               msect -= nsect;
-       } else
-               nsect = 1;
-       to = ide_map_buffer(rq, &flags);
-       taskfile_input_data(drive, to, nsect * SECTOR_WORDS);
-#ifdef DEBUG
-       printk("%s:  read: sectors(%ld-%ld), buffer=0x%08lx, remaining=%ld\n",
-               drive->name, rq->sector, rq->sector+nsect-1,
-               (unsigned long) rq->buffer+(nsect<<9), rq->nr_sectors-nsect);
-#endif
-       ide_unmap_buffer(rq, to, &flags);
-       rq->sector += nsect;
-       rq->errors = 0;
-       i = (rq->nr_sectors -= nsect);
-       if (((long)(rq->current_nr_sectors -= nsect)) <= 0)
-               ide_end_request(drive, 1, rq->hard_cur_sectors);
-       /*
-        * Another BH Page walker and DATA INTEGRITY Questioned on ERROR.
-        * If passed back up on multimode read, BAD DATA could be ACKED
-        * to FILE SYSTEMS above ...
-        */
-       if (i > 0) {
-               if (msect)
-                       goto read_next;
-               ide_set_handler(drive, &read_intr, WAIT_CMD, NULL);
-                return ide_started;
-       }
-        return ide_stopped;
-}
-
-/*
- * write_intr() is the handler for disk write interrupts
- */
-static ide_startstop_t write_intr (ide_drive_t *drive)
-{
-       ide_hwgroup_t *hwgroup  = HWGROUP(drive);
-       ide_hwif_t *hwif        = HWIF(drive);
-       struct request *rq      = hwgroup->rq;
-       u32 i = 0;
-       u8 stat;
-
-       if (!OK_STAT(stat = hwif->INB(IDE_STATUS_REG),
-                       DRIVE_READY, drive->bad_wstat)) {
-               printk("%s: write_intr error1: nr_sectors=%ld, stat=0x%02x\n",
-                       drive->name, rq->nr_sectors, stat);
-        } else {
-#ifdef DEBUG
-               printk("%s: write: sector %ld, buffer=0x%08lx, remaining=%ld\n",
-                       drive->name, rq->sector, (unsigned long) rq->buffer,
-                       rq->nr_sectors-1);
-#endif
-               if ((rq->nr_sectors == 1) ^ ((stat & DRQ_STAT) != 0)) {
-                       rq->sector++;
-                       rq->errors = 0;
-                       i = --rq->nr_sectors;
-                       --rq->current_nr_sectors;
-                       if (((long)rq->current_nr_sectors) <= 0)
-                               ide_end_request(drive, 1, rq->hard_cur_sectors);
-                       if (i > 0) {
-                               unsigned long flags;
-                               char *to = ide_map_buffer(rq, &flags);
-                               taskfile_output_data(drive, to, SECTOR_WORDS);
-                               ide_unmap_buffer(rq, to, &flags);
-                               ide_set_handler(drive, &write_intr, WAIT_CMD, NULL);
-                                return ide_started;
-                       }
-                        return ide_stopped;
-               }
-               /* the original code did this here (?) */
-               return ide_stopped;
-       }
-       return DRIVER(drive)->error(drive, "write_intr", stat);
-}
-
-/*
- * ide_multwrite() transfers a block of up to mcount sectors of data
- * to a drive as part of a disk multiple-sector write operation.
- *
- * Note that we may be called from two contexts - __ide_do_rw_disk() context
- * and IRQ context. The IRQ can happen any time after we've output the
- * full "mcount" number of sectors, so we must make sure we update the
- * state _before_ we output the final part of the data!
- *
- * The update and return to BH is a BLOCK Layer Fakey to get more data
- * to satisfy the hardware atomic segment.  If the hardware atomic segment
- * is shorter or smaller than the BH segment then we should be OKAY.
- * This is only valid if we can rewind the rq->current_nr_sectors counter.
- */
-static void ide_multwrite(ide_drive_t *drive, unsigned int mcount)
-{
-       ide_hwgroup_t *hwgroup  = HWGROUP(drive);
-       struct request *rq      = &hwgroup->wrq;
-       do {
-               char *buffer;
-               int nsect = rq->current_nr_sectors;
-               unsigned long flags;
-               if (nsect > mcount)
-                       nsect = mcount;
-               mcount -= nsect;
-               buffer = ide_map_buffer(rq, &flags);
-
-               rq->sector += nsect;
-               rq->nr_sectors -= nsect;
-               rq->current_nr_sectors -= nsect;
-
-               /* Do we move to the next bh after this? */
-               if (!rq->current_nr_sectors) {
-                       struct bio *bio = rq->bio;
-
-                       /*
-                        * only move to next bio, when we have processed
-                        * all bvecs in this one.
-                        */
-                       if (++bio->bi_idx >= bio->bi_vcnt) {
-                               bio->bi_idx = bio->bi_vcnt - rq->nr_cbio_segments;
-                               bio = bio->bi_next;
-                       }
-
-                       /* end early early we ran out of requests */
-                       if (!bio) {
-                               mcount = 0;
-                       } else {
-                               rq->bio = bio;
-                               rq->nr_cbio_segments = bio_segments(bio);
-                               rq->current_nr_sectors = bio_cur_sectors(bio);
-                               rq->hard_cur_sectors = rq->current_nr_sectors;
-                       }
-               }
-
-               /*
-                * Ok, we're all setup for the interrupt
-                * re-entering us on the last transfer.
-                */
-               taskfile_output_data(drive, buffer, nsect<<7);
-               ide_unmap_buffer(rq, buffer, &flags);
-       } while (mcount);
-}
-
-/*
- * multwrite_intr() is the handler for disk multwrite interrupts
- */
-static ide_startstop_t multwrite_intr (ide_drive_t *drive)
-{
-       ide_hwgroup_t *hwgroup  = HWGROUP(drive);
-       ide_hwif_t *hwif        = HWIF(drive);
-       struct request *rq      = &hwgroup->wrq;
-       struct bio *bio         = rq->bio;
-       u8 stat;
-
-       stat = hwif->INB(IDE_STATUS_REG);
-       if (OK_STAT(stat, DRIVE_READY, drive->bad_wstat)) {
-               if (stat & DRQ_STAT) {
-                       /*
-                        *      The drive wants data. Remember rq is the copy
-                        *      of the request
-                        */
-                       if (rq->nr_sectors) {
-                               ide_multwrite(drive, drive->mult_count);
-                               ide_set_handler(drive, &multwrite_intr, WAIT_CMD, NULL);
-                               return ide_started;
-                       }
-               } else {
-                       /*
-                        *      If the copy has all the blocks completed then
-                        *      we can end the original request.
-                        */
-                       if (!rq->nr_sectors) {  /* all done? */
-                               bio->bi_idx = bio->bi_vcnt - rq->nr_cbio_segments;
-                               rq = hwgroup->rq;
-                               ide_end_request(drive, 1, rq->nr_sectors);
-                               return ide_stopped;
-                       }
-               }
-               bio->bi_idx = bio->bi_vcnt - rq->nr_cbio_segments;
-               /* the original code did this here (?) */
-               return ide_stopped;
-       }
-       bio->bi_idx = bio->bi_vcnt - rq->nr_cbio_segments;
-       return DRIVER(drive)->error(drive, "multwrite_intr", stat);
-}
-
 /*
  * __ide_do_rw_disk() issues READ and WRITE commands to a disk,
  * using LBA if supported, or CHS otherwise, to address sectors.
- * It also takes care of issuing special DRIVE_CMDs.
  */
-ide_startstop_t __ide_do_rw_disk (ide_drive_t *drive, struct request *rq, sector_t block)
+static ide_startstop_t __ide_do_rw_disk(ide_drive_t *drive, struct request *rq, sector_t block)
 {
        ide_hwif_t *hwif        = HWIF(drive);
+       unsigned int dma        = drive->using_dma;
        u8 lba48                = (drive->addressing == 1) ? 1 : 0;
        task_ioreg_t command    = WIN_NOP;
        ata_nsector_t           nsectors;
 
        nsectors.all            = (u16) rq->nr_sectors;
 
-       if (drive->using_tcq && idedisk_start_tag(drive, rq)) {
-               if (!ata_pending_commands(drive))
-                       BUG();
+       if (hwif->no_lba48_dma && lba48 && dma) {
+               if (block + rq->nr_sectors > 1ULL << 28)
+                       dma = 0;
+       }
 
-               return ide_started;
+       if (!dma) {
+               ide_init_sg_cmd(drive, rq);
+               ide_map_sg(drive, rq);
        }
 
        if (IDE_CONTROL_REG)
                hwif->OUTB(drive->ctl, IDE_CONTROL_REG);
 
+       /* FIXME: SELECT_MASK(drive, 0) ? */
+
        if (drive->select.b.lba) {
                if (drive->addressing == 1) {
                        task_ioreg_t tasklets[10];
 
-                       if (blk_rq_tagged(rq)) {
-                               tasklets[0] = nsectors.b.low;
-                               tasklets[1] = nsectors.b.high;
-                               tasklets[2] = rq->tag << 3;
-                               tasklets[3] = 0;
-                       } else {
-                               tasklets[0] = 0;
-                               tasklets[1] = 0;
-                               tasklets[2] = nsectors.b.low;
-                               tasklets[3] = nsectors.b.high;
-                       }
+                       pr_debug("%s: LBA=0x%012llx\n", drive->name, block);
 
+                       tasklets[0] = 0;
+                       tasklets[1] = 0;
+                       tasklets[2] = nsectors.b.low;
+                       tasklets[3] = nsectors.b.high;
                        tasklets[4] = (task_ioreg_t) block;
                        tasklets[5] = (task_ioreg_t) (block>>8);
                        tasklets[6] = (task_ioreg_t) (block>>16);
@@ -396,14 +167,6 @@ ide_startstop_t __ide_do_rw_disk (ide_drive_t *drive, struct request *rq, sector
                                tasklets[9] = (task_ioreg_t)((u64)block >> 40);
                        }
 #ifdef DEBUG
-                       printk("%s: %sing: LBAsect=%lu, sectors=%ld, "
-                               "buffer=0x%08lx, LBAsect=0x%012lx\n",
-                               drive->name,
-                               rq_data_dir(rq)==READ?"read":"writ",
-                               block,
-                               rq->nr_sectors,
-                               (unsigned long) rq->buffer,
-                               block);
                        printk("%s: 0x%02x%02x 0x%02x%02x%02x%02x%02x%02x\n",
                                drive->name, tasklets[3], tasklets[2],
                                tasklets[9], tasklets[8], tasklets[7],
@@ -422,22 +185,8 @@ ide_startstop_t __ide_do_rw_disk (ide_drive_t *drive, struct request *rq, sector
                        hwif->OUTB(tasklets[6], IDE_HCYL_REG);
                        hwif->OUTB(0x00|drive->select.all,IDE_SELECT_REG);
                } else {
-#ifdef DEBUG
-                       printk("%s: %sing: LBAsect=%llu, sectors=%ld, "
-                               "buffer=0x%08lx\n",
-                               drive->name,
-                               rq_data_dir(rq)==READ?"read":"writ",
-                               (unsigned long long)block, rq->nr_sectors,
-                               (unsigned long) rq->buffer);
-#endif
-                       if (blk_rq_tagged(rq)) {
-                               hwif->OUTB(nsectors.b.low, IDE_FEATURE_REG);
-                               hwif->OUTB(rq->tag << 3, IDE_NSECTOR_REG);
-                       } else {
-                               hwif->OUTB(0x00, IDE_FEATURE_REG);
-                               hwif->OUTB(nsectors.b.low, IDE_NSECTOR_REG);
-                       }
-
+                       hwif->OUTB(0x00, IDE_FEATURE_REG);
+                       hwif->OUTB(nsectors.b.low, IDE_NSECTOR_REG);
                        hwif->OUTB(block, IDE_SECTOR_REG);
                        hwif->OUTB(block>>=8, IDE_LCYL_REG);
                        hwif->OUTB(block>>=8, IDE_HCYL_REG);
@@ -451,231 +200,60 @@ ide_startstop_t __ide_do_rw_disk (ide_drive_t *drive, struct request *rq, sector
                head  = track % drive->head;
                cyl   = track / drive->head;
 
-               if (blk_rq_tagged(rq)) {
-                       hwif->OUTB(nsectors.b.low, IDE_FEATURE_REG);
-                       hwif->OUTB(rq->tag << 3, IDE_NSECTOR_REG);
-               } else {
-                       hwif->OUTB(0x00, IDE_FEATURE_REG);
-                       hwif->OUTB(nsectors.b.low, IDE_NSECTOR_REG);
-               }
+               pr_debug("%s: CHS=%u/%u/%u\n", drive->name, cyl, head, sect);
 
+               hwif->OUTB(0x00, IDE_FEATURE_REG);
+               hwif->OUTB(nsectors.b.low, IDE_NSECTOR_REG);
                hwif->OUTB(cyl, IDE_LCYL_REG);
                hwif->OUTB(cyl>>8, IDE_HCYL_REG);
                hwif->OUTB(head|drive->select.all,IDE_SELECT_REG);
-#ifdef DEBUG
-               printk("%s: %sing: CHS=%d/%d/%d, sectors=%ld, buffer=0x%08lx\n",
-                       drive->name, rq_data_dir(rq)==READ?"read":"writ", cyl,
-                       head, sect, rq->nr_sectors, (unsigned long) rq->buffer);
-#endif
        }
 
-       if (rq_data_dir(rq) == READ) {
-#ifdef CONFIG_BLK_DEV_IDE_TCQ
-               if (blk_rq_tagged(rq))
-                       return __ide_dma_queued_read(drive);
-#endif
-               if (drive->using_dma && !hwif->ide_dma_read(drive))
-                       return ide_started;
-
-               command = ((drive->mult_count) ?
-                          ((lba48) ? WIN_MULTREAD_EXT : WIN_MULTREAD) :
-                          ((lba48) ? WIN_READ_EXT : WIN_READ));
-               ide_execute_command(drive, command, &read_intr, WAIT_CMD, NULL);
-               return ide_started;
-       } else if (rq_data_dir(rq) == WRITE) {
-               ide_startstop_t startstop;
-#ifdef CONFIG_BLK_DEV_IDE_TCQ
-               if (blk_rq_tagged(rq))
-                       return __ide_dma_queued_write(drive);
-#endif
-               if (drive->using_dma && !(HWIF(drive)->ide_dma_write(drive)))
+       if (dma) {
+               if (!hwif->dma_setup(drive)) {
+                       if (rq_data_dir(rq)) {
+                               command = lba48 ? WIN_WRITEDMA_EXT : WIN_WRITEDMA;
+                               if (drive->vdma)
+                                       command = lba48 ? WIN_WRITE_EXT: WIN_WRITE;
+                       } else {
+                               command = lba48 ? WIN_READDMA_EXT : WIN_READDMA;
+                               if (drive->vdma)
+                                       command = lba48 ? WIN_READ_EXT: WIN_READ;
+                       }
+                       hwif->dma_exec_cmd(drive, command);
+                       hwif->dma_start(drive);
                        return ide_started;
+               }
+               /* fallback to PIO */
+               ide_init_sg_cmd(drive, rq);
+       }
 
-               command = ((drive->mult_count) ?
-                          ((lba48) ? WIN_MULTWRITE_EXT : WIN_MULTWRITE) :
-                          ((lba48) ? WIN_WRITE_EXT : WIN_WRITE));
-               hwif->OUTB(command, IDE_COMMAND_REG);
+       if (rq_data_dir(rq) == READ) {
 
-               if (ide_wait_stat(&startstop, drive, DATA_READY,
-                               drive->bad_wstat, WAIT_DRQ)) {
-                       printk(KERN_ERR "%s: no DRQ after issuing %s\n",
-                               drive->name,
-                               drive->mult_count ? "MULTWRITE" : "WRITE");
-                       return startstop;
-               }
-               if (!drive->unmask)
-                       local_irq_disable();
                if (drive->mult_count) {
-                       ide_hwgroup_t *hwgroup = HWGROUP(drive);
-
-                       hwgroup->wrq = *rq; /* scratchpad */
-                       ide_set_handler(drive, &multwrite_intr, WAIT_CMD, NULL);
-                       ide_multwrite(drive, drive->mult_count);
+                       hwif->data_phase = TASKFILE_MULTI_IN;
+                       command = lba48 ? WIN_MULTREAD_EXT : WIN_MULTREAD;
                } else {
-                       unsigned long flags;
-                       char *to = ide_map_buffer(rq, &flags);
-                       ide_set_handler(drive, &write_intr, WAIT_CMD, NULL);
-                       taskfile_output_data(drive, to, SECTOR_WORDS);
-                       ide_unmap_buffer(rq, to, &flags);
+                       hwif->data_phase = TASKFILE_IN;
+                       command = lba48 ? WIN_READ_EXT : WIN_READ;
                }
-               return ide_started;
-       }
-       blk_dump_rq_flags(rq, "__ide_do_rw_disk - bad command");
-       ide_end_request(drive, 0, 0);
-       return ide_stopped;
-}
-EXPORT_SYMBOL_GPL(__ide_do_rw_disk);
-
-#else /* CONFIG_IDE_TASKFILE_IO */
-
-static ide_startstop_t chs_rw_disk(ide_drive_t *, struct request *, unsigned long);
-static ide_startstop_t lba_28_rw_disk(ide_drive_t *, struct request *, unsigned long);
-static ide_startstop_t lba_48_rw_disk(ide_drive_t *, struct request *, unsigned long long);
-
-/*
- * __ide_do_rw_disk() issues READ and WRITE commands to a disk,
- * using LBA if supported, or CHS otherwise, to address sectors.
- * It also takes care of issuing special DRIVE_CMDs.
- */
-ide_startstop_t __ide_do_rw_disk (ide_drive_t *drive, struct request *rq, sector_t block)
-{
-       BUG_ON(drive->blocked);
-       if (!blk_fs_request(rq)) {
-               blk_dump_rq_flags(rq, "__ide_do_rw_disk - bad command");
-               ide_end_request(drive, 0, 0);
-               return ide_stopped;
-       }
-
-       /*
-        * 268435455  == 137439 MB or 28bit limit
-        *
-        * need to add split taskfile operations based on 28bit threshold.
-        */
-
-       if (drive->using_tcq && idedisk_start_tag(drive, rq)) {
-               if (!ata_pending_commands(drive))
-                       BUG();
 
+               ide_execute_command(drive, command, &task_in_intr, WAIT_CMD, NULL);
                return ide_started;
-       }
-
-       if (drive->addressing == 1)             /* 48-bit LBA */
-               return lba_48_rw_disk(drive, rq, (unsigned long long) block);
-       if (drive->select.b.lba)                /* 28-bit LBA */
-               return lba_28_rw_disk(drive, rq, (unsigned long) block);
-
-       /* 28-bit CHS : DIE DIE DIE piece of legacy crap!!! */
-       return chs_rw_disk(drive, rq, (unsigned long) block);
-}
-EXPORT_SYMBOL_GPL(__ide_do_rw_disk);
-
-static u8 get_command(ide_drive_t *drive, int cmd, ide_task_t *task)
-{
-       unsigned int lba48 = (drive->addressing == 1) ? 1 : 0;
-
-       if (cmd == READ) {
-               task->command_type = IDE_DRIVE_TASK_IN;
-               if (drive->using_tcq)
-                       return lba48 ? WIN_READDMA_QUEUED_EXT : WIN_READDMA_QUEUED;
-               if (drive->using_dma)
-                       return lba48 ? WIN_READDMA_EXT : WIN_READDMA;
-               if (drive->mult_count) {
-                       task->handler = &task_mulin_intr;
-                       return lba48 ? WIN_MULTREAD_EXT : WIN_MULTREAD;
-               }
-               task->handler = &task_in_intr;
-               return lba48 ? WIN_READ_EXT : WIN_READ;
        } else {
-               task->command_type = IDE_DRIVE_TASK_RAW_WRITE;
-               if (drive->using_tcq)
-                       return lba48 ? WIN_WRITEDMA_QUEUED_EXT : WIN_WRITEDMA_QUEUED;
-               if (drive->using_dma)
-                       return lba48 ? WIN_WRITEDMA_EXT : WIN_WRITEDMA;
                if (drive->mult_count) {
-                       task->prehandler = &pre_task_mulout_intr;
-                       task->handler = &task_mulout_intr;
-                       return lba48 ? WIN_MULTWRITE_EXT : WIN_MULTWRITE;
+                       hwif->data_phase = TASKFILE_MULTI_OUT;
+                       command = lba48 ? WIN_MULTWRITE_EXT : WIN_MULTWRITE;
+               } else {
+                       hwif->data_phase = TASKFILE_OUT;
+                       command = lba48 ? WIN_WRITE_EXT : WIN_WRITE;
                }
-               task->prehandler = &pre_task_out_intr;
-               task->handler = &task_out_intr;
-               return lba48 ? WIN_WRITE_EXT : WIN_WRITE;
-       }
-}
-
-static ide_startstop_t chs_rw_disk (ide_drive_t *drive, struct request *rq, unsigned long block)
-{
-       ide_task_t              args;
-       int                     sectors;
-       ata_nsector_t           nsectors;
-       unsigned int track      = (block / drive->sect);
-       unsigned int sect       = (block % drive->sect) + 1;
-       unsigned int head       = (track % drive->head);
-       unsigned int cyl        = (track / drive->head);
-
-       nsectors.all = (u16) rq->nr_sectors;
-
-#ifdef DEBUG
-       printk("%s: %sing: ", drive->name, (rq_data_dir(rq)==READ) ? "read" : "writ");
-       printk("CHS=%d/%d/%d, ", cyl, head, sect);
-       printk("sectors=%ld, ", rq->nr_sectors);
-       printk("buffer=0x%08lx\n", (unsigned long) rq->buffer);
-#endif
 
-       memset(&args, 0, sizeof(ide_task_t));
-
-       sectors = (rq->nr_sectors == 256) ? 0x00 : rq->nr_sectors;
-
-       if (blk_rq_tagged(rq)) {
-               args.tfRegister[IDE_FEATURE_OFFSET] = sectors;
-               args.tfRegister[IDE_NSECTOR_OFFSET] = rq->tag << 3;
-       } else
-               args.tfRegister[IDE_NSECTOR_OFFSET] = sectors;
-
-       args.tfRegister[IDE_SECTOR_OFFSET]      = sect;
-       args.tfRegister[IDE_LCYL_OFFSET]        = cyl;
-       args.tfRegister[IDE_HCYL_OFFSET]        = (cyl>>8);
-       args.tfRegister[IDE_SELECT_OFFSET]      = head;
-       args.tfRegister[IDE_SELECT_OFFSET]      |= drive->select.all;
-       args.tfRegister[IDE_COMMAND_OFFSET]     = get_command(drive, rq_data_dir(rq), &args);
-       args.rq                                 = (struct request *) rq;
-       rq->special                             = (ide_task_t *)&args;
-       return do_rw_taskfile(drive, &args);
-}
-
-static ide_startstop_t lba_28_rw_disk (ide_drive_t *drive, struct request *rq, unsigned long block)
-{
-       ide_task_t              args;
-       int                     sectors;
-       ata_nsector_t           nsectors;
-
-       nsectors.all = (u16) rq->nr_sectors;
-
-#ifdef DEBUG
-       printk("%s: %sing: ", drive->name, (rq_data_dir(rq)==READ) ? "read" : "writ");
-       printk("LBAsect=%lld, ", block);
-       printk("sectors=%ld, ", rq->nr_sectors);
-       printk("buffer=0x%08lx\n", (unsigned long) rq->buffer);
-#endif
-
-       memset(&args, 0, sizeof(ide_task_t));
-
-       sectors = (rq->nr_sectors == 256) ? 0x00 : rq->nr_sectors;
+               /* FIXME: ->OUTBSYNC ? */
+               hwif->OUTB(command, IDE_COMMAND_REG);
 
-       if (blk_rq_tagged(rq)) {
-               args.tfRegister[IDE_FEATURE_OFFSET] = sectors;
-               args.tfRegister[IDE_NSECTOR_OFFSET] = rq->tag << 3;
-       } else
-               args.tfRegister[IDE_NSECTOR_OFFSET] = sectors;
-
-       args.tfRegister[IDE_SECTOR_OFFSET]      = block;
-       args.tfRegister[IDE_LCYL_OFFSET]        = (block>>=8);
-       args.tfRegister[IDE_HCYL_OFFSET]        = (block>>=8);
-       args.tfRegister[IDE_SELECT_OFFSET]      = ((block>>8)&0x0f);
-       args.tfRegister[IDE_SELECT_OFFSET]      |= drive->select.all;
-       args.tfRegister[IDE_COMMAND_OFFSET]     = get_command(drive, rq_data_dir(rq), &args);
-       args.rq                                 = (struct request *) rq;
-       rq->special                             = (ide_task_t *)&args;
-       return do_rw_taskfile(drive, &args);
+               return pre_task_out_intr(drive, rq);
+       }
 }
 
 /*
@@ -684,237 +262,26 @@ static ide_startstop_t lba_28_rw_disk (ide_drive_t *drive, struct request *rq, u
  * 1073741822 == 549756 MB or 48bit addressing fake drive
  */
 
-static ide_startstop_t lba_48_rw_disk (ide_drive_t *drive, struct request *rq, unsigned long long block)
-{
-       ide_task_t              args;
-       int                     sectors;
-       ata_nsector_t           nsectors;
-
-       nsectors.all = (u16) rq->nr_sectors;
-
-#ifdef DEBUG
-       printk("%s: %sing: ", drive->name, (rq_data_dir(rq)==READ) ? "read" : "writ");
-       printk("LBAsect=%lld, ", block);
-       printk("sectors=%ld, ", rq->nr_sectors);
-       printk("buffer=0x%08lx\n", (unsigned long) rq->buffer);
-#endif
-
-       memset(&args, 0, sizeof(ide_task_t));
-
-       sectors = (rq->nr_sectors == 65536) ? 0 : rq->nr_sectors;
-
-       if (blk_rq_tagged(rq)) {
-               args.tfRegister[IDE_FEATURE_OFFSET] = sectors;
-               args.tfRegister[IDE_NSECTOR_OFFSET] = rq->tag << 3;
-               args.hobRegister[IDE_FEATURE_OFFSET] = sectors >> 8;
-               args.hobRegister[IDE_NSECTOR_OFFSET] = 0;
-       } else {
-               args.tfRegister[IDE_NSECTOR_OFFSET] = sectors;
-               args.hobRegister[IDE_NSECTOR_OFFSET] = sectors >> 8;
-       }
-
-       args.tfRegister[IDE_SECTOR_OFFSET]      = block;        /* low lba */
-       args.tfRegister[IDE_LCYL_OFFSET]        = (block>>=8);  /* mid lba */
-       args.tfRegister[IDE_HCYL_OFFSET]        = (block>>=8);  /* hi  lba */
-       args.tfRegister[IDE_SELECT_OFFSET]      = drive->select.all;
-       args.tfRegister[IDE_COMMAND_OFFSET]     = get_command(drive, rq_data_dir(rq), &args);
-       args.hobRegister[IDE_SECTOR_OFFSET]     = (block>>=8);  /* low lba */
-       args.hobRegister[IDE_LCYL_OFFSET]       = (block>>=8);  /* mid lba */
-       args.hobRegister[IDE_HCYL_OFFSET]       = (block>>=8);  /* hi  lba */
-       args.hobRegister[IDE_SELECT_OFFSET]     = drive->select.all;
-       args.hobRegister[IDE_CONTROL_OFFSET_HOB]= (drive->ctl|0x80);
-       args.rq                                 = (struct request *) rq;
-       rq->special                             = (ide_task_t *)&args;
-       return do_rw_taskfile(drive, &args);
-}
-
-#endif /* CONFIG_IDE_TASKFILE_IO */
-
 static ide_startstop_t ide_do_rw_disk (ide_drive_t *drive, struct request *rq, sector_t block)
 {
        ide_hwif_t *hwif = HWIF(drive);
 
-       if (hwif->rw_disk)
-               return hwif->rw_disk(drive, rq, block);
-       else
-               return __ide_do_rw_disk(drive, rq, block);
-}
-
-static int do_idedisk_flushcache(ide_drive_t *drive);
-
-static u8 idedisk_dump_status (ide_drive_t *drive, const char *msg, u8 stat)
-{
-       ide_hwif_t *hwif = HWIF(drive);
-       unsigned long flags;
-       u8 err = 0;
-
-       local_irq_set(flags);
-       printk("%s: %s: status=0x%02x", drive->name, msg, stat);
-#if FANCY_STATUS_DUMPS
-       printk(" { ");
-       if (stat & BUSY_STAT)
-               printk("Busy ");
-       else {
-               if (stat & READY_STAT)  printk("DriveReady ");
-               if (stat & WRERR_STAT)  printk("DeviceFault ");
-               if (stat & SEEK_STAT)   printk("SeekComplete ");
-               if (stat & DRQ_STAT)    printk("DataRequest ");
-               if (stat & ECC_STAT)    printk("CorrectedError ");
-               if (stat & INDEX_STAT)  printk("Index ");
-               if (stat & ERR_STAT)    printk("Error ");
-       }
-       printk("}");
-#endif /* FANCY_STATUS_DUMPS */
-       printk("\n");
-       if ((stat & (BUSY_STAT|ERR_STAT)) == ERR_STAT) {
-               err = hwif->INB(IDE_ERROR_REG);
-               printk("%s: %s: error=0x%02x", drive->name, msg, err);
-#if FANCY_STATUS_DUMPS
-               printk(" { ");
-               if (err & ABRT_ERR)     printk("DriveStatusError ");
-               if (err & ICRC_ERR)
-                       printk("Bad%s ", (err & ABRT_ERR) ? "CRC" : "Sector");
-               if (err & ECC_ERR)      printk("UncorrectableError ");
-               if (err & ID_ERR)       printk("SectorIdNotFound ");
-               if (err & TRK0_ERR)     printk("TrackZeroNotFound ");
-               if (err & MARK_ERR)     printk("AddrMarkNotFound ");
-               printk("}");
-               if ((err & (BBD_ERR | ABRT_ERR)) == BBD_ERR ||
-                   (err & (ECC_ERR|ID_ERR|MARK_ERR))) {
-                       if (drive->addressing == 1) {
-                               __u64 sectors = 0;
-                               u32 low = 0, high = 0;
-                               low = ide_read_24(drive);
-                               hwif->OUTB(drive->ctl|0x80, IDE_CONTROL_REG);
-                               high = ide_read_24(drive);
-                               sectors = ((__u64)high << 24) | low;
-                               printk(", LBAsect=%llu, high=%d, low=%d",
-                                      (unsigned long long) sectors,
-                                      high, low);
-                       } else {
-                               u8 cur = hwif->INB(IDE_SELECT_REG);
-                               if (cur & 0x40) {       /* using LBA? */
-                                       printk(", LBAsect=%ld", (unsigned long)
-                                        ((cur&0xf)<<24)
-                                        |(hwif->INB(IDE_HCYL_REG)<<16)
-                                        |(hwif->INB(IDE_LCYL_REG)<<8)
-                                        | hwif->INB(IDE_SECTOR_REG));
-                               } else {
-                                       printk(", CHS=%d/%d/%d",
-                                        (hwif->INB(IDE_HCYL_REG)<<8) +
-                                         hwif->INB(IDE_LCYL_REG),
-                                         cur & 0xf,
-                                         hwif->INB(IDE_SECTOR_REG));
-                               }
-                       }
-                       if (HWGROUP(drive) && HWGROUP(drive)->rq)
-                               printk(", sector=%llu",
-                                       (unsigned long long)HWGROUP(drive)->rq->sector);
-               }
-       }
-#endif /* FANCY_STATUS_DUMPS */
-       printk("\n");
-       local_irq_restore(flags);
-       return err;
-}
-
-ide_startstop_t idedisk_error (ide_drive_t *drive, const char *msg, u8 stat)
-{
-       ide_hwif_t *hwif;
-       struct request *rq;
-       u8 err;
-       int i = (drive->mult_count ? drive->mult_count : 1) * SECTOR_WORDS;
-
-       err = idedisk_dump_status(drive, msg, stat);
-
-       if (drive == NULL || (rq = HWGROUP(drive)->rq) == NULL)
-               return ide_stopped;
+       BUG_ON(drive->blocked);
 
-       hwif = HWIF(drive);
-       /* retry only "normal" I/O: */
-       if (rq->flags & (REQ_DRIVE_CMD | REQ_DRIVE_TASK | REQ_DRIVE_TASKFILE)) {
-               rq->errors = 1;
-               ide_end_drive_cmd(drive, stat, err);
+       if (!blk_fs_request(rq)) {
+               blk_dump_rq_flags(rq, "ide_do_rw_disk - bad command");
+               ide_end_request(drive, 0, 0);
                return ide_stopped;
        }
-#ifdef CONFIG_IDE_TASKFILE_IO
-       /* make rq completion pointers new submission pointers */
-       blk_rq_prep_restart(rq);
-#endif
-
-       if (stat & BUSY_STAT || ((stat & WRERR_STAT) && !drive->nowerr)) {
-               /* other bits are useless when BUSY */
-               rq->errors |= ERROR_RESET;
-       } else if (stat & ERR_STAT) {
-               /* err has different meaning on cdrom and tape */
-               if (err == ABRT_ERR) {
-                       if (drive->select.b.lba &&
-                           /* some newer drives don't support WIN_SPECIFY */
-                           hwif->INB(IDE_COMMAND_REG) == WIN_SPECIFY)
-                               return ide_stopped;
-               } else if ((err & BAD_CRC) == BAD_CRC) {
-                       /* UDMA crc error, just retry the operation */
-                       drive->crc_count++;
-               } else if (err & (BBD_ERR | ECC_ERR)) {
-                       /* retries won't help these */
-                       rq->errors = ERROR_MAX;
-               } else if (err & TRK0_ERR) {
-                       /* help it find track zero */
-                       rq->errors |= ERROR_RECAL;
-               }
-       }
-       if ((stat & DRQ_STAT) && rq_data_dir(rq) == READ) {
-               /*
-                * try_to_flush_leftover_data() is invoked in response to
-                * a drive unexpectedly having its DRQ_STAT bit set.  As
-                * an alternative to resetting the drive, this routine
-                * tries to clear the condition by read a sector's worth
-                * of data from the drive.  Of course, this may not help
-                * if the drive is *waiting* for data from *us*.
-                */
-               while (i > 0) {
-                       u32 buffer[16];
-                       unsigned int wcount = (i > 16) ? 16 : i;
-                       i -= wcount;
-                       taskfile_input_data(drive, buffer, wcount);
-               }
-       }
-       if (hwif->INB(IDE_STATUS_REG) & (BUSY_STAT|DRQ_STAT)) {
-               /* force an abort */
-               hwif->OUTB(WIN_IDLEIMMEDIATE,IDE_COMMAND_REG);
-       }
-       if (rq->errors >= ERROR_MAX || blk_noretry_request(rq))
-               DRIVER(drive)->end_request(drive, 0, 0);
-       else {
-               if ((rq->errors & ERROR_RESET) == ERROR_RESET) {
-                       ++rq->errors;
-                       return ide_do_reset(drive);
-               }
-               if ((rq->errors & ERROR_RECAL) == ERROR_RECAL)
-                       drive->special.b.recalibrate = 1;
-               ++rq->errors;
-       }
-       return ide_stopped;
-}
-
-ide_startstop_t idedisk_abort(ide_drive_t *drive, const char *msg)
-{
-       ide_hwif_t *hwif;
-       struct request *rq;
-
-       if (drive == NULL || (rq = HWGROUP(drive)->rq) == NULL)
-               return ide_stopped;
 
-       hwif = HWIF(drive);
+       pr_debug("%s: %sing: block=%llu, sectors=%lu, buffer=0x%08lx\n",
+                drive->name, rq_data_dir(rq) == READ ? "read" : "writ",
+                block, rq->nr_sectors, (unsigned long)rq->buffer);
 
-       if (rq->flags & (REQ_DRIVE_CMD | REQ_DRIVE_TASK | REQ_DRIVE_TASKFILE)) {
-               rq->errors = 1;
-               ide_end_drive_cmd(drive, BUSY_STAT, 0);
-               return ide_stopped;
-       }
+       if (hwif->rw_disk)
+               hwif->rw_disk(drive, rq);
 
-       DRIVER(drive)->end_request(drive, 0, 0);
-       return ide_stopped;
+       return __ide_do_rw_disk(drive, rq, block);
 }
 
 /*
@@ -975,7 +342,6 @@ static unsigned long long idedisk_read_native_max_address_ext(ide_drive_t *drive
        return addr;
 }
 
-#ifdef CONFIG_IDEDISK_STROKE
 /*
  * Sets maximum virtual LBA address of the drive.
  * Returns new maximum virtual LBA address (> 0) or 0 on failure.
@@ -1044,8 +410,6 @@ static unsigned long long idedisk_set_max_address_ext(ide_drive_t *drive, unsign
        return addr_set;
 }
 
-#endif /* CONFIG_IDEDISK_STROKE */
-
 static unsigned long long sectors_to_MB(unsigned long long n)
 {
        n <<= 9;                /* make it bytes */
@@ -1092,7 +456,7 @@ static inline void idedisk_check_hpa(ide_drive_t *drive)
                         drive->name,
                         capacity, sectors_to_MB(capacity),
                         set_max, sectors_to_MB(set_max));
-#ifdef CONFIG_IDEDISK_STROKE
+
        if (lba48)
                set_max = idedisk_set_max_address_ext(drive, set_max);
        else
@@ -1102,7 +466,6 @@ static inline void idedisk_check_hpa(ide_drive_t *drive)
                printk(KERN_INFO "%s: Host Protected Area disabled.\n",
                                 drive->name);
        }
-#endif
 }
 
 /*
@@ -1151,6 +514,8 @@ static sector_t idedisk_capacity (ide_drive_t *drive)
        return drive->capacity64 - drive->sect0;
 }
 
+#define IS_PDC4030_DRIVE       0
+
 static ide_startstop_t idedisk_special (ide_drive_t *drive)
 {
        special_t *s = &drive->special;
@@ -1245,6 +610,7 @@ static int get_smart_values(ide_drive_t *drive, u8 *buf)
        args.tfRegister[IDE_HCYL_OFFSET]        = SMART_HCYL_PASS;
        args.tfRegister[IDE_COMMAND_OFFSET]     = WIN_SMART;
        args.command_type                       = IDE_DRIVE_TASK_IN;
+       args.data_phase                         = TASKFILE_IN;
        args.handler                            = &task_in_intr;
        (void) smart_enable(drive);
        return ide_raw_taskfile(drive, &args, buf);
@@ -1260,6 +626,7 @@ static int get_smart_thresholds(ide_drive_t *drive, u8 *buf)
        args.tfRegister[IDE_HCYL_OFFSET]        = SMART_HCYL_PASS;
        args.tfRegister[IDE_COMMAND_OFFSET]     = WIN_SMART;
        args.command_type                       = IDE_DRIVE_TASK_IN;
+       args.data_phase                         = TASKFILE_IN;
        args.handler                            = &task_in_intr;
        (void) smart_enable(drive);
        return ide_raw_taskfile(drive, &args, buf);
@@ -1331,6 +698,42 @@ static ide_proc_entry_t idedisk_proc[] = {
 
 #endif /* CONFIG_PROC_FS */
 
+static int idedisk_issue_flush(request_queue_t *q, struct gendisk *disk,
+                              sector_t *error_sector)
+{
+       ide_drive_t *drive = q->queuedata;
+       struct request *rq;
+       int ret;
+
+       if (!drive->wcache)
+               return 0;
+
+       rq = blk_get_request(q, WRITE, __GFP_WAIT);
+
+       memset(rq->cmd, 0, sizeof(rq->cmd));
+
+       if (ide_id_has_flush_cache_ext(drive->id) &&
+           (drive->capacity64 >= (1UL << 28)))
+               rq->cmd[0] = WIN_FLUSH_CACHE_EXT;
+       else
+               rq->cmd[0] = WIN_FLUSH_CACHE;
+
+
+       rq->flags |= REQ_DRIVE_TASK | REQ_SOFTBARRIER;
+       rq->buffer = rq->cmd;
+
+       ret = blk_execute_rq(q, disk, rq);
+
+       /*
+        * if we failed and caller wants error offset, get it
+        */
+       if (ret && error_sector)
+               *error_sector = ide_get_error_location(drive, rq->cmd);
+
+       blk_put_request(rq);
+       return ret;
+}
+
 /*
  * This is tightly woven into the driver->do_special can not touch.
  * DON'T do it again until a total personality rewrite is committed.
@@ -1359,11 +762,12 @@ static int set_nowerr(ide_drive_t *drive, int arg)
        return 0;
 }
 
-static int write_cache (ide_drive_t *drive, int arg)
+static int write_cache(ide_drive_t *drive, int arg)
 {
        ide_task_t args;
+       int err;
 
-       if (!(drive->id->cfs_enable_2 & 0x3000))
+       if (!ide_id_has_flush_cache(drive->id))
                return 1;
 
        memset(&args, 0, sizeof(ide_task_t));
@@ -1372,7 +776,10 @@ static int write_cache (ide_drive_t *drive, int arg)
        args.tfRegister[IDE_COMMAND_OFFSET]     = WIN_SETFEATURES;
        args.command_type                       = IDE_DRIVE_TASK_NO_DATA;
        args.handler                            = &task_no_data_intr;
-       (void) ide_raw_taskfile(drive, &args, NULL);
+
+       err = ide_raw_taskfile(drive, &args, NULL);
+       if (err)
+               return err;
 
        drive->wcache = arg;
        return 0;
@@ -1383,7 +790,7 @@ static int do_idedisk_flushcache (ide_drive_t *drive)
        ide_task_t args;
 
        memset(&args, 0, sizeof(ide_task_t));
-       if (drive->id->cfs_enable_2 & 0x2400)
+       if (ide_id_has_flush_cache_ext(drive->id))
                args.tfRegister[IDE_COMMAND_OFFSET]     = WIN_FLUSH_CACHE_EXT;
        else
                args.tfRegister[IDE_COMMAND_OFFSET]     = WIN_FLUSH_CACHE;
@@ -1408,34 +815,6 @@ static int set_acoustic (ide_drive_t *drive, int arg)
        return 0;
 }
 
-#ifdef CONFIG_BLK_DEV_IDE_TCQ
-static int set_using_tcq(ide_drive_t *drive, int arg)
-{
-       int ret;
-
-       if (!drive->driver)
-               return -EPERM;
-       if (arg == drive->queue_depth && drive->using_tcq)
-               return 0;
-
-       /*
-        * set depth, but check also id for max supported depth
-        */
-       drive->queue_depth = arg ? arg : 1;
-       if (drive->id) {
-               if (drive->queue_depth > drive->id->queue_depth + 1)
-                       drive->queue_depth = drive->id->queue_depth + 1;
-       }
-
-       if (arg)
-               ret = __ide_dma_queued_on(drive);
-       else
-               ret = __ide_dma_queued_off(drive);
-
-       return ret ? -EIO : 0;
-}
-#endif
-
 /*
  * drive->addressing:
  *     0: 28-bit
@@ -1471,9 +850,6 @@ static void idedisk_add_settings(ide_drive_t *drive)
        ide_add_setting(drive,  "acoustic",             SETTING_RW,                                     HDIO_GET_ACOUSTIC,      HDIO_SET_ACOUSTIC,      TYPE_BYTE,      0,      254,                            1,      1,      &drive->acoustic,               set_acoustic);
        ide_add_setting(drive,  "failures",             SETTING_RW,                                     -1,                     -1,                     TYPE_INT,       0,      65535,                          1,      1,      &drive->failures,               NULL);
        ide_add_setting(drive,  "max_failures",         SETTING_RW,                                     -1,                     -1,                     TYPE_INT,       0,      65535,                          1,      1,      &drive->max_failures,           NULL);
-#ifdef CONFIG_BLK_DEV_IDE_TCQ
-       ide_add_setting(drive,  "using_tcq",            SETTING_RW,                                     HDIO_GET_QDMA,          HDIO_SET_QDMA,          TYPE_BYTE,      0,      IDE_MAX_TAG,                    1,              1,              &drive->using_tcq,              set_using_tcq);
-#endif
 }
 
 /*
@@ -1486,7 +862,8 @@ enum {
        idedisk_pm_flush_cache  = ide_pm_state_start_suspend,
        idedisk_pm_standby,
 
-       idedisk_pm_restore_dma  = ide_pm_state_start_resume,
+       idedisk_pm_idle         = ide_pm_state_start_resume,
+       idedisk_pm_restore_dma,
 };
 
 static void idedisk_complete_power_step (ide_drive_t *drive, struct request *rq, u8 stat, u8 error)
@@ -1501,6 +878,9 @@ static void idedisk_complete_power_step (ide_drive_t *drive, struct request *rq,
        case idedisk_pm_standby:        /* Suspend step 2 (standby) complete */
                rq->pm->pm_step = ide_pm_state_completed;
                break;
+       case idedisk_pm_idle:           /* Resume step 1 (idle) complete */
+               rq->pm->pm_step = idedisk_pm_restore_dma;
+               break;
        }
 }
 
@@ -1513,24 +893,31 @@ static ide_startstop_t idedisk_start_power_step (ide_drive_t *drive, struct requ
        switch (rq->pm->pm_step) {
        case idedisk_pm_flush_cache:    /* Suspend step 1 (flush cache) */
                /* Not supported? Switch to next step now. */
-               if (!drive->wcache) {
+               if (!drive->wcache || !ide_id_has_flush_cache(drive->id)) {
                        idedisk_complete_power_step(drive, rq, 0, 0);
                        return ide_stopped;
                }
-               if (drive->id->cfs_enable_2 & 0x2400)
+               if (ide_id_has_flush_cache_ext(drive->id))
                        args->tfRegister[IDE_COMMAND_OFFSET] = WIN_FLUSH_CACHE_EXT;
                else
                        args->tfRegister[IDE_COMMAND_OFFSET] = WIN_FLUSH_CACHE;
                args->command_type = IDE_DRIVE_TASK_NO_DATA;
                args->handler      = &task_no_data_intr;
                return do_rw_taskfile(drive, args);
+
        case idedisk_pm_standby:        /* Suspend step 2 (standby) */
                args->tfRegister[IDE_COMMAND_OFFSET] = WIN_STANDBYNOW1;
                args->command_type = IDE_DRIVE_TASK_NO_DATA;
                args->handler      = &task_no_data_intr;
                return do_rw_taskfile(drive, args);
 
-       case idedisk_pm_restore_dma:    /* Resume step 1 (restore DMA) */
+       case idedisk_pm_idle:           /* Resume step 1 (idle) */
+               args->tfRegister[IDE_COMMAND_OFFSET] = WIN_IDLEIMMEDIATE;
+               args->command_type = IDE_DRIVE_TASK_NO_DATA;
+               args->handler = task_no_data_intr;
+               return do_rw_taskfile(drive, args);
+
+       case idedisk_pm_restore_dma:    /* Resume step 2 (restore DMA) */
                /*
                 * Right now, all we do is call hwif->ide_dma_check(drive),
                 * we could be smarter and check for current xfer_speed
@@ -1553,6 +940,7 @@ static void idedisk_setup (ide_drive_t *drive)
 {
        struct hd_driveid *id = drive->id;
        unsigned long long capacity;
+       int barrier;
 
        idedisk_add_settings(drive);
 
@@ -1584,7 +972,7 @@ static void idedisk_setup (ide_drive_t *drive)
                blk_queue_max_sectors(drive->queue, max_s);
        }
 
-       printk("%s: max request size: %dKiB\n", drive->name, drive->queue->max_sectors / 2);
+       printk(KERN_INFO "%s: max request size: %dKiB\n", drive->name, drive->queue->max_sectors / 2);
 
        /* Extract geometry if we did not already have one for the drive */
        if (!drive->cyl || !drive->head || !drive->sect) {
@@ -1613,13 +1001,22 @@ static void idedisk_setup (ide_drive_t *drive)
 
        /* limit drive capacity to 137GB if LBA48 cannot be used */
        if (drive->addressing == 0 && drive->capacity64 > 1ULL << 28) {
-               printk("%s: cannot use LBA48 - full capacity "
+               printk(KERN_WARNING "%s: cannot use LBA48 - full capacity "
                       "%llu sectors (%llu MB)\n",
                       drive->name, (unsigned long long)drive->capacity64,
                       sectors_to_MB(drive->capacity64));
                drive->capacity64 = 1ULL << 28;
        }
 
+       if (drive->hwif->no_lba48_dma && drive->addressing) {
+               if (drive->capacity64 > 1ULL << 28) {
+                       printk(KERN_INFO "%s: cannot use LBA48 DMA - PIO mode will"
+                                        " be used for accessing sectors > %u\n",
+                                        drive->name, 1 << 28);
+               } else
+                       drive->addressing = 0;
+       }
+
        /*
         * if possible, give fdisk access to more of the drive,
         * by correcting bios_cyls:
@@ -1659,7 +1056,7 @@ static void idedisk_setup (ide_drive_t *drive)
        printk(", CHS=%d/%d/%d", 
               drive->bios_cyl, drive->bios_head, drive->bios_sect);
        if (drive->using_dma)
-               (void) HWIF(drive)->ide_dma_verbose(drive);
+               ide_dma_verbose(drive);
        printk("\n");
 
        drive->mult_count = 0;
@@ -1678,18 +1075,48 @@ static void idedisk_setup (ide_drive_t *drive)
 #endif /* CONFIG_IDEDISK_MULTI_MODE */
        }
        drive->no_io_32bit = id->dword_io ? 1 : 0;
-       if (drive->id->cfs_enable_2 & 0x3000)
-               write_cache(drive, (id->cfs_enable_2 & 0x3000));
 
-#ifdef CONFIG_BLK_DEV_IDE_TCQ_DEFAULT
-       if (drive->using_dma)
-               __ide_dma_queued_on(drive);
-#endif
+       /* write cache enabled? */
+       if ((id->csfo & 1) || (id->cfs_enable_1 & (1 << 5)))
+               drive->wcache = 1;
+
+       write_cache(drive, 1);
+
+       /*
+        * We must avoid issuing commands a drive does not understand
+        * or we may crash it. We check flush cache is supported. We also
+        * check we have the LBA48 flush cache if the drive capacity is
+        * too large. By this time we have trimmed the drive capacity if
+        * LBA48 is not available so we don't need to recheck that.
+        */
+       barrier = 0;
+       if (ide_id_has_flush_cache(id))
+               barrier = 1;
+       if (drive->addressing == 1) {
+               /* Can't issue the correct flush ? */
+               if (capacity > (1ULL << 28) && !ide_id_has_flush_cache_ext(id))
+                       barrier = 0;
+       }
+
+       printk(KERN_DEBUG "%s: cache flushes %ssupported\n",
+               drive->name, barrier ? "" : "not ");
+       if (barrier) {
+               blk_queue_ordered(drive->queue, 1);
+               blk_queue_issue_flush_fn(drive->queue, idedisk_issue_flush);
+       }
+}
+
+static void ide_cacheflush_p(ide_drive_t *drive)
+{
+       if (!drive->wcache || !ide_id_has_flush_cache(drive->id))
+               return;
+
+       if (do_idedisk_flushcache(drive))
+               printk(KERN_INFO "%s: wcache flush failed!\n", drive->name);
 }
 
 static int idedisk_cleanup (ide_drive_t *drive)
 {
-       static int ide_cacheflush_p(ide_drive_t *drive);
        struct gendisk *g = drive->disk;
        ide_cacheflush_p(drive);
        if (ide_unregister_subdriver(drive))
@@ -1706,6 +1133,26 @@ static void ide_device_shutdown(struct device *dev)
 {
        ide_drive_t *drive = container_of(dev, ide_drive_t, gendev);
 
+#ifdef CONFIG_ALPHA
+       /* On Alpha, halt(8) doesn't actually turn the machine off,
+          it puts you into the sort of firmware monitor. Typically,
+          it's used to boot another kernel image, so it's not much
+          different from reboot(8). Therefore, we don't need to
+          spin down the disk in this case, especially since Alpha
+          firmware doesn't handle disks in standby mode properly.
+          On the other hand, it's reasonably safe to turn the power
+          off when the shutdown process reaches the firmware prompt,
+          as the firmware initialization takes rather long time -
+          at least 10 seconds, which should be sufficient for
+          the disk to expire its write cache. */
+       if (system_state != SYSTEM_POWER_OFF) {
+#else
+       if (system_state == SYSTEM_RESTART) {
+#endif
+               ide_cacheflush_p(drive);
+               return;
+       }
+
        printk("Shutdown: %s\n", drive->name);
        dev->bus->suspend(dev, PM_SUSPEND_STANDBY);
 }
@@ -1725,9 +1172,6 @@ static ide_driver_t idedisk_driver = {
        .supports_dsc_overlap   = 0,
        .cleanup                = idedisk_cleanup,
        .do_request             = ide_do_rw_disk,
-       .sense                  = idedisk_dump_status,
-       .error                  = idedisk_error,
-       .abort                  = idedisk_abort,
        .pre_reset              = idedisk_pre_reset,
        .capacity               = idedisk_capacity,
        .special                = idedisk_special,
@@ -1740,7 +1184,6 @@ static ide_driver_t idedisk_driver = {
 
 static int idedisk_open(struct inode *inode, struct file *filp)
 {
-       u8 cf;
        ide_drive_t *drive = inode->i_bdev->bd_disk->private_data;
        drive->usage++;
        if (drive->removable && drive->usage == 1) {
@@ -1758,35 +1201,6 @@ static int idedisk_open(struct inode *inode, struct file *filp)
                if (drive->doorlocking && ide_raw_taskfile(drive, &args, NULL))
                        drive->doorlocking = 0;
        }
-       drive->wcache = 0;
-       /* Cache enabled? */
-       if (drive->id->csfo & 1)
-               drive->wcache = 1;
-       /* Cache command set available? */
-       if (drive->id->cfs_enable_1 & (1 << 5))
-               drive->wcache = 1;
-       /* ATA6 cache extended commands */
-       cf = drive->id->command_set_2 >> 24;
-       if ((cf & 0xC0) == 0x40 && (cf & 0x30) != 0)
-               drive->wcache = 1;
-       return 0;
-}
-
-static int ide_cacheflush_p(ide_drive_t *drive)
-{
-       if (!(drive->id->cfs_enable_2 & 0x3000))
-               return 0;
-
-       if(drive->wcache)
-       {
-               if (do_idedisk_flushcache(drive))
-               {
-                       printk (KERN_INFO "%s: Write Cache FAILED Flushing!\n",
-                               drive->name);
-                       return -EIO;
-               }
-               return 1;
-       }
        return 0;
 }
 
@@ -1812,7 +1226,7 @@ static int idedisk_ioctl(struct inode *inode, struct file *file,
                        unsigned int cmd, unsigned long arg)
 {
        struct block_device *bdev = inode->i_bdev;
-       return generic_ide_ioctl(bdev, cmd, arg);
+       return generic_ide_ioctl(file, bdev, cmd, arg);
 }
 
 static int idedisk_media_changed(struct gendisk *disk)
@@ -1831,7 +1245,7 @@ static int idedisk_media_changed(struct gendisk *disk)
 static int idedisk_revalidate_disk(struct gendisk *disk)
 {
        ide_drive_t *drive = disk->private_data;
-       set_capacity(disk, current_capacity(drive));
+       set_capacity(disk, idedisk_capacity(drive));
        return 0;
 }
 
@@ -1867,22 +1281,16 @@ static int idedisk_attach(ide_drive_t *drive)
        if ((!drive->head || drive->head > 16) && !drive->select.b.lba) {
                printk(KERN_ERR "%s: INVALID GEOMETRY: %d PHYSICAL HEADS?\n",
                        drive->name, drive->head);
-               if ((drive->id->cfs_enable_2 & 0x3000) && drive->wcache)
-                       if (do_idedisk_flushcache(drive))
-                               printk (KERN_INFO "%s: Write Cache FAILED Flushing!\n",
-                                       drive->name);
-               ide_unregister_subdriver(drive);
-               DRIVER(drive)->busy--;
-               goto failed;
-       }
+               drive->attach = 0;
+       } else
+               drive->attach = 1;
        DRIVER(drive)->busy--;
        g->minors = 1 << PARTN_BITS;
        strcpy(g->devfs_name, drive->devfs_name);
        g->driverfs_dev = &drive->gendev;
        g->flags = drive->removable ? GENHD_FL_REMOVABLE : 0;
-       set_capacity(g, current_capacity(drive));
+       set_capacity(g, idedisk_capacity(drive));
        g->fops = &idedisk_ops;
-       drive->attach = 1;
        add_disk(g);
        return 0;
 failed: