fedora core 6 1.2949 + vserver 2.2.0
[linux-2.6.git] / drivers / ide / pci / piix.c
index c4161a5..c5ec6f1 100644 (file)
@@ -1,13 +1,14 @@
 /*
- *  linux/drivers/ide/pci/piix.c       Version 0.44    March 20, 2003
+ *  linux/drivers/ide/pci/piix.c       Version 0.45    May 12, 2006
  *
  *  Copyright (C) 1998-1999 Andrzej Krzysztofowicz, Author and Maintainer
  *  Copyright (C) 1998-2000 Andre Hedrick <andre@linux-ide.org>
  *  Copyright (C) 2003 Red Hat Inc <alan@redhat.com>
+ *  Copyright (C) 2006 MontaVista Software, Inc. <source@mvista.com>
  *
  *  May be copied or modified under the terms of the GNU General Public License
  *
- *  PIO mode setting function for Intel chipsets.  
+ *  PIO mode setting function for Intel chipsets.
  *  For use instead of BIOS settings.
  *
  * 40-41
@@ -25,7 +26,7 @@
  * sitre = word42 & 0x4000; secondary
  *
  * 44 8421|8421    hdd|hdb
- * 
+ *
  * 48 8421         hdd|hdc|hdb|hda udma enabled
  *
  *    0001         hda
@@ -90,7 +91,6 @@
  *     ICH3    errata #18      - Don't use native mode
  */
 
-#include <linux/config.h>
 #include <linux/types.h>
 #include <linux/module.h>
 #include <linux/kernel.h>
 
 #include <asm/io.h>
 
-#include "piix.h"
-
 static int no_piix_dma;
-#if defined(DISPLAY_PIIX_TIMINGS) && defined(CONFIG_PROC_FS)
-#include <linux/stat.h>
-#include <linux/proc_fs.h>
-
-static u8 piix_proc = 0;
-#define PIIX_MAX_DEVS          5
-static struct pci_dev *piix_devs[PIIX_MAX_DEVS];
-static int n_piix_devs;
-
-/**
- *     piix_get_info           -       fill in /proc for PIIX ide
- *     @buffer: buffer to fill
- *     @addr: address of user start in buffer
- *     @offset: offset into 'file'
- *     @count: buffer count
- *
- *     Walks the PIIX devices and outputs summary data on the tuning and
- *     anything else that will help with debugging
- */
-static int piix_get_info (char *buffer, char **addr, off_t offset, int count)
-{
-       char *p = buffer;
-       int i;
-
-       for (i = 0; i < n_piix_devs; i++) {
-               struct pci_dev *dev     = piix_devs[i];
-               unsigned long bibma = pci_resource_start(dev, 4);
-               u16 reg40 = 0, psitre = 0, reg42 = 0, ssitre = 0;
-               u8  c0 = 0, c1 = 0, reg54 = 0, reg55 = 0;
-               u8  reg44 = 0, reg48 = 0, reg4a = 0, reg4b = 0;
-
-               p += sprintf(p, "\nController: %d\n", i);
-               p += sprintf(p, "\n                                Intel ");
-               switch(dev->device) {
-                       case PCI_DEVICE_ID_INTEL_82801EB_1:
-                               p += sprintf(p, "PIIX4 SATA 150 ");
-                               break;
-                       case PCI_DEVICE_ID_INTEL_82801BA_8:
-                       case PCI_DEVICE_ID_INTEL_82801BA_9:
-                       case PCI_DEVICE_ID_INTEL_82801CA_10:
-                       case PCI_DEVICE_ID_INTEL_82801CA_11:
-                       case PCI_DEVICE_ID_INTEL_82801DB_10:
-                       case PCI_DEVICE_ID_INTEL_82801DB_11:
-                       case PCI_DEVICE_ID_INTEL_82801EB_11:
-                       case PCI_DEVICE_ID_INTEL_82801E_11:
-                       case PCI_DEVICE_ID_INTEL_ESB_2:
-                       case PCI_DEVICE_ID_INTEL_ICH6_19:
-                               p += sprintf(p, "PIIX4 Ultra 100 ");
-                               break;
-                       case PCI_DEVICE_ID_INTEL_82372FB_1:
-                       case PCI_DEVICE_ID_INTEL_82801AA_1:
-                               p += sprintf(p, "PIIX4 Ultra 66 ");
-                               break;
-                       case PCI_DEVICE_ID_INTEL_82451NX:
-                       case PCI_DEVICE_ID_INTEL_82801AB_1:
-                       case PCI_DEVICE_ID_INTEL_82443MX_1:
-                       case PCI_DEVICE_ID_INTEL_82371AB:
-                               p += sprintf(p, "PIIX4 Ultra 33 ");
-                               break;
-                       case PCI_DEVICE_ID_INTEL_82371SB_1:
-                               p += sprintf(p, "PIIX3 ");
-                               break;
-                       case PCI_DEVICE_ID_INTEL_82371MX:
-                               p += sprintf(p, "MPIIX ");
-                               break;
-                       case PCI_DEVICE_ID_INTEL_82371FB_1:
-                       case PCI_DEVICE_ID_INTEL_82371FB_0:
-                       default:
-                               p += sprintf(p, "PIIX ");
-                               break;
-               }
-               p += sprintf(p, "Chipset.\n");
-
-               if (dev->device == PCI_DEVICE_ID_INTEL_82371MX)
-                       continue;
-
-               pci_read_config_word(dev, 0x40, &reg40);
-               pci_read_config_word(dev, 0x42, &reg42);
-               pci_read_config_byte(dev, 0x44, &reg44);
-               pci_read_config_byte(dev, 0x48, &reg48);
-               pci_read_config_byte(dev, 0x4a, &reg4a);
-               pci_read_config_byte(dev, 0x4b, &reg4b);
-               pci_read_config_byte(dev, 0x54, &reg54);
-               pci_read_config_byte(dev, 0x55, &reg55);
-
-               psitre = (reg40 & 0x4000) ? 1 : 0;
-               ssitre = (reg42 & 0x4000) ? 1 : 0;
-
-               /*
-                * at that point bibma+0x2 et bibma+0xa are byte registers
-                * to investigate:
-                */
-               c0 = inb(bibma + 0x02);
-               c1 = inb(bibma + 0x0a);
-
-               p += sprintf(p, "--------------- Primary Channel "
-                               "---------------- Secondary Channel "
-                               "-------------\n");
-               p += sprintf(p, "                %sabled "
-                               "                        %sabled\n",
-                               (c0&0x80) ? "dis" : " en",
-                               (c1&0x80) ? "dis" : " en");
-               p += sprintf(p, "--------------- drive0 --------- drive1 "
-                               "-------- drive0 ---------- drive1 ------\n");
-               p += sprintf(p, "DMA enabled:    %s              %s "
-                               "            %s               %s\n",
-                               (c0&0x20) ? "yes" : "no ",
-                               (c0&0x40) ? "yes" : "no ",
-                               (c1&0x20) ? "yes" : "no ",
-                               (c1&0x40) ? "yes" : "no " );
-               p += sprintf(p, "UDMA enabled:   %s              %s "
-                               "            %s               %s\n",
-                               (reg48&0x01) ? "yes" : "no ",
-                               (reg48&0x02) ? "yes" : "no ",
-                               (reg48&0x04) ? "yes" : "no ",
-                               (reg48&0x08) ? "yes" : "no " );
-               p += sprintf(p, "UDMA enabled:   %s                %s "
-                               "              %s                 %s\n",
-                               ((reg54&0x11) &&
-                                (reg55&0x10) && (reg4a&0x01)) ? "5" :
-                               ((reg54&0x11) && (reg4a&0x02)) ? "4" :
-                               ((reg54&0x11) && (reg4a&0x01)) ? "3" :
-                               (reg4a&0x02) ? "2" :
-                               (reg4a&0x01) ? "1" :
-                               (reg4a&0x00) ? "0" : "X",
-                               ((reg54&0x22) &&
-                                (reg55&0x20) && (reg4a&0x10)) ? "5" :
-                               ((reg54&0x22) && (reg4a&0x20)) ? "4" :
-                               ((reg54&0x22) && (reg4a&0x10)) ? "3" :
-                               (reg4a&0x20) ? "2" :
-                               (reg4a&0x10) ? "1" :
-                               (reg4a&0x00) ? "0" : "X",
-                               ((reg54&0x44) &&
-                                (reg55&0x40) && (reg4b&0x03)) ? "5" :
-                               ((reg54&0x44) && (reg4b&0x02)) ? "4" :
-                               ((reg54&0x44) && (reg4b&0x01)) ? "3" :
-                               (reg4b&0x02) ? "2" :
-                               (reg4b&0x01) ? "1" :
-                               (reg4b&0x00) ? "0" : "X",
-                               ((reg54&0x88) &&
-                                (reg55&0x80) && (reg4b&0x30)) ? "5" :
-                               ((reg54&0x88) && (reg4b&0x20)) ? "4" :
-                               ((reg54&0x88) && (reg4b&0x10)) ? "3" :
-                               (reg4b&0x20) ? "2" :
-                               (reg4b&0x10) ? "1" :
-                               (reg4b&0x00) ? "0" : "X");
-
-               p += sprintf(p, "UDMA\n");
-               p += sprintf(p, "DMA\n");
-               p += sprintf(p, "PIO\n");
-
-               /*
-                * FIXME.... Add configuration junk data....blah blah......
-                */
-       }
-       return p-buffer;         /* => must be less than 4k! */
-}
-#endif  /* defined(DISPLAY_PIIX_TIMINGS) && defined(CONFIG_PROC_FS) */
 
 /**
  *     piix_ratemask           -       compute rate mask for PIIX IDE
@@ -288,11 +127,15 @@ static u8 piix_ratemask (ide_drive_t *drive)
                case PCI_DEVICE_ID_INTEL_82801CA_10:
                case PCI_DEVICE_ID_INTEL_82801CA_11:
                case PCI_DEVICE_ID_INTEL_82801E_11:
+               case PCI_DEVICE_ID_INTEL_82801DB_1:
                case PCI_DEVICE_ID_INTEL_82801DB_10:
                case PCI_DEVICE_ID_INTEL_82801DB_11:
                case PCI_DEVICE_ID_INTEL_82801EB_11:
                case PCI_DEVICE_ID_INTEL_ESB_2:
                case PCI_DEVICE_ID_INTEL_ICH6_19:
+               case PCI_DEVICE_ID_INTEL_ICH7_21:
+               case PCI_DEVICE_ID_INTEL_ESB2_18:
+               case PCI_DEVICE_ID_INTEL_ICH8_6:
                        mode = 3;
                        break;
                /* UDMA 66 capable */
@@ -379,35 +222,56 @@ static void piix_tune_drive (ide_drive_t *drive, u8 pio)
        unsigned long flags;
        u16 master_data;
        u8 slave_data;
+       static DEFINE_SPINLOCK(tune_lock);
+       int control = 0;
+
                                 /* ISP  RTC */
-       u8 timings[][2] = { { 0, 0 },
-                           { 0, 0 },
-                           { 1, 0 },
-                           { 2, 1 },
-                           { 2, 3 }, };
+       static const u8 timings[][2]= {
+                                       { 0, 0 },
+                                       { 0, 0 },
+                                       { 1, 0 },
+                                       { 2, 1 },
+                                       { 2, 3 }, };
 
        pio = ide_get_best_pio_mode(drive, pio, 5, NULL);
-       spin_lock_irqsave(&ide_lock, flags);
+
+       /*
+        * Master vs slave is synchronized above us but the slave register is
+        * shared by the two hwifs so the corner case of two slave timeouts in
+        * parallel must be locked.
+        */
+       spin_lock_irqsave(&tune_lock, flags);
        pci_read_config_word(dev, master_port, &master_data);
+
+       if (pio >= 2)
+               control |= 1;   /* Programmable timing on */
+       if (drive->media == ide_disk)
+               control |= 4;   /* Prefetch, post write */
+       if (pio >= 3)
+               control |= 2;   /* IORDY */
        if (is_slave) {
                master_data = master_data | 0x4000;
-               if (pio > 1)
+               if (pio > 1) {
                        /* enable PPE, IE and TIME */
-                       master_data = master_data | 0x0070;
+                       master_data = master_data | (control << 4);
+               } else {
+                       master_data &= ~0x0070;
+               }
                pci_read_config_byte(dev, slave_port, &slave_data);
                slave_data = slave_data & (hwif->channel ? 0x0f : 0xf0);
                slave_data = slave_data | (((timings[pio][0] << 2) | timings[pio][1]) << (hwif->channel ? 4 : 0));
        } else {
                master_data = master_data & 0xccf8;
-               if (pio > 1)
+               if (pio > 1) {
                        /* enable PPE, IE and TIME */
-                       master_data = master_data | 0x0007;
+                       master_data = master_data | control;
+               }
                master_data = master_data | (timings[pio][0] << 12) | (timings[pio][1] << 8);
        }
        pci_write_config_word(dev, master_port, master_data);
        if (is_slave)
                pci_write_config_byte(dev, slave_port, slave_data);
-       spin_unlock_irqrestore(&ide_lock, flags);
+       spin_unlock_irqrestore(&tune_lock, flags);
 }
 
 /**
@@ -489,57 +353,25 @@ static int piix_tune_chipset (ide_drive_t *drive, u8 xferspeed)
        return (ide_config_drive_speed(drive, speed));
 }
 
-/**
- *     piix_faulty_dma0                -       check for DMA0 errata
- *     @hwif: IDE interface to check
- *
- *     If an ICH/ICH0/ICH2 interface is is operating in multi-word
- *     DMA mode with 600nS cycle time the IDE PIO prefetch buffer will
- *     inadvertently provide an extra piece of secondary data to the primary
- *     device resulting in data corruption.
- *
- *     With such a device this test function returns true. This allows
- *     our tuning code to follow Intel recommendations and use PIO on
- *     such devices.
- */
-static int piix_faulty_dma0(ide_hwif_t *hwif)
-{
-       switch(hwif->pci_dev->device)
-       {
-               case PCI_DEVICE_ID_INTEL_82801AA_1:     /* ICH */
-               case PCI_DEVICE_ID_INTEL_82801AB_1:     /* ICH0 */
-               case PCI_DEVICE_ID_INTEL_82801BA_8:     /* ICH2 */
-               case PCI_DEVICE_ID_INTEL_82801BA_9:     /* ICH2 */
-                       return 1;
-       }
-       return 0;
-}
-
 /**
  *     piix_config_drive_for_dma       -       configure drive for DMA
  *     @drive: IDE drive to configure
  *
  *     Set up a PIIX interface channel for the best available speed.
- *     We prefer UDMA if it is available and then MWDMA. If DMA is 
- *     not available we switch to PIO and return 0. 
+ *     We prefer UDMA if it is available and then MWDMA.  If DMA is
+ *     not available we switch to PIO and return 0.
  */
  
 static int piix_config_drive_for_dma (ide_drive_t *drive)
 {
        u8 speed = ide_dma_speed(drive, piix_ratemask(drive));
-       
-       /* Some ICH devices cannot support DMA mode 0 */
-       if(speed == XFER_MW_DMA_0 && piix_faulty_dma0(HWIF(drive)))
-               speed = 0;
-
-       /* If no DMA speed was available or the chipset has DMA bugs
-          then disable DMA and use PIO */
-          
-       if (!speed || no_piix_dma) {
-               u8 tspeed = ide_get_best_pio_mode(drive, 255, 5, NULL);
-               speed = piix_dma_2_pio(XFER_PIO_0 + tspeed);
-       }
+
+       /*
+        * If no DMA speed was available or the chipset has DMA bugs
+        * then disable DMA and use PIO
+        */
+       if (!speed || no_piix_dma)
+               return 0;
 
        (void) piix_tune_chipset(drive, speed);
        return ide_dma_enable(drive);
@@ -562,31 +394,16 @@ static int piix_config_drive_xfer_rate (ide_drive_t *drive)
 
        if ((id->capability & 1) && drive->autodma) {
 
-               /* Consult the list of known "bad" drives */
-               if (__ide_dma_bad_drive(drive))
-                       goto fast_ata_pio;
-
-               /**
-                * Try to turn DMA on if:
-                *  - UDMA or EIDE modes are supported or
-                *  - drive is a known "good" drive
-                *
-                * Checks for best mode supported are down later by
-                * piix_config_drive_for_dma() -> ide_dma_speed()
-                */
-               if ((id->field_valid & (4 | 2)) ||
-                   (__ide_dma_good_drive(drive) && id->eide_dma_time < 150)) {
-                       if (piix_config_drive_for_dma(drive))
-                               return hwif->ide_dma_on(drive);
-               }
+               if (ide_use_dma(drive) && piix_config_drive_for_dma(drive))
+                       return hwif->ide_dma_on(drive);
 
-               /* For some reason DMA wasn't turned on, so try PIO. */
                goto fast_ata_pio;
 
        } else if ((id->capability & 8) || (id->field_valid & 2)) {
 fast_ata_pio:
                /* Find best PIO mode. */
-               hwif->tuneproc(drive, 255);
+               (void) hwif->speedproc(drive, XFER_PIO_0 +
+                                      ide_get_best_pio_mode(drive, 255, 4, NULL));
                return hwif->ide_dma_off_quietly(drive);
        }
        /* IORDY not supported */
@@ -594,17 +411,14 @@ fast_ata_pio:
 }
 
 /**
- *     init_chipset_piix       -       set up the PIIX chipset
- *     @dev: PCI device to set up
- *     @name: Name of the device
+ *     piix_is_ichx    -       check if ICHx
+ *     @dev: PCI device to check
  *
- *     Initialize the PCI device as required. For the PIIX this turns
- *     out to be nice and simple
+ *     returns 1 if ICHx, 0 otherwise.
  */
-static unsigned int __devinit init_chipset_piix (struct pci_dev *dev, const char *name)
+static int piix_is_ichx(struct pci_dev *dev)
 {
-        switch(dev->device) {
+        switch (dev->device) {
                case PCI_DEVICE_ID_INTEL_82801EB_1:
                case PCI_DEVICE_ID_INTEL_82801AA_1:
                case PCI_DEVICE_ID_INTEL_82801AB_1:
@@ -612,32 +426,60 @@ static unsigned int __devinit init_chipset_piix (struct pci_dev *dev, const char
                case PCI_DEVICE_ID_INTEL_82801BA_9:
                case PCI_DEVICE_ID_INTEL_82801CA_10:
                case PCI_DEVICE_ID_INTEL_82801CA_11:
+               case PCI_DEVICE_ID_INTEL_82801DB_1:
                case PCI_DEVICE_ID_INTEL_82801DB_10:
                case PCI_DEVICE_ID_INTEL_82801DB_11:
                case PCI_DEVICE_ID_INTEL_82801EB_11:
                case PCI_DEVICE_ID_INTEL_82801E_11:
                case PCI_DEVICE_ID_INTEL_ESB_2:
                case PCI_DEVICE_ID_INTEL_ICH6_19:
-               {
-                       unsigned int extra = 0;
-                       pci_read_config_dword(dev, 0x54, &extra);
-                       pci_write_config_dword(dev, 0x54, extra|0x400);
-               }
-               default:
-                       break;
+               case PCI_DEVICE_ID_INTEL_ICH7_21:
+               case PCI_DEVICE_ID_INTEL_ESB2_18:
+               case PCI_DEVICE_ID_INTEL_ICH8_6:
+                       return 1;
        }
 
-#if defined(DISPLAY_PIIX_TIMINGS) && defined(CONFIG_PROC_FS)
-       piix_devs[n_piix_devs++] = dev;
+       return 0;
+}
+
+/**
+ *     init_chipset_piix       -       set up the PIIX chipset
+ *     @dev: PCI device to set up
+ *     @name: Name of the device
+ *
+ *     Initialize the PCI device as required. For the PIIX this turns
+ *     out to be nice and simple
+ */
 
-       if (!piix_proc) {
-               piix_proc = 1;
-               ide_pci_create_host_proc("piix", piix_get_info);
+static unsigned int __devinit init_chipset_piix (struct pci_dev *dev, const char *name)
+{
+       if (piix_is_ichx(dev)) {
+               unsigned int extra = 0;
+               pci_read_config_dword(dev, 0x54, &extra);
+               pci_write_config_dword(dev, 0x54, extra|0x400);
        }
-#endif /* DISPLAY_PIIX_TIMINGS && CONFIG_PROC_FS */
+
        return 0;
 }
 
+/**
+ *     piix_dma_clear_irq      -       clear BMDMA status
+ *     @drive: IDE drive to clear
+ *
+ *     Called from ide_intr() for PIO interrupts
+ *     to clear BMDMA status as needed by ICHx
+ */
+static void piix_dma_clear_irq(ide_drive_t *drive)
+{
+       ide_hwif_t *hwif = HWIF(drive);
+       u8 dma_stat;
+
+       /* clear the INTR & ERROR bits */
+       dma_stat = hwif->INB(hwif->dma_status);
+       /* Should we force the bit as well ? */
+       hwif->OUTB(dma_stat, hwif->dma_status);
+}
+
 /**
  *     init_hwif_piix          -       fill in the hwif for the PIIX
  *     @hwif: IDE interface
@@ -670,6 +512,10 @@ static void __devinit init_hwif_piix(ide_hwif_t *hwif)
        if (!hwif->dma_base)
                return;
 
+       /* ICHx need to clear the bmdma status for all interrupts */
+       if (piix_is_ichx(hwif->pci_dev))
+               hwif->ide_dma_clear_irq = &piix_dma_clear_irq;
+
        hwif->atapi_dma = 1;
        hwif->ultra_mask = 0x3f;
        hwif->mwdma_mask = 0x06;
@@ -707,19 +553,53 @@ static void __devinit init_hwif_piix(ide_hwif_t *hwif)
        hwif->drives[0].autodma = hwif->autodma;
 }
 
-/**
- *     init_setup_piix         -       callback for IDE initialize
- *     @dev: PIIX PCI device
- *     @d: IDE pci info
- *
- *     Enable the xp fixup for the PIIX controller and then perform
- *     a standard ide PCI setup
- */
+#define DECLARE_PIIX_DEV(name_str) \
+       {                                               \
+               .name           = name_str,             \
+               .init_chipset   = init_chipset_piix,    \
+               .init_hwif      = init_hwif_piix,       \
+               .channels       = 2,                    \
+               .autodma        = AUTODMA,              \
+               .enablebits     = {{0x41,0x80,0x80}, {0x43,0x80,0x80}}, \
+               .bootable       = ON_BOARD,             \
+       }
 
-static void __devinit init_setup_piix(struct pci_dev *dev, ide_pci_device_t *d)
-{
-       ide_setup_pci_device(dev, d);
-}
+static ide_pci_device_t piix_pci_info[] __devinitdata = {
+       /*  0 */ DECLARE_PIIX_DEV("PIIXa"),
+       /*  1 */ DECLARE_PIIX_DEV("PIIXb"),
+
+       {       /* 2 */
+               .name           = "MPIIX",
+               .init_hwif      = init_hwif_piix,
+               .channels       = 2,
+               .autodma        = NODMA,
+               .enablebits     = {{0x6D,0x80,0x80}, {0x6F,0x80,0x80}},
+               .bootable       = ON_BOARD,
+       },
+
+       /*  3 */ DECLARE_PIIX_DEV("PIIX3"),
+       /*  4 */ DECLARE_PIIX_DEV("PIIX4"),
+       /*  5 */ DECLARE_PIIX_DEV("ICH0"),
+       /*  6 */ DECLARE_PIIX_DEV("PIIX4"),
+       /*  7 */ DECLARE_PIIX_DEV("ICH"),
+       /*  8 */ DECLARE_PIIX_DEV("PIIX4"),
+       /*  9 */ DECLARE_PIIX_DEV("PIIX4"),
+       /* 10 */ DECLARE_PIIX_DEV("ICH2"),
+       /* 11 */ DECLARE_PIIX_DEV("ICH2M"),
+       /* 12 */ DECLARE_PIIX_DEV("ICH3M"),
+       /* 13 */ DECLARE_PIIX_DEV("ICH3"),
+       /* 14 */ DECLARE_PIIX_DEV("ICH4"),
+       /* 15 */ DECLARE_PIIX_DEV("ICH5"),
+       /* 16 */ DECLARE_PIIX_DEV("C-ICH"),
+       /* 17 */ DECLARE_PIIX_DEV("ICH4"),
+       /* 18 */ DECLARE_PIIX_DEV("ICH5-SATA"),
+       /* 19 */ DECLARE_PIIX_DEV("ICH5"),
+       /* 20 */ DECLARE_PIIX_DEV("ICH6"),
+       /* 21 */ DECLARE_PIIX_DEV("ICH7"),
+       /* 22 */ DECLARE_PIIX_DEV("ICH4"),
+       /* 23 */ DECLARE_PIIX_DEV("ESB2"),
+       /* 24 */ DECLARE_PIIX_DEV("ICH8M"),
+};
 
 /**
  *     piix_init_one   -       called when a PIIX is found
@@ -734,8 +614,7 @@ static int __devinit piix_init_one(struct pci_dev *dev, const struct pci_device_
 {
        ide_pci_device_t *d = &piix_pci_info[id->driver_data];
 
-       d->init_setup(dev, d);
-       return 0;
+       return ide_setup_pci_device(dev, d);
 }
 
 /**
@@ -750,7 +629,7 @@ static void __devinit piix_check_450nx(void)
        struct pci_dev *pdev = NULL;
        u16 cfg;
        u8 rev;
-       while((pdev=pci_find_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82454NX, pdev))!=NULL)
+       while((pdev=pci_get_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82454NX, pdev))!=NULL)
        {
                /* Look for 450NX PXB. Check for problem configurations
                   A PCI quirk checks bit 6 already */
@@ -793,6 +672,10 @@ static struct pci_device_id piix_pci_tbl[] = {
 #endif
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB_2, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 19},
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH6_19, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 20},
+       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_21, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 21},
+       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801DB_1, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 22},
+       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB2_18, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 23},
+       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8_6, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 24},
        { 0, },
 };
 MODULE_DEVICE_TABLE(pci, piix_pci_tbl);