Fedora kernel-2.6.17-1.2142_FC4 patched with stable patch-2.6.17.4-vs2.0.2-rc26.diff
[linux-2.6.git] / drivers / input / mousedev.c
index f266b7e..b685a50 100644 (file)
@@ -9,7 +9,7 @@
  * the Free Software Foundation.
  */
 
-#define MOUSEDEV_MINOR_BASE    32
+#define MOUSEDEV_MINOR_BASE    32
 #define MOUSEDEV_MINORS                32
 #define MOUSEDEV_MIX           31
 
@@ -24,7 +24,6 @@
 #include <linux/random.h>
 #include <linux/major.h>
 #include <linux/device.h>
-#include <linux/devfs_fs_kernel.h>
 #ifdef CONFIG_INPUT_MOUSEDEV_PSAUX
 #include <linux/miscdevice.h>
 #endif
@@ -41,15 +40,22 @@ MODULE_LICENSE("GPL");
 #endif
 
 static int xres = CONFIG_INPUT_MOUSEDEV_SCREEN_X;
-module_param(xres, uint, 0);
+module_param(xres, uint, 0644);
 MODULE_PARM_DESC(xres, "Horizontal screen resolution");
 
 static int yres = CONFIG_INPUT_MOUSEDEV_SCREEN_Y;
-module_param(yres, uint, 0);
+module_param(yres, uint, 0644);
 MODULE_PARM_DESC(yres, "Vertical screen resolution");
 
-struct mousedev_motion {
+static unsigned tap_time = 200;
+module_param(tap_time, uint, 0644);
+MODULE_PARM_DESC(tap_time, "Tap time for touchpads in absolute mode (msecs)");
+
+struct mousedev_hw_data {
        int dx, dy, dz;
+       int x, y;
+       int abs_event;
+       unsigned long buttons;
 };
 
 struct mousedev {
@@ -61,22 +67,40 @@ struct mousedev {
        struct list_head list;
        struct input_handle handle;
 
-       struct mousedev_motion packet;
-       unsigned long buttons;
+       struct mousedev_hw_data packet;
        unsigned int pkt_count;
        int old_x[4], old_y[4];
-       unsigned int touch;
+       int frac_dx, frac_dy;
+       unsigned long touch;
 };
 
+enum mousedev_emul {
+       MOUSEDEV_EMUL_PS2,
+       MOUSEDEV_EMUL_IMPS,
+       MOUSEDEV_EMUL_EXPS
+};
+
+struct mousedev_motion {
+       int dx, dy, dz;
+       unsigned long buttons;
+};
+
+#define PACKET_QUEUE_LEN       16
 struct mousedev_list {
        struct fasync_struct *fasync;
        struct mousedev *mousedev;
        struct list_head node;
-       int dx, dy, dz;
-       unsigned long buttons;
+
+       struct mousedev_motion packets[PACKET_QUEUE_LEN];
+       unsigned int head, tail;
+       spinlock_t packet_lock;
+       int pos_x, pos_y;
+
        signed char ps2[6];
        unsigned char ready, buffer, bufsiz;
-       unsigned char mode, imexseq, impsseq;
+       unsigned char imexseq, impsseq;
+       enum mousedev_emul mode;
+       unsigned long last_buttons;
 };
 
 #define MOUSEDEV_SEQ_LEN       6
@@ -92,20 +116,33 @@ static struct mousedev mousedev_mix;
 #define fx(i)  (mousedev->old_x[(mousedev->pkt_count - (i)) & 03])
 #define fy(i)  (mousedev->old_y[(mousedev->pkt_count - (i)) & 03])
 
-static void mousedev_touchpad_event(struct mousedev *mousedev, unsigned int code, int value)
+static void mousedev_touchpad_event(struct input_dev *dev, struct mousedev *mousedev, unsigned int code, int value)
 {
+       int size, tmp;
+       enum { FRACTION_DENOM = 128 };
+
        if (mousedev->touch) {
+               size = dev->absmax[ABS_X] - dev->absmin[ABS_X];
+               if (size == 0) size = 256 * 2;
                switch (code) {
                        case ABS_X:
                                fx(0) = value;
-                               if (mousedev->pkt_count >= 2)
-                                       mousedev->packet.dx = ((fx(0) - fx(1)) / 2 + (fx(1) - fx(2)) / 2) / 8;
+                               if (mousedev->pkt_count >= 2) {
+                                       tmp = ((value - fx(2)) * (256 * FRACTION_DENOM)) / size;
+                                       tmp += mousedev->frac_dx;
+                                       mousedev->packet.dx = tmp / FRACTION_DENOM;
+                                       mousedev->frac_dx = tmp - mousedev->packet.dx * FRACTION_DENOM;
+                               }
                                break;
 
                        case ABS_Y:
                                fy(0) = value;
-                               if (mousedev->pkt_count >= 2)
-                                       mousedev->packet.dy = -((fy(0) - fy(1)) / 2 + (fy(1) - fy(2)) / 2) / 8;
+                               if (mousedev->pkt_count >= 2) {
+                                       tmp = -((value - fy(2)) * (256 * FRACTION_DENOM)) / size;
+                                       tmp += mousedev->frac_dy;
+                                       mousedev->packet.dy = tmp / FRACTION_DENOM;
+                                       mousedev->frac_dy = tmp - mousedev->packet.dy * FRACTION_DENOM;
+                               }
                                break;
                }
        }
@@ -118,16 +155,20 @@ static void mousedev_abs_event(struct input_dev *dev, struct mousedev *mousedev,
        switch (code) {
                case ABS_X:
                        size = dev->absmax[ABS_X] - dev->absmin[ABS_X];
-                       if (size == 0) size = xres;
-                       mousedev->packet.dx = (value * xres - mousedev->old_x[0]) / size;
-                       mousedev->old_x[0] = mousedev->packet.dx * size;
+                       if (size == 0) size = xres ? : 1;
+                       if (value > dev->absmax[ABS_X]) value = dev->absmax[ABS_X];
+                       if (value < dev->absmin[ABS_X]) value = dev->absmin[ABS_X];
+                       mousedev->packet.x = ((value - dev->absmin[ABS_X]) * xres) / size;
+                       mousedev->packet.abs_event = 1;
                        break;
 
                case ABS_Y:
                        size = dev->absmax[ABS_Y] - dev->absmin[ABS_Y];
-                       if (size == 0) size = yres;
-                       mousedev->packet.dy = (value * yres - mousedev->old_y[0]) / size;
-                       mousedev->old_y[0] = mousedev->packet.dy * size;
+                       if (size == 0) size = yres ? : 1;
+                       if (value > dev->absmax[ABS_Y]) value = dev->absmax[ABS_Y];
+                       if (value < dev->absmin[ABS_Y]) value = dev->absmin[ABS_Y];
+                       mousedev->packet.y = yres - ((value - dev->absmin[ABS_Y]) * yres) / size;
+                       mousedev->packet.abs_event = 1;
                        break;
        }
 }
@@ -165,28 +206,89 @@ static void mousedev_key_event(struct mousedev *mousedev, unsigned int code, int
        }
 
        if (value) {
-               set_bit(index, &mousedev->buttons);
-               set_bit(index, &mousedev_mix.buttons);
+               set_bit(index, &mousedev->packet.buttons);
+               set_bit(index, &mousedev_mix.packet.buttons);
        } else {
-               clear_bit(index, &mousedev->buttons);
-               clear_bit(index, &mousedev_mix.buttons);
+               clear_bit(index, &mousedev->packet.buttons);
+               clear_bit(index, &mousedev_mix.packet.buttons);
        }
 }
 
-static void mousedev_notify_readers(struct mousedev *mousedev, struct mousedev_motion *packet)
+static void mousedev_notify_readers(struct mousedev *mousedev, struct mousedev_hw_data *packet)
 {
        struct mousedev_list *list;
+       struct mousedev_motion *p;
+       unsigned long flags;
+       int wake_readers = 0;
 
        list_for_each_entry(list, &mousedev->list, node) {
-               list->dx += packet->dx;
-               list->dy += packet->dy;
-               list->dz += packet->dz;
-               list->buttons = mousedev->buttons;
-               list->ready = 1;
-               kill_fasync(&list->fasync, SIGIO, POLL_IN);
+               spin_lock_irqsave(&list->packet_lock, flags);
+
+               p = &list->packets[list->head];
+               if (list->ready && p->buttons != mousedev->packet.buttons) {
+                       unsigned int new_head = (list->head + 1) % PACKET_QUEUE_LEN;
+                       if (new_head != list->tail) {
+                               p = &list->packets[list->head = new_head];
+                               memset(p, 0, sizeof(struct mousedev_motion));
+                       }
+               }
+
+               if (packet->abs_event) {
+                       p->dx += packet->x - list->pos_x;
+                       p->dy += packet->y - list->pos_y;
+                       list->pos_x = packet->x;
+                       list->pos_y = packet->y;
+               }
+
+               list->pos_x += packet->dx;
+               list->pos_x = list->pos_x < 0 ? 0 : (list->pos_x >= xres ? xres : list->pos_x);
+               list->pos_y += packet->dy;
+               list->pos_y = list->pos_y < 0 ? 0 : (list->pos_y >= yres ? yres : list->pos_y);
+
+               p->dx += packet->dx;
+               p->dy += packet->dy;
+               p->dz += packet->dz;
+               p->buttons = mousedev->packet.buttons;
+
+               if (p->dx || p->dy || p->dz || p->buttons != list->last_buttons)
+                       list->ready = 1;
+
+               spin_unlock_irqrestore(&list->packet_lock, flags);
+
+               if (list->ready) {
+                       kill_fasync(&list->fasync, SIGIO, POLL_IN);
+                       wake_readers = 1;
+               }
        }
 
-       wake_up_interruptible(&mousedev->wait);
+       if (wake_readers)
+               wake_up_interruptible(&mousedev->wait);
+}
+
+static void mousedev_touchpad_touch(struct mousedev *mousedev, int value)
+{
+       if (!value) {
+               if (mousedev->touch &&
+                   time_before(jiffies, mousedev->touch + msecs_to_jiffies(tap_time))) {
+                       /*
+                        * Toggle left button to emulate tap.
+                        * We rely on the fact that mousedev_mix always has 0
+                        * motion packet so we won't mess current position.
+                        */
+                       set_bit(0, &mousedev->packet.buttons);
+                       set_bit(0, &mousedev_mix.packet.buttons);
+                       mousedev_notify_readers(mousedev, &mousedev_mix.packet);
+                       mousedev_notify_readers(&mousedev_mix, &mousedev_mix.packet);
+                       clear_bit(0, &mousedev->packet.buttons);
+                       clear_bit(0, &mousedev_mix.packet.buttons);
+               }
+               mousedev->touch = mousedev->pkt_count = 0;
+               mousedev->frac_dx = 0;
+               mousedev->frac_dy = 0;
+       }
+       else
+               if (!mousedev->touch)
+                       mousedev->touch = jiffies;
 }
 
 static void mousedev_event(struct input_handle *handle, unsigned int type, unsigned int code, int value)
@@ -200,7 +302,7 @@ static void mousedev_event(struct input_handle *handle, unsigned int type, unsig
                                return;
 
                        if (test_bit(BTN_TOOL_FINGER, handle->dev->keybit))
-                               mousedev_touchpad_event(mousedev, code, value);
+                               mousedev_touchpad_event(handle->dev, mousedev, code, value);
                        else
                                mousedev_abs_event(handle->dev, mousedev, code, value);
 
@@ -212,12 +314,8 @@ static void mousedev_event(struct input_handle *handle, unsigned int type, unsig
 
                case EV_KEY:
                        if (value != 2) {
-                               if (code == BTN_TOUCH && test_bit(BTN_TOOL_FINGER, handle->dev->keybit)) {
-                                       /* Handle touchpad data */
-                                       mousedev->touch = value;
-                                       if (!mousedev->touch)
-                                               mousedev->pkt_count = 0;
-                               }
+                               if (code == BTN_TOUCH && test_bit(BTN_TOOL_FINGER, handle->dev->keybit))
+                                       mousedev_touchpad_touch(mousedev, value);
                                else
                                        mousedev_key_event(mousedev, code, value);
                        }
@@ -237,7 +335,8 @@ static void mousedev_event(struct input_handle *handle, unsigned int type, unsig
                                mousedev_notify_readers(mousedev, &mousedev->packet);
                                mousedev_notify_readers(&mousedev_mix, &mousedev->packet);
 
-                               memset(&mousedev->packet, 0, sizeof(struct mousedev_motion));
+                               mousedev->packet.dx = mousedev->packet.dy = mousedev->packet.dz = 0;
+                               mousedev->packet.abs_event = 0;
                        }
                        break;
        }
@@ -253,13 +352,11 @@ static int mousedev_fasync(int fd, struct file *file, int on)
 
 static void mousedev_free(struct mousedev *mousedev)
 {
-       devfs_remove("input/mouse%d", mousedev->minor);
-       class_simple_device_remove(MKDEV(INPUT_MAJOR, MOUSEDEV_MINOR_BASE + mousedev->minor));
        mousedev_table[mousedev->minor] = NULL;
        kfree(mousedev);
 }
 
-static int mixdev_release(void)
+static void mixdev_release(void)
 {
        struct input_handle *handle;
 
@@ -273,8 +370,6 @@ static int mixdev_release(void)
                                mousedev_free(mousedev);
                }
        }
-
-       return 0;
 }
 
 static int mousedev_release(struct inode * inode, struct file * file)
@@ -287,9 +382,8 @@ static int mousedev_release(struct inode * inode, struct file * file)
 
        if (!--list->mousedev->open) {
                if (list->mousedev->minor == MOUSEDEV_MIX)
-                       return mixdev_release();
-
-               if (!mousedev_mix.open) {
+                       mixdev_release();
+               else if (!mousedev_mix.open) {
                        if (list->mousedev->exist)
                                input_close_device(&list->mousedev->handle);
                        else
@@ -318,10 +412,12 @@ static int mousedev_open(struct inode * inode, struct file * file)
        if (i >= MOUSEDEV_MINORS || !mousedev_table[i])
                return -ENODEV;
 
-       if (!(list = kmalloc(sizeof(struct mousedev_list), GFP_KERNEL)))
+       if (!(list = kzalloc(sizeof(struct mousedev_list), GFP_KERNEL)))
                return -ENOMEM;
-       memset(list, 0, sizeof(struct mousedev_list));
 
+       spin_lock_init(&list->packet_lock);
+       list->pos_x = xres / 2;
+       list->pos_y = yres / 2;
        list->mousedev = mousedev_table[i];
        list_add_tail(&list->node, &mousedev_table[i]->list);
        file->private_data = list;
@@ -341,32 +437,57 @@ static int mousedev_open(struct inode * inode, struct file * file)
        return 0;
 }
 
-static void mousedev_packet(struct mousedev_list *list, unsigned char off)
+static inline int mousedev_limit_delta(int delta, int limit)
 {
-       list->ps2[off] = 0x08 | ((list->dx < 0) << 4) | ((list->dy < 0) << 5) | (list->buttons & 0x07);
-       list->ps2[off + 1] = (list->dx > 127 ? 127 : (list->dx < -127 ? -127 : list->dx));
-       list->ps2[off + 2] = (list->dy > 127 ? 127 : (list->dy < -127 ? -127 : list->dy));
-       list->dx -= list->ps2[off + 1];
-       list->dy -= list->ps2[off + 2];
-       list->bufsiz = off + 3;
-
-       if (list->mode == 2) {
-               list->ps2[off + 3] = (list->dz > 7 ? 7 : (list->dz < -7 ? -7 : list->dz));
-               list->dz -= list->ps2[off + 3];
-               list->ps2[off + 3] = (list->ps2[off + 3] & 0x0f) | ((list->buttons & 0x18) << 1);
-               list->bufsiz++;
-       } else {
-               list->ps2[off] |= ((list->buttons & 0x10) >> 3) | ((list->buttons & 0x08) >> 1);
+       return delta > limit ? limit : (delta < -limit ? -limit : delta);
+}
+
+static void mousedev_packet(struct mousedev_list *list, signed char *ps2_data)
+{
+       struct mousedev_motion *p;
+       unsigned long flags;
+
+       spin_lock_irqsave(&list->packet_lock, flags);
+       p = &list->packets[list->tail];
+
+       ps2_data[0] = 0x08 | ((p->dx < 0) << 4) | ((p->dy < 0) << 5) | (p->buttons & 0x07);
+       ps2_data[1] = mousedev_limit_delta(p->dx, 127);
+       ps2_data[2] = mousedev_limit_delta(p->dy, 127);
+       p->dx -= ps2_data[1];
+       p->dy -= ps2_data[2];
+
+       switch (list->mode) {
+               case MOUSEDEV_EMUL_EXPS:
+                       ps2_data[3] = mousedev_limit_delta(p->dz, 7);
+                       p->dz -= ps2_data[3];
+                       ps2_data[3] = (ps2_data[3] & 0x0f) | ((p->buttons & 0x18) << 1);
+                       list->bufsiz = 4;
+                       break;
+
+               case MOUSEDEV_EMUL_IMPS:
+                       ps2_data[0] |= ((p->buttons & 0x10) >> 3) | ((p->buttons & 0x08) >> 1);
+                       ps2_data[3] = mousedev_limit_delta(p->dz, 127);
+                       p->dz -= ps2_data[3];
+                       list->bufsiz = 4;
+                       break;
+
+               case MOUSEDEV_EMUL_PS2:
+               default:
+                       ps2_data[0] |= ((p->buttons & 0x10) >> 3) | ((p->buttons & 0x08) >> 1);
+                       p->dz = 0;
+                       list->bufsiz = 3;
+                       break;
        }
 
-       if (list->mode == 1) {
-               list->ps2[off + 3] = (list->dz > 127 ? 127 : (list->dz < -127 ? -127 : list->dz));
-               list->dz -= list->ps2[off + 3];
-               list->bufsiz++;
+       if (!p->dx && !p->dy && !p->dz) {
+               if (list->tail == list->head) {
+                       list->ready = 0;
+                       list->last_buttons = p->buttons;
+               } else
+                       list->tail = (list->tail + 1) % PACKET_QUEUE_LEN;
        }
 
-       if (!list->dx && !list->dy && (!list->mode || !list->dz)) list->ready = 0;
-       list->buffer = list->bufsiz;
+       spin_unlock_irqrestore(&list->packet_lock, flags);
 }
 
 
@@ -384,31 +505,31 @@ static ssize_t mousedev_write(struct file * file, const char __user * buffer, si
                if (c == mousedev_imex_seq[list->imexseq]) {
                        if (++list->imexseq == MOUSEDEV_SEQ_LEN) {
                                list->imexseq = 0;
-                               list->mode = 2;
+                               list->mode = MOUSEDEV_EMUL_EXPS;
                        }
                } else list->imexseq = 0;
 
                if (c == mousedev_imps_seq[list->impsseq]) {
                        if (++list->impsseq == MOUSEDEV_SEQ_LEN) {
                                list->impsseq = 0;
-                               list->mode = 1;
+                               list->mode = MOUSEDEV_EMUL_IMPS;
                        }
                } else list->impsseq = 0;
 
                list->ps2[0] = 0xfa;
-               list->bufsiz = 1;
 
                switch (c) {
 
                        case 0xeb: /* Poll */
-                               mousedev_packet(list, 1);
+                               mousedev_packet(list, &list->ps2[1]);
+                               list->bufsiz++; /* account for leading ACK */
                                break;
 
                        case 0xf2: /* Get ID */
                                switch (list->mode) {
-                                       case 0: list->ps2[1] = 0; break;
-                                       case 1: list->ps2[1] = 3; break;
-                                       case 2: list->ps2[1] = 4; break;
+                                       case MOUSEDEV_EMUL_PS2:  list->ps2[1] = 0; break;
+                                       case MOUSEDEV_EMUL_IMPS: list->ps2[1] = 3; break;
+                                       case MOUSEDEV_EMUL_EXPS: list->ps2[1] = 4; break;
                                }
                                list->bufsiz = 2;
                                break;
@@ -419,13 +540,15 @@ static ssize_t mousedev_write(struct file * file, const char __user * buffer, si
                                break;
 
                        case 0xff: /* Reset */
-                               list->impsseq = 0;
-                               list->imexseq = 0;
-                               list->mode = 0;
-                               list->ps2[1] = 0xaa;
-                               list->ps2[2] = 0x00;
+                               list->impsseq = list->imexseq = 0;
+                               list->mode = MOUSEDEV_EMUL_PS2;
+                               list->ps2[1] = 0xaa; list->ps2[2] = 0x00;
                                list->bufsiz = 3;
                                break;
+
+                       default:
+                               list->bufsiz = 1;
+                               break;
                }
 
                list->buffer = list->bufsiz;
@@ -446,13 +569,19 @@ static ssize_t mousedev_read(struct file * file, char __user * buffer, size_t co
        if (!list->ready && !list->buffer && (file->f_flags & O_NONBLOCK))
                return -EAGAIN;
 
-       retval = wait_event_interruptible(list->mousedev->wait, list->ready || list->buffer);
+       retval = wait_event_interruptible(list->mousedev->wait,
+                                         !list->mousedev->exist || list->ready || list->buffer);
 
        if (retval)
                return retval;
 
-       if (!list->buffer && list->ready)
-               mousedev_packet(list, 0);
+       if (!list->mousedev->exist)
+               return -ENODEV;
+
+       if (!list->buffer && list->ready) {
+               mousedev_packet(list, list->ps2);
+               list->buffer = list->bufsiz;
+       }
 
        if (count > list->buffer)
                count = list->buffer;
@@ -470,12 +599,11 @@ static unsigned int mousedev_poll(struct file *file, poll_table *wait)
 {
        struct mousedev_list *list = file->private_data;
        poll_wait(file, &list->mousedev->wait, wait);
-       if (list->ready || list->buffer)
-               return POLLIN | POLLRDNORM;
-       return 0;
+       return ((list->ready || list->buffer) ? (POLLIN | POLLRDNORM) : 0) |
+               (list->mousedev->exist ? 0 : (POLLHUP | POLLERR));
 }
 
-struct file_operations mousedev_fops = {
+static struct file_operations mousedev_fops = {
        .owner =        THIS_MODULE,
        .read =         mousedev_read,
        .write =        mousedev_write,
@@ -488,6 +616,7 @@ struct file_operations mousedev_fops = {
 static struct input_handle *mousedev_connect(struct input_handler *handler, struct input_dev *dev, struct input_device_id *id)
 {
        struct mousedev *mousedev;
+       struct class_device *cdev;
        int minor = 0;
 
        for (minor = 0; minor < MOUSEDEV_MINORS && mousedev_table[minor]; minor++);
@@ -496,9 +625,8 @@ static struct input_handle *mousedev_connect(struct input_handler *handler, stru
                return NULL;
        }
 
-       if (!(mousedev = kmalloc(sizeof(struct mousedev), GFP_KERNEL)))
+       if (!(mousedev = kzalloc(sizeof(struct mousedev), GFP_KERNEL)))
                return NULL;
-       memset(mousedev, 0, sizeof(struct mousedev));
 
        INIT_LIST_HEAD(&mousedev->list);
        init_waitqueue_head(&mousedev->wait);
@@ -516,11 +644,13 @@ static struct input_handle *mousedev_connect(struct input_handler *handler, stru
 
        mousedev_table[minor] = mousedev;
 
-       devfs_mk_cdev(MKDEV(INPUT_MAJOR, MOUSEDEV_MINOR_BASE + minor),
-                       S_IFCHR|S_IRUGO|S_IWUSR, "input/mouse%d", minor);
-       class_simple_device_add(input_class,
-                               MKDEV(INPUT_MAJOR, MOUSEDEV_MINOR_BASE + minor),
-                               dev->dev, "mouse%d", minor);
+       cdev = class_device_create(&input_class, &dev->cdev,
+                       MKDEV(INPUT_MAJOR, MOUSEDEV_MINOR_BASE + minor),
+                       dev->cdev.dev, mousedev->name);
+
+       /* temporary symlink to keep userspace happy */
+       sysfs_create_link(&input_class.subsys.kset.kobj, &cdev->kobj,
+                         mousedev->name);
 
        return &mousedev->handle;
 }
@@ -528,11 +658,18 @@ static struct input_handle *mousedev_connect(struct input_handler *handler, stru
 static void mousedev_disconnect(struct input_handle *handle)
 {
        struct mousedev *mousedev = handle->private;
+       struct mousedev_list *list;
 
+       sysfs_remove_link(&input_class.subsys.kset.kobj, mousedev->name);
+       class_device_destroy(&input_class,
+                       MKDEV(INPUT_MAJOR, MOUSEDEV_MINOR_BASE + mousedev->minor));
        mousedev->exist = 0;
 
        if (mousedev->open) {
                input_close_device(handle);
+               wake_up_interruptible(&mousedev->wait);
+               list_for_each_entry(list, &mousedev->list, node)
+                       kill_fasync(&list->fasync, SIGIO, POLL_HUP);
        } else {
                if (mousedev_mix.open)
                        input_close_device(handle);
@@ -598,10 +735,8 @@ static int __init mousedev_init(void)
        mousedev_mix.exist = 1;
        mousedev_mix.minor = MOUSEDEV_MIX;
 
-       devfs_mk_cdev(MKDEV(INPUT_MAJOR, MOUSEDEV_MINOR_BASE + MOUSEDEV_MIX),
-                       S_IFCHR|S_IRUGO|S_IWUSR, "input/mice");
-       class_simple_device_add(input_class, MKDEV(INPUT_MAJOR, MOUSEDEV_MINOR_BASE + MOUSEDEV_MIX),
-                               NULL, "mice");
+       class_device_create(&input_class, NULL,
+                       MKDEV(INPUT_MAJOR, MOUSEDEV_MINOR_BASE + MOUSEDEV_MIX), NULL, "mice");
 
 #ifdef CONFIG_INPUT_MOUSEDEV_PSAUX
        if (!(psaux_registered = !misc_register(&psaux_mouse)))
@@ -619,8 +754,8 @@ static void __exit mousedev_exit(void)
        if (psaux_registered)
                misc_deregister(&psaux_mouse);
 #endif
-       devfs_remove("input/mice");
-       class_simple_device_remove(MKDEV(INPUT_MAJOR, MOUSEDEV_MINOR_BASE + MOUSEDEV_MIX));
+       class_device_destroy(&input_class,
+                       MKDEV(INPUT_MAJOR, MOUSEDEV_MINOR_BASE + MOUSEDEV_MIX));
        input_unregister_handler(&mousedev_handler);
 }