Revert to Fedora kernel-2.6.17-1.2187_FC5 patched with vs2.0.2.1; there are too many...
[linux-2.6.git] / drivers / media / video / cx88 / cx88-dvb.c
index fd3ef4c..3619a44 100644 (file)
@@ -51,7 +51,6 @@
 #endif
 #ifdef HAVE_LGDT330X
 # include "lgdt330x.h"
-# include "lg_h06xf.h"
 #endif
 #ifdef HAVE_NXT200X
 # include "nxt200x.h"
@@ -59,7 +58,6 @@
 #ifdef HAVE_CX24123
 # include "cx24123.h"
 #endif
-#include "isl6421.h"
 
 MODULE_DESCRIPTION("driver for cx2388x based DVB cards");
 MODULE_AUTHOR("Chris Pascoe <c.pascoe@itee.uq.edu.au>");
@@ -115,6 +113,21 @@ static struct videobuf_queue_ops dvb_qops = {
 
 /* ------------------------------------------------------------------ */
 
+#if defined(HAVE_MT352) || defined(HAVE_ZL10353)
+static int zarlink_pll_set(struct dvb_frontend *fe,
+                             struct dvb_frontend_parameters *params,
+                             u8 *pllbuf)
+{
+       struct cx8802_dev *dev = fe->dvb->priv;
+
+       pllbuf[0] = dev->core->pll_addr << 1;
+       dvb_pll_configure(dev->core->pll_desc, pllbuf + 1,
+                         params->frequency,
+                         params->u.ofdm.bandwidth);
+       return 0;
+}
+#endif
+
 #ifdef HAVE_MT352
 static int dvico_fusionhdtv_demod_init(struct dvb_frontend* fe)
 {
@@ -183,16 +196,19 @@ static int dntv_live_dvbt_demod_init(struct dvb_frontend* fe)
 static struct mt352_config dvico_fusionhdtv = {
        .demod_address = 0x0F,
        .demod_init    = dvico_fusionhdtv_demod_init,
+       .pll_set       = zarlink_pll_set,
 };
 
 static struct mt352_config dntv_live_dvbt_config = {
        .demod_address = 0x0f,
        .demod_init    = dntv_live_dvbt_demod_init,
+       .pll_set       = zarlink_pll_set,
 };
 
 static struct mt352_config dvico_fusionhdtv_dual = {
        .demod_address = 0x0F,
        .demod_init    = dvico_dual_demod_init,
+       .pll_set       = zarlink_pll_set,
 };
 
 #ifdef HAVE_VP3054_I2C
@@ -230,8 +246,6 @@ static int philips_fmd1216_pll_init(struct dvb_frontend *fe)
                  .buf = fmd1216_init, .len = sizeof(fmd1216_init) };
        int err;
 
-       if (fe->ops.i2c_gate_ctrl)
-               fe->ops.i2c_gate_ctrl(fe, 1);
        if ((err = i2c_transfer(&dev->core->i2c_adap, &msg, 1)) != 1) {
                if (err < 0)
                        return err;
@@ -242,14 +256,14 @@ static int philips_fmd1216_pll_init(struct dvb_frontend *fe)
        return 0;
 }
 
-static int dntv_live_dvbt_pro_tuner_set_params(struct dvb_frontend* fe,
-                                              struct dvb_frontend_parameters* params)
+static int dntv_live_dvbt_pro_pll_set(struct dvb_frontend* fe,
+                                     struct dvb_frontend_parameters* params,
+                                     u8* pllbuf)
 {
        struct cx8802_dev *dev= fe->dvb->priv;
-       u8 buf[4];
        struct i2c_msg msg =
                { .addr = dev->core->pll_addr, .flags = 0,
-                 .buf = buf, .len = 4 };
+                 .buf = pllbuf+1, .len = 4 };
        int err;
 
        /* Switch PLL to DVB mode */
@@ -258,16 +272,14 @@ static int dntv_live_dvbt_pro_tuner_set_params(struct dvb_frontend* fe,
                return err;
 
        /* Tune PLL */
-       dvb_pll_configure(dev->core->pll_desc, buf,
+       pllbuf[0] = dev->core->pll_addr << 1;
+       dvb_pll_configure(dev->core->pll_desc, pllbuf+1,
                          params->frequency,
                          params->u.ofdm.bandwidth);
-       if (fe->ops.i2c_gate_ctrl)
-               fe->ops.i2c_gate_ctrl(fe, 1);
        if ((err = i2c_transfer(&dev->core->i2c_adap, &msg, 1)) != 1) {
-
                printk(KERN_WARNING "cx88-dvb: %s error "
                           "(addr %02x <- %02x, err = %i)\n",
-                          __FUNCTION__, dev->core->pll_addr, buf[0], err);
+                          __FUNCTION__, pllbuf[0], pllbuf[1], err);
                if (err < 0)
                        return err;
                else
@@ -281,27 +293,27 @@ static struct mt352_config dntv_live_dvbt_pro_config = {
        .demod_address = 0x0f,
        .no_tuner      = 1,
        .demod_init    = dntv_live_dvbt_pro_demod_init,
+       .pll_set       = dntv_live_dvbt_pro_pll_set,
 };
 #endif
 #endif
 
 #ifdef HAVE_ZL10353
-static int dvico_hybrid_tuner_set_params(struct dvb_frontend *fe,
-                                        struct dvb_frontend_parameters *params)
+static int dvico_hybrid_tune_pll(struct dvb_frontend *fe,
+                                struct dvb_frontend_parameters *params,
+                                u8 *pllbuf)
 {
-       u8 pllbuf[4];
        struct cx8802_dev *dev= fe->dvb->priv;
        struct i2c_msg msg =
                { .addr = dev->core->pll_addr, .flags = 0,
-                 .buf = pllbuf, .len = 4 };
+                 .buf = pllbuf + 1, .len = 4 };
        int err;
 
-       dvb_pll_configure(dev->core->pll_desc, pllbuf,
+       pllbuf[0] = dev->core->pll_addr << 1;
+       dvb_pll_configure(dev->core->pll_desc, pllbuf + 1,
                          params->frequency,
                          params->u.ofdm.bandwidth);
 
-       if (fe->ops.i2c_gate_ctrl)
-               fe->ops.i2c_gate_ctrl(fe, 1);
        if ((err = i2c_transfer(&dev->core->i2c_adap, &msg, 1)) != 1) {
                printk(KERN_WARNING "cx88-dvb: %s error "
                           "(addr %02x <- %02x, err = %i)\n",
@@ -317,11 +329,12 @@ static int dvico_hybrid_tuner_set_params(struct dvb_frontend *fe,
 
 static struct zl10353_config dvico_fusionhdtv_hybrid = {
        .demod_address = 0x0F,
-       .no_tuner      = 1,
+       .pll_set       = dvico_hybrid_tune_pll,
 };
 
 static struct zl10353_config dvico_fusionhdtv_plus_v1_1 = {
        .demod_address = 0x0F,
+       .pll_set       = zarlink_pll_set,
 };
 #endif
 
@@ -329,15 +342,21 @@ static struct zl10353_config dvico_fusionhdtv_plus_v1_1 = {
 static struct cx22702_config connexant_refboard_config = {
        .demod_address = 0x43,
        .output_mode   = CX22702_SERIAL_OUTPUT,
+       .pll_address   = 0x60,
+       .pll_desc      = &dvb_pll_thomson_dtt7579,
 };
 
 static struct cx22702_config hauppauge_novat_config = {
        .demod_address = 0x43,
        .output_mode   = CX22702_SERIAL_OUTPUT,
+       .pll_address   = 0x61,
+       .pll_desc      = &dvb_pll_thomson_dtt759x,
 };
 static struct cx22702_config hauppauge_hvr1100_config = {
        .demod_address = 0x63,
        .output_mode   = CX22702_SERIAL_OUTPUT,
+       .pll_address   = 0x61,
+       .pll_desc      = &dvb_pll_fmd1216me,
 };
 #endif
 
@@ -352,13 +371,15 @@ static int or51132_set_ts_param(struct dvb_frontend* fe,
 
 static struct or51132_config pchdtv_hd3000 = {
        .demod_address    = 0x15,
+       .pll_address      = 0x61,
+       .pll_desc         = &dvb_pll_thomson_dtt761x,
        .set_ts_params    = or51132_set_ts_param,
 };
 #endif
 
 #ifdef HAVE_LGDT330X
-static int lgdt3302_tuner_set_params(struct dvb_frontend* fe,
-                                    struct dvb_frontend_parameters* params)
+static int lgdt330x_pll_set(struct dvb_frontend* fe,
+                           struct dvb_frontend_parameters* params)
 {
        /* FIXME make this routine use the tuner-simple code.
         * It could probably be shared with a number of ATSC
@@ -371,12 +392,12 @@ static int lgdt3302_tuner_set_params(struct dvb_frontend* fe,
                { .addr = dev->core->pll_addr, .flags = 0, .buf = buf, .len = 4 };
        int err;
 
+       /* Put the analog decoder in standby to keep it quiet */
+       cx88_call_i2c_clients (dev->core, TUNER_SET_STANDBY, NULL);
+
        dvb_pll_configure(core->pll_desc, buf, params->frequency, 0);
        dprintk(1, "%s: tuner at 0x%02x bytes: 0x%02x 0x%02x 0x%02x 0x%02x\n",
                        __FUNCTION__, msg.addr, buf[0],buf[1],buf[2],buf[3]);
-
-       if (fe->ops.i2c_gate_ctrl)
-               fe->ops.i2c_gate_ctrl(fe, 1);
        if ((err = i2c_transfer(&core->i2c_adap, &msg, 1)) != 1) {
                printk(KERN_WARNING "cx88-dvb: %s error "
                           "(addr %02x <- %02x, err = %i)\n",
@@ -386,21 +407,16 @@ static int lgdt3302_tuner_set_params(struct dvb_frontend* fe,
                else
                        return -EREMOTEIO;
        }
+       if (core->tuner_type == TUNER_LG_TDVS_H062F) {
+               /* Set the Auxiliary Byte. */
+               buf[2] &= ~0x20;
+               buf[2] |= 0x18;
+               buf[3] = 0x50;
+               i2c_transfer(&core->i2c_adap, &msg, 1);
+       }
        return 0;
 }
 
-static int lgdt3303_tuner_set_params(struct dvb_frontend* fe,
-                                    struct dvb_frontend_parameters* params)
-{
-       struct cx8802_dev *dev= fe->dvb->priv;
-       struct cx88_core *core = dev->core;
-
-       /* Put the analog decoder in standby to keep it quiet */
-       cx88_call_i2c_clients (dev->core, TUNER_SET_STANDBY, NULL);
-
-       return lg_h06xf_pll_set(fe, &core->i2c_adap, params);
-}
-
 static int lgdt330x_pll_rf_set(struct dvb_frontend* fe, int index)
 {
        struct cx8802_dev *dev= fe->dvb->priv;
@@ -428,6 +444,7 @@ static struct lgdt330x_config fusionhdtv_3_gold = {
        .demod_address    = 0x0e,
        .demod_chip       = LGDT3302,
        .serial_mpeg      = 0x04, /* TPSERIAL for 3302 in TOP_CONTROL */
+       .pll_set          = lgdt330x_pll_set,
        .set_ts_params    = lgdt330x_set_ts_param,
 };
 
@@ -435,13 +452,7 @@ static struct lgdt330x_config fusionhdtv_5_gold = {
        .demod_address    = 0x0e,
        .demod_chip       = LGDT3303,
        .serial_mpeg      = 0x40, /* TPSERIAL for 3303 in TOP_CONTROL */
-       .set_ts_params    = lgdt330x_set_ts_param,
-};
-
-static struct lgdt330x_config pchdtv_hd5500 = {
-       .demod_address    = 0x59,
-       .demod_chip       = LGDT3303,
-       .serial_mpeg      = 0x40, /* TPSERIAL for 3303 in TOP_CONTROL */
+       .pll_set          = lgdt330x_pll_set,
        .set_ts_params    = lgdt330x_set_ts_param,
 };
 #endif
@@ -466,6 +477,8 @@ static int nxt200x_set_pll_input(u8* buf, int input)
 
 static struct nxt200x_config ati_hdtvwonder = {
        .demod_address    = 0x0a,
+       .pll_address      = 0x61,
+       .pll_desc         = &dvb_pll_tuv1236d,
        .set_pll_input    = nxt200x_set_pll_input,
        .set_ts_params    = nxt200x_set_ts_param,
 };
@@ -480,50 +493,28 @@ static int cx24123_set_ts_param(struct dvb_frontend* fe,
        return 0;
 }
 
-static int kworld_dvbs_100_set_voltage(struct dvb_frontend* fe, fe_sec_voltage_t voltage)
+static void cx24123_enable_lnb_voltage(struct dvb_frontend* fe, int on)
 {
        struct cx8802_dev *dev= fe->dvb->priv;
        struct cx88_core *core = dev->core;
 
-       if (voltage == SEC_VOLTAGE_OFF) {
-               cx_write(MO_GP0_IO, 0x000006fB);
-       } else {
+       if (on)
                cx_write(MO_GP0_IO, 0x000006f9);
-       }
-
-       if (core->prev_set_voltage)
-               return core->prev_set_voltage(fe, voltage);
-       return 0;
-}
-
-static int geniatech_dvbs_set_voltage(struct dvb_frontend *fe, fe_sec_voltage_t voltage)
-{
-       struct cx8802_dev *dev= fe->dvb->priv;
-       struct cx88_core *core = dev->core;
-
-       if (voltage == SEC_VOLTAGE_OFF) {
-               dprintk(1,"LNB Voltage OFF\n");
-               cx_write(MO_GP0_IO, 0x0000efff);
-       }
-
-       if (core->prev_set_voltage)
-               return core->prev_set_voltage(fe, voltage);
-       return 0;
+       else
+               cx_write(MO_GP0_IO, 0x000006fB);
 }
 
-static struct cx24123_config geniatech_dvbs_config = {
-       .demod_address  = 0x55,
-       .set_ts_params  = cx24123_set_ts_param,
-};
-
 static struct cx24123_config hauppauge_novas_config = {
        .demod_address          = 0x55,
+       .use_isl6421            = 1,
        .set_ts_params          = cx24123_set_ts_param,
 };
 
 static struct cx24123_config kworld_dvbs_100_config = {
        .demod_address          = 0x15,
+       .use_isl6421            = 0,
        .set_ts_params          = cx24123_set_ts_param,
+       .enable_lnb_voltage     = cx24123_enable_lnb_voltage,
 };
 #endif
 
@@ -539,11 +530,6 @@ static int dvb_register(struct cx8802_dev *dev)
        case CX88_BOARD_HAUPPAUGE_DVB_T1:
                dev->dvb.frontend = cx22702_attach(&hauppauge_novat_config,
                                                   &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dvb_pll_attach(dev->dvb.frontend, 0x61,
-                                      &dev->core->i2c_adap,
-                                      &dvb_pll_thomson_dtt759x);
-               }
                break;
        case CX88_BOARD_TERRATEC_CINERGY_1400_DVB_T1:
        case CX88_BOARD_CONEXANT_DVB_T1:
@@ -551,92 +537,44 @@ static int dvb_register(struct cx8802_dev *dev)
        case CX88_BOARD_WINFAST_DTV1000:
                dev->dvb.frontend = cx22702_attach(&connexant_refboard_config,
                                                   &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dvb_pll_attach(dev->dvb.frontend, 0x60,
-                                      &dev->core->i2c_adap,
-                                      &dvb_pll_thomson_dtt7579);
-               }
                break;
-       case CX88_BOARD_WINFAST_DTV2000H:
        case CX88_BOARD_HAUPPAUGE_HVR1100:
        case CX88_BOARD_HAUPPAUGE_HVR1100LP:
                dev->dvb.frontend = cx22702_attach(&hauppauge_hvr1100_config,
                                                   &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dvb_pll_attach(dev->dvb.frontend, 0x61,
-                                      &dev->core->i2c_adap,
-                                      &dvb_pll_fmd1216me);
-               }
                break;
 #endif
 #if defined(HAVE_MT352) || defined(HAVE_ZL10353)
        case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_PLUS:
+               dev->core->pll_addr = 0x60;
+               dev->core->pll_desc = &dvb_pll_thomson_dtt7579;
 #ifdef HAVE_MT352
                dev->dvb.frontend = mt352_attach(&dvico_fusionhdtv,
                                                 &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dvb_pll_attach(dev->dvb.frontend, 0x60,
-                                      NULL,
-                                      &dvb_pll_thomson_dtt7579);
+               if (dev->dvb.frontend != NULL)
                        break;
-               }
 #endif
 #ifdef HAVE_ZL10353
                /* ZL10353 replaces MT352 on later cards */
                dev->dvb.frontend = zl10353_attach(&dvico_fusionhdtv_plus_v1_1,
                                                   &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dvb_pll_attach(dev->dvb.frontend, 0x60,
-                                      NULL,
-                                      &dvb_pll_thomson_dtt7579);
-               }
-#endif
-               break;
-       case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL:
-#ifdef HAVE_MT352
-               /* The tin box says DEE1601, but it seems to be DTT7579
-                * compatible, with a slightly different MT352 AGC gain. */
-               dev->dvb.frontend = mt352_attach(&dvico_fusionhdtv_dual,
-                                                &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dvb_pll_attach(dev->dvb.frontend, 0x61,
-                                      NULL,
-                                      &dvb_pll_thomson_dtt7579);
-                       break;
-               }
-#endif
-#ifdef HAVE_ZL10353
-               /* ZL10353 replaces MT352 on later cards */
-               dev->dvb.frontend = zl10353_attach(&dvico_fusionhdtv_plus_v1_1,
-                                                  &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dvb_pll_attach(dev->dvb.frontend, 0x61,
-                                      NULL,
-                                      &dvb_pll_thomson_dtt7579);
-               }
 #endif
                break;
 #endif /* HAVE_MT352 || HAVE_ZL10353 */
 #ifdef HAVE_MT352
        case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T1:
+               dev->core->pll_addr = 0x61;
+               dev->core->pll_desc = &dvb_pll_lg_z201;
                dev->dvb.frontend = mt352_attach(&dvico_fusionhdtv,
                                                 &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dvb_pll_attach(dev->dvb.frontend, 0x61,
-                                      NULL,
-                                      &dvb_pll_lg_z201);
-               }
                break;
        case CX88_BOARD_KWORLD_DVB_T:
        case CX88_BOARD_DNTV_LIVE_DVB_T:
        case CX88_BOARD_ADSTECH_DVB_T_PCI:
+               dev->core->pll_addr = 0x61;
+               dev->core->pll_desc = &dvb_pll_unknown_1;
                dev->dvb.frontend = mt352_attach(&dntv_live_dvbt_config,
                                                 &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dvb_pll_attach(dev->dvb.frontend, 0x61,
-                                      NULL,
-                                      &dvb_pll_unknown_1);
-               }
                break;
        case CX88_BOARD_DNTV_LIVE_DVB_T_PRO:
 #ifdef HAVE_VP3054_I2C
@@ -644,13 +582,18 @@ static int dvb_register(struct cx8802_dev *dev)
                dev->core->pll_desc = &dvb_pll_fmd1216me;
                dev->dvb.frontend = mt352_attach(&dntv_live_dvbt_pro_config,
                        &((struct vp3054_i2c_state *)dev->card_priv)->adap);
-               if (dev->dvb.frontend != NULL) {
-                       dev->dvb.frontend->ops.tuner_ops.set_params = dntv_live_dvbt_pro_tuner_set_params;
-               }
 #else
                printk("%s: built without vp3054 support\n", dev->core->name);
 #endif
                break;
+       case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL:
+               /* The tin box says DEE1601, but it seems to be DTT7579
+                * compatible, with a slightly different MT352 AGC gain. */
+               dev->core->pll_addr = 0x61;
+               dev->core->pll_desc = &dvb_pll_thomson_dtt7579;
+               dev->dvb.frontend = mt352_attach(&dvico_fusionhdtv_dual,
+                                                &dev->core->i2c_adap);
+               break;
 #endif
 #ifdef HAVE_ZL10353
        case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_HYBRID:
@@ -658,20 +601,12 @@ static int dvb_register(struct cx8802_dev *dev)
                dev->core->pll_desc = &dvb_pll_thomson_fe6600;
                dev->dvb.frontend = zl10353_attach(&dvico_fusionhdtv_hybrid,
                                                   &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dev->dvb.frontend->ops.tuner_ops.set_params = dvico_hybrid_tuner_set_params;
-               }
                break;
 #endif
 #ifdef HAVE_OR51132
        case CX88_BOARD_PCHDTV_HD3000:
                dev->dvb.frontend = or51132_attach(&pchdtv_hd3000,
                                                 &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dvb_pll_attach(dev->dvb.frontend, 0x61,
-                                      &dev->core->i2c_adap,
-                                      &dvb_pll_thomson_dtt761x);
-               }
                break;
 #endif
 #ifdef HAVE_LGDT330X
@@ -692,9 +627,6 @@ static int dvb_register(struct cx8802_dev *dev)
                dev->core->pll_desc = &dvb_pll_microtune_4042;
                dev->dvb.frontend = lgdt330x_attach(&fusionhdtv_3_gold,
                                                    &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dev->dvb.frontend->ops.tuner_ops.set_params = lgdt3302_tuner_set_params;
-               }
                }
                break;
        case CX88_BOARD_DVICO_FUSIONHDTV_3_GOLD_T:
@@ -711,9 +643,6 @@ static int dvb_register(struct cx8802_dev *dev)
                dev->core->pll_desc = &dvb_pll_thomson_dtt761x;
                dev->dvb.frontend = lgdt330x_attach(&fusionhdtv_3_gold,
                                                    &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dev->dvb.frontend->ops.tuner_ops.set_params = lgdt3302_tuner_set_params;
-               }
                }
                break;
        case CX88_BOARD_DVICO_FUSIONHDTV_5_GOLD:
@@ -726,28 +655,10 @@ static int dvb_register(struct cx8802_dev *dev)
                mdelay(100);
                cx_set(MO_GP0_IO, 1);
                mdelay(200);
+               dev->core->pll_addr = 0x61;
+               dev->core->pll_desc = &dvb_pll_tdvs_tua6034;
                dev->dvb.frontend = lgdt330x_attach(&fusionhdtv_5_gold,
                                                    &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dev->dvb.frontend->ops.tuner_ops.set_params = lgdt3303_tuner_set_params;
-               }
-               }
-               break;
-       case CX88_BOARD_PCHDTV_HD5500:
-               dev->ts_gen_cntrl = 0x08;
-               {
-               /* Do a hardware reset of chip before using it. */
-               struct cx88_core *core = dev->core;
-
-               cx_clear(MO_GP0_IO, 1);
-               mdelay(100);
-               cx_set(MO_GP0_IO, 1);
-               mdelay(200);
-               dev->dvb.frontend = lgdt330x_attach(&pchdtv_hd5500,
-                                                   &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dev->dvb.frontend->ops.tuner_ops.set_params = lgdt3303_tuner_set_params;
-               }
                }
                break;
 #endif
@@ -755,11 +666,6 @@ static int dvb_register(struct cx8802_dev *dev)
        case CX88_BOARD_ATI_HDTVWONDER:
                dev->dvb.frontend = nxt200x_attach(&ati_hdtvwonder,
                                                 &dev->core->i2c_adap);
-               if (dev->dvb.frontend != NULL) {
-                       dvb_pll_attach(dev->dvb.frontend, 0x61,
-                                      NULL,
-                                      &dvb_pll_tuv1236d);
-               }
                break;
 #endif
 #ifdef HAVE_CX24123
@@ -767,26 +673,10 @@ static int dvb_register(struct cx8802_dev *dev)
        case CX88_BOARD_HAUPPAUGE_NOVASE2_S1:
                dev->dvb.frontend = cx24123_attach(&hauppauge_novas_config,
                        &dev->core->i2c_adap);
-               if (dev->dvb.frontend) {
-                       isl6421_attach(dev->dvb.frontend, &dev->core->i2c_adap,
-                                      0x08, 0x00, 0x00);
-               }
                break;
        case CX88_BOARD_KWORLD_DVBS_100:
                dev->dvb.frontend = cx24123_attach(&kworld_dvbs_100_config,
                        &dev->core->i2c_adap);
-               if (dev->dvb.frontend) {
-                       dev->core->prev_set_voltage = dev->dvb.frontend->ops.set_voltage;
-                       dev->dvb.frontend->ops.set_voltage = kworld_dvbs_100_set_voltage;
-               }
-               break;
-       case CX88_BOARD_GENIATECH_DVBS:
-               dev->dvb.frontend = cx24123_attach(&geniatech_dvbs_config,
-                                                  &dev->core->i2c_adap);
-               if (dev->dvb.frontend) {
-                       dev->core->prev_set_voltage = dev->dvb.frontend->ops.set_voltage;
-                       dev->dvb.frontend->ops.set_voltage = geniatech_dvbs_set_voltage;
-               }
                break;
 #endif
        default:
@@ -800,15 +690,15 @@ static int dvb_register(struct cx8802_dev *dev)
        }
 
        if (dev->core->pll_desc) {
-               dev->dvb.frontend->ops.info.frequency_min = dev->core->pll_desc->min;
-               dev->dvb.frontend->ops.info.frequency_max = dev->core->pll_desc->max;
+               dev->dvb.frontend->ops->info.frequency_min = dev->core->pll_desc->min;
+               dev->dvb.frontend->ops->info.frequency_max = dev->core->pll_desc->max;
        }
 
        /* Put the analog decoder in standby to keep it quiet */
        cx88_call_i2c_clients (dev->core, TUNER_SET_STANDBY, NULL);
 
        /* register everything */
-       return videobuf_dvb_register(&dev->dvb, THIS_MODULE, dev, &dev->pci->dev);
+       return videobuf_dvb_register(&dev->dvb, THIS_MODULE, dev);
 }
 
 /* ----------------------------------------------------------- */