fedora core 6 1.2949 + vserver 2.2.0
[linux-2.6.git] / drivers / media / video / cx88 / cx88-video.c
index b1e5ddc..8613378 100644 (file)
@@ -1,8 +1,9 @@
 /*
+ *
  * device driver for Conexant 2388x based TV cards
  * video4linux video interface
  *
- * (c) 2003 Gerd Knorr <kraxel@bytesex.org> [SuSE Labs]
+ * (c) 2003-04 Gerd Knorr <kraxel@bytesex.org> [SuSE Labs]
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
  *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
-#define __NO_VERSION__ 1
-
 #include <linux/init.h>
 #include <linux/list.h>
 #include <linux/module.h>
+#include <linux/moduleparam.h>
 #include <linux/kmod.h>
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/interrupt.h>
+#include <linux/delay.h>
+#include <linux/kthread.h>
 #include <asm/div64.h>
 
 #include "cx88.h"
+#include <media/v4l2-common.h>
+
+#ifdef CONFIG_VIDEO_V4L1_COMPAT
+/* Include V4L1 specific functions. Should be removed soon */
+#include <linux/videodev.h>
+#endif
 
 MODULE_DESCRIPTION("v4l2 driver module for cx2388x based TV cards");
 MODULE_AUTHOR("Gerd Knorr <kraxel@bytesex.org> [SuSE Labs]");
@@ -39,108 +47,40 @@ MODULE_LICENSE("GPL");
 /* ------------------------------------------------------------------ */
 
 static unsigned int video_nr[] = {[0 ... (CX88_MAXBOARDS - 1)] = UNSET };
-MODULE_PARM(video_nr,"1-" __stringify(CX88_MAXBOARDS) "i");
-MODULE_PARM_DESC(video_nr,"video device numbers");
+static unsigned int vbi_nr[]   = {[0 ... (CX88_MAXBOARDS - 1)] = UNSET };
+static unsigned int radio_nr[] = {[0 ... (CX88_MAXBOARDS - 1)] = UNSET };
 
-static unsigned int vbi_nr[] = {[0 ... (CX88_MAXBOARDS - 1)] = UNSET };
-MODULE_PARM(vbi_nr,"1-" __stringify(CX88_MAXBOARDS) "i");
-MODULE_PARM_DESC(vbi_nr,"vbi device numbers");
+module_param_array(video_nr, int, NULL, 0444);
+module_param_array(vbi_nr,   int, NULL, 0444);
+module_param_array(radio_nr, int, NULL, 0444);
 
-static unsigned int radio_nr[] = {[0 ... (CX88_MAXBOARDS - 1)] = UNSET };
-MODULE_PARM(radio_nr,"1-" __stringify(CX88_MAXBOARDS) "i");
+MODULE_PARM_DESC(video_nr,"video device numbers");
+MODULE_PARM_DESC(vbi_nr,"vbi device numbers");
 MODULE_PARM_DESC(radio_nr,"radio device numbers");
 
-static unsigned int latency = UNSET;
-MODULE_PARM(latency,"i");
-MODULE_PARM_DESC(latency,"pci latency timer");
-
 static unsigned int video_debug = 0;
-MODULE_PARM(video_debug,"i");
+module_param(video_debug,int,0644);
 MODULE_PARM_DESC(video_debug,"enable debug messages [video]");
 
 static unsigned int irq_debug = 0;
-MODULE_PARM(irq_debug,"i");
+module_param(irq_debug,int,0644);
 MODULE_PARM_DESC(irq_debug,"enable debug messages [IRQ handler]");
 
 static unsigned int vid_limit = 16;
-MODULE_PARM(vid_limit,"i");
+module_param(vid_limit,int,0644);
 MODULE_PARM_DESC(vid_limit,"capture memory limit in megabytes");
 
-static unsigned int tuner[] = {[0 ... (CX88_MAXBOARDS - 1)] = UNSET };
-MODULE_PARM(tuner,"1-" __stringify(CX88_MAXBOARDS) "i");
-MODULE_PARM_DESC(tuner,"tuner type");
-
-static unsigned int card[] = {[0 ... (CX88_MAXBOARDS - 1)] = UNSET };
-MODULE_PARM(card,"1-" __stringify(CX88_MAXBOARDS) "i");
-MODULE_PARM_DESC(card,"card type");
-
-static unsigned int nicam = 0;
-MODULE_PARM(nicam,"i");
-MODULE_PARM_DESC(nicam,"tv audio is nicam");
-
 #define dprintk(level,fmt, arg...)     if (video_debug >= level) \
-       printk(KERN_DEBUG "%s: " fmt, dev->name , ## arg)
+       printk(KERN_DEBUG "%s/0: " fmt, core->name , ## arg)
 
 /* ------------------------------------------------------------------ */
 
-static struct list_head  cx8800_devlist;
-static unsigned int      cx8800_devcount;
+static LIST_HEAD(cx8800_devlist);
 
 /* ------------------------------------------------------------------- */
 /* static data                                                         */
 
-static unsigned int inline norm_swidth(struct cx8800_tvnorm *norm)
-{
-       return (norm->id & V4L2_STD_625_50) ? 922 : 754;
-}
-
-static unsigned int inline norm_hdelay(struct cx8800_tvnorm *norm)
-{
-       return (norm->id & V4L2_STD_625_50) ? 186 : 135;
-}
-
-static unsigned int inline norm_vdelay(struct cx8800_tvnorm *norm)
-{
-       return (norm->id & V4L2_STD_625_50) ? 0x24 : 0x18;
-}
-
-static unsigned int inline norm_maxw(struct cx8800_tvnorm *norm)
-{
-       return (norm->id & V4L2_STD_625_50) ? 768 : 640;
-//     return (norm->id & V4L2_STD_625_50) ? 720 : 640;
-}
-
-static unsigned int inline norm_maxh(struct cx8800_tvnorm *norm)
-{
-       return (norm->id & V4L2_STD_625_50) ? 576 : 480;
-}
-
-static unsigned int inline norm_fsc8(struct cx8800_tvnorm *norm)
-{
-       static const unsigned int ntsc = 28636360;
-       static const unsigned int pal  = 35468950;
-       
-       return (norm->id & V4L2_STD_625_50) ? pal : ntsc;
-}
-
-static unsigned int inline norm_notchfilter(struct cx8800_tvnorm *norm)
-{
-       return (norm->id & V4L2_STD_625_50)
-               ? HLNotchFilter135PAL
-               : HLNotchFilter135NTSC;
-}
-
-static unsigned int inline norm_htotal(struct cx8800_tvnorm *norm)
-{
-       return (norm->id & V4L2_STD_625_50) ? 1135 : 910;
-}
-
-static unsigned int inline norm_vbipack(struct cx8800_tvnorm *norm)
-{
-       return (norm->id & V4L2_STD_625_50) ? 511 : 288;
-}
-
-static struct cx8800_tvnorm tvnorms[] = {
+static struct cx88_tvnorm tvnorms[] = {
        {
                .name      = "NTSC-M",
                .id        = V4L2_STD_NTSC_M,
@@ -151,13 +91,6 @@ static struct cx8800_tvnorm tvnorms[] = {
                .id        = V4L2_STD_NTSC_M_JP,
                .cxiformat = VideoFormatNTSCJapan,
                .cxoformat = 0x181f0008,
-#if 0
-       },{
-               .name      = "NTSC-4.43",
-               .id        = FIXME,
-               .cxiformat = VideoFormatNTSC443,
-               .cxoformat = 0x181f0008,
-#endif
        },{
                .name      = "PAL-BG",
                .id        = V4L2_STD_PAL_BG,
@@ -173,7 +106,7 @@ static struct cx8800_tvnorm tvnorms[] = {
                .id        = V4L2_STD_PAL_I,
                .cxiformat = VideoFormatPAL,
                .cxoformat = 0x181f0008,
-        },{
+       },{
                .name      = "PAL-M",
                .id        = V4L2_STD_PAL_M,
                .cxiformat = VideoFormatPALM,
@@ -194,8 +127,13 @@ static struct cx8800_tvnorm tvnorms[] = {
                .cxiformat = VideoFormatPAL60,
                .cxoformat = 0x181f0008,
        },{
-               .name      = "SECAM",
-               .id        = V4L2_STD_SECAM,
+               .name      = "SECAM-L",
+               .id        = V4L2_STD_SECAM_L,
+               .cxiformat = VideoFormatSECAM,
+               .cxoformat = 0x181f0008,
+       },{
+               .name      = "SECAM-DK",
+               .id        = V4L2_STD_SECAM_DK,
                .cxiformat = VideoFormatSECAM,
                .cxoformat = 0x181f0008,
        }
@@ -268,7 +206,7 @@ static struct cx8800_fmt formats[] = {
 static struct cx8800_fmt* format_by_fourcc(unsigned int fourcc)
 {
        unsigned int i;
-       
+
        for (i = 0; i < ARRAY_SIZE(formats); i++)
                if (formats[i].fourcc == fourcc)
                        return formats+i;
@@ -291,7 +229,7 @@ static struct cx88_ctrl cx8800_ctls[] = {
                        .minimum       = 0x00,
                        .maximum       = 0xff,
                        .step          = 1,
-                       .default_value = 0,
+                       .default_value = 0x7f,
                        .type          = V4L2_CTRL_TYPE_INTEGER,
                },
                .off                   = 128,
@@ -305,9 +243,10 @@ static struct cx88_ctrl cx8800_ctls[] = {
                        .minimum       = 0,
                        .maximum       = 0xff,
                        .step          = 1,
-                       .default_value = 0,
+                       .default_value = 0x3f,
                        .type          = V4L2_CTRL_TYPE_INTEGER,
                },
+               .off                   = 0,
                .reg                   = MO_CONTR_BRIGHT,
                .mask                  = 0xff00,
                .shift                 = 8,
@@ -318,10 +257,10 @@ static struct cx88_ctrl cx8800_ctls[] = {
                        .minimum       = 0,
                        .maximum       = 0xff,
                        .step          = 1,
-                       .default_value = 0,
+                       .default_value = 0x7f,
                        .type          = V4L2_CTRL_TYPE_INTEGER,
                },
-               .off                   = 0,
+               .off                   = 128,
                .reg                   = MO_HUE,
                .mask                  = 0x00ff,
                .shift                 = 0,
@@ -335,7 +274,7 @@ static struct cx88_ctrl cx8800_ctls[] = {
                        .minimum       = 0,
                        .maximum       = 0xff,
                        .step          = 1,
-                       .default_value = 0,
+                       .default_value = 0x7f,
                        .type          = V4L2_CTRL_TYPE_INTEGER,
                },
                .off                   = 0,
@@ -349,6 +288,7 @@ static struct cx88_ctrl cx8800_ctls[] = {
                        .name          = "Mute",
                        .minimum       = 0,
                        .maximum       = 1,
+                       .default_value = 1,
                        .type          = V4L2_CTRL_TYPE_BOOLEAN,
                },
                .reg                   = AUD_VOL_CTL,
@@ -362,7 +302,7 @@ static struct cx88_ctrl cx8800_ctls[] = {
                        .minimum       = 0,
                        .maximum       = 0x3f,
                        .step          = 1,
-                       .default_value = 0,
+                       .default_value = 0x3f,
                        .type          = V4L2_CTRL_TYPE_INTEGER,
                },
                .reg                   = AUD_VOL_CTL,
@@ -385,29 +325,75 @@ static struct cx88_ctrl cx8800_ctls[] = {
                .shift                 = 0,
        }
 };
-const int CX8800_CTLS = ARRAY_SIZE(cx8800_ctls);
+static const int CX8800_CTLS = ARRAY_SIZE(cx8800_ctls);
+
+const u32 cx88_user_ctrls[] = {
+       V4L2_CID_USER_CLASS,
+       V4L2_CID_BRIGHTNESS,
+       V4L2_CID_CONTRAST,
+       V4L2_CID_SATURATION,
+       V4L2_CID_HUE,
+       V4L2_CID_AUDIO_VOLUME,
+       V4L2_CID_AUDIO_BALANCE,
+       V4L2_CID_AUDIO_MUTE,
+       0
+};
+EXPORT_SYMBOL(cx88_user_ctrls);
+
+static const u32 *ctrl_classes[] = {
+       cx88_user_ctrls,
+       NULL
+};
+
+int cx8800_ctrl_query(struct v4l2_queryctrl *qctrl)
+{
+       int i;
+
+       if (qctrl->id < V4L2_CID_BASE ||
+           qctrl->id >= V4L2_CID_LASTP1)
+               return -EINVAL;
+       for (i = 0; i < CX8800_CTLS; i++)
+               if (cx8800_ctls[i].v.id == qctrl->id)
+                       break;
+       if (i == CX8800_CTLS) {
+               *qctrl = no_ctl;
+               return 0;
+       }
+       *qctrl = cx8800_ctls[i].v;
+       return 0;
+}
+EXPORT_SYMBOL(cx8800_ctrl_query);
+
+static int cx88_queryctrl(struct v4l2_queryctrl *qctrl)
+{
+       qctrl->id = v4l2_ctrl_next(ctrl_classes, qctrl->id);
+       if (qctrl->id == 0)
+               return -EINVAL;
+       return cx8800_ctrl_query(qctrl);
+}
 
 /* ------------------------------------------------------------------- */
 /* resource management                                                 */
 
 static int res_get(struct cx8800_dev *dev, struct cx8800_fh *fh, unsigned int bit)
 {
+       struct cx88_core *core = dev->core;
        if (fh->resources & bit)
                /* have it already allocated */
                return 1;
 
        /* is it free? */
-       down(&dev->lock);
+       mutex_lock(&core->lock);
        if (dev->resources & bit) {
                /* no, someone else uses it */
-               up(&dev->lock);
+               mutex_unlock(&core->lock);
                return 0;
        }
        /* it's free, grab it */
        fh->resources  |= bit;
        dev->resources |= bit;
        dprintk(1,"res: get %d\n",bit);
-       up(&dev->lock);
+       mutex_unlock(&core->lock);
        return 1;
 }
 
@@ -426,261 +412,56 @@ int res_locked(struct cx8800_dev *dev, unsigned int bit)
 static
 void res_free(struct cx8800_dev *dev, struct cx8800_fh *fh, unsigned int bits)
 {
-       if ((fh->resources & bits) != bits)
-               BUG();
+       struct cx88_core *core = dev->core;
+       BUG_ON((fh->resources & bits) != bits);
 
-       down(&dev->lock);
+       mutex_lock(&core->lock);
        fh->resources  &= ~bits;
        dev->resources &= ~bits;
        dprintk(1,"res: put %d\n",bits);
-       up(&dev->lock);
+       mutex_unlock(&core->lock);
 }
 
 /* ------------------------------------------------------------------ */
 
-static const u32 xtal = 28636363;
-
-static int set_pll(struct cx8800_dev *dev, int prescale, u32 ofreq)
-{
-       static u32 pre[] = { 0, 0, 0, 3, 2, 1 };
-       u64 pll;
-       u32 reg;
-       int i;
-
-       if (prescale < 2)
-               prescale = 2;
-       if (prescale > 5)
-               prescale = 5;
-
-       pll = ofreq * 8 * prescale * (u64)(1 << 20);
-       do_div(pll,xtal);
-       reg = (pll & 0x3ffffff) | (pre[prescale] << 26);
-       if (((reg >> 20) & 0x3f) < 14) {
-               printk("%s: pll out of range\n",dev->name);
-               return -1;
-       }
-               
-       dprintk(1,"set_pll:    MO_PLL_REG       0x%08x [old=0x%08x,freq=%d]\n",
-               reg, cx_read(MO_PLL_REG), ofreq);
-       cx_write(MO_PLL_REG, reg);
-       for (i = 0; i < 10; i++) {
-               reg = cx_read(MO_DEVICE_STATUS);
-               if (reg & (1<<2)) {
-                       dprintk(1,"pll locked [pre=%d,ofreq=%d]\n",
-                               prescale,ofreq);
-                       return 0;
-               }
-               dprintk(1,"pll not locked yet, waiting ...\n");
-               set_current_state(TASK_INTERRUPTIBLE);
-               schedule_timeout(HZ/10);
-       }
-       dprintk(1,"pll NOT locked [pre=%d,ofreq=%d]\n",prescale,ofreq);
-       return -1;
-}
-
-static int set_tvaudio(struct cx8800_dev *dev)
-{
-       if (CX88_VMUX_TELEVISION != INPUT(dev->input)->type)
-               return 0;
-
-       switch (dev->tvnorm->id) {
-       case V4L2_STD_PAL_BG:
-               dev->tvaudio = nicam ? WW_NICAM_BGDKL : WW_A2_BG;
-               break;
-       case V4L2_STD_PAL_DK:
-               dev->tvaudio = nicam ? WW_NICAM_BGDKL : WW_A2_DK;
-               break;
-       case V4L2_STD_PAL_I:
-               dev->tvaudio = WW_NICAM_I;
-               break;
-       case V4L2_STD_SECAM:
-               dev->tvaudio = WW_SYSTEM_L_AM;  /* FIXME: fr != ru */
-               break;
-       case V4L2_STD_NTSC_M:
-               dev->tvaudio = WW_BTSC;
-               break;
-       case V4L2_STD_NTSC_M_JP:
-               dev->tvaudio = WW_EIAJ;
-               break;
-       default:
-               dprintk(1,"tvaudio support needs work for this tv norm [%s], sorry\n",
-                       dev->tvnorm->name);
-               dev->tvaudio = 0;
-               return 0;
-       }
-
-       cx_andor(MO_AFECFG_IO, 0x1f, 0x0);
-       cx88_set_tvaudio(dev);
-       cx88_set_stereo(dev,V4L2_TUNER_MODE_STEREO);
-
-       cx_write(MO_AUDD_LNGTH, 128/8);  /* fifo size */
-       cx_write(MO_AUDR_LNGTH, 128/8);  /* fifo size */
-       cx_write(MO_AUD_DMACNTRL, 0x03); /* need audio fifo */
-       return 0;
-}
-
-static int set_tvnorm(struct cx8800_dev *dev, struct cx8800_tvnorm *norm)
-{
-       u32 fsc8;
-       u32 adc_clock;
-       u32 vdec_clock;
-       u64 tmp64;
-       u32 bdelay,agcdelay,htotal;
-       struct video_channel c;
-       
-       dev->tvnorm = norm;
-       fsc8       = norm_fsc8(norm);
-       adc_clock  = xtal;
-       vdec_clock = fsc8;
-
-       dprintk(1,"set_tvnorm: \"%s\" fsc8=%d adc=%d vdec=%d\n",
-               norm->name, fsc8, adc_clock, vdec_clock);
-       set_pll(dev,2,vdec_clock);
-       
-       dprintk(1,"set_tvnorm: MO_INPUT_FORMAT  0x%08x [old=0x%08x]\n",
-               norm->cxiformat, cx_read(MO_INPUT_FORMAT) & 0x0f);
-       cx_andor(MO_INPUT_FORMAT, 0xf, norm->cxiformat);
-
-#if 1
-       // FIXME: as-is from DScaler
-       dprintk(1,"set_tvnorm: MO_OUTPUT_FORMAT 0x%08x [old=0x%08x]\n",
-               norm->cxoformat, cx_read(MO_OUTPUT_FORMAT));
-       cx_write(MO_OUTPUT_FORMAT, norm->cxoformat);
-#endif
-
-       // MO_SCONV_REG = adc clock / video dec clock * 2^17
-       tmp64  = adc_clock * (u64)(1 << 17);
-       do_div(tmp64, vdec_clock);
-       dprintk(1,"set_tvnorm: MO_SCONV_REG     0x%08x [old=0x%08x]\n",
-               (u32)tmp64, cx_read(MO_SCONV_REG));
-       cx_write(MO_SCONV_REG, (u32)tmp64);
-
-       // MO_SUB_STEP = 8 * fsc / video dec clock * 2^22
-       tmp64  = fsc8 * (u64)(1 << 22);
-       do_div(tmp64, vdec_clock);
-       dprintk(1,"set_tvnorm: MO_SUB_STEP      0x%08x [old=0x%08x]\n",
-               (u32)tmp64, cx_read(MO_SUB_STEP));
-       cx_write(MO_SUB_STEP, (u32)tmp64);
-
-       // MO_SUB_STEP_DR = 8 * 4406250 / video dec clock * 2^22
-       tmp64  = 4406250 * 8 * (u64)(1 << 22);
-       do_div(tmp64, vdec_clock);
-       dprintk(1,"set_tvnorm: MO_SUB_STEP_DR   0x%08x [old=0x%08x]\n",
-               (u32)tmp64, cx_read(MO_SUB_STEP_DR));
-       cx_write(MO_SUB_STEP_DR, (u32)tmp64);
-
-       // bdelay + agcdelay
-       bdelay   = vdec_clock * 65 / 20000000 + 21;
-       agcdelay = vdec_clock * 68 / 20000000 + 15;
-       dprintk(1,"set_tvnorm: MO_AGC_BURST     0x%08x [old=0x%08x,bdelay=%d,agcdelay=%d]\n",
-               (bdelay << 8) | agcdelay, cx_read(MO_AGC_BURST), bdelay, agcdelay);
-       cx_write(MO_AGC_BURST, (bdelay << 8) | agcdelay);
-
-       // htotal
-       tmp64 = norm_htotal(norm) * (u64)vdec_clock;
-       do_div(tmp64, fsc8);
-       htotal = (u32)tmp64 | (norm_notchfilter(norm) << 11);
-       dprintk(1,"set_tvnorm: MO_HTOTAL        0x%08x [old=0x%08x,htotal=%d]\n",
-               htotal, cx_read(MO_HTOTAL), (u32)tmp64);
-       cx_write(MO_HTOTAL, htotal);
-
-       // vbi stuff
-       cx_write(MO_VBI_PACKET, ((1 << 11) | /* (norm_vdelay(norm)   << 11) | */
-                                norm_vbipack(norm)));
-       
-       // audio
-       set_tvaudio(dev);
-
-       // tell i2c chips
-       memset(&c,0,sizeof(c));
-       c.channel = dev->input;
-       c.norm = VIDEO_MODE_PAL;
-       if ((norm->id & (V4L2_STD_NTSC_M|V4L2_STD_NTSC_M_JP)))
-               c.norm = VIDEO_MODE_NTSC;
-       if (norm->id & V4L2_STD_SECAM)
-               c.norm = VIDEO_MODE_SECAM;
-       cx8800_call_i2c_clients(dev,VIDIOCSCHAN,&c);
-
-       // done
-       return 0;
-}
-
-static int set_scale(struct cx8800_dev *dev, unsigned int width, unsigned int height,
-                    int interlaced)
+/* static int video_mux(struct cx8800_dev *dev, unsigned int input) */
+static int video_mux(struct cx88_core *core, unsigned int input)
 {
-       unsigned int swidth  = norm_swidth(dev->tvnorm);
-       unsigned int sheight = norm_maxh(dev->tvnorm);
-       u32 value;
-
-       dprintk(1,"set_scale: %dx%d [%s]\n", width, height, dev->tvnorm->name);
-
-       // recalc H delay and scale registers
-       value = (width * norm_hdelay(dev->tvnorm)) / swidth;
-       cx_write(MO_HDELAY_EVEN,  value);
-       cx_write(MO_HDELAY_ODD,   value);
-       dprintk(1,"set_scale: hdelay  0x%04x\n", value);
-       
-       value = (swidth * 4096 / width) - 4096;
-       cx_write(MO_HSCALE_EVEN,  value);
-       cx_write(MO_HSCALE_ODD,   value);
-       dprintk(1,"set_scale: hscale  0x%04x\n", value);
-
-       cx_write(MO_HACTIVE_EVEN, width);
-       cx_write(MO_HACTIVE_ODD,  width);
-       dprintk(1,"set_scale: hactive 0x%04x\n", width);
-       
-       // recalc V scale Register (delay is constant)
-       cx_write(MO_VDELAY_EVEN, norm_vdelay(dev->tvnorm));
-       cx_write(MO_VDELAY_ODD,  norm_vdelay(dev->tvnorm));
-       dprintk(1,"set_scale: vdelay  0x%04x\n", norm_vdelay(dev->tvnorm));
-       
-       value = (0x10000 - (sheight * 512 / height - 512)) & 0x1fff;
-       cx_write(MO_VSCALE_EVEN,  value);
-       cx_write(MO_VSCALE_ODD,   value);
-       dprintk(1,"set_scale: vscale  0x%04x\n", value);
-
-       cx_write(MO_VACTIVE_EVEN, sheight);
-       cx_write(MO_VACTIVE_ODD,  sheight);
-       dprintk(1,"set_scale: vactive 0x%04x\n", sheight);
-
-       // setup filters
-       value = 0;
-       value |= (1 << 19);        // CFILT (default)
-       if (interlaced)
-               value |= (1 << 3); // VINT (interlaced vertical scaling)
-       if (width < 385)
-               value |= (1 << 0); // 3-tap interpolation
-       if (width < 193)
-               value |= (1 << 1); // 5-tap interpolation
-
-       cx_write(MO_FILTER_EVEN,  value);
-       cx_write(MO_FILTER_ODD,   value);
-       dprintk(1,"set_scale: filter  0x%04x\n", value);
-       
-       return 0;
-}
+       /* struct cx88_core *core = dev->core; */
 
-static int video_mux(struct cx8800_dev *dev, unsigned int input)
-{
        dprintk(1,"video_mux: %d [vmux=%d,gpio=0x%x,0x%x,0x%x,0x%x]\n",
                input, INPUT(input)->vmux,
                INPUT(input)->gpio0,INPUT(input)->gpio1,
                INPUT(input)->gpio2,INPUT(input)->gpio3);
-       dev->input = input;
+       core->input = input;
        cx_andor(MO_INPUT_FORMAT, 0x03 << 14, INPUT(input)->vmux << 14);
+       cx_write(MO_GP3_IO, INPUT(input)->gpio3);
        cx_write(MO_GP0_IO, INPUT(input)->gpio0);
        cx_write(MO_GP1_IO, INPUT(input)->gpio1);
        cx_write(MO_GP2_IO, INPUT(input)->gpio2);
-       cx_write(MO_GP3_IO, INPUT(input)->gpio3);
 
        switch (INPUT(input)->type) {
        case CX88_VMUX_SVIDEO:
-               cx_andor(MO_AFECFG_IO, 0x01, 0x01);
+               cx_set(MO_AFECFG_IO,    0x00000001);
+               cx_set(MO_INPUT_FORMAT, 0x00010010);
+               cx_set(MO_FILTER_EVEN,  0x00002020);
+               cx_set(MO_FILTER_ODD,   0x00002020);
                break;
        default:
-               cx_andor(MO_AFECFG_IO, 0x01, 0x00);
+               cx_clear(MO_AFECFG_IO,    0x00000001);
+               cx_clear(MO_INPUT_FORMAT, 0x00010010);
+               cx_clear(MO_FILTER_EVEN,  0x00002020);
+               cx_clear(MO_FILTER_ODD,   0x00002020);
                break;
        }
+
+       if (cx88_boards[core->board].mpeg & CX88_MPEG_BLACKBIRD) {
+               /* sets sound input from external adc */
+               if (INPUT(input)->extadc)
+                       cx_set(AUD_CTL, EN_I2SIN_ENABLE);
+               else
+                       cx_clear(AUD_CTL, EN_I2SIN_ENABLE);
+       }
        return 0;
 }
 
@@ -690,38 +471,67 @@ static int start_video_dma(struct cx8800_dev    *dev,
                           struct cx88_dmaqueue *q,
                           struct cx88_buffer   *buf)
 {
+       struct cx88_core *core = dev->core;
+
        /* setup fifo + format */
-       cx88_sram_channel_setup(dev, &cx88_sram_channels[SRAM_CH21],
+       cx88_sram_channel_setup(core, &cx88_sram_channels[SRAM_CH21],
                                buf->bpl, buf->risc.dma);
-       set_scale(dev, buf->vb.width, buf->vb.height, 1);
+       cx88_set_scale(core, buf->vb.width, buf->vb.height, buf->vb.field);
        cx_write(MO_COLOR_CTRL, buf->fmt->cxformat | ColorFormatGamma);
 
        /* reset counter */
-       cx_write(MO_VIDY_GPCNTRL,0x3);
+       cx_write(MO_VIDY_GPCNTRL,GP_COUNT_CONTROL_RESET);
        q->count = 1;
 
        /* enable irqs */
-       cx_set(MO_PCI_INTMSK, 0x00fc01);
+       cx_set(MO_PCI_INTMSK, core->pci_irqmask | 0x01);
+
+       /* Enables corresponding bits at PCI_INT_STAT:
+               bits 0 to 4: video, audio, transport stream, VIP, Host
+               bit 7: timer
+               bits 8 and 9: DMA complete for: SRC, DST
+               bits 10 and 11: BERR signal asserted for RISC: RD, WR
+               bits 12 to 15: BERR signal asserted for: BRDG, SRC, DST, IPB
+        */
        cx_set(MO_VID_INTMSK, 0x0f0011);
-       
+
        /* enable capture */
        cx_set(VID_CAPTURE_CONTROL,0x06);
-       
+
        /* start dma */
        cx_set(MO_DEV_CNTRL2, (1<<5));
-       cx_set(MO_VID_DMACNTRL, 0x11);
+       cx_set(MO_VID_DMACNTRL, 0x11); /* Planar Y and packed FIFO and RISC enable */
+
+       return 0;
+}
 
+#ifdef CONFIG_PM
+static int stop_video_dma(struct cx8800_dev    *dev)
+{
+       struct cx88_core *core = dev->core;
+
+       /* stop dma */
+       cx_clear(MO_VID_DMACNTRL, 0x11);
+
+       /* disable capture */
+       cx_clear(VID_CAPTURE_CONTROL,0x06);
+
+       /* disable irqs */
+       cx_clear(MO_PCI_INTMSK, 0x000001);
+       cx_clear(MO_VID_INTMSK, 0x0f0011);
        return 0;
 }
+#endif
 
 static int restart_video_queue(struct cx8800_dev    *dev,
                               struct cx88_dmaqueue *q)
 {
+       struct cx88_core *core = dev->core;
        struct cx88_buffer *buf, *prev;
        struct list_head *item;
-       
+
        if (!list_empty(&q->active)) {
-               buf = list_entry(q->active.next, struct cx88_buffer, vb.queue);
+               buf = list_entry(q->active.next, struct cx88_buffer, vb.queue);
                dprintk(2,"restart_queue [%p/%d]: restart dma\n",
                        buf, buf->vb.i);
                start_video_dma(dev, q, buf);
@@ -737,10 +547,9 @@ static int restart_video_queue(struct cx8800_dev    *dev,
        for (;;) {
                if (list_empty(&q->queued))
                        return 0;
-               buf = list_entry(q->queued.next, struct cx88_buffer, vb.queue);
+               buf = list_entry(q->queued.next, struct cx88_buffer, vb.queue);
                if (NULL == prev) {
-                       list_del(&buf->vb.queue);
-                       list_add_tail(&buf->vb.queue,&q->active);
+                       list_move_tail(&buf->vb.queue, &q->active);
                        start_video_dma(dev, q, buf);
                        buf->vb.state = STATE_ACTIVE;
                        buf->count    = q->count++;
@@ -751,8 +560,7 @@ static int restart_video_queue(struct cx8800_dev    *dev,
                } else if (prev->vb.width  == buf->vb.width  &&
                           prev->vb.height == buf->vb.height &&
                           prev->fmt       == buf->fmt) {
-                       list_del(&buf->vb.queue);
-                       list_add_tail(&buf->vb.queue,&q->active);
+                       list_move_tail(&buf->vb.queue, &q->active);
                        buf->vb.state = STATE_ACTIVE;
                        buf->count    = q->count++;
                        prev->risc.jmp[1] = cpu_to_le32(buf->risc.dma);
@@ -768,10 +576,10 @@ static int restart_video_queue(struct cx8800_dev    *dev,
 /* ------------------------------------------------------------------ */
 
 static int
-buffer_setup(struct file *file, unsigned int *count, unsigned int *size)
+buffer_setup(struct videobuf_queue *q, unsigned int *count, unsigned int *size)
 {
-       struct cx8800_fh *fh = file->private_data;
-       
+       struct cx8800_fh *fh = q->priv_data;
+
        *size = fh->fmt->depth*fh->width*fh->height >> 3;
        if (0 == *count)
                *count = 32;
@@ -781,17 +589,18 @@ buffer_setup(struct file *file, unsigned int *count, unsigned int *size)
 }
 
 static int
-buffer_prepare(struct file *file, struct videobuf_buffer *vb,
+buffer_prepare(struct videobuf_queue *q, struct videobuf_buffer *vb,
               enum v4l2_field field)
 {
-       struct cx8800_fh   *fh  = file->private_data;
+       struct cx8800_fh   *fh  = q->priv_data;
        struct cx8800_dev  *dev = fh->dev;
-       struct cx88_buffer *buf = (struct cx88_buffer*)vb;
+       struct cx88_core *core = dev->core;
+       struct cx88_buffer *buf = container_of(vb,struct cx88_buffer,vb);
        int rc, init_buffer = 0;
 
        BUG_ON(NULL == fh->fmt);
-       if (fh->width  < 48 || fh->width  > norm_maxw(dev->tvnorm) ||
-           fh->height < 32 || fh->height > norm_maxh(dev->tvnorm))
+       if (fh->width  < 48 || fh->width  > norm_maxw(core->tvnorm) ||
+           fh->height < 32 || fh->height > norm_maxh(core->tvnorm))
                return -EINVAL;
        buf->vb.size = (fh->width * fh->height * fh->fmt->depth) >> 3;
        if (0 != buf->vb.baddr  &&  buf->vb.bsize < buf->vb.size)
@@ -810,7 +619,7 @@ buffer_prepare(struct file *file, struct videobuf_buffer *vb,
 
        if (STATE_NEEDS_INIT == buf->vb.state) {
                init_buffer = 1;
-               if (0 != (rc = videobuf_iolock(dev->pci,&buf->vb,NULL)))
+               if (0 != (rc = videobuf_iolock(q,&buf->vb,NULL)))
                        goto fail;
        }
 
@@ -860,21 +669,22 @@ buffer_prepare(struct file *file, struct videobuf_buffer *vb,
        return 0;
 
  fail:
-       cx88_free_buffer(dev->pci,buf);
+       cx88_free_buffer(q,buf);
        return rc;
 }
 
 static void
-buffer_queue(struct file *file, struct videobuf_buffer *vb)
+buffer_queue(struct videobuf_queue *vq, struct videobuf_buffer *vb)
 {
-       struct cx88_buffer    *buf  = (struct cx88_buffer*)vb;
+       struct cx88_buffer    *buf = container_of(vb,struct cx88_buffer,vb);
        struct cx88_buffer    *prev;
-       struct cx8800_fh      *fh   = file->private_data;
+       struct cx8800_fh      *fh   = vq->priv_data;
        struct cx8800_dev     *dev  = fh->dev;
+       struct cx88_core      *core = dev->core;
        struct cx88_dmaqueue  *q    = &dev->vidq;
 
        /* add jump to stopper */
-       buf->risc.jmp[0] = cpu_to_le32(RISC_JUMP | RISC_IRQ1 | 0x10000);
+       buf->risc.jmp[0] = cpu_to_le32(RISC_JUMP | RISC_IRQ1 | RISC_CNT_INC);
        buf->risc.jmp[1] = cpu_to_le32(q->stopper.dma);
 
        if (!list_empty(&q->queued)) {
@@ -913,15 +723,14 @@ buffer_queue(struct file *file, struct videobuf_buffer *vb)
        }
 }
 
-static void buffer_release(struct file *file, struct videobuf_buffer *vb)
+static void buffer_release(struct videobuf_queue *q, struct videobuf_buffer *vb)
 {
-       struct cx88_buffer *buf = (struct cx88_buffer*)vb;
-       struct cx8800_fh   *fh  = file->private_data;
+       struct cx88_buffer *buf = container_of(vb,struct cx88_buffer,vb);
 
-       cx88_free_buffer(fh->dev->pci,buf);
+       cx88_free_buffer(q,buf);
 }
 
-struct videobuf_queue_ops cx8800_video_qops = {
+static struct videobuf_queue_ops cx8800_video_qops = {
        .buf_setup    = buffer_setup,
        .buf_prepare  = buffer_prepare,
        .buf_queue    = buffer_queue,
@@ -930,231 +739,6 @@ struct videobuf_queue_ops cx8800_video_qops = {
 
 /* ------------------------------------------------------------------ */
 
-#if 0 /* overlay support not finished yet */
-static u32* ov_risc_field(struct cx8800_dev *dev, struct cx8800_fh *fh,
-                         u32 *rp, struct btcx_skiplist *skips,
-                         u32 sync_line, int skip_even, int skip_odd)
-{
-       int line,maxy,start,end,skip,nskips;
-       u32 ri,ra;
-       u32 addr;
-
-       /* sync instruction */
-       *(rp++) = cpu_to_le32(RISC_RESYNC | sync_line);
-
-       addr  = (unsigned long)dev->fbuf.base;
-       addr += dev->fbuf.fmt.bytesperline * fh->win.w.top;
-       addr += (fh->fmt->depth >> 3)      * fh->win.w.left;
-
-       /* scan lines */
-       for (maxy = -1, line = 0; line < fh->win.w.height;
-            line++, addr += dev->fbuf.fmt.bytesperline) {
-               if ((line%2) == 0  &&  skip_even)
-                       continue;
-               if ((line%2) == 1  &&  skip_odd)
-                       continue;
-
-               /* calculate clipping */
-               if (line > maxy)
-                       btcx_calc_skips(line, fh->win.w.width, &maxy,
-                                       skips, &nskips, fh->clips, fh->nclips);
-
-               /* write out risc code */
-               for (start = 0, skip = 0; start < fh->win.w.width; start = end) {
-                       if (skip >= nskips) {
-                               ri  = RISC_WRITE;
-                               end = fh->win.w.width;
-                       } else if (start < skips[skip].start) {
-                               ri  = RISC_WRITE;
-                               end = skips[skip].start;
-                       } else {
-                               ri  = RISC_SKIP;
-                               end = skips[skip].end;
-                               skip++;
-                       }
-                       if (RISC_WRITE == ri)
-                               ra = addr + (fh->fmt->depth>>3)*start;
-                       else
-                               ra = 0;
-                               
-                       if (0 == start)
-                               ri |= RISC_SOL;
-                       if (fh->win.w.width == end)
-                               ri |= RISC_EOL;
-                       ri |= (fh->fmt->depth>>3) * (end-start);
-
-                       *(rp++)=cpu_to_le32(ri);
-                       if (0 != ra)
-                               *(rp++)=cpu_to_le32(ra);
-               }
-       }
-       kfree(skips);
-       return rp;
-}
-
-static int ov_risc_frame(struct cx8800_dev *dev, struct cx8800_fh *fh,
-                        struct cx88_buffer *buf)
-{
-       struct btcx_skiplist *skips;
-       u32 instructions,fields;
-       u32 *rp;
-       int rc;
-       
-       /* skip list for window clipping */
-       if (NULL == (skips = kmalloc(sizeof(*skips) * fh->nclips,GFP_KERNEL)))
-               return -ENOMEM;
-       
-       fields = 0;
-       if (V4L2_FIELD_HAS_TOP(fh->win.field))
-               fields++;
-       if (V4L2_FIELD_HAS_BOTTOM(fh->win.field))
-               fields++;
-
-        /* estimate risc mem: worst case is (clip+1) * lines instructions
-           + syncs + jump (all 2 dwords) */
-       instructions  = (fh->nclips+1) * fh->win.w.height;
-       instructions += 3 + 4;
-       if ((rc = btcx_riscmem_alloc(dev->pci,&buf->risc,instructions*8)) < 0) {
-               kfree(skips);
-               return rc;
-       }
-
-       /* write risc instructions */
-       rp = buf->risc.cpu;
-       switch (fh->win.field) {
-       case V4L2_FIELD_TOP:
-               rp = ov_risc_field(dev, fh, rp, skips, 0,     0, 0);
-               break;
-       case V4L2_FIELD_BOTTOM:
-               rp = ov_risc_field(dev, fh, rp, skips, 0x200, 0, 0);
-               break;
-       case V4L2_FIELD_INTERLACED:
-               rp = ov_risc_field(dev, fh, rp, skips, 0,     0, 1);
-               rp = ov_risc_field(dev, fh, rp, skips, 0x200, 1, 0);
-               break;
-       default:
-               BUG();
-       }
-
-       /* save pointer to jmp instruction address */
-       buf->risc.jmp = rp;
-       kfree(skips);
-       return 0;
-}
-
-static int verify_window(struct cx8800_dev *dev, struct v4l2_window *win)
-{
-       enum v4l2_field field;
-       int maxw, maxh;
-
-       if (NULL == dev->fbuf.base)
-               return -EINVAL;
-       if (win->w.width < 48 || win->w.height <  32)
-               return -EINVAL;
-       if (win->clipcount > 2048)
-               return -EINVAL;
-
-       field = win->field;
-       maxw  = norm_maxw(dev->tvnorm);
-       maxh  = norm_maxh(dev->tvnorm);
-
-       if (V4L2_FIELD_ANY == field) {
-                field = (win->w.height > maxh/2)
-                        ? V4L2_FIELD_INTERLACED
-                        : V4L2_FIELD_TOP;
-        }
-        switch (field) {
-        case V4L2_FIELD_TOP:
-        case V4L2_FIELD_BOTTOM:
-                maxh = maxh / 2;
-                break;
-        case V4L2_FIELD_INTERLACED:
-                break;
-        default:
-                return -EINVAL;
-        }
-
-       win->field = field;
-       if (win->w.width > maxw)
-               win->w.width = maxw;
-       if (win->w.height > maxh)
-               win->w.height = maxh;
-       return 0;
-}
-
-static int setup_window(struct cx8800_dev *dev, struct cx8800_fh *fh,
-                       struct v4l2_window *win)
-{
-       struct v4l2_clip *clips = NULL;
-       int n,size,retval = 0;
-
-       if (NULL == fh->fmt)
-               return -EINVAL;
-       retval = verify_window(dev,win);
-       if (0 != retval)
-               return retval;
-
-       /* copy clips  --  luckily v4l1 + v4l2 are binary
-          compatible here ...*/
-       n = win->clipcount;
-       size = sizeof(*clips)*(n+4);
-       clips = kmalloc(size,GFP_KERNEL);
-       if (NULL == clips)
-               return -ENOMEM;
-       if (n > 0) {
-               if (copy_from_user(clips,win->clips,sizeof(struct v4l2_clip)*n)) {
-                       kfree(clips);
-                       return -EFAULT;
-               }
-       }
-
-       /* clip against screen */
-       if (NULL != dev->fbuf.base)
-               n = btcx_screen_clips(dev->fbuf.fmt.width, dev->fbuf.fmt.height,
-                                     &win->w, clips, n);
-       btcx_sort_clips(clips,n);
-
-       /* 4-byte alignments */
-       switch (fh->fmt->depth) {
-       case 8:
-       case 24:
-               btcx_align(&win->w, clips, n, 3);
-               break;
-       case 16:
-               btcx_align(&win->w, clips, n, 1);
-               break;
-       case 32:
-               /* no alignment fixups needed */
-               break;
-       default:
-               BUG();
-       }
-       
-       down(&fh->vidq.lock);
-       if (fh->clips)
-               kfree(fh->clips);
-       fh->clips    = clips;
-       fh->nclips   = n;
-       fh->win      = *win;
-#if 0
-       fh->ov.setup_ok = 1;
-#endif
-       
-       /* update overlay if needed */
-       retval = 0;
-#if 0
-       if (check_btres(fh, RESOURCE_OVERLAY)) {
-               struct bttv_buffer *new;
-               
-               new = videobuf_alloc(sizeof(*new));
-               bttv_overlay_risc(btv, &fh->ov, fh->ovfmt, new);
-               retval = bttv_switch_overlay(btv,fh,new);
-       }
-#endif
-       up(&fh->vidq.lock);
-       return retval;
-}
-#endif
 
 /* ------------------------------------------------------------------ */
 
@@ -1188,11 +772,12 @@ static int video_open(struct inode *inode, struct file *file)
 {
        int minor = iminor(inode);
        struct cx8800_dev *h,*dev = NULL;
+       struct cx88_core *core;
        struct cx8800_fh *fh;
        struct list_head *list;
        enum v4l2_buf_type type = 0;
        int radio = 0;
-       
+
        list_for_each(list,&cx8800_devlist) {
                h = list_entry(list, struct cx8800_dev, devlist);
                if (h->video_dev->minor == minor) {
@@ -1212,14 +797,15 @@ static int video_open(struct inode *inode, struct file *file)
        if (NULL == dev)
                return -ENODEV;
 
+       core = dev->core;
+
        dprintk(1,"open minor=%d radio=%d type=%s\n",
                minor,radio,v4l2_type_names[type]);
 
        /* allocate + initialize per filehandle data */
-       fh = kmalloc(sizeof(*fh),GFP_KERNEL);
+       fh = kzalloc(sizeof(*fh),GFP_KERNEL);
        if (NULL == fh)
                return -ENOMEM;
-       memset(fh,0,sizeof(*fh));
        file->private_data = fh;
        fh->dev      = dev;
        fh->radio    = radio;
@@ -1232,32 +818,33 @@ static int video_open(struct inode *inode, struct file *file)
                            dev->pci, &dev->slock,
                            V4L2_BUF_TYPE_VIDEO_CAPTURE,
                            V4L2_FIELD_INTERLACED,
-                           sizeof(struct cx88_buffer));
+                           sizeof(struct cx88_buffer),
+                           fh);
        videobuf_queue_init(&fh->vbiq, &cx8800_vbi_qops,
                            dev->pci, &dev->slock,
                            V4L2_BUF_TYPE_VBI_CAPTURE,
                            V4L2_FIELD_SEQ_TB,
-                           sizeof(struct cx88_buffer));
-       init_MUTEX(&fh->vidq.lock);
-       init_MUTEX(&fh->vbiq.lock);
+                           sizeof(struct cx88_buffer),
+                           fh);
 
        if (fh->radio) {
+               int board = core->board;
                dprintk(1,"video_open: setting radio device\n");
-               cx_write(MO_GP0_IO, cx88_boards[dev->board].radio.gpio0);
-               cx_write(MO_GP1_IO, cx88_boards[dev->board].radio.gpio1);
-               cx_write(MO_GP2_IO, cx88_boards[dev->board].radio.gpio2);
-               cx_write(MO_GP3_IO, cx88_boards[dev->board].radio.gpio3);
-               dev->tvaudio = WW_FM;
-               cx88_set_tvaudio(dev);
-               cx88_set_stereo(dev,V4L2_TUNER_MODE_STEREO);
-               cx8800_call_i2c_clients(dev,AUDC_SET_RADIO,NULL);
+               cx_write(MO_GP3_IO, cx88_boards[board].radio.gpio3);
+               cx_write(MO_GP0_IO, cx88_boards[board].radio.gpio0);
+               cx_write(MO_GP1_IO, cx88_boards[board].radio.gpio1);
+               cx_write(MO_GP2_IO, cx88_boards[board].radio.gpio2);
+               core->tvaudio = WW_FM;
+               cx88_set_tvaudio(core);
+               cx88_set_stereo(core,V4L2_TUNER_MODE_STEREO,1);
+               cx88_call_i2c_clients(core,AUDC_SET_RADIO,NULL);
        }
 
-        return 0;
+       return 0;
 }
 
 static ssize_t
-video_read(struct file *file, char *data, size_t count, loff_t *ppos)
+video_read(struct file *file, char __user *data, size_t count, loff_t *ppos)
 {
        struct cx8800_fh *fh = file->private_data;
 
@@ -1265,11 +852,13 @@ video_read(struct file *file, char *data, size_t count, loff_t *ppos)
        case V4L2_BUF_TYPE_VIDEO_CAPTURE:
                if (res_locked(fh->dev,RESOURCE_VIDEO))
                        return -EBUSY;
-               return videobuf_read_one(file, &fh->vidq, data, count, ppos);
+               return videobuf_read_one(&fh->vidq, data, count, ppos,
+                                        file->f_flags & O_NONBLOCK);
        case V4L2_BUF_TYPE_VBI_CAPTURE:
                if (!res_get(fh->dev,fh,RESOURCE_VBI))
                        return -EBUSY;
-               return videobuf_read_stream(file, &fh->vbiq, data, count, ppos, 1);
+               return videobuf_read_stream(&fh->vbiq, data, count, ppos, 1,
+                                           file->f_flags & O_NONBLOCK);
        default:
                BUG();
                return 0;
@@ -1280,12 +869,30 @@ static unsigned int
 video_poll(struct file *file, struct poll_table_struct *wait)
 {
        struct cx8800_fh *fh = file->private_data;
+       struct cx88_buffer *buf;
 
-       if (V4L2_BUF_TYPE_VBI_CAPTURE == fh->type)
+       if (V4L2_BUF_TYPE_VBI_CAPTURE == fh->type) {
+               if (!res_get(fh->dev,fh,RESOURCE_VBI))
+                       return POLLERR;
                return videobuf_poll_stream(file, &fh->vbiq, wait);
+       }
 
-       /* FIXME */
-       return POLLERR;
+       if (res_check(fh,RESOURCE_VIDEO)) {
+               /* streaming capture */
+               if (list_empty(&fh->vidq.stream))
+                       return POLLERR;
+               buf = list_entry(fh->vidq.stream.next,struct cx88_buffer,vb.stream);
+       } else {
+               /* read() capture */
+               buf = (struct cx88_buffer*)fh->vidq.read_buf;
+               if (NULL == buf)
+                       return POLLERR;
+       }
+       poll_wait(file, &buf->vb.done, wait);
+       if (buf->vb.state == STATE_DONE ||
+           buf->vb.state == STATE_ERROR)
+               return POLLIN|POLLRDNORM;
+       return 0;
 }
 
 static int video_release(struct inode *inode, struct file *file)
@@ -1301,25 +908,30 @@ static int video_release(struct inode *inode, struct file *file)
 
        /* stop video capture */
        if (res_check(fh, RESOURCE_VIDEO)) {
-               videobuf_queue_cancel(file,&fh->vidq);
+               videobuf_queue_cancel(&fh->vidq);
                res_free(dev,fh,RESOURCE_VIDEO);
        }
        if (fh->vidq.read_buf) {
-               buffer_release(file,fh->vidq.read_buf);
+               buffer_release(&fh->vidq,fh->vidq.read_buf);
                kfree(fh->vidq.read_buf);
        }
 
        /* stop vbi capture */
        if (res_check(fh, RESOURCE_VBI)) {
                if (fh->vbiq.streaming)
-                       videobuf_streamoff(file,&fh->vbiq);
+                       videobuf_streamoff(&fh->vbiq);
                if (fh->vbiq.reading)
-                       videobuf_read_stop(file,&fh->vbiq);
+                       videobuf_read_stop(&fh->vbiq);
                res_free(dev,fh,RESOURCE_VBI);
        }
 
+       videobuf_mmap_free(&fh->vidq);
+       videobuf_mmap_free(&fh->vbiq);
        file->private_data = NULL;
        kfree(fh);
+
+       cx88_call_i2c_clients (dev->core, TUNER_SET_STANDBY, NULL);
+
        return 0;
 }
 
@@ -1328,17 +940,19 @@ video_mmap(struct file *file, struct vm_area_struct * vma)
 {
        struct cx8800_fh *fh = file->private_data;
 
-       return videobuf_mmap_mapper(vma, get_queue(fh));
+       return videobuf_mmap_mapper(get_queue(fh), vma);
 }
 
 /* ------------------------------------------------------------------ */
 
-static int get_control(struct cx8800_dev *dev, struct v4l2_control *ctl)
+/* static int get_control(struct cx8800_dev *dev, struct v4l2_control *ctl) */
+static int get_control(struct cx88_core *core, struct v4l2_control *ctl)
 {
+       /* struct cx88_core *core = dev->core; */
        struct cx88_ctrl *c = NULL;
        u32 value;
        int i;
-       
+
        for (i = 0; i < CX8800_CTLS; i++)
                if (cx8800_ctls[i].v.id == ctl->id)
                        c = &cx8800_ctls[i];
@@ -1348,72 +962,88 @@ static int get_control(struct cx8800_dev *dev, struct v4l2_control *ctl)
        value = c->sreg ? cx_sread(c->sreg) : cx_read(c->reg);
        switch (ctl->id) {
        case V4L2_CID_AUDIO_BALANCE:
-               ctl->value = (value & 0x40) ? (value & 0x3f) : (0x40 - (value & 0x3f));
+               ctl->value = ((value & 0x7f) < 0x40) ? ((value & 0x7f) + 0x40)
+                                       : (0x7f - (value & 0x7f));
+               break;
+       case V4L2_CID_AUDIO_VOLUME:
+               ctl->value = 0x3f - (value & 0x3f);
                break;
        default:
                ctl->value = ((value + (c->off << c->shift)) & c->mask) >> c->shift;
                break;
        }
+       dprintk(1,"get_control id=0x%X(%s) ctrl=0x%02x, reg=0x%02x val=0x%02x (mask 0x%02x)%s\n",
+                               ctl->id, c->v.name, ctl->value, c->reg,
+                               value,c->mask, c->sreg ? " [shadowed]" : "");
        return 0;
 }
 
-static int set_control(struct cx8800_dev *dev, struct v4l2_control *ctl)
+/* static int set_control(struct cx8800_dev *dev, struct v4l2_control *ctl) */
+static int set_control(struct cx88_core *core, struct v4l2_control *ctl)
 {
+       /* struct cx88_core *core = dev->core; */
        struct cx88_ctrl *c = NULL;
-        u32 v_sat_value;
-       u32 value;
+       u32 value,mask;
        int i;
-
-       for (i = 0; i < CX8800_CTLS; i++)
-               if (cx8800_ctls[i].v.id == ctl->id)
+       for (i = 0; i < CX8800_CTLS; i++) {
+               if (cx8800_ctls[i].v.id == ctl->id) {
                        c = &cx8800_ctls[i];
+               }
+       }
        if (NULL == c)
                return -EINVAL;
 
        if (ctl->value < c->v.minimum)
-               return -ERANGE;
+               ctl->value = c->v.minimum;
        if (ctl->value > c->v.maximum)
-               return -ERANGE;
+               ctl->value = c->v.maximum;
+       mask=c->mask;
        switch (ctl->id) {
        case V4L2_CID_AUDIO_BALANCE:
-               value = (ctl->value < 0x40) ? (0x40 - ctl->value) : ctl->value;
+               value = (ctl->value < 0x40) ? (0x7f - ctl->value) : (ctl->value - 0x40);
+               break;
+       case V4L2_CID_AUDIO_VOLUME:
+               value = 0x3f - (ctl->value & 0x3f);
                break;
        case V4L2_CID_SATURATION:
                /* special v_sat handling */
-               v_sat_value = ctl->value - (0x7f - 0x5a);
-               if (v_sat_value > 0xff)
-                       v_sat_value = 0xff;
-               if (v_sat_value < 0x00)
-                       v_sat_value = 0x00;
-               cx_andor(MO_UV_SATURATION, 0xff00, v_sat_value << 8);
-               /* fall through to default route for u_sat */
+
+               value = ((ctl->value - c->off) << c->shift) & c->mask;
+
+               if (core->tvnorm->id & V4L2_STD_SECAM) {
+                       /* For SECAM, both U and V sat should be equal */
+                       value=value<<8|value;
+               } else {
+                       /* Keeps U Saturation proportional to V Sat */
+                       value=(value*0x5a)/0x7f<<8|value;
+               }
+               mask=0xffff;
+               break;
        default:
                value = ((ctl->value - c->off) << c->shift) & c->mask;
                break;
        }
-       dprintk(1,"set_control id=0x%X reg=0x%x val=0x%x%s\n",
-               ctl->id, c->reg, value, c->sreg ? " [shadowed]" : "");
+       dprintk(1,"set_control id=0x%X(%s) ctrl=0x%02x, reg=0x%02x val=0x%02x (mask 0x%02x)%s\n",
+                               ctl->id, c->v.name, ctl->value, c->reg, value,
+                               mask, c->sreg ? " [shadowed]" : "");
        if (c->sreg) {
-               cx_sandor(c->sreg, c->reg, c->mask, value);
+               cx_sandor(c->sreg, c->reg, mask, value);
        } else {
-               cx_andor(c->reg, c->mask, value);
+               cx_andor(c->reg, mask, value);
        }
        return 0;
 }
 
-static void init_controls(struct cx8800_dev *dev)
+static void init_controls(struct cx88_core *core)
 {
-       static struct v4l2_control mute = {
-               .id    = V4L2_CID_AUDIO_MUTE,
-               .value = 1,
-       };
-       static struct v4l2_control volume = {
-               .id    = V4L2_CID_AUDIO_VOLUME,
-               .value = 0,
-       };
+       struct v4l2_control ctrl;
+       int i;
 
-       set_control(dev,&mute);
-       set_control(dev,&volume);
+       for (i = 0; i < CX8800_CTLS; i++) {
+               ctrl.id=cx8800_ctls[i].v.id;
+               ctrl.value=cx8800_ctls[i].v.default_value;
+               set_control(core, &ctrl);
+       }
 }
 
 /* ------------------------------------------------------------------ */
@@ -1444,6 +1074,8 @@ static int cx8800_g_fmt(struct cx8800_dev *dev, struct cx8800_fh *fh,
 static int cx8800_try_fmt(struct cx8800_dev *dev, struct cx8800_fh *fh,
                          struct v4l2_format *f)
 {
+       struct cx88_core *core = dev->core;
+
        switch (f->type) {
        case V4L2_BUF_TYPE_VIDEO_CAPTURE:
        {
@@ -1456,18 +1088,15 @@ static int cx8800_try_fmt(struct cx8800_dev *dev, struct cx8800_fh *fh,
                        return -EINVAL;
 
                field = f->fmt.pix.field;
-               maxw  = norm_maxw(dev->tvnorm);
-               maxh  = norm_maxh(dev->tvnorm);
+               maxw  = norm_maxw(core->tvnorm);
+               maxh  = norm_maxh(core->tvnorm);
 
-#if 0
                if (V4L2_FIELD_ANY == field) {
                        field = (f->fmt.pix.height > maxh/2)
                                ? V4L2_FIELD_INTERLACED
                                : V4L2_FIELD_BOTTOM;
                }
-#else
-               field = V4L2_FIELD_INTERLACED;
-#endif
+
                switch (field) {
                case V4L2_FIELD_TOP:
                case V4L2_FIELD_BOTTOM:
@@ -1480,14 +1109,15 @@ static int cx8800_try_fmt(struct cx8800_dev *dev, struct cx8800_fh *fh,
                }
 
                f->fmt.pix.field = field;
-               if (f->fmt.pix.width < 48)
-                       f->fmt.pix.width = 48;
                if (f->fmt.pix.height < 32)
                        f->fmt.pix.height = 32;
-               if (f->fmt.pix.width > maxw)
-                       f->fmt.pix.width = maxw;
                if (f->fmt.pix.height > maxh)
                        f->fmt.pix.height = maxh;
+               if (f->fmt.pix.width < 48)
+                       f->fmt.pix.width = 48;
+               if (f->fmt.pix.width > maxw)
+                       f->fmt.pix.width = maxw;
+               f->fmt.pix.width &= ~0x03;
                f->fmt.pix.bytesperline =
                        (f->fmt.pix.width * fmt->depth) >> 3;
                f->fmt.pix.sizeimage =
@@ -1507,7 +1137,7 @@ static int cx8800_s_fmt(struct cx8800_dev *dev, struct cx8800_fh *fh,
                        struct v4l2_format *f)
 {
        int err;
-       
+
        switch (f->type) {
        case V4L2_BUF_TYPE_VIDEO_CAPTURE:
                err = cx8800_try_fmt(dev,fh,f);
@@ -1535,23 +1165,23 @@ static int cx8800_s_fmt(struct cx8800_dev *dev, struct cx8800_fh *fh,
 static int video_do_ioctl(struct inode *inode, struct file *file,
                          unsigned int cmd, void *arg)
 {
-       struct cx8800_fh  *fh  = file->private_data;
-       struct cx8800_dev *dev = fh->dev;
-#if 0
-       unsigned long flags;
-#endif
+       struct cx8800_fh  *fh   = file->private_data;
+       struct cx8800_dev *dev  = fh->dev;
+       struct cx88_core  *core = dev->core;
        int err;
 
        if (video_debug > 1)
-               cx88_print_ioctl(dev->name,cmd);
+               v4l_print_ioctl(core->name,cmd);
        switch (cmd) {
+
+       /* --- capabilities ------------------------------------------ */
        case VIDIOC_QUERYCAP:
        {
                struct v4l2_capability *cap = arg;
-               
+
                memset(cap,0,sizeof(*cap));
-                strcpy(cap->driver, "cx8800");
-               strlcpy(cap->card, cx88_boards[dev->board].name,
+               strcpy(cap->driver, "cx8800");
+               strlcpy(cap->card, cx88_boards[core->board].name,
                        sizeof(cap->card));
                sprintf(cap->bus_info,"PCI:%s",pci_name(dev->pci));
                cap->version = CX88_VERSION_CODE;
@@ -1560,37 +1190,154 @@ static int video_do_ioctl(struct inode *inode, struct file *file,
                        V4L2_CAP_READWRITE     |
                        V4L2_CAP_STREAMING     |
                        V4L2_CAP_VBI_CAPTURE   |
-#if 0
-                       V4L2_CAP_VIDEO_OVERLAY |
-#endif
                        0;
-               if (UNSET != dev->tuner_type)
+               if (UNSET != core->tuner_type)
                        cap->capabilities |= V4L2_CAP_TUNER;
-
                return 0;
        }
 
-       /* ---------- tv norms ---------- */
-       case VIDIOC_ENUMSTD:
+       /* --- capture ioctls ---------------------------------------- */
+       case VIDIOC_ENUM_FMT:
        {
-               struct v4l2_standard *e = arg;
-               unsigned int i;
+               struct v4l2_fmtdesc *f = arg;
+               enum v4l2_buf_type type;
+               unsigned int index;
 
-               i = e->index;
-               if (i >= ARRAY_SIZE(tvnorms))
+               index = f->index;
+               type  = f->type;
+               switch (type) {
+               case V4L2_BUF_TYPE_VIDEO_CAPTURE:
+                       if (index >= ARRAY_SIZE(formats))
+                               return -EINVAL;
+                       memset(f,0,sizeof(*f));
+                       f->index = index;
+                       f->type  = type;
+                       strlcpy(f->description,formats[index].name,sizeof(f->description));
+                       f->pixelformat = formats[index].fourcc;
+                       break;
+               default:
                        return -EINVAL;
-               err = v4l2_video_std_construct(e, tvnorms[e->index].id,
-                                              tvnorms[e->index].name);
-               e->index = i;
-               if (err < 0)
-                       return err;
+               }
+               return 0;
+       }
+       case VIDIOC_G_FMT:
+       {
+               struct v4l2_format *f = arg;
+               return cx8800_g_fmt(dev,fh,f);
+       }
+       case VIDIOC_S_FMT:
+       {
+               struct v4l2_format *f = arg;
+               return cx8800_s_fmt(dev,fh,f);
+       }
+       case VIDIOC_TRY_FMT:
+       {
+               struct v4l2_format *f = arg;
+               return cx8800_try_fmt(dev,fh,f);
+       }
+#ifdef CONFIG_VIDEO_V4L1_COMPAT
+       /* --- streaming capture ------------------------------------- */
+       case VIDIOCGMBUF:
+       {
+               struct video_mbuf *mbuf = arg;
+               struct videobuf_queue *q;
+               struct v4l2_requestbuffers req;
+               unsigned int i;
+
+               q = get_queue(fh);
+               memset(&req,0,sizeof(req));
+               req.type   = q->type;
+               req.count  = 8;
+               req.memory = V4L2_MEMORY_MMAP;
+               err = videobuf_reqbufs(q,&req);
+               if (err < 0)
+                       return err;
+               memset(mbuf,0,sizeof(*mbuf));
+               mbuf->frames = req.count;
+               mbuf->size   = 0;
+               for (i = 0; i < mbuf->frames; i++) {
+                       mbuf->offsets[i]  = q->bufs[i]->boff;
+                       mbuf->size       += q->bufs[i]->bsize;
+               }
+               return 0;
+       }
+#endif
+       case VIDIOC_REQBUFS:
+               return videobuf_reqbufs(get_queue(fh), arg);
+
+       case VIDIOC_QUERYBUF:
+               return videobuf_querybuf(get_queue(fh), arg);
+
+       case VIDIOC_QBUF:
+               return videobuf_qbuf(get_queue(fh), arg);
+
+       case VIDIOC_DQBUF:
+               return videobuf_dqbuf(get_queue(fh), arg,
+                                       file->f_flags & O_NONBLOCK);
+
+       case VIDIOC_STREAMON:
+       {
+               int res = get_ressource(fh);
+
+               if (!res_get(dev,fh,res))
+                       return -EBUSY;
+               return videobuf_streamon(get_queue(fh));
+       }
+       case VIDIOC_STREAMOFF:
+       {
+               int res = get_ressource(fh);
+
+               err = videobuf_streamoff(get_queue(fh));
+               if (err < 0)
+                       return err;
+               res_free(dev,fh,res);
+               return 0;
+       }
+       default:
+               return cx88_do_ioctl( inode, file, fh->radio, core, cmd, arg, video_do_ioctl );
+       }
+       return 0;
+}
+
+int cx88_do_ioctl(struct inode *inode, struct file *file, int radio,
+                 struct cx88_core *core, unsigned int cmd, void *arg, v4l2_kioctl driver_ioctl)
+{
+       int err;
+
+       if (video_debug) {
+              if (video_debug > 1) {
+                      if (_IOC_DIR(cmd) & _IOC_WRITE)
+                              v4l_printk_ioctl_arg("cx88(w)",cmd, arg);
+                      else if (!_IOC_DIR(cmd) & _IOC_READ) {
+                              v4l_print_ioctl("cx88", cmd);
+                      }
+              } else
+                      v4l_print_ioctl(core->name,cmd);
+
+       }
+
+       switch (cmd) {
+       /* ---------- tv norms ---------- */
+       case VIDIOC_ENUMSTD:
+       {
+               struct v4l2_standard *e = arg;
+               unsigned int i;
+
+               i = e->index;
+               if (i >= ARRAY_SIZE(tvnorms))
+                       return -EINVAL;
+               err = v4l2_video_std_construct(e, tvnorms[e->index].id,
+                                              tvnorms[e->index].name);
+               e->index = i;
+               if (err < 0)
+                       return err;
                return 0;
        }
        case VIDIOC_G_STD:
        {
                v4l2_std_id *id = arg;
 
-               *id = dev->tvnorm->id;
+               *id = core->tvnorm->id;
                return 0;
        }
        case VIDIOC_S_STD:
@@ -1604,9 +1351,9 @@ static int video_do_ioctl(struct inode *inode, struct file *file,
                if (i == ARRAY_SIZE(tvnorms))
                        return -EINVAL;
 
-               down(&dev->lock);
-               set_tvnorm(dev,&tvnorms[i]);
-               up(&dev->lock);
+               mutex_lock(&core->lock);
+               cx88_set_tvnorm(core,&tvnorms[i]);
+               mutex_unlock(&core->lock);
                return 0;
        }
 
@@ -1618,8 +1365,10 @@ static int video_do_ioctl(struct inode *inode, struct file *file,
                        [ CX88_VMUX_COMPOSITE2 ] = "Composite2",
                        [ CX88_VMUX_COMPOSITE3 ] = "Composite3",
                        [ CX88_VMUX_COMPOSITE4 ] = "Composite4",
-                       [ CX88_VMUX_TELEVISION ] = "Television",
                        [ CX88_VMUX_SVIDEO     ] = "S-Video",
+                       [ CX88_VMUX_TELEVISION ] = "Television",
+                       [ CX88_VMUX_CABLE      ] = "Cable TV",
+                       [ CX88_VMUX_DVB        ] = "DVB",
                        [ CX88_VMUX_DEBUG      ] = "for debug only",
                };
                struct v4l2_input *i = arg;
@@ -1634,7 +1383,8 @@ static int video_do_ioctl(struct inode *inode, struct file *file,
                i->index = n;
                i->type  = V4L2_INPUT_TYPE_CAMERA;
                strcpy(i->name,iname[INPUT(n)->type]);
-               if (CX88_VMUX_TELEVISION == INPUT(n)->type)
+               if ((CX88_VMUX_TELEVISION == INPUT(n)->type) ||
+                   (CX88_VMUX_CABLE      == INPUT(n)->type))
                        i->type = V4L2_INPUT_TYPE_TUNER;
                for (n = 0; n < ARRAY_SIZE(tvnorms); n++)
                        i->std |= tvnorms[n].id;
@@ -1644,92 +1394,43 @@ static int video_do_ioctl(struct inode *inode, struct file *file,
        {
                unsigned int *i = arg;
 
-               *i = dev->input;
+               *i = core->input;
                return 0;
        }
        case VIDIOC_S_INPUT:
        {
                unsigned int *i = arg;
-               
+
                if (*i >= 4)
                        return -EINVAL;
-               down(&dev->lock);
-               video_mux(dev,*i);
-               up(&dev->lock);
+               mutex_lock(&core->lock);
+               cx88_newstation(core);
+               video_mux(core,*i);
+               mutex_unlock(&core->lock);
                return 0;
        }
 
-       /* --- capture ioctls ---------------------------------------- */
-       case VIDIOC_ENUM_FMT:
-       {
-               struct v4l2_fmtdesc *f = arg;
-               enum v4l2_buf_type type;
-               unsigned int index;
 
-               index = f->index;
-               type  = f->type;
-               switch (type) {
-               case V4L2_BUF_TYPE_VIDEO_CAPTURE:
-                       if (index >= ARRAY_SIZE(formats))
-                               return -EINVAL;
-                       memset(f,0,sizeof(*f));
-                       f->index = index;
-                       f->type  = type;
-                       strlcpy(f->description,formats[index].name,sizeof(f->description));
-                       f->pixelformat = formats[index].fourcc;
-                       break;
-               default:
-                       return -EINVAL;
-               }
-               return 0;
-       }
-       case VIDIOC_G_FMT:
-       {
-               struct v4l2_format *f = arg;
-               return cx8800_g_fmt(dev,fh,f);
-       }
-       case VIDIOC_S_FMT:
-       {
-               struct v4l2_format *f = arg;
-               return cx8800_s_fmt(dev,fh,f);
-       }
-       case VIDIOC_TRY_FMT:
-       {
-               struct v4l2_format *f = arg;
-               return cx8800_try_fmt(dev,fh,f);
-       }
 
        /* --- controls ---------------------------------------------- */
        case VIDIOC_QUERYCTRL:
        {
                struct v4l2_queryctrl *c = arg;
-               int i;
 
-               if (c->id <  V4L2_CID_BASE ||
-                   c->id >= V4L2_CID_LASTP1)
-                       return -EINVAL;
-               for (i = 0; i < CX8800_CTLS; i++)
-                       if (cx8800_ctls[i].v.id == c->id)
-                               break;
-               if (i == CX8800_CTLS) {
-                       *c = no_ctl;
-                       return 0;
-               }
-               *c = cx8800_ctls[i].v;
-               return 0;
+               return cx88_queryctrl(c);
        }
        case VIDIOC_G_CTRL:
-               return get_control(dev,arg);
+               return get_control(core,arg);
        case VIDIOC_S_CTRL:
-               return set_control(dev,arg);
-               
+               return set_control(core,arg);
+
        /* --- tuner ioctls ------------------------------------------ */
        case VIDIOC_G_TUNER:
        {
                struct v4l2_tuner *t = arg;
                u32 reg;
-               
-               if (UNSET == dev->tuner_type)
+
+               if (UNSET == core->tuner_type)
                        return -EINVAL;
                if (0 != t->index)
                        return -EINVAL;
@@ -1740,113 +1441,91 @@ static int video_do_ioctl(struct inode *inode, struct file *file,
                t->capability = V4L2_TUNER_CAP_NORM;
                t->rangehigh  = 0xffffffffUL;
 
-               cx88_get_stereo(dev ,t);
+               cx88_get_stereo(core ,t);
                reg = cx_read(MO_DEVICE_STATUS);
-                t->signal = (reg & (1<<5)) ? 0xffff : 0x0000;
+               t->signal = (reg & (1<<5)) ? 0xffff : 0x0000;
                return 0;
        }
        case VIDIOC_S_TUNER:
        {
                struct v4l2_tuner *t = arg;
 
-               if (UNSET == dev->tuner_type)
+               if (UNSET == core->tuner_type)
                        return -EINVAL;
                if (0 != t->index)
                        return -EINVAL;
-               cx88_set_stereo(dev,t->audmode);
+               cx88_set_stereo(core, t->audmode, 1);
                return 0;
        }
        case VIDIOC_G_FREQUENCY:
        {
                struct v4l2_frequency *f = arg;
 
-               if (UNSET == dev->tuner_type)
-                       return -EINVAL;
-               if (f->tuner != 0)
-                       return -EINVAL;
                memset(f,0,sizeof(*f));
-               f->type = fh->radio ? V4L2_TUNER_RADIO : V4L2_TUNER_ANALOG_TV;
-               f->frequency = dev->freq;
+
+               if (UNSET == core->tuner_type)
+                       return -EINVAL;
+
+               /* f->type = fh->radio ? V4L2_TUNER_RADIO : V4L2_TUNER_ANALOG_TV; */
+               f->type = radio ? V4L2_TUNER_RADIO : V4L2_TUNER_ANALOG_TV;
+               f->frequency = core->freq;
+
+               cx88_call_i2c_clients(core,VIDIOC_G_FREQUENCY,f);
+
                return 0;
        }
        case VIDIOC_S_FREQUENCY:
        {
                struct v4l2_frequency *f = arg;
 
-               if (UNSET == dev->tuner_type)
+               if (UNSET == core->tuner_type)
                        return -EINVAL;
                if (f->tuner != 0)
                        return -EINVAL;
-               if (0 == fh->radio && f->type != V4L2_TUNER_ANALOG_TV)
+               if (0 == radio && f->type != V4L2_TUNER_ANALOG_TV)
                        return -EINVAL;
-               if (1 == fh->radio && f->type != V4L2_TUNER_RADIO)
+               if (1 == radio && f->type != V4L2_TUNER_RADIO)
                        return -EINVAL;
-               down(&dev->lock);
-               dev->freq = f->frequency;
-               cx8800_call_i2c_clients(dev,VIDIOCSFREQ,&dev->freq);
-               up(&dev->lock);
-               return 0;
-       }
+               mutex_lock(&core->lock);
+               core->freq = f->frequency;
+               cx88_newstation(core);
+               cx88_call_i2c_clients(core,VIDIOC_S_FREQUENCY,f);
 
-       /* --- streaming capture ------------------------------------- */
-       case VIDIOCGMBUF:
-       {
-               struct video_mbuf *mbuf = arg;
-               struct videobuf_queue *q;
-               struct v4l2_requestbuffers req;
-               unsigned int i;
+               /* When changing channels it is required to reset TVAUDIO */
+               msleep (10);
+               cx88_set_tvaudio(core);
 
-               q = get_queue(fh);
-               memset(&req,0,sizeof(req));
-               req.type   = q->type;
-               req.count  = 8;
-               req.memory = V4L2_MEMORY_MMAP;
-               err = videobuf_reqbufs(file,q,&req);
-               if (err < 0)
-                       return err;
-               memset(mbuf,0,sizeof(*mbuf));
-               mbuf->frames = req.count;
-               mbuf->size   = 0;
-               for (i = 0; i < mbuf->frames; i++) {
-                       mbuf->offsets[i]  = q->bufs[i]->boff;
-                       mbuf->size       += q->bufs[i]->bsize;
-               }
+               mutex_unlock(&core->lock);
                return 0;
        }
-       case VIDIOC_REQBUFS:
-               return videobuf_reqbufs(file, get_queue(fh), arg);
-
-       case VIDIOC_QUERYBUF:
-               return videobuf_querybuf(get_queue(fh), arg);
-
-       case VIDIOC_QBUF:
-               return videobuf_qbuf(file, get_queue(fh), arg);
-
-       case VIDIOC_DQBUF:
-               return videobuf_dqbuf(file, get_queue(fh), arg);
-
-       case VIDIOC_STREAMON:
+#ifdef CONFIG_VIDEO_ADV_DEBUG
+       /* ioctls to allow direct acces to the cx2388x registers */
+       case VIDIOC_INT_G_REGISTER:
        {
-               int res = get_ressource(fh);
+               struct v4l2_register *reg = arg;
 
-                if (!res_get(dev,fh,res))
-                       return -EBUSY;
-               return videobuf_streamon(file, get_queue(fh));
+               if (reg->i2c_id != 0)
+                       return -EINVAL;
+               /* cx2388x has a 24-bit register space */
+               reg->val = cx_read(reg->reg&0xffffff);
+               return 0;
        }
-       case VIDIOC_STREAMOFF:
+       case VIDIOC_INT_S_REGISTER:
        {
-               int res = get_ressource(fh);
+               struct v4l2_register *reg = arg;
 
-               err = videobuf_streamoff(file, get_queue(fh));
-               if (err < 0)
-                       return err;
-               res_free(dev,fh,res);
+               if (reg->i2c_id != 0)
+                       return -EINVAL;
+               if (!capable(CAP_SYS_ADMIN))
+                       return -EPERM;
+               cx_write(reg->reg&0xffffff, reg->val);
                return 0;
        }
+#endif
 
        default:
                return v4l_compat_translate_ioctl(inode,file,cmd,arg,
-                                                 video_do_ioctl);
+                                                 driver_ioctl);
        }
        return 0;
 }
@@ -1854,7 +1533,19 @@ static int video_do_ioctl(struct inode *inode, struct file *file,
 static int video_ioctl(struct inode *inode, struct file *file,
                       unsigned int cmd, unsigned long arg)
 {
-       return video_usercopy(inode, file, cmd, arg, video_do_ioctl);
+       int retval;
+
+       retval=video_usercopy(inode, file, cmd, arg, video_do_ioctl);
+
+       if (video_debug > 1) {
+              if (retval < 0) {
+                      v4l_print_ioctl("cx88(err)", cmd);
+                      printk(KERN_DEBUG "cx88(err): errcode=%d\n",retval);
+              } else if (_IOC_DIR(cmd) & _IOC_READ)
+                      v4l_printk_ioctl_arg("cx88(r)",cmd, (void *)arg);
+       }
+
+       return retval;
 }
 
 /* ----------------------------------------------------------- */
@@ -1862,20 +1553,21 @@ static int video_ioctl(struct inode *inode, struct file *file,
 static int radio_do_ioctl(struct inode *inode, struct file *file,
                        unsigned int cmd, void *arg)
 {
-       struct cx8800_fh *fh = file->private_data;
-       struct cx8800_dev *dev = fh->dev;
-       
+       struct cx8800_fh *fh    = file->private_data;
+       struct cx8800_dev *dev  = fh->dev;
+       struct cx88_core  *core = dev->core;
+
        if (video_debug > 1)
-               cx88_print_ioctl(dev->name,cmd);
+               v4l_print_ioctl(core->name,cmd);
 
        switch (cmd) {
        case VIDIOC_QUERYCAP:
        {
                struct v4l2_capability *cap = arg;
-               
+
                memset(cap,0,sizeof(*cap));
-                strcpy(cap->driver, "cx8800");
-               strlcpy(cap->card, cx88_boards[dev->board].name,
+               strcpy(cap->driver, "cx8800");
+               strlcpy(cap->card, cx88_boards[core->board].name,
                        sizeof(cap->card));
                sprintf(cap->bus_info,"PCI:%s", pci_name(dev->pci));
                cap->version = CX88_VERSION_CODE;
@@ -1885,25 +1577,21 @@ static int radio_do_ioctl(struct inode *inode, struct file *file,
        case VIDIOC_G_TUNER:
        {
                struct v4l2_tuner *t = arg;
-               struct video_tuner vt;
 
                if (t->index > 0)
                        return -EINVAL;
 
                memset(t,0,sizeof(*t));
                strcpy(t->name, "Radio");
-                t->rangelow  = (int)(65*16);
-                t->rangehigh = (int)(108*16);
-               
-               memset(&vt,0,sizeof(vt));
-               cx8800_call_i2c_clients(dev,VIDIOCGTUNER,&vt);
-               t->signal = vt.signal;
+               t->type = V4L2_TUNER_RADIO;
+
+               cx88_call_i2c_clients(core,VIDIOC_G_TUNER,t);
                return 0;
        }
        case VIDIOC_ENUMINPUT:
        {
                struct v4l2_input *i = arg;
-               
+
                if (i->index != 0)
                        return -EINVAL;
                strcpy(i->name,"Radio");
@@ -1930,8 +1618,31 @@ static int radio_do_ioctl(struct inode *inode, struct file *file,
                *id = 0;
                return 0;
        }
-       case VIDIOC_S_AUDIO:
+#ifdef CONFIG_VIDEO_V4L1_COMPAT
+       case VIDIOCSTUNER:
+       {
+               struct video_tuner *v = arg;
+
+               if (v->tuner) /* Only tuner 0 */
+                       return -EINVAL;
+
+               cx88_call_i2c_clients(core,VIDIOCSTUNER,v);
+               return 0;
+       }
+#endif
        case VIDIOC_S_TUNER:
+       {
+               struct v4l2_tuner *t = arg;
+
+               if (0 != t->index)
+                       return -EINVAL;
+
+               cx88_call_i2c_clients(core,VIDIOC_S_TUNER,t);
+
+               return 0;
+       }
+
+       case VIDIOC_S_AUDIO:
        case VIDIOC_S_INPUT:
        case VIDIOC_S_STD:
                return 0;
@@ -1960,7 +1671,7 @@ static int radio_do_ioctl(struct inode *inode, struct file *file,
        case VIDIOC_G_FREQUENCY:
        case VIDIOC_S_FREQUENCY:
                return video_do_ioctl(inode,file,cmd,arg);
-               
+
        default:
                return v4l_compat_translate_ioctl(inode,file,cmd,arg,
                                                  radio_do_ioctl);
@@ -1979,13 +1690,13 @@ static int radio_ioctl(struct inode *inode, struct file *file,
 static void cx8800_vid_timeout(unsigned long data)
 {
        struct cx8800_dev *dev = (struct cx8800_dev*)data;
+       struct cx88_core *core = dev->core;
        struct cx88_dmaqueue *q = &dev->vidq;
        struct cx88_buffer *buf;
        unsigned long flags;
 
-       cx88_sram_channel_dump(dev, &cx88_sram_channels[SRAM_CH21]);
-       //cx88_risc_disasm(dev,&dev->vidq.stopper);
-       
+       cx88_sram_channel_dump(core, &cx88_sram_channels[SRAM_CH21]);
+
        cx_clear(MO_VID_DMACNTRL, 0x11);
        cx_clear(VID_CAPTURE_CONTROL, 0x06);
 
@@ -1995,41 +1706,24 @@ static void cx8800_vid_timeout(unsigned long data)
                list_del(&buf->vb.queue);
                buf->vb.state = STATE_ERROR;
                wake_up(&buf->vb.done);
-               printk("%s: [%p/%d] timeout - dma=0x%08lx\n", dev->name,
+               printk("%s/0: [%p/%d] timeout - dma=0x%08lx\n", core->name,
                       buf, buf->vb.i, (unsigned long)buf->risc.dma);
        }
        restart_video_queue(dev,q);
        spin_unlock_irqrestore(&dev->slock,flags);
 }
 
-static void cx8800_wakeup(struct cx8800_dev *dev,
-                         struct cx88_dmaqueue *q, u32 count)
-{
-       struct cx88_buffer *buf;
-
-       for (;;) {
-               if (list_empty(&q->active))
-                       break;
-               buf = list_entry(q->active.next,
-                                struct cx88_buffer, vb.queue);
-               if (buf->count > count)
-                       break;
-               do_gettimeofday(&buf->vb.ts);
-               dprintk(2,"[%p/%d] wakeup reg=%d buf=%d\n",buf,buf->vb.i,
-                       count, buf->count);
-               buf->vb.state = STATE_DONE;
-               list_del(&buf->vb.queue);
-               wake_up(&buf->vb.done);
-       }
-       if (list_empty(&q->active)) {
-               del_timer(&q->timeout);
-       } else {
-               mod_timer(&q->timeout, jiffies+BUFFER_TIMEOUT);
-       }
-}
+static char *cx88_vid_irqs[32] = {
+       "y_risci1", "u_risci1", "v_risci1", "vbi_risc1",
+       "y_risci2", "u_risci2", "v_risci2", "vbi_risc2",
+       "y_oflow",  "u_oflow",  "v_oflow",  "vbi_oflow",
+       "y_sync",   "u_sync",   "v_sync",   "vbi_sync",
+       "opc_err",  "par_err",  "rip_err",  "pci_abort",
+};
 
 static void cx8800_vid_irq(struct cx8800_dev *dev)
 {
+       struct cx88_core *core = dev->core;
        u32 status, mask, count;
 
        status = cx_read(MO_VID_INTSTAT);
@@ -2038,22 +1732,22 @@ static void cx8800_vid_irq(struct cx8800_dev *dev)
                return;
        cx_write(MO_VID_INTSTAT, status);
        if (irq_debug  ||  (status & mask & ~0xff))
-               cx88_print_irqbits(dev->name, "irq vid",
+               cx88_print_irqbits(core->name, "irq vid",
                                   cx88_vid_irqs, status, mask);
 
        /* risc op code error */
        if (status & (1 << 16)) {
-               printk(KERN_WARNING "%s: video risc op code error\n",dev->name);
+               printk(KERN_WARNING "%s/0: video risc op code error\n",core->name);
                cx_clear(MO_VID_DMACNTRL, 0x11);
                cx_clear(VID_CAPTURE_CONTROL, 0x06);
-               cx88_sram_channel_dump(dev, &cx88_sram_channels[SRAM_CH21]);
+               cx88_sram_channel_dump(core, &cx88_sram_channels[SRAM_CH21]);
        }
-       
+
        /* risc1 y */
        if (status & 0x01) {
                spin_lock(&dev->slock);
                count = cx_read(MO_VIDY_GPCNT);
-               cx8800_wakeup(dev, &dev->vidq, count);
+               cx88_wakeup(core, &dev->vidq, count);
                spin_unlock(&dev->slock);
        }
 
@@ -2061,7 +1755,7 @@ static void cx8800_vid_irq(struct cx8800_dev *dev)
        if (status & 0x08) {
                spin_lock(&dev->slock);
                count = cx_read(MO_VBI_GPCNT);
-               cx8800_wakeup(dev, &dev->vbiq, count);
+               cx88_wakeup(core, &dev->vbiq, count);
                spin_unlock(&dev->slock);
        }
 
@@ -2082,32 +1776,31 @@ static void cx8800_vid_irq(struct cx8800_dev *dev)
        }
 }
 
-static irqreturn_t cx8800_irq(int irq, void *dev_id, struct pt_regs *regs)
+static irqreturn_t cx8800_irq(int irq, void *dev_id)
 {
        struct cx8800_dev *dev = dev_id;
-       u32 status, mask;
+       struct cx88_core *core = dev->core;
+       u32 status;
        int loop, handled = 0;
 
        for (loop = 0; loop < 10; loop++) {
-               status = cx_read(MO_PCI_INTSTAT);
-               mask   = cx_read(MO_PCI_INTMSK);
-               if (0 == (status & mask))
+               status = cx_read(MO_PCI_INTSTAT) & (core->pci_irqmask | 0x01);
+               if (0 == status)
                        goto out;
-               handled = 1;
                cx_write(MO_PCI_INTSTAT, status);
-               if (irq_debug  ||  (status & mask & ~0x1f))
-                       cx88_print_irqbits(dev->name, "irq pci",
-                                          cx88_pci_irqs, status, mask);
+               handled = 1;
 
-               if (status & 1)
+               if (status & core->pci_irqmask)
+                       cx88_core_irq(core,status);
+               if (status & 0x01)
                        cx8800_vid_irq(dev);
        };
        if (10 == loop) {
-               printk(KERN_WARNING "%s: irq loop -- clearing mask\n",
-                      dev->name);
+               printk(KERN_WARNING "%s/0: irq loop -- clearing mask\n",
+                      core->name);
                cx_write(MO_PCI_INTMSK,0);
        }
-       
+
  out:
        return IRQ_RETVAL(handled);
 }
@@ -2124,10 +1817,11 @@ static struct file_operations video_fops =
        .poll          = video_poll,
        .mmap          = video_mmap,
        .ioctl         = video_ioctl,
+       .compat_ioctl  = v4l_compat_ioctl32,
        .llseek        = no_llseek,
 };
 
-struct video_device cx8800_video_template =
+static struct video_device cx8800_video_template =
 {
        .name          = "cx8800-video",
        .type          = VID_TYPE_CAPTURE|VID_TYPE_TUNER|VID_TYPE_SCALES,
@@ -2136,7 +1830,7 @@ struct video_device cx8800_video_template =
        .minor         = -1,
 };
 
-struct video_device cx8800_vbi_template =
+static struct video_device cx8800_vbi_template =
 {
        .name          = "cx8800-vbi",
        .type          = VID_TYPE_TELETEXT|VID_TYPE_TUNER,
@@ -2151,10 +1845,11 @@ static struct file_operations radio_fops =
        .open          = video_open,
        .release       = video_release,
        .ioctl         = radio_ioctl,
+       .compat_ioctl  = v4l_compat_ioctl32,
        .llseek        = no_llseek,
 };
 
-struct video_device cx8800_radio_template =
+static struct video_device cx8800_radio_template =
 {
        .name          = "cx8800-radio",
        .type          = VID_TYPE_TUNER,
@@ -2165,97 +1860,6 @@ struct video_device cx8800_radio_template =
 
 /* ----------------------------------------------------------- */
 
-static void cx8800_shutdown(struct cx8800_dev *dev)
-{
-       /* disable RISC controller + IRQs */
-       cx_write(MO_DEV_CNTRL2, 0);
-
-       /* stop dma transfers */
-       cx_write(MO_VID_DMACNTRL, 0x0);
-       cx_write(MO_AUD_DMACNTRL, 0x0);
-       cx_write(MO_TS_DMACNTRL, 0x0);
-       cx_write(MO_VIP_DMACNTRL, 0x0);
-       cx_write(MO_GPHST_DMACNTRL, 0x0);
-
-       /* stop interupts */
-       cx_write(MO_PCI_INTMSK, 0x0);
-       cx_write(MO_VID_INTMSK, 0x0);
-       cx_write(MO_AUD_INTMSK, 0x0);
-       cx_write(MO_TS_INTMSK, 0x0);
-       cx_write(MO_VIP_INTMSK, 0x0);
-       cx_write(MO_GPHST_INTMSK, 0x0);
-
-       /* stop capturing */
-       cx_write(VID_CAPTURE_CONTROL, 0);
-}
-
-static int cx8800_reset(struct cx8800_dev *dev)
-{
-       dprintk(1,"cx8800_reset\n");
-
-       cx8800_shutdown(dev);
-       
-       /* clear irq status */
-       cx_write(MO_VID_INTSTAT, 0xFFFFFFFF); // Clear PIV int
-       cx_write(MO_PCI_INTSTAT, 0xFFFFFFFF); // Clear PCI int
-       cx_write(MO_INT1_STAT,   0xFFFFFFFF); // Clear RISC int
-
-       /* wait a bit */
-       set_current_state(TASK_INTERRUPTIBLE);
-       schedule_timeout(HZ/10);
-       
-       /* init sram */
-       cx88_sram_channel_setup(dev, &cx88_sram_channels[SRAM_CH21], 720*4, 0);
-       cx88_sram_channel_setup(dev, &cx88_sram_channels[SRAM_CH22], 128, 0);
-       cx88_sram_channel_setup(dev, &cx88_sram_channels[SRAM_CH23], 128, 0);
-       cx88_sram_channel_setup(dev, &cx88_sram_channels[SRAM_CH24], 128, 0);
-       cx88_sram_channel_setup(dev, &cx88_sram_channels[SRAM_CH25], 128, 0);
-       cx88_sram_channel_setup(dev, &cx88_sram_channels[SRAM_CH26], 128, 0);
-       
-       /* misc init ... */
-       cx_write(MO_INPUT_FORMAT, ((1 << 13) |   // agc enable
-                                  (1 << 12) |   // agc gain
-                                  (1 << 11) |   // adaptibe agc
-                                  (0 << 10) |   // chroma agc
-                                  (0 <<  9) |   // ckillen
-                                  (7)));
-
-       /* setup image format */
-       cx_andor(MO_COLOR_CTRL, 0x4000, 0x4000);
-
-       /* setup FIFO Threshholds */
-       cx_write(MO_PDMA_STHRSH,   0x0807);
-       cx_write(MO_PDMA_DTHRSH,   0x0807);
-
-       /* fixes flashing of image */
-       cx_write(MO_AGC_SYNC_TIP1, 0x0380000F);
-       cx_write(MO_AGC_BACK_VBI,  0x00E00555);
-       
-       cx_write(MO_VID_INTSTAT,   0xFFFFFFFF); // Clear PIV int
-       cx_write(MO_PCI_INTSTAT,   0xFFFFFFFF); // Clear PCI int
-       cx_write(MO_INT1_STAT,     0xFFFFFFFF); // Clear RISC int
-
-       return 0;
-}
-
-static struct video_device *vdev_init(struct cx8800_dev *dev,
-                                     struct video_device *template,
-                                     char *type)
-{
-       struct video_device *vfd;
-
-       vfd = video_device_alloc();
-       if (NULL == vfd)
-               return NULL;
-       *vfd = *template;
-       vfd->minor   = -1;
-       vfd->dev     = &dev->pci->dev;
-       vfd->release = video_device_release;
-       snprintf(vfd->name, sizeof(vfd->name), "%s %s (%s)",
-                dev->name, type, cx88_boards[dev->board].name);
-       return vfd;
-}
-
 static void cx8800_unregister_video(struct cx8800_dev *dev)
 {
        if (dev->radio_dev) {
@@ -2281,95 +1885,48 @@ static void cx8800_unregister_video(struct cx8800_dev *dev)
        }
 }
 
-/* debug that damn oops ... */
-static unsigned int oops = 0;
-MODULE_PARM(oops,"i");
-#define OOPS(msg) if (oops) printk("%s: %s\n",__FUNCTION__,msg);
-
 static int __devinit cx8800_initdev(struct pci_dev *pci_dev,
                                    const struct pci_device_id *pci_id)
 {
        struct cx8800_dev *dev;
-       unsigned int i;
+       struct cx88_core *core;
        int err;
 
-       dev = kmalloc(sizeof(*dev),GFP_KERNEL);
+       dev = kzalloc(sizeof(*dev),GFP_KERNEL);
        if (NULL == dev)
                return -ENOMEM;
-       memset(dev,0,sizeof(*dev));
 
        /* pci init */
-       OOPS("pci init");
        dev->pci = pci_dev;
        if (pci_enable_device(pci_dev)) {
                err = -EIO;
-               goto fail1;
+               goto fail_free;
        }
-       sprintf(dev->name,"cx%x[%d]",pci_dev->device,cx8800_devcount);
-
-       /* pci quirks */
-       OOPS("pci quirks");
-       cx88_pci_quirks(dev->name, dev->pci, &latency);
-       if (UNSET != latency) {
-               printk(KERN_INFO "%s: setting pci latency timer to %d\n",
-                      dev->name,latency);
-               pci_write_config_byte(pci_dev, PCI_LATENCY_TIMER, latency);
+       core = cx88_core_get(dev->pci);
+       if (NULL == core) {
+               err = -EINVAL;
+               goto fail_free;
        }
+       dev->core = core;
 
        /* print pci info */
-       OOPS("pci info");
        pci_read_config_byte(pci_dev, PCI_CLASS_REVISION, &dev->pci_rev);
-        pci_read_config_byte(pci_dev, PCI_LATENCY_TIMER,  &dev->pci_lat);
-        printk(KERN_INFO "%s: found at %s, rev: %d, irq: %d, "
-              "latency: %d, mmio: 0x%lx\n", dev->name,
+       pci_read_config_byte(pci_dev, PCI_LATENCY_TIMER,  &dev->pci_lat);
+       printk(KERN_INFO "%s/0: found at %s, rev: %d, irq: %d, "
+              "latency: %d, mmio: 0x%llx\n", core->name,
               pci_name(pci_dev), dev->pci_rev, pci_dev->irq,
-              dev->pci_lat,pci_resource_start(pci_dev,0));
+              dev->pci_lat,(unsigned long long)pci_resource_start(pci_dev,0));
 
        pci_set_master(pci_dev);
        if (!pci_dma_supported(pci_dev,0xffffffff)) {
-               printk("%s: Oops: no 32bit PCI DMA ???\n",dev->name);
+               printk("%s/0: Oops: no 32bit PCI DMA ???\n",core->name);
                err = -EIO;
-               goto fail1;
-       }
-
-       /* board config */
-       OOPS("board config");
-       dev->board = card[cx8800_devcount];
-       for (i = 0; UNSET == dev->board  &&  i < cx88_idcount; i++) 
-               if (pci_dev->subsystem_vendor == cx88_subids[i].subvendor &&
-                   pci_dev->subsystem_device == cx88_subids[i].subdevice)
-                       dev->board = cx88_subids[i].card;
-       if (UNSET == dev->board)
-               dev->board = CX88_BOARD_UNKNOWN;
-        printk(KERN_INFO "%s: subsystem: %04x:%04x, board: %s [card=%d,%s]\n",
-              dev->name,pci_dev->subsystem_vendor,
-              pci_dev->subsystem_device,cx88_boards[dev->board].name,
-              dev->board, card[cx8800_devcount] == dev->board ?
-              "insmod option" : "autodetected");
-
-       dev->tuner_type = tuner[cx8800_devcount];
-       if (UNSET == dev->tuner_type)
-               dev->tuner_type = cx88_boards[dev->board].tuner_type;
-
-       /* get mmio */
-       OOPS("get mmio");
-       if (!request_mem_region(pci_resource_start(pci_dev,0),
-                               pci_resource_len(pci_dev,0),
-                               dev->name)) {
-               err = -EBUSY;
-               printk(KERN_ERR "%s: can't get MMIO memory @ 0x%lx\n",
-                      dev->name,pci_resource_start(pci_dev,0));
-               goto fail1;
-       }
-       dev->lmmio = ioremap(pci_resource_start(pci_dev,0),
-                            pci_resource_len(pci_dev,0));
-       dev->bmmio = (u8*)dev->lmmio;
+               goto fail_core;
+       }
 
        /* initialize driver struct */
-       OOPS("init structs");
-        init_MUTEX(&dev->lock);
-       dev->slock = SPIN_LOCK_UNLOCKED;
-       dev->tvnorm = tvnorms;
+       spin_lock_init(&dev->slock);
+       core->tvnorm = tvnorms;
 
        /* init video dma queues */
        INIT_LIST_HEAD(&dev->vidq.active);
@@ -2389,141 +1946,139 @@ static int __devinit cx8800_initdev(struct pci_dev *pci_dev,
        cx88_risc_stopper(dev->pci,&dev->vbiq.stopper,
                          MO_VID_DMACNTRL,0x88,0x00);
 
-       /* initialize hardware */
-       OOPS("reset hardware");
-       cx8800_reset(dev);
-
        /* get irq */
-       OOPS("install irq handler");
        err = request_irq(pci_dev->irq, cx8800_irq,
-                         SA_SHIRQ | SA_INTERRUPT, dev->name, dev);
+                         IRQF_SHARED | IRQF_DISABLED, core->name, dev);
        if (err < 0) {
                printk(KERN_ERR "%s: can't get IRQ %d\n",
-                      dev->name,pci_dev->irq);
-               goto fail2;
+                      core->name,pci_dev->irq);
+               goto fail_core;
        }
-
-       /* register i2c bus + load i2c helpers */
-       OOPS("i2c setup");
-       cx8800_i2c_init(dev);
-       OOPS("card setup");
-       cx88_card_setup(dev);
+       cx_set(MO_PCI_INTMSK, core->pci_irqmask);
 
        /* load and configure helper modules */
-       OOPS("configure i2c clients");
-       if (TUNER_ABSENT != dev->tuner_type)
+       if (TUNER_ABSENT != core->tuner_type)
                request_module("tuner");
-       if (cx88_boards[dev->board].needs_tda9887)
-               request_module("tda9887");
-       if (dev->tuner_type != UNSET)
-               cx8800_call_i2c_clients(dev,TUNER_SET_TYPE,&dev->tuner_type);
+
+       if (cx88_boards[ core->board ].audio_chip == AUDIO_CHIP_WM8775)
+               request_module("wm8775");
 
        /* register v4l devices */
-       OOPS("register video");
-       dev->video_dev = vdev_init(dev,&cx8800_video_template,"video");
+       dev->video_dev = cx88_vdev_init(core,dev->pci,
+                                       &cx8800_video_template,"video");
        err = video_register_device(dev->video_dev,VFL_TYPE_GRABBER,
-                                   video_nr[cx8800_devcount]);
+                                   video_nr[core->nr]);
        if (err < 0) {
                printk(KERN_INFO "%s: can't register video device\n",
-                      dev->name);
-               goto fail3;
+                      core->name);
+               goto fail_unreg;
        }
-       printk(KERN_INFO "%s: registered device video%d [v4l2]\n",
-              dev->name,dev->video_dev->minor & 0x1f);
+       printk(KERN_INFO "%s/0: registered device video%d [v4l2]\n",
+              core->name,dev->video_dev->minor & 0x1f);
 
-       OOPS("register vbi");
-       dev->vbi_dev = vdev_init(dev,&cx8800_vbi_template,"vbi");
+       dev->vbi_dev = cx88_vdev_init(core,dev->pci,&cx8800_vbi_template,"vbi");
        err = video_register_device(dev->vbi_dev,VFL_TYPE_VBI,
-                                   vbi_nr[cx8800_devcount]);
+                                   vbi_nr[core->nr]);
        if (err < 0) {
-               printk(KERN_INFO "%s: can't register vbi device\n",
-                      dev->name);
-               goto fail3;
+               printk(KERN_INFO "%s/0: can't register vbi device\n",
+                      core->name);
+               goto fail_unreg;
        }
-       printk(KERN_INFO "%s: registered device vbi%d\n",
-              dev->name,dev->vbi_dev->minor & 0x1f);
+       printk(KERN_INFO "%s/0: registered device vbi%d\n",
+              core->name,dev->vbi_dev->minor & 0x1f);
 
-       if (dev->has_radio) {
-               OOPS("register radio");
-               dev->radio_dev = vdev_init(dev,&cx8800_radio_template,"radio");
+       if (core->has_radio) {
+               dev->radio_dev = cx88_vdev_init(core,dev->pci,
+                                               &cx8800_radio_template,"radio");
                err = video_register_device(dev->radio_dev,VFL_TYPE_RADIO,
-                                           radio_nr[cx8800_devcount]);
+                                           radio_nr[core->nr]);
                if (err < 0) {
-                       printk(KERN_INFO "%s: can't register radio device\n",
-                              dev->name);
-                       goto fail3;
+                       printk(KERN_INFO "%s/0: can't register radio device\n",
+                              core->name);
+                       goto fail_unreg;
                }
-               printk(KERN_INFO "%s: registered device radio%d\n",
-                      dev->name,dev->radio_dev->minor & 0x1f);
+               printk(KERN_INFO "%s/0: registered device radio%d\n",
+                      core->name,dev->radio_dev->minor & 0x1f);
        }
 
        /* everything worked */
-       OOPS("finalize");
        list_add_tail(&dev->devlist,&cx8800_devlist);
        pci_set_drvdata(pci_dev,dev);
-       cx8800_devcount++;
 
        /* initial device configuration */
-       OOPS("init device");
-       down(&dev->lock);
-       init_controls(dev);
-       set_tvnorm(dev,tvnorms);
-       video_mux(dev,0);
-       up(&dev->lock);
+       mutex_lock(&core->lock);
+       cx88_set_tvnorm(core,tvnorms);
+       init_controls(core);
+       video_mux(core,0);
+       mutex_unlock(&core->lock);
+
+       /* start tvaudio thread */
+       if (core->tuner_type != TUNER_ABSENT)
+               core->kthread = kthread_run(cx88_audio_thread, core, "cx88 tvaudio");
        return 0;
 
- fail3:
-       OOPS("fail3");
+fail_unreg:
        cx8800_unregister_video(dev);
-       if (0 == dev->i2c_rc)
-               i2c_bit_del_bus(&dev->i2c_adap);
        free_irq(pci_dev->irq, dev);
- fail2:
-       OOPS("fail2");
-       release_mem_region(pci_resource_start(pci_dev,0),
-                          pci_resource_len(pci_dev,0));
- fail1:
-       OOPS("fail1");
+fail_core:
+       cx88_core_put(core,dev->pci);
+fail_free:
        kfree(dev);
        return err;
 }
 
 static void __devexit cx8800_finidev(struct pci_dev *pci_dev)
 {
-        struct cx8800_dev *dev = pci_get_drvdata(pci_dev);
+       struct cx8800_dev *dev = pci_get_drvdata(pci_dev);
+       struct cx88_core *core = dev->core;
+
+       /* stop thread */
+       if (core->kthread) {
+               kthread_stop(core->kthread);
+               core->kthread = NULL;
+       }
 
-       cx8800_shutdown(dev);
+       cx88_shutdown(core); /* FIXME */
        pci_disable_device(pci_dev);
 
-       /* unregister stuff */  
-       if (0 == dev->i2c_rc)
-               i2c_bit_del_bus(&dev->i2c_adap);
+       /* unregister stuff */
 
        free_irq(pci_dev->irq, dev);
-       release_mem_region(pci_resource_start(pci_dev,0),
-                          pci_resource_len(pci_dev,0));
-
        cx8800_unregister_video(dev);
        pci_set_drvdata(pci_dev, NULL);
 
        /* free memory */
        btcx_riscmem_free(dev->pci,&dev->vidq.stopper);
        list_del(&dev->devlist);
-       cx8800_devcount--;
+       cx88_core_put(core,dev->pci);
        kfree(dev);
 }
 
-static int cx8800_suspend(struct pci_dev *pci_dev, u32 state)
+#ifdef CONFIG_PM
+static int cx8800_suspend(struct pci_dev *pci_dev, pm_message_t state)
 {
-        struct cx8800_dev *dev = pci_get_drvdata(pci_dev);
+       struct cx8800_dev *dev = pci_get_drvdata(pci_dev);
+       struct cx88_core *core = dev->core;
+
+       /* stop video+vbi capture */
+       spin_lock(&dev->slock);
+       if (!list_empty(&dev->vidq.active)) {
+               printk("%s: suspend video\n", core->name);
+               stop_video_dma(dev);
+               del_timer(&dev->vidq.timeout);
+       }
+       if (!list_empty(&dev->vbiq.active)) {
+               printk("%s: suspend vbi\n", core->name);
+               cx8800_stop_vbi_dma(dev);
+               del_timer(&dev->vbiq.timeout);
+       }
+       spin_unlock(&dev->slock);
 
-       printk("%s: suspend %d\n", dev->name, state);
+       /* FIXME -- shutdown device */
+       cx88_shutdown(core);
 
-       cx8800_shutdown(dev);
-       del_timer(&dev->vidq.timeout);
-       
-       pci_save_state(pci_dev, dev->state.pci_cfg);
-       if (0 != pci_set_power_state(pci_dev, state)) {
+       pci_save_state(pci_dev);
+       if (0 != pci_set_power_state(pci_dev, pci_choose_state(pci_dev, state))) {
                pci_disable_device(pci_dev);
                dev->state.disabled = 1;
        }
@@ -2532,36 +2087,59 @@ static int cx8800_suspend(struct pci_dev *pci_dev, u32 state)
 
 static int cx8800_resume(struct pci_dev *pci_dev)
 {
-        struct cx8800_dev *dev = pci_get_drvdata(pci_dev);
-
-       printk("%s: resume\n", dev->name);
+       struct cx8800_dev *dev = pci_get_drvdata(pci_dev);
+       struct cx88_core *core = dev->core;
+       int err;
 
        if (dev->state.disabled) {
-               pci_enable_device(pci_dev);
+               err=pci_enable_device(pci_dev);
+               if (err) {
+                       printk(KERN_ERR "%s: can't enable device\n",
+                                                      core->name);
+                       return err;
+               }
+
                dev->state.disabled = 0;
        }
-       pci_set_power_state(pci_dev, 0);
-       pci_restore_state(pci_dev, dev->state.pci_cfg);
+       err= pci_set_power_state(pci_dev, PCI_D0);
+       if (err) {
+               printk(KERN_ERR "%s: can't enable device\n",
+                                      core->name);
+
+               pci_disable_device(pci_dev);
+               dev->state.disabled = 1;
+
+               return err;
+       }
+       pci_restore_state(pci_dev);
 
-       /* re-initialize hardware */
-       cx8800_reset(dev);
+       /* FIXME: re-initialize hardware */
+       cx88_reset(core);
 
-       /* restart video capture */
+       /* restart video+vbi capture */
        spin_lock(&dev->slock);
-       restart_video_queue(dev,&dev->vidq);
+       if (!list_empty(&dev->vidq.active)) {
+               printk("%s: resume video\n", core->name);
+               restart_video_queue(dev,&dev->vidq);
+       }
+       if (!list_empty(&dev->vbiq.active)) {
+               printk("%s: resume vbi\n", core->name);
+               cx8800_restart_vbi_queue(dev,&dev->vbiq);
+       }
        spin_unlock(&dev->slock);
 
        return 0;
 }
+#endif
 
 /* ----------------------------------------------------------- */
 
-struct pci_device_id cx8800_pci_tbl[] = {
+static struct pci_device_id cx8800_pci_tbl[] = {
        {
                .vendor       = 0x14f1,
                .device       = 0x8800,
-                .subvendor    = PCI_ANY_ID,
-                .subdevice    = PCI_ANY_ID,
+               .subvendor    = PCI_ANY_ID,
+               .subdevice    = PCI_ANY_ID,
        },{
                /* --- end of list --- */
        }
@@ -2569,18 +2147,18 @@ struct pci_device_id cx8800_pci_tbl[] = {
 MODULE_DEVICE_TABLE(pci, cx8800_pci_tbl);
 
 static struct pci_driver cx8800_pci_driver = {
-        .name     = "cx8800",
-        .id_table = cx8800_pci_tbl,
-        .probe    = cx8800_initdev,
-        .remove   = cx8800_finidev,
-
+       .name     = "cx8800",
+       .id_table = cx8800_pci_tbl,
+       .probe    = cx8800_initdev,
+       .remove   = __devexit_p(cx8800_finidev),
+#ifdef CONFIG_PM
        .suspend  = cx8800_suspend,
        .resume   = cx8800_resume,
+#endif
 };
 
 static int cx8800_init(void)
 {
-       INIT_LIST_HEAD(&cx8800_devlist);
        printk(KERN_INFO "cx2388x v4l2 driver version %d.%d.%d loaded\n",
               (CX88_VERSION_CODE >> 16) & 0xff,
               (CX88_VERSION_CODE >>  8) & 0xff,
@@ -2589,7 +2167,7 @@ static int cx8800_init(void)
        printk(KERN_INFO "cx2388x: snapshot date %04d-%02d-%02d\n",
               SNAPSHOT/10000, (SNAPSHOT/100)%100, SNAPSHOT%100);
 #endif
-       return pci_module_init(&cx8800_pci_driver);
+       return pci_register_driver(&cx8800_pci_driver);
 }
 
 static void cx8800_fini(void)
@@ -2600,9 +2178,12 @@ static void cx8800_fini(void)
 module_init(cx8800_init);
 module_exit(cx8800_fini);
 
+EXPORT_SYMBOL(cx88_do_ioctl);
+
 /* ----------------------------------------------------------- */
 /*
  * Local variables:
  * c-basic-offset: 8
  * End:
+ * kate: eol "unix"; indent-width 3; remove-trailing-space on; replace-trailing-space-save on; tab-width 8; replace-tabs off; space-indent off; mixed-indent off
  */