Fedora kernel-2.6.17-1.2142_FC4 patched with stable patch-2.6.17.4-vs2.0.2-rc26.diff
[linux-2.6.git] / drivers / media / video / video-buf.c
index f541a06..acc5ea9 100644 (file)
@@ -1,14 +1,20 @@
 /*
+ *
  * generic helper functions for video4linux capture buffers, to handle
- * memory management and PCI DMA.  Right now bttv + saa7134 use it.
+ * memory management and PCI DMA.
+ * Right now, bttv, saa7134, saa7146 and cx88 use it.
  *
  * The functions expect the hardware being able to scatter gatter
  * (i.e. the buffers are not linear in physical memory, but fragmented
  * into PAGE_SIZE chunks).  They also assume the driver does not need
- * to touch the video data (thus it is probably not useful for USB as
- * data often must be uncompressed by the drivers).
- * 
- * (c) 2001,02 Gerd Knorr <kraxel@bytesex.org>
+ * to touch the video data.
+ *
+ * device specific map/unmap/sync stuff now are mapped as operations
+ * to allow its usage by USB and virtual devices.
+ *
+ * (c) 2001-2004 Gerd Knorr <kraxel@bytesex.org> [SUSE Labs]
+ * (c) 2006 Mauro Carvalho Chehab <mchehab@infradead.org>
+ * (c) 2006 Ted Walther and John Sokol
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -18,6 +24,7 @@
 
 #include <linux/init.h>
 #include <linux/module.h>
+#include <linux/moduleparam.h>
 #include <linux/vmalloc.h>
 #include <linux/pagemap.h>
 #include <linux/slab.h>
 
 #include <media/video-buf.h>
 
+#define MAGIC_DMABUF 0x19721112
+#define MAGIC_BUFFER 0x20040302
+#define MAGIC_CHECK(is,should) if (unlikely((is) != (should))) \
+       { printk(KERN_ERR "magic mismatch: %x (expected %x)\n",is,should); BUG(); }
+
 static int debug = 0;
+module_param(debug, int, 0644);
 
 MODULE_DESCRIPTION("helper module to manage video4linux pci dma buffers");
 MODULE_AUTHOR("Gerd Knorr <kraxel@bytesex.org> [SuSE Labs]");
 MODULE_LICENSE("GPL");
-MODULE_PARM(debug,"i");
 
 #define dprintk(level, fmt, arg...)    if (debug >= level) \
        printk(KERN_DEBUG "vbuf: " fmt , ## arg)
@@ -45,21 +57,19 @@ videobuf_vmalloc_to_sg(unsigned char *virt, int nr_pages)
        struct page *pg;
        int i;
 
-       sglist = kmalloc(sizeof(struct scatterlist)*nr_pages, GFP_KERNEL);
+       sglist = kcalloc(nr_pages, sizeof(struct scatterlist), GFP_KERNEL);
        if (NULL == sglist)
                return NULL;
-       memset(sglist,0,sizeof(struct scatterlist)*nr_pages);
        for (i = 0; i < nr_pages; i++, virt += PAGE_SIZE) {
                pg = vmalloc_to_page(virt);
                if (NULL == pg)
                        goto err;
-               if (PageHighMem(pg))
-                       BUG();
+               BUG_ON(PageHighMem(pg));
                sglist[i].page   = pg;
                sglist[i].length = PAGE_SIZE;
        }
        return sglist;
-       
+
  err:
        kfree(sglist);
        return NULL;
@@ -73,10 +83,9 @@ videobuf_pages_to_sg(struct page **pages, int nr_pages, int offset)
 
        if (NULL == pages[0])
                return NULL;
-       sglist = kmalloc(sizeof(*sglist) * nr_pages, GFP_KERNEL);
+       sglist = kcalloc(nr_pages, sizeof(*sglist), GFP_KERNEL);
        if (NULL == sglist)
                return NULL;
-       memset(sglist, 0, sizeof(*sglist) * nr_pages);
 
        if (NULL == pages[0])
                goto nopage;
@@ -109,6 +118,12 @@ videobuf_pages_to_sg(struct page **pages, int nr_pages, int offset)
 
 /* --------------------------------------------------------------------- */
 
+void videobuf_dma_init(struct videobuf_dmabuf *dma)
+{
+       memset(dma,0,sizeof(*dma));
+       dma->magic = MAGIC_DMABUF;
+}
+
 int videobuf_dma_init_user(struct videobuf_dmabuf *dma, int direction,
                           unsigned long data, unsigned long size)
 {
@@ -134,7 +149,7 @@ int videobuf_dma_init_user(struct videobuf_dmabuf *dma, int direction,
                data,size,dma->nr_pages);
 
        down_read(&current->mm->mmap_sem);
-        err = get_user_pages(current,current->mm,
+       err = get_user_pages(current,current->mm,
                             data & PAGE_MASK, dma->nr_pages,
                             rw == READ, 1, /* force */
                             dma->pages, NULL);
@@ -157,6 +172,9 @@ int videobuf_dma_init_kernel(struct videobuf_dmabuf *dma, int direction,
                dprintk(1,"vmalloc_32(%d pages) failed\n",nr_pages);
                return -ENOMEM;
        }
+       dprintk(1,"vmalloc is at addr 0x%08lx, size=%d\n",
+                               (unsigned long)dma->vmalloc,
+                               nr_pages << PAGE_SHIFT);
        memset(dma->vmalloc,0,nr_pages << PAGE_SHIFT);
        dma->nr_pages = nr_pages;
        return 0;
@@ -176,18 +194,20 @@ int videobuf_dma_init_overlay(struct videobuf_dmabuf *dma, int direction,
        return 0;
 }
 
-int videobuf_dma_pci_map(struct pci_dev *dev, struct videobuf_dmabuf *dma)
+int videobuf_dma_map(struct videobuf_queue* q,struct videobuf_dmabuf *dma)
 {
-       if (0 == dma->nr_pages)
-               BUG();
-       
+       void                   *dev=q->dev;
+
+       MAGIC_CHECK(dma->magic,MAGIC_DMABUF);
+       BUG_ON(0 == dma->nr_pages);
+
        if (dma->pages) {
                dma->sglist = videobuf_pages_to_sg(dma->pages, dma->nr_pages,
                                                   dma->offset);
        }
        if (dma->vmalloc) {
                dma->sglist = videobuf_vmalloc_to_sg
-                       (dma->vmalloc,dma->nr_pages);
+                                               (dma->vmalloc,dma->nr_pages);
        }
        if (dma->bus_addr) {
                dma->sglist = kmalloc(sizeof(struct scatterlist), GFP_KERNEL);
@@ -202,30 +222,48 @@ int videobuf_dma_pci_map(struct pci_dev *dev, struct videobuf_dmabuf *dma)
                dprintk(1,"scatterlist is NULL\n");
                return -ENOMEM;
        }
-
-       if (!dma->bus_addr)
-               dma->sglen = pci_map_sg(dev,dma->sglist,dma->nr_pages,
-                                       dma->direction);
+       if (!dma->bus_addr) {
+               if (q->ops->vb_map_sg) {
+                       dma->sglen = q->ops->vb_map_sg(dev,dma->sglist,
+                                       dma->nr_pages, dma->direction);
+               }
+               if (0 == dma->sglen) {
+                       printk(KERN_WARNING
+                              "%s: videobuf_map_sg failed\n",__FUNCTION__);
+                       kfree(dma->sglist);
+                       dma->sglist = NULL;
+                       dma->sglen = 0;
+                       return -EIO;
+               }
+       }
        return 0;
 }
 
-int videobuf_dma_pci_sync(struct pci_dev *dev, struct videobuf_dmabuf *dma)
+int videobuf_dma_sync(struct videobuf_queue* q,struct videobuf_dmabuf *dma)
 {
-       if (!dma->sglen)
-               BUG();
+       void                   *dev=q->dev;
+
+       MAGIC_CHECK(dma->magic,MAGIC_DMABUF);
+       BUG_ON(!dma->sglen);
+
+       if (!dma->bus_addr && q->ops->vb_dma_sync_sg)
+               q->ops->vb_dma_sync_sg(dev,dma->sglist,dma->nr_pages,
+                                                       dma->direction);
 
-       if (!dma->bus_addr)
-               pci_dma_sync_sg_for_cpu(dev,dma->sglist,dma->nr_pages,dma->direction);
        return 0;
 }
 
-int videobuf_dma_pci_unmap(struct pci_dev *dev, struct videobuf_dmabuf *dma)
+int videobuf_dma_unmap(struct videobuf_queue* q,struct videobuf_dmabuf *dma)
 {
+       void                   *dev=q->dev;
+
+       MAGIC_CHECK(dma->magic,MAGIC_DMABUF);
        if (!dma->sglen)
                return 0;
 
-       if (!dma->bus_addr)
-               pci_unmap_sg(dev,dma->sglist,dma->nr_pages,dma->direction);
+       if (!dma->bus_addr && q->ops->vb_unmap_sg)
+                       q->ops->vb_unmap_sg(dev,dma->sglist,dma->nr_pages,
+                                                       dma->direction);
        kfree(dma->sglist);
        dma->sglist = NULL;
        dma->sglen = 0;
@@ -234,8 +272,8 @@ int videobuf_dma_pci_unmap(struct pci_dev *dev, struct videobuf_dmabuf *dma)
 
 int videobuf_dma_free(struct videobuf_dmabuf *dma)
 {
-       if (dma->sglen)
-               BUG();
+       MAGIC_CHECK(dma->magic,MAGIC_DMABUF);
+       BUG_ON(dma->sglen);
 
        if (dma->pages) {
                int i;
@@ -244,10 +282,10 @@ int videobuf_dma_free(struct videobuf_dmabuf *dma)
                kfree(dma->pages);
                dma->pages = NULL;
        }
-       if (dma->vmalloc) {
-               vfree(dma->vmalloc);
-               dma->vmalloc = NULL;
-       }
+
+       vfree(dma->vmalloc);
+       dma->vmalloc = NULL;
+
        if (dma->bus_addr) {
                dma->bus_addr = 0;
        }
@@ -261,10 +299,11 @@ void* videobuf_alloc(unsigned int size)
 {
        struct videobuf_buffer *vb;
 
-       vb = kmalloc(size,GFP_KERNEL);
+       vb = kzalloc(size,GFP_KERNEL);
        if (NULL != vb) {
-               memset(vb,0,size);
+               videobuf_dma_init(&vb->dma);
                init_waitqueue_head(&vb->done);
+               vb->magic     = MAGIC_BUFFER;
        }
        return vb;
 }
@@ -273,7 +312,8 @@ int videobuf_waiton(struct videobuf_buffer *vb, int non_blocking, int intr)
 {
        int retval = 0;
        DECLARE_WAITQUEUE(wait, current);
-       
+
+       MAGIC_CHECK(vb->magic,MAGIC_BUFFER);
        add_wait_queue(&vb->done, &wait);
        while (vb->state == STATE_ACTIVE || vb->state == STATE_QUEUED) {
                if (non_blocking) {
@@ -296,12 +336,13 @@ int videobuf_waiton(struct videobuf_buffer *vb, int non_blocking, int intr)
 }
 
 int
-videobuf_iolock(struct pci_dev *pci, struct videobuf_buffer *vb,
+videobuf_iolock(struct videobuf_queue* q, struct videobuf_buffer *vb,
                struct v4l2_framebuffer *fbuf)
 {
        int err,pages;
        dma_addr_t bus;
 
+       MAGIC_CHECK(vb->magic,MAGIC_BUFFER);
        switch (vb->memory) {
        case V4L2_MEMORY_MMAP:
        case V4L2_MEMORY_USERPTR:
@@ -334,42 +375,82 @@ videobuf_iolock(struct pci_dev *pci, struct videobuf_buffer *vb,
        default:
                BUG();
        }
-       err = videobuf_dma_pci_map(pci,&vb->dma);
+       err = videobuf_dma_map(q,&vb->dma);
        if (0 != err)
                return err;
-               
+
        return 0;
 }
 
 /* --------------------------------------------------------------------- */
 
-void
-videobuf_queue_init(struct videobuf_queue *q,
-                   struct videobuf_queue_ops *ops,
-                   struct pci_dev *pci,
-                   spinlock_t *irqlock,
-                   enum v4l2_buf_type type,
-                   enum v4l2_field field,
-                   unsigned int msize)
+void videobuf_queue_pci(struct videobuf_queue* q)
 {
-       memset(q,0,sizeof(*q));
+       /* If not specified, defaults to PCI map sg */
+       if (!q->ops->vb_map_sg)
+               q->ops->vb_map_sg=(vb_map_sg_t *)pci_map_sg;
+
+       if (!q->ops->vb_dma_sync_sg)
+               q->ops->vb_dma_sync_sg=(vb_map_sg_t *)pci_dma_sync_sg_for_cpu;
+       if (!q->ops->vb_unmap_sg)
+               q->ops->vb_unmap_sg=(vb_map_sg_t *)pci_unmap_sg;
+}
 
+int videobuf_pci_dma_map(struct pci_dev *pci,struct videobuf_dmabuf *dma)
+{
+       struct videobuf_queue q;
+       struct videobuf_queue_ops qops;
+
+       q.dev=pci;
+       qops.vb_map_sg=(vb_map_sg_t *)pci_map_sg;
+       qops.vb_unmap_sg=(vb_map_sg_t *)pci_unmap_sg;
+       q.ops = &qops;
+
+       return (videobuf_dma_map(&q,dma));
+}
+
+int videobuf_pci_dma_unmap(struct pci_dev *pci,struct videobuf_dmabuf *dma)
+{
+       struct videobuf_queue q;
+       struct videobuf_queue_ops qops;
+
+       q.dev=pci;
+       qops.vb_map_sg=(vb_map_sg_t *)pci_map_sg;
+       qops.vb_unmap_sg=(vb_map_sg_t *)pci_unmap_sg;
+       q.ops = &qops;
+
+       return (videobuf_dma_unmap(&q,dma));
+}
+
+void videobuf_queue_init(struct videobuf_queue* q,
+                        struct videobuf_queue_ops *ops,
+                        void *dev,
+                        spinlock_t *irqlock,
+                        enum v4l2_buf_type type,
+                        enum v4l2_field field,
+                        unsigned int msize,
+                        void *priv)
+{
+       memset(q,0,sizeof(*q));
        q->irqlock = irqlock;
-       q->pci     = pci;
+       q->dev     = dev;
        q->type    = type;
        q->field   = field;
        q->msize   = msize;
        q->ops     = ops;
+       q->priv_data = priv;
 
-       init_MUTEX(&q->lock);
+       videobuf_queue_pci(q);
+
+       mutex_init(&q->lock);
        INIT_LIST_HEAD(&q->stream);
 }
 
-int 
+int
 videobuf_queue_is_busy(struct videobuf_queue *q)
 {
        int i;
-       
+
        if (q->streaming) {
                dprintk(1,"busy: streaming active\n");
                return 1;
@@ -402,13 +483,14 @@ videobuf_queue_is_busy(struct videobuf_queue *q)
 }
 
 void
-videobuf_queue_cancel(struct file *file, struct videobuf_queue *q)
+videobuf_queue_cancel(struct videobuf_queue *q)
 {
-       unsigned long flags;
+       unsigned long flags=0;
        int i;
 
        /* remove queued buffers from list */
-       spin_lock_irqsave(q->irqlock,flags);
+       if (q->irqlock)
+               spin_lock_irqsave(q->irqlock,flags);
        for (i = 0; i < VIDEO_MAX_FRAME; i++) {
                if (NULL == q->bufs[i])
                        continue;
@@ -417,13 +499,14 @@ videobuf_queue_cancel(struct file *file, struct videobuf_queue *q)
                        q->bufs[i]->state = STATE_ERROR;
                }
        }
-       spin_unlock_irqrestore(q->irqlock,flags);
+       if (q->irqlock)
+               spin_unlock_irqrestore(q->irqlock,flags);
 
        /* free all buffers + clear queue */
        for (i = 0; i < VIDEO_MAX_FRAME; i++) {
                if (NULL == q->bufs[i])
                        continue;
-               q->ops->buf_release(file,q->bufs[i]);
+               q->ops->buf_release(q,q->bufs[i]);
        }
        INIT_LIST_HEAD(&q->stream);
 }
@@ -453,6 +536,8 @@ void
 videobuf_status(struct v4l2_buffer *b, struct videobuf_buffer *vb,
                enum v4l2_buf_type type)
 {
+       MAGIC_CHECK(vb->magic,MAGIC_BUFFER);
+
        b->index    = vb->i;
        b->type     = type;
 
@@ -491,6 +576,11 @@ videobuf_status(struct v4l2_buffer *b, struct videobuf_buffer *vb,
                break;
        }
 
+       if (vb->input != UNSET) {
+               b->flags |= V4L2_BUF_FLAG_INPUT;
+               b->input  = vb->input;
+       }
+
        b->field     = vb->field;
        b->timestamp = vb->ts;
        b->bytesused = vb->size;
@@ -498,146 +588,218 @@ videobuf_status(struct v4l2_buffer *b, struct videobuf_buffer *vb,
 }
 
 int
-videobuf_reqbufs(struct file *file, struct videobuf_queue *q,
+videobuf_reqbufs(struct videobuf_queue *q,
                 struct v4l2_requestbuffers *req)
 {
        unsigned int size,count;
        int retval;
 
-       if (req->type != q->type)
+       if (req->type != q->type) {
+               dprintk(1,"reqbufs: queue type invalid\n");
                return -EINVAL;
-       if (req->count < 1)
+       }
+       if (req->count < 1) {
+               dprintk(1,"reqbufs: count invalid (%d)\n",req->count);
                return -EINVAL;
+       }
        if (req->memory != V4L2_MEMORY_MMAP     &&
            req->memory != V4L2_MEMORY_USERPTR  &&
-           req->memory != V4L2_MEMORY_OVERLAY)
+           req->memory != V4L2_MEMORY_OVERLAY) {
+               dprintk(1,"reqbufs: memory type invalid\n");
                return -EINVAL;
+       }
 
-       down(&q->lock);
+       if (q->streaming) {
+               dprintk(1,"reqbufs: streaming already exists\n");
+               return -EBUSY;
+       }
+       if (!list_empty(&q->stream)) {
+               dprintk(1,"reqbufs: stream running\n");
+               return -EBUSY;
+       }
+
+       mutex_lock(&q->lock);
        count = req->count;
        if (count > VIDEO_MAX_FRAME)
                count = VIDEO_MAX_FRAME;
        size = 0;
-       q->ops->buf_setup(file,&count,&size);
+       q->ops->buf_setup(q,&count,&size);
        size = PAGE_ALIGN(size);
        dprintk(1,"reqbufs: bufs=%d, size=0x%x [%d pages total]\n",
                count, size, (count*size)>>PAGE_SHIFT);
 
-       retval = videobuf_mmap_setup(file,q,count,size,req->memory);
-       if (retval < 0)
+       retval = videobuf_mmap_setup(q,count,size,req->memory);
+       if (retval < 0) {
+               dprintk(1,"reqbufs: mmap setup returned %d\n",retval);
                goto done;
+       }
 
        req->count = count;
 
  done:
-       up(&q->lock);
+       mutex_unlock(&q->lock);
        return retval;
 }
 
 int
 videobuf_querybuf(struct videobuf_queue *q, struct v4l2_buffer *b)
 {
-       if (unlikely(b->type != q->type))
+       if (unlikely(b->type != q->type)) {
+               dprintk(1,"querybuf: Wrong type.\n");
                return -EINVAL;
-       if (unlikely(b->index < 0 || b->index >= VIDEO_MAX_FRAME))
+       }
+       if (unlikely(b->index < 0 || b->index >= VIDEO_MAX_FRAME)) {
+               dprintk(1,"querybuf: index out of range.\n");
                return -EINVAL;
-       if (unlikely(NULL == q->bufs[b->index]))
+       }
+       if (unlikely(NULL == q->bufs[b->index])) {
+               dprintk(1,"querybuf: buffer is null.\n");
                return -EINVAL;
+       }
        videobuf_status(b,q->bufs[b->index],q->type);
        return 0;
 }
 
 int
-videobuf_qbuf(struct file *file, struct videobuf_queue *q,
+videobuf_qbuf(struct videobuf_queue *q,
              struct v4l2_buffer *b)
 {
        struct videobuf_buffer *buf;
        enum v4l2_field field;
-       unsigned long flags;
+       unsigned long flags=0;
        int retval;
 
-       down(&q->lock);
+       mutex_lock(&q->lock);
        retval = -EBUSY;
-       if (q->reading)
+       if (q->reading) {
+               dprintk(1,"qbuf: Reading running...\n");
                goto done;
+       }
        retval = -EINVAL;
-       if (b->type != q->type)
+       if (b->type != q->type) {
+               dprintk(1,"qbuf: Wrong type.\n");
                goto done;
-       if (b->index < 0 || b->index >= VIDEO_MAX_FRAME)
+       }
+       if (b->index < 0 || b->index >= VIDEO_MAX_FRAME) {
+               dprintk(1,"qbuf: index out of range.\n");
                goto done;
+       }
        buf = q->bufs[b->index];
-       if (NULL == buf)
+       if (NULL == buf) {
+               dprintk(1,"qbuf: buffer is null.\n");
                goto done;
-       if (buf->memory != b->memory)
+       }
+       MAGIC_CHECK(buf->magic,MAGIC_BUFFER);
+       if (buf->memory != b->memory) {
+               dprintk(1,"qbuf: memory type is wrong.\n");
                goto done;
+       }
        if (buf->state == STATE_QUEUED ||
-           buf->state == STATE_ACTIVE)
+           buf->state == STATE_ACTIVE) {
+               dprintk(1,"qbuf: buffer is already queued or active.\n");
                goto done;
+       }
+
+       if (b->flags & V4L2_BUF_FLAG_INPUT) {
+               if (b->input >= q->inputs) {
+                       dprintk(1,"qbuf: wrong input.\n");
+                       goto done;
+               }
+               buf->input = b->input;
+       } else {
+               buf->input = UNSET;
+       }
 
        switch (b->memory) {
        case V4L2_MEMORY_MMAP:
-               if (0 == buf->baddr)
+               if (0 == buf->baddr) {
+                       dprintk(1,"qbuf: mmap requested but buffer addr is zero!\n");
                        goto done;
+               }
                break;
        case V4L2_MEMORY_USERPTR:
-               if (b->length < buf->bsize)
+               if (b->length < buf->bsize) {
+                       dprintk(1,"qbuf: buffer length is not enough\n");
                        goto done;
+               }
+               if (STATE_NEEDS_INIT != buf->state && buf->baddr != b->m.userptr)
+                       q->ops->buf_release(q,buf);
                buf->baddr = b->m.userptr;
                break;
        case V4L2_MEMORY_OVERLAY:
                buf->boff = b->m.offset;
                break;
        default:
+               dprintk(1,"qbuf: wrong memory type\n");
                goto done;
        }
 
+       dprintk(1,"qbuf: requesting next field\n");
        field = videobuf_next_field(q);
-       retval = q->ops->buf_prepare(file,buf,field);
-       if (0 != retval)
+       retval = q->ops->buf_prepare(q,buf,field);
+       if (0 != retval) {
+               dprintk(1,"qbuf: buffer_prepare returned %d\n",retval);
                goto done;
-       
+       }
+
        list_add_tail(&buf->stream,&q->stream);
        if (q->streaming) {
-               spin_lock_irqsave(q->irqlock,flags);
-               q->ops->buf_queue(file,buf);
-               spin_unlock_irqrestore(q->irqlock,flags);
+               if (q->irqlock)
+                       spin_lock_irqsave(q->irqlock,flags);
+               q->ops->buf_queue(q,buf);
+               if (q->irqlock)
+                       spin_unlock_irqrestore(q->irqlock,flags);
        }
+       dprintk(1,"qbuf: succeded\n");
        retval = 0;
-       
+
  done:
-       up(&q->lock);
+       mutex_unlock(&q->lock);
        return retval;
 }
 
 int
-videobuf_dqbuf(struct file *file, struct videobuf_queue *q,
-              struct v4l2_buffer *b)
+videobuf_dqbuf(struct videobuf_queue *q,
+              struct v4l2_buffer *b, int nonblocking)
 {
        struct videobuf_buffer *buf;
        int retval;
-       
-       down(&q->lock);
+
+       mutex_lock(&q->lock);
        retval = -EBUSY;
-       if (q->reading)
+       if (q->reading) {
+               dprintk(1,"dqbuf: Reading running...\n");
                goto done;
+       }
        retval = -EINVAL;
-       if (b->type != q->type)
+       if (b->type != q->type) {
+               dprintk(1,"dqbuf: Wrong type.\n");
                goto done;
-       if (list_empty(&q->stream))
+       }
+       if (list_empty(&q->stream)) {
+               dprintk(1,"dqbuf: stream running\n");
                goto done;
+       }
        buf = list_entry(q->stream.next, struct videobuf_buffer, stream);
-       retval = videobuf_waiton(buf, file->f_flags & O_NONBLOCK, 1);
-       if (retval < 0)
+       retval = videobuf_waiton(buf, nonblocking, 1);
+       if (retval < 0) {
+               dprintk(1,"dqbuf: waiton returned %d\n",retval);
                goto done;
+       }
        switch (buf->state) {
        case STATE_ERROR:
+               dprintk(1,"dqbuf: state is error\n");
                retval = -EIO;
-               /* fall through */
+               videobuf_dma_sync(q,&buf->dma);
+               buf->state = STATE_IDLE;
+               break;
        case STATE_DONE:
-               videobuf_dma_pci_sync(q->pci,&buf->dma);
+               dprintk(1,"dqbuf: state is done\n");
+               videobuf_dma_sync(q,&buf->dma);
                buf->state = STATE_IDLE;
                break;
        default:
+               dprintk(1,"dqbuf: state invalid\n");
                retval = -EINVAL;
                goto done;
        }
@@ -646,18 +808,18 @@ videobuf_dqbuf(struct file *file, struct videobuf_queue *q,
        videobuf_status(b,buf,q->type);
 
  done:
-       up(&q->lock);
+       mutex_unlock(&q->lock);
        return retval;
 }
 
-int videobuf_streamon(struct file *file, struct videobuf_queue *q)
+int videobuf_streamon(struct videobuf_queue *q)
 {
        struct videobuf_buffer *buf;
        struct list_head *list;
-       unsigned long flags;
+       unsigned long flags=0;
        int retval;
-       
-       down(&q->lock);
+
+       mutex_lock(&q->lock);
        retval = -EBUSY;
        if (q->reading)
                goto done;
@@ -665,64 +827,67 @@ int videobuf_streamon(struct file *file, struct videobuf_queue *q)
        if (q->streaming)
                goto done;
        q->streaming = 1;
-       spin_lock_irqsave(q->irqlock,flags);
+       if (q->irqlock)
+               spin_lock_irqsave(q->irqlock,flags);
        list_for_each(list,&q->stream) {
                buf = list_entry(list, struct videobuf_buffer, stream);
                if (buf->state == STATE_PREPARED)
-                       q->ops->buf_queue(file,buf);
+                       q->ops->buf_queue(q,buf);
        }
-       spin_unlock_irqrestore(q->irqlock,flags);
+       if (q->irqlock)
+               spin_unlock_irqrestore(q->irqlock,flags);
 
  done:
-       up(&q->lock);
+       mutex_unlock(&q->lock);
        return retval;
 }
 
-int videobuf_streamoff(struct file *file, struct videobuf_queue *q)
+int videobuf_streamoff(struct videobuf_queue *q)
 {
        int retval = -EINVAL;
 
-       down(&q->lock);
+       mutex_lock(&q->lock);
        if (!q->streaming)
                goto done;
-       videobuf_queue_cancel(file,q);
+       videobuf_queue_cancel(q);
        q->streaming = 0;
        retval = 0;
 
  done:
-       up(&q->lock);
+       mutex_unlock(&q->lock);
        return retval;
 }
 
 static ssize_t
-videobuf_read_zerocopy(struct file *file, struct videobuf_queue *q,
-                      char *data, size_t count, loff_t *ppos)
+videobuf_read_zerocopy(struct videobuf_queue *q, char __user *data,
+                      size_t count, loff_t *ppos)
 {
        enum v4l2_field field;
-       unsigned long flags;
-        int retval;
+       unsigned long flags=0;
+       int retval;
 
-        /* setup stuff */
-       retval = -ENOMEM;
+       /* setup stuff */
        q->read_buf = videobuf_alloc(q->msize);
        if (NULL == q->read_buf)
-               goto done;
+               return -ENOMEM;
 
        q->read_buf->memory = V4L2_MEMORY_USERPTR;
        q->read_buf->baddr  = (unsigned long)data;
-        q->read_buf->bsize  = count;
+       q->read_buf->bsize  = count;
        field = videobuf_next_field(q);
-       retval = q->ops->buf_prepare(file,q->read_buf,field);
+       retval = q->ops->buf_prepare(q,q->read_buf,field);
        if (0 != retval)
                goto done;
-       
-        /* start capture & wait */
-       spin_lock_irqsave(q->irqlock,flags);
-       q->ops->buf_queue(file,q->read_buf);
-       spin_unlock_irqrestore(q->irqlock,flags);
-        retval = videobuf_waiton(q->read_buf,0,0);
-        if (0 == retval) {
-               videobuf_dma_pci_sync(q->pci,&q->read_buf->dma);
+
+       /* start capture & wait */
+       if (q->irqlock)
+               spin_lock_irqsave(q->irqlock,flags);
+       q->ops->buf_queue(q,q->read_buf);
+       if (q->irqlock)
+               spin_unlock_irqrestore(q->irqlock,flags);
+       retval = videobuf_waiton(q->read_buf,0,0);
+       if (0 == retval) {
+               videobuf_dma_sync(q,&q->read_buf->dma);
                if (STATE_ERROR == q->read_buf->state)
                        retval = -EIO;
                else
@@ -731,28 +896,29 @@ videobuf_read_zerocopy(struct file *file, struct videobuf_queue *q,
 
  done:
        /* cleanup */
-       q->ops->buf_release(file,q->read_buf);
+       q->ops->buf_release(q,q->read_buf);
        kfree(q->read_buf);
        q->read_buf = NULL;
        return retval;
 }
 
-ssize_t videobuf_read_one(struct file *file, struct videobuf_queue *q,
-                         char *data, size_t count, loff_t *ppos)
+ssize_t videobuf_read_one(struct videobuf_queue *q,
+                         char __user *data, size_t count, loff_t *ppos,
+                         int nonblocking)
 {
        enum v4l2_field field;
-       unsigned long flags;
+       unsigned long flags=0;
        unsigned size, nbufs, bytes;
        int retval;
 
-       down(&q->lock);
+       mutex_lock(&q->lock);
 
        nbufs = 1; size = 0;
-       q->ops->buf_setup(file,&nbufs,&size);
+       q->ops->buf_setup(q,&nbufs,&size);
        if (NULL == q->read_buf  &&
            count >= size        &&
-           !(file->f_flags & O_NONBLOCK)) {
-               retval = videobuf_read_zerocopy(file,q,data,count,ppos);
+           !nonblocking) {
+               retval = videobuf_read_zerocopy(q,data,count,ppos);
                if (retval >= 0  ||  retval == -EIO)
                        /* ok, all done */
                        goto done;
@@ -763,28 +929,35 @@ ssize_t videobuf_read_one(struct file *file, struct videobuf_queue *q,
                /* need to capture a new frame */
                retval = -ENOMEM;
                q->read_buf = videobuf_alloc(q->msize);
+               dprintk(1,"video alloc=0x%p\n", q->read_buf);
                if (NULL == q->read_buf)
                        goto done;
                q->read_buf->memory = V4L2_MEMORY_USERPTR;
+               q->read_buf->bsize = count; /* preferred size */
                field = videobuf_next_field(q);
-               retval = q->ops->buf_prepare(file,q->read_buf,field);
-               if (0 != retval)
+               retval = q->ops->buf_prepare(q,q->read_buf,field);
+               if (0 != retval) {
+                       kfree (q->read_buf);
+                       q->read_buf = NULL;
                        goto done;
-               spin_lock_irqsave(q->irqlock,flags);
-               q->ops->buf_queue(file,q->read_buf);
-               spin_unlock_irqrestore(q->irqlock,flags);
+               }
+               if (q->irqlock)
+                       spin_lock_irqsave(q->irqlock,flags);
+               q->ops->buf_queue(q,q->read_buf);
+               if (q->irqlock)
+                       spin_unlock_irqrestore(q->irqlock,flags);
                q->read_off = 0;
        }
 
        /* wait until capture is done */
-        retval = videobuf_waiton(q->read_buf, file->f_flags & O_NONBLOCK, 1);
+       retval = videobuf_waiton(q->read_buf, nonblocking, 1);
        if (0 != retval)
                goto done;
-       videobuf_dma_pci_sync(q->pci,&q->read_buf->dma);
+       videobuf_dma_sync(q,&q->read_buf->dma);
 
        if (STATE_ERROR == q->read_buf->state) {
                /* catch I/O errors */
-               q->ops->buf_release(file,q->read_buf);
+               q->ops->buf_release(q,q->read_buf);
                kfree(q->read_buf);
                q->read_buf = NULL;
                retval = -EIO;
@@ -803,53 +976,56 @@ ssize_t videobuf_read_one(struct file *file, struct videobuf_queue *q,
        q->read_off += bytes;
        if (q->read_off == q->read_buf->size) {
                /* all data copied, cleanup */
-               q->ops->buf_release(file,q->read_buf);
+               q->ops->buf_release(q,q->read_buf);
                kfree(q->read_buf);
                q->read_buf = NULL;
        }
 
  done:
-       up(&q->lock);
+       mutex_unlock(&q->lock);
        return retval;
 }
 
-int videobuf_read_start(struct file *file, struct videobuf_queue *q)
+int videobuf_read_start(struct videobuf_queue *q)
 {
        enum v4l2_field field;
-       unsigned long flags;
+       unsigned long flags=0;
        int count = 0, size = 0;
        int err, i;
 
-       q->ops->buf_setup(file,&count,&size);
+       q->ops->buf_setup(q,&count,&size);
        if (count < 2)
                count = 2;
        if (count > VIDEO_MAX_FRAME)
                count = VIDEO_MAX_FRAME;
        size = PAGE_ALIGN(size);
 
-       err = videobuf_mmap_setup(file, q, count, size, V4L2_MEMORY_USERPTR);
+       err = videobuf_mmap_setup(q, count, size, V4L2_MEMORY_USERPTR);
        if (err)
                return err;
        for (i = 0; i < count; i++) {
                field = videobuf_next_field(q);
-               err = q->ops->buf_prepare(file,q->bufs[i],field);
+               err = q->ops->buf_prepare(q,q->bufs[i],field);
                if (err)
                        return err;
                list_add_tail(&q->bufs[i]->stream, &q->stream);
        }
-       spin_lock_irqsave(q->irqlock,flags);
+       if (q->irqlock)
+               spin_lock_irqsave(q->irqlock,flags);
        for (i = 0; i < count; i++)
-               q->ops->buf_queue(file,q->bufs[i]);
-       spin_unlock_irqrestore(q->irqlock,flags);
+               q->ops->buf_queue(q,q->bufs[i]);
+       if (q->irqlock)
+               spin_unlock_irqrestore(q->irqlock,flags);
        q->reading = 1;
        return 0;
 }
 
-void videobuf_read_stop(struct file *file, struct videobuf_queue *q)
+void videobuf_read_stop(struct videobuf_queue *q)
 {
        int i;
-       
-       videobuf_queue_cancel(file,q);
+
+       videobuf_queue_cancel(q);
+       videobuf_mmap_free(q);
        INIT_LIST_HEAD(&q->stream);
        for (i = 0; i < VIDEO_MAX_FRAME; i++) {
                if (NULL == q->bufs[i])
@@ -861,20 +1037,21 @@ void videobuf_read_stop(struct file *file, struct videobuf_queue *q)
        q->reading  = 0;
 }
 
-ssize_t videobuf_read_stream(struct file *file, struct videobuf_queue *q,
-                            char *data, size_t count, loff_t *ppos,
-                            int vbihack)
+ssize_t videobuf_read_stream(struct videobuf_queue *q,
+                            char __user *data, size_t count, loff_t *ppos,
+                            int vbihack, int nonblocking)
 {
        unsigned int *fc, bytes;
        int err, retval;
-       unsigned long flags;
-       
-       down(&q->lock);
+       unsigned long flags=0;
+
+       dprintk(2,"%s\n",__FUNCTION__);
+       mutex_lock(&q->lock);
        retval = -EBUSY;
        if (q->streaming)
                goto done;
        if (!q->reading) {
-               retval = videobuf_read_start(file,q);
+               retval = videobuf_read_start(q);
                if (retval < 0)
                        goto done;
        }
@@ -889,8 +1066,7 @@ ssize_t videobuf_read_stream(struct file *file, struct videobuf_queue *q,
                        list_del(&q->read_buf->stream);
                        q->read_off = 0;
                }
-               err = videobuf_waiton(q->read_buf,
-                                     file->f_flags & O_NONBLOCK,1);
+               err = videobuf_waiton(q->read_buf, nonblocking, 1);
                if (err < 0) {
                        if (0 == retval)
                                retval = err;
@@ -908,7 +1084,7 @@ ssize_t videobuf_read_stream(struct file *file, struct videobuf_queue *q,
                                *fc = q->read_buf->field_count >> 1;
                                dprintk(1,"vbihack: %d\n",*fc);
                        }
-                       
+
                        /* copy stuff */
                        bytes = count;
                        if (bytes > q->read_buf->size - q->read_off)
@@ -934,9 +1110,11 @@ ssize_t videobuf_read_stream(struct file *file, struct videobuf_queue *q,
                if (q->read_off == q->read_buf->size) {
                        list_add_tail(&q->read_buf->stream,
                                      &q->stream);
-                       spin_lock_irqsave(q->irqlock,flags);
-                       q->ops->buf_queue(file,q->read_buf);
-                       spin_unlock_irqrestore(q->irqlock,flags);
+                       if (q->irqlock)
+                               spin_lock_irqsave(q->irqlock,flags);
+                       q->ops->buf_queue(q,q->read_buf);
+                       if (q->irqlock)
+                               spin_unlock_irqrestore(q->irqlock,flags);
                        q->read_buf = NULL;
                }
                if (retval < 0)
@@ -944,7 +1122,7 @@ ssize_t videobuf_read_stream(struct file *file, struct videobuf_queue *q,
        }
 
  done:
-       up(&q->lock);
+       mutex_unlock(&q->lock);
        return retval;
 }
 
@@ -955,14 +1133,14 @@ unsigned int videobuf_poll_stream(struct file *file,
        struct videobuf_buffer *buf = NULL;
        unsigned int rc = 0;
 
-       down(&q->lock);
+       mutex_lock(&q->lock);
        if (q->streaming) {
                if (!list_empty(&q->stream))
                        buf = list_entry(q->stream.next,
                                         struct videobuf_buffer, stream);
        } else {
                if (!q->reading)
-                       videobuf_read_start(file,q);
+                       videobuf_read_start(q);
                if (!q->reading) {
                        rc = POLLERR;
                } else if (NULL == q->read_buf) {
@@ -983,7 +1161,7 @@ unsigned int videobuf_poll_stream(struct file *file,
                    buf->state == STATE_ERROR)
                        rc = POLLIN|POLLRDNORM;
        }
-       up(&q->lock);
+       mutex_unlock(&q->lock);
        return rc;
 }
 
@@ -1003,29 +1181,30 @@ static void
 videobuf_vm_close(struct vm_area_struct *vma)
 {
        struct videobuf_mapping *map = vma->vm_private_data;
+       struct videobuf_queue *q = map->q;
        int i;
 
        dprintk(2,"vm_close %p [count=%d,vma=%08lx-%08lx]\n",map,
                map->count,vma->vm_start,vma->vm_end);
 
-       /* down(&fh->lock); FIXME */
        map->count--;
        if (0 == map->count) {
-               dprintk(1,"munmap %p\n",map);
+               dprintk(1,"munmap %p q=%p\n",map,q);
+               mutex_lock(&q->lock);
                for (i = 0; i < VIDEO_MAX_FRAME; i++) {
-                       if (NULL == map->q->bufs[i])
+                       if (NULL == q->bufs[i])
                                continue;
-                       if (map->q->bufs[i])
+                       if (q->bufs[i])
                                ;
-                       if (map->q->bufs[i]->map != map)
+                       if (q->bufs[i]->map != map)
                                continue;
-                       map->q->bufs[i]->map   = NULL;
-                       map->q->bufs[i]->baddr = 0;
-                       map->q->ops->buf_release(vma->vm_file,map->q->bufs[i]);
+                       q->bufs[i]->map   = NULL;
+                       q->bufs[i]->baddr = 0;
+                       q->ops->buf_release(q,q->bufs[i]);
                }
+               mutex_unlock(&q->lock);
                kfree(map);
        }
-       /* up(&fh->lock); FIXME */
        return;
 }
 
@@ -1043,7 +1222,7 @@ videobuf_vm_nopage(struct vm_area_struct *vma, unsigned long vaddr,
 
        dprintk(3,"nopage: fault @ %08lx [vma %08lx-%08lx]\n",
                vaddr,vma->vm_start,vma->vm_end);
-        if (vaddr > vma->vm_end)
+       if (vaddr > vma->vm_end)
                return NOPAGE_SIGBUS;
        page = alloc_page(GFP_USER);
        if (!page)
@@ -1061,20 +1240,21 @@ static struct vm_operations_struct videobuf_vm_ops =
        .nopage   = videobuf_vm_nopage,
 };
 
-int videobuf_mmap_setup(struct file *file, struct videobuf_queue *q,
+int videobuf_mmap_setup(struct videobuf_queue *q,
                        unsigned int bcount, unsigned int bsize,
                        enum v4l2_memory memory)
 {
        unsigned int i;
        int err;
 
-       err = videobuf_mmap_free(file,q);
+       err = videobuf_mmap_free(q);
        if (0 != err)
                return err;
 
        for (i = 0; i < bcount; i++) {
                q->bufs[i] = videobuf_alloc(q->msize);
                q->bufs[i]->i      = i;
+               q->bufs[i]->input  = UNSET;
                q->bufs[i]->memory = memory;
                q->bufs[i]->bsize  = bsize;
                switch (memory) {
@@ -1085,14 +1265,14 @@ int videobuf_mmap_setup(struct file *file, struct videobuf_queue *q,
                case V4L2_MEMORY_OVERLAY:
                        /* nothing */
                        break;
-               };
+               }
        }
        dprintk(1,"mmap setup: %d buffers, %d bytes each\n",
                bcount,bsize);
        return 0;
 }
 
-int videobuf_mmap_free(struct file *file, struct videobuf_queue *q)
+int videobuf_mmap_free(struct videobuf_queue *q)
 {
        int i;
 
@@ -1102,21 +1282,21 @@ int videobuf_mmap_free(struct file *file, struct videobuf_queue *q)
        for (i = 0; i < VIDEO_MAX_FRAME; i++) {
                if (NULL == q->bufs[i])
                        continue;
-               q->ops->buf_release(file,q->bufs[i]);
+               q->ops->buf_release(q,q->bufs[i]);
                kfree(q->bufs[i]);
                q->bufs[i] = NULL;
        }
        return 0;
 }
 
-int videobuf_mmap_mapper(struct vm_area_struct *vma,
-                        struct videobuf_queue *q)
+int videobuf_mmap_mapper(struct videobuf_queue *q,
+                        struct vm_area_struct *vma)
 {
        struct videobuf_mapping *map;
        unsigned int first,last,size,i;
        int retval;
 
-       down(&q->lock);
+       mutex_lock(&q->lock);
        retval = -EINVAL;
        if (!(vma->vm_flags & VM_WRITE)) {
                dprintk(1,"mmap app bug: PROT_WRITE please\n");
@@ -1179,12 +1359,12 @@ int videobuf_mmap_mapper(struct vm_area_struct *vma,
        vma->vm_flags |= VM_DONTEXPAND | VM_RESERVED;
        vma->vm_flags &= ~VM_IO; /* using shared anonymous pages */
        vma->vm_private_data = map;
-       dprintk(1,"mmap %p: %08lx-%08lx pgoff %08lx bufs %d-%d\n",
-               map,vma->vm_start,vma->vm_end,vma->vm_pgoff,first,last);
+       dprintk(1,"mmap %p: q=%p %08lx-%08lx pgoff %08lx bufs %d-%d\n",
+               map,q,vma->vm_start,vma->vm_end,vma->vm_pgoff,first,last);
        retval = 0;
 
  done:
-       up(&q->lock);
+       mutex_unlock(&q->lock);
        return retval;
 }
 
@@ -1192,14 +1372,18 @@ int videobuf_mmap_mapper(struct vm_area_struct *vma,
 
 EXPORT_SYMBOL_GPL(videobuf_vmalloc_to_sg);
 
+EXPORT_SYMBOL_GPL(videobuf_dma_init);
 EXPORT_SYMBOL_GPL(videobuf_dma_init_user);
 EXPORT_SYMBOL_GPL(videobuf_dma_init_kernel);
 EXPORT_SYMBOL_GPL(videobuf_dma_init_overlay);
-EXPORT_SYMBOL_GPL(videobuf_dma_pci_map);
-EXPORT_SYMBOL_GPL(videobuf_dma_pci_sync);
-EXPORT_SYMBOL_GPL(videobuf_dma_pci_unmap);
+EXPORT_SYMBOL_GPL(videobuf_dma_map);
+EXPORT_SYMBOL_GPL(videobuf_dma_sync);
+EXPORT_SYMBOL_GPL(videobuf_dma_unmap);
 EXPORT_SYMBOL_GPL(videobuf_dma_free);
 
+EXPORT_SYMBOL_GPL(videobuf_pci_dma_map);
+EXPORT_SYMBOL_GPL(videobuf_pci_dma_unmap);
+
 EXPORT_SYMBOL_GPL(videobuf_alloc);
 EXPORT_SYMBOL_GPL(videobuf_waiton);
 EXPORT_SYMBOL_GPL(videobuf_iolock);