vserver 1.9.5.x5
[linux-2.6.git] / drivers / net / b44.c
index ba1d4fc..f6fd409 100644 (file)
@@ -8,6 +8,7 @@
 
 #include <linux/kernel.h>
 #include <linux/module.h>
+#include <linux/moduleparam.h>
 #include <linux/types.h>
 #include <linux/netdevice.h>
 #include <linux/ethtool.h>
@@ -27,8 +28,8 @@
 
 #define DRV_MODULE_NAME                "b44"
 #define PFX DRV_MODULE_NAME    ": "
-#define DRV_MODULE_VERSION     "0.94"
-#define DRV_MODULE_RELDATE     "May 4, 2004"
+#define DRV_MODULE_VERSION     "0.95"
+#define DRV_MODULE_RELDATE     "Aug 3, 2004"
 
 #define B44_DEF_MSG_ENABLE       \
        (NETIF_MSG_DRV          | \
@@ -57,6 +58,7 @@
 #define B44_DEF_TX_RING_PENDING                (B44_TX_RING_SIZE - 1)
 #define B44_TX_RING_BYTES      (sizeof(struct dma_desc) * \
                                 B44_TX_RING_SIZE)
+#define B44_DMA_MASK 0x3fffffff
 
 #define TX_RING_GAP(BP)        \
        (B44_TX_RING_SIZE - (BP)->tx_pending)
@@ -67,6 +69,7 @@
 #define NEXT_TX(N)             (((N) + 1) & (B44_TX_RING_SIZE - 1))
 
 #define RX_PKT_BUF_SZ          (1536 + bp->rx_offset + 64)
+#define TX_PKT_BUF_SZ          (B44_MAX_MTU + ETH_HLEN + 8)
 
 /* minimum number of free TX descriptors required to wake up TX process */
 #define B44_TX_WAKEUP_THRESH           (B44_TX_RING_SIZE / 4)
 static char version[] __devinitdata =
        DRV_MODULE_NAME ".c:v" DRV_MODULE_VERSION " (" DRV_MODULE_RELDATE ")\n";
 
-MODULE_AUTHOR("David S. Miller (davem@redhat.com)");
+MODULE_AUTHOR("Florian Schirmer, Pekka Pietikainen, David S. Miller");
 MODULE_DESCRIPTION("Broadcom 4400 10/100 PCI ethernet driver");
 MODULE_LICENSE("GPL");
-MODULE_PARM(b44_debug, "i");
-MODULE_PARM_DESC(b44_debug, "B44 bitmapped debugging message enable value");
+MODULE_VERSION(DRV_MODULE_VERSION);
 
 static int b44_debug = -1;     /* -1 == use B44_DEF_MSG_ENABLE as value */
+module_param(b44_debug, int, 0);
+MODULE_PARM_DESC(b44_debug, "B44 bitmapped debugging message enable value");
 
 static struct pci_device_id b44_pci_tbl[] = {
        { PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_BCM4401,
@@ -97,6 +101,21 @@ MODULE_DEVICE_TABLE(pci, b44_pci_tbl);
 static void b44_halt(struct b44 *);
 static void b44_init_rings(struct b44 *);
 static void b44_init_hw(struct b44 *);
+static int b44_poll(struct net_device *dev, int *budget);
+#ifdef CONFIG_NET_POLL_CONTROLLER
+static void b44_poll_controller(struct net_device *dev);
+#endif
+
+static inline unsigned long br32(const struct b44 *bp, unsigned long reg)
+{
+       return readl(bp->regs + reg);
+}
+
+static inline void bw32(const struct b44 *bp, 
+                       unsigned long reg, unsigned long val)
+{
+       writel(val, bp->regs + reg);
+}
 
 static int b44_wait_bit(struct b44 *bp, unsigned long reg,
                        u32 bit, unsigned long timeout, const int clear)
@@ -104,7 +123,7 @@ static int b44_wait_bit(struct b44 *bp, unsigned long reg,
        unsigned long i;
 
        for (i = 0; i < timeout; i++) {
-               u32 val = br32(reg);
+               u32 val = br32(bp, reg);
 
                if (clear && !(val & bit))
                        break;
@@ -130,45 +149,12 @@ static int b44_wait_bit(struct b44 *bp, unsigned long reg,
  * interrupts disabled.
  */
 
-#define SBID_SDRAM             0
-#define SBID_PCI_MEM           1
-#define SBID_PCI_CFG           2
-#define SBID_PCI_DMA           3
-#define        SBID_SDRAM_SWAPPED      4
-#define SBID_ENUM              5
-#define SBID_REG_SDRAM         6
-#define SBID_REG_ILINE20       7
-#define SBID_REG_EMAC          8
-#define SBID_REG_CODEC         9
-#define SBID_REG_USB           10
-#define SBID_REG_PCI           11
-#define SBID_REG_MIPS          12
-#define SBID_REG_EXTIF         13
-#define        SBID_EXTIF              14
-#define        SBID_EJTAG              15
-#define        SBID_MAX                16
-
-static u32 ssb_get_addr(struct b44 *bp, u32 id, u32 instance)
-{
-       switch (id) {
-       case SBID_PCI_DMA:
-               return 0x40000000;
-       case SBID_ENUM:
-               return 0x18000000;
-       case SBID_REG_EMAC:
-               return 0x18000000;
-       case SBID_REG_CODEC:
-               return 0x18001000;
-       case SBID_REG_PCI:
-               return 0x18002000;
-       default:
-               return 0;
-       };
-}
+#define SB_PCI_DMA             0x40000000      /* Client Mode PCI memory access space (1 GB) */
+#define BCM4400_PCI_CORE_ADDR  0x18002000      /* Address of PCI core on BCM4400 cards */
 
 static u32 ssb_get_core_rev(struct b44 *bp)
 {
-       return (br32(B44_SBIDHIGH) & SBIDHIGH_RC_MASK);
+       return (br32(bp, B44_SBIDHIGH) & SBIDHIGH_RC_MASK);
 }
 
 static u32 ssb_pci_setup(struct b44 *bp, u32 cores)
@@ -176,17 +162,16 @@ static u32 ssb_pci_setup(struct b44 *bp, u32 cores)
        u32 bar_orig, pci_rev, val;
 
        pci_read_config_dword(bp->pdev, SSB_BAR0_WIN, &bar_orig);
-       pci_write_config_dword(bp->pdev, SSB_BAR0_WIN,
-                              ssb_get_addr(bp, SBID_REG_PCI, 0));
+       pci_write_config_dword(bp->pdev, SSB_BAR0_WIN, BCM4400_PCI_CORE_ADDR);
        pci_rev = ssb_get_core_rev(bp);
 
-       val = br32(B44_SBINTVEC);
+       val = br32(bp, B44_SBINTVEC);
        val |= cores;
-       bw32(B44_SBINTVEC, val);
+       bw32(bp, B44_SBINTVEC, val);
 
-       val = br32(SSB_PCI_TRANS_2);
+       val = br32(bp, SSB_PCI_TRANS_2);
        val |= SSB_PCI_PREF | SSB_PCI_BURST;
-       bw32(SSB_PCI_TRANS_2, val);
+       bw32(bp, SSB_PCI_TRANS_2, val);
 
        pci_write_config_dword(bp->pdev, SSB_BAR0_WIN, bar_orig);
 
@@ -195,18 +180,18 @@ static u32 ssb_pci_setup(struct b44 *bp, u32 cores)
 
 static void ssb_core_disable(struct b44 *bp)
 {
-       if (br32(B44_SBTMSLOW) & SBTMSLOW_RESET)
+       if (br32(bp, B44_SBTMSLOW) & SBTMSLOW_RESET)
                return;
 
-       bw32(B44_SBTMSLOW, (SBTMSLOW_REJECT | SBTMSLOW_CLOCK));
+       bw32(bp, B44_SBTMSLOW, (SBTMSLOW_REJECT | SBTMSLOW_CLOCK));
        b44_wait_bit(bp, B44_SBTMSLOW, SBTMSLOW_REJECT, 100000, 0);
        b44_wait_bit(bp, B44_SBTMSHIGH, SBTMSHIGH_BUSY, 100000, 1);
-       bw32(B44_SBTMSLOW, (SBTMSLOW_FGC | SBTMSLOW_CLOCK |
+       bw32(bp, B44_SBTMSLOW, (SBTMSLOW_FGC | SBTMSLOW_CLOCK |
                            SBTMSLOW_REJECT | SBTMSLOW_RESET));
-       br32(B44_SBTMSLOW);
+       br32(bp, B44_SBTMSLOW);
        udelay(1);
-       bw32(B44_SBTMSLOW, (SBTMSLOW_REJECT | SBTMSLOW_RESET));
-       br32(B44_SBTMSLOW);
+       bw32(bp, B44_SBTMSLOW, (SBTMSLOW_REJECT | SBTMSLOW_RESET));
+       br32(bp, B44_SBTMSLOW);
        udelay(1);
 }
 
@@ -215,31 +200,31 @@ static void ssb_core_reset(struct b44 *bp)
        u32 val;
 
        ssb_core_disable(bp);
-       bw32(B44_SBTMSLOW, (SBTMSLOW_RESET | SBTMSLOW_CLOCK | SBTMSLOW_FGC));
-       br32(B44_SBTMSLOW);
+       bw32(bp, B44_SBTMSLOW, (SBTMSLOW_RESET | SBTMSLOW_CLOCK | SBTMSLOW_FGC));
+       br32(bp, B44_SBTMSLOW);
        udelay(1);
 
        /* Clear SERR if set, this is a hw bug workaround.  */
-       if (br32(B44_SBTMSHIGH) & SBTMSHIGH_SERR)
-               bw32(B44_SBTMSHIGH, 0);
+       if (br32(bp, B44_SBTMSHIGH) & SBTMSHIGH_SERR)
+               bw32(bp, B44_SBTMSHIGH, 0);
 
-       val = br32(B44_SBIMSTATE);
+       val = br32(bp, B44_SBIMSTATE);
        if (val & (SBIMSTATE_IBE | SBIMSTATE_TO))
-               bw32(B44_SBIMSTATE, val & ~(SBIMSTATE_IBE | SBIMSTATE_TO));
+               bw32(bp, B44_SBIMSTATE, val & ~(SBIMSTATE_IBE | SBIMSTATE_TO));
 
-       bw32(B44_SBTMSLOW, (SBTMSLOW_CLOCK | SBTMSLOW_FGC));
-       br32(B44_SBTMSLOW);
+       bw32(bp, B44_SBTMSLOW, (SBTMSLOW_CLOCK | SBTMSLOW_FGC));
+       br32(bp, B44_SBTMSLOW);
        udelay(1);
 
-       bw32(B44_SBTMSLOW, (SBTMSLOW_CLOCK));
-       br32(B44_SBTMSLOW);
+       bw32(bp, B44_SBTMSLOW, (SBTMSLOW_CLOCK));
+       br32(bp, B44_SBTMSLOW);
        udelay(1);
 }
 
 static int ssb_core_unit(struct b44 *bp)
 {
 #if 0
-       u32 val = br32(B44_SBADMATCH0);
+       u32 val = br32(bp, B44_SBADMATCH0);
        u32 base;
 
        type = val & SBADMATCH0_TYPE_MASK;
@@ -263,7 +248,7 @@ static int ssb_core_unit(struct b44 *bp)
 
 static int ssb_is_core_up(struct b44 *bp)
 {
-       return ((br32(B44_SBTMSLOW) & (SBTMSLOW_RESET | SBTMSLOW_REJECT | SBTMSLOW_CLOCK))
+       return ((br32(bp, B44_SBTMSLOW) & (SBTMSLOW_RESET | SBTMSLOW_REJECT | SBTMSLOW_CLOCK))
                == SBTMSLOW_CLOCK);
 }
 
@@ -275,19 +260,19 @@ static void __b44_cam_write(struct b44 *bp, unsigned char *data, int index)
        val |= ((u32) data[3]) << 16;
        val |= ((u32) data[4]) <<  8;
        val |= ((u32) data[5]) <<  0;
-       bw32(B44_CAM_DATA_LO, val);
+       bw32(bp, B44_CAM_DATA_LO, val);
        val = (CAM_DATA_HI_VALID | 
               (((u32) data[0]) << 8) |
               (((u32) data[1]) << 0));
-       bw32(B44_CAM_DATA_HI, val);
-       bw32(B44_CAM_CTRL, (CAM_CTRL_WRITE |
+       bw32(bp, B44_CAM_DATA_HI, val);
+       bw32(bp, B44_CAM_CTRL, (CAM_CTRL_WRITE |
                            (index << CAM_CTRL_INDEX_SHIFT)));
        b44_wait_bit(bp, B44_CAM_CTRL, CAM_CTRL_BUSY, 100, 1);  
 }
 
 static inline void __b44_disable_ints(struct b44 *bp)
 {
-       bw32(B44_IMASK, 0);
+       bw32(bp, B44_IMASK, 0);
 }
 
 static void b44_disable_ints(struct b44 *bp)
@@ -295,34 +280,34 @@ static void b44_disable_ints(struct b44 *bp)
        __b44_disable_ints(bp);
 
        /* Flush posted writes. */
-       br32(B44_IMASK);
+       br32(bp, B44_IMASK);
 }
 
 static void b44_enable_ints(struct b44 *bp)
 {
-       bw32(B44_IMASK, bp->imask);
+       bw32(bp, B44_IMASK, bp->imask);
 }
 
 static int b44_readphy(struct b44 *bp, int reg, u32 *val)
 {
        int err;
 
-       bw32(B44_EMAC_ISTAT, EMAC_INT_MII);
-       bw32(B44_MDIO_DATA, (MDIO_DATA_SB_START |
+       bw32(bp, B44_EMAC_ISTAT, EMAC_INT_MII);
+       bw32(bp, B44_MDIO_DATA, (MDIO_DATA_SB_START |
                             (MDIO_OP_READ << MDIO_DATA_OP_SHIFT) |
                             (bp->phy_addr << MDIO_DATA_PMD_SHIFT) |
                             (reg << MDIO_DATA_RA_SHIFT) |
                             (MDIO_TA_VALID << MDIO_DATA_TA_SHIFT)));
        err = b44_wait_bit(bp, B44_EMAC_ISTAT, EMAC_INT_MII, 100, 0);
-       *val = br32(B44_MDIO_DATA) & MDIO_DATA_DATA;
+       *val = br32(bp, B44_MDIO_DATA) & MDIO_DATA_DATA;
 
        return err;
 }
 
 static int b44_writephy(struct b44 *bp, int reg, u32 val)
 {
-       bw32(B44_EMAC_ISTAT, EMAC_INT_MII);
-       bw32(B44_MDIO_DATA, (MDIO_DATA_SB_START |
+       bw32(bp, B44_EMAC_ISTAT, EMAC_INT_MII);
+       bw32(bp, B44_MDIO_DATA, (MDIO_DATA_SB_START |
                             (MDIO_OP_WRITE << MDIO_DATA_OP_SHIFT) |
                             (bp->phy_addr << MDIO_DATA_PMD_SHIFT) |
                             (reg << MDIO_DATA_RA_SHIFT) |
@@ -382,20 +367,20 @@ static void __b44_set_flow_ctrl(struct b44 *bp, u32 pause_flags)
        bp->flags &= ~(B44_FLAG_TX_PAUSE | B44_FLAG_RX_PAUSE);
        bp->flags |= pause_flags;
 
-       val = br32(B44_RXCONFIG);
+       val = br32(bp, B44_RXCONFIG);
        if (pause_flags & B44_FLAG_RX_PAUSE)
                val |= RXCONFIG_FLOW;
        else
                val &= ~RXCONFIG_FLOW;
-       bw32(B44_RXCONFIG, val);
+       bw32(bp, B44_RXCONFIG, val);
 
-       val = br32(B44_MAC_FLOW);
+       val = br32(bp, B44_MAC_FLOW);
        if (pause_flags & B44_FLAG_TX_PAUSE)
                val |= (MAC_FLOW_PAUSE_ENAB |
                        (0xc0 & MAC_FLOW_RX_HI_WATER));
        else
                val &= ~MAC_FLOW_PAUSE_ENAB;
-       bw32(B44_MAC_FLOW, val);
+       bw32(bp, B44_MAC_FLOW, val);
 }
 
 static void b44_set_flow_ctrl(struct b44 *bp, u32 local, u32 remote)
@@ -491,11 +476,11 @@ static void b44_stats_update(struct b44 *bp)
 
        val = &bp->hw_stats.tx_good_octets;
        for (reg = B44_TX_GOOD_O; reg <= B44_TX_PAUSE; reg += 4UL) {
-               *val++ += br32(reg);
+               *val++ += br32(bp, reg);
        }
        val = &bp->hw_stats.rx_good_octets;
        for (reg = B44_RX_GOOD_O; reg <= B44_RX_NPAUSE; reg += 4UL) {
-               *val++ += br32(reg);
+               *val++ += br32(bp, reg);
        }
 }
 
@@ -535,14 +520,14 @@ static void b44_check_phy(struct b44 *bp)
 
                if (!netif_carrier_ok(bp->dev) &&
                    (bmsr & BMSR_LSTATUS)) {
-                       u32 val = br32(B44_TX_CTRL);
+                       u32 val = br32(bp, B44_TX_CTRL);
                        u32 local_adv, remote_adv;
 
                        if (bp->flags & B44_FLAG_FULL_DUPLEX)
                                val |= TX_CTRL_DUPLEX;
                        else
                                val &= ~TX_CTRL_DUPLEX;
-                       bw32(B44_TX_CTRL, val);
+                       bw32(bp, B44_TX_CTRL, val);
 
                        if (!(bp->flags & B44_FLAG_FORCE_LINK) &&
                            !b44_readphy(bp, MII_ADVERTISE, &local_adv) &&
@@ -587,7 +572,7 @@ static void b44_tx(struct b44 *bp)
 {
        u32 cur, cons;
 
-       cur  = br32(B44_DMATX_STAT) & DMATX_STAT_CDMASK;
+       cur  = br32(bp, B44_DMATX_STAT) & DMATX_STAT_CDMASK;
        cur /= sizeof(struct dma_desc);
 
        /* XXX needs updating when NETIF_F_SG is supported */
@@ -611,7 +596,7 @@ static void b44_tx(struct b44 *bp)
            TX_BUFFS_AVAIL(bp) > B44_TX_WAKEUP_THRESH)
                netif_wake_queue(bp->dev);
 
-       bw32(B44_GPTIMER, 0);
+       bw32(bp, B44_GPTIMER, 0);
 }
 
 /* Works like this.  This chip writes a 'struct rx_header" 30 bytes
@@ -638,10 +623,30 @@ static int b44_alloc_rx_skb(struct b44 *bp, int src_idx, u32 dest_idx_unmasked)
        if (skb == NULL)
                return -ENOMEM;
 
-       skb->dev = bp->dev;
        mapping = pci_map_single(bp->pdev, skb->data,
                                 RX_PKT_BUF_SZ,
                                 PCI_DMA_FROMDEVICE);
+
+       /* Hardware bug work-around, the chip is unable to do PCI DMA
+          to/from anything above 1GB :-( */
+       if(mapping+RX_PKT_BUF_SZ > B44_DMA_MASK) {
+               /* Sigh... */
+               pci_unmap_single(bp->pdev, mapping, RX_PKT_BUF_SZ,PCI_DMA_FROMDEVICE);
+               dev_kfree_skb_any(skb);
+               skb = __dev_alloc_skb(RX_PKT_BUF_SZ,GFP_DMA);
+               if (skb == NULL)
+                       return -ENOMEM;
+               mapping = pci_map_single(bp->pdev, skb->data,
+                                        RX_PKT_BUF_SZ,
+                                        PCI_DMA_FROMDEVICE);
+               if(mapping+RX_PKT_BUF_SZ > B44_DMA_MASK) {
+                       pci_unmap_single(bp->pdev, mapping, RX_PKT_BUF_SZ,PCI_DMA_FROMDEVICE);
+                       dev_kfree_skb_any(skb);
+                       return -ENOMEM;
+               }
+       }
+
+       skb->dev = bp->dev;
        skb_reserve(skb, bp->rx_offset);
 
        rh = (struct rx_header *)
@@ -708,7 +713,7 @@ static int b44_rx(struct b44 *bp, int budget)
        u32 cons, prod;
 
        received = 0;
-       prod  = br32(B44_DMARX_STAT) & DMARX_STAT_CDMASK;
+       prod  = br32(bp, B44_DMARX_STAT) & DMARX_STAT_CDMASK;
        prod /= sizeof(struct dma_desc);
        cons = bp->rx_cons;
 
@@ -787,7 +792,7 @@ static int b44_rx(struct b44 *bp, int budget)
        }
 
        bp->rx_cons = cons;
-       bw32(B44_DMARX_PTR, cons * sizeof(struct dma_desc));
+       bw32(bp, B44_DMARX_PTR, cons * sizeof(struct dma_desc));
 
        return received;
 }
@@ -851,8 +856,8 @@ static irqreturn_t b44_interrupt(int irq, void *dev_id, struct pt_regs *regs)
 
        spin_lock_irqsave(&bp->lock, flags);
 
-       istat = br32(B44_ISTAT);
-       imask = br32(B44_IMASK);
+       istat = br32(bp, B44_ISTAT);
+       imask = br32(bp, B44_IMASK);
 
        /* ??? What the fuck is the purpose of the interrupt mask
         * ??? register if we have to mask it out by hand anyways?
@@ -872,8 +877,8 @@ static irqreturn_t b44_interrupt(int irq, void *dev_id, struct pt_regs *regs)
                               dev->name);
                }
 
-               bw32(B44_ISTAT, istat);
-               br32(B44_ISTAT);
+               bw32(bp, B44_ISTAT, istat);
+               br32(bp, B44_ISTAT);
        }
        spin_unlock_irqrestore(&bp->lock, flags);
        return IRQ_RETVAL(handled);
@@ -919,6 +924,12 @@ static int b44_start_xmit(struct sk_buff *skb, struct net_device *dev)
 
        entry = bp->tx_prod;
        mapping = pci_map_single(bp->pdev, skb->data, len, PCI_DMA_TODEVICE);
+       if(mapping+len > B44_DMA_MASK) {
+               /* Chip can't handle DMA to/from >1GB, use bounce buffer */
+               pci_unmap_single(bp->pdev, mapping, len,PCI_DMA_TODEVICE);
+               memcpy(bp->tx_bufs+entry*TX_PKT_BUF_SZ,skb->data,skb->len);
+               mapping = pci_map_single(bp->pdev, bp->tx_bufs+entry*TX_PKT_BUF_SZ, len, PCI_DMA_TODEVICE);
+       }
 
        bp->tx_buffers[entry].skb = skb;
        pci_unmap_addr_set(&bp->tx_buffers[entry], mapping, mapping);
@@ -937,11 +948,11 @@ static int b44_start_xmit(struct sk_buff *skb, struct net_device *dev)
 
        wmb();
 
-       bw32(B44_DMATX_PTR, entry * sizeof(struct dma_desc));
+       bw32(bp, B44_DMATX_PTR, entry * sizeof(struct dma_desc));
        if (bp->flags & B44_FLAG_BUGGY_TXPTR)
-               bw32(B44_DMATX_PTR, entry * sizeof(struct dma_desc));
+               bw32(bp, B44_DMATX_PTR, entry * sizeof(struct dma_desc));
        if (bp->flags & B44_FLAG_REORDER_BUG)
-               br32(B44_DMATX_PTR);
+               br32(bp, B44_DMATX_PTR);
 
        if (TX_BUFFS_AVAIL(bp) < 1)
                netif_stop_queue(dev);
@@ -1066,6 +1077,11 @@ static void b44_free_consistent(struct b44 *bp)
                                    bp->tx_ring, bp->tx_ring_dma);
                bp->tx_ring = NULL;
        }
+       if (bp->tx_bufs) {
+               pci_free_consistent(bp->pdev, B44_TX_RING_SIZE * TX_PKT_BUF_SZ,
+                                   bp->tx_bufs, bp->tx_bufs_dma);
+               bp->tx_bufs = NULL;
+       }
 }
 
 /*
@@ -1088,6 +1104,12 @@ static int b44_alloc_consistent(struct b44 *bp)
                goto out_err;
        memset(bp->tx_buffers, 0, size);
 
+       size = B44_TX_RING_SIZE * TX_PKT_BUF_SZ;
+       bp->tx_bufs = pci_alloc_consistent(bp->pdev, size, &bp->tx_bufs_dma);
+       if (!bp->tx_bufs)
+               goto out_err;
+       memset(bp->tx_bufs, 0, size);
+
        size = DMA_TABLE_BYTES;
        bp->rx_ring = pci_alloc_consistent(bp->pdev, size, &bp->rx_ring_dma);
        if (!bp->rx_ring)
@@ -1109,27 +1131,27 @@ static void b44_clear_stats(struct b44 *bp)
 {
        unsigned long reg;
 
-       bw32(B44_MIB_CTRL, MIB_CTRL_CLR_ON_READ);
+       bw32(bp, B44_MIB_CTRL, MIB_CTRL_CLR_ON_READ);
        for (reg = B44_TX_GOOD_O; reg <= B44_TX_PAUSE; reg += 4UL)
-               br32(reg);
+               br32(bp, reg);
        for (reg = B44_RX_GOOD_O; reg <= B44_RX_NPAUSE; reg += 4UL)
-               br32(reg);
+               br32(bp, reg);
 }
 
 /* bp->lock is held. */
 static void b44_chip_reset(struct b44 *bp)
 {
        if (ssb_is_core_up(bp)) {
-               bw32(B44_RCV_LAZY, 0);
-               bw32(B44_ENET_CTRL, ENET_CTRL_DISABLE);
+               bw32(bp, B44_RCV_LAZY, 0);
+               bw32(bp, B44_ENET_CTRL, ENET_CTRL_DISABLE);
                b44_wait_bit(bp, B44_ENET_CTRL, ENET_CTRL_DISABLE, 100, 1);
-               bw32(B44_DMATX_CTRL, 0);
+               bw32(bp, B44_DMATX_CTRL, 0);
                bp->tx_prod = bp->tx_cons = 0;
-               if (br32(B44_DMARX_STAT) & DMARX_STAT_EMASK) {
+               if (br32(bp, B44_DMARX_STAT) & DMARX_STAT_EMASK) {
                        b44_wait_bit(bp, B44_DMARX_STAT, DMARX_STAT_SIDLE,
                                     100, 0);
                }
-               bw32(B44_DMARX_CTRL, 0);
+               bw32(bp, B44_DMARX_CTRL, 0);
                bp->rx_prod = bp->rx_cons = 0;
        } else {
                ssb_pci_setup(bp, (bp->core_unit == 0 ?
@@ -1142,20 +1164,20 @@ static void b44_chip_reset(struct b44 *bp)
        b44_clear_stats(bp);
 
        /* Make PHY accessible. */
-       bw32(B44_MDIO_CTRL, (MDIO_CTRL_PREAMBLE |
+       bw32(bp, B44_MDIO_CTRL, (MDIO_CTRL_PREAMBLE |
                             (0x0d & MDIO_CTRL_MAXF_MASK)));
-       br32(B44_MDIO_CTRL);
+       br32(bp, B44_MDIO_CTRL);
 
-       if (!(br32(B44_DEVCTRL) & DEVCTRL_IPP)) {
-               bw32(B44_ENET_CTRL, ENET_CTRL_EPSEL);
-               br32(B44_ENET_CTRL);
+       if (!(br32(bp, B44_DEVCTRL) & DEVCTRL_IPP)) {
+               bw32(bp, B44_ENET_CTRL, ENET_CTRL_EPSEL);
+               br32(bp, B44_ENET_CTRL);
                bp->flags &= ~B44_FLAG_INTERNAL_PHY;
        } else {
-               u32 val = br32(B44_DEVCTRL);
+               u32 val = br32(bp, B44_DEVCTRL);
 
                if (val & DEVCTRL_EPR) {
-                       bw32(B44_DEVCTRL, (val & ~DEVCTRL_EPR));
-                       br32(B44_DEVCTRL);
+                       bw32(bp, B44_DEVCTRL, (val & ~DEVCTRL_EPR));
+                       br32(bp, B44_DEVCTRL);
                        udelay(100);
                }
                bp->flags |= B44_FLAG_INTERNAL_PHY;
@@ -1172,13 +1194,13 @@ static void b44_halt(struct b44 *bp)
 /* bp->lock is held. */
 static void __b44_set_mac_addr(struct b44 *bp)
 {
-       bw32(B44_CAM_CTRL, 0);
+       bw32(bp, B44_CAM_CTRL, 0);
        if (!(bp->dev->flags & IFF_PROMISC)) {
                u32 val;
 
                __b44_cam_write(bp, bp->dev->dev_addr, 0);
-               val = br32(B44_CAM_CTRL);
-               bw32(B44_CAM_CTRL, val | CAM_CTRL_ENABLE);
+               val = br32(bp, B44_CAM_CTRL);
+               bw32(bp, B44_CAM_CTRL, val | CAM_CTRL_ENABLE);
        }
 }
 
@@ -1212,30 +1234,30 @@ static void b44_init_hw(struct b44 *bp)
        b44_setup_phy(bp);
 
        /* Enable CRC32, set proper LED modes and power on PHY */
-       bw32(B44_MAC_CTRL, MAC_CTRL_CRC32_ENAB | MAC_CTRL_PHY_LEDCTRL);
-       bw32(B44_RCV_LAZY, (1 << RCV_LAZY_FC_SHIFT));
+       bw32(bp, B44_MAC_CTRL, MAC_CTRL_CRC32_ENAB | MAC_CTRL_PHY_LEDCTRL);
+       bw32(bp, B44_RCV_LAZY, (1 << RCV_LAZY_FC_SHIFT));
 
        /* This sets the MAC address too.  */
        __b44_set_rx_mode(bp->dev);
 
        /* MTU + eth header + possible VLAN tag + struct rx_header */
-       bw32(B44_RXMAXLEN, bp->dev->mtu + ETH_HLEN + 8 + RX_HEADER_LEN);
-       bw32(B44_TXMAXLEN, bp->dev->mtu + ETH_HLEN + 8 + RX_HEADER_LEN);
+       bw32(bp, B44_RXMAXLEN, bp->dev->mtu + ETH_HLEN + 8 + RX_HEADER_LEN);
+       bw32(bp, B44_TXMAXLEN, bp->dev->mtu + ETH_HLEN + 8 + RX_HEADER_LEN);
 
-       bw32(B44_TX_WMARK, 56); /* XXX magic */
-       bw32(B44_DMATX_CTRL, DMATX_CTRL_ENABLE);
-       bw32(B44_DMATX_ADDR, bp->tx_ring_dma + bp->dma_offset);
-       bw32(B44_DMARX_CTRL, (DMARX_CTRL_ENABLE |
+       bw32(bp, B44_TX_WMARK, 56); /* XXX magic */
+       bw32(bp, B44_DMATX_CTRL, DMATX_CTRL_ENABLE);
+       bw32(bp, B44_DMATX_ADDR, bp->tx_ring_dma + bp->dma_offset);
+       bw32(bp, B44_DMARX_CTRL, (DMARX_CTRL_ENABLE |
                              (bp->rx_offset << DMARX_CTRL_ROSHIFT)));
-       bw32(B44_DMARX_ADDR, bp->rx_ring_dma + bp->dma_offset);
+       bw32(bp, B44_DMARX_ADDR, bp->rx_ring_dma + bp->dma_offset);
 
-       bw32(B44_DMARX_PTR, bp->rx_pending);
+       bw32(bp, B44_DMARX_PTR, bp->rx_pending);
        bp->rx_prod = bp->rx_pending;   
 
-       bw32(B44_MIB_CTRL, MIB_CTRL_CLR_ON_READ);
+       bw32(bp, B44_MIB_CTRL, MIB_CTRL_CLR_ON_READ);
 
-       val = br32(B44_ENET_CTRL);
-       bw32(B44_ENET_CTRL, (val | ENET_CTRL_ENABLE));
+       val = br32(bp, B44_ENET_CTRL);
+       bw32(bp, B44_ENET_CTRL, (val | ENET_CTRL_ENABLE));
 }
 
 static int b44_open(struct net_device *dev)
@@ -1286,6 +1308,19 @@ err_out_free:
 }
 #endif
 
+#ifdef CONFIG_NET_POLL_CONTROLLER
+/*
+ * Polling receive - used by netconsole and other diagnostic tools
+ * to allow network i/o with interrupts disabled.
+ */
+static void b44_poll_controller(struct net_device *dev)
+{
+       disable_irq(dev->irq);
+       b44_interrupt(dev->irq, dev, NULL);
+       enable_irq(dev->irq);
+}
+#endif
+
 static int b44_close(struct net_device *dev)
 {
        struct b44 *bp = netdev_priv(dev);
@@ -1347,7 +1382,10 @@ static struct net_device_stats *b44_get_stats(struct net_device *dev)
                                   hwstat->rx_symbol_errs);
 
        nstat->tx_aborted_errors = hwstat->tx_underruns;
+#if 0
+       /* Carrier lost counter seems to be broken for some devices */
        nstat->tx_carrier_errors = hwstat->tx_carrier_lost;
+#endif
 
        return nstat;
 }
@@ -1372,11 +1410,11 @@ static void __b44_set_rx_mode(struct net_device *dev)
        int i=0;
        unsigned char zero[6] = {0,0,0,0,0,0};
 
-       val = br32(B44_RXCONFIG);
+       val = br32(bp, B44_RXCONFIG);
        val &= ~(RXCONFIG_PROMISC | RXCONFIG_ALLMULTI);
        if (dev->flags & IFF_PROMISC) {
                val |= RXCONFIG_PROMISC;
-               bw32(B44_RXCONFIG, val);
+               bw32(bp, B44_RXCONFIG, val);
        } else {
                __b44_set_mac_addr(bp);
 
@@ -1388,9 +1426,9 @@ static void __b44_set_rx_mode(struct net_device *dev)
                for(;i<64;i++) {
                        __b44_cam_write(bp, zero, i);                   
                }
-               bw32(B44_RXCONFIG, val);
-               val = br32(B44_CAM_CTRL);
-               bw32(B44_CAM_CTRL, val | CAM_CTRL_ENABLE);
+               bw32(bp, B44_RXCONFIG, val);
+               val = br32(bp, B44_CAM_CTRL);
+               bw32(bp, B44_CAM_CTRL, val | CAM_CTRL_ENABLE);
        }
 }
 
@@ -1673,7 +1711,6 @@ static int __devinit b44_get_invariants(struct b44 *bp)
        bp->dev->dev_addr[5] = eeprom[82];
 
        bp->phy_addr = eeprom[90] & 0x1f;
-       bp->mdc_port = (eeprom[90] >> 14) & 0x1;
 
        /* With this, plus the rx_header prepended to the data by the
         * hardware, we'll land the ethernet header on a 2-byte boundary.
@@ -1683,7 +1720,7 @@ static int __devinit b44_get_invariants(struct b44 *bp)
        bp->imask = IMASK_DEF;
 
        bp->core_unit = ssb_core_unit(bp);
-       bp->dma_offset = ssb_get_addr(bp, SBID_PCI_DMA, 0);
+       bp->dma_offset = SB_PCI_DMA;
 
        /* XXX - really required? 
           bp->flags |= B44_FLAG_BUGGY_TXPTR;
@@ -1727,12 +1764,19 @@ static int __devinit b44_init_one(struct pci_dev *pdev,
 
        pci_set_master(pdev);
 
-       err = pci_set_dma_mask(pdev, (u64) 0xffffffff);
+       err = pci_set_dma_mask(pdev, (u64) B44_DMA_MASK);
        if (err) {
                printk(KERN_ERR PFX "No usable DMA configuration, "
                       "aborting.\n");
                goto err_out_free_res;
        }
+       
+       err = pci_set_consistent_dma_mask(pdev, (u64) B44_DMA_MASK);
+       if (err) {
+         printk(KERN_ERR PFX "No usable DMA configuration, "
+                "aborting.\n");
+         goto err_out_free_res;
+       }
 
        b44reg_base = pci_resource_start(pdev, 0);
        b44reg_len = pci_resource_len(pdev, 0);
@@ -1760,7 +1804,7 @@ static int __devinit b44_init_one(struct pci_dev *pdev,
 
        spin_lock_init(&bp->lock);
 
-       bp->regs = (unsigned long) ioremap(b44reg_base, b44reg_len);
+       bp->regs = ioremap(b44reg_base, b44reg_len);
        if (bp->regs == 0UL) {
                printk(KERN_ERR PFX "Cannot map device registers, "
                       "aborting.\n");
@@ -1782,6 +1826,9 @@ static int __devinit b44_init_one(struct pci_dev *pdev,
        dev->poll = b44_poll;
        dev->weight = 64;
        dev->watchdog_timeo = B44_TX_TIMEOUT;
+#ifdef CONFIG_NET_POLL_CONTROLLER
+       dev->poll_controller = b44_poll_controller;
+#endif
        dev->change_mtu = b44_change_mtu;
        dev->irq = pdev->irq;
        SET_ETHTOOL_OPS(dev, &b44_ethtool_ops);
@@ -1816,7 +1863,7 @@ static int __devinit b44_init_one(struct pci_dev *pdev,
 
        pci_set_drvdata(pdev, dev);
 
-       pci_save_state(bp->pdev, bp->pci_cfg_state);
+       pci_save_state(bp->pdev);
 
        printk(KERN_INFO "%s: Broadcom 4400 10/100BaseT Ethernet ", dev->name);
        for (i = 0; i < 6; i++)
@@ -1826,7 +1873,7 @@ static int __devinit b44_init_one(struct pci_dev *pdev,
        return 0;
 
 err_out_iounmap:
-       iounmap((void *) bp->regs);
+       iounmap(bp->regs);
 
 err_out_free_dev:
        free_netdev(dev);
@@ -1848,7 +1895,7 @@ static void __devexit b44_remove_one(struct pci_dev *pdev)
                struct b44 *bp = netdev_priv(dev);
 
                unregister_netdev(dev);
-               iounmap((void *) bp->regs);
+               iounmap(bp->regs);
                free_netdev(dev);
                pci_release_regions(pdev);
                pci_disable_device(pdev);
@@ -1859,7 +1906,7 @@ static void __devexit b44_remove_one(struct pci_dev *pdev)
 static int b44_suspend(struct pci_dev *pdev, u32 state)
 {
        struct net_device *dev = pci_get_drvdata(pdev);
-       struct b44 *bp = dev->priv;
+       struct b44 *bp = netdev_priv(dev);
 
         if (!netif_running(dev))
                  return 0;
@@ -1880,9 +1927,9 @@ static int b44_suspend(struct pci_dev *pdev, u32 state)
 static int b44_resume(struct pci_dev *pdev)
 {
        struct net_device *dev = pci_get_drvdata(pdev);
-       struct b44 *bp = dev->priv;
+       struct b44 *bp = netdev_priv(dev);
 
-       pci_restore_state(pdev, bp->pci_cfg_state);
+       pci_restore_state(pdev);
 
        if (!netif_running(dev))
                return 0;