linux 2.6.16.38 w/ vs2.0.3-rc1
[linux-2.6.git] / drivers / pci / hotplug / shpchp_hpc.c
index 66123cf..b4226ff 100644 (file)
 #define SLOT_100MHZ_PCIX_533   0x0f000000
 #define SLOT_133MHZ_PCIX_533   0xf0000000
 
+
+/* Secondary Bus Configuration Register */
+/* For PI = 1, Bits 0 to 2 have been encoded as follows to show current bus speed/mode */
+#define PCI_33MHZ              0x0
+#define PCI_66MHZ              0x1
+#define PCIX_66MHZ             0x2
+#define PCIX_100MHZ            0x3
+#define PCIX_133MHZ            0x4
+
+/* For PI = 2, Bits 0 to 3 have been encoded as follows to show current bus speed/mode */
+#define PCI_33MHZ              0x0
+#define PCI_66MHZ              0x1
+#define PCIX_66MHZ             0x2
+#define PCIX_100MHZ            0x3
+#define PCIX_133MHZ            0x4
+#define PCIX_66MHZ_ECC         0x5
+#define PCIX_100MHZ_ECC                0x6
+#define PCIX_133MHZ_ECC                0x7
+#define PCIX_66MHZ_266         0x9
+#define PCIX_100MHZ_266                0xa
+#define PCIX_133MHZ_266                0xb
+#define PCIX_66MHZ_533         0x11
+#define PCIX_100MHZ_533                0x12
+#define PCIX_133MHZ_533                0x13
+
 /* Slot Configuration */
 #define SLOT_NUM               0x0000001F
 #define        FIRST_DEV_NUM           0x00001F00
@@ -206,7 +231,6 @@ static spinlock_t list_lock;
 static irqreturn_t shpc_isr(int IRQ, void *dev_id, struct pt_regs *regs);
 
 static void start_int_poll_timer(struct php_ctlr_state_s *php_ctlr, int seconds);
-static int hpc_check_cmd_status(struct controller *ctrl);
 
 /* This is the interrupt polling timeout function. */
 static void int_poll_timeout(unsigned long lphp_ctlr)
@@ -279,13 +303,10 @@ static int shpc_write_cmd(struct slot *slot, u8 t_slot, u8 cmd)
        int i;
 
        DBG_ENTER_ROUTINE 
-
-       mutex_lock(&slot->ctrl->cmd_lock);
-
+       
        if (!php_ctlr) {
                err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
-               retval = -EINVAL;
-               goto out;
+               return -1;
        }
 
        for (i = 0; i < 10; i++) {
@@ -302,8 +323,7 @@ static int shpc_write_cmd(struct slot *slot, u8 t_slot, u8 cmd)
        if (cmd_status & 0x1) { 
                /* After 1 sec and and the controller is still busy */
                err("%s : Controller is still busy after 1 sec.\n", __FUNCTION__);
-               retval = -EBUSY;
-               goto out;
+               return -1;
        }
 
        ++t_slot;
@@ -320,17 +340,6 @@ static int shpc_write_cmd(struct slot *slot, u8 t_slot, u8 cmd)
         * Wait for command completion.
         */
        retval = shpc_wait_cmd(slot->ctrl);
-       if (retval)
-               goto out;
-
-       cmd_status = hpc_check_cmd_status(slot->ctrl);
-       if (cmd_status) {
-               err("%s: Failed to issued command 0x%x (error code = %d)\n",
-                   __FUNCTION__, cmd, cmd_status);
-               retval = -EIO;
-       }
- out:
-       mutex_unlock(&slot->ctrl->cmd_lock);
 
        DBG_LEAVE_ROUTINE 
        return retval;
@@ -523,41 +532,81 @@ static int hpc_get_prog_int(struct slot *slot, u8 *prog_int)
 
 static int hpc_get_adapter_speed(struct slot *slot, enum pci_bus_speed *value)
 {
-       int retval = 0;
        struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
-       u32 slot_reg = readl(php_ctlr->creg + SLOT1 + 4 * slot->hp_slot);
-       u8 pcix_cap = (slot_reg >> 12) & 7;
-       u8 m66_cap  = (slot_reg >> 9) & 1;
+       u32 slot_reg;
+       u16 slot_status, sec_bus_status;
+       u8 m66_cap, pcix_cap, pi;
+       int retval = 0;
 
        DBG_ENTER_ROUTINE 
 
-       dbg("%s: slot_reg = %x, pcix_cap = %x, m66_cap = %x\n",
-           __FUNCTION__, slot_reg, pcix_cap, m66_cap);
+       if (!slot->ctrl->hpc_ctlr_handle) {
+               err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
+               return -1;
+       }
 
-       switch (pcix_cap) {
-       case 0x0:
-               *value = m66_cap ? PCI_SPEED_66MHz : PCI_SPEED_33MHz;
-               break;
-       case 0x1:
-               *value = PCI_SPEED_66MHz_PCIX;
-               break;
-       case 0x3:
-               *value = PCI_SPEED_133MHz_PCIX;
-               break;
-       case 0x4:
-               *value = PCI_SPEED_133MHz_PCIX_266;
-               break;
-       case 0x5:
-               *value = PCI_SPEED_133MHz_PCIX_533;
-               break;
-       case 0x2:
-       default:
-               *value = PCI_SPEED_UNKNOWN;
-               retval = -ENODEV;
-               break;
+       if (slot->hp_slot >= php_ctlr->num_slots) {
+               err("%s: Invalid HPC slot number!\n", __FUNCTION__);
+               return -1;
+       }
+       
+       pi = readb(php_ctlr->creg + PROG_INTERFACE);
+       slot_reg = readl(php_ctlr->creg + SLOT1 + 4*(slot->hp_slot));
+       dbg("%s: pi = %d, slot_reg = %x\n", __FUNCTION__, pi, slot_reg);
+       slot_status = (u16) slot_reg;
+       dbg("%s: slot_status = %x\n", __FUNCTION__, slot_status);
+       sec_bus_status = readw(php_ctlr->creg + SEC_BUS_CONFIG);
+
+       pcix_cap = (u8) ((slot_status & 0x3000) >> 12);
+       dbg("%s:  pcix_cap = %x\n", __FUNCTION__, pcix_cap);
+       m66_cap = (u8) ((slot_status & 0x0200) >> 9);
+       dbg("%s:  m66_cap = %x\n", __FUNCTION__, m66_cap);
+
+
+       if (pi == 2) {
+               switch (pcix_cap) {
+               case 0:
+                       *value = m66_cap ? PCI_SPEED_66MHz : PCI_SPEED_33MHz;
+                       break;
+               case 1:
+                       *value = PCI_SPEED_66MHz_PCIX;
+                       break;
+               case 3:
+                       *value = PCI_SPEED_133MHz_PCIX;
+                       break;
+               case 4:
+                       *value = PCI_SPEED_133MHz_PCIX_266;     
+                       break;
+               case 5:
+                       *value = PCI_SPEED_133MHz_PCIX_533;     
+                       break;
+               case 2: /* Reserved */
+               default:
+                       *value = PCI_SPEED_UNKNOWN;
+                       retval = -ENODEV;
+                       break;
+               }
+       } else {
+               switch (pcix_cap) {
+               case 0:
+                       *value = m66_cap ? PCI_SPEED_66MHz : PCI_SPEED_33MHz;
+                       break;
+               case 1:
+                       *value = PCI_SPEED_66MHz_PCIX;
+                       break;
+               case 3:
+                       *value = PCI_SPEED_133MHz_PCIX; 
+                       break;
+               case 2: /* Reserved */
+               default:
+                       *value = PCI_SPEED_UNKNOWN;
+                       retval = -ENODEV;
+                       break;
+               }
        }
 
        dbg("Adapter speed = %d\n", *value);
+       
        DBG_LEAVE_ROUTINE 
        return retval;
 }
@@ -748,7 +797,6 @@ static void hpc_release_ctlr(struct controller *ctrl)
 {
        struct php_ctlr_state_s *php_ctlr = ctrl->hpc_ctlr_handle;
        struct php_ctlr_state_s *p, *p_prev;
-       int i;
 
        DBG_ENTER_ROUTINE 
 
@@ -757,14 +805,6 @@ static void hpc_release_ctlr(struct controller *ctrl)
                return ;
        }
 
-       /*
-        * Mask all slot event interrupts
-        */
-       for (i = 0; i < ctrl->num_slots; i++)
-               writel(0xffff3fff, php_ctlr->creg + SLOT1 + (4 * i));
-
-       cleanup_slots(ctrl);
-
        if (shpchp_poll_mode) {
            del_timer(&php_ctlr->int_poll_timer);
        } else {        
@@ -774,7 +814,6 @@ static void hpc_release_ctlr(struct controller *ctrl)
                        pci_disable_msi(php_ctlr->pci_dev);
                }
        }
-
        if (php_ctlr->pci_dev) {
                iounmap(php_ctlr->creg);
                release_mem_region(ctrl->mmio_base, ctrl->mmio_size);
@@ -900,66 +939,98 @@ static int hpc_slot_disable(struct slot * slot)
 
 static int hpc_set_bus_speed_mode(struct slot * slot, enum pci_bus_speed value)
 {
-       int retval;
+       u8 slot_cmd;
+       u8 pi;
+       int retval = 0;
        struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
-       u8 pi, cmd;
 
        DBG_ENTER_ROUTINE 
+       
+       if (!slot->ctrl->hpc_ctlr_handle) {
+               err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
+               return -1;
+       }
 
        pi = readb(php_ctlr->creg + PROG_INTERFACE);
-       if ((pi == 1) && (value > PCI_SPEED_133MHz_PCIX))
-               return -EINVAL;
+       
+       if (pi == 1) {
+               switch (value) {
+               case 0:
+                       slot_cmd = SETA_PCI_33MHZ;
+                       break;
+               case 1:
+                       slot_cmd = SETA_PCI_66MHZ;
+                       break;
+               case 2:
+                       slot_cmd = SETA_PCIX_66MHZ;
+                       break;
+               case 3:
+                       slot_cmd = SETA_PCIX_100MHZ;    
+                       break;
+               case 4:
+                       slot_cmd = SETA_PCIX_133MHZ;    
+                       break;
+               default:
+                       slot_cmd = PCI_SPEED_UNKNOWN;
+                       retval = -ENODEV;
+                       return retval;  
+               }
+       } else {
+               switch (value) {
+               case 0:
+                       slot_cmd = SETB_PCI_33MHZ;
+                       break;
+               case 1:
+                       slot_cmd = SETB_PCI_66MHZ;
+                       break;
+               case 2:
+                       slot_cmd = SETB_PCIX_66MHZ_PM;
+                       break;
+               case 3:
+                       slot_cmd = SETB_PCIX_100MHZ_PM; 
+                       break;
+               case 4:
+                       slot_cmd = SETB_PCIX_133MHZ_PM; 
+                       break;
+               case 5:
+                       slot_cmd = SETB_PCIX_66MHZ_EM;  
+                       break;
+               case 6:
+                       slot_cmd = SETB_PCIX_100MHZ_EM; 
+                       break;
+               case 7:
+                       slot_cmd = SETB_PCIX_133MHZ_EM; 
+                       break;
+               case 8:
+                       slot_cmd = SETB_PCIX_66MHZ_266; 
+                       break;
+               case 0x9:
+                       slot_cmd = SETB_PCIX_100MHZ_266;        
+                       break;
+               case 0xa:
+                       slot_cmd = SETB_PCIX_133MHZ_266;        
+                       break;
+               case 0xb:
+                       slot_cmd = SETB_PCIX_66MHZ_533; 
+                       break;
+               case 0xc:
+                       slot_cmd = SETB_PCIX_100MHZ_533;        
+                       break;
+               case 0xd:
+                       slot_cmd = SETB_PCIX_133MHZ_533;        
+                       break;
+               default:
+                       slot_cmd = PCI_SPEED_UNKNOWN;
+                       retval = -ENODEV;
+                       return retval;  
+               }
 
-       switch (value) {
-       case PCI_SPEED_33MHz:
-               cmd = SETA_PCI_33MHZ;
-               break;
-       case PCI_SPEED_66MHz:
-               cmd = SETA_PCI_66MHZ;
-               break;
-       case PCI_SPEED_66MHz_PCIX:
-               cmd = SETA_PCIX_66MHZ;
-               break;
-       case PCI_SPEED_100MHz_PCIX:
-               cmd = SETA_PCIX_100MHZ;
-               break;
-       case PCI_SPEED_133MHz_PCIX:
-               cmd = SETA_PCIX_133MHZ;
-               break;
-       case PCI_SPEED_66MHz_PCIX_ECC:
-               cmd = SETB_PCIX_66MHZ_EM;
-               break;
-       case PCI_SPEED_100MHz_PCIX_ECC:
-               cmd = SETB_PCIX_100MHZ_EM;
-               break;
-       case PCI_SPEED_133MHz_PCIX_ECC:
-               cmd = SETB_PCIX_133MHZ_EM;
-               break;
-       case PCI_SPEED_66MHz_PCIX_266:
-               cmd = SETB_PCIX_66MHZ_266;
-               break;
-       case PCI_SPEED_100MHz_PCIX_266:
-               cmd = SETB_PCIX_100MHZ_266;
-               break;
-       case PCI_SPEED_133MHz_PCIX_266:
-               cmd = SETB_PCIX_133MHZ_266;
-               break;
-       case PCI_SPEED_66MHz_PCIX_533:
-               cmd = SETB_PCIX_66MHZ_533;
-               break;
-       case PCI_SPEED_100MHz_PCIX_533:
-               cmd = SETB_PCIX_100MHZ_533;
-               break;
-       case PCI_SPEED_133MHz_PCIX_533:
-               cmd = SETB_PCIX_133MHZ_533;
-               break;
-       default:
-               return -EINVAL;
        }
-
-       retval = shpc_write_cmd(slot, 0, cmd);
-       if (retval)
+       retval = shpc_write_cmd(slot, 0, slot_cmd);
+       if (retval) {
                err("%s: Write command failed!\n", __FUNCTION__);
+               return -1;
+       }
 
        DBG_LEAVE_ROUTINE
        return retval;
@@ -1022,8 +1093,14 @@ static irqreturn_t shpc_isr(int IRQ, void *dev_id, struct pt_regs *regs)
                wake_up_interruptible(&ctrl->queue);
        }
 
-       if ((intr_loc = (intr_loc >> 1)) == 0)
-               goto out;
+       if ((intr_loc = (intr_loc >> 1)) == 0) {
+               /* Unmask Global Interrupt Mask */
+               temp_dword = readl(php_ctlr->creg + SERR_INTR_ENABLE);
+               temp_dword &= 0xfffffffe;
+               writel(temp_dword, php_ctlr->creg + SERR_INTR_ENABLE);
+
+               return IRQ_NONE;
+       }
 
        for (hp_slot = 0; hp_slot < ctrl->num_slots; hp_slot++) { 
        /* To find out which slot has interrupt pending */
@@ -1053,7 +1130,6 @@ static irqreturn_t shpc_isr(int IRQ, void *dev_id, struct pt_regs *regs)
                        dbg("%s: intr_loc2 = %x\n",__FUNCTION__, intr_loc2); 
                }
        }
- out:
        if (!shpchp_poll_mode) {
                /* Unmask Global Interrupt Mask */
                temp_dword = readl(php_ctlr->creg + SERR_INTR_ENABLE);
@@ -1066,43 +1142,64 @@ static irqreturn_t shpc_isr(int IRQ, void *dev_id, struct pt_regs *regs)
 
 static int hpc_get_max_bus_speed (struct slot *slot, enum pci_bus_speed *value)
 {
-       int retval = 0;
        struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        enum pci_bus_speed bus_speed = PCI_SPEED_UNKNOWN;
-       u8 pi = readb(php_ctlr->creg + PROG_INTERFACE);
-       u32 slot_avail1 = readl(php_ctlr->creg + SLOT_AVAIL1);
-       u32 slot_avail2 = readl(php_ctlr->creg + SLOT_AVAIL2);
+       int retval = 0;
+       u8 pi;
+       u32 slot_avail1, slot_avail2;
 
        DBG_ENTER_ROUTINE 
 
+       if (!slot->ctrl->hpc_ctlr_handle) {
+               err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
+               return -1;
+       }
+
+       if (slot->hp_slot >= php_ctlr->num_slots) {
+               err("%s: Invalid HPC slot number!\n", __FUNCTION__);
+               return -1;
+       }
+
+       pi = readb(php_ctlr->creg + PROG_INTERFACE);
+       slot_avail1 = readl(php_ctlr->creg + SLOT_AVAIL1);
+       slot_avail2 = readl(php_ctlr->creg + SLOT_AVAIL2);
+
        if (pi == 2) {
                if (slot_avail2 & SLOT_133MHZ_PCIX_533)
-                       bus_speed = PCI_SPEED_133MHz_PCIX_533;
+                       bus_speed = PCIX_133MHZ_533;
                else if (slot_avail2 & SLOT_100MHZ_PCIX_533)
-                       bus_speed = PCI_SPEED_100MHz_PCIX_533;
+                       bus_speed = PCIX_100MHZ_533;
                else if (slot_avail2 & SLOT_66MHZ_PCIX_533)
-                       bus_speed = PCI_SPEED_66MHz_PCIX_533;
+                       bus_speed = PCIX_66MHZ_533;
                else if (slot_avail2 & SLOT_133MHZ_PCIX_266)
-                       bus_speed = PCI_SPEED_133MHz_PCIX_266;
+                       bus_speed = PCIX_133MHZ_266;
                else if (slot_avail2 & SLOT_100MHZ_PCIX_266)
-                       bus_speed = PCI_SPEED_100MHz_PCIX_266;
+                       bus_speed = PCIX_100MHZ_266;
                else if (slot_avail2 & SLOT_66MHZ_PCIX_266)
-                       bus_speed = PCI_SPEED_66MHz_PCIX_266;
-       }
-
-       if (bus_speed == PCI_SPEED_UNKNOWN) {
+                       bus_speed = PCIX_66MHZ_266;
+               else if (slot_avail1 & SLOT_133MHZ_PCIX)
+                       bus_speed = PCIX_133MHZ;
+               else if (slot_avail1 & SLOT_100MHZ_PCIX)
+                       bus_speed = PCIX_100MHZ;
+               else if (slot_avail1 & SLOT_66MHZ_PCIX)
+                       bus_speed = PCIX_66MHZ;
+               else if (slot_avail2 & SLOT_66MHZ)
+                       bus_speed = PCI_66MHZ;
+               else if (slot_avail1 & SLOT_33MHZ)
+                       bus_speed = PCI_33MHZ;
+               else bus_speed = PCI_SPEED_UNKNOWN;
+       } else {
                if (slot_avail1 & SLOT_133MHZ_PCIX)
-                       bus_speed = PCI_SPEED_133MHz_PCIX;
+                       bus_speed = PCIX_133MHZ;
                else if (slot_avail1 & SLOT_100MHZ_PCIX)
-                       bus_speed = PCI_SPEED_100MHz_PCIX;
+                       bus_speed = PCIX_100MHZ;
                else if (slot_avail1 & SLOT_66MHZ_PCIX)
-                       bus_speed = PCI_SPEED_66MHz_PCIX;
+                       bus_speed = PCIX_66MHZ;
                else if (slot_avail2 & SLOT_66MHZ)
-                       bus_speed = PCI_SPEED_66MHz;
+                       bus_speed = PCI_66MHZ;
                else if (slot_avail1 & SLOT_33MHZ)
-                       bus_speed = PCI_SPEED_33MHz;
-               else
-                       retval = -ENODEV;
+                       bus_speed = PCI_33MHZ;
+               else bus_speed = PCI_SPEED_UNKNOWN;
        }
 
        *value = bus_speed;
@@ -1113,69 +1210,111 @@ static int hpc_get_max_bus_speed (struct slot *slot, enum pci_bus_speed *value)
 
 static int hpc_get_cur_bus_speed (struct slot *slot, enum pci_bus_speed *value)
 {
-       int retval = 0;
        struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        enum pci_bus_speed bus_speed = PCI_SPEED_UNKNOWN;
-       u16 sec_bus_reg = readw(php_ctlr->creg + SEC_BUS_CONFIG);
-       u8 pi = readb(php_ctlr->creg + PROG_INTERFACE);
-       u8 speed_mode = (pi == 2) ? (sec_bus_reg & 0xF) : (sec_bus_reg & 0x7);
+       u16 sec_bus_status;
+       int retval = 0;
+       u8 pi;
 
        DBG_ENTER_ROUTINE 
 
-       if ((pi == 1) && (speed_mode > 4)) {
-               *value = PCI_SPEED_UNKNOWN;
-               return -ENODEV;
+       if (!slot->ctrl->hpc_ctlr_handle) {
+               err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
+               return -1;
        }
 
-       switch (speed_mode) {
-       case 0x0:
-               *value = PCI_SPEED_33MHz;
-               break;
-       case 0x1:
-               *value = PCI_SPEED_66MHz;
-               break;
-       case 0x2:
-               *value = PCI_SPEED_66MHz_PCIX;
-               break;
-       case 0x3:
-               *value = PCI_SPEED_100MHz_PCIX;
-               break;
-       case 0x4:
-               *value = PCI_SPEED_133MHz_PCIX;
-               break;
-       case 0x5:
-               *value = PCI_SPEED_66MHz_PCIX_ECC;
-               break;
-       case 0x6:
-               *value = PCI_SPEED_100MHz_PCIX_ECC;
-               break;
-       case 0x7:
-               *value = PCI_SPEED_133MHz_PCIX_ECC;
-               break;
-       case 0x8:
-               *value = PCI_SPEED_66MHz_PCIX_266;
-               break;
-       case 0x9:
-               *value = PCI_SPEED_100MHz_PCIX_266;
-               break;
-       case 0xa:
-               *value = PCI_SPEED_133MHz_PCIX_266;
-               break;
-       case 0xb:
-               *value = PCI_SPEED_66MHz_PCIX_533;
-               break;
-       case 0xc:
-               *value = PCI_SPEED_100MHz_PCIX_533;
-               break;
-       case 0xd:
-               *value = PCI_SPEED_133MHz_PCIX_533;
-               break;
-       default:
-               *value = PCI_SPEED_UNKNOWN;
-               retval = -ENODEV;
-               break;
+       if (slot->hp_slot >= php_ctlr->num_slots) {
+               err("%s: Invalid HPC slot number!\n", __FUNCTION__);
+               return -1;
        }
 
+       pi = readb(php_ctlr->creg + PROG_INTERFACE);
+       sec_bus_status = readw(php_ctlr->creg + SEC_BUS_CONFIG);
+
+       if (pi == 2) {
+               switch (sec_bus_status & 0x000f) {
+               case 0:
+                       bus_speed = PCI_SPEED_33MHz;
+                       break;
+               case 1:
+                       bus_speed = PCI_SPEED_66MHz;
+                       break;
+               case 2:
+                       bus_speed = PCI_SPEED_66MHz_PCIX;
+                       break;
+               case 3:
+                       bus_speed = PCI_SPEED_100MHz_PCIX;      
+                       break;
+               case 4:
+                       bus_speed = PCI_SPEED_133MHz_PCIX;      
+                       break;
+               case 5:
+                       bus_speed = PCI_SPEED_66MHz_PCIX_ECC;
+                       break;
+               case 6:
+                       bus_speed = PCI_SPEED_100MHz_PCIX_ECC;
+                       break;
+               case 7:
+                       bus_speed = PCI_SPEED_133MHz_PCIX_ECC;  
+                       break;
+               case 8:
+                       bus_speed = PCI_SPEED_66MHz_PCIX_266;   
+                       break;
+               case 9:
+                       bus_speed = PCI_SPEED_100MHz_PCIX_266;  
+                       break;
+               case 0xa:
+                       bus_speed = PCI_SPEED_133MHz_PCIX_266;  
+                       break;
+               case 0xb:
+                       bus_speed = PCI_SPEED_66MHz_PCIX_533;   
+                       break;
+               case 0xc:
+                       bus_speed = PCI_SPEED_100MHz_PCIX_533;  
+                       break;
+               case 0xd:
+                       bus_speed = PCI_SPEED_133MHz_PCIX_533;  
+                       break;
+               case 0xe:
+               case 0xf:
+               default:
+                       bus_speed = PCI_SPEED_UNKNOWN;
+                       break;
+               }
+       } else {
+               /* In the case where pi is undefined, default it to 1 */ 
+               switch (sec_bus_status & 0x0007) {
+               case 0:
+                       bus_speed = PCI_SPEED_33MHz;
+                       break;
+               case 1:
+                       bus_speed = PCI_SPEED_66MHz;
+                       break;
+               case 2:
+                       bus_speed = PCI_SPEED_66MHz_PCIX;
+                       break;
+               case 3:
+                       bus_speed = PCI_SPEED_100MHz_PCIX;      
+                       break;
+               case 4:
+                       bus_speed = PCI_SPEED_133MHz_PCIX;      
+                       break;
+               case 5:
+                       bus_speed = PCI_SPEED_UNKNOWN;          /*      Reserved */
+                       break;
+               case 6:
+                       bus_speed = PCI_SPEED_UNKNOWN;          /*      Reserved */
+                       break;
+               case 7:
+                       bus_speed = PCI_SPEED_UNKNOWN;          /*      Reserved */     
+                       break;
+               default:
+                       bus_speed = PCI_SPEED_UNKNOWN;
+                       break;
+               }
+       }
+
+       *value = bus_speed;
        dbg("Current bus speed = %d\n", bus_speed);
        DBG_LEAVE_ROUTINE 
        return retval;
@@ -1204,6 +1343,7 @@ static struct hpc_ops shpchp_hpc_ops = {
        .green_led_blink                = hpc_set_green_led_blink,
        
        .release_ctlr                   = hpc_release_ctlr,
+       .check_cmd_status               = hpc_check_cmd_status,
 };
 
 inline static int shpc_indirect_creg_read(struct controller *ctrl, int index,
@@ -1235,13 +1375,15 @@ int shpc_init(struct controller * ctrl, struct pci_dev * pdev)
        ctrl->pci_dev = pdev;  /* pci_dev of the P2P bridge */
 
        spin_lock_init(&list_lock);
-       php_ctlr = kzalloc(sizeof(*php_ctlr), GFP_KERNEL);
+       php_ctlr = (struct php_ctlr_state_s *) kmalloc(sizeof(struct php_ctlr_state_s), GFP_KERNEL);
 
        if (!php_ctlr) {        /* allocate controller state data */
                err("%s: HPC controller memory allocation error!\n", __FUNCTION__);
                goto abort;
        }
 
+       memset(php_ctlr, 0, sizeof(struct php_ctlr_state_s));
+
        php_ctlr->pci_dev = pdev;       /* save pci_dev in context */
 
        if ((pdev->vendor == PCI_VENDOR_ID_AMD) || (pdev->device ==
@@ -1312,9 +1454,7 @@ int shpc_init(struct controller * ctrl, struct pci_dev * pdev)
        }
        dbg("%s: php_ctlr->creg %p\n", __FUNCTION__, php_ctlr->creg);
 
-       mutex_init(&ctrl->crit_sect);
-       mutex_init(&ctrl->cmd_lock);
-
+       init_MUTEX(&ctrl->crit_sect);
        /* Setup wait queue */
        init_waitqueue_head(&ctrl->queue);