This commit was manufactured by cvs2svn to create tag
[linux-2.6.git] / drivers / pci / msi.c
index d4c89d7..35c73b9 100644 (file)
@@ -64,13 +64,15 @@ static void msi_set_mask_bit(unsigned int vector, int flag)
        case PCI_CAP_ID_MSI:
        {
                int             pos;
-               u32             mask_bits;
+               unsigned int    mask_bits;
 
                pos = entry->mask_base;
-               pci_read_config_dword(entry->dev, pos, &mask_bits);
+               entry->dev->bus->ops->read(entry->dev->bus, entry->dev->devfn,
+                               pos, 4, &mask_bits);
                mask_bits &= ~(1);
                mask_bits |= flag;
-               pci_write_config_dword(entry->dev, pos, mask_bits);
+               entry->dev->bus->ops->write(entry->dev->bus, entry->dev->devfn,
+                               pos, 4, mask_bits);
                break;
        }
        case PCI_CAP_ID_MSIX:
@@ -103,13 +105,15 @@ static void set_msi_affinity(unsigned int vector, cpumask_t cpu_mask)
                if (!(pos = pci_find_capability(entry->dev, PCI_CAP_ID_MSI)))
                        return;
 
-               pci_read_config_dword(entry->dev, msi_lower_address_reg(pos),
+               entry->dev->bus->ops->read(entry->dev->bus, entry->dev->devfn,
+                       msi_lower_address_reg(pos), 4,
                        &address.lo_address.value);
                address.lo_address.value &= MSI_ADDRESS_DEST_ID_MASK;
                address.lo_address.value |= (cpu_mask_to_apicid(cpu_mask) <<
                        MSI_TARGET_CPU_SHIFT);
                entry->msi_attrib.current_cpu = cpu_mask_to_apicid(cpu_mask);
-               pci_write_config_dword(entry->dev, msi_lower_address_reg(pos),
+               entry->dev->bus->ops->write(entry->dev->bus, entry->dev->devfn,
+                       msi_lower_address_reg(pos), 4,
                        address.lo_address.value);
                break;
        }
@@ -154,25 +158,13 @@ static void unmask_MSI_irq(unsigned int vector)
 
 static unsigned int startup_msi_irq_wo_maskbit(unsigned int vector)
 {
-       struct msi_desc *entry;
-       unsigned long flags;
-
-       spin_lock_irqsave(&msi_lock, flags);
-       entry = msi_desc[vector];
-       if (!entry || !entry->dev) {
-               spin_unlock_irqrestore(&msi_lock, flags);
-               return 0;
-       }
-       entry->msi_attrib.state = 1;    /* Mark it active */
-       spin_unlock_irqrestore(&msi_lock, flags);
-
        return 0;       /* never anything pending */
 }
 
-static void release_msi(unsigned int vector);
+static void pci_disable_msi(unsigned int vector);
 static void shutdown_msi_irq(unsigned int vector)
 {
-       release_msi(vector);
+       pci_disable_msi(vector);
 }
 
 #define shutdown_msi_irq_wo_maskbit    shutdown_msi_irq
@@ -187,18 +179,6 @@ static void end_msi_irq_wo_maskbit(unsigned int vector)
 
 static unsigned int startup_msi_irq_w_maskbit(unsigned int vector)
 {
-       struct msi_desc *entry;
-       unsigned long flags;
-
-       spin_lock_irqsave(&msi_lock, flags);
-       entry = msi_desc[vector];
-       if (!entry || !entry->dev) {
-               spin_unlock_irqrestore(&msi_lock, flags);
-               return 0;
-       }
-       entry->msi_attrib.state = 1;    /* Mark it active */
-       spin_unlock_irqrestore(&msi_lock, flags);
-
        unmask_MSI_irq(vector);
        return 0;       /* never anything pending */
 }
@@ -220,7 +200,7 @@ static void end_msi_irq_w_maskbit(unsigned int vector)
  * which implement the MSI-X Capability Structure.
  */
 static struct hw_interrupt_type msix_irq_type = {
-       .typename       = "PCI-MSI-X",
+       .typename       = "PCI MSI-X",
        .startup        = startup_msi_irq_w_maskbit,
        .shutdown       = shutdown_msi_irq_w_maskbit,
        .enable         = enable_msi_irq_w_maskbit,
@@ -236,7 +216,7 @@ static struct hw_interrupt_type msix_irq_type = {
  * Mask-and-Pending Bits.
  */
 static struct hw_interrupt_type msi_irq_w_maskbit_type = {
-       .typename       = "PCI-MSI",
+       .typename       = "PCI MSI",
        .startup        = startup_msi_irq_w_maskbit,
        .shutdown       = shutdown_msi_irq_w_maskbit,
        .enable         = enable_msi_irq_w_maskbit,
@@ -252,7 +232,7 @@ static struct hw_interrupt_type msi_irq_w_maskbit_type = {
  * Mask-and-Pending Bits.
  */
 static struct hw_interrupt_type msi_irq_wo_maskbit_type = {
-       .typename       = "PCI-MSI",
+       .typename       = "PCI MSI",
        .startup        = startup_msi_irq_wo_maskbit,
        .shutdown       = shutdown_msi_irq_wo_maskbit,
        .enable         = enable_msi_irq_wo_maskbit,
@@ -285,7 +265,6 @@ static void msi_address_init(struct msg_address *msi_address)
        msi_address->lo_address.value |= (MSI_TARGET_CPU << MSI_TARGET_CPU_SHIFT);
 }
 
-static int msi_free_vector(struct pci_dev* dev, int vector, int reassign);
 static int assign_msi_vector(void)
 {
        static int new_vector_avail = 1;
@@ -299,8 +278,6 @@ static int assign_msi_vector(void)
        spin_lock_irqsave(&msi_lock, flags);
 
        if (!new_vector_avail) {
-               int free_vector = 0;
-
                /*
                 * vector_irq[] = -1 indicates that this specific vector is:
                 * - assigned for MSI (since MSI have no associated IRQ) or
@@ -317,34 +294,13 @@ static int assign_msi_vector(void)
                for (vector = FIRST_DEVICE_VECTOR; vector < NR_IRQS; vector++) {
                        if (vector_irq[vector] != 0)
                                continue;
-                       free_vector = vector;
-                       if (!msi_desc[vector])
-                               break;
-                       else
-                               continue;
-               }
-               if (!free_vector) {
+                       vector_irq[vector] = -1;
+                       nr_released_vectors--;
                        spin_unlock_irqrestore(&msi_lock, flags);
-                       return -EBUSY;
+                       return vector;
                }
-               vector_irq[free_vector] = -1;
-               nr_released_vectors--;
                spin_unlock_irqrestore(&msi_lock, flags);
-               if (msi_desc[free_vector] != NULL) {
-                       struct pci_dev *dev;
-                       int tail;
-
-                       /* free all linked vectors before re-assign */
-                       do {
-                               spin_lock_irqsave(&msi_lock, flags);
-                               dev = msi_desc[free_vector]->dev;
-                               tail = msi_desc[free_vector]->link.tail;
-                               spin_unlock_irqrestore(&msi_lock, flags);
-                               msi_free_vector(dev, tail, 1);
-                       } while (free_vector != tail);
-               }
-
-               return free_vector;
+               return -EBUSY;
        }
        vector = assign_irq_vector(AUTO_ASSIGN);
        last_alloc_vector = vector;
@@ -377,15 +333,6 @@ static int msi_init(void)
                printk(KERN_INFO "WARNING: MSI INIT FAILURE\n");
                return status;
        }
-       last_alloc_vector = assign_irq_vector(AUTO_ASSIGN);
-       if (last_alloc_vector < 0) {
-               pci_msi_enable = 0;
-               printk(KERN_INFO "WARNING: ALL VECTORS ARE BUSY\n");
-               status = -EBUSY;
-               return status;
-       }
-       vector_irq[last_alloc_vector] = 0;
-       nr_released_vectors++;
        printk(KERN_INFO "MSI INIT SUCCESS\n");
 
        return status;
@@ -436,49 +383,55 @@ static void irq_handler_init(int cap_id, int pos, int mask)
 
 static void enable_msi_mode(struct pci_dev *dev, int pos, int type)
 {
-       u16 control;
+       u32 control;
 
-       pci_read_config_word(dev, msi_control_reg(pos), &control);
+       dev->bus->ops->read(dev->bus, dev->devfn,
+               msi_control_reg(pos), 2, &control);
        if (type == PCI_CAP_ID_MSI) {
                /* Set enabled bits to single MSI & enable MSI_enable bit */
                msi_enable(control, 1);
-               pci_write_config_word(dev, msi_control_reg(pos), control);
+               dev->bus->ops->write(dev->bus, dev->devfn,
+                       msi_control_reg(pos), 2, control);
        } else {
                msix_enable(control);
-               pci_write_config_word(dev, msi_control_reg(pos), control);
+               dev->bus->ops->write(dev->bus, dev->devfn,
+                       msi_control_reg(pos), 2, control);
        }
        if (pci_find_capability(dev, PCI_CAP_ID_EXP)) {
                /* PCI Express Endpoint device detected */
-               u16 cmd;
-               pci_read_config_word(dev, PCI_COMMAND, &cmd);
+               u32 cmd;
+               dev->bus->ops->read(dev->bus, dev->devfn, PCI_COMMAND, 2, &cmd);
                cmd |= PCI_COMMAND_INTX_DISABLE;
-               pci_write_config_word(dev, PCI_COMMAND, cmd);
+               dev->bus->ops->write(dev->bus, dev->devfn, PCI_COMMAND, 2, cmd);
        }
 }
 
 static void disable_msi_mode(struct pci_dev *dev, int pos, int type)
 {
-       u16 control;
+       u32 control;
 
-       pci_read_config_word(dev, msi_control_reg(pos), &control);
+       dev->bus->ops->read(dev->bus, dev->devfn,
+               msi_control_reg(pos), 2, &control);
        if (type == PCI_CAP_ID_MSI) {
                /* Set enabled bits to single MSI & enable MSI_enable bit */
                msi_disable(control);
-               pci_write_config_word(dev, msi_control_reg(pos), control);
+               dev->bus->ops->write(dev->bus, dev->devfn,
+                       msi_control_reg(pos), 2, control);
        } else {
                msix_disable(control);
-               pci_write_config_word(dev, msi_control_reg(pos), control);
+               dev->bus->ops->write(dev->bus, dev->devfn,
+                       msi_control_reg(pos), 2, control);
        }
        if (pci_find_capability(dev, PCI_CAP_ID_EXP)) {
                /* PCI Express Endpoint device detected */
-               u16 cmd;
-               pci_read_config_word(dev, PCI_COMMAND, &cmd);
+               u32 cmd;
+               dev->bus->ops->read(dev->bus, dev->devfn, PCI_COMMAND, 2, &cmd);
                cmd &= ~PCI_COMMAND_INTX_DISABLE;
-               pci_write_config_word(dev, PCI_COMMAND, cmd);
+               dev->bus->ops->write(dev->bus, dev->devfn, PCI_COMMAND, 2, cmd);
        }
 }
 
-static int msi_lookup_vector(struct pci_dev *dev, int type)
+static int msi_lookup_vector(struct pci_dev *dev)
 {
        int vector;
        unsigned long flags;
@@ -486,11 +439,11 @@ static int msi_lookup_vector(struct pci_dev *dev, int type)
        spin_lock_irqsave(&msi_lock, flags);
        for (vector = FIRST_DEVICE_VECTOR; vector < NR_IRQS; vector++) {
                if (!msi_desc[vector] || msi_desc[vector]->dev != dev ||
-                       msi_desc[vector]->msi_attrib.type != type ||
+                       msi_desc[vector]->msi_attrib.entry_nr ||
                        msi_desc[vector]->msi_attrib.default_vector != dev->irq)
-                       continue;
+                       continue;       /* not entry 0, skip */
                spin_unlock_irqrestore(&msi_lock, flags);
-               /* This pre-assigned MSI vector for this device
+               /* This pre-assigned entry-0 MSI vector for this device
                   already exits. Override dev->irq with this vector */
                dev->irq = vector;
                return 0;
@@ -505,9 +458,10 @@ void pci_scan_msi_device(struct pci_dev *dev)
        if (!dev)
                return;
 
-       if (pci_find_capability(dev, PCI_CAP_ID_MSIX) > 0)
+       if (pci_find_capability(dev, PCI_CAP_ID_MSIX) > 0) {
+               nr_reserved_vectors++;
                nr_msix_devices++;
-       else if (pci_find_capability(dev, PCI_CAP_ID_MSI) > 0)
+       else if (pci_find_capability(dev, PCI_CAP_ID_MSI) > 0)
                nr_reserved_vectors++;
 }
 
@@ -526,10 +480,22 @@ static int msi_capability_init(struct pci_dev *dev)
        struct msg_address address;
        struct msg_data data;
        int pos, vector;
-       u16 control;
+       u32 control;
 
        pos = pci_find_capability(dev, PCI_CAP_ID_MSI);
-       pci_read_config_word(dev, msi_control_reg(pos), &control);
+       if (!pos)
+               return -EINVAL;
+
+       dev->bus->ops->read(dev->bus, dev->devfn, msi_control_reg(pos),
+               2, &control);
+       if (control & PCI_MSI_FLAGS_ENABLE)
+               return 0;
+
+       if (!msi_lookup_vector(dev)) {
+               /* Lookup Sucess */
+               enable_msi_mode(dev, pos, PCI_CAP_ID_MSI);
+               return 0;
+       }
        /* MSI Entry Initialization */
        if (!(entry = alloc_msi_entry()))
                return -ENOMEM;
@@ -538,14 +504,11 @@ static int msi_capability_init(struct pci_dev *dev)
                kmem_cache_free(msi_cachep, entry);
                return -EBUSY;
        }
-       entry->link.head = vector;
-       entry->link.tail = vector;
        entry->msi_attrib.type = PCI_CAP_ID_MSI;
-       entry->msi_attrib.state = 0;                    /* Mark it not active */
        entry->msi_attrib.entry_nr = 0;
        entry->msi_attrib.maskbit = is_mask_bit_support(control);
-       entry->msi_attrib.default_vector = dev->irq;    /* Save IOAPIC IRQ */
-       dev->irq = vector;
+       entry->msi_attrib.default_vector = dev->irq;
+       dev->irq = vector;      /* save default pre-assigned ioapic vector */
        entry->dev = dev;
        if (is_mask_bit_support(control)) {
                entry->mask_base = msi_mask_bits_reg(pos,
@@ -558,27 +521,27 @@ static int msi_capability_init(struct pci_dev *dev)
        msi_data_init(&data, vector);
        entry->msi_attrib.current_cpu = ((address.lo_address.u.dest_id >>
                                MSI_TARGET_CPU_SHIFT) & MSI_TARGET_CPU_MASK);
-       pci_write_config_dword(dev, msi_lower_address_reg(pos),
-                       address.lo_address.value);
+       dev->bus->ops->write(dev->bus, dev->devfn, msi_lower_address_reg(pos),
+                               4, address.lo_address.value);
        if (is_64bit_address(control)) {
-               pci_write_config_dword(dev,
-                       msi_upper_address_reg(pos), address.hi_address);
-               pci_write_config_word(dev,
-                       msi_data_reg(pos, 1), *((u32*)&data));
+               dev->bus->ops->write(dev->bus, dev->devfn,
+                       msi_upper_address_reg(pos), 4, address.hi_address);
+               dev->bus->ops->write(dev->bus, dev->devfn,
+                       msi_data_reg(pos, 1), 2, *((u32*)&data));
        } else
-               pci_write_config_word(dev,
-                       msi_data_reg(pos, 0), *((u32*)&data));
+               dev->bus->ops->write(dev->bus, dev->devfn,
+                       msi_data_reg(pos, 0), 2, *((u32*)&data));
        if (entry->msi_attrib.maskbit) {
                unsigned int maskbits, temp;
                /* All MSIs are unmasked by default, Mask them all */
-               pci_read_config_dword(dev,
-                       msi_mask_bits_reg(pos, is_64bit_address(control)),
+               dev->bus->ops->read(dev->bus, dev->devfn,
+                       msi_mask_bits_reg(pos, is_64bit_address(control)), 4,
                        &maskbits);
                temp = (1 << multi_msi_capable(control));
                temp = ((temp - 1) & ~temp);
                maskbits |= temp;
-               pci_write_config_dword(dev,
-                       msi_mask_bits_reg(pos, is_64bit_address(control)),
+               dev->bus->ops->write(dev->bus, dev->devfn,
+                       msi_mask_bits_reg(pos, is_64bit_address(control)), 4,
                        maskbits);
        }
        attach_msi_entry(entry, vector);
@@ -593,219 +556,238 @@ static int msi_capability_init(struct pci_dev *dev)
  * @dev: pointer to the pci_dev data structure of MSI-X device function
  *
  * Setup the MSI-X capability structure of device funtion with a
- * single MSI-X vector. A return of zero indicates the successful setup of
- * requested MSI-X entries with allocated vectors or non-zero for otherwise.
+ * single MSI-X vector. A return of zero indicates the successful setup
+ * of an entry zero with the new MSI-X vector or non-zero for otherwise.
+ * To request for additional MSI-X vectors, the device drivers are
+ * required to utilize the following supported APIs:
+ * 1) msi_alloc_vectors(...) for requesting one or more MSI-X vectors
+ * 2) msi_free_vectors(...) for releasing one or more MSI-X vectors
+ *    back to PCI subsystem before calling free_irq(...)
  **/
-static int msix_capability_init(struct pci_dev *dev,
-                               struct msix_entry *entries, int nvec)
+static int msix_capability_init(struct pci_dev *dev)
 {
-       struct msi_desc *head = NULL, *tail = NULL, *entry = NULL;
+       struct msi_desc *entry;
        struct msg_address address;
        struct msg_data data;
-       int vector, pos, i, j, nr_entries, temp = 0;
+       int vector = 0, pos, dev_msi_cap, i;
        u32 phys_addr, table_offset;
-       u16 control;
+       u32 control;
        u8 bir;
        void *base;
 
        pos = pci_find_capability(dev, PCI_CAP_ID_MSIX);
+       if (!pos)
+               return -EINVAL;
+
        /* Request & Map MSI-X table region */
-       pci_read_config_word(dev, msi_control_reg(pos), &control);
-       nr_entries = multi_msix_capable(control);
-       pci_read_config_dword(dev, msix_table_offset_reg(pos),
-               &table_offset);
+       dev->bus->ops->read(dev->bus, dev->devfn, msi_control_reg(pos), 2,
+               &control);
+       if (control & PCI_MSIX_FLAGS_ENABLE)
+               return 0;
+
+       if (!msi_lookup_vector(dev)) {
+               /* Lookup Sucess */
+               enable_msi_mode(dev, pos, PCI_CAP_ID_MSIX);
+               return 0;
+       }
+
+       dev_msi_cap = multi_msix_capable(control);
+       dev->bus->ops->read(dev->bus, dev->devfn,
+               msix_table_offset_reg(pos), 4, &table_offset);
        bir = (u8)(table_offset & PCI_MSIX_FLAGS_BIRMASK);
        phys_addr = pci_resource_start (dev, bir);
        phys_addr += (u32)(table_offset & ~PCI_MSIX_FLAGS_BIRMASK);
        if (!request_mem_region(phys_addr,
-               nr_entries * PCI_MSIX_ENTRY_SIZE,
-               "MSI-X vector table"))
+               dev_msi_cap * PCI_MSIX_ENTRY_SIZE,
+               "MSI-X iomap Failure"))
                return -ENOMEM;
-       base = ioremap_nocache(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
-       if (base == NULL) {
-               release_mem_region(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
-               return -ENOMEM;
-       }
-       /* MSI-X Table Initialization */
-       for (i = 0; i < nvec; i++) {
-               entry = alloc_msi_entry();
-               if (!entry)
-                       break;
-               if ((vector = get_msi_vector(dev)) < 0)
-                       break;
+       base = ioremap_nocache(phys_addr, dev_msi_cap * PCI_MSIX_ENTRY_SIZE);
+       if (base == NULL)
+               goto free_region;
+       /* MSI Entry Initialization */
+       entry = alloc_msi_entry();
+       if (!entry)
+               goto free_iomap;
+       if ((vector = get_msi_vector(dev)) < 0)
+               goto free_entry;
 
-               j = entries[i].entry;
-               entries[i].vector = vector;
-               entry->msi_attrib.type = PCI_CAP_ID_MSIX;
-               entry->msi_attrib.state = 0;            /* Mark it not active */
-               entry->msi_attrib.entry_nr = j;
-               entry->msi_attrib.maskbit = 1;
-               entry->msi_attrib.default_vector = dev->irq;
-               entry->dev = dev;
-               entry->mask_base = (unsigned long)base;
-               if (!head) {
-                       entry->link.head = vector;
-                       entry->link.tail = vector;
-                       head = entry;
-               } else {
-                       entry->link.head = temp;
-                       entry->link.tail = tail->link.tail;
-                       tail->link.tail = vector;
-                       head->link.head = vector;
-               }
-               temp = vector;
-               tail = entry;
-               /* Replace with MSI-X handler */
-               irq_handler_init(PCI_CAP_ID_MSIX, vector, 1);
-               /* Configure MSI-X capability structure */
-               msi_address_init(&address);
-               msi_data_init(&data, vector);
-               entry->msi_attrib.current_cpu =
-                       ((address.lo_address.u.dest_id >>
-                       MSI_TARGET_CPU_SHIFT) & MSI_TARGET_CPU_MASK);
-               writel(address.lo_address.value,
-                       base + j * PCI_MSIX_ENTRY_SIZE +
+       entry->msi_attrib.type = PCI_CAP_ID_MSIX;
+       entry->msi_attrib.entry_nr = 0;
+       entry->msi_attrib.maskbit = 1;
+       entry->msi_attrib.default_vector = dev->irq;
+       dev->irq = vector;      /* save default pre-assigned ioapic vector */
+       entry->dev = dev;
+       entry->mask_base = (unsigned long)base;
+       /* Replace with MSI handler */
+       irq_handler_init(PCI_CAP_ID_MSIX, vector, 1);
+       /* Configure MSI-X capability structure */
+       msi_address_init(&address);
+       msi_data_init(&data, vector);
+       entry->msi_attrib.current_cpu = ((address.lo_address.u.dest_id >>
+                               MSI_TARGET_CPU_SHIFT) & MSI_TARGET_CPU_MASK);
+       writel(address.lo_address.value, base + PCI_MSIX_ENTRY_LOWER_ADDR_OFFSET);
+       writel(address.hi_address, base + PCI_MSIX_ENTRY_UPPER_ADDR_OFFSET);
+       writel(*(u32*)&data, base + PCI_MSIX_ENTRY_DATA_OFFSET);
+       /* Initialize all entries from 1 up to 0 */
+       for (i = 1; i < dev_msi_cap; i++) {
+               writel(0, base + i * PCI_MSIX_ENTRY_SIZE +
                        PCI_MSIX_ENTRY_LOWER_ADDR_OFFSET);
-               writel(address.hi_address,
-                       base + j * PCI_MSIX_ENTRY_SIZE +
+               writel(0, base + i * PCI_MSIX_ENTRY_SIZE +
                        PCI_MSIX_ENTRY_UPPER_ADDR_OFFSET);
-               writel(*(u32*)&data,
-                       base + j * PCI_MSIX_ENTRY_SIZE +
+               writel(0, base + i * PCI_MSIX_ENTRY_SIZE +
                        PCI_MSIX_ENTRY_DATA_OFFSET);
-               attach_msi_entry(entry, vector);
        }
-       if (i != nvec) {
-               i--;
-               for (; i >= 0; i--) {
-                       vector = (entries + i)->vector;
-                       msi_free_vector(dev, vector, 0);
-                       (entries + i)->vector = 0;
-               }
-               return -EBUSY;
-       }
-       /* Set MSI-X enabled bits */
+       attach_msi_entry(entry, vector);
+       /* Set MSI enabled bits  */
        enable_msi_mode(dev, pos, PCI_CAP_ID_MSIX);
 
        return 0;
+
+free_entry:
+       kmem_cache_free(msi_cachep, entry);
+free_iomap:
+       iounmap(base);
+free_region:
+       release_mem_region(phys_addr, dev_msi_cap * PCI_MSIX_ENTRY_SIZE);
+
+       return ((vector < 0) ? -EBUSY : -ENOMEM);
 }
 
 /**
- * pci_enable_msi - configure device's MSI capability structure
- * @dev: pointer to the pci_dev data structure of MSI device function
+ * pci_enable_msi - configure device's MSI(X) capability structure
+ * @dev: pointer to the pci_dev data structure of MSI(X) device function
  *
- * Setup the MSI capability structure of device function with
- * a single MSI vector upon its software driver call to request for
- * MSI mode enabled on its hardware device function. A return of zero
- * indicates the successful setup of an entry zero with the new MSI
+ * Setup the MSI/MSI-X capability structure of device function with
+ * a single MSI(X) vector upon its software driver call to request for
+ * MSI(X) mode enabled on its hardware device function. A return of zero
+ * indicates the successful setup of an entry zero with the new MSI(X)
  * vector or non-zero for otherwise.
  **/
 int pci_enable_msi(struct pci_dev* dev)
 {
-       int pos, temp = dev->irq, status = -EINVAL;
-       u16 control;
+       int status = -EINVAL;
 
        if (!pci_msi_enable || !dev)
                return status;
 
-       if ((status = msi_init()) < 0)
-               return status;
-
-       if (!(pos = pci_find_capability(dev, PCI_CAP_ID_MSI)))
-               return -EINVAL;
-
-       pci_read_config_word(dev, msi_control_reg(pos), &control);
-       if (control & PCI_MSI_FLAGS_ENABLE)
-               return 0;                       /* Already in MSI mode */
-
-       if (!msi_lookup_vector(dev, PCI_CAP_ID_MSI)) {
-               /* Lookup Sucess */
-               unsigned long flags;
+       if (msi_init() < 0)
+               return -ENOMEM;
 
-               spin_lock_irqsave(&msi_lock, flags);
-               if (!vector_irq[dev->irq]) {
-                       msi_desc[dev->irq]->msi_attrib.state = 0;
-                       vector_irq[dev->irq] = -1;
-                       nr_released_vectors--;
-                       spin_unlock_irqrestore(&msi_lock, flags);
-                       enable_msi_mode(dev, pos, PCI_CAP_ID_MSI);
-                       return 0;
-               }
-               spin_unlock_irqrestore(&msi_lock, flags);
-               dev->irq = temp;
-       }
-       /* Check whether driver already requested for MSI-X vectors */
-       if ((pos = pci_find_capability(dev, PCI_CAP_ID_MSIX)) > 0 &&
-               !msi_lookup_vector(dev, PCI_CAP_ID_MSIX)) {
-                       printk(KERN_INFO "Can't enable MSI. Device already had MSI-X vectors assigned\n");
-                       dev->irq = temp;
-                       return -EINVAL;
-       }
-       status = msi_capability_init(dev);
-       if (!status) {
-               if (!pos)
-                       nr_reserved_vectors--;  /* Only MSI capable */
-               else if (nr_msix_devices > 0)
-                       nr_msix_devices--;      /* Both MSI and MSI-X capable,
-                                                  but choose enabling MSI */
-       }
+       if ((status = msix_capability_init(dev)) == -EINVAL)
+               status = msi_capability_init(dev);
+       if (!status)
+               nr_reserved_vectors--;
 
        return status;
 }
 
-void pci_disable_msi(struct pci_dev* dev)
+static int msi_free_vector(struct pci_dev* dev, int vector);
+static void pci_disable_msi(unsigned int vector)
 {
+       int head, tail, type, default_vector;
        struct msi_desc *entry;
-       int pos, default_vector;
-       u16 control;
+       struct pci_dev *dev;
        unsigned long flags;
 
-       if (!dev || !(pos = pci_find_capability(dev, PCI_CAP_ID_MSI)))
-               return;
-
-       pci_read_config_word(dev, msi_control_reg(pos), &control);
-       if (!(control & PCI_MSI_FLAGS_ENABLE))
-               return;
-
        spin_lock_irqsave(&msi_lock, flags);
-       entry = msi_desc[dev->irq];
-       if (!entry || !entry->dev || entry->msi_attrib.type != PCI_CAP_ID_MSI) {
+       entry = msi_desc[vector];
+       if (!entry || !entry->dev) {
                spin_unlock_irqrestore(&msi_lock, flags);
                return;
        }
-       if (entry->msi_attrib.state) {
-               spin_unlock_irqrestore(&msi_lock, flags);
-               printk(KERN_DEBUG "Driver[%d:%d:%d] unloaded wo doing free_irq on vector->%d\n",
-               dev->bus->number, PCI_SLOT(dev->devfn), PCI_FUNC(dev->devfn),
-               dev->irq);
-               BUG_ON(entry->msi_attrib.state > 0);
-       } else {
-               vector_irq[dev->irq] = 0; /* free it */
-               nr_released_vectors++;
-               default_vector = entry->msi_attrib.default_vector;
-               spin_unlock_irqrestore(&msi_lock, flags);
-               /* Restore dev->irq to its default pin-assertion vector */
-               dev->irq = default_vector;
-               disable_msi_mode(dev, pci_find_capability(dev, PCI_CAP_ID_MSI),
-                                       PCI_CAP_ID_MSI);
+       dev = entry->dev;
+       type = entry->msi_attrib.type;
+       head = entry->link.head;
+       tail = entry->link.tail;
+       default_vector = entry->msi_attrib.default_vector;
+       spin_unlock_irqrestore(&msi_lock, flags);
+
+       disable_msi_mode(dev, pci_find_capability(dev, type), type);
+       /* Restore dev->irq to its default pin-assertion vector */
+       dev->irq = default_vector;
+       if (type == PCI_CAP_ID_MSIX && head != tail) {
+               /* Bad driver, which do not call msi_free_vectors before exit.
+                  We must do a cleanup here */
+               while (1) {
+                       spin_lock_irqsave(&msi_lock, flags);
+                       entry = msi_desc[vector];
+                       head = entry->link.head;
+                       tail = entry->link.tail;
+                       spin_unlock_irqrestore(&msi_lock, flags);
+                       if (tail == head)
+                               break;
+                       if (msi_free_vector(dev, entry->link.tail))
+                               break;
+               }
        }
 }
 
-static void release_msi(unsigned int vector)
+static int msi_alloc_vector(struct pci_dev* dev, int head)
 {
        struct msi_desc *entry;
+       struct msg_address address;
+       struct msg_data data;
+       int i, offset, pos, dev_msi_cap, vector;
+       u32 low_address, control;
+       unsigned long base = 0L;
        unsigned long flags;
 
        spin_lock_irqsave(&msi_lock, flags);
-       entry = msi_desc[vector];
-       if (entry && entry->dev)
-               entry->msi_attrib.state = 0;    /* Mark it not active */
+       entry = msi_desc[dev->irq];
+       if (!entry) {
+               spin_unlock_irqrestore(&msi_lock, flags);
+               return -EINVAL;
+       }
+       base = entry->mask_base;
        spin_unlock_irqrestore(&msi_lock, flags);
+
+       pos = pci_find_capability(dev, PCI_CAP_ID_MSIX);
+       dev->bus->ops->read(dev->bus, dev->devfn, msi_control_reg(pos),
+               2, &control);
+       dev_msi_cap = multi_msix_capable(control);
+       for (i = 1; i < dev_msi_cap; i++) {
+               if (!(low_address = readl(base + i * PCI_MSIX_ENTRY_SIZE)))
+                        break;
+       }
+       if (i >= dev_msi_cap)
+               return -EINVAL;
+
+       /* MSI Entry Initialization */
+       if (!(entry = alloc_msi_entry()))
+               return -ENOMEM;
+
+       if ((vector = get_new_vector()) < 0) {
+               kmem_cache_free(msi_cachep, entry);
+               return vector;
+       }
+       entry->msi_attrib.type = PCI_CAP_ID_MSIX;
+       entry->msi_attrib.entry_nr = i;
+       entry->msi_attrib.maskbit = 1;
+       entry->dev = dev;
+       entry->link.head = head;
+       entry->mask_base = base;
+       irq_handler_init(PCI_CAP_ID_MSIX, vector, 1);
+       /* Configure MSI-X capability structure */
+       msi_address_init(&address);
+       msi_data_init(&data, vector);
+       entry->msi_attrib.current_cpu = ((address.lo_address.u.dest_id >>
+                               MSI_TARGET_CPU_SHIFT) & MSI_TARGET_CPU_MASK);
+       offset = entry->msi_attrib.entry_nr * PCI_MSIX_ENTRY_SIZE;
+       writel(address.lo_address.value, base + offset +
+               PCI_MSIX_ENTRY_LOWER_ADDR_OFFSET);
+       writel(address.hi_address, base + offset +
+               PCI_MSIX_ENTRY_UPPER_ADDR_OFFSET);
+       writel(*(u32*)&data, base + offset + PCI_MSIX_ENTRY_DATA_OFFSET);
+       writel(1, base + offset + PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET);
+       attach_msi_entry(entry, vector);
+
+       return vector;
 }
 
-static int msi_free_vector(struct pci_dev* dev, int vector, int reassign)
+static int msi_free_vector(struct pci_dev* dev, int vector)
 {
        struct msi_desc *entry;
-       int head, entry_nr, type;
+       int entry_nr, type;
        unsigned long base = 0L;
        unsigned long flags;
 
@@ -817,177 +799,66 @@ static int msi_free_vector(struct pci_dev* dev, int vector, int reassign)
        }
        type = entry->msi_attrib.type;
        entry_nr = entry->msi_attrib.entry_nr;
-       head = entry->link.head;
        base = entry->mask_base;
-       msi_desc[entry->link.head]->link.tail = entry->link.tail;
-       msi_desc[entry->link.tail]->link.head = entry->link.head;
-       entry->dev = NULL;
-       if (!reassign) {
-               vector_irq[vector] = 0;
-               nr_released_vectors++;
+       if (entry->link.tail != entry->link.head) {
+               msi_desc[entry->link.head]->link.tail = entry->link.tail;
+               if (entry->link.tail)
+                       msi_desc[entry->link.tail]->link.head = entry->link.head;
        }
+       entry->dev = NULL;
+       vector_irq[vector] = 0;
+       nr_released_vectors++;
        msi_desc[vector] = NULL;
        spin_unlock_irqrestore(&msi_lock, flags);
 
        kmem_cache_free(msi_cachep, entry);
-
        if (type == PCI_CAP_ID_MSIX) {
-               if (!reassign)
-                       writel(1, base +
-                               entry_nr * PCI_MSIX_ENTRY_SIZE +
-                               PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET);
-
-               if (head == vector) {
-                       /*
-                        * Detect last MSI-X vector to be released.
-                        * Release the MSI-X memory-mapped table.
-                        */
-                       int pos, nr_entries;
-                       u32 phys_addr, table_offset;
-                       u16 control;
-                       u8 bir;
-
-                       pos = pci_find_capability(dev, PCI_CAP_ID_MSIX);
-                       pci_read_config_word(dev, msi_control_reg(pos),
-                               &control);
-                       nr_entries = multi_msix_capable(control);
-                       pci_read_config_dword(dev, msix_table_offset_reg(pos),
-                               &table_offset);
-                       bir = (u8)(table_offset & PCI_MSIX_FLAGS_BIRMASK);
-                       phys_addr = pci_resource_start (dev, bir);
-                       phys_addr += (u32)(table_offset &
-                               ~PCI_MSIX_FLAGS_BIRMASK);
-                       iounmap((void*)base);
-                       release_mem_region(phys_addr,
-                               nr_entries * PCI_MSIX_ENTRY_SIZE);
-               }
-       }
+               int offset;
 
-       return 0;
-}
-
-static int reroute_msix_table(int head, struct msix_entry *entries, int *nvec)
-{
-       int vector = head, tail = 0;
-       int i = 0, j = 0, nr_entries = 0;
-       unsigned long base = 0L;
-       unsigned long flags;
-
-       spin_lock_irqsave(&msi_lock, flags);
-       while (head != tail) {
-               nr_entries++;
-               tail = msi_desc[vector]->link.tail;
-               if (entries[0].entry == msi_desc[vector]->msi_attrib.entry_nr)
-                       j = vector;
-               vector = tail;
+               offset = entry_nr * PCI_MSIX_ENTRY_SIZE;
+               writel(1, base + offset + PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET);
+               writel(0, base + offset + PCI_MSIX_ENTRY_LOWER_ADDR_OFFSET);
        }
-       if (*nvec > nr_entries) {
-               spin_unlock_irqrestore(&msi_lock, flags);
-               *nvec = nr_entries;
-               return -EINVAL;
-       }
-       vector = ((j > 0) ? j : head);
-       for (i = 0; i < *nvec; i++) {
-               j = msi_desc[vector]->msi_attrib.entry_nr;
-               msi_desc[vector]->msi_attrib.state = 0; /* Mark it not active */
-               vector_irq[vector] = -1;                /* Mark it busy */
-               nr_released_vectors--;
-               entries[i].vector = vector;
-               if (j != (entries + i)->entry) {
-                       base = msi_desc[vector]->mask_base;
-                       msi_desc[vector]->msi_attrib.entry_nr =
-                               (entries + i)->entry;
-                       writel( readl(base + j * PCI_MSIX_ENTRY_SIZE +
-                               PCI_MSIX_ENTRY_LOWER_ADDR_OFFSET), base +
-                               (entries + i)->entry * PCI_MSIX_ENTRY_SIZE +
-                               PCI_MSIX_ENTRY_LOWER_ADDR_OFFSET);
-                       writel( readl(base + j * PCI_MSIX_ENTRY_SIZE +
-                               PCI_MSIX_ENTRY_UPPER_ADDR_OFFSET), base +
-                               (entries + i)->entry * PCI_MSIX_ENTRY_SIZE +
-                               PCI_MSIX_ENTRY_UPPER_ADDR_OFFSET);
-                       writel( (readl(base + j * PCI_MSIX_ENTRY_SIZE +
-                               PCI_MSIX_ENTRY_DATA_OFFSET) & 0xff00) | vector,
-                               base + (entries+i)->entry*PCI_MSIX_ENTRY_SIZE +
-                               PCI_MSIX_ENTRY_DATA_OFFSET);
-               }
-               vector = msi_desc[vector]->link.tail;
-       }
-       spin_unlock_irqrestore(&msi_lock, flags);
 
        return 0;
 }
 
 /**
- * pci_enable_msix - configure device's MSI-X capability structure
+ * msi_alloc_vectors - allocate additional MSI-X vectors
  * @dev: pointer to the pci_dev data structure of MSI-X device function
- * @data: pointer to an array of MSI-X entries
+ * @vector: pointer to an array of new allocated MSI-X vectors
  * @nvec: number of MSI-X vectors requested for allocation by device driver
  *
- * Setup the MSI-X capability structure of device function with the number
- * of requested vectors upon its software driver call to request for
- * MSI-X mode enabled on its hardware device function. A return of zero
- * indicates the successful configuration of MSI-X capability structure
- * with new allocated MSI-X vectors. A return of < 0 indicates a failure.
- * Or a return of > 0 indicates that driver request is exceeding the number
- * of vectors available. Driver should use the returned value to re-send
- * its request.
+ * Allocate additional MSI-X vectors requested by device driver. A
+ * return of zero indicates the successful setup of MSI-X capability
+ * structure with new allocated MSI-X vectors or non-zero for otherwise.
  **/
-int pci_enable_msix(struct pci_dev* dev, struct msix_entry *entries, int nvec)
+int msi_alloc_vectors(struct pci_dev* dev, int *vector, int nvec)
 {
-       int status, pos, nr_entries, free_vectors;
-       int i, j, temp;
-       u16 control;
+       struct msi_desc *entry;
+       int i, head, pos, vec, free_vectors, alloc_vectors;
+       int *vectors = (int *)vector;
+       u32 control;
        unsigned long flags;
 
-       if (!pci_msi_enable || !dev || !entries)
+       if (!pci_msi_enable || !dev)
                return -EINVAL;
 
-       if ((status = msi_init()) < 0)
-               return status;
-
        if (!(pos = pci_find_capability(dev, PCI_CAP_ID_MSIX)))
                return -EINVAL;
 
-       pci_read_config_word(dev, msi_control_reg(pos), &control);
-       if (control & PCI_MSIX_FLAGS_ENABLE)
-               return -EINVAL;                 /* Already in MSI-X mode */
-
-       nr_entries = multi_msix_capable(control);
-       if (nvec > nr_entries)
+       dev->bus->ops->read(dev->bus, dev->devfn, msi_control_reg(pos),                         2, &control);
+       if (nvec > multi_msix_capable(control))
                return -EINVAL;
 
-       /* Check for any invalid entries */
-       for (i = 0; i < nvec; i++) {
-               if (entries[i].entry >= nr_entries)
-                       return -EINVAL;         /* invalid entry */
-               for (j = i + 1; j < nvec; j++) {
-                       if (entries[i].entry == entries[j].entry)
-                               return -EINVAL; /* duplicate entry */
-               }
-       }
-       temp = dev->irq;
-       if (!msi_lookup_vector(dev, PCI_CAP_ID_MSIX)) {
-               /* Lookup Sucess */
-               nr_entries = nvec;
-               /* Reroute MSI-X table */
-               if (reroute_msix_table(dev->irq, entries, &nr_entries)) {
-                       /* #requested > #previous-assigned */
-                       dev->irq = temp;
-                       return nr_entries;
-               }
-               dev->irq = temp;
-               enable_msi_mode(dev, pos, PCI_CAP_ID_MSIX);
-               return 0;
-       }
-       /* Check whether driver already requested for MSI vector */
-       if (pci_find_capability(dev, PCI_CAP_ID_MSI) > 0 &&
-               !msi_lookup_vector(dev, PCI_CAP_ID_MSI)) {
-               printk(KERN_INFO "Can't enable MSI-X. Device already had MSI vector assigned\n");
-               dev->irq = temp;
+       spin_lock_irqsave(&msi_lock, flags);
+       entry = msi_desc[dev->irq];
+       if (!entry || entry->dev != dev ||              /* legal call */
+          entry->msi_attrib.type != PCI_CAP_ID_MSIX || /* must be MSI-X */
+          entry->link.head != entry->link.tail) {      /* already multi */
+               spin_unlock_irqrestore(&msi_lock, flags);
                return -EINVAL;
        }
-
-       spin_lock_irqsave(&msi_lock, flags);
        /*
         * msi_lock is provided to ensure that enough vectors resources are
         * available before granting.
@@ -1003,65 +874,71 @@ int pci_enable_msix(struct pci_dev* dev, struct msix_entry *entries, int nvec)
                free_vectors /= nr_msix_devices;
        spin_unlock_irqrestore(&msi_lock, flags);
 
-       if (nvec > free_vectors) {
-               if (free_vectors > 0)
-                       return free_vectors;
-               else
-                       return -EBUSY;
-       }
+       if (nvec > free_vectors)
+               return -EBUSY;
 
-       status = msix_capability_init(dev, entries, nvec);
-       if (!status && nr_msix_devices > 0)
+       alloc_vectors = 0;
+       head = dev->irq;
+       for (i = 0; i < nvec; i++) {
+               if ((vec = msi_alloc_vector(dev, head)) < 0)
+                       break;
+               *(vectors + i) = vec;
+               head = vec;
+               alloc_vectors++;
+       }
+       if (alloc_vectors != nvec) {
+               for (i = 0; i < alloc_vectors; i++) {
+                       vec = *(vectors + i);
+                       msi_free_vector(dev, vec);
+               }
+               spin_lock_irqsave(&msi_lock, flags);
+               msi_desc[dev->irq]->link.tail = msi_desc[dev->irq]->link.head;
+               spin_unlock_irqrestore(&msi_lock, flags);
+               return -EBUSY;
+       }
+       if (nr_msix_devices > 0)
                nr_msix_devices--;
 
-       return status;
+       return 0;
 }
 
-void pci_disable_msix(struct pci_dev* dev)
+/**
+ * msi_free_vectors - reclaim MSI-X vectors to unused state
+ * @dev: pointer to the pci_dev data structure of MSI-X device function
+ * @vector: pointer to an array of released MSI-X vectors
+ * @nvec: number of MSI-X vectors requested for release by device driver
+ *
+ * Reclaim MSI-X vectors released by device driver to unused state,
+ * which may be used later on. A return of zero indicates the
+ * success or non-zero for otherwise. Device driver should call this
+ * before calling function free_irq.
+ **/
+int msi_free_vectors(struct pci_dev* dev, int *vector, int nvec)
 {
-       int pos, temp;
-       u16 control;
-
-       if (!dev || !(pos = pci_find_capability(dev, PCI_CAP_ID_MSIX)))
-               return;
-
-       pci_read_config_word(dev, msi_control_reg(pos), &control);
-       if (!(control & PCI_MSIX_FLAGS_ENABLE))
-               return;
+       struct msi_desc *entry;
+       int i;
+       unsigned long flags;
 
-       temp = dev->irq;
-       if (!msi_lookup_vector(dev, PCI_CAP_ID_MSIX)) {
-               int state, vector, head, tail = 0, warning = 0;
-               unsigned long flags;
+       if (!pci_msi_enable)
+               return -EINVAL;
 
-               vector = head = dev->irq;
-               spin_lock_irqsave(&msi_lock, flags);
-               while (head != tail) {
-                       state = msi_desc[vector]->msi_attrib.state;
-                       if (state)
-                               warning = 1;
-                       else {
-                               vector_irq[vector] = 0; /* free it */
-                               nr_released_vectors++;
-                       }
-                       tail = msi_desc[vector]->link.tail;
-                       vector = tail;
-               }
+       spin_lock_irqsave(&msi_lock, flags);
+       entry = msi_desc[dev->irq];
+       if (!entry || entry->dev != dev ||
+               entry->msi_attrib.type != PCI_CAP_ID_MSIX ||
+               entry->link.head == entry->link.tail) { /* Nothing to free */
                spin_unlock_irqrestore(&msi_lock, flags);
-               if (warning) {
-                       dev->irq = temp;
-                       printk(KERN_DEBUG "Driver[%d:%d:%d] unloaded wo doing free_irq on all vectors\n",
-                       dev->bus->number, PCI_SLOT(dev->devfn),
-                       PCI_FUNC(dev->devfn));
-                       BUG_ON(warning > 0);
-               } else {
-                       dev->irq = temp;
-                       disable_msi_mode(dev,
-                               pci_find_capability(dev, PCI_CAP_ID_MSIX),
-                               PCI_CAP_ID_MSIX);
+               return -EINVAL;
+       }
+       spin_unlock_irqrestore(&msi_lock, flags);
 
-               }
+       for (i = 0; i < nvec; i++) {
+               if (*(vector + i) == dev->irq)
+                       continue;/* Don't free entry 0 if mistaken by driver */
+               msi_free_vector(dev, *(vector + i));
        }
+
+       return 0;
 }
 
 /**
@@ -1075,73 +952,62 @@ void pci_disable_msix(struct pci_dev* dev)
  **/
 void msi_remove_pci_irq_vectors(struct pci_dev* dev)
 {
-       int state, pos, temp;
+       struct msi_desc *entry;
+       int type, temp;
        unsigned long flags;
 
        if (!pci_msi_enable || !dev)
                return;
 
-       temp = dev->irq;                /* Save IOAPIC IRQ */
-       if ((pos = pci_find_capability(dev, PCI_CAP_ID_MSI)) > 0 &&
-               !msi_lookup_vector(dev, PCI_CAP_ID_MSI)) {
-               spin_lock_irqsave(&msi_lock, flags);
-               state = msi_desc[dev->irq]->msi_attrib.state;
+       if (!pci_find_capability(dev, PCI_CAP_ID_MSI)) {
+               if (!pci_find_capability(dev, PCI_CAP_ID_MSIX))
+                       return;
+       }
+       temp = dev->irq;
+       if (msi_lookup_vector(dev))
+               return;
+
+       spin_lock_irqsave(&msi_lock, flags);
+       entry = msi_desc[dev->irq];
+       if (!entry || entry->dev != dev) {
                spin_unlock_irqrestore(&msi_lock, flags);
-               if (state) {
-                       printk(KERN_DEBUG "Driver[%d:%d:%d] unloaded wo doing free_irq on vector->%d\n",
-                       dev->bus->number, PCI_SLOT(dev->devfn),
-                       PCI_FUNC(dev->devfn), dev->irq);
-                       BUG_ON(state > 0);
-               } else /* Release MSI vector assigned to this device */
-                       msi_free_vector(dev, dev->irq, 0);
-               dev->irq = temp;                /* Restore IOAPIC IRQ */
+               return;
        }
-       if ((pos = pci_find_capability(dev, PCI_CAP_ID_MSIX)) > 0 &&
-               !msi_lookup_vector(dev, PCI_CAP_ID_MSIX)) {
-               int vector, head, tail = 0, warning = 0;
-               unsigned long base = 0L;
+       type = entry->msi_attrib.type;
+       spin_unlock_irqrestore(&msi_lock, flags);
 
-               vector = head = dev->irq;
-               while (head != tail) {
+       msi_free_vector(dev, dev->irq);
+       if (type == PCI_CAP_ID_MSIX) {
+               int i, pos, dev_msi_cap;
+               u32 phys_addr, table_offset;
+               u32 control;
+               u8 bir;
+
+               pos = pci_find_capability(dev, PCI_CAP_ID_MSIX);
+               dev->bus->ops->read(dev->bus, dev->devfn, msi_control_reg(pos),                         2, &control);
+               dev_msi_cap = multi_msix_capable(control);
+               dev->bus->ops->read(dev->bus, dev->devfn,
+                       msix_table_offset_reg(pos), 4, &table_offset);
+               bir = (u8)(table_offset & PCI_MSIX_FLAGS_BIRMASK);
+               phys_addr = pci_resource_start (dev, bir);
+               phys_addr += (u32)(table_offset & ~PCI_MSIX_FLAGS_BIRMASK);
+               for (i = FIRST_DEVICE_VECTOR; i < NR_IRQS; i++) {
                        spin_lock_irqsave(&msi_lock, flags);
-                       state = msi_desc[vector]->msi_attrib.state;
-                       tail = msi_desc[vector]->link.tail;
-                       base = msi_desc[vector]->mask_base;
+                       if (!msi_desc[i] || msi_desc[i]->dev != dev) {
+                               spin_unlock_irqrestore(&msi_lock, flags);
+                               continue;
+                       }
                        spin_unlock_irqrestore(&msi_lock, flags);
-                       if (state)
-                               warning = 1;
-                       else if (vector != head) /* Release MSI-X vector */
-                               msi_free_vector(dev, vector, 0);
-                       vector = tail;
-               }
-               msi_free_vector(dev, vector, 0);
-               if (warning) {
-                       /* Force to release the MSI-X memory-mapped table */
-                       u32 phys_addr, table_offset;
-                       u16 control;
-                       u8 bir;
-
-                       pci_read_config_word(dev, msi_control_reg(pos),
-                               &control);
-                       pci_read_config_dword(dev, msix_table_offset_reg(pos),
-                               &table_offset);
-                       bir = (u8)(table_offset & PCI_MSIX_FLAGS_BIRMASK);
-                       phys_addr = pci_resource_start (dev, bir);
-                       phys_addr += (u32)(table_offset &
-                               ~PCI_MSIX_FLAGS_BIRMASK);
-                       iounmap((void*)base);
-                       release_mem_region(phys_addr, PCI_MSIX_ENTRY_SIZE *
-                               multi_msix_capable(control));
-                       printk(KERN_DEBUG "Driver[%d:%d:%d] unloaded wo doing free_irq on all vectors\n",
-                               dev->bus->number, PCI_SLOT(dev->devfn),
-                               PCI_FUNC(dev->devfn));
-                       BUG_ON(warning > 0);
+                       msi_free_vector(dev, i);
                }
-               dev->irq = temp;                /* Restore IOAPIC IRQ */
+               writel(1, entry->mask_base + PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET);
+               iounmap((void*)entry->mask_base);
+               release_mem_region(phys_addr, dev_msi_cap * PCI_MSIX_ENTRY_SIZE);
        }
+       dev->irq = temp;
+       nr_reserved_vectors++;
 }
 
 EXPORT_SYMBOL(pci_enable_msi);
-EXPORT_SYMBOL(pci_disable_msi);
-EXPORT_SYMBOL(pci_enable_msix);
-EXPORT_SYMBOL(pci_disable_msix);
+EXPORT_SYMBOL(msi_alloc_vectors);
+EXPORT_SYMBOL(msi_free_vectors);