Fedora kernel-2.6.17-1.2142_FC4 patched with stable patch-2.6.17.4-vs2.0.2-rc26.diff
[linux-2.6.git] / drivers / usb / core / devio.c
index 776c1bf..545da37 100644 (file)
@@ -21,7 +21,7 @@
  *
  *  $Id: devio.c,v 1.7 2000/02/01 17:28:48 fliegl Exp $
  *
- *  This file implements the usbdevfs/x/y files, where
+ *  This file implements the usbfs/x/y files, where
  *  x is the bus number and y the device number.
  *
  *  It allows user space programs/"drivers" to communicate directly
@@ -30,6 +30,8 @@
  *  Revision history
  *    22.12.1999   0.1   Initial release (split from proc_usb.c)
  *    04.01.2000   0.2   Turned into its own filesystem
+ *    30.09.2005   0.3   Fix user-triggerable oops in async URB delivery
+ *                      (CAN-2005-3055)
  */
 
 /*****************************************************************************/
@@ -43,6 +45,8 @@
 #include <linux/module.h>
 #include <linux/usb.h>
 #include <linux/usbdevice_fs.h>
+#include <linux/cdev.h>
+#include <linux/notifier.h>
 #include <asm/uaccess.h>
 #include <asm/byteorder.h>
 #include <linux/moduleparam.h>
 #include "hcd.h"       /* for usbcore internals */
 #include "usb.h"
 
+#define USB_MAXBUS                     64
+#define USB_DEVICE_MAX                 USB_MAXBUS * 128
+static struct class *usb_device_class;
+
 struct async {
        struct list_head asynclist;
        struct dev_state *ps;
-       struct task_struct *task;
+       pid_t pid;
+       uid_t uid, euid;
        unsigned int signr;
        unsigned int ifnum;
        void __user *userbuffer;
@@ -71,6 +80,8 @@ MODULE_PARM_DESC (usbfs_snoop, "true to log all usbfs traffic");
                        dev_info( dev , format , ## arg);       \
        } while (0)
 
+#define USB_DEVICE_DEV         MKDEV(USB_DEVICE_MAJOR, 0)
+
 
 #define        MAX_USBFS_BUFFER_SIZE   16384
 
@@ -113,7 +124,7 @@ static ssize_t usbdev_read(struct file *file, char __user *buf, size_t nbytes, l
        int i;
 
        pos = *ppos;
-       down(&dev->serialize);
+       usb_lock_device(dev);
        if (!connected(dev)) {
                ret = -ENODEV;
                goto err;
@@ -123,10 +134,18 @@ static ssize_t usbdev_read(struct file *file, char __user *buf, size_t nbytes, l
        }
 
        if (pos < sizeof(struct usb_device_descriptor)) {
+               struct usb_device_descriptor temp_desc ; /* 18 bytes - fits on the stack */
+
+               memcpy(&temp_desc, &dev->descriptor, sizeof(dev->descriptor));
+               le16_to_cpus(&temp_desc.bcdUSB);
+               le16_to_cpus(&temp_desc.idVendor);
+               le16_to_cpus(&temp_desc.idProduct);
+               le16_to_cpus(&temp_desc.bcdDevice);
+
                len = sizeof(struct usb_device_descriptor) - pos;
                if (len > nbytes)
                        len = nbytes;
-               if (copy_to_user(buf, ((char *)&dev->descriptor) + pos, len)) {
+               if (copy_to_user(buf, ((char *)&temp_desc) + pos, len)) {
                        ret = -EFAULT;
                        goto err;
                }
@@ -148,7 +167,7 @@ static ssize_t usbdev_read(struct file *file, char __user *buf, size_t nbytes, l
                        /* The descriptor may claim to be longer than it
                         * really is.  Here is the actual allocated length. */
                        unsigned alloclen =
-                               dev->config[i].desc.wTotalLength;
+                               le16_to_cpu(dev->config[i].desc.wTotalLength);
 
                        len = length - (*ppos - pos);
                        if (len > nbytes)
@@ -175,7 +194,7 @@ static ssize_t usbdev_read(struct file *file, char __user *buf, size_t nbytes, l
        }
 
 err:
-       up(&dev->serialize);
+       usb_unlock_device(dev);
        return ret;
 }
 
@@ -186,10 +205,10 @@ err:
 static struct async *alloc_async(unsigned int numisoframes)
 {
         unsigned int assize = sizeof(struct async) + numisoframes * sizeof(struct usb_iso_packet_descriptor);
-        struct async *as = kmalloc(assize, GFP_KERNEL);
+        struct async *as = kzalloc(assize, GFP_KERNEL);
+
         if (!as)
                 return NULL;
-        memset(as, 0, assize);
        as->urb = usb_alloc_urb(numisoframes, GFP_KERNEL);
        if (!as->urb) {
                kfree(as);
@@ -200,12 +219,10 @@ static struct async *alloc_async(unsigned int numisoframes)
 
 static void free_async(struct async *as)
 {
-        if (as->urb->transfer_buffer)
-                kfree(as->urb->transfer_buffer);
-        if (as->urb->setup_packet)
-                kfree(as->urb->setup_packet);
+       kfree(as->urb->transfer_buffer);
+       kfree(as->urb->setup_packet);
        usb_free_urb(as->urb);
-        kfree(as);
+       kfree(as);
 }
 
 static inline void async_newpending(struct async *as)
@@ -258,6 +275,28 @@ static inline struct async *async_getpending(struct dev_state *ps, void __user *
         return NULL;
 }
 
+static void snoop_urb(struct urb *urb, void __user *userurb)
+{
+       int j;
+       unsigned char *data = urb->transfer_buffer;
+
+       if (!usbfs_snoop)
+               return;
+
+       if (urb->pipe & USB_DIR_IN)
+               dev_info(&urb->dev->dev, "direction=IN\n");
+       else
+               dev_info(&urb->dev->dev, "direction=OUT\n");
+       dev_info(&urb->dev->dev, "userurb=%p\n", userurb);
+       dev_info(&urb->dev->dev, "transfer_buffer_length=%d\n",
+                urb->transfer_buffer_length);
+       dev_info(&urb->dev->dev, "actual_length=%d\n", urb->actual_length);
+       dev_info(&urb->dev->dev, "data: ");
+       for (j = 0; j < urb->transfer_buffer_length; ++j)
+               printk ("%02x ", data[j]);
+       printk("\n");
+}
+
 static void async_completed(struct urb *urb, struct pt_regs *regs)
 {
         struct async *as = (struct async *)urb->context;
@@ -272,9 +311,12 @@ static void async_completed(struct urb *urb, struct pt_regs *regs)
                sinfo.si_errno = as->urb->status;
                sinfo.si_code = SI_ASYNCIO;
                sinfo.si_addr = as->userurb;
-               send_sig_info(as->signr, &sinfo, as->task);
+               kill_proc_info_as_uid(as->signr, &sinfo, as->pid, as->uid, 
+                                     as->euid);
        }
-        wake_up(&ps->wait);
+       snoop(&urb->dev->dev, "urb complete\n");
+       snoop_urb(urb, as->userurb);
+       wake_up(&ps->wait);
 }
 
 static void destroy_async (struct dev_state *ps, struct list_head *list)
@@ -286,9 +328,10 @@ static void destroy_async (struct dev_state *ps, struct list_head *list)
        while (!list_empty(list)) {
                as = list_entry(list->next, struct async, asynclist);
                list_del_init(&as->asynclist);
+
+               /* drop the spinlock so the completion handler can run */
                spin_unlock_irqrestore(&ps->lock, flags);
-                /* usb_unlink_urb calls the completion handler with status == -ENOENT */
-               usb_unlink_urb(as->urb);
+               usb_kill_urb(as->urb);
                spin_lock_irqsave(&ps->lock, flags);
        }
        spin_unlock_irqrestore(&ps->lock, flags);
@@ -353,8 +396,7 @@ static void driver_disconnect(struct usb_interface *intf)
        destroy_async_on_interface(ps, ifnum);
 }
 
-struct usb_driver usbdevfs_driver = {
-       .owner =        THIS_MODULE,
+struct usb_driver usbfs_driver = {
        .name =         "usbfs",
        .probe =        driver_probe,
        .disconnect =   driver_disconnect,
@@ -378,7 +420,7 @@ static int claimintf(struct dev_state *ps, unsigned int ifnum)
        if (!intf)
                err = -ENOENT;
        else
-               err = usb_driver_claim_interface(&usbdevfs_driver, intf, ps);
+               err = usb_driver_claim_interface(&usbfs_driver, intf, ps);
        up_write(&usb_bus_type.subsys.rwsem);
        if (err == 0)
                set_bit(ifnum, &ps->ifclaimed);
@@ -401,7 +443,7 @@ static int releaseintf(struct dev_state *ps, unsigned int ifnum)
        if (!intf)
                err = -ENOENT;
        else if (test_and_clear_bit(ifnum, &ps->ifclaimed)) {
-               usb_driver_release_interface(&usbdevfs_driver, intf);
+               usb_driver_release_interface(&usbfs_driver, intf);
                err = 0;
        }
        up_write(&usb_bus_type.subsys.rwsem);
@@ -410,6 +452,8 @@ static int releaseintf(struct dev_state *ps, unsigned int ifnum)
 
 static int checkintf(struct dev_state *ps, unsigned int ifnum)
 {
+       if (ps->dev->state != USB_STATE_CONFIGURED)
+               return -EHOSTUNREACH;
        if (ifnum >= 8*sizeof(ps->ifclaimed))
                return -EINVAL;
        if (test_bit(ifnum, &ps->ifclaimed))
@@ -449,6 +493,9 @@ static int check_ctrlrecip(struct dev_state *ps, unsigned int requesttype, unsig
 {
        int ret = 0;
 
+       if (ps->dev->state != USB_STATE_ADDRESS
+        && ps->dev->state != USB_STATE_CONFIGURED)
+               return -EHOSTUNREACH;
        if (USB_TYPE_VENDOR == (USB_TYPE_MASK & requesttype))
                return 0;
 
@@ -466,12 +513,29 @@ static int check_ctrlrecip(struct dev_state *ps, unsigned int requesttype, unsig
        return ret;
 }
 
+static struct usb_device *usbdev_lookup_minor(int minor)
+{
+       struct class_device *class_dev;
+       struct usb_device *dev = NULL;
+
+       down(&usb_device_class->sem);
+       list_for_each_entry(class_dev, &usb_device_class->children, node) {
+               if (class_dev->devt == MKDEV(USB_DEVICE_MAJOR, minor)) {
+                       dev = class_dev->class_data;
+                       break;
+               }
+       }
+       up(&usb_device_class->sem);
+
+       return dev;
+};
+
 /*
  * file operations
  */
 static int usbdev_open(struct inode *inode, struct file *file)
 {
-       struct usb_device *dev;
+       struct usb_device *dev = NULL;
        struct dev_state *ps;
        int ret;
 
@@ -485,11 +549,16 @@ static int usbdev_open(struct inode *inode, struct file *file)
 
        lock_kernel();
        ret = -ENOENT;
-       dev = usb_get_dev(inode->u.generic_ip);
+       /* check if we are called from a real node or usbfs */
+       if (imajor(inode) == USB_DEVICE_MAJOR)
+               dev = usbdev_lookup_minor(iminor(inode));
+       if (!dev)
+               dev = inode->u.generic_ip;
        if (!dev) {
                kfree(ps);
                goto out;
        }
+       usb_get_dev(dev);
        ret = 0;
        ps->dev = dev;
        ps->file = file;
@@ -498,7 +567,9 @@ static int usbdev_open(struct inode *inode, struct file *file)
        INIT_LIST_HEAD(&ps->async_completed);
        init_waitqueue_head(&ps->wait);
        ps->discsignr = 0;
-       ps->disctask = current;
+       ps->disc_pid = current->pid;
+       ps->disc_uid = current->uid;
+       ps->disc_euid = current->euid;
        ps->disccontext = NULL;
        ps->ifclaimed = 0;
        wmb();
@@ -516,16 +587,15 @@ static int usbdev_release(struct inode *inode, struct file *file)
        struct usb_device *dev = ps->dev;
        unsigned int ifnum;
 
-       down(&dev->serialize);
+       usb_lock_device(dev);
        list_del_init(&ps->list);
-
-       if (connected(dev)) {
-               for (ifnum = 0; ps->ifclaimed && ifnum < 8*sizeof(ps->ifclaimed); ifnum++)
-                       if (test_bit(ifnum, &ps->ifclaimed))
-                               releaseintf(ps, ifnum);
-               destroy_all_async(ps);
+       for (ifnum = 0; ps->ifclaimed && ifnum < 8*sizeof(ps->ifclaimed);
+                       ifnum++) {
+               if (test_bit(ifnum, &ps->ifclaimed))
+                       releaseintf(ps, ifnum);
        }
-       up(&dev->serialize);
+       destroy_all_async(ps);
+       usb_unlock_device(dev);
        usb_put_dev(dev);
        ps->dev = NULL;
        kfree(ps);
@@ -548,27 +618,30 @@ static int proc_control(struct dev_state *ps, void __user *arg)
                return -EINVAL;
        if (!(tbuf = (unsigned char *)__get_free_page(GFP_KERNEL)))
                return -ENOMEM;
-       tmo = (ctrl.timeout * HZ + 999) / 1000;
+       tmo = ctrl.timeout;
        if (ctrl.bRequestType & 0x80) {
                if (ctrl.wLength && !access_ok(VERIFY_WRITE, ctrl.data, ctrl.wLength)) {
                        free_page((unsigned long)tbuf);
                        return -EINVAL;
                }
-               snoop(&dev->dev, "control read: bRequest=%02x bRrequestType=%02x wValue=%04x wIndex=%04x\n", 
-                       ctrl.bRequest, ctrl.bRequestType, ctrl.wValue, ctrl.wIndex);
+               snoop(&dev->dev, "control read: bRequest=%02x "
+                               "bRrequestType=%02x wValue=%04x "
+                               "wIndex=%04x wLength=%04x\n",
+                       ctrl.bRequest, ctrl.bRequestType, ctrl.wValue,
+                               ctrl.wIndex, ctrl.wLength);
 
-               up(&dev->serialize);
+               usb_unlock_device(dev);
                i = usb_control_msg(dev, usb_rcvctrlpipe(dev, 0), ctrl.bRequest, ctrl.bRequestType,
                                       ctrl.wValue, ctrl.wIndex, tbuf, ctrl.wLength, tmo);
-               down(&dev->serialize);
+               usb_lock_device(dev);
                if ((i > 0) && ctrl.wLength) {
                        if (usbfs_snoop) {
                                dev_info(&dev->dev, "control read: data ");
-                               for (j = 0; j < ctrl.wLength; ++j)
-                                       printk ("%02x ", (unsigned char)(tbuf)[j]);
+                               for (j = 0; j < i; ++j)
+                                       printk("%02x ", (unsigned char)(tbuf)[j]);
                                printk("\n");
                        }
-                       if (copy_to_user(ctrl.data, tbuf, ctrl.wLength)) {
+                       if (copy_to_user(ctrl.data, tbuf, i)) {
                                free_page((unsigned long)tbuf);
                                return -EFAULT;
                        }
@@ -580,21 +653,24 @@ static int proc_control(struct dev_state *ps, void __user *arg)
                                return -EFAULT;
                        }
                }
-               snoop(&dev->dev, "control write: bRequest=%02x bRrequestType=%02x wValue=%04x wIndex=%04x\n", 
-                       ctrl.bRequest, ctrl.bRequestType, ctrl.wValue, ctrl.wIndex);
+               snoop(&dev->dev, "control write: bRequest=%02x "
+                               "bRrequestType=%02x wValue=%04x "
+                               "wIndex=%04x wLength=%04x\n",
+                       ctrl.bRequest, ctrl.bRequestType, ctrl.wValue,
+                               ctrl.wIndex, ctrl.wLength);
                if (usbfs_snoop) {
                        dev_info(&dev->dev, "control write: data: ");
                        for (j = 0; j < ctrl.wLength; ++j)
-                               printk ("%02x ", (unsigned char)(tbuf)[j]);
+                               printk("%02x ", (unsigned char)(tbuf)[j]);
                        printk("\n");
                }
-               up(&dev->serialize);
+               usb_unlock_device(dev);
                i = usb_control_msg(dev, usb_sndctrlpipe(dev, 0), ctrl.bRequest, ctrl.bRequestType,
                                       ctrl.wValue, ctrl.wIndex, tbuf, ctrl.wLength, tmo);
-               down(&dev->serialize);
+               usb_lock_device(dev);
        }
        free_page((unsigned long)tbuf);
-       if (i<0) {
+       if (i<0 && i != -EPIPE) {
                dev_printk(KERN_DEBUG, &dev->dev, "usbfs: USBDEVFS_CONTROL "
                           "failed cmd %s rqt %u rq %u len %u ret %d\n",
                           current->comm, ctrl.bRequestType, ctrl.bRequest,
@@ -610,7 +686,7 @@ static int proc_bulk(struct dev_state *ps, void __user *arg)
        unsigned int tmo, len1, pipe;
        int len2;
        unsigned char *tbuf;
-       int i, ret;
+       int i, j, ret;
 
        if (copy_from_user(&bulk, arg, sizeof(bulk)))
                return -EFAULT;
@@ -629,16 +705,24 @@ static int proc_bulk(struct dev_state *ps, void __user *arg)
                return -EINVAL;
        if (!(tbuf = kmalloc(len1, GFP_KERNEL)))
                return -ENOMEM;
-       tmo = (bulk.timeout * HZ + 999) / 1000;
+       tmo = bulk.timeout;
        if (bulk.ep & 0x80) {
                if (len1 && !access_ok(VERIFY_WRITE, bulk.data, len1)) {
                        kfree(tbuf);
                        return -EINVAL;
                }
-               up(&dev->serialize);
+               snoop(&dev->dev, "bulk read: len=0x%02x timeout=%04d\n",
+                       bulk.len, bulk.timeout);
+               usb_unlock_device(dev);
                i = usb_bulk_msg(dev, pipe, tbuf, len1, &len2, tmo);
-               down(&dev->serialize);
+               usb_lock_device(dev);
                if (!i && len2) {
+                       if (usbfs_snoop) {
+                               dev_info(&dev->dev, "bulk read: data ");
+                               for (j = 0; j < len2; ++j)
+                                       printk("%02x ", (unsigned char)(tbuf)[j]);
+                               printk("\n");
+                       }
                        if (copy_to_user(bulk.data, tbuf, len2)) {
                                kfree(tbuf);
                                return -EFAULT;
@@ -651,16 +735,21 @@ static int proc_bulk(struct dev_state *ps, void __user *arg)
                                return -EFAULT;
                        }
                }
-               up(&dev->serialize);
+               snoop(&dev->dev, "bulk write: len=0x%02x timeout=%04d\n",
+                       bulk.len, bulk.timeout);
+               if (usbfs_snoop) {
+                       dev_info(&dev->dev, "bulk write: data: ");
+                       for (j = 0; j < len1; ++j)
+                               printk("%02x ", (unsigned char)(tbuf)[j]);
+                       printk("\n");
+               }
+               usb_unlock_device(dev);
                i = usb_bulk_msg(dev, pipe, tbuf, len1, &len2, tmo);
-               down(&dev->serialize);
+               usb_lock_device(dev);
        }
        kfree(tbuf);
-       if (i < 0) {
-               dev_warn(&dev->dev, "usbfs: USBDEVFS_BULK failed "
-                        "ep 0x%x len %u ret %d\n", bulk.ep, bulk.len, i);
+       if (i < 0)
                return i;
-       }
        return len2;
 }
 
@@ -734,7 +823,7 @@ static int proc_connectinfo(struct dev_state *ps, void __user *arg)
 
 static int proc_resetdevice(struct dev_state *ps)
 {
-       return __usb_reset_device(ps->dev);
+       return usb_reset_device(ps->dev);
 
 }
 
@@ -772,16 +861,16 @@ static int proc_setconfig(struct dev_state *ps, void __user *arg)
                for (i = 0; i < actconfig->desc.bNumInterfaces; ++i) {
                        if (usb_interface_claimed(actconfig->interface[i])) {
                                dev_warn (&ps->dev->dev,
-                                       "usbfs: interface %d claimed "
+                                       "usbfs: interface %d claimed by %s "
                                        "while '%s' sets config #%d\n",
                                        actconfig->interface[i]
                                                ->cur_altsetting
                                                ->desc.bInterfaceNumber,
+                                       actconfig->interface[i]
+                                               ->dev.driver->name,
                                        current->comm, u);
-#if 0  /* FIXME:  enable in 2.6.10 or so */
                                status = -EBUSY;
                                break;
-#endif
                        }
                }
        }
@@ -799,49 +888,51 @@ static int proc_setconfig(struct dev_state *ps, void __user *arg)
        return status;
 }
 
-static int proc_submiturb(struct dev_state *ps, void __user *arg)
+static int proc_do_submiturb(struct dev_state *ps, struct usbdevfs_urb *uurb,
+                            struct usbdevfs_iso_packet_desc __user *iso_frame_desc,
+                            void __user *arg)
 {
-       struct usbdevfs_urb uurb;
        struct usbdevfs_iso_packet_desc *isopkt = NULL;
-       struct usb_endpoint_descriptor *ep_desc;
+       struct usb_host_endpoint *ep;
        struct async *as;
        struct usb_ctrlrequest *dr = NULL;
        unsigned int u, totlen, isofrmlen;
        int ret, interval = 0, ifnum = -1;
 
-       if (copy_from_user(&uurb, arg, sizeof(uurb)))
-               return -EFAULT;
-       if (uurb.flags & ~(USBDEVFS_URB_ISO_ASAP|USBDEVFS_URB_SHORT_NOT_OK|
+       if (uurb->flags & ~(USBDEVFS_URB_ISO_ASAP|USBDEVFS_URB_SHORT_NOT_OK|
                           URB_NO_FSBR|URB_ZERO_PACKET))
                return -EINVAL;
-       if (!uurb.buffer)
+       if (!uurb->buffer)
                return -EINVAL;
-       if (uurb.signr != 0 && (uurb.signr < SIGRTMIN || uurb.signr > SIGRTMAX))
+       if (uurb->signr != 0 && (uurb->signr < SIGRTMIN || uurb->signr > SIGRTMAX))
                return -EINVAL;
-       if (!(uurb.type == USBDEVFS_URB_TYPE_CONTROL && (uurb.endpoint & ~USB_ENDPOINT_DIR_MASK) == 0)) {
-               if ((ifnum = findintfep(ps->dev, uurb.endpoint)) < 0)
+       if (!(uurb->type == USBDEVFS_URB_TYPE_CONTROL && (uurb->endpoint & ~USB_ENDPOINT_DIR_MASK) == 0)) {
+               if ((ifnum = findintfep(ps->dev, uurb->endpoint)) < 0)
                        return ifnum;
                if ((ret = checkintf(ps, ifnum)))
                        return ret;
        }
-       switch(uurb.type) {
+       if ((uurb->endpoint & USB_ENDPOINT_DIR_MASK) != 0)
+               ep = ps->dev->ep_in [uurb->endpoint & USB_ENDPOINT_NUMBER_MASK];
+       else
+               ep = ps->dev->ep_out [uurb->endpoint & USB_ENDPOINT_NUMBER_MASK];
+       if (!ep)
+               return -ENOENT;
+       switch(uurb->type) {
        case USBDEVFS_URB_TYPE_CONTROL:
-               if ((uurb.endpoint & ~USB_ENDPOINT_DIR_MASK) != 0) {
-                       if (!(ep_desc = usb_epnum_to_ep_desc(ps->dev, uurb.endpoint)))
-                               return -ENOENT;
-                       if ((ep_desc->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) != USB_ENDPOINT_XFER_CONTROL)
-                               return -EINVAL;
-               }
+               if ((ep->desc.bmAttributes & USB_ENDPOINT_XFERTYPE_MASK)
+                               != USB_ENDPOINT_XFER_CONTROL)
+                       return -EINVAL;
                /* min 8 byte setup packet, max arbitrary */
-               if (uurb.buffer_length < 8 || uurb.buffer_length > PAGE_SIZE)
+               if (uurb->buffer_length < 8 || uurb->buffer_length > PAGE_SIZE)
                        return -EINVAL;
                if (!(dr = kmalloc(sizeof(struct usb_ctrlrequest), GFP_KERNEL)))
                        return -ENOMEM;
-               if (copy_from_user(dr, uurb.buffer, 8)) {
+               if (copy_from_user(dr, uurb->buffer, 8)) {
                        kfree(dr);
                        return -EFAULT;
                }
-               if (uurb.buffer_length < (le16_to_cpup(&dr->wLength) + 8)) {
+               if (uurb->buffer_length < (le16_to_cpup(&dr->wLength) + 8)) {
                        kfree(dr);
                        return -EINVAL;
                }
@@ -849,39 +940,48 @@ static int proc_submiturb(struct dev_state *ps, void __user *arg)
                        kfree(dr);
                        return ret;
                }
-               uurb.endpoint = (uurb.endpoint & ~USB_ENDPOINT_DIR_MASK) | (dr->bRequestType & USB_ENDPOINT_DIR_MASK);
-               uurb.number_of_packets = 0;
-               uurb.buffer_length = le16_to_cpup(&dr->wLength);
-               uurb.buffer += 8;
-               if (!access_ok((uurb.endpoint & USB_DIR_IN) ?  VERIFY_WRITE : VERIFY_READ, uurb.buffer, uurb.buffer_length)) {
+               uurb->endpoint = (uurb->endpoint & ~USB_ENDPOINT_DIR_MASK) | (dr->bRequestType & USB_ENDPOINT_DIR_MASK);
+               uurb->number_of_packets = 0;
+               uurb->buffer_length = le16_to_cpup(&dr->wLength);
+               uurb->buffer += 8;
+               if (!access_ok((uurb->endpoint & USB_DIR_IN) ?  VERIFY_WRITE : VERIFY_READ, uurb->buffer, uurb->buffer_length)) {
                        kfree(dr);
                        return -EFAULT;
                }
+               snoop(&ps->dev->dev, "control urb\n");
                break;
 
        case USBDEVFS_URB_TYPE_BULK:
-               uurb.number_of_packets = 0;
-               if (uurb.buffer_length > MAX_USBFS_BUFFER_SIZE)
+               switch (ep->desc.bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) {
+               case USB_ENDPOINT_XFER_CONTROL:
+               case USB_ENDPOINT_XFER_ISOC:
                        return -EINVAL;
-               if (!access_ok((uurb.endpoint & USB_DIR_IN) ? VERIFY_WRITE : VERIFY_READ, uurb.buffer, uurb.buffer_length))
+               /* allow single-shot interrupt transfers, at bogus rates */
+               }
+               uurb->number_of_packets = 0;
+               if (uurb->buffer_length > MAX_USBFS_BUFFER_SIZE)
+                       return -EINVAL;
+               if (!access_ok((uurb->endpoint & USB_DIR_IN) ? VERIFY_WRITE : VERIFY_READ, uurb->buffer, uurb->buffer_length))
                        return -EFAULT;
+               snoop(&ps->dev->dev, "bulk urb\n");
                break;
 
        case USBDEVFS_URB_TYPE_ISO:
                /* arbitrary limit */
-               if (uurb.number_of_packets < 1 || uurb.number_of_packets > 128)
+               if (uurb->number_of_packets < 1 || uurb->number_of_packets > 128)
+                       return -EINVAL;
+               if ((ep->desc.bmAttributes & USB_ENDPOINT_XFERTYPE_MASK)
+                               != USB_ENDPOINT_XFER_ISOC)
                        return -EINVAL;
-               if (!(ep_desc = usb_epnum_to_ep_desc(ps->dev, uurb.endpoint)))
-                       return -ENOENT;
-               interval = 1 << min (15, ep_desc->bInterval - 1);
-               isofrmlen = sizeof(struct usbdevfs_iso_packet_desc) * uurb.number_of_packets;
+               interval = 1 << min (15, ep->desc.bInterval - 1);
+               isofrmlen = sizeof(struct usbdevfs_iso_packet_desc) * uurb->number_of_packets;
                if (!(isopkt = kmalloc(isofrmlen, GFP_KERNEL)))
                        return -ENOMEM;
-               if (copy_from_user(isopkt, &((struct usbdevfs_urb __user *)arg)->iso_frame_desc, isofrmlen)) {
+               if (copy_from_user(isopkt, iso_frame_desc, isofrmlen)) {
                        kfree(isopkt);
                        return -EFAULT;
                }
-               for (totlen = u = 0; u < uurb.number_of_packets; u++) {
+               for (totlen = u = 0; u < uurb->number_of_packets; u++) {
                        if (isopkt[u].length > 1023) {
                                kfree(isopkt);
                                return -EINVAL;
@@ -892,73 +992,75 @@ static int proc_submiturb(struct dev_state *ps, void __user *arg)
                        kfree(isopkt);
                        return -EINVAL;
                }
-               uurb.buffer_length = totlen;
+               uurb->buffer_length = totlen;
+               snoop(&ps->dev->dev, "iso urb\n");
                break;
 
        case USBDEVFS_URB_TYPE_INTERRUPT:
-               uurb.number_of_packets = 0;
-               if (!(ep_desc = usb_epnum_to_ep_desc(ps->dev, uurb.endpoint)))
-                       return -ENOENT;
+               uurb->number_of_packets = 0;
+               if ((ep->desc.bmAttributes & USB_ENDPOINT_XFERTYPE_MASK)
+                               != USB_ENDPOINT_XFER_INT)
+                       return -EINVAL;
                if (ps->dev->speed == USB_SPEED_HIGH)
-                       interval = 1 << min (15, ep_desc->bInterval - 1);
+                       interval = 1 << min (15, ep->desc.bInterval - 1);
                else
-                       interval = ep_desc->bInterval;
-               if (uurb.buffer_length > MAX_USBFS_BUFFER_SIZE)
+                       interval = ep->desc.bInterval;
+               if (uurb->buffer_length > MAX_USBFS_BUFFER_SIZE)
                        return -EINVAL;
-               if (!access_ok((uurb.endpoint & USB_DIR_IN) ? VERIFY_WRITE : VERIFY_READ, uurb.buffer, uurb.buffer_length))
+               if (!access_ok((uurb->endpoint & USB_DIR_IN) ? VERIFY_WRITE : VERIFY_READ, uurb->buffer, uurb->buffer_length))
                        return -EFAULT;
+               snoop(&ps->dev->dev, "interrupt urb\n");
                break;
 
        default:
                return -EINVAL;
        }
-       if (!(as = alloc_async(uurb.number_of_packets))) {
-               if (isopkt)
-                       kfree(isopkt);
-               if (dr)
-                       kfree(dr);
+       if (!(as = alloc_async(uurb->number_of_packets))) {
+               kfree(isopkt);
+               kfree(dr);
                return -ENOMEM;
        }
-       if (!(as->urb->transfer_buffer = kmalloc(uurb.buffer_length, GFP_KERNEL))) {
-               if (isopkt)
-                       kfree(isopkt);
-               if (dr)
-                       kfree(dr);
+       if (!(as->urb->transfer_buffer = kmalloc(uurb->buffer_length, GFP_KERNEL))) {
+               kfree(isopkt);
+               kfree(dr);
                free_async(as);
                return -ENOMEM;
        }
         as->urb->dev = ps->dev;
-        as->urb->pipe = (uurb.type << 30) | __create_pipe(ps->dev, uurb.endpoint & 0xf) | (uurb.endpoint & USB_DIR_IN);
-        as->urb->transfer_flags = uurb.flags;
-       as->urb->transfer_buffer_length = uurb.buffer_length;
+        as->urb->pipe = (uurb->type << 30) | __create_pipe(ps->dev, uurb->endpoint & 0xf) | (uurb->endpoint & USB_DIR_IN);
+        as->urb->transfer_flags = uurb->flags;
+       as->urb->transfer_buffer_length = uurb->buffer_length;
        as->urb->setup_packet = (unsigned char*)dr;
-       as->urb->start_frame = uurb.start_frame;
-       as->urb->number_of_packets = uurb.number_of_packets;
+       as->urb->start_frame = uurb->start_frame;
+       as->urb->number_of_packets = uurb->number_of_packets;
        as->urb->interval = interval;
         as->urb->context = as;
         as->urb->complete = async_completed;
-       for (totlen = u = 0; u < uurb.number_of_packets; u++) {
+       for (totlen = u = 0; u < uurb->number_of_packets; u++) {
                as->urb->iso_frame_desc[u].offset = totlen;
                as->urb->iso_frame_desc[u].length = isopkt[u].length;
                totlen += isopkt[u].length;
        }
-       if (isopkt)
-               kfree(isopkt);
+       kfree(isopkt);
        as->ps = ps;
         as->userurb = arg;
-       if (uurb.endpoint & USB_DIR_IN)
-               as->userbuffer = uurb.buffer;
+       if (uurb->endpoint & USB_DIR_IN)
+               as->userbuffer = uurb->buffer;
        else
                as->userbuffer = NULL;
-       as->signr = uurb.signr;
+       as->signr = uurb->signr;
        as->ifnum = ifnum;
-       as->task = current;
-       if (!(uurb.endpoint & USB_DIR_IN)) {
-               if (copy_from_user(as->urb->transfer_buffer, uurb.buffer, as->urb->transfer_buffer_length)) {
+       as->pid = current->pid;
+       as->uid = current->uid;
+       as->euid = current->euid;
+       if (!(uurb->endpoint & USB_DIR_IN)) {
+               if (copy_from_user(as->urb->transfer_buffer, uurb->buffer, as->urb->transfer_buffer_length)) {
                        free_async(as);
                        return -EFAULT;
                }
        }
+       snoop(&as->urb->dev->dev, "submit urb\n");
+       snoop_urb(as->urb, as->userurb);
         async_newpending(as);
         if ((ret = usb_submit_urb(as->urb, GFP_KERNEL))) {
                dev_printk(KERN_DEBUG, &ps->dev->dev, "usbfs: usb_submit_urb returned %d\n", ret);
@@ -969,6 +1071,16 @@ static int proc_submiturb(struct dev_state *ps, void __user *arg)
         return 0;
 }
 
+static int proc_submiturb(struct dev_state *ps, void __user *arg)
+{
+       struct usbdevfs_urb uurb;
+
+       if (copy_from_user(&uurb, arg, sizeof(uurb)))
+               return -EFAULT;
+
+       return proc_do_submiturb(ps, &uurb, (((struct usbdevfs_urb __user *)arg)->iso_frame_desc), arg);
+}
+
 static int proc_unlinkurb(struct dev_state *ps, void __user *arg)
 {
        struct async *as;
@@ -976,14 +1088,15 @@ static int proc_unlinkurb(struct dev_state *ps, void __user *arg)
        as = async_getpending(ps, arg);
        if (!as)
                return -EINVAL;
-       usb_unlink_urb(as->urb);
+       usb_kill_urb(as->urb);
        return 0;
 }
 
-static int processcompl(struct async *as)
+static int processcompl(struct async *as, void __user * __user *arg)
 {
        struct urb *urb = as->urb;
        struct usbdevfs_urb __user *userurb = as->userurb;
+       void __user *addr = as->userurb;
        unsigned int i;
 
        if (as->userbuffer)
@@ -996,50 +1109,51 @@ static int processcompl(struct async *as)
        if (put_user(urb->error_count, &userurb->error_count))
                return -EFAULT;
 
-       if (!(usb_pipeisoc(urb->pipe)))
-               return 0;
-       for (i = 0; i < urb->number_of_packets; i++) {
-               if (put_user(urb->iso_frame_desc[i].actual_length,
-                            &userurb->iso_frame_desc[i].actual_length))
-                       return -EFAULT;
-               if (put_user(urb->iso_frame_desc[i].status,
-                            &userurb->iso_frame_desc[i].status))
-                       return -EFAULT;
+       if (usb_pipeisoc(urb->pipe)) {
+               for (i = 0; i < urb->number_of_packets; i++) {
+                       if (put_user(urb->iso_frame_desc[i].actual_length,
+                                    &userurb->iso_frame_desc[i].actual_length))
+                               return -EFAULT;
+                       if (put_user(urb->iso_frame_desc[i].status,
+                                    &userurb->iso_frame_desc[i].status))
+                               return -EFAULT;
+               }
        }
+
+       free_async(as);
+
+       if (put_user(addr, (void __user * __user *)arg))
+               return -EFAULT;
        return 0;
 }
 
-static int proc_reapurb(struct dev_state *ps, void __user *arg)
+static struct async* reap_as(struct dev_state *ps)
 {
         DECLARE_WAITQUEUE(wait, current);
        struct async *as = NULL;
-       void __user *addr;
        struct usb_device *dev = ps->dev;
-       int ret;
 
        add_wait_queue(&ps->wait, &wait);
-       while (connected(dev)) {
+       for (;;) {
                __set_current_state(TASK_INTERRUPTIBLE);
                if ((as = async_getcompleted(ps)))
                        break;
                if (signal_pending(current))
                        break;
-               up(&dev->serialize);
+               usb_unlock_device(dev);
                schedule();
-               down(&dev->serialize);
+               usb_lock_device(dev);
        }
        remove_wait_queue(&ps->wait, &wait);
        set_current_state(TASK_RUNNING);
-       if (as) {
-               ret = processcompl(as);
-               addr = as->userurb;
-               free_async(as);
-               if (ret)
-                       return ret;
-               if (put_user(addr, (void __user * __user *)arg))
-                       return -EFAULT;
-               return 0;
-       }
+       return as;
+}
+
+static int proc_reapurb(struct dev_state *ps, void __user *arg)
+{
+       struct async *as = reap_as(ps);
+       if (as)
+               return processcompl(as, (void __user * __user *)arg);
        if (signal_pending(current))
                return -EINTR;
        return -EIO;
@@ -1048,21 +1162,105 @@ static int proc_reapurb(struct dev_state *ps, void __user *arg)
 static int proc_reapurbnonblock(struct dev_state *ps, void __user *arg)
 {
        struct async *as;
-       void __user *addr;
-       int ret;
 
        if (!(as = async_getcompleted(ps)))
                return -EAGAIN;
-       ret = processcompl(as);
-       addr = as->userurb;
+       return processcompl(as, (void __user * __user *)arg);
+}
+
+#ifdef CONFIG_COMPAT
+
+static int get_urb32(struct usbdevfs_urb *kurb,
+                    struct usbdevfs_urb32 __user *uurb)
+{
+       __u32  uptr;
+       if (get_user(kurb->type, &uurb->type) ||
+           __get_user(kurb->endpoint, &uurb->endpoint) ||
+           __get_user(kurb->status, &uurb->status) ||
+           __get_user(kurb->flags, &uurb->flags) ||
+           __get_user(kurb->buffer_length, &uurb->buffer_length) ||
+           __get_user(kurb->actual_length, &uurb->actual_length) ||
+           __get_user(kurb->start_frame, &uurb->start_frame) ||
+           __get_user(kurb->number_of_packets, &uurb->number_of_packets) ||
+           __get_user(kurb->error_count, &uurb->error_count) ||
+           __get_user(kurb->signr, &uurb->signr))
+               return -EFAULT;
+
+       if (__get_user(uptr, &uurb->buffer))
+               return -EFAULT;
+       kurb->buffer = compat_ptr(uptr);
+       if (__get_user(uptr, &uurb->buffer))
+               return -EFAULT;
+       kurb->usercontext = compat_ptr(uptr);
+
+       return 0;
+}
+
+static int proc_submiturb_compat(struct dev_state *ps, void __user *arg)
+{
+       struct usbdevfs_urb uurb;
+
+       if (get_urb32(&uurb,(struct usbdevfs_urb32 *)arg))
+               return -EFAULT;
+
+       return proc_do_submiturb(ps, &uurb, ((struct usbdevfs_urb32 __user *)arg)->iso_frame_desc, arg);
+}
+
+static int processcompl_compat(struct async *as, void __user * __user *arg)
+{
+       struct urb *urb = as->urb;
+       struct usbdevfs_urb32 __user *userurb = as->userurb;
+       void __user *addr = as->userurb;
+       unsigned int i;
+
+       if (as->userbuffer)
+               if (copy_to_user(as->userbuffer, urb->transfer_buffer, urb->transfer_buffer_length))
+                       return -EFAULT;
+       if (put_user(urb->status, &userurb->status))
+               return -EFAULT;
+       if (put_user(urb->actual_length, &userurb->actual_length))
+               return -EFAULT;
+       if (put_user(urb->error_count, &userurb->error_count))
+               return -EFAULT;
+
+       if (usb_pipeisoc(urb->pipe)) {
+               for (i = 0; i < urb->number_of_packets; i++) {
+                       if (put_user(urb->iso_frame_desc[i].actual_length,
+                                    &userurb->iso_frame_desc[i].actual_length))
+                               return -EFAULT;
+                       if (put_user(urb->iso_frame_desc[i].status,
+                                    &userurb->iso_frame_desc[i].status))
+                               return -EFAULT;
+               }
+       }
+
        free_async(as);
-       if (ret)
-               return ret;
-       if (put_user(addr, (void __user * __user *)arg))
+       if (put_user((u32)(u64)addr, (u32 __user *)arg))
                return -EFAULT;
        return 0;
 }
 
+static int proc_reapurb_compat(struct dev_state *ps, void __user *arg)
+{
+       struct async *as = reap_as(ps);
+       if (as)
+               return processcompl_compat(as, (void __user * __user *)arg);
+       if (signal_pending(current))
+               return -EINTR;
+       return -EIO;
+}
+
+static int proc_reapurbnonblock_compat(struct dev_state *ps, void __user *arg)
+{
+       struct async *as;
+
+       if (!(as = async_getcompleted(ps)))
+               return -EAGAIN;
+       return processcompl_compat(as, (void __user * __user *)arg);
+}
+
+#endif
+
 static int proc_disconnectsignal(struct dev_state *ps, void __user *arg)
 {
        struct usbdevfs_disconnectsignal ds;
@@ -1098,24 +1296,21 @@ static int proc_releaseinterface(struct dev_state *ps, void __user *arg)
        return 0;
 }
 
-static int proc_ioctl (struct dev_state *ps, void __user *arg)
+static int proc_ioctl(struct dev_state *ps, struct usbdevfs_ioctl *ctl)
 {
-       struct usbdevfs_ioctl   ctrl;
        int                     size;
        void                    *buf = NULL;
        int                     retval = 0;
        struct usb_interface    *intf = NULL;
        struct usb_driver       *driver = NULL;
 
-       /* get input parameters and alloc buffer */
-       if (copy_from_user(&ctrl, arg, sizeof (ctrl)))
-               return -EFAULT;
-       if ((size = _IOC_SIZE (ctrl.ioctl_code)) > 0) {
-               if ((buf = kmalloc (size, GFP_KERNEL)) == 0)
+       /* alloc buffer */
+       if ((size = _IOC_SIZE (ctl->ioctl_code)) > 0) {
+               if ((buf = kmalloc (size, GFP_KERNEL)) == NULL)
                        return -ENOMEM;
-               if ((_IOC_DIR(ctrl.ioctl_code) & _IOC_WRITE)) {
-                       if (copy_from_user (buf, ctrl.data, size)) {
-                               kfree (buf);
+               if ((_IOC_DIR(ctl->ioctl_code) & _IOC_WRITE)) {
+                       if (copy_from_user (buf, ctl->data, size)) {
+                               kfree(buf);
                                return -EFAULT;
                        }
                } else {
@@ -1124,19 +1319,19 @@ static int proc_ioctl (struct dev_state *ps, void __user *arg)
        }
 
        if (!connected(ps->dev)) {
-               if (buf)
-                       kfree(buf);
+               kfree(buf);
                return -ENODEV;
        }
 
        if (ps->dev->state != USB_STATE_CONFIGURED)
-               retval = -ENODEV;
-       else if (!(intf = usb_ifnum_to_if (ps->dev, ctrl.ifno)))
+               retval = -EHOSTUNREACH;
+       else if (!(intf = usb_ifnum_to_if (ps->dev, ctl->ifno)))
                retval = -EINVAL;
-       else switch (ctrl.ioctl_code) {
+       else switch (ctl->ioctl_code) {
 
        /* disconnect kernel driver from interface */
        case USBDEVFS_DISCONNECT:
+
                down_write(&usb_bus_type.subsys.rwsem);
                if (intf->dev.driver) {
                        driver = to_usb_driver(intf->dev.driver);
@@ -1149,7 +1344,9 @@ static int proc_ioctl (struct dev_state *ps, void __user *arg)
 
        /* let kernel drivers try to (re)bind to the interface */
        case USBDEVFS_CONNECT:
+               usb_unlock_device(ps->dev);
                bus_rescan_devices(intf->dev.bus);
+               usb_lock_device(ps->dev);
                break;
 
        /* talk directly to the interface's driver */
@@ -1157,10 +1354,10 @@ static int proc_ioctl (struct dev_state *ps, void __user *arg)
                down_read(&usb_bus_type.subsys.rwsem);
                if (intf->dev.driver)
                        driver = to_usb_driver(intf->dev.driver);
-               if (driver == 0 || driver->ioctl == 0) {
+               if (driver == NULL || driver->ioctl == NULL) {
                        retval = -ENOTTY;
                } else {
-                       retval = driver->ioctl (intf, ctrl.ioctl_code, buf);
+                       retval = driver->ioctl (intf, ctl->ioctl_code, buf);
                        if (retval == -ENOIOCTLCMD)
                                retval = -ENOTTY;
                }
@@ -1169,15 +1366,42 @@ static int proc_ioctl (struct dev_state *ps, void __user *arg)
 
        /* cleanup and return */
        if (retval >= 0
-                       && (_IOC_DIR (ctrl.ioctl_code) & _IOC_READ) != 0
+                       && (_IOC_DIR (ctl->ioctl_code) & _IOC_READ) != 0
                        && size > 0
-                       && copy_to_user (ctrl.data, buf, size) != 0)
+                       && copy_to_user (ctl->data, buf, size) != 0)
                retval = -EFAULT;
-       if (buf != 0)
-               kfree (buf);
+
+       kfree(buf);
        return retval;
 }
 
+static int proc_ioctl_default(struct dev_state *ps, void __user *arg)
+{
+       struct usbdevfs_ioctl   ctrl;
+
+       if (copy_from_user(&ctrl, arg, sizeof (ctrl)))
+               return -EFAULT;
+       return proc_ioctl(ps, &ctrl);
+}
+
+#ifdef CONFIG_COMPAT
+static int proc_ioctl_compat(struct dev_state *ps, compat_uptr_t arg)
+{
+       struct usbdevfs_ioctl32 __user *uioc;
+       struct usbdevfs_ioctl ctrl;
+       u32 udata;
+
+       uioc = compat_ptr((long)arg);
+       if (get_user(ctrl.ifno, &uioc->ifno) ||
+           get_user(ctrl.ioctl_code, &uioc->ioctl_code) ||
+           __get_user(udata, &uioc->data))
+               return -EFAULT;
+       ctrl.data = compat_ptr(udata);
+
+       return proc_ioctl(ps, &ctrl);
+}
+#endif
+
 /*
  * NOTE:  All requests here that have interface numbers as parameters
  * are assuming that somehow the configuration has been prevented from
@@ -1192,9 +1416,9 @@ static int usbdev_ioctl(struct inode *inode, struct file *file, unsigned int cmd
 
        if (!(file->f_mode & FMODE_WRITE))
                return -EPERM;
-       down(&dev->serialize);
+       usb_lock_device(dev);
        if (!connected(dev)) {
-               up(&dev->serialize);
+               usb_unlock_device(dev);
                return -ENODEV;
        }
 
@@ -1259,6 +1483,31 @@ static int usbdev_ioctl(struct inode *inode, struct file *file, unsigned int cmd
                        inode->i_mtime = CURRENT_TIME;
                break;
 
+#ifdef CONFIG_COMPAT
+
+       case USBDEVFS_SUBMITURB32:
+               snoop(&dev->dev, "%s: SUBMITURB32\n", __FUNCTION__);
+               ret = proc_submiturb_compat(ps, p);
+               if (ret >= 0)
+                       inode->i_mtime = CURRENT_TIME;
+               break;
+
+       case USBDEVFS_REAPURB32:
+               snoop(&dev->dev, "%s: REAPURB32\n", __FUNCTION__);
+               ret = proc_reapurb_compat(ps, p);
+               break;
+
+       case USBDEVFS_REAPURBNDELAY32:
+               snoop(&dev->dev, "%s: REAPURBDELAY32\n", __FUNCTION__);
+               ret = proc_reapurbnonblock_compat(ps, p);
+               break;
+
+       case USBDEVFS_IOCTL32:
+               snoop(&dev->dev, "%s: IOCTL\n", __FUNCTION__);
+               ret = proc_ioctl_compat(ps, (compat_uptr_t)(long)p);
+               break;
+#endif
+
        case USBDEVFS_DISCARDURB:
                snoop(&dev->dev, "%s: DISCARDURB\n", __FUNCTION__);
                ret = proc_unlinkurb(ps, p);
@@ -1291,10 +1540,10 @@ static int usbdev_ioctl(struct inode *inode, struct file *file, unsigned int cmd
 
        case USBDEVFS_IOCTL:
                snoop(&dev->dev, "%s: IOCTL\n", __FUNCTION__);
-               ret = proc_ioctl(ps, p);
+               ret = proc_ioctl_default(ps, p);
                break;
        }
-       up(&dev->serialize);
+       usb_unlock_device(dev);
        if (ret >= 0)
                inode->i_atime = CURRENT_TIME;
        return ret;
@@ -1314,7 +1563,7 @@ static unsigned int usbdev_poll(struct file *file, struct poll_table_struct *wai
        return mask;
 }
 
-struct file_operations usbdevfs_device_file_operations = {
+struct file_operations usbfs_device_file_operations = {
        .llseek =       usbdev_lseek,
        .read =         usbdev_read,
        .poll =         usbdev_poll,
@@ -1322,3 +1571,88 @@ struct file_operations usbdevfs_device_file_operations = {
        .open =         usbdev_open,
        .release =      usbdev_release,
 };
+
+static void usbdev_add(struct usb_device *dev)
+{
+       int minor = ((dev->bus->busnum-1) * 128) + (dev->devnum-1);
+
+       dev->class_dev = class_device_create(usb_device_class, NULL,
+                               MKDEV(USB_DEVICE_MAJOR, minor), &dev->dev,
+                               "usbdev%d.%d", dev->bus->busnum, dev->devnum);
+
+       dev->class_dev->class_data = dev;
+}
+
+static void usbdev_remove(struct usb_device *dev)
+{
+       class_device_unregister(dev->class_dev);
+}
+
+static int usbdev_notify(struct notifier_block *self, unsigned long action,
+                        void *dev)
+{
+       switch (action) {
+       case USB_DEVICE_ADD:
+               usbdev_add(dev);
+               break;
+       case USB_DEVICE_REMOVE:
+               usbdev_remove(dev);
+               break;
+       }
+       return NOTIFY_OK;
+}
+
+static struct notifier_block usbdev_nb = {
+       .notifier_call =        usbdev_notify,
+};
+
+static struct cdev usb_device_cdev = {
+       .kobj   = {.name = "usb_device", },
+       .owner  = THIS_MODULE,
+};
+
+int __init usbdev_init(void)
+{
+       int retval;
+
+       retval = register_chrdev_region(USB_DEVICE_DEV, USB_DEVICE_MAX,
+                       "usb_device");
+       if (retval) {
+               err("unable to register minors for usb_device");
+               goto out;
+       }
+       cdev_init(&usb_device_cdev, &usbfs_device_file_operations);
+       retval = cdev_add(&usb_device_cdev, USB_DEVICE_DEV, USB_DEVICE_MAX);
+       if (retval) {
+               err("unable to get usb_device major %d", USB_DEVICE_MAJOR);
+               goto error_cdev;
+       }
+       usb_device_class = class_create(THIS_MODULE, "usb_device");
+       if (IS_ERR(usb_device_class)) {
+               err("unable to register usb_device class");
+               retval = PTR_ERR(usb_device_class);
+               goto error_class;
+       }
+
+       usb_register_notify(&usbdev_nb);
+
+out:
+       return retval;
+
+error_class:
+       usb_device_class = NULL;
+       cdev_del(&usb_device_cdev);
+
+error_cdev:
+       unregister_chrdev_region(USB_DEVICE_DEV, USB_DEVICE_MAX);
+       goto out;
+}
+
+void usbdev_cleanup(void)
+{
+       usb_unregister_notify(&usbdev_nb);
+       class_destroy(usb_device_class);
+       cdev_del(&usb_device_cdev);
+       unregister_chrdev_region(USB_DEVICE_DEV, USB_DEVICE_MAX);
+}
+