vserver 1.9.5.x5
[linux-2.6.git] / drivers / usb / core / hub.c
index cdade32..bab1057 100644 (file)
@@ -9,6 +9,11 @@
  */
 
 #include <linux/config.h>
+#ifdef CONFIG_USB_DEBUG
+       #define DEBUG
+#else
+       #undef DEBUG
+#endif
 #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/smp_lock.h>
 #include <linux/ioctl.h>
-#ifdef CONFIG_USB_DEBUG
-       #define DEBUG
-#else
-       #undef DEBUG
-#endif
 #include <linux/usb.h>
 #include <linux/usbdevice_fs.h>
-#include <linux/suspend.h>
 
 #include <asm/semaphore.h>
 #include <asm/uaccess.h>
 #include "hcd.h"
 #include "hub.h"
 
-/* Wakes up khubd */
-static spinlock_t hub_event_lock = SPIN_LOCK_UNLOCKED;
+/* Protect struct usb_device->state and ->children members
+ * Note: Both are also protected by ->serialize, except that ->state can
+ * change to USB_STATE_NOTATTACHED even when the semaphore isn't held. */
+static DEFINE_SPINLOCK(device_state_lock);
 
+/* khubd's worklist and its lock */
+static DEFINE_SPINLOCK(hub_event_lock);
 static LIST_HEAD(hub_event_list);      /* List of hubs needing servicing */
-static LIST_HEAD(hub_list);            /* List of all hubs (for cleanup) */
 
+/* Wakes up khubd */
 static DECLARE_WAIT_QUEUE_HEAD(khubd_wait);
+
 static pid_t khubd_pid = 0;                    /* PID of khubd */
 static DECLARE_COMPLETION(khubd_exited);
 
@@ -51,6 +55,31 @@ static int blinkenlights = 0;
 module_param (blinkenlights, bool, S_IRUGO);
 MODULE_PARM_DESC (blinkenlights, "true to cycle leds on hubs");
 
+/*
+ * As of 2.6.10 we introduce a new USB device initialization scheme which
+ * closely resembles the way Windows works.  Hopefully it will be compatible
+ * with a wider range of devices than the old scheme.  However some previously
+ * working devices may start giving rise to "device not accepting address"
+ * errors; if that happens the user can try the old scheme by adjusting the
+ * following module parameters.
+ *
+ * For maximum flexibility there are two boolean parameters to control the
+ * hub driver's behavior.  On the first initialization attempt, if the
+ * "old_scheme_first" parameter is set then the old scheme will be used,
+ * otherwise the new scheme is used.  If that fails and "use_both_schemes"
+ * is set, then the driver will make another attempt, using the other scheme.
+ */
+static int old_scheme_first = 0;
+module_param(old_scheme_first, bool, S_IRUGO | S_IWUSR);
+MODULE_PARM_DESC(old_scheme_first,
+                "start with the old device initialization scheme");
+
+static int use_both_schemes = 0;
+module_param(use_both_schemes, bool, S_IRUGO | S_IWUSR);
+MODULE_PARM_DESC(use_both_schemes,
+               "try the other device initialization scheme if the "
+               "first one fails");
+
 
 #ifdef DEBUG
 static inline char *portspeed (int portstatus)
@@ -64,18 +93,26 @@ static inline char *portspeed (int portstatus)
 }
 #endif
 
-/* for dev_info, dev_dbg, etc */
-static inline struct device *hubdev (struct usb_device *hdev)
+/* Note that hdev or one of its children must be locked! */
+static inline struct usb_hub *hdev_to_hub(struct usb_device *hdev)
 {
-       return &hdev->actconfig->interface[0]->dev;
+       return usb_get_intfdata(hdev->actconfig->interface[0]);
 }
 
 /* USB 2.0 spec Section 11.24.4.5 */
 static int get_hub_descriptor(struct usb_device *hdev, void *data, int size)
 {
-       return usb_control_msg(hdev, usb_rcvctrlpipe(hdev, 0),
-               USB_REQ_GET_DESCRIPTOR, USB_DIR_IN | USB_RT_HUB,
-               USB_DT_HUB << 8, 0, data, size, HZ * USB_CTRL_GET_TIMEOUT);
+       int i, ret;
+
+       for (i = 0; i < 3; i++) {
+               ret = usb_control_msg(hdev, usb_rcvctrlpipe(hdev, 0),
+                       USB_REQ_GET_DESCRIPTOR, USB_DIR_IN | USB_RT_HUB,
+                       USB_DT_HUB << 8, 0, data, size,
+                       HZ * USB_CTRL_GET_TIMEOUT);
+               if (ret >= (USB_DT_HUB_NONVAR_SIZE + 2))
+                       return ret;
+       }
+       return -EINVAL;
 }
 
 /*
@@ -90,19 +127,21 @@ static int clear_hub_feature(struct usb_device *hdev, int feature)
 /*
  * USB 2.0 spec Section 11.24.2.2
  */
-static int clear_port_feature(struct usb_device *hdev, int port, int feature)
+static int clear_port_feature(struct usb_device *hdev, int port1, int feature)
 {
        return usb_control_msg(hdev, usb_sndctrlpipe(hdev, 0),
-               USB_REQ_CLEAR_FEATURE, USB_RT_PORT, feature, port, NULL, 0, HZ);
+               USB_REQ_CLEAR_FEATURE, USB_RT_PORT, feature, port1,
+               NULL, 0, HZ);
 }
 
 /*
  * USB 2.0 spec Section 11.24.2.13
  */
-static int set_port_feature(struct usb_device *hdev, int port, int feature)
+static int set_port_feature(struct usb_device *hdev, int port1, int feature)
 {
        return usb_control_msg(hdev, usb_sndctrlpipe(hdev, 0),
-               USB_REQ_SET_FEATURE, USB_RT_PORT, feature, port, NULL, 0, HZ);
+               USB_REQ_SET_FEATURE, USB_RT_PORT, feature, port1,
+               NULL, 0, HZ);
 }
 
 /*
@@ -110,17 +149,17 @@ static int set_port_feature(struct usb_device *hdev, int port, int feature)
  * for info about using port indicators
  */
 static void set_port_led(
-       struct usb_device *hdev,
-       int port,
+       struct usb_hub *hub,
+       int port1,
        int selector
 )
 {
-       int status = set_port_feature(hdev, (selector << 8) | port,
+       int status = set_port_feature(hub->hdev, (selector << 8) | port1,
                        USB_PORT_FEAT_INDICATOR);
        if (status < 0)
-               dev_dbg (hubdev (hdev),
+               dev_dbg (hub->intfdev,
                        "port %d indicator %s status %d\n",
-                       port,
+                       port1,
                        ({ char *s; switch (selector) {
                        case HUB_LED_AMBER: s = "amber"; break;
                        case HUB_LED_GREEN: s = "green"; break;
@@ -136,12 +175,12 @@ static void set_port_led(
 static void led_work (void *__hub)
 {
        struct usb_hub          *hub = __hub;
-       struct usb_device       *hdev = interface_to_usbdev (hub->intf);
+       struct usb_device       *hdev = hub->hdev;
        unsigned                i;
        unsigned                changed = 0;
        int                     cursor = -1;
 
-       if (hdev->state != USB_STATE_CONFIGURED)
+       if (hdev->state != USB_STATE_CONFIGURED || hub->quiescing)
                return;
 
        for (i = 0; i < hub->descriptor->bNbrPorts; i++) {
@@ -188,13 +227,13 @@ static void led_work (void *__hub)
                }
                if (selector != HUB_LED_AUTO)
                        changed = 1;
-               set_port_led(hdev, i + 1, selector);
+               set_port_led(hub, i + 1, selector);
                hub->indicator[i] = mode;
        }
        if (!changed && blinkenlights) {
                cursor++;
                cursor %= hub->descriptor->bNbrPorts;
-               set_port_led(hdev, cursor + 1, HUB_LED_GREEN);
+               set_port_led(hub, cursor + 1, HUB_LED_GREEN);
                hub->indicator[cursor] = INDICATOR_CYCLE;
                changed++;
        }
@@ -202,50 +241,72 @@ static void led_work (void *__hub)
                schedule_delayed_work(&hub->leds, LED_CYCLE_PERIOD);
 }
 
+/* use a short timeout for hub/port status fetches */
+#define        USB_STS_TIMEOUT         1
+#define        USB_STS_RETRIES         5
+
 /*
  * USB 2.0 spec Section 11.24.2.6
  */
 static int get_hub_status(struct usb_device *hdev,
                struct usb_hub_status *data)
 {
-       return usb_control_msg(hdev, usb_rcvctrlpipe(hdev, 0),
-               USB_REQ_GET_STATUS, USB_DIR_IN | USB_RT_HUB, 0, 0,
-               data, sizeof(*data), HZ * USB_CTRL_GET_TIMEOUT);
+       int i, status = -ETIMEDOUT;
+
+       for (i = 0; i < USB_STS_RETRIES && status == -ETIMEDOUT; i++) {
+               status = usb_control_msg(hdev, usb_rcvctrlpipe(hdev, 0),
+                       USB_REQ_GET_STATUS, USB_DIR_IN | USB_RT_HUB, 0, 0,
+                       data, sizeof(*data), HZ * USB_STS_TIMEOUT);
+       }
+       return status;
 }
 
 /*
  * USB 2.0 spec Section 11.24.2.7
  */
-static int get_port_status(struct usb_device *hdev, int port,
+static int get_port_status(struct usb_device *hdev, int port1,
                struct usb_port_status *data)
 {
-       return usb_control_msg(hdev, usb_rcvctrlpipe(hdev, 0),
-               USB_REQ_GET_STATUS, USB_DIR_IN | USB_RT_PORT, 0, port,
-               data, sizeof(*data), HZ * USB_CTRL_GET_TIMEOUT);
+       int i, status = -ETIMEDOUT;
+
+       for (i = 0; i < USB_STS_RETRIES && status == -ETIMEDOUT; i++) {
+               status = usb_control_msg(hdev, usb_rcvctrlpipe(hdev, 0),
+                       USB_REQ_GET_STATUS, USB_DIR_IN | USB_RT_PORT, 0, port1,
+                       data, sizeof(*data), HZ * USB_STS_TIMEOUT);
+       }
+       return status;
 }
 
+static void kick_khubd(struct usb_hub *hub)
+{
+       unsigned long   flags;
+
+       spin_lock_irqsave(&hub_event_lock, flags);
+       if (list_empty(&hub->event_list)) {
+               list_add_tail(&hub->event_list, &hub_event_list);
+               wake_up(&khubd_wait);
+       }
+       spin_unlock_irqrestore(&hub_event_lock, flags);
+}
+
+
 /* completion function, fires on port status changes and various faults */
 static void hub_irq(struct urb *urb, struct pt_regs *regs)
 {
        struct usb_hub *hub = (struct usb_hub *)urb->context;
        int status;
-
-       spin_lock(&hub_event_lock);
-       hub->urb_active = 0;
-       if (hub->urb_complete) {        /* disconnect or rmmod */
-               complete(hub->urb_complete);
-               goto done;
-       }
+       int i;
+       unsigned long bits;
 
        switch (urb->status) {
        case -ENOENT:           /* synchronous unlink */
        case -ECONNRESET:       /* async unlink */
        case -ESHUTDOWN:        /* hardware going away */
-               goto done;
+               return;
 
        default:                /* presumably an error */
                /* Cause a hub reset after 10 consecutive errors */
-               dev_dbg (&hub->intf->dev, "transfer --> %d\n", urb->status);
+               dev_dbg (hub->intfdev, "transfer --> %d\n", urb->status);
                if ((++hub->nerrors < 10) || hub->error)
                        goto resubmit;
                hub->error = urb->status;
@@ -253,35 +314,35 @@ static void hub_irq(struct urb *urb, struct pt_regs *regs)
        
        /* let khubd handle things */
        case 0:                 /* we got data:  port status changed */
+               bits = 0;
+               for (i = 0; i < urb->actual_length; ++i)
+                       bits |= ((unsigned long) ((*hub->buffer)[i]))
+                                       << (i*8);
+               hub->event_bits[0] = bits;
                break;
        }
 
        hub->nerrors = 0;
 
        /* Something happened, let khubd figure it out */
-       if (list_empty(&hub->event_list)) {
-               list_add(&hub->event_list, &hub_event_list);
-               wake_up(&khubd_wait);
-       }
+       kick_khubd(hub);
 
 resubmit:
+       if (hub->quiescing)
+               return;
+
        if ((status = usb_submit_urb (hub->urb, GFP_ATOMIC)) != 0
-                       /* ENODEV means we raced disconnect() */
-                       && status != -ENODEV)
-               dev_err (&hub->intf->dev, "resubmit --> %d\n", urb->status);
-       if (status == 0)
-               hub->urb_active = 1;
-done:
-       spin_unlock(&hub_event_lock);
+                       && status != -ENODEV && status != -EPERM)
+               dev_err (hub->intfdev, "resubmit --> %d\n", status);
 }
 
 /* USB 2.0 spec Section 11.24.2.3 */
 static inline int
 hub_clear_tt_buffer (struct usb_device *hdev, u16 devinfo, u16 tt)
 {
-       return usb_control_msg (hdev, usb_rcvctrlpipe (hdev, 0),
-               HUB_CLEAR_TT_BUFFER, USB_RT_PORT,
-               devinfo, tt, 0, 0, HZ);
+       return usb_control_msg(hdev, usb_rcvctrlpipe(hdev, 0),
+                              HUB_CLEAR_TT_BUFFER, USB_RT_PORT, devinfo,
+                              tt, NULL, 0, HZ);
 }
 
 /*
@@ -299,7 +360,7 @@ static void hub_tt_kevent (void *arg)
        while (!list_empty (&hub->tt.clear_list)) {
                struct list_head        *temp;
                struct usb_tt_clear     *clear;
-               struct usb_device       *hdev;
+               struct usb_device       *hdev = hub->hdev;
                int                     status;
 
                temp = hub->tt.clear_list.next;
@@ -308,7 +369,6 @@ static void hub_tt_kevent (void *arg)
 
                /* drop lock so HCD can concurrently report other TT errors */
                spin_unlock_irqrestore (&hub->tt.lock, flags);
-               hdev = interface_to_usbdev (hub->intf);
                status = hub_clear_tt_buffer (hdev, clear->devinfo, clear->tt);
                spin_lock_irqsave (&hub->tt.lock, flags);
 
@@ -344,7 +404,7 @@ void usb_hub_tt_clear_buffer (struct usb_device *udev, int pipe)
         * since each TT has "at least two" buffers that can need it (and
         * there can be many TTs per hub).  even if they're uncommon.
         */
-       if ((clear = kmalloc (sizeof *clear, SLAB_ATOMIC)) == 0) {
+       if ((clear = kmalloc (sizeof *clear, SLAB_ATOMIC)) == NULL) {
                dev_err (&udev->dev, "can't save CLEAR_TT_BUFFER state\n");
                /* FIXME recover somehow ... RESET_TT? */
                return;
@@ -369,30 +429,55 @@ void usb_hub_tt_clear_buffer (struct usb_device *udev, int pipe)
 
 static void hub_power_on(struct usb_hub *hub)
 {
-       struct usb_device *hdev;
-       int i;
+       int port1;
 
        /* if hub supports power switching, enable power on each port */
        if ((hub->descriptor->wHubCharacteristics & HUB_CHAR_LPSM) < 2) {
-               dev_dbg(&hub->intf->dev, "enabling power on all ports\n");
-               hdev = interface_to_usbdev(hub->intf);
-               for (i = 0; i < hub->descriptor->bNbrPorts; i++)
-                       set_port_feature(hdev, i + 1, USB_PORT_FEAT_POWER);
+               dev_dbg(hub->intfdev, "enabling power on all ports\n");
+               for (port1 = 1; port1 <= hub->descriptor->bNbrPorts; port1++)
+                       set_port_feature(hub->hdev, port1,
+                                       USB_PORT_FEAT_POWER);
        }
 
        /* Wait for power to be enabled */
        msleep(hub->descriptor->bPwrOn2PwrGood * 2);
 }
 
+static void hub_quiesce(struct usb_hub *hub)
+{
+       /* stop khubd and related activity */
+       hub->quiescing = 1;
+       usb_kill_urb(hub->urb);
+       if (hub->has_indicators)
+               cancel_delayed_work(&hub->leds);
+       if (hub->has_indicators || hub->tt.hub)
+               flush_scheduled_work();
+}
+
+static void hub_activate(struct usb_hub *hub)
+{
+       int     status;
+
+       hub->quiescing = 0;
+       status = usb_submit_urb(hub->urb, GFP_NOIO);
+       if (status < 0)
+               dev_err(hub->intfdev, "activate --> %d\n", status);
+       if (hub->has_indicators && blinkenlights)
+               schedule_delayed_work(&hub->leds, LED_CYCLE_PERIOD);
+
+       /* scan all ports ASAP */
+       hub->event_bits[0] = (1UL << (hub->descriptor->bNbrPorts + 1)) - 1;
+       kick_khubd(hub);
+}
+
 static int hub_hub_status(struct usb_hub *hub,
                u16 *status, u16 *change)
 {
-       struct usb_device *hdev = interface_to_usbdev (hub->intf);
        int ret;
 
-       ret = get_hub_status(hdev, &hub->status->hub);
+       ret = get_hub_status(hub->hdev, &hub->status->hub);
        if (ret < 0)
-               dev_err (&hub->intf->dev,
+               dev_err (hub->intfdev,
                        "%s failed (err = %d)\n", __FUNCTION__, ret);
        else {
                *status = le16_to_cpu(hub->status->hub.wHubStatus);
@@ -405,8 +490,8 @@ static int hub_hub_status(struct usb_hub *hub,
 static int hub_configure(struct usb_hub *hub,
        struct usb_endpoint_descriptor *endpoint)
 {
-       struct usb_device *hdev = interface_to_usbdev (hub->intf);
-       struct device *hub_dev = &hub->intf->dev;
+       struct usb_device *hdev = hub->hdev;
+       struct device *hub_dev = hub->intfdev;
        u16 hubstatus, hubchange;
        unsigned int pipe;
        int maxp, ret;
@@ -580,7 +665,7 @@ static int hub_configure(struct usb_hub *hub,
                dev_dbg(hub_dev, "%sover-current condition exists\n",
                        (hubstatus & HUB_STATUS_OVERCURRENT) ? "" : "no ");
 
-       /* Start the interrupt endpoint */
+       /* set up the interrupt endpoint */
        pipe = usb_rcvintpipe(hdev, endpoint->bEndpointAddress);
        maxp = usb_maxpacket(hdev, pipe, usb_pipeout(pipe));
 
@@ -598,25 +683,14 @@ static int hub_configure(struct usb_hub *hub,
                hub, endpoint->bInterval);
        hub->urb->transfer_dma = hub->buffer_dma;
        hub->urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
-       ret = usb_submit_urb(hub->urb, GFP_KERNEL);
-       if (ret) {
-               message = "couldn't submit status urb";
-               goto fail;
-       }
-       hub->urb_active = 1;
 
-       /* Wake up khubd */
-       wake_up(&khubd_wait);
-
-       /* maybe start cycling the hub leds */
-       if (hub->has_indicators && blinkenlights) {
-               set_port_led(hdev, 1, HUB_LED_GREEN);
+       /* maybe cycle the hub leds */
+       if (hub->has_indicators && blinkenlights)
                hub->indicator [0] = INDICATOR_CYCLE;
-               schedule_delayed_work(&hub->leds, LED_CYCLE_PERIOD);
-       }
 
        hub_power_on(hub);
-
+       hub->change_bits[0] = (1UL << (hub->descriptor->bNbrPorts + 1)) - 2;
+       hub_activate(hub);
        return 0;
 
 fail:
@@ -631,41 +705,24 @@ static unsigned highspeed_hubs;
 static void hub_disconnect(struct usb_interface *intf)
 {
        struct usb_hub *hub = usb_get_intfdata (intf);
-       DECLARE_COMPLETION(urb_complete);
-       unsigned long flags;
+       struct usb_device *hdev;
 
        if (!hub)
                return;
+       hdev = hub->hdev;
 
-       if (interface_to_usbdev(intf)->speed == USB_SPEED_HIGH)
+       if (hdev->speed == USB_SPEED_HIGH)
                highspeed_hubs--;
 
        usb_set_intfdata (intf, NULL);
-       spin_lock_irqsave(&hub_event_lock, flags);
-       hub->urb_complete = &urb_complete;
 
-       /* Delete it and then reset it */
-       list_del_init(&hub->event_list);
-       list_del_init(&hub->hub_list);
-
-       spin_unlock_irqrestore(&hub_event_lock, flags);
-
-       down(&hub->khubd_sem); /* Wait for khubd to leave this hub alone. */
-       up(&hub->khubd_sem);
+       hub_quiesce(hub);
+       usb_free_urb(hub->urb);
+       hub->urb = NULL;
 
-       /* assuming we used keventd, it must quiesce too */
-       if (hub->has_indicators)
-               cancel_delayed_work (&hub->leds);
-       if (hub->has_indicators || hub->tt.hub)
-               flush_scheduled_work ();
-
-       if (hub->urb) {
-               usb_unlink_urb(hub->urb);
-               if (hub->urb_active)
-                       wait_for_completion(&urb_complete);
-               usb_free_urb(hub->urb);
-               hub->urb = NULL;
-       }
+       spin_lock_irq(&hub_event_lock);
+       list_del_init(&hub->event_list);
+       spin_unlock_irq(&hub_event_lock);
 
        if (hub->descriptor) {
                kfree(hub->descriptor);
@@ -678,8 +735,7 @@ static void hub_disconnect(struct usb_interface *intf)
        }
 
        if (hub->buffer) {
-               usb_buffer_free(interface_to_usbdev(intf),
-                               sizeof(*hub->buffer), hub->buffer,
+               usb_buffer_free(hdev, sizeof(*hub->buffer), hub->buffer,
                                hub->buffer_dma);
                hub->buffer = NULL;
        }
@@ -694,63 +750,50 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id)
        struct usb_endpoint_descriptor *endpoint;
        struct usb_device *hdev;
        struct usb_hub *hub;
-       struct device *hub_dev;
-       unsigned long flags;
 
        desc = intf->cur_altsetting;
        hdev = interface_to_usbdev(intf);
-       hub_dev = &intf->dev;
 
        /* Some hubs have a subclass of 1, which AFAICT according to the */
        /*  specs is not defined, but it works */
        if ((desc->desc.bInterfaceSubClass != 0) &&
            (desc->desc.bInterfaceSubClass != 1)) {
 descriptor_error:
-               dev_err (hub_dev, "bad descriptor, ignoring hub\n");
+               dev_err (&intf->dev, "bad descriptor, ignoring hub\n");
                return -EIO;
        }
 
        /* Multiple endpoints? What kind of mutant ninja-hub is this? */
-       if (desc->desc.bNumEndpoints != 1) {
+       if (desc->desc.bNumEndpoints != 1)
                goto descriptor_error;
-       }
 
        endpoint = &desc->endpoint[0].desc;
 
        /* Output endpoint? Curiouser and curiouser.. */
-       if (!(endpoint->bEndpointAddress & USB_DIR_IN)) {
+       if (!(endpoint->bEndpointAddress & USB_DIR_IN))
                goto descriptor_error;
-       }
 
        /* If it's not an interrupt endpoint, we'd better punt! */
        if ((endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK)
-                       != USB_ENDPOINT_XFER_INT) {
+                       != USB_ENDPOINT_XFER_INT)
                goto descriptor_error;
-               return -EIO;
-       }
 
        /* We found a hub */
-       dev_info (hub_dev, "USB hub found\n");
+       dev_info (&intf->dev, "USB hub found\n");
 
        hub = kmalloc(sizeof(*hub), GFP_KERNEL);
        if (!hub) {
-               dev_dbg (hub_dev, "couldn't kmalloc hub struct\n");
+               dev_dbg (&intf->dev, "couldn't kmalloc hub struct\n");
                return -ENOMEM;
        }
 
        memset(hub, 0, sizeof(*hub));
 
        INIT_LIST_HEAD(&hub->event_list);
-       hub->intf = intf;
-       init_MUTEX(&hub->khubd_sem);
+       hub->intfdev = &intf->dev;
+       hub->hdev = hdev;
        INIT_WORK(&hub->leds, led_work, hub);
 
-       /* Record the new hub's existence */
-       spin_lock_irqsave(&hub_event_lock, flags);
-       INIT_LIST_HEAD(&hub->hub_list);
-       list_add(&hub->hub_list, &hub_list);
-       spin_unlock_irqrestore(&hub_event_lock, flags);
-
        usb_set_intfdata (intf, hub);
 
        if (hdev->speed == USB_SPEED_HIGH)
@@ -772,10 +815,9 @@ hub_ioctl(struct usb_interface *intf, unsigned int code, void *user_data)
        switch (code) {
        case USBDEVFS_HUB_PORTINFO: {
                struct usbdevfs_hub_portinfo *info = user_data;
-               unsigned long flags;
                int i;
 
-               spin_lock_irqsave(&hub_event_lock, flags);
+               spin_lock_irq(&device_state_lock);
                if (hdev->devnum <= 0)
                        info->nports = 0;
                else {
@@ -788,7 +830,7 @@ hub_ioctl(struct usb_interface *intf, unsigned int code, void *user_data)
                                                hdev->children[i]->devnum;
                        }
                }
-               spin_unlock_irqrestore(&hub_event_lock, flags);
+               spin_unlock_irq(&device_state_lock);
 
                return info->nports + 1;
                }
@@ -798,65 +840,459 @@ hub_ioctl(struct usb_interface *intf, unsigned int code, void *user_data)
        }
 }
 
-static int hub_reset(struct usb_hub *hub)
+/* caller has locked the hub device */
+static void hub_pre_reset(struct usb_hub *hub)
 {
-       struct usb_device *hdev = interface_to_usbdev(hub->intf);
+       struct usb_device *hdev = hub->hdev;
        int i;
 
-       /* Disconnect any attached devices */
-       for (i = 0; i < hub->descriptor->bNbrPorts; i++) {
+       for (i = 0; i < hdev->maxchild; ++i) {
                if (hdev->children[i])
                        usb_disconnect(&hdev->children[i]);
        }
+       hub_quiesce(hub);
+}
 
-       /* Attempt to reset the hub */
-       if (hub->urb)
-               usb_unlink_urb(hub->urb);
-       else
-               return -1;
+/* caller has locked the hub device */
+static void hub_post_reset(struct usb_hub *hub)
+{
+       hub_activate(hub);
+       hub_power_on(hub);
+}
 
-       if (usb_reset_device(hdev))
-               return -1;
 
-       hub->urb->dev = hdev;                                                    
-       if (usb_submit_urb(hub->urb, GFP_KERNEL))
-               return -1;
+/* grab device/port lock, returning index of that port (zero based).
+ * protects the upstream link used by this device from concurrent
+ * tree operations like suspend, resume, reset, and disconnect, which
+ * apply to everything downstream of a given port.
+ */
+static int locktree(struct usb_device *udev)
+{
+       int                     t;
+       struct usb_device       *hdev;
 
-       hub_power_on(hub);
+       if (!udev)
+               return -ENODEV;
 
-       return 0;
+       /* root hub is always the first lock in the series */
+       hdev = udev->parent;
+       if (!hdev) {
+               usb_lock_device(udev);
+               return 0;
+       }
+
+       /* on the path from root to us, lock everything from
+        * top down, dropping parent locks when not needed
+        */
+       t = locktree(hdev);
+       if (t < 0)
+               return t;
+       for (t = 0; t < hdev->maxchild; t++) {
+               if (hdev->children[t] == udev) {
+                       /* everything is fail-fast once disconnect
+                        * processing starts
+                        */
+                       if (udev->state == USB_STATE_NOTATTACHED)
+                               break;
+
+                       /* when everyone grabs locks top->bottom,
+                        * non-overlapping work may be concurrent
+                        */
+                       down(&udev->serialize);
+                       up(&hdev->serialize);
+                       return t + 1;
+               }
+       }
+       usb_unlock_device(hdev);
+       return -ENODEV;
 }
 
-static void hub_start_disconnect(struct usb_device *hdev)
+static void recursively_mark_NOTATTACHED(struct usb_device *udev)
 {
-       struct usb_device *parent = hdev->parent;
        int i;
 
-       /* Find the device pointer to disconnect */
-       if (parent) {
-               for (i = 0; i < parent->maxchild; i++) {
-                       if (parent->children[i] == hdev) {
-                               usb_disconnect(&parent->children[i]);
-                               return;
+       for (i = 0; i < udev->maxchild; ++i) {
+               if (udev->children[i])
+                       recursively_mark_NOTATTACHED(udev->children[i]);
+       }
+       udev->state = USB_STATE_NOTATTACHED;
+}
+
+/**
+ * usb_set_device_state - change a device's current state (usbcore, hcds)
+ * @udev: pointer to device whose state should be changed
+ * @new_state: new state value to be stored
+ *
+ * udev->state is _not_ fully protected by the device lock.  Although
+ * most transitions are made only while holding the lock, the state can
+ * can change to USB_STATE_NOTATTACHED at almost any time.  This
+ * is so that devices can be marked as disconnected as soon as possible,
+ * without having to wait for any semaphores to be released.  As a result,
+ * all changes to any device's state must be protected by the
+ * device_state_lock spinlock.
+ *
+ * Once a device has been added to the device tree, all changes to its state
+ * should be made using this routine.  The state should _not_ be set directly.
+ *
+ * If udev->state is already USB_STATE_NOTATTACHED then no change is made.
+ * Otherwise udev->state is set to new_state, and if new_state is
+ * USB_STATE_NOTATTACHED then all of udev's descendants' states are also set
+ * to USB_STATE_NOTATTACHED.
+ */
+void usb_set_device_state(struct usb_device *udev,
+               enum usb_device_state new_state)
+{
+       unsigned long flags;
+
+       spin_lock_irqsave(&device_state_lock, flags);
+       if (udev->state == USB_STATE_NOTATTACHED)
+               ;       /* do nothing */
+       else if (new_state != USB_STATE_NOTATTACHED)
+               udev->state = new_state;
+       else
+               recursively_mark_NOTATTACHED(udev);
+       spin_unlock_irqrestore(&device_state_lock, flags);
+}
+EXPORT_SYMBOL(usb_set_device_state);
+
+
+static void choose_address(struct usb_device *udev)
+{
+       int             devnum;
+       struct usb_bus  *bus = udev->bus;
+
+       /* If khubd ever becomes multithreaded, this will need a lock */
+
+       /* Try to allocate the next devnum beginning at bus->devnum_next. */
+       devnum = find_next_zero_bit(bus->devmap.devicemap, 128,
+                       bus->devnum_next);
+       if (devnum >= 128)
+               devnum = find_next_zero_bit(bus->devmap.devicemap, 128, 1);
+
+       bus->devnum_next = ( devnum >= 127 ? 1 : devnum + 1);
+
+       if (devnum < 128) {
+               set_bit(devnum, bus->devmap.devicemap);
+               udev->devnum = devnum;
+       }
+}
+
+static void release_address(struct usb_device *udev)
+{
+       if (udev->devnum > 0) {
+               clear_bit(udev->devnum, udev->bus->devmap.devicemap);
+               udev->devnum = -1;
+       }
+}
+
+/**
+ * usb_disconnect - disconnect a device (usbcore-internal)
+ * @pdev: pointer to device being disconnected
+ * Context: !in_interrupt ()
+ *
+ * Something got disconnected. Get rid of it and all of its children.
+ *
+ * If *pdev is a normal device then the parent hub must already be locked.
+ * If *pdev is a root hub then this routine will acquire the
+ * usb_bus_list_lock on behalf of the caller.
+ *
+ * Only hub drivers (including virtual root hub drivers for host
+ * controllers) should ever call this.
+ *
+ * This call is synchronous, and may not be used in an interrupt context.
+ */
+void usb_disconnect(struct usb_device **pdev)
+{
+       struct usb_device       *udev = *pdev;
+       int                     i;
+
+       if (!udev) {
+               pr_debug ("%s nodev\n", __FUNCTION__);
+               return;
+       }
+
+       /* mark the device as inactive, so any further urb submissions for
+        * this device (and any of its children) will fail immediately.
+        * this quiesces everyting except pending urbs.
+        */
+       usb_set_device_state(udev, USB_STATE_NOTATTACHED);
+
+       /* lock the bus list on behalf of HCDs unregistering their root hubs */
+       if (!udev->parent) {
+               down(&usb_bus_list_lock);
+               usb_lock_device(udev);
+       } else
+               down(&udev->serialize);
+
+       dev_info (&udev->dev, "USB disconnect, address %d\n", udev->devnum);
+
+       /* Free up all the children before we remove this device */
+       for (i = 0; i < USB_MAXCHILDREN; i++) {
+               if (udev->children[i])
+                       usb_disconnect(&udev->children[i]);
+       }
+
+       /* deallocate hcd/hardware state ... nuking all pending urbs and
+        * cleaning up all state associated with the current configuration
+        * so that the hardware is now fully quiesced.
+        */
+       usb_disable_device(udev, 0);
+
+       /* Free the device number, remove the /proc/bus/usb entry and
+        * the sysfs attributes, and delete the parent's children[]
+        * (or root_hub) pointer.
+        */
+       dev_dbg (&udev->dev, "unregistering device\n");
+       release_address(udev);
+       usbfs_remove_device(udev);
+       usb_remove_sysfs_dev_files(udev);
+
+       /* Avoid races with recursively_mark_NOTATTACHED() */
+       spin_lock_irq(&device_state_lock);
+       *pdev = NULL;
+       spin_unlock_irq(&device_state_lock);
+
+       if (!udev->parent) {
+               usb_unlock_device(udev);
+               up(&usb_bus_list_lock);
+       } else
+               up(&udev->serialize);
+
+       device_unregister(&udev->dev);
+}
+
+static int choose_configuration(struct usb_device *udev)
+{
+       int c, i;
+
+       /* NOTE: this should interact with hub power budgeting */
+
+       c = udev->config[0].desc.bConfigurationValue;
+       if (udev->descriptor.bNumConfigurations != 1) {
+               for (i = 0; i < udev->descriptor.bNumConfigurations; i++) {
+                       struct usb_interface_descriptor *desc;
+
+                       /* heuristic:  Linux is more likely to have class
+                        * drivers, so avoid vendor-specific interfaces.
+                        */
+                       desc = &udev->config[i].intf_cache[0]
+                                       ->altsetting->desc;
+                       if (desc->bInterfaceClass == USB_CLASS_VENDOR_SPEC)
+                               continue;
+                       /* COMM/2/all is CDC ACM, except 0xff is MSFT RNDIS.
+                        * MSFT needs this to be the first config; never use
+                        * it as the default unless Linux has host-side RNDIS.
+                        * A second config would ideally be CDC-Ethernet, but
+                        * may instead be the "vendor specific" CDC subset
+                        * long used by ARM Linux for sa1100 or pxa255.
+                        */
+                       if (desc->bInterfaceClass == USB_CLASS_COMM
+                                       && desc->bInterfaceSubClass == 2
+                                       && desc->bInterfaceProtocol == 0xff) {
+                               c = udev->config[1].desc.bConfigurationValue;
+                               continue;
+                       }
+                       c = udev->config[i].desc.bConfigurationValue;
+                       break;
+               }
+               dev_info(&udev->dev,
+                       "configuration #%d chosen from %d choices\n",
+                       c, udev->descriptor.bNumConfigurations);
+       }
+       return c;
+}
+
+#ifdef DEBUG
+static void show_string(struct usb_device *udev, char *id, int index)
+{
+       char *buf;
+
+       if (!index)
+               return;
+       if (!(buf = kmalloc(256, GFP_KERNEL)))
+               return;
+       if (usb_string(udev, index, buf, 256) > 0)
+               dev_printk(KERN_INFO, &udev->dev, "%s: %s\n", id, buf);
+       kfree(buf);
+}
+
+#else
+static inline void show_string(struct usb_device *udev, char *id, int index)
+{}
+#endif
+
+#ifdef CONFIG_USB_OTG
+#include "otg_whitelist.h"
+#endif
+
+/**
+ * usb_new_device - perform initial device setup (usbcore-internal)
+ * @udev: newly addressed device (in ADDRESS state)
+ *
+ * This is called with devices which have been enumerated, but not yet
+ * configured.  The device descriptor is available, but not descriptors
+ * for any device configuration.  The caller must have locked udev and
+ * either the parent hub (if udev is a normal device) or else the
+ * usb_bus_list_lock (if udev is a root hub).  The parent's pointer to
+ * udev has already been installed, but udev is not yet visible through
+ * sysfs or other filesystem code.
+ *
+ * Returns 0 for success (device is configured and listed, with its
+ * interfaces, in sysfs); else a negative errno value.
+ *
+ * This call is synchronous, and may not be used in an interrupt context.
+ *
+ * Only the hub driver should ever call this; root hub registration
+ * uses it indirectly.
+ */
+int usb_new_device(struct usb_device *udev)
+{
+       int err;
+       int c;
+
+       err = usb_get_configuration(udev);
+       if (err < 0) {
+               dev_err(&udev->dev, "can't read configurations, error %d\n",
+                       err);
+               goto fail;
+       }
+
+       /* Tell the world! */
+       dev_dbg(&udev->dev, "new device strings: Mfr=%d, Product=%d, "
+                       "SerialNumber=%d\n",
+                       udev->descriptor.iManufacturer,
+                       udev->descriptor.iProduct,
+                       udev->descriptor.iSerialNumber);
+
+       if (udev->descriptor.iProduct)
+               show_string(udev, "Product",
+                               udev->descriptor.iProduct);
+       if (udev->descriptor.iManufacturer)
+               show_string(udev, "Manufacturer",
+                               udev->descriptor.iManufacturer);
+       if (udev->descriptor.iSerialNumber)
+               show_string(udev, "SerialNumber",
+                               udev->descriptor.iSerialNumber);
+
+#ifdef CONFIG_USB_OTG
+       /*
+        * OTG-aware devices on OTG-capable root hubs may be able to use SRP,
+        * to wake us after we've powered off VBUS; and HNP, switching roles
+        * "host" to "peripheral".  The OTG descriptor helps figure this out.
+        */
+       if (!udev->bus->is_b_host
+                       && udev->config
+                       && udev->parent == udev->bus->root_hub) {
+               struct usb_otg_descriptor       *desc = 0;
+               struct usb_bus                  *bus = udev->bus;
+
+               /* descriptor may appear anywhere in config */
+               if (__usb_get_extra_descriptor (udev->rawdescriptors[0],
+                                       le16_to_cpu(udev->config[0].desc.wTotalLength),
+                                       USB_DT_OTG, (void **) &desc) == 0) {
+                       if (desc->bmAttributes & USB_OTG_HNP) {
+                               unsigned                port1;
+                               struct usb_device       *root = udev->parent;
+                               
+                               for (port1 = 1; port1 <= root->maxchild;
+                                               port1++) {
+                                       if (root->children[port1-1] == udev)
+                                               break;
+                               }
+
+                               dev_info(&udev->dev,
+                                       "Dual-Role OTG device on %sHNP port\n",
+                                       (port1 == bus->otg_port)
+                                               ? "" : "non-");
+
+                               /* enable HNP before suspend, it's simpler */
+                               if (port1 == bus->otg_port)
+                                       bus->b_hnp_enable = 1;
+                               err = usb_control_msg(udev,
+                                       usb_sndctrlpipe(udev, 0),
+                                       USB_REQ_SET_FEATURE, 0,
+                                       bus->b_hnp_enable
+                                               ? USB_DEVICE_B_HNP_ENABLE
+                                               : USB_DEVICE_A_ALT_HNP_SUPPORT,
+                                       0, NULL, 0, HZ * USB_CTRL_SET_TIMEOUT);
+                               if (err < 0) {
+                                       /* OTG MESSAGE: report errors here,
+                                        * customize to match your product.
+                                        */
+                                       dev_info(&udev->dev,
+                                               "can't set HNP mode; %d\n",
+                                               err);
+                                       bus->b_hnp_enable = 0;
+                               }
                        }
                }
        }
 
-       dev_err(&hdev->dev, "cannot disconnect hub!\n");
+       if (!is_targeted(udev)) {
+
+               /* Maybe it can talk to us, though we can't talk to it.
+                * (Includes HNP test device.)
+                */
+               if (udev->bus->b_hnp_enable || udev->bus->is_b_host) {
+                       static int __usb_suspend_device (struct usb_device *,
+                                               int port1, u32 state);
+                       err = __usb_suspend_device(udev,
+                                       udev->bus->otg_port,
+                                       PM_SUSPEND_MEM);
+                       if (err < 0)
+                               dev_dbg(&udev->dev, "HNP fail, %d\n", err);
+               }
+               err = -ENODEV;
+               goto fail;
+       }
+#endif
+
+       /* put device-specific files into sysfs */
+       err = device_add (&udev->dev);
+       if (err) {
+               dev_err(&udev->dev, "can't device_add, error %d\n", err);
+               goto fail;
+       }
+       usb_create_sysfs_dev_files (udev);
+
+       /* choose and set the configuration. that registers the interfaces
+        * with the driver core, and lets usb device drivers bind to them.
+        */
+       c = choose_configuration(udev);
+       if (c < 0)
+               dev_warn(&udev->dev,
+                               "can't choose an initial configuration\n");
+       else {
+               err = usb_set_configuration(udev, c);
+               if (err) {
+                       dev_err(&udev->dev, "can't set config #%d, error %d\n",
+                                       c, err);
+                       usb_remove_sysfs_dev_files(udev);
+                       device_del(&udev->dev);
+                       goto fail;
+               }
+       }
+
+       /* USB device state == configured ... usable */
+
+       /* add a /proc/bus/usb entry */
+       usbfs_add_device(udev);
+       return 0;
+
+fail:
+       usb_set_device_state(udev, USB_STATE_NOTATTACHED);
+       return err;
 }
 
-static int hub_port_status(struct usb_device *hdev, int port,
+
+static int hub_port_status(struct usb_hub *hub, int port1,
                               u16 *status, u16 *change)
 {
-       struct usb_hub *hub = usb_get_intfdata(hdev->actconfig->interface[0]);
        int ret;
 
-       if (!hub)
-               return -ENODEV;
-
-       ret = get_port_status(hdev, port + 1, &hub->status->port);
+       ret = get_port_status(hub->hdev, port1, &hub->status->port);
        if (ret < 0)
-               dev_err (&hub->intf->dev,
+               dev_err (hub->intfdev,
                        "%s failed (err = %d)\n", __FUNCTION__, ret);
        else {
                *status = le16_to_cpu(hub->status->port.wPortStatus);
@@ -869,14 +1305,15 @@ static int hub_port_status(struct usb_device *hdev, int port,
 #define PORT_RESET_TRIES       5
 #define SET_ADDRESS_TRIES      2
 #define GET_DESCRIPTOR_TRIES   2
-#define SET_CONFIG_TRIES       2
+#define SET_CONFIG_TRIES       (2 * (use_both_schemes + 1))
+#define USE_NEW_SCHEME(i)      ((i) / 2 == old_scheme_first)
 
 #define HUB_ROOT_RESET_TIME    50      /* times are in msec */
 #define HUB_SHORT_RESET_TIME   10
 #define HUB_LONG_RESET_TIME    200
 #define HUB_RESET_TIMEOUT      500
 
-static int hub_port_wait_reset(struct usb_device *hdev, int port,
+static int hub_port_wait_reset(struct usb_hub *hub, int port1,
                                struct usb_device *udev, unsigned int delay)
 {
        int delay_time, ret;
@@ -890,7 +1327,7 @@ static int hub_port_wait_reset(struct usb_device *hdev, int port,
                msleep(delay);
 
                /* read and decode port status */
-               ret = hub_port_status(hdev, port, &portstatus, &portchange);
+               ret = hub_port_status(hub, port1, &portstatus, &portchange);
                if (ret < 0)
                        return ret;
 
@@ -918,146 +1355,733 @@ static int hub_port_wait_reset(struct usb_device *hdev, int port,
                if (delay_time >= 2 * HUB_SHORT_RESET_TIME)
                        delay = HUB_LONG_RESET_TIME;
 
-               dev_dbg (hubdev (hdev),
+               dev_dbg (hub->intfdev,
                        "port %d not reset yet, waiting %dms\n",
-                       port + 1, delay);
+                       port1, delay);
        }
 
        return -EBUSY;
 }
 
-static int hub_port_reset(struct usb_device *hdev, int port,
+static int hub_port_reset(struct usb_hub *hub, int port1,
                                struct usb_device *udev, unsigned int delay)
 {
        int i, status;
-       struct device *hub_dev = hubdev (hdev);
 
        /* Reset the port */
        for (i = 0; i < PORT_RESET_TRIES; i++) {
-               set_port_feature(hdev, port + 1, USB_PORT_FEAT_RESET);
+               status = set_port_feature(hub->hdev,
+                               port1, USB_PORT_FEAT_RESET);
+               if (status)
+                       dev_err(hub->intfdev,
+                                       "cannot reset port %d (err = %d)\n",
+                                       port1, status);
+               else
+                       status = hub_port_wait_reset(hub, port1, udev, delay);
 
                /* return on disconnect or reset */
-               status = hub_port_wait_reset(hdev, port, udev, delay);
-               if (status == -ENOTCONN || status == 0) {
-                       clear_port_feature(hdev,
-                               port + 1, USB_PORT_FEAT_C_RESET);
-                       udev->state = status
+               switch (status) {
+               case 0:
+                       /* TRSTRCY = 10 ms */
+                       msleep(10);
+                       /* FALL THROUGH */
+               case -ENOTCONN:
+               case -ENODEV:
+                       clear_port_feature(hub->hdev,
+                               port1, USB_PORT_FEAT_C_RESET);
+                       /* FIXME need disconnect() for NOTATTACHED device */
+                       usb_set_device_state(udev, status
                                        ? USB_STATE_NOTATTACHED
-                                       : USB_STATE_DEFAULT;
+                                       : USB_STATE_DEFAULT);
                        return status;
                }
 
-               dev_dbg (hub_dev,
+               dev_dbg (hub->intfdev,
                        "port %d not enabled, trying reset again...\n",
-                       port + 1);
+                       port1);
                delay = HUB_LONG_RESET_TIME;
        }
 
-       dev_err (hub_dev,
+       dev_err (hub->intfdev,
                "Cannot enable port %i.  Maybe the USB cable is bad?\n",
-               port + 1);
+               port1);
 
        return status;
 }
 
-static int hub_port_disable(struct usb_device *hdev, int port)
+static int hub_port_disable(struct usb_hub *hub, int port1, int set_state)
 {
+       struct usb_device *hdev = hub->hdev;
        int ret;
 
-       ret = clear_port_feature(hdev, port + 1, USB_PORT_FEAT_ENABLE);
+       if (hdev->children[port1-1] && set_state) {
+               usb_set_device_state(hdev->children[port1-1],
+                               USB_STATE_NOTATTACHED);
+       }
+       ret = clear_port_feature(hdev, port1, USB_PORT_FEAT_ENABLE);
        if (ret)
-               dev_err(hubdev(hdev), "cannot disable port %d (err = %d)\n",
-                       port + 1, ret);
+               dev_err(hub->intfdev, "cannot disable port %d (err = %d)\n",
+                       port1, ret);
 
        return ret;
 }
 
-/* USB 2.0 spec, 7.1.7.3 / fig 7-29:
- *
- * Between connect detection and reset signaling there must be a delay
- * of 100ms at least for debounce and power-settling. The corresponding
- * timer shall restart whenever the downstream port detects a disconnect.
- * 
- * Apparently there are some bluetooth and irda-dongles and a number
- * of low-speed devices which require longer delays of about 200-400ms.
- * Not covered by the spec - but easy to deal with.
- *
- * This implementation uses 400ms minimum debounce timeout and checks
- * every 25ms for transient disconnects to restart the delay.
+/*
+ * Disable a port and mark a logical connnect-change event, so that some
+ * time later khubd will disconnect() any existing usb_device on the port
+ * and will re-enumerate if there actually is a device attached.
  */
+static void hub_port_logical_disconnect(struct usb_hub *hub, int port1)
+{
+       dev_dbg(hub->intfdev, "logical disconnect on port %d\n", port1);
+       hub_port_disable(hub, port1, 1);
+
+       /* FIXME let caller ask to power down the port:
+        *  - some devices won't enumerate without a VBUS power cycle
+        *  - SRP saves power that way
+        *  - usb_suspend_device(dev,PM_SUSPEND_DISK)
+        * That's easy if this hub can switch power per-port, and
+        * khubd reactivates the port later (timer, SRP, etc).
+        * Powerdown must be optional, because of reset/DFU.
+        */
 
-#define HUB_DEBOUNCE_TIMEOUT   400
-#define HUB_DEBOUNCE_STEP       25
-#define HUB_DEBOUNCE_STABLE      4
+       set_bit(port1, hub->change_bits);
+       kick_khubd(hub);
+}
 
-static int hub_port_debounce(struct usb_device *hdev, int port)
-{
-       int ret;
-       int delay_time, stable_count;
-       u16 portchange, portstatus;
-       unsigned connection;
 
-       connection = 0;
-       stable_count = 0;
-       for (delay_time = 0; delay_time < HUB_DEBOUNCE_TIMEOUT; delay_time += HUB_DEBOUNCE_STEP) {
-               msleep(HUB_DEBOUNCE_STEP);
+#ifdef CONFIG_USB_SUSPEND
+
+/*
+ * Selective port suspend reduces power; most suspended devices draw
+ * less than 500 uA.  It's also used in OTG, along with remote wakeup.
+ * All devices below the suspended port are also suspended.
+ *
+ * Devices leave suspend state when the host wakes them up.  Some devices
+ * also support "remote wakeup", where the device can activate the USB
+ * tree above them to deliver data, such as a keypress or packet.  In
+ * some cases, this wakes the USB host.
+ */
+static int hub_port_suspend(struct usb_hub *hub, int port1,
+               struct usb_device *udev)
+{
+       int     status;
+
+       // dev_dbg(hub->intfdev, "suspend port %d\n", port1);
+
+       /* enable remote wakeup when appropriate; this lets the device
+        * wake up the upstream hub (including maybe the root hub).
+        *
+        * NOTE:  OTG devices may issue remote wakeup (or SRP) even when
+        * we don't explicitly enable it here.
+        */
+       if (udev->actconfig
+                       // && FIXME (remote wakeup enabled on this bus)
+                       // ... currently assuming it's always appropriate
+                       && (udev->actconfig->desc.bmAttributes
+                               & USB_CONFIG_ATT_WAKEUP) != 0) {
+               status = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
+                               USB_REQ_SET_FEATURE, USB_RECIP_DEVICE,
+                               USB_DEVICE_REMOTE_WAKEUP, 0,
+                               NULL, 0,
+                               USB_CTRL_SET_TIMEOUT);
+               if (status)
+                       dev_dbg(&udev->dev,
+                               "won't remote wakeup, status %d\n",
+                               status);
+       }
+
+       /* see 7.1.7.6 */
+       status = set_port_feature(hub->hdev, port1, USB_PORT_FEAT_SUSPEND);
+       if (status) {
+               dev_dbg(hub->intfdev,
+                       "can't suspend port %d, status %d\n",
+                       port1, status);
+               /* paranoia:  "should not happen" */
+               (void) usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
+                               USB_REQ_CLEAR_FEATURE, USB_RECIP_DEVICE,
+                               USB_DEVICE_REMOTE_WAKEUP, 0,
+                               NULL, 0,
+                               USB_CTRL_SET_TIMEOUT);
+       } else {
+               /* device has up to 10 msec to fully suspend */
+               dev_dbg(&udev->dev, "usb suspend\n");
+               usb_set_device_state(udev, USB_STATE_SUSPENDED);
+               msleep(10);
+       }
+       return status;
+}
+
+/*
+ * Devices on USB hub ports have only one "suspend" state, corresponding
+ * to ACPI D2 (PM_SUSPEND_MEM), "may cause the device to lose some context".
+ * State transitions include:
+ *
+ *   - suspend, resume ... when the VBUS power link stays live
+ *   - suspend, disconnect ... VBUS lost
+ *
+ * Once VBUS drop breaks the circuit, the port it's using has to go through
+ * normal re-enumeration procedures, starting with enabling VBUS power.
+ * Other than re-initializing the hub (plug/unplug, except for root hubs),
+ * Linux (2.6) currently has NO mechanisms to initiate that:  no khubd
+ * timer, no SRP, no requests through sysfs.
+ */
+int __usb_suspend_device (struct usb_device *udev, int port1, u32 state)
+{
+       int     status;
+
+       /* caller owns the udev device lock */
+       if (port1 < 0)
+               return port1;
+
+       if (udev->state == USB_STATE_SUSPENDED
+                       || udev->state == USB_STATE_NOTATTACHED) {
+               return 0;
+       }
+
+       /* suspend interface drivers; if this is a hub, it
+        * suspends the child devices
+        */
+       if (udev->actconfig) {
+               int     i;
+
+               for (i = 0; i < udev->actconfig->desc.bNumInterfaces; i++) {
+                       struct usb_interface    *intf;
+                       struct usb_driver       *driver;
+
+                       intf = udev->actconfig->interface[i];
+                       if (state <= intf->dev.power.power_state)
+                               continue;
+                       if (!intf->dev.driver)
+                               continue;
+                       driver = to_usb_driver(intf->dev.driver);
+
+                       if (driver->suspend) {
+                               status = driver->suspend(intf, state);
+                               if (intf->dev.power.power_state != state
+                                               || status)
+                                       dev_err(&intf->dev,
+                                               "suspend %d fail, code %d\n",
+                                               state, status);
+                       }
+
+                       /* only drivers with suspend() can ever resume();
+                        * and after power loss, even they won't.
+                        * bus_rescan_devices() can rebind drivers later.
+                        *
+                        * FIXME the PM core self-deadlocks when unbinding
+                        * drivers during suspend/resume ... everything grabs
+                        * dpm_sem (not a spinlock, ugh).  we want to unbind,
+                        * since we know every driver's probe/disconnect works
+                        * even for drivers that can't suspend.
+                        */
+                       if (!driver->suspend || state > PM_SUSPEND_MEM) {
+#if 1
+                               dev_warn(&intf->dev, "resume is unsafe!\n");
+#else
+                               down_write(&usb_bus_type.rwsem);
+                               device_release_driver(&intf->dev);
+                               up_write(&usb_bus_type.rwsem);
+#endif
+                       }
+               }
+       }
+
+       /*
+        * FIXME this needs port power off call paths too, to help force
+        * USB into the "generic" PM model.  At least for devices on
+        * ports that aren't using ganged switching (usually root hubs).
+        *
+        * NOTE: SRP-capable links should adopt more aggressive poweroff
+        * policies (when HNP doesn't apply) once we have mechanisms to
+        * turn power back on!  (Likely not before 2.7...)
+        */
+       if (state > PM_SUSPEND_MEM) {
+               dev_warn(&udev->dev, "no poweroff yet, suspending instead\n");
+       }
+
+       /* "global suspend" of the HC-to-USB interface (root hub), or
+        * "selective suspend" of just one hub-device link.
+        */
+       if (!udev->parent) {
+               struct usb_bus  *bus = udev->bus;
+               if (bus && bus->op->hub_suspend) {
+                       status = bus->op->hub_suspend (bus);
+                       if (status == 0)
+                               usb_set_device_state(udev,
+                                               USB_STATE_SUSPENDED);
+               } else
+                       status = -EOPNOTSUPP;
+       } else
+               status = hub_port_suspend(hdev_to_hub(udev->parent), port1,
+                               udev);
+
+       if (status == 0)
+               udev->dev.power.power_state = state;
+       return status;
+}
+
+/**
+ * usb_suspend_device - suspend a usb device
+ * @udev: device that's no longer in active use
+ * @state: PM_SUSPEND_MEM to suspend
+ * Context: must be able to sleep; device not locked
+ *
+ * Suspends a USB device that isn't in active use, conserving power.
+ * Devices may wake out of a suspend, if anything important happens,
+ * using the remote wakeup mechanism.  They may also be taken out of
+ * suspend by the host, using usb_resume_device().  It's also routine
+ * to disconnect devices while they are suspended.
+ *
+ * Suspending OTG devices may trigger HNP, if that's been enabled
+ * between a pair of dual-role devices.  That will change roles, such
+ * as from A-Host to A-Peripheral or from B-Host back to B-Peripheral.
+ *
+ * Returns 0 on success, else negative errno.
+ */
+int usb_suspend_device(struct usb_device *udev, u32 state)
+{
+       int     port1, status;
+
+       port1 = locktree(udev);
+       if (port1 < 0)
+               return port1;
+
+       status = __usb_suspend_device(udev, port1, state);
+       usb_unlock_device(udev);
+       return status;
+}
+
+/*
+ * hardware resume signaling is finished, either because of selective
+ * resume (by host) or remote wakeup (by device) ... now see what changed
+ * in the tree that's rooted at this device.
+ */
+static int finish_port_resume(struct usb_device *udev)
+{
+       int     status;
+       u16     devstatus;
+
+       /* caller owns the udev device lock */
+       dev_dbg(&udev->dev, "usb resume\n");
+
+       /* usb ch9 identifies four variants of SUSPENDED, based on what
+        * state the device resumes to.  Linux currently won't see the
+        * first two on the host side; they'd be inside hub_port_init()
+        * during many timeouts, but khubd can't suspend until later.
+        */
+       usb_set_device_state(udev, udev->actconfig
+                       ? USB_STATE_CONFIGURED
+                       : USB_STATE_ADDRESS);
+       udev->dev.power.power_state = PM_SUSPEND_ON;
+
+       /* 10.5.4.5 says be sure devices in the tree are still there.
+        * For now let's assume the device didn't go crazy on resume,
+        * and device drivers will know about any resume quirks.
+        */
+       status = usb_get_status(udev, USB_RECIP_DEVICE, 0, &devstatus);
+       if (status < 0)
+               dev_dbg(&udev->dev,
+                       "gone after usb resume? status %d\n",
+                       status);
+       else if (udev->actconfig) {
+               unsigned        i;
+
+               le16_to_cpus(&devstatus);
+               if (devstatus & (1 << USB_DEVICE_REMOTE_WAKEUP)) {
+                       status = usb_control_msg(udev,
+                                       usb_sndctrlpipe(udev, 0),
+                                       USB_REQ_CLEAR_FEATURE,
+                                               USB_RECIP_DEVICE,
+                                       USB_DEVICE_REMOTE_WAKEUP, 0,
+                                       NULL, 0,
+                                       USB_CTRL_SET_TIMEOUT);
+                       if (status) {
+                               dev_dbg(&udev->dev, "disable remote "
+                                       "wakeup, status %d\n", status);
+                               status = 0;
+                       }
+               }
+
+               /* resume interface drivers; if this is a hub, it
+                * resumes the child devices
+                */
+               for (i = 0; i < udev->actconfig->desc.bNumInterfaces; i++) {
+                       struct usb_interface    *intf;
+                       struct usb_driver       *driver;
+
+                       intf = udev->actconfig->interface[i];
+                       if (intf->dev.power.power_state == PM_SUSPEND_ON)
+                               continue;
+                       if (!intf->dev.driver) {
+                               /* FIXME maybe force to alt 0 */
+                               continue;
+                       }
+                       driver = to_usb_driver(intf->dev.driver);
+
+                       /* bus_rescan_devices() may rebind drivers */
+                       if (!driver->resume)
+                               continue;
+
+                       /* can we do better than just logging errors? */
+                       status = driver->resume(intf);
+                       if (intf->dev.power.power_state != PM_SUSPEND_ON
+                                       || status)
+                               dev_dbg(&intf->dev,
+                                       "resume fail, state %d code %d\n",
+                                       intf->dev.power.power_state, status);
+               }
+               status = 0;
+
+       } else if (udev->devnum <= 0) {
+               dev_dbg(&udev->dev, "bogus resume!\n");
+               status = -EINVAL;
+       }
+       return status;
+}
+
+static int
+hub_port_resume(struct usb_hub *hub, int port1, struct usb_device *udev)
+{
+       int     status;
+
+       // dev_dbg(hub->intfdev, "resume port %d\n", port1);
+
+       /* see 7.1.7.7; affects power usage, but not budgeting */
+       status = clear_port_feature(hub->hdev,
+                       port1, USB_PORT_FEAT_SUSPEND);
+       if (status) {
+               dev_dbg(hub->intfdev,
+                       "can't resume port %d, status %d\n",
+                       port1, status);
+       } else {
+               u16             devstatus;
+               u16             portchange;
+
+               /* drive resume for at least 20 msec */
+               if (udev)
+                       dev_dbg(&udev->dev, "RESUME\n");
+               msleep(25);
+
+#define LIVE_FLAGS     ( USB_PORT_STAT_POWER \
+                       | USB_PORT_STAT_ENABLE \
+                       | USB_PORT_STAT_CONNECTION)
+
+               /* Virtual root hubs can trigger on GET_PORT_STATUS to
+                * stop resume signaling.  Then finish the resume
+                * sequence.
+                */
+               devstatus = portchange = 0;
+               status = hub_port_status(hub, port1,
+                               &devstatus, &portchange);
+               if (status < 0
+                               || (devstatus & LIVE_FLAGS) != LIVE_FLAGS
+                               || (devstatus & USB_PORT_STAT_SUSPEND) != 0
+                               ) {
+                       dev_dbg(hub->intfdev,
+                               "port %d status %04x.%04x after resume, %d\n",
+                               port1, portchange, devstatus, status);
+               } else {
+                       /* TRSMRCY = 10 msec */
+                       msleep(10);
+                       if (udev)
+                               status = finish_port_resume(udev);
+               }
+       }
+       if (status < 0)
+               hub_port_logical_disconnect(hub, port1);
+
+       return status;
+}
+
+static int hub_resume (struct usb_interface *intf);
+
+/**
+ * usb_resume_device - re-activate a suspended usb device
+ * @udev: device to re-activate
+ * Context: must be able to sleep; device not locked
+ *
+ * This will re-activate the suspended device, increasing power usage
+ * while letting drivers communicate again with its endpoints.
+ * USB resume explicitly guarantees that the power session between
+ * the host and the device is the same as it was when the device
+ * suspended.
+ *
+ * Returns 0 on success, else negative errno.
+ */
+int usb_resume_device(struct usb_device *udev)
+{
+       int     port1, status;
+
+       port1 = locktree(udev);
+       if (port1 < 0)
+               return port1;
+
+       /* "global resume" of the HC-to-USB interface (root hub), or
+        * selective resume of one hub-to-device port
+        */
+       if (!udev->parent) {
+               struct usb_bus  *bus = udev->bus;
+               if (bus && bus->op->hub_resume) {
+                       status = bus->op->hub_resume (bus);
+               } else
+                       status = -EOPNOTSUPP;
+               if (status == 0) {
+                       /* TRSMRCY = 10 msec */
+                       msleep(10);
+                       usb_set_device_state (udev, USB_STATE_CONFIGURED);
+                       status = hub_resume (udev
+                                       ->actconfig->interface[0]);
+               }
+       } else if (udev->state == USB_STATE_SUSPENDED) {
+               // NOTE this fails if parent is also suspended...
+               status = hub_port_resume(hdev_to_hub(udev->parent),
+                               port1, udev);
+       } else {
+               status = 0;
+       }
+       if (status < 0) {
+               dev_dbg(&udev->dev, "can't resume, status %d\n",
+                       status);
+       }
+
+       usb_unlock_device(udev);
+
+       /* rebind drivers that had no suspend() */
+       if (status == 0) {
+               usb_lock_all_devices();
+               bus_rescan_devices(&usb_bus_type);
+               usb_unlock_all_devices();
+       }
+       return status;
+}
+
+static int remote_wakeup(struct usb_device *udev)
+{
+       int     status = 0;
+
+       /* don't repeat RESUME sequence if this device
+        * was already woken up by some other task
+        */
+       down(&udev->serialize);
+       if (udev->state == USB_STATE_SUSPENDED) {
+               dev_dbg(&udev->dev, "RESUME (wakeup)\n");
+               /* TRSMRCY = 10 msec */
+               msleep(10);
+               status = finish_port_resume(udev);
+       }
+       up(&udev->serialize);
+       return status;
+}
+
+static int hub_suspend(struct usb_interface *intf, u32 state)
+{
+       struct usb_hub          *hub = usb_get_intfdata (intf);
+       struct usb_device       *hdev = hub->hdev;
+       unsigned                port1;
+       int                     status;
+
+       /* stop khubd and related activity */
+       hub_quiesce(hub);
+
+       /* then suspend every port */
+       for (port1 = 1; port1 <= hdev->maxchild; port1++) {
+               struct usb_device       *udev;
+
+               udev = hdev->children [port1-1];
+               if (!udev)
+                       continue;
+               down(&udev->serialize);
+               status = __usb_suspend_device(udev, port1, state);
+               up(&udev->serialize);
+               if (status < 0)
+                       dev_dbg(&intf->dev, "suspend port %d --> %d\n",
+                               port1, status);
+       }
+
+       intf->dev.power.power_state = state;
+       return 0;
+}
+
+static int hub_resume(struct usb_interface *intf)
+{
+       struct usb_device       *hdev = interface_to_usbdev(intf);
+       struct usb_hub          *hub = usb_get_intfdata (intf);
+       unsigned                port1;
+       int                     status;
+
+       if (intf->dev.power.power_state == PM_SUSPEND_ON)
+               return 0;
+
+       for (port1 = 1; port1 <= hdev->maxchild; port1++) {
+               struct usb_device       *udev;
+               u16                     portstat, portchange;
+
+               udev = hdev->children [port1-1];
+               status = hub_port_status(hub, port1, &portstat, &portchange);
+               if (status == 0) {
+                       if (portchange & USB_PORT_STAT_C_SUSPEND) {
+                               clear_port_feature(hdev, port1,
+                                       USB_PORT_FEAT_C_SUSPEND);
+                               portchange &= ~USB_PORT_STAT_C_SUSPEND;
+                       }
+
+                       /* let khubd handle disconnects etc */
+                       if (portchange)
+                               continue;
+               }
+
+               if (!udev || status < 0)
+                       continue;
+               down (&udev->serialize);
+               if (portstat & USB_PORT_STAT_SUSPEND)
+                       status = hub_port_resume(hub, port1, udev);
+               else {
+                       status = finish_port_resume(udev);
+                       if (status < 0) {
+                               dev_dbg(&intf->dev, "resume port %d --> %d\n",
+                                       port1, status);
+                               hub_port_logical_disconnect(hub, port1);
+                       }
+               }
+               up(&udev->serialize);
+       }
+       intf->dev.power.power_state = PM_SUSPEND_ON;
+
+       hub_activate(hub);
+       return 0;
+}
+
+#else  /* !CONFIG_USB_SUSPEND */
+
+int usb_suspend_device(struct usb_device *udev, u32 state)
+{
+       return 0;
+}
+
+int usb_resume_device(struct usb_device *udev)
+{
+       return 0;
+}
+
+#define        hub_suspend             NULL
+#define        hub_resume              NULL
+#define        remote_wakeup(x)        0
+
+#endif /* CONFIG_USB_SUSPEND */
+
+EXPORT_SYMBOL(usb_suspend_device);
+EXPORT_SYMBOL(usb_resume_device);
+
+
+
+/* USB 2.0 spec, 7.1.7.3 / fig 7-29:
+ *
+ * Between connect detection and reset signaling there must be a delay
+ * of 100ms at least for debounce and power-settling.  The corresponding
+ * timer shall restart whenever the downstream port detects a disconnect.
+ * 
+ * Apparently there are some bluetooth and irda-dongles and a number of
+ * low-speed devices for which this debounce period may last over a second.
+ * Not covered by the spec - but easy to deal with.
+ *
+ * This implementation uses a 1500ms total debounce timeout; if the
+ * connection isn't stable by then it returns -ETIMEDOUT.  It checks
+ * every 25ms for transient disconnects.  When the port status has been
+ * unchanged for 100ms it returns the port status.
+ */
+
+#define HUB_DEBOUNCE_TIMEOUT   1500
+#define HUB_DEBOUNCE_STEP        25
+#define HUB_DEBOUNCE_STABLE     100
+
+static int hub_port_debounce(struct usb_hub *hub, int port1)
+{
+       int ret;
+       int total_time, stable_time = 0;
+       u16 portchange, portstatus;
+       unsigned connection = 0xffff;
 
-               ret = hub_port_status(hdev, port, &portstatus, &portchange);
+       for (total_time = 0; ; total_time += HUB_DEBOUNCE_STEP) {
+               ret = hub_port_status(hub, port1, &portstatus, &portchange);
                if (ret < 0)
                        return ret;
 
-               if ((portstatus & USB_PORT_STAT_CONNECTION) == connection) {
-                       if (connection) {
-                               if (++stable_count == HUB_DEBOUNCE_STABLE)
-                                       break;
-                       }
+               if (!(portchange & USB_PORT_STAT_C_CONNECTION) &&
+                    (portstatus & USB_PORT_STAT_CONNECTION) == connection) {
+                       stable_time += HUB_DEBOUNCE_STEP;
+                       if (stable_time >= HUB_DEBOUNCE_STABLE)
+                               break;
                } else {
-                       stable_count = 0;
+                       stable_time = 0;
+                       connection = portstatus & USB_PORT_STAT_CONNECTION;
                }
-               connection = portstatus & USB_PORT_STAT_CONNECTION;
 
-               if ((portchange & USB_PORT_STAT_C_CONNECTION)) {
-                       clear_port_feature(hdev, port+1, USB_PORT_FEAT_C_CONNECTION);
+               if (portchange & USB_PORT_STAT_C_CONNECTION) {
+                       clear_port_feature(hub->hdev, port1,
+                                       USB_PORT_FEAT_C_CONNECTION);
                }
+
+               if (total_time >= HUB_DEBOUNCE_TIMEOUT)
+                       break;
+               msleep(HUB_DEBOUNCE_STEP);
        }
 
-       dev_dbg (hubdev (hdev),
-               "debounce: port %d: delay %dms stable %d status 0x%x\n",
-               port + 1, delay_time, stable_count, portstatus);
+       dev_dbg (hub->intfdev,
+               "debounce: port %d: total %dms stable %dms status 0x%x\n",
+               port1, total_time, stable_time, portstatus);
 
-       return (portstatus & USB_PORT_STAT_CONNECTION) ? 0 : -ENOTCONN;
+       if (stable_time < HUB_DEBOUNCE_STABLE)
+               return -ETIMEDOUT;
+       return portstatus;
 }
 
+static void ep0_reinit(struct usb_device *udev)
+{
+       usb_disable_endpoint(udev, 0 + USB_DIR_IN);
+       usb_disable_endpoint(udev, 0 + USB_DIR_OUT);
+       udev->ep_in[0] = udev->ep_out[0] = &udev->ep0;
+}
+
+#define usb_sndaddr0pipe()     (PIPE_CONTROL << 30)
+#define usb_rcvaddr0pipe()     ((PIPE_CONTROL << 30) | USB_DIR_IN)
+
 static int hub_set_address(struct usb_device *udev)
 {
        int retval;
 
        if (udev->devnum == 0)
                return -EINVAL;
-       if (udev->state != USB_STATE_DEFAULT &&
-                       udev->state != USB_STATE_ADDRESS)
+       if (udev->state == USB_STATE_ADDRESS)
+               return 0;
+       if (udev->state != USB_STATE_DEFAULT)
                return -EINVAL;
-       retval = usb_control_msg(udev, usb_snddefctrl(udev),
+       retval = usb_control_msg(udev, usb_sndaddr0pipe(),
                USB_REQ_SET_ADDRESS, 0, udev->devnum, 0,
                NULL, 0, HZ * USB_CTRL_SET_TIMEOUT);
-       if (retval == 0)
-               udev->state = USB_STATE_ADDRESS;
+       if (retval == 0) {
+               usb_set_device_state(udev, USB_STATE_ADDRESS);
+               ep0_reinit(udev);
+       }
        return retval;
 }
 
-/* reset device, (re)assign address, get device descriptor.
- * device connection is stable, no more debouncing needed.
- * returns device in USB_STATE_ADDRESS, except on error.
- * on error return, device is no longer usable (ref dropped).
+/* Reset device, (re)assign address, get device descriptor.
+ * Device connection must be stable, no more debouncing needed.
+ * Returns device in USB_STATE_ADDRESS, except on error.
  *
- * caller owns dev->serialize for the device, guarding against
- * config changes and disconnect processing.
+ * If this is called for an already-existing device (as part of
+ * usb_reset_device), the caller must own the device lock.  For a
+ * newly detected device that is not accessible through any global
+ * pointers, it's not necessary to lock the device.
  */
 static int
-hub_port_init (struct usb_device *hdev, struct usb_device *udev, int port)
+hub_port_init (struct usb_hub *hub, struct usb_device *udev, int port1,
+               int retry_counter)
 {
        static DECLARE_MUTEX(usb_address0_sem);
 
+       struct usb_device       *hdev = hub->hdev;
        int                     i, j, retval;
        unsigned                delay = HUB_SHORT_RESET_TIME;
        enum usb_device_speed   oldspeed = udev->speed;
@@ -1065,8 +2089,11 @@ hub_port_init (struct usb_device *hdev, struct usb_device *udev, int port)
        /* root hub ports have a slightly longer reset period
         * (from USB 2.0 spec, section 7.1.7.5)
         */
-       if (!hdev->parent)
+       if (!hdev->parent) {
                delay = HUB_ROOT_RESET_TIME;
+               if (port1 == hdev->bus->otg_port)
+                       hdev->bus->b_hnp_enable = 0;
+       }
 
        /* Some low speed devices have problems with the quick delay, so */
        /*  be a bit pessimistic with those devices. RHbug #23670 */
@@ -1076,7 +2103,7 @@ hub_port_init (struct usb_device *hdev, struct usb_device *udev, int port)
        down(&usb_address0_sem);
 
        /* Reset the device; full speed may morph to high speed */
-       retval = hub_port_reset(hdev, port, udev, delay);
+       retval = hub_port_reset(hub, port1, udev, delay);
        if (retval < 0)         /* error or disconnect */
                goto fail;
                                /* success, speed is known */
@@ -1086,74 +2113,120 @@ hub_port_init (struct usb_device *hdev, struct usb_device *udev, int port)
                dev_dbg(&udev->dev, "device reset changed speed!\n");
                goto fail;
        }
+       oldspeed = udev->speed;
   
        /* USB 2.0 section 5.5.3 talks about ep0 maxpacket ...
         * it's fixed size except for full speed devices.
         */
        switch (udev->speed) {
        case USB_SPEED_HIGH:            /* fixed at 64 */
-               i = 64;
+               udev->ep0.desc.wMaxPacketSize = __constant_cpu_to_le16(64);
                break;
        case USB_SPEED_FULL:            /* 8, 16, 32, or 64 */
-               /* to determine the ep0 maxpacket size, read the first 8
-                * bytes from the device descriptor to get bMaxPacketSize0;
-                * then correct our initial (small) guess.
+               /* to determine the ep0 maxpacket size, try to read
+                * the device descriptor to get bMaxPacketSize0 and
+                * then correct our initial guess.
                 */
-               // FALLTHROUGH
+               udev->ep0.desc.wMaxPacketSize = __constant_cpu_to_le16(64);
+               break;
        case USB_SPEED_LOW:             /* fixed at 8 */
-               i = 8;
+               udev->ep0.desc.wMaxPacketSize = __constant_cpu_to_le16(8);
                break;
        default:
                goto fail;
        }
-       udev->epmaxpacketin [0] = i;
-       udev->epmaxpacketout[0] = i;
-       /* set the address */
-       if (udev->devnum <= 0) {
-               usb_choose_address(udev);
-               if (udev->devnum <= 0)
-                       goto fail;
-
-               /* Set up TT records, if needed  */
-               if (hdev->tt) {
-                       udev->tt = hdev->tt;
-                       udev->ttport = hdev->ttport;
-               } else if (udev->speed != USB_SPEED_HIGH
-                               && hdev->speed == USB_SPEED_HIGH) {
-                       struct usb_hub  *hub;
-                       hub = usb_get_intfdata (hdev->actconfig
-                                                       ->interface[0]);
-                       udev->tt = &hub->tt;
-                       udev->ttport = port + 1;
-               }
-
-               /* force the right log message (below) at low speed */
-               oldspeed = USB_SPEED_UNKNOWN;
-       }
  
        dev_info (&udev->dev,
-                       "%s %s speed USB device using address %d\n",
-                       (oldspeed == USB_SPEED_UNKNOWN) ? "new" : "reset",
+                       "%s %s speed USB device using %s and address %d\n",
+                       (udev->config) ? "reset" : "new",
                        ({ char *speed; switch (udev->speed) {
                        case USB_SPEED_LOW:     speed = "low";  break;
                        case USB_SPEED_FULL:    speed = "full"; break;
                        case USB_SPEED_HIGH:    speed = "high"; break;
                        default:                speed = "?";    break;
                        }; speed;}),
+                       udev->bus->controller->driver->name,
                        udev->devnum);
+
+       /* Set up TT records, if needed  */
+       if (hdev->tt) {
+               udev->tt = hdev->tt;
+               udev->ttport = hdev->ttport;
+       } else if (udev->speed != USB_SPEED_HIGH
+                       && hdev->speed == USB_SPEED_HIGH) {
+               udev->tt = &hub->tt;
+               udev->ttport = port1;
+       }
  
        /* Why interleave GET_DESCRIPTOR and SET_ADDRESS this way?
         * Because device hardware and firmware is sometimes buggy in
         * this area, and this is how Linux has done it for ages.
         * Change it cautiously.
         *
-        * NOTE:  Windows gets the descriptor first, seemingly to help
-        * work around device bugs like "can't use addresses with bit 3
-        * set in certain configurations".  Yes, really.
+        * NOTE:  If USE_NEW_SCHEME() is true we will start by issuing
+        * a 64-byte GET_DESCRIPTOR request.  This is what Windows does,
+        * so it may help with some non-standards-compliant devices.
+        * Otherwise we start with SET_ADDRESS and then try to read the
+        * first 8 bytes of the device descriptor to get the ep0 maxpacket
+        * value.
         */
-       for (i = 0; i < GET_DESCRIPTOR_TRIES; ++i) {
+       for (i = 0; i < GET_DESCRIPTOR_TRIES; (++i, msleep(100))) {
+               if (USE_NEW_SCHEME(retry_counter)) {
+                       struct usb_device_descriptor *buf;
+                       int r = 0;
+
+#define GET_DESCRIPTOR_BUFSIZE 64
+                       buf = kmalloc(GET_DESCRIPTOR_BUFSIZE, GFP_NOIO);
+                       if (!buf) {
+                               retval = -ENOMEM;
+                               continue;
+                       }
+                       buf->bMaxPacketSize0 = 0;
+
+                       /* Use a short timeout the first time through,
+                        * so that recalcitrant full-speed devices with
+                        * 8- or 16-byte ep0-maxpackets won't slow things
+                        * down tremendously by NAKing the unexpectedly
+                        * early status stage.  Also, retry on length 0
+                        * or stall; some devices are flakey.
+                        */
+                       for (j = 0; j < 3; ++j) {
+                               r = usb_control_msg(udev, usb_rcvaddr0pipe(),
+                                       USB_REQ_GET_DESCRIPTOR, USB_DIR_IN,
+                                       USB_DT_DEVICE << 8, 0,
+                                       buf, GET_DESCRIPTOR_BUFSIZE,
+                                       (i ? HZ * USB_CTRL_GET_TIMEOUT : HZ));
+                               if (r == 0 || r == -EPIPE)
+                                       continue;
+                               if (r < 0)
+                                       break;
+                       }
+                       udev->descriptor.bMaxPacketSize0 =
+                                       buf->bMaxPacketSize0;
+                       kfree(buf);
+
+                       retval = hub_port_reset(hub, port1, udev, delay);
+                       if (retval < 0)         /* error or disconnect */
+                               goto fail;
+                       if (oldspeed != udev->speed) {
+                               dev_dbg(&udev->dev,
+                                       "device reset changed speed!\n");
+                               retval = -ENODEV;
+                               goto fail;
+                       }
+                       switch (udev->descriptor.bMaxPacketSize0) {
+                       case 64: case 32: case 16: case 8:
+                               break;
+                       default:
+                               dev_err(&udev->dev, "device descriptor "
+                                               "read/%s, error %d\n",
+                                               "64", r);
+                               retval = -EMSGSIZE;
+                               continue;
+                       }
+#undef GET_DESCRIPTOR_BUFSIZE
+               }
+
                for (j = 0; j < SET_ADDRESS_TRIES; ++j) {
                        retval = hub_set_address(udev);
                        if (retval >= 0)
@@ -1164,12 +2237,7 @@ hub_port_init (struct usb_device *hdev, struct usb_device *udev, int port)
                        dev_err(&udev->dev,
                                "device not accepting address %d, error %d\n",
                                udev->devnum, retval);
- fail:
-                       hub_port_disable(hdev, port);
-                       usb_release_address(udev);
-                       usb_put_dev(udev);
-                       up(&usb_address0_sem);
-                       return retval;
+                       goto fail;
                }
  
                /* cope with hardware quirkiness:
@@ -1177,26 +2245,35 @@ hub_port_init (struct usb_device *hdev, struct usb_device *udev, int port)
                 *  - read ep0 maxpacket even for high and low speed,
                 */
                msleep(10);
+               if (USE_NEW_SCHEME(retry_counter))
+                       break;
+
                retval = usb_get_device_descriptor(udev, 8);
-               if (retval >= 8)
+               if (retval < 8) {
+                       dev_err(&udev->dev, "device descriptor "
+                                       "read/%s, error %d\n",
+                                       "8", retval);
+                       if (retval >= 0)
+                               retval = -EMSGSIZE;
+               } else {
+                       retval = 0;
                        break;
-               msleep(100);
+               }
        }
-       if (retval != 8) {
-               dev_err(&udev->dev, "device descriptor read/%s, error %d\n",
-                               "8", retval);
-               if (retval >= 0)
-                       retval = -EMSGSIZE;
+       if (retval)
                goto fail;
-       }
-       if (udev->speed == USB_SPEED_FULL
-                       && (udev->epmaxpacketin [0]
-                               != udev->descriptor.bMaxPacketSize0)) {
-               usb_disable_endpoint(udev, 0);
-               usb_endpoint_running(udev, 0, 1);
-               usb_endpoint_running(udev, 0, 0);
-               udev->epmaxpacketin [0] = udev->descriptor.bMaxPacketSize0;
-               udev->epmaxpacketout[0] = udev->descriptor.bMaxPacketSize0;
+
+       i = udev->descriptor.bMaxPacketSize0;
+       if (le16_to_cpu(udev->ep0.desc.wMaxPacketSize) != i) {
+               if (udev->speed != USB_SPEED_FULL ||
+                               !(i == 8 || i == 16 || i == 32 || i == 64)) {
+                       dev_err(&udev->dev, "ep0 maxpacket = %d\n", i);
+                       retval = -EMSGSIZE;
+                       goto fail;
+               }
+               dev_dbg(&udev->dev, "ep0 maxpacket = %d\n", i);
+               udev->ep0.desc.wMaxPacketSize = cpu_to_le16(i);
+               ep0_reinit(udev);
        }
   
        retval = usb_get_device_descriptor(udev, USB_DT_DEVICE_SIZE);
@@ -1208,21 +2285,23 @@ hub_port_init (struct usb_device *hdev, struct usb_device *udev, int port)
                goto fail;
        }
 
-       /* now dev is visible to other tasks */
-       hdev->children[port] = udev;
+       retval = 0;
 
+fail:
+       if (retval)
+               hub_port_disable(hub, port1, 0);
        up(&usb_address0_sem);
-       return 0;
+       return retval;
 }
 
 static void
-check_highspeed (struct usb_hub *hub, struct usb_device *udev, int port)
+check_highspeed (struct usb_hub *hub, struct usb_device *udev, int port1)
 {
        struct usb_qualifier_descriptor *qual;
        int                             status;
 
        qual = kmalloc (sizeof *qual, SLAB_KERNEL);
-       if (qual == 0)
+       if (qual == NULL)
                return;
 
        status = usb_get_descriptor (udev, USB_DT_DEVICE_QUALIFIER, 0,
@@ -1232,7 +2311,7 @@ check_highspeed (struct usb_hub *hub, struct usb_device *udev, int port)
                        "connect to a high speed hub\n");
                /* hub LEDs are probably harder to miss than syslog */
                if (hub->has_indicators) {
-                       hub->indicator[port] = INDICATOR_GREEN_BLINK;
+                       hub->indicator[port1-1] = INDICATOR_GREEN_BLINK;
                        schedule_work (&hub->leds);
                }
        }
@@ -1240,8 +2319,9 @@ check_highspeed (struct usb_hub *hub, struct usb_device *udev, int port)
 }
 
 static unsigned
-hub_power_remaining (struct usb_hub *hub, struct usb_device *hdev)
+hub_power_remaining (struct usb_hub *hub)
 {
+       struct usb_device *hdev = hub->hdev;
        int remaining;
        unsigned i;
 
@@ -1251,49 +2331,81 @@ hub_power_remaining (struct usb_hub *hub, struct usb_device *hdev)
 
        for (i = 0; i < hdev->maxchild; i++) {
                struct usb_device       *udev = hdev->children[i];
-               int                     delta;
+               int                     delta, ceiling;
 
                if (!udev)
                        continue;
 
+               /* 100mA per-port ceiling, or 8mA for OTG ports */
+               if (i != (udev->bus->otg_port - 1) || hdev->parent)
+                       ceiling = 50;
+               else
+                       ceiling = 4;
+
                if (udev->actconfig)
                        delta = udev->actconfig->desc.bMaxPower;
                else
-                       delta = 50;
+                       delta = ceiling;
                // dev_dbg(&udev->dev, "budgeted %dmA\n", 2 * delta);
+               if (delta > ceiling)
+                       dev_warn(&udev->dev, "%dmA over %dmA budget!\n",
+                               2 * (delta - ceiling), 2 * ceiling);
                remaining -= delta;
        }
        if (remaining < 0) {
-               dev_warn(&hub->intf->dev,
+               dev_warn(hub->intfdev,
                        "%dmA over power budget!\n",
                        -2 * remaining);
                remaining = 0;
        }
        return remaining;
 }
-static void hub_port_connect_change(struct usb_hub *hub, int port,
+
+/* Handle physical or logical connection change events.
+ * This routine is called when:
+ *     a port connection-change occurs;
+ *     a port enable-change occurs (often caused by EMI);
+ *     usb_reset_device() encounters changed descriptors (as from
+ *             a firmware download)
+ * caller already locked the hub
+ */
+static void hub_port_connect_change(struct usb_hub *hub, int port1,
                                        u16 portstatus, u16 portchange)
 {
-       struct usb_device *hdev = interface_to_usbdev(hub->intf);
-       struct device *hub_dev = &hub->intf->dev;
+       struct usb_device *hdev = hub->hdev;
+       struct device *hub_dev = hub->intfdev;
        int status, i;
  
        dev_dbg (hub_dev,
                "port %d, status %04x, change %04x, %s\n",
-               port + 1, portstatus, portchange, portspeed (portstatus));
-       /* Clear the connection change status */
-       clear_port_feature(hdev, port + 1, USB_PORT_FEAT_C_CONNECTION);
+               port1, portstatus, portchange, portspeed (portstatus));
 
        if (hub->has_indicators) {
-               set_port_led(hdev, port + 1, HUB_LED_AUTO);
-               hub->indicator[port] = INDICATOR_AUTO;
+               set_port_led(hub, port1, HUB_LED_AUTO);
+               hub->indicator[port1-1] = INDICATOR_AUTO;
        }
  
        /* Disconnect any existing devices under this port */
-       if (hdev->children[port])
-               usb_disconnect(&hdev->children[port]);
+       if (hdev->children[port1-1])
+               usb_disconnect(&hdev->children[port1-1]);
+       clear_bit(port1, hub->change_bits);
+
+#ifdef CONFIG_USB_OTG
+       /* during HNP, don't repeat the debounce */
+       if (hdev->bus->is_b_host)
+               portchange &= ~USB_PORT_STAT_C_CONNECTION;
+#endif
+
+       if (portchange & USB_PORT_STAT_C_CONNECTION) {
+               status = hub_port_debounce(hub, port1);
+               if (status < 0) {
+                       dev_err (hub_dev,
+                               "connect-debounce failed, port %d disabled\n",
+                               port1);
+                       goto done;
+               }
+               portstatus = status;
+       }
 
        /* Return now if nothing is connected */
        if (!(portstatus & USB_PORT_STAT_CONNECTION)) {
@@ -1302,19 +2414,25 @@ static void hub_port_connect_change(struct usb_hub *hub, int port,
                if ((hub->descriptor->wHubCharacteristics
                                        & HUB_CHAR_LPSM) < 2
                                && !(portstatus & (1 << USB_PORT_FEAT_POWER)))
-                       set_port_feature(hdev, port + 1, USB_PORT_FEAT_POWER);
+                       set_port_feature(hdev, port1, USB_PORT_FEAT_POWER);
  
                if (portstatus & USB_PORT_STAT_ENABLE)
                        goto done;
                return;
        }
-  
-       if (hub_port_debounce(hdev, port)) {
-               dev_err (hub_dev,
-                       "connect-debounce failed, port %d disabled\n",
-                       port+1);
-               goto done;
+
+#ifdef  CONFIG_USB_SUSPEND
+       /* If something is connected, but the port is suspended, wake it up. */
+       if (portstatus & USB_PORT_STAT_SUSPEND) {
+               status = hub_port_resume(hub, port1, NULL);
+               if (status < 0) {
+                       dev_dbg(hub_dev,
+                               "can't clear suspend on port %d; %d\n",
+                               port1, status);
+                       goto done;
+               }
        }
+#endif
 
        for (i = 0; i < SET_CONFIG_TRIES; i++) {
                struct usb_device *udev;
@@ -1322,27 +2440,28 @@ static void hub_port_connect_change(struct usb_hub *hub, int port,
                /* reallocate for each attempt, since references
                 * to the previous one can escape in various ways
                 */
-               udev = usb_alloc_dev(hdev, hdev->bus, port);
+               udev = usb_alloc_dev(hdev, hdev->bus, port1);
                if (!udev) {
                        dev_err (hub_dev,
-                               "couldn't allocate port %d usb_device\n", port+1);
+                               "couldn't allocate port %d usb_device\n",
+                               port1);
                        goto done;
                }
-               udev->state = USB_STATE_POWERED;
-         
-               /* hub can tell if it's lowspeed already:  D- pullup (not D+) */
-               if (portstatus & USB_PORT_STAT_LOW_SPEED)
-                       udev->speed = USB_SPEED_LOW;
-               else
-                       udev->speed = USB_SPEED_UNKNOWN;
 
-               /* reset, set address, get descriptor, add to hub's children */
-               down (&udev->serialize);
-               status = hub_port_init(hdev, udev, port);
-               if (status == -ENOTCONN)
-                       break;
+               usb_set_device_state(udev, USB_STATE_POWERED);
+               udev->speed = USB_SPEED_UNKNOWN;
+               /* set the address */
+               choose_address(udev);
+               if (udev->devnum <= 0) {
+                       status = -ENOTCONN;     /* Don't retry */
+                       goto loop;
+               }
+
+               /* reset and get descriptor */
+               status = hub_port_init(hub, udev, port1, i);
                if (status < 0)
-                       continue;
+                       goto loop;
 
                /* consecutive bus-powered hubs aren't reliable; they can
                 * violate the voltage drop budget.  if the new child has
@@ -1358,7 +2477,7 @@ static void hub_port_connect_change(struct usb_hub *hub, int port,
                                        &devstat);
                        if (status < 0) {
                                dev_dbg(&udev->dev, "get status %d ?\n", status);
-                               continue;
+                               goto loop_disable;
                        }
                        cpu_to_le16s(&devstat);
                        if ((devstat & (1 << USB_DEVICE_SELF_POWERED)) == 0) {
@@ -1366,49 +2485,80 @@ static void hub_port_connect_change(struct usb_hub *hub, int port,
                                        "can't connect bus-powered hub "
                                        "to this port\n");
                                if (hub->has_indicators) {
-                                       hub->indicator[port] =
+                                       hub->indicator[port1-1] =
                                                INDICATOR_AMBER_BLINK;
                                        schedule_work (&hub->leds);
                                }
-                               hdev->children[port] = NULL;
-                               usb_put_dev(udev);
-                               hub_port_disable(hdev, port);
-                               return;
+                               status = -ENOTCONN;     /* Don't retry */
+                               goto loop_disable;
                        }
                }
  
                /* check for devices running slower than they could */
-               if (udev->descriptor.bcdUSB >= 0x0200
+               if (le16_to_cpu(udev->descriptor.bcdUSB) >= 0x0200
                                && udev->speed == USB_SPEED_FULL
                                && highspeed_hubs != 0)
-                       check_highspeed (hub, udev, port);
+                       check_highspeed (hub, udev, port1);
+
+               /* Store the parent's children[] pointer.  At this point
+                * udev becomes globally accessible, although presumably
+                * no one will look at it until hdev is unlocked.
+                */
+               down (&udev->serialize);
+               status = 0;
+
+               /* We mustn't add new devices if the parent hub has
+                * been disconnected; we would race with the
+                * recursively_mark_NOTATTACHED() routine.
+                */
+               spin_lock_irq(&device_state_lock);
+               if (hdev->state == USB_STATE_NOTATTACHED)
+                       status = -ENOTCONN;
+               else
+                       hdev->children[port1-1] = udev;
+               spin_unlock_irq(&device_state_lock);
 
                /* Run it through the hoops (find a driver, etc) */
-               status = usb_new_device(udev);
-               if (status != 0) {
-                       hdev->children[port] = NULL;
-                       continue;
+               if (!status) {
+                       status = usb_new_device(udev);
+                       if (status) {
+                               spin_lock_irq(&device_state_lock);
+                               hdev->children[port1-1] = NULL;
+                               spin_unlock_irq(&device_state_lock);
+                       }
                }
+
                up (&udev->serialize);
+               if (status)
+                       goto loop_disable;
 
-               status = hub_power_remaining(hub, hdev);
+               status = hub_power_remaining(hub);
                if (status)
                        dev_dbg(hub_dev,
                                "%dmA power budget left\n",
                                2 * status);
 
                return;
+
+loop_disable:
+               hub_port_disable(hub, port1, 1);
+loop:
+               ep0_reinit(udev);
+               release_address(udev);
+               usb_put_dev(udev);
+               if (status == -ENOTCONN)
+                       break;
        }
  
 done:
-       hub_port_disable(hdev, port);
+       hub_port_disable(hub, port1, 1);
 }
 
 static void hub_events(void)
 {
-       unsigned long flags;
        struct list_head *tmp;
        struct usb_device *hdev;
+       struct usb_interface *intf;
        struct usb_hub *hub;
        struct device *hub_dev;
        u16 hubstatus;
@@ -1416,6 +2566,7 @@ static void hub_events(void)
        u16 portstatus;
        u16 portchange;
        int i, ret;
+       int connect_change;
 
        /*
         *  We restart the list every time to avoid a deadlock with
@@ -1424,55 +2575,83 @@ static void hub_events(void)
         * Not the most efficient, but avoids deadlocks.
         */
        while (1) {
-               spin_lock_irqsave(&hub_event_lock, flags);
 
-               if (list_empty(&hub_event_list))
+               /* Grab the first entry at the beginning of the list */
+               spin_lock_irq(&hub_event_lock);
+               if (list_empty(&hub_event_list)) {
+                       spin_unlock_irq(&hub_event_lock);
                        break;
+               }
 
-               /* Grab the next entry from the beginning of the list */
                tmp = hub_event_list.next;
-
-               hub = list_entry(tmp, struct usb_hub, event_list);
-               hdev = interface_to_usbdev(hub->intf);
-               hub_dev = &hub->intf->dev;
-
                list_del_init(tmp);
 
-               if (unlikely(down_trylock(&hub->khubd_sem)))
-                       BUG();  /* never blocks, we were on list */
-
-               spin_unlock_irqrestore(&hub_event_lock, flags);
+               hub = list_entry(tmp, struct usb_hub, event_list);
+               hdev = hub->hdev;
+               intf = to_usb_interface(hub->intfdev);
+               hub_dev = &intf->dev;
+
+               dev_dbg(hub_dev, "state %d ports %d chg %04x evt %04x\n",
+                               hdev->state, hub->descriptor
+                                       ? hub->descriptor->bNbrPorts
+                                       : 0,
+                               /* NOTE: expects max 15 ports... */
+                               (u16) hub->change_bits[0],
+                               (u16) hub->event_bits[0]);
+
+               usb_get_intf(intf);
+               spin_unlock_irq(&hub_event_lock);
+
+               /* Lock the device, then check to see if we were
+                * disconnected while waiting for the lock to succeed. */
+               if (locktree(hdev) < 0) {
+                       usb_put_intf(intf);
+                       continue;
+               }
+               if (hub != usb_get_intfdata(intf) || hub->quiescing)
+                       goto loop;
 
                if (hub->error) {
                        dev_dbg (hub_dev, "resetting for error %d\n",
                                hub->error);
 
-                       if (hub_reset(hub)) {
+                       ret = usb_reset_device(hdev);
+                       if (ret) {
                                dev_dbg (hub_dev,
-                                       "can't reset; disconnecting\n");
-                               up(&hub->khubd_sem);
-                               hub_start_disconnect(hdev);
-                               continue;
+                                       "error resetting hub: %d\n", ret);
+                               goto loop;
                        }
 
                        hub->nerrors = 0;
                        hub->error = 0;
                }
 
-               for (i = 0; i < hub->descriptor->bNbrPorts; i++) {
-                       ret = hub_port_status(hdev, i, &portstatus, &portchange);
-                       if (ret < 0) {
+               /* deal with port status changes */
+               for (i = 1; i <= hub->descriptor->bNbrPorts; i++) {
+                       connect_change = test_bit(i, hub->change_bits);
+                       if (!test_and_clear_bit(i, hub->event_bits) &&
+                                       !connect_change)
+                               continue;
+
+                       ret = hub_port_status(hub, i,
+                                       &portstatus, &portchange);
+                       if (ret < 0)
                                continue;
-                       }
 
                        if (portchange & USB_PORT_STAT_C_CONNECTION) {
-                               hub_port_connect_change(hub, i, portstatus, portchange);
-                       } else if (portchange & USB_PORT_STAT_C_ENABLE) {
-                               dev_dbg (hub_dev,
-                                       "port %d enable change, status %08x\n",
-                                       i + 1, portstatus);
-                               clear_port_feature(hdev,
-                                       i + 1, USB_PORT_FEAT_C_ENABLE);
+                               clear_port_feature(hdev, i,
+                                       USB_PORT_FEAT_C_CONNECTION);
+                               connect_change = 1;
+                       }
+
+                       if (portchange & USB_PORT_STAT_C_ENABLE) {
+                               if (!connect_change)
+                                       dev_dbg (hub_dev,
+                                               "port %d enable change, "
+                                               "status %08x\n",
+                                               i, portstatus);
+                               clear_port_feature(hdev, i,
+                                       USB_PORT_FEAT_C_ENABLE);
 
                                /*
                                 * EM interference sometimes causes badly
@@ -1481,46 +2660,60 @@ static void hub_events(void)
                                 * Works at least with mouse driver. 
                                 */
                                if (!(portstatus & USB_PORT_STAT_ENABLE)
-                                   && (portstatus & USB_PORT_STAT_CONNECTION)
-                                   && (hdev->children[i])) {
+                                   && !connect_change
+                                   && hdev->children[i-1]) {
                                        dev_err (hub_dev,
                                            "port %i "
                                            "disabled by hub (EMI?), "
-                                           "re-enabling...",
-                                               i + 1);
-                                       hub_port_connect_change(hub,
-                                               i, portstatus, portchange);
+                                           "re-enabling...\n",
+                                               i);
+                                       connect_change = 1;
                                }
                        }
 
                        if (portchange & USB_PORT_STAT_C_SUSPEND) {
+                               clear_port_feature(hdev, i,
+                                       USB_PORT_FEAT_C_SUSPEND);
+                               if (hdev->children[i-1]) {
+                                       ret = remote_wakeup(hdev->
+                                                       children[i-1]);
+                                       if (ret < 0)
+                                               connect_change = 1;
+                               } else {
+                                       ret = -ENODEV;
+                                       hub_port_disable(hub, i, 1);
+                               }
                                dev_dbg (hub_dev,
-                                       "suspend change on port %d\n",
-                                       i + 1);
-                               clear_port_feature(hdev,
-                                       i + 1,  USB_PORT_FEAT_C_SUSPEND);
+                                       "resume on port %d, status %d\n",
+                                       i, ret);
                        }
                        
                        if (portchange & USB_PORT_STAT_C_OVERCURRENT) {
                                dev_err (hub_dev,
                                        "over-current change on port %d\n",
-                                       i + 1);
-                               clear_port_feature(hdev,
-                                       i + 1, USB_PORT_FEAT_C_OVER_CURRENT);
+                                       i);
+                               clear_port_feature(hdev, i,
+                                       USB_PORT_FEAT_C_OVER_CURRENT);
                                hub_power_on(hub);
                        }
 
                        if (portchange & USB_PORT_STAT_C_RESET) {
                                dev_dbg (hub_dev,
                                        "reset change on port %d\n",
-                                       i + 1);
-                               clear_port_feature(hdev,
-                                       i + 1, USB_PORT_FEAT_C_RESET);
+                                       i);
+                               clear_port_feature(hdev, i,
+                                       USB_PORT_FEAT_C_RESET);
                        }
+
+                       if (connect_change)
+                               hub_port_connect_change(hub, i,
+                                               portstatus, portchange);
                } /* end for i */
 
                /* deal with hub status changes */
-               if (hub_hub_status(hub, &hubstatus, &hubchange) < 0)
+               if (test_and_clear_bit(0, hub->event_bits) == 0)
+                       ;       /* do nothing */
+               else if (hub_hub_status(hub, &hubstatus, &hubchange) < 0)
                        dev_err (hub_dev, "get_hub_status failed\n");
                else {
                        if (hubchange & HUB_CHANGE_LOCAL_POWER) {
@@ -1534,10 +2727,12 @@ static void hub_events(void)
                                hub_power_on(hub);
                        }
                }
-               up(&hub->khubd_sem);
-        } /* end while (1) */
 
-       spin_unlock_irqrestore(&hub_event_lock, flags);
+loop:
+               usb_unlock_device(hdev);
+               usb_put_intf(intf);
+
+        } /* end while (1) */
 }
 
 static int hub_thread(void *__unused)
@@ -1554,8 +2749,7 @@ static int hub_thread(void *__unused)
        do {
                hub_events();
                wait_event_interruptible(khubd_wait, !list_empty(&hub_event_list)); 
-               if (current->flags & PF_FREEZE)
-                       refrigerator(PF_FREEZE);
+               try_to_freeze(PF_FREEZE);
        } while (!signal_pending(current));
 
        pr_debug ("%s: khubd exiting\n", usbcore_name);
@@ -1577,13 +2771,12 @@ static struct usb_driver hub_driver = {
        .name =         "hub",
        .probe =        hub_probe,
        .disconnect =   hub_disconnect,
+       .suspend =      hub_suspend,
+       .resume =       hub_resume,
        .ioctl =        hub_ioctl,
        .id_table =     hub_id_table,
 };
 
-/*
- * This should be a separate module.
- */
 int usb_hub_init(void)
 {
        pid_t pid;
@@ -1635,18 +2828,18 @@ static int config_descriptors_changed(struct usb_device *udev)
        struct usb_config_descriptor    *buf;
 
        for (index = 0; index < udev->descriptor.bNumConfigurations; index++) {
-               if (len < udev->config[index].desc.wTotalLength)
-                       len = udev->config[index].desc.wTotalLength;
+               if (len < le16_to_cpu(udev->config[index].desc.wTotalLength))
+                       len = le16_to_cpu(udev->config[index].desc.wTotalLength);
        }
        buf = kmalloc (len, SLAB_KERNEL);
-       if (buf == 0) {
+       if (buf == NULL) {
                dev_err(&udev->dev, "no mem to re-read configs after reset\n");
                /* assume the worst */
                return 1;
        }
        for (index = 0; index < udev->descriptor.bNumConfigurations; index++) {
                int length;
-               int old_length = udev->config[index].desc.wTotalLength;
+               int old_length = le16_to_cpu(udev->config[index].desc.wTotalLength);
 
                length = usb_get_descriptor(udev, USB_DT_CONFIG, index, buf,
                                old_length);
@@ -1659,49 +2852,89 @@ static int config_descriptors_changed(struct usb_device *udev)
                                != 0) {
                        dev_dbg(&udev->dev, "config index %d changed (#%d)\n",
                                index, buf->bConfigurationValue);
-/* FIXME enable this when we can re-enumerate after reset;
- * until then DFU-ish drivers need this and other workarounds
- */
-//                     break;
+                       break;
                }
        }
        kfree(buf);
        return index != udev->descriptor.bNumConfigurations;
 }
 
-/*
+/**
+ * usb_reset_device - perform a USB port reset to reinitialize a device
+ * @udev: device to reset (not in SUSPENDED or NOTATTACHED state)
+ *
  * WARNING - don't reset any device unless drivers for all of its
  * interfaces are expecting that reset!  Maybe some driver->reset()
  * method should eventually help ensure sufficient cooperation.
  *
- * This is the same as usb_reset_device() except that the caller
- * already holds dev->serialize.  For example, it's safe to use
+ * Do a port reset, reassign the device's address, and establish its
+ * former operating configuration.  If the reset fails, or the device's
+ * descriptors change from their values before the reset, or the original
+ * configuration and altsettings cannot be restored, a flag will be set
+ * telling khubd to pretend the device has been disconnected and then
+ * re-connected.  All drivers will be unbound, and the device will be
+ * re-enumerated and probed all over again.
+ *
+ * Returns 0 if the reset succeeded, -ENODEV if the device has been
+ * flagged for logical disconnection, or some other negative error code
+ * if the reset wasn't even attempted.
+ *
+ * The caller must own the device lock.  For example, it's safe to use
  * this from a driver probe() routine after downloading new firmware.
+ * For calls that might not occur during probe(), drivers should lock
+ * the device using usb_lock_device_for_reset().
  */
-int __usb_reset_device(struct usb_device *udev)
+int usb_reset_device(struct usb_device *udev)
 {
-       struct usb_device *parent = udev->parent;
-       struct usb_device_descriptor descriptor = udev->descriptor;
-       int i, ret, port = -1;
-
-       if (udev->maxchild) {
-               /* this requires hub- or hcd-specific logic;
-                * see hub_reset() and OHCI hc_restart()
-                */
-               dev_dbg(&udev->dev, "%s for hub!\n", __FUNCTION__);
+       struct usb_device               *parent_hdev = udev->parent;
+       struct usb_hub                  *parent_hub;
+       struct usb_device_descriptor    descriptor = udev->descriptor;
+       struct usb_hub                  *hub = NULL;
+       int                             i, ret = 0, port1 = -1;
+
+       if (udev->state == USB_STATE_NOTATTACHED ||
+                       udev->state == USB_STATE_SUSPENDED) {
+               dev_dbg(&udev->dev, "device reset not allowed in state %d\n",
+                               udev->state);
                return -EINVAL;
        }
 
-       for (i = 0; i < parent->maxchild; i++)
-               if (parent->children[i] == udev) {
-                       port = i;
+       if (!parent_hdev) {
+               /* this requires hcd-specific logic; see OHCI hc_restart() */
+               dev_dbg(&udev->dev, "%s for root hub!\n", __FUNCTION__);
+               return -EISDIR;
+       }
+
+       for (i = 0; i < parent_hdev->maxchild; i++)
+               if (parent_hdev->children[i] == udev) {
+                       port1 = i + 1;
                        break;
                }
 
-       if (port < 0)
+       if (port1 < 0) {
+               /* If this ever happens, it's very bad */
+               dev_err(&udev->dev, "Can't locate device's port!\n");
                return -ENOENT;
+       }
+       parent_hub = hdev_to_hub(parent_hdev);
+
+       /* If we're resetting an active hub, take some special actions */
+       if (udev->actconfig &&
+                       udev->actconfig->interface[0]->dev.driver ==
+                               &hub_driver.driver &&
+                       (hub = hdev_to_hub(udev)) != NULL) {
+               hub_pre_reset(hub);
+       }
 
-       ret = hub_port_init(parent, udev, port);
+       for (i = 0; i < SET_CONFIG_TRIES; ++i) {
+
+               /* ep0 maxpacket size may change; let the HCD know about it.
+                * Other endpoints will be handled by re-enumeration. */
+               ep0_reinit(udev);
+               ret = hub_port_init(parent_hub, udev, port1, i);
+               if (ret >= 0)
+                       break;
+       }
        if (ret < 0)
                goto re_enumerate;
  
@@ -1714,7 +2947,7 @@ int __usb_reset_device(struct usb_device *udev)
        }
   
        if (!udev->actconfig)
-               return 0;
+               goto done;
 
        ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
                        USB_REQ_SET_CONFIGURATION, 0,
@@ -1726,13 +2959,13 @@ int __usb_reset_device(struct usb_device *udev)
                        udev->actconfig->desc.bConfigurationValue, ret);
                goto re_enumerate;
        }
-       udev->state = USB_STATE_CONFIGURED;
+       usb_set_device_state(udev, USB_STATE_CONFIGURED);
 
        for (i = 0; i < udev->actconfig->desc.bNumInterfaces; i++) {
                struct usb_interface *intf = udev->actconfig->interface[i];
                struct usb_interface_descriptor *desc;
 
-               /* set_interface resets host side toggle and halt status even
+               /* set_interface resets host side toggle even
                 * for altsetting zero.  the interface may have no driver.
                 */
                desc = &intf->cur_altsetting->desc;
@@ -1748,22 +2981,12 @@ int __usb_reset_device(struct usb_device *udev)
                }
        }
 
+done:
+       if (hub)
+               hub_post_reset(hub);
        return 0;
  
 re_enumerate:
-       /* FIXME make some task re-enumerate; don't just mark unusable */
-       udev->state = USB_STATE_NOTATTACHED;
+       hub_port_logical_disconnect(parent_hub, port1);
        return -ENODEV;
 }
-EXPORT_SYMBOL(__usb_reset_device);
-
-int usb_reset_device(struct usb_device *udev)
-{
-       int r;
-       
-       down(&udev->serialize);
-       r = __usb_reset_device(udev);
-       up(&udev->serialize);
-
-       return r;
-}