fedora core 6 1.2949 + vserver 2.2.0
[linux-2.6.git] / drivers / usb / host / ohci-hub.c
index 424971c..216c9c9 100644 (file)
@@ -1,9 +1,9 @@
 /*
  * OHCI HCD (Host Controller Driver) for USB.
- * 
+ *
  * (C) Copyright 1999 Roman Weissgaerber <weissg@vienna.at>
- * (C) Copyright 2000-2002 David Brownell <dbrownell@users.sourceforge.net>
- * 
+ * (C) Copyright 2000-2004 David Brownell <dbrownell@users.sourceforge.net>
+ *
  * This file is licenced under GPL
  */
 
 
 /*
  * OHCI Root Hub ... the nonsharable stuff
- *
- * Registers don't need cpu_to_le32, that happens transparently
  */
 
-/* AMD-756 (D2 rev) reports corrupt register contents in some cases.
- * The erratum (#4) description is incorrect.  AMD's workaround waits
- * till some bits (mostly reserved) are clear; ok for all revs.
- */
-#define read_roothub(hc, register, mask) ({ \
-       u32 temp = ohci_readl (&hc->regs->roothub.register); \
-       if (temp == -1) \
-               disable (hc); \
-       else if (hc->flags & OHCI_QUIRK_AMD756) \
-               while (temp & mask) \
-                       temp = ohci_readl (&hc->regs->roothub.register); \
-       temp; })
-
-static u32 roothub_a (struct ohci_hcd *hc)
-       { return read_roothub (hc, a, 0xfc0fe000); }
-static inline u32 roothub_b (struct ohci_hcd *hc)
-       { return ohci_readl (&hc->regs->roothub.b); }
-static inline u32 roothub_status (struct ohci_hcd *hc)
-       { return ohci_readl (&hc->regs->roothub.status); }
-static u32 roothub_portstatus (struct ohci_hcd *hc, int i)
-       { return read_roothub (hc, portstatus [i], 0xffe0fce0); }
-
-/*-------------------------------------------------------------------------*/
-
 #define dbg_port(hc,label,num,value) \
        ohci_dbg (hc, \
                "%s roothub.portstatus [%d] " \
@@ -49,109 +23,111 @@ static u32 roothub_portstatus (struct ohci_hcd *hc, int i)
                (temp & RH_PS_PSSC) ? " PSSC" : "", \
                (temp & RH_PS_PESC) ? " PESC" : "", \
                (temp & RH_PS_CSC) ? " CSC" : "", \
-               \
+               \
                (temp & RH_PS_LSDA) ? " LSDA" : "", \
                (temp & RH_PS_PPS) ? " PPS" : "", \
                (temp & RH_PS_PRS) ? " PRS" : "", \
                (temp & RH_PS_POCI) ? " POCI" : "", \
                (temp & RH_PS_PSS) ? " PSS" : "", \
-               \
+               \
                (temp & RH_PS_PES) ? " PES" : "", \
                (temp & RH_PS_CCS) ? " CCS" : "" \
                );
 
 /*-------------------------------------------------------------------------*/
 
-#if    defined(CONFIG_USB_SUSPEND) || defined(CONFIG_PM)
+/* hcd->hub_irq_enable() */
+static void ohci_rhsc_enable (struct usb_hcd *hcd)
+{
+       struct ohci_hcd         *ohci = hcd_to_ohci (hcd);
+
+       spin_lock_irq(&ohci->lock);
+       if (!ohci->autostop)
+               del_timer(&hcd->rh_timer);      /* Prevent next poll */
+       ohci_writel(ohci, OHCI_INTR_RHSC, &ohci->regs->intrenable);
+       spin_unlock_irq(&ohci->lock);
+}
 
 #define OHCI_SCHED_ENABLES \
        (OHCI_CTRL_CLE|OHCI_CTRL_BLE|OHCI_CTRL_PLE|OHCI_CTRL_IE)
 
-static void dl_done_list (struct ohci_hcd *, struct pt_regs *);
-static void finish_unlinks (struct ohci_hcd *, u16 , struct pt_regs *);
+static void dl_done_list (struct ohci_hcd *);
+static void finish_unlinks (struct ohci_hcd *, u16);
 
-static int ohci_hub_suspend (struct usb_hcd *hcd)
+#ifdef CONFIG_PM
+static int ohci_restart(struct ohci_hcd *ohci);
+
+static int ohci_rh_suspend (struct ohci_hcd *ohci, int autostop)
+__releases(ohci->lock)
+__acquires(ohci->lock)
 {
-       struct ohci_hcd         *ohci = hcd_to_ohci (hcd);
-       struct usb_device       *root = hcd_to_bus (&ohci->hcd)->root_hub;
        int                     status = 0;
 
-       if (root->dev.power.power_state != 0)
-               return 0;
-       if (time_before (jiffies, ohci->next_statechange))
-               return -EAGAIN;
-
-       spin_lock_irq (&ohci->lock);
-
-       ohci->hc_control = ohci_readl (&ohci->regs->control);
+       ohci->hc_control = ohci_readl (ohci, &ohci->regs->control);
        switch (ohci->hc_control & OHCI_CTRL_HCFS) {
        case OHCI_USB_RESUME:
                ohci_dbg (ohci, "resume/suspend?\n");
                ohci->hc_control &= ~OHCI_CTRL_HCFS;
                ohci->hc_control |= OHCI_USB_RESET;
-               writel (ohci->hc_control, &ohci->regs->control);
-               (void) ohci_readl (&ohci->regs->control);
+               ohci_writel (ohci, ohci->hc_control, &ohci->regs->control);
+               (void) ohci_readl (ohci, &ohci->regs->control);
                /* FALL THROUGH */
        case OHCI_USB_RESET:
                status = -EBUSY;
                ohci_dbg (ohci, "needs reinit!\n");
                goto done;
        case OHCI_USB_SUSPEND:
-               ohci_dbg (ohci, "already suspended?\n");
-               goto succeed;
+               if (!ohci->autostop) {
+                       ohci_dbg (ohci, "already suspended\n");
+                       goto done;
+               }
        }
-       ohci_dbg (ohci, "suspend root hub\n");
+       ohci_dbg (ohci, "%s root hub\n",
+                       autostop ? "auto-stop" : "suspend");
 
        /* First stop any processing */
-       ohci->hcd.state = USB_STATE_QUIESCING;
-       if (ohci->hc_control & OHCI_SCHED_ENABLES) {
-               int             limit;
-
+       if (!autostop && (ohci->hc_control & OHCI_SCHED_ENABLES)) {
                ohci->hc_control &= ~OHCI_SCHED_ENABLES;
-               writel (ohci->hc_control, &ohci->regs->control);
-               ohci->hc_control = ohci_readl (&ohci->regs->control);
-               writel (OHCI_INTR_SF, &ohci->regs->intrstatus);
+               ohci_writel (ohci, ohci->hc_control, &ohci->regs->control);
+               ohci->hc_control = ohci_readl (ohci, &ohci->regs->control);
+               ohci_writel (ohci, OHCI_INTR_SF, &ohci->regs->intrstatus);
 
                /* sched disables take effect on the next frame,
                 * then the last WDH could take 6+ msec
                 */
                ohci_dbg (ohci, "stopping schedules ...\n");
-               limit = 2000;
-               while (limit > 0) {
-                       udelay (250);
-                       limit =- 250;
-                       if (ohci_readl (&ohci->regs->intrstatus) & OHCI_INTR_SF)
-                               break;
-               }
-               dl_done_list (ohci, NULL);
-               mdelay (7);
+               ohci->autostop = 0;
+               spin_unlock_irq (&ohci->lock);
+               msleep (8);
+               spin_lock_irq (&ohci->lock);
        }
-       dl_done_list (ohci, NULL);
-       finish_unlinks (ohci, OHCI_FRAME_NO(ohci->hcca), NULL);
-       writel (ohci_readl (&ohci->regs->intrstatus), &ohci->regs->intrstatus);
+       dl_done_list (ohci);
+       finish_unlinks (ohci, ohci_frame_no(ohci));
 
        /* maybe resume can wake root hub */
-       if (ohci->hcd.remote_wakeup)
+       if (device_may_wakeup(&ohci_to_hcd(ohci)->self.root_hub->dev) ||
+                       autostop)
                ohci->hc_control |= OHCI_CTRL_RWE;
-       else
+       else {
+               ohci_writel (ohci, OHCI_INTR_RHSC, &ohci->regs->intrdisable);
                ohci->hc_control &= ~OHCI_CTRL_RWE;
+       }
 
-       /* Suspend hub */
+       /* Suspend hub ... this is the "global (to this bus) suspend" mode,
+        * which doesn't imply ports will first be individually suspended.
+        */
        ohci->hc_control &= ~OHCI_CTRL_HCFS;
        ohci->hc_control |= OHCI_USB_SUSPEND;
-       writel (ohci->hc_control, &ohci->regs->control);
-       (void) ohci_readl (&ohci->regs->control);
+       ohci_writel (ohci, ohci->hc_control, &ohci->regs->control);
+       (void) ohci_readl (ohci, &ohci->regs->control);
 
        /* no resumes until devices finish suspending */
-       ohci->next_statechange = jiffies + msecs_to_jiffies (5);
+       if (!autostop) {
+               ohci->next_statechange = jiffies + msecs_to_jiffies (5);
+               ohci->autostop = 0;
+       }
 
-succeed:
-       /* it's not USB_STATE_SUSPENDED unless access to this
-        * hub from the non-usb side (PCI, SOC, etc) stopped 
-        */
-       root->dev.power.power_state = 3;
 done:
-       spin_unlock_irq (&ohci->lock);
        return status;
 }
 
@@ -163,158 +139,270 @@ static inline struct ed *find_head (struct ed *ed)
        return ed;
 }
 
-static int hc_restart (struct ohci_hcd *ohci);
-
-/* caller owns root->serialize */
-static int ohci_hub_resume (struct usb_hcd *hcd)
+/* caller has locked the root hub */
+static int ohci_rh_resume (struct ohci_hcd *ohci)
+__releases(ohci->lock)
+__acquires(ohci->lock)
 {
-       struct ohci_hcd         *ohci = hcd_to_ohci (hcd);
-       struct usb_device       *root = hcd_to_bus (&ohci->hcd)->root_hub;
+       struct usb_hcd          *hcd = ohci_to_hcd (ohci);
        u32                     temp, enables;
        int                     status = -EINPROGRESS;
-
-       if (!root->dev.power.power_state)
-               return 0;
-       if (time_before (jiffies, ohci->next_statechange))
-               return -EAGAIN;
-
-       spin_lock_irq (&ohci->lock);
-       ohci->hc_control = ohci_readl (&ohci->regs->control);
-       switch (ohci->hc_control & OHCI_CTRL_HCFS) {
+       int                     autostopped = ohci->autostop;
+
+       ohci->autostop = 0;
+       ohci->hc_control = ohci_readl (ohci, &ohci->regs->control);
+
+       if (ohci->hc_control & (OHCI_CTRL_IR | OHCI_SCHED_ENABLES)) {
+               /* this can happen after resuming a swsusp snapshot */
+               if (hcd->state == HC_STATE_RESUMING) {
+                       ohci_dbg (ohci, "BIOS/SMM active, control %03x\n",
+                                       ohci->hc_control);
+                       status = -EBUSY;
+               /* this happens when pmcore resumes HC then root */
+               } else {
+                       ohci_dbg (ohci, "duplicate resume\n");
+                       status = 0;
+               }
+       } else switch (ohci->hc_control & OHCI_CTRL_HCFS) {
        case OHCI_USB_SUSPEND:
                ohci->hc_control &= ~(OHCI_CTRL_HCFS|OHCI_SCHED_ENABLES);
                ohci->hc_control |= OHCI_USB_RESUME;
-               writel (ohci->hc_control, &ohci->regs->control);
-               (void) ohci_readl (&ohci->regs->control);
-               ohci_dbg (ohci, "resume root hub\n");
+               ohci_writel (ohci, ohci->hc_control, &ohci->regs->control);
+               (void) ohci_readl (ohci, &ohci->regs->control);
+               ohci_dbg (ohci, "%s root hub\n",
+                               autostopped ? "auto-start" : "resume");
                break;
        case OHCI_USB_RESUME:
                /* HCFS changes sometime after INTR_RD */
-               ohci_info (ohci, "wakeup\n");
+               ohci_dbg(ohci, "%swakeup root hub\n",
+                               autostopped ? "auto-" : "");
                break;
        case OHCI_USB_OPER:
-               ohci_dbg (ohci, "odd resume\n");
-               root->dev.power.power_state = 0;
-               status = 0;
+               /* this can happen after resuming a swsusp snapshot */
+               ohci_dbg (ohci, "snapshot resume? reinit\n");
+               status = -EBUSY;
                break;
        default:                /* RESET, we lost power */
-               ohci_dbg (ohci, "root hub hardware reset\n");
+               ohci_dbg (ohci, "lost power\n");
                status = -EBUSY;
        }
-       spin_unlock_irq (&ohci->lock);
-       if (status == -EBUSY)
-               return hc_restart (ohci);
-       if (status != -EINPROGRESS)
+       if (status == -EBUSY) {
+               if (!autostopped) {
+                       spin_unlock_irq (&ohci->lock);
+                       (void) ohci_init (ohci);
+                       status = ohci_restart (ohci);
+                       spin_lock_irq (&ohci->lock);
+               }
                return status;
-
-       temp = roothub_a (ohci) & RH_A_NDP;
-       enables = 0;
-       while (temp--) {
-               u32 stat = ohci_readl (&ohci->regs->roothub.portstatus [temp]);
-
-               /* force global, not selective, resume */
-               if (!(stat & RH_PS_PSS))
-                       continue;
-               writel (RH_PS_POCI, &ohci->regs->roothub.portstatus [temp]);
        }
+       if (status != -EINPROGRESS)
+               return status;
+       if (autostopped)
+               goto skip_resume;
+       spin_unlock_irq (&ohci->lock);
 
-       /* Some controllers (lucent) need extra-long delays */
-       ohci->hcd.state = USB_STATE_RESUMING;
-       mdelay (20 /* usb 11.5.1.10 */ + 15);
+       /* Some controllers (lucent erratum) need extra-long delays */
+       msleep (20 /* usb 11.5.1.10 */ + 12 /* 32 msec counter */ + 1);
 
-       temp = ohci_readl (&ohci->regs->control);
+       temp = ohci_readl (ohci, &ohci->regs->control);
        temp &= OHCI_CTRL_HCFS;
        if (temp != OHCI_USB_RESUME) {
                ohci_err (ohci, "controller won't resume\n");
+               spin_lock_irq(&ohci->lock);
                return -EBUSY;
        }
 
        /* disable old schedule state, reinit from scratch */
-       writel (0, &ohci->regs->ed_controlhead);
-       writel (0, &ohci->regs->ed_controlcurrent);
-       writel (0, &ohci->regs->ed_bulkhead);
-       writel (0, &ohci->regs->ed_bulkcurrent);
-       writel (0, &ohci->regs->ed_periodcurrent);
-       writel ((u32) ohci->hcca_dma, &ohci->regs->hcca);
-
+       ohci_writel (ohci, 0, &ohci->regs->ed_controlhead);
+       ohci_writel (ohci, 0, &ohci->regs->ed_controlcurrent);
+       ohci_writel (ohci, 0, &ohci->regs->ed_bulkhead);
+       ohci_writel (ohci, 0, &ohci->regs->ed_bulkcurrent);
+       ohci_writel (ohci, 0, &ohci->regs->ed_periodcurrent);
+       ohci_writel (ohci, (u32) ohci->hcca_dma, &ohci->regs->hcca);
+
+       /* Sometimes PCI D3 suspend trashes frame timings ... */
        periodic_reinit (ohci);
 
+       /* the following code is executed with ohci->lock held and
+        * irqs disabled if and only if autostopped is true
+        */
+
+skip_resume:
        /* interrupts might have been disabled */
-       writel (OHCI_INTR_INIT, &ohci->regs->intrenable);
+       ohci_writel (ohci, OHCI_INTR_INIT, &ohci->regs->intrenable);
        if (ohci->ed_rm_list)
-               writel (OHCI_INTR_SF, &ohci->regs->intrenable);
-       writel (ohci_readl (&ohci->regs->intrstatus), &ohci->regs->intrstatus);
+               ohci_writel (ohci, OHCI_INTR_SF, &ohci->regs->intrenable);
 
        /* Then re-enable operations */
-       writel (OHCI_USB_OPER, &ohci->regs->control);
-       (void) ohci_readl (&ohci->regs->control);
-       msleep (3);
-
-       temp = OHCI_CONTROL_INIT | OHCI_USB_OPER;
-       if (ohci->hcd.can_wakeup)
-               temp |= OHCI_CTRL_RWC;
+       ohci_writel (ohci, OHCI_USB_OPER, &ohci->regs->control);
+       (void) ohci_readl (ohci, &ohci->regs->control);
+       if (!autostopped)
+               msleep (3);
+
+       temp = ohci->hc_control;
+       temp &= OHCI_CTRL_RWC;
+       temp |= OHCI_CONTROL_INIT | OHCI_USB_OPER;
        ohci->hc_control = temp;
-       writel (temp, &ohci->regs->control);
-       (void) ohci_readl (&ohci->regs->control);
+       ohci_writel (ohci, temp, &ohci->regs->control);
+       (void) ohci_readl (ohci, &ohci->regs->control);
 
        /* TRSMRCY */
-       msleep (10);
-       root->dev.power.power_state = 0;
+       if (!autostopped) {
+               msleep (10);
+               spin_lock_irq (&ohci->lock);
+       }
+       /* now ohci->lock is always held and irqs are always disabled */
 
-       /* keep it alive for ~5x suspend + resume costs */
-       ohci->next_statechange = jiffies + msecs_to_jiffies (250);
+       /* keep it alive for more than ~5x suspend + resume costs */
+       ohci->next_statechange = jiffies + STATECHANGE_DELAY;
 
        /* maybe turn schedules back on */
        enables = 0;
        temp = 0;
        if (!ohci->ed_rm_list) {
                if (ohci->ed_controltail) {
-                       writel (find_head (ohci->ed_controltail)->dma,
-                               &ohci->regs->ed_controlhead);
+                       ohci_writel (ohci,
+                                       find_head (ohci->ed_controltail)->dma,
+                                       &ohci->regs->ed_controlhead);
                        enables |= OHCI_CTRL_CLE;
                        temp |= OHCI_CLF;
                }
                if (ohci->ed_bulktail) {
-                       writel (find_head (ohci->ed_bulktail)->dma,
+                       ohci_writel (ohci, find_head (ohci->ed_bulktail)->dma,
                                &ohci->regs->ed_bulkhead);
                        enables |= OHCI_CTRL_BLE;
                        temp |= OHCI_BLF;
                }
        }
-       if (hcd_to_bus (&ohci->hcd)->bandwidth_isoc_reqs
-                       || hcd_to_bus (&ohci->hcd)->bandwidth_int_reqs)
+       if (hcd->self.bandwidth_isoc_reqs || hcd->self.bandwidth_int_reqs)
                enables |= OHCI_CTRL_PLE|OHCI_CTRL_IE;
        if (enables) {
                ohci_dbg (ohci, "restarting schedules ... %08x\n", enables);
                ohci->hc_control |= enables;
-               writel (ohci->hc_control, &ohci->regs->control);
+               ohci_writel (ohci, ohci->hc_control, &ohci->regs->control);
                if (temp)
-                       writel (status, &ohci->regs->cmdstatus);
-               (void) ohci_readl (&ohci->regs->control);
+                       ohci_writel (ohci, temp, &ohci->regs->cmdstatus);
+               (void) ohci_readl (ohci, &ohci->regs->control);
        }
 
-       ohci->hcd.state = USB_STATE_RUNNING;
        return 0;
 }
 
-static void ohci_rh_resume (void *_hcd)
+static int ohci_bus_suspend (struct usb_hcd *hcd)
+{
+       struct ohci_hcd         *ohci = hcd_to_ohci (hcd);
+       int                     rc;
+
+       spin_lock_irq (&ohci->lock);
+
+       if (unlikely(!test_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags)))
+               rc = -ESHUTDOWN;
+       else
+               rc = ohci_rh_suspend (ohci, 0);
+       spin_unlock_irq (&ohci->lock);
+       return rc;
+}
+
+static int ohci_bus_resume (struct usb_hcd *hcd)
 {
-       struct usb_hcd  *hcd = _hcd;
+       struct ohci_hcd         *ohci = hcd_to_ohci (hcd);
+       int                     rc;
+
+       if (time_before (jiffies, ohci->next_statechange))
+               msleep(5);
+
+       spin_lock_irq (&ohci->lock);
+
+       if (unlikely(!test_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags)))
+               rc = -ESHUTDOWN;
+       else
+               rc = ohci_rh_resume (ohci);
+       spin_unlock_irq (&ohci->lock);
 
-       down (&hcd->self.root_hub->serialize);
-       (void) ohci_hub_resume (hcd);
-       up (&hcd->self.root_hub->serialize);
+       /* poll until we know a device is connected or we autostop */
+       if (rc == 0)
+               usb_hcd_poll_rh_status(hcd);
+       return rc;
 }
 
-#else
+/* Carry out polling-, autostop-, and autoresume-related state changes */
+static int ohci_root_hub_state_changes(struct ohci_hcd *ohci, int changed,
+               int any_connected)
+{
+       int     poll_rh = 1;
+
+       switch (ohci->hc_control & OHCI_CTRL_HCFS) {
 
-static void ohci_rh_resume (void *_hcd)
+       case OHCI_USB_OPER:
+               /* keep on polling until we know a device is connected
+                * and RHSC is enabled */
+               if (!ohci->autostop) {
+                       if (any_connected ||
+                                       !device_may_wakeup(&ohci_to_hcd(ohci)
+                                               ->self.root_hub->dev)) {
+                               if (ohci_readl(ohci, &ohci->regs->intrenable) &
+                                               OHCI_INTR_RHSC)
+                                       poll_rh = 0;
+                       } else {
+                               ohci->autostop = 1;
+                               ohci->next_statechange = jiffies + HZ;
+                       }
+
+               /* if no devices have been attached for one second, autostop */
+               } else {
+                       if (changed || any_connected) {
+                               ohci->autostop = 0;
+                               ohci->next_statechange = jiffies +
+                                               STATECHANGE_DELAY;
+                       } else if (time_after_eq(jiffies,
+                                               ohci->next_statechange)
+                                       && !ohci->ed_rm_list
+                                       && !(ohci->hc_control &
+                                               OHCI_SCHED_ENABLES)) {
+                               ohci_rh_suspend(ohci, 1);
+                       }
+               }
+               break;
+
+       /* if there is a port change, autostart or ask to be resumed */
+       case OHCI_USB_SUSPEND:
+       case OHCI_USB_RESUME:
+               if (changed) {
+                       if (ohci->autostop)
+                               ohci_rh_resume(ohci);
+                       else
+                               usb_hcd_resume_root_hub(ohci_to_hcd(ohci));
+               } else {
+                       /* everything is idle, no need for polling */
+                       poll_rh = 0;
+               }
+               break;
+       }
+       return poll_rh;
+}
+
+#else  /* CONFIG_PM */
+
+static inline int ohci_rh_resume(struct ohci_hcd *ohci)
 {
-       struct ohci_hcd *ohci = hcd_to_ohci (_hcd);
-       ohci_dbg(ohci, "rh_resume ??\n");
+       return 0;
 }
 
-#endif /* CONFIG_USB_SUSPEND || CONFIG_PM */
+/* Carry out polling-related state changes.
+ * autostop isn't used when CONFIG_PM is turned off.
+ */
+static int ohci_root_hub_state_changes(struct ohci_hcd *ohci, int changed,
+               int any_connected)
+{
+       int     poll_rh = 1;
+
+       /* keep on polling until RHSC is enabled */
+       if (ohci_readl(ohci, &ohci->regs->intrenable) & OHCI_INTR_RHSC)
+               poll_rh = 0;
+       return poll_rh;
+}
+
+#endif /* CONFIG_PM */
 
 /*-------------------------------------------------------------------------*/
 
@@ -324,17 +412,19 @@ static int
 ohci_hub_status_data (struct usb_hcd *hcd, char *buf)
 {
        struct ohci_hcd *ohci = hcd_to_ohci (hcd);
-       int             ports, i, changed = 0, length = 1;
-       int             can_suspend = 1;
-
-       ports = roothub_a (ohci) & RH_A_NDP; 
-       if (ports > MAX_ROOT_PORTS) {
-               if (!HCD_IS_RUNNING(ohci->hcd.state))
-                       return -ESHUTDOWN;
-               ohci_err (ohci, "bogus NDP=%d, rereads as NDP=%d\n",
-                       ports, ohci_readl (&ohci->regs->roothub.a) & RH_A_NDP);
+       int             i, changed = 0, length = 1;
+       int             any_connected = 0;
+       unsigned long   flags;
+
+       spin_lock_irqsave (&ohci->lock, flags);
+
+       /* undocumented erratum seen on at least rev D */
+       if ((ohci->flags & OHCI_QUIRK_AMD756)
+                       && (roothub_a (ohci) & RH_A_NDP) > MAX_ROOT_PORTS) {
+               ohci_warn (ohci, "bogus NDP, rereads as NDP=%d\n",
+                         ohci_readl (ohci, &ohci->regs->roothub.a) & RH_A_NDP);
                /* retry later; "should not happen" */
-               return 0;
+               goto done;
        }
 
        /* init status */
@@ -342,15 +432,18 @@ ohci_hub_status_data (struct usb_hcd *hcd, char *buf)
                buf [0] = changed = 1;
        else
                buf [0] = 0;
-       if (ports > 7) {
+       if (ohci->num_ports > 7) {
                buf [1] = 0;
                length++;
        }
 
        /* look at each port */
-       for (i = 0; i < ports; i++) {
+       for (i = 0; i < ohci->num_ports; i++) {
                u32     status = roothub_portstatus (ohci, i);
 
+               /* can't autostop if ports are connected */
+               any_connected |= (status & RH_PS_CCS);
+
                if (status & (RH_PS_CSC | RH_PS_PESC | RH_PS_PSSC
                                | RH_PS_OCIC | RH_PS_PRSC)) {
                        changed = 1;
@@ -358,37 +451,14 @@ ohci_hub_status_data (struct usb_hcd *hcd, char *buf)
                            buf [0] |= 1 << (i + 1);
                        else
                            buf [1] |= 1 << (i - 7);
-                       continue;
                }
-
-               /* can suspend if no ports are enabled; or if all all
-                * enabled ports are suspended AND remote wakeup is on.
-                */
-               if (!(status & RH_PS_CCS))
-                       continue;
-               if ((status & RH_PS_PSS) && ohci->hcd.remote_wakeup)
-                       continue;
-               can_suspend = 0;
        }
 
-#ifdef CONFIG_PM
-       /* save power by suspending idle root hubs;
-        * INTR_RD wakes us when there's work
-        */
-       if (can_suspend
-                       && !changed
-                       && !ohci->ed_rm_list
-                       && ((OHCI_CTRL_HCFS | OHCI_SCHED_ENABLES)
-                                       & ohci->hc_control)
-                               == OHCI_USB_OPER
-                       && down_trylock (&hcd->self.root_hub->serialize) == 0
-                       ) {
-               ohci_vdbg (ohci, "autosuspend\n");
-               (void) ohci_hub_suspend (&ohci->hcd);
-               ohci->hcd.state = USB_STATE_RUNNING;
-               up (&hcd->self.root_hub->serialize);
-       }
-#endif
+       hcd->poll_rh = ohci_root_hub_state_changes(ohci, changed,
+                       any_connected);
+
+done:
+       spin_unlock_irqrestore (&ohci->lock, flags);
 
        return changed ? length : 0;
 }
@@ -401,34 +471,34 @@ ohci_hub_descriptor (
        struct usb_hub_descriptor       *desc
 ) {
        u32             rh = roothub_a (ohci);
-       int             ports = rh & RH_A_NDP; 
        u16             temp;
 
        desc->bDescriptorType = 0x29;
        desc->bPwrOn2PwrGood = (rh & RH_A_POTPGT) >> 24;
        desc->bHubContrCurrent = 0;
 
-       desc->bNbrPorts = ports;
-       temp = 1 + (ports / 8);
+       desc->bNbrPorts = ohci->num_ports;
+       temp = 1 + (ohci->num_ports / 8);
        desc->bDescLength = 7 + 2 * temp;
 
        temp = 0;
        if (rh & RH_A_NPS)              /* no power switching? */
            temp |= 0x0002;
-       if (rh & RH_A_PSM)              /* per-port power switching? */
+       if (rh & RH_A_PSM)              /* per-port power switching? */
            temp |= 0x0001;
        if (rh & RH_A_NOCP)             /* no overcurrent reporting? */
            temp |= 0x0010;
        else if (rh & RH_A_OCPM)        /* per-port overcurrent reporting? */
            temp |= 0x0008;
-       desc->wHubCharacteristics = cpu_to_le16 (temp);
+       desc->wHubCharacteristics = (__force __u16)cpu_to_hc16(ohci, temp);
 
        /* two bitmaps:  ports removable, and usb 1.0 legacy PortPwrCtrlMask */
        rh = roothub_b (ohci);
+       memset(desc->bitmap, 0xff, sizeof(desc->bitmap));
        desc->bitmap [0] = rh & RH_B_DR;
-       if (ports > 7) {
+       if (ohci->num_ports > 7) {
                desc->bitmap [1] = (rh & RH_B_DR) >> 8;
-               desc->bitmap [2] = desc->bitmap [3] = 0xff;
+               desc->bitmap [2] = 0xff;
        } else
                desc->bitmap [1] = 0xff;
 }
@@ -447,12 +517,12 @@ static int ohci_start_port_reset (struct usb_hcd *hcd, unsigned port)
        port--;
 
        /* start port reset before HNP protocol times out */
-       status = ohci_readl(&ohci->regs->roothub.portstatus [port]);
+       status = ohci_readl(ohci, &ohci->regs->roothub.portstatus [port]);
        if (!(status & RH_PS_CCS))
                return -ENODEV;
 
        /* khubd will finish the reset later */
-       writel(RH_PS_PRS, &ohci->regs->roothub.portstatus [port]);
+       ohci_writel(ohci, RH_PS_PRS, &ohci->regs->roothub.portstatus [port]);
        return 0;
 }
 
@@ -481,15 +551,15 @@ static void start_hnp(struct ohci_hcd *ohci);
 /* this timer value might be vendor-specific ... */
 #define        PORT_RESET_HW_MSEC      10
 
-/* wrap-aware logic stolen from <linux/jiffies.h> */
-#define tick_before(t1,t2) ((((s16)(t1))-((s16)(t2))) < 0)
+/* wrap-aware logic morphed from <linux/jiffies.h> */
+#define tick_before(t1,t2) ((s16)(((s16)(t1))-((s16)(t2))) < 0)
 
 /* called from some task, normally khubd */
-static inline void root_port_reset (struct ohci_hcd *ohci, unsigned port)
+static inline int root_port_reset (struct ohci_hcd *ohci, unsigned port)
 {
-       u32 __iomem *portstat = &ohci->regs->roothub.portstatus [port];
+       __hc32 __iomem *portstat = &ohci->regs->roothub.portstatus [port];
        u32     temp;
-       u16     now = readl(&ohci->regs->fmnumber);
+       u16     now = ohci_readl(ohci, &ohci->regs->fmnumber);
        u16     reset_done = now + PORT_RESET_MSEC;
 
        /* build a "continuous enough" reset signal, with up to
@@ -499,23 +569,28 @@ static inline void root_port_reset (struct ohci_hcd *ohci, unsigned port)
        do {
                /* spin until any current reset finishes */
                for (;;) {
-                       temp = ohci_readl (portstat);
+                       temp = ohci_readl (ohci, portstat);
+                       /* handle e.g. CardBus eject */
+                       if (temp == ~(u32)0)
+                               return -ESHUTDOWN;
                        if (!(temp & RH_PS_PRS))
                                break;
                        udelay (500);
-               } 
+               }
 
                if (!(temp & RH_PS_CCS))
                        break;
                if (temp & RH_PS_PRSC)
-                       writel (RH_PS_PRSC, portstat);
+                       ohci_writel (ohci, RH_PS_PRSC, portstat);
 
                /* start the next reset, sleep till it's probably done */
-               writel (RH_PS_PRS, portstat);
+               ohci_writel (ohci, RH_PS_PRS, portstat);
                msleep(PORT_RESET_HW_MSEC);
-               now = readl(&ohci->regs->fmnumber);
+               now = ohci_readl(ohci, &ohci->regs->fmnumber);
        } while (tick_before(now, reset_done));
        /* caller synchronizes using PRSC */
+
+       return 0;
 }
 
 static int ohci_hub_control (
@@ -531,11 +606,15 @@ static int ohci_hub_control (
        u32             temp;
        int             retval = 0;
 
+       if (unlikely(!test_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags)))
+               return -ESHUTDOWN;
+
        switch (typeReq) {
        case ClearHubFeature:
                switch (wValue) {
                case C_HUB_OVER_CURRENT:
-                       writel (RH_HS_OCIC, &ohci->regs->roothub.status);
+                       ohci_writel (ohci, RH_HS_OCIC,
+                                       &ohci->regs->roothub.status);
                case C_HUB_LOCAL_POWER:
                        break;
                default:
@@ -556,9 +635,6 @@ static int ohci_hub_control (
                        break;
                case USB_PORT_FEAT_SUSPEND:
                        temp = RH_PS_POCI;
-                       if ((ohci->hc_control & OHCI_CTRL_HCFS)
-                                       != OHCI_USB_OPER)
-                               schedule_work (&ohci->rh_resume);
                        break;
                case USB_PORT_FEAT_C_SUSPEND:
                        temp = RH_PS_PSSC;
@@ -578,22 +654,23 @@ static int ohci_hub_control (
                default:
                        goto error;
                }
-               writel (temp, &ohci->regs->roothub.portstatus [wIndex]);
-               // ohci_readl (&ohci->regs->roothub.portstatus [wIndex]);
+               ohci_writel (ohci, temp,
+                               &ohci->regs->roothub.portstatus [wIndex]);
+               // ohci_readl (ohci, &ohci->regs->roothub.portstatus [wIndex]);
                break;
        case GetHubDescriptor:
                ohci_hub_descriptor (ohci, (struct usb_hub_descriptor *) buf);
                break;
        case GetHubStatus:
                temp = roothub_status (ohci) & ~(RH_HS_CRWE | RH_HS_DRWE);
-               *(__le32 *) buf = cpu_to_le32 (temp);
+               put_unaligned(cpu_to_le32 (temp), (__le32 *) buf);
                break;
        case GetPortStatus:
                if (!wIndex || wIndex > ports)
                        goto error;
                wIndex--;
                temp = roothub_portstatus (ohci, wIndex);
-               *(__le32 *) buf = cpu_to_le32 (temp);
+               put_unaligned(cpu_to_le32 (temp), (__le32 *) buf);
 
 #ifndef        OHCI_VERBOSE_DEBUG
        if (*(u16*)(buf+2))     /* only if wPortChange is interesting */
@@ -617,20 +694,20 @@ static int ohci_hub_control (
                switch (wValue) {
                case USB_PORT_FEAT_SUSPEND:
 #ifdef CONFIG_USB_OTG
-                       if (ohci->hcd.self.otg_port == (wIndex + 1)
-                                       && ohci->hcd.self.b_hnp_enable)
+                       if (hcd->self.otg_port == (wIndex + 1)
+                                       && hcd->self.b_hnp_enable)
                                start_hnp(ohci);
                        else
 #endif
-                       writel (RH_PS_PSS,
+                       ohci_writel (ohci, RH_PS_PSS,
                                &ohci->regs->roothub.portstatus [wIndex]);
                        break;
                case USB_PORT_FEAT_POWER:
-                       writel (RH_PS_PPS,
+                       ohci_writel (ohci, RH_PS_PPS,
                                &ohci->regs->roothub.portstatus [wIndex]);
                        break;
                case USB_PORT_FEAT_RESET:
-                       root_port_reset (ohci, wIndex);
+                       retval = root_port_reset (ohci, wIndex);
                        break;
                default:
                        goto error;