This commit was manufactured by cvs2svn to create tag
[linux-2.6.git] / drivers / usb / media / sn9c102_tas5130d1b.c
index 36b00d1..0bab194 100644 (file)
@@ -1,6 +1,6 @@
 /***************************************************************************
- * Plug-in for TAS5130D1B image sensor connected to the SN9C10x PC Camera  *
- * Controllers                                                             *
+ * Driver for TAS5130D1B image sensor connected to the SN9C10[12] PC       *
+ * Camera Controllers                                                      *
  *                                                                         *
  * Copyright (C) 2004 by Luca Risolia <luca.risolia@studio.unibo.it>       *
  *                                                                         *
@@ -24,8 +24,6 @@
 
 static struct sn9c102_sensor tas5130d1b;
 
-static struct v4l2_control tas5130d1b_gain, tas5130d1b_exposure;
-
 
 static int tas5130d1b_init(struct sn9c102_device* cam)
 {
@@ -40,47 +38,25 @@ static int tas5130d1b_init(struct sn9c102_device* cam)
        err += sn9c102_write_reg(cam, 0x60, 0x17);
        err += sn9c102_write_reg(cam, 0x07, 0x18);
 
-       return err;
-}
-
-
-static int tas5130d1b_get_ctrl(struct sn9c102_device* cam, 
-                               struct v4l2_control* ctrl)
-{
-       switch (ctrl->id) {
-       case V4L2_CID_GAIN:
-               ctrl->value = tas5130d1b_gain.value;
-               break;
-       case V4L2_CID_EXPOSURE:
-               ctrl->value = tas5130d1b_exposure.value;
-               break;
-       default:
-               return -EINVAL;
-       }
+       err += sn9c102_i2c_try_raw_write(cam, &tas5130d1b, 4, 0x11, 0x00, 0x40,
+                                        0x47, 0, 0);
 
-       return 0;
+       return err;
 }
 
 
 static int tas5130d1b_set_ctrl(struct sn9c102_device* cam, 
                                const struct v4l2_control* ctrl)
 {
-       int err = 0;
-
        switch (ctrl->id) {
        case V4L2_CID_GAIN:
-               if (!(err += sn9c102_i2c_write(cam, 0x20, 0xf6 - ctrl->value)))
-                       tas5130d1b_gain.value = ctrl->value;
-               break;
-       case V4L2_CID_EXPOSURE:
-               if (!(err += sn9c102_i2c_write(cam, 0x40, 0x47 - ctrl->value)))
-                       tas5130d1b_exposure.value = ctrl->value;
-               break;
+               return sn9c102_i2c_try_raw_write(cam, &tas5130d1b, 4, 0x11,
+                                                0x02, 0x20,
+                                                0xff - (ctrl->value & 0xff),
+                                                0, 0);
        default:
                return -EINVAL;
        }
-
-       return err ? -EIO : 0;
 }
 
 
@@ -96,8 +72,8 @@ static int tas5130d1b_set_crop(struct sn9c102_device* cam,
        err += sn9c102_write_reg(cam, v_start, 0x13);
 
        /* Do NOT change! */
-       err += sn9c102_write_reg(cam, 0x1f, 0x1a);
-       err += sn9c102_write_reg(cam, 0x1a, 0x1b);
+       err += sn9c102_write_reg(cam, 0x1d, 0x1a);
+       err += sn9c102_write_reg(cam, 0x10, 0x1b);
        err += sn9c102_write_reg(cam, 0xf3, 0x19);
 
        return err;
@@ -109,8 +85,6 @@ static struct sn9c102_sensor tas5130d1b = {
        .maintainer = "Luca Risolia <luca.risolia@studio.unibo.it>",
        .frequency = SN9C102_I2C_100KHZ,
        .interface = SN9C102_I2C_3WIRES,
-       .slave_read_id = SN9C102_I2C_SLAVEID_UNAVAILABLE,
-       .slave_write_id = SN9C102_I2C_SLAVEID_FICTITIOUS,
        .init = &tas5130d1b_init,
        .qctrl = {
                {
@@ -118,23 +92,12 @@ static struct sn9c102_sensor tas5130d1b = {
                        .type = V4L2_CTRL_TYPE_INTEGER,
                        .name = "global gain",
                        .minimum = 0x00,
-                       .maximum = 0xf6,
-                       .step = 0x02,
-                       .default_value = 0x00,
-                       .flags = 0,
-               },
-               {
-                       .id = V4L2_CID_EXPOSURE,
-                       .type = V4L2_CTRL_TYPE_INTEGER,
-                       .name = "exposure",
-                       .minimum = 0x00,
-                       .maximum = 0x47,
+                       .maximum = 0xff,
                        .step = 0x01,
                        .default_value = 0x00,
                        .flags = 0,
                },
        },
-       .get_ctrl = &tas5130d1b_get_ctrl,
        .set_ctrl = &tas5130d1b_set_ctrl,
        .cropcap = {
                .bounds = {
@@ -165,9 +128,8 @@ int sn9c102_probe_tas5130d1b(struct sn9c102_device* cam)
        /* This sensor has no identifiers, so let's attach it anyway */
        sn9c102_attach_sensor(cam, &tas5130d1b);
 
-       /* Sensor detection is based on USB pid/vid */
-       if (tas5130d1b.usbdev->descriptor.idProduct != 0x6025 &&
-           tas5130d1b.usbdev->descriptor.idProduct != 0x60aa)
+       /* At the moment, sensor detection is based on USB pid/vid */
+       if (tas5130d1b.usbdev->descriptor.idProduct != 0x6025)
                return -ENODEV;
 
        return 0;