This commit was manufactured by cvs2svn to create tag
[linux-2.6.git] / fs / exec.c
index 95ae49b..3d1f71b 100644 (file)
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -34,7 +34,6 @@
 #include <linux/pagemap.h>
 #include <linux/highmem.h>
 #include <linux/spinlock.h>
-#include <linux/key.h>
 #include <linux/personality.h>
 #include <linux/binfmts.h>
 #include <linux/swap.h>
@@ -47,9 +46,9 @@
 #include <linux/security.h>
 #include <linux/syscalls.h>
 #include <linux/rmap.h>
-#include <linux/ckrm_events.h>
-#include <linux/ckrm_mem_inline.h>
+#include <linux/ckrm.h>
 #include <linux/vs_memory.h>
+#include <linux/ckrm_mem.h>
 
 #include <asm/uaccess.h>
 #include <asm/mmu_context.h>
@@ -63,6 +62,7 @@ char core_pattern[65] = "core";
 int suid_dumpable = 0;
 
 EXPORT_SYMBOL(suid_dumpable);
+
 /* The maximal length of core_pattern is also specified in sysctl.c */
 
 static struct linux_binfmt *formats;
@@ -344,8 +344,6 @@ out_sig:
        force_sig(SIGKILL, current);
 }
 
-#define EXTRA_STACK_VM_PAGES   20      /* random */
-
 int setup_arg_pages(struct linux_binprm *bprm, int executable_stack)
 {
        unsigned long stack_base;
@@ -383,15 +381,15 @@ int setup_arg_pages(struct linux_binprm *bprm, int executable_stack)
        memmove(to, to + offset, PAGE_SIZE - offset);
        kunmap(bprm->page[j - 1]);
 
+       /* Adjust bprm->p to point to the end of the strings. */
+       bprm->p = PAGE_SIZE * i - offset;
+
        /* Limit stack size to 1GB */
-       stack_base = current->signal->rlim[RLIMIT_STACK].rlim_max;
+       stack_base = current->rlim[RLIMIT_STACK].rlim_max;
        if (stack_base > (1 << 30))
                stack_base = 1 << 30;
        stack_base = PAGE_ALIGN(STACK_TOP - stack_base);
 
-       /* Adjust bprm->p to point to the end of the strings. */
-       bprm->p = stack_base + PAGE_SIZE * i - offset;
-
        mm->arg_start = stack_base;
        arg_size = i << PAGE_SHIFT;
 
@@ -405,13 +403,11 @@ int setup_arg_pages(struct linux_binprm *bprm, int executable_stack)
 #else
        stack_base = STACK_TOP - MAX_ARG_PAGES * PAGE_SIZE;
 #endif
-       bprm->p += stack_base;
-       mm->arg_start = bprm->p;
+       mm->arg_start = bprm->p + stack_base;
        arg_size = STACK_TOP - (PAGE_MASK & (unsigned long) mm->arg_start);
 #endif
 
-       arg_size += EXTRA_STACK_VM_PAGES * PAGE_SIZE;
-
+       bprm->p += stack_base;
        if (bprm->loader)
                bprm->loader += stack_base;
        bprm->exec += stack_base;
@@ -433,10 +429,11 @@ int setup_arg_pages(struct linux_binprm *bprm, int executable_stack)
                mpnt->vm_mm = mm;
 #ifdef CONFIG_STACK_GROWSUP
                mpnt->vm_start = stack_base;
-               mpnt->vm_end = stack_base + arg_size;
+               mpnt->vm_end = PAGE_MASK &
+                       (PAGE_SIZE - 1 + (unsigned long) bprm->p);
 #else
+               mpnt->vm_start = PAGE_MASK & (unsigned long) bprm->p;
                mpnt->vm_end = STACK_TOP;
-               mpnt->vm_start = mpnt->vm_end - arg_size;
 #endif
                /* Adjust stack execute permissions; explicitly enable
                 * for EXSTACK_ENABLE_X, disable for EXSTACK_DISABLE_X
@@ -552,6 +549,12 @@ static int exec_mmap(struct mm_struct *mm)
        struct task_struct *tsk;
        struct mm_struct * old_mm, *active_mm;
 
+       /* Add it to the list of mm's */
+       spin_lock(&mmlist_lock);
+       list_add(&mm->mmlist, &init_mm.mmlist);
+       mmlist_nr++;
+       spin_unlock(&mmlist_lock);
+
        /* Notify parent that we're no longer interested in the old VM */
        tsk = current;
        old_mm = current->mm;
@@ -564,7 +567,18 @@ static int exec_mmap(struct mm_struct *mm)
        activate_mm(active_mm, mm);
        task_unlock(tsk);
        arch_pick_mmap_layout(mm);
-       ckrm_task_change_mm(tsk, old_mm, mm);
+#ifdef CONFIG_CKRM_RES_MEM
+       if (old_mm) {
+               spin_lock(&old_mm->peertask_lock);
+               list_del(&tsk->mm_peers);
+               ckrm_mem_evaluate_mm(old_mm);
+               spin_unlock(&old_mm->peertask_lock);
+       }
+       spin_lock(&mm->peertask_lock);
+       list_add_tail(&tsk->mm_peers, &mm->tasklist);
+       ckrm_mem_evaluate_mm(mm);
+       spin_unlock(&mm->peertask_lock);
+#endif
        if (old_mm) {
                if (active_mm != old_mm) BUG();
                mmput(old_mm);
@@ -582,7 +596,7 @@ static int exec_mmap(struct mm_struct *mm)
  */
 static inline int de_thread(struct task_struct *tsk)
 {
-       struct signal_struct *sig = tsk->signal;
+       struct signal_struct *newsig, *oldsig = tsk->signal;
        struct sighand_struct *newsighand, *oldsighand = tsk->sighand;
        spinlock_t *lock = &oldsighand->siglock;
        int count;
@@ -591,16 +605,43 @@ static inline int de_thread(struct task_struct *tsk)
         * If we don't share sighandlers, then we aren't sharing anything
         * and we can just re-use it all.
         */
-       if (atomic_read(&oldsighand->count) <= 1) {
-               BUG_ON(atomic_read(&sig->count) != 1);
-               exit_itimers(sig);
+       if (atomic_read(&oldsighand->count) <= 1)
                return 0;
-       }
 
        newsighand = kmem_cache_alloc(sighand_cachep, GFP_KERNEL);
        if (!newsighand)
                return -ENOMEM;
 
+       spin_lock_init(&newsighand->siglock);
+       atomic_set(&newsighand->count, 1);
+       memcpy(newsighand->action, oldsighand->action, sizeof(newsighand->action));
+
+       /*
+        * See if we need to allocate a new signal structure
+        */
+       newsig = NULL;
+       if (atomic_read(&oldsig->count) > 1) {
+               newsig = kmem_cache_alloc(signal_cachep, GFP_KERNEL);
+               if (!newsig) {
+                       kmem_cache_free(sighand_cachep, newsighand);
+                       return -ENOMEM;
+               }
+               atomic_set(&newsig->count, 1);
+               newsig->group_exit = 0;
+               newsig->group_exit_code = 0;
+               newsig->group_exit_task = NULL;
+               newsig->group_stop_count = 0;
+               newsig->curr_target = NULL;
+               init_sigpending(&newsig->shared_pending);
+               INIT_LIST_HEAD(&newsig->posix_timers);
+
+               newsig->tty = oldsig->tty;
+               newsig->pgrp = oldsig->pgrp;
+               newsig->session = oldsig->session;
+               newsig->leader = oldsig->leader;
+               newsig->tty_old_pgrp = oldsig->tty_old_pgrp;
+       }
+
        if (thread_group_empty(current))
                goto no_thread_group;
 
@@ -610,7 +651,7 @@ static inline int de_thread(struct task_struct *tsk)
         */
        read_lock(&tasklist_lock);
        spin_lock_irq(lock);
-       if (sig->group_exit) {
+       if (oldsig->group_exit) {
                /*
                 * Another group action in progress, just
                 * return so that the signal is processed.
@@ -618,9 +659,11 @@ static inline int de_thread(struct task_struct *tsk)
                spin_unlock_irq(lock);
                read_unlock(&tasklist_lock);
                kmem_cache_free(sighand_cachep, newsighand);
+               if (newsig)
+                       kmem_cache_free(signal_cachep, newsig);
                return -EAGAIN;
        }
-       sig->group_exit = 1;
+       oldsig->group_exit = 1;
        zap_other_threads(current);
        read_unlock(&tasklist_lock);
 
@@ -630,16 +673,14 @@ static inline int de_thread(struct task_struct *tsk)
        count = 2;
        if (current->pid == current->tgid)
                count = 1;
-       while (atomic_read(&sig->count) > count) {
-               sig->group_exit_task = current;
-               sig->notify_count = count;
+       while (atomic_read(&oldsig->count) > count) {
+               oldsig->group_exit_task = current;
+               oldsig->notify_count = count;
                __set_current_state(TASK_UNINTERRUPTIBLE);
                spin_unlock_irq(lock);
                schedule();
                spin_lock_irq(lock);
        }
-       sig->group_exit_task = NULL;
-       sig->notify_count = 0;
        spin_unlock_irq(lock);
 
        /*
@@ -714,44 +755,32 @@ static inline int de_thread(struct task_struct *tsk)
                release_task(leader);
         }
 
-       /*
-        * Now there are really no other threads at all,
-        * so it's safe to stop telling them to kill themselves.
-        */
-       sig->group_exit = 0;
-
 no_thread_group:
-       BUG_ON(atomic_read(&sig->count) != 1);
-       exit_itimers(sig);
-
-       if (atomic_read(&oldsighand->count) == 1) {
-               /*
-                * Now that we nuked the rest of the thread group,
-                * it turns out we are not sharing sighand any more either.
-                * So we can just keep it.
-                */
-               kmem_cache_free(sighand_cachep, newsighand);
-       } else {
-               /*
-                * Move our state over to newsighand and switch it in.
-                */
-               spin_lock_init(&newsighand->siglock);
-               atomic_set(&newsighand->count, 1);
-               memcpy(newsighand->action, oldsighand->action,
-                      sizeof(newsighand->action));
-               write_lock_irq(&tasklist_lock);
-               spin_lock(&oldsighand->siglock);
-               spin_lock(&newsighand->siglock);
-               current->sighand = newsighand;
-               recalc_sigpending();
-               spin_unlock(&newsighand->siglock);
-               spin_unlock(&oldsighand->siglock);
-               write_unlock_irq(&tasklist_lock);
 
-               if (atomic_dec_and_test(&oldsighand->count))
-                       kmem_cache_free(sighand_cachep, oldsighand);
+       write_lock_irq(&tasklist_lock);
+       spin_lock(&oldsighand->siglock);
+       spin_lock(&newsighand->siglock);
+
+       if (current == oldsig->curr_target)
+               oldsig->curr_target = next_thread(current);
+       if (newsig)
+               current->signal = newsig;
+       current->sighand = newsighand;
+       init_sigpending(&current->pending);
+       recalc_sigpending();
+
+       spin_unlock(&newsighand->siglock);
+       spin_unlock(&oldsighand->siglock);
+       write_unlock_irq(&tasklist_lock);
+
+       if (newsig && atomic_dec_and_test(&oldsig->count)) {
+               exit_itimers(oldsig);
+               kmem_cache_free(signal_cachep, oldsig);
        }
 
+       if (atomic_dec_and_test(&oldsighand->count))
+               kmem_cache_free(sighand_cachep, oldsighand);
+
        if (!thread_group_empty(current))
                BUG();
        if (current->tgid != current->pid)
@@ -867,10 +896,8 @@ int flush_old_exec(struct linux_binprm * bprm)
 
        if (bprm->e_uid != current->euid || bprm->e_gid != current->egid || 
            permission(bprm->file->f_dentry->d_inode,MAY_READ, NULL) ||
-           (bprm->interp_flags & BINPRM_FLAGS_ENFORCE_NONDUMP)) {
-               suid_keys(current);
+           (bprm->interp_flags & BINPRM_FLAGS_ENFORCE_NONDUMP))
                current->mm->dumpable = suid_dumpable;
-       }
 
        /* An exec changes our domain. We are no longer part of the thread
           group */
@@ -904,7 +931,7 @@ int prepare_binprm(struct linux_binprm *bprm)
        mode = inode->i_mode;
        /*
         * Check execute perms again - if the caller has CAP_DAC_OVERRIDE,
-        * generic_permission lets a non-executable through
+        * vfs_permission lets a non-executable through
         */
        if (!(mode & 0111))     /* with at least _one_ execute bit set */
                return -EACCES;
@@ -964,11 +991,6 @@ static inline int unsafe_exec(struct task_struct *p)
 void compute_creds(struct linux_binprm *bprm)
 {
        int unsafe;
-
-       if (bprm->e_uid != current->uid)
-               suid_keys(current);
-       exec_keys(current);
-
        task_lock(current);
        unsafe = unsafe_exec(current);
        security_bprm_apply_creds(bprm, unsafe);
@@ -1115,26 +1137,26 @@ int do_execve(char * filename,
        int retval;
        int i;
 
-       retval = -ENOMEM;
-       bprm = kmalloc(sizeof(*bprm), GFP_KERNEL);
-       if (!bprm)
-               goto out_ret;
-       memset(bprm, 0, sizeof(*bprm));
-
        file = open_exec(filename);
+
        retval = PTR_ERR(file);
        if (IS_ERR(file))
-               goto out_kfree;
+               return retval;
 
        sched_exec();
 
+       retval = -ENOMEM;
+       bprm = kmalloc(sizeof(*bprm), GFP_KERNEL);
+       if (!bprm)
+               goto out_ret;
+       memset(bprm, 0, sizeof(*bprm));
+
        bprm->p = PAGE_SIZE*MAX_ARG_PAGES-sizeof(void *);
 
        bprm->file = file;
        bprm->filename = filename;
        bprm->interp = filename;
        bprm->mm = mm_alloc();
-       retval = -ENOMEM;
        if (!bprm->mm)
                goto out_file;
 
@@ -1201,8 +1223,6 @@ out_file:
                allow_write_access(bprm->file);
                fput(bprm->file);
        }
-
-out_kfree:
        kfree(bprm);
 
 out_ret:
@@ -1346,7 +1366,6 @@ static void zap_threads (struct mm_struct *mm)
        struct task_struct *g, *p;
        struct task_struct *tsk = current;
        struct completion *vfork_done = tsk->vfork_done;
-       int traced = 0;
 
        /*
         * Make sure nobody is waiting for us to release the VM,
@@ -1362,65 +1381,10 @@ static void zap_threads (struct mm_struct *mm)
                if (mm == p->mm && p != tsk) {
                        force_sig_specific(SIGKILL, p);
                        mm->core_waiters++;
-                       if (unlikely(p->ptrace) &&
-                           unlikely(p->parent->mm == mm))
-                               traced = 1;
                }
        while_each_thread(g,p);
 
        read_unlock(&tasklist_lock);
-
-       while (unlikely(traced)) {
-               /*
-                * We are zapping a thread and the thread it ptraces.
-                * The tracee won't come out of TASK_TRACED state until
-                * its ptracer detaches.  That happens when the ptracer
-                * dies, but it synchronizes with us and so won't get
-                * that far until we finish the core dump.  If we're
-                * waiting for the tracee to synchronize but it stays
-                * blocked in TASK_TRACED, then we deadlock.  So, for
-                * this weirdo case we have to do another round with
-                * tasklist_lock write-locked to __ptrace_unlink the
-                * children that might cause this deadlock.  That will
-                * wake them up to process their pending SIGKILL.
-                *
-                * First, give everyone we just killed a chance to run
-                * so they can all get into the coredump synchronization.
-                * That should leave only the TASK_TRACED stragglers for
-                * us to wake up.  If a ptracer is still running, we'll
-                * have to come around again after letting it finish.
-                */
-               yield();
-               traced = 0;
-               write_lock_irq(&tasklist_lock);
-               do_each_thread(g,p) {
-                       if (mm != p->mm || p == tsk ||
-                           !p->ptrace || p->parent->mm != mm)
-                               continue;
-                       if ((p->parent->flags & (PF_SIGNALED|PF_EXITING)) ||
-                           (p->parent->state & (TASK_TRACED|TASK_STOPPED))) {
-                               /*
-                                * The parent is in the process of exiting
-                                * itself, or else it's stopped right now.
-                                * It cannot be in a ptrace call, and would
-                                * have to read_lock tasklist_lock before
-                                * it could start one, so we are safe here.
-                                */
-                               __ptrace_unlink(p);
-                       } else {
-                               /*
-                                * Blargh!  The ptracer is not dying
-                                * yet, so we cannot be sure that it
-                                * isn't in the middle of a ptrace call.
-                                * We'll have to let it run to get into
-                                * coredump_wait and come around another
-                                * time to detach its tracee.
-                                */
-                               traced = 1;
-                       }
-               } while_each_thread(g,p);
-               write_unlock_irq(&tasklist_lock);
-       }
 }
 
 static void coredump_wait(struct mm_struct *mm)
@@ -1452,7 +1416,7 @@ int do_coredump(long signr, int exit_code, struct pt_regs * regs)
        int retval = 0;
        int fsuid = current->fsuid;
        int flag = 0;
-
+       
        binfmt = current->binfmt;
        if (!binfmt || !binfmt->core_dump)
                goto fail;
@@ -1463,13 +1427,14 @@ int do_coredump(long signr, int exit_code, struct pt_regs * regs)
                up_write(&mm->mmap_sem);
                goto fail;
        }
-
+       
        /*
         *      We cannot trust fsuid as being the "true" uid of the
         *      process nor do we know its entire history. We only know it
         *      was tainted so we dump it as root in mode 2.
         */
-       if (mm->dumpable == 2) {        /* Setuid core dump mode */
+       if (mm->dumpable == 2)          /* Setuid core dump mode */
+       {
                flag = O_EXCL;          /* Stop rewrite attacks */
                current->fsuid = 0;     /* Dump root private */
        }
@@ -1479,7 +1444,7 @@ int do_coredump(long signr, int exit_code, struct pt_regs * regs)
        current->signal->group_exit_code = exit_code;
        coredump_wait(mm);
 
-       if (current->signal->rlim[RLIMIT_CORE].rlim_cur < binfmt->min_coredump)
+       if (current->rlim[RLIMIT_CORE].rlim_cur < binfmt->min_coredump)
                goto fail_unlock;
 
        /*
@@ -1509,8 +1474,7 @@ int do_coredump(long signr, int exit_code, struct pt_regs * regs)
 
        retval = binfmt->core_dump(signr, regs, file);
 
-       if (retval)
-               current->signal->group_exit_code |= 0x80;
+       current->signal->group_exit_code |= 0x80;
 close_fail:
        filp_close(file, NULL);
 fail_unlock: