Fedora kernel-2.6.17-1.2142_FC4 patched with stable patch-2.6.17.4-vs2.0.2-rc26.diff
[linux-2.6.git] / fs / ext3 / super.c
index 09d6032..2a0cb4c 100644 (file)
 #include <linux/mount.h>
 #include <linux/namei.h>
 #include <linux/quotaops.h>
+#include <linux/seq_file.h>
+
 #include <asm/uaccess.h>
+
 #include "xattr.h"
 #include "acl.h"
+#include "namei.h"
 
-static int ext3_load_journal(struct super_block *, struct ext3_super_block *);
+static int ext3_load_journal(struct super_block *, struct ext3_super_block *,
+                            unsigned long journal_devnum);
 static int ext3_create_journal(struct super_block *, struct ext3_super_block *,
                               int);
 static void ext3_commit_super (struct super_block * sb,
@@ -50,6 +55,13 @@ static void ext3_mark_recovery_complete(struct super_block * sb,
 static void ext3_clear_journal_err(struct super_block * sb,
                                   struct ext3_super_block * es);
 static int ext3_sync_fs(struct super_block *sb, int wait);
+static const char *ext3_decode_error(struct super_block * sb, int errno,
+                                    char nbuf[16]);
+static int ext3_remount (struct super_block * sb, int * flags, char * data);
+static int ext3_statfs (struct super_block * sb, struct kstatfs * buf);
+static void ext3_unlockfs(struct super_block *sb);
+static void ext3_write_super (struct super_block * sb);
+static void ext3_write_super_lockfs(struct super_block *sb);
 
 /* 
  * Wrappers for journal_start/end.
@@ -59,19 +71,19 @@ static int ext3_sync_fs(struct super_block *sb, int wait);
  * that sync() will call the filesystem's write_super callback if
  * appropriate. 
  */
-handle_t *ext3_journal_start(struct inode *inode, int nblocks)
+handle_t *ext3_journal_start_sb(struct super_block *sb, int nblocks)
 {
        journal_t *journal;
 
-       if (inode->i_sb->s_flags & MS_RDONLY)
+       if (sb->s_flags & MS_RDONLY)
                return ERR_PTR(-EROFS);
 
        /* Special case here: if the journal has aborted behind our
         * backs (eg. EIO in the commit thread), then we still need to
         * take the FS itself readonly cleanly. */
-       journal = EXT3_JOURNAL(inode);
+       journal = EXT3_SB(sb)->s_journal;
        if (is_journal_aborted(journal)) {
-               ext3_abort(inode->i_sb, __FUNCTION__,
+               ext3_abort(sb, __FUNCTION__,
                           "Detected aborted journal");
                return ERR_PTR(-EROFS);
        }
@@ -108,17 +120,20 @@ void ext3_journal_abort_handle(const char *caller, const char *err_fn,
        char nbuf[16];
        const char *errstr = ext3_decode_error(NULL, err, nbuf);
 
-       printk(KERN_ERR "%s: aborting transaction: %s in %s", 
-              caller, errstr, err_fn);
-
        if (bh)
                BUFFER_TRACE(bh, "abort");
-       journal_abort_handle(handle);
+
        if (!handle->h_err)
                handle->h_err = err;
-}
 
-static char error_buf[1024];
+       if (is_handle_aborted(handle))
+               return;
+
+       printk(KERN_ERR "%s: aborting transaction: %s in %s\n",
+              caller, errstr, err_fn);
+
+       journal_abort_handle(handle);
+}
 
 /* Deal with the reporting of failure conditions on a filesystem such as
  * inconsistencies detected or read IO failures.
@@ -140,14 +155,11 @@ static void ext3_handle_error(struct super_block *sb)
        struct ext3_super_block *es = EXT3_SB(sb)->s_es;
 
        EXT3_SB(sb)->s_mount_state |= EXT3_ERROR_FS;
-       es->s_state |= cpu_to_le32(EXT3_ERROR_FS);
+       es->s_state |= cpu_to_le16(EXT3_ERROR_FS);
 
        if (sb->s_flags & MS_RDONLY)
                return;
 
-       if (test_opt (sb, ERRORS_PANIC))
-               panic ("EXT3-fs (device %s): panic forced after error\n",
-                      sb->s_id);
        if (test_opt (sb, ERRORS_RO)) {
                printk (KERN_CRIT "Remounting filesystem read-only\n");
                sb->s_flags |= MS_RDONLY;
@@ -158,6 +170,9 @@ static void ext3_handle_error(struct super_block *sb)
                if (journal)
                        journal_abort(journal, -EIO);
        }
+       if (test_opt(sb, ERRORS_PANIC))
+               panic("EXT3-fs (device %s): panic forced after error\n",
+                       sb->s_id);
        ext3_commit_super(sb, es, 1);
 }
 
@@ -166,17 +181,17 @@ void ext3_error (struct super_block * sb, const char * function,
 {
        va_list args;
 
-       va_start (args, fmt);
-       vsprintf (error_buf, fmt, args);
-       va_end (args);
-
-       printk (KERN_CRIT "EXT3-fs error (device %s): %s: %s\n",
-               sb->s_id, function, error_buf);
+       va_start(args, fmt);
+       printk(KERN_CRIT "EXT3-fs error (device %s): %s: ",sb->s_id, function);
+       vprintk(fmt, args);
+       printk("\n");
+       va_end(args);
 
        ext3_handle_error(sb);
 }
 
-const char *ext3_decode_error(struct super_block * sb, int errno, char nbuf[16])
+static const char *ext3_decode_error(struct super_block * sb, int errno,
+                                    char nbuf[16])
 {
        char *errstr = NULL;
 
@@ -215,8 +230,16 @@ void __ext3_std_error (struct super_block * sb, const char * function,
                       int errno)
 {
        char nbuf[16];
-       const char *errstr = ext3_decode_error(sb, errno, nbuf);
+       const char *errstr;
 
+       /* Special case: if the error is EROFS, and we're not already
+        * inside a transaction, then there's really no point in logging
+        * an error. */
+       if (errno == -EROFS && journal_current_handle() == NULL &&
+           (sb->s_flags & MS_RDONLY))
+               return;
+
+       errstr = ext3_decode_error(sb, errno, nbuf);
        printk (KERN_CRIT "EXT3-fs error (device %s) in %s: %s\n",
                sb->s_id, function, errstr);
 
@@ -240,59 +263,36 @@ void ext3_abort (struct super_block * sb, const char * function,
 
        printk (KERN_CRIT "ext3_abort called.\n");
 
-       va_start (args, fmt);
-       vsprintf (error_buf, fmt, args);
-       va_end (args);
-
-       if (test_opt (sb, ERRORS_PANIC))
-               panic ("EXT3-fs panic (device %s): %s: %s\n",
-                      sb->s_id, function, error_buf);
+       va_start(args, fmt);
+       printk(KERN_CRIT "EXT3-fs error (device %s): %s: ",sb->s_id, function);
+       vprintk(fmt, args);
+       printk("\n");
+       va_end(args);
 
-       printk (KERN_CRIT "EXT3-fs abort (device %s): %s: %s\n",
-               sb->s_id, function, error_buf);
+       if (test_opt(sb, ERRORS_PANIC))
+               panic("EXT3-fs panic from previous error\n");
 
        if (sb->s_flags & MS_RDONLY)
                return;
 
-       printk (KERN_CRIT "Remounting filesystem read-only\n");
+       printk(KERN_CRIT "Remounting filesystem read-only\n");
        EXT3_SB(sb)->s_mount_state |= EXT3_ERROR_FS;
        sb->s_flags |= MS_RDONLY;
        EXT3_SB(sb)->s_mount_opt |= EXT3_MOUNT_ABORT;
        journal_abort(EXT3_SB(sb)->s_journal, -EIO);
 }
 
-/* Deal with the reporting of failure conditions while running, such as
- * inconsistencies in operation or invalid system states.
- *
- * Use ext3_error() for cases of invalid filesystem states, as that will
- * record an error on disk and force a filesystem check on the next boot.
- */
-NORET_TYPE void ext3_panic (struct super_block * sb, const char * function,
-                           const char * fmt, ...)
-{
-       va_list args;
-
-       va_start (args, fmt);
-       vsprintf (error_buf, fmt, args);
-       va_end (args);
-
-       /* this is to prevent panic from syncing this filesystem */
-       /* AKPM: is this sufficient? */
-       sb->s_flags |= MS_RDONLY;
-       panic ("EXT3-fs panic (device %s): %s: %s\n",
-              sb->s_id, function, error_buf);
-}
-
 void ext3_warning (struct super_block * sb, const char * function,
                   const char * fmt, ...)
 {
        va_list args;
 
-       va_start (args, fmt);
-       vsprintf (error_buf, fmt, args);
-       va_end (args);
-       printk (KERN_WARNING "EXT3-fs warning (device %s): %s: %s\n",
-               sb->s_id, function, error_buf);
+       va_start(args, fmt);
+       printk(KERN_WARNING "EXT3-fs warning (device %s): %s: ",
+              sb->s_id, function);
+       vprintk(fmt, args);
+       printk("\n");
+       va_end(args);
 }
 
 void ext3_update_dynamic_rev(struct super_block *sb)
@@ -356,7 +356,7 @@ static int ext3_blkdev_remove(struct ext3_sb_info *sbi)
        bdev = sbi->journal_bdev;
        if (bdev) {
                ret = ext3_blkdev_put(bdev);
-               sbi->journal_bdev = 0;
+               sbi->journal_bdev = NULL;
        }
        return ret;
 }
@@ -380,11 +380,11 @@ static void dump_orphan_list(struct super_block *sb, struct ext3_sb_info *sbi)
                       "inode %s:%ld at %p: mode %o, nlink %d, next %d\n",
                       inode->i_sb->s_id, inode->i_ino, inode,
                       inode->i_mode, inode->i_nlink, 
-                      le32_to_cpu(NEXT_ORPHAN(inode)));
+                      NEXT_ORPHAN(inode));
        }
 }
 
-void ext3_put_super (struct super_block * sb)
+static void ext3_put_super (struct super_block * sb)
 {
        struct ext3_sb_info *sbi = EXT3_SB(sb);
        struct ext3_super_block *es = sbi->s_es;
@@ -394,7 +394,7 @@ void ext3_put_super (struct super_block * sb)
        journal_destroy(sbi->s_journal);
        if (!(sb->s_flags & MS_RDONLY)) {
                EXT3_CLEAR_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER);
-               es->s_state = le16_to_cpu(sbi->s_mount_state);
+               es->s_state = cpu_to_le16(sbi->s_mount_state);
                BUFFER_TRACE(sbi->s_sbh, "marking dirty");
                mark_buffer_dirty(sbi->s_sbh);
                ext3_commit_super(sb, es, 1);
@@ -403,13 +403,13 @@ void ext3_put_super (struct super_block * sb)
        for (i = 0; i < sbi->s_gdb_count; i++)
                brelse(sbi->s_group_desc[i]);
        kfree(sbi->s_group_desc);
-       kfree(sbi->s_debts);
+       percpu_counter_destroy(&sbi->s_freeblocks_counter);
+       percpu_counter_destroy(&sbi->s_freeinodes_counter);
+       percpu_counter_destroy(&sbi->s_dirs_counter);
        brelse(sbi->s_sbh);
 #ifdef CONFIG_QUOTA
-       for (i = 0; i < MAXQUOTAS; i++) {
-               if (sbi->s_qf_names[i])
-                       kfree(sbi->s_qf_names[i]);
-       }
+       for (i = 0; i < MAXQUOTAS; i++)
+               kfree(sbi->s_qf_names[i]);
 #endif
 
        /* Debugging code just in case the in-memory inode orphan list
@@ -452,6 +452,7 @@ static struct inode *ext3_alloc_inode(struct super_block *sb)
        ei->i_acl = EXT3_ACL_NOT_CACHED;
        ei->i_default_acl = EXT3_ACL_NOT_CACHED;
 #endif
+       ei->i_block_alloc_info = NULL;
        ei->vfs_inode.i_version = 1;
        return &ei->vfs_inode;
 }
@@ -471,7 +472,7 @@ static void init_once(void * foo, kmem_cache_t * cachep, unsigned long flags)
 #ifdef CONFIG_EXT3_FS_XATTR
                init_rwsem(&ei->xattr_sem);
 #endif
-               init_MUTEX(&ei->truncate_sem);
+               mutex_init(&ei->truncate_mutex);
                inode_init_once(&ei->vfs_inode);
        }
 }
@@ -480,7 +481,8 @@ static int init_inodecache(void)
 {
        ext3_inode_cachep = kmem_cache_create("ext3_inode_cache",
                                             sizeof(struct ext3_inode_info),
-                                            0, SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT,
+                                            0, (SLAB_RECLAIM_ACCOUNT|
+                                               SLAB_MEM_SPREAD),
                                             init_once, NULL);
        if (ext3_inode_cachep == NULL)
                return -ENOMEM;
@@ -493,10 +495,10 @@ static void destroy_inodecache(void)
                printk(KERN_INFO "ext3_inode_cache: not all structures were freed\n");
 }
 
-#ifdef CONFIG_EXT3_FS_POSIX_ACL
-
 static void ext3_clear_inode(struct inode *inode)
 {
+       struct ext3_block_alloc_info *rsv = EXT3_I(inode)->i_block_alloc_info;
+#ifdef CONFIG_EXT3_FS_POSIX_ACL
        if (EXT3_I(inode)->i_acl &&
            EXT3_I(inode)->i_acl != EXT3_ACL_NOT_CACHED) {
                posix_acl_release(EXT3_I(inode)->i_acl);
@@ -507,25 +509,68 @@ static void ext3_clear_inode(struct inode *inode)
                posix_acl_release(EXT3_I(inode)->i_default_acl);
                EXT3_I(inode)->i_default_acl = EXT3_ACL_NOT_CACHED;
        }
+#endif
+       ext3_discard_reservation(inode);
+       EXT3_I(inode)->i_block_alloc_info = NULL;
+       kfree(rsv);
 }
 
-#else
-# define ext3_clear_inode NULL
+static inline void ext3_show_quota_options(struct seq_file *seq, struct super_block *sb)
+{
+#if defined(CONFIG_QUOTA)
+       struct ext3_sb_info *sbi = EXT3_SB(sb);
+
+       if (sbi->s_jquota_fmt)
+               seq_printf(seq, ",jqfmt=%s",
+               (sbi->s_jquota_fmt == QFMT_VFS_OLD) ? "vfsold": "vfsv0");
+
+       if (sbi->s_qf_names[USRQUOTA])
+               seq_printf(seq, ",usrjquota=%s", sbi->s_qf_names[USRQUOTA]);
+
+       if (sbi->s_qf_names[GRPQUOTA])
+               seq_printf(seq, ",grpjquota=%s", sbi->s_qf_names[GRPQUOTA]);
+
+       if (sbi->s_mount_opt & EXT3_MOUNT_USRQUOTA)
+               seq_puts(seq, ",usrquota");
+
+       if (sbi->s_mount_opt & EXT3_MOUNT_GRPQUOTA)
+               seq_puts(seq, ",grpquota");
 #endif
+}
 
-#ifdef CONFIG_QUOTA
+static int ext3_show_options(struct seq_file *seq, struct vfsmount *vfs)
+{
+       struct super_block *sb = vfs->mnt_sb;
+
+       if (test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_JOURNAL_DATA)
+               seq_puts(seq, ",data=journal");
+       else if (test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_ORDERED_DATA)
+               seq_puts(seq, ",data=ordered");
+       else if (test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_WRITEBACK_DATA)
+               seq_puts(seq, ",data=writeback");
+
+       ext3_show_quota_options(seq, sb);
 
+       return 0;
+}
+
+#ifdef CONFIG_QUOTA
 #define QTYPE2NAME(t) ((t)==USRQUOTA?"user":"group")
 #define QTYPE2MOPT(on, t) ((t)==USRQUOTA?((on)##USRJQUOTA):((on)##GRPJQUOTA))
 
 static int ext3_dquot_initialize(struct inode *inode, int type);
 static int ext3_dquot_drop(struct inode *inode);
 static int ext3_write_dquot(struct dquot *dquot);
+static int ext3_acquire_dquot(struct dquot *dquot);
+static int ext3_release_dquot(struct dquot *dquot);
 static int ext3_mark_dquot_dirty(struct dquot *dquot);
 static int ext3_write_info(struct super_block *sb, int type);
 static int ext3_quota_on(struct super_block *sb, int type, int format_id, char *path);
 static int ext3_quota_on_mount(struct super_block *sb, int type);
-static int ext3_quota_off_mount(struct super_block *sb, int type);
+static ssize_t ext3_quota_read(struct super_block *sb, int type, char *data,
+                              size_t len, loff_t off);
+static ssize_t ext3_quota_write(struct super_block *sb, int type,
+                               const char *data, size_t len, loff_t off);
 
 static struct dquot_operations ext3_quota_operations = {
        .initialize     = ext3_dquot_initialize,
@@ -536,6 +581,8 @@ static struct dquot_operations ext3_quota_operations = {
        .free_inode     = dquot_free_inode,
        .transfer       = dquot_transfer,
        .write_dquot    = ext3_write_dquot,
+       .acquire_dquot  = ext3_acquire_dquot,
+       .release_dquot  = ext3_release_dquot,
        .mark_dirty     = ext3_mark_dquot_dirty,
        .write_info     = ext3_write_info
 };
@@ -557,7 +604,6 @@ static struct super_operations ext3_sops = {
        .read_inode     = ext3_read_inode,
        .write_inode    = ext3_write_inode,
        .dirty_inode    = ext3_dirty_inode,
-       .put_inode      = ext3_put_inode,
        .delete_inode   = ext3_delete_inode,
        .put_super      = ext3_put_super,
        .write_super    = ext3_write_super,
@@ -567,9 +613,13 @@ static struct super_operations ext3_sops = {
        .statfs         = ext3_statfs,
        .remount_fs     = ext3_remount,
        .clear_inode    = ext3_clear_inode,
+       .show_options   = ext3_show_options,
+#ifdef CONFIG_QUOTA
+       .quota_read     = ext3_quota_read,
+       .quota_write    = ext3_quota_write,
+#endif
 };
 
-struct dentry *ext3_get_parent(struct dentry *child);
 static struct export_operations ext3_export_ops = {
        .get_parent = ext3_get_parent,
 };
@@ -577,13 +627,15 @@ static struct export_operations ext3_export_ops = {
 enum {
        Opt_bsd_df, Opt_minix_df, Opt_grpid, Opt_nogrpid,
        Opt_resgid, Opt_resuid, Opt_sb, Opt_err_cont, Opt_err_panic, Opt_err_ro,
-       Opt_nouid32, Opt_check, Opt_nocheck, Opt_debug, Opt_oldalloc, Opt_orlov,
-       Opt_user_xattr, Opt_nouser_xattr, Opt_acl, Opt_noacl, Opt_noload,
-       Opt_commit, Opt_journal_update, Opt_journal_inum,
+       Opt_nouid32, Opt_nocheck, Opt_debug, Opt_oldalloc, Opt_orlov,
+       Opt_user_xattr, Opt_nouser_xattr, Opt_acl, Opt_noacl,
+       Opt_reservation, Opt_noreservation, Opt_noload, Opt_nobh,
+       Opt_commit, Opt_journal_update, Opt_journal_inum, Opt_journal_dev,
        Opt_abort, Opt_data_journal, Opt_data_ordered, Opt_data_writeback,
        Opt_usrjquota, Opt_grpjquota, Opt_offusrjquota, Opt_offgrpjquota,
-       Opt_jqfmt_vfsold, Opt_jqfmt_vfsv0,
-       Opt_tagxid, Opt_ignore, Opt_err,
+       Opt_jqfmt_vfsold, Opt_jqfmt_vfsv0, Opt_quota, Opt_noquota,
+       Opt_ignore, Opt_barrier, Opt_err, Opt_resize, Opt_usrquota,
+       Opt_grpquota, Opt_tagxid
 };
 
 static match_table_t tokens = {
@@ -602,7 +654,6 @@ static match_table_t tokens = {
        {Opt_nouid32, "nouid32"},
        {Opt_nocheck, "nocheck"},
        {Opt_nocheck, "check=none"},
-       {Opt_check, "check"},
        {Opt_debug, "debug"},
        {Opt_oldalloc, "oldalloc"},
        {Opt_orlov, "orlov"},
@@ -610,10 +661,14 @@ static match_table_t tokens = {
        {Opt_nouser_xattr, "nouser_xattr"},
        {Opt_acl, "acl"},
        {Opt_noacl, "noacl"},
+       {Opt_reservation, "reservation"},
+       {Opt_noreservation, "noreservation"},
        {Opt_noload, "noload"},
+       {Opt_nobh, "nobh"},
        {Opt_commit, "commit=%u"},
        {Opt_journal_update, "journal=update"},
        {Opt_journal_inum, "journal=%u"},
+       {Opt_journal_dev, "journal_dev=%u"},
        {Opt_abort, "abort"},
        {Opt_data_journal, "data=journal"},
        {Opt_data_ordered, "data=ordered"},
@@ -624,12 +679,14 @@ static match_table_t tokens = {
        {Opt_grpjquota, "grpjquota=%s"},
        {Opt_jqfmt_vfsold, "jqfmt=vfsold"},
        {Opt_jqfmt_vfsv0, "jqfmt=vfsv0"},
+       {Opt_grpquota, "grpquota"},
+       {Opt_noquota, "noquota"},
+       {Opt_quota, "quota"},
+       {Opt_usrquota, "usrquota"},
+       {Opt_barrier, "barrier=%u"},
        {Opt_tagxid, "tagxid"},
-       {Opt_ignore, "grpquota"},
-       {Opt_ignore, "noquota"},
-       {Opt_ignore, "quota"},
-       {Opt_ignore, "usrquota"},
-       {Opt_err, NULL}
+       {Opt_err, NULL},
+       {Opt_resize, "resize"},
 };
 
 static unsigned long get_sb_block(void **data)
@@ -652,8 +709,9 @@ static unsigned long get_sb_block(void **data)
        return sb_block;
 }
 
-static int parse_options (char * options, struct super_block *sb,
-                         unsigned long * inum, int is_remount)
+static int parse_options (char *options, struct super_block *sb,
+                         unsigned long *inum, unsigned long *journal_devnum,
+                         unsigned long *n_blocks_count, int is_remount)
 {
        struct ext3_sb_info *sbi = EXT3_SB(sb);
        char * p;
@@ -662,6 +720,7 @@ static int parse_options (char * options, struct super_block *sb,
        int option;
 #ifdef CONFIG_QUOTA
        int qtype;
+       char *qname;
 #endif
 
        if (!options)
@@ -720,17 +779,9 @@ static int parse_options (char * options, struct super_block *sb,
                        break;
 #ifndef CONFIG_INOXID_NONE
                case Opt_tagxid:
-                       set_opt (sbi->s_mount_opt, TAG_XID);
+                       set_opt (sbi->s_mount_opt, TAGXID);
                        break;
 #endif
-               case Opt_check:
-#ifdef CONFIG_EXT3_CHECK
-                       set_opt (sbi->s_mount_opt, CHECK);
-#else
-                       printk(KERN_ERR
-                              "EXT3 Check option not supported\n");
-#endif
-                       break;
                case Opt_nocheck:
                        clear_opt (sbi->s_mount_opt, CHECK);
                        break;
@@ -769,6 +820,12 @@ static int parse_options (char * options, struct super_block *sb,
                        printk("EXT3 (no)acl options not supported\n");
                        break;
 #endif
+               case Opt_reservation:
+                       set_opt(sbi->s_mount_opt, RESERVATION);
+                       break;
+               case Opt_noreservation:
+                       clear_opt(sbi->s_mount_opt, RESERVATION);
+                       break;
                case Opt_journal_update:
                        /* @@@ FIXME */
                        /* Eventually we will want to be able to create
@@ -792,6 +849,16 @@ static int parse_options (char * options, struct super_block *sb,
                                return 0;
                        *inum = option;
                        break;
+               case Opt_journal_dev:
+                       if (is_remount) {
+                               printk(KERN_ERR "EXT3-fs: cannot specify "
+                                      "journal on remount\n");
+                               return 0;
+                       }
+                       if (match_int(&args[0], &option))
+                               return 0;
+                       *journal_devnum = option;
+                       break;
                case Opt_noload:
                        set_opt (sbi->s_mount_opt, NOLOAD);
                        break;
@@ -839,19 +906,22 @@ set_qf_name:
                                        "quota options when quota turned on.\n");
                                return 0;
                        }
-                       if (sbi->s_qf_names[qtype]) {
+                       qname = match_strdup(&args[0]);
+                       if (!qname) {
                                printk(KERN_ERR
-                                       "EXT3-fs: %s quota file already "
-                                       "specified.\n", QTYPE2NAME(qtype));
+                                       "EXT3-fs: not enough memory for "
+                                       "storing quotafile name.\n");
                                return 0;
                        }
-                       sbi->s_qf_names[qtype] = match_strdup(&args[0]);
-                       if (!sbi->s_qf_names[qtype]) {
+                       if (sbi->s_qf_names[qtype] &&
+                           strcmp(sbi->s_qf_names[qtype], qname)) {
                                printk(KERN_ERR
-                                       "EXT3-fs: not enough memory for "
-                                       "storing quotafile name.\n");
+                                       "EXT3-fs: %s quota file already "
+                                       "specified.\n", QTYPE2NAME(qtype));
+                               kfree(qname);
                                return 0;
                        }
+                       sbi->s_qf_names[qtype] = qname;
                        if (strchr(sbi->s_qf_names[qtype], '/')) {
                                printk(KERN_ERR
                                        "EXT3-fs: quotafile must be on "
@@ -860,6 +930,7 @@ set_qf_name:
                                sbi->s_qf_names[qtype] = NULL;
                                return 0;
                        }
+                       set_opt(sbi->s_mount_opt, QUOTA);
                        break;
                case Opt_offusrjquota:
                        qtype = USRQUOTA;
@@ -873,10 +944,11 @@ clear_qf_name:
                                        "quota turned on.\n");
                                return 0;
                        }
-                       if (sbi->s_qf_names[qtype]) {
-                               kfree(sbi->s_qf_names[qtype]);
-                               sbi->s_qf_names[qtype] = NULL;
-                       }
+                       /*
+                        * The space will be released later when all options
+                        * are confirmed to be correct
+                        */
+                       sbi->s_qf_names[qtype] = NULL;
                        break;
                case Opt_jqfmt_vfsold:
                        sbi->s_jquota_fmt = QFMT_VFS_OLD;
@@ -884,7 +956,29 @@ clear_qf_name:
                case Opt_jqfmt_vfsv0:
                        sbi->s_jquota_fmt = QFMT_VFS_V0;
                        break;
+               case Opt_quota:
+               case Opt_usrquota:
+                       set_opt(sbi->s_mount_opt, QUOTA);
+                       set_opt(sbi->s_mount_opt, USRQUOTA);
+                       break;
+               case Opt_grpquota:
+                       set_opt(sbi->s_mount_opt, QUOTA);
+                       set_opt(sbi->s_mount_opt, GRPQUOTA);
+                       break;
+               case Opt_noquota:
+                       if (sb_any_quota_enabled(sb)) {
+                               printk(KERN_ERR "EXT3-fs: Cannot change quota "
+                                       "options when quota turned on.\n");
+                               return 0;
+                       }
+                       clear_opt(sbi->s_mount_opt, QUOTA);
+                       clear_opt(sbi->s_mount_opt, USRQUOTA);
+                       clear_opt(sbi->s_mount_opt, GRPQUOTA);
+                       break;
 #else
+               case Opt_quota:
+               case Opt_usrquota:
+               case Opt_grpquota:
                case Opt_usrjquota:
                case Opt_grpjquota:
                case Opt_offusrjquota:
@@ -895,12 +989,35 @@ clear_qf_name:
                                "EXT3-fs: journalled quota options not "
                                "supported.\n");
                        break;
+               case Opt_noquota:
+                       break;
 #endif
                case Opt_abort:
                        set_opt(sbi->s_mount_opt, ABORT);
                        break;
+               case Opt_barrier:
+                       if (match_int(&args[0], &option))
+                               return 0;
+                       if (option)
+                               set_opt(sbi->s_mount_opt, BARRIER);
+                       else
+                               clear_opt(sbi->s_mount_opt, BARRIER);
+                       break;
                case Opt_ignore:
                        break;
+               case Opt_resize:
+                       if (!is_remount) {
+                               printk("EXT3-fs: resize option only available "
+                                       "for remount\n");
+                               return 0;
+                       }
+                       if (match_int(&args[0], &option) != 0)
+                               return 0;
+                       *n_blocks_count = option;
+                       break;
+               case Opt_nobh:
+                       set_opt(sbi->s_mount_opt, NOBH);
+                       break;
                default:
                        printk (KERN_ERR
                                "EXT3-fs: Unrecognized mount option \"%s\" "
@@ -909,14 +1026,38 @@ clear_qf_name:
                }
        }
 #ifdef CONFIG_QUOTA
-       if (!sbi->s_jquota_fmt && (sbi->s_qf_names[USRQUOTA] ||
-           sbi->s_qf_names[GRPQUOTA])) {
-               printk(KERN_ERR
-                       "EXT3-fs: journalled quota format not specified.\n");
-               return 0;
+       if (sbi->s_qf_names[USRQUOTA] || sbi->s_qf_names[GRPQUOTA]) {
+               if ((sbi->s_mount_opt & EXT3_MOUNT_USRQUOTA) &&
+                    sbi->s_qf_names[USRQUOTA])
+                       clear_opt(sbi->s_mount_opt, USRQUOTA);
+
+               if ((sbi->s_mount_opt & EXT3_MOUNT_GRPQUOTA) &&
+                    sbi->s_qf_names[GRPQUOTA])
+                       clear_opt(sbi->s_mount_opt, GRPQUOTA);
+
+               if ((sbi->s_qf_names[USRQUOTA] &&
+                               (sbi->s_mount_opt & EXT3_MOUNT_GRPQUOTA)) ||
+                   (sbi->s_qf_names[GRPQUOTA] &&
+                               (sbi->s_mount_opt & EXT3_MOUNT_USRQUOTA))) {
+                       printk(KERN_ERR "EXT3-fs: old and new quota "
+                                       "format mixing.\n");
+                       return 0;
+               }
+
+               if (!sbi->s_jquota_fmt) {
+                       printk(KERN_ERR "EXT3-fs: journalled quota format "
+                                       "not specified.\n");
+                       return 0;
+               }
+       } else {
+               if (sbi->s_jquota_fmt) {
+                       printk(KERN_ERR "EXT3-fs: journalled quota format "
+                                       "specified with no journalling "
+                                       "enabled.\n");
+                       return 0;
+               }
        }
 #endif
-
        return 1;
 }
 
@@ -960,8 +1101,7 @@ static int ext3_setup_super(struct super_block *sb, struct ext3_super_block *es,
        es->s_state = cpu_to_le16(le16_to_cpu(es->s_state) & ~EXT3_VALID_FS);
 #endif
        if (!(__s16) le16_to_cpu(es->s_max_mnt_count))
-               es->s_max_mnt_count =
-                       (__s16) cpu_to_le16(EXT3_DFL_MAX_MNT_COUNT);
+               es->s_max_mnt_count = cpu_to_le16(EXT3_DFL_MAX_MNT_COUNT);
        es->s_mnt_count=cpu_to_le16(le16_to_cpu(es->s_mnt_count) + 1);
        es->s_mtime = cpu_to_le32(get_seconds());
        ext3_update_dynamic_rev(sb);
@@ -986,15 +1126,10 @@ static int ext3_setup_super(struct super_block *sb, struct ext3_super_block *es,
        } else {
                printk("internal journal\n");
        }
-#ifdef CONFIG_EXT3_CHECK
-       if (test_opt (sb, CHECK)) {
-               ext3_check_blocks_bitmap (sb);
-               ext3_check_inodes_bitmap (sb);
-       }
-#endif
        return res;
 }
 
+/* Called at mount-time, super-block is locked */
 static int ext3_check_descriptors (struct super_block * sb)
 {
        struct ext3_sb_info *sbi = EXT3_SB(sb);
@@ -1154,7 +1289,7 @@ static void ext3_orphan_cleanup (struct super_block * sb,
        /* Turn quotas off */
        for (i = 0; i < MAXQUOTAS; i++) {
                if (sb_dqopt(sb)->files[i])
-                       ext3_quota_off_mount(sb, i);
+                       vfs_quota_off(sb, i);
        }
 #endif
        sb->s_flags = s_flags; /* Restore MS_RDONLY status */
@@ -1170,12 +1305,18 @@ static void ext3_orphan_cleanup (struct super_block * sb,
 static loff_t ext3_max_size(int bits)
 {
        loff_t res = EXT3_NDIR_BLOCKS;
+       /* This constant is calculated to be the largest file size for a
+        * dense, 4k-blocksize file such that the total number of
+        * sectors in the file, including data and all indirect blocks,
+        * does not exceed 2^32. */
+       const loff_t upper_limit = 0x1ff7fffd000LL;
+
        res += 1LL << (bits-2);
        res += 1LL << (2*(bits-2));
        res += 1LL << (3*(bits-2));
        res <<= bits;
-       if (res > (512LL << 32) - (1 << bits))
-               res = (512LL << 32) - (1 << bits);
+       if (res > upper_limit)
+               res = upper_limit;
        return res;
 }
 
@@ -1203,13 +1344,14 @@ static unsigned long descriptor_loc(struct super_block *sb,
 static int ext3_fill_super (struct super_block *sb, void *data, int silent)
 {
        struct buffer_head * bh;
-       struct ext3_super_block *es = 0;
+       struct ext3_super_block *es = NULL;
        struct ext3_sb_info *sbi;
        unsigned long block;
        unsigned long sb_block = get_sb_block(&data);
        unsigned long logic_sb_block;
        unsigned long offset = 0;
        unsigned long journal_inum = 0;
+       unsigned long journal_devnum = 0;
        unsigned long def_mount_opts;
        struct inode *root;
        int blocksize;
@@ -1217,6 +1359,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
        int db_count;
        int i;
        int needs_recovery;
+       __le32 features;
 
        sbi = kmalloc(sizeof(*sbi), GFP_KERNEL);
        if (!sbi)
@@ -1227,6 +1370,8 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
        sbi->s_resuid = EXT3_DEF_RESUID;
        sbi->s_resgid = EXT3_DEF_RESGID;
 
+       unlock_kernel();
+
        blocksize = sb_min_blocksize(sb, EXT3_MIN_BLOCK_SIZE);
        if (!blocksize) {
                printk(KERN_ERR "EXT3-fs: unable to set blocksize\n");
@@ -1255,13 +1400,8 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
        es = (struct ext3_super_block *) (((char *)bh->b_data) + offset);
        sbi->s_es = es;
        sb->s_magic = le16_to_cpu(es->s_magic);
-       if (sb->s_magic != EXT3_SUPER_MAGIC) {
-               if (!silent)
-                       printk(KERN_ERR 
-                              "VFS: Can't find ext3 filesystem on dev %s.\n",
-                              sb->s_id);
-               goto failed_mount;
-       }
+       if (sb->s_magic != EXT3_SUPER_MAGIC)
+               goto cantfind_ext3;
 
        /* Set defaults before we parse the mount options */
        def_mount_opts = le32_to_cpu(es->s_default_mount_opts);
@@ -1290,12 +1430,15 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
        sbi->s_resuid = le16_to_cpu(es->s_def_resuid);
        sbi->s_resgid = le16_to_cpu(es->s_def_resgid);
 
-       if (!parse_options ((char *) data, sb, &journal_inum, 0))
+       set_opt(sbi->s_mount_opt, RESERVATION);
+
+       if (!parse_options ((char *) data, sb, &journal_inum, &journal_devnum,
+                           NULL, 0))
                goto failed_mount;
 
-       if (EXT3_SB(sb)->s_mount_opt & EXT3_MOUNT_TAG_XID)
+       if (EXT3_SB(sb)->s_mount_opt & EXT3_MOUNT_TAGXID)
                sb->s_flags |= MS_TAGXID;
-       sb->s_flags |= MS_ONE_SECOND;
+
        sb->s_flags = (sb->s_flags & ~MS_POSIXACL) |
                ((sbi->s_mount_opt & EXT3_MOUNT_POSIX_ACL) ? MS_POSIXACL : 0);
 
@@ -1311,17 +1454,18 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
         * previously didn't change the revision level when setting the flags,
         * so there is a chance incompat flags are set on a rev 0 filesystem.
         */
-       if ((i = EXT3_HAS_INCOMPAT_FEATURE(sb, ~EXT3_FEATURE_INCOMPAT_SUPP))) {
+       features = EXT3_HAS_INCOMPAT_FEATURE(sb, ~EXT3_FEATURE_INCOMPAT_SUPP);
+       if (features) {
                printk(KERN_ERR "EXT3-fs: %s: couldn't mount because of "
                       "unsupported optional features (%x).\n",
-                      sb->s_id, i);
+                      sb->s_id, le32_to_cpu(features));
                goto failed_mount;
        }
-       if (!(sb->s_flags & MS_RDONLY) &&
-           (i = EXT3_HAS_RO_COMPAT_FEATURE(sb, ~EXT3_FEATURE_RO_COMPAT_SUPP))){
+       features = EXT3_HAS_RO_COMPAT_FEATURE(sb, ~EXT3_FEATURE_RO_COMPAT_SUPP);
+       if (!(sb->s_flags & MS_RDONLY) && features) {
                printk(KERN_ERR "EXT3-fs: %s: couldn't mount RDWR because of "
                       "unsupported optional features (%x).\n",
-                      sb->s_id, i);
+                      sb->s_id, le32_to_cpu(features));
                goto failed_mount;
        }
        blocksize = BLOCK_SIZE << le32_to_cpu(es->s_log_block_size);
@@ -1358,7 +1502,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
                }
                es = (struct ext3_super_block *)(((char *)bh->b_data) + offset);
                sbi->s_es = es;
-               if (es->s_magic != le16_to_cpu(EXT3_SUPER_MAGIC)) {
+               if (es->s_magic != cpu_to_le16(EXT3_SUPER_MAGIC)) {
                        printk (KERN_ERR 
                                "EXT3-fs: Magic mismatch, very weird !\n");
                        goto failed_mount;
@@ -1394,8 +1538,13 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
        sbi->s_blocks_per_group = le32_to_cpu(es->s_blocks_per_group);
        sbi->s_frags_per_group = le32_to_cpu(es->s_frags_per_group);
        sbi->s_inodes_per_group = le32_to_cpu(es->s_inodes_per_group);
+       if (EXT3_INODE_SIZE(sb) == 0)
+               goto cantfind_ext3;
        sbi->s_inodes_per_block = blocksize / EXT3_INODE_SIZE(sb);
-       sbi->s_itb_per_group = sbi->s_inodes_per_group /sbi->s_inodes_per_block;
+       if (sbi->s_inodes_per_block == 0)
+               goto cantfind_ext3;
+       sbi->s_itb_per_group = sbi->s_inodes_per_group /
+                                       sbi->s_inodes_per_block;
        sbi->s_desc_per_block = blocksize / sizeof(struct ext3_group_desc);
        sbi->s_sbh = bh;
        sbi->s_mount_state = le16_to_cpu(es->s_state);
@@ -1424,6 +1573,8 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
                goto failed_mount;
        }
 
+       if (EXT3_BLOCKS_PER_GROUP(sb) == 0)
+               goto cantfind_ext3;
        sbi->s_groups_count = (le32_to_cpu(es->s_blocks_count) -
                               le32_to_cpu(es->s_first_data_block) +
                               EXT3_BLOCKS_PER_GROUP(sb) - 1) /
@@ -1436,13 +1587,6 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
                printk (KERN_ERR "EXT3-fs: not enough memory\n");
                goto failed_mount;
        }
-       sbi->s_debts = kmalloc(sbi->s_groups_count * sizeof(u8),
-                       GFP_KERNEL);
-       if (!sbi->s_debts) {
-               printk("EXT3-fs: not enough memory to allocate s_bgi\n");
-               goto failed_mount2;
-       }
-       memset(sbi->s_debts, 0,  sbi->s_groups_count * sizeof(u8));
 
        percpu_counter_init(&sbi->s_freeblocks_counter);
        percpu_counter_init(&sbi->s_freeinodes_counter);
@@ -1466,18 +1610,32 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
        sbi->s_gdb_count = db_count;
        get_random_bytes(&sbi->s_next_generation, sizeof(u32));
        spin_lock_init(&sbi->s_next_gen_lock);
+       /* per fileystem reservation list head & lock */
+       spin_lock_init(&sbi->s_rsv_window_lock);
+       sbi->s_rsv_window_root = RB_ROOT;
+       /* Add a single, static dummy reservation to the start of the
+        * reservation window list --- it gives us a placeholder for
+        * append-at-start-of-list which makes the allocation logic
+        * _much_ simpler. */
+       sbi->s_rsv_window_head.rsv_start = EXT3_RESERVE_WINDOW_NOT_ALLOCATED;
+       sbi->s_rsv_window_head.rsv_end = EXT3_RESERVE_WINDOW_NOT_ALLOCATED;
+       sbi->s_rsv_window_head.rsv_alloc_hit = 0;
+       sbi->s_rsv_window_head.rsv_goal_size = 0;
+       ext3_rsv_window_add(sb, &sbi->s_rsv_window_head);
+
        /*
         * set up enough so that it can read an inode
         */
        sb->s_op = &ext3_sops;
        sb->s_export_op = &ext3_export_ops;
+       sb->s_xattr = ext3_xattr_handlers;
 #ifdef CONFIG_QUOTA
        sb->s_qcop = &ext3_qctl_operations;
        sb->dq_op = &ext3_quota_operations;
 #endif
        INIT_LIST_HEAD(&sbi->s_orphan); /* unlinked but open files */
 
-       sb->s_root = 0;
+       sb->s_root = NULL;
 
        needs_recovery = (es->s_last_orphan != 0 ||
                          EXT3_HAS_INCOMPAT_FEATURE(sb,
@@ -1489,7 +1647,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
         */
        if (!test_opt(sb, NOLOAD) &&
            EXT3_HAS_COMPAT_FEATURE(sb, EXT3_FEATURE_COMPAT_HAS_JOURNAL)) {
-               if (ext3_load_journal(sb, es))
+               if (ext3_load_journal(sb, es, journal_devnum))
                        goto failed_mount2;
        } else if (journal_inum) {
                if (ext3_create_journal(sb, es, journal_inum))
@@ -1528,6 +1686,13 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
                break;
        }
 
+       if (test_opt(sb, NOBH)) {
+               if (!(test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_WRITEBACK_DATA)) {
+                       printk(KERN_WARNING "EXT3-fs: Ignoring nobh option - "
+                               "its supported only with writeback mode\n");
+                       clear_opt(sbi->s_mount_opt, NOBH);
+               }
+       }
        /*
         * The journal_load will have done any necessary log recovery,
         * so we can safely mount the rest of the filesystem now.
@@ -1574,27 +1739,32 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
        percpu_counter_mod(&sbi->s_dirs_counter,
                ext3_count_dirs(sb));
 
+       lock_kernel();
        return 0;
 
+cantfind_ext3:
+       if (!silent)
+               printk(KERN_ERR "VFS: Can't find ext3 filesystem on dev %s.\n",
+                      sb->s_id);
+       goto failed_mount;
+
 failed_mount3:
        journal_destroy(sbi->s_journal);
 failed_mount2:
-       kfree(sbi->s_debts);
        for (i = 0; i < db_count; i++)
                brelse(sbi->s_group_desc[i]);
        kfree(sbi->s_group_desc);
 failed_mount:
 #ifdef CONFIG_QUOTA
-       for (i = 0; i < MAXQUOTAS; i++) {
-               if (sbi->s_qf_names[i])
-                       kfree(sbi->s_qf_names[i]);
-       }
+       for (i = 0; i < MAXQUOTAS; i++)
+               kfree(sbi->s_qf_names[i]);
 #endif
        ext3_blkdev_remove(sbi);
        brelse(bh);
 out_fail:
        sb->s_fs_info = NULL;
        kfree(sbi);
+       lock_kernel();
        return -EINVAL;
 }
 
@@ -1603,16 +1773,23 @@ out_fail:
  * initial mount, once the journal has been initialised but before we've
  * done any recovery; and again on any subsequent remount. 
  */
-static void ext3_init_journal_params(struct ext3_sb_info *sbi, 
-                                    journal_t *journal)
+static void ext3_init_journal_params(struct super_block *sb, journal_t *journal)
 {
+       struct ext3_sb_info *sbi = EXT3_SB(sb);
+
        if (sbi->s_commit_interval)
                journal->j_commit_interval = sbi->s_commit_interval;
        /* We could also set up an ext3-specific default for the commit
         * interval here, but for now we'll just fall back to the jbd
         * default. */
-}
 
+       spin_lock(&journal->j_state_lock);
+       if (test_opt(sb, BARRIER))
+               journal->j_flags |= JFS_BARRIER;
+       else
+               journal->j_flags &= ~JFS_BARRIER;
+       spin_unlock(&journal->j_state_lock);
+}
 
 static journal_t *ext3_get_journal(struct super_block *sb, int journal_inum)
 {
@@ -1647,9 +1824,10 @@ static journal_t *ext3_get_journal(struct super_block *sb, int journal_inum)
        if (!journal) {
                printk(KERN_ERR "EXT3-fs: Could not load journal inode\n");
                iput(journal_inode);
+               return NULL;
        }
        journal->j_private = sb;
-       ext3_init_journal_params(EXT3_SB(sb), journal);
+       ext3_init_journal_params(sb, journal);
        return journal;
 }
 
@@ -1727,14 +1905,14 @@ static journal_t *ext3_get_dev_journal(struct super_block *sb,
                printk(KERN_ERR "EXT3-fs: I/O error on journal device\n");
                goto out_journal;
        }
-       if (ntohl(journal->j_superblock->s_nr_users) != 1) {
+       if (be32_to_cpu(journal->j_superblock->s_nr_users) != 1) {
                printk(KERN_ERR "EXT3-fs: External journal has more than one "
                                        "user (unsupported) - %d\n",
-                       ntohl(journal->j_superblock->s_nr_users));
+                       be32_to_cpu(journal->j_superblock->s_nr_users));
                goto out_journal;
        }
        EXT3_SB(sb)->journal_bdev = bdev;
-       ext3_init_journal_params(EXT3_SB(sb), journal);
+       ext3_init_journal_params(sb, journal);
        return journal;
 out_journal:
        journal_destroy(journal);
@@ -1743,15 +1921,24 @@ out_bdev:
        return NULL;
 }
 
-static int ext3_load_journal(struct super_block * sb,
-                            struct ext3_super_block * es)
+static int ext3_load_journal(struct super_block *sb,
+                            struct ext3_super_block *es,
+                            unsigned long journal_devnum)
 {
        journal_t *journal;
        int journal_inum = le32_to_cpu(es->s_journal_inum);
-       dev_t journal_dev = new_decode_dev(le32_to_cpu(es->s_journal_dev));
+       dev_t journal_dev;
        int err = 0;
        int really_read_only;
 
+       if (journal_devnum &&
+           journal_devnum != le32_to_cpu(es->s_journal_dev)) {
+               printk(KERN_INFO "EXT3-fs: external journal device major/minor "
+                       "numbers have changed\n");
+               journal_dev = new_decode_dev(journal_devnum);
+       } else
+               journal_dev = new_decode_dev(le32_to_cpu(es->s_journal_dev));
+
        really_read_only = bdev_read_only(sb->s_bdev);
 
        /*
@@ -1810,6 +1997,16 @@ static int ext3_load_journal(struct super_block * sb,
 
        EXT3_SB(sb)->s_journal = journal;
        ext3_clear_journal_err(sb, es);
+
+       if (journal_devnum &&
+           journal_devnum != le32_to_cpu(es->s_journal_dev)) {
+               es->s_journal_dev = cpu_to_le32(journal_devnum);
+               sb->s_dirt = 1;
+
+               /* Make sure we flush the recovery flag to disk. */
+               ext3_commit_super(sb, es, 1);
+       }
+
        return 0;
 }
 
@@ -1878,13 +2075,17 @@ static void ext3_commit_super (struct super_block * sb,
 static void ext3_mark_recovery_complete(struct super_block * sb,
                                        struct ext3_super_block * es)
 {
-       journal_flush(EXT3_SB(sb)->s_journal);
+       journal_t *journal = EXT3_SB(sb)->s_journal;
+
+       journal_lock_updates(journal);
+       journal_flush(journal);
        if (EXT3_HAS_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER) &&
            sb->s_flags & MS_RDONLY) {
                EXT3_CLEAR_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER);
                sb->s_dirt = 0;
                ext3_commit_super(sb, es, 1);
        }
+       journal_unlock_updates(journal);
 }
 
 /*
@@ -1951,9 +2152,9 @@ int ext3_force_commit(struct super_block *sb)
  * This implicitly triggers the writebehind on sync().
  */
 
-void ext3_write_super (struct super_block * sb)
+static void ext3_write_super (struct super_block * sb)
 {
-       if (down_trylock(&sb->s_lock) == 0)
+       if (mutex_trylock(&sb->s_lock) != 0)
                BUG();
        sb->s_dirt = 0;
 }
@@ -1974,7 +2175,7 @@ static int ext3_sync_fs(struct super_block *sb, int wait)
  * LVM calls this function before a (read-only) snapshot is created.  This
  * gives us a chance to flush the journal completely and mark the fs clean.
  */
-void ext3_write_super_lockfs(struct super_block *sb)
+static void ext3_write_super_lockfs(struct super_block *sb)
 {
        sb->s_dirt = 0;
 
@@ -1995,7 +2196,7 @@ void ext3_write_super_lockfs(struct super_block *sb)
  * Called by LVM after the snapshot is done.  We need to reset the RECOVER
  * flag here, even though the filesystem is not technically dirty yet.
  */
-void ext3_unlockfs(struct super_block *sb)
+static void ext3_unlockfs(struct super_block *sb)
 {
        if (!(sb->s_flags & MS_RDONLY)) {
                lock_super(sb);
@@ -2007,31 +2208,60 @@ void ext3_unlockfs(struct super_block *sb)
        }
 }
 
-int ext3_remount (struct super_block * sb, int * flags, char * data)
+static int ext3_remount (struct super_block * sb, int * flags, char * data)
 {
        struct ext3_super_block * es;
        struct ext3_sb_info *sbi = EXT3_SB(sb);
-       unsigned long tmp;
+       unsigned long n_blocks_count = 0;
+       unsigned long old_sb_flags;
+       struct ext3_mount_options old_opts;
+       int err;
+#ifdef CONFIG_QUOTA
+       int i;
+#endif
+
+       /* Store the original options */
+       old_sb_flags = sb->s_flags;
+       old_opts.s_mount_opt = sbi->s_mount_opt;
+       old_opts.s_resuid = sbi->s_resuid;
+       old_opts.s_resgid = sbi->s_resgid;
+       old_opts.s_commit_interval = sbi->s_commit_interval;
+#ifdef CONFIG_QUOTA
+       old_opts.s_jquota_fmt = sbi->s_jquota_fmt;
+       for (i = 0; i < MAXQUOTAS; i++)
+               old_opts.s_qf_names[i] = sbi->s_qf_names[i];
+#endif
 
        /*
         * Allow the "check" option to be passed as a remount option.
         */
-       if (!parse_options(data, sb, &tmp, 1))
-               return -EINVAL;
+       if (!parse_options(data, sb, NULL, NULL, &n_blocks_count, 1)) {
+               err = -EINVAL;
+               goto restore_opts;
+       }
 
        if (sbi->s_mount_opt & EXT3_MOUNT_ABORT)
                ext3_abort(sb, __FUNCTION__, "Abort forced by user");
+       if ((sbi->s_mount_opt & EXT3_MOUNT_TAGXID) &&
+               !(sb->s_flags & MS_TAGXID)) {
+               printk("EXT3-fs: %s: tagxid not permitted on remount.\n",
+                       sb->s_id);
+               return -EINVAL;
+       }
 
        sb->s_flags = (sb->s_flags & ~MS_POSIXACL) |
                ((sbi->s_mount_opt & EXT3_MOUNT_POSIX_ACL) ? MS_POSIXACL : 0);
 
        es = sbi->s_es;
 
-       ext3_init_journal_params(sbi, sbi->s_journal);
+       ext3_init_journal_params(sb, sbi->s_journal);
 
-       if ((*flags & MS_RDONLY) != (sb->s_flags & MS_RDONLY)) {
-               if (sbi->s_mount_opt & EXT3_MOUNT_ABORT)
-                       return -EROFS;
+       if ((*flags & MS_RDONLY) != (sb->s_flags & MS_RDONLY) ||
+               n_blocks_count > le32_to_cpu(es->s_blocks_count)) {
+               if (sbi->s_mount_opt & EXT3_MOUNT_ABORT) {
+                       err = -EROFS;
+                       goto restore_opts;
+               }
 
                if (*flags & MS_RDONLY) {
                        /*
@@ -2051,14 +2281,15 @@ int ext3_remount (struct super_block * sb, int * flags, char * data)
 
                        ext3_mark_recovery_complete(sb, es);
                } else {
-                       int ret;
+                       __le32 ret;
                        if ((ret = EXT3_HAS_RO_COMPAT_FEATURE(sb,
                                        ~EXT3_FEATURE_RO_COMPAT_SUPP))) {
                                printk(KERN_WARNING "EXT3-fs: %s: couldn't "
                                       "remount RDWR because of unsupported "
                                       "optional features (%x).\n",
-                                      sb->s_id, ret);
-                               return -EROFS;
+                                      sb->s_id, le32_to_cpu(ret));
+                               err = -EROFS;
+                               goto restore_opts;
                        }
                        /*
                         * Mounting a RDONLY partition read-write, so reread
@@ -2068,22 +2299,54 @@ int ext3_remount (struct super_block * sb, int * flags, char * data)
                         */
                        ext3_clear_journal_err(sb, es);
                        sbi->s_mount_state = le16_to_cpu(es->s_state);
+                       if ((ret = ext3_group_extend(sb, es, n_blocks_count))) {
+                               err = ret;
+                               goto restore_opts;
+                       }
                        if (!ext3_setup_super (sb, es, 0))
                                sb->s_flags &= ~MS_RDONLY;
                }
        }
+#ifdef CONFIG_QUOTA
+       /* Release old quota file names */
+       for (i = 0; i < MAXQUOTAS; i++)
+               if (old_opts.s_qf_names[i] &&
+                   old_opts.s_qf_names[i] != sbi->s_qf_names[i])
+                       kfree(old_opts.s_qf_names[i]);
+#endif
        return 0;
+restore_opts:
+       sb->s_flags = old_sb_flags;
+       sbi->s_mount_opt = old_opts.s_mount_opt;
+       sbi->s_resuid = old_opts.s_resuid;
+       sbi->s_resgid = old_opts.s_resgid;
+       sbi->s_commit_interval = old_opts.s_commit_interval;
+#ifdef CONFIG_QUOTA
+       sbi->s_jquota_fmt = old_opts.s_jquota_fmt;
+       for (i = 0; i < MAXQUOTAS; i++) {
+               if (sbi->s_qf_names[i] &&
+                   old_opts.s_qf_names[i] != sbi->s_qf_names[i])
+                       kfree(sbi->s_qf_names[i]);
+               sbi->s_qf_names[i] = old_opts.s_qf_names[i];
+       }
+#endif
+       return err;
 }
 
-int ext3_statfs (struct super_block * sb, struct kstatfs * buf)
+static int ext3_statfs (struct super_block * sb, struct kstatfs * buf)
 {
-       struct ext3_super_block *es = EXT3_SB(sb)->s_es;
+       struct ext3_sb_info *sbi = EXT3_SB(sb);
+       struct ext3_super_block *es = sbi->s_es;
        unsigned long overhead;
        int i;
 
        if (test_opt (sb, MINIX_DF))
                overhead = 0;
        else {
+               unsigned long ngroups;
+               ngroups = EXT3_SB(sb)->s_groups_count;
+               smp_rmb();
+
                /*
                 * Compute the overhead (FS structures)
                 */
@@ -2099,27 +2362,28 @@ int ext3_statfs (struct super_block * sb, struct kstatfs * buf)
                 * block group descriptors.  If the sparse superblocks
                 * feature is turned on, then not all groups have this.
                 */
-               for (i = 0; i < EXT3_SB(sb)->s_groups_count; i++)
+               for (i = 0; i < ngroups; i++) {
                        overhead += ext3_bg_has_super(sb, i) +
                                ext3_bg_num_gdb(sb, i);
+                       cond_resched();
+               }
 
                /*
                 * Every block group has an inode bitmap, a block
                 * bitmap, and an inode table.
                 */
-               overhead += (EXT3_SB(sb)->s_groups_count *
-                            (2 + EXT3_SB(sb)->s_itb_per_group));
+               overhead += (ngroups * (2 + EXT3_SB(sb)->s_itb_per_group));
        }
 
        buf->f_type = EXT3_SUPER_MAGIC;
        buf->f_bsize = sb->s_blocksize;
        buf->f_blocks = le32_to_cpu(es->s_blocks_count) - overhead;
-       buf->f_bfree = ext3_count_free_blocks (sb);
+       buf->f_bfree = percpu_counter_sum(&sbi->s_freeblocks_counter);
        buf->f_bavail = buf->f_bfree - le32_to_cpu(es->s_r_blocks_count);
        if (buf->f_bfree < le32_to_cpu(es->s_r_blocks_count))
                buf->f_bavail = 0;
        buf->f_files = le32_to_cpu(es->s_inodes_count);
-       buf->f_ffree = ext3_count_free_inodes (sb);
+       buf->f_ffree = percpu_counter_sum(&sbi->s_freeinodes_counter);
        buf->f_namelen = EXT3_NAME_LEN;
        return 0;
 }
@@ -2129,8 +2393,8 @@ int ext3_statfs (struct super_block * sb, struct kstatfs * buf)
  * Process 1                         Process 2
  * ext3_create()                     quota_sync()
  *   journal_start()                   write_dquot()
- *   DQUOT_INIT()                        down(dqio_sem)
- *     down(dqio_sem)                    journal_start()
+ *   DQUOT_INIT()                        down(dqio_mutex)
+ *     down(dqio_mutex)                    journal_start()
  *
  */
 
@@ -2138,7 +2402,7 @@ int ext3_statfs (struct super_block * sb, struct kstatfs * buf)
 
 static inline struct inode *dquot_to_inode(struct dquot *dquot)
 {
-       return sb_dqopt(dquot->dq_sb)->files[dquot->dq_type]->f_dentry->d_inode;
+       return sb_dqopt(dquot->dq_sb)->files[dquot->dq_type];
 }
 
 static int ext3_dquot_initialize(struct inode *inode, int type)
@@ -2147,7 +2411,7 @@ static int ext3_dquot_initialize(struct inode *inode, int type)
        int ret, err;
 
        /* We may create quota structure so we need to reserve enough blocks */
-       handle = ext3_journal_start(inode, 2*EXT3_QUOTA_INIT_BLOCKS);
+       handle = ext3_journal_start(inode, 2*EXT3_QUOTA_INIT_BLOCKS(inode->i_sb));
        if (IS_ERR(handle))
                return PTR_ERR(handle);
        ret = dquot_initialize(inode, type);
@@ -2163,7 +2427,7 @@ static int ext3_dquot_drop(struct inode *inode)
        int ret, err;
 
        /* We may delete quota structure so we need to reserve enough blocks */
-       handle = ext3_journal_start(inode, 2*EXT3_QUOTA_INIT_BLOCKS);
+       handle = ext3_journal_start(inode, 2*EXT3_QUOTA_DEL_BLOCKS(inode->i_sb));
        if (IS_ERR(handle))
                return PTR_ERR(handle);
        ret = dquot_drop(inode);
@@ -2177,9 +2441,11 @@ static int ext3_write_dquot(struct dquot *dquot)
 {
        int ret, err;
        handle_t *handle;
+       struct inode *inode;
 
-       handle = ext3_journal_start(dquot_to_inode(dquot),
-                                       EXT3_QUOTA_TRANS_BLOCKS);
+       inode = dquot_to_inode(dquot);
+       handle = ext3_journal_start(inode,
+                                       EXT3_QUOTA_TRANS_BLOCKS(dquot->dq_sb));
        if (IS_ERR(handle))
                return PTR_ERR(handle);
        ret = dquot_commit(dquot);
@@ -2189,6 +2455,38 @@ static int ext3_write_dquot(struct dquot *dquot)
        return ret;
 }
 
+static int ext3_acquire_dquot(struct dquot *dquot)
+{
+       int ret, err;
+       handle_t *handle;
+
+       handle = ext3_journal_start(dquot_to_inode(dquot),
+                                       EXT3_QUOTA_INIT_BLOCKS(dquot->dq_sb));
+       if (IS_ERR(handle))
+               return PTR_ERR(handle);
+       ret = dquot_acquire(dquot);
+       err = ext3_journal_stop(handle);
+       if (!ret)
+               ret = err;
+       return ret;
+}
+
+static int ext3_release_dquot(struct dquot *dquot)
+{
+       int ret, err;
+       handle_t *handle;
+
+       handle = ext3_journal_start(dquot_to_inode(dquot),
+                                       EXT3_QUOTA_DEL_BLOCKS(dquot->dq_sb));
+       if (IS_ERR(handle))
+               return PTR_ERR(handle);
+       ret = dquot_release(dquot);
+       err = ext3_journal_stop(handle);
+       if (!ret)
+               ret = err;
+       return ret;
+}
+
 static int ext3_mark_dquot_dirty(struct dquot *dquot)
 {
        /* Are we journalling quotas? */
@@ -2223,35 +2521,8 @@ static int ext3_write_info(struct super_block *sb, int type)
  */
 static int ext3_quota_on_mount(struct super_block *sb, int type)
 {
-       int err;
-       struct dentry *dentry;
-       struct qstr name = { .name = EXT3_SB(sb)->s_qf_names[type],
-                            .hash = 0,
-                            .len = strlen(EXT3_SB(sb)->s_qf_names[type])};
-
-       dentry = lookup_hash(&name, sb->s_root);
-       if (IS_ERR(dentry))
-               return PTR_ERR(dentry);
-       err = vfs_quota_on_mount(type, EXT3_SB(sb)->s_jquota_fmt, dentry);
-       if (err)
-               dput(dentry);
-       /* We keep the dentry reference if everything went ok - we drop it
-        * on quota_off time */
-       return err;
-}
-
-/* Turn quotas off during mount time */
-static int ext3_quota_off_mount(struct super_block *sb, int type)
-{
-       int err;
-       struct dentry *dentry;
-
-       dentry = sb_dqopt(sb)->files[type]->f_dentry;
-       err = vfs_quota_off_mount(sb, type);
-       /* We invalidate dentry - it has at least wrong hash... */
-       d_invalidate(dentry);
-       dput(dentry);
-       return err;
+       return vfs_quota_on_mount(sb, EXT3_SB(sb)->s_qf_names[type],
+                       EXT3_SB(sb)->s_jquota_fmt, type);
 }
 
 /*
@@ -2263,6 +2534,8 @@ static int ext3_quota_on(struct super_block *sb, int type, int format_id,
        int err;
        struct nameidata nd;
 
+       if (!test_opt(sb, QUOTA))
+               return -EINVAL;
        /* Not journalling quota? */
        if (!EXT3_SB(sb)->s_qf_names[USRQUOTA] &&
            !EXT3_SB(sb)->s_qf_names[GRPQUOTA])
@@ -2271,20 +2544,121 @@ static int ext3_quota_on(struct super_block *sb, int type, int format_id,
        if (err)
                return err;
        /* Quotafile not on the same filesystem? */
-       if (nd.mnt->mnt_sb != sb)
+       if (nd.mnt->mnt_sb != sb) {
+               path_release(&nd);
                return -EXDEV;
+       }
        /* Quotafile not of fs root? */
        if (nd.dentry->d_parent->d_inode != sb->s_root->d_inode)
                printk(KERN_WARNING
                        "EXT3-fs: Quota file not on filesystem root. "
                        "Journalled quota will not work.\n");
-       if (!ext3_should_journal_data(nd.dentry->d_inode))
-               printk(KERN_WARNING "EXT3-fs: Quota file does not have "
-                       "data-journalling. Journalled quota will not work.\n");
        path_release(&nd);
        return vfs_quota_on(sb, type, format_id, path);
 }
 
+/* Read data from quotafile - avoid pagecache and such because we cannot afford
+ * acquiring the locks... As quota files are never truncated and quota code
+ * itself serializes the operations (and noone else should touch the files)
+ * we don't have to be afraid of races */
+static ssize_t ext3_quota_read(struct super_block *sb, int type, char *data,
+                              size_t len, loff_t off)
+{
+       struct inode *inode = sb_dqopt(sb)->files[type];
+       sector_t blk = off >> EXT3_BLOCK_SIZE_BITS(sb);
+       int err = 0;
+       int offset = off & (sb->s_blocksize - 1);
+       int tocopy;
+       size_t toread;
+       struct buffer_head *bh;
+       loff_t i_size = i_size_read(inode);
+
+       if (off > i_size)
+               return 0;
+       if (off+len > i_size)
+               len = i_size-off;
+       toread = len;
+       while (toread > 0) {
+               tocopy = sb->s_blocksize - offset < toread ?
+                               sb->s_blocksize - offset : toread;
+               bh = ext3_bread(NULL, inode, blk, 0, &err);
+               if (err)
+                       return err;
+               if (!bh)        /* A hole? */
+                       memset(data, 0, tocopy);
+               else
+                       memcpy(data, bh->b_data+offset, tocopy);
+               brelse(bh);
+               offset = 0;
+               toread -= tocopy;
+               data += tocopy;
+               blk++;
+       }
+       return len;
+}
+
+/* Write to quotafile (we know the transaction is already started and has
+ * enough credits) */
+static ssize_t ext3_quota_write(struct super_block *sb, int type,
+                               const char *data, size_t len, loff_t off)
+{
+       struct inode *inode = sb_dqopt(sb)->files[type];
+       sector_t blk = off >> EXT3_BLOCK_SIZE_BITS(sb);
+       int err = 0;
+       int offset = off & (sb->s_blocksize - 1);
+       int tocopy;
+       int journal_quota = EXT3_SB(sb)->s_qf_names[type] != NULL;
+       size_t towrite = len;
+       struct buffer_head *bh;
+       handle_t *handle = journal_current_handle();
+
+       mutex_lock(&inode->i_mutex);
+       while (towrite > 0) {
+               tocopy = sb->s_blocksize - offset < towrite ?
+                               sb->s_blocksize - offset : towrite;
+               bh = ext3_bread(handle, inode, blk, 1, &err);
+               if (!bh)
+                       goto out;
+               if (journal_quota) {
+                       err = ext3_journal_get_write_access(handle, bh);
+                       if (err) {
+                               brelse(bh);
+                               goto out;
+                       }
+               }
+               lock_buffer(bh);
+               memcpy(bh->b_data+offset, data, tocopy);
+               flush_dcache_page(bh->b_page);
+               unlock_buffer(bh);
+               if (journal_quota)
+                       err = ext3_journal_dirty_metadata(handle, bh);
+               else {
+                       /* Always do at least ordered writes for quotas */
+                       err = ext3_journal_dirty_data(handle, bh);
+                       mark_buffer_dirty(bh);
+               }
+               brelse(bh);
+               if (err)
+                       goto out;
+               offset = 0;
+               towrite -= tocopy;
+               data += tocopy;
+               blk++;
+       }
+out:
+       if (len == towrite)
+               return err;
+       if (inode->i_size < off+len-towrite) {
+               i_size_write(inode, off+len-towrite);
+               EXT3_I(inode)->i_disksize = inode->i_size;
+       }
+       inode->i_version++;
+       inode->i_mtime = inode->i_ctime = CURRENT_TIME;
+       ext3_mark_inode_dirty(handle, inode);
+       mutex_unlock(&inode->i_mutex);
+       return len - towrite;
+}
+
 #endif
 
 static struct super_block *ext3_get_sb(struct file_system_type *fs_type,