ofproto: Fix potential leak during flow mods.

[sliver-openvswitch.git] / lib / memory.c

diff --git a/lib/memory.c b/lib/memory.c
index c26c743..6c97e19 100644 (file)
--- a/lib/memory.c
+++ b/lib/memory.c
@@ -51,7 +51,10 @@ static void memory_init(void);
 
 /* Runs the memory monitor.
  *
- * The client should call memory_should_report() afterward. */
+ * The client should call memory_should_report() afterward.
+ *
+ * This function, and the remainder of this module's interface, should be
+ * called from only a single thread. */
 void
 memory_run(void)
 {
@@ -137,8 +140,10 @@ memory_report(const struct simap *usage)
     ds_init(&s);
     compose_report(usage, &s);
 
-    if (want_report && s.length) {
-        VLOG_INFO("%s", ds_cstr(&s));
+    if (want_report) {
+        if (s.length) {
+            VLOG_INFO("%s", ds_cstr(&s));
+        }
         want_report = false;
     }
     if (n_conns) {