{
int num;
void *buf;
- size_t size;
+ size_t size = maxnum * sizeof(struct __fdb_entry);
- /* Clamp size to PAGE_SIZE, test maxnum to avoid overflow */
- if (maxnum > PAGE_SIZE/sizeof(struct __fdb_entry))
+ if (size > PAGE_SIZE) {
+ size = PAGE_SIZE;
maxnum = PAGE_SIZE/sizeof(struct __fdb_entry);
-
- size = maxnum * sizeof(struct __fdb_entry);
+ }
buf = kmalloc(size, GFP_USER);
if (!buf)
if (num > BR_MAX_PORTS)
num = BR_MAX_PORTS;
- indices = kcalloc(num, sizeof(int), GFP_KERNEL);
+ indices = kmalloc(num*sizeof(int), GFP_KERNEL);
if (indices == NULL)
return -ENOMEM;
+ memset(indices, 0, num*sizeof(int));
+
get_port_ifindices(br, indices, num);
if (copy_to_user((void __user *)args[1], indices, num*sizeof(int)))
num = -EFAULT;
if (args[2] >= 2048)
return -ENOMEM;
- indices = kcalloc(args[2], sizeof(int), GFP_KERNEL);
+ indices = kmalloc(args[2]*sizeof(int), GFP_KERNEL);
if (indices == NULL)
return -ENOMEM;
+ memset(indices, 0, args[2]*sizeof(int));
args[2] = get_bridge_ifindices(indices, args[2]);
ret = copy_to_user((void __user *)args[1], indices, args[2]*sizeof(int))