Merge "master" into "wdp".
[sliver-openvswitch.git] / ofproto / ofproto-sflow.c
index 076bd79..3724911 100644 (file)
 #include <inttypes.h>
 #include <stdlib.h>
 #include "collectors.h"
-#include "dpif.h"
 #include "compiler.h"
 #include "hash.h"
 #include "hmap.h"
 #include "netdev.h"
 #include "ofpbuf.h"
 #include "ofproto.h"
+#include "packets.h"
 #include "poll-loop.h"
 #include "sflow_api.h"
 #include "socket-util.h"
 #include "timeval.h"
 #include "vlog.h"
+#include "wdp.h"
+#include "xfif.h"
 
 VLOG_DEFINE_THIS_MODULE(sflow)
 
@@ -39,7 +41,7 @@ struct ofproto_sflow_port {
     struct hmap_node hmap_node; /* In struct ofproto_sflow's "ports" hmap. */
     struct netdev *netdev;      /* Underlying network device, for stats. */
     SFLDataSource_instance dsi; /* sFlow library's notion of port number. */
-    uint16_t odp_port;          /* ODP port number. */
+    uint16_t xflow_port;        /* xflow port number. */
 };
 
 struct ofproto_sflow {
@@ -47,7 +49,7 @@ struct ofproto_sflow {
     struct collectors *collectors;
     SFLAgent *sflow_agent;
     struct ofproto_sflow_options *options;
-    struct dpif *dpif;
+    struct wdp *wdp;
     time_t next_tick;
     size_t n_flood, n_all;
     struct hmap ports;          /* Contains "struct ofproto_sflow_port"s. */
@@ -136,13 +138,13 @@ sflow_agent_send_packet_cb(void *os_, SFLAgent *agent OVS_UNUSED,
 }
 
 static struct ofproto_sflow_port *
-ofproto_sflow_find_port(const struct ofproto_sflow *os, uint16_t odp_port)
+ofproto_sflow_find_port(const struct ofproto_sflow *os, uint16_t xflow_port)
 {
     struct ofproto_sflow_port *osp;
 
-    HMAP_FOR_EACH_IN_BUCKET (osp, struct ofproto_sflow_port, hmap_node,
-                             hash_int(odp_port, 0), &os->ports) {
-        if (osp->odp_port == odp_port) {
+    HMAP_FOR_EACH_IN_BUCKET (osp, hmap_node,
+                             hash_int(xflow_port, 0), &os->ports) {
+        if (osp->xflow_port == xflow_port) {
             return osp;
         }
     }
@@ -269,7 +271,7 @@ ofproto_sflow_clear(struct ofproto_sflow *os)
     os->options = NULL;
 
     /* Turn off sampling to save CPU cycles. */
-    dpif_set_sflow_probability(os->dpif, 0);
+    wdp_set_sflow_probability(os->wdp, 0);
 }
 
 bool
@@ -279,12 +281,12 @@ ofproto_sflow_is_enabled(const struct ofproto_sflow *os)
 }
 
 struct ofproto_sflow *
-ofproto_sflow_create(struct dpif *dpif)
+ofproto_sflow_create(struct wdp *wdp)
 {
     struct ofproto_sflow *os;
 
     os = xcalloc(1, sizeof *os);
-    os->dpif = dpif;
+    os->wdp = wdp;
     os->next_tick = time_now() + 1;
     hmap_init(&os->ports);
     return os;
@@ -297,8 +299,7 @@ ofproto_sflow_destroy(struct ofproto_sflow *os)
         struct ofproto_sflow_port *osp, *next;
 
         ofproto_sflow_clear(os);
-        HMAP_FOR_EACH_SAFE (osp, next, struct ofproto_sflow_port, hmap_node,
-                            &os->ports) {
+        HMAP_FOR_EACH_SAFE (osp, next, hmap_node, &os->ports) {
             ofproto_sflow_del_port__(os, osp);
         }
         hmap_destroy(&os->ports);
@@ -308,13 +309,13 @@ ofproto_sflow_destroy(struct ofproto_sflow *os)
 
 static void
 ofproto_sflow_add_poller(struct ofproto_sflow *os,
-                         struct ofproto_sflow_port *osp, uint16_t odp_port)
+                         struct ofproto_sflow_port *osp, uint16_t xflow_port)
 {
     SFLPoller *poller = sfl_agent_addPoller(os->sflow_agent, &osp->dsi, os,
                                             sflow_agent_get_counters);
     sfl_poller_set_sFlowCpInterval(poller, os->options->polling_interval);
     sfl_poller_set_sFlowCpReceiver(poller, RECEIVER_INDEX);
-    sfl_poller_set_bridgePort(poller, odp_port);
+    sfl_poller_set_bridgePort(poller, xflow_port);
 }
 
 static void
@@ -328,7 +329,7 @@ ofproto_sflow_add_sampler(struct ofproto_sflow *os,
 }
 
 void
-ofproto_sflow_add_port(struct ofproto_sflow *os, uint16_t odp_port,
+ofproto_sflow_add_port(struct ofproto_sflow *os, uint16_t xflow_port,
                        const char *netdev_name)
 {
     struct ofproto_sflow_port *osp;
@@ -336,7 +337,7 @@ ofproto_sflow_add_port(struct ofproto_sflow *os, uint16_t odp_port,
     uint32_t ifindex;
     int error;
 
-    ofproto_sflow_del_port(os, odp_port);
+    ofproto_sflow_del_port(os, xflow_port);
 
     /* Open network device. */
     error = netdev_open_default(netdev_name, &netdev);
@@ -351,15 +352,15 @@ ofproto_sflow_add_port(struct ofproto_sflow *os, uint16_t odp_port,
     osp->netdev = netdev;
     ifindex = netdev_get_ifindex(netdev);
     if (ifindex <= 0) {
-        ifindex = (os->sflow_agent->subId << 16) + odp_port;
+        ifindex = (os->sflow_agent->subId << 16) + xflow_port;
     }
     SFL_DS_SET(osp->dsi, 0, ifindex, 0);
-    osp->odp_port = odp_port;
-    hmap_insert(&os->ports, &osp->hmap_node, hash_int(odp_port, 0));
+    osp->xflow_port = xflow_port;
+    hmap_insert(&os->ports, &osp->hmap_node, hash_int(xflow_port, 0));
 
     /* Add poller and sampler. */
     if (os->sflow_agent) {
-        ofproto_sflow_add_poller(os, osp, odp_port);
+        ofproto_sflow_add_poller(os, osp, xflow_port);
         ofproto_sflow_add_sampler(os, osp);
     }
 }
@@ -378,9 +379,9 @@ ofproto_sflow_del_port__(struct ofproto_sflow *os,
 }
 
 void
-ofproto_sflow_del_port(struct ofproto_sflow *os, uint16_t odp_port)
+ofproto_sflow_del_port(struct ofproto_sflow *os, uint16_t xflow_port)
 {
-    struct ofproto_sflow_port *osp = ofproto_sflow_find_port(os, odp_port);
+    struct ofproto_sflow_port *osp = ofproto_sflow_find_port(os, xflow_port);
     if (osp) {
         ofproto_sflow_del_port__(os, osp);
     }
@@ -459,48 +460,48 @@ ofproto_sflow_set_options(struct ofproto_sflow *os,
     sfl_receiver_set_sFlowRcvrTimeout(receiver, 0xffffffff);
 
     /* Set the sampling_rate down in the datapath. */
-    dpif_set_sflow_probability(os->dpif,
-                               MAX(1, UINT32_MAX / options->sampling_rate));
+    wdp_set_sflow_probability(os->wdp,
+                              MAX(1, UINT32_MAX / options->sampling_rate));
 
     /* Add samplers and pollers for the currently known ports. */
-    HMAP_FOR_EACH (osp, struct ofproto_sflow_port, hmap_node, &os->ports) {
-        ofproto_sflow_add_poller(os, osp, osp->odp_port);
+    HMAP_FOR_EACH (osp, hmap_node, &os->ports) {
+        ofproto_sflow_add_poller(os, osp, osp->xflow_port);
         ofproto_sflow_add_sampler(os, osp);
     }
 }
 
 static int
-ofproto_sflow_odp_port_to_ifindex(const struct ofproto_sflow *os,
-                                  uint16_t odp_port)
+ofproto_sflow_xflow_port_to_ifindex(const struct ofproto_sflow *os,
+                                    uint16_t xflow_port)
 {
-    struct ofproto_sflow_port *osp = ofproto_sflow_find_port(os, odp_port);
+    struct ofproto_sflow_port *osp = ofproto_sflow_find_port(os, xflow_port);
     return osp ? SFL_DS_INDEX(osp->dsi) : 0;
 }
 
 void
-ofproto_sflow_received(struct ofproto_sflow *os, struct odp_msg *msg)
+ofproto_sflow_received(struct ofproto_sflow *os, struct xflow_msg *msg)
 {
     SFL_FLOW_SAMPLE_TYPE fs;
     SFLFlow_sample_element hdrElem;
     SFLSampled_header *header;
     SFLFlow_sample_element switchElem;
     SFLSampler *sampler;
-    const struct odp_sflow_sample_header *hdr;
-    const union odp_action *actions;
+    const struct xflow_sflow_sample_header *hdr;
+    const union xflow_action *actions;
     struct ofpbuf payload;
     size_t n_actions, n_outputs;
     size_t min_size;
     flow_t flow;
     size_t i;
 
-    /* Get odp_sflow_sample_header. */
+    /* Get xflow_sflow_sample_header. */
     min_size = sizeof *msg + sizeof *hdr;
     if (min_size > msg->length) {
         VLOG_WARN_RL(&rl, "sFlow packet too small (%"PRIu32" < %zu)",
                      msg->length, min_size);
         return;
     }
-    hdr = (const struct odp_sflow_sample_header *) (msg + 1);
+    hdr = (const struct xflow_sflow_sample_header *) (msg + 1);
 
     /* Get actions. */
     n_actions = hdr->n_actions;
@@ -516,16 +517,16 @@ ofproto_sflow_received(struct ofproto_sflow *os, struct odp_msg *msg)
                      n_actions, msg->length, min_size);
         return;
     }
-    actions = (const union odp_action *) (hdr + 1);
+    actions = (const union xflow_action *) (hdr + 1);
 
     /* Get packet payload and extract flow. */
-    payload.data = (union odp_action *) (actions + n_actions);
+    payload.data = (union xflow_action *) (actions + n_actions);
     payload.size = msg->length - min_size;
     flow_extract(&payload, 0, msg->port, &flow);
 
     /* Build a flow sample */
     memset(&fs, 0, sizeof fs);
-    fs.input = ofproto_sflow_odp_port_to_ifindex(os, msg->port);
+    fs.input = ofproto_sflow_xflow_port_to_ifindex(os, msg->port);
     fs.output = 0;              /* Filled in correctly below. */
     fs.sample_pool = hdr->sample_pool;
 
@@ -566,26 +567,29 @@ ofproto_sflow_received(struct ofproto_sflow *os, struct odp_msg *msg)
     /* Figure out the output ports. */
     n_outputs = 0;
     for (i = 0; i < n_actions; i++) {
-        const union odp_action *a = &actions[i];
+        const union xflow_action *a = &actions[i];
 
         switch (a->type) {
-        case ODPAT_OUTPUT:
-            fs.output = ofproto_sflow_odp_port_to_ifindex(os, a->output.port);
+        case XFLOWAT_OUTPUT:
+            fs.output = ofproto_sflow_xflow_port_to_ifindex(os, a->output.port);
             n_outputs++;
             break;
 
-        case ODPAT_OUTPUT_GROUP:
+        case XFLOWAT_OUTPUT_GROUP:
+#if 0
             n_outputs += (a->output_group.group == DP_GROUP_FLOOD ? os->n_flood
                           : a->output_group.group == DP_GROUP_ALL ? os->n_all
                           : 0);
+#endif
             break;
 
-        case ODPAT_SET_VLAN_VID:
-            switchElem.flowType.sw.dst_vlan = ntohs(a->vlan_vid.vlan_vid);
-            break;
-
-        case ODPAT_SET_VLAN_PCP:
-            switchElem.flowType.sw.dst_priority = a->vlan_pcp.vlan_pcp;
+        case XFLOWAT_SET_DL_TCI:
+            if (a->dl_tci.mask & htons(VLAN_VID_MASK)) {
+                switchElem.flowType.sw.dst_vlan = vlan_tci_to_vid(a->dl_tci.tci);
+            }
+            if (a->dl_tci.mask & htons(VLAN_PCP_MASK)) {
+                switchElem.flowType.sw.dst_priority = vlan_tci_to_pcp(a->dl_tci.tci);
+            }
             break;
 
         default: