details can be updated inline - old forms still to be cleaned up
[plewww.git] / planetlab / persons / person.php
index 3a83228..6331398 100644 (file)
@@ -15,6 +15,7 @@ include 'plc_header.php';
 
 // Common functions
 require_once 'plc_functions.php';
+require_once 'plc_peers.php';
 require_once 'plc_minitabs.php';
 require_once 'plc_tables.php';
 require_once 'plc_details.php';
@@ -57,38 +58,39 @@ $slice_ids= $person['slice_ids'];
 $key_ids= $person['key_ids'];
 
 // gets more data from API calls
-$sites= $api->GetSites( $site_ids, array( "site_id", "name", "login_base" ) );
+$site_columns=array( "site_id", "name", "login_base" );
+$sites= $api->GetSites( $site_ids, $site_columns);
 $slices= $api->GetSlices( $slice_ids, array( "slice_id", "name" ) );
 $keys= $api->GetKeys( $key_ids );
 
 drupal_set_title("Details for account " . $first_name . " " . $last_name);
+$local_peer = ! $peer_id;
 
-$plc_hash=plc_peer_get_hash($api);
+$peers = new Peers ($api);
 
-$local_peer = plc_peer_block_start ($peer_hash,$peer_id);
 $is_my_account = plc_my_person_id() == $person_id;
 $privileges = plc_is_admin () || ( plc_in_site($site_id) && plc_is_pi());
 
 $tabs=array();
 
 // update
-if ($privileges || $is_my_account) 
-  $tabs['Update'] = array('url'=>'/db/persons/update.php',
-                         'values'=>array('id'=>$person_id),
-                         'bubble'=>"Update $first_name $last_name");
-  
+//if ($privileges || $is_my_account) 
+//  $tabs['Update'] = array('url'=>'/db/persons/update.php',
+//                       'values'=>array('id'=>$person_id),
+//                       'bubble'=>"Update $first_name $last_name");
+//  
 // enable / disable
 if ($local_peer && $privileges) 
   if ($enabled) 
     $tabs['Disable'] = array ('method'=>'POST',
-                             'url'=>l_person_actions(),
+                             'url'=>l_actions(),
                              'values'=> array ('person_id'=>$person_id,
                                                'action'=>'disable-person'),
                              'bubble'=>"Disable $first_name $last_name",
                              'confirm'=>"Are you sure you want to disable $first_name $last_name");
   else 
     $tabs['Enable'] = array ('method'=>'POST',
-                            'url'=>l_person_actions(),
+                            'url'=>l_actions(),
                             'values'=> array ('person_id'=>$person_id,
                                               'action'=>'enable-person'),
                             'bubble'=>"Enable $first_name $last_name",
@@ -96,7 +98,8 @@ if ($local_peer && $privileges)
 
 // become
 if (plc_is_admin() && ! $is_my_account) 
-  $tabs['Become'] = array('url'=>l_person_actions(),
+  $tabs['Become'] = array('method'=>'POST',
+                         'url'=>l_actions(),
                          'values'=>array('action'=>'become-person',
                                          'person_id'=>$person_id),
                          'bubble'=>"Become $first_name $last_name",
@@ -105,7 +108,7 @@ if (plc_is_admin() && ! $is_my_account)
 // delete
 if ($local_peer && $privileges) 
   $tabs['Delete'] = array ('method'=>'POST',
-                          'url'=>l_person_actions(),
+                          'url'=>l_actions(),
                           'values'=> array ('person_id'=>$person_id,
                                             'action'=>'delete-person'),
                           'bubble'=>"Delete $first_name $last_name",
@@ -115,8 +118,7 @@ if ( $privileges)
   $tabs['Events'] = array('url'=>l_events(),
                          'values'=>array('type'=>'Person','person'=>$person_id),
                          'bubble'=>"Events about $first_name $last_name",
-                         'image'=>'/planetlab/icons/event.png',
-                         'height'=>18);
+                         'image'=>'/planetlab/icons/event.png','height'=>18);
 
 // Back button
 $tabs['All Users'] = array ('url'=>l_persons(),
@@ -124,206 +126,226 @@ $tabs['All Users'] = array ('url'=>l_persons(),
 
 plc_tabs($tabs);
     
+$peers->block_start ($peer_id);
+
 if ($local_peer && $privileges && ! $enabled ) 
   drupal_set_message ("$first_name $last_name is not enabled yet, you can enable her/him with the 'Enable' button below");
 
-$enabled_text="Enabled";
-if ( ! $enabled ) $enabled_text = plc_warning_div("Disabled");
+$enabled_label="Enabled";
+if ( ! $enabled ) $enabled_label = plc_warning_html("Disabled");
+
+$can_update = $is_my_account || plc_is_admin();
+$details = new PlcDetails($can_update);
+$details->start();
+$details->line("Enabled",$enabled_label);
+$details->space();
+$details->form_start(l_actions(),array("action"=>"update-person",
+                                      "person_id"=>$person_id));
+$details->line("Title",$title,"title");
+$details->line("First Name",$first_name,"first_name");
+$details->line("Last Name",$last_name,"last_name");
+$details->line(href("mailto:$email","Email"),$email,"email");
+$details->line("URL",$url,"url");
+$details->line("Phone",$phone,"phone");
+$details->line("Bio",wordwrap($bio,50,"<br/>"),"bio");
+// xxx need to check that this is working
+if ($can_update) {
+  $save=$details->set_input_type("password");
+  $details->line("Password","","password1");
+  $details->line("Repeat","","password2");
+  $details->set_input_type($save);
+ }
+// xxx need fields to reset password ?
+$details->line("",$details->submit_html("submit","Update Account"));
+$details->form_end();
 
-plc_details_start();
-plc_details_line("Enabled",$enabled_text);
-plc_details_line("First Name",$first_name);
-plc_details_line("Last Name",$last_name);
-plc_details_line("Email",href("mailto:$email",$email));
-plc_details_line("URL",$url);
-plc_details_line("Phone",$phone);
-plc_details_line("Title",$title);
-plc_details_line("Bio",wordwrap($bio,50,"<br/>"));
-plc_details_end();
+$details->line("Peer",$peers->peer_link($peer_id));
+$details->end();
 
 //////////////////// slices
-echo "<hr />\n";
-plc_table_title('Slices');
+plc_section('Slices');
 
-if( empty( $slices ) ) {
-  drupal_set_message ("User has no slice");
+if( ! $slices) {
+  plc_warning ("User has no slice");
  } else {
-  $columns=array('Slice name'=>'string');
-  $table_options=array('notes_area'=>false,
-                      'pagesize'=>5);
-  plc_table_start("person_slices",$columns,1,$table_options);
+  $headers=array('Slice name'=>'string');
+  $reasonable_page=5;
+  $table_options = array('notes_area'=>false,"search_width"=>10,'pagesize'=>$reasonable_page);
+  if (count ($slices) <= $reasonable_page) {
+    $table_options['search_area']=false;
+    $table_options['pagesize_area']=false;
+  }
+  $table=new PlcTable ("person_slices",$headers,1,$table_options);
+  $table->start();
 
   foreach( $slices as $slice ) {
     $slice_name= $slice['name'];
     $slice_id= $slice['slice_id'];
-    plc_table_row_start();
-    plc_table_cell(l_slice_t($slice_id,$slice_name));
-    plc_table_row_end();
+    $table->row_start();
+    $table->cell(l_slice_t($slice_id,$slice_name));
+    $table->row_end();
   }
-  plc_table_end("person_slices");
+  $table->end();
  }
 
-////////// keys          
-echo "<hr />\n";
-plc_table_title ("Keys");
+// we don't set 'action', but use the submit button name instead
+$form=new PlcForm(l_actions(), array("person_id"=>$person_id));
+$form->start();
+
+//////////////////// keys
+plc_section ("Keys");
                
 $can_manage_keys = ( $local_peer && ( plc_is_admin() || $is_my_account) );
 if ( empty( $key_ids ) ) {
   plc_warning("This user has no known key");
  } 
-// we don't set 'action', but use the submit button name instead
-plc_form_start(l_person_actions(),
-              array("person_id"=>$person_id,
-                    //"action"=>"debug",
-                    ));
 
-// the headers
-$columns=array("Type"=>"string",
+// headers
+$headers=array("Type"=>"string",
               "Key"=>"string");
-if ($can_manage_keys) $columns['Remove']="none";
+if ($can_manage_keys) $headers['Remove']="none";
 // table overall options
-$table_options=array("search_area"=>false,"notes_area"=>false);
-// add the 'remove site' button and key upload areas as the table footer
-if ($can_manage_keys) {
-  $remove_keys_area=plc_form_submit_text ("delete-keys","Remove keys");
-  $upload_key_left_area= plc_form_label_text("Upload new key","key") . plc_form_file_text("key",60);
-  $upload_key_right_area=plc_form_submit_text("upload-key","Upload key");
-  $table_options['footer']="";
-  if ($keys) $table_options['footer'].="<tr><td colspan=3 style='text-align:right'> $remove_keys_area </td></tr>";
-  $table_options['footer'].="<tr><td colspan=2 style='text-align:right'> $upload_key_left_area </td>".
-    "<td> $upload_key_right_area </td></tr>";
- }
-plc_table_start("person_keys",$columns,"1",$table_options);
+$table_options=array('search_area'=>false,'pagesize_area'=>false,'notes_area'=>false);
+$table=new PlcTable("person_keys",$headers,"1",$table_options);
+$table->start();
     
 if ($keys) foreach ($keys as $key) {
   $key_id=$key['key_id'];
-  plc_table_row_start($key_id);
-  plc_table_cell ($key['key_type']);
-  plc_table_cell(wordwrap( $key['key'], 60, "<br />\n", 1 ));
+  $table->row_start();
+  $table->cell ($key['key_type']);
+  $table->cell(wordwrap( $key['key'], 60, "<br />\n", 1 ));
   if ($can_manage_keys) 
-    plc_table_cell (plc_form_checkbox_text('key_ids[]',$key_id));
-  plc_table_row_end();
+    $table->cell ($form->checkbox_html('key_ids[]',$key_id));
+  $table->row_end();
+}
+// the footer area is used for displaying key-management buttons
+// add the 'remove keys' button and key upload areas as the table footer
+if ($can_manage_keys) {
+  $table->tfoot_start();
+  // no need to remove if there's no key
+  if ($keys) {
+    $table->row_start();
+    $table->cell($form->submit_html ("delete-keys","Remove keys"),
+                $table->columns(),"right");
+    $table->row_end();
+  }
+  $table->row_start();
+  $table->cell($form->label_html("key","Upload new key") . $form->file_html("key",60),
+              $table->columns()-1,"right");
+  $table->cell($form->submit_html("upload-key","Upload key"));
+  $table->row_end();
 }
-plc_table_end("person_keys");
-plc_form_end();
 
-// sites
-echo "<hr />\n";
-plc_table_title('Sites');
+$table->end();
+
+//////////////////// sites
+plc_section('Sites');
   
 // sites
 if (empty( $sites ) ) {
   plc_warning('This user is not affiliated with a site !!');
- } else {
-  $columns=array();
-  $columns['Name']="string";
-  $columns['Login_base']="string";
-  $columns['Remove']="string";
-  $table_options = array('notes_area'=>false,'search_area'=>false);
-  plc_table_start ("person_sites",$columns,1,$table_options);
-  foreach( $sites as $site ) {
-    $site_name= $site['name'];
-    $site_id= $site['site_id'];
-    $login_base=$site['login_base'];
-    plc_table_row_start();
-    plc_table_cell (l_site_t($site_id,$site_name));
-    plc_table_cell ($login_base);
-    plc_table_cell ("<input id=" . $login_base . " type=checkbox name='rem_site[]' value=" . $site_id . ">");
-    plc_table_row_end ();
-  }
-  plc_table_end("person_sites");
- }
+ } 
+$can_manage_sites = $local_peer && plc_is_admin() || $is_my_account;
+$headers=array();
+$headers['Login_base']="string";
+$headers['Name']="string";
+if ($can_manage_sites) 
+  $headers['Remove']="string";
+$table_options = array('notes_area'=>false,'search_area'=>false, 'pagesize_area'=>false);
+$table=new PlcTable ("person_sites",$headers,0,$table_options);
+$table->start();
+foreach( $sites as $site ) {
+  $site_name= $site['name'];
+  $site_id= $site['site_id'];
+  $login_base=$site['login_base'];
+  $table->row_start();
+  $table->cell ($login_base);
+  $table->cell (l_site_t($site_id,$site_name));
+  if ($can_manage_sites)
+    $table->cell ($form->checkbox_html('site_ids[]',$site_id));
+  $table->row_end ();
+}
+if ($can_manage_sites) {
+  $table->tfoot_start();
 
-echo "<input type=submit name='Remove_Sites' value='Remove Sites'>\n";
-  
-       
-// diplay site select list to add another site for user
-if ($local_peer && plc_is_admin()) {
-  // get site info
-  $all_sites= $api->GetSites( NULL, array( "site_id", "name" ) );
-    
-  if( $sites )
-    $person_site= arr_diff( $all_sites, $sites );
-  else
-    $person_site= $all_sites;
-    
-  //    sort_sites( $person_site );
-    
-  echo "<p>Select a site to add this user to: ";
-  echo "<select name='site_add' onChange='submit()'>\n<option value=''>Choose a site to add:</option>\n";
-    
-  foreach( $person_site as $site ) {
-    echo "<option value=". $site['site_id'] .">". $site['name'] ."</option>\n";
-      
+  if ($sites) {
+    $table->row_start();
+    $table->cell($form->submit_html("remove-person-from-sites","Remove Sites"),
+                $table->columns(),"right");
+    $table->row_end();
   }
-    
-  echo "</select>";
-    
+
+  $table->row_start();
+
+  // get list of local sites that the person is not in
+  function get_site_id ($site) { return $site['site_id'];}
+  $person_site_ids=array_map("get_site_id",$sites);
+  $relevant_sites= $api->GetSites( array("peer_id"=>NULL,"~site_id"=>$person_site_ids), $site_columns);
+  // xxx cannot use onchange=submit() - would need to somehow pass action name 
+  function select_arguments($site) { return array('display'=>$site['name'],"value"=>$site['site_id']); }
+  $selectors = array_map ("select_arguments",$relevant_sites);
+  $table->cell ($form->select_html("site_id",$selectors,"Choose a site to add").
+               $form->submit_html("add-person-to-site","Add in site"),
+               $table->columns(),"right");
+  $table->row_end();
  }
-echo "<hr />\n";
-  
-// roles
-echo "<h3>Roles</h3>\n";
-echo "<p><table>\n";
-echo "<thead><tr><th>Role</th>";
-if( plc_is_admin())
-  echo "<th>Remove</th>";
-echo "</tr></thead><tbody>\n";
+$table->end();
+
+//////////////////// roles
+plc_section("Roles");
+if (! $roles) plc_warning ("This user has no role !");
+
+$can_manage_roles= ($local_peer && plc_is_admin());
+$table_options=array("search_area"=>false,"notes_area"=>false);
+
+$headers=array("Role"=>"none");
+if ($can_manage_roles) $headers ["Remove"]="none";
+
+$table_options=array('search_area'=>false,'pagesize_area'=>false,'notes_area'=>false);
+$table=new PlcTable("person_roles",$headers,0,$table_options);  
+$table->start();
   
-// construct role array
-for( $n=0; $n<count($roles); $n++ ) {
-  $proles[]= array( 'role_id'=>$role_ids[$n], 'name'=>$roles[$n] );
+// construct array of role objs
+$role_objs=array();
+for ($n=0; $n<count($roles); $n++) {
+  $role_objs[]= array('role_id'=>$role_ids[$n], 'name'=>$roles[$n]);
  }
-    
-$button_shown=0;
-if ( !empty ($roles) ) {
-  foreach( $proles as $role ) {
-    $role_name= $role['name'];
-    $role_id= $role['role_id'];
-      
-    echo "<tr><td>$role_name";
-             
-
-    if( plc_is_admin()) {
-      echo "</td><td><input type=checkbox name='rem_role[]' value='$role_id'>";
-      if ( ! $button_shown ) {
-       $rowspan=count($roles);
-       echo "</td><td rowspan=$rowspan valign=center><input type=submit name='Remove_Roles' value='Remove Roles'></td></tr>\n";
-       $button_shown=1;
-      }
-    }
-      
-    echo "</td></tr>\n";
-  }
- } else {
-  echo "<span class='plc-warning'> This user has no known role !!</span>";
+
+if ($role_objs) foreach ($role_objs as $role_obj) {
+  $table->row_start();
+  $table->cell($role_obj['name']);
+  if ($can_manage_roles) $table->cell ($form->checkbox_html('role_ids[]',$role_obj['role_id']));
+  $table->row_end();
  }
-echo "</tbody></table>\n";
-         
-// if admin show roles to add
-if( plc_is_admin()) {
-  $all_roles= $api->GetRoles();
-  $addable_roles= arr_diff( $all_roles, $proles );
-  ##when the proles array is empty strangely the method arr_diff($all_roles, $proles )
-  ##return an empty array and the scrolling roles list is not displayed in this case
-  ##assign to addablerole all the roles
-  if (count($proles)==0)
-    $addable_roles=$all_roles;
-    
-  if( !empty( $addable_roles ) ) {
-    echo "<p>Add role: <select name='add_role' onChange='submit()'>\n<option value=''>Choose a Role to add:</option>\n";
-      
-    foreach( $addable_roles as $arole ) {
-      echo "<option value=". $arole['role_id'] .">". $arole['name'] ."</option>\n";
-       
-    }
-      
-    echo "</select>\n";
-      
+
+// footers : the remove and add buttons
+if ($can_manage_roles) {
+  $table->tfoot_start();
+  if ($roles) {
+    $table->row_start();
+    $table->cell($form->submit_html("remove-roles-from-person","Remove Roles"),
+                $table->columns(),"right");
+    $table->row_end();
   }
+
+  $table->row_start();
+  // get list of local roles that the person has not yet
+  // xxx this does not work because GetRoles does not support filters
+  $relevant_roles = $api->GetRoles( array("~role_id"=>$role_ids));
+  function selector_argument ($role) { return array('display'=>$role['name'],"value"=>$role['role_id']); }
+  $selectors=array_map("selector_argument",$relevant_roles);
+  $add_role_left_area=$form->select_html("role_id",$selectors,"Choose a role to add");
+  // add a role : the button
+  $add_role_right_area=$form->submit_html("add-role-to-person","Add role");
+  $table->cell ($add_role_left_area . $add_role_right_area,
+               $table->columns(),"right");
+  $table->row_end();
  }
-  
-plc_peer_block_end();
+$table->end();
+
+//////////////////////////////
+$form->end();
+$peers->block_end($peer_id);
   
 // Print footer
 include 'plc_footer.php';