brute-force changed access to $_GET['key'] to use get_array instead

[plewww.git] / planetlab / tags / nodegroup.php

diff --git a/planetlab/tags/nodegroup.php b/planetlab/tags/nodegroup.php
index 30a6d51..fddba94 100644 (file)
--- a/planetlab/tags/nodegroup.php
+++ b/planetlab/tags/nodegroup.php
@@ -22,7 +22,7 @@ require_once 'toggle.php';
 
 // -------------------- 
 // recognized URL arguments
-$nodegroup_id=intval($_GET['id']);
+$nodegroup_id=intval(get_array($_GET, 'id'));
 if ( ! $nodegroup_id ) { plc_error('Malformed URL - id not set'); return; }
 
 ////////////////////
@@ -50,23 +50,31 @@ $tabs []= tab_nodegroups();
 $tabs []= tab_nodes_local();
 
 drupal_set_title("Details for node group " . $nodegroup['groupname']);
-plc_tabs($tabs);
+plekit_linetabs($tabs);
 
-$details=new PlcDetails(false);
+$toggle=new PlekitToggle('details','Details');
+$toggle->start();
+$details=new PlekitDetails(plc_is_admin());
 $details->start();
-$details->th_td ("Node group name",$nodegroup['groupname']);
+$details->form_start(l_actions(),array("action"=>"update-nodegroup", "nodegroup_id"=>$nodegroup_id));
+$details->th_td ("Node group name",$nodegroup['groupname'],'groupname');
+// can't change the target tag
 $details->th_td ("Based on tag",href(l_tag($nodegroup['tag_type_id']),$tagname));
-$details->th_td("Matching value",$nodegroup['value']);
+$details->th_td("Matching value",$nodegroup['value'],'value');
 $details->th_td("# nodes",count($nodegroup['node_ids']));
+$details->tr_submit("submit","Update Nodegroup");
+$details->form_end();
 $details->end();
 
+$toggle->end();
+
 // xxx : add & delete buttons would make sense here too
-$toggle=new PlcToggle('nodes',"Nodes",array('trigger-tagname'=>'h2'));
-$toggle=>start();
+$toggle=new PlekitToggle('nodes',"Nodes");
+$toggle->start();
 
 $headers["Hostname"]="string";
 
-$table = new PlcTable("nodegroup_nodes",$headers,0,array('search_width'=>15));
+$table = new PlekitTable("nodegroup_nodes",$headers,0,array('search_width'=>15));
 $table->start();
 if ($nodes) foreach ($nodes as $node) {
   $table->row_start ();
@@ -77,7 +85,7 @@ if ($nodes) foreach ($nodes as $node) {
 $table->end ();
 $toggle->end();
 
-//plc_tabs ($tabs,"bottom");
+//plekit_linetabs ($tabs,"bottom");
 
 // Print footer
 include 'plc_footer.php';