minor bug

[sfa.git] / sfa / methods / remove.py

diff --git a/sfa/methods/remove.py b/sfa/methods/remove.py
index b9dd9bd..1b1ae98 100644 (file)
--- a/sfa/methods/remove.py
+++ b/sfa/methods/remove.py
@@ -4,12 +4,8 @@
 from sfa.util.faults import *
 from sfa.util.method import Method
 from sfa.util.parameter import Parameter, Mixed
-from sfa.trust.auth import Auth
-from sfa.util.record import GeniRecord
-from sfa.util.genitable import GeniTable
 from sfa.util.debug import log
 from sfa.trust.credential import Credential
-from sfa.server.registry import Registries
 
 class remove(Method):
     """
@@ -28,71 +24,28 @@ class remove(Method):
     accepts = [
         Parameter(str, "Credential string"),
         Parameter(str, "Record type"),
-        Parameter(str, "Human readable name (hrn) of record to be removed"),
-        Mixed(Parameter(str, "Request hash"),
-              Parameter(None, "Request hash not specified"))
+        Parameter(str, "Human readable name of slice to instantiate"),
+        Mixed(Parameter(str, "Human readable name of the original caller"),
+              Parameter(None, "Origin hrn not specified"))
         ]
 
     returns = Parameter(int, "1 if successful")
     
-    def call(self, cred, type, hrn, request_hash=None, origin_hrn=None):
-        # This cred will be an authority cred, not a user, so we cant use it to 
-        # authenticate the caller's request_hash. Let just get the caller's gid
-        # from the cred and authenticate using that
-        client_gid = Credential(string=cred).get_gid_caller()
-        client_gid_str = client_gid.save_to_string(save_parents=True)
-        self.api.auth.authenticateGid(client_gid_str, [cred, type, hrn], request_hash)
-        self.api.auth.check(cred, "remove")
-        self.api.auth.verify_object_permission(hrn)
-
-        if origin_hrn==None:
-            origin_hrn=Credential(string=cred).get_gid_caller().get_hrn()
+    def call(self, cred, type, hrn, origin_hrn=None):
+        user_cred = Credential(string=cred)
 
         #log the call
+        if not origin_hrn:
+            origin_hrn = user_cred.get_gid_caller().get_hrn()
         self.api.logger.info("interface: %s\tcaller-hrn: %s\ttarget-hrn: %s\tmethod-name: %s"%(self.api.interface, origin_hrn, hrn, self.name))
-        table = GeniTable()
-        filter = {'hrn': hrn}
-        if type not in ['all', '*']:
-            filter['type'] = type
-        records = table.find(filter)
-        if not records:
-            raise RecordNotFound(hrn)
-        record = records[0]
-        type = record['type']
-
-        credential = self.api.getCredential()
-               registries = Registries(self.api) 
 
-        # Try to remove the object from the PLCDB of federated agg.
-        # This is attempted before removing the object from the local agg's PLCDB and sfa table
-        if hrn.startswith(self.api.hrn) and type in ['user', 'slice', 'authority']:
-            for registry in registries:
-                if registry not in [self.api.hrn]:
-                    try:
-                       request_hash=None
-                        result=registries[registry].remove_peer_object(credential, record, request_hash, origin_hrn)
-                    except:
-                        pass
-        if type == "user":
-            persons = self.api.plshell.GetPersons(self.api.plauth, record['pointer'])
-            # only delete this person if he has site ids. if he doesnt, it probably means 
-            # he was just removed from a site, not actually deleted
-            if persons and persons[0]['site_ids']:
-                self.api.plshell.DeletePerson(self.api.plauth, record['pointer'])
-        elif type == "slice":
-            if self.api.plshell.GetSlices(self.api.plauth, record['pointer']):
-                self.api.plshell.DeleteSlice(self.api.plauth, record['pointer'])
-        elif type == "node":
-            if self.api.plshell.GetNodes(self.api.plauth, record['pointer']):
-                self.api.plshell.DeleteNode(self.api.plauth, record['pointer'])
-        elif type == "authority":
-            if self.api.plshell.GetSites(self.api.plauth, record['pointer']):
-                self.api.plshell.DeleteSite(self.api.plauth, record['pointer'])
-        else:
-            raise UnknownGeniType(type)
-
-        table.remove(record)
-           
-       # forward the call after replacing the root hrn
-
-        return 1
+        # validate the cred
+        self.api.auth.check(cred, "remove")
+        self.api.auth.verify_object_permission(hrn)
+       
+        # send the call to the right manager
+        manager_base = 'sfa.managers'
+        mgr_type = self.api.config.SFA_REGISTRY_TYPE
+        manager_module = manager_base + ".registry_manager_%s" % mgr_type
+        manager = __import__(manager_module, fromlist=[manager_base])
+        return manager.remove(self.api, hrn, type, origin_hrn)