upgrade to fedora-2.6.12-1.1398.FC4 + vserver 2.0.rc7
[linux-2.6.git] / sound / core / control.c
index 191a0ed..f4ea6bf 100644 (file)
@@ -31,6 +31,9 @@
 #include <sound/info.h>
 #include <sound/control.h>
 
+/* max number of user-defined controls */
+#define MAX_USER_CONTROLS      32
+
 typedef struct _snd_kctl_ioctl {
        struct list_head list;          /* list of all ioctls */
        snd_kctl_ioctl_func_t fioctl;
@@ -40,6 +43,9 @@ typedef struct _snd_kctl_ioctl {
 
 static DECLARE_RWSEM(snd_ioctl_rwsem);
 static LIST_HEAD(snd_control_ioctls);
+#ifdef CONFIG_COMPAT
+static LIST_HEAD(snd_control_compat_ioctls);
+#endif
 
 static int snd_ctl_open(struct inode *inode, struct file *file)
 {
@@ -513,20 +519,25 @@ snd_kcontrol_t *snd_ctl_find_id(snd_card_t * card, snd_ctl_elem_id_t *id)
 static int snd_ctl_card_info(snd_card_t * card, snd_ctl_file_t * ctl,
                             unsigned int cmd, void __user *arg)
 {
-       snd_ctl_card_info_t info;
+       snd_ctl_card_info_t *info;
 
-       memset(&info, 0, sizeof(info));
+       info = kcalloc(1, sizeof(*info), GFP_KERNEL);
+       if (! info)
+               return -ENOMEM;
        down_read(&snd_ioctl_rwsem);
-       info.card = card->number;
-       strlcpy(info.id, card->id, sizeof(info.id));
-       strlcpy(info.driver, card->driver, sizeof(info.driver));
-       strlcpy(info.name, card->shortname, sizeof(info.name));
-       strlcpy(info.longname, card->longname, sizeof(info.longname));
-       strlcpy(info.mixername, card->mixername, sizeof(info.mixername));
-       strlcpy(info.components, card->components, sizeof(info.components));
+       info->card = card->number;
+       strlcpy(info->id, card->id, sizeof(info->id));
+       strlcpy(info->driver, card->driver, sizeof(info->driver));
+       strlcpy(info->name, card->shortname, sizeof(info->name));
+       strlcpy(info->longname, card->longname, sizeof(info->longname));
+       strlcpy(info->mixername, card->mixername, sizeof(info->mixername));
+       strlcpy(info->components, card->components, sizeof(info->components));
        up_read(&snd_ioctl_rwsem);
-       if (copy_to_user(arg, &info, sizeof(snd_ctl_card_info_t)))
+       if (copy_to_user(arg, info, sizeof(snd_ctl_card_info_t))) {
+               kfree(info);
                return -EFAULT;
+       }
+       kfree(info);
        return 0;
 }
 
@@ -592,43 +603,51 @@ static int snd_ctl_elem_list(snd_card_t *card, snd_ctl_elem_list_t __user *_list
        return 0;
 }
 
-static int snd_ctl_elem_info(snd_ctl_file_t *ctl, snd_ctl_elem_info_t __user *_info)
+static int snd_ctl_elem_info(snd_ctl_file_t *ctl, snd_ctl_elem_info_t *info)
 {
        snd_card_t *card = ctl->card;
-       snd_ctl_elem_info_t info;
        snd_kcontrol_t *kctl;
        snd_kcontrol_volatile_t *vd;
        unsigned int index_offset;
        int result;
        
-       if (copy_from_user(&info, _info, sizeof(info)))
-               return -EFAULT;
        down_read(&card->controls_rwsem);
-       kctl = snd_ctl_find_id(card, &info.id);
+       kctl = snd_ctl_find_id(card, &info->id);
        if (kctl == NULL) {
                up_read(&card->controls_rwsem);
                return -ENOENT;
        }
 #ifdef CONFIG_SND_DEBUG
-       info.access = 0;
+       info->access = 0;
 #endif
-       result = kctl->info(kctl, &info);
+       result = kctl->info(kctl, info);
        if (result >= 0) {
-               snd_assert(info.access == 0, );
-               index_offset = snd_ctl_get_ioff(kctl, &info.id);
+               snd_assert(info->access == 0, );
+               index_offset = snd_ctl_get_ioff(kctl, &info->id);
                vd = &kctl->vd[index_offset];
-               snd_ctl_build_ioff(&info.id, kctl, index_offset);
-               info.access = vd->access;
+               snd_ctl_build_ioff(&info->id, kctl, index_offset);
+               info->access = vd->access;
                if (vd->owner) {
-                       info.access |= SNDRV_CTL_ELEM_ACCESS_LOCK;
+                       info->access |= SNDRV_CTL_ELEM_ACCESS_LOCK;
                        if (vd->owner == ctl)
-                               info.access |= SNDRV_CTL_ELEM_ACCESS_OWNER;
-                       info.owner = vd->owner_pid;
+                               info->access |= SNDRV_CTL_ELEM_ACCESS_OWNER;
+                       info->owner = vd->owner_pid;
                } else {
-                       info.owner = -1;
+                       info->owner = -1;
                }
        }
        up_read(&card->controls_rwsem);
+       return result;
+}
+
+static int snd_ctl_elem_info_user(snd_ctl_file_t *ctl, snd_ctl_elem_info_t __user *_info)
+{
+       snd_ctl_elem_info_t info;
+       int result;
+
+       if (copy_from_user(&info, _info, sizeof(info)))
+               return -EFAULT;
+       result = snd_ctl_elem_info(ctl, &info);
        if (result >= 0)
                if (copy_to_user(_info, &info, sizeof(info)))
                        return -EFAULT;
@@ -685,9 +704,8 @@ static int snd_ctl_elem_read_user(snd_card_t *card, snd_ctl_elem_value_t __user
        return result;
 }
 
-int snd_ctl_elem_write(snd_ctl_file_t *file, snd_ctl_elem_value_t *control)
+int snd_ctl_elem_write(snd_card_t *card, snd_ctl_file_t *file, snd_ctl_elem_value_t *control)
 {
-       snd_card_t *card = file->card;
        snd_kcontrol_t *kctl;
        snd_kcontrol_volatile_t *vd;
        unsigned int index_offset;
@@ -706,7 +724,7 @@ int snd_ctl_elem_write(snd_ctl_file_t *file, snd_ctl_elem_value_t *control)
                } else {
                        if (!(vd->access & SNDRV_CTL_ELEM_ACCESS_WRITE) ||
                            kctl->put == NULL ||
-                           (vd->owner != NULL && vd->owner != file)) {
+                           (file && vd->owner != NULL && vd->owner != file)) {
                                result = -EPERM;
                        } else {
                                snd_ctl_build_ioff(&control->id, kctl, index_offset);
@@ -735,7 +753,7 @@ static int snd_ctl_elem_write_user(snd_ctl_file_t *file, snd_ctl_elem_value_t __
                kfree(control);
                return -EFAULT;
        }
-       result = snd_ctl_elem_write(file, control);
+       result = snd_ctl_elem_write(file->card, file, control);
        if (result >= 0)
                if (copy_to_user(_control, control, sizeof(*control)))
                        result = -EFAULT;
@@ -802,35 +820,18 @@ static int snd_ctl_elem_unlock(snd_ctl_file_t *file, snd_ctl_elem_id_t __user *_
 }
 
 struct user_element {
-       enum sndrv_ctl_elem_type type;  /* element type */
-       unsigned int elem_count;        /* count of elements */
-       union {
-               struct {
-                       unsigned int items;
-               } enumerated;
-       } u;
+       snd_ctl_elem_info_t info;
        void *elem_data;                /* element data */
        unsigned long elem_data_size;   /* size of element data in bytes */
        void *priv_data;                /* private data (like strings for enumerated type) */
        unsigned long priv_data_size;   /* size of private data in bytes */
-       unsigned short dimen_count;     /* count of dimensions */
-       unsigned short dimen[0];        /* array of dimensions */
 };
 
 static int snd_ctl_elem_user_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t *uinfo)
 {
        struct user_element *ue = kcontrol->private_data;
 
-       uinfo->type = ue->type;
-       uinfo->count = ue->elem_count;
-       if (ue->type == SNDRV_CTL_ELEM_TYPE_ENUMERATED) {
-               uinfo->value.enumerated.items = ue->u.enumerated.items;
-               if (uinfo->value.enumerated.item >= ue->u.enumerated.items)
-                       uinfo->value.enumerated.item = 0;
-               strlcpy(uinfo->value.enumerated.name,
-                       (char *)ue->priv_data + uinfo->value.enumerated.item * 64,
-                       64);
-       }
+       *uinfo = ue->info;
        return 0;
 }
 
@@ -847,9 +848,10 @@ static int snd_ctl_elem_user_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t
        int change;
        struct user_element *ue = kcontrol->private_data;
        
-       change = memcmp(&ucontrol->value, ue->elem_data, ue->elem_data_size);
-       memcpy(ue->elem_data, &ucontrol->value, ue->elem_data_size);
-       return !!change;
+       change = memcmp(&ucontrol->value, ue->elem_data, ue->elem_data_size) != 0;
+       if (change)
+               memcpy(ue->elem_data, &ucontrol->value, ue->elem_data_size);
+       return change;
 }
 
 static void snd_ctl_elem_user_free(snd_kcontrol_t * kcontrol)
@@ -857,114 +859,82 @@ static void snd_ctl_elem_user_free(snd_kcontrol_t * kcontrol)
        kfree(kcontrol->private_data);
 }
 
-static int snd_ctl_elem_add(snd_ctl_file_t *file, snd_ctl_elem_info_t __user *_info, int replace)
+static int snd_ctl_elem_add(snd_ctl_file_t *file, snd_ctl_elem_info_t *info, int replace)
 {
        snd_card_t *card = file->card;
-       snd_ctl_elem_info_t info;
        snd_kcontrol_t kctl, *_kctl;
        unsigned int access;
-       long private_size, dimen_size, extra_size;
+       long private_size;
        struct user_element *ue;
        int idx, err;
        
-       if (copy_from_user(&info, _info, sizeof(info)))
-               return -EFAULT;
-       if (info.count > 1024)
-               return -EINVAL;
-       access = info.access == 0 ? SNDRV_CTL_ELEM_ACCESS_READWRITE :
-                (info.access & (SNDRV_CTL_ELEM_ACCESS_READWRITE|SNDRV_CTL_ELEM_ACCESS_INACTIVE|
-                                SNDRV_CTL_ELEM_ACCESS_DINDIRECT|SNDRV_CTL_ELEM_ACCESS_INDIRECT));
-       if (access & (SNDRV_CTL_ELEM_ACCESS_DINDIRECT | SNDRV_CTL_ELEM_ACCESS_INDIRECT))
+       if (card->user_ctl_count >= MAX_USER_CONTROLS)
+               return -ENOMEM;
+       if (info->count > 1024)
                return -EINVAL;
-       info.id.numid = 0;
+       access = info->access == 0 ? SNDRV_CTL_ELEM_ACCESS_READWRITE :
+               (info->access & (SNDRV_CTL_ELEM_ACCESS_READWRITE|SNDRV_CTL_ELEM_ACCESS_INACTIVE));
+       info->id.numid = 0;
        memset(&kctl, 0, sizeof(kctl));
        down_write(&card->controls_rwsem);
-       if (!!((_kctl = snd_ctl_find_id(card, &info.id)) != NULL) ^ replace) {
-               up_write(&card->controls_rwsem);
-               return !replace ? -EBUSY : -ENOENT;
-       }
-       if (replace) {
-               err = snd_ctl_remove(card, _kctl);
-               if (err < 0) {
-                       up_write(&card->controls_rwsem);
-                       return err;
-               }
+       _kctl = snd_ctl_find_id(card, &info->id);
+       err = 0;
+       if (_kctl) {
+               if (replace)
+                       err = snd_ctl_remove(card, _kctl);
+               else
+                       err = -EBUSY;
+       } else {
+               if (replace)
+                       err = -ENOENT;
        }
        up_write(&card->controls_rwsem);
-       memcpy(&kctl.id, &info.id, sizeof(info.id));
-       kctl.count = info.owner ? info.owner : 1;
+       if (err < 0)
+               return err;
+       memcpy(&kctl.id, &info->id, sizeof(info->id));
+       kctl.count = info->owner ? info->owner : 1;
        access |= SNDRV_CTL_ELEM_ACCESS_USER;
        kctl.info = snd_ctl_elem_user_info;
        if (access & SNDRV_CTL_ELEM_ACCESS_READ)
                kctl.get = snd_ctl_elem_user_get;
        if (access & SNDRV_CTL_ELEM_ACCESS_WRITE)
                kctl.put = snd_ctl_elem_user_put;
-       extra_size = 0;
-       switch (info.type) {
+       switch (info->type) {
        case SNDRV_CTL_ELEM_TYPE_BOOLEAN:
                private_size = sizeof(char);
-               if (info.count > 128)
+               if (info->count > 128)
                        return -EINVAL;
                break;
        case SNDRV_CTL_ELEM_TYPE_INTEGER:
                private_size = sizeof(long);
-               if (info.count > 128)
+               if (info->count > 128)
                        return -EINVAL;
                break;
        case SNDRV_CTL_ELEM_TYPE_INTEGER64:
                private_size = sizeof(long long);
-               if (info.count > 64)
-                       return -EINVAL;
-               break;
-       case SNDRV_CTL_ELEM_TYPE_ENUMERATED:
-               private_size = sizeof(unsigned int);
-               if (info.count > 128)
+               if (info->count > 64)
                        return -EINVAL;
-               if (info.value.enumerated.items > 1024)
-                       return -EINVAL;
-               extra_size = info.value.enumerated.items * 64;
                break;
        case SNDRV_CTL_ELEM_TYPE_BYTES:
                private_size = sizeof(unsigned char);
-               if (info.count > 512)
+               if (info->count > 512)
                        return -EINVAL;
                break;
        case SNDRV_CTL_ELEM_TYPE_IEC958:
                private_size = sizeof(struct sndrv_aes_iec958);
-               if (info.count != 1)
+               if (info->count != 1)
                        return -EINVAL;
                break;
        default:
                return -EINVAL;
        }
-       private_size *= info.count;
-       if (private_size > 1024 * 1024)
-               return -EINVAL;
-       dimen_size = 0;
-       if (!(info.access & SNDRV_CTL_ELEM_ACCESS_DINDIRECT))
-               for (idx = 0; idx < 4 && info.dimen.d[idx]; idx++)
-                       dimen_size += sizeof(unsigned short);
-       ue = kcalloc(1, sizeof(struct user_element) + dimen_size + private_size + extra_size, GFP_KERNEL);
+       private_size *= info->count;
+       ue = kcalloc(1, sizeof(struct user_element) + private_size, GFP_KERNEL);
        if (ue == NULL)
                return -ENOMEM;
-       ue->type = info.type;
-       ue->elem_count = info.count;
-       if (!(info.access & SNDRV_CTL_ELEM_ACCESS_DINDIRECT)) {
-               for (idx = 0; idx < 4 && info.dimen.d[idx]; idx++)
-                       ue->dimen[idx] = info.dimen.d[idx];
-               ue->dimen_count = dimen_size / sizeof(unsigned short);
-       }
-       ue->elem_data = (char *)ue + sizeof(ue) + dimen_size;
+       ue->info = *info;
+       ue->elem_data = (char *)ue + sizeof(*ue);
        ue->elem_data_size = private_size;
-       if (extra_size) {
-               ue->priv_data = (char *)ue + sizeof(ue) + dimen_size + private_size;
-               ue->priv_data_size = extra_size;
-               if (ue->type == SNDRV_CTL_ELEM_TYPE_ENUMERATED) {
-                       if (copy_from_user(ue->priv_data, *(char **)info.value.enumerated.name, extra_size))
-                               return -EFAULT;
-                       ue->u.enumerated.items = info.value.enumerated.items;
-               }
-       }
        kctl.private_free = snd_ctl_elem_user_free;
        _kctl = snd_ctl_new(&kctl, access);
        if (_kctl == NULL) {
@@ -979,16 +949,37 @@ static int snd_ctl_elem_add(snd_ctl_file_t *file, snd_ctl_elem_info_t __user *_i
                snd_ctl_free_one(_kctl);
                return err;
        }
+
+       down_write(&card->controls_rwsem);
+       card->user_ctl_count++;
+       up_write(&card->controls_rwsem);
+
        return 0;
 }
 
+static int snd_ctl_elem_add_user(snd_ctl_file_t *file, snd_ctl_elem_info_t __user *_info, int replace)
+{
+       snd_ctl_elem_info_t info;
+       if (copy_from_user(&info, _info, sizeof(info)))
+               return -EFAULT;
+       return snd_ctl_elem_add(file, &info, replace);
+}
+
 static int snd_ctl_elem_remove(snd_ctl_file_t *file, snd_ctl_elem_id_t __user *_id)
 {
        snd_ctl_elem_id_t id;
+       int err;
 
        if (copy_from_user(&id, _id, sizeof(id)))
                return -EFAULT;
-       return snd_ctl_remove_unlocked_id(file, &id);
+       err = snd_ctl_remove_unlocked_id(file, &id);
+       if (! err) {
+               snd_card_t *card = file->card;
+               down_write(&card->controls_rwsem);
+               card->user_ctl_count--;
+               up_write(&card->controls_rwsem);
+       }
+       return err;
 }
 
 static int snd_ctl_subscribe_events(snd_ctl_file_t *file, int __user *ptr)
@@ -1020,18 +1011,21 @@ static int snd_ctl_set_power_state(snd_card_t *card, unsigned int power_state)
 {
        switch (power_state) {
        case SNDRV_CTL_POWER_D0:
-       case SNDRV_CTL_POWER_D1:
-       case SNDRV_CTL_POWER_D2:
-               if (card->power_state != power_state)
-                       /* FIXME: pass the correct state value */
-                       card->pm_resume(card, 0);
+               if (card->power_state != power_state) {
+                       card->pm_resume(card);
+                       snd_power_change_state(card, power_state);
+               }
                break;
        case SNDRV_CTL_POWER_D3hot:
-       case SNDRV_CTL_POWER_D3cold:
-               if (card->power_state != power_state)
-                       /* FIXME: pass the correct state value */
-                       card->pm_suspend(card, 0);
+               if (card->power_state != power_state) {
+                       card->pm_suspend(card, PMSG_SUSPEND);
+                       snd_power_change_state(card, power_state);
+               }
                break;
+       case SNDRV_CTL_POWER_D1:
+       case SNDRV_CTL_POWER_D2:
+       case SNDRV_CTL_POWER_D3cold:
+               /* not supported yet */
        default:
                return -EINVAL;
        }
@@ -1039,8 +1033,7 @@ static int snd_ctl_set_power_state(snd_card_t *card, unsigned int power_state)
 }
 #endif
 
-static inline int _snd_ctl_ioctl(struct inode *inode, struct file *file,
-                                unsigned int cmd, unsigned long arg)
+static long snd_ctl_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 {
        snd_ctl_file_t *ctl;
        snd_card_t *card;
@@ -1061,7 +1054,7 @@ static inline int _snd_ctl_ioctl(struct inode *inode, struct file *file,
        case SNDRV_CTL_IOCTL_ELEM_LIST:
                return snd_ctl_elem_list(ctl->card, argp);
        case SNDRV_CTL_IOCTL_ELEM_INFO:
-               return snd_ctl_elem_info(ctl, argp);
+               return snd_ctl_elem_info_user(ctl, argp);
        case SNDRV_CTL_IOCTL_ELEM_READ:
                return snd_ctl_elem_read_user(ctl->card, argp);
        case SNDRV_CTL_IOCTL_ELEM_WRITE:
@@ -1071,9 +1064,9 @@ static inline int _snd_ctl_ioctl(struct inode *inode, struct file *file,
        case SNDRV_CTL_IOCTL_ELEM_UNLOCK:
                return snd_ctl_elem_unlock(ctl, argp);
        case SNDRV_CTL_IOCTL_ELEM_ADD:
-               return snd_ctl_elem_add(ctl, argp, 0);
+               return snd_ctl_elem_add_user(ctl, argp, 0);
        case SNDRV_CTL_IOCTL_ELEM_REPLACE:
-               return snd_ctl_elem_add(ctl, argp, 1);
+               return snd_ctl_elem_add_user(ctl, argp, 1);
        case SNDRV_CTL_IOCTL_ELEM_REMOVE:
                return snd_ctl_elem_remove(ctl, argp);
        case SNDRV_CTL_IOCTL_SUBSCRIBE_EVENTS:
@@ -1113,17 +1106,6 @@ static inline int _snd_ctl_ioctl(struct inode *inode, struct file *file,
        return -ENOTTY;
 }
 
-/* FIXME: need to unlock BKL to allow preemption */
-static int snd_ctl_ioctl(struct inode *inode, struct file *file,
-                        unsigned int cmd, unsigned long arg)
-{
-       int err;
-       unlock_kernel();
-       err = _snd_ctl_ioctl(inode, file, cmd, arg);
-       lock_kernel();
-       return err;
-}
-
 static ssize_t snd_ctl_read(struct file *file, char __user *buffer, size_t count, loff_t * offset)
 {
        snd_ctl_file_t *ctl;
@@ -1199,7 +1181,7 @@ static unsigned int snd_ctl_poll(struct file *file, poll_table * wait)
  * register the device-specific control-ioctls.
  * called from each device manager like pcm.c, hwdep.c, etc.
  */
-int snd_ctl_register_ioctl(snd_kctl_ioctl_func_t fcn)
+static int _snd_ctl_register_ioctl(snd_kctl_ioctl_func_t fcn, struct list_head *lists)
 {
        snd_kctl_ioctl_t *pn;
 
@@ -1208,22 +1190,34 @@ int snd_ctl_register_ioctl(snd_kctl_ioctl_func_t fcn)
                return -ENOMEM;
        pn->fioctl = fcn;
        down_write(&snd_ioctl_rwsem);
-       list_add_tail(&pn->list, &snd_control_ioctls);
+       list_add_tail(&pn->list, lists);
        up_write(&snd_ioctl_rwsem);
        return 0;
 }
 
+int snd_ctl_register_ioctl(snd_kctl_ioctl_func_t fcn)
+{
+       return _snd_ctl_register_ioctl(fcn, &snd_control_ioctls);
+}
+
+#ifdef CONFIG_COMPAT
+int snd_ctl_register_ioctl_compat(snd_kctl_ioctl_func_t fcn)
+{
+       return _snd_ctl_register_ioctl(fcn, &snd_control_compat_ioctls);
+}
+#endif
+
 /*
  * de-register the device-specific control-ioctls.
  */
-int snd_ctl_unregister_ioctl(snd_kctl_ioctl_func_t fcn)
+static int _snd_ctl_unregister_ioctl(snd_kctl_ioctl_func_t fcn, struct list_head *lists)
 {
        struct list_head *list;
        snd_kctl_ioctl_t *p;
 
        snd_runtime_check(fcn != NULL, return -EINVAL);
        down_write(&snd_ioctl_rwsem);
-       list_for_each(list, &snd_control_ioctls) {
+       list_for_each(list, lists) {
                p = list_entry(list, snd_kctl_ioctl_t, list);
                if (p->fioctl == fcn) {
                        list_del(&p->list);
@@ -1237,6 +1231,19 @@ int snd_ctl_unregister_ioctl(snd_kctl_ioctl_func_t fcn)
        return -EINVAL;
 }
 
+int snd_ctl_unregister_ioctl(snd_kctl_ioctl_func_t fcn)
+{
+       return _snd_ctl_unregister_ioctl(fcn, &snd_control_ioctls);
+}
+
+#ifdef CONFIG_COMPAT
+int snd_ctl_unregister_ioctl_compat(snd_kctl_ioctl_func_t fcn)
+{
+       return _snd_ctl_unregister_ioctl(fcn, &snd_control_compat_ioctls);
+}
+
+#endif
+
 static int snd_ctl_fasync(int fd, struct file * file, int on)
 {
        snd_ctl_file_t *ctl;
@@ -1248,6 +1255,15 @@ static int snd_ctl_fasync(int fd, struct file * file, int on)
        return 0;
 }
 
+/*
+ * ioctl32 compat
+ */
+#ifdef CONFIG_COMPAT
+#include "control_compat.c"
+#else
+#define snd_ctl_ioctl_compat   NULL
+#endif
+
 /*
  *  INIT PART
  */
@@ -1259,7 +1275,8 @@ static struct file_operations snd_ctl_f_ops =
        .open =         snd_ctl_open,
        .release =      snd_ctl_release,
        .poll =         snd_ctl_poll,
-       .ioctl =        snd_ctl_ioctl,
+       .unlocked_ioctl =       snd_ctl_ioctl,
+       .compat_ioctl = snd_ctl_ioctl_compat,
        .fasync =       snd_ctl_fasync,
 };
 
@@ -1270,11 +1287,11 @@ static snd_minor_t snd_ctl_reg =
 };
 
 /*
- * registration of the control device:
- * called from init.c
+ * registration of the control device
  */
-int snd_ctl_register(snd_card_t *card)
+static int snd_ctl_dev_register(snd_device_t *device)
 {
+       snd_card_t *card = device->device_data;
        int err, cardnum;
        char name[16];
 
@@ -1289,11 +1306,11 @@ int snd_ctl_register(snd_card_t *card)
 }
 
 /*
- * disconnection of the control device:
- * called from init.c
+ * disconnection of the control device
  */
-int snd_ctl_disconnect(snd_card_t *card)
+static int snd_ctl_dev_disconnect(snd_device_t *device)
 {
+       snd_card_t *card = device->device_data;
        struct list_head *flist;
        snd_ctl_file_t *ctl;
 
@@ -1308,19 +1325,13 @@ int snd_ctl_disconnect(snd_card_t *card)
 }
 
 /*
- * de-registration of the control device:
- * called from init.c
+ * free all controls
  */
-int snd_ctl_unregister(snd_card_t *card)
+static int snd_ctl_dev_free(snd_device_t *device)
 {
-       int err, cardnum;
+       snd_card_t *card = device->device_data;
        snd_kcontrol_t *control;
 
-       snd_assert(card != NULL, return -ENXIO);
-       cardnum = card->number;
-       snd_assert(cardnum >= 0 && cardnum < SNDRV_CARDS, return -ENXIO);
-       if ((err = snd_unregister_device(SNDRV_DEVICE_TYPE_CONTROL, card, 0)) < 0)
-               return err;
        down_write(&card->controls_rwsem);
        while (!list_empty(&card->controls)) {
                control = snd_kcontrol(card->controls.next);
@@ -1329,3 +1340,36 @@ int snd_ctl_unregister(snd_card_t *card)
        up_write(&card->controls_rwsem);
        return 0;
 }
+
+/*
+ * de-registration of the control device
+ */
+static int snd_ctl_dev_unregister(snd_device_t *device)
+{
+       snd_card_t *card = device->device_data;
+       int err, cardnum;
+
+       snd_assert(card != NULL, return -ENXIO);
+       cardnum = card->number;
+       snd_assert(cardnum >= 0 && cardnum < SNDRV_CARDS, return -ENXIO);
+       if ((err = snd_unregister_device(SNDRV_DEVICE_TYPE_CONTROL, card, 0)) < 0)
+               return err;
+       return snd_ctl_dev_free(device);
+}
+
+/*
+ * create control core:
+ * called from init.c
+ */
+int snd_ctl_create(snd_card_t *card)
+{
+       static snd_device_ops_t ops = {
+               .dev_free = snd_ctl_dev_free,
+               .dev_register = snd_ctl_dev_register,
+               .dev_disconnect = snd_ctl_dev_disconnect,
+               .dev_unregister = snd_ctl_dev_unregister
+       };
+
+       snd_assert(card != NULL, return -ENXIO);
+       return snd_device_new(card, SNDRV_DEV_CONTROL, card, &ops);
+}