Fedora kernel-2.6.17-1.2142_FC4 patched with stable patch-2.6.17.4-vs2.0.2-rc26.diff
[linux-2.6.git] / sound / pci / emu10k1 / emufx.c
index 6290ed5..dfba002 100644 (file)
 
 #include <sound/driver.h>
 #include <linux/pci.h>
+#include <linux/capability.h>
 #include <linux/delay.h>
 #include <linux/slab.h>
+#include <linux/vmalloc.h>
 #include <linux/init.h>
+#include <linux/mutex.h>
+
 #include <sound/core.h>
 #include <sound/emu10k1.h>
 
@@ -309,9 +313,10 @@ static inline void snd_leave_user(mm_segment_t fs)
  *   controls
  */
 
-static int snd_emu10k1_gpr_ctl_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_emu10k1_gpr_ctl_info(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
-       snd_emu10k1_fx8010_ctl_t *ctl = (snd_emu10k1_fx8010_ctl_t *)kcontrol->private_value;
+       struct snd_emu10k1_fx8010_ctl *ctl =
+               (struct snd_emu10k1_fx8010_ctl *) kcontrol->private_value;
 
        if (ctl->min == 0 && ctl->max == 1)
                uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
@@ -323,10 +328,11 @@ static int snd_emu10k1_gpr_ctl_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_
        return 0;
 }
 
-static int snd_emu10k1_gpr_ctl_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_emu10k1_gpr_ctl_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       emu10k1_t *emu = snd_kcontrol_chip(kcontrol);
-       snd_emu10k1_fx8010_ctl_t *ctl = (snd_emu10k1_fx8010_ctl_t *)kcontrol->private_value;
+       struct snd_emu10k1 *emu = snd_kcontrol_chip(kcontrol);
+       struct snd_emu10k1_fx8010_ctl *ctl =
+               (struct snd_emu10k1_fx8010_ctl *) kcontrol->private_value;
        unsigned long flags;
        unsigned int i;
        
@@ -337,10 +343,11 @@ static int snd_emu10k1_gpr_ctl_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value
        return 0;
 }
 
-static int snd_emu10k1_gpr_ctl_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_emu10k1_gpr_ctl_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       emu10k1_t *emu = snd_kcontrol_chip(kcontrol);
-       snd_emu10k1_fx8010_ctl_t *ctl = (snd_emu10k1_fx8010_ctl_t *)kcontrol->private_value;
+       struct snd_emu10k1 *emu = snd_kcontrol_chip(kcontrol);
+       struct snd_emu10k1_fx8010_ctl *ctl =
+               (struct snd_emu10k1_fx8010_ctl *) kcontrol->private_value;
        unsigned long flags;
        unsigned int nval, val;
        unsigned int i, j;
@@ -364,12 +371,18 @@ static int snd_emu10k1_gpr_ctl_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value
                        snd_emu10k1_ptr_write(emu, emu->gpr_base + ctl->gpr[i], 0, db_table[val]);
                        break;
                case EMU10K1_GPR_TRANSLATION_BASS:
-                       snd_runtime_check((ctl->count % 5) == 0 && (ctl->count / 5) == ctl->vcount, change = -EIO; goto __error);
+                       if ((ctl->count % 5) != 0 || (ctl->count / 5) != ctl->vcount) {
+                               change = -EIO;
+                               goto __error;
+                       }
                        for (j = 0; j < 5; j++)
                                snd_emu10k1_ptr_write(emu, emu->gpr_base + ctl->gpr[j * ctl->vcount + i], 0, bass_table[val][j]);
                        break;
                case EMU10K1_GPR_TRANSLATION_TREBLE:
-                       snd_runtime_check((ctl->count % 5) == 0 && (ctl->count / 5) == ctl->vcount, change = -EIO; goto __error);
+                       if ((ctl->count % 5) != 0 || (ctl->count / 5) != ctl->vcount) {
+                               change = -EIO;
+                               goto __error;
+                       }
                        for (j = 0; j < 5; j++)
                                snd_emu10k1_ptr_write(emu, emu->gpr_base + ctl->gpr[j * ctl->vcount + i], 0, treble_table[val][j]);
                        break;
@@ -387,9 +400,9 @@ static int snd_emu10k1_gpr_ctl_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value
  *   Interrupt handler
  */
 
-static void snd_emu10k1_fx8010_interrupt(emu10k1_t *emu)
+static void snd_emu10k1_fx8010_interrupt(struct snd_emu10k1 *emu)
 {
-       snd_emu10k1_fx8010_irq_t *irq, *nirq;
+       struct snd_emu10k1_fx8010_irq *irq, *nirq;
 
        irq = emu->fx8010.irq_handlers;
        while (irq) {
@@ -403,17 +416,15 @@ static void snd_emu10k1_fx8010_interrupt(emu10k1_t *emu)
        }
 }
 
-int snd_emu10k1_fx8010_register_irq_handler(emu10k1_t *emu,
-                                                  snd_fx8010_irq_handler_t *handler,
-                                                  unsigned char gpr_running,
-                                                  void *private_data,
-                                                  snd_emu10k1_fx8010_irq_t **r_irq)
+int snd_emu10k1_fx8010_register_irq_handler(struct snd_emu10k1 *emu,
+                                           snd_fx8010_irq_handler_t *handler,
+                                           unsigned char gpr_running,
+                                           void *private_data,
+                                           struct snd_emu10k1_fx8010_irq **r_irq)
 {
-       snd_emu10k1_fx8010_irq_t *irq;
+       struct snd_emu10k1_fx8010_irq *irq;
        unsigned long flags;
        
-       snd_runtime_check(emu, return -EINVAL);
-       snd_runtime_check(handler, return -EINVAL);
        irq = kmalloc(sizeof(*irq), GFP_ATOMIC);
        if (irq == NULL)
                return -ENOMEM;
@@ -436,13 +447,12 @@ int snd_emu10k1_fx8010_register_irq_handler(emu10k1_t *emu,
        return 0;
 }
 
-int snd_emu10k1_fx8010_unregister_irq_handler(emu10k1_t *emu,
-                                                    snd_emu10k1_fx8010_irq_t *irq)
+int snd_emu10k1_fx8010_unregister_irq_handler(struct snd_emu10k1 *emu,
+                                             struct snd_emu10k1_fx8010_irq *irq)
 {
-       snd_emu10k1_fx8010_irq_t *tmp;
+       struct snd_emu10k1_fx8010_irq *tmp;
        unsigned long flags;
        
-       snd_runtime_check(irq, return -EINVAL);
        spin_lock_irqsave(&emu->fx8010.irq_lock, flags);
        if ((tmp = emu->fx8010.irq_handlers) == irq) {
                emu->fx8010.irq_handlers = tmp->next;
@@ -465,115 +475,165 @@ int snd_emu10k1_fx8010_unregister_irq_handler(emu10k1_t *emu,
  * EMU10K1 effect manager
  *************************************************************************/
 
-static void snd_emu10k1_write_op(emu10k1_fx8010_code_t *icode, unsigned int *ptr,
+static void snd_emu10k1_write_op(struct snd_emu10k1_fx8010_code *icode,
+                                unsigned int *ptr,
                                 u32 op, u32 r, u32 a, u32 x, u32 y)
 {
+       u_int32_t *code;
        snd_assert(*ptr < 512, return);
+       code = (u_int32_t __force *)icode->code + (*ptr) * 2;
        set_bit(*ptr, icode->code_valid);
-       icode->code[*ptr    ][0] = ((x & 0x3ff) << 10) | (y & 0x3ff);
-       icode->code[(*ptr)++][1] = ((op & 0x0f) << 20) | ((r & 0x3ff) << 10) | (a & 0x3ff);
+       code[0] = ((x & 0x3ff) << 10) | (y & 0x3ff);
+       code[1] = ((op & 0x0f) << 20) | ((r & 0x3ff) << 10) | (a & 0x3ff);
+       (*ptr)++;
 }
 
 #define OP(icode, ptr, op, r, a, x, y) \
        snd_emu10k1_write_op(icode, ptr, op, r, a, x, y)
 
-static void snd_emu10k1_audigy_write_op(emu10k1_fx8010_code_t *icode, unsigned int *ptr,
+static void snd_emu10k1_audigy_write_op(struct snd_emu10k1_fx8010_code *icode,
+                                       unsigned int *ptr,
                                        u32 op, u32 r, u32 a, u32 x, u32 y)
 {
-       snd_assert(*ptr < 512, return);
+       u_int32_t *code;
+       snd_assert(*ptr < 1024, return);
+       code = (u_int32_t __force *)icode->code + (*ptr) * 2;
        set_bit(*ptr, icode->code_valid);
-       icode->code[*ptr    ][0] = ((x & 0x7ff) << 12) | (y & 0x7ff);
-       icode->code[(*ptr)++][1] = ((op & 0x0f) << 24) | ((r & 0x7ff) << 12) | (a & 0x7ff);
+       code[0] = ((x & 0x7ff) << 12) | (y & 0x7ff);
+       code[1] = ((op & 0x0f) << 24) | ((r & 0x7ff) << 12) | (a & 0x7ff);
+       (*ptr)++;
 }
 
 #define A_OP(icode, ptr, op, r, a, x, y) \
        snd_emu10k1_audigy_write_op(icode, ptr, op, r, a, x, y)
 
-void snd_emu10k1_efx_write(emu10k1_t *emu, unsigned int pc, unsigned int data)
+static void snd_emu10k1_efx_write(struct snd_emu10k1 *emu, unsigned int pc, unsigned int data)
 {
        pc += emu->audigy ? A_MICROCODEBASE : MICROCODEBASE;
        snd_emu10k1_ptr_write(emu, pc, 0, data);
 }
 
-unsigned int snd_emu10k1_efx_read(emu10k1_t *emu, unsigned int pc)
+unsigned int snd_emu10k1_efx_read(struct snd_emu10k1 *emu, unsigned int pc)
 {
        pc += emu->audigy ? A_MICROCODEBASE : MICROCODEBASE;
        return snd_emu10k1_ptr_read(emu, pc, 0);
 }
 
-static void snd_emu10k1_gpr_poke(emu10k1_t *emu, emu10k1_fx8010_code_t *icode)
+static int snd_emu10k1_gpr_poke(struct snd_emu10k1 *emu,
+                               struct snd_emu10k1_fx8010_code *icode)
 {
        int gpr;
+       u32 val;
 
-       for (gpr = 0; gpr < 0x100; gpr++) {
+       for (gpr = 0; gpr < (emu->audigy ? 0x200 : 0x100); gpr++) {
                if (!test_bit(gpr, icode->gpr_valid))
                        continue;
-               snd_emu10k1_ptr_write(emu, emu->gpr_base + gpr, 0, icode->gpr_map[gpr]);
+               if (get_user(val, &icode->gpr_map[gpr]))
+                       return -EFAULT;
+               snd_emu10k1_ptr_write(emu, emu->gpr_base + gpr, 0, val);
        }
+       return 0;
 }
 
-static void snd_emu10k1_gpr_peek(emu10k1_t *emu, emu10k1_fx8010_code_t *icode)
+static int snd_emu10k1_gpr_peek(struct snd_emu10k1 *emu,
+                               struct snd_emu10k1_fx8010_code *icode)
 {
        int gpr;
+       u32 val;
 
-       for (gpr = 0; gpr < 0x100; gpr++) {
+       for (gpr = 0; gpr < (emu->audigy ? 0x200 : 0x100); gpr++) {
                set_bit(gpr, icode->gpr_valid);
-               icode->gpr_map[gpr] = snd_emu10k1_ptr_read(emu, emu->gpr_base + gpr, 0);
+               val = snd_emu10k1_ptr_read(emu, emu->gpr_base + gpr, 0);
+               if (put_user(val, &icode->gpr_map[gpr]))
+                       return -EFAULT;
        }
+       return 0;
 }
 
-static void snd_emu10k1_tram_poke(emu10k1_t *emu, emu10k1_fx8010_code_t *icode)
+static int snd_emu10k1_tram_poke(struct snd_emu10k1 *emu,
+                                struct snd_emu10k1_fx8010_code *icode)
 {
        int tram;
+       u32 addr, val;
 
-       for (tram = 0; tram < 0xa0; tram++) {
+       for (tram = 0; tram < (emu->audigy ? 0x100 : 0xa0); tram++) {
                if (!test_bit(tram, icode->tram_valid))
                        continue;
-               snd_emu10k1_ptr_write(emu, TANKMEMDATAREGBASE + tram, 0, icode->tram_data_map[tram]);
-               snd_emu10k1_ptr_write(emu, TANKMEMADDRREGBASE + tram, 0, icode->tram_addr_map[tram]);
+               if (get_user(val, &icode->tram_data_map[tram]) ||
+                   get_user(addr, &icode->tram_addr_map[tram]))
+                       return -EFAULT;
+               snd_emu10k1_ptr_write(emu, TANKMEMDATAREGBASE + tram, 0, val);
+               if (!emu->audigy) {
+                       snd_emu10k1_ptr_write(emu, TANKMEMADDRREGBASE + tram, 0, addr);
+               } else {
+                       snd_emu10k1_ptr_write(emu, TANKMEMADDRREGBASE + tram, 0, addr << 12);
+                       snd_emu10k1_ptr_write(emu, A_TANKMEMCTLREGBASE + tram, 0, addr >> 20);
+               }
        }
+       return 0;
 }
 
-static void snd_emu10k1_tram_peek(emu10k1_t *emu, emu10k1_fx8010_code_t *icode)
+static int snd_emu10k1_tram_peek(struct snd_emu10k1 *emu,
+                                struct snd_emu10k1_fx8010_code *icode)
 {
        int tram;
+       u32 val, addr;
 
        memset(icode->tram_valid, 0, sizeof(icode->tram_valid));
-       for (tram = 0; tram < 0xa0; tram++) {
+       for (tram = 0; tram < (emu->audigy ? 0x100 : 0xa0); tram++) {
                set_bit(tram, icode->tram_valid);
-               icode->tram_data_map[tram] = snd_emu10k1_ptr_read(emu, TANKMEMDATAREGBASE + tram, 0);
-               icode->tram_addr_map[tram] = snd_emu10k1_ptr_read(emu, TANKMEMADDRREGBASE + tram, 0);
+               val = snd_emu10k1_ptr_read(emu, TANKMEMDATAREGBASE + tram, 0);
+               if (!emu->audigy) {
+                       addr = snd_emu10k1_ptr_read(emu, TANKMEMADDRREGBASE + tram, 0);
+               } else {
+                       addr = snd_emu10k1_ptr_read(emu, TANKMEMADDRREGBASE + tram, 0) >> 12;
+                       addr |= snd_emu10k1_ptr_read(emu, A_TANKMEMCTLREGBASE + tram, 0) << 20;
+               }
+               if (put_user(val, &icode->tram_data_map[tram]) ||
+                   put_user(addr, &icode->tram_addr_map[tram]))
+                       return -EFAULT;
        }
+       return 0;
 }
 
-static void snd_emu10k1_code_poke(emu10k1_t *emu, emu10k1_fx8010_code_t *icode)
+static int snd_emu10k1_code_poke(struct snd_emu10k1 *emu,
+                                struct snd_emu10k1_fx8010_code *icode)
 {
-       u32 pc;
+       u32 pc, lo, hi;
 
-       for (pc = 0; pc < 512; pc++) {
-               if (!test_bit(pc, icode->code_valid))
+       for (pc = 0; pc < (emu->audigy ? 2*1024 : 2*512); pc += 2) {
+               if (!test_bit(pc / 2, icode->code_valid))
                        continue;
-               snd_emu10k1_efx_write(emu, pc * 2, icode->code[pc][0]);
-               snd_emu10k1_efx_write(emu, pc * 2 + 1, icode->code[pc][1]);
+               if (get_user(lo, &icode->code[pc + 0]) ||
+                   get_user(hi, &icode->code[pc + 1]))
+                       return -EFAULT;
+               snd_emu10k1_efx_write(emu, pc + 0, lo);
+               snd_emu10k1_efx_write(emu, pc + 1, hi);
        }
+       return 0;
 }
 
-static void snd_emu10k1_code_peek(emu10k1_t *emu, emu10k1_fx8010_code_t *icode)
+static int snd_emu10k1_code_peek(struct snd_emu10k1 *emu,
+                                struct snd_emu10k1_fx8010_code *icode)
 {
        u32 pc;
 
        memset(icode->code_valid, 0, sizeof(icode->code_valid));
-       for (pc = 0; pc < 512; pc++) {
-               set_bit(pc, icode->code_valid);
-               icode->code[pc][0] = snd_emu10k1_efx_read(emu, pc * 2);
-               icode->code[pc][1] = snd_emu10k1_efx_read(emu, pc * 2 + 1);
+       for (pc = 0; pc < (emu->audigy ? 2*1024 : 2*512); pc += 2) {
+               set_bit(pc / 2, icode->code_valid);
+               if (put_user(snd_emu10k1_efx_read(emu, pc + 0), &icode->code[pc + 0]))
+                       return -EFAULT;
+               if (put_user(snd_emu10k1_efx_read(emu, pc + 1), &icode->code[pc + 1]))
+                       return -EFAULT;
        }
+       return 0;
 }
 
-static snd_emu10k1_fx8010_ctl_t *snd_emu10k1_look_for_ctl(emu10k1_t *emu, snd_ctl_elem_id_t *id)
+static struct snd_emu10k1_fx8010_ctl *
+snd_emu10k1_look_for_ctl(struct snd_emu10k1 *emu, struct snd_ctl_elem_id *id)
 {
-       snd_emu10k1_fx8010_ctl_t *ctl;
-       snd_kcontrol_t *kcontrol;
+       struct snd_emu10k1_fx8010_ctl *ctl;
+       struct snd_kcontrol *kcontrol;
        struct list_head *list;
        
        list_for_each(list, &emu->fx8010.gpr_ctl) {
@@ -587,13 +647,15 @@ static snd_emu10k1_fx8010_ctl_t *snd_emu10k1_look_for_ctl(emu10k1_t *emu, snd_ct
        return NULL;
 }
 
-static int snd_emu10k1_verify_controls(emu10k1_t *emu, emu10k1_fx8010_code_t *icode)
+static int snd_emu10k1_verify_controls(struct snd_emu10k1 *emu,
+                                      struct snd_emu10k1_fx8010_code *icode)
 {
        unsigned int i;
-       snd_ctl_elem_id_t __user *_id;
-       snd_ctl_elem_id_t id;
-       emu10k1_fx8010_control_gpr_t __user *_gctl;
-       emu10k1_fx8010_control_gpr_t gctl;
+       struct snd_ctl_elem_id __user *_id;
+       struct snd_ctl_elem_id id;
+       struct snd_emu10k1_fx8010_control_gpr __user *_gctl;
+       struct snd_emu10k1_fx8010_control_gpr *gctl;
+       int err;
        
        for (i = 0, _id = icode->gpr_del_controls;
             i < icode->gpr_del_control_count; i++, _id++) {
@@ -602,173 +664,219 @@ static int snd_emu10k1_verify_controls(emu10k1_t *emu, emu10k1_fx8010_code_t *ic
                if (snd_emu10k1_look_for_ctl(emu, &id) == NULL)
                        return -ENOENT;
        }
+       gctl = kmalloc(sizeof(*gctl), GFP_KERNEL);
+       if (! gctl)
+               return -ENOMEM;
+       err = 0;
        for (i = 0, _gctl = icode->gpr_add_controls;
             i < icode->gpr_add_control_count; i++, _gctl++) {
-               if (copy_from_user(&gctl, _gctl, sizeof(gctl)))
-                       return -EFAULT;
-               if (snd_emu10k1_look_for_ctl(emu, &gctl.id))
+               if (copy_from_user(gctl, _gctl, sizeof(*gctl))) {
+                       err = -EFAULT;
+                       goto __error;
+               }
+               if (snd_emu10k1_look_for_ctl(emu, &gctl->id))
                        continue;
                down_read(&emu->card->controls_rwsem);
-               if (snd_ctl_find_id(emu->card, &gctl.id) != NULL) {
+               if (snd_ctl_find_id(emu->card, &gctl->id) != NULL) {
                        up_read(&emu->card->controls_rwsem);
-                       return -EEXIST;
+                       err = -EEXIST;
+                       goto __error;
                }
                up_read(&emu->card->controls_rwsem);
-               if (gctl.id.iface != SNDRV_CTL_ELEM_IFACE_MIXER &&
-                   gctl.id.iface != SNDRV_CTL_ELEM_IFACE_PCM)
-                       return -EINVAL;
+               if (gctl->id.iface != SNDRV_CTL_ELEM_IFACE_MIXER &&
+                   gctl->id.iface != SNDRV_CTL_ELEM_IFACE_PCM) {
+                       err = -EINVAL;
+                       goto __error;
+               }
        }
        for (i = 0, _gctl = icode->gpr_list_controls;
             i < icode->gpr_list_control_count; i++, _gctl++) {
                /* FIXME: we need to check the WRITE access */
-               if (copy_from_user(&gctl, _gctl, sizeof(gctl)))
-                       return -EFAULT;
+               if (copy_from_user(gctl, _gctl, sizeof(*gctl))) {
+                       err = -EFAULT;
+                       goto __error;
+               }
        }
-       return 0;
+ __error:
+       kfree(gctl);
+       return err;
 }
 
-static void snd_emu10k1_ctl_private_free(snd_kcontrol_t *kctl)
+static void snd_emu10k1_ctl_private_free(struct snd_kcontrol *kctl)
 {
-       snd_emu10k1_fx8010_ctl_t *ctl;
+       struct snd_emu10k1_fx8010_ctl *ctl;
        
-       ctl = (snd_emu10k1_fx8010_ctl_t *)kctl->private_value;
+       ctl = (struct snd_emu10k1_fx8010_ctl *) kctl->private_value;
        kctl->private_value = 0;
        list_del(&ctl->list);
        kfree(ctl);
 }
 
-static void snd_emu10k1_add_controls(emu10k1_t *emu, emu10k1_fx8010_code_t *icode)
+static int snd_emu10k1_add_controls(struct snd_emu10k1 *emu,
+                                   struct snd_emu10k1_fx8010_code *icode)
 {
        unsigned int i, j;
-       emu10k1_fx8010_control_gpr_t __user *_gctl;
-       emu10k1_fx8010_control_gpr_t gctl;
-       snd_emu10k1_fx8010_ctl_t *ctl, nctl;
-       snd_kcontrol_new_t knew;
-       snd_kcontrol_t *kctl;
-       snd_ctl_elem_value_t *val;
-
-       val = (snd_ctl_elem_value_t *)kmalloc(sizeof(*val), GFP_KERNEL);
-       if (!val)
-               return;
+       struct snd_emu10k1_fx8010_control_gpr __user *_gctl;
+       struct snd_emu10k1_fx8010_control_gpr *gctl;
+       struct snd_emu10k1_fx8010_ctl *ctl, *nctl;
+       struct snd_kcontrol_new knew;
+       struct snd_kcontrol *kctl;
+       struct snd_ctl_elem_value *val;
+       int err = 0;
+
+       val = kmalloc(sizeof(*val), GFP_KERNEL);
+       gctl = kmalloc(sizeof(*gctl), GFP_KERNEL);
+       nctl = kmalloc(sizeof(*nctl), GFP_KERNEL);
+       if (!val || !gctl || !nctl) {
+               err = -ENOMEM;
+               goto __error;
+       }
+
        for (i = 0, _gctl = icode->gpr_add_controls;
             i < icode->gpr_add_control_count; i++, _gctl++) {
-               if (copy_from_user(&gctl, _gctl, sizeof(gctl)))
-                       break;
-               snd_runtime_check(gctl.id.iface == SNDRV_CTL_ELEM_IFACE_MIXER ||
-                                 gctl.id.iface == SNDRV_CTL_ELEM_IFACE_PCM, continue);
-               snd_runtime_check(gctl.id.name[0] != '\0', continue);
-               ctl = snd_emu10k1_look_for_ctl(emu, &gctl.id);
+               if (copy_from_user(gctl, _gctl, sizeof(*gctl))) {
+                       err = -EFAULT;
+                       goto __error;
+               }
+               if (gctl->id.iface != SNDRV_CTL_ELEM_IFACE_MIXER &&
+                   gctl->id.iface != SNDRV_CTL_ELEM_IFACE_PCM) {
+                       err = -EINVAL;
+                       goto __error;
+               }
+               if (! gctl->id.name[0]) {
+                       err = -EINVAL;
+                       goto __error;
+               }
+               ctl = snd_emu10k1_look_for_ctl(emu, &gctl->id);
                memset(&knew, 0, sizeof(knew));
-               knew.iface = gctl.id.iface;
-               knew.name = gctl.id.name;
-               knew.index = gctl.id.index;
-               knew.device = gctl.id.device;
-               knew.subdevice = gctl.id.subdevice;
+               knew.iface = gctl->id.iface;
+               knew.name = gctl->id.name;
+               knew.index = gctl->id.index;
+               knew.device = gctl->id.device;
+               knew.subdevice = gctl->id.subdevice;
                knew.info = snd_emu10k1_gpr_ctl_info;
                knew.get = snd_emu10k1_gpr_ctl_get;
                knew.put = snd_emu10k1_gpr_ctl_put;
-               memset(&nctl, 0, sizeof(nctl));
-               nctl.vcount = gctl.vcount;
-               nctl.count = gctl.count;
+               memset(nctl, 0, sizeof(*nctl));
+               nctl->vcount = gctl->vcount;
+               nctl->count = gctl->count;
                for (j = 0; j < 32; j++) {
-                       nctl.gpr[j] = gctl.gpr[j];
-                       nctl.value[j] = ~gctl.value[j]; /* inverted, we want to write new value in gpr_ctl_put() */
-                       val->value.integer.value[j] = gctl.value[j];
+                       nctl->gpr[j] = gctl->gpr[j];
+                       nctl->value[j] = ~gctl->value[j];       /* inverted, we want to write new value in gpr_ctl_put() */
+                       val->value.integer.value[j] = gctl->value[j];
                }
-               nctl.min = gctl.min;
-               nctl.max = gctl.max;
-               nctl.translation = gctl.translation;
+               nctl->min = gctl->min;
+               nctl->max = gctl->max;
+               nctl->translation = gctl->translation;
                if (ctl == NULL) {
-                       ctl = (snd_emu10k1_fx8010_ctl_t *)kmalloc(sizeof(*ctl), GFP_KERNEL);
-                       if (ctl == NULL)
-                               continue;
+                       ctl = kmalloc(sizeof(*ctl), GFP_KERNEL);
+                       if (ctl == NULL) {
+                               err = -ENOMEM;
+                               goto __error;
+                       }
                        knew.private_value = (unsigned long)ctl;
-                       memcpy(ctl, &nctl, sizeof(nctl));
-                       if (snd_ctl_add(emu->card, kctl = snd_ctl_new1(&knew, emu)) < 0) {
+                       *ctl = *nctl;
+                       if ((err = snd_ctl_add(emu->card, kctl = snd_ctl_new1(&knew, emu))) < 0) {
                                kfree(ctl);
-                               continue;
+                               goto __error;
                        }
                        kctl->private_free = snd_emu10k1_ctl_private_free;
                        ctl->kcontrol = kctl;
                        list_add_tail(&ctl->list, &emu->fx8010.gpr_ctl);
                } else {
                        /* overwrite */
-                       nctl.list = ctl->list;
-                       nctl.kcontrol = ctl->kcontrol;
-                       memcpy(ctl, &nctl, sizeof(nctl));
+                       nctl->list = ctl->list;
+                       nctl->kcontrol = ctl->kcontrol;
+                       *ctl = *nctl;
                        snd_ctl_notify(emu->card, SNDRV_CTL_EVENT_MASK_VALUE |
                                                  SNDRV_CTL_EVENT_MASK_INFO, &ctl->kcontrol->id);
                }
                snd_emu10k1_gpr_ctl_put(ctl->kcontrol, val);
        }
+      __error:
+       kfree(nctl);
+       kfree(gctl);
        kfree(val);
+       return err;
 }
 
-static void snd_emu10k1_del_controls(emu10k1_t *emu, emu10k1_fx8010_code_t *icode)
+static int snd_emu10k1_del_controls(struct snd_emu10k1 *emu,
+                                   struct snd_emu10k1_fx8010_code *icode)
 {
        unsigned int i;
-       snd_ctl_elem_id_t id;
-       snd_ctl_elem_id_t __user *_id;
-       snd_emu10k1_fx8010_ctl_t *ctl;
-       snd_card_t *card = emu->card;
+       struct snd_ctl_elem_id id;
+       struct snd_ctl_elem_id __user *_id;
+       struct snd_emu10k1_fx8010_ctl *ctl;
+       struct snd_card *card = emu->card;
        
        for (i = 0, _id = icode->gpr_del_controls;
             i < icode->gpr_del_control_count; i++, _id++) {
-               snd_runtime_check(copy_from_user(&id, _id, sizeof(id)) == 0, continue);
+               if (copy_from_user(&id, _id, sizeof(id)))
+                       return -EFAULT;
                down_write(&card->controls_rwsem);
                ctl = snd_emu10k1_look_for_ctl(emu, &id);
                if (ctl)
                        snd_ctl_remove(card, ctl->kcontrol);
                up_write(&card->controls_rwsem);
        }
+       return 0;
 }
 
-static int snd_emu10k1_list_controls(emu10k1_t *emu, emu10k1_fx8010_code_t *icode)
+static int snd_emu10k1_list_controls(struct snd_emu10k1 *emu,
+                                    struct snd_emu10k1_fx8010_code *icode)
 {
        unsigned int i = 0, j;
        unsigned int total = 0;
-       emu10k1_fx8010_control_gpr_t gctl;
-       emu10k1_fx8010_control_gpr_t __user *_gctl;
-       snd_emu10k1_fx8010_ctl_t *ctl;
-       snd_ctl_elem_id_t *id;
+       struct snd_emu10k1_fx8010_control_gpr *gctl;
+       struct snd_emu10k1_fx8010_control_gpr __user *_gctl;
+       struct snd_emu10k1_fx8010_ctl *ctl;
+       struct snd_ctl_elem_id *id;
        struct list_head *list;
 
+       gctl = kmalloc(sizeof(*gctl), GFP_KERNEL);
+       if (! gctl)
+               return -ENOMEM;
+
        _gctl = icode->gpr_list_controls;       
        list_for_each(list, &emu->fx8010.gpr_ctl) {
                ctl = emu10k1_gpr_ctl(list);
                total++;
                if (_gctl && i < icode->gpr_list_control_count) {
-                       memset(&gctl, 0, sizeof(gctl));
+                       memset(gctl, 0, sizeof(*gctl));
                        id = &ctl->kcontrol->id;
-                       gctl.id.iface = id->iface;
-                       strlcpy(gctl.id.name, id->name, sizeof(gctl.id.name));
-                       gctl.id.index = id->index;
-                       gctl.id.device = id->device;
-                       gctl.id.subdevice = id->subdevice;
-                       gctl.vcount = ctl->vcount;
-                       gctl.count = ctl->count;
+                       gctl->id.iface = id->iface;
+                       strlcpy(gctl->id.name, id->name, sizeof(gctl->id.name));
+                       gctl->id.index = id->index;
+                       gctl->id.device = id->device;
+                       gctl->id.subdevice = id->subdevice;
+                       gctl->vcount = ctl->vcount;
+                       gctl->count = ctl->count;
                        for (j = 0; j < 32; j++) {
-                               gctl.gpr[j] = ctl->gpr[j];
-                               gctl.value[j] = ctl->value[j];
+                               gctl->gpr[j] = ctl->gpr[j];
+                               gctl->value[j] = ctl->value[j];
                        }
-                       gctl.min = ctl->min;
-                       gctl.max = ctl->max;
-                       gctl.translation = ctl->translation;
-                       if (copy_to_user(_gctl, &gctl, sizeof(gctl)))
+                       gctl->min = ctl->min;
+                       gctl->max = ctl->max;
+                       gctl->translation = ctl->translation;
+                       if (copy_to_user(_gctl, gctl, sizeof(*gctl))) {
+                               kfree(gctl);
                                return -EFAULT;
+                       }
                        _gctl++;
                        i++;
                }
        }
        icode->gpr_list_control_total = total;
+       kfree(gctl);
        return 0;
 }
 
-static int snd_emu10k1_icode_poke(emu10k1_t *emu, emu10k1_fx8010_code_t *icode)
+static int snd_emu10k1_icode_poke(struct snd_emu10k1 *emu,
+                                 struct snd_emu10k1_fx8010_code *icode)
 {
        int err = 0;
 
-       down(&emu->fx8010.lock);
+       mutex_lock(&emu->fx8010.lock);
        if ((err = snd_emu10k1_verify_controls(emu, icode)) < 0)
                goto __error;
        strlcpy(emu->fx8010.name, icode->name, sizeof(emu->fx8010.name));
@@ -779,48 +887,54 @@ static int snd_emu10k1_icode_poke(emu10k1_t *emu, emu10k1_fx8010_code_t *icode)
        else
                snd_emu10k1_ptr_write(emu, DBG, 0, emu->fx8010.dbg | EMU10K1_DBG_SINGLE_STEP);
        /* ok, do the main job */
-       snd_emu10k1_del_controls(emu, icode);
-       snd_emu10k1_gpr_poke(emu, icode);
-       snd_emu10k1_tram_poke(emu, icode);
-       snd_emu10k1_code_poke(emu, icode);
-       snd_emu10k1_add_controls(emu, icode);
+       if ((err = snd_emu10k1_del_controls(emu, icode)) < 0 ||
+           (err = snd_emu10k1_gpr_poke(emu, icode)) < 0 ||
+           (err = snd_emu10k1_tram_poke(emu, icode)) < 0 ||
+           (err = snd_emu10k1_code_poke(emu, icode)) < 0 ||
+           (err = snd_emu10k1_add_controls(emu, icode)) < 0)
+               goto __error;
        /* start FX processor when the DSP code is updated */
        if (emu->audigy)
                snd_emu10k1_ptr_write(emu, A_DBG, 0, emu->fx8010.dbg);
        else
                snd_emu10k1_ptr_write(emu, DBG, 0, emu->fx8010.dbg);
       __error:
-       up(&emu->fx8010.lock);
+       mutex_unlock(&emu->fx8010.lock);
        return err;
 }
 
-static int snd_emu10k1_icode_peek(emu10k1_t *emu, emu10k1_fx8010_code_t *icode)
+static int snd_emu10k1_icode_peek(struct snd_emu10k1 *emu,
+                                 struct snd_emu10k1_fx8010_code *icode)
 {
        int err;
 
-       down(&emu->fx8010.lock);
+       mutex_lock(&emu->fx8010.lock);
        strlcpy(icode->name, emu->fx8010.name, sizeof(icode->name));
        /* ok, do the main job */
-       snd_emu10k1_gpr_peek(emu, icode);
-       snd_emu10k1_tram_peek(emu, icode);
-       snd_emu10k1_code_peek(emu, icode);
-       err = snd_emu10k1_list_controls(emu, icode);
-       up(&emu->fx8010.lock);
+       err = snd_emu10k1_gpr_peek(emu, icode);
+       if (err >= 0)
+               err = snd_emu10k1_tram_peek(emu, icode);
+       if (err >= 0)
+               err = snd_emu10k1_code_peek(emu, icode);
+       if (err >= 0)
+               err = snd_emu10k1_list_controls(emu, icode);
+       mutex_unlock(&emu->fx8010.lock);
        return err;
 }
 
-static int snd_emu10k1_ipcm_poke(emu10k1_t *emu, emu10k1_fx8010_pcm_t *ipcm)
+static int snd_emu10k1_ipcm_poke(struct snd_emu10k1 *emu,
+                                struct snd_emu10k1_fx8010_pcm_rec *ipcm)
 {
        unsigned int i;
        int err = 0;
-       snd_emu10k1_fx8010_pcm_t *pcm;
+       struct snd_emu10k1_fx8010_pcm *pcm;
 
        if (ipcm->substream >= EMU10K1_FX8010_PCM_COUNT)
                return -EINVAL;
        if (ipcm->channels > 32)
                return -EINVAL;
        pcm = &emu->fx8010.pcm[ipcm->substream];
-       down(&emu->fx8010.lock);
+       mutex_lock(&emu->fx8010.lock);
        spin_lock_irq(&emu->reg_lock);
        if (pcm->opened) {
                err = -EBUSY;
@@ -850,20 +964,21 @@ static int snd_emu10k1_ipcm_poke(emu10k1_t *emu, emu10k1_fx8010_pcm_t *ipcm)
        }
       __error:
        spin_unlock_irq(&emu->reg_lock);
-       up(&emu->fx8010.lock);
+       mutex_unlock(&emu->fx8010.lock);
        return err;
 }
 
-static int snd_emu10k1_ipcm_peek(emu10k1_t *emu, emu10k1_fx8010_pcm_t *ipcm)
+static int snd_emu10k1_ipcm_peek(struct snd_emu10k1 *emu,
+                                struct snd_emu10k1_fx8010_pcm_rec *ipcm)
 {
        unsigned int i;
        int err = 0;
-       snd_emu10k1_fx8010_pcm_t *pcm;
+       struct snd_emu10k1_fx8010_pcm *pcm;
 
        if (ipcm->substream >= EMU10K1_FX8010_PCM_COUNT)
                return -EINVAL;
        pcm = &emu->fx8010.pcm[ipcm->substream];
-       down(&emu->fx8010.lock);
+       mutex_lock(&emu->fx8010.lock);
        spin_lock_irq(&emu->reg_lock);
        ipcm->channels = pcm->channels;
        ipcm->tram_start = pcm->tram_start;
@@ -879,16 +994,18 @@ static int snd_emu10k1_ipcm_peek(emu10k1_t *emu, emu10k1_fx8010_pcm_t *ipcm)
        ipcm->res1 = ipcm->res2 = 0;
        ipcm->pad = 0;
        spin_unlock_irq(&emu->reg_lock);
-       up(&emu->fx8010.lock);
+       mutex_unlock(&emu->fx8010.lock);
        return err;
 }
 
-#define SND_EMU10K1_GPR_CONTROLS       41
-#define SND_EMU10K1_INPUTS             10
+#define SND_EMU10K1_GPR_CONTROLS       44
+#define SND_EMU10K1_INPUTS             12
 #define SND_EMU10K1_PLAYBACK_CHANNELS  8
 #define SND_EMU10K1_CAPTURE_CHANNELS   4
 
-static void __devinit snd_emu10k1_init_mono_control(emu10k1_fx8010_control_gpr_t *ctl, const char *name, int gpr, int defval)
+static void __devinit
+snd_emu10k1_init_mono_control(struct snd_emu10k1_fx8010_control_gpr *ctl,
+                             const char *name, int gpr, int defval)
 {
        ctl->id.iface = SNDRV_CTL_ELEM_IFACE_MIXER;
        strcpy(ctl->id.name, name);
@@ -899,7 +1016,9 @@ static void __devinit snd_emu10k1_init_mono_control(emu10k1_fx8010_control_gpr_t
        ctl->translation = EMU10K1_GPR_TRANSLATION_TABLE100;    
 }
 
-static void __devinit snd_emu10k1_init_stereo_control(emu10k1_fx8010_control_gpr_t *ctl, const char *name, int gpr, int defval)
+static void __devinit
+snd_emu10k1_init_stereo_control(struct snd_emu10k1_fx8010_control_gpr *ctl,
+                               const char *name, int gpr, int defval)
 {
        ctl->id.iface = SNDRV_CTL_ELEM_IFACE_MIXER;
        strcpy(ctl->id.name, name);
@@ -911,7 +1030,9 @@ static void __devinit snd_emu10k1_init_stereo_control(emu10k1_fx8010_control_gpr
        ctl->translation = EMU10K1_GPR_TRANSLATION_TABLE100;
 }
 
-static void __devinit snd_emu10k1_init_mono_onoff_control(emu10k1_fx8010_control_gpr_t *ctl, const char *name, int gpr, int defval)
+static void __devinit
+snd_emu10k1_init_mono_onoff_control(struct snd_emu10k1_fx8010_control_gpr *ctl,
+                                   const char *name, int gpr, int defval)
 {
        ctl->id.iface = SNDRV_CTL_ELEM_IFACE_MIXER;
        strcpy(ctl->id.name, name);
@@ -922,7 +1043,9 @@ static void __devinit snd_emu10k1_init_mono_onoff_control(emu10k1_fx8010_control
        ctl->translation = EMU10K1_GPR_TRANSLATION_ONOFF;
 }
 
-static void __devinit snd_emu10k1_init_stereo_onoff_control(emu10k1_fx8010_control_gpr_t *ctl, const char *name, int gpr, int defval)
+static void __devinit
+snd_emu10k1_init_stereo_onoff_control(struct snd_emu10k1_fx8010_control_gpr *ctl,
+                                     const char *name, int gpr, int defval)
 {
        ctl->id.iface = SNDRV_CTL_ELEM_IFACE_MIXER;
        strcpy(ctl->id.name, name);
@@ -939,7 +1062,7 @@ static void __devinit snd_emu10k1_init_stereo_onoff_control(emu10k1_fx8010_contr
  * initial DSP configuration for Audigy
  */
 
-static int __devinit _snd_emu10k1_audigy_init_efx(emu10k1_t *emu)
+static int __devinit _snd_emu10k1_audigy_init_efx(struct snd_emu10k1 *emu)
 {
        int err, i, z, gpr, nctl;
        const int playback = 10;
@@ -947,23 +1070,33 @@ static int __devinit _snd_emu10k1_audigy_init_efx(emu10k1_t *emu)
        const int stereo_mix = capture + 2;
        const int tmp = 0x88;
        u32 ptr;
-       emu10k1_fx8010_code_t *icode;
-       emu10k1_fx8010_control_gpr_t *controls, *ctl;
+       struct snd_emu10k1_fx8010_code *icode = NULL;
+       struct snd_emu10k1_fx8010_control_gpr *controls = NULL, *ctl;
+       u32 *gpr_map;
        mm_segment_t seg;
 
-       spin_lock_init(&emu->fx8010.irq_lock);
-       INIT_LIST_HEAD(&emu->fx8010.gpr_ctl);
-
-       if ((icode = kcalloc(1, sizeof(*icode), GFP_KERNEL)) == NULL)
-               return -ENOMEM;
-       if ((controls = kcalloc(SND_EMU10K1_GPR_CONTROLS, sizeof(*controls), GFP_KERNEL)) == NULL) {
-               kfree(icode);
-               return -ENOMEM;
+       if ((icode = kzalloc(sizeof(*icode), GFP_KERNEL)) == NULL ||
+           (icode->gpr_map = (u_int32_t __user *)
+            kcalloc(512 + 256 + 256 + 2 * 1024, sizeof(u_int32_t),
+                    GFP_KERNEL)) == NULL ||
+           (controls = kcalloc(SND_EMU10K1_GPR_CONTROLS,
+                               sizeof(*controls), GFP_KERNEL)) == NULL) {
+               err = -ENOMEM;
+               goto __err;
        }
+       gpr_map = (u32 __force *)icode->gpr_map;
+
+       icode->tram_data_map = icode->gpr_map + 512;
+       icode->tram_addr_map = icode->tram_data_map + 256;
+       icode->code = icode->tram_addr_map + 256;
 
        /* clear free GPRs */
-       for (i = 0; i < 256; i++)
+       for (i = 0; i < 512; i++)
                set_bit(i, icode->gpr_valid);
+               
+       /* clear TRAM data & address lines */
+       for (i = 0; i < 256; i++)
+               set_bit(i, icode->tram_valid);
 
        strcpy(icode->name, "Audigy DSP code for ALSA");
        ptr = 0;
@@ -973,6 +1106,14 @@ static int __devinit _snd_emu10k1_audigy_init_efx(emu10k1_t *emu)
        /* stop FX processor */
        snd_emu10k1_ptr_write(emu, A_DBG, 0, (emu->fx8010.dbg = 0) | A_DBG_SINGLE_STEP);
 
+#if 0
+       /* FIX: jcd test */
+       for (z = 0; z < 80; z=z+2) {
+               A_OP(icode, &ptr, iACC3, A_EXTOUT(z), A_FXBUS(FXBUS_PCM_LEFT_FRONT), A_C_00000000, A_C_00000000); /* left */
+               A_OP(icode, &ptr, iACC3, A_EXTOUT(z+1), A_FXBUS(FXBUS_PCM_RIGHT_FRONT), A_C_00000000, A_C_00000000); /* right */
+       }
+#endif /* jcd test */
+#if 1
        /* PCM front Playback Volume (independent from stereo mix) */
        A_OP(icode, &ptr, iMAC0, A_GPR(playback), A_C_00000000, A_GPR(gpr), A_FXBUS(FXBUS_PCM_LEFT_FRONT));
        A_OP(icode, &ptr, iMAC0, A_GPR(playback+1), A_C_00000000, A_GPR(gpr+1), A_FXBUS(FXBUS_PCM_RIGHT_FRONT));
@@ -986,7 +1127,7 @@ static int __devinit _snd_emu10k1_audigy_init_efx(emu10k1_t *emu)
        gpr += 2;
        
        /* PCM Side Playback (independent from stereo mix) */
-       if (emu->spk71) {
+       if (emu->card_capabilities->spk71) {
                A_OP(icode, &ptr, iMAC0, A_GPR(playback+6), A_C_00000000, A_GPR(gpr), A_FXBUS(FXBUS_PCM_LEFT_SIDE));
                A_OP(icode, &ptr, iMAC0, A_GPR(playback+7), A_C_00000000, A_GPR(gpr+1), A_FXBUS(FXBUS_PCM_RIGHT_SIDE));
                snd_emu10k1_init_stereo_control(&controls[nctl++], "PCM Side Playback Volume", gpr, 100);
@@ -1012,10 +1153,10 @@ static int __devinit _snd_emu10k1_audigy_init_efx(emu10k1_t *emu)
        snd_emu10k1_init_stereo_control(&controls[nctl++], "Wave Playback Volume", gpr, 100);
        gpr += 2;
 
-       /* Music Playback */
+       /* Synth Playback */
        A_OP(icode, &ptr, iMAC0, A_GPR(stereo_mix+0), A_GPR(stereo_mix+0), A_GPR(gpr), A_FXBUS(FXBUS_MIDI_LEFT));
        A_OP(icode, &ptr, iMAC0, A_GPR(stereo_mix+1), A_GPR(stereo_mix+1), A_GPR(gpr+1), A_FXBUS(FXBUS_MIDI_RIGHT));
-       snd_emu10k1_init_stereo_control(&controls[nctl++], "Music Playback Volume", gpr, 100);
+       snd_emu10k1_init_stereo_control(&controls[nctl++], "Synth Playback Volume", gpr, 100);
        gpr += 2;
 
        /* Wave (PCM) Capture */
@@ -1024,10 +1165,10 @@ static int __devinit _snd_emu10k1_audigy_init_efx(emu10k1_t *emu)
        snd_emu10k1_init_stereo_control(&controls[nctl++], "PCM Capture Volume", gpr, 0);
        gpr += 2;
 
-       /* Music Capture */
+       /* Synth Capture */
        A_OP(icode, &ptr, iMAC0, A_GPR(capture+0), A_GPR(capture+0), A_GPR(gpr), A_FXBUS(FXBUS_MIDI_LEFT));
        A_OP(icode, &ptr, iMAC0, A_GPR(capture+1), A_GPR(capture+1), A_GPR(gpr+1), A_FXBUS(FXBUS_MIDI_RIGHT));
-       snd_emu10k1_init_stereo_control(&controls[nctl++], "Music Capture Volume", gpr, 0);
+       snd_emu10k1_init_stereo_control(&controls[nctl++], "Synth Capture Volume", gpr, 0);
        gpr += 2;
 
        /*
@@ -1054,40 +1195,40 @@ A_OP(icode, &ptr, iMAC0, A_GPR(var), A_GPR(var), A_GPR(vol), A_EXTIN(input))
        A_ADD_VOLUME_IN(stereo_mix, gpr, A_EXTIN_SPDIF_CD_L);
        A_ADD_VOLUME_IN(stereo_mix+1, gpr+1, A_EXTIN_SPDIF_CD_R);
        snd_emu10k1_init_stereo_control(&controls[nctl++],
-                                       emu->no_ac97 ? "CD Playback Volume" : "Audigy CD Playback Volume",
+                                       emu->card_capabilities->ac97_chip ? "Audigy CD Playback Volume" : "CD Playback Volume",
                                        gpr, 0);
        gpr += 2;
        /* Audigy CD Capture Volume */
        A_ADD_VOLUME_IN(capture, gpr, A_EXTIN_SPDIF_CD_L);
        A_ADD_VOLUME_IN(capture+1, gpr+1, A_EXTIN_SPDIF_CD_R);
        snd_emu10k1_init_stereo_control(&controls[nctl++],
-                                       emu->no_ac97 ? "CD Capture Volume" : "Audigy CD Capture Volume",
+                                       emu->card_capabilities->ac97_chip ? "Audigy CD Capture Volume" : "CD Capture Volume",
                                        gpr, 0);
        gpr += 2;
 
        /* Optical SPDIF Playback Volume */
        A_ADD_VOLUME_IN(stereo_mix, gpr, A_EXTIN_OPT_SPDIF_L);
        A_ADD_VOLUME_IN(stereo_mix+1, gpr+1, A_EXTIN_OPT_SPDIF_R);
-       snd_emu10k1_init_stereo_control(&controls[nctl++], "IEC958 Optical Playback Volume", gpr, 0);
+       snd_emu10k1_init_stereo_control(&controls[nctl++], SNDRV_CTL_NAME_IEC958("Optical ",PLAYBACK,VOLUME), gpr, 0);
        gpr += 2;
        /* Optical SPDIF Capture Volume */
        A_ADD_VOLUME_IN(capture, gpr, A_EXTIN_OPT_SPDIF_L);
        A_ADD_VOLUME_IN(capture+1, gpr+1, A_EXTIN_OPT_SPDIF_R);
-       snd_emu10k1_init_stereo_control(&controls[nctl++], "IEC958 Optical Capture Volume", gpr, 0);
+       snd_emu10k1_init_stereo_control(&controls[nctl++], SNDRV_CTL_NAME_IEC958("Optical ",CAPTURE,VOLUME), gpr, 0);
        gpr += 2;
 
        /* Line2 Playback Volume */
        A_ADD_VOLUME_IN(stereo_mix, gpr, A_EXTIN_LINE2_L);
        A_ADD_VOLUME_IN(stereo_mix+1, gpr+1, A_EXTIN_LINE2_R);
        snd_emu10k1_init_stereo_control(&controls[nctl++],
-                                       emu->no_ac97 ? "Line Playback Volume" : "Line2 Playback Volume",
+                                       emu->card_capabilities->ac97_chip ? "Line2 Playback Volume" : "Line Playback Volume",
                                        gpr, 0);
        gpr += 2;
        /* Line2 Capture Volume */
        A_ADD_VOLUME_IN(capture, gpr, A_EXTIN_LINE2_L);
        A_ADD_VOLUME_IN(capture+1, gpr+1, A_EXTIN_LINE2_R);
        snd_emu10k1_init_stereo_control(&controls[nctl++],
-                                       emu->no_ac97 ? "Line Capture Volume" : "Line2 Capture Volume",
+                                       emu->card_capabilities->ac97_chip ? "Line2 Capture Volume" : "Line Capture Volume",
                                        gpr, 0);
        gpr += 2;
         
@@ -1106,14 +1247,14 @@ A_OP(icode, &ptr, iMAC0, A_GPR(var), A_GPR(var), A_GPR(vol), A_EXTIN(input))
        A_ADD_VOLUME_IN(stereo_mix, gpr, A_EXTIN_AUX2_L);
        A_ADD_VOLUME_IN(stereo_mix+1, gpr+1, A_EXTIN_AUX2_R);
        snd_emu10k1_init_stereo_control(&controls[nctl++],
-                                       emu->no_ac97 ? "Aux Playback Volume" : "Aux2 Playback Volume",
+                                       emu->card_capabilities->ac97_chip ? "Aux2 Playback Volume" : "Aux Playback Volume",
                                        gpr, 0);
        gpr += 2;
        /* Aux2 Capture Volume */
        A_ADD_VOLUME_IN(capture, gpr, A_EXTIN_AUX2_L);
        A_ADD_VOLUME_IN(capture+1, gpr+1, A_EXTIN_AUX2_R);
        snd_emu10k1_init_stereo_control(&controls[nctl++],
-                                       emu->no_ac97 ? "Aux Capture Volume" : "Aux2 Capture Volume",
+                                       emu->card_capabilities->ac97_chip ? "Aux2 Capture Volume" : "Aux Capture Volume",
                                        gpr, 0);
        gpr += 2;
        
@@ -1141,7 +1282,7 @@ A_OP(icode, &ptr, iMAC0, A_GPR(var), A_GPR(var), A_GPR(vol), A_EXTIN(input))
        snd_emu10k1_init_mono_control(&controls[nctl++], "LFE Playback Volume", gpr, 0);
        gpr++;
        
-       if (emu->spk71) {
+       if (emu->card_capabilities->spk71) {
                /* Stereo Mix Side Playback */
                A_OP(icode, &ptr, iMAC0, A_GPR(playback+6), A_GPR(playback+6), A_GPR(gpr), A_GPR(stereo_mix));
                A_OP(icode, &ptr, iMAC0, A_GPR(playback+7), A_GPR(playback+7), A_GPR(gpr+1), A_GPR(stereo_mix+1));
@@ -1175,7 +1316,7 @@ A_OP(icode, &ptr, iMAC0, A_GPR(var), A_GPR(var), A_GPR(vol), A_EXTIN(input))
        A_OP(icode, &ptr, iACC3, A_GPR(playback + SND_EMU10K1_PLAYBACK_CHANNELS + 3), A_GPR(playback + 3), A_C_00000000, A_C_00000000); /* rear right */
        A_OP(icode, &ptr, iACC3, A_GPR(playback + SND_EMU10K1_PLAYBACK_CHANNELS + 4), A_GPR(playback + 4), A_C_00000000, A_C_00000000); /* center */
        A_OP(icode, &ptr, iACC3, A_GPR(playback + SND_EMU10K1_PLAYBACK_CHANNELS + 5), A_GPR(playback + 5), A_C_00000000, A_C_00000000); /* LFE */
-       if (emu->spk71) {
+       if (emu->card_capabilities->spk71) {
                A_OP(icode, &ptr, iACC3, A_GPR(playback + SND_EMU10K1_PLAYBACK_CHANNELS + 6), A_GPR(playback + 6), A_C_00000000, A_C_00000000); /* side left */
                A_OP(icode, &ptr, iACC3, A_GPR(playback + SND_EMU10K1_PLAYBACK_CHANNELS + 7), A_GPR(playback + 7), A_C_00000000, A_C_00000000); /* side right */
        }
@@ -1268,7 +1409,7 @@ A_OP(icode, &ptr, iMAC0, A_GPR(var), A_GPR(var), A_GPR(vol), A_EXTIN(input))
        A_PUT_STEREO_OUTPUT(A_EXTOUT_AREAR_L, A_EXTOUT_AREAR_R, playback+2 + SND_EMU10K1_PLAYBACK_CHANNELS);
        A_PUT_OUTPUT(A_EXTOUT_ACENTER, playback+4 + SND_EMU10K1_PLAYBACK_CHANNELS);
        A_PUT_OUTPUT(A_EXTOUT_ALFE, playback+5 + SND_EMU10K1_PLAYBACK_CHANNELS);
-       if (emu->spk71)
+       if (emu->card_capabilities->spk71)
                A_PUT_STEREO_OUTPUT(A_EXTOUT_ASIDE_L, A_EXTOUT_ASIDE_R, playback+6 + SND_EMU10K1_PLAYBACK_CHANNELS);
 
        /* headphone */
@@ -1278,8 +1419,9 @@ A_OP(icode, &ptr, iMAC0, A_GPR(var), A_GPR(var), A_GPR(vol), A_EXTIN(input))
        /* A_PUT_STEREO_OUTPUT(A_EXTOUT_FRONT_L, A_EXTOUT_FRONT_R, playback + SND_EMU10K1_PLAYBACK_CHANNELS); */
 
        /* IEC958 Optical Raw Playback Switch */ 
-       icode->gpr_map[gpr++] = 0x1008;
-       icode->gpr_map[gpr++] = 0xffff0000;
+       gpr_map[gpr++] = 0;
+       gpr_map[gpr++] = 0x1008;
+       gpr_map[gpr++] = 0xffff0000;
        for (z = 0; z < 2; z++) {
                A_OP(icode, &ptr, iMAC0, A_GPR(tmp + 2), A_FXBUS(FXBUS_PT_LEFT + z), A_C_00000000, A_C_00000000);
                A_OP(icode, &ptr, iSKIP, A_GPR_COND, A_GPR_COND, A_GPR(gpr - 2), A_C_00000001);
@@ -1288,9 +1430,16 @@ A_OP(icode, &ptr, iMAC0, A_GPR(var), A_GPR(var), A_GPR(vol), A_EXTIN(input))
                A_SWITCH(icode, &ptr, tmp + 0, tmp + 2, gpr + z);
                A_SWITCH_NEG(icode, &ptr, tmp + 1, gpr + z);
                A_SWITCH(icode, &ptr, tmp + 1, playback + SND_EMU10K1_PLAYBACK_CHANNELS + z, tmp + 1);
-               A_OP(icode, &ptr, iACC3, A_EXTOUT(A_EXTOUT_FRONT_L + z), A_GPR(tmp + 0), A_GPR(tmp + 1), A_C_00000000);
+               if ((z==1) && (emu->card_capabilities->spdif_bug)) {
+                       /* Due to a SPDIF output bug on some Audigy cards, this code delays the Right channel by 1 sample */
+                       snd_printk(KERN_INFO "Installing spdif_bug patch: %s\n", emu->card_capabilities->name);
+                       A_OP(icode, &ptr, iACC3, A_EXTOUT(A_EXTOUT_FRONT_L + z), A_GPR(gpr - 3), A_C_00000000, A_C_00000000);
+                       A_OP(icode, &ptr, iACC3, A_GPR(gpr - 3), A_GPR(tmp + 0), A_GPR(tmp + 1), A_C_00000000);
+               } else {
+                       A_OP(icode, &ptr, iACC3, A_EXTOUT(A_EXTOUT_FRONT_L + z), A_GPR(tmp + 0), A_GPR(tmp + 1), A_C_00000000);
+               }
        }
-       snd_emu10k1_init_stereo_onoff_control(controls + nctl++, "IEC958 Optical Raw Playback Switch", gpr, 0);
+       snd_emu10k1_init_stereo_onoff_control(controls + nctl++, SNDRV_CTL_NAME_IEC958("Optical Raw ",PLAYBACK,SWITCH), gpr, 0);
        gpr += 2;
        
        A_PUT_STEREO_OUTPUT(A_EXTOUT_REAR_L, A_EXTOUT_REAR_R, playback+2 + SND_EMU10K1_PLAYBACK_CHANNELS);
@@ -1298,9 +1447,19 @@ A_OP(icode, &ptr, iMAC0, A_GPR(var), A_GPR(var), A_GPR(vol), A_EXTIN(input))
        A_PUT_OUTPUT(A_EXTOUT_LFE, playback+5 + SND_EMU10K1_PLAYBACK_CHANNELS);
 
        /* ADC buffer */
+#ifdef EMU10K1_CAPTURE_DIGITAL_OUT
+       A_PUT_STEREO_OUTPUT(A_EXTOUT_ADC_CAP_L, A_EXTOUT_ADC_CAP_R, playback + SND_EMU10K1_PLAYBACK_CHANNELS);
+#else
        A_PUT_OUTPUT(A_EXTOUT_ADC_CAP_L, capture);
        A_PUT_OUTPUT(A_EXTOUT_ADC_CAP_R, capture+1);
+#endif
 
+       /* EFX capture - capture the 16 EXTINs */
+       for (z = 0; z < 16; z++) {
+               A_OP(icode, &ptr, iACC3, A_FXBUS2(z), A_C_00000000, A_C_00000000, A_EXTIN(z));
+       }
+       
+#endif /* JCD test */
        /*
         * ok, set up done..
         */
@@ -1311,18 +1470,21 @@ A_OP(icode, &ptr, iMAC0, A_GPR(var), A_GPR(var), A_GPR(vol), A_EXTIN(input))
                goto __err;
        }
        /* clear remaining instruction memory */
-       while (ptr < 0x200)
+       while (ptr < 0x400)
                A_OP(icode, &ptr, 0x0f, 0xc0, 0xc0, 0xcf, 0xc0);
 
        seg = snd_enter_user();
        icode->gpr_add_control_count = nctl;
-       icode->gpr_add_controls = controls;
+       icode->gpr_add_controls = (struct snd_emu10k1_fx8010_control_gpr __user *)controls;
        err = snd_emu10k1_icode_poke(emu, icode);
        snd_leave_user(seg);
 
  __err:
        kfree(controls);
-       kfree(icode);
+       if (icode != NULL) {
+               kfree((void __force *)icode->gpr_map);
+               kfree(icode);
+       }
        return err;
 }
 
@@ -1333,14 +1495,14 @@ A_OP(icode, &ptr, iMAC0, A_GPR(var), A_GPR(var), A_GPR(vol), A_EXTIN(input))
 
 /* when volume = max, then copy only to avoid volume modification */
 /* with iMAC0 (negative values) */
-static void __devinit _volume(emu10k1_fx8010_code_t *icode, u32 *ptr, u32 dst, u32 src, u32 vol)
+static void __devinit _volume(struct snd_emu10k1_fx8010_code *icode, u32 *ptr, u32 dst, u32 src, u32 vol)
 {
        OP(icode, ptr, iMAC0, dst, C_00000000, src, vol);
        OP(icode, ptr, iANDXOR, C_00000000, vol, C_ffffffff, C_7fffffff);
        OP(icode, ptr, iSKIP, GPR_COND, GPR_COND, CC_REG_NONZERO, C_00000001);
        OP(icode, ptr, iACC3, dst, src, C_00000000, C_00000000);
 }
-static void __devinit _volume_add(emu10k1_fx8010_code_t *icode, u32 *ptr, u32 dst, u32 src, u32 vol)
+static void __devinit _volume_add(struct snd_emu10k1_fx8010_code *icode, u32 *ptr, u32 dst, u32 src, u32 vol)
 {
        OP(icode, ptr, iANDXOR, C_00000000, vol, C_ffffffff, C_7fffffff);
        OP(icode, ptr, iSKIP, GPR_COND, GPR_COND, CC_REG_NONZERO, C_00000002);
@@ -1348,7 +1510,7 @@ static void __devinit _volume_add(emu10k1_fx8010_code_t *icode, u32 *ptr, u32 ds
        OP(icode, ptr, iSKIP, C_00000000, C_7fffffff, C_7fffffff, C_00000001);
        OP(icode, ptr, iMAC0, dst, dst, src, vol);
 }
-static void __devinit _volume_out(emu10k1_fx8010_code_t *icode, u32 *ptr, u32 dst, u32 src, u32 vol)
+static void __devinit _volume_out(struct snd_emu10k1_fx8010_code *icode, u32 *ptr, u32 dst, u32 src, u32 vol)
 {
        OP(icode, ptr, iANDXOR, C_00000000, vol, C_ffffffff, C_7fffffff);
        OP(icode, ptr, iSKIP, GPR_COND, GPR_COND, CC_REG_NONZERO, C_00000002);
@@ -1379,29 +1541,33 @@ static void __devinit _volume_out(emu10k1_fx8010_code_t *icode, u32 *ptr, u32 ds
                _SWITCH_NEG(icode, ptr, GPR(dst), GPR(src))
 
 
-static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
+static int __devinit _snd_emu10k1_init_efx(struct snd_emu10k1 *emu)
 {
        int err, i, z, gpr, tmp, playback, capture;
        u32 ptr;
-       emu10k1_fx8010_code_t *icode;
-       emu10k1_fx8010_pcm_t *ipcm;
-       emu10k1_fx8010_control_gpr_t *controls, *ctl;
+       struct snd_emu10k1_fx8010_code *icode;
+       struct snd_emu10k1_fx8010_pcm_rec *ipcm = NULL;
+       struct snd_emu10k1_fx8010_control_gpr *controls = NULL, *ctl;
+       u32 *gpr_map;
        mm_segment_t seg;
 
-       spin_lock_init(&emu->fx8010.irq_lock);
-       INIT_LIST_HEAD(&emu->fx8010.gpr_ctl);
-
-       if ((icode = kcalloc(1, sizeof(*icode), GFP_KERNEL)) == NULL)
-               return -ENOMEM;
-       if ((controls = kcalloc(SND_EMU10K1_GPR_CONTROLS, sizeof(emu10k1_fx8010_control_gpr_t), GFP_KERNEL)) == NULL) {
-               kfree(icode);
-               return -ENOMEM;
-       }
-       if ((ipcm = kcalloc(1, sizeof(*ipcm), GFP_KERNEL)) == NULL) {
-               kfree(controls);
-               kfree(icode);
+       if ((icode = kzalloc(sizeof(*icode), GFP_KERNEL)) == NULL)
                return -ENOMEM;
+       if ((icode->gpr_map = (u_int32_t __user *)
+            kcalloc(256 + 160 + 160 + 2 * 512, sizeof(u_int32_t),
+                    GFP_KERNEL)) == NULL ||
+            (controls = kcalloc(SND_EMU10K1_GPR_CONTROLS,
+                               sizeof(struct snd_emu10k1_fx8010_control_gpr),
+                               GFP_KERNEL)) == NULL ||
+           (ipcm = kzalloc(sizeof(*ipcm), GFP_KERNEL)) == NULL) {
+               err = -ENOMEM;
+               goto __err;
        }
+       gpr_map = (u32 __force *)icode->gpr_map;
+
+       icode->tram_data_map = icode->gpr_map + 256;
+       icode->tram_addr_map = icode->tram_data_map + 160;
+       icode->code = icode->tram_addr_map + 160;
        
        /* clear free GPRs */
        for (i = 0; i < 256; i++)
@@ -1413,7 +1579,7 @@ static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
 
        strcpy(icode->name, "SB Live! FX8010 code for ALSA v1.2 by Jaroslav Kysela");
        ptr = 0; i = 0;
-       /* we have 10 inputs */
+       /* we have 12 inputs */
        playback = SND_EMU10K1_INPUTS;
        /* we have 6 playback channels and tone control doubles */
        capture = playback + (SND_EMU10K1_PLAYBACK_CHANNELS * 2);
@@ -1437,6 +1603,8 @@ static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
        OP(icode, &ptr, iMACINT0, GPR(7), C_00000000, FXBUS(FXBUS_PCM_LFE), C_00000004);
        OP(icode, &ptr, iMACINT0, GPR(8), C_00000000, C_00000000, C_00000000);  /* S/PDIF left */
        OP(icode, &ptr, iMACINT0, GPR(9), C_00000000, C_00000000, C_00000000);  /* S/PDIF right */
+       OP(icode, &ptr, iMACINT0, GPR(10), C_00000000, FXBUS(FXBUS_PCM_LEFT_FRONT), C_00000004);
+       OP(icode, &ptr, iMACINT0, GPR(11), C_00000000, FXBUS(FXBUS_PCM_RIGHT_FRONT), C_00000004);
 
        /* Raw S/PDIF PCM */
        ipcm->substream = 0;
@@ -1452,19 +1620,19 @@ static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
        ipcm->etram[0] = 0;
        ipcm->etram[1] = 1;
 
-       icode->gpr_map[gpr + 0] = 0xfffff000;
-       icode->gpr_map[gpr + 1] = 0xffff0000;
-       icode->gpr_map[gpr + 2] = 0x70000000;
-       icode->gpr_map[gpr + 3] = 0x00000007;
-       icode->gpr_map[gpr + 4] = 0x001f << 11;
-       icode->gpr_map[gpr + 5] = 0x001c << 11;
-       icode->gpr_map[gpr + 6] = (0x22  - 0x01) - 1;   /* skip at 01 to 22 */
-       icode->gpr_map[gpr + 7] = (0x22  - 0x06) - 1;   /* skip at 06 to 22 */
-       icode->gpr_map[gpr + 8] = 0x2000000 + (2<<11);
-       icode->gpr_map[gpr + 9] = 0x4000000 + (2<<11);
-       icode->gpr_map[gpr + 10] = 1<<11;
-       icode->gpr_map[gpr + 11] = (0x24 - 0x0a) - 1;   /* skip at 0a to 24 */
-       icode->gpr_map[gpr + 12] = 0;
+       gpr_map[gpr + 0] = 0xfffff000;
+       gpr_map[gpr + 1] = 0xffff0000;
+       gpr_map[gpr + 2] = 0x70000000;
+       gpr_map[gpr + 3] = 0x00000007;
+       gpr_map[gpr + 4] = 0x001f << 11;
+       gpr_map[gpr + 5] = 0x001c << 11;
+       gpr_map[gpr + 6] = (0x22  - 0x01) - 1;  /* skip at 01 to 22 */
+       gpr_map[gpr + 7] = (0x22  - 0x06) - 1;  /* skip at 06 to 22 */
+       gpr_map[gpr + 8] = 0x2000000 + (2<<11);
+       gpr_map[gpr + 9] = 0x4000000 + (2<<11);
+       gpr_map[gpr + 10] = 1<<11;
+       gpr_map[gpr + 11] = (0x24 - 0x0a) - 1;  /* skip at 0a to 24 */
+       gpr_map[gpr + 12] = 0;
 
        /* if the trigger flag is not set, skip */
        /* 00: */ OP(icode, &ptr, iMAC0, C_00000000, GPR(ipcm->gpr_trigger), C_00000000, C_00000000);
@@ -1545,19 +1713,19 @@ static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
        snd_emu10k1_init_stereo_onoff_control(controls + i++, "Wave Capture Switch", gpr + 2, 0);
        gpr += 4;
 
-       /* Music Playback Volume */
+       /* Synth Playback Volume */
        for (z = 0; z < 2; z++)
                VOLUME_ADD(icode, &ptr, playback + z, 2 + z, gpr + z);
-       snd_emu10k1_init_stereo_control(controls + i++, "Music Playback Volume", gpr, 100);
+       snd_emu10k1_init_stereo_control(controls + i++, "Synth Playback Volume", gpr, 100);
        gpr += 2;
 
-       /* Music Capture Volume + Switch */
+       /* Synth Capture Volume + Switch */
        for (z = 0; z < 2; z++) {
                SWITCH(icode, &ptr, tmp + 0, 2 + z, gpr + 2 + z);
                VOLUME_ADD(icode, &ptr, capture + z, tmp + 0, gpr + z);
        }
-       snd_emu10k1_init_stereo_control(controls + i++, "Music Capture Volume", gpr, 0);
-       snd_emu10k1_init_stereo_onoff_control(controls + i++, "Music Capture Switch", gpr + 2, 0);
+       snd_emu10k1_init_stereo_control(controls + i++, "Synth Capture Volume", gpr, 0);
+       snd_emu10k1_init_stereo_onoff_control(controls + i++, "Synth Capture Switch", gpr + 2, 0);
        gpr += 4;
 
        /* Surround Digital Playback Volume (renamed later without Digital) */
@@ -1583,6 +1751,21 @@ static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
        VOLUME_ADD(icode, &ptr, playback + 5, 7, gpr);
        snd_emu10k1_init_mono_control(controls + i++, "LFE Digital Playback Volume", gpr++, 100);
 
+       /* Front Playback Volume */
+       for (z = 0; z < 2; z++)
+               VOLUME_ADD(icode, &ptr, playback + z, 10 + z, gpr + z);
+       snd_emu10k1_init_stereo_control(controls + i++, "Front Playback Volume", gpr, 100);
+       gpr += 2;
+
+       /* Front Capture Volume + Switch */
+       for (z = 0; z < 2; z++) {
+               SWITCH(icode, &ptr, tmp + 0, 10 + z, gpr + 2);
+               VOLUME_ADD(icode, &ptr, capture + z, tmp + 0, gpr + z);
+       }
+       snd_emu10k1_init_stereo_control(controls + i++, "Front Capture Volume", gpr, 0);
+       snd_emu10k1_init_mono_onoff_control(controls + i++, "Front Capture Switch", gpr + 2, 0);
+       gpr += 3;
+
        /*
         *  Process inputs
         */
@@ -1602,7 +1785,7 @@ static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
                /* IEC958 TTL Playback Volume */
                for (z = 0; z < 2; z++)
                        VOLUME_ADDIN(icode, &ptr, playback + z, EXTIN_SPDIF_CD_L + z, gpr + z);
-               snd_emu10k1_init_stereo_control(controls + i++, "IEC958 TTL Playback Volume", gpr, 0);
+               snd_emu10k1_init_stereo_control(controls + i++, SNDRV_CTL_NAME_IEC958("TTL ",PLAYBACK,VOLUME), gpr, 0);
                gpr += 2;
        
                /* IEC958 TTL Capture Volume + Switch */
@@ -1610,8 +1793,8 @@ static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
                        SWITCH_IN(icode, &ptr, tmp + 0, EXTIN_SPDIF_CD_L + z, gpr + 2 + z);
                        VOLUME_ADD(icode, &ptr, capture + z, tmp + 0, gpr + z);
                }
-               snd_emu10k1_init_stereo_control(controls + i++, "IEC958 TTL Capture Volume", gpr, 0);
-               snd_emu10k1_init_stereo_onoff_control(controls + i++, "IEC958 TTL Capture Switch", gpr + 2, 0);
+               snd_emu10k1_init_stereo_control(controls + i++, SNDRV_CTL_NAME_IEC958("TTL ",CAPTURE,VOLUME), gpr, 0);
+               snd_emu10k1_init_stereo_onoff_control(controls + i++, SNDRV_CTL_NAME_IEC958("TTL ",CAPTURE,SWITCH), gpr + 2, 0);
                gpr += 4;
        }
        
@@ -1636,7 +1819,7 @@ static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
                /* IEC958 Optical Playback Volume */
                for (z = 0; z < 2; z++)
                        VOLUME_ADDIN(icode, &ptr, playback + z, EXTIN_TOSLINK_L + z, gpr + z);
-               snd_emu10k1_init_stereo_control(controls + i++, "IEC958 LiveDrive Playback Volume", gpr, 0);
+               snd_emu10k1_init_stereo_control(controls + i++, SNDRV_CTL_NAME_IEC958("LiveDrive ",PLAYBACK,VOLUME), gpr, 0);
                gpr += 2;
        
                /* IEC958 Optical Capture Volume */
@@ -1644,8 +1827,8 @@ static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
                        SWITCH_IN(icode, &ptr, tmp + 0, EXTIN_TOSLINK_L + z, gpr + 2 + z);
                        VOLUME_ADD(icode, &ptr, capture + z, tmp + 0, gpr + z);
                }
-               snd_emu10k1_init_stereo_control(controls + i++, "IEC958 LiveDrive Capture Volume", gpr, 0);
-               snd_emu10k1_init_stereo_onoff_control(controls + i++, "IEC958 LiveDrive Capture Switch", gpr + 2, 0);
+               snd_emu10k1_init_stereo_control(controls + i++, SNDRV_CTL_NAME_IEC958("LiveDrive ",CAPTURE,VOLUME), gpr, 0);
+               snd_emu10k1_init_stereo_onoff_control(controls + i++, SNDRV_CTL_NAME_IEC958("LiveDrive ",CAPTURE,SWITCH), gpr + 2, 0);
                gpr += 4;
        }
        
@@ -1670,7 +1853,7 @@ static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
                /* IEC958 Coax Playback Volume */
                for (z = 0; z < 2; z++)
                        VOLUME_ADDIN(icode, &ptr, playback + z, EXTIN_COAX_SPDIF_L + z, gpr + z);
-               snd_emu10k1_init_stereo_control(controls + i++, "IEC958 Coaxial Playback Volume", gpr, 0);
+               snd_emu10k1_init_stereo_control(controls + i++, SNDRV_CTL_NAME_IEC958("Coaxial ",PLAYBACK,VOLUME), gpr, 0);
                gpr += 2;
        
                /* IEC958 Coax Capture Volume + Switch */
@@ -1678,8 +1861,8 @@ static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
                        SWITCH_IN(icode, &ptr, tmp + 0, EXTIN_COAX_SPDIF_L + z, gpr + 2 + z);
                        VOLUME_ADD(icode, &ptr, capture + z, tmp + 0, gpr + z);
                }
-               snd_emu10k1_init_stereo_control(controls + i++, "IEC958 Coaxial Capture Volume", gpr, 0);
-               snd_emu10k1_init_stereo_onoff_control(controls + i++, "IEC958 Coaxial Capture Switch", gpr + 2, 0);
+               snd_emu10k1_init_stereo_control(controls + i++, SNDRV_CTL_NAME_IEC958("Coaxial ",CAPTURE,VOLUME), gpr, 0);
+               snd_emu10k1_init_stereo_onoff_control(controls + i++, SNDRV_CTL_NAME_IEC958("Coaxial ",CAPTURE,SWITCH), gpr + 2, 0);
                gpr += 4;
        }
        
@@ -1806,7 +1989,7 @@ static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
 #endif
                }
 
-               snd_emu10k1_init_stereo_onoff_control(controls + i++, "IEC958 Optical Raw Playback Switch", gpr, 0);
+               snd_emu10k1_init_stereo_onoff_control(controls + i++, SNDRV_CTL_NAME_IEC958("Optical Raw ",PLAYBACK,SWITCH), gpr, 0);
                gpr += 2;
        }
 
@@ -1867,6 +2050,29 @@ static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
        if (emu->fx8010.extout_mask & (1<<EXTOUT_MIC_CAP))
                OP(icode, &ptr, iACC3, EXTOUT(EXTOUT_MIC_CAP), GPR(capture + 2), C_00000000, C_00000000);
 
+       /* EFX capture - capture the 16 EXTINS */
+       if (emu->card_capabilities->sblive51) {
+               /* On the Live! 5.1, FXBUS2(1) and FXBUS(2) are shared with EXTOUT_ACENTER
+                * and EXTOUT_ALFE, so we can't connect inputs to them for multitrack recording.
+                *
+                * Since only 14 of the 16 EXTINs are used, this is not a big problem.  
+                * We route AC97L and R to FX capture 14 and 15, SPDIF CD in to FX capture 
+                * 0 and 3, then the rest of the EXTINs to the corresponding FX capture 
+                * channel.  Multitrack recorders will still see the center/lfe output signal 
+                * on the second and third channels.
+                */
+               OP(icode, &ptr, iACC3, FXBUS2(14), C_00000000, C_00000000, EXTIN(0));
+               OP(icode, &ptr, iACC3, FXBUS2(15), C_00000000, C_00000000, EXTIN(1));
+               OP(icode, &ptr, iACC3, FXBUS2(0), C_00000000, C_00000000, EXTIN(2));
+               OP(icode, &ptr, iACC3, FXBUS2(3), C_00000000, C_00000000, EXTIN(3));
+               for (z = 4; z < 14; z++)
+                       OP(icode, &ptr, iACC3, FXBUS2(z), C_00000000, C_00000000, EXTIN(z));
+       } else {
+               for (z = 0; z < 16; z++)
+                       OP(icode, &ptr, iACC3, FXBUS2(z), C_00000000, C_00000000, EXTIN(z));
+       }
+           
+
        if (gpr > tmp) {
                snd_BUG();
                err = -EIO;
@@ -1886,7 +2092,7 @@ static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
                goto __err;
        seg = snd_enter_user();
        icode->gpr_add_control_count = i;
-       icode->gpr_add_controls = controls;
+       icode->gpr_add_controls = (struct snd_emu10k1_fx8010_control_gpr __user *)controls;
        err = snd_emu10k1_icode_poke(emu, icode);
        snd_leave_user(seg);
        if (err >= 0)
@@ -1894,19 +2100,24 @@ static int __devinit _snd_emu10k1_init_efx(emu10k1_t *emu)
       __err:
        kfree(ipcm);
        kfree(controls);
-       kfree(icode);
+       if (icode != NULL) {
+               kfree((void __force *)icode->gpr_map);
+               kfree(icode);
+       }
        return err;
 }
 
-int __devinit snd_emu10k1_init_efx(emu10k1_t *emu)
+int __devinit snd_emu10k1_init_efx(struct snd_emu10k1 *emu)
 {
+       spin_lock_init(&emu->fx8010.irq_lock);
+       INIT_LIST_HEAD(&emu->fx8010.gpr_ctl);
        if (emu->audigy)
                return _snd_emu10k1_audigy_init_efx(emu);
        else
                return _snd_emu10k1_init_efx(emu);
 }
 
-void snd_emu10k1_free_efx(emu10k1_t *emu)
+void snd_emu10k1_free_efx(struct snd_emu10k1 *emu)
 {
        /* stop processor */
        if (emu->audigy)
@@ -1916,22 +2127,24 @@ void snd_emu10k1_free_efx(emu10k1_t *emu)
 }
 
 #if 0 // FIXME: who use them?
-int snd_emu10k1_fx8010_tone_control_activate(emu10k1_t *emu, int output)
+int snd_emu10k1_fx8010_tone_control_activate(struct snd_emu10k1 *emu, int output)
 {
-       snd_runtime_check(output >= 0 && output < 6, return -EINVAL);
+       if (output < 0 || output >= 6)
+               return -EINVAL;
        snd_emu10k1_ptr_write(emu, emu->gpr_base + 0x94 + output, 0, 1);
        return 0;
 }
 
-int snd_emu10k1_fx8010_tone_control_deactivate(emu10k1_t *emu, int output)
+int snd_emu10k1_fx8010_tone_control_deactivate(struct snd_emu10k1 *emu, int output)
 {
-       snd_runtime_check(output >= 0 && output < 6, return -EINVAL);
+       if (output < 0 || output >= 6)
+               return -EINVAL;
        snd_emu10k1_ptr_write(emu, emu->gpr_base + 0x94 + output, 0, 0);
        return 0;
 }
 #endif
 
-int snd_emu10k1_fx8010_tram_setup(emu10k1_t *emu, u32 size)
+int snd_emu10k1_fx8010_tram_setup(struct snd_emu10k1 *emu, u32 size)
 {
        u8 size_reg = 0;
 
@@ -1945,7 +2158,7 @@ int snd_emu10k1_fx8010_tram_setup(emu10k1_t *emu, u32 size)
                }
                size = 0x2000 << size_reg;
        }
-       if (emu->fx8010.etram_pages.bytes == size)
+       if ((emu->fx8010.etram_pages.bytes / 2) == size)
                return 0;
        spin_lock_irq(&emu->emu_lock);
        outl(HCFG_LOCKTANKCACHE_MASK | inl(emu->port + HCFG), emu->port + HCFG);
@@ -1967,13 +2180,13 @@ int snd_emu10k1_fx8010_tram_setup(emu10k1_t *emu, u32 size)
                snd_emu10k1_ptr_write(emu, TCBS, 0, size_reg);
                spin_lock_irq(&emu->emu_lock);
                outl(inl(emu->port + HCFG) & ~HCFG_LOCKTANKCACHE_MASK, emu->port + HCFG);
-               spin_unlock_irq(&emu->emu_lock);        
+               spin_unlock_irq(&emu->emu_lock);
        }
 
        return 0;
 }
 
-static int snd_emu10k1_fx8010_open(snd_hwdep_t * hw, struct file *file)
+static int snd_emu10k1_fx8010_open(struct snd_hwdep * hw, struct file *file)
 {
        return 0;
 }
@@ -1986,16 +2199,16 @@ static void copy_string(char *dst, char *src, char *null, int idx)
                strcpy(dst, src);
 }
 
-static int snd_emu10k1_fx8010_info(emu10k1_t *emu, emu10k1_fx8010_info_t *info)
+static int snd_emu10k1_fx8010_info(struct snd_emu10k1 *emu,
+                                  struct snd_emu10k1_fx8010_info *info)
 {
        char **fxbus, **extin, **extout;
        unsigned short fxbus_mask, extin_mask, extout_mask;
        int res;
 
        memset(info, 0, sizeof(info));
-       info->card = emu->card_type;
        info->internal_tram_size = emu->fx8010.itram_size;
-       info->external_tram_size = emu->fx8010.etram_pages.bytes;
+       info->external_tram_size = emu->fx8010.etram_pages.bytes / 2;
        fxbus = fxbuses;
        extin = emu->audigy ? audigy_ins : creative_ins;
        extout = emu->audigy ? audigy_outs : creative_outs;
@@ -2013,19 +2226,19 @@ static int snd_emu10k1_fx8010_info(emu10k1_t *emu, emu10k1_fx8010_info_t *info)
        return 0;
 }
 
-static int snd_emu10k1_fx8010_ioctl(snd_hwdep_t * hw, struct file *file, unsigned int cmd, unsigned long arg)
+static int snd_emu10k1_fx8010_ioctl(struct snd_hwdep * hw, struct file *file, unsigned int cmd, unsigned long arg)
 {
-       emu10k1_t *emu = hw->private_data;
-       emu10k1_fx8010_info_t *info;
-       emu10k1_fx8010_code_t *icode;
-       emu10k1_fx8010_pcm_t *ipcm;
+       struct snd_emu10k1 *emu = hw->private_data;
+       struct snd_emu10k1_fx8010_info *info;
+       struct snd_emu10k1_fx8010_code *icode;
+       struct snd_emu10k1_fx8010_pcm_rec *ipcm;
        unsigned int addr;
        void __user *argp = (void __user *)arg;
        int res;
        
        switch (cmd) {
        case SNDRV_EMU10K1_IOCTL_INFO:
-               info = (emu10k1_fx8010_info_t *)kmalloc(sizeof(*info), GFP_KERNEL);
+               info = kmalloc(sizeof(*info), GFP_KERNEL);
                if (!info)
                        return -ENOMEM;
                if ((res = snd_emu10k1_fx8010_info(emu, info)) < 0) {
@@ -2041,7 +2254,7 @@ static int snd_emu10k1_fx8010_ioctl(snd_hwdep_t * hw, struct file *file, unsigne
        case SNDRV_EMU10K1_IOCTL_CODE_POKE:
                if (!capable(CAP_SYS_ADMIN))
                        return -EPERM;
-               icode = (emu10k1_fx8010_code_t *)kmalloc(sizeof(*icode), GFP_KERNEL);
+               icode = kmalloc(sizeof(*icode), GFP_KERNEL);
                if (icode == NULL)
                        return -ENOMEM;
                if (copy_from_user(icode, argp, sizeof(*icode))) {
@@ -2052,7 +2265,7 @@ static int snd_emu10k1_fx8010_ioctl(snd_hwdep_t * hw, struct file *file, unsigne
                kfree(icode);
                return res;
        case SNDRV_EMU10K1_IOCTL_CODE_PEEK:
-               icode = (emu10k1_fx8010_code_t *)kmalloc(sizeof(*icode), GFP_KERNEL);
+               icode = kmalloc(sizeof(*icode), GFP_KERNEL);
                if (icode == NULL)
                        return -ENOMEM;
                if (copy_from_user(icode, argp, sizeof(*icode))) {
@@ -2067,9 +2280,7 @@ static int snd_emu10k1_fx8010_ioctl(snd_hwdep_t * hw, struct file *file, unsigne
                kfree(icode);
                return res;
        case SNDRV_EMU10K1_IOCTL_PCM_POKE:
-               if (emu->audigy)
-                       return -EINVAL;
-               ipcm = (emu10k1_fx8010_pcm_t *)kmalloc(sizeof(*ipcm), GFP_KERNEL);
+               ipcm = kmalloc(sizeof(*ipcm), GFP_KERNEL);
                if (ipcm == NULL)
                        return -ENOMEM;
                if (copy_from_user(ipcm, argp, sizeof(*ipcm))) {
@@ -2080,9 +2291,7 @@ static int snd_emu10k1_fx8010_ioctl(snd_hwdep_t * hw, struct file *file, unsigne
                kfree(ipcm);
                return res;
        case SNDRV_EMU10K1_IOCTL_PCM_PEEK:
-               if (emu->audigy)
-                       return -EINVAL;
-               ipcm = kcalloc(1, sizeof(*ipcm), GFP_KERNEL);
+               ipcm = kzalloc(sizeof(*ipcm), GFP_KERNEL);
                if (ipcm == NULL)
                        return -ENOMEM;
                if (copy_from_user(ipcm, argp, sizeof(*ipcm))) {
@@ -2097,15 +2306,13 @@ static int snd_emu10k1_fx8010_ioctl(snd_hwdep_t * hw, struct file *file, unsigne
                kfree(ipcm);
                return res;
        case SNDRV_EMU10K1_IOCTL_TRAM_SETUP:
-               if (emu->audigy)
-                       return -EINVAL;
                if (!capable(CAP_SYS_ADMIN))
                        return -EPERM;
                if (get_user(addr, (unsigned int __user *)argp))
                        return -EFAULT;
-               down(&emu->fx8010.lock);
+               mutex_lock(&emu->fx8010.lock);
                res = snd_emu10k1_fx8010_tram_setup(emu, addr);
-               up(&emu->fx8010.lock);
+               mutex_unlock(&emu->fx8010.lock);
                return res;
        case SNDRV_EMU10K1_IOCTL_STOP:
                if (!capable(CAP_SYS_ADMIN))
@@ -2165,14 +2372,14 @@ static int snd_emu10k1_fx8010_ioctl(snd_hwdep_t * hw, struct file *file, unsigne
        return -ENOTTY;
 }
 
-static int snd_emu10k1_fx8010_release(snd_hwdep_t * hw, struct file *file)
+static int snd_emu10k1_fx8010_release(struct snd_hwdep * hw, struct file *file)
 {
        return 0;
 }
 
-int __devinit snd_emu10k1_fx8010_new(emu10k1_t *emu, int device, snd_hwdep_t ** rhwdep)
+int __devinit snd_emu10k1_fx8010_new(struct snd_emu10k1 *emu, int device, struct snd_hwdep ** rhwdep)
 {
-       snd_hwdep_t *hw;
+       struct snd_hwdep *hw;
        int err;
        
        if (rhwdep)
@@ -2189,3 +2396,114 @@ int __devinit snd_emu10k1_fx8010_new(emu10k1_t *emu, int device, snd_hwdep_t **
                *rhwdep = hw;
        return 0;
 }
+
+#ifdef CONFIG_PM
+int __devinit snd_emu10k1_efx_alloc_pm_buffer(struct snd_emu10k1 *emu)
+{
+       int len;
+
+       len = emu->audigy ? 0x200 : 0x100;
+       emu->saved_gpr = kmalloc(len * 4, GFP_KERNEL);
+       if (! emu->saved_gpr)
+               return -ENOMEM;
+       len = emu->audigy ? 0x100 : 0xa0;
+       emu->tram_val_saved = kmalloc(len * 4, GFP_KERNEL);
+       emu->tram_addr_saved = kmalloc(len * 4, GFP_KERNEL);
+       if (! emu->tram_val_saved || ! emu->tram_addr_saved)
+               return -ENOMEM;
+       len = emu->audigy ? 2 * 1024 : 2 * 512;
+       emu->saved_icode = vmalloc(len * 4);
+       if (! emu->saved_icode)
+               return -ENOMEM;
+       return 0;
+}
+
+void snd_emu10k1_efx_free_pm_buffer(struct snd_emu10k1 *emu)
+{
+       kfree(emu->saved_gpr);
+       kfree(emu->tram_val_saved);
+       kfree(emu->tram_addr_saved);
+       vfree(emu->saved_icode);
+}
+
+/*
+ * save/restore GPR, TRAM and codes
+ */
+void snd_emu10k1_efx_suspend(struct snd_emu10k1 *emu)
+{
+       int i, len;
+
+       len = emu->audigy ? 0x200 : 0x100;
+       for (i = 0; i < len; i++)
+               emu->saved_gpr[i] = snd_emu10k1_ptr_read(emu, emu->gpr_base + i, 0);
+
+       len = emu->audigy ? 0x100 : 0xa0;
+       for (i = 0; i < len; i++) {
+               emu->tram_val_saved[i] = snd_emu10k1_ptr_read(emu, TANKMEMDATAREGBASE + i, 0);
+               emu->tram_addr_saved[i] = snd_emu10k1_ptr_read(emu, TANKMEMADDRREGBASE + i, 0);
+               if (emu->audigy) {
+                       emu->tram_addr_saved[i] >>= 12;
+                       emu->tram_addr_saved[i] |=
+                               snd_emu10k1_ptr_read(emu, A_TANKMEMCTLREGBASE + i, 0) << 20;
+               }
+       }
+
+       len = emu->audigy ? 2 * 1024 : 2 * 512;
+       for (i = 0; i < len; i++)
+               emu->saved_icode[i] = snd_emu10k1_efx_read(emu, i);
+}
+
+void snd_emu10k1_efx_resume(struct snd_emu10k1 *emu)
+{
+       int i, len;
+
+       /* set up TRAM */
+       if (emu->fx8010.etram_pages.bytes > 0) {
+               unsigned size, size_reg = 0;
+               size = emu->fx8010.etram_pages.bytes / 2;
+               size = (size - 1) >> 13;
+               while (size) {
+                       size >>= 1;
+                       size_reg++;
+               }
+               outl(HCFG_LOCKTANKCACHE_MASK | inl(emu->port + HCFG), emu->port + HCFG);
+               snd_emu10k1_ptr_write(emu, TCB, 0, emu->fx8010.etram_pages.addr);
+               snd_emu10k1_ptr_write(emu, TCBS, 0, size_reg);
+               outl(inl(emu->port + HCFG) & ~HCFG_LOCKTANKCACHE_MASK, emu->port + HCFG);
+       }
+
+       if (emu->audigy)
+               snd_emu10k1_ptr_write(emu, A_DBG, 0, emu->fx8010.dbg | A_DBG_SINGLE_STEP);
+       else
+               snd_emu10k1_ptr_write(emu, DBG, 0, emu->fx8010.dbg | EMU10K1_DBG_SINGLE_STEP);
+
+       len = emu->audigy ? 0x200 : 0x100;
+       for (i = 0; i < len; i++)
+               snd_emu10k1_ptr_write(emu, emu->gpr_base + i, 0, emu->saved_gpr[i]);
+
+       len = emu->audigy ? 0x100 : 0xa0;
+       for (i = 0; i < len; i++) {
+               snd_emu10k1_ptr_write(emu, TANKMEMDATAREGBASE + i, 0,
+                                     emu->tram_val_saved[i]);
+               if (! emu->audigy)
+                       snd_emu10k1_ptr_write(emu, TANKMEMADDRREGBASE + i, 0,
+                                             emu->tram_addr_saved[i]);
+               else {
+                       snd_emu10k1_ptr_write(emu, TANKMEMADDRREGBASE + i, 0,
+                                             emu->tram_addr_saved[i] << 12);
+                       snd_emu10k1_ptr_write(emu, TANKMEMADDRREGBASE + i, 0,
+                                             emu->tram_addr_saved[i] >> 20);
+               }
+       }
+
+       len = emu->audigy ? 2 * 1024 : 2 * 512;
+       for (i = 0; i < len; i++)
+               snd_emu10k1_efx_write(emu, i, emu->saved_icode[i]);
+
+       /* start FX processor when the DSP code is updated */
+       if (emu->audigy)
+               snd_emu10k1_ptr_write(emu, A_DBG, 0, emu->fx8010.dbg);
+       else
+               snd_emu10k1_ptr_write(emu, DBG, 0, emu->fx8010.dbg);
+}
+#endif