Fedora kernel-2.6.17-1.2142_FC4 patched with stable patch-2.6.17.4-vs2.0.2-rc26.diff
[linux-2.6.git] / sound / pci / emu10k1 / emupcm.c
index 9fbbf6c..717e92e 100644 (file)
@@ -2,6 +2,7 @@
  *  Copyright (c) by Jaroslav Kysela <perex@suse.cz>
  *                   Creative Labs, Inc.
  *  Routines for control of EMU10K1 chips / PCM routines
+ *  Multichannel PCM support Copyright (c) Lee Revell <rlrevell@joe-job.com>
  *
  *  BUGS:
  *    --
 #include <sound/core.h>
 #include <sound/emu10k1.h>
 
-static void snd_emu10k1_pcm_interrupt(emu10k1_t *emu, emu10k1_voice_t *voice)
+static void snd_emu10k1_pcm_interrupt(struct snd_emu10k1 *emu,
+                                     struct snd_emu10k1_voice *voice)
 {
-       emu10k1_pcm_t *epcm;
+       struct snd_emu10k1_pcm *epcm;
 
        if ((epcm = voice->epcm) == NULL)
                return;
@@ -51,7 +53,8 @@ static void snd_emu10k1_pcm_interrupt(emu10k1_t *emu, emu10k1_voice_t *voice)
        snd_pcm_period_elapsed(epcm->substream);
 }
 
-static void snd_emu10k1_pcm_ac97adc_interrupt(emu10k1_t *emu, unsigned int status)
+static void snd_emu10k1_pcm_ac97adc_interrupt(struct snd_emu10k1 *emu,
+                                             unsigned int status)
 {
 #if 0
        if (status & IPR_ADCBUFHALFFULL) {
@@ -62,7 +65,8 @@ static void snd_emu10k1_pcm_ac97adc_interrupt(emu10k1_t *emu, unsigned int statu
        snd_pcm_period_elapsed(emu->pcm_capture_substream);
 }
 
-static void snd_emu10k1_pcm_ac97mic_interrupt(emu10k1_t *emu, unsigned int status)
+static void snd_emu10k1_pcm_ac97mic_interrupt(struct snd_emu10k1 *emu,
+                                             unsigned int status)
 {
 #if 0
        if (status & IPR_MICBUFHALFFULL) {
@@ -73,7 +77,8 @@ static void snd_emu10k1_pcm_ac97mic_interrupt(emu10k1_t *emu, unsigned int statu
        snd_pcm_period_elapsed(emu->pcm_capture_mic_substream);
 }
 
-static void snd_emu10k1_pcm_efx_interrupt(emu10k1_t *emu, unsigned int status)
+static void snd_emu10k1_pcm_efx_interrupt(struct snd_emu10k1 *emu,
+                                         unsigned int status)
 {
 #if 0
        if (status & IPR_EFXBUFHALFFULL) {
@@ -82,43 +87,71 @@ static void snd_emu10k1_pcm_efx_interrupt(emu10k1_t *emu, unsigned int status)
        }
 #endif
        snd_pcm_period_elapsed(emu->pcm_capture_efx_substream);
+}       
+
+static snd_pcm_uframes_t snd_emu10k1_efx_playback_pointer(struct snd_pcm_substream *substream)
+{
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_emu10k1_pcm *epcm = runtime->private_data;
+       unsigned int ptr;
+
+       if (!epcm->running)
+               return 0;
+       ptr = snd_emu10k1_ptr_read(emu, CCCA, epcm->voices[0]->number) & 0x00ffffff;
+       ptr += runtime->buffer_size;
+       ptr -= epcm->ccca_start_addr;
+       ptr %= runtime->buffer_size;
+
+       return ptr;
 }
 
-static int snd_emu10k1_pcm_channel_alloc(emu10k1_pcm_t * epcm, int voices)
+static int snd_emu10k1_pcm_channel_alloc(struct snd_emu10k1_pcm * epcm, int voices)
 {
-       int err;
+       int err, i;
 
        if (epcm->voices[1] != NULL && voices < 2) {
                snd_emu10k1_voice_free(epcm->emu, epcm->voices[1]);
                epcm->voices[1] = NULL;
        }
-       if (voices == 1 && epcm->voices[0] != NULL)
-               return 0;               /* already allocated */
-       if (voices == 2 && epcm->voices[0] != NULL && epcm->voices[1] != NULL)
-               return 0;
-       if (voices > 1) {
-               if (epcm->voices[0] != NULL && epcm->voices[1] == NULL) {
-                       snd_emu10k1_voice_free(epcm->emu, epcm->voices[0]);
-                       epcm->voices[0] = NULL;
+       for (i = 0; i < voices; i++) {
+               if (epcm->voices[i] == NULL)
+                       break;
+       }
+       if (i == voices)
+               return 0; /* already allocated */
+
+       for (i = 0; i < ARRAY_SIZE(epcm->voices); i++) {
+               if (epcm->voices[i]) {
+                       snd_emu10k1_voice_free(epcm->emu, epcm->voices[i]);
+                       epcm->voices[i] = NULL;
                }
        }
-       err = snd_emu10k1_voice_alloc(epcm->emu, EMU10K1_PCM, voices > 1, &epcm->voices[0]);
+       err = snd_emu10k1_voice_alloc(epcm->emu,
+                                     epcm->type == PLAYBACK_EMUVOICE ? EMU10K1_PCM : EMU10K1_EFX,
+                                     voices,
+                                     &epcm->voices[0]);
+       
        if (err < 0)
                return err;
        epcm->voices[0]->epcm = epcm;
        if (voices > 1) {
-               epcm->voices[1] = &epcm->emu->voices[epcm->voices[0]->number + 1];
-               epcm->voices[1]->epcm = epcm;
+               for (i = 1; i < voices; i++) {
+                       epcm->voices[i] = &epcm->emu->voices[epcm->voices[0]->number + i];
+                       epcm->voices[i]->epcm = epcm;
+               }
        }
        if (epcm->extra == NULL) {
-               err = snd_emu10k1_voice_alloc(epcm->emu, EMU10K1_PCM, 0, &epcm->extra);
+               err = snd_emu10k1_voice_alloc(epcm->emu,
+                                             epcm->type == PLAYBACK_EMUVOICE ? EMU10K1_PCM : EMU10K1_EFX,
+                                             1,
+                                             &epcm->extra);
                if (err < 0) {
                        // printk("pcm_channel_alloc: failed extra: voices=%d, frame=%d\n", voices, frame);
-                       snd_emu10k1_voice_free(epcm->emu, epcm->voices[0]);
-                       epcm->voices[0] = NULL;
-                       if (epcm->voices[1])
-                               snd_emu10k1_voice_free(epcm->emu, epcm->voices[1]);
-                       epcm->voices[1] = NULL;
+                       for (i = 0; i < voices; i++) {
+                               snd_emu10k1_voice_free(epcm->emu, epcm->voices[i]);
+                               epcm->voices[i] = NULL;
+                       }
                        return err;
                }
                epcm->extra->epcm = epcm;
@@ -138,7 +171,7 @@ static unsigned int capture_period_sizes[31] = {
        384*128,448*128,512*128
 };
 
-static snd_pcm_hw_constraint_list_t hw_constraints_capture_period_sizes = {
+static struct snd_pcm_hw_constraint_list hw_constraints_capture_period_sizes = {
        .count = 31,
        .list = capture_period_sizes,
        .mask = 0
@@ -148,7 +181,7 @@ static unsigned int capture_rates[8] = {
        8000, 11025, 16000, 22050, 24000, 32000, 44100, 48000
 };
 
-static snd_pcm_hw_constraint_list_t hw_constraints_capture_rates = {
+static struct snd_pcm_hw_constraint_list hw_constraints_capture_rates = {
        .count = 8,
        .list = capture_rates,
        .mask = 0
@@ -225,22 +258,39 @@ static unsigned int emu10k1_select_interprom(unsigned int pitch_target)
                return CCCA_INTERPROM_2;
 }
 
+/*
+ * calculate cache invalidate size 
+ *
+ * stereo: channel is stereo
+ * w_16: using 16bit samples
+ *
+ * returns: cache invalidate size in samples
+ */
+static inline int emu10k1_ccis(int stereo, int w_16)
+{
+       if (w_16) {
+               return stereo ? 24 : 26;
+       } else {
+               return stereo ? 24*2 : 26*2;
+       }
+}
 
-static void snd_emu10k1_pcm_init_voice(emu10k1_t *emu,
+static void snd_emu10k1_pcm_init_voice(struct snd_emu10k1 *emu,
                                       int master, int extra,
-                                      emu10k1_voice_t *evoice,
+                                      struct snd_emu10k1_voice *evoice,
                                       unsigned int start_addr,
-                                      unsigned int end_addr)
+                                      unsigned int end_addr,
+                                      struct snd_emu10k1_pcm_mixer *mix)
 {
-       snd_pcm_substream_t *substream = evoice->epcm->substream;
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       emu10k1_pcm_mixer_t *mix = &emu->pcm_mixer[substream->number];
+       struct snd_pcm_substream *substream = evoice->epcm->substream;
+       struct snd_pcm_runtime *runtime = substream->runtime;
        unsigned int silent_page, tmp;
        int voice, stereo, w_16;
        unsigned char attn, send_amount[8];
        unsigned char send_routing[8];
        unsigned long flags;
        unsigned int pitch_target;
+       unsigned int ccis;
 
        voice = evoice->number;
        stereo = runtime->channels == 2;
@@ -267,15 +317,15 @@ static void snd_emu10k1_pcm_init_voice(emu10k1_t *emu,
                send_routing[3] = 3;
                memset(send_amount, 0, sizeof(send_amount));
        } else {
+               /* mono, left, right (master voice = left) */
                tmp = stereo ? (master ? 1 : 2) : 0;
                memcpy(send_routing, &mix->send_routing[tmp][0], 8);
                memcpy(send_amount, &mix->send_volume[tmp][0], 8);
        }
 
+       ccis = emu10k1_ccis(stereo, w_16);
+       
        if (master) {
-               unsigned int ccis = stereo ? 28 : 30;
-               if (w_16)
-                       ccis *= 2;
                evoice->epcm->ccca_start_addr = start_addr + ccis;
                if (extra) {
                        start_addr += ccis;
@@ -292,15 +342,9 @@ static void snd_emu10k1_pcm_init_voice(emu10k1_t *emu,
        // setup routing
        if (emu->audigy) {
                snd_emu10k1_ptr_write(emu, A_FXRT1, voice,
-                                     ((unsigned int)send_routing[3] << 24) |
-                                     ((unsigned int)send_routing[2] << 16) |
-                                     ((unsigned int)send_routing[1] << 8) |
-                                     (unsigned int)send_routing[0]);
+                                     snd_emu10k1_compose_audigy_fxrt1(send_routing));
                snd_emu10k1_ptr_write(emu, A_FXRT2, voice,
-                                     ((unsigned int)send_routing[7] << 24) |
-                                     ((unsigned int)send_routing[6] << 16) |
-                                     ((unsigned int)send_routing[5] << 8) |
-                                     (unsigned int)send_routing[4]);
+                                     snd_emu10k1_compose_audigy_fxrt2(send_routing));
                snd_emu10k1_ptr_write(emu, A_SENDAMOUNTS, voice,
                                      ((unsigned int)send_amount[4] << 24) |
                                      ((unsigned int)send_amount[5] << 16) |
@@ -315,7 +359,12 @@ static void snd_emu10k1_pcm_init_voice(emu10k1_t *emu,
        snd_emu10k1_ptr_write(emu, DSL, voice, end_addr | (send_amount[3] << 24));
        snd_emu10k1_ptr_write(emu, PSST, voice, start_addr | (send_amount[2] << 24));
        pitch_target = emu10k1_calc_pitch_target(runtime->rate);
-       snd_emu10k1_ptr_write(emu, CCCA, voice, evoice->epcm->ccca_start_addr |
+       if (extra)
+               snd_emu10k1_ptr_write(emu, CCCA, voice, start_addr |
+                             emu10k1_select_interprom(pitch_target) |
+                             (w_16 ? 0 : CCCA_8BITSELECT));
+       else
+               snd_emu10k1_ptr_write(emu, CCCA, voice, (start_addr + ccis) |
                              emu10k1_select_interprom(pitch_target) |
                              (w_16 ? 0 : CCCA_8BITSELECT));
        // Clear filter delay memory
@@ -347,12 +396,12 @@ static void snd_emu10k1_pcm_init_voice(emu10k1_t *emu,
        spin_unlock_irqrestore(&emu->reg_lock, flags);
 }
 
-static int snd_emu10k1_playback_hw_params(snd_pcm_substream_t * substream,
-                                         snd_pcm_hw_params_t * hw_params)
+static int snd_emu10k1_playback_hw_params(struct snd_pcm_substream *substream,
+                                         struct snd_pcm_hw_params *hw_params)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       emu10k1_pcm_t *epcm = runtime->private_data;
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_emu10k1_pcm *epcm = runtime->private_data;
        int err;
 
        if ((err = snd_emu10k1_pcm_channel_alloc(epcm, params_channels(hw_params))) < 0)
@@ -360,24 +409,26 @@ static int snd_emu10k1_playback_hw_params(snd_pcm_substream_t * substream,
        if ((err = snd_pcm_lib_malloc_pages(substream, params_buffer_bytes(hw_params))) < 0)
                return err;
        if (err > 0) {  /* change */
-               snd_util_memblk_t *memblk;
+               int mapped;
                if (epcm->memblk != NULL)
                        snd_emu10k1_free_pages(emu, epcm->memblk);
-               memblk = snd_emu10k1_alloc_pages(emu, substream);
-               if ((epcm->memblk = memblk) == NULL || ((emu10k1_memblk_t *)memblk)->mapped_page < 0) {
-                       epcm->start_addr = 0;
+               epcm->memblk = snd_emu10k1_alloc_pages(emu, substream);
+               epcm->start_addr = 0;
+               if (! epcm->memblk)
                        return -ENOMEM;
-               }
-               epcm->start_addr = ((emu10k1_memblk_t *)memblk)->mapped_page << PAGE_SHIFT;
+               mapped = ((struct snd_emu10k1_memblk *)epcm->memblk)->mapped_page;
+               if (mapped < 0)
+                       return -ENOMEM;
+               epcm->start_addr = mapped << PAGE_SHIFT;
        }
        return 0;
 }
 
-static int snd_emu10k1_playback_hw_free(snd_pcm_substream_t * substream)
+static int snd_emu10k1_playback_hw_free(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       emu10k1_pcm_t *epcm;
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_emu10k1_pcm *epcm;
 
        if (runtime->private_data == NULL)
                return 0;
@@ -403,47 +454,138 @@ static int snd_emu10k1_playback_hw_free(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static int snd_emu10k1_playback_prepare(snd_pcm_substream_t * substream)
+static int snd_emu10k1_efx_playback_hw_free(struct snd_pcm_substream *substream)
+{
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_emu10k1_pcm *epcm;
+       int i;
+
+       if (runtime->private_data == NULL)
+               return 0;
+       epcm = runtime->private_data;
+       if (epcm->extra) {
+               snd_emu10k1_voice_free(epcm->emu, epcm->extra);
+               epcm->extra = NULL;
+       }
+       for (i=0; i < NUM_EFX_PLAYBACK; i++) {
+               if (epcm->voices[i]) {
+                       snd_emu10k1_voice_free(epcm->emu, epcm->voices[i]);
+                       epcm->voices[i] = NULL;
+               }
+       }
+       if (epcm->memblk) {
+               snd_emu10k1_free_pages(emu, epcm->memblk);
+               epcm->memblk = NULL;
+               epcm->start_addr = 0;
+       }
+       snd_pcm_lib_free_pages(substream);
+       return 0;
+}
+
+static int snd_emu10k1_playback_prepare(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       emu10k1_pcm_t *epcm = runtime->private_data;
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_emu10k1_pcm *epcm = runtime->private_data;
        unsigned int start_addr, end_addr;
 
        start_addr = epcm->start_addr;
        end_addr = snd_pcm_lib_period_bytes(substream);
-       if (runtime->channels == 2)
+       if (runtime->channels == 2) {
+               start_addr >>= 1;
                end_addr >>= 1;
+       }
        end_addr += start_addr;
        snd_emu10k1_pcm_init_voice(emu, 1, 1, epcm->extra,
-                                  start_addr, end_addr);
+                                  start_addr, end_addr, NULL);
+       start_addr = epcm->start_addr;
        end_addr = epcm->start_addr + snd_pcm_lib_buffer_bytes(substream);
        snd_emu10k1_pcm_init_voice(emu, 1, 0, epcm->voices[0],
-                                  start_addr, end_addr);
+                                  start_addr, end_addr,
+                                  &emu->pcm_mixer[substream->number]);
        if (epcm->voices[1])
                snd_emu10k1_pcm_init_voice(emu, 0, 0, epcm->voices[1],
-                                          start_addr, end_addr);
+                                          start_addr, end_addr,
+                                          &emu->pcm_mixer[substream->number]);
        return 0;
 }
 
-static int snd_emu10k1_capture_hw_params(snd_pcm_substream_t * substream,
-                                        snd_pcm_hw_params_t * hw_params)
+static int snd_emu10k1_efx_playback_prepare(struct snd_pcm_substream *substream)
+{
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_emu10k1_pcm *epcm = runtime->private_data;
+       unsigned int start_addr, end_addr;
+       unsigned int channel_size;
+       int i;
+
+       start_addr = epcm->start_addr;
+       end_addr = epcm->start_addr + snd_pcm_lib_buffer_bytes(substream);
+
+       /*
+        * the kX driver leaves some space between voices
+        */
+       channel_size = ( end_addr - start_addr ) / NUM_EFX_PLAYBACK;
+
+       snd_emu10k1_pcm_init_voice(emu, 1, 1, epcm->extra,
+                                  start_addr, start_addr + (channel_size / 2), NULL);
+
+       /* only difference with the master voice is we use it for the pointer */
+       snd_emu10k1_pcm_init_voice(emu, 1, 0, epcm->voices[0],
+                                  start_addr, start_addr + channel_size,
+                                  &emu->efx_pcm_mixer[0]);
+
+       start_addr += channel_size;
+       for (i = 1; i < NUM_EFX_PLAYBACK; i++) {
+               snd_emu10k1_pcm_init_voice(emu, 0, 0, epcm->voices[i],
+                                          start_addr, start_addr + channel_size,
+                                          &emu->efx_pcm_mixer[i]);
+               start_addr += channel_size;
+       }
+
+       return 0;
+}
+
+static struct snd_pcm_hardware snd_emu10k1_efx_playback =
+{
+       .info =                 (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_NONINTERLEAVED |
+                                SNDRV_PCM_INFO_BLOCK_TRANSFER |
+                                SNDRV_PCM_INFO_RESUME |
+                                SNDRV_PCM_INFO_MMAP_VALID | SNDRV_PCM_INFO_PAUSE),
+       .formats =              SNDRV_PCM_FMTBIT_S16_LE,
+       .rates =                SNDRV_PCM_RATE_48000,
+       .rate_min =             48000,
+       .rate_max =             48000,
+       .channels_min =         NUM_EFX_PLAYBACK,
+       .channels_max =         NUM_EFX_PLAYBACK,
+       .buffer_bytes_max =     (64*1024),
+       .period_bytes_min =     64,
+       .period_bytes_max =     (64*1024),
+       .periods_min =          2,
+       .periods_max =          2,
+       .fifo_size =            0,
+};
+
+static int snd_emu10k1_capture_hw_params(struct snd_pcm_substream *substream,
+                                        struct snd_pcm_hw_params *hw_params)
 {
        return snd_pcm_lib_malloc_pages(substream, params_buffer_bytes(hw_params));
 }
 
-static int snd_emu10k1_capture_hw_free(snd_pcm_substream_t * substream)
+static int snd_emu10k1_capture_hw_free(struct snd_pcm_substream *substream)
 {
        return snd_pcm_lib_free_pages(substream);
 }
 
-static int snd_emu10k1_capture_prepare(snd_pcm_substream_t * substream)
+static int snd_emu10k1_capture_prepare(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       emu10k1_pcm_t *epcm = runtime->private_data;
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_emu10k1_pcm *epcm = runtime->private_data;
        int idx;
 
+       /* zeroing the buffer size will stop capture */
        snd_emu10k1_ptr_write(emu, epcm->capture_bs_reg, 0, 0);
        switch (epcm->type) {
        case CAPTURE_AC97ADC:
@@ -483,70 +625,89 @@ static int snd_emu10k1_capture_prepare(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static void snd_emu10k1_playback_invalidate_cache(emu10k1_t *emu, emu10k1_voice_t *evoice)
+static void snd_emu10k1_playback_invalidate_cache(struct snd_emu10k1 *emu, int extra, struct snd_emu10k1_voice *evoice)
 {
-       snd_pcm_runtime_t *runtime;
-       unsigned int voice, i, ccis, cra = 64, cs, sample;
+       struct snd_pcm_runtime *runtime;
+       unsigned int voice, stereo, i, ccis, cra = 64, cs, sample;
 
        if (evoice == NULL)
                return;
        runtime = evoice->epcm->substream->runtime;
        voice = evoice->number;
+       stereo = (!extra && runtime->channels == 2);
        sample = snd_pcm_format_width(runtime->format) == 16 ? 0 : 0x80808080;
-       if (runtime->channels > 1) {
-               ccis = 28;
-               cs = 4;
-       } else {
-               ccis = 30;
-               cs = 2;
-       }
-       if (sample == 0)        /* 16-bit */
-               ccis *= 2;
-       for (i = 0; i < cs; i++)
+       ccis = emu10k1_ccis(stereo, sample == 0);
+       // set cs to 2 * number of cache registers beside the invalidated
+       cs = (sample == 0) ? (32-ccis) : (64-ccis+1) >> 1;
+       if (cs > 16) cs = 16;
+       for (i = 0; i < cs; i++) {
                snd_emu10k1_ptr_write(emu, CD0 + i, voice, sample);
+               if (stereo) {
+                       snd_emu10k1_ptr_write(emu, CD0 + i, voice + 1, sample);
+               }
+       }
        // reset cache
        snd_emu10k1_ptr_write(emu, CCR_CACHEINVALIDSIZE, voice, 0);
        snd_emu10k1_ptr_write(emu, CCR_READADDRESS, voice, cra);
-       if (runtime->channels > 1) {
+       if (stereo) {
                snd_emu10k1_ptr_write(emu, CCR_CACHEINVALIDSIZE, voice + 1, 0);
                snd_emu10k1_ptr_write(emu, CCR_READADDRESS, voice + 1, cra);
        }
        // fill cache
        snd_emu10k1_ptr_write(emu, CCR_CACHEINVALIDSIZE, voice, ccis);
+       if (stereo) {
+               snd_emu10k1_ptr_write(emu, CCR_CACHEINVALIDSIZE, voice+1, ccis);
+       }
 }
 
-static void snd_emu10k1_playback_trigger_voice(emu10k1_t *emu, emu10k1_voice_t *evoice, int master, int extra)
+static void snd_emu10k1_playback_prepare_voice(struct snd_emu10k1 *emu, struct snd_emu10k1_voice *evoice,
+                                              int master, int extra,
+                                              struct snd_emu10k1_pcm_mixer *mix)
 {
-       snd_pcm_substream_t *substream;
-       snd_pcm_runtime_t *runtime;
-       emu10k1_pcm_mixer_t *mix;
-       unsigned int voice, pitch, pitch_target, tmp;
-       unsigned int attn;
+       struct snd_pcm_substream *substream;
+       struct snd_pcm_runtime *runtime;
+       unsigned int attn, vattn;
+       unsigned int voice, tmp;
 
        if (evoice == NULL)     /* skip second voice for mono */
                return;
        substream = evoice->epcm->substream;
        runtime = substream->runtime;
-       mix = &emu->pcm_mixer[substream->number];
        voice = evoice->number;
-       pitch = snd_emu10k1_rate_to_pitch(runtime->rate) >> 8;
-       pitch_target = emu10k1_calc_pitch_target(runtime->rate);
+
        attn = extra ? 0 : 0x00ff;
        tmp = runtime->channels == 2 ? (master ? 1 : 2) : 0;
+       vattn = mix != NULL ? (mix->attn[tmp] << 16) : 0;
        snd_emu10k1_ptr_write(emu, IFATN, voice, attn);
-       snd_emu10k1_ptr_write(emu, VTFT, voice, (mix->attn[tmp] << 16) | 0xffff);
-       snd_emu10k1_ptr_write(emu, CVCF, voice, (mix->attn[tmp] << 16) | 0xffff);
-       snd_emu10k1_voice_clear_loop_stop(emu, voice);          
-       if (extra)
-               snd_emu10k1_voice_intr_enable(emu, voice);
+       snd_emu10k1_ptr_write(emu, VTFT, voice, vattn | 0xffff);
+       snd_emu10k1_ptr_write(emu, CVCF, voice, vattn | 0xffff);
        snd_emu10k1_ptr_write(emu, DCYSUSV, voice, 0x7f7f);
+       snd_emu10k1_voice_clear_loop_stop(emu, voice);
+}      
+
+static void snd_emu10k1_playback_trigger_voice(struct snd_emu10k1 *emu, struct snd_emu10k1_voice *evoice, int master, int extra)
+{
+       struct snd_pcm_substream *substream;
+       struct snd_pcm_runtime *runtime;
+       unsigned int voice, pitch, pitch_target;
+
+       if (evoice == NULL)     /* skip second voice for mono */
+               return;
+       substream = evoice->epcm->substream;
+       runtime = substream->runtime;
+       voice = evoice->number;
+
+       pitch = snd_emu10k1_rate_to_pitch(runtime->rate) >> 8;
+       pitch_target = emu10k1_calc_pitch_target(runtime->rate);
        snd_emu10k1_ptr_write(emu, PTRX_PITCHTARGET, voice, pitch_target);
-       if (master)
+       if (master || evoice->epcm->type == PLAYBACK_EFX)
                snd_emu10k1_ptr_write(emu, CPF_CURRENTPITCH, voice, pitch_target);
        snd_emu10k1_ptr_write(emu, IP, voice, pitch);
+       if (extra)
+               snd_emu10k1_voice_intr_enable(emu, voice);
 }
 
-static void snd_emu10k1_playback_stop_voice(emu10k1_t *emu, emu10k1_voice_t *evoice)
+static void snd_emu10k1_playback_stop_voice(struct snd_emu10k1 *emu, struct snd_emu10k1_voice *evoice)
 {
        unsigned int voice;
 
@@ -562,22 +723,28 @@ static void snd_emu10k1_playback_stop_voice(emu10k1_t *emu, emu10k1_voice_t *evo
        snd_emu10k1_ptr_write(emu, IP, voice, 0);
 }
 
-static int snd_emu10k1_playback_trigger(snd_pcm_substream_t * substream,
+static int snd_emu10k1_playback_trigger(struct snd_pcm_substream *substream,
                                        int cmd)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       emu10k1_pcm_t *epcm = runtime->private_data;
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_emu10k1_pcm *epcm = runtime->private_data;
+       struct snd_emu10k1_pcm_mixer *mix;
        int result = 0;
 
        // printk("trigger - emu10k1 = 0x%x, cmd = %i, pointer = %i\n", (int)emu, cmd, substream->ops->pointer(substream));
        spin_lock(&emu->reg_lock);
        switch (cmd) {
        case SNDRV_PCM_TRIGGER_START:
-               snd_emu10k1_playback_invalidate_cache(emu, epcm->extra);        /* do we need this? */
-               snd_emu10k1_playback_invalidate_cache(emu, epcm->voices[0]);
+               snd_emu10k1_playback_invalidate_cache(emu, 1, epcm->extra);     /* do we need this? */
+               snd_emu10k1_playback_invalidate_cache(emu, 0, epcm->voices[0]);
                /* follow thru */
        case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
+       case SNDRV_PCM_TRIGGER_RESUME:
+               mix = &emu->pcm_mixer[substream->number];
+               snd_emu10k1_playback_prepare_voice(emu, epcm->voices[0], 1, 0, mix);
+               snd_emu10k1_playback_prepare_voice(emu, epcm->voices[1], 0, 0, mix);
+               snd_emu10k1_playback_prepare_voice(emu, epcm->extra, 1, 1, NULL);
                snd_emu10k1_playback_trigger_voice(emu, epcm->voices[0], 1, 0);
                snd_emu10k1_playback_trigger_voice(emu, epcm->voices[1], 0, 0);
                snd_emu10k1_playback_trigger_voice(emu, epcm->extra, 1, 1);
@@ -585,6 +752,7 @@ static int snd_emu10k1_playback_trigger(snd_pcm_substream_t * substream,
                break;
        case SNDRV_PCM_TRIGGER_STOP:
        case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
+       case SNDRV_PCM_TRIGGER_SUSPEND:
                epcm->running = 0;
                snd_emu10k1_playback_stop_voice(emu, epcm->voices[0]);
                snd_emu10k1_playback_stop_voice(emu, epcm->voices[1]);
@@ -598,18 +766,19 @@ static int snd_emu10k1_playback_trigger(snd_pcm_substream_t * substream,
        return result;
 }
 
-static int snd_emu10k1_capture_trigger(snd_pcm_substream_t * substream,
+static int snd_emu10k1_capture_trigger(struct snd_pcm_substream *substream,
                                       int cmd)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       emu10k1_pcm_t *epcm = runtime->private_data;
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_emu10k1_pcm *epcm = runtime->private_data;
        int result = 0;
 
-       // printk("trigger - emu10k1 = %p, cmd = %i, pointer = %i\n", emu, cmd, substream->ops->pointer(substream));
        spin_lock(&emu->reg_lock);
        switch (cmd) {
        case SNDRV_PCM_TRIGGER_START:
+       case SNDRV_PCM_TRIGGER_RESUME:
+               // hmm this should cause full and half full interrupt to be raised?  
                outl(epcm->capture_ipr, emu->port + IPR);
                snd_emu10k1_intr_enable(emu, epcm->capture_inte);
                // printk("adccr = 0x%x, adcbs = 0x%x\n", epcm->adccr, epcm->adcbs);
@@ -632,6 +801,7 @@ static int snd_emu10k1_capture_trigger(snd_pcm_substream_t * substream,
                epcm->first_ptr = 1;
                break;
        case SNDRV_PCM_TRIGGER_STOP:
+       case SNDRV_PCM_TRIGGER_SUSPEND:
                epcm->running = 0;
                snd_emu10k1_intr_disable(emu, epcm->capture_inte);
                outl(epcm->capture_ipr, emu->port + IPR);
@@ -658,11 +828,11 @@ static int snd_emu10k1_capture_trigger(snd_pcm_substream_t * substream,
        return result;
 }
 
-static snd_pcm_uframes_t snd_emu10k1_playback_pointer(snd_pcm_substream_t * substream)
+static snd_pcm_uframes_t snd_emu10k1_playback_pointer(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       emu10k1_pcm_t *epcm = runtime->private_data;
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_emu10k1_pcm *epcm = runtime->private_data;
        unsigned int ptr;
 
        if (!epcm->running)
@@ -685,11 +855,63 @@ static snd_pcm_uframes_t snd_emu10k1_playback_pointer(snd_pcm_substream_t * subs
        return ptr;
 }
 
-static snd_pcm_uframes_t snd_emu10k1_capture_pointer(snd_pcm_substream_t * substream)
+
+static int snd_emu10k1_efx_playback_trigger(struct snd_pcm_substream *substream,
+                                       int cmd)
+{
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_emu10k1_pcm *epcm = runtime->private_data;
+       int i;
+       int result = 0;
+
+       spin_lock(&emu->reg_lock);
+       switch (cmd) {
+       case SNDRV_PCM_TRIGGER_START:
+               // prepare voices
+               for (i = 0; i < NUM_EFX_PLAYBACK; i++) {        
+                       snd_emu10k1_playback_invalidate_cache(emu, 0, epcm->voices[i]);
+               }
+               snd_emu10k1_playback_invalidate_cache(emu, 1, epcm->extra);
+
+               /* follow thru */
+       case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
+       case SNDRV_PCM_TRIGGER_RESUME:
+               snd_emu10k1_playback_prepare_voice(emu, epcm->extra, 1, 1, NULL);
+               snd_emu10k1_playback_prepare_voice(emu, epcm->voices[0], 0, 0,
+                                                  &emu->efx_pcm_mixer[0]);
+               for (i = 1; i < NUM_EFX_PLAYBACK; i++)
+                       snd_emu10k1_playback_prepare_voice(emu, epcm->voices[i], 0, 0,
+                                                          &emu->efx_pcm_mixer[i]);
+               snd_emu10k1_playback_trigger_voice(emu, epcm->voices[0], 0, 0);
+               snd_emu10k1_playback_trigger_voice(emu, epcm->extra, 1, 1);
+               for (i = 1; i < NUM_EFX_PLAYBACK; i++)
+                       snd_emu10k1_playback_trigger_voice(emu, epcm->voices[i], 0, 0);
+               epcm->running = 1;
+               break;
+       case SNDRV_PCM_TRIGGER_SUSPEND:
+       case SNDRV_PCM_TRIGGER_STOP:
+       case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
+               epcm->running = 0;
+               for (i = 0; i < NUM_EFX_PLAYBACK; i++) {        
+                       snd_emu10k1_playback_stop_voice(emu, epcm->voices[i]);
+               }
+               snd_emu10k1_playback_stop_voice(emu, epcm->extra);
+               break;
+       default:
+               result = -EINVAL;
+               break;
+       }
+       spin_unlock(&emu->reg_lock);
+       return result;
+}
+
+
+static snd_pcm_uframes_t snd_emu10k1_capture_pointer(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       emu10k1_pcm_t *epcm = runtime->private_data;
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_emu10k1_pcm *epcm = runtime->private_data;
        unsigned int ptr;
 
        if (!epcm->running)
@@ -706,15 +928,16 @@ static snd_pcm_uframes_t snd_emu10k1_capture_pointer(snd_pcm_substream_t * subst
  *  Playback support device description
  */
 
-static snd_pcm_hardware_t snd_emu10k1_playback =
+static struct snd_pcm_hardware snd_emu10k1_playback =
 {
        .info =                 (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
                                 SNDRV_PCM_INFO_BLOCK_TRANSFER |
+                                SNDRV_PCM_INFO_RESUME |
                                 SNDRV_PCM_INFO_MMAP_VALID | SNDRV_PCM_INFO_PAUSE),
        .formats =              SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S16_LE,
-       .rates =                SNDRV_PCM_RATE_CONTINUOUS | SNDRV_PCM_RATE_8000_48000,
+       .rates =                SNDRV_PCM_RATE_CONTINUOUS | SNDRV_PCM_RATE_8000_96000,
        .rate_min =             4000,
-       .rate_max =             48000,
+       .rate_max =             96000,
        .channels_min =         1,
        .channels_max =         2,
        .buffer_bytes_max =     (128*1024),
@@ -729,10 +952,11 @@ static snd_pcm_hardware_t snd_emu10k1_playback =
  *  Capture support device description
  */
 
-static snd_pcm_hardware_t snd_emu10k1_capture =
+static struct snd_pcm_hardware snd_emu10k1_capture =
 {
        .info =                 (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
                                 SNDRV_PCM_INFO_BLOCK_TRANSFER |
+                                SNDRV_PCM_INFO_RESUME |
                                 SNDRV_PCM_INFO_MMAP_VALID),
        .formats =              SNDRV_PCM_FMTBIT_S16_LE,
        .rates =                SNDRV_PCM_RATE_8000_48000,
@@ -752,11 +976,12 @@ static snd_pcm_hardware_t snd_emu10k1_capture =
  *
  */
 
-static void snd_emu10k1_pcm_mixer_notify1(emu10k1_t *emu, snd_kcontrol_t *kctl, int idx, int activate)
+static void snd_emu10k1_pcm_mixer_notify1(struct snd_emu10k1 *emu, struct snd_kcontrol *kctl, int idx, int activate)
 {
-       snd_ctl_elem_id_t id;
+       struct snd_ctl_elem_id id;
 
-       snd_runtime_check(kctl != NULL, return);
+       if (! kctl)
+               return;
        if (activate)
                kctl->vd[idx].access &= ~SNDRV_CTL_ELEM_ACCESS_INACTIVE;
        else
@@ -766,30 +991,81 @@ static void snd_emu10k1_pcm_mixer_notify1(emu10k1_t *emu, snd_kcontrol_t *kctl,
                       snd_ctl_build_ioff(&id, kctl, idx));
 }
 
-static void snd_emu10k1_pcm_mixer_notify(emu10k1_t *emu, int idx, int activate)
+static void snd_emu10k1_pcm_mixer_notify(struct snd_emu10k1 *emu, int idx, int activate)
 {
        snd_emu10k1_pcm_mixer_notify1(emu, emu->ctl_send_routing, idx, activate);
        snd_emu10k1_pcm_mixer_notify1(emu, emu->ctl_send_volume, idx, activate);
        snd_emu10k1_pcm_mixer_notify1(emu, emu->ctl_attn, idx, activate);
 }
 
-static void snd_emu10k1_pcm_free_substream(snd_pcm_runtime_t *runtime)
+static void snd_emu10k1_pcm_efx_mixer_notify(struct snd_emu10k1 *emu, int idx, int activate)
 {
-       emu10k1_pcm_t *epcm = runtime->private_data;
+       snd_emu10k1_pcm_mixer_notify1(emu, emu->ctl_efx_send_routing, idx, activate);
+       snd_emu10k1_pcm_mixer_notify1(emu, emu->ctl_efx_send_volume, idx, activate);
+       snd_emu10k1_pcm_mixer_notify1(emu, emu->ctl_efx_attn, idx, activate);
+}
 
-       if (epcm)
-               kfree(epcm);
+static void snd_emu10k1_pcm_free_substream(struct snd_pcm_runtime *runtime)
+{
+       kfree(runtime->private_data);
 }
 
-static int snd_emu10k1_playback_open(snd_pcm_substream_t * substream)
+static int snd_emu10k1_efx_playback_close(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       emu10k1_pcm_t *epcm;
-       emu10k1_pcm_mixer_t *mix;
-       snd_pcm_runtime_t *runtime = substream->runtime;
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_emu10k1_pcm_mixer *mix;
+       int i;
+
+       for (i=0; i < NUM_EFX_PLAYBACK; i++) {
+               mix = &emu->efx_pcm_mixer[i];
+               mix->epcm = NULL;
+               snd_emu10k1_pcm_efx_mixer_notify(emu, i, 0);
+       }
+       return 0;
+}
+
+static int snd_emu10k1_efx_playback_open(struct snd_pcm_substream *substream)
+{
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_emu10k1_pcm *epcm;
+       struct snd_emu10k1_pcm_mixer *mix;
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       int i;
+
+       epcm = kzalloc(sizeof(*epcm), GFP_KERNEL);
+       if (epcm == NULL)
+               return -ENOMEM;
+       epcm->emu = emu;
+       epcm->type = PLAYBACK_EFX;
+       epcm->substream = substream;
+       
+       emu->pcm_playback_efx_substream = substream;
+
+       runtime->private_data = epcm;
+       runtime->private_free = snd_emu10k1_pcm_free_substream;
+       runtime->hw = snd_emu10k1_efx_playback;
+       
+       for (i=0; i < NUM_EFX_PLAYBACK; i++) {
+               mix = &emu->efx_pcm_mixer[i];
+               mix->send_routing[0][0] = i;
+               memset(&mix->send_volume, 0, sizeof(mix->send_volume));
+               mix->send_volume[0][0] = 255;
+               mix->attn[0] = 0xffff;
+               mix->epcm = epcm;
+               snd_emu10k1_pcm_efx_mixer_notify(emu, i, 1);
+       }
+       return 0;
+}
+
+static int snd_emu10k1_playback_open(struct snd_pcm_substream *substream)
+{
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_emu10k1_pcm *epcm;
+       struct snd_emu10k1_pcm_mixer *mix;
+       struct snd_pcm_runtime *runtime = substream->runtime;
        int i, err;
 
-       epcm = kcalloc(1, sizeof(*epcm), GFP_KERNEL);
+       epcm = kzalloc(sizeof(*epcm), GFP_KERNEL);
        if (epcm == NULL)
                return -ENOMEM;
        epcm->emu = emu;
@@ -818,23 +1094,23 @@ static int snd_emu10k1_playback_open(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static int snd_emu10k1_playback_close(snd_pcm_substream_t * substream)
+static int snd_emu10k1_playback_close(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       emu10k1_pcm_mixer_t *mix = &emu->pcm_mixer[substream->number];
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_emu10k1_pcm_mixer *mix = &emu->pcm_mixer[substream->number];
 
        mix->epcm = NULL;
        snd_emu10k1_pcm_mixer_notify(emu, substream->number, 0);
        return 0;
 }
 
-static int snd_emu10k1_capture_open(snd_pcm_substream_t * substream)
+static int snd_emu10k1_capture_open(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       emu10k1_pcm_t *epcm;
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_emu10k1_pcm *epcm;
 
-       epcm = kcalloc(1, sizeof(*epcm), GFP_KERNEL);
+       epcm = kzalloc(sizeof(*epcm), GFP_KERNEL);
        if (epcm == NULL)
                return -ENOMEM;
        epcm->emu = emu;
@@ -855,22 +1131,22 @@ static int snd_emu10k1_capture_open(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static int snd_emu10k1_capture_close(snd_pcm_substream_t * substream)
+static int snd_emu10k1_capture_close(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
 
        emu->capture_interrupt = NULL;
        emu->pcm_capture_substream = NULL;
        return 0;
 }
 
-static int snd_emu10k1_capture_mic_open(snd_pcm_substream_t * substream)
+static int snd_emu10k1_capture_mic_open(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       emu10k1_pcm_t *epcm;
-       snd_pcm_runtime_t *runtime = substream->runtime;
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_emu10k1_pcm *epcm;
+       struct snd_pcm_runtime *runtime = substream->runtime;
 
-       epcm = kcalloc(1, sizeof(*epcm), GFP_KERNEL);
+       epcm = kzalloc(sizeof(*epcm), GFP_KERNEL);
        if (epcm == NULL)
                return -ENOMEM;
        epcm->emu = emu;
@@ -893,24 +1169,24 @@ static int snd_emu10k1_capture_mic_open(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static int snd_emu10k1_capture_mic_close(snd_pcm_substream_t * substream)
+static int snd_emu10k1_capture_mic_close(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
 
        emu->capture_interrupt = NULL;
        emu->pcm_capture_mic_substream = NULL;
        return 0;
 }
 
-static int snd_emu10k1_capture_efx_open(snd_pcm_substream_t * substream)
+static int snd_emu10k1_capture_efx_open(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       emu10k1_pcm_t *epcm;
-       snd_pcm_runtime_t *runtime = substream->runtime;
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_emu10k1_pcm *epcm;
+       struct snd_pcm_runtime *runtime = substream->runtime;
        int nefx = emu->audigy ? 64 : 32;
        int idx;
 
-       epcm = kcalloc(1, sizeof(*epcm), GFP_KERNEL);
+       epcm = kzalloc(sizeof(*epcm), GFP_KERNEL);
        if (epcm == NULL)
                return -ENOMEM;
        epcm->emu = emu;
@@ -943,16 +1219,16 @@ static int snd_emu10k1_capture_efx_open(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static int snd_emu10k1_capture_efx_close(snd_pcm_substream_t * substream)
+static int snd_emu10k1_capture_efx_close(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
 
        emu->capture_interrupt = NULL;
        emu->pcm_capture_efx_substream = NULL;
        return 0;
 }
 
-static snd_pcm_ops_t snd_emu10k1_playback_ops = {
+static struct snd_pcm_ops snd_emu10k1_playback_ops = {
        .open =                 snd_emu10k1_playback_open,
        .close =                snd_emu10k1_playback_close,
        .ioctl =                snd_pcm_lib_ioctl,
@@ -964,7 +1240,7 @@ static snd_pcm_ops_t snd_emu10k1_playback_ops = {
        .page =                 snd_pcm_sgbuf_ops_page,
 };
 
-static snd_pcm_ops_t snd_emu10k1_capture_ops = {
+static struct snd_pcm_ops snd_emu10k1_capture_ops = {
        .open =                 snd_emu10k1_capture_open,
        .close =                snd_emu10k1_capture_close,
        .ioctl =                snd_pcm_lib_ioctl,
@@ -975,17 +1251,23 @@ static snd_pcm_ops_t snd_emu10k1_capture_ops = {
        .pointer =              snd_emu10k1_capture_pointer,
 };
 
-static void snd_emu10k1_pcm_free(snd_pcm_t *pcm)
-{
-       emu10k1_t *emu = pcm->private_data;
-       emu->pcm = NULL;
-       snd_pcm_lib_preallocate_free_for_all(pcm);
-}
+/* EFX playback */
+static struct snd_pcm_ops snd_emu10k1_efx_playback_ops = {
+       .open =                 snd_emu10k1_efx_playback_open,
+       .close =                snd_emu10k1_efx_playback_close,
+       .ioctl =                snd_pcm_lib_ioctl,
+       .hw_params =            snd_emu10k1_playback_hw_params,
+       .hw_free =              snd_emu10k1_efx_playback_hw_free,
+       .prepare =              snd_emu10k1_efx_playback_prepare,
+       .trigger =              snd_emu10k1_efx_playback_trigger,
+       .pointer =              snd_emu10k1_efx_playback_pointer,
+       .page =                 snd_pcm_sgbuf_ops_page,
+};
 
-int __devinit snd_emu10k1_pcm(emu10k1_t * emu, int device, snd_pcm_t ** rpcm)
+int __devinit snd_emu10k1_pcm(struct snd_emu10k1 * emu, int device, struct snd_pcm ** rpcm)
 {
-       snd_pcm_t *pcm;
-       snd_pcm_substream_t *substream;
+       struct snd_pcm *pcm;
+       struct snd_pcm_substream *substream;
        int err;
 
        if (rpcm)
@@ -995,14 +1277,13 @@ int __devinit snd_emu10k1_pcm(emu10k1_t * emu, int device, snd_pcm_t ** rpcm)
                return err;
 
        pcm->private_data = emu;
-       pcm->private_free = snd_emu10k1_pcm_free;
 
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &snd_emu10k1_playback_ops);
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &snd_emu10k1_capture_ops);
 
        pcm->info_flags = 0;
        pcm->dev_subclass = SNDRV_PCM_SUBCLASS_GENERIC_MIX;
-       strcpy(pcm->name, "EMU10K1");
+       strcpy(pcm->name, "ADC Capture/Standard PCM Playback");
        emu->pcm = pcm;
 
        for (substream = pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream; substream; substream = substream->next)
@@ -1018,7 +1299,39 @@ int __devinit snd_emu10k1_pcm(emu10k1_t * emu, int device, snd_pcm_t ** rpcm)
        return 0;
 }
 
-static snd_pcm_ops_t snd_emu10k1_capture_mic_ops = {
+int __devinit snd_emu10k1_pcm_multi(struct snd_emu10k1 * emu, int device, struct snd_pcm ** rpcm)
+{
+       struct snd_pcm *pcm;
+       struct snd_pcm_substream *substream;
+       int err;
+
+       if (rpcm)
+               *rpcm = NULL;
+
+       if ((err = snd_pcm_new(emu->card, "emu10k1", device, 1, 0, &pcm)) < 0)
+               return err;
+
+       pcm->private_data = emu;
+
+       snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &snd_emu10k1_efx_playback_ops);
+
+       pcm->info_flags = 0;
+       pcm->dev_subclass = SNDRV_PCM_SUBCLASS_GENERIC_MIX;
+       strcpy(pcm->name, "Multichannel Playback");
+       emu->pcm_multi = pcm;
+
+       for (substream = pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream; substream; substream = substream->next)
+               if ((err = snd_pcm_lib_preallocate_pages(substream, SNDRV_DMA_TYPE_DEV_SG, snd_dma_pci_data(emu->pci), 64*1024, 64*1024)) < 0)
+                       return err;
+
+       if (rpcm)
+               *rpcm = pcm;
+
+       return 0;
+}
+
+
+static struct snd_pcm_ops snd_emu10k1_capture_mic_ops = {
        .open =                 snd_emu10k1_capture_mic_open,
        .close =                snd_emu10k1_capture_mic_close,
        .ioctl =                snd_pcm_lib_ioctl,
@@ -1029,16 +1342,9 @@ static snd_pcm_ops_t snd_emu10k1_capture_mic_ops = {
        .pointer =              snd_emu10k1_capture_pointer,
 };
 
-static void snd_emu10k1_pcm_mic_free(snd_pcm_t *pcm)
-{
-       emu10k1_t *emu = pcm->private_data;
-       emu->pcm_mic = NULL;
-       snd_pcm_lib_preallocate_free_for_all(pcm);
-}
-
-int __devinit snd_emu10k1_pcm_mic(emu10k1_t * emu, int device, snd_pcm_t ** rpcm)
+int __devinit snd_emu10k1_pcm_mic(struct snd_emu10k1 * emu, int device, struct snd_pcm ** rpcm)
 {
-       snd_pcm_t *pcm;
+       struct snd_pcm *pcm;
        int err;
 
        if (rpcm)
@@ -1048,12 +1354,11 @@ int __devinit snd_emu10k1_pcm_mic(emu10k1_t * emu, int device, snd_pcm_t ** rpcm
                return err;
 
        pcm->private_data = emu;
-       pcm->private_free = snd_emu10k1_pcm_mic_free;
 
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &snd_emu10k1_capture_mic_ops);
 
        pcm->info_flags = 0;
-       strcpy(pcm->name, "EMU10K1 MIC");
+       strcpy(pcm->name, "Mic Capture");
        emu->pcm_mic = pcm;
 
        snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV, snd_dma_pci_data(emu->pci), 64*1024, 64*1024);
@@ -1063,9 +1368,9 @@ int __devinit snd_emu10k1_pcm_mic(emu10k1_t * emu, int device, snd_pcm_t ** rpcm
        return 0;
 }
 
-static int snd_emu10k1_pcm_efx_voices_mask_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_emu10k1_pcm_efx_voices_mask_info(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
-       emu10k1_t *emu = snd_kcontrol_chip(kcontrol);
+       struct snd_emu10k1 *emu = snd_kcontrol_chip(kcontrol);
        int nefx = emu->audigy ? 64 : 32;
        uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
        uinfo->count = nefx;
@@ -1074,9 +1379,9 @@ static int snd_emu10k1_pcm_efx_voices_mask_info(snd_kcontrol_t *kcontrol, snd_ct
        return 0;
 }
 
-static int snd_emu10k1_pcm_efx_voices_mask_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_emu10k1_pcm_efx_voices_mask_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       emu10k1_t *emu = snd_kcontrol_chip(kcontrol);
+       struct snd_emu10k1 *emu = snd_kcontrol_chip(kcontrol);
        int nefx = emu->audigy ? 64 : 32;
        int idx;
        
@@ -1087,11 +1392,12 @@ static int snd_emu10k1_pcm_efx_voices_mask_get(snd_kcontrol_t * kcontrol, snd_ct
        return 0;
 }
 
-static int snd_emu10k1_pcm_efx_voices_mask_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_emu10k1_pcm_efx_voices_mask_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
-       emu10k1_t *emu = snd_kcontrol_chip(kcontrol);
+       struct snd_emu10k1 *emu = snd_kcontrol_chip(kcontrol);
        unsigned int nval[2], bits;
        int nefx = emu->audigy ? 64 : 32;
+       int nefxb = emu->audigy ? 7 : 6;
        int change, idx;
        
        nval[0] = nval[1] = 0;
@@ -1100,8 +1406,14 @@ static int snd_emu10k1_pcm_efx_voices_mask_put(snd_kcontrol_t * kcontrol, snd_ct
                        nval[idx / 32] |= 1 << (idx % 32);
                        bits++;
                }
-       if (bits != 1 && bits != 2 && bits != 4 && bits != 8)
+               
+       for (idx = 0; idx < nefxb; idx++)
+               if (1 << idx == bits)
+                       break;
+       
+       if (idx >= nefxb)
                return -EINVAL;
+
        spin_lock_irq(&emu->reg_lock);
        change = (nval[0] != emu->efx_voices_mask[0]) ||
                (nval[1] != emu->efx_voices_mask[1]);
@@ -1111,15 +1423,15 @@ static int snd_emu10k1_pcm_efx_voices_mask_put(snd_kcontrol_t * kcontrol, snd_ct
        return change;
 }
 
-static snd_kcontrol_new_t snd_emu10k1_pcm_efx_voices_mask = {
+static struct snd_kcontrol_new snd_emu10k1_pcm_efx_voices_mask = {
        .iface = SNDRV_CTL_ELEM_IFACE_PCM,
-       .name = "EFX voices mask",
+       .name = "Captured FX8010 Outputs",
        .info = snd_emu10k1_pcm_efx_voices_mask_info,
        .get = snd_emu10k1_pcm_efx_voices_mask_get,
        .put = snd_emu10k1_pcm_efx_voices_mask_put
 };
 
-static snd_pcm_ops_t snd_emu10k1_capture_efx_ops = {
+static struct snd_pcm_ops snd_emu10k1_capture_efx_ops = {
        .open =                 snd_emu10k1_capture_efx_open,
        .close =                snd_emu10k1_capture_efx_close,
        .ioctl =                snd_pcm_lib_ioctl,
@@ -1136,9 +1448,9 @@ static snd_pcm_ops_t snd_emu10k1_capture_efx_ops = {
 #define INITIAL_TRAM_SHIFT     14
 #define INITIAL_TRAM_POS(size) ((((size) / 2) - INITIAL_TRAM_SHIFT) - 1)
 
-static void snd_emu10k1_fx8010_playback_irq(emu10k1_t *emu, void *private_data)
+static void snd_emu10k1_fx8010_playback_irq(struct snd_emu10k1 *emu, void *private_data)
 {
-       snd_pcm_substream_t *substream = private_data;
+       struct snd_pcm_substream *substream = private_data;
        snd_pcm_period_elapsed(substream);
 }
 
@@ -1162,11 +1474,11 @@ static void snd_emu10k1_fx8010_playback_tram_poke1(unsigned short *dst_left,
        }
 }
 
-static void fx8010_pb_trans_copy(snd_pcm_substream_t *substream,
-                                snd_pcm_indirect_t *rec, size_t bytes)
+static void fx8010_pb_trans_copy(struct snd_pcm_substream *substream,
+                                struct snd_pcm_indirect *rec, size_t bytes)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_emu10k1_fx8010_pcm_t *pcm = &emu->fx8010.pcm[substream->number];
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_emu10k1_fx8010_pcm *pcm = &emu->fx8010.pcm[substream->number];
        unsigned int tram_size = pcm->buffer_size;
        unsigned short *src = (unsigned short *)(substream->runtime->dma_area + rec->sw_data);
        unsigned int frames = bytes >> 2, count;
@@ -1185,31 +1497,31 @@ static void fx8010_pb_trans_copy(snd_pcm_substream_t *substream,
        }
        snd_emu10k1_fx8010_playback_tram_poke1((unsigned short *)emu->fx8010.etram_pages.area + tram_pos,
                                               (unsigned short *)emu->fx8010.etram_pages.area + tram_pos + tram_size / 2,
-                                              src, frames, tram_shift++);
+                                              src, frames, tram_shift);
        tram_pos -= frames;
        pcm->tram_pos = tram_pos;
        pcm->tram_shift = tram_shift;
 }
 
-static int snd_emu10k1_fx8010_playback_transfer(snd_pcm_substream_t *substream)
+static int snd_emu10k1_fx8010_playback_transfer(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_emu10k1_fx8010_pcm_t *pcm = &emu->fx8010.pcm[substream->number];
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_emu10k1_fx8010_pcm *pcm = &emu->fx8010.pcm[substream->number];
 
        snd_pcm_indirect_playback_transfer(substream, &pcm->pcm_rec, fx8010_pb_trans_copy);
        return 0;
 }
 
-static int snd_emu10k1_fx8010_playback_hw_params(snd_pcm_substream_t * substream,
-                                                snd_pcm_hw_params_t * hw_params)
+static int snd_emu10k1_fx8010_playback_hw_params(struct snd_pcm_substream *substream,
+                                                struct snd_pcm_hw_params *hw_params)
 {
        return snd_pcm_lib_malloc_pages(substream, params_buffer_bytes(hw_params));
 }
 
-static int snd_emu10k1_fx8010_playback_hw_free(snd_pcm_substream_t * substream)
+static int snd_emu10k1_fx8010_playback_hw_free(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_emu10k1_fx8010_pcm_t *pcm = &emu->fx8010.pcm[substream->number];
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_emu10k1_fx8010_pcm *pcm = &emu->fx8010.pcm[substream->number];
        unsigned int i;
 
        for (i = 0; i < pcm->channels; i++)
@@ -1218,11 +1530,11 @@ static int snd_emu10k1_fx8010_playback_hw_free(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static int snd_emu10k1_fx8010_playback_prepare(snd_pcm_substream_t * substream)
+static int snd_emu10k1_fx8010_playback_prepare(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       snd_emu10k1_fx8010_pcm_t *pcm = &emu->fx8010.pcm[substream->number];
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_emu10k1_fx8010_pcm *pcm = &emu->fx8010.pcm[substream->number];
        unsigned int i;
        
        // printk("prepare: etram_pages = 0x%p, dma_area = 0x%x, buffer_size = 0x%x (0x%x)\n", emu->fx8010.etram_pages, runtime->dma_area, runtime->buffer_size, runtime->buffer_size << 2);
@@ -1242,10 +1554,10 @@ static int snd_emu10k1_fx8010_playback_prepare(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static int snd_emu10k1_fx8010_playback_trigger(snd_pcm_substream_t * substream, int cmd)
+static int snd_emu10k1_fx8010_playback_trigger(struct snd_pcm_substream *substream, int cmd)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_emu10k1_fx8010_pcm_t *pcm = &emu->fx8010.pcm[substream->number];
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_emu10k1_fx8010_pcm *pcm = &emu->fx8010.pcm[substream->number];
        int result = 0;
 
        spin_lock(&emu->reg_lock);
@@ -1253,6 +1565,7 @@ static int snd_emu10k1_fx8010_playback_trigger(snd_pcm_substream_t * substream,
        case SNDRV_PCM_TRIGGER_START:
                /* follow thru */
        case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
+       case SNDRV_PCM_TRIGGER_RESUME:
 #ifdef EMU10K1_SET_AC3_IEC958
        {
                int i;
@@ -1273,6 +1586,7 @@ static int snd_emu10k1_fx8010_playback_trigger(snd_pcm_substream_t * substream,
                break;
        case SNDRV_PCM_TRIGGER_STOP:
        case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
+       case SNDRV_PCM_TRIGGER_SUSPEND:
                snd_emu10k1_fx8010_unregister_irq_handler(emu, pcm->irq); pcm->irq = NULL;
                snd_emu10k1_ptr_write(emu, emu->gpr_base + pcm->gpr_trigger, 0, 0);
                pcm->tram_pos = INITIAL_TRAM_POS(pcm->buffer_size);
@@ -1287,10 +1601,10 @@ static int snd_emu10k1_fx8010_playback_trigger(snd_pcm_substream_t * substream,
        return result;
 }
 
-static snd_pcm_uframes_t snd_emu10k1_fx8010_playback_pointer(snd_pcm_substream_t * substream)
+static snd_pcm_uframes_t snd_emu10k1_fx8010_playback_pointer(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_emu10k1_fx8010_pcm_t *pcm = &emu->fx8010.pcm[substream->number];
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_emu10k1_fx8010_pcm *pcm = &emu->fx8010.pcm[substream->number];
        size_t ptr; /* byte pointer */
 
        if (!snd_emu10k1_ptr_read(emu, emu->gpr_base + pcm->gpr_trigger, 0))
@@ -1299,9 +1613,10 @@ static snd_pcm_uframes_t snd_emu10k1_fx8010_playback_pointer(snd_pcm_substream_t
        return snd_pcm_indirect_playback_pointer(substream, &pcm->pcm_rec, ptr);
 }
 
-static snd_pcm_hardware_t snd_emu10k1_fx8010_playback =
+static struct snd_pcm_hardware snd_emu10k1_fx8010_playback =
 {
        .info =                 (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
+                                SNDRV_PCM_INFO_RESUME |
                                 /* SNDRV_PCM_INFO_MMAP_VALID | */ SNDRV_PCM_INFO_PAUSE),
        .formats =              SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S16_LE,
        .rates =                SNDRV_PCM_RATE_48000,
@@ -1317,11 +1632,11 @@ static snd_pcm_hardware_t snd_emu10k1_fx8010_playback =
        .fifo_size =            0,
 };
 
-static int snd_emu10k1_fx8010_playback_open(snd_pcm_substream_t * substream)
+static int snd_emu10k1_fx8010_playback_open(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       snd_emu10k1_fx8010_pcm_t *pcm = &emu->fx8010.pcm[substream->number];
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_emu10k1_fx8010_pcm *pcm = &emu->fx8010.pcm[substream->number];
 
        runtime->hw = snd_emu10k1_fx8010_playback;
        runtime->hw.channels_min = runtime->hw.channels_max = pcm->channels;
@@ -1336,10 +1651,10 @@ static int snd_emu10k1_fx8010_playback_open(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static int snd_emu10k1_fx8010_playback_close(snd_pcm_substream_t * substream)
+static int snd_emu10k1_fx8010_playback_close(struct snd_pcm_substream *substream)
 {
-       emu10k1_t *emu = snd_pcm_substream_chip(substream);
-       snd_emu10k1_fx8010_pcm_t *pcm = &emu->fx8010.pcm[substream->number];
+       struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream);
+       struct snd_emu10k1_fx8010_pcm *pcm = &emu->fx8010.pcm[substream->number];
 
        spin_lock_irq(&emu->reg_lock);
        pcm->opened = 0;
@@ -1347,7 +1662,7 @@ static int snd_emu10k1_fx8010_playback_close(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static snd_pcm_ops_t snd_emu10k1_fx8010_playback_ops = {
+static struct snd_pcm_ops snd_emu10k1_fx8010_playback_ops = {
        .open =                 snd_emu10k1_fx8010_playback_open,
        .close =                snd_emu10k1_fx8010_playback_close,
        .ioctl =                snd_pcm_lib_ioctl,
@@ -1359,16 +1674,10 @@ static snd_pcm_ops_t snd_emu10k1_fx8010_playback_ops = {
        .ack =                  snd_emu10k1_fx8010_playback_transfer,
 };
 
-static void snd_emu10k1_pcm_efx_free(snd_pcm_t *pcm)
+int __devinit snd_emu10k1_pcm_efx(struct snd_emu10k1 * emu, int device, struct snd_pcm ** rpcm)
 {
-       emu10k1_t *emu = pcm->private_data;
-       emu->pcm_efx = NULL;
-       snd_pcm_lib_preallocate_free_for_all(pcm);
-}
-
-int __devinit snd_emu10k1_pcm_efx(emu10k1_t * emu, int device, snd_pcm_t ** rpcm)
-{
-       snd_pcm_t *pcm;
+       struct snd_pcm *pcm;
+       struct snd_kcontrol *kctl;
        int err;
 
        if (rpcm)
@@ -1378,20 +1687,33 @@ int __devinit snd_emu10k1_pcm_efx(emu10k1_t * emu, int device, snd_pcm_t ** rpcm
                return err;
 
        pcm->private_data = emu;
-       pcm->private_free = snd_emu10k1_pcm_efx_free;
 
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &snd_emu10k1_fx8010_playback_ops);
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &snd_emu10k1_capture_efx_ops);
 
        pcm->info_flags = 0;
-       strcpy(pcm->name, "EMU10K1 EFX");
+       strcpy(pcm->name, "Multichannel Capture/PT Playback");
        emu->pcm_efx = pcm;
        if (rpcm)
                *rpcm = pcm;
 
-       emu->efx_voices_mask[0] = FXWC_DEFAULTROUTE_C | FXWC_DEFAULTROUTE_A;
-       emu->efx_voices_mask[1] = 0;
-       snd_ctl_add(emu->card, snd_ctl_new1(&snd_emu10k1_pcm_efx_voices_mask, emu));
+       /* EFX capture - record the "FXBUS2" channels, by default we connect the EXTINs 
+        * to these
+        */     
+       
+       /* emu->efx_voices_mask[0] = FXWC_DEFAULTROUTE_C | FXWC_DEFAULTROUTE_A; */
+       if (emu->audigy) {
+               emu->efx_voices_mask[0] = 0;
+               emu->efx_voices_mask[1] = 0xffff;
+       } else {
+               emu->efx_voices_mask[0] = 0xffff0000;
+               emu->efx_voices_mask[1] = 0;
+       }
+       kctl = snd_ctl_new1(&snd_emu10k1_pcm_efx_voices_mask, emu);
+       if (!kctl)
+               return -ENOMEM;
+       kctl->id.device = device;
+       snd_ctl_add(emu->card, kctl);
 
        snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV, snd_dma_pci_data(emu->pci), 64*1024, 64*1024);