Fedora kernel-2.6.17-1.2142_FC4 patched with stable patch-2.6.17.4-vs2.0.2-rc26.diff
[linux-2.6.git] / sound / pci / es1968.c
index f658de4..5ff4175 100644 (file)
 #include <linux/interrupt.h>
 #include <linux/init.h>
 #include <linux/pci.h>
+#include <linux/dma-mapping.h>
 #include <linux/slab.h>
 #include <linux/gameport.h>
 #include <linux/moduleparam.h>
+#include <linux/mutex.h>
+
 #include <sound/core.h>
 #include <sound/pcm.h>
 #include <sound/mpu401.h>
 #include <sound/ac97_codec.h>
 #include <sound/initval.h>
 
-#define chip_t es1968_t
-
 #define CARD_NAME "ESS Maestro1/2"
 #define DRIVER_NAME "ES1968"
 
 MODULE_DESCRIPTION("ESS Maestro");
-MODULE_CLASSES("{sound}");
 MODULE_LICENSE("GPL");
-MODULE_DEVICES("{{ESS,Maestro 2e},"
+MODULE_SUPPORTED_DEVICE("{{ESS,Maestro 2e},"
                "{ESS,Maestro 2},"
                "{ESS,Maestro 1},"
                "{TerraTec,DMX}}");
@@ -138,61 +138,31 @@ static int enable_mpu[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = 2};
 #ifdef SUPPORT_JOYSTICK
 static int joystick[SNDRV_CARDS];
 #endif
-static int boot_devs;
 
-module_param_array(index, int, boot_devs, 0444);
+module_param_array(index, int, NULL, 0444);
 MODULE_PARM_DESC(index, "Index value for " CARD_NAME " soundcard.");
-MODULE_PARM_SYNTAX(index, SNDRV_INDEX_DESC);
-module_param_array(id, charp, boot_devs, 0444);
+module_param_array(id, charp, NULL, 0444);
 MODULE_PARM_DESC(id, "ID string for " CARD_NAME " soundcard.");
-MODULE_PARM_SYNTAX(id, SNDRV_ID_DESC);
-module_param_array(enable, bool, boot_devs, 0444);
+module_param_array(enable, bool, NULL, 0444);
 MODULE_PARM_DESC(enable, "Enable " CARD_NAME " soundcard.");
-MODULE_PARM_SYNTAX(enable, SNDRV_ENABLE_DESC);
-module_param_array(total_bufsize, int, boot_devs, 0444);
+module_param_array(total_bufsize, int, NULL, 0444);
 MODULE_PARM_DESC(total_bufsize, "Total buffer size in kB.");
-MODULE_PARM_SYNTAX(total_bufsize, SNDRV_ENABLED ",allows:{{1,4096}},skill:advanced");
-module_param_array(pcm_substreams_p, int, boot_devs, 0444);
+module_param_array(pcm_substreams_p, int, NULL, 0444);
 MODULE_PARM_DESC(pcm_substreams_p, "PCM Playback substreams for " CARD_NAME " soundcard.");
-MODULE_PARM_SYNTAX(pcm_substreams_p, SNDRV_ENABLED ",allows:{{1,8}}");
-module_param_array(pcm_substreams_c, int, boot_devs, 0444);
+module_param_array(pcm_substreams_c, int, NULL, 0444);
 MODULE_PARM_DESC(pcm_substreams_c, "PCM Capture substreams for " CARD_NAME " soundcard.");
-MODULE_PARM_SYNTAX(pcm_substreams_c, SNDRV_ENABLED ",allows:{{0,8}}");
-module_param_array(clock, int, boot_devs, 0444);
+module_param_array(clock, int, NULL, 0444);
 MODULE_PARM_DESC(clock, "Clock on " CARD_NAME " soundcard.  (0 = auto-detect)");
-MODULE_PARM_SYNTAX(clock, SNDRV_ENABLED);
-module_param_array(use_pm, int, boot_devs, 0444);
+module_param_array(use_pm, int, NULL, 0444);
 MODULE_PARM_DESC(use_pm, "Toggle power-management.  (0 = off, 1 = on, 2 = auto)");
-MODULE_PARM_SYNTAX(use_pm, SNDRV_ENABLED ",allows:{{0,1,2}},default:2,skill:advanced");
-module_param_array(enable_mpu, int, boot_devs, 0444);
+module_param_array(enable_mpu, int, NULL, 0444);
 MODULE_PARM_DESC(enable_mpu, "Enable MPU401.  (0 = off, 1 = on, 2 = auto)");
-MODULE_PARM_SYNTAX(enable_mpu, SNDRV_ENABLED ",allows:{{0,2}},default:2");
 #ifdef SUPPORT_JOYSTICK
-module_param_array(joystick, bool, boot_devs, 0444);
+module_param_array(joystick, bool, NULL, 0444);
 MODULE_PARM_DESC(joystick, "Enable joystick.");
-MODULE_PARM_SYNTAX(joystick, SNDRV_ENABLED "," SNDRV_BOOLEAN_FALSE_DESC);
 #endif
 
 
-/* PCI Dev ID's */
-
-#ifndef PCI_VENDOR_ID_ESS
-#define PCI_VENDOR_ID_ESS      0x125D
-#endif
-
-#define PCI_VENDOR_ID_ESS_OLD  0x1285  /* Platform Tech, the people the ESS
-                                          was bought form */
-
-#ifndef PCI_DEVICE_ID_ESS_M2E
-#define PCI_DEVICE_ID_ESS_M2E  0x1978
-#endif
-#ifndef PCI_DEVICE_ID_ESS_M2
-#define PCI_DEVICE_ID_ESS_M2   0x1968
-#endif
-#ifndef PCI_DEVICE_ID_ESS_M1
-#define PCI_DEVICE_ID_ESS_M1   0x0100
-#endif
-
 #define NR_APUS                        64
 #define NR_APU_REGS            16
 
@@ -209,7 +179,7 @@ MODULE_PARM_SYNTAX(joystick, SNDRV_ENABLED "," SNDRV_BOOLEAN_FALSE_DESC);
 
 /* Values for the ESM_LEGACY_AUDIO_CONTROL */
 
-#define ESS_ENABLE_AUDIO       0x8000
+#define ESS_DISABLE_AUDIO      0x8000
 #define ESS_ENABLE_SERIAL_IRQ  0x4000
 #define IO_ADRESS_ALIAS                0x0020
 #define MPU401_IRQ_ENABLE      0x0010
@@ -228,7 +198,7 @@ MODULE_PARM_SYNTAX(joystick, SNDRV_ENABLED "," SNDRV_BOOLEAN_FALSE_DESC);
 #define DMA_TDMA               0x0100
 #define DMA_PCPCI              0x0200
 #define POST_WRITE             0x0080
-#define ISA_TIMING             0x0040
+#define PCI_TIMING             0x0040
 #define SWAP_LR                        0x0020
 #define SUBTR_DECODE           0x0002
 
@@ -503,10 +473,6 @@ static u16 acpi_state_mask[] = {
 };
 
 
-typedef struct snd_es1968 es1968_t;
-typedef struct snd_esschan esschan_t;
-typedef struct snd_esm_memory esm_memory_t;
-
 /* APU use in the driver */
 enum snd_enum_apu_type {
        ESM_APU_PCM_PLAY,
@@ -521,25 +487,23 @@ enum {
 };
 
 /* DMA Hack! */
-struct snd_esm_memory {
-       char *buf;
-       unsigned long addr;
-       int size;
+struct esm_memory {
+       struct snd_dma_buffer buf;
        int empty;      /* status */
        struct list_head list;
 };
 
 /* Playback Channel */
-struct snd_esschan {
+struct esschan {
        int running;
 
        u8 apu[4];
        u8 apu_mode[4];
 
        /* playback/capture pcm buffer */
-       esm_memory_t *memory;
+       struct esm_memory *memory;
        /* capture mixer buffer */
-       esm_memory_t *mixbuf;
+       struct esm_memory *mixbuf;
 
        unsigned int hwptr;     /* current hw pointer in bytes */
        unsigned int count;     /* sample counter in bytes */
@@ -554,7 +518,7 @@ struct snd_esschan {
 
        int bob_freq;   /* required timer frequency */
 
-       snd_pcm_substream_t *substream;
+       struct snd_pcm_substream *substream;
 
        /* linked list */
        struct list_head list;
@@ -564,46 +528,51 @@ struct snd_esschan {
 #endif
 };
 
-struct snd_es1968 {
+struct es1968 {
        /* Module Config */
        int total_bufsize;                      /* in bytes */
 
        int playback_streams, capture_streams;
 
        unsigned int clock;             /* clock */
+       /* for clock measurement */
+       unsigned int in_measurement: 1;
+       unsigned int measure_apu;
+       unsigned int measure_lastpos;
+       unsigned int measure_count;
 
        /* buffer */
-       struct snd_dma_device dma_dev;
        struct snd_dma_buffer dma;
 
        /* Resources... */
        int irq;
        unsigned long io_port;
-       struct resource *res_io_port;
        int type;
        struct pci_dev *pci;
-       snd_card_t *card;
-       snd_pcm_t *pcm;
+       struct snd_card *card;
+       struct snd_pcm *pcm;
        int do_pm;              /* power-management enabled */
 
        /* DMA memory block */
        struct list_head buf_list;
 
        /* ALSA Stuff */
-       ac97_t *ac97;
-       snd_kcontrol_t *master_switch; /* for h/w volume control */
-       snd_kcontrol_t *master_volume;
+       struct snd_ac97 *ac97;
+       struct snd_kcontrol *master_switch; /* for h/w volume control */
+       struct snd_kcontrol *master_volume;
 
-       snd_rawmidi_t *rmidi;
+       struct snd_rawmidi *rmidi;
 
        spinlock_t reg_lock;
+       spinlock_t ac97_lock;
        struct tasklet_struct hwvol_tq;
+       unsigned int in_suspend;
 
        /* Maestro Stuff */
        u16 maestro_map[32];
        int bobclient;          /* active timer instancs */
        int bob_freq;           /* timer frequency */
-       struct semaphore memory_mutex;  /* memory lock */
+       struct mutex memory_mutex;      /* memory lock */
 
        /* APU states */
        unsigned char apu[NR_APUS];
@@ -617,14 +586,13 @@ struct snd_es1968 {
 #endif
 
 #ifdef SUPPORT_JOYSTICK
-       struct gameport gameport;
-       struct resource *res_joystick;
+       struct gameport *gameport;
 #endif
 };
 
 static irqreturn_t snd_es1968_interrupt(int irq, void *dev_id, struct pt_regs *regs);
 
-static struct pci_device_id snd_es1968_ids[] = {
+static struct pci_device_id snd_es1968_ids[] __devinitdata = {
        /* Maestro 1 */
         { 0x1285, 0x0100, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_MULTIMEDIA_AUDIO << 8, 0xffff00, TYPE_MAESTRO },
        /* Maestro 2 */
@@ -641,14 +609,14 @@ MODULE_DEVICE_TABLE(pci, snd_es1968_ids);
    *********************/
 
 /* no spinlock */
-static void __maestro_write(es1968_t *chip, u16 reg, u16 data)
+static void __maestro_write(struct es1968 *chip, u16 reg, u16 data)
 {
        outw(reg, chip->io_port + ESM_INDEX);
        outw(data, chip->io_port + ESM_DATA);
        chip->maestro_map[reg] = data;
 }
 
-inline static void maestro_write(es1968_t *chip, u16 reg, u16 data)
+static inline void maestro_write(struct es1968 *chip, u16 reg, u16 data)
 {
        unsigned long flags;
        spin_lock_irqsave(&chip->reg_lock, flags);
@@ -657,7 +625,7 @@ inline static void maestro_write(es1968_t *chip, u16 reg, u16 data)
 }
 
 /* no spinlock */
-static u16 __maestro_read(es1968_t *chip, u16 reg)
+static u16 __maestro_read(struct es1968 *chip, u16 reg)
 {
        if (READABLE_MAP & (1 << reg)) {
                outw(reg, chip->io_port + ESM_INDEX);
@@ -666,7 +634,7 @@ static u16 __maestro_read(es1968_t *chip, u16 reg)
        return chip->maestro_map[reg];
 }
 
-inline static u16 maestro_read(es1968_t *chip, u16 reg)
+static inline u16 maestro_read(struct es1968 *chip, u16 reg)
 {
        unsigned long flags;
        u16 result;
@@ -676,66 +644,59 @@ inline static u16 maestro_read(es1968_t *chip, u16 reg)
        return result;
 }
 
-#define big_mdelay(msec) do {\
-       set_current_state(TASK_UNINTERRUPTIBLE);\
-       schedule_timeout(((msec) * HZ + 999) / 1000);\
-} while (0)
-       
 /* Wait for the codec bus to be free */
-static int snd_es1968_ac97_wait(es1968_t *chip)
+static int snd_es1968_ac97_wait(struct es1968 *chip)
 {
        int timeout = 100000;
 
        while (timeout-- > 0) {
                if (!(inb(chip->io_port + ESM_AC97_INDEX) & 1))
                        return 0;
+               cond_resched();
        }
        snd_printd("es1968: ac97 timeout\n");
        return 1; /* timeout */
 }
 
-static void snd_es1968_ac97_write(ac97_t *ac97, unsigned short reg, unsigned short val)
+static void snd_es1968_ac97_write(struct snd_ac97 *ac97, unsigned short reg, unsigned short val)
 {
-       es1968_t *chip = snd_magic_cast(es1968_t, ac97->private_data, return);
+       struct es1968 *chip = ac97->private_data;
        unsigned long flags;
 
-       spin_lock_irqsave(&chip->reg_lock, flags);
-
        snd_es1968_ac97_wait(chip);
 
        /* Write the bus */
+       spin_lock_irqsave(&chip->ac97_lock, flags);
        outw(val, chip->io_port + ESM_AC97_DATA);
-       mdelay(1);
+       /*msleep(1);*/
        outb(reg, chip->io_port + ESM_AC97_INDEX);
-       mdelay(1);
-
-       spin_unlock_irqrestore(&chip->reg_lock, flags);
+       /*msleep(1);*/
+       spin_unlock_irqrestore(&chip->ac97_lock, flags);
 }
 
-static unsigned short snd_es1968_ac97_read(ac97_t *ac97, unsigned short reg)
+static unsigned short snd_es1968_ac97_read(struct snd_ac97 *ac97, unsigned short reg)
 {
        u16 data = 0;
-       es1968_t *chip = snd_magic_cast(es1968_t, ac97->private_data, return 0);
+       struct es1968 *chip = ac97->private_data;
        unsigned long flags;
 
-       spin_lock_irqsave(&chip->reg_lock, flags);
-
        snd_es1968_ac97_wait(chip);
 
+       spin_lock_irqsave(&chip->ac97_lock, flags);
        outb(reg | 0x80, chip->io_port + ESM_AC97_INDEX);
-       mdelay(1);
+       /*msleep(1);*/
 
        if (! snd_es1968_ac97_wait(chip)) {
                data = inw(chip->io_port + ESM_AC97_DATA);
-               mdelay(1);
+               /*msleep(1);*/
        }
-       spin_unlock_irqrestore(&chip->reg_lock, flags);
+       spin_unlock_irqrestore(&chip->ac97_lock, flags);
 
        return data;
 }
 
 /* no spinlock */
-static void apu_index_set(es1968_t *chip, u16 index)
+static void apu_index_set(struct es1968 *chip, u16 index)
 {
        int i;
        __maestro_write(chip, IDR1_CRAM_POINTER, index);
@@ -746,7 +707,7 @@ static void apu_index_set(es1968_t *chip, u16 index)
 }
 
 /* no spinlock */
-static void apu_data_set(es1968_t *chip, u16 data)
+static void apu_data_set(struct es1968 *chip, u16 data)
 {
        int i;
        for (i = 0; i < 1000; i++) {
@@ -758,7 +719,7 @@ static void apu_data_set(es1968_t *chip, u16 data)
 }
 
 /* no spinlock */
-static void __apu_set_register(es1968_t *chip, u16 channel, u8 reg, u16 data)
+static void __apu_set_register(struct es1968 *chip, u16 channel, u8 reg, u16 data)
 {
        snd_assert(channel < NR_APUS, return);
 #ifdef CONFIG_PM
@@ -769,7 +730,7 @@ static void __apu_set_register(es1968_t *chip, u16 channel, u8 reg, u16 data)
        apu_data_set(chip, data);
 }
 
-inline static void apu_set_register(es1968_t *chip, u16 channel, u8 reg, u16 data)
+static void apu_set_register(struct es1968 *chip, u16 channel, u8 reg, u16 data)
 {
        unsigned long flags;
        spin_lock_irqsave(&chip->reg_lock, flags);
@@ -777,7 +738,7 @@ inline static void apu_set_register(es1968_t *chip, u16 channel, u8 reg, u16 dat
        spin_unlock_irqrestore(&chip->reg_lock, flags);
 }
 
-static u16 __apu_get_register(es1968_t *chip, u16 channel, u8 reg)
+static u16 __apu_get_register(struct es1968 *chip, u16 channel, u8 reg)
 {
        snd_assert(channel < NR_APUS, return 0);
        reg |= (channel << 4);
@@ -785,7 +746,7 @@ static u16 __apu_get_register(es1968_t *chip, u16 channel, u8 reg)
        return __maestro_read(chip, IDR0_DATA_PORT);
 }
 
-inline static u16 apu_get_register(es1968_t *chip, u16 channel, u8 reg)
+static u16 apu_get_register(struct es1968 *chip, u16 channel, u8 reg)
 {
        unsigned long flags;
        u16 v;
@@ -797,7 +758,7 @@ inline static u16 apu_get_register(es1968_t *chip, u16 channel, u8 reg)
 
 #if 0 /* ASSP is not supported */
 
-static void assp_set_register(es1968_t *chip, u32 reg, u32 value)
+static void assp_set_register(struct es1968 *chip, u32 reg, u32 value)
 {
        unsigned long flags;
 
@@ -807,7 +768,7 @@ static void assp_set_register(es1968_t *chip, u32 reg, u32 value)
        spin_unlock_irqrestore(&chip->reg_lock, flags);
 }
 
-static u32 assp_get_register(es1968_t *chip, u32 reg)
+static u32 assp_get_register(struct es1968 *chip, u32 reg)
 {
        unsigned long flags;
        u32 value;
@@ -822,7 +783,7 @@ static u32 assp_get_register(es1968_t *chip, u32 reg)
 
 #endif
 
-static void wave_set_register(es1968_t *chip, u16 reg, u16 value)
+static void wave_set_register(struct es1968 *chip, u16 reg, u16 value)
 {
        unsigned long flags;
 
@@ -832,7 +793,7 @@ static void wave_set_register(es1968_t *chip, u16 reg, u16 value)
        spin_unlock_irqrestore(&chip->reg_lock, flags);
 }
 
-static u16 wave_get_register(es1968_t *chip, u16 reg)
+static u16 wave_get_register(struct es1968 *chip, u16 reg)
 {
        unsigned long flags;
        u16 value;
@@ -849,26 +810,22 @@ static u16 wave_get_register(es1968_t *chip, u16 reg)
    * Bob the Timer!  *
    *******************/
 
-static void snd_es1968_bob_stop(es1968_t *chip)
+static void snd_es1968_bob_stop(struct es1968 *chip)
 {
        u16 reg;
-       unsigned long flags;
 
-       spin_lock_irqsave(&chip->reg_lock, flags);
        reg = __maestro_read(chip, 0x11);
        reg &= ~ESM_BOB_ENABLE;
        __maestro_write(chip, 0x11, reg);
        reg = __maestro_read(chip, 0x17);
        reg &= ~ESM_BOB_START;
        __maestro_write(chip, 0x17, reg);
-       spin_unlock_irqrestore(&chip->reg_lock, flags);
 }
 
-static void snd_es1968_bob_start(es1968_t *chip)
+static void snd_es1968_bob_start(struct es1968 *chip)
 {
        int prescale;
        int divide;
-       unsigned long flags;
 
        /* compute ideal interrupt frequency for buffer size & play rate */
        /* first, find best prescaler value to match freq */
@@ -897,17 +854,15 @@ static void snd_es1968_bob_start(es1968_t *chip)
        } else if (divide > 1)
                divide--;
 
-       spin_lock_irqsave(&chip->reg_lock, flags);
        __maestro_write(chip, 6, 0x9000 | (prescale << 5) | divide);    /* set reg */
 
        /* Now set IDR 11/17 */
        __maestro_write(chip, 0x11, __maestro_read(chip, 0x11) | 1);
        __maestro_write(chip, 0x17, __maestro_read(chip, 0x17) | 1);
-       spin_unlock_irqrestore(&chip->reg_lock, flags);
 }
 
 /* call with substream spinlock */
-static void snd_es1968_bob_inc(es1968_t *chip, int freq)
+static void snd_es1968_bob_inc(struct es1968 *chip, int freq)
 {
        chip->bobclient++;
        if (chip->bobclient == 1) {
@@ -921,7 +876,7 @@ static void snd_es1968_bob_inc(es1968_t *chip, int freq)
 }
 
 /* call with substream spinlock */
-static void snd_es1968_bob_dec(es1968_t *chip)
+static void snd_es1968_bob_dec(struct es1968 *chip)
 {
        chip->bobclient--;
        if (chip->bobclient <= 0)
@@ -931,7 +886,7 @@ static void snd_es1968_bob_dec(es1968_t *chip)
                struct list_head *p;
                int max_freq = ESM_BOB_FREQ;
                list_for_each(p, &chip->substream_list) {
-                       esschan_t *es = list_entry(p, esschan_t, list);
+                       struct esschan *es = list_entry(p, struct esschan, list);
                        if (max_freq < es->bob_freq)
                                max_freq = es->bob_freq;
                }
@@ -944,8 +899,8 @@ static void snd_es1968_bob_dec(es1968_t *chip)
 }
 
 static int
-snd_es1968_calc_bob_rate(es1968_t *chip, esschan_t *es,
-                        snd_pcm_runtime_t *runtime)
+snd_es1968_calc_bob_rate(struct es1968 *chip, struct esschan *es,
+                        struct snd_pcm_runtime *runtime)
 {
        /* we acquire 4 interrupts per period for precise control.. */
        int freq = runtime->rate * 4;
@@ -966,7 +921,7 @@ snd_es1968_calc_bob_rate(es1968_t *chip, esschan_t *es,
  *  PCM Part *
  *************/
 
-static u32 snd_es1968_compute_rate(es1968_t *chip, u32 freq)
+static u32 snd_es1968_compute_rate(struct es1968 *chip, u32 freq)
 {
        u32 rate = (freq << 16) / chip->clock;
 #if 0 /* XXX: do we need this? */ 
@@ -977,8 +932,8 @@ static u32 snd_es1968_compute_rate(es1968_t *chip, u32 freq)
 }
 
 /* get current pointer */
-inline static unsigned int
-snd_es1968_get_dma_ptr(es1968_t *chip, esschan_t *es)
+static inline unsigned int
+snd_es1968_get_dma_ptr(struct es1968 *chip, struct esschan *es)
 {
        unsigned int offset;
 
@@ -989,7 +944,7 @@ snd_es1968_get_dma_ptr(es1968_t *chip, esschan_t *es)
        return (offset & 0xFFFE);       /* hardware is in words */
 }
 
-static void snd_es1968_apu_set_freq(es1968_t *chip, int apu, int freq)
+static void snd_es1968_apu_set_freq(struct es1968 *chip, int apu, int freq)
 {
        apu_set_register(chip, apu, 2,
                           (apu_get_register(chip, apu, 2) & 0x00FF) |
@@ -998,7 +953,7 @@ static void snd_es1968_apu_set_freq(es1968_t *chip, int apu, int freq)
 }
 
 /* spin lock held */
-inline static void snd_es1968_trigger_apu(es1968_t *esm, int apu, int mode)
+static inline void snd_es1968_trigger_apu(struct es1968 *esm, int apu, int mode)
 {
        /* set the APU mode */
        __apu_set_register(esm, apu, 0,
@@ -1006,7 +961,7 @@ inline static void snd_es1968_trigger_apu(es1968_t *esm, int apu, int mode)
                           (mode << 4));
 }
 
-static void snd_es1968_pcm_start(es1968_t *chip, esschan_t *es)
+static void snd_es1968_pcm_start(struct es1968 *chip, struct esschan *es)
 {
        spin_lock(&chip->reg_lock);
        __apu_set_register(chip, es->apu[0], 5, es->base[0]);
@@ -1026,7 +981,7 @@ static void snd_es1968_pcm_start(es1968_t *chip, esschan_t *es)
        spin_unlock(&chip->reg_lock);
 }
 
-static void snd_es1968_pcm_stop(es1968_t *chip, esschan_t *es)
+static void snd_es1968_pcm_stop(struct es1968 *chip, struct esschan *es)
 {
        spin_lock(&chip->reg_lock);
        snd_es1968_trigger_apu(chip, es->apu[0], 0);
@@ -1039,7 +994,7 @@ static void snd_es1968_pcm_stop(es1968_t *chip, esschan_t *es)
 }
 
 /* set the wavecache control reg */
-static void snd_es1968_program_wavecache(es1968_t *chip, esschan_t *es,
+static void snd_es1968_program_wavecache(struct es1968 *chip, struct esschan *es,
                                         int channel, u32 addr, int capture)
 {
        u32 tmpval = (addr - 0x10) & 0xFFF8;
@@ -1060,8 +1015,8 @@ static void snd_es1968_program_wavecache(es1968_t *chip, esschan_t *es,
 }
 
 
-static void snd_es1968_playback_setup(es1968_t *chip, esschan_t *es,
-                                     snd_pcm_runtime_t *runtime)
+static void snd_es1968_playback_setup(struct es1968 *chip, struct esschan *es,
+                                     struct snd_pcm_runtime *runtime)
 {
        u32 pa;
        int high_apu = 0;
@@ -1078,10 +1033,10 @@ static void snd_es1968_playback_setup(es1968_t *chip, esschan_t *es,
        for (channel = 0; channel <= high_apu; channel++) {
                apu = es->apu[channel];
 
-               snd_es1968_program_wavecache(chip, es, channel, es->memory->addr, 0);
+               snd_es1968_program_wavecache(chip, es, channel, es->memory->buf.addr, 0);
 
                /* Offset to PCMBAR */
-               pa = es->memory->addr;
+               pa = es->memory->buf.addr;
                pa -= chip->dma.addr;
                pa >>= 1;       /* words */
 
@@ -1163,7 +1118,7 @@ static void snd_es1968_playback_setup(es1968_t *chip, esschan_t *es,
 }
 
 
-static void init_capture_apu(es1968_t *chip, esschan_t *es, int channel,
+static void init_capture_apu(struct es1968 *chip, struct esschan *es, int channel,
                             unsigned int pa, unsigned int bsize,
                             int mode, int route)
 {
@@ -1208,8 +1163,8 @@ static void init_capture_apu(es1968_t *chip, esschan_t *es, int channel,
        apu_set_register(chip, apu, 0, 0x400F);
 }
 
-static void snd_es1968_capture_setup(es1968_t *chip, esschan_t *es,
-                                    snd_pcm_runtime_t *runtime)
+static void snd_es1968_capture_setup(struct es1968 *chip, struct esschan *es,
+                                    struct snd_pcm_runtime *runtime)
 {
        int size;
        u32 freq;
@@ -1230,20 +1185,20 @@ static void snd_es1968_capture_setup(es1968_t *chip, esschan_t *es,
        /* input mixer (left/mono) */
        /* parallel in crap, see maestro reg 0xC [8-11] */
        init_capture_apu(chip, es, 2,
-                        es->mixbuf->addr, ESM_MIXBUF_SIZE/4, /* in words */
+                        es->mixbuf->buf.addr, ESM_MIXBUF_SIZE/4, /* in words */
                         ESM_APU_INPUTMIXER, 0x14);
        /* SRC (left/mono); get input from inputing apu */
-       init_capture_apu(chip, es, 0, es->memory->addr, size,
+       init_capture_apu(chip, es, 0, es->memory->buf.addr, size,
                         ESM_APU_SRCONVERTOR, es->apu[2]);
        if (es->fmt & ESS_FMT_STEREO) {
                /* input mixer (right) */
                init_capture_apu(chip, es, 3,
-                                es->mixbuf->addr + ESM_MIXBUF_SIZE/2,
+                                es->mixbuf->buf.addr + ESM_MIXBUF_SIZE/2,
                                 ESM_MIXBUF_SIZE/4, /* in words */
                                 ESM_APU_INPUTMIXER, 0x15);
                /* SRC (right) */
                init_capture_apu(chip, es, 1,
-                                es->memory->addr + size*2, size,
+                                es->memory->buf.addr + size*2, size,
                                 ESM_APU_SRCONVERTOR, es->apu[3]);
        }
 
@@ -1277,11 +1232,11 @@ static void snd_es1968_capture_setup(es1968_t *chip, esschan_t *es,
  *  ALSA Interface *
  *******************/
 
-static int snd_es1968_pcm_prepare(snd_pcm_substream_t *substream)
+static int snd_es1968_pcm_prepare(struct snd_pcm_substream *substream)
 {
-       es1968_t *chip = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       esschan_t *es = snd_magic_cast(esschan_t, runtime->private_data, return -ENXIO);
+       struct es1968 *chip = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct esschan *es = runtime->private_data;
 
        es->dma_size = snd_pcm_lib_buffer_bytes(substream);
        es->frag_size = snd_pcm_lib_period_bytes(substream);
@@ -1309,13 +1264,12 @@ static int snd_es1968_pcm_prepare(snd_pcm_substream_t *substream)
        return 0;
 }
 
-static int snd_es1968_pcm_trigger(snd_pcm_substream_t *substream, int cmd)
+static int snd_es1968_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
 {
-       es1968_t *chip = snd_pcm_substream_chip(substream);
-       esschan_t *es = snd_magic_cast(esschan_t, substream->runtime->private_data, return -ENXIO);
-       unsigned long flags;
+       struct es1968 *chip = snd_pcm_substream_chip(substream);
+       struct esschan *es = substream->runtime->private_data;
 
-       spin_lock_irqsave(&chip->substream_lock, flags);
+       spin_lock(&chip->substream_lock);
        switch (cmd) {
        case SNDRV_PCM_TRIGGER_START:
        case SNDRV_PCM_TRIGGER_RESUME:
@@ -1336,14 +1290,14 @@ static int snd_es1968_pcm_trigger(snd_pcm_substream_t *substream, int cmd)
                snd_es1968_bob_dec(chip);
                break;
        }
-       spin_unlock_irqrestore(&chip->substream_lock, flags);
+       spin_unlock(&chip->substream_lock);
        return 0;
 }
 
-static snd_pcm_uframes_t snd_es1968_pcm_pointer(snd_pcm_substream_t *substream)
+static snd_pcm_uframes_t snd_es1968_pcm_pointer(struct snd_pcm_substream *substream)
 {
-       es1968_t *chip = snd_pcm_substream_chip(substream);
-       esschan_t *es = snd_magic_cast(esschan_t, substream->runtime->private_data, return -ENXIO);
+       struct es1968 *chip = snd_pcm_substream_chip(substream);
+       struct esschan *es = substream->runtime->private_data;
        unsigned int ptr;
 
        ptr = snd_es1968_get_dma_ptr(chip, es) << es->wav_shift;
@@ -1351,7 +1305,7 @@ static snd_pcm_uframes_t snd_es1968_pcm_pointer(snd_pcm_substream_t *substream)
        return bytes_to_frames(substream->runtime, ptr % es->dma_size);
 }
 
-static snd_pcm_hardware_t snd_es1968_playback = {
+static struct snd_pcm_hardware snd_es1968_playback = {
        .info =                 (SNDRV_PCM_INFO_MMAP |
                                         SNDRV_PCM_INFO_MMAP_VALID |
                                 SNDRV_PCM_INFO_INTERLEAVED |
@@ -1372,7 +1326,7 @@ static snd_pcm_hardware_t snd_es1968_playback = {
        .fifo_size =            0,
 };
 
-static snd_pcm_hardware_t snd_es1968_capture = {
+static struct snd_pcm_hardware snd_es1968_capture = {
        .info =                 (SNDRV_PCM_INFO_NONINTERLEAVED |
                                 SNDRV_PCM_INFO_MMAP |
                                 SNDRV_PCM_INFO_MMAP_VALID |
@@ -1400,121 +1354,122 @@ static snd_pcm_hardware_t snd_es1968_capture = {
 /* Because the Maestro can only take addresses relative to the PCM base address
    register :( */
 
-static int calc_available_memory_size(es1968_t *chip)
+static int calc_available_memory_size(struct es1968 *chip)
 {
        struct list_head *p;
        int max_size = 0;
        
-       down(&chip->memory_mutex);
+       mutex_lock(&chip->memory_mutex);
        list_for_each(p, &chip->buf_list) {
-               esm_memory_t *buf = list_entry(p, esm_memory_t, list);
-               if (buf->empty && buf->size > max_size)
-                       max_size = buf->size;
+               struct esm_memory *buf = list_entry(p, struct esm_memory, list);
+               if (buf->empty && buf->buf.bytes > max_size)
+                       max_size = buf->buf.bytes;
        }
-       up(&chip->memory_mutex);
+       mutex_unlock(&chip->memory_mutex);
        if (max_size >= 128*1024)
                max_size = 127*1024;
        return max_size;
 }
 
 /* allocate a new memory chunk with the specified size */
-static esm_memory_t *snd_es1968_new_memory(es1968_t *chip, int size)
+static struct esm_memory *snd_es1968_new_memory(struct es1968 *chip, int size)
 {
-       esm_memory_t *buf;
+       struct esm_memory *buf;
        struct list_head *p;
        
        size = ((size + ESM_MEM_ALIGN - 1) / ESM_MEM_ALIGN) * ESM_MEM_ALIGN;
-       down(&chip->memory_mutex);
+       mutex_lock(&chip->memory_mutex);
        list_for_each(p, &chip->buf_list) {
-               buf = list_entry(p, esm_memory_t, list);
-               if (buf->empty && buf->size >= size)
+               buf = list_entry(p, struct esm_memory, list);
+               if (buf->empty && buf->buf.bytes >= size)
                        goto __found;
        }
-       up(&chip->memory_mutex);
+       mutex_unlock(&chip->memory_mutex);
        return NULL;
 
 __found:
-       if (buf->size > size) {
-               esm_memory_t *chunk = kmalloc(sizeof(*chunk), GFP_KERNEL);
+       if (buf->buf.bytes > size) {
+               struct esm_memory *chunk = kmalloc(sizeof(*chunk), GFP_KERNEL);
                if (chunk == NULL) {
-                       up(&chip->memory_mutex);
+                       mutex_unlock(&chip->memory_mutex);
                        return NULL;
                }
-               chunk->size = buf->size - size;
-               chunk->buf = buf->buf + size;
-               chunk->addr = buf->addr + size;
+               chunk->buf = buf->buf;
+               chunk->buf.bytes -= size;
+               chunk->buf.area += size;
+               chunk->buf.addr += size;
                chunk->empty = 1;
-               buf->size = size;
+               buf->buf.bytes = size;
                list_add(&chunk->list, &buf->list);
        }
        buf->empty = 0;
-       up(&chip->memory_mutex);
+       mutex_unlock(&chip->memory_mutex);
        return buf;
 }
 
 /* free a memory chunk */
-static void snd_es1968_free_memory(es1968_t *chip, esm_memory_t *buf)
+static void snd_es1968_free_memory(struct es1968 *chip, struct esm_memory *buf)
 {
-       esm_memory_t *chunk;
+       struct esm_memory *chunk;
 
-       down(&chip->memory_mutex);
+       mutex_lock(&chip->memory_mutex);
        buf->empty = 1;
        if (buf->list.prev != &chip->buf_list) {
-               chunk = list_entry(buf->list.prev, esm_memory_t, list);
+               chunk = list_entry(buf->list.prev, struct esm_memory, list);
                if (chunk->empty) {
-                       chunk->size += buf->size;
+                       chunk->buf.bytes += buf->buf.bytes;
                        list_del(&buf->list);
                        kfree(buf);
                        buf = chunk;
                }
        }
        if (buf->list.next != &chip->buf_list) {
-               chunk = list_entry(buf->list.next, esm_memory_t, list);
+               chunk = list_entry(buf->list.next, struct esm_memory, list);
                if (chunk->empty) {
-                       buf->size += chunk->size;
+                       buf->buf.bytes += chunk->buf.bytes;
                        list_del(&chunk->list);
                        kfree(chunk);
                }
        }
-       up(&chip->memory_mutex);
+       mutex_unlock(&chip->memory_mutex);
 }
 
-static void snd_es1968_free_dmabuf(es1968_t *chip)
+static void snd_es1968_free_dmabuf(struct es1968 *chip)
 {
        struct list_head *p;
 
        if (! chip->dma.area)
                return;
-       snd_dma_free_reserved(&chip->dma_dev);
+       snd_dma_reserve_buf(&chip->dma, snd_dma_pci_buf_id(chip->pci));
        while ((p = chip->buf_list.next) != &chip->buf_list) {
-               esm_memory_t *chunk = list_entry(p, esm_memory_t, list);
+               struct esm_memory *chunk = list_entry(p, struct esm_memory, list);
                list_del(p);
                kfree(chunk);
        }
 }
 
 static int __devinit
-snd_es1968_init_dmabuf(es1968_t *chip)
+snd_es1968_init_dmabuf(struct es1968 *chip)
 {
        int err;
-       esm_memory_t *chunk;
-
-       chip->dma_dev.type = SNDRV_DMA_TYPE_DEV;
-       chip->dma_dev.dev = snd_dma_pci_data(chip->pci);
-       chip->dma_dev.id = 0;
-       if (! snd_dma_get_reserved(&chip->dma_dev, &chip->dma)) {
-               err = snd_dma_alloc_pages_fallback(&chip->dma_dev, chip->total_bufsize, &chip->dma);
+       struct esm_memory *chunk;
+
+       chip->dma.dev.type = SNDRV_DMA_TYPE_DEV;
+       chip->dma.dev.dev = snd_dma_pci_data(chip->pci);
+       if (! snd_dma_get_reserved_buf(&chip->dma, snd_dma_pci_buf_id(chip->pci))) {
+               err = snd_dma_alloc_pages_fallback(SNDRV_DMA_TYPE_DEV,
+                                                  snd_dma_pci_data(chip->pci),
+                                                  chip->total_bufsize, &chip->dma);
                if (err < 0 || ! chip->dma.area) {
-                       snd_printk("es1968: can't allocate dma pages for size %d\n",
+                       snd_printk(KERN_ERR "es1968: can't allocate dma pages for size %d\n",
                                   chip->total_bufsize);
                        return -ENOMEM;
                }
                if ((chip->dma.addr + chip->dma.bytes - 1) & ~((1 << 28) - 1)) {
-                       snd_dma_free_pages(&chip->dma_dev, &chip->dma);
-                       snd_printk("es1968: DMA buffer beyond 256MB.\n");
+                       snd_dma_free_pages(&chip->dma);
+                       snd_printk(KERN_ERR "es1968: DMA buffer beyond 256MB.\n");
                        return -ENOMEM;
                }
-               snd_dma_set_reserved(&chip->dma_dev, &chip->dma);
        }
 
        INIT_LIST_HEAD(&chip->buf_list);
@@ -1525,9 +1480,10 @@ snd_es1968_init_dmabuf(es1968_t *chip)
                return -ENOMEM;
        }
        memset(chip->dma.area, 0, ESM_MEM_ALIGN);
-       chunk->buf = chip->dma.area + ESM_MEM_ALIGN;
-       chunk->addr = chip->dma.addr + ESM_MEM_ALIGN;
-       chunk->size = chip->dma.bytes - ESM_MEM_ALIGN;
+       chunk->buf = chip->dma;
+       chunk->buf.area += ESM_MEM_ALIGN;
+       chunk->buf.addr += ESM_MEM_ALIGN;
+       chunk->buf.bytes -= ESM_MEM_ALIGN;
        chunk->empty = 1;
        list_add(&chunk->list, &chip->buf_list);
 
@@ -1536,16 +1492,16 @@ snd_es1968_init_dmabuf(es1968_t *chip)
 
 /* setup the dma_areas */
 /* buffer is extracted from the pre-allocated memory chunk */
-static int snd_es1968_hw_params(snd_pcm_substream_t *substream,
-                               snd_pcm_hw_params_t *hw_params)
+static int snd_es1968_hw_params(struct snd_pcm_substream *substream,
+                               struct snd_pcm_hw_params *hw_params)
 {
-       es1968_t *chip = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       esschan_t *chan = snd_magic_cast(esschan_t, runtime->private_data, return -ENXIO);
+       struct es1968 *chip = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct esschan *chan = runtime->private_data;
        int size = params_buffer_bytes(hw_params);
 
        if (chan->memory) {
-               if (chan->memory->size >= size) {
+               if (chan->memory->buf.bytes >= size) {
                        runtime->dma_bytes = size;
                        return 0;
                }
@@ -1556,22 +1512,20 @@ static int snd_es1968_hw_params(snd_pcm_substream_t *substream,
                // snd_printd("cannot allocate dma buffer: size = %d\n", size);
                return -ENOMEM;
        }
-       runtime->dma_bytes = size;
-       runtime->dma_area = chan->memory->buf;
-       runtime->dma_addr = chan->memory->addr;
+       snd_pcm_set_runtime_buffer(substream, &chan->memory->buf);
        return 1; /* area was changed */
 }
 
 /* remove dma areas if allocated */
-static int snd_es1968_hw_free(snd_pcm_substream_t * substream)
+static int snd_es1968_hw_free(struct snd_pcm_substream *substream)
 {
-       es1968_t *chip = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       esschan_t *chan;
+       struct es1968 *chip = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct esschan *chan;
        
        if (runtime->private_data == NULL)
                return 0;
-       chan = snd_magic_cast(esschan_t, runtime->private_data, return -ENXIO);
+       chan = runtime->private_data;
        if (chan->memory) {
                snd_es1968_free_memory(chip, chan->memory);
                chan->memory = NULL;
@@ -1583,7 +1537,7 @@ static int snd_es1968_hw_free(snd_pcm_substream_t * substream)
 /*
  * allocate APU pair
  */
-static int snd_es1968_alloc_apu_pair(es1968_t *chip, int type)
+static int snd_es1968_alloc_apu_pair(struct es1968 *chip, int type)
 {
        int apu;
 
@@ -1600,7 +1554,7 @@ static int snd_es1968_alloc_apu_pair(es1968_t *chip, int type)
 /*
  * release APU pair
  */
-static void snd_es1968_free_apu_pair(es1968_t *chip, int apu)
+static void snd_es1968_free_apu_pair(struct es1968 *chip, int apu)
 {
        chip->apu[apu] = chip->apu[apu + 1] = ESM_APU_FREE;
 }
@@ -1610,20 +1564,19 @@ static void snd_es1968_free_apu_pair(es1968_t *chip, int apu)
  * PCM open/close *
  ******************/
 
-static int snd_es1968_playback_open(snd_pcm_substream_t *substream)
+static int snd_es1968_playback_open(struct snd_pcm_substream *substream)
 {
-       es1968_t *chip = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       esschan_t *es;
+       struct es1968 *chip = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct esschan *es;
        int apu1;
-       unsigned long flags;
 
        /* search 2 APUs */
        apu1 = snd_es1968_alloc_apu_pair(chip, ESM_APU_PCM_PLAY);
        if (apu1 < 0)
                return apu1;
 
-       es = snd_magic_kcalloc(esschan_t, 0, GFP_KERNEL);
+       es = kzalloc(sizeof(*es), GFP_KERNEL);
        if (!es) {
                snd_es1968_free_apu_pair(chip, apu1);
                return -ENOMEM;
@@ -1645,20 +1598,19 @@ static int snd_es1968_playback_open(snd_pcm_substream_t *substream)
        snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_BUFFER_BYTES,
                                   1024);
 #endif
-       spin_lock_irqsave(&chip->substream_lock, flags);
+       spin_lock_irq(&chip->substream_lock);
        list_add(&es->list, &chip->substream_list);
-       spin_unlock_irqrestore(&chip->substream_lock, flags);
+       spin_unlock_irq(&chip->substream_lock);
 
        return 0;
 }
 
-static int snd_es1968_capture_open(snd_pcm_substream_t *substream)
+static int snd_es1968_capture_open(struct snd_pcm_substream *substream)
 {
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       es1968_t *chip = snd_pcm_substream_chip(substream);
-       esschan_t *es;
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct es1968 *chip = snd_pcm_substream_chip(substream);
+       struct esschan *es;
        int apu1, apu2;
-       unsigned long flags;
 
        apu1 = snd_es1968_alloc_apu_pair(chip, ESM_APU_PCM_CAPTURE);
        if (apu1 < 0)
@@ -1669,7 +1621,7 @@ static int snd_es1968_capture_open(snd_pcm_substream_t *substream)
                return apu2;
        }
        
-       es = snd_magic_kcalloc(esschan_t, 0, GFP_KERNEL);
+       es = kzalloc(sizeof(*es), GFP_KERNEL);
        if (!es) {
                snd_es1968_free_apu_pair(chip, apu1);
                snd_es1968_free_apu_pair(chip, apu2);
@@ -1692,10 +1644,10 @@ static int snd_es1968_capture_open(snd_pcm_substream_t *substream)
        if ((es->mixbuf = snd_es1968_new_memory(chip, ESM_MIXBUF_SIZE)) == NULL) {
                snd_es1968_free_apu_pair(chip, apu1);
                snd_es1968_free_apu_pair(chip, apu2);
-               snd_magic_kfree(es);
+               kfree(es);
                 return -ENOMEM;
         }
-       memset(es->mixbuf->buf, 0, ESM_MIXBUF_SIZE);
+       memset(es->mixbuf->buf.area, 0, ESM_MIXBUF_SIZE);
 
        runtime->private_data = es;
        runtime->hw = snd_es1968_capture;
@@ -1705,52 +1657,50 @@ static int snd_es1968_capture_open(snd_pcm_substream_t *substream)
        snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_BUFFER_BYTES,
                                   1024);
 #endif
-       spin_lock_irqsave(&chip->substream_lock, flags);
+       spin_lock_irq(&chip->substream_lock);
        list_add(&es->list, &chip->substream_list);
-       spin_unlock_irqrestore(&chip->substream_lock, flags);
+       spin_unlock_irq(&chip->substream_lock);
 
        return 0;
 }
 
-static int snd_es1968_playback_close(snd_pcm_substream_t * substream)
+static int snd_es1968_playback_close(struct snd_pcm_substream *substream)
 {
-       es1968_t *chip = snd_pcm_substream_chip(substream);
-       esschan_t *es;
-       unsigned long flags;
+       struct es1968 *chip = snd_pcm_substream_chip(substream);
+       struct esschan *es;
 
        if (substream->runtime->private_data == NULL)
                return 0;
-       es = snd_magic_cast(esschan_t, substream->runtime->private_data, return -ENXIO);
-       spin_lock_irqsave(&chip->substream_lock, flags);
+       es = substream->runtime->private_data;
+       spin_lock_irq(&chip->substream_lock);
        list_del(&es->list);
-       spin_unlock_irqrestore(&chip->substream_lock, flags);
+       spin_unlock_irq(&chip->substream_lock);
        snd_es1968_free_apu_pair(chip, es->apu[0]);
-       snd_magic_kfree(es);
+       kfree(es);
 
        return 0;
 }
 
-static int snd_es1968_capture_close(snd_pcm_substream_t * substream)
+static int snd_es1968_capture_close(struct snd_pcm_substream *substream)
 {
-       es1968_t *chip = snd_pcm_substream_chip(substream);
-       esschan_t *es;
-       unsigned long flags;
+       struct es1968 *chip = snd_pcm_substream_chip(substream);
+       struct esschan *es;
 
        if (substream->runtime->private_data == NULL)
                return 0;
-       es = snd_magic_cast(esschan_t, substream->runtime->private_data, return -ENXIO);
-       spin_lock_irqsave(&chip->substream_lock, flags);
+       es = substream->runtime->private_data;
+       spin_lock_irq(&chip->substream_lock);
        list_del(&es->list);
-       spin_unlock_irqrestore(&chip->substream_lock, flags);
+       spin_unlock_irq(&chip->substream_lock);
        snd_es1968_free_memory(chip, es->mixbuf);
        snd_es1968_free_apu_pair(chip, es->apu[0]);
        snd_es1968_free_apu_pair(chip, es->apu[2]);
-       snd_magic_kfree(es);
+       kfree(es);
 
        return 0;
 }
 
-static snd_pcm_ops_t snd_es1968_playback_ops = {
+static struct snd_pcm_ops snd_es1968_playback_ops = {
        .open =         snd_es1968_playback_open,
        .close =        snd_es1968_playback_close,
        .ioctl =        snd_pcm_lib_ioctl,
@@ -1761,7 +1711,7 @@ static snd_pcm_ops_t snd_es1968_playback_ops = {
        .pointer =      snd_es1968_pcm_pointer,
 };
 
-static snd_pcm_ops_t snd_es1968_capture_ops = {
+static struct snd_pcm_ops snd_es1968_capture_ops = {
        .open =         snd_es1968_capture_open,
        .close =        snd_es1968_capture_close,
        .ioctl =        snd_pcm_lib_ioctl,
@@ -1778,12 +1728,11 @@ static snd_pcm_ops_t snd_es1968_capture_ops = {
  */
 #define CLOCK_MEASURE_BUFSIZE  16768   /* enough large for a single shot */
 
-static void __devinit es1968_measure_clock(es1968_t *chip)
+static void __devinit es1968_measure_clock(struct es1968 *chip)
 {
        int i, apu;
        unsigned int pa, offset, t;
-       esm_memory_t *memory;
-       unsigned long flags;
+       struct esm_memory *memory;
        struct timeval start_time, stop_time;
 
        if (chip->clock == 0)
@@ -1791,20 +1740,20 @@ static void __devinit es1968_measure_clock(es1968_t *chip)
 
        /* search 2 APUs (although one apu is enough) */
        if ((apu = snd_es1968_alloc_apu_pair(chip, ESM_APU_PCM_PLAY)) < 0) {
-               snd_printk("Hmm, cannot find empty APU pair!?\n");
+               snd_printk(KERN_ERR "Hmm, cannot find empty APU pair!?\n");
                return;
        }
        if ((memory = snd_es1968_new_memory(chip, CLOCK_MEASURE_BUFSIZE)) == NULL) {
-               snd_printk("cannot allocate dma buffer - using default clock %d\n", chip->clock);
+               snd_printk(KERN_ERR "cannot allocate dma buffer - using default clock %d\n", chip->clock);
                snd_es1968_free_apu_pair(chip, apu);
                return;
        }
 
-       memset(memory->buf, 0, CLOCK_MEASURE_BUFSIZE);
+       memset(memory->buf.area, 0, CLOCK_MEASURE_BUFSIZE);
 
-       wave_set_register(chip, apu << 3, (memory->addr - 0x10) & 0xfff8);
+       wave_set_register(chip, apu << 3, (memory->buf.addr - 0x10) & 0xfff8);
 
-       pa = (unsigned int)((memory->addr - chip->dma.addr) >> 1);
+       pa = (unsigned int)((memory->buf.addr - chip->dma.addr) >> 1);
        pa |= 0x00400000;       /* System RAM (Bit 22) */
 
        /* initialize apu */
@@ -1820,37 +1769,34 @@ static void __devinit es1968_measure_clock(es1968_t *chip)
        apu_set_register(chip, apu, 9, 0xD000);
        apu_set_register(chip, apu, 10, 0x8F08);
        apu_set_register(chip, apu, 11, 0x0000);
-       spin_lock_irqsave(&chip->reg_lock, flags);
+       spin_lock_irq(&chip->reg_lock);
        outw(1, chip->io_port + 0x04); /* clear WP interrupts */
        outw(inw(chip->io_port + ESM_PORT_HOST_IRQ) | ESM_HIRQ_DSIE, chip->io_port + ESM_PORT_HOST_IRQ); /* enable WP ints */
-       spin_unlock_irqrestore(&chip->reg_lock, flags);
+       spin_unlock_irq(&chip->reg_lock);
 
        snd_es1968_apu_set_freq(chip, apu, ((unsigned int)48000 << 16) / chip->clock); /* 48000 Hz */
 
-       spin_lock_irqsave(&chip->reg_lock, flags);
+       chip->in_measurement = 1;
+       chip->measure_apu = apu;
+       spin_lock_irq(&chip->reg_lock);
+       snd_es1968_bob_inc(chip, ESM_BOB_FREQ);
        __apu_set_register(chip, apu, 5, pa & 0xffff);
        snd_es1968_trigger_apu(chip, apu, ESM_APU_16BITLINEAR);
        do_gettimeofday(&start_time);
-       spin_unlock_irqrestore(&chip->reg_lock, flags);
-#if 0
-       set_current_state(TASK_UNINTERRUPTIBLE);
-       schedule_timeout(HZ / 20); /* 50 msec */
-#else
-       /* FIXME:
-        * schedule() above may be too inaccurate and the pointer can
-        * overlap the boundary..
-        */
-       mdelay(50);
-#endif
-       spin_lock_irqsave(&chip->reg_lock, flags);
+       spin_unlock_irq(&chip->reg_lock);
+       msleep(50);
+       spin_lock_irq(&chip->reg_lock);
        offset = __apu_get_register(chip, apu, 5);
        do_gettimeofday(&stop_time);
        snd_es1968_trigger_apu(chip, apu, 0); /* stop */
-       spin_unlock_irqrestore(&chip->reg_lock, flags);
+       snd_es1968_bob_dec(chip);
+       chip->in_measurement = 0;
+       spin_unlock_irq(&chip->reg_lock);
 
        /* check the current position */
        offset -= (pa & 0xffff);
        offset &= 0xfffe;
+       offset += chip->measure_count * (CLOCK_MEASURE_BUFSIZE/2);
 
        t = stop_time.tv_sec - start_time.tv_sec;
        t *= 1000000;
@@ -1859,7 +1805,7 @@ static void __devinit es1968_measure_clock(es1968_t *chip)
        else
                t += stop_time.tv_usec - start_time.tv_usec;
        if (t == 0) {
-               snd_printk("?? calculation error..\n");
+               snd_printk(KERN_ERR "?? calculation error..\n");
        } else {
                offset *= 1000;
                offset = (offset / t) * 1000 + ((offset % t) * 1000) / t;
@@ -1877,17 +1823,17 @@ static void __devinit es1968_measure_clock(es1968_t *chip)
 /*
  */
 
-static void snd_es1968_pcm_free(snd_pcm_t *pcm)
+static void snd_es1968_pcm_free(struct snd_pcm *pcm)
 {
-       es1968_t *esm = snd_magic_cast(es1968_t, pcm->private_data, return);
+       struct es1968 *esm = pcm->private_data;
        snd_es1968_free_dmabuf(esm);
        esm->pcm = NULL;
 }
 
 static int __devinit
-snd_es1968_pcm(es1968_t *chip, int device)
+snd_es1968_pcm(struct es1968 *chip, int device)
 {
-       snd_pcm_t *pcm;
+       struct snd_pcm *pcm;
        int err;
 
        /* get DMA buffer */
@@ -1923,11 +1869,11 @@ snd_es1968_pcm(es1968_t *chip, int device)
 /*
  * update pointer
  */
-static void snd_es1968_update_pcm(es1968_t *chip, esschan_t *es)
+static void snd_es1968_update_pcm(struct es1968 *chip, struct esschan *es)
 {
        unsigned int hwptr;
        unsigned int diff;
-       snd_pcm_substream_t *subs = es->substream;
+       struct snd_pcm_substream *subs = es->substream;
         
        if (subs == NULL || !es->running)
                return;
@@ -1952,8 +1898,9 @@ static void snd_es1968_update_pcm(es1968_t *chip, esschan_t *es)
  */
 static void es1968_update_hw_volume(unsigned long private_data)
 {
-       es1968_t *chip = snd_magic_cast(es1968_t, (void*)private_data, return);
+       struct es1968 *chip = (struct es1968 *) private_data;
        int x, val;
+       unsigned long flags;
 
        /* Figure out which volume control button was pushed,
           based on differences from the default register
@@ -1965,14 +1912,21 @@ static void es1968_update_hw_volume(unsigned long private_data)
        outb(0x88, chip->io_port + 0x1e);
        outb(0x88, chip->io_port + 0x1f);
 
+       if (chip->in_suspend)
+               return;
+
        if (! chip->master_switch || ! chip->master_volume)
                return;
 
-       /* FIXME: more clean up is needed.. */
+       /* FIXME: we can't call snd_ac97_* functions since here is in tasklet. */
+       spin_lock_irqsave(&chip->ac97_lock, flags);
        val = chip->ac97->regs[AC97_MASTER];
        if (x & 1) {
                /* mute */
-               snd_ac97_write_cache(chip->ac97, AC97_MASTER, val ^ 0x8000);
+               val ^= 0x8000;
+               chip->ac97->regs[AC97_MASTER] = val;
+               outw(val, chip->io_port + ESM_AC97_DATA);
+               outb(AC97_MASTER, chip->io_port + ESM_AC97_INDEX);
                snd_ctl_notify(chip->card, SNDRV_CTL_EVENT_MASK_VALUE,
                               &chip->master_switch->id);
        } else {
@@ -1990,10 +1944,13 @@ static void es1968_update_hw_volume(unsigned long private_data)
                        if ((val & 0xff00) < 0x1f00)
                                val += 0x0100;
                }
-               snd_ac97_write_cache(chip->ac97, AC97_MASTER, val);
+               chip->ac97->regs[AC97_MASTER] = val;
+               outw(val, chip->io_port + ESM_AC97_DATA);
+               outb(AC97_MASTER, chip->io_port + ESM_AC97_INDEX);
                snd_ctl_notify(chip->card, SNDRV_CTL_EVENT_MASK_VALUE,
                               &chip->master_volume->id);
        }
+       spin_unlock_irqrestore(&chip->ac97_lock, flags);
 }
 
 /*
@@ -2001,7 +1958,7 @@ static void es1968_update_hw_volume(unsigned long private_data)
  */
 static irqreturn_t snd_es1968_interrupt(int irq, void *dev_id, struct pt_regs *regs)
 {
-       es1968_t *chip = snd_magic_cast(es1968_t, dev_id, return IRQ_NONE);
+       struct es1968 *chip = dev_id;
        u32 event;
 
        if (!(event = inb(chip->io_port + 0x1A)))
@@ -2023,11 +1980,17 @@ static irqreturn_t snd_es1968_interrupt(int irq, void *dev_id, struct pt_regs *r
                struct list_head *p;
                spin_lock(&chip->substream_lock);
                list_for_each(p, &chip->substream_list) {
-                       esschan_t *es = list_entry(p, esschan_t, list);
+                       struct esschan *es = list_entry(p, struct esschan, list);
                        if (es->running)
                                snd_es1968_update_pcm(chip, es);
                }
                spin_unlock(&chip->substream_lock);
+               if (chip->in_measurement) {
+                       unsigned int curp = __apu_get_register(chip, chip->measure_apu, 5);
+                       if (curp < chip->measure_lastpos)
+                               chip->measure_count++;
+                       chip->measure_lastpos = curp;
+               }
        }
 
        return IRQ_HANDLED;
@@ -2038,18 +2001,20 @@ static irqreturn_t snd_es1968_interrupt(int irq, void *dev_id, struct pt_regs *r
  */
 
 static int __devinit
-snd_es1968_mixer(es1968_t *chip)
+snd_es1968_mixer(struct es1968 *chip)
 {
-       ac97_bus_t bus, *pbus;
-       ac97_t ac97;
-       snd_ctl_elem_id_t id;
+       struct snd_ac97_bus *pbus;
+       struct snd_ac97_template ac97;
+       struct snd_ctl_elem_id id;
        int err;
+       static struct snd_ac97_bus_ops ops = {
+               .write = snd_es1968_ac97_write,
+               .read = snd_es1968_ac97_read,
+       };
 
-       memset(&bus, 0, sizeof(bus));
-       bus.write = snd_es1968_ac97_write;
-       bus.read = snd_es1968_ac97_read;
-       if ((err = snd_ac97_bus(chip->card, &bus, &pbus)) < 0)
+       if ((err = snd_ac97_bus(chip->card, 0, &ops, NULL, &pbus)) < 0)
                return err;
+       pbus->no_vra = 1; /* ES1968 doesn't need VRA */
 
        memset(&ac97, 0, sizeof(ac97));
        ac97.private_data = chip;
@@ -2073,7 +2038,7 @@ snd_es1968_mixer(es1968_t *chip)
  * reset ac97 codec
  */
 
-static void snd_es1968_ac97_reset(es1968_t *chip)
+static void snd_es1968_ac97_reset(struct es1968 *chip)
 {
        unsigned long ioaddr = chip->io_port;
 
@@ -2102,7 +2067,7 @@ static void snd_es1968_ac97_reset(es1968_t *chip)
        outw(0x0000, ioaddr + 0x60);    /* write 0 to gpio 0 */
        udelay(20);
        outw(0x0001, ioaddr + 0x60);    /* write 1 to gpio 1 */
-       big_mdelay(20);
+       msleep(20);
 
        outw(save_68 | 0x1, ioaddr + 0x68);     /* now restore .. */
        outw((inw(ioaddr + 0x38) & 0xfffc) | 0x1, ioaddr + 0x38);
@@ -2118,13 +2083,13 @@ static void snd_es1968_ac97_reset(es1968_t *chip)
        outw(0x0001, ioaddr + 0x60);    /* write 1 to gpio */
        udelay(20);
        outw(0x0009, ioaddr + 0x60);    /* write 9 to gpio */
-       big_mdelay(500);
+       msleep(500);
        //outw(inw(ioaddr + 0x38) & 0xfffc, ioaddr + 0x38);
        outw(inw(ioaddr + 0x3a) & 0xfffc, ioaddr + 0x3a);
        outw(inw(ioaddr + 0x3c) & 0xfffc, ioaddr + 0x3c);
 
 #if 0                          /* the loop here needs to be much better if we want it.. */
-       snd_printk("trying software reset\n");
+       snd_printk(KERN_INFO "trying software reset\n");
        /* try and do a software reset */
        outb(0x80 | 0x7c, ioaddr + 0x30);
        for (w = 0;; w++) {
@@ -2144,7 +2109,7 @@ static void snd_es1968_ac97_reset(es1968_t *chip)
 
                if (w > 10000) {
                        outb(inb(ioaddr + 0x37) | 0x08, ioaddr + 0x37); /* do a software reset */
-                       big_mdelay(500);        /* oh my.. */
+                       msleep(500);    /* oh my.. */
                        outb(inb(ioaddr + 0x37) & ~0x08,
                                ioaddr + 0x37);
                        udelay(1);
@@ -2178,7 +2143,7 @@ static void snd_es1968_ac97_reset(es1968_t *chip)
        outb(0x3f, ioaddr+0xd0);
 }
 
-static void snd_es1968_reset(es1968_t *chip)
+static void snd_es1968_reset(struct es1968 *chip)
 {
        /* Reset */
        outw(ESM_RESET_MAESTRO | ESM_RESET_DIRECTSOUND,
@@ -2191,7 +2156,7 @@ static void snd_es1968_reset(es1968_t *chip)
 /*
  * power management
  */
-static void snd_es1968_set_acpi(es1968_t *chip, int state)
+static void snd_es1968_set_acpi(struct es1968 *chip, int state)
 {
        u16 active_mask = acpi_state_mask[state];
 
@@ -2206,7 +2171,7 @@ static void snd_es1968_set_acpi(es1968_t *chip, int state)
 /*
  * initialize maestro chip
  */
-static void snd_es1968_chip_init(es1968_t *chip)
+static void snd_es1968_chip_init(struct es1968 *chip)
 {
        struct pci_dev *pci = chip->pci;
        int i;
@@ -2231,14 +2196,11 @@ static void snd_es1968_chip_init(es1968_t *chip)
        /* Config Reg A */
        pci_read_config_word(pci, ESM_CONFIG_A, &w);
 
-       /*      Use TDMA for now. TDMA works on all boards, so while its
-        *      not the most efficient its the simplest. */
        w &= ~DMA_CLEAR;        /* Clear DMA bits */
-       w |= DMA_TDMA;          /* TDMA on */
        w &= ~(PIC_SNOOP1 | PIC_SNOOP2);        /* Clear Pic Snoop Mode Bits */
        w &= ~SAFEGUARD;        /* Safeguard off */
        w |= POST_WRITE;        /* Posted write */
-       w |= ISA_TIMING;        /* ISA timing on */
+       w |= PCI_TIMING;        /* PCI timing on */
        /* XXX huh?  claims to be reserved.. */
        w &= ~SWAP_LR;          /* swap left/right 
                                   seems to only have effect on SB
@@ -2279,7 +2241,7 @@ static void snd_es1968_chip_init(es1968_t *chip)
 
        pci_read_config_word(pci, ESM_LEGACY_AUDIO_CONTROL, &w);
 
-       w &= ~ESS_ENABLE_AUDIO; /* Disable Legacy Audio */
+       w |= ESS_DISABLE_AUDIO; /* Disable Legacy Audio */
        w &= ~ESS_ENABLE_SERIAL_IRQ;    /* Disable SIRQ */
        w &= ~(0x1f);           /* disable mpu irq/io, game port, fm, SB */
 
@@ -2403,7 +2365,7 @@ static void snd_es1968_chip_init(es1968_t *chip)
 }
 
 /* Enable IRQ's */
-static void snd_es1968_start_irq(es1968_t *chip)
+static void snd_es1968_start_irq(struct es1968 *chip)
 {
        unsigned short w;
        w = ESM_HIRQ_DSIE | ESM_HIRQ_HW_VOLUME;
@@ -2416,30 +2378,38 @@ static void snd_es1968_start_irq(es1968_t *chip)
 /*
  * PM support
  */
-static int es1968_suspend(snd_card_t *card, unsigned int state)
+static int es1968_suspend(struct pci_dev *pci, pm_message_t state)
 {
-       es1968_t *chip = snd_magic_cast(es1968_t, card->pm_private_data, return -EINVAL);
+       struct snd_card *card = pci_get_drvdata(pci);
+       struct es1968 *chip = card->private_data;
 
        if (! chip->do_pm)
                return 0;
 
+       chip->in_suspend = 1;
+       snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
        snd_pcm_suspend_all(chip->pcm);
        snd_ac97_suspend(chip->ac97);
        snd_es1968_bob_stop(chip);
        snd_es1968_set_acpi(chip, ACPI_D3);
-       snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
+       pci_disable_device(pci);
+       pci_save_state(pci);
        return 0;
 }
 
-static int es1968_resume(snd_card_t *card, unsigned int state)
+static int es1968_resume(struct pci_dev *pci)
 {
-       es1968_t *chip = snd_magic_cast(es1968_t, card->pm_private_data, return -EINVAL);
+       struct snd_card *card = pci_get_drvdata(pci);
+       struct es1968 *chip = card->private_data;
+       struct list_head *p;
 
        if (! chip->do_pm)
                return 0;
 
        /* restore all our config */
-       pci_enable_device(chip->pci);
+       pci_restore_state(pci);
+       pci_enable_device(pci);
+       pci_set_master(pci);
        snd_es1968_chip_init(chip);
 
        /* need to restore the base pointers.. */ 
@@ -2453,46 +2423,103 @@ static int es1968_resume(snd_card_t *card, unsigned int state)
        /* restore ac97 state */
        snd_ac97_resume(chip->ac97);
 
+       list_for_each(p, &chip->substream_list) {
+               struct esschan *es = list_entry(p, struct esschan, list);
+               switch (es->mode) {
+               case ESM_MODE_PLAY:
+                       snd_es1968_playback_setup(chip, es, es->substream->runtime);
+                       break;
+               case ESM_MODE_CAPTURE:
+                       snd_es1968_capture_setup(chip, es, es->substream->runtime);
+                       break;
+               }
+       }
+
        /* start timer again */
        if (chip->bobclient)
                snd_es1968_bob_start(chip);
 
        snd_power_change_state(card, SNDRV_CTL_POWER_D0);
+       chip->in_suspend = 0;
        return 0;
 }
 #endif /* CONFIG_PM */
 
-static int snd_es1968_free(es1968_t *chip)
+#ifdef SUPPORT_JOYSTICK
+#define JOYSTICK_ADDR  0x200
+static int __devinit snd_es1968_create_gameport(struct es1968 *chip, int dev)
+{
+       struct gameport *gp;
+       struct resource *r;
+       u16 val;
+
+       if (!joystick[dev])
+               return -ENODEV;
+
+       r = request_region(JOYSTICK_ADDR, 8, "ES1968 gameport");
+       if (!r)
+               return -EBUSY;
+
+       chip->gameport = gp = gameport_allocate_port();
+       if (!gp) {
+               printk(KERN_ERR "es1968: cannot allocate memory for gameport\n");
+               release_and_free_resource(r);
+               return -ENOMEM;
+       }
+
+       pci_read_config_word(chip->pci, ESM_LEGACY_AUDIO_CONTROL, &val);
+       pci_write_config_word(chip->pci, ESM_LEGACY_AUDIO_CONTROL, val | 0x04);
+
+       gameport_set_name(gp, "ES1968 Gameport");
+       gameport_set_phys(gp, "pci%s/gameport0", pci_name(chip->pci));
+       gameport_set_dev_parent(gp, &chip->pci->dev);
+       gp->io = JOYSTICK_ADDR;
+       gameport_set_port_data(gp, r);
+
+       gameport_register_port(gp);
+
+       return 0;
+}
+
+static void snd_es1968_free_gameport(struct es1968 *chip)
 {
-       if (chip->res_io_port) {
+       if (chip->gameport) {
+               struct resource *r = gameport_get_port_data(chip->gameport);
+
+               gameport_unregister_port(chip->gameport);
+               chip->gameport = NULL;
+
+               release_and_free_resource(r);
+       }
+}
+#else
+static inline int snd_es1968_create_gameport(struct es1968 *chip, int dev) { return -ENOSYS; }
+static inline void snd_es1968_free_gameport(struct es1968 *chip) { }
+#endif
+
+static int snd_es1968_free(struct es1968 *chip)
+{
+       if (chip->io_port) {
                synchronize_irq(chip->irq);
                outw(1, chip->io_port + 0x04); /* clear WP interrupts */
                outw(0, chip->io_port + ESM_PORT_HOST_IRQ); /* disable IRQ */
        }
 
-#ifdef SUPPORT_JOYSTICK
-       if (chip->res_joystick) {
-               gameport_unregister_port(&chip->gameport);
-               release_resource(chip->res_joystick);
-               kfree_nocheck(chip->res_joystick);
-       }
-#endif
+       if (chip->irq >= 0)
+               free_irq(chip->irq, (void *)chip);
+       snd_es1968_free_gameport(chip);
        snd_es1968_set_acpi(chip, ACPI_D3);
        chip->master_switch = NULL;
        chip->master_volume = NULL;
-       if (chip->res_io_port) {
-               release_resource(chip->res_io_port);
-               kfree_nocheck(chip->res_io_port);
-       }
-       if (chip->irq >= 0)
-               free_irq(chip->irq, (void *)chip);
-       snd_magic_kfree(chip);
+       pci_release_regions(chip->pci);
+       pci_disable_device(chip->pci);
+       kfree(chip);
        return 0;
 }
 
-static int snd_es1968_dev_free(snd_device_t *device)
+static int snd_es1968_dev_free(struct snd_device *device)
 {
-       es1968_t *chip = snd_magic_cast(es1968_t, device->device_data, return -ENXIO);
+       struct es1968 *chip = device->device_data;
        return snd_es1968_free(chip);
 }
 
@@ -2507,25 +2534,26 @@ static struct ess_device_list pm_whitelist[] __devinitdata = {
        { TYPE_MAESTRO2E, 0x103c },
        { TYPE_MAESTRO2E, 0x1179 },
        { TYPE_MAESTRO2E, 0x14c0 },     /* HP omnibook 4150 */
+       { TYPE_MAESTRO2E, 0x1558 },
 };
 
 static struct ess_device_list mpu_blacklist[] __devinitdata = {
        { TYPE_MAESTRO2, 0x125d },
 };
 
-static int __devinit snd_es1968_create(snd_card_t * card,
+static int __devinit snd_es1968_create(struct snd_card *card,
                                       struct pci_dev *pci,
                                       int total_bufsize,
                                       int play_streams,
                                       int capt_streams,
                                       int chip_type,
                                       int do_pm,
-                                      es1968_t **chip_ret)
+                                      struct es1968 **chip_ret)
 {
-       static snd_device_ops_t ops = {
+       static struct snd_device_ops ops = {
                .dev_free =     snd_es1968_dev_free,
        };
-       es1968_t *chip;
+       struct es1968 *chip;
        int i, err;
 
        *chip_ret = NULL;
@@ -2534,15 +2562,18 @@ static int __devinit snd_es1968_create(snd_card_t * card,
        if ((err = pci_enable_device(pci)) < 0)
                return err;
        /* check, if we can restrict PCI DMA transfers to 28 bits */
-       if (pci_set_dma_mask(pci, 0x0fffffff) < 0 ||
-           pci_set_consistent_dma_mask(pci, 0x0fffffff) < 0) {
-               snd_printk("architecture does not support 28bit PCI busmaster DMA\n");
+       if (pci_set_dma_mask(pci, DMA_28BIT_MASK) < 0 ||
+           pci_set_consistent_dma_mask(pci, DMA_28BIT_MASK) < 0) {
+               snd_printk(KERN_ERR "architecture does not support 28bit PCI busmaster DMA\n");
+               pci_disable_device(pci);
                return -ENXIO;
        }
 
-       chip = (es1968_t *) snd_magic_kcalloc(es1968_t, 0, GFP_KERNEL);
-       if (! chip)
+       chip = kzalloc(sizeof(*chip), GFP_KERNEL);
+       if (! chip) {
+               pci_disable_device(pci);
                return -ENOMEM;
+       }
 
        /* Set Vars */
        chip->type = chip_type;
@@ -2550,7 +2581,8 @@ static int __devinit snd_es1968_create(snd_card_t * card,
        spin_lock_init(&chip->substream_lock);
        INIT_LIST_HEAD(&chip->buf_list);
        INIT_LIST_HEAD(&chip->substream_list);
-       init_MUTEX(&chip->memory_mutex);
+       spin_lock_init(&chip->ac97_lock);
+       mutex_init(&chip->memory_mutex);
        tasklet_init(&chip->hwvol_tq, es1968_update_hw_volume, (unsigned long)chip);
        chip->card = card;
        chip->pci = pci;
@@ -2559,15 +2591,15 @@ static int __devinit snd_es1968_create(snd_card_t * card,
        chip->playback_streams = play_streams;
        chip->capture_streams = capt_streams;
 
-       chip->io_port = pci_resource_start(pci, 0);
-       if ((chip->res_io_port = request_region(chip->io_port, 0x100, "ESS Maestro")) == NULL) {
-               snd_printk("unable to grab region 0x%lx-0x%lx\n", chip->io_port, chip->io_port + 0x100 - 1);
-               snd_es1968_free(chip);
-               return -EBUSY;
+       if ((err = pci_request_regions(pci, "ESS Maestro")) < 0) {
+               kfree(chip);
+               pci_disable_device(pci);
+               return err;
        }
+       chip->io_port = pci_resource_start(pci, 0);
        if (request_irq(pci->irq, snd_es1968_interrupt, SA_INTERRUPT|SA_SHIRQ,
                        "ESS Maestro", (void*)chip)) {
-               snd_printk("unable to grab IRQ %d\n", pci->irq);
+               snd_printk(KERN_ERR "unable to grab IRQ %d\n", pci->irq);
                snd_es1968_free(chip);
                return -EBUSY;
        }
@@ -2605,9 +2637,6 @@ static int __devinit snd_es1968_create(snd_card_t * card,
 
        snd_es1968_chip_init(chip);
 
-       if (chip->do_pm)
-               snd_card_set_pm_callback(card, es1968_suspend, es1968_resume, chip);
-
        if ((err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops)) < 0) {
                snd_es1968_free(chip);
                return err;
@@ -2627,8 +2656,8 @@ static int __devinit snd_es1968_probe(struct pci_dev *pci,
                                      const struct pci_device_id *pci_id)
 {
        static int dev;
-       snd_card_t *card;
-       es1968_t *chip;
+       struct snd_card *card;
+       struct es1968 *chip;
        unsigned int i;
        int err;
 
@@ -2657,6 +2686,7 @@ static int __devinit snd_es1968_probe(struct pci_dev *pci,
                snd_card_free(card);
                return err;
        }
+       card->private_data = chip;
 
        switch (chip->type) {
        case TYPE_MAESTRO2E:
@@ -2703,17 +2733,7 @@ static int __devinit snd_es1968_probe(struct pci_dev *pci,
                }
        }
 
-#ifdef SUPPORT_JOYSTICK
-#define JOYSTICK_ADDR  0x200
-       if (joystick[dev] &&
-           (chip->res_joystick = request_region(JOYSTICK_ADDR, 8, "ES1968 gameport")) != NULL) {
-               u16 val;
-               pci_read_config_word(pci, ESM_LEGACY_AUDIO_CONTROL, &val);
-               pci_write_config_word(pci, ESM_LEGACY_AUDIO_CONTROL, val | 0x04);
-               chip->gameport.io = JOYSTICK_ADDR;
-               gameport_register_port(&chip->gameport);
-       }
-#endif
+       snd_es1968_create_gameport(chip, dev);
 
        snd_es1968_start_irq(chip);
 
@@ -2744,12 +2764,15 @@ static struct pci_driver driver = {
        .id_table = snd_es1968_ids,
        .probe = snd_es1968_probe,
        .remove = __devexit_p(snd_es1968_remove),
-       SND_PCI_PM_CALLBACKS
+#ifdef CONFIG_PM
+       .suspend = es1968_suspend,
+       .resume = es1968_resume,
+#endif
 };
 
 static int __init alsa_card_es1968_init(void)
 {
-       return pci_module_init(&driver);
+       return pci_register_driver(&driver);
 }
 
 static void __exit alsa_card_es1968_exit(void)