Fedora kernel-2.6.17-1.2142_FC4 patched with stable patch-2.6.17.4-vs2.0.2-rc26.diff
[linux-2.6.git] / sound / pci / ice1712 / ice1724.c
index 60fb189..b1c007e 100644 (file)
@@ -30,6 +30,7 @@
 #include <linux/pci.h>
 #include <linux/slab.h>
 #include <linux/moduleparam.h>
+#include <linux/mutex.h>
 #include <sound/core.h>
 #include <sound/info.h>
 #include <sound/mpu401.h>
 #include "amp.h"
 #include "revo.h"
 #include "aureon.h"
+#include "vt1720_mobo.h"
+#include "pontis.h"
+#include "prodigy192.h"
+#include "juli.h"
+#include "phase.h"
 
 
 MODULE_AUTHOR("Jaroslav Kysela <perex@suse.cz>");
 MODULE_DESCRIPTION("VIA ICEnsemble ICE1724/1720 (Envy24HT/PT)");
 MODULE_LICENSE("GPL");
-MODULE_CLASSES("{sound}");
-MODULE_DEVICES("{"
+MODULE_SUPPORTED_DEVICE("{"
               REVO_DEVICE_DESC
               AMP_AUDIO2000_DEVICE_DESC
               AUREON_DEVICE_DESC
+              VT1720_MOBO_DEVICE_DESC
+              PONTIS_DEVICE_DESC
+              PRODIGY192_DEVICE_DESC
+              JULI_DEVICE_DESC
+              PHASE_DEVICE_DESC
                "{VIA,VT1720},"
                "{VIA,VT1724},"
                "{ICEnsemble,Generic ICE1724},"
@@ -64,29 +74,19 @@ static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX;  /* Index 0-MAX */
 static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR;      /* ID for this card */
 static int enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP;             /* Enable this card */
 static char *model[SNDRV_CARDS];
-static int boot_devs;
 
-module_param_array(index, int, boot_devs, 0444);
+module_param_array(index, int, NULL, 0444);
 MODULE_PARM_DESC(index, "Index value for ICE1724 soundcard.");
-MODULE_PARM_SYNTAX(index, SNDRV_INDEX_DESC);
-module_param_array(id, charp, boot_devs, 0444);
+module_param_array(id, charp, NULL, 0444);
 MODULE_PARM_DESC(id, "ID string for ICE1724 soundcard.");
-MODULE_PARM_SYNTAX(id, SNDRV_ID_DESC);
-module_param_array(enable, bool, boot_devs, 0444);
+module_param_array(enable, bool, NULL, 0444);
 MODULE_PARM_DESC(enable, "Enable ICE1724 soundcard.");
-MODULE_PARM_SYNTAX(enable, SNDRV_ENABLE_DESC);
-module_param_array(model, charp, boot_devs, 0444);
+module_param_array(model, charp, NULL, 0444);
 MODULE_PARM_DESC(model, "Use the given board model.");
 
-#ifndef PCI_VENDOR_ID_ICE
-#define PCI_VENDOR_ID_ICE              0x1412
-#endif
-#ifndef PCI_DEVICE_ID_VT1724
-#define PCI_DEVICE_ID_VT1724           0x1724
-#endif
 
 /* Both VT1720 and VT1724 have the same PCI IDs */
-static struct pci_device_id snd_vt1724_ids[] = {
+static struct pci_device_id snd_vt1724_ids[] __devinitdata = {
        { PCI_VENDOR_ID_ICE, PCI_DEVICE_ID_VT1724, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
        { 0, }
 };
@@ -103,12 +103,12 @@ static unsigned int PRO_RATE_DEFAULT = 44100;
  */
  
 /* check whether the clock mode is spdif-in */
-static inline int is_spdif_master(ice1712_t *ice)
+static inline int is_spdif_master(struct snd_ice1712 *ice)
 {
        return (inb(ICEMT1724(ice, RATE)) & VT1724_SPDIF_MASTER) ? 1 : 0;
 }
 
-static inline int is_pro_rate_locked(ice1712_t *ice)
+static inline int is_pro_rate_locked(struct snd_ice1712 *ice)
 {
        return is_spdif_master(ice) || PRO_RATE_LOCKED;
 }
@@ -117,7 +117,7 @@ static inline int is_pro_rate_locked(ice1712_t *ice)
  * ac97 section
  */
 
-static unsigned char snd_vt1724_ac97_ready(ice1712_t *ice)
+static unsigned char snd_vt1724_ac97_ready(struct snd_ice1712 *ice)
 {
        unsigned char old_cmd;
        int tm;
@@ -133,7 +133,7 @@ static unsigned char snd_vt1724_ac97_ready(ice1712_t *ice)
        return old_cmd;
 }
 
-static int snd_vt1724_ac97_wait_bit(ice1712_t *ice, unsigned char bit)
+static int snd_vt1724_ac97_wait_bit(struct snd_ice1712 *ice, unsigned char bit)
 {
        int tm;
        for (tm = 0; tm < 0x10000; tm++)
@@ -143,11 +143,11 @@ static int snd_vt1724_ac97_wait_bit(ice1712_t *ice, unsigned char bit)
        return -EIO;
 }
 
-static void snd_vt1724_ac97_write(ac97_t *ac97,
+static void snd_vt1724_ac97_write(struct snd_ac97 *ac97,
                                  unsigned short reg,
                                  unsigned short val)
 {
-       ice1712_t *ice = (ice1712_t *)ac97->private_data;
+       struct snd_ice1712 *ice = ac97->private_data;
        unsigned char old_cmd;
 
        old_cmd = snd_vt1724_ac97_ready(ice);
@@ -159,9 +159,9 @@ static void snd_vt1724_ac97_write(ac97_t *ac97,
        snd_vt1724_ac97_wait_bit(ice, VT1724_AC97_WRITE);
 }
 
-static unsigned short snd_vt1724_ac97_read(ac97_t *ac97, unsigned short reg)
+static unsigned short snd_vt1724_ac97_read(struct snd_ac97 *ac97, unsigned short reg)
 {
-       ice1712_t *ice = (ice1712_t *)ac97->private_data;
+       struct snd_ice1712 *ice = ac97->private_data;
        unsigned char old_cmd;
 
        old_cmd = snd_vt1724_ac97_ready(ice);
@@ -180,31 +180,36 @@ static unsigned short snd_vt1724_ac97_read(ac97_t *ac97, unsigned short reg)
  */
 
 /* set gpio direction 0 = read, 1 = write */
-static void snd_vt1724_set_gpio_dir(ice1712_t *ice, unsigned int data)
+static void snd_vt1724_set_gpio_dir(struct snd_ice1712 *ice, unsigned int data)
 {
        outl(data, ICEREG1724(ice, GPIO_DIRECTION));
        inw(ICEREG1724(ice, GPIO_DIRECTION)); /* dummy read for pci-posting */
 }
 
 /* set the gpio mask (0 = writable) */
-static void snd_vt1724_set_gpio_mask(ice1712_t *ice, unsigned int data)
+static void snd_vt1724_set_gpio_mask(struct snd_ice1712 *ice, unsigned int data)
 {
        outw(data, ICEREG1724(ice, GPIO_WRITE_MASK));
-       outb((data >> 16) & 0xff, ICEREG1724(ice, GPIO_WRITE_MASK_22));
+       if (! ice->vt1720) /* VT1720 supports only 16 GPIO bits */
+               outb((data >> 16) & 0xff, ICEREG1724(ice, GPIO_WRITE_MASK_22));
        inw(ICEREG1724(ice, GPIO_WRITE_MASK)); /* dummy read for pci-posting */
 }
 
-static void snd_vt1724_set_gpio_data(ice1712_t *ice, unsigned int data)
+static void snd_vt1724_set_gpio_data(struct snd_ice1712 *ice, unsigned int data)
 {
        outw(data, ICEREG1724(ice, GPIO_DATA));
-       outb(data >> 16, ICEREG1724(ice, GPIO_DATA_22));
+       if (! ice->vt1720)
+               outb(data >> 16, ICEREG1724(ice, GPIO_DATA_22));
        inw(ICEREG1724(ice, GPIO_DATA)); /* dummy read for pci-posting */
 }
 
-static unsigned int snd_vt1724_get_gpio_data(ice1712_t *ice)
+static unsigned int snd_vt1724_get_gpio_data(struct snd_ice1712 *ice)
 {
        unsigned int data;
-       data = (unsigned int)inb(ICEREG1724(ice, GPIO_DATA_22));
+       if (! ice->vt1720)
+               data = (unsigned int)inb(ICEREG1724(ice, GPIO_DATA_22));
+       else
+               data = 0;
        data = (data << 16) | inw(ICEREG1724(ice, GPIO_DATA));
        return data;
 }
@@ -215,7 +220,7 @@ static unsigned int snd_vt1724_get_gpio_data(ice1712_t *ice)
 
 static irqreturn_t snd_vt1724_interrupt(int irq, void *dev_id, struct pt_regs *regs)
 {
-       ice1712_t *ice = snd_magic_cast(ice1712_t, dev_id, return IRQ_NONE);
+       struct snd_ice1712 *ice = dev_id;
        unsigned char status;
        int handled = 0;
 
@@ -225,12 +230,14 @@ static irqreturn_t snd_vt1724_interrupt(int irq, void *dev_id, struct pt_regs *r
                        break;
 
                handled = 1;            
-               /*  these should probably be separated at some point, 
-                       but as we don't currently have MPU support on the board I will leave it */
+               /* these should probably be separated at some point, 
+                * but as we don't currently have MPU support on the board
+                * I will leave it
+                */
                if ((status & VT1724_IRQ_MPU_RX)||(status & VT1724_IRQ_MPU_TX)) {
                        if (ice->rmidi[0])
                                snd_mpu401_uart_interrupt(irq, ice->rmidi[0]->private_data, regs);
-                       outb(VT1724_IRQ_MPU_RX|VT1724_IRQ_MPU_TX, ICEREG1724(ice, IRQSTAT));
+                       outb(status & (VT1724_IRQ_MPU_RX|VT1724_IRQ_MPU_TX), ICEREG1724(ice, IRQSTAT));
                        status &= ~(VT1724_IRQ_MPU_RX|VT1724_IRQ_MPU_TX);
                }
                if (status & VT1724_IRQ_MTPCM) {
@@ -299,36 +306,45 @@ static unsigned int rates[] = {
        176400, 192000,
 };
 
-static snd_pcm_hw_constraint_list_t hw_constraints_rates_96 = {
+static struct snd_pcm_hw_constraint_list hw_constraints_rates_96 = {
        .count = ARRAY_SIZE(rates) - 2, /* up to 96000 */
        .list = rates,
        .mask = 0,
 };
 
-static snd_pcm_hw_constraint_list_t hw_constraints_rates_48 = {
+static struct snd_pcm_hw_constraint_list hw_constraints_rates_48 = {
        .count = ARRAY_SIZE(rates) - 5, /* up to 48000 */
        .list = rates,
        .mask = 0,
 };
 
-static snd_pcm_hw_constraint_list_t hw_constraints_rates_192 = {
+static struct snd_pcm_hw_constraint_list hw_constraints_rates_192 = {
        .count = ARRAY_SIZE(rates),
        .list = rates,
        .mask = 0,
 };
 
-static int snd_vt1724_pcm_trigger(snd_pcm_substream_t *substream, int cmd)
+struct vt1724_pcm_reg {
+       unsigned int addr;      /* ADDR register offset */
+       unsigned int size;      /* SIZE register offset */
+       unsigned int count;     /* COUNT register offset */
+       unsigned int start;     /* start & pause bit */
+};
+
+static int snd_vt1724_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
        unsigned char what;
        unsigned char old;
        struct list_head *pos;
-       snd_pcm_substream_t *s;
+       struct snd_pcm_substream *s;
 
        what = 0;
        snd_pcm_group_for_each(pos, substream) {
+               struct vt1724_pcm_reg *reg;
                s = snd_pcm_group_substream_entry(pos);
-               what |= (unsigned long)(s->runtime->private_data);
+               reg = s->runtime->private_data;
+               what |= reg->start;
                snd_pcm_trigger_done(s, substream);
        }
 
@@ -371,23 +387,26 @@ static int snd_vt1724_pcm_trigger(snd_pcm_substream_t *substream, int cmd)
 #define DMA_PAUSES     (VT1724_RDMA0_PAUSE|VT1724_PDMA0_PAUSE|VT1724_RDMA1_PAUSE|\
        VT1724_PDMA1_PAUSE|VT1724_PDMA2_PAUSE|VT1724_PDMA3_PAUSE|VT1724_PDMA4_PAUSE)
 
-static void snd_vt1724_set_pro_rate(ice1712_t *ice, unsigned int rate, int force)
+static int get_max_rate(struct snd_ice1712 *ice)
+{
+       if (ice->eeprom.data[ICE_EEP2_ACLINK] & VT1724_CFG_PRO_I2S) {
+               if ((ice->eeprom.data[ICE_EEP2_I2S] & 0x08) && !ice->vt1720)
+                       return 192000;
+               else
+                       return 96000;
+       } else
+               return 48000;
+}
+
+static void snd_vt1724_set_pro_rate(struct snd_ice1712 *ice, unsigned int rate,
+                                   int force)
 {
        unsigned long flags;
        unsigned char val, old;
-       unsigned int i;
+       unsigned int i, mclk_change;
 
-       spin_lock_irqsave(&ice->reg_lock, flags);
-       if ((inb(ICEMT1724(ice, DMA_CONTROL)) & DMA_STARTS) || 
-           (inb(ICEMT1724(ice, DMA_PAUSE)) & DMA_PAUSES)) {
-               /* running? we cannot change the rate now... */
-               spin_unlock_irqrestore(&ice->reg_lock, flags);
+       if (rate > get_max_rate(ice))
                return;
-       }
-       if (!force && is_pro_rate_locked(ice)) {
-               spin_unlock_irqrestore(&ice->reg_lock, flags);
-               return;
-       }
 
        switch (rate) {
        case 8000: val = 6; break;
@@ -410,8 +429,23 @@ static void snd_vt1724_set_pro_rate(ice1712_t *ice, unsigned int rate, int force
                val = 0;
                break;
        }
-       outb(val, ICEMT1724(ice, RATE));
-       if (rate == ice->cur_rate) {
+
+       spin_lock_irqsave(&ice->reg_lock, flags);
+       if ((inb(ICEMT1724(ice, DMA_CONTROL)) & DMA_STARTS) || 
+           (inb(ICEMT1724(ice, DMA_PAUSE)) & DMA_PAUSES)) {
+               /* running? we cannot change the rate now... */
+               spin_unlock_irqrestore(&ice->reg_lock, flags);
+               return;
+       }
+       if (!force && is_pro_rate_locked(ice)) {
+               spin_unlock_irqrestore(&ice->reg_lock, flags);
+               return;
+       }
+
+       old = inb(ICEMT1724(ice, RATE));
+       if (force || old != val)
+               outb(val, ICEMT1724(ice, RATE));
+       else if (rate == ice->cur_rate) {
                spin_unlock_irqrestore(&ice->reg_lock, flags);
                return;
        }
@@ -419,7 +453,8 @@ static void snd_vt1724_set_pro_rate(ice1712_t *ice, unsigned int rate, int force
        ice->cur_rate = rate;
 
        /* check MT02 */
-       if (ice->eeprom.data[ICE_EEP2_ACLINK] & 0x80) {
+       mclk_change = 0;
+       if (ice->eeprom.data[ICE_EEP2_ACLINK] & VT1724_CFG_PRO_I2S) {
                val = old = inb(ICEMT1724(ice, I2S_FORMAT));
                if (rate > 96000)
                        val |= VT1724_MT_I2S_MCLK_128X; /* 128x MCLK */
@@ -427,51 +462,41 @@ static void snd_vt1724_set_pro_rate(ice1712_t *ice, unsigned int rate, int force
                        val &= ~VT1724_MT_I2S_MCLK_128X; /* 256x MCLK */
                if (val != old) {
                        outb(val, ICEMT1724(ice, I2S_FORMAT));
-                       if (ice->eeprom.subvendor == VT1724_SUBDEVICE_REVOLUTION71) {
-                               /* FIXME: is this revo only? */
-                               /* assert PRST# to converters; MT05 bit 7 */
-                               outb(inb(ICEMT1724(ice, AC97_CMD)) | 0x80, ICEMT1724(ice, AC97_CMD));
-                               spin_unlock_irqrestore(&ice->reg_lock, flags);
-                               mdelay(5);
-                               spin_lock_irqsave(&ice->reg_lock, flags);
-                               /* deassert PRST# */
-                               outb(inb(ICEMT1724(ice, AC97_CMD)) & ~0x80, ICEMT1724(ice, AC97_CMD));
-                       }
+                       mclk_change = 1;
                }
        }
        spin_unlock_irqrestore(&ice->reg_lock, flags);
 
+       if (mclk_change && ice->gpio.i2s_mclk_changed)
+               ice->gpio.i2s_mclk_changed(ice);
+       if (ice->gpio.set_pro_rate)
+               ice->gpio.set_pro_rate(ice, rate);
+
        /* set up codecs */
        for (i = 0; i < ice->akm_codecs; i++) {
                if (ice->akm[i].ops.set_rate_val)
                        ice->akm[i].ops.set_rate_val(&ice->akm[i], rate);
        }
-
-       /* set up AC97 registers if needed */
-       if (! (ice->eeprom.data[ICE_EEP2_ACLINK] & 0x80) && ice->ac97) {
-               snd_ac97_set_rate(ice->ac97, AC97_PCM_FRONT_DAC_RATE, rate);
-               snd_ac97_set_rate(ice->ac97, AC97_PCM_SURR_DAC_RATE, rate);
-               snd_ac97_set_rate(ice->ac97, AC97_PCM_LFE_DAC_RATE, rate);
-               snd_ac97_set_rate(ice->ac97, AC97_SPDIF, rate);
-               snd_ac97_set_rate(ice->ac97, AC97_PCM_LR_ADC_RATE, rate);
-       }
+       if (ice->spdif.ops.setup_rate)
+               ice->spdif.ops.setup_rate(ice, rate);
 }
 
-static int snd_vt1724_pcm_hw_params(snd_pcm_substream_t * substream,
-                                   snd_pcm_hw_params_t * hw_params)
+static int snd_vt1724_pcm_hw_params(struct snd_pcm_substream *substream,
+                                   struct snd_pcm_hw_params *hw_params)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
        int i, chs;
 
        chs = params_channels(hw_params);
-       down(&ice->open_mutex);
+       mutex_lock(&ice->open_mutex);
        /* mark surround channels */
        if (substream == ice->playback_pro_substream) {
                /* PDMA0 can be multi-channel up to 8 */
                chs = chs / 2 - 1;
                for (i = 0; i < chs; i++) {
-                       if (ice->pcm_reserved[i] && ice->pcm_reserved[i] != substream) {
-                               up(&ice->open_mutex);
+                       if (ice->pcm_reserved[i] &&
+                           ice->pcm_reserved[i] != substream) {
+                               mutex_unlock(&ice->open_mutex);
                                return -EBUSY;
                        }
                        ice->pcm_reserved[i] = substream;
@@ -484,8 +509,9 @@ static int snd_vt1724_pcm_hw_params(snd_pcm_substream_t * substream,
                for (i = 0; i < 3; i++) {
                        /* check individual playback stream */
                        if (ice->playback_con_substream_ds[i] == substream) {
-                               if (ice->pcm_reserved[i] && ice->pcm_reserved[i] != substream) {
-                                       up(&ice->open_mutex);
+                               if (ice->pcm_reserved[i] &&
+                                   ice->pcm_reserved[i] != substream) {
+                                       mutex_unlock(&ice->open_mutex);
                                        return -EBUSY;
                                }
                                ice->pcm_reserved[i] = substream;
@@ -493,32 +519,32 @@ static int snd_vt1724_pcm_hw_params(snd_pcm_substream_t * substream,
                        }
                }
        }
-       up(&ice->open_mutex);
+       mutex_unlock(&ice->open_mutex);
        snd_vt1724_set_pro_rate(ice, params_rate(hw_params), 0);
        return snd_pcm_lib_malloc_pages(substream, params_buffer_bytes(hw_params));
 }
 
-static int snd_vt1724_pcm_hw_free(snd_pcm_substream_t * substream)
+static int snd_vt1724_pcm_hw_free(struct snd_pcm_substream *substream)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
        int i;
 
-       down(&ice->open_mutex);
+       mutex_lock(&ice->open_mutex);
        /* unmark surround channels */
        for (i = 0; i < 3; i++)
                if (ice->pcm_reserved[i] == substream)
                        ice->pcm_reserved[i] = NULL;
-       up(&ice->open_mutex);
+       mutex_unlock(&ice->open_mutex);
        return snd_pcm_lib_free_pages(substream);
 }
 
-static int snd_vt1724_playback_pro_prepare(snd_pcm_substream_t * substream)
+static int snd_vt1724_playback_pro_prepare(struct snd_pcm_substream *substream)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
        unsigned char val;
        unsigned int size;
 
-       spin_lock(&ice->reg_lock);
+       spin_lock_irq(&ice->reg_lock);
        val = (8 - substream->runtime->channels) >> 1;
        outb(val, ICEMT1724(ice, BURST));
 
@@ -533,15 +559,15 @@ static int snd_vt1724_playback_pro_prepare(snd_pcm_substream_t * substream)
        outw(size, ICEMT1724(ice, PLAYBACK_COUNT));
        outb(size >> 16, ICEMT1724(ice, PLAYBACK_COUNT) + 2);
 
-       spin_unlock(&ice->reg_lock);
+       spin_unlock_irq(&ice->reg_lock);
 
        // printk("pro prepare: ch = %d, addr = 0x%x, buffer = 0x%x, period = 0x%x\n", substream->runtime->channels, (unsigned int)substream->runtime->dma_addr, snd_pcm_lib_buffer_bytes(substream), snd_pcm_lib_period_bytes(substream));
        return 0;
 }
 
-static snd_pcm_uframes_t snd_vt1724_playback_pro_pointer(snd_pcm_substream_t * substream)
+static snd_pcm_uframes_t snd_vt1724_playback_pro_pointer(struct snd_pcm_substream *substream)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
        size_t ptr;
 
        if (!(inl(ICEMT1724(ice, DMA_CONTROL)) & VT1724_PDMA0_START))
@@ -555,46 +581,46 @@ static snd_pcm_uframes_t snd_vt1724_playback_pro_pointer(snd_pcm_substream_t * s
        ptr -= substream->runtime->dma_addr;
        ptr = bytes_to_frames(substream->runtime, ptr);
        if (ptr >= substream->runtime->buffer_size) {
-               snd_printd("ice1724: invalid ptr %d (size=%d)\n", (int)ptr, (int)substream->runtime->period_size);
+               snd_printd("ice1724: invalid ptr %d (size=%d)\n",
+                          (int)ptr, (int)substream->runtime->period_size);
                return 0;
        }
 #else /* read PLAYBACK_SIZE */
        ptr = inl(ICEMT1724(ice, PLAYBACK_SIZE)) & 0xffffff;
        ptr = (ptr + 1) << 2;
        ptr = bytes_to_frames(substream->runtime, ptr);
-       if (ptr <= substream->runtime->buffer_size)
+       if (! ptr)
+               ;
+       else if (ptr <= substream->runtime->buffer_size)
                ptr = substream->runtime->buffer_size - ptr;
        else {
-               snd_printd("ice1724: invalid ptr %d (size=%d)\n", (int)ptr, (int)substream->runtime->buffer_size);
+               snd_printd("ice1724: invalid ptr %d (size=%d)\n",
+                          (int)ptr, (int)substream->runtime->buffer_size);
                ptr = 0;
        }
 #endif
        return ptr;
 }
 
-struct vt1724_pcm_reg {
-       unsigned int addr;      /* ADDR register offset */
-       unsigned int size;      /* SIZE register offset */
-       unsigned int count;     /* COUNT register offset */
-       unsigned int start;     /* start bit */
-       unsigned int pause;     /* pause bit */
-};
-
-static int snd_vt1724_pcm_prepare(snd_pcm_substream_t *substream, const struct vt1724_pcm_reg *reg)
+static int snd_vt1724_pcm_prepare(struct snd_pcm_substream *substream)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
+       struct vt1724_pcm_reg *reg = substream->runtime->private_data;
 
-       spin_lock(&ice->reg_lock);
+       spin_lock_irq(&ice->reg_lock);
        outl(substream->runtime->dma_addr, ice->profi_port + reg->addr);
-       outw((snd_pcm_lib_buffer_bytes(substream) >> 2) - 1, ice->profi_port + reg->size);
-       outw((snd_pcm_lib_period_bytes(substream) >> 2) - 1, ice->profi_port + reg->count);
-       spin_unlock(&ice->reg_lock);
+       outw((snd_pcm_lib_buffer_bytes(substream) >> 2) - 1,
+            ice->profi_port + reg->size);
+       outw((snd_pcm_lib_period_bytes(substream) >> 2) - 1,
+            ice->profi_port + reg->count);
+       spin_unlock_irq(&ice->reg_lock);
        return 0;
 }
 
-static snd_pcm_uframes_t snd_vt1724_pcm_pointer(snd_pcm_substream_t *substream, const struct vt1724_pcm_reg *reg)
+static snd_pcm_uframes_t snd_vt1724_pcm_pointer(struct snd_pcm_substream *substream)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
+       struct vt1724_pcm_reg *reg = substream->runtime->private_data;
        size_t ptr;
 
        if (!(inl(ICEMT1724(ice, DMA_CONTROL)) & reg->start))
@@ -607,35 +633,34 @@ static snd_pcm_uframes_t snd_vt1724_pcm_pointer(snd_pcm_substream_t *substream,
        ptr = inw(ice->profi_port + reg->size);
        ptr = (ptr + 1) << 2;
        ptr = bytes_to_frames(substream->runtime, ptr);
-       if (ptr <= substream->runtime->buffer_size)
+       if (! ptr)
+               ;
+       else if (ptr <= substream->runtime->buffer_size)
                ptr = substream->runtime->buffer_size - ptr;
        else {
-               snd_printd("ice1724: invalid ptr %d (size=%d)\n", (int)ptr, (int)substream->runtime->buffer_size);
+               snd_printd("ice1724: invalid ptr %d (size=%d)\n",
+                          (int)ptr, (int)substream->runtime->buffer_size);
                ptr = 0;
        }
        return ptr;
 #endif
 }
 
-const static struct vt1724_pcm_reg vt1724_capture_pro_reg = {
+static struct vt1724_pcm_reg vt1724_playback_pro_reg = {
+       .addr = VT1724_MT_PLAYBACK_ADDR,
+       .size = VT1724_MT_PLAYBACK_SIZE,
+       .count = VT1724_MT_PLAYBACK_COUNT,
+       .start = VT1724_PDMA0_START,
+};
+
+static struct vt1724_pcm_reg vt1724_capture_pro_reg = {
        .addr = VT1724_MT_CAPTURE_ADDR,
        .size = VT1724_MT_CAPTURE_SIZE,
        .count = VT1724_MT_CAPTURE_COUNT,
        .start = VT1724_RDMA0_START,
-       .pause = VT1724_RDMA0_PAUSE,
 };
 
-static int snd_vt1724_capture_pro_prepare(snd_pcm_substream_t * substream)
-{
-       return snd_vt1724_pcm_prepare(substream, &vt1724_capture_pro_reg);
-}
-
-static snd_pcm_uframes_t snd_vt1724_capture_pro_pointer(snd_pcm_substream_t * substream)
-{
-       return snd_vt1724_pcm_pointer(substream, &vt1724_capture_pro_reg);
-}
-
-static snd_pcm_hardware_t snd_vt1724_playback_pro =
+static struct snd_pcm_hardware snd_vt1724_playback_pro =
 {
        .info =                 (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
                                 SNDRV_PCM_INFO_BLOCK_TRANSFER |
@@ -654,16 +679,19 @@ static snd_pcm_hardware_t snd_vt1724_playback_pro =
        .periods_max =          1024,
 };
 
-static snd_pcm_hardware_t snd_vt1724_spdif =
+static struct snd_pcm_hardware snd_vt1724_spdif =
 {
        .info =                 (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
                                 SNDRV_PCM_INFO_BLOCK_TRANSFER |
                                 SNDRV_PCM_INFO_MMAP_VALID |
                                 SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_SYNC_START),
        .formats =              SNDRV_PCM_FMTBIT_S32_LE,
-       .rates =                SNDRV_PCM_RATE_32000|SNDRV_PCM_RATE_44100|SNDRV_PCM_RATE_48000,
+       .rates =                (SNDRV_PCM_RATE_32000|SNDRV_PCM_RATE_44100|
+                                SNDRV_PCM_RATE_48000|SNDRV_PCM_RATE_88200|
+                                SNDRV_PCM_RATE_96000|SNDRV_PCM_RATE_176400|
+                                SNDRV_PCM_RATE_192000),
        .rate_min =             32000,
-       .rate_max =             48000,
+       .rate_max =             192000,
        .channels_min =         2,
        .channels_max =         2,
        .buffer_bytes_max =     (1UL << 18),    /* 16bits dword */
@@ -673,7 +701,7 @@ static snd_pcm_hardware_t snd_vt1724_spdif =
        .periods_max =          1024,
 };
 
-static snd_pcm_hardware_t snd_vt1724_2ch_stereo =
+static struct snd_pcm_hardware snd_vt1724_2ch_stereo =
 {
        .info =                 (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
                                 SNDRV_PCM_INFO_BLOCK_TRANSFER |
@@ -695,56 +723,63 @@ static snd_pcm_hardware_t snd_vt1724_2ch_stereo =
 /*
  * set rate constraints
  */
-static int set_rate_constraints(ice1712_t *ice, snd_pcm_substream_t *substream)
-{
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       if (ice->eeprom.data[ICE_EEP2_ACLINK] & 0x80) {
+static int set_rate_constraints(struct snd_ice1712 *ice,
+                               struct snd_pcm_substream *substream)
+{
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       if (ice->hw_rates) {
+               /* hardware specific */
+               runtime->hw.rate_min = ice->hw_rates->list[0];
+               runtime->hw.rate_max = ice->hw_rates->list[ice->hw_rates->count - 1];
+               runtime->hw.rates = SNDRV_PCM_RATE_KNOT;
+               return snd_pcm_hw_constraint_list(runtime, 0,
+                                                 SNDRV_PCM_HW_PARAM_RATE,
+                                                 ice->hw_rates);
+       }
+       if (ice->eeprom.data[ICE_EEP2_ACLINK] & VT1724_CFG_PRO_I2S) {
                /* I2S */
-               if (ice->eeprom.data[ICE_EEP2_I2S] & 0x08)
-                       return snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_RATE, &hw_constraints_rates_192);
+               /* VT1720 doesn't support more than 96kHz */
+               if ((ice->eeprom.data[ICE_EEP2_I2S] & 0x08) && !ice->vt1720)
+                       return snd_pcm_hw_constraint_list(runtime, 0,
+                                                         SNDRV_PCM_HW_PARAM_RATE,
+                                                         &hw_constraints_rates_192);
                else {
-                       runtime->hw.rates = SNDRV_PCM_RATE_KNOT | SNDRV_PCM_RATE_8000_96000;
+                       runtime->hw.rates = SNDRV_PCM_RATE_KNOT |
+                               SNDRV_PCM_RATE_8000_96000;
                        runtime->hw.rate_max = 96000;
-                       return snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_RATE, &hw_constraints_rates_96);
+                       return snd_pcm_hw_constraint_list(runtime, 0,
+                                                         SNDRV_PCM_HW_PARAM_RATE,
+                                                         &hw_constraints_rates_96);
                }
        } else if (ice->ac97) {
                /* ACLINK */
-               int ratec;
-               if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
-                       ratec = AC97_RATES_FRONT_DAC;
-               else
-                       ratec = AC97_RATES_ADC;
-               runtime->hw.rates = ice->ac97->rates[ratec];
                runtime->hw.rate_max = 48000;
-               if (runtime->hw.rates == SNDRV_PCM_RATE_48000) {
-                       runtime->hw.rate_min = 48000;
-                       return 0;
-               } else {
-                       runtime->hw.rates = SNDRV_PCM_RATE_KNOT | SNDRV_PCM_RATE_8000_48000;
-                       return snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_RATE, &hw_constraints_rates_48);
-               }
+               runtime->hw.rates = SNDRV_PCM_RATE_KNOT | SNDRV_PCM_RATE_8000_48000;
+               return snd_pcm_hw_constraint_list(runtime, 0,
+                                                 SNDRV_PCM_HW_PARAM_RATE,
+                                                 &hw_constraints_rates_48);
        }
        return 0;
 }
 
-/* multi-channel playback needs alignment 8x32bit regarless of the channels
+/* multi-channel playback needs alignment 8x32bit regardless of the channels
  * actually used
  */
 #define VT1724_BUFFER_ALIGN    0x20
 
-static int snd_vt1724_playback_pro_open(snd_pcm_substream_t * substream)
+static int snd_vt1724_playback_pro_open(struct snd_pcm_substream *substream)
 {
-       snd_pcm_runtime_t *runtime = substream->runtime;
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
        int chs;
 
-       runtime->private_data = (void*)VT1724_PDMA0_START; /* irq/status/trigger bit */
+       runtime->private_data = &vt1724_playback_pro_reg;
        ice->playback_pro_substream = substream;
        runtime->hw = snd_vt1724_playback_pro;
        snd_pcm_set_sync(substream);
        snd_pcm_hw_constraint_msbits(runtime, 0, 32, 24);
        set_rate_constraints(ice, substream);
-       down(&ice->open_mutex);
+       mutex_lock(&ice->open_mutex);
        /* calculate the currently available channels */
        for (chs = 0; chs < 3; chs++) {
                if (ice->pcm_reserved[chs])
@@ -754,7 +789,7 @@ static int snd_vt1724_playback_pro_open(snd_pcm_substream_t * substream)
        runtime->hw.channels_max = chs;
        if (chs > 2) /* channels must be even */
                snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS, 2);
-       up(&ice->open_mutex);
+       mutex_unlock(&ice->open_mutex);
        snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_PERIOD_BYTES,
                                   VT1724_BUFFER_ALIGN);
        snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_BUFFER_BYTES,
@@ -762,23 +797,27 @@ static int snd_vt1724_playback_pro_open(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static int snd_vt1724_capture_pro_open(snd_pcm_substream_t * substream)
+static int snd_vt1724_capture_pro_open(struct snd_pcm_substream *substream)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
 
-       runtime->private_data = (void*)VT1724_RDMA0_START; /* irq/status/trigger bit */
+       runtime->private_data = &vt1724_capture_pro_reg;
        ice->capture_pro_substream = substream;
        runtime->hw = snd_vt1724_2ch_stereo;
        snd_pcm_set_sync(substream);
        snd_pcm_hw_constraint_msbits(runtime, 0, 32, 24);
        set_rate_constraints(ice, substream);
+       snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_PERIOD_BYTES,
+                                  VT1724_BUFFER_ALIGN);
+       snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_BUFFER_BYTES,
+                                  VT1724_BUFFER_ALIGN);
        return 0;
 }
 
-static int snd_vt1724_playback_pro_close(snd_pcm_substream_t * substream)
+static int snd_vt1724_playback_pro_close(struct snd_pcm_substream *substream)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
 
        if (PRO_RATE_RESET)
                snd_vt1724_set_pro_rate(ice, PRO_RATE_DEFAULT, 0);
@@ -787,9 +826,9 @@ static int snd_vt1724_playback_pro_close(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static int snd_vt1724_capture_pro_close(snd_pcm_substream_t * substream)
+static int snd_vt1724_capture_pro_close(struct snd_pcm_substream *substream)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
 
        if (PRO_RATE_RESET)
                snd_vt1724_set_pro_rate(ice, PRO_RATE_DEFAULT, 0);
@@ -797,7 +836,7 @@ static int snd_vt1724_capture_pro_close(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static snd_pcm_ops_t snd_vt1724_playback_pro_ops = {
+static struct snd_pcm_ops snd_vt1724_playback_pro_ops = {
        .open =         snd_vt1724_playback_pro_open,
        .close =        snd_vt1724_playback_pro_close,
        .ioctl =        snd_pcm_lib_ioctl,
@@ -808,20 +847,20 @@ static snd_pcm_ops_t snd_vt1724_playback_pro_ops = {
        .pointer =      snd_vt1724_playback_pro_pointer,
 };
 
-static snd_pcm_ops_t snd_vt1724_capture_pro_ops = {
+static struct snd_pcm_ops snd_vt1724_capture_pro_ops = {
        .open =         snd_vt1724_capture_pro_open,
        .close =        snd_vt1724_capture_pro_close,
        .ioctl =        snd_pcm_lib_ioctl,
        .hw_params =    snd_vt1724_pcm_hw_params,
        .hw_free =      snd_vt1724_pcm_hw_free,
-       .prepare =      snd_vt1724_capture_pro_prepare,
+       .prepare =      snd_vt1724_pcm_prepare,
        .trigger =      snd_vt1724_pcm_trigger,
-       .pointer =      snd_vt1724_capture_pro_pointer,
+       .pointer =      snd_vt1724_pcm_pointer,
 };
 
-static int __devinit snd_vt1724_pcm_profi(ice1712_t * ice, int device)
+static int __devinit snd_vt1724_pcm_profi(struct snd_ice1712 * ice, int device)
 {
-       snd_pcm_t *pcm;
+       struct snd_pcm *pcm;
        int err;
 
        err = snd_pcm_new(ice->card, "ICE1724", device, 1, 1, &pcm);
@@ -836,7 +875,8 @@ static int __devinit snd_vt1724_pcm_profi(ice1712_t * ice, int device)
        strcpy(pcm->name, "ICE1724");
 
        snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
-                                             snd_dma_pci_data(ice->pci), 256*1024, 256*1024);
+                                             snd_dma_pci_data(ice->pci),
+                                             256*1024, 256*1024);
 
        ice->pcm_pro = pcm;
 
@@ -848,48 +888,72 @@ static int __devinit snd_vt1724_pcm_profi(ice1712_t * ice, int device)
  * SPDIF PCM
  */
 
-const static struct vt1724_pcm_reg vt1724_playback_spdif_reg = {
+static struct vt1724_pcm_reg vt1724_playback_spdif_reg = {
        .addr = VT1724_MT_PDMA4_ADDR,
        .size = VT1724_MT_PDMA4_SIZE,
        .count = VT1724_MT_PDMA4_COUNT,
        .start = VT1724_PDMA4_START,
-       .pause = VT1724_PDMA4_PAUSE,
 };
 
-const static struct vt1724_pcm_reg vt1724_capture_spdif_reg = {
+static struct vt1724_pcm_reg vt1724_capture_spdif_reg = {
        .addr = VT1724_MT_RDMA1_ADDR,
        .size = VT1724_MT_RDMA1_SIZE,
        .count = VT1724_MT_RDMA1_COUNT,
        .start = VT1724_RDMA1_START,
-       .pause = VT1724_RDMA1_PAUSE,
 };
 
-static int snd_vt1724_playback_spdif_prepare(snd_pcm_substream_t * substream)
+/* update spdif control bits; call with reg_lock */
+static void update_spdif_bits(struct snd_ice1712 *ice, unsigned int val)
 {
-       return snd_vt1724_pcm_prepare(substream, &vt1724_playback_spdif_reg);
-}
+       unsigned char cbit, disabled;
 
-static snd_pcm_uframes_t snd_vt1724_playback_spdif_pointer(snd_pcm_substream_t * substream)
-{
-       return snd_vt1724_pcm_pointer(substream, &vt1724_playback_spdif_reg);
+       cbit = inb(ICEREG1724(ice, SPDIF_CFG));
+       disabled = cbit & ~VT1724_CFG_SPDIF_OUT_EN;
+       if (cbit != disabled)
+               outb(disabled, ICEREG1724(ice, SPDIF_CFG));
+       outw(val, ICEMT1724(ice, SPDIF_CTRL));
+       if (cbit != disabled)
+               outb(cbit, ICEREG1724(ice, SPDIF_CFG));
+       outw(val, ICEMT1724(ice, SPDIF_CTRL));
 }
 
-static int snd_vt1724_capture_spdif_prepare(snd_pcm_substream_t * substream)
+/* update SPDIF control bits according to the given rate */
+static void update_spdif_rate(struct snd_ice1712 *ice, unsigned int rate)
 {
-       return snd_vt1724_pcm_prepare(substream, &vt1724_capture_spdif_reg);
+       unsigned int val, nval;
+       unsigned long flags;
+
+       spin_lock_irqsave(&ice->reg_lock, flags);
+       nval = val = inw(ICEMT1724(ice, SPDIF_CTRL));
+       nval &= ~(7 << 12);
+       switch (rate) {
+       case 44100: break;
+       case 48000: nval |= 2 << 12; break;
+       case 32000: nval |= 3 << 12; break;
+       case 88200: nval |= 4 << 12; break;
+       case 96000: nval |= 5 << 12; break;
+       case 192000: nval |= 6 << 12; break;
+       case 176400: nval |= 7 << 12; break;
+       }
+       if (val != nval)
+               update_spdif_bits(ice, nval);
+       spin_unlock_irqrestore(&ice->reg_lock, flags);
 }
 
-static snd_pcm_uframes_t snd_vt1724_capture_spdif_pointer(snd_pcm_substream_t * substream)
+static int snd_vt1724_playback_spdif_prepare(struct snd_pcm_substream *substream)
 {
-       return snd_vt1724_pcm_pointer(substream, &vt1724_capture_spdif_reg);
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
+       if (! ice->force_pdma4)
+               update_spdif_rate(ice, substream->runtime->rate);
+       return snd_vt1724_pcm_prepare(substream);
 }
 
-static int snd_vt1724_playback_spdif_open(snd_pcm_substream_t *substream)
+static int snd_vt1724_playback_spdif_open(struct snd_pcm_substream *substream)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
 
-       runtime->private_data = (void*)VT1724_PDMA4_START; /* irq/status/trigger bit */
+       runtime->private_data = &vt1724_playback_spdif_reg;
        ice->playback_con_substream = substream;
        if (ice->force_pdma4) {
                runtime->hw = snd_vt1724_2ch_stereo;
@@ -898,12 +962,16 @@ static int snd_vt1724_playback_spdif_open(snd_pcm_substream_t *substream)
                runtime->hw = snd_vt1724_spdif;
        snd_pcm_set_sync(substream);
        snd_pcm_hw_constraint_msbits(runtime, 0, 32, 24);
+       snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_PERIOD_BYTES,
+                                  VT1724_BUFFER_ALIGN);
+       snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_BUFFER_BYTES,
+                                  VT1724_BUFFER_ALIGN);
        return 0;
 }
 
-static int snd_vt1724_playback_spdif_close(snd_pcm_substream_t * substream)
+static int snd_vt1724_playback_spdif_close(struct snd_pcm_substream *substream)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
 
        if (PRO_RATE_RESET)
                snd_vt1724_set_pro_rate(ice, PRO_RATE_DEFAULT, 0);
@@ -912,12 +980,12 @@ static int snd_vt1724_playback_spdif_close(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static int snd_vt1724_capture_spdif_open(snd_pcm_substream_t *substream)
+static int snd_vt1724_capture_spdif_open(struct snd_pcm_substream *substream)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
 
-       runtime->private_data = (void*)VT1724_RDMA1_START; /* irq/status/trigger bit */
+       runtime->private_data = &vt1724_capture_spdif_reg;
        ice->capture_con_substream = substream;
        if (ice->force_rdma1) {
                runtime->hw = snd_vt1724_2ch_stereo;
@@ -926,12 +994,16 @@ static int snd_vt1724_capture_spdif_open(snd_pcm_substream_t *substream)
                runtime->hw = snd_vt1724_spdif;
        snd_pcm_set_sync(substream);
        snd_pcm_hw_constraint_msbits(runtime, 0, 32, 24);
+       snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_PERIOD_BYTES,
+                                  VT1724_BUFFER_ALIGN);
+       snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_BUFFER_BYTES,
+                                  VT1724_BUFFER_ALIGN);
        return 0;
 }
 
-static int snd_vt1724_capture_spdif_close(snd_pcm_substream_t * substream)
+static int snd_vt1724_capture_spdif_close(struct snd_pcm_substream *substream)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
 
        if (PRO_RATE_RESET)
                snd_vt1724_set_pro_rate(ice, PRO_RATE_DEFAULT, 0);
@@ -940,7 +1012,7 @@ static int snd_vt1724_capture_spdif_close(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static snd_pcm_ops_t snd_vt1724_playback_spdif_ops = {
+static struct snd_pcm_ops snd_vt1724_playback_spdif_ops = {
        .open =         snd_vt1724_playback_spdif_open,
        .close =        snd_vt1724_playback_spdif_close,
        .ioctl =        snd_pcm_lib_ioctl,
@@ -948,25 +1020,25 @@ static snd_pcm_ops_t snd_vt1724_playback_spdif_ops = {
        .hw_free =      snd_vt1724_pcm_hw_free,
        .prepare =      snd_vt1724_playback_spdif_prepare,
        .trigger =      snd_vt1724_pcm_trigger,
-       .pointer =      snd_vt1724_playback_spdif_pointer,
+       .pointer =      snd_vt1724_pcm_pointer,
 };
 
-static snd_pcm_ops_t snd_vt1724_capture_spdif_ops = {
+static struct snd_pcm_ops snd_vt1724_capture_spdif_ops = {
        .open =         snd_vt1724_capture_spdif_open,
        .close =        snd_vt1724_capture_spdif_close,
        .ioctl =        snd_pcm_lib_ioctl,
        .hw_params =    snd_vt1724_pcm_hw_params,
        .hw_free =      snd_vt1724_pcm_hw_free,
-       .prepare =      snd_vt1724_capture_spdif_prepare,
+       .prepare =      snd_vt1724_pcm_prepare,
        .trigger =      snd_vt1724_pcm_trigger,
-       .pointer =      snd_vt1724_capture_spdif_pointer,
+       .pointer =      snd_vt1724_pcm_pointer,
 };
 
 
-static int __devinit snd_vt1724_pcm_spdif(ice1712_t * ice, int device)
+static int __devinit snd_vt1724_pcm_spdif(struct snd_ice1712 * ice, int device)
 {
        char *name;
-       snd_pcm_t *pcm;
+       struct snd_pcm *pcm;
        int play, capt;
        int err;
 
@@ -1005,7 +1077,8 @@ static int __devinit snd_vt1724_pcm_spdif(ice1712_t * ice, int device)
        strcpy(pcm->name, name);
 
        snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
-                                             snd_dma_pci_data(ice->pci), 64*1024, 64*1024);
+                                             snd_dma_pci_data(ice->pci),
+                                             64*1024, 64*1024);
 
        ice->pcm = pcm;
 
@@ -1017,61 +1090,53 @@ static int __devinit snd_vt1724_pcm_spdif(ice1712_t * ice, int device)
  * independent surround PCMs
  */
 
-const static struct vt1724_pcm_reg vt1724_playback_dma_regs[3] = {
+static struct vt1724_pcm_reg vt1724_playback_dma_regs[3] = {
        {
                .addr = VT1724_MT_PDMA1_ADDR,
                .size = VT1724_MT_PDMA1_SIZE,
                .count = VT1724_MT_PDMA1_COUNT,
                .start = VT1724_PDMA1_START,
-               .pause = VT1724_PDMA1_PAUSE,
        },
        {
                .addr = VT1724_MT_PDMA2_ADDR,
                .size = VT1724_MT_PDMA2_SIZE,
                .count = VT1724_MT_PDMA2_COUNT,
                .start = VT1724_PDMA2_START,
-               .pause = VT1724_PDMA2_PAUSE,
        },
        {
                .addr = VT1724_MT_PDMA3_ADDR,
                .size = VT1724_MT_PDMA3_SIZE,
                .count = VT1724_MT_PDMA3_COUNT,
                .start = VT1724_PDMA3_START,
-               .pause = VT1724_PDMA3_PAUSE,
        },
 };
 
-static int snd_vt1724_playback_indep_prepare(snd_pcm_substream_t * substream)
+static int snd_vt1724_playback_indep_prepare(struct snd_pcm_substream *substream)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
        unsigned char val;
 
-       spin_lock(&ice->reg_lock);
+       spin_lock_irq(&ice->reg_lock);
        val = 3 - substream->number;
        if (inb(ICEMT1724(ice, BURST)) < val)
                outb(val, ICEMT1724(ice, BURST));
-       spin_unlock(&ice->reg_lock);
-       return snd_vt1724_pcm_prepare(substream, &vt1724_playback_dma_regs[substream->number]);
-}
-
-static snd_pcm_uframes_t snd_vt1724_playback_indep_pointer(snd_pcm_substream_t * substream)
-{
-       return snd_vt1724_pcm_pointer(substream, &vt1724_playback_dma_regs[substream->number]);
+       spin_unlock_irq(&ice->reg_lock);
+       return snd_vt1724_pcm_prepare(substream);
 }
 
-static int snd_vt1724_playback_indep_open(snd_pcm_substream_t *substream)
+static int snd_vt1724_playback_indep_open(struct snd_pcm_substream *substream)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
-       snd_pcm_runtime_t *runtime = substream->runtime;
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
 
-       down(&ice->open_mutex);
+       mutex_lock(&ice->open_mutex);
        /* already used by PDMA0? */
        if (ice->pcm_reserved[substream->number]) {
-               up(&ice->open_mutex);
+               mutex_unlock(&ice->open_mutex);
                return -EBUSY; /* FIXME: should handle blocking mode properly */
        }
-       up(&ice->open_mutex);
-       runtime->private_data = (void*)(1UL << (substream->number + 4));
+       mutex_unlock(&ice->open_mutex);
+       runtime->private_data = &vt1724_playback_dma_regs[substream->number];
        ice->playback_con_substream_ds[substream->number] = substream;
        runtime->hw = snd_vt1724_2ch_stereo;
        snd_pcm_set_sync(substream);
@@ -1080,9 +1145,9 @@ static int snd_vt1724_playback_indep_open(snd_pcm_substream_t *substream)
        return 0;
 }
 
-static int snd_vt1724_playback_indep_close(snd_pcm_substream_t * substream)
+static int snd_vt1724_playback_indep_close(struct snd_pcm_substream *substream)
 {
-       ice1712_t *ice = snd_pcm_substream_chip(substream);
+       struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
 
        if (PRO_RATE_RESET)
                snd_vt1724_set_pro_rate(ice, PRO_RATE_DEFAULT, 0);
@@ -1092,7 +1157,7 @@ static int snd_vt1724_playback_indep_close(snd_pcm_substream_t * substream)
        return 0;
 }
 
-static snd_pcm_ops_t snd_vt1724_playback_indep_ops = {
+static struct snd_pcm_ops snd_vt1724_playback_indep_ops = {
        .open =         snd_vt1724_playback_indep_open,
        .close =        snd_vt1724_playback_indep_close,
        .ioctl =        snd_pcm_lib_ioctl,
@@ -1100,13 +1165,13 @@ static snd_pcm_ops_t snd_vt1724_playback_indep_ops = {
        .hw_free =      snd_vt1724_pcm_hw_free,
        .prepare =      snd_vt1724_playback_indep_prepare,
        .trigger =      snd_vt1724_pcm_trigger,
-       .pointer =      snd_vt1724_playback_indep_pointer,
+       .pointer =      snd_vt1724_pcm_pointer,
 };
 
 
-static int __devinit snd_vt1724_pcm_indep(ice1712_t * ice, int device)
+static int __devinit snd_vt1724_pcm_indep(struct snd_ice1712 * ice, int device)
 {
-       snd_pcm_t *pcm;
+       struct snd_pcm *pcm;
        int play;
        int err;
 
@@ -1126,7 +1191,8 @@ static int __devinit snd_vt1724_pcm_indep(ice1712_t * ice, int device)
        strcpy(pcm->name, "ICE1724 Surround PCM");
 
        snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
-                                             snd_dma_pci_data(ice->pci), 64*1024, 64*1024);
+                                             snd_dma_pci_data(ice->pci),
+                                             64*1024, 64*1024);
 
        ice->pcm_ds = pcm;
 
@@ -1138,22 +1204,24 @@ static int __devinit snd_vt1724_pcm_indep(ice1712_t * ice, int device)
  *  Mixer section
  */
 
-static int __devinit snd_vt1724_ac97_mixer(ice1712_t * ice)
+static int __devinit snd_vt1724_ac97_mixer(struct snd_ice1712 * ice)
 {
        int err;
 
        if (! (ice->eeprom.data[ICE_EEP2_ACLINK] & VT1724_CFG_PRO_I2S)) {
-               ac97_bus_t bus, *pbus;
-               ac97_t ac97;
+               struct snd_ac97_bus *pbus;
+               struct snd_ac97_template ac97;
+               static struct snd_ac97_bus_ops ops = {
+                       .write = snd_vt1724_ac97_write,
+                       .read = snd_vt1724_ac97_read,
+               };
+
                /* cold reset */
                outb(inb(ICEMT1724(ice, AC97_CMD)) | 0x80, ICEMT1724(ice, AC97_CMD));
                mdelay(5); /* FIXME */
                outb(inb(ICEMT1724(ice, AC97_CMD)) & ~0x80, ICEMT1724(ice, AC97_CMD));
 
-               memset(&bus, 0, sizeof(bus));
-               bus.write = snd_vt1724_ac97_write;
-               bus.read = snd_vt1724_ac97_read;
-               if ((err = snd_ac97_bus(ice->card, &bus, &pbus)) < 0)
+               if ((err = snd_ac97_bus(ice->card, 0, &ops, NULL, &pbus)) < 0)
                        return err;
                memset(&ac97, 0, sizeof(ac97));
                ac97.private_data = ice;
@@ -1171,17 +1239,17 @@ static int __devinit snd_vt1724_ac97_mixer(ice1712_t * ice)
  *
  */
 
-static inline unsigned int eeprom_triple(ice1712_t *ice, int idx)
+static inline unsigned int eeprom_triple(struct snd_ice1712 *ice, int idx)
 {
        return (unsigned int)ice->eeprom.data[idx] | \
                ((unsigned int)ice->eeprom.data[idx + 1] << 8) | \
                ((unsigned int)ice->eeprom.data[idx + 2] << 16);
 }
 
-static void snd_vt1724_proc_read(snd_info_entry_t *entry, 
-                                snd_info_buffer_t * buffer)
+static void snd_vt1724_proc_read(struct snd_info_entry *entry, 
+                                struct snd_info_buffer *buffer)
 {
-       ice1712_t *ice = snd_magic_cast(ice1712_t, entry->private_data, return);
+       struct snd_ice1712 *ice = entry->private_data;
        unsigned int idx;
 
        snd_iprintf(buffer, "%s\n\n", ice->card->longname);
@@ -1190,28 +1258,39 @@ static void snd_vt1724_proc_read(snd_info_entry_t *entry,
        snd_iprintf(buffer, "  Subvendor        : 0x%x\n", ice->eeprom.subvendor);
        snd_iprintf(buffer, "  Size             : %i bytes\n", ice->eeprom.size);
        snd_iprintf(buffer, "  Version          : %i\n", ice->eeprom.version);
-       snd_iprintf(buffer, "  System Config    : 0x%x\n", ice->eeprom.data[ICE_EEP2_SYSCONF]);
-       snd_iprintf(buffer, "  ACLink           : 0x%x\n", ice->eeprom.data[ICE_EEP2_ACLINK]);
-       snd_iprintf(buffer, "  I2S              : 0x%x\n", ice->eeprom.data[ICE_EEP2_I2S]);
-       snd_iprintf(buffer, "  S/PDIF           : 0x%x\n", ice->eeprom.data[ICE_EEP2_SPDIF]);
-       snd_iprintf(buffer, "  GPIO direction   : 0x%x\n", ice->eeprom.gpiodir);
-       snd_iprintf(buffer, "  GPIO mask        : 0x%x\n", ice->eeprom.gpiomask);
-       snd_iprintf(buffer, "  GPIO state       : 0x%x\n", ice->eeprom.gpiostate);
+       snd_iprintf(buffer, "  System Config    : 0x%x\n",
+                   ice->eeprom.data[ICE_EEP2_SYSCONF]);
+       snd_iprintf(buffer, "  ACLink           : 0x%x\n",
+                   ice->eeprom.data[ICE_EEP2_ACLINK]);
+       snd_iprintf(buffer, "  I2S              : 0x%x\n",
+                   ice->eeprom.data[ICE_EEP2_I2S]);
+       snd_iprintf(buffer, "  S/PDIF           : 0x%x\n",
+                   ice->eeprom.data[ICE_EEP2_SPDIF]);
+       snd_iprintf(buffer, "  GPIO direction   : 0x%x\n",
+                   ice->eeprom.gpiodir);
+       snd_iprintf(buffer, "  GPIO mask        : 0x%x\n",
+                   ice->eeprom.gpiomask);
+       snd_iprintf(buffer, "  GPIO state       : 0x%x\n",
+                   ice->eeprom.gpiostate);
        for (idx = 0x12; idx < ice->eeprom.size; idx++)
-               snd_iprintf(buffer, "  Extra #%02i        : 0x%x\n", idx, ice->eeprom.data[idx]);
+               snd_iprintf(buffer, "  Extra #%02i        : 0x%x\n",
+                           idx, ice->eeprom.data[idx]);
 
        snd_iprintf(buffer, "\nRegisters:\n");
 
-       snd_iprintf(buffer, "  PSDOUT03 : 0x%08x\n", (unsigned)inl(ICEMT1724(ice, ROUTE_PLAYBACK)));
+       snd_iprintf(buffer, "  PSDOUT03 : 0x%08x\n",
+                   (unsigned)inl(ICEMT1724(ice, ROUTE_PLAYBACK)));
        for (idx = 0x0; idx < 0x20 ; idx++)
-               snd_iprintf(buffer, "  CCS%02x    : 0x%02x\n", idx, inb(ice->port+idx));
+               snd_iprintf(buffer, "  CCS%02x    : 0x%02x\n",
+                           idx, inb(ice->port+idx));
        for (idx = 0x0; idx < 0x30 ; idx++)
-               snd_iprintf(buffer, "  MT%02x     : 0x%02x\n", idx, inb(ice->profi_port+idx));
+               snd_iprintf(buffer, "  MT%02x     : 0x%02x\n",
+                           idx, inb(ice->profi_port+idx));
 }
 
-static void __devinit snd_vt1724_proc_init(ice1712_t * ice)
+static void __devinit snd_vt1724_proc_init(struct snd_ice1712 * ice)
 {
-       snd_info_entry_t *entry;
+       struct snd_info_entry *entry;
 
        if (! snd_card_proc_new(ice->card, "ice1724", &entry))
                snd_info_set_text_ops(entry, ice, 1024, snd_vt1724_proc_read);
@@ -1221,22 +1300,24 @@ static void __devinit snd_vt1724_proc_init(ice1712_t * ice)
  *
  */
 
-static int snd_vt1724_eeprom_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_vt1724_eeprom_info(struct snd_kcontrol *kcontrol,
+                                 struct snd_ctl_elem_info *uinfo)
 {
        uinfo->type = SNDRV_CTL_ELEM_TYPE_BYTES;
-       uinfo->count = sizeof(ice1712_eeprom_t);
+       uinfo->count = sizeof(struct snd_ice1712_eeprom);
        return 0;
 }
 
-static int snd_vt1724_eeprom_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_vt1724_eeprom_get(struct snd_kcontrol *kcontrol,
+                                struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        
        memcpy(ucontrol->value.bytes.data, &ice->eeprom, sizeof(ice->eeprom));
        return 0;
 }
 
-static snd_kcontrol_new_t snd_vt1724_eeprom __devinitdata = {
+static struct snd_kcontrol_new snd_vt1724_eeprom __devinitdata = {
        .iface = SNDRV_CTL_ELEM_IFACE_CARD,
        .name = "ICE1724 EEPROM",
        .access = SNDRV_CTL_ELEM_ACCESS_READ,
@@ -1246,36 +1327,49 @@ static snd_kcontrol_new_t snd_vt1724_eeprom __devinitdata = {
 
 /*
  */
-static int snd_vt1724_spdif_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_vt1724_spdif_info(struct snd_kcontrol *kcontrol,
+                                struct snd_ctl_elem_info *uinfo)
 {
        uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
        uinfo->count = 1;
        return 0;
 }
 
-static unsigned int encode_spdif_bits(snd_aes_iec958_t *diga)
+static unsigned int encode_spdif_bits(struct snd_aes_iec958 *diga)
 {
-       unsigned int val;
+       unsigned int val, rbits;
 
        val = diga->status[0] & 0x03; /* professional, non-audio */
        if (val & 0x01) {
                /* professional */
-               if ((diga->status[0] & IEC958_AES0_PRO_EMPHASIS) == IEC958_AES0_PRO_EMPHASIS_5015)
+               if ((diga->status[0] & IEC958_AES0_PRO_EMPHASIS) ==
+                   IEC958_AES0_PRO_EMPHASIS_5015)
                        val |= 1U << 3;
-               switch (diga->status[0] & IEC958_AES0_PRO_FS) {
-               case IEC958_AES0_PRO_FS_44100:
-                       break;
-               case IEC958_AES0_PRO_FS_32000:
-                       val |= 3U << 12;
-                       break;
-               default:
-                       val |= 2U << 12;
-                       break;
+               rbits = (diga->status[4] >> 3) & 0x0f;
+               if (rbits) {
+                       switch (rbits) {
+                       case 2: val |= 5 << 12; break; /* 96k */
+                       case 3: val |= 6 << 12; break; /* 192k */
+                       case 10: val |= 4 << 12; break; /* 88.2k */
+                       case 11: val |= 7 << 12; break; /* 176.4k */
+                       }
+               } else {
+                       switch (diga->status[0] & IEC958_AES0_PRO_FS) {
+                       case IEC958_AES0_PRO_FS_44100:
+                               break;
+                       case IEC958_AES0_PRO_FS_32000:
+                               val |= 3U << 12;
+                               break;
+                       default:
+                               val |= 2U << 12;
+                               break;
+                       }
                }
        } else {
                /* consumer */
-               val |= diga->status[0] & 0x04; /* copyright */
-               if ((diga->status[0] & IEC958_AES0_CON_EMPHASIS)== IEC958_AES0_CON_EMPHASIS_5015)
+               val |= diga->status[1] & 0x04; /* copyright */
+               if ((diga->status[0] & IEC958_AES0_CON_EMPHASIS) ==
+                   IEC958_AES0_CON_EMPHASIS_5015)
                        val |= 1U << 3;
                val |= (unsigned int)(diga->status[1] & 0x3f) << 4; /* category */
                val |= (unsigned int)(diga->status[3] & IEC958_AES3_CON_FS) << 12; /* fs */
@@ -1283,7 +1377,7 @@ static unsigned int encode_spdif_bits(snd_aes_iec958_t *diga)
        return val;
 }
 
-static void decode_spdif_bits(snd_aes_iec958_t *diga, unsigned int val)
+static void decode_spdif_bits(struct snd_aes_iec958 *diga, unsigned int val)
 {
        memset(diga->status, 0, sizeof(diga->status));
        diga->status[0] = val & 0x03; /* professional, non-audio */
@@ -1311,41 +1405,32 @@ static void decode_spdif_bits(snd_aes_iec958_t *diga, unsigned int val)
        }
 }
 
-static int snd_vt1724_spdif_default_get(snd_kcontrol_t * kcontrol,
-                                       snd_ctl_elem_value_t * ucontrol)
+static int snd_vt1724_spdif_default_get(struct snd_kcontrol *kcontrol,
+                                       struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        unsigned int val;
        val = inw(ICEMT1724(ice, SPDIF_CTRL));
        decode_spdif_bits(&ucontrol->value.iec958, val);
        return 0;
 }
 
-static int snd_vt1724_spdif_default_put(snd_kcontrol_t * kcontrol,
-                                        snd_ctl_elem_value_t * ucontrol)
+static int snd_vt1724_spdif_default_put(struct snd_kcontrol *kcontrol,
+                                        struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        unsigned int val, old;
-       unsigned long flags;
 
        val = encode_spdif_bits(&ucontrol->value.iec958);
-       spin_lock_irqsave(&ice->reg_lock, flags);
+       spin_lock_irq(&ice->reg_lock);
        old = inw(ICEMT1724(ice, SPDIF_CTRL));
-       if (val != old) {
-               unsigned char cbit, disabled;
-               cbit = inb(ICEREG1724(ice, SPDIF_CFG));
-               disabled = cbit & ~VT1724_CFG_SPDIF_OUT_EN;
-               if (cbit != disabled)
-                       outb(disabled, ICEREG1724(ice, SPDIF_CFG));
-               outw(val, ICEMT1724(ice, SPDIF_CTRL));
-               if (cbit != disabled)
-                       outb(cbit, ICEREG1724(ice, SPDIF_CFG));
-       }
-       spin_unlock_irqrestore(&ice->reg_lock, flags);
+       if (val != old)
+               update_spdif_bits(ice, val);
+       spin_unlock_irq(&ice->reg_lock);
        return (val != old);
 }
 
-static snd_kcontrol_new_t snd_vt1724_spdif_default __devinitdata =
+static struct snd_kcontrol_new snd_vt1724_spdif_default __devinitdata =
 {
        .iface =        SNDRV_CTL_ELEM_IFACE_PCM,
        .name =         SNDRV_CTL_NAME_IEC958("",PLAYBACK,DEFAULT),
@@ -1354,8 +1439,8 @@ static snd_kcontrol_new_t snd_vt1724_spdif_default __devinitdata =
        .put =          snd_vt1724_spdif_default_put
 };
 
-static int snd_vt1724_spdif_maskc_get(snd_kcontrol_t * kcontrol,
-                                      snd_ctl_elem_value_t * ucontrol)
+static int snd_vt1724_spdif_maskc_get(struct snd_kcontrol *kcontrol,
+                                      struct snd_ctl_elem_value *ucontrol)
 {
        ucontrol->value.iec958.status[0] = IEC958_AES0_NONAUDIO |
                                                     IEC958_AES0_PROFESSIONAL |
@@ -1367,8 +1452,8 @@ static int snd_vt1724_spdif_maskc_get(snd_kcontrol_t * kcontrol,
        return 0;
 }
 
-static int snd_vt1724_spdif_maskp_get(snd_kcontrol_t * kcontrol,
-                                      snd_ctl_elem_value_t * ucontrol)
+static int snd_vt1724_spdif_maskp_get(struct snd_kcontrol *kcontrol,
+                                      struct snd_ctl_elem_value *ucontrol)
 {
        ucontrol->value.iec958.status[0] = IEC958_AES0_NONAUDIO |
                                                     IEC958_AES0_PROFESSIONAL |
@@ -1377,25 +1462,26 @@ static int snd_vt1724_spdif_maskp_get(snd_kcontrol_t * kcontrol,
        return 0;
 }
 
-static snd_kcontrol_new_t snd_vt1724_spdif_maskc __devinitdata =
+static struct snd_kcontrol_new snd_vt1724_spdif_maskc __devinitdata =
 {
        .access =       SNDRV_CTL_ELEM_ACCESS_READ,
-       .iface =        SNDRV_CTL_ELEM_IFACE_MIXER,
+       .iface =        SNDRV_CTL_ELEM_IFACE_PCM,
        .name =         SNDRV_CTL_NAME_IEC958("",PLAYBACK,CON_MASK),
        .info =         snd_vt1724_spdif_info,
        .get =          snd_vt1724_spdif_maskc_get,
 };
 
-static snd_kcontrol_new_t snd_vt1724_spdif_maskp __devinitdata =
+static struct snd_kcontrol_new snd_vt1724_spdif_maskp __devinitdata =
 {
        .access =       SNDRV_CTL_ELEM_ACCESS_READ,
-       .iface =        SNDRV_CTL_ELEM_IFACE_MIXER,
+       .iface =        SNDRV_CTL_ELEM_IFACE_PCM,
        .name =         SNDRV_CTL_NAME_IEC958("",PLAYBACK,PRO_MASK),
        .info =         snd_vt1724_spdif_info,
        .get =          snd_vt1724_spdif_maskp_get,
 };
 
-static int snd_vt1724_spdif_sw_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_vt1724_spdif_sw_info(struct snd_kcontrol *kcontrol,
+                                   struct snd_ctl_elem_info *uinfo)
 {
        uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
        uinfo->count = 1;
@@ -1404,35 +1490,38 @@ static int snd_vt1724_spdif_sw_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_
        return 0;
 }
 
-static int snd_vt1724_spdif_sw_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_vt1724_spdif_sw_get(struct snd_kcontrol *kcontrol,
+                                  struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
-       ucontrol->value.integer.value[0] = inb(ICEREG1724(ice, SPDIF_CFG)) & VT1724_CFG_SPDIF_OUT_EN ? 1 : 0;
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
+       ucontrol->value.integer.value[0] = inb(ICEREG1724(ice, SPDIF_CFG)) &
+               VT1724_CFG_SPDIF_OUT_EN ? 1 : 0;
        return 0;
 }
 
-static int snd_vt1724_spdif_sw_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_vt1724_spdif_sw_put(struct snd_kcontrol *kcontrol,
+                                  struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        unsigned char old, val;
-       unsigned long flags;
-       spin_lock_irqsave(&ice->reg_lock, flags);
+
+       spin_lock_irq(&ice->reg_lock);
        old = val = inb(ICEREG1724(ice, SPDIF_CFG));
        val &= ~VT1724_CFG_SPDIF_OUT_EN;
        if (ucontrol->value.integer.value[0])
                val |= VT1724_CFG_SPDIF_OUT_EN;
        if (old != val)
                outb(val, ICEREG1724(ice, SPDIF_CFG));
-       spin_unlock_irqrestore(&ice->reg_lock, flags);
+       spin_unlock_irq(&ice->reg_lock);
        return old != val;
 }
 
-static snd_kcontrol_new_t snd_vt1724_spdif_switch __devinitdata =
+static struct snd_kcontrol_new snd_vt1724_spdif_switch __devinitdata =
 {
        .iface =        SNDRV_CTL_ELEM_IFACE_MIXER,
        /* FIXME: the following conflict with IEC958 Playback Route */
        // .name =         SNDRV_CTL_NAME_IEC958("",PLAYBACK,SWITCH),
-       .name =         "IEC958 Output Switch",
+       .name =         SNDRV_CTL_NAME_IEC958("Output ",NONE,SWITCH),
        .info =         snd_vt1724_spdif_sw_info,
        .get =          snd_vt1724_spdif_sw_get,
        .put =          snd_vt1724_spdif_sw_put
@@ -1444,7 +1533,8 @@ static snd_kcontrol_new_t snd_vt1724_spdif_switch __devinitdata =
  * GPIO access from extern
  */
 
-int snd_vt1724_gpio_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+int snd_vt1724_gpio_info(struct snd_kcontrol *kcontrol,
+                        struct snd_ctl_elem_info *uinfo)
 {
        uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
        uinfo->count = 1;
@@ -1453,21 +1543,24 @@ int snd_vt1724_gpio_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
        return 0;
 }
 
-int snd_vt1724_gpio_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+int snd_vt1724_gpio_get(struct snd_kcontrol *kcontrol,
+                       struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        int shift = kcontrol->private_value & 0xff;
        int invert = (kcontrol->private_value & (1<<24)) ? 1 : 0;
        
        snd_ice1712_save_gpio_status(ice);
-       ucontrol->value.integer.value[0] = (snd_ice1712_gpio_read(ice) & (1 << shift) ? 1 : 0) ^ invert;
+       ucontrol->value.integer.value[0] =
+               (snd_ice1712_gpio_read(ice) & (1 << shift) ? 1 : 0) ^ invert;
        snd_ice1712_restore_gpio_status(ice);
        return 0;
 }
 
-int snd_ice1712_gpio_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+int snd_ice1712_gpio_put(struct snd_kcontrol *kcontrol,
+                        struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        int shift = kcontrol->private_value & 0xff;
        int invert = (kcontrol->private_value & (1<<24)) ? mask : 0;
        unsigned int val, nval;
@@ -1488,9 +1581,10 @@ int snd_ice1712_gpio_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucont
 /*
  *  rate
  */
-static int snd_vt1724_pro_internal_clock_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_vt1724_pro_internal_clock_info(struct snd_kcontrol *kcontrol,
+                                             struct snd_ctl_elem_info *uinfo)
 {
-       static char *texts[] = {
+       static char *texts_1724[] = {
                "8000",         /* 0: 6 */
                "9600",         /* 1: 3 */
                "11025",        /* 2: 10 */
@@ -1508,18 +1602,39 @@ static int snd_vt1724_pro_internal_clock_info(snd_kcontrol_t *kcontrol, snd_ctl_
                "192000",       /* 14: 14 */
                "IEC958 Input", /* 15: -- */
        };
+       static char *texts_1720[] = {
+               "8000",         /* 0: 6 */
+               "9600",         /* 1: 3 */
+               "11025",        /* 2: 10 */
+               "12000",        /* 3: 2 */
+               "16000",        /* 4: 5 */
+               "22050",        /* 5: 9 */
+               "24000",        /* 6: 1 */
+               "32000",        /* 7: 4 */
+               "44100",        /* 8: 8 */
+               "48000",        /* 9: 0 */
+               "64000",        /* 10: 15 */
+               "88200",        /* 11: 11 */
+               "96000",        /* 12: 7 */
+               "IEC958 Input", /* 13: -- */
+       };
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
+
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
-       uinfo->value.enumerated.items = 16;
+       uinfo->value.enumerated.items = ice->vt1720 ? 14 : 16;
        if (uinfo->value.enumerated.item >= uinfo->value.enumerated.items)
                uinfo->value.enumerated.item = uinfo->value.enumerated.items - 1;
-       strcpy(uinfo->value.enumerated.name, texts[uinfo->value.enumerated.item]);
+       strcpy(uinfo->value.enumerated.name,
+              ice->vt1720 ? texts_1720[uinfo->value.enumerated.item] :
+              texts_1724[uinfo->value.enumerated.item]);
        return 0;
 }
 
-static int snd_vt1724_pro_internal_clock_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_vt1724_pro_internal_clock_get(struct snd_kcontrol *kcontrol,
+                                            struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        static unsigned char xlate[16] = {
                9, 6, 3, 1, 7, 4, 0, 12, 8, 5, 2, 11, 13, 255, 14, 10
        };
@@ -1527,7 +1642,7 @@ static int snd_vt1724_pro_internal_clock_get(snd_kcontrol_t * kcontrol, snd_ctl_
        
        spin_lock_irq(&ice->reg_lock);
        if (is_spdif_master(ice)) {
-               ucontrol->value.enumerated.item[0] = 15;
+               ucontrol->value.enumerated.item[0] = ice->vt1720 ? 13 : 15;
        } else {
                val = xlate[inb(ICEMT1724(ice, RATE)) & 15];
                if (val == 255) {
@@ -1540,26 +1655,33 @@ static int snd_vt1724_pro_internal_clock_get(snd_kcontrol_t * kcontrol, snd_ctl_
        return 0;
 }
 
-static int snd_vt1724_pro_internal_clock_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_vt1724_pro_internal_clock_put(struct snd_kcontrol *kcontrol,
+                                            struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        unsigned char oval;
+       int rate;
        int change = 0;
+       int spdif = ice->vt1720 ? 13 : 15;
 
        spin_lock_irq(&ice->reg_lock);
        oval = inb(ICEMT1724(ice, RATE));
-       if (ucontrol->value.enumerated.item[0] == 15) {
+       if (ucontrol->value.enumerated.item[0] == spdif) {
                outb(oval | VT1724_SPDIF_MASTER, ICEMT1724(ice, RATE));
        } else {
-               PRO_RATE_DEFAULT = rates[ucontrol->value.integer.value[0] % 15];
-               spin_unlock_irq(&ice->reg_lock);
-               snd_vt1724_set_pro_rate(ice, PRO_RATE_DEFAULT, 1);
-               spin_lock_irq(&ice->reg_lock);
+               rate = rates[ucontrol->value.integer.value[0] % 15];
+               if (rate <= get_max_rate(ice)) {
+                       PRO_RATE_DEFAULT = rate;
+                       spin_unlock_irq(&ice->reg_lock);
+                       snd_vt1724_set_pro_rate(ice, PRO_RATE_DEFAULT, 1);
+                       spin_lock_irq(&ice->reg_lock);
+               }
        }
        change = inb(ICEMT1724(ice, RATE)) != oval;
        spin_unlock_irq(&ice->reg_lock);
 
-       if ((oval & VT1724_SPDIF_MASTER) != (inb(ICEMT1724(ice, RATE)) & VT1724_SPDIF_MASTER)) {
+       if ((oval & VT1724_SPDIF_MASTER) !=
+           (inb(ICEMT1724(ice, RATE)) & VT1724_SPDIF_MASTER)) {
                /* notify akm chips as well */
                if (is_spdif_master(ice)) {
                        unsigned int i;
@@ -1572,7 +1694,7 @@ static int snd_vt1724_pro_internal_clock_put(snd_kcontrol_t * kcontrol, snd_ctl_
        return change;
 }
 
-static snd_kcontrol_new_t snd_vt1724_pro_internal_clock __devinitdata = {
+static struct snd_kcontrol_new snd_vt1724_pro_internal_clock __devinitdata = {
        .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
        .name = "Multi Track Internal Clock",
        .info = snd_vt1724_pro_internal_clock_info,
@@ -1580,7 +1702,8 @@ static snd_kcontrol_new_t snd_vt1724_pro_internal_clock __devinitdata = {
        .put = snd_vt1724_pro_internal_clock_put
 };
 
-static int snd_vt1724_pro_rate_locking_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_vt1724_pro_rate_locking_info(struct snd_kcontrol *kcontrol,
+                                           struct snd_ctl_elem_info *uinfo)
 {
        uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
        uinfo->count = 1;
@@ -1589,15 +1712,17 @@ static int snd_vt1724_pro_rate_locking_info(snd_kcontrol_t *kcontrol, snd_ctl_el
        return 0;
 }
 
-static int snd_vt1724_pro_rate_locking_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_vt1724_pro_rate_locking_get(struct snd_kcontrol *kcontrol,
+                                          struct snd_ctl_elem_value *ucontrol)
 {
        ucontrol->value.integer.value[0] = PRO_RATE_LOCKED;
        return 0;
 }
 
-static int snd_vt1724_pro_rate_locking_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_vt1724_pro_rate_locking_put(struct snd_kcontrol *kcontrol,
+                                          struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        int change = 0, nval;
 
        nval = ucontrol->value.integer.value[0] ? 1 : 0;
@@ -1608,7 +1733,7 @@ static int snd_vt1724_pro_rate_locking_put(snd_kcontrol_t * kcontrol, snd_ctl_el
        return change;
 }
 
-static snd_kcontrol_new_t snd_vt1724_pro_rate_locking __devinitdata = {
+static struct snd_kcontrol_new snd_vt1724_pro_rate_locking __devinitdata = {
        .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
        .name = "Multi Track Rate Locking",
        .info = snd_vt1724_pro_rate_locking_info,
@@ -1616,7 +1741,8 @@ static snd_kcontrol_new_t snd_vt1724_pro_rate_locking __devinitdata = {
        .put = snd_vt1724_pro_rate_locking_put
 };
 
-static int snd_vt1724_pro_rate_reset_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_vt1724_pro_rate_reset_info(struct snd_kcontrol *kcontrol,
+                                         struct snd_ctl_elem_info *uinfo)
 {
        uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
        uinfo->count = 1;
@@ -1625,15 +1751,17 @@ static int snd_vt1724_pro_rate_reset_info(snd_kcontrol_t *kcontrol, snd_ctl_elem
        return 0;
 }
 
-static int snd_vt1724_pro_rate_reset_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_vt1724_pro_rate_reset_get(struct snd_kcontrol *kcontrol,
+                                        struct snd_ctl_elem_value *ucontrol)
 {
        ucontrol->value.integer.value[0] = PRO_RATE_RESET ? 1 : 0;
        return 0;
 }
 
-static int snd_vt1724_pro_rate_reset_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_vt1724_pro_rate_reset_put(struct snd_kcontrol *kcontrol,
+                                        struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        int change = 0, nval;
 
        nval = ucontrol->value.integer.value[0] ? 1 : 0;
@@ -1644,7 +1772,7 @@ static int snd_vt1724_pro_rate_reset_put(snd_kcontrol_t * kcontrol, snd_ctl_elem
        return change;
 }
 
-static snd_kcontrol_new_t snd_vt1724_pro_rate_reset __devinitdata = {
+static struct snd_kcontrol_new snd_vt1724_pro_rate_reset __devinitdata = {
        .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
        .name = "Multi Track Rate Reset",
        .info = snd_vt1724_pro_rate_reset_info,
@@ -1656,7 +1784,8 @@ static snd_kcontrol_new_t snd_vt1724_pro_rate_reset __devinitdata = {
 /*
  * routing
  */
-static int snd_vt1724_pro_route_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_vt1724_pro_route_info(struct snd_kcontrol *kcontrol,
+                                    struct snd_ctl_elem_info *uinfo)
 {
        static char *texts[] = {
                "PCM Out", /* 0 */
@@ -1683,7 +1812,7 @@ static inline int digital_route_shift(int idx)
        return idx * 3;
 }
 
-static int get_route_val(ice1712_t *ice, int shift)
+static int get_route_val(struct snd_ice1712 *ice, int shift)
 {
        unsigned long val;
        unsigned char eitem;
@@ -1702,7 +1831,7 @@ static int get_route_val(ice1712_t *ice, int shift)
        return eitem;
 }
 
-static int put_route_val(ice1712_t *ice, unsigned int val, int shift)
+static int put_route_val(struct snd_ice1712 *ice, unsigned int val, int shift)
 {
        unsigned int old_val, nval;
        int change;
@@ -1724,39 +1853,45 @@ static int put_route_val(ice1712_t *ice, unsigned int val, int shift)
        return change;
 }
 
-static int snd_vt1724_pro_route_analog_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t *ucontrol)
+static int snd_vt1724_pro_route_analog_get(struct snd_kcontrol *kcontrol,
+                                          struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        int idx = snd_ctl_get_ioffidx(kcontrol, &ucontrol->id);
-       ucontrol->value.enumerated.item[0] = get_route_val(ice, analog_route_shift(idx));
+       ucontrol->value.enumerated.item[0] =
+               get_route_val(ice, analog_route_shift(idx));
        return 0;
 }
 
-static int snd_vt1724_pro_route_analog_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t *ucontrol)
+static int snd_vt1724_pro_route_analog_put(struct snd_kcontrol *kcontrol,
+                                          struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        int idx = snd_ctl_get_ioffidx(kcontrol, &ucontrol->id);
        return put_route_val(ice, ucontrol->value.enumerated.item[0],
                             analog_route_shift(idx));
 }
 
-static int snd_vt1724_pro_route_spdif_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t *ucontrol)
+static int snd_vt1724_pro_route_spdif_get(struct snd_kcontrol *kcontrol,
+                                         struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        int idx = snd_ctl_get_ioffidx(kcontrol, &ucontrol->id);
-       ucontrol->value.enumerated.item[0] = get_route_val(ice, digital_route_shift(idx));
+       ucontrol->value.enumerated.item[0] =
+               get_route_val(ice, digital_route_shift(idx));
        return 0;
 }
 
-static int snd_vt1724_pro_route_spdif_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t *ucontrol)
+static int snd_vt1724_pro_route_spdif_put(struct snd_kcontrol *kcontrol,
+                                         struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        int idx = snd_ctl_get_ioffidx(kcontrol, &ucontrol->id);
        return put_route_val(ice, ucontrol->value.enumerated.item[0],
                             digital_route_shift(idx));
 }
 
-static snd_kcontrol_new_t snd_vt1724_mixer_pro_analog_route __devinitdata = {
+static struct snd_kcontrol_new snd_vt1724_mixer_pro_analog_route __devinitdata = {
        .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
        .name = "H/W Playback Route",
        .info = snd_vt1724_pro_route_info,
@@ -1764,9 +1899,9 @@ static snd_kcontrol_new_t snd_vt1724_mixer_pro_analog_route __devinitdata = {
        .put = snd_vt1724_pro_route_analog_put,
 };
 
-static snd_kcontrol_new_t snd_vt1724_mixer_pro_spdif_route __devinitdata = {
+static struct snd_kcontrol_new snd_vt1724_mixer_pro_spdif_route __devinitdata = {
        .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
-       .name = "IEC958 Playback Route",
+       .name = SNDRV_CTL_NAME_IEC958("",PLAYBACK,NONE) "Route",
        .info = snd_vt1724_pro_route_info,
        .get = snd_vt1724_pro_route_spdif_get,
        .put = snd_vt1724_pro_route_spdif_put,
@@ -1774,7 +1909,8 @@ static snd_kcontrol_new_t snd_vt1724_mixer_pro_spdif_route __devinitdata = {
 };
 
 
-static int snd_vt1724_pro_peak_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+static int snd_vt1724_pro_peak_info(struct snd_kcontrol *kcontrol,
+                                   struct snd_ctl_elem_info *uinfo)
 {
        uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
        uinfo->count = 22; /* FIXME: for compatibility with ice1712... */
@@ -1783,21 +1919,23 @@ static int snd_vt1724_pro_peak_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_
        return 0;
 }
 
-static int snd_vt1724_pro_peak_get(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+static int snd_vt1724_pro_peak_get(struct snd_kcontrol *kcontrol,
+                                  struct snd_ctl_elem_value *ucontrol)
 {
-       ice1712_t *ice = snd_kcontrol_chip(kcontrol);
+       struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
        int idx;
        
        spin_lock_irq(&ice->reg_lock);
        for (idx = 0; idx < 22; idx++) {
                outb(idx, ICEMT1724(ice, MONITOR_PEAKINDEX));
-               ucontrol->value.integer.value[idx] = inb(ICEMT1724(ice, MONITOR_PEAKDATA));
+               ucontrol->value.integer.value[idx] =
+                       inb(ICEMT1724(ice, MONITOR_PEAKDATA));
        }
        spin_unlock_irq(&ice->reg_lock);
        return 0;
 }
 
-static snd_kcontrol_new_t snd_vt1724_mixer_pro_peak __devinitdata = {
+static struct snd_kcontrol_new snd_vt1724_mixer_pro_peak __devinitdata = {
        .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
        .name = "Multi Track Peak",
        .access = SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE,
@@ -1815,6 +1953,11 @@ static struct snd_ice1712_card_info *card_tables[] __devinitdata = {
        snd_vt1724_revo_cards,
        snd_vt1724_amp_cards, 
        snd_vt1724_aureon_cards,
+       snd_vt1720_mobo_cards,
+       snd_vt1720_pontis_cards,
+       snd_vt1724_prodigy192_cards,
+       snd_vt1724_juli_cards,
+       snd_vt1724_phase_cards,
        NULL,
 };
 
@@ -1822,27 +1965,45 @@ static struct snd_ice1712_card_info *card_tables[] __devinitdata = {
 /*
  */
 
-unsigned char snd_vt1724_read_i2c(ice1712_t *ice, unsigned char dev, unsigned char addr)
+static void wait_i2c_busy(struct snd_ice1712 *ice)
+{
+       int t = 0x10000;
+       while ((inb(ICEREG1724(ice, I2C_CTRL)) & VT1724_I2C_BUSY) && t--)
+               ;
+       if (t == -1)
+               printk(KERN_ERR "ice1724: i2c busy timeout\n");
+}
+
+unsigned char snd_vt1724_read_i2c(struct snd_ice1712 *ice,
+                                 unsigned char dev, unsigned char addr)
 {
-       long t = 0x10000;
+       unsigned char val;
 
+       mutex_lock(&ice->i2c_mutex);
        outb(addr, ICEREG1724(ice, I2C_BYTE_ADDR));
        outb(dev & ~VT1724_I2C_WRITE, ICEREG1724(ice, I2C_DEV_ADDR));
-       while (t-- > 0 && (inb(ICEREG1724(ice, I2C_CTRL)) & VT1724_I2C_BUSY)) ;
-       return inb(ICEREG1724(ice, I2C_DATA));
+       wait_i2c_busy(ice);
+       val = inb(ICEREG1724(ice, I2C_DATA));
+       mutex_unlock(&ice->i2c_mutex);
+       //printk("i2c_read: [0x%x,0x%x] = 0x%x\n", dev, addr, val);
+       return val;
 }
 
-void snd_vt1724_write_i2c(ice1712_t *ice, unsigned char dev, unsigned char addr, unsigned char data)
+void snd_vt1724_write_i2c(struct snd_ice1712 *ice,
+                         unsigned char dev, unsigned char addr, unsigned char data)
 {
-       long t = 0x10000;
-
+       mutex_lock(&ice->i2c_mutex);
+       wait_i2c_busy(ice);
+       //printk("i2c_write: [0x%x,0x%x] = 0x%x\n", dev, addr, data);
        outb(addr, ICEREG1724(ice, I2C_BYTE_ADDR));
        outb(data, ICEREG1724(ice, I2C_DATA));
        outb(dev | VT1724_I2C_WRITE, ICEREG1724(ice, I2C_DEV_ADDR));
-       while (t-- > 0 && (inb(ICEREG1724(ice, I2C_CTRL)) & VT1724_I2C_BUSY)) ;
+       wait_i2c_busy(ice);
+       mutex_unlock(&ice->i2c_mutex);
 }
 
-static int __devinit snd_vt1724_read_eeprom(ice1712_t *ice, const char *modelname)
+static int __devinit snd_vt1724_read_eeprom(struct snd_ice1712 *ice,
+                                           const char *modelname)
 {
        const int dev = 0xa0;           /* EEPROM device address */
        unsigned int i, size;
@@ -1851,17 +2012,24 @@ static int __devinit snd_vt1724_read_eeprom(ice1712_t *ice, const char *modelnam
        if (! modelname || ! *modelname) {
                ice->eeprom.subvendor = 0;
                if ((inb(ICEREG1724(ice, I2C_CTRL)) & VT1724_I2C_EEPROM) != 0)
-                       ice->eeprom.subvendor = (snd_vt1724_read_i2c(ice, dev, 0x00) << 0) |
+                       ice->eeprom.subvendor =
+                               (snd_vt1724_read_i2c(ice, dev, 0x00) << 0) |
                                (snd_vt1724_read_i2c(ice, dev, 0x01) << 8) | 
                                (snd_vt1724_read_i2c(ice, dev, 0x02) << 16) | 
                                (snd_vt1724_read_i2c(ice, dev, 0x03) << 24);
-               if (ice->eeprom.subvendor == 0 || ice->eeprom.subvendor == (unsigned int)-1) {
-                       /* invalid subvendor from EEPROM, try the PCI subststem ID instead */
+               if (ice->eeprom.subvendor == 0 ||
+                   ice->eeprom.subvendor == (unsigned int)-1) {
+                       /* invalid subvendor from EEPROM, try the PCI
+                        * subststem ID instead
+                        */
                        u16 vendor, device;
-                       pci_read_config_word(ice->pci, PCI_SUBSYSTEM_VENDOR_ID, &vendor);
+                       pci_read_config_word(ice->pci, PCI_SUBSYSTEM_VENDOR_ID,
+                                            &vendor);
                        pci_read_config_word(ice->pci, PCI_SUBSYSTEM_ID, &device);
-                       ice->eeprom.subvendor = ((unsigned int)swab16(vendor) << 16) | swab16(device);
-                       if (ice->eeprom.subvendor == 0 || ice->eeprom.subvendor == (unsigned int)-1) {
+                       ice->eeprom.subvendor =
+                               ((unsigned int)swab16(vendor) << 16) | swab16(device);
+                       if (ice->eeprom.subvendor == 0 ||
+                           ice->eeprom.subvendor == (unsigned int)-1) {
                                printk(KERN_ERR "ice1724: No valid ID is found\n");
                                return -ENXIO;
                        }
@@ -1869,8 +2037,10 @@ static int __devinit snd_vt1724_read_eeprom(ice1712_t *ice, const char *modelnam
        }
        for (tbl = card_tables; *tbl; tbl++) {
                for (c = *tbl; c->subvendor; c++) {
-                       if (modelname && c->model && ! strcmp(modelname, c->model)) {
-                               printk(KERN_INFO "ice1724: Using board model %s\n", c->name);
+                       if (modelname && c->model &&
+                           ! strcmp(modelname, c->model)) {
+                               printk(KERN_INFO "ice1724: Using board model %s\n",
+                                      c->name);
                                ice->eeprom.subvendor = c->subvendor;
                        } else if (c->subvendor != ice->eeprom.subvendor)
                                continue;
@@ -1884,19 +2054,22 @@ static int __devinit snd_vt1724_read_eeprom(ice1712_t *ice, const char *modelnam
                        goto read_skipped;
                }
        }
-       printk(KERN_WARNING "ice1724: No matching model found for ID 0x%x\n", ice->eeprom.subvendor);
+       printk(KERN_WARNING "ice1724: No matching model found for ID 0x%x\n",
+              ice->eeprom.subvendor);
 
  found:
        ice->eeprom.size = snd_vt1724_read_i2c(ice, dev, 0x04);
        if (ice->eeprom.size < 6)
                ice->eeprom.size = 32;
        else if (ice->eeprom.size > 32) {
-               printk(KERN_ERR "ice1724: Invalid EEPROM (size = %i)\n", ice->eeprom.size);
+               printk(KERN_ERR "ice1724: Invalid EEPROM (size = %i)\n",
+                      ice->eeprom.size);
                return -EIO;
        }
        ice->eeprom.version = snd_vt1724_read_i2c(ice, dev, 0x05);
        if (ice->eeprom.version != 2)
-               printk(KERN_WARNING "ice1724: Invalid EEPROM version %i\n", ice->eeprom.version);
+               printk(KERN_WARNING "ice1724: Invalid EEPROM version %i\n",
+                      ice->eeprom.version);
        size = ice->eeprom.size - 6;
        for (i = 0; i < size; i++)
                ice->eeprom.data[i] = snd_vt1724_read_i2c(ice, dev, i + 6);
@@ -1911,7 +2084,7 @@ static int __devinit snd_vt1724_read_eeprom(ice1712_t *ice, const char *modelnam
 
 
 
-static int __devinit snd_vt1724_chip_init(ice1712_t *ice)
+static int __devinit snd_vt1724_chip_init(struct snd_ice1712 *ice)
 {
        outb(VT1724_RESET , ICEREG1724(ice, CONTROL));
        udelay(200);
@@ -1930,16 +2103,13 @@ static int __devinit snd_vt1724_chip_init(ice1712_t *ice)
 
        outb(0, ICEREG1724(ice, POWERDOWN));
 
-       /* read back to check the availability of SPDIF out */
-       ice->eeprom.data[ICE_EEP2_SPDIF] = inb(ICEREG1724(ice, SPDIF_CFG));
-
        return 0;
 }
 
-static int __devinit snd_vt1724_spdif_build_controls(ice1712_t *ice)
+static int __devinit snd_vt1724_spdif_build_controls(struct snd_ice1712 *ice)
 {
        int err;
-       snd_kcontrol_t *kctl;
+       struct snd_kcontrol *kctl;
 
        snd_assert(ice->pcm != NULL, return -EIO);
 
@@ -1974,7 +2144,7 @@ static int __devinit snd_vt1724_spdif_build_controls(ice1712_t *ice)
 }
 
 
-static int __devinit snd_vt1724_build_controls(ice1712_t *ice)
+static int __devinit snd_vt1724_build_controls(struct snd_ice1712 *ice)
 {
        int err;
 
@@ -1993,11 +2163,10 @@ static int __devinit snd_vt1724_build_controls(ice1712_t *ice)
                return err;
 
        if (ice->num_total_dacs > 0) {
-               snd_kcontrol_new_t tmp = snd_vt1724_mixer_pro_analog_route;
-               if (ice->vt1720)
+               struct snd_kcontrol_new tmp = snd_vt1724_mixer_pro_analog_route;
+               tmp.count = ice->num_total_dacs;
+               if (ice->vt1720 && tmp.count > 2)
                        tmp.count = 2;
-               else
-                       tmp.count = ice->num_total_dacs;
                err = snd_ctl_add(ice->card, snd_ctl_new1(&tmp, ice));
                if (err < 0)
                        return err;
@@ -2010,9 +2179,9 @@ static int __devinit snd_vt1724_build_controls(ice1712_t *ice)
        return 0;
 }
 
-static int snd_vt1724_free(ice1712_t *ice)
+static int snd_vt1724_free(struct snd_ice1712 *ice)
 {
-       if (ice->res_port == NULL)
+       if (! ice->port)
                goto __hw_end;
        /* mask all interrupts */
        outb(0xff, ICEMT1724(ice, DMA_INT_MASK));
@@ -2021,36 +2190,30 @@ static int snd_vt1724_free(ice1712_t *ice)
       __hw_end:
        if (ice->irq >= 0) {
                synchronize_irq(ice->irq);
-               free_irq(ice->irq, (void *) ice);
-       }
-       if (ice->res_port) {
-               release_resource(ice->res_port);
-               kfree_nocheck(ice->res_port);
-       }
-       if (ice->res_profi_port) {
-               release_resource(ice->res_profi_port);
-               kfree_nocheck(ice->res_profi_port);
+               free_irq(ice->irq, ice);
        }
+       pci_release_regions(ice->pci);
        snd_ice1712_akm4xxx_free(ice);
-       snd_magic_kfree(ice);
+       pci_disable_device(ice->pci);
+       kfree(ice);
        return 0;
 }
 
-static int snd_vt1724_dev_free(snd_device_t *device)
+static int snd_vt1724_dev_free(struct snd_device *device)
 {
-       ice1712_t *ice = snd_magic_cast(ice1712_t, device->device_data, return -ENXIO);
+       struct snd_ice1712 *ice = device->device_data;
        return snd_vt1724_free(ice);
 }
 
-static int __devinit snd_vt1724_create(snd_card_t * card,
+static int __devinit snd_vt1724_create(struct snd_card *card,
                                       struct pci_dev *pci,
                                       const char *modelname,
-                                      ice1712_t ** r_ice1712)
+                                      struct snd_ice1712 ** r_ice1712)
 {
-       ice1712_t *ice;
+       struct snd_ice1712 *ice;
        int err;
        unsigned char mask;
-       static snd_device_ops_t ops = {
+       static struct snd_device_ops ops = {
                .dev_free =     snd_vt1724_dev_free,
        };
 
@@ -2060,13 +2223,16 @@ static int __devinit snd_vt1724_create(snd_card_t * card,
        if ((err = pci_enable_device(pci)) < 0)
                return err;
 
-       ice = snd_magic_kcalloc(ice1712_t, 0, GFP_KERNEL);
-       if (ice == NULL)
+       ice = kzalloc(sizeof(*ice), GFP_KERNEL);
+       if (ice == NULL) {
+               pci_disable_device(pci);
                return -ENOMEM;
+       }
        ice->vt1724 = 1;
        spin_lock_init(&ice->reg_lock);
-       init_MUTEX(&ice->gpio_mutex);
-       init_MUTEX(&ice->open_mutex);
+       mutex_init(&ice->gpio_mutex);
+       mutex_init(&ice->open_mutex);
+       mutex_init(&ice->i2c_mutex);
        ice->gpio.set_mask = snd_vt1724_set_gpio_mask;
        ice->gpio.set_dir = snd_vt1724_set_gpio_dir;
        ice->gpio.set_data = snd_vt1724_set_gpio_data;
@@ -2074,26 +2240,21 @@ static int __devinit snd_vt1724_create(snd_card_t * card,
        ice->card = card;
        ice->pci = pci;
        ice->irq = -1;
-       ice->port = pci_resource_start(pci, 0);
-       ice->profi_port = pci_resource_start(pci, 1);
        pci_set_master(pci);
        snd_vt1724_proc_init(ice);
        synchronize_irq(pci->irq);
 
-       if ((ice->res_port = request_region(ice->port, 32, "ICE1724 - Controller")) == NULL) {
-               snd_printk("unable to grab ports 0x%lx-0x%lx\n", ice->port, ice->port + 32 - 1);
-               snd_vt1724_free(ice);
-               return -EIO;
+       if ((err = pci_request_regions(pci, "ICE1724")) < 0) {
+               kfree(ice);
+               pci_disable_device(pci);
+               return err;
        }
+       ice->port = pci_resource_start(pci, 0);
+       ice->profi_port = pci_resource_start(pci, 1);
 
-       if ((ice->res_profi_port = request_region(ice->profi_port, 128, "ICE1724 - Professional")) == NULL) {
-               snd_printk("unable to grab ports 0x%lx-0x%lx\n", ice->profi_port, ice->profi_port + 16 - 1);
-               snd_vt1724_free(ice);
-               return -EIO;
-       }
-               
-       if (request_irq(pci->irq, snd_vt1724_interrupt, SA_INTERRUPT|SA_SHIRQ, "ICE1724", (void *) ice)) {
-               snd_printk("unable to grab IRQ %d\n", pci->irq);
+       if (request_irq(pci->irq, snd_vt1724_interrupt,
+                       SA_INTERRUPT|SA_SHIRQ, "ICE1724", ice)) {
+               snd_printk(KERN_ERR "unable to grab IRQ %d\n", pci->irq);
                snd_vt1724_free(ice);
                return -EIO;
        }
@@ -2115,7 +2276,9 @@ static int __devinit snd_vt1724_create(snd_card_t * card,
        else
                mask = 0;
        outb(mask, ICEREG1724(ice, IRQMASK));
-       /* don't handle FIFO overrun/underruns (just yet), since they cause machine lockups */
+       /* don't handle FIFO overrun/underruns (just yet),
+        * since they cause machine lockups
+        */
        outb(VT1724_MULTI_FIFO_ERR, ICEMT1724(ice, DMA_INT_MASK));
 
        if ((err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, ice, &ops)) < 0) {
@@ -2140,8 +2303,8 @@ static int __devinit snd_vt1724_probe(struct pci_dev *pci,
                                      const struct pci_device_id *pci_id)
 {
        static int dev;
-       snd_card_t *card;
-       ice1712_t *ice;
+       struct snd_card *card;
+       struct snd_ice1712 *ice;
        int pcm_dev = 0, err;
        struct snd_ice1712_card_info **tbl, *c;
 
@@ -2261,7 +2424,7 @@ static struct pci_driver driver = {
 
 static int __init alsa_card_ice1724_init(void)
 {
-       return pci_module_init(&driver);
+       return pci_register_driver(&driver);
 }
 
 static void __exit alsa_card_ice1724_exit(void)