Rename struct buffer to struct ofpbuf.
[sliver-openvswitch.git] / switch / table-hash.c
index 47bbe4a..175b840 100644 (file)
  * derivatives without specific, written prior permission.
  */
 
+#include <config.h>
 #include "table.h"
 #include <assert.h>
 #include <stdlib.h>
 #include <string.h>
 #include "crc32.h"
-#include "flow.h"
 #include "datapath.h"
+#include "flow.h"
+#include "switch-flow.h"
 
 struct sw_table_hash {
     struct sw_table swt;
@@ -51,7 +53,8 @@ static struct sw_flow **find_bucket(struct sw_table *swt,
                                     const struct sw_flow_key *key)
 {
     struct sw_table_hash *th = (struct sw_table_hash *) swt;
-    unsigned int crc = crc32_calculate(&th->crc32, key, sizeof *key);
+    unsigned int crc = crc32_calculate(&th->crc32, key, 
+            offsetof(struct sw_flow_key, wildcards));
     return &th->buckets[crc & th->bucket_mask];
 }
 
@@ -59,7 +62,7 @@ static struct sw_flow *table_hash_lookup(struct sw_table *swt,
                                          const struct sw_flow_key *key)
 {
     struct sw_flow *flow = *find_bucket(swt, key);
-    return flow && !memcmp(&flow->key, key, sizeof *key) ? flow : NULL;
+    return flow && !flow_compare(&flow->key.flow, &key->flow) ? flow : NULL;
 }
 
 static int table_hash_insert(struct sw_table *swt, struct sw_flow *flow)
@@ -78,7 +81,7 @@ static int table_hash_insert(struct sw_table *swt, struct sw_flow *flow)
         retval = 1;
     } else {
         struct sw_flow *old_flow = *bucket;
-        if (!memcmp(&old_flow->key, &flow->key, sizeof flow->key)) {
+        if (!flow_compare(&old_flow->key.flow, &flow->key.flow)) {
             *bucket = flow;
             flow_free(old_flow);
             retval = 1;
@@ -110,7 +113,7 @@ static int table_hash_delete(struct sw_table *swt,
     if (key->wildcards == 0) {
         struct sw_flow **bucket = find_bucket(swt, key);
         struct sw_flow *flow = *bucket;
-        if (flow && !memcmp(&flow->key, key, sizeof *key)) {
+        if (flow && !flow_compare(&flow->key.flow, &key->flow)) {
             do_delete(bucket);
             count = 1;
         }
@@ -159,56 +162,36 @@ static void table_hash_destroy(struct sw_table *swt)
     free(th);
 }
 
-struct swt_iterator_hash {
-    struct sw_table_hash *th;
-    unsigned int bucket_i;
-};
-
-static struct sw_flow *next_flow(struct swt_iterator_hash *ih)
+static int table_hash_iterate(struct sw_table *swt,
+                              const struct sw_flow_key *key,
+                              struct sw_table_position *position,
+                              int (*callback)(struct sw_flow *, void *private),
+                              void *private) 
 {
-    for (;ih->bucket_i <= ih->th->bucket_mask; ih->bucket_i++) {
-        struct sw_flow *f = ih->th->buckets[ih->bucket_i];
-        if (f != NULL)
-            return f;
-    }
-
-    return NULL;
-}
-
-static int table_hash_iterator(struct sw_table *swt,
-                               struct swt_iterator *swt_iter)
-{
-    struct swt_iterator_hash *ih;
-
-    swt_iter->private = ih = malloc(sizeof *ih);
+    struct sw_table_hash *th = (struct sw_table_hash *) swt;
 
-    if (ih == NULL)
+    if (position->private[0] > th->bucket_mask)
         return 0;
 
-    ih->th = (struct sw_table_hash *) swt;
-
-    ih->bucket_i = 0;
-    swt_iter->flow = next_flow(ih);
-
-    return 1;
-}
-
-static void table_hash_next(struct swt_iterator *swt_iter)
-{
-    struct swt_iterator_hash *ih;
-
-    if (swt_iter->flow == NULL)
-        return;
-
-    ih = (struct swt_iterator_hash *) swt_iter->private;
-
-    ih->bucket_i++;
-    swt_iter->flow = next_flow(ih);
-}
-
-static void table_hash_iterator_destroy(struct swt_iterator *swt_iter)
-{
-    free(swt_iter->private);
+    if (key->wildcards == 0) {
+        struct sw_flow *flow = table_hash_lookup(swt, key);
+        position->private[0] = -1;
+        return flow ? callback(flow, private) : 0;
+    } else {
+        int i;
+
+        for (i = position->private[0]; i <= th->bucket_mask; i++) {
+            struct sw_flow *flow = th->buckets[i];
+            if (flow && flow_matches_1wild(&flow->key, key)) {
+                int error = callback(flow, private);
+                if (error) {
+                    position->private[0] = i + 1;
+                    return error;
+                }
+            }
+        }
+        return 0;
+    }
 }
 
 static void table_hash_stats(struct sw_table *swt,
@@ -218,6 +201,7 @@ static void table_hash_stats(struct sw_table *swt,
     stats->name = "hash";
     stats->n_flows = th->n_flows;
     stats->max_flows = th->bucket_mask + 1;
+    stats->n_matched = swt->n_matched;
 }
 
 struct sw_table *table_hash_create(unsigned int polynomial,
@@ -229,6 +213,7 @@ struct sw_table *table_hash_create(unsigned int polynomial,
     th = malloc(sizeof *th);
     if (th == NULL)
         return NULL;
+    memset(th, '\0', sizeof *th);
 
     assert(!(n_buckets & (n_buckets - 1)));
     th->buckets = calloc(n_buckets, sizeof *th->buckets);
@@ -246,9 +231,7 @@ struct sw_table *table_hash_create(unsigned int polynomial,
     swt->delete = table_hash_delete;
     swt->timeout = table_hash_timeout;
     swt->destroy = table_hash_destroy;
-    swt->iterator = table_hash_iterator;
-    swt->iterator_next = table_hash_next;
-    swt->iterator_destroy = table_hash_iterator_destroy;
+    swt->iterate = table_hash_iterate;
     swt->stats = table_hash_stats;
 
     crc32_init(&th->crc32, polynomial);
@@ -271,7 +254,7 @@ static struct sw_flow *table_hash2_lookup(struct sw_table *swt,
         
     for (i = 0; i < 2; i++) {
         struct sw_flow *flow = *find_bucket(t2->subtable[i], key);
-        if (flow && !memcmp(&flow->key, key, sizeof *key))
+        if (flow && !flow_compare(&flow->key.flow, &key->flow))
             return flow;
     }
     return NULL;
@@ -310,79 +293,25 @@ static void table_hash2_destroy(struct sw_table *swt)
     free(t2);
 }
 
-struct swt_iterator_hash2 {
-    struct sw_table_hash2 *th2;
-    struct swt_iterator ih;
-    uint8_t table_i;
-};
-
-static int table_hash2_iterator(struct sw_table *swt,
-                                struct swt_iterator *swt_iter)
-{
-    struct swt_iterator_hash2 *ih2;
-
-    swt_iter->private = ih2 = malloc(sizeof *ih2);
-    if (ih2 == NULL)
-        return 0;
-
-    ih2->th2 = (struct sw_table_hash2 *) swt;
-    if (!table_hash_iterator(ih2->th2->subtable[0], &ih2->ih)) {
-        free(ih2);
-        return 0;
-    }
-
-    if (ih2->ih.flow != NULL) {
-        swt_iter->flow = ih2->ih.flow;
-        ih2->table_i = 0;
-    } else {
-        table_hash_iterator_destroy(&ih2->ih);
-        ih2->table_i = 1;
-        if (!table_hash_iterator(ih2->th2->subtable[1], &ih2->ih)) {
-            free(ih2);
-            return 0;
-        }
-        swt_iter->flow = ih2->ih.flow;
-    }
-
-    return 1;
-}
-
-static void table_hash2_next(struct swt_iterator *swt_iter) 
+static int table_hash2_iterate(struct sw_table *swt,
+                               const struct sw_flow_key *key,
+                               struct sw_table_position *position,
+                               int (*callback)(struct sw_flow *, void *),
+                               void *private)
 {
-    struct swt_iterator_hash2 *ih2;
-
-    if (swt_iter->flow == NULL)
-        return;
-
-    ih2 = (struct swt_iterator_hash2 *) swt_iter->private;
-    table_hash_next(&ih2->ih);
+    struct sw_table_hash2 *t2 = (struct sw_table_hash2 *) swt;
+    int i;
 
-    if (ih2->ih.flow != NULL) {
-        swt_iter->flow = ih2->ih.flow;
-    } else {
-        if (ih2->table_i == 0) {
-            table_hash_iterator_destroy(&ih2->ih);
-            ih2->table_i = 1;
-            if (!table_hash_iterator(ih2->th2->subtable[1], &ih2->ih)) {
-                ih2->ih.private = NULL;
-                swt_iter->flow = NULL;
-            } else {
-                swt_iter->flow = ih2->ih.flow;
-            }
-        } else {
-            swt_iter->flow = NULL;
+    for (i = position->private[1]; i < 2; i++) {
+        int error = table_hash_iterate(t2->subtable[i], key, position,
+                                       callback, private);
+        if (error) {
+            return error;
         }
+        position->private[0] = 0;
+        position->private[1]++;
     }
-}
-
-static void table_hash2_iterator_destroy(struct swt_iterator *swt_iter)
-{
-    struct swt_iterator_hash2 *ih2;
-
-    ih2 = (struct swt_iterator_hash2 *) swt_iter->private;
-    if (ih2->ih.private != NULL)
-        table_hash_iterator_destroy(&ih2->ih);
-    free(ih2);
+    return 0;
 }
 
 static void table_hash2_stats(struct sw_table *swt,
@@ -397,6 +326,7 @@ static void table_hash2_stats(struct sw_table *swt,
     stats->name = "hash2";
     stats->n_flows = substats[0].n_flows + substats[1].n_flows;
     stats->max_flows = substats[0].max_flows + substats[1].max_flows;
+    stats->n_matched = swt->n_matched;
 }
 
 struct sw_table *table_hash2_create(unsigned int poly0, unsigned int buckets0,
@@ -409,6 +339,7 @@ struct sw_table *table_hash2_create(unsigned int poly0, unsigned int buckets0,
     t2 = malloc(sizeof *t2);
     if (t2 == NULL)
         return NULL;
+    memset(t2, '\0', sizeof *t2);
 
     t2->subtable[0] = table_hash_create(poly0, buckets0);
     if (t2->subtable[0] == NULL)
@@ -424,12 +355,9 @@ struct sw_table *table_hash2_create(unsigned int poly0, unsigned int buckets0,
     swt->delete = table_hash2_delete;
     swt->timeout = table_hash2_timeout;
     swt->destroy = table_hash2_destroy;
+    swt->iterate = table_hash2_iterate;
     swt->stats = table_hash2_stats;
 
-    swt->iterator = table_hash2_iterator;
-    swt->iterator_next = table_hash2_next;
-    swt->iterator_destroy = table_hash2_iterator_destroy;
-
     return swt;
 
 out_free_subtable0: