modifications realted to special account
[tests.git] / system / TestPlc.py
index baa2091..377c4a4 100644 (file)
@@ -3,10 +3,9 @@ import os, os.path
 import datetime
 import time
 import sys
-import xmlrpclib
-import datetime
 import traceback
 from types import StringTypes
+import socket
 
 import utils
 from TestSite import TestSite
@@ -16,96 +15,159 @@ from TestKey import TestKey
 from TestSlice import TestSlice
 from TestSliver import TestSliver
 from TestBox import TestBox
+from TestSsh import TestSsh
+from TestApiserver import TestApiserver
+from TestSliceSfa import TestSliceSfa
+from TestUserSfa import TestUserSfa
 
-# step methods must take (self, options) and return a boolean
+# step methods must take (self) and return a boolean (options is a member of the class)
 
-def standby(minutes):
-        utils.header('Entering StandBy for %d mn'%minutes)
+def standby(minutes,dry_run):
+    utils.header('Entering StandBy for %d mn'%minutes)
+    if dry_run:
+        print 'dry_run'
+    else:
         time.sleep(60*minutes)
-        return True
+    return True
 
 def standby_generic (func):
-    def actual(self,options):
+    def actual(self):
         minutes=int(func.__name__.split("_")[1])
-        return standby(minutes)
+        return standby(minutes,self.options.dry_run)
+    return actual
+
+def node_mapper (method):
+    def actual(self):
+        overall=True
+        node_method = TestNode.__dict__[method.__name__]
+        for site_spec in self.plc_spec['sites']:
+            test_site = TestSite (self,site_spec)
+            for node_spec in site_spec['nodes']:
+                test_node = TestNode (self,test_site,node_spec)
+                if not node_method(test_node): overall=False
+        return overall
+    # restore the doc text
+    actual.__doc__=method.__doc__
     return actual
 
+def slice_mapper_options (method):
+    def actual(self):
+        overall=True
+        slice_method = TestSlice.__dict__[method.__name__]
+        for slice_spec in self.plc_spec['slices']:
+            site_spec = self.locate_site (slice_spec['sitename'])
+            test_site = TestSite(self,site_spec)
+            test_slice=TestSlice(self,test_site,slice_spec)
+            if not slice_method(test_slice,self.options): overall=False
+        return overall
+    # restore the doc text
+    actual.__doc__=method.__doc__
+    return actual
+
+def slice_mapper_options_sfa (method):
+    def actual(self):
+       test_plc=self
+        overall=True
+        slice_method = TestSliceSfa.__dict__[method.__name__]
+        for slice_spec in self.plc_spec['sfa']['slices_sfa']:
+            site_spec = self.locate_site (slice_spec['sitename'])
+            test_site = TestSite(self,site_spec)
+            test_slice=TestSliceSfa(test_plc,test_site,slice_spec)
+            if not slice_method(test_slice,self.options): overall=False
+        return overall
+    # restore the doc text
+    actual.__doc__=method.__doc__
+    return actual
+
+SEP='<sep>'
+
 class TestPlc:
 
-    def __init__ (self,plc_spec):
+    default_steps = [
+        'display', 'local_pre', SEP,
+        'delete','create','install', 'configure', 'start', SEP,
+        'fetch_keys', 'store_keys', 'clear_known_hosts', SEP,
+        'initscripts', 'sites', 'nodes', 'slices', 'nodegroups', SEP,
+        'reinstall_node', 'init_node','bootcd', 'configure_qemu', 'export_qemu',
+        'kill_all_qemus', 'start_node', SEP,
+        # better use of time: do this now that the nodes are taking off
+        'plcsh_stress_test', SEP,
+        'nodes_ssh_debug', 'nodes_ssh_boot', 'check_slice', 'check_initscripts', SEP,
+       'install_sfa', 'configure_sfa', 'import_sfa', 'start_sfa', SEP,
+        'setup_sfa', 'add_sfa', 'update_sfa', SEP,
+        'view_sfa', 'check_slice_sfa', 'delete_sfa', 'stop_sfa', SEP,
+        'check_tcp',  'check_hooks',  SEP,
+        'force_gather_logs', 'force_local_post',
+        ]
+    other_steps = [ 
+        'fresh_install', 'stop', 'vs_start', SEP,
+        'clean_initscripts', 'clean_nodegroups','clean_all_sites', SEP,
+        'clean_sites', 'clean_nodes', 'clean_slices', 'clean_keys', SEP,
+        'populate' , SEP,
+        'show_boxes', 'list_all_qemus', 'list_qemus', 'kill_qemus', SEP,
+        'db_dump' , 'db_restore', SEP,
+        'local_list','local_cleanup',SEP,
+        'standby_1 through 20',
+        ]
+
+    @staticmethod
+    def printable_steps (list):
+        return " ".join(list).replace(" "+SEP+" "," \\\n")
+    @staticmethod
+    def valid_step (step):
+        return step != SEP
+
+    def __init__ (self,plc_spec,options):
        self.plc_spec=plc_spec
-       self.path=os.path.dirname(sys.argv[0])
+        self.options=options
+       self.test_ssh=TestSsh(self.plc_spec['hostname'],self.options.buildname)
         try:
             self.vserverip=plc_spec['vserverip']
             self.vservername=plc_spec['vservername']
             self.url="https://%s:443/PLCAPI/"%plc_spec['vserverip']
             self.vserver=True
         except:
-            self.vserver=False
-            self.url="https://%s:443/PLCAPI/"%plc_spec['hostname']
-        utils.header('Using API url %s'%self.url)
-       self.server=xmlrpclib.Server(self.url,allow_none=True)
+            raise Exception,'chroot-based myplc testing is deprecated'
+       self.apiserver=TestApiserver(self.url,options.dry_run)
         
     def name(self):
         name=self.plc_spec['name']
-        if self.vserver:
-            return name+"[%s]"%self.vservername
-        else:
-            return name+"[chroot]"
+        return "%s.%s"%(name,self.vservername)
 
     def hostname(self):
         return self.plc_spec['hostname']
 
     def is_local (self):
-        return utils.is_local(self.hostname())
+        return self.test_ssh.is_local()
 
     # define the API methods on this object through xmlrpc
     # would help, but not strictly necessary
     def connect (self):
        pass
-    
-    # command gets run in the chroot/vserver
-    def host_to_guest(self,command):
-        if self.vserver:
-            return "vserver %s exec %s"%(self.vservername,command)
-        else:
-            return "chroot /plc/root %s"%utils.backslash_shell_specials(command)
-
-    # command gets run on the right box
-    def to_host(self,command):
-        if self.is_local():
-            return command
-        else:
-            return "ssh %s %s"%(self.hostname(),utils.backslash_shell_specials(command))
-
-    def full_command(self,command):
-        return self.to_host(self.host_to_guest(command))
 
+    def actual_command_in_guest (self,command):
+        return self.test_ssh.actual_command(self.host_to_guest(command))
+    
+    def start_guest (self):
+      return utils.system(self.test_ssh.actual_command(self.start_guest_in_host()))
+    
     def run_in_guest (self,command):
-        return utils.system(self.full_command(command))
+        return utils.system(self.actual_command_in_guest(command))
+    
     def run_in_host (self,command):
-        return utils.system(self.to_host(command))
+        return self.test_ssh.run_in_buildname(command)
 
+    #command gets run in the vserver
+    def host_to_guest(self,command):
+        return "vserver %s exec %s"%(self.vservername,command)
+    
+    #command gets run in the vserver
+    def start_guest_in_host(self):
+        return "vserver %s start"%(self.vservername)
+    
     # xxx quick n dirty
     def run_in_guest_piped (self,local,remote):
-        return utils.system(local+" | "+self.full_command(remote))
-
-    # copy a file to the myplc root image - pass in_data=True if the file must go in /plc/data
-    def copy_in_guest (self, localfile, remotefile, in_data=False):
-        if in_data:
-            chroot_dest="/plc/data"
-        else:
-            chroot_dest="/plc/root"
-        if self.is_local():
-            if not self.vserver:
-                utils.system("cp %s %s/%s"%(localfile,chroot_dest,remotefile))
-            else:
-                utils.system("cp %s /vservers/%s/%s"%(localfile,self.vservername,remotefile))
-        else:
-            if not self.vserver:
-                utils.system("scp %s %s:%s/%s"%(localfile,self.hostname(),chroot_dest,remotefile))
-            else:
-                utils.system("scp %s %s@/vservers/%s/%s"%(localfile,self.hostname(),self.vservername,remotefile))
+        return utils.system(local+" | "+self.test_ssh.actual_command(self.host_to_guest(remote),keep_stdin=True))
 
     def auth_root (self):
        return {'Username':self.plc_spec['PLC_ROOT_USER'],
@@ -124,16 +186,60 @@ class TestPlc:
     def locate_node (self,nodename):
         for site in self.plc_spec['sites']:
             for node in site['nodes']:
-                if node['node_fields']['hostname'] == nodename:
+                if node['name'] == nodename:
                     return (site,node)
         raise Exception,"Cannot locate node %s"%nodename
         
+    def locate_hostname (self,hostname):
+        for site in self.plc_spec['sites']:
+            for node in site['nodes']:
+                if node['node_fields']['hostname'] == hostname:
+                    return (site,node)
+        raise Exception,"Cannot locate hostname %s"%hostname
+        
     def locate_key (self,keyname):
         for key in self.plc_spec['keys']:
             if key['name'] == keyname:
                 return key
         raise Exception,"Cannot locate key %s"%keyname
 
+    def locate_slice (self, slicename):
+        for slice in self.plc_spec['slices']:
+            if slice['slice_fields']['name'] == slicename:
+                return slice
+        raise Exception,"Cannot locate slice %s"%slicename
+
+    def all_sliver_objs (self):
+        result=[]
+        for slice_spec in self.plc_spec['slices']:
+            slicename = slice_spec['slice_fields']['name']
+            for nodename in slice_spec['nodenames']:
+                result.append(self.locate_sliver_obj (nodename,slicename))
+        return result
+
+    def locate_sliver_obj (self,nodename,slicename):
+        (site,node) = self.locate_node(nodename)
+        slice = self.locate_slice (slicename)
+        # build objects
+        test_site = TestSite (self, site)
+        test_node = TestNode (self, test_site,node)
+        # xxx the slice site is assumed to be the node site - mhh - probably harmless
+        test_slice = TestSlice (self, test_site, slice)
+        return TestSliver (self, test_node, test_slice)
+
+    def locate_first_node(self):
+        nodename=self.plc_spec['slices'][0]['nodenames'][0]
+        (site,node) = self.locate_node(nodename)
+        test_site = TestSite (self, site)
+        test_node = TestNode (self, test_site,node)
+        return test_node
+
+    def locate_first_sliver (self):
+        slice_spec=self.plc_spec['slices'][0]
+        slicename=slice_spec['slice_fields']['name']
+        nodename=slice_spec['nodenames'][0]
+        return self.locate_sliver_obj(nodename,slicename)
+
     # all different hostboxes used in this plc
     def gather_hostBoxes(self):
         # maps on sites and nodes, return [ (host_box,test_node) ]
@@ -144,7 +250,7 @@ class TestPlc:
                 test_node = TestNode (self, test_site, node_spec)
                 if not test_node.is_real():
                     tuples.append( (test_node.host_box(),test_node) )
-        # transform into a dict { 'host_box' -> [ hostnames .. ] }
+        # transform into a dict { 'host_box' -> [ test_node .. ] }
         result = {}
         for (box,node) in tuples:
             if not result.has_key(box):
@@ -154,142 +260,230 @@ class TestPlc:
         return result
                     
     # a step for checking this stuff
-    def showboxes (self,options):
-        print 'showboxes'
+    def show_boxes (self):
         for (box,nodes) in self.gather_hostBoxes().iteritems():
             print box,":"," + ".join( [ node.name() for node in nodes ] )
         return True
 
     # make this a valid step
-    def kill_all_qemus(self,options):
+    def kill_all_qemus(self):
+        "all qemu boxes: kill all running qemus (even of former runs)"
+        # this is the brute force version, kill all qemus on that host box
         for (box,nodes) in self.gather_hostBoxes().iteritems():
-            # this is the brute force version, kill all qemus on that host box
-            TestBox(box,options.buildname).kill_all_qemus()
+            # pass the first nodename, as we don't push template-qemu on testboxes
+            nodedir=nodes[0].nodedir()
+            TestBox(box,self.options.buildname).kill_all_qemus(nodedir)
         return True
 
     # make this a valid step
-    def list_all_qemus(self,options):
+    def list_all_qemus(self):
         for (box,nodes) in self.gather_hostBoxes().iteritems():
-           # push the script
-           TestBox(box,options.buildname).copy("qemu_kill.sh") 
             # this is the brute force version, kill all qemus on that host box
-            TestBox(box,options.buildname).run_in_buildname("qemu_kill.sh -l")
+            TestBox(box,self.options.buildname).list_all_qemus()
         return True
 
     # kill only the right qemus
-    def kill_qemus(self,options):
+    def list_qemus(self):
         for (box,nodes) in self.gather_hostBoxes().iteritems():
-           # push the script
-           TestBox(box,options.buildname).copy("qemu_kill.sh") 
             # the fine-grain version
             for node in nodes:
-                node.kill_qemu()
+                node.list_qemu()
         return True
 
-    def clear_ssh_config (self,options):
-        # install local ssh_config file as root's .ssh/config - ssh should be quiet
-        # dir might need creation first
-        self.run_in_guest("mkdir /root/.ssh")
-        self.run_in_guest("chmod 700 /root/.ssh")
-        # this does not work - > redirection somehow makes it until an argument to cat
-        #self.run_in_guest_piped("cat ssh_config","cat > /root/.ssh/config")
-        self.copy_in_guest("ssh_config","/root/.ssh/config",True)
-        return True
-            
-    #################### step methods
-
-    ### uninstall
-    def uninstall_chroot(self,options):
-        self.run_in_host('service plc safestop')
-        #####detecting the last myplc version installed and remove it
-        self.run_in_host('rpm -e myplc')
-        ##### Clean up the /plc directory
-        self.run_in_host('rm -rf  /plc/data')
-        ##### stop any running vservers
-        self.run_in_host('for vserver in $(ls /vservers/* | sed -e s,/vservers/,,) ; do vserver $vserver stop ; done')
+    # kill only the right qemus
+    def kill_qemus(self):
+        for (box,nodes) in self.gather_hostBoxes().iteritems():
+            # the fine-grain version
+            for node in nodes:
+                node.kill_qemu()
         return True
 
-    def uninstall_vserver(self,options):
-        self.run_in_host("vserver --silent %s delete"%self.vservername)
+    #################### display config
+    def display (self):
+        "show test configuration after localization"
+        self.display_pass (1)
+        self.display_pass (2)
         return True
 
-    def uninstall(self,options):
-        # if there's a chroot-based myplc running, and then a native-based myplc is being deployed
-        # it sounds safer to have the former uninstalled too
-        # now the vserver method cannot be invoked for chroot instances as vservername is required
-        if self.vserver:
-            self.uninstall_vserver(options)
-            self.uninstall_chroot(options)
-        else:
-            self.uninstall_chroot(options)
+    # entry point
+    def display_pass (self,passno):
+        for (key,val) in self.plc_spec.iteritems():
+            if passno == 2:
+                if key == 'sites':
+                    for site in val:
+                        self.display_site_spec(site)
+                        for node in site['nodes']:
+                            self.display_node_spec(node)
+                elif key=='initscripts':
+                    for initscript in val:
+                        self.display_initscript_spec (initscript)
+                elif key=='slices':
+                    for slice in val:
+                        self.display_slice_spec (slice)
+                elif key=='keys':
+                    for key in val:
+                        self.display_key_spec (key)
+            elif passno == 1:
+                if key not in ['sites','initscripts','slices','keys']:
+                    print '+   ',key,':',val
+
+    def display_site_spec (self,site):
+        print '+ ======== site',site['site_fields']['name']
+        for (k,v) in site.iteritems():
+            if k=='nodes':
+                if v: 
+                    print '+       ','nodes : ',
+                    for node in v:  
+                        print node['node_fields']['hostname'],'',
+                    print ''
+            elif k=='users':
+                if v: 
+                    print '+       users : ',
+                    for user in v:  
+                        print user['name'],'',
+                    print ''
+            elif k == 'site_fields':
+                print '+       login_base',':',v['login_base']
+            elif k == 'address_fields':
+                pass
+            else:
+                print '+       ',k,
+                PrettyPrinter(indent=8,depth=2).pprint(v)
+        
+    def display_initscript_spec (self,initscript):
+        print '+ ======== initscript',initscript['initscript_fields']['name']
+
+    def display_key_spec (self,key):
+        print '+ ======== key',key['name']
+
+    def display_slice_spec (self,slice):
+        print '+ ======== slice',slice['slice_fields']['name']
+        for (k,v) in slice.iteritems():
+            if k=='nodenames':
+                if v: 
+                    print '+       nodes : ',
+                    for nodename in v:  
+                        print nodename,'',
+                    print ''
+            elif k=='usernames':
+                if v: 
+                    print '+       users : ',
+                    for username in v:  
+                        print username,'',
+                    print ''
+            elif k=='slice_fields':
+                print '+       fields',':',
+                print 'max_nodes=',v['max_nodes'],
+                print ''
+            else:
+                print '+       ',k,v
+
+    def display_node_spec (self,node):
+        print "+           node",node['name'],"host_box=",node['host_box'],
+        print "hostname=",node['node_fields']['hostname'],
+        print "ip=",node['interface_fields']['ip']
+    
+
+    # another entry point for just showing the boxes involved
+    def display_mapping (self):
+        TestPlc.display_mapping_plc(self.plc_spec)
         return True
 
-    ### install
-    def install_chroot(self,options):
-        # nothing to do
+    @staticmethod
+    def display_mapping_plc (plc_spec):
+        print '+ MyPLC',plc_spec['name']
+        print '+\tvserver address = root@%s:/vservers/%s'%(plc_spec['hostname'],plc_spec['vservername'])
+        print '+\tIP = %s/%s'%(plc_spec['PLC_API_HOST'],plc_spec['vserverip'])
+        for site_spec in plc_spec['sites']:
+            for node_spec in site_spec['nodes']:
+                TestPlc.display_mapping_node(node_spec)
+
+    @staticmethod
+    def display_mapping_node (node_spec):
+        print '+   NODE %s'%(node_spec['name'])
+        print '+\tqemu box %s'%node_spec['host_box']
+        print '+\thostname=%s'%node_spec['node_fields']['hostname']
+
+    def local_pre (self):
+        "run site-dependant pre-test script as defined in LocalTestResources"
+        from LocalTestResources import local_resources
+        return local_resources.step_pre(self)
+    def local_post (self):
+        "run site-dependant post-test script as defined in LocalTestResources"
+        from LocalTestResources import local_resources
+        return local_resources.step_post(self)
+    def local_list (self):
+        "run site-dependant list script as defined in LocalTestResources"
+        from LocalTestResources import local_resources
+        return local_resources.step_list(self)
+    def local_cleanup (self):
+        "run site-dependant cleanup script as defined in LocalTestResources"
+        from LocalTestResources import local_resources
+        return local_resources.step_cleanup(self)
+    def delete(self):
+        "vserver delete the test myplc"
+        self.run_in_host("vserver --silent %s delete"%self.vservername)
         return True
 
-    # xxx this would not work with hostname != localhost as mylc-init-vserver was extracted locally
-    def install_vserver(self,options):
-        # we need build dir for vtest-init-vserver
+    ### install
+    def create (self):
+        "vserver creation (no install done)"
         if self.is_local():
             # a full path for the local calls
-            build_dir=self.path+"/build"
+            build_dir=os.path.dirname(sys.argv[0])
+            # sometimes this is empty - set to "." in such a case
+            if not build_dir: build_dir="."
+            build_dir += "/build"
         else:
-            # use a standard name - will be relative to HOME 
-            build_dir="tests-system-build"
-        build_checkout = "svn checkout %s %s"%(options.build_url,build_dir)
+            # use a standard name - will be relative to remote buildname
+            build_dir="build"
+       # run checkout in any case - would do an update if already exists
+        build_checkout = "svn checkout %s %s"%(self.options.build_url,build_dir)
         if self.run_in_host(build_checkout) != 0:
-            raise Exception,"Cannot checkout build dir"
-        # the repo url is taken from myplc-url 
-        # with the last two steps (i386/myplc...) removed
-        repo_url = options.myplc_url
-        repo_url = os.path.dirname(repo_url)
-        repo_url = os.path.dirname(repo_url)
-        create_vserver="%s/vtest-init-vserver.sh %s %s -- --interface eth0:%s"%\
-            (build_dir,self.vservername,repo_url,self.vserverip)
-        if self.run_in_host(create_vserver) != 0:
-            raise Exception,"Could not create vserver for %s"%self.vservername
-        return True
-
-    def install(self,options):
-        if self.vserver:
-            return self.install_vserver(options)
-        else:
-            return self.install_chroot(options)
-    
-    ### install_rpm
-    def cache_rpm(self,url):
-        self.run_in_host('rm -rf *.rpm')
-       utils.header('Curling rpm from %s'%url)
-       id= self.run_in_host('curl -O '+url)
-       if (id != 0):
-               raise Exception,"Could not get rpm from  %s"%url
-               return False
-       return True
-
-    def install_rpm_chroot(self,options):
-        rpm = os.path.basename(options.myplc_url)
-       if (not os.path.isfile(rpm)):
-               self.cache_rpm(options.myplc_url)
-       utils.header('Installing the :  %s'%rpm)
-        self.run_in_host('rpm -Uvh '+rpm)
-        self.run_in_host('service plc mount')
-        return True
-
-    def install_rpm_vserver(self,options):
-        self.run_in_guest("yum -y install myplc-native")
-        return True
+            return False
+        # the repo url is taken from arch-rpms-url 
+        # with the last step (i386) removed
+        repo_url = self.options.arch_rpms_url
+        for level in [ 'arch' ]:
+           repo_url = os.path.dirname(repo_url)
+        # pass the vbuild-nightly options to vtest-init-vserver
+        test_env_options=""
+        test_env_options += " -p %s"%self.options.personality
+        test_env_options += " -d %s"%self.options.pldistro
+        test_env_options += " -f %s"%self.options.fcdistro
+        script="vtest-init-vserver.sh"
+        vserver_name = self.vservername
+        vserver_options="--netdev eth0 --interface %s"%self.vserverip
+        try:
+            vserver_hostname=socket.gethostbyaddr(self.vserverip)[0]
+            vserver_options += " --hostname %s"%vserver_hostname
+        except:
+            pass
+        create_vserver="%(build_dir)s/%(script)s %(test_env_options)s %(vserver_name)s %(repo_url)s -- %(vserver_options)s"%locals()
+        return self.run_in_host(create_vserver) == 0
 
-    def install_rpm(self,options):
-        if self.vserver:
-            return self.install_rpm_vserver(options)
+    ### install_rpm 
+    def install(self):
+        "yum install myplc, noderepo, and the plain bootstrapfs"
+        if self.options.personality == "linux32":
+            arch = "i386"
+        elif self.options.personality == "linux64":
+            arch = "x86_64"
         else:
-            return self.install_rpm_chroot(options)
+            raise Exception, "Unsupported personality %r"%self.options.personality
+        return \
+            self.run_in_guest("yum -y install myplc")==0 and \
+            self.run_in_guest("yum -y install noderepo-%s-%s"%(self.options.pldistro,arch))==0 and \
+            self.run_in_guest("yum -y install bootstrapfs-%s-%s-plain"%(self.options.pldistro,arch))==0 
 
     ### 
-    def configure(self,options):
-        tmpname='/root/%s/%s.plc-config-tty'%(options.path,self.name())
+    def configure(self):
+        "run plc-config-tty"
+        tmpname='%s.plc-config-tty'%(self.name())
         fileconf=open(tmpname,'w')
         for var in [ 'PLC_NAME',
                      'PLC_ROOT_PASSWORD',
@@ -297,6 +491,8 @@ class TestPlc:
                      'PLC_MAIL_ENABLED',
                      'PLC_MAIL_SUPPORT_ADDRESS',
                      'PLC_DB_HOST',
+                     'PLC_DB_PASSWORD',
+                    # Above line was added for integrating SFA Testing
                      'PLC_API_HOST',
                      'PLC_WWW_HOST',
                      'PLC_BOOT_HOST',
@@ -311,37 +507,55 @@ class TestPlc:
         utils.system('rm %s'%tmpname)
         return True
 
-    # the chroot install is slightly different to this respect
-    def start(self, options):
-        if self.vserver:
-            self.run_in_guest('service plc start')
-        else:
-            self.run_in_host('service plc start')
+    def start(self):
+        "service plc start"
+        self.run_in_guest('service plc start')
         return True
-        
-    def stop(self, options):
-        if self.vserver:
-            self.run_in_guest('service plc stop')
-        else:
-            self.run_in_host('service plc stop')
+
+    def stop(self):
+        "service plc stop"
+        self.run_in_guest('service plc stop')
         return True
         
-    # could use a TestKey class
-    def store_keys(self, options):
+    def vs_start (self):
+        self.start_guest()
+        return True
+
+    # stores the keys from the config for further use
+    def store_keys(self):
+        "stores test users ssh keys in keys/"
         for key_spec in self.plc_spec['keys']:
-            TestKey(self,key_spec).store_key()
+               TestKey(self,key_spec).store_key()
         return True
 
-    def clean_keys(self, options):
-        utils.system("rm -rf %s/keys/"%self.path)
+    def clean_keys(self):
+        utils.system("rm -rf %s/keys/"%os.path(sys.argv[0]))
 
-    def sites (self,options):
-        return self.do_sites(options)
+    # fetches the ssh keys in the plc's /etc/planetlab and stores them in keys/
+    # for later direct access to the nodes
+    def fetch_keys(self):
+        "gets ssh keys in /etc/planetlab/ and stores them locally in keys/"
+        dir="./keys"
+        if not os.path.isdir(dir):
+            os.mkdir(dir)
+        vservername=self.vservername
+        overall=True
+        prefix = 'debug_ssh_key'
+        for ext in [ 'pub', 'rsa' ] :
+            src="/vservers/%(vservername)s/etc/planetlab/%(prefix)s.%(ext)s"%locals()
+            dst="keys/%(vservername)s-debug.%(ext)s"%locals()
+            if self.test_ssh.fetch(src,dst) != 0: overall=False
+        return overall
+
+    def sites (self):
+        "create sites with PLCAPI"
+        return self.do_sites()
     
-    def clean_sites (self,options):
-        return self.do_sites(options,action="delete")
+    def clean_sites (self):
+        "delete sites with PLCAPI"
+        return self.do_sites(action="delete")
     
-    def do_sites (self,options,action="add"):
+    def do_sites (self,action="add"):
         for site_spec in self.plc_spec['sites']:
             test_site = TestSite (self,site_spec)
             if (action != "add"):
@@ -356,12 +570,21 @@ class TestPlc:
                 test_site.create_users()
         return True
 
-    def nodes (self, options):
-        return self.do_nodes(options)
-    def clean_nodes (self, options):
-        return self.do_nodes(options,action="delete")
+    def clean_all_sites (self):
+        print 'auth_root',self.auth_root()
+        site_ids = [s['site_id'] for s in self.apiserver.GetSites(self.auth_root(), {}, ['site_id'])]
+        for site_id in site_ids:
+            print 'Deleting site_id',site_id
+            self.apiserver.DeleteSite(self.auth_root(),site_id)
+
+    def nodes (self):
+        "create nodes with PLCAPI"
+        return self.do_nodes()
+    def clean_nodes (self):
+        "delete nodes with PLCAPI"
+        return self.do_nodes(action="delete")
 
-    def do_nodes (self, options,action="add"):
+    def do_nodes (self,action="add"):
         for site_spec in self.plc_spec['sites']:
             test_site = TestSite (self,site_spec)
             if action != "add":
@@ -378,9 +601,15 @@ class TestPlc:
                     test_node.create_node ()
         return True
 
+    def nodegroups (self):
+        "create nodegroups with PLCAPI"
+        return self.do_nodegroups("add")
+    def clean_nodegroups (self):
+        "delete nodegroups with PLCAPI"
+        return self.do_nodegroups("delete")
+
     # create nodegroups if needed, and populate
-    # no need for a clean_nodegroups if we are careful enough
-    def nodegroups (self, options):
+    def do_nodegroups (self, action="add"):
         # 1st pass to scan contents
         groups_dict = {}
         for site_spec in self.plc_spec['sites']:
@@ -396,14 +625,54 @@ class TestPlc:
                             groups_dict[nodegroupname]=[]
                         groups_dict[nodegroupname].append(test_node.name())
         auth=self.auth_root()
+        overall = True
         for (nodegroupname,group_nodes) in groups_dict.iteritems():
-            try:
-                self.server.GetNodeGroups(auth,{'name':nodegroupname})[0]
-            except:
-                self.server.AddNodeGroup(auth,{'name':nodegroupname})
-            for node in group_nodes:
-                self.server.AddNodeToNodeGroup(auth,node,nodegroupname)
-        return True
+            if action == "add":
+                print 'nodegroups:','dealing with nodegroup',nodegroupname,'on nodes',group_nodes
+                # first, check if the nodetagtype is here
+                tag_types = self.apiserver.GetTagTypes(auth,{'tagname':nodegroupname})
+                if tag_types:
+                    tag_type_id = tag_types[0]['tag_type_id']
+                else:
+                    tag_type_id = self.apiserver.AddTagType(auth,
+                                                            {'tagname':nodegroupname,
+                                                             'description': 'for nodegroup %s'%nodegroupname,
+                                                             'category':'test',
+                                                             'min_role_id':10})
+                print 'located tag (type)',nodegroupname,'as',tag_type_id
+                # create nodegroup
+                nodegroups = self.apiserver.GetNodeGroups (auth, {'groupname':nodegroupname})
+                if not nodegroups:
+                    self.apiserver.AddNodeGroup(auth, nodegroupname, tag_type_id, 'yes')
+                    print 'created nodegroup',nodegroupname,'from tagname',nodegroupname,'and value','yes'
+                # set node tag on all nodes, value='yes'
+                for nodename in group_nodes:
+                    try:
+                        self.apiserver.AddNodeTag(auth, nodename, nodegroupname, "yes")
+                    except:
+                        traceback.print_exc()
+                        print 'node',nodename,'seems to already have tag',nodegroupname
+                    # check anyway
+                    try:
+                        expect_yes = self.apiserver.GetNodeTags(auth,
+                                                                {'hostname':nodename,
+                                                                 'tagname':nodegroupname},
+                                                                ['value'])[0]['value']
+                        if expect_yes != "yes":
+                            print 'Mismatch node tag on node',nodename,'got',expect_yes
+                            overall=False
+                    except:
+                        if not self.options.dry_run:
+                            print 'Cannot find tag',nodegroupname,'on node',nodename
+                            overall = False
+            else:
+                try:
+                    print 'cleaning nodegroup',nodegroupname
+                    self.apiserver.DeleteNodeGroup(auth,nodegroupname)
+                except:
+                    traceback.print_exc()
+                    overall=False
+        return overall
 
     def all_hostnames (self) :
         hostnames = []
@@ -412,11 +681,14 @@ class TestPlc:
                            for node_spec in site_spec['nodes'] ]
         return hostnames
 
-    # gracetime : during the first <gracetime> minutes nothing gets printed
-    def do_nodes_booted (self, minutes, gracetime=2):
+    # silent_minutes : during the first <silent_minutes> minutes nothing gets printed
+    def nodes_check_boot_state (self, target_boot_state, timeout_minutes, silent_minutes,period=15):
+        if self.options.dry_run:
+            print 'dry_run'
+            return True
         # compute timeout
-        timeout = datetime.datetime.now()+datetime.timedelta(minutes=minutes)
-        graceout = datetime.datetime.now()+datetime.timedelta(minutes=gracetime)
+        timeout = datetime.datetime.now()+datetime.timedelta(minutes=timeout_minutes)
+        graceout = datetime.datetime.now()+datetime.timedelta(minutes=silent_minutes)
         # the nodes that haven't checked yet - start with a full list and shrink over time
         tocheck = self.all_hostnames()
         utils.header("checking nodes %r"%tocheck)
@@ -424,26 +696,26 @@ class TestPlc:
         status = dict ( [ (hostname,'undef') for hostname in tocheck ] )
         while tocheck:
             # get their status
-            tocheck_status=self.server.GetNodes(self.auth_root(), tocheck, ['hostname','boot_state' ] )
+            tocheck_status=self.apiserver.GetNodes(self.auth_root(), tocheck, ['hostname','boot_state' ] )
             # update status
             for array in tocheck_status:
                 hostname=array['hostname']
                 boot_state=array['boot_state']
-                if boot_state == 'boot':
-                    utils.header ("%s has reached the 'boot' state"%hostname)
+                if boot_state == target_boot_state:
+                    utils.header ("%s has reached the %s state"%(hostname,target_boot_state))
                 else:
                     # if it's a real node, never mind
-                    (site_spec,node_spec)=self.locate_node(hostname)
+                    (site_spec,node_spec)=self.locate_hostname(hostname)
                     if TestNode.is_real_model(node_spec['node_fields']['model']):
                         utils.header("WARNING - Real node %s in %s - ignored"%(hostname,boot_state))
                         # let's cheat
-                        boot_state = 'boot'
-                    if datetime.datetime.now() > graceout:
+                        boot_state = target_boot_state
+                    elif datetime.datetime.now() > graceout:
                         utils.header ("%s still in '%s' state"%(hostname,boot_state))
                         graceout=datetime.datetime.now()+datetime.timedelta(1)
                 status[hostname] = boot_state
             # refresh tocheck
-            tocheck = [ hostname for (hostname,boot_state) in status.iteritems() if boot_state != 'boot' ]
+            tocheck = [ hostname for (hostname,boot_state) in status.iteritems() if boot_state != target_boot_state ]
             if not tocheck:
                 return True
             if datetime.datetime.now() > timeout:
@@ -451,45 +723,52 @@ class TestPlc:
                     utils.header("FAILURE due to %s in '%s' state"%(hostname,status[hostname]))
                 return False
             # otherwise, sleep for a while
-            time.sleep(15)
+            time.sleep(period)
         # only useful in empty plcs
         return True
 
-    def nodes_booted(self,options):
-        return self.do_nodes_booted(minutes=5)
-    
-    #to scan and store the nodes's public keys and avoid to ask for confirmation when  ssh 
-    def scan_publicKeys(self,hostnames):
-        try:
-            temp_knownhosts="/root/known_hosts"
-            remote_knownhosts="/root/.ssh/known_hosts"
-            self.run_in_host("touch %s"%temp_knownhosts )
-            for hostname in hostnames:
-                utils.header("Scan Public %s key and store it in the known_host file(under the root image) "%hostname)
-                scan=self.run_in_host('ssh-keyscan -t rsa %s >> %s '%(hostname,temp_knownhosts))
-            #Store the public keys in the right root image
-            self.copy_in_guest(temp_knownhosts,remote_knownhosts,True)
-            #clean the temp keys file used
-            self.run_in_host('rm -f  %s '%temp_knownhosts )
-        except Exception, err:
-            print err
-            
-    def do_check_nodesSsh(self,minutes):
+    def nodes_booted(self):
+        return self.nodes_check_boot_state('boot',timeout_minutes=20,silent_minutes=15)
+
+    def check_nodes_ssh(self,debug,timeout_minutes,silent_minutes,period=20):
         # compute timeout
-        timeout = datetime.datetime.now()+datetime.timedelta(minutes=minutes)
+        timeout = datetime.datetime.now()+datetime.timedelta(minutes=timeout_minutes)
+        graceout = datetime.datetime.now()+datetime.timedelta(minutes=silent_minutes)
+        vservername=self.vservername
+        if debug: 
+            message="debug"
+            local_key = "keys/%(vservername)s-debug.rsa"%locals()
+        else: 
+            message="boot"
+           local_key = "keys/key1.rsa"
         tocheck = self.all_hostnames()
-        self.scan_publicKeys(tocheck)
-        utils.header("checking Connectivity on nodes %r"%tocheck)
+        utils.header("checking ssh access (expected in %s mode) to nodes %r"%(message,tocheck))
+        utils.header("max timeout is %d minutes, silent for %d minutes (period is %s)"%\
+                         (timeout_minutes,silent_minutes,period))
         while tocheck:
             for hostname in tocheck:
-                # try to ssh in nodes
-                access=self.run_in_guest('ssh -i /etc/planetlab/root_ssh_key.rsa root@%s date'%hostname )
-                if (not access):
-                    utils.header('The node %s is sshable -->'%hostname)
+                # try to run 'hostname' in the node
+                command = TestSsh (hostname,key=local_key).actual_command("hostname;uname -a")
+                # don't spam logs - show the command only after the grace period 
+                if datetime.datetime.now() > graceout:
+                    success=utils.system(command)
+                else:
+                    # truly silent, just print out a dot to show we're alive
+                    print '.',
+                    sys.stdout.flush()
+                    command += " 2>/dev/null"
+                    if self.options.dry_run:
+                        print 'dry_run',command
+                        success=0
+                    else:
+                        success=os.system(command)
+                if success==0:
+                    utils.header('Successfully entered root@%s (%s)'%(hostname,message))
                     # refresh tocheck
                     tocheck.remove(hostname)
                 else:
-                    (site_spec,node_spec)=self.locate_node(hostname)
+                    # we will have tried real nodes once, in case they're up - but if not, just skip
+                    (site_spec,node_spec)=self.locate_hostname(hostname)
                     if TestNode.is_real_model(node_spec['node_fields']['model']):
                         utils.header ("WARNING : check ssh access into real node %s - skipped"%hostname)
                        tocheck.remove(hostname)
@@ -500,48 +779,97 @@ class TestPlc:
                     utils.header("FAILURE to ssh into %s"%hostname)
                 return False
             # otherwise, sleep for a while
-            time.sleep(15)
+            time.sleep(period)
         # only useful in empty plcs
         return True
         
-    def nodes_ssh(self, options):
-        return  self.do_check_nodesSsh(minutes=2)
+    def nodes_ssh_debug(self):
+        "Tries to ssh into nodes in debug mode with the debug ssh key"
+        return self.check_nodes_ssh(debug=True,timeout_minutes=30,silent_minutes=10)
     
-    def bootcd (self, options):
-        for site_spec in self.plc_spec['sites']:
-            test_site = TestSite (self,site_spec)
-            for node_spec in site_spec['nodes']:
-                test_node=TestNode (self,test_site,node_spec)
-                test_node.prepare_area()
-                test_node.create_boot_cd()
-               test_node.configure_qemu()
-        return True
+    def nodes_ssh_boot(self):
+        "Tries to ssh into nodes in production mode with the root ssh key"
+        return self.check_nodes_ssh(debug=False,timeout_minutes=30,silent_minutes=10)
+    
+    @node_mapper
+    def init_node (self): 
+        "all nodes : init a clean local directory for holding node-dep stuff like iso image..."
+        pass
+    @node_mapper
+    def bootcd (self): 
+        "all nodes: invoke GetBootMedium and store result locally"
+        pass
+    @node_mapper
+    def configure_qemu (self): 
+        "all nodes: compute qemu config qemu.conf and store it locally"
+        pass
+    @node_mapper
+    def reinstall_node (self): 
+        "all nodes: mark PLCAPI boot_state as reinstall"
+        pass
+    @node_mapper
+    def export_qemu (self): 
+        "all nodes: push local node-dep directory on the qemu box"
+        pass
+        
+    ### check hooks : invoke scripts from hooks/{node,slice}
+    def check_hooks_node (self): 
+        return self.locate_first_node().check_hooks()
+    def check_hooks_sliver (self) : 
+        return self.locate_first_sliver().check_hooks()
+    
+    def check_hooks (self):
+        "runs unit tests in the node and slice contexts - see hooks/{node,slice}"
+        return self.check_hooks_node() and self.check_hooks_sliver()
 
-    def do_check_intiscripts(self):
-       for site_spec in self.plc_spec['sites']:
-               test_site = TestSite (self,site_spec)
-               test_node = TestNode (self,test_site,site_spec['nodes'])
-               for slice_spec in self.plc_spec['slices']:
-                       test_slice=TestSlice (self,test_site,slice_spec)
-                       test_sliver=TestSliver(self,test_node,test_slice)
-                       init_status=test_sliver.get_initscript(slice_spec)
-                       if (not init_status):
-                               return False
-               return init_status
+    ### initscripts
+    def do_check_initscripts(self):
+        overall = True
+        for slice_spec in self.plc_spec['slices']:
+            if not slice_spec.has_key('initscriptname'):
+                continue
+            initscript=slice_spec['initscriptname']
+            for nodename in slice_spec['nodenames']:
+                (site,node) = self.locate_node (nodename)
+                # xxx - passing the wrong site - probably harmless
+                test_site = TestSite (self,site)
+                test_slice = TestSlice (self,test_site,slice_spec)
+                test_node = TestNode (self,test_site,node)
+                test_sliver = TestSliver (self, test_node, test_slice)
+                if not test_sliver.check_initscript(initscript):
+                    overall = False
+        return overall
            
-    def check_initscripts(self, options):
-           return self.do_check_intiscripts()
-                   
-    def initscripts (self, options):
+    def check_initscripts(self):
+        "check that the initscripts have triggered"
+        return self.do_check_initscripts()
+    
+    def initscripts (self):
+        "create initscripts with PLCAPI"
         for initscript in self.plc_spec['initscripts']:
             utils.pprint('Adding Initscript in plc %s'%self.plc_spec['name'],initscript)
-            self.server.AddInitScript(self.auth_root(),initscript['initscript_fields'])
+            self.apiserver.AddInitScript(self.auth_root(),initscript['initscript_fields'])
         return True
 
-    def slices (self, options):
+    def clean_initscripts (self):
+        "delete initscripts with PLCAPI"
+        for initscript in self.plc_spec['initscripts']:
+            initscript_name = initscript['initscript_fields']['name']
+            print('Attempting to delete %s in plc %s'%(initscript_name,self.plc_spec['name']))
+            try:
+                self.apiserver.DeleteInitScript(self.auth_root(),initscript_name)
+                print initscript_name,'deleted'
+            except:
+                print 'deletion went wrong - probably did not exist'
+        return True
+
+    ### manage slices
+    def slices (self):
+        "create slices with PLCAPI"
         return self.do_slices()
 
-    def clean_slices (self, options):
+    def clean_slices (self):
+        "delete slices with PLCAPI"
         return self.do_slices("delete")
 
     def do_slices (self,  action="add"):
@@ -558,40 +886,301 @@ class TestPlc:
                 utils.header('Created Slice %s'%slice['slice_fields']['name'])
         return True
         
-    def check_slices(self, options):
-        for slice_spec in self.plc_spec['slices']:
+    @slice_mapper_options
+    def check_slice(self): 
+        "tries to ssh-enter the slice with the user key, to ensure slice creation"
+        pass
+
+    @node_mapper
+    def clear_known_hosts (self): 
+        "remove test nodes entries from the local known_hosts file"
+        pass
+    
+    @node_mapper
+    def start_node (self) : 
+        "all nodes: start the qemu instance (also runs qemu-bridge-init start)"
+        pass
+
+    def check_tcp (self):
+        "check TCP connectivity between 2 slices (or in loopback if only one is defined)"
+        specs = self.plc_spec['tcp_test']
+        overall=True
+        for spec in specs:
+            port = spec['port']
+            # server side
+            s_test_sliver = self.locate_sliver_obj (spec['server_node'],spec['server_slice'])
+            if not s_test_sliver.run_tcp_server(port,timeout=10):
+                overall=False
+                break
+
+            # idem for the client side
+            c_test_sliver = self.locate_sliver_obj(spec['server_node'],spec['server_slice'])
+            if not c_test_sliver.run_tcp_client(s_test_sliver.test_node.name(),port):
+                overall=False
+        return overall
+
+    def plcsh_stress_test (self):
+        "runs PLCAPI stress test, that checks Add/Update/Delete on all types - preserves contents"
+        # install the stress-test in the plc image
+        location = "/usr/share/plc_api/plcsh_stress_test.py"
+        remote="/vservers/%s/%s"%(self.vservername,location)
+        self.test_ssh.copy_abs("plcsh_stress_test.py",remote)
+        command = location
+        command += " -- --check"
+        if self.options.size == 1:
+            command +=  " --tiny"
+        return ( self.run_in_guest(command) == 0)
+
+    # populate runs the same utility without slightly different options
+    # in particular runs with --preserve (dont cleanup) and without --check
+    # also it gets run twice, once with the --foreign option for creating fake foreign entries
+
+    ### install_sfa_rpm
+    def install_sfa(self):
+        "yum install sfa, sfa-plc and sfa-client"
+        if self.options.personality == "linux32":
+            arch = "i386"
+        elif self.options.personality == "linux64":
+            arch = "x86_64"
+        else:
+            raise Exception, "Unsupported personality %r"%self.options.personality
+        return \
+            self.run_in_guest("yum -y install sfa")==0 and \
+            self.run_in_guest("yum -y install sfa-client")==0 and \
+            self.run_in_guest("yum -y install sfa-plc")==0 and \
+            self.run_in_guest("yum -y install sfa-sfatables")==0
+    ###
+    def configure_sfa(self):
+        "run sfa-config-tty"
+        tmpname='%s.sfa-config-tty'%(self.name())
+        fileconf=open(tmpname,'w')
+        fileconf.write ('u\n')
+        for var in [ 'SFA_REGISTRY_ROOT_AUTH',
+                     'SFA_REGISTRY_LEVEL1_AUTH',
+                     'SFA_PLC_USER',
+                     'SFA_PLC_PASSWORD',
+                     'SFA_PLC_DB_HOST',
+                     'SFA_PLC_DB_USER',
+                     'SFA_PLC_DB_PASSWORD']:
+            fileconf.write ('%s\n'%(self.plc_spec['sfa'][var]))
+        fileconf.write('w\n')
+        fileconf.write('q\n')
+        fileconf.close()
+        utils.system('cat %s'%tmpname)
+        self.run_in_guest_piped('cat %s'%tmpname,'sfa-config-tty')
+        utils.system('rm %s'%tmpname)
+        return True
+
+    def import_sfa(self):
+        "sfa-import-plc"
+       auth=self.plc_spec['sfa']['SFA_REGISTRY_ROOT_AUTH']
+        self.run_in_guest('sfa-import-plc.py')
+        self.run_in_guest('cp /etc/sfa/authorities/%s/%s.pkey /etc/sfa/authorities/server.key'%(auth,auth))
+        return True
+
+    def start_sfa(self):
+        "service sfa start"
+        self.run_in_guest('service sfa start')
+        return True
+
+    def setup_sfa(self):
+        "sfi client configuration"
+       dir_name=".sfi"
+       if os.path.exists(dir_name):
+           utils.system('rm -rf %s'%dir_name)
+       utils.system('mkdir %s'%dir_name)
+       file_name=dir_name + os.sep + 'fake-pi1.pkey'
+        fileconf=open(file_name,'w')
+        fileconf.write (self.plc_spec['keys'][0]['private'])
+        fileconf.close()
+
+       file_name=dir_name + os.sep + 'sfi_config'
+        fileconf=open(file_name,'w')
+       SFI_AUTH=self.plc_spec['sfa']['SFA_REGISTRY_ROOT_AUTH']+".main"
+        fileconf.write ("SFI_AUTH='%s'"%SFI_AUTH)
+       fileconf.write('\n')
+       SFI_USER=SFI_AUTH+'.fake-pi1'
+        fileconf.write ("SFI_USER='%s'"%SFI_USER)
+       fileconf.write('\n')
+        fileconf.write ("SFI_REGISTRY='http://localhost:12345/'")
+       fileconf.write('\n')
+        fileconf.write ("SFI_SM='http://localhost:12347/'")
+       fileconf.write('\n')
+        fileconf.close()
+
+       file_name=dir_name + os.sep + 'person.xml'
+        fileconf=open(file_name,'w')
+       for record in self.plc_spec['sfa']['sfa_person_xml']:
+          person_record=record
+       fileconf.write(person_record)
+       fileconf.write('\n')
+        fileconf.close()
+
+       file_name=dir_name + os.sep + 'slice.xml'
+        fileconf=open(file_name,'w')
+       for record in self.plc_spec['sfa']['sfa_slice_xml']:
+           slice_record=record
+       #slice_record=self.plc_spec['sfa']['sfa_slice_xml']
+       fileconf.write(slice_record)
+       fileconf.write('\n')
+        fileconf.close()
+
+       file_name=dir_name + os.sep + 'slice.rspec'
+        fileconf=open(file_name,'w')
+       slice_rspec=''
+       for (key, value) in self.plc_spec['sfa']['sfa_slice_rspec'].items():
+           slice_rspec +=value 
+       fileconf.write(slice_rspec)
+       fileconf.write('\n')
+        fileconf.close()
+        location = "root/"
+        remote="/vservers/%s/%s"%(self.vservername,location)
+       self.test_ssh.copy_abs(dir_name, remote, recursive=True)
+
+        #utils.system('cat %s'%tmpname)
+        utils.system('rm -rf %s'%dir_name)
+        return True
+
+    def add_sfa(self):
+        "run sfi.py add (on Registry) and sfi.py create (on SM) to form new objects"
+       test_plc=self
+        test_user_sfa=TestUserSfa(test_plc,self.plc_spec['sfa'])
+        success=test_user_sfa.add_user()
+
+       for slice_spec in self.plc_spec['sfa']['slices_sfa']:
             site_spec = self.locate_site (slice_spec['sitename'])
             test_site = TestSite(self,site_spec)
-            test_slice=TestSlice(self,test_site,slice_spec)
-            status=test_slice.do_check_slice(options)
-            if (not status):
-                return False
-        return status
-    
-    def start_nodes (self, options):
-        utils.header("Starting  nodes")
+           test_slice_sfa=TestSliceSfa(test_plc,test_site,slice_spec)
+           success1=test_slice_sfa.add_slice()
+           success2=test_slice_sfa.create_slice()
+       return success and success1 and success2
+
+    def update_sfa(self):
+        "run sfi.py update (on Registry) and sfi.py create (on SM) on existing objects"
+       test_plc=self
+       test_user_sfa=TestUserSfa(test_plc,self.plc_spec['sfa'])
+       success1=test_user_sfa.update_user()
+       
+       for slice_spec in self.plc_spec['sfa']['slices_sfa']:
+           site_spec = self.locate_site (slice_spec['sitename'])
+           test_site = TestSite(self,site_spec)
+           test_slice_sfa=TestSliceSfa(test_plc,test_site,slice_spec)
+           success2=test_slice_sfa.update_slice()
+       return success1 and success2
+
+    def view_sfa(self):
+        "run sfi.py list and sfi.py show (both on Registry) and sfi.py slices and sfi.py resources (both on SM)"
+       auth=self.plc_spec['sfa']['SFA_REGISTRY_ROOT_AUTH']
+       return \
+       self.run_in_guest("sfi.py -d /root/.sfi/ list %s.main"%auth)==0 and \
+       self.run_in_guest("sfi.py -d /root/.sfi/ show %s.main"%auth)==0 and \
+       self.run_in_guest("sfi.py -d /root/.sfi/ slices")==0 and \
+       self.run_in_guest("sfi.py -d /root/.sfi/ resources")==0
+
+    @slice_mapper_options_sfa
+    def check_slice_sfa(self): 
+       "tries to ssh-enter the SFA slice"
+        pass
+
+    def delete_sfa(self):
+       "run sfi.py delete (on SM), sfi.py remove (on Registry)"
+       test_plc=self
+       test_user_sfa=TestUserSfa(test_plc,self.plc_spec['sfa'])
+       success1=test_user_sfa.delete_user()
+       for slice_spec in self.plc_spec['sfa']['slices_sfa']:
+            site_spec = self.locate_site (slice_spec['sitename'])
+            test_site = TestSite(self,site_spec)
+           test_slice_sfa=TestSliceSfa(test_plc,test_site,slice_spec)
+           success2=test_slice_sfa.delete_slice()
+
+       return success1 and success2
+
+    def stop_sfa(self):
+        "service sfa stop"
+        self.run_in_guest('service sfa stop')
+        return True
+
+    def populate (self):
+        "creates random entries in the PLCAPI"
+        # install the stress-test in the plc image
+        location = "/usr/share/plc_api/plcsh_stress_test.py"
+        remote="/vservers/%s/%s"%(self.vservername,location)
+        self.test_ssh.copy_abs("plcsh_stress_test.py",remote)
+        command = location
+        command += " -- --preserve --short-names"
+        local = (self.run_in_guest(command) == 0);
+        # second run with --foreign
+        command += ' --foreign'
+        remote = (self.run_in_guest(command) == 0);
+        return ( local and remote)
+
+    def gather_logs (self):
+        "gets all possible logs from plc's/qemu node's/slice's for future reference"
+        # (1.a) get the plc's /var/log/ and store it locally in logs/myplc.var-log.<plcname>/*
+        # (1.b) get the plc's  /var/lib/pgsql/data/pg_log/ -> logs/myplc.pgsql-log.<plcname>/*
+        # (2) get all the nodes qemu log and store it as logs/node.qemu.<node>.log
+        # (3) get the nodes /var/log and store is as logs/node.var-log.<node>/*
+        # (4) as far as possible get the slice's /var/log as logs/sliver.var-log.<sliver>/*
+        # (1.a)
+        print "-------------------- TestPlc.gather_logs : PLC's /var/log"
+        self.gather_var_logs ()
+        # (1.b)
+        print "-------------------- TestPlc.gather_logs : PLC's /var/lib/psql/data/pg_log/"
+        self.gather_pgsql_logs ()
+        # (2) 
+        print "-------------------- TestPlc.gather_logs : nodes's QEMU logs"
         for site_spec in self.plc_spec['sites']:
-            TestSite(self,site_spec).start_nodes (options)
+            test_site = TestSite (self,site_spec)
+            for node_spec in site_spec['nodes']:
+                test_node=TestNode(self,test_site,node_spec)
+                test_node.gather_qemu_logs()
+        # (3)
+        print "-------------------- TestPlc.gather_logs : nodes's /var/log"
+        self.gather_nodes_var_logs()
+        # (4)
+        print "-------------------- TestPlc.gather_logs : sample sliver's /var/log"
+        self.gather_slivers_var_logs()
         return True
 
-    def stop_nodes (self, options):
-        self.kill_all_qemus(options)
+    def gather_slivers_var_logs(self):
+        for test_sliver in self.all_sliver_objs():
+            remote = test_sliver.tar_var_logs()
+            utils.system("mkdir -p logs/sliver.var-log.%s"%test_sliver.name())
+            command = remote + " | tar -C logs/sliver.var-log.%s -xf -"%test_sliver.name()
+            utils.system(command)
         return True
 
-    def check_tcp (self, options):
-           #we just need to create a sliver object nothing else
-           test_sliver=TestSliver(self,
-                                  TestNode(self, TestSite(self,self.plc_spec['sites'][0]),
-                                           self.plc_spec['sites'][0]['nodes'][0]),
-                                  TestSlice(self,TestSite(self,self.plc_spec['sites'][0]),
-                                            self.plc_spec['slices']))
-           return test_sliver.do_check_tcp(self.plc_spec['tcp_param'],options)
+    def gather_var_logs (self):
+        utils.system("mkdir -p logs/myplc.var-log.%s"%self.name())
+        to_plc = self.actual_command_in_guest("tar -C /var/log/ -cf - .")        
+        command = to_plc + "| tar -C logs/myplc.var-log.%s -xf -"%self.name()
+        utils.system(command)
+        command = "chmod a+r,a+x logs/myplc.var-log.%s/httpd"%self.name()
+        utils.system(command)
+
+    def gather_pgsql_logs (self):
+        utils.system("mkdir -p logs/myplc.pgsql-log.%s"%self.name())
+        to_plc = self.actual_command_in_guest("tar -C /var/lib/pgsql/data/pg_log/ -cf - .")        
+        command = to_plc + "| tar -C logs/myplc.pgsql-log.%s -xf -"%self.name()
+        utils.system(command)
+
+    def gather_nodes_var_logs (self):
+        for site_spec in self.plc_spec['sites']:
+            test_site = TestSite (self,site_spec)
+            for node_spec in site_spec['nodes']:
+                test_node=TestNode(self,test_site,node_spec)
+                test_ssh = TestSsh (test_node.name(),key="keys/key1.rsa")
+                command = test_ssh.actual_command("tar -C /var/log -cf - .")
+                command = command + "| tar -C logs/node.var-log.%s -xf -"%test_node.name()
+                utils.system("mkdir -p logs/node.var-log.%s"%test_node.name())
+                utils.system(command)
+
 
     # returns the filename to use for sql dump/restore, using options.dbname if set
-    def dbfile (self, database, options):
+    def dbfile (self, database):
         # uses options.dbname if it is found
         try:
-            name=options.dbname
+            name=self.options.dbname
             if not isinstance(name,StringTypes):
                 raise Exception
         except:
@@ -600,15 +1189,14 @@ class TestPlc:
             name=str(d)
         return "/root/%s-%s.sql"%(database,name)
 
-    def db_dump(self, options):
-        
-        dump=self.dbfile("planetab4",options)
+    def db_dump(self):
+        dump=self.dbfile("planetab4")
         self.run_in_guest('pg_dump -U pgsqluser planetlab4 -f '+ dump)
         utils.header('Dumped planetlab4 database in %s'%dump)
         return True
 
-    def db_restore(self, options):
-        dump=self.dbfile("planetab4",options)
+    def db_restore(self):
+        dump=self.dbfile("planetab4")
         ##stop httpd service
         self.run_in_guest('service httpd stop')
         # xxx - need another wrapper
@@ -660,4 +1248,3 @@ class TestPlc:
     def standby_19(): pass
     @standby_generic 
     def standby_20(): pass
-